[Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2
3         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4         https://bugs.webkit.org/show_bug.cgi?id=195346
5
6         Reviewed by Fujii Hironori.
7
8         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
9         (TestWebKitAPI::TEST):
10         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
11
12         * DumpRenderTree/win/DumpRenderTree.cpp:
13         (findFontFallback):
14         (addFontFallbackIfPresent):
15         (removeFontFallbackIfPresent):
16         (main):
17         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
18         (TestWebKitAPI::Util::moduleDirectory):
19         (TestWebKitAPI::Util::createInjectedBundlePath):
20         Use wchar helpers as needed.
21
22 2019-03-06  Rob Buis  <rbuis@igalia.com>
23
24         Consider supporting the `referrerpolicy` attribute.
25         https://bugs.webkit.org/show_bug.cgi?id=179053
26
27         Reviewed by Darin Adler.
28
29         Add a runtime flag for referrerpolicy attribute.
30
31         * DumpRenderTree/mac/DumpRenderTree.mm:
32         (enableExperimentalFeatures):
33
34 2019-03-05  Daniel Bates  <dabates@apple.com>
35
36         Update expected API test result following r242379
37         (https://bugs.webkit.org/show_bug.cgi?id=195125)
38
39         Update expected x-coordinate of selection rect now that the left padding of
40         a textarea is sized in ems (so dependent on the font size) just like the left
41         padding of a text field.
42
43         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
44         (TestWebKitAPI::TEST):
45
46 2019-03-05  David Quesada  <david_quesada@apple.com>
47
48         [WK2] It should be possible to follow links with 'download' attributes
49         https://bugs.webkit.org/show_bug.cgi?id=195145
50         rdar://problem/48462642
51
52         Reviewed by Alex Christensen.
53
54         Add a unit test to verify that activating links with 'download' attributes now
55         navigates to the linked resource, rather than starts downloading it. Add another
56         to verify that it is still possible to explicitly download the link via the
57         'Download' navigation action policy.
58
59         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
60         (-[DownloadAttributeTestDelegate init]):
61         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
62         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
63         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
64         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
65         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
66         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
67         (TEST):
68         * WebKitTestRunner/TestController.cpp:
69         (WTR::TestController::decidePolicyForNavigationAction):
70         * WebKitTestRunner/TestController.h:
71
72 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
73
74         [Curl] Implement Cookie Accept Policy.
75         https://bugs.webkit.org/show_bug.cgi?id=191645
76
77         Reviewed by Fujii Hironori.
78
79         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
80         (TestWebKitAPI::Curl::TEST_F):
81
82 2019-03-05  Youenn Fablet  <youenn@apple.com>
83
84         Rename requestCacheStorageSpace to requestStorageSpace
85         https://bugs.webkit.org/show_bug.cgi?id=195282
86
87         Reviewed by Chris Dumez.
88
89         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
90         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
91         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
92
93 2019-03-05  Brady Eidson  <beidson@apple.com>
94
95         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
96         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
97
98         Reviewed by Tim Horton.
99
100         Loading a file: URL into a WKWebView and then loading another file: url from a completely
101         different directory into that same WKWebView should work.
102
103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
104         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
105
106 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
107
108         Add WeakHashSet
109         https://bugs.webkit.org/show_bug.cgi?id=195152
110
111         Reviewed by Antti Koivisto.
112
113         Added tests for WeakHashSet.
114
115         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
116         (TestWebKitAPI::Base::Base): Moved.
117         (TestWebKitAPI::Derived::foo): Moved.
118         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
119         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
120         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
121         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
122
123 2019-03-04  Chris Dumez  <cdumez@apple.com>
124
125         Do not share WebProcesses between private and regular sessions
126         https://bugs.webkit.org/show_bug.cgi?id=195189
127         <rdar://problem/48421064>
128
129         Reviewed by Alex Christensen.
130
131         Add API test coverage.
132
133         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
134         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
135
136 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
137
138         [WPE] Enable web process sandbox
139         https://bugs.webkit.org/show_bug.cgi?id=195169
140
141         Reviewed by Daniel Bates.
142
143         * wpe/install-dependencies:
144         * wpe/jhbuild.modules:
145
146 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
147
148         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
149         https://bugs.webkit.org/show_bug.cgi?id=195206
150
151         Reviewed by Žan Doberšek.
152
153         Add a new test case.
154
155         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
156         (testJSCClass):
157
158 2019-03-04  Charlie Turner  <cturner@igalia.com>
159
160         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
161         https://bugs.webkit.org/show_bug.cgi?id=194898
162
163         Reviewed by Žan Doberšek.
164
165         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
166         a GCC extension that permits arithmetic on void* pointer. Inline
167         the macro until this issue is fixed upstream.
168
169 2019-03-03  Tim Horton  <timothy_horton@apple.com>
170
171         Rid the world of WK_API_ENABLED
172         https://bugs.webkit.org/show_bug.cgi?id=195263
173
174         Reviewed by Dan Bernstein.
175
176         List of changed files elided because it's useless.
177
178 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
179
180         Unreviewed follow-up to r242292.
181
182         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
183
184         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
185         (TestWebKitAPI::testStrip): Renamed from strip.
186         (TestWebKitAPI::TEST):
187
188 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
189
190         Unreviewed, remove accidentally-committed URLHelpers.cpp test
191
192         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
193         and bug #194272 for details.
194
195         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
196
197 2019-03-03  Tim Horton  <timothy_horton@apple.com>
198
199         Remove some more unused 32-bit code
200         https://bugs.webkit.org/show_bug.cgi?id=195255
201
202         Reviewed by Darin Adler.
203
204         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
205         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
206         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
207         (NPP_New):
208         (NPP_HandleEvent):
209         (handleEventCarbon): Deleted.
210
211 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
212
213         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
214
215         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
216         (TestWebKitAPI::TEST):
217
218 2019-03-01  Darin Adler  <darin@apple.com>
219
220         Finish removing String::format
221         https://bugs.webkit.org/show_bug.cgi?id=194893
222
223         Reviewed by Daniel Bates.
224 '
225         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
226
227 2019-03-01  Alex Christensen  <achristensen@webkit.org>
228
229         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
230         https://bugs.webkit.org/show_bug.cgi?id=195229
231         <rdar://problem/48520362>
232
233         Reviewed by Chris Dumez.
234
235         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
236         (TEST):
237
238 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
239
240         Add a system trace scope for event region building
241         https://bugs.webkit.org/show_bug.cgi?id=195226
242
243         Reviewed by Jon Lee.
244
245         This trace scope measures the time spend converting element rects into Region objects,
246         which can be large on some pages.
247
248         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
249
250         * Tracing/SystemTracePoints.plist:
251
252 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
253
254         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
255         https://bugs.webkit.org/show_bug.cgi?id=194612
256
257         Reviewed by Alex Christensen.
258
259         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
260         Just test the new string-processing function and don't touch the actual environment.
261         (Test cases are all as before, but based on operator== instead of strcmp.)
262
263 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
264
265         [ews-app] Update primary keys for handling multiple Buildbot instances
266         https://bugs.webkit.org/show_bug.cgi?id=195120
267
268         Reviewed by Stephanie Lewis.
269
270         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
271         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
272         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
273
274         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
275         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
276         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
277         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
278         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
279         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
280
281 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
282
283         [WinCairo] Enable service worker
284         https://bugs.webkit.org/show_bug.cgi?id=188318
285
286         Reviewed by Youenn Fablet.
287
288         * DumpRenderTree/DumpRenderTreePrefix.h:
289         * TestWebKitAPI/PlatformWin.cmake:
290         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
291         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
292         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
293
294 2019-03-01  Justin Fan  <justin_fan@apple.com>
295
296         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
297         https://bugs.webkit.org/show_bug.cgi?id=195191
298
299         Rubber-stamped by Dean Jackson.
300
301         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
302
303         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
304
305 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
306
307         Unreviewed, fix lldb webkitpy tests
308         https://bugs.webkit.org/show_bug.cgi?id=194375
309
310         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
311
312         * lldb/lldb_webkit.py:
313         (WTFStringImplProvider.is_8bit):
314
315 2019-02-28  David Quesada  <david_quesada@apple.com>
316
317         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
318         https://bugs.webkit.org/show_bug.cgi?id=195121
319         rdar://problem/48450302
320
321         Reviewed by Alex Christensen.
322
323         Add API tests for -WKNavigationAction._shouldPerformDownload in various
324         configurations where the 'download' attribute is absent, blank, or populated
325         with a filename, and where the anchor element is same-origin or cross-origin
326         (meaning the 'download' attribute shouldn't be honored).
327
328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
329         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
330         (-[NavigationActionTestDelegate init]):
331         (-[NavigationActionTestDelegate navigationAction]):
332         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
333         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
334         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
335         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
336         (TEST):
337
338 2019-02-28  Antoine Quint  <graouts@apple.com>
339
340         Enable the Pointer Events runtime flag by default
341         https://bugs.webkit.org/show_bug.cgi?id=195156
342
343         Reviewed by Dean Jackson.
344
345         * DumpRenderTree/mac/DumpRenderTree.mm:
346         (enableExperimentalFeatures):
347
348 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
349
350         Several PasteImage API tests are flaky
351         https://bugs.webkit.org/show_bug.cgi?id=195160
352
353         Reviewed by Tim Horton.
354
355         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
356         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
357         listening for a "load" event after image load is already complete.
358
359         To address this, make these tests first register a "load" event handler, then run script to insert an image
360         element into the document, and finally wait until the load event is observed before checking image size.
361
362         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
363
364 2019-02-28  Chris Dumez  <cdumez@apple.com>
365
366         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
367         https://bugs.webkit.org/show_bug.cgi?id=195107
368
369         Reviewed by Alex Christensen.
370
371         Give some time for the zoom level to get restored.
372
373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
374
375 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
376
377         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
378         https://bugs.webkit.org/show_bug.cgi?id=194958
379
380         Reviewed by Geoffrey Garen.
381
382         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
383         (TEST):
384
385 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
386
387         [ews-app] Update method to save build to handle builder_display_name
388         https://bugs.webkit.org/show_bug.cgi?id=195047
389
390         Reviewed by Dewei Zhu.
391
392         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
393         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
394
395 2019-02-28  Justin Fan  <justin_fan@apple.com>
396
397         [Web GPU] Enable Web GPU only on 64-bit
398         https://bugs.webkit.org/show_bug.cgi?id=195139
399
400         Because Metal is only supported on 64 bit apps.
401
402         Unreviewed build fix.
403
404         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
405
406 2019-02-27  Youenn Fablet  <youenn@apple.com>
407
408         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
409         https://bugs.webkit.org/show_bug.cgi?id=194959
410
411         Reviewed by Chris Dumez.
412
413         Spin loop until getting the condition to remove flakiness.
414
415         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
416
417 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
418
419         [ews-build] Buildbot should include builder_display_name in the build events
420         https://bugs.webkit.org/show_bug.cgi?id=195045
421
422         Reviewed by Dewei Zhu.
423
424         * BuildSlaveSupport/ews-build/events.py:
425         (Events.buildStarted): Included builder_display_name in event data. Also renamed
426         buildername to builder_name to be consistent in naming style.
427         (Events.buildFinished): Ditto.
428
429 2019-02-27  Chris Dumez  <cdumez@apple.com>
430
431         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
432         https://bugs.webkit.org/show_bug.cgi?id=194480
433
434         Reviewed by Brady Eidson.
435
436         Update existing API test to make it more likely to reproduce the issue.
437
438         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
439
440 2019-02-27  Brady Eidson  <beidson@apple.com>
441
442         Universal links from Google search results pages don't open the app.
443         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
444
445         Reviewed by Geoffrey Garen.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
448         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
449         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
450         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
451
452 2019-02-27  Chris Dumez  <cdumez@apple.com>
453
454         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
455         https://bugs.webkit.org/show_bug.cgi?id=195102
456
457         Reviewed by Geoffrey Garen.
458
459         If the number of processes is not yet what we expect, wait a bit and check again to give
460         processes some time to exit.
461
462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
463
464 2019-02-27  Chris Dumez  <cdumez@apple.com>
465
466         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
467         https://bugs.webkit.org/show_bug.cgi?id=194545
468
469         Reviewed by Brady Eidson.
470
471         Make sure the test navigates forward and then back only once. Previously, navigating
472         back would trigger a navigation again in a timer.
473
474         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
475
476 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
477
478         High Sierra Debug JSC test queue should use faster hardware
479         https://bugs.webkit.org/show_bug.cgi?id=194603
480
481         Rubber-stamped by Alexey Proskuryakov.
482
483         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
484
485         * BuildSlaveSupport/build.webkit.org-config/config.json:
486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
487         (BubbleQueueServer):
488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
489         (WebKitBuildbot):
490         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
491         * QueueStatusServer/config/queues.py:
492         * Scripts/webkitpy/common/config/ews.json:
493         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
494         (test_ews_name):
495
496 2019-02-27  John Wilander  <wilander@apple.com>
497
498         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
499         https://bugs.webkit.org/show_bug.cgi?id=195071
500         <rdar://problem/48417690>
501
502         Reviewed by Alex Christensen and Brent Fulgham.
503
504         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
505         (TestWebKitAPI::createURL):
506             Convenience function.
507         (TestWebKitAPI::TEST):
508             WebCore::AdClickAttribution now takes a URL when creating Source and
509             Destination.
510         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
511         (TestWebKitAPI::TEST):
512             WebCore::AdClickAttribution now takes a URL when creating Source and
513             Destination.
514
515 2019-02-27  Antoine Quint  <graouts@apple.com>
516
517         Support Pointer Events on macOS
518         https://bugs.webkit.org/show_bug.cgi?id=195008
519         <rdar://problem/47454419>
520
521         Reviewed by Dean Jackson.
522
523         * DumpRenderTree/mac/DumpRenderTree.mm:
524         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
525         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
526
527 2019-02-26  Mark Lam  <mark.lam@apple.com>
528
529         Remove remaining poisoning code.
530         https://bugs.webkit.org/show_bug.cgi?id=194138
531
532         Reviewed by Saam Barati.
533
534         * TestWebKitAPI/CMakeLists.txt:
535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
536         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
537         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
538         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
539         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
540         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
541         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
542
543 2019-02-26  Alex Christensen  <achristensen@webkit.org>
544
545         Move ephemeral local storage from WebProcess to UIProcess
546         https://bugs.webkit.org/show_bug.cgi?id=195074
547         <rdar://problem/47937975>
548
549         Reviewed by Geoff Garen.
550
551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
552
553 2019-02-20  Jer Noble  <jer.noble@apple.com>
554
555         [Cocoa] Media elements will restart network buffering just before suspending
556         https://bugs.webkit.org/show_bug.cgi?id=193691
557
558         Reviewed by Eric Carlson.
559
560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
562         (TEST):
563
564 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
565
566         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
567         https://bugs.webkit.org/show_bug.cgi?id=191652
568
569         Reviewed by Alex Christensen.
570
571         Fix WinCairo MiniBrowser behavior of authentication dialog.
572
573         * MiniBrowser/win/WebKitBrowserWindow.cpp:
574         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
575
576 2019-02-26  Youenn Fablet  <youenn@apple.com>
577
578         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
579         https://bugs.webkit.org/show_bug.cgi?id=195028
580         <rdar://problem/48243733>
581
582         Reviewed by Eric Carlson.
583
584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
585
586 2019-02-26  Philippe Normand  <pnormand@igalia.com>
587
588         [WPE] Add API for webview background color configuration
589         https://bugs.webkit.org/show_bug.cgi?id=192305
590
591         Reviewed by Michael Catanzaro.
592
593         * MiniBrowser/wpe/main.cpp:
594         (main): Add a new option to configure the webview background
595         color. Example: --bg-color=transparent.
596         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
597         (testWebViewBackgroundColor): Enable background color API tests for WPE.
598         (beforeAll): Ditto.
599
600 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
601
602         scalableNativeWebpageParameters() is not preserved on new page navigation.
603         https://bugs.webkit.org/show_bug.cgi?id=194892
604         <rdar://problem/47538280>
605
606         Reviewed by Wenson Hsieh.
607         
608         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
609
610         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
611         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
612         * DumpRenderTree/mac/UIScriptControllerMac.mm:
613         (WTR::UIScriptController::allowsViewportShrinkToFit):
614         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
615         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
616         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
617         * TestRunnerShared/UIScriptContext/UIScriptController.h:
618         * WebKitTestRunner/UIScriptControllerCocoa.mm:
619         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
620
621 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
622
623         [ews-app] Add model for handling multiple Buildbot instances
624         https://bugs.webkit.org/show_bug.cgi?id=194863
625
626         Reviewed by Stephanie Lewis.
627
628         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
629
630 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
631
632         [ews-app] Remove BuilderMapping table
633         https://bugs.webkit.org/show_bug.cgi?id=194961
634
635         Reviewed by Stephanie Lewis.
636
637         Store builder name directly in build table, instead of having a separate
638         table for it.
639
640         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
641         * BuildSlaveSupport/ews-app/ews/models/build.py:
642         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
643         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
644
645 2019-02-25  John Wilander  <wilander@apple.com>
646
647         Introduce and adopt new class RegistrableDomain for eTLD+1
648         https://bugs.webkit.org/show_bug.cgi?id=194791
649         <rdar://problem/48179240>
650
651         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
652
653         This patch adds an API test and replaces two instances of
654         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
655
656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
657         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
658         (TestWebKitAPI::TEST):
659             Changed two strings to make sure the registrable domains are still considered
660             invalid and pass the test.
661         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
662         (TestWebKitAPI::TEST):
663         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
664         (WTR::InjectedBundle::didReceiveMessageToPage):
665
666 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
667
668         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
669         https://bugs.webkit.org/show_bug.cgi?id=195001
670
671         Reviewed by Carlos Garcia Campos.
672
673         API version 1.0 always includes the functionality previously guarded with
674         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
675         unconditionally.
676
677         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
678         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
679         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
680         (WebViewTest::showInWindow): Ditto.
681         (WebViewTest::hideView): Ditto.
682         * wpe/backends/HeadlessViewBackend.cpp:
683         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
684         * wpe/backends/ViewBackend.cpp:
685         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
686         * wpe/backends/WindowViewBackend.cpp:
687         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
688         WPE_BACKEND_CHECK_VERSION().
689         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
690
691 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
692
693         [Flatpak] Add support for flatpak > 1.1.2
694         https://bugs.webkit.org/show_bug.cgi?id=194088
695
696         Flatpak 1.2 is now out so we need to support that
697         version now.
698
699         Reviewed by Michael Catanzaro.
700
701         * flatpak/flatpakutils.py:
702         (check_flatpak):
703         (FlatpakPackages.__init__):
704         (FlatpakPackages.__detect_packages):
705         (FlatpakPackages.__detect_packages.in):
706         (FlatpakRepos.update):
707
708 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
709
710         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
711         https://bugs.webkit.org/show_bug.cgi?id=194998
712
713         Reviewed by Carlos Garcia Campos.
714
715         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
716         to a Git checkout and using the latest commit containing various fixes
717         and improvements.
718
719 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
720
721         [WPE][GTK] Remove user agent quirk for washingtonpost.com
722         https://bugs.webkit.org/show_bug.cgi?id=194981
723
724         Reviewed by Žan Doberšek.
725
726         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
727         (TestWebKitAPI::TEST):
728
729 2019-02-23  Keith Miller  <keith_miller@apple.com>
730
731         Add new mac target numbers
732         https://bugs.webkit.org/show_bug.cgi?id=194955
733
734         Reviewed by Tim Horton.
735
736         * DumpRenderTree/mac/Configurations/Base.xcconfig:
737         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
738         * MiniBrowser/Configurations/Base.xcconfig:
739         * TestWebKitAPI/Configurations/Base.xcconfig:
740         * WebKitTestRunner/Configurations/Base.xcconfig:
741
742 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
743
744         [WinCairo] Enable wk1/wk2 suffix for platform search path.
745         https://bugs.webkit.org/show_bug.cgi?id=194846
746
747         Reviewed by Don Olmstead.
748
749         Added _search_paths() and _port_specific_expectations_files() for
750         WinCairoPort.
751
752         * Scripts/webkitpy/port/win.py:
753         (WinCairoPort.default_baseline_search_path):
754         (WinCairoPort):
755         (WinCairoPort._port_specific_expectations_files):
756         (WinCairoPort._search_paths):
757
758 2019-02-22  Tim Horton  <timothy_horton@apple.com>
759
760         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
761         https://bugs.webkit.org/show_bug.cgi?id=194963
762
763         Reviewed by Dean Jackson.
764
765         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
766         Do a `contains` check instead of `equals`, because in debug builds we
767         put the GraphicsLayer pointer in a prefix.
768
769 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
770
771         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
772         https://bugs.webkit.org/show_bug.cgi?id=194873
773         <rdar://problem/46701974>
774
775         Reviewed by Tim Horton.
776
777         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
778
779         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
780         (WTR::UIScriptController::menuRect const):
781         (WTR::UIScriptController::isShowingMenu const):
782         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
783         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
784         (WTR::UIScriptController::menuRect const):
785
786         Add a function to query the bounds of the callout menu in content coordinates.
787
788         (WTR::UIScriptController::isShowingMenu const):
789
790         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
791
792         * TestRunnerShared/UIScriptContext/UIScriptController.h:
793         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
794         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
795         (WTR::UIScriptController::rectForMenuAction const):
796         (WTR::UIScriptController::menuRect const):
797         (WTR::UIScriptController::isShowingMenu const):
798         (WTR::findViewInHierarchyOfType): Deleted.
799
800 2019-02-22  Chris Dumez  <cdumez@apple.com>
801
802         Regression(PSON) Unable to preview password-protected documents on iCloud.com
803         https://bugs.webkit.org/show_bug.cgi?id=194954
804         <rdar://problem/48127957>
805
806         Reviewed by Alex Christensen.
807
808         Add API test coverage.
809
810         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
811         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
812         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
813         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
814
815 2019-02-22  Chris Dumez  <cdumez@apple.com>
816
817         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
818         https://bugs.webkit.org/show_bug.cgi?id=194924
819         <rdar://problem/48216125>
820
821         Reviewed by Geoffrey Garen.
822
823         Add API test coverage.
824
825         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
826
827 2019-02-22  Chris Dumez  <cdumez@apple.com>
828
829         Unreviewed, disable API test added in r241928 on iOS.
830
831         The cache is not enabled on devices with less than 3GB of RAM.
832
833         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
834
835 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
836
837         Hardcode Visual Viewports on everywhere except iOS WK1
838         https://bugs.webkit.org/show_bug.cgi?id=194928
839
840         Reviewed by Zalan Bujtas.
841
842         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
843         change the default value of the Setting to 'true', and hardcode WebView on iOS to
844         set it to false. The setting has shipped for several years and there's no need to turn
845         it off now.
846
847         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
848         Visual Viewports are not enabled.
849         
850         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
851         that only runs in WK2
852
853         * MiniBrowser/mac/SettingsController.h:
854         * MiniBrowser/mac/SettingsController.m:
855         (-[SettingsController init]):
856         (-[SettingsController _populateMenu]):
857         (-[SettingsController validateMenuItem:]):
858         (-[SettingsController visualViewportEnabled]): Deleted.
859         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
860         * MiniBrowser/mac/WK1BrowserWindowController.m:
861         (-[WK1BrowserWindowController didChangeSettings]):
862         * MiniBrowser/mac/WK2BrowserWindowController.m:
863         (-[WK2BrowserWindowController didChangeSettings]):
864
865 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
866
867         Discard cached processes when clearing website data store
868         https://bugs.webkit.org/show_bug.cgi?id=194894
869
870         Reviewed by Chris Dumez.
871
872         Added a test case.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
875         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
876
877 2019-02-21  Alex Christensen  <achristensen@webkit.org>
878
879         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
880         https://bugs.webkit.org/show_bug.cgi?id=194914
881         <rdar://problem/47586889>
882
883         Reviewed by Geoffrey Garen.
884
885         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
886         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
887         (TEST):
888         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
889
890 2019-02-21  David Kilzer  <ddkilzer@apple.com>
891
892         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
893         <https://webkit.org/b/194761>
894
895         Reviewed by Myles Maxfield.
896
897         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
898         (WTR::activateSystemCoreWebFonts): Log `error` to console if
899         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
900         to use ARC-compliant cast.
901         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
902         ARC-compliant cast.
903         (WTR::installFakeHelvetica): Log `error` to console if
904         CTFontManagerRegisterFontsForURL() fails, but only on supported
905         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
906         Call CFRelease() on `error` to fix the leak.  Update to use
907         ARC-compliant cast.
908         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
909         cast.
910
911 2019-02-21  Chris Dumez  <cdumez@apple.com>
912
913         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
914         https://bugs.webkit.org/show_bug.cgi?id=194481
915
916         Reviewed by Alex Christensen.
917
918         Give the processes a chance to shutdown and wait until we reached the expected number
919         of processes.
920
921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
922
923 2019-02-21  Tim Horton  <timothy_horton@apple.com>
924
925         Fix the macOS build
926
927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
928
929 2019-02-21  Tim Horton  <timothy_horton@apple.com>
930
931         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
932
933         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
934         I am a backwards.
935
936 2019-02-21  Tim Horton  <timothy_horton@apple.com>
937
938         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
939
940         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
941         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
942         We could force on UI-side compositing, but I feel like the test might be more
943         valuable exercising the normal path on each platform (though the original
944         bug was also UI-side specific). Though we can't validate that the overlay
945         layer was installed successfully, there are layout tests that do that.
946
947 2019-02-21  Tim Horton  <timothy_horton@apple.com>
948
949         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
950         https://bugs.webkit.org/show_bug.cgi?id=194845
951         <rdar://problem/47944579>
952
953         Reviewed by Antti Koivisto.
954
955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
956         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
957
958 2019-02-21  Zalan Bujtas  <zalan@apple.com>
959
960         [LFC][Floats] Add support for placing formatting roots in-between floats.
961         https://bugs.webkit.org/show_bug.cgi?id=194902
962
963         Reviewed by Antti Koivisto.
964
965         * LayoutReloaded/misc/LFC-passing-tests.txt:
966
967 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
968
969         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
970         https://bugs.webkit.org/show_bug.cgi?id=194901
971
972         Unreviewed build fix.
973
974         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
975         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
976         WPEBackend-fdo-0.1 as library name.
977
978 2019-02-21  Rob Buis  <rbuis@igalia.com>
979
980         Update MIME type parser
981         https://bugs.webkit.org/show_bug.cgi?id=180526
982
983         Reviewed by Darin Adler.
984
985         Add tests involving leading and trailing whitespace, non-token
986         characters and quoted strings.
987
988         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
989         (TestWebKitAPI::TEST):
990
991 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
992
993         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
994         https://bugs.webkit.org/show_bug.cgi?id=194884
995
996         Reviewed by Michael Catanzaro.
997
998         * PlatformWin.cmake:
999
1000 2019-02-20  Chris Dumez  <cdumez@apple.com>
1001
1002         Add API test for <rdar://problem/47471222>
1003         https://bugs.webkit.org/show_bug.cgi?id=194847
1004
1005         Reviewed by Alex Christensen.
1006
1007         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1008
1009 2019-02-20  Chris Dumez  <cdumez@apple.com>
1010
1011         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1012         https://bugs.webkit.org/show_bug.cgi?id=194872
1013         <rdar://problem/47924500>
1014
1015         Reviewed by Alex Christensen.
1016
1017         Add API test coverage.
1018
1019         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1020
1021 2019-02-20  Jer Noble  <jer.noble@apple.com>
1022
1023         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1024         https://bugs.webkit.org/show_bug.cgi?id=191332
1025
1026         Reviewed by Dean Jackson.
1027
1028         * Scripts/git-is-in-range: Added.
1029
1030 2019-02-20  Andy Estes  <aestes@apple.com>
1031
1032         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1033         https://bugs.webkit.org/show_bug.cgi?id=194869
1034
1035         Rubber-stamped by Jer Noble.
1036
1037         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1038         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1039         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1040         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1042         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1043
1044 2019-02-20  Chris Dumez  <cdumez@apple.com>
1045
1046         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1047         https://bugs.webkit.org/show_bug.cgi?id=194857
1048         <rdar://problem/47759323>
1049
1050         Reviewed by Alex Christensen.
1051
1052         Add API test coverage.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1055
1056 2019-02-20  Chris Dumez  <cdumez@apple.com>
1057
1058         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1059         https://bugs.webkit.org/show_bug.cgi?id=194829
1060         <rdar://problem/47889906>
1061
1062         Reviewed by Alexey Proskuryakov.
1063
1064         Every time the TestOptions were changing we were creating both a new Web view and
1065         a new WKContext, which would start a new Network process. In most cases, we only
1066         need to contruct a new Web view and we do can keep reusing the same WKContext.
1067         This patch implements this optimization and thus avoids spinning a lot of new
1068         Network processes while running the layout tests.
1069
1070         * WebKitTestRunner/TestController.cpp:
1071         (WTR::TestController::generateContextConfiguration const):
1072         (WTR::TestController::generatePageConfiguration):
1073         (WTR::TestController::createWebViewWithOptions):
1074         (WTR::TestController::resetPreferencesToConsistentValues):
1075         (WTR::updateTestOptionsFromTestHeader):
1076         * WebKitTestRunner/TestController.h:
1077         * WebKitTestRunner/TestOptions.h:
1078         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1079         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1080         (WTR::TestOptions::hasSameInitializationOptions const):
1081         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1082         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1083         (WTR::TestController::platformAddTestOptions const):
1084
1085 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1086
1087         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1088         https://bugs.webkit.org/show_bug.cgi?id=167941
1089
1090         Reviewed by Carlos Garcia Campos.
1091
1092         * MiniBrowser/gtk/main.c:
1093         (filterSavedCallback): Added.
1094         (main): Support loading a JSON rule set file for content filtering.
1095         * MiniBrowser/wpe/main.cpp:
1096         (filterSavedCallback): Added.
1097         (main): Support loading a JSON rule set file for content filtering.
1098         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1099         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1100         (WTF::derefGPtr): Ditto.
1101         (testEmptyStore):
1102         (testSaveInvalidFilter):
1103         (testSaveLoadFilter):
1104         (testSavedFilterIdentifierMatch):
1105         (testRemoveFilter):
1106         (testSaveMultipleFilters):
1107         (testSaveFilterFromFile):
1108         (testFilterPersistence):
1109         (beforeAll):
1110         (afterAll):
1111         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1112         (removeOldInjectedContentAndResetLists): Also reset content filters.
1113         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1114         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1115         the element affected by the style sheet.
1116         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1117         and returns it to be used by tests.
1118         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1119         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1120         (serverCallback): Add support for serving a CSS style sheet for testing.
1121         (beforeAll): Add call to testUserContentManagerContentFilter().
1122         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1123
1124 2019-02-19  Keith Rollin  <krollin@apple.com>
1125
1126         Add timing information to build output
1127         https://bugs.webkit.org/show_bug.cgi?id=194839
1128         <rdar://problem/48219609>
1129
1130         Reviewed by Alexey Proskuryakov.
1131
1132         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1133         emit each project's build time to its output. E.g.,
1134
1135             ** BUILD SUCCEEDED ** [0.132 sec]
1136
1137         * Scripts/webkitdirs.pm:
1138         (XcodeOptions):
1139
1140 2019-02-19  Truitt Savell  <tsavell@apple.com>
1141
1142         Unreviewed, rolling out r241784.
1143
1144         Broke all OpenSource builds.
1145
1146         Reverted changeset:
1147
1148         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1149         instances view"
1150         https://bugs.webkit.org/show_bug.cgi?id=172848
1151         https://trac.webkit.org/changeset/241784
1152
1153 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1154
1155         [LFC][Floats] Remove redundant intersecting logic
1156         https://bugs.webkit.org/show_bug.cgi?id=194804
1157
1158         Reviewed by Antti Koivisto.
1159
1160         * LayoutReloaded/misc/LFC-passing-tests.txt:
1161
1162 2019-02-19  Dean Jackson  <dino@apple.com>
1163
1164         Clean-up output from generate-xcfilelists so it can be filtered
1165         https://bugs.webkit.org/show_bug.cgi?id=194795
1166
1167         Reviewed by Joseph Pecoraro (and Keith Rollin).
1168
1169         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1170         make a slight tweak to filter-build-webkit so such lines are marked
1171         as plain.
1172
1173         * Scripts/filter-build-webkit:
1174         * Scripts/generate-xcfilelists:
1175
1176 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1177
1178         pytest is not correctly auto-installed
1179         https://bugs.webkit.org/show_bug.cgi?id=194707
1180
1181         Reviewed by Carlos Garcia Campos.
1182
1183         * Scripts/webkitpy/thirdparty/__init__.py:
1184         (AutoinstallImportHook._install_pytest):
1185
1186 2019-02-18  Chris Dumez  <cdumez@apple.com>
1187
1188         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1189         https://bugs.webkit.org/show_bug.cgi?id=194797
1190         <rdar://problem/48055151>
1191
1192         Reviewed by Geoffrey Garen.
1193
1194         Add API test coverage.
1195
1196         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1197
1198 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1199
1200         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1201         https://bugs.webkit.org/show_bug.cgi?id=194670
1202         <rdar://problem/39066529>
1203
1204         Reviewed by Tim Horton.
1205
1206         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1207         pasted in an editable area as attachment elements.
1208
1209         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1210         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1211         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1212         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1213         (TestWebKitAPI::TEST):
1214         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1215         (WTR::InjectedBundlePage::InjectedBundlePage):
1216
1217 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1218
1219         Fix API test after r241728
1220        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1221
1222         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1223         (TEST):
1224         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1225
1226 2019-02-18  Daniel Bates  <dabates@apple.com>
1227
1228         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1229         https://bugs.webkit.org/show_bug.cgi?id=192824
1230         <rdar://problem/47100332>
1231
1232         Reviewed by Wenson Hsieh.
1233
1234         Fix a bug where the wrong usage code was used for F13 thru F24.
1235
1236         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1237         (keyCodeForDOMFunctionKey):
1238
1239 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1240
1241         Bytecode cache should a have a boot-specific validation
1242         https://bugs.webkit.org/show_bug.cgi?id=194769
1243         <rdar://problem/48149509>
1244
1245         Reviewed by Keith Miller.
1246
1247         Add test for WTF::bootSessionUUIDString()
1248
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1251         (TEST):
1252
1253 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1254
1255         Disable safe browsing in WKWebView and remove its WKPreferences API
1256         https://bugs.webkit.org/show_bug.cgi?id=194723
1257         <rdar://problem/48122993>
1258
1259         Reviewed by Geoffrey Garen.
1260
1261         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1262         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1263         (TEST):
1264         (safeBrowsingView):
1265         Make tests use SPI instead of API.
1266
1267 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1268
1269         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1270         https://bugs.webkit.org/show_bug.cgi?id=194586
1271
1272         Reviewed by Ross Kirsling.
1273
1274         * DumpRenderTree/win/DumpRenderTree.cpp:
1275         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1276         * Scripts/webkitpy/port/driver.py:
1277         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1278
1279 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1280
1281         Unreviewed, rolling out r241620.
1282
1283         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1284         (Requested by ddkilzer on #webkit.)
1285
1286         Reverted changeset:
1287
1288         "[WTF] Add environment variable helpers"
1289         https://bugs.webkit.org/show_bug.cgi?id=192405
1290         https://trac.webkit.org/changeset/241620
1291
1292 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1293
1294         [LFC] RenderImage's default intrinsic size is 0.
1295         https://bugs.webkit.org/show_bug.cgi?id=194745
1296
1297         Reviewed by Antti Koivisto.
1298
1299         * LayoutReloaded/misc/LFC-passing-tests.txt:
1300
1301 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1302
1303         [LFC][BFC] Add support for block replaced intrinsic width.
1304         https://bugs.webkit.org/show_bug.cgi?id=194705
1305
1306         Reviewed by Simon Fraser.
1307
1308         * LayoutReloaded/misc/LFC-passing-tests.txt:
1309
1310 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1311
1312         [LFC] Apply min/max width constraints to preferred width computation
1313         https://bugs.webkit.org/show_bug.cgi?id=194739
1314
1315         Reviewed by Simon Fraser.
1316
1317         * LayoutReloaded/misc/LFC-passing-tests.txt:
1318
1319 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1320
1321         [WTF] Add environment variable helpers
1322         https://bugs.webkit.org/show_bug.cgi?id=192405
1323
1324         Reviewed by Michael Catanzaro.
1325
1326         * DumpRenderTree/mac/DumpRenderTree.mm:
1327         (libraryPathForDumpRenderTree):
1328         * DumpRenderTree/win/DumpRenderTree.cpp:
1329         (libraryPathForDumpRenderTree):
1330         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1331         (setUpIOSLayoutTestCommunication):
1332         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1333         (beforeAll):
1334         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1335         (main):
1336         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1337         (WebKitTestBus::run):
1338         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1339         (WTR::getOutputDir):
1340         (WTR::initializeFontConfigSetting):
1341         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1342         (WTR::InjectedBundle::platformInitialize):
1343         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1344         (WTR::topLevelPath):
1345         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1346         (WTR::topLevelPath):
1347         (WTR::getOutputDir):
1348         (WTR::activateFonts):
1349         * WebKitTestRunner/TestController.cpp:
1350         (WTR::TestController::libraryPathForTesting):
1351         (WTR::TestController::generateContextConfiguration const):
1352         (WTR::TestController::generatePageConfiguration):
1353         (WTR::TestController::decideDestinationWithSuggestedFilename):
1354         (WTR::TestController::platformAdjustContext):
1355         * WebKitTestRunner/TestController.h:
1356         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1357         (WTR::TestController::cocoaPlatformInitialize):
1358         (WTR::TestController::platformAdjustContext):
1359         * WebKitTestRunner/gtk/main.cpp:
1360         (main):
1361         * WebKitTestRunner/mac/TestControllerMac.mm:
1362         (WTR::TestController::configureContentExtensionForTest):
1363         * WebKitTestRunner/wpe/main.cpp:
1364         (main):
1365         Utilize WTF::Environment where possible.
1366
1367 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1368
1369         [iOS] WKWebView callout bar is missing Change Writing Direction item
1370         https://bugs.webkit.org/show_bug.cgi?id=190015
1371         <rdar://problem/44810366>
1372
1373         Reviewed by Tim Horton.
1374
1375         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1376         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1377
1378         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1379         (TestWebKitAPI::TEST):
1380
1381 2019-02-15  Chris Dumez  <cdumez@apple.com>
1382
1383         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1384         https://bugs.webkit.org/show_bug.cgi?id=194717
1385         <rdar://problem/47884404>
1386
1387         Reviewed by Brady Eidson.
1388
1389         Add API test coverage.
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1392
1393 2019-02-15  Youenn Fablet  <youenn@apple.com>
1394
1395         Make navigator.mediaDevices SecureContext
1396         https://bugs.webkit.org/show_bug.cgi?id=194666
1397
1398         Reviewed by Eric Carlson.
1399
1400         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1401         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1402         (TEST_F):
1403
1404 2019-02-15  Brian Burg  <bburg@apple.com>
1405
1406         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1407         https://bugs.webkit.org/show_bug.cgi?id=194411
1408         <rdar://problem/47787614>
1409
1410         Reviewed by Joseph Pecoraro.
1411
1412         Remove unnecessary soft linking macro usage.
1413
1414         * DumpRenderTree/mac/TestRunnerMac.mm:
1415         (TestRunner::inspectorTestStubURL):
1416         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1417         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1418         (WTR::TestRunner::inspectorTestStubURL):
1419
1420 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1421
1422         Unreviewed, rolling out r241559 and r241566.
1423         https://bugs.webkit.org/show_bug.cgi?id=194710
1424
1425         Causes layout test crashes under GuardMalloc (Requested by
1426         ryanhaddad on #webkit).
1427
1428         Reverted changesets:
1429
1430         "[WTF] Add environment variable helpers"
1431         https://bugs.webkit.org/show_bug.cgi?id=192405
1432         https://trac.webkit.org/changeset/241559
1433
1434         "Unreviewed build fix for WinCairo Debug after r241559."
1435         https://trac.webkit.org/changeset/241566
1436
1437 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1438
1439         [LFC] Out-of-flow box is never a float box
1440         https://bugs.webkit.org/show_bug.cgi?id=194704
1441
1442         Reviewed by Antti Koivisto.
1443
1444         * LayoutReloaded/misc/LFC-passing-tests.txt:
1445
1446 2019-02-10  Darin Adler  <darin@apple.com>
1447
1448         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1449         https://bugs.webkit.org/show_bug.cgi?id=194487
1450
1451         Reviewed by Daniel Bates.
1452
1453         * DumpRenderTree/win/DumpRenderTree.cpp:
1454         (applicationId): Use makeString instead of String::format.
1455         (main): Ditto.
1456         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1457         (TestWebKitAPI::Util::createURLForResource): Ditto.
1458         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1459         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1460
1461         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1462         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1463         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1464         (WTR::createStringWithAttributes): Use appendLiteral.
1465         (WTR::AccessibilityUIElement::helpText const): Ditto.
1466         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1467         directly instead of using String::format.
1468         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1469         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1470
1471 2019-02-15  Truitt Savell  <tsavell@apple.com>
1472
1473         Unreviewed, rolling out r241564.
1474
1475         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1476
1477         Reverted changeset:
1478
1479         "[Mac] WebInspectorUI.framework does not need to be soft-
1480         linked anymore"
1481         https://bugs.webkit.org/show_bug.cgi?id=194411
1482         https://trac.webkit.org/changeset/241564
1483
1484 2019-02-15  Saam barati  <sbarati@apple.com>
1485
1486         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1487         https://bugs.webkit.org/show_bug.cgi?id=194036
1488
1489         Reviewed by Yusuke Suzuki.
1490
1491         * Scripts/run-jsc-stress-tests:
1492
1493 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1494
1495         Fix the build.
1496
1497         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1498         (WTR::UIScriptController::drawSquareInEditableImage):
1499         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1500         (TestWebKitAPI::drawSquareInEditableImage):
1501
1502 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1503
1504         Fix the build.
1505
1506         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1507         (WTR::UIScriptController::drawSquareInEditableImage):
1508         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1509         (TestWebKitAPI::drawSquareInEditableImage):
1510
1511 2019-02-14  Brian Burg  <bburg@apple.com>
1512
1513         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1514         https://bugs.webkit.org/show_bug.cgi?id=194411
1515         <rdar://problem/47787614>
1516
1517         Reviewed by Joseph Pecoraro.
1518
1519         Remove unnecessary soft linking macro usage.
1520
1521         * DumpRenderTree/mac/TestRunnerMac.mm:
1522         (TestRunner::inspectorTestStubURL):
1523         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1524         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1525         (WTR::TestRunner::inspectorTestStubURL):
1526
1527 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1528
1529         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1530         https://bugs.webkit.org/show_bug.cgi?id=194599
1531
1532         Reviewed by Lucas Forschler.
1533
1534         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1535         (StatusBubble._build_bubble):
1536
1537 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1538
1539         [ews-app] Set Foreign Key in Django build model
1540         https://bugs.webkit.org/show_bug.cgi?id=194667
1541
1542         Reviewed by Lucas Forschler.
1543
1544         * BuildSlaveSupport/ews-app/ews/models/build.py:
1545         (Build):
1546
1547 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1548
1549         [WTF] Add environment variable helpers
1550         https://bugs.webkit.org/show_bug.cgi?id=192405
1551
1552         Reviewed by Michael Catanzaro.
1553
1554         * DumpRenderTree/mac/DumpRenderTree.mm:
1555         (libraryPathForDumpRenderTree):
1556         * DumpRenderTree/win/DumpRenderTree.cpp:
1557         (libraryPathForDumpRenderTree):
1558         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1559         (setUpIOSLayoutTestCommunication):
1560         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1561         (TestWebKitAPI::strip):
1562         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1563         (beforeAll):
1564         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1565         (main):
1566         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1567         (WebKitTestBus::run):
1568         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1569         (WTR::getOutputDir):
1570         (WTR::initializeFontConfigSetting):
1571         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1572         (WTR::InjectedBundle::platformInitialize):
1573         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1574         (WTR::topLevelPath):
1575         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1576         (WTR::topLevelPath):
1577         (WTR::getOutputDir):
1578         (WTR::activateFonts):
1579         * WebKitTestRunner/TestController.cpp:
1580         (WTR::TestController::libraryPathForTesting):
1581         (WTR::TestController::generateContextConfiguration const):
1582         (WTR::TestController::generatePageConfiguration):
1583         (WTR::TestController::decideDestinationWithSuggestedFilename):
1584         (WTR::TestController::platformAdjustContext):
1585         * WebKitTestRunner/TestController.h:
1586         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1587         (WTR::TestController::cocoaPlatformInitialize):
1588         (WTR::TestController::platformAdjustContext):
1589         * WebKitTestRunner/gtk/main.cpp:
1590         (main):
1591         * WebKitTestRunner/mac/TestControllerMac.mm:
1592         (WTR::TestController::configureContentExtensionForTest):
1593         * WebKitTestRunner/wpe/main.cpp:
1594         (main):
1595         Utilize WTF::Environment where possible.
1596
1597 2019-02-14  Chris Dumez  <cdumez@apple.com>
1598
1599         [PSON] Introduce a WebContent Process cache
1600         https://bugs.webkit.org/show_bug.cgi?id=194594
1601         <rdar://problem/46793397>
1602
1603         Reviewed by Geoff Garen.
1604
1605         Update API tests to turn on the WebContent Process cache.
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1608
1609 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1610
1611         Unreviewed, build fix after r241480
1612
1613         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1614         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1615         (-[DragAndDropSimulator initWithWebView:]):
1616
1617 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1618
1619         AX: ARIA Reflection was disabled in error
1620         https://bugs.webkit.org/show_bug.cgi?id=194647
1621         <rdar://problem/48068336>
1622
1623         Reviewed by Ryosuke Niwa.
1624
1625         Remove test override now that this feature should be enabled by default.
1626
1627         * WebKitTestRunner/TestController.cpp:
1628         (WTR::TestController::resetPreferencesToConsistentValues):
1629
1630 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1631
1632         Unreviewed, rolling out r241486.
1633         https://bugs.webkit.org/show_bug.cgi?id=194655
1634
1635         causing API failures in builds (Requested by ShawnRoberts on
1636         #webkit).
1637
1638         Reverted changeset:
1639
1640         "[Cocoa] Media elements will restart network buffering just
1641         before suspending"
1642         https://bugs.webkit.org/show_bug.cgi?id=193691
1643         https://trac.webkit.org/changeset/241486
1644
1645 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1646
1647         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1648         https://bugs.webkit.org/show_bug.cgi?id=194622
1649
1650         Reviewed by Antti Koivisto.
1651
1652         * LayoutReloaded/misc/LFC-passing-tests.txt:
1653
1654 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1655
1656         [LFC] Shrink-to-fit-width should be constrained by min/max width
1657         https://bugs.webkit.org/show_bug.cgi?id=194653
1658
1659         Reviewed by Antti Koivisto.
1660
1661         * LayoutReloaded/misc/LFC-passing-tests.txt:
1662
1663 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1664
1665         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1666         https://bugs.webkit.org/show_bug.cgi?id=194641
1667
1668         Reviewed by Geoffrey Garen.
1669
1670         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1671         so that the test would fail without this fix.
1672
1673         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1674         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1675
1676 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1677
1678         [ews-app] Change log level for a log statement
1679
1680         Unreviewed minor fix.
1681
1682         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1683         (Patch.save_patch):
1684
1685 2019-02-13  Jer Noble  <jer.noble@apple.com>
1686
1687         [Cocoa] Media elements will restart network buffering just before suspending
1688         https://bugs.webkit.org/show_bug.cgi?id=193691
1689
1690         Reviewed by Eric Carlson.
1691
1692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1693         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1694         (TEST):
1695
1696 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1697
1698         [ews-app] Fetch builder id to name mapping
1699         https://bugs.webkit.org/show_bug.cgi?id=194355
1700
1701         Reviewed by Lucas Forschler.
1702
1703         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1704         (Buildbot.get_builder_id_to_name_mapping):
1705         (Buildbot._get_display_name_from_builder_name):
1706
1707 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1708
1709         Further restricting webarchive loads
1710         https://bugs.webkit.org/show_bug.cgi?id=194567
1711         <rdar://problem/47610130>
1712
1713         Reviewed by Youenn Fablet.
1714
1715         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1716         navigations on drop.
1717
1718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1719         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1720         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1721         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1722         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1723         (TestWebKitAPI::TEST):
1724         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1725         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1726         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1727         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1728         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1729         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1730         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1731
1732 2019-02-13  John Wilander  <wilander@apple.com>
1733
1734         Store Ad Click Attribution requests in the network process
1735         https://bugs.webkit.org/show_bug.cgi?id=194510
1736         <rdar://problem/47650118>
1737
1738         Reviewed by Alex Christensen and Daniel Bates.
1739
1740         This patch adds two TestRunner functions:
1741         - dumpAdClickAttribution()
1742         - clearAdClickAttribution()
1743
1744         They call into the network process to dump and clear Ad Click
1745         Attribution state, respectively.
1746
1747         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1748         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1749         (WTR::TestRunner::dumpAdClickAttribution):
1750         (WTR::TestRunner::clearAdClickAttribution):
1751         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1752         * WebKitTestRunner/TestController.cpp:
1753         (WTR::TestController::resetStateToConsistentValues):
1754         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1755         (WTR::adClickAttributionStringResultCallback):
1756         (WTR::TestController::dumpAdClickAttribution):
1757         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1758         (WTR::adClickAttributionVoidCallback):
1759         (WTR::TestController::clearAdClickAttribution):
1760         * WebKitTestRunner/TestController.h:
1761         * WebKitTestRunner/TestInvocation.cpp:
1762         (WTR::TestInvocation::dumpResults):
1763         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1764         (WTR::TestInvocation::dumpAdClickAttribution):
1765         * WebKitTestRunner/TestInvocation.h:
1766
1767 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1768
1769         [ews-app] Generate status-bubble
1770         https://bugs.webkit.org/show_bug.cgi?id=194572
1771
1772         Reviewed by Lucas Forschler.
1773
1774         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1775         (StatusBubble._build_bubble):
1776         (StatusBubble._should_show_bubble_for):
1777         (StatusBubble._build_bubbles_for_patch):
1778
1779 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-app] Add status bubble html template
1782         https://bugs.webkit.org/show_bug.cgi?id=194571
1783
1784         Reviewed by Lucas Forschler.
1785
1786         * BuildSlaveSupport/ews-app/ews/templates: Added.
1787         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1788
1789 2019-02-12  Chris Dumez  <cdumez@apple.com>
1790
1791         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1792         https://bugs.webkit.org/show_bug.cgi?id=194568
1793         <rdar://problem/47944490>
1794
1795         Reviewed by Ryosuke Niwa.
1796
1797         Add API test coverage.
1798
1799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1800         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1801
1802 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1803
1804         webkitpy: Remove bug_dummy from parsed test expectations
1805         https://bugs.webkit.org/show_bug.cgi?id=194562
1806         <rdar://problem/47853999>
1807
1808         Reviewed by Lucas Forschler.
1809
1810         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1811         (TestExpectationParser):
1812         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1813         skipped tests.
1814         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1815
1816 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1817
1818         [ews-app] Add method to fetch patch
1819         https://bugs.webkit.org/show_bug.cgi?id=194518
1820
1821         Reviewed by Lucas Forschler.
1822
1823         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1824         (Patch.get_patch):
1825
1826 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1827
1828         [LFC] Expand tests coverage (60 new tests -> 860)
1829
1830         Unreviewed test gardening (run-singly, --child-processes=1).
1831
1832         * LayoutReloaded/misc/LFC-passing-tests.txt:
1833
1834 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1835
1836         Allow pages to trigger programmatic paste from script on iOS
1837         https://bugs.webkit.org/show_bug.cgi?id=194271
1838         <rdar://problem/47808810>
1839
1840         Reviewed by Tim Horton.
1841
1842         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1843
1844         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1845         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1846         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1847         (WTR::UIScriptController::rectForMenuAction const):
1848
1849         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1850         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1851         for when the menu is shown or hidden.
1852
1853         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1854         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1855         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1856         (WTR::UIScriptController::setDidShowMenuCallback):
1857         (WTR::UIScriptController::didShowMenuCallback const):
1858         (WTR::UIScriptController::setDidHideMenuCallback):
1859         (WTR::UIScriptController::didHideMenuCallback const):
1860         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1861         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1862         (WTR::UIScriptController::rectForMenuAction const):
1863         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1864         * WebKitTestRunner/TestController.cpp:
1865         (WTR::TestController::resetPreferencesToConsistentValues):
1866         (WTR::updateTestOptionsFromTestHeader):
1867         * WebKitTestRunner/TestOptions.h:
1868
1869         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1870         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1871
1872         (WTR::TestOptions::hasSameInitializationOptions const):
1873         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1874         (WTR::UIScriptController::calendarType const):
1875         (WTR::UIScriptController::platformUndoManager const):
1876         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1877         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1878         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1879         (-[TestRunnerWKWebView dealloc]):
1880         (-[TestRunnerWKWebView _didShowMenu]):
1881         (-[TestRunnerWKWebView _didHideMenu]):
1882
1883         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1884
1885         * WebKitTestRunner/ios/TestControllerIOS.mm:
1886         (WTR::handleMenuWillHideNotification):
1887         (WTR::handleMenuDidHideNotification):
1888         (WTR::TestController::platformInitialize):
1889         (WTR::TestController::platformDestroy):
1890         (WTR::TestController::platformResetStateToConsistentValues):
1891
1892         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1893         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1894
1895         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1896         (WTR::forEachViewInHierarchy):
1897         (WTR::findViewInHierarchyOfType):
1898
1899         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1900         functions that dig through a given view's hierarchy in search of a view of a given class.
1901
1902         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1903         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1904         (WTR::UIScriptController::selectionCaretViewRect const):
1905         (WTR::UIScriptController::selectionRangeViewRects const):
1906         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1907         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1908
1909         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1910
1911         (WTR::UIScriptController::rectForMenuAction const):
1912
1913         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1914         callout bar) whose label matches the given string.
1915
1916         (WTR::UIScriptController::platformContentView const):
1917
1918         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1919         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1920         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1921
1922         (WTR::UIScriptController::platformUndoManager const): Deleted.
1923         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1924         (WTR::UIScriptController::platformContentView const):
1925         (WTR::UIScriptController::platformUndoManager const): Deleted.
1926
1927 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1928
1929         webkitpy: No option to only show unexpected failures in results.html for iPad
1930         https://bugs.webkit.org/show_bug.cgi?id=194554
1931         <rdar://problem/47922442>
1932
1933         Rubber-stamped by Aakash Jain.
1934
1935         Just because a TestExpecations file does not exist for a specific platform does not mean that
1936         TestExpecations are not being used, given that platforms inherit test expectations.
1937
1938         * Scripts/webkitpy/port/base.py:
1939         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1940         * Scripts/webkitpy/port/base_unittest.py:
1941         (PortTest.test_uses_test_expectations_file):
1942
1943 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1944
1945         Remove setDefersLoading infrastructure from WebKit2
1946         https://bugs.webkit.org/show_bug.cgi?id=194506
1947
1948         Reviewed by Brady Eidson.
1949
1950         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1951         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1952         (WTR::TestRunner::setDefersLoading): Deleted.
1953         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1954
1955 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1956
1957         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1958         https://bugs.webkit.org/show_bug.cgi?id=194522
1959         <rdar://problem/47789393>
1960
1961         Reviewed by Chris Dumez.
1962
1963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1964         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1965         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1967
1968 2019-02-12  Andy Estes  <aestes@apple.com>
1969
1970         [iOSMac] Enable Parental Controls Content Filtering
1971         https://bugs.webkit.org/show_bug.cgi?id=194521
1972         <rdar://39732376>
1973
1974         Reviewed by Tim Horton.
1975
1976         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1977
1978 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1979
1980         [LFC][IFC] Add intrinsic width support for float boxes.
1981         https://bugs.webkit.org/show_bug.cgi?id=194528
1982
1983         Reviewed by Antti Koivisto.
1984
1985         Expand tests coverage (2 new tests -> 800).
1986         (This is the correct test ordering --runs-singly --child-processes=1)
1987
1988         * LayoutReloaded/misc/LFC-passing-tests.txt:
1989
1990 2019-02-12  Rob Buis  <rbuis@igalia.com>
1991
1992         Implement serializing in MIME type parser
1993         https://bugs.webkit.org/show_bug.cgi?id=193909
1994
1995         Reviewed by Darin Adler.
1996
1997         Add various tests involving upper case, non-ASCII, control/null characters,
1998         various HTTP whitespace, single quotes and an unpaired surrogate.
1999
2000         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2001         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2002         (TestWebKitAPI::serializeIfValid):
2003         (TestWebKitAPI::TEST):
2004
2005 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2006
2007         [Cocoa] Ask platform for generic font family mappings
2008         https://bugs.webkit.org/show_bug.cgi?id=187723
2009         <rdar://problem/41892438>
2010
2011         Reviewed by Brent Fulgham.
2012
2013         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2014
2015         * DumpRenderTree/mac/DumpRenderTree.mm:
2016         (allowedFontFamilySet):
2017         * WebKitTestRunner/mac/TestControllerMac.mm:
2018         (WTR::allowedFontFamilySet):
2019
2020 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2021
2022         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2023         https://bugs.webkit.org/show_bug.cgi?id=193622
2024
2025         Reviewed by Michael Catanzaro.
2026
2027         This adds support for loading content extension rule sets from the JSON files which
2028         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2029         of WKTR for this could be removed, but that is left for a follow-up patch with
2030         cleanups.
2031
2032         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2035         avoid having the null-terminator copied into the result.
2036         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2037         part of the preparations to run a test.
2038         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2039         (WTR::contentExtensionStoreCallback): Added.
2040         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2041         used for content extensions test.
2042         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2043         extensions and compiling the JSON rule set for tests involving content extensions.
2044         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2045         testing and disables content extensions.
2046         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2047         resetContentExtensions().
2048         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2049         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2050         configureContentExtensionForTest(), and userContentController().
2051
2052 2019-02-11  Daniel Bates  <dabates@apple.com>
2053
2054         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2055         https://bugs.webkit.org/show_bug.cgi?id=191446
2056         <rdar://problem/45929460>
2057
2058         Reviewed by Tim Horton.
2059
2060         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2061
2062         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2063         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2064         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2065         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2066         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2067         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2068         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2069         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2070         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2071         (WTR::arrayLength):
2072         (WTR::parseModifierArray):
2073         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2074         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2075         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2076         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2077
2078 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2079
2080         Unreviewed, rolling out r241272 and r241276.
2081         https://bugs.webkit.org/show_bug.cgi?id=194514
2082
2083         Broke the Apple Internal build and the fix requires human
2084         intervention :( (Requested by dydz on #webkit).
2085
2086         Reverted changesets:
2087
2088         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2089         https://bugs.webkit.org/show_bug.cgi?id=191446
2090         https://trac.webkit.org/changeset/241272
2091
2092         "Fix internal iOS build after r241272"
2093         https://bugs.webkit.org/show_bug.cgi?id=191446
2094         https://trac.webkit.org/changeset/241276
2095
2096 2019-02-11  Truitt Savell  <tsavell@apple.com>
2097
2098         Unreviewed, rolling out r241269.
2099
2100         Caused 5 layout tests crashes on Mac WK1
2101
2102         Reverted changeset:
2103
2104         "DumpRenderTree should report unknown options"
2105         https://bugs.webkit.org/show_bug.cgi?id=191303
2106         https://trac.webkit.org/changeset/241269
2107
2108 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2109
2110         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2111         https://bugs.webkit.org/show_bug.cgi?id=194313
2112
2113         Reviewed by Tim Horton.
2114
2115         Add a helper to determine whether the web view is presenting modal UI.
2116
2117         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2118         (WTR::UIScriptController::isPresentingModally const):
2119         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2120         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2121         (WTR::UIScriptController::isPresentingModally const):
2122         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2123         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2124         (WTR::UIScriptController::calendarType const): Deleted.
2125         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2126         (WTR::UIScriptController::isPresentingModally const):
2127         (WTR::UIScriptController::calendarType const):
2128         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2129         (WTR::UIScriptController::calendarType const):
2130
2131 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2132
2133         GCHeapInspector: Show the retained sizes in more places
2134         https://bugs.webkit.org/show_bug.cgi?id=194464
2135
2136         Reviewed by Simon Fraser.
2137
2138         * GCHeapInspector/gc-heap-inspector.html:
2139         * GCHeapInspector/script/interface.js:
2140         (HeapInspectorUtils.humanReadableSize):
2141         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2142         (HeapInspectorUtils.spanForNode.span.span):
2143         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2144         (HeapSnapshotInspector.prototype.buildRoots):
2145
2146 2019-02-11  Daniel Bates  <dabates@apple.com>
2147
2148         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2149         https://bugs.webkit.org/show_bug.cgi?id=191446
2150         <rdar://problem/45929460>
2151
2152         Reviewed by Tim Horton.
2153
2154         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2155
2156         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2157         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2158         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2159         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2160         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2161         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2162         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2163         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2164         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2165         (WTR::arrayLength):
2166         (WTR::parseModifierArray):
2167         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2168         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2169         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2170         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2171
2172 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2173
2174         DumpRenderTree should report unknown options
2175         https://bugs.webkit.org/show_bug.cgi?id=191303
2176
2177         Reviewed by Frédéric Wang.
2178
2179         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2180         to report unknown options.
2181         Added and assigned test options which are currently used in tests.
2182
2183         * DumpRenderTree/TestOptions.cpp:
2184         (TestOptions::TestOptions):
2185
2186 2019-02-11  Truitt Savell  <tsavell@apple.com>
2187
2188         Unreviewed, rolling out r241229.
2189
2190         Revision broke internal builds for watchOS.
2191
2192         Reverted changeset:
2193
2194         "[Cocoa] Ask platform for generic font family mappings"
2195         https://bugs.webkit.org/show_bug.cgi?id=187723
2196         https://trac.webkit.org/changeset/241229
2197
2198 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2199
2200         [WinCairo][MiniBrowser] Basic authentication always fails.
2201         https://bugs.webkit.org/show_bug.cgi?id=194496
2202
2203         Reviewed by Don Olmstead.
2204
2205         * MiniBrowser/win/DialogHelper.h:
2206         (Dialog::getText):
2207
2208 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2209
2210         [GStreamer] GstMappedBuffer testsuite build fails
2211         https://bugs.webkit.org/show_bug.cgi?id=194495
2212
2213         Reviewed by Carlos Garcia Campos.
2214
2215         Fix the build by explicitely adding the gstreamer1.0-audio include
2216         directories to the include path.
2217
2218         * TestWebKitAPI/PlatformGTK.cmake:
2219         * TestWebKitAPI/PlatformWPE.cmake:
2220
2221 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2222
2223         [GTK][WPE] Add enable-javascript-markup setting
2224         https://bugs.webkit.org/show_bug.cgi?id=193439
2225
2226         Reviewed by Michael Catanzaro.
2227
2228         Add test cases to check the new setting.
2229
2230         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2231         (testWebKitSettings):
2232         (testWebKitSettingsJavaScriptMarkup):
2233         (beforeAll):
2234
2235 2019-02-10  Darin Adler  <darin@apple.com>
2236
2237         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2238         https://bugs.webkit.org/show_bug.cgi?id=194485
2239
2240         Reviewed by Daniel Bates.
2241
2242         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2243
2244 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2245
2246         Add more tests for clampTo<>()
2247         https://bugs.webkit.org/show_bug.cgi?id=194462
2248
2249         Reviewed by Geoffrey Garen.
2250
2251         Darin suggested to test the very last floating point number
2252         at the boundaries when truncating to integer.
2253         I added test for max/min and max-1/min-1.
2254
2255         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2256         (TestWebKitAPI::TEST):
2257
2258 2019-02-09  Darin Adler  <darin@apple.com>
2259
2260         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2261         https://bugs.webkit.org/show_bug.cgi?id=194021
2262
2263         Reviewed by Geoffrey Garen.
2264
2265         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2266         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2267         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2268
2269 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2270
2271         [LFC][IFC] Add intrinsic width support for basic inline containers
2272         https://bugs.webkit.org/show_bug.cgi?id=194473
2273
2274         Reviewed by Antti Koivisto.
2275
2276         Expand tests coverage (11 new tests -> 798)
2277
2278         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2279
2280 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2281
2282         Fix MiniBrowser's entitlements
2283         https://bugs.webkit.org/show_bug.cgi?id=192431
2284
2285         Reviewed by Joseph Pecoraro.
2286
2287         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2288         files, making it impossible to load any extension.
2289
2290         * MiniBrowser/MiniBrowser.entitlements:
2291
2292 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2293
2294         [Cocoa] Ask platform for generic font family mappings
2295         https://bugs.webkit.org/show_bug.cgi?id=187723
2296         <rdar://problem/41892438>
2297
2298         Reviewed by Brent Fulgham.
2299
2300         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2301
2302         * DumpRenderTree/mac/DumpRenderTree.mm:
2303         (allowedFontFamilySet):
2304         * WebKitTestRunner/mac/TestControllerMac.mm:
2305         (WTR::allowedFontFamilySet):
2306
2307 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2308
2309         [GTK] Implement back/forward touchpad gesture
2310         https://bugs.webkit.org/show_bug.cgi?id=193919
2311
2312         Reviewed by Michael Catanzaro.
2313
2314         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2315         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2316
2317 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2318
2319         Add SPI to use networking daemon instead of XPC service
2320         https://bugs.webkit.org/show_bug.cgi?id=194427
2321
2322         Reviewed by Geoffrey Garen
2323
2324         * MiniBrowser/MiniBrowser.entitlements:
2325
2326 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-build] Ensure that every builder in config.json has short name
2329         https://bugs.webkit.org/show_bug.cgi?id=194461
2330
2331         Reviewed by Lucas Forschler.
2332
2333         * BuildSlaveSupport/ews-build/loadConfig.py:
2334         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2335
2336 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2337
2338         [ews-build] Add short name to config.json
2339         https://bugs.webkit.org/show_bug.cgi?id=194456
2340
2341         Reviewed by Lucas Forschler.
2342
2343         * BuildSlaveSupport/ews-build/config.json: Added short name.
2344         * BuildSlaveSupport/ews-build/loadConfig.py:
2345         (loadBuilderConfig): Set the short name as the builder description.
2346
2347 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2348
2349         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2350         https://bugs.webkit.org/show_bug.cgi?id=194418
2351
2352         Reviewed by Lucas Forschler.
2353
2354         Do not include errors trying when finding crashlogs at the end of
2355         a run-webkit-tests run since we don't process those errors.
2356
2357         * Scripts/webkitpy/port/darwin.py:
2358         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2359         * Scripts/webkitpy/port/ios_device.py:
2360         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2361         * Scripts/webkitpy/port/watch_device.py:
2362         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2363
2364 2019-02-08  Beth Dakin  <bdakin@apple.com>
2365
2366         Add afterScreenUpdates to WKSnapshotConfiguration
2367         https://bugs.webkit.org/show_bug.cgi?id=194362
2368         -and corresponding-
2369         <rdar://problem/40655528> Please add an "after screen updates" property to 
2370         WKSnapshotConfiguration (to solve blank snapshots)
2371
2372         Reviewed by Tim Horton.
2373
2374         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2375         (TEST):
2376
2377 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2378
2379         clampTo(): do not convert the input to double when dealing with integers
2380         https://bugs.webkit.org/show_bug.cgi?id=194263
2381         <rdar://problem/47692312>
2382
2383         Reviewed by Darin Adler.
2384
2385         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2386         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2387         (TestWebKitAPI::testClampFloatingPointToInteger):
2388         (TestWebKitAPI::testClampSameSignIntegers):
2389         (TestWebKitAPI::testClampUnsignedToSigned):
2390         (TestWebKitAPI::testClampSignedToUnsigned):
2391
2392 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2393
2394         webkitpy: Respect --dedicated-simulators flag
2395         https://bugs.webkit.org/show_bug.cgi?id=194416
2396         <rdar://problem/47894722>
2397
2398         Reviewed by Lucas Forschler.
2399
2400         * Scripts/webkitpy/port/device_port.py:
2401         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2402         available devices can be safely ignored.
2403
2404 2019-02-07  Keith Rollin  <krollin@apple.com>
2405
2406         Remove extra copy of 100x100-red.tga
2407         https://bugs.webkit.org/show_bug.cgi?id=194371
2408         <rdar://problem/47873465>
2409
2410         Reviewed by Said Abou-Hallawa.
2411
2412         In order to help it pass its tests, Bug 194190 added a second copy of
2413         the file 100x100-red.tga. However, it turns out that this additional
2414         file wasn't actually needed, and that that sole previous copy was
2415         sufficient. At the same time, this second copy -- which was copied to
2416         the same location in the build output as the first copy -- now caused
2417         XCBuild to complain because there were two production rules for the
2418         same output file. Address this by removing the newly-added extra copy.
2419
2420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2421         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2422
2423 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2424
2425         Deprecate WKBundlePageSetDefersLoading
2426         https://bugs.webkit.org/show_bug.cgi?id=191394
2427
2428         Reviewed by Dean Jackson.
2429
2430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2431         (WTR::TestRunner::setDefersLoading):
2432
2433 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2434
2435         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2436         https://bugs.webkit.org/show_bug.cgi?id=194391
2437
2438         Reviewed by Antti Koivisto.
2439
2440         * LayoutReloaded/misc/LFC-passing-tests.txt:
2441
2442 2019-02-06  Keith Rollin  <krollin@apple.com>
2443
2444         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2445         https://bugs.webkit.org/show_bug.cgi?id=193975
2446         <rdar://problem/47643306>
2447
2448         Reviewed by Tim Horton.
2449
2450         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2451         the Info.plist file into the bundle. This step is not necessary as the
2452         implicit "bundle up all the build products into a framework" build
2453         phase does this already. Having the Copy Bundle Resources phase do
2454         this causes a conflict under XCBuild, which objects to two build
2455         phases producing the same file (Info.plist). Address this by removing
2456         Info.plist from the Copy Bundle Resources phase.
2457
2458         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2459
2460 2019-02-06  Keith Rollin  <krollin@apple.com>
2461
2462         Really enable the automatic checking and regenerations of .xcfilelists during builds
2463         https://bugs.webkit.org/show_bug.cgi?id=194357
2464         <rdar://problem/47861231>
2465
2466         Reviewed by Chris Dumez.
2467
2468         Bug 194124 was supposed to enable the automatic checking and
2469         regenerating of .xcfilelist files during the build. While related
2470         changes were included in that patch, the change to actually enable the
2471         operation somehow was omitted. This patch actually enables the
2472         operation. The check-xcfilelist.sh scripts now check
2473         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2474         from the checking.
2475
2476         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2477         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2478
2479 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2480
2481         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2482         <https://webkit.org/b/194286>
2483         <rdar://problem/47815558>
2484
2485         Reviewed by Alexey Proskuryakov.
2486
2487         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2488         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2489         WKRetainPtr<> to avoid leaking the WKDataRef.
2490
2491 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2492
2493         Unreviewed, fix a typo
2494
2495         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2496
2497 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2498
2499         [GTK][WPE] force libpsl build to use ICU in jhbuild
2500         https://bugs.webkit.org/show_bug.cgi?id=194288
2501
2502         Reviewed by Carlos Garcia Campos.
2503
2504         * gtk/jhbuild.modules:
2505         Require ICU for libpsl build in jhbuild, like done in WPE.
2506
2507 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2508
2509         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2510         https://bugs.webkit.org/show_bug.cgi?id=194209
2511
2512         Reviewed by Carlos Garcia Campos.
2513
2514         Enhance TestCookieManager to ensure this doesn't happen again.
2515
2516         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2517         (testCookieManagerPersistentStorage):
2518         (beforeAll):
2519
2520 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2521
2522         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2523         https://bugs.webkit.org/show_bug.cgi?id=194324
2524
2525         Reviewed by Andy Estes.
2526
2527         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2528         part of the name is already implicit, since this is in testing code in TestOptions.
2529
2530         * WebKitTestRunner/TestController.cpp:
2531         (WTR::TestController::generateContextConfiguration const):
2532         (WTR::updateTestOptionsFromTestHeader):
2533         * WebKitTestRunner/TestOptions.h:
2534         (WTR::TestOptions::hasSameInitializationOptions const):
2535
2536 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2537
2538         [ews-build] Allow * as platform for builders and workers
2539         https://bugs.webkit.org/show_bug.cgi?id=188533
2540
2541         Reviewed by Lucas Forschler.
2542
2543         * BuildSlaveSupport/ews-build/loadConfig.py:
2544         (checkWorkersAndBuildersForConsistency):
2545
2546 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2547
2548         [ews-build] Add few bots to config.json
2549         https://bugs.webkit.org/show_bug.cgi?id=194304
2550
2551         Reviewed by Lucas Forschler.
2552
2553         * BuildSlaveSupport/ews-build/config.json:
2554
2555 2019-02-05  Keith Rollin  <krollin@apple.com>
2556
2557         Enable the automatic checking and regenerations of .xcfilelists during builds
2558         https://bugs.webkit.org/show_bug.cgi?id=194124
2559         <rdar://problem/47721277>
2560
2561         Reviewed by Tim Horton.
2562
2563         Bug 193790 add a facility for checking -- during build time -- that
2564         any needed .xcfilelist files are up-to-date and for updating them if
2565         they are not. This facility was initially opt-in by setting
2566         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2567         the process seemed robust. Its now time to enable this facility and
2568         make it opt-out. If there is a need to disable this facility, set and
2569         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2570         running `make` or `build-webkit`, or before running Xcode from the
2571         command line.
2572
2573         Additionally, remove the step that generates a list of source files
2574         going into the UnifiedSources build step. It's only necessarily to
2575         specify Sources.txt and SourcesCocoa.txt as inputs.
2576
2577         * Scripts/generate-xcfilelists:
2578
2579 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2580
2581         [GTK][WPE] force libpsl build to use ICU in jhbuild
2582         https://bugs.webkit.org/show_bug.cgi?id=194288
2583
2584         Reviewed by Philippe Normand.
2585
2586         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2587         This can cause build failures if libidn is detected but libunistring is not available.
2588
2589         Make sure that ICU is used for runtime and builtin PSL data.
2590
2591         * gtk/jhbuild.modules:
2592         * wpe/jhbuild.modules:
2593
2594 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2595
2596         [ews-app] Modified timestamp should be updated on updating data
2597         https://bugs.webkit.org/show_bug.cgi?id=194295
2598
2599         Reviewed by Lucas Forschler.
2600
2601         * BuildSlaveSupport/ews-app/ews/models/build.py:
2602         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2603         * BuildSlaveSupport/ews-app/ews/models/step.py:
2604
2605 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2606
2607         Unreviewed, rolling out r240742.
2608
2609         Causes crashes on iOS simulator.
2610
2611         Reverted changeset:
2612
2613         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2614         not focused in a content-editable element"
2615         https://bugs.webkit.org/show_bug.cgi?id=192824
2616         https://trac.webkit.org/changeset/240742
2617
2618 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2619
2620         run-webkit-tests emits message "...running None" when running tests
2621         https://bugs.webkit.org/show_bug.cgi?id=194133
2622         <rdar://problem/47724738>
2623
2624         Reviewed by Lucas Forschler.
2625
2626         * Scripts/webkitpy/xcode/device_type.py:
2627         (DeviceType.__str__): Use both version mapping tables and use just the variant
2628         name if no version name is available.
2629         * Scripts/webkitpy/xcode/device_type_unittest.py:
2630         (DeviceTypeTest):
2631         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2632         an associated named.
2633
2634 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2635
2636         [WPE] require python3-setuptools for meson build in jhbuild
2637         https://bugs.webkit.org/show_bug.cgi?id=194287
2638
2639         Reviewed by Philippe Normand.
2640
2641         python3-setuptools is needed to build meson in jhbuild.
2642         It is already required by the GTK port.
2643
2644         * wpe/install-dependencies:
2645
2646 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2647
2648         [ews-app] Add method to save BuilderMapping to database
2649         https://bugs.webkit.org/show_bug.cgi?id=194264
2650
2651         Reviewed by Lucas Forschler.
2652
2653         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2654         (BuilderMapping.__str__):
2655         (BuilderMapping):
2656         (BuilderMapping.save_mapping):
2657         (BuilderMapping.update_mapping):
2658         (BuilderMapping.get_existing_mapping):
2659         (BuilderMapping.is_valid_mapping):
2660
2661 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2662
2663         [ews-app] Add timestamp fields for BuilderMappings
2664         https://bugs.webkit.org/show_bug.cgi?id=194266
2665
2666         Reviewed by Lucas Forschler.
2667
2668         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2669         (BuilderMapping):
2670
2671 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2672
2673         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2674         https://bugs.webkit.org/show_bug.cgi?id=174816
2675
2676         Reviewed by Michael Catanzaro.
2677
2678         Add tests for webkit_uri_for_display().
2679
2680         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2681         (testURIForDisplayUnaffected):
2682         (testURIForDisplayAffected):
2683         (beforeAll):
2684         (afterAll):
2685         * TestWebKitAPI/glib/CMakeLists.txt:
2686
2687 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2688
2689         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2690         https://bugs.webkit.org/show_bug.cgi?id=194158
2691         <rdar://problem/47737268>
2692
2693         Rubber-stamped by Aakash Jain.
2694
2695         * Scripts/webkitpy/port/device_port.py:
2696         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2697
2698 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2699
2700         [CG] Enable setAdditionalSupportedImageTypes for WK1
2701         https://bugs.webkit.org/show_bug.cgi?id=194190
2702
2703         Reviewed by Tim Horton.
2704
2705         Add a test similar to the one under WebKit Cocoa but make it create a
2706         WebView instead of a WKWebView.
2707
2708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2709         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2710         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2711         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2712         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2713         (TestWebKitAPI::runTest):
2714         (TestWebKitAPI::TEST):
2715
2716 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2717
2718         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2719         https://bugs.webkit.org/show_bug.cgi?id=194168
2720
2721         Reviewed by Simon Fraser.
2722
2723         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2724
2725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2726         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2727         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2728         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2729         (TEST):
2730         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2731         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2732
2733 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2734
2735         REGRESSION (r237269): webkit-patch what-broke is broken 
2736         https://bugs.webkit.org/show_bug.cgi?id=193025
2737
2738         Reviewed by Aakash Jain.
2739
2740         * Scripts/webkitpy/common/host.py:
2741         (Host.buildbot):
2742         (Host.bugzilla): Renamed to 'buildbot'.
2743
2744 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2745
2746         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2747         https://bugs.webkit.org/show_bug.cgi?id=194207
2748
2749         Reviewed by Tim Horton.
2750
2751         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2752         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2753         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2754         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2755         start and delete forwards to remove the original attachment.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2758         (TestWebKitAPI::TEST):
2759
2760 2019-02-04  Youenn Fablet  <youenn@apple.com>
2761
2762         Capture state should be managed consistently when doing process swapping
2763         https://bugs.webkit.org/show_bug.cgi?id=194122
2764         <rdar://problem/47609293>
2765
2766         Reviewed by Eric Carlson.
2767
2768         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2769         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2770         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2771         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2772         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2773         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2774         (WTR::TestRunner::isDoingMediaCapture const):
2775         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2776         * WebKitTestRunner/TestController.cpp:
2777         (WTR::TestController::isDoingMediaCapture const):
2778         * WebKitTestRunner/TestController.h:
2779         * WebKitTestRunner/TestInvocation.cpp:
2780         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2781         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2782         (WTR::TestController::isDoingMediaCapture const):
2783
2784 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2785
2786         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2787         https://bugs.webkit.org/show_bug.cgi?id=194142
2788
2789         Reviewed by Ross Kirsling.
2790
2791         There three 'separator' variables in TestController.cpp. Renamed
2792         it 'pathSeparator', and unified them.
2793
2794         * WebKitTestRunner/TestController.cpp:
2795         (WTR::TestController::generateContextConfiguration const):
2796         (WTR::createTestURL):
2797         (WTR::TestController::platformAdjustContext):
2798
2799 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2800
2801         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2802         https://bugs.webkit.org/show_bug.cgi?id=194198
2803
2804         Reviewed by Antti Koivisto.
2805
2806         No need to set the banner heights on navigation now, since Page stores them.
2807
2808         * MiniBrowser/mac/WK2BrowserWindowController.m:
2809         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2810
2811 2019-02-03  John Wilander  <wilander@apple.com>
2812
2813         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2814         https://bugs.webkit.org/show_bug.cgi?id=194104
2815         <rdar://problem/47649991>
2816
2817         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2818
2819         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2820         (TestWebKitAPI::TEST):
2821             Changed numeric types from unsigned short to uint32_t.
2822
2823 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2824
2825         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2826         <https://webkit.org/b/194178>
2827         <rdar://problem/47753473>
2828
2829         Reviewed by Alexey Proskuryakov.
2830
2831         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2832         (WTR::uninstallFakeHelvetica): Pass nullptr into
2833         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2834
2835 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2836
2837         [LFC] Initialize ICB's style with fixed width/height.
2838         https://bugs.webkit.org/show_bug.cgi?id=194188
2839
2840         Reviewed by Antti Koivisto.
2841
2842         * LayoutReloaded/misc/LFC-passing-tests.txt:
2843
2844 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2845
2846         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2847         https://bugs.webkit.org/show_bug.cgi?id=194185
2848
2849         Reviewed by Antti Koivisto.
2850
2851         * LayoutReloaded/misc/LFC-passing-tests.txt:
2852
2853 2018-12-16  Darin Adler  <darin@apple.com>
2854
2855         Convert additional String::format clients to alternative approaches
2856         https://bugs.webkit.org/show_bug.cgi?id=192746
2857
2858         Reviewed by Alexey Proskuryakov.
2859
2860         * WebKitTestRunner/TestController.cpp:
2861         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2862         as an intermediate in code that ultimately constructs a WTF::String.
2863         (WTR::userMediaOriginHash): Use makeString.
2864         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2865         (WTR::TestController::didPerformClientRedirect): Ditto.
2866         (WTR::TestController::didPerformServerRedirect): Ditto.
2867         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2868
2869 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2870
2871         [ews-build] Add unit test to verify builder keys
2872         https://bugs.webkit.org/show_bug.cgi?id=194152
2873
2874         Reviewed by Lucas Forschler.
2875
2876         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2877         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2878
2879 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2880
2881         [LFC] Expand tests coverage (12 new tests -> 787)
2882
2883         Unreviewed test gardening.
2884
2885         * LayoutReloaded/misc/LFC-passing-tests.txt:
2886
2887 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2888
2889         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2890         https://bugs.webkit.org/show_bug.cgi?id=194163
2891
2892         Reviewed by Simon Fraser.
2893
2894         775
2895
2896         * LayoutReloaded/misc/LFC-passing-tests.txt:
2897
2898 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2899
2900         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2901         https://bugs.webkit.org/show_bug.cgi?id=194140
2902         <rdar://problem/47728098>
2903
2904         Reviewed by Tim Horton.
2905
2906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2907         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2908         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2909
2910         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2911         test to induce an IPC deadlock when presenting a modal alert during touch start.
2912
2913         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2914         * WebKitTestRunner/TestController.cpp:
2915         (WTR::runJavaScriptAlert):
2916
2917         Add a client callback function for running JavaScript alerts.
2918
2919         (WTR::TestController::createOtherPage):
2920         (WTR::TestController::generateContextConfiguration const):
2921
2922         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2923         the fix in this patch.
2924
2925         (WTR::TestController::createWebViewWithOptions):
2926
2927         Plumb TestOptions to generateContextConfiguration.
2928
2929         (WTR::TestController::resetPreferencesToConsistentValues):
2930         (WTR::TestController::resetStateToConsistentValues):
2931         (WTR::updateTestOptionsFromTestHeader):
2932         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2933         (WTR::TestController::handleJavaScriptAlert):
2934         * WebKitTestRunner/TestController.h:
2935         * WebKitTestRunner/TestInvocation.cpp:
2936         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2937         * WebKitTestRunner/TestOptions.h:
2938         (WTR::TestOptions::hasSameInitializationOptions const):
2939
2940 2019-02-01  Chris Dumez  <cdumez@apple.com>
2941
2942         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2943         https://bugs.webkit.org/show_bug.cgi?id=193740
2944         <rdar://problem/47527267>
2945
2946         Reviewed by Alex Christensen.
2947
2948         Add API test coverage.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2951
2952 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2953
2954         [ews-app] Add display name field to BuilderMapping model
2955         https://bugs.webkit.org/show_bug.cgi?id=194153
2956
2957         Reviewed by Lucas Forschler.
2958
2959         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2960         (BuilderMapping):
2961
2962 2019-02-01  Youenn Fablet  <youenn@apple.com>
2963
2964         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2965         https://bugs.webkit.org/show_bug.cgi?id=194155
2966
2967         Reviewed by Eric Carlson.
2968
2969         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2970         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2971         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2972
2973 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2974
2975         [LFC] Adjust replaced element's intrinsic ratio
2976         https://bugs.webkit.org/show_bug.cgi?id=194154
2977
2978         Reviewed by Antti Koivisto.
2979
2980         761
2981
2982         * LayoutReloaded/misc/LFC-passing-tests.txt:
2983
2984 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2985
2986         [WPE] Show test results in minibrowser
2987         https://bugs.webkit.org/show_bug.cgi?id=194150
2988
2989         Reviewed by Žan Doberšek.
2990
2991         * Scripts/webkitpy/port/wpe.py:
2992         (WPEPort.show_results_html_file):
2993
2994 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2995
2996         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2997         https://bugs.webkit.org/show_bug.cgi?id=194151
2998
2999         Reviewed by Žan Doberšek.
3000
3001         ALT + <- go back
3002         ALT + -> go forward
3003
3004         * MiniBrowser/wpe/main.cpp:
3005         (main):
3006
3007 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3008
3009         [LFC] Set intrinsic size on Layout::Replaced
3010         https://bugs.webkit.org/show_bug.cgi?id=194139
3011
3012         Reviewed by Antti Koivisto.
3013
3014         744
3015
3016         * LayoutReloaded/misc/LFC-passing-tests.txt:
3017
3018 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3019
3020         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3021         https://bugs.webkit.org/show_bug.cgi?id=194146
3022
3023         Reviewed by Xabier Rodriguez-Calvar.
3024
3025         It allows to open relative paths.
3026
3027         * MiniBrowser/wpe/main.cpp:
3028         (main):
3029
3030 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3031
3032         Update flakiness dashboard configuration after recent queue changes
3033         https://bugs.webkit.org/show_bug.cgi?id=194127
3034
3035         Rubber-stamped by Aakash Jain.
3036
3037         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3038
3039         * TestResultServer/static-dashboards/builders.jsonp:
3040
3041 2019-01-31  Youenn Fablet  <youenn@apple.com>
3042
3043         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3044         https://bugs.webkit.org/show_bug.cgi?id=194106
3045         <rdar://problem/47676333>
3046
3047         Reviewed by Ryosuke Niwa.
3048
3049         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3050         (TestWebKitAPI::didFinishNavigation):
3051         (TestWebKitAPI::TEST):
3052         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3053
3054 2019-01-31  Chris Dumez  <cdumez@apple.com>
3055
3056         Page zoom level is lost after a process swap or a crash
3057         https://bugs.webkit.org/show_bug.cgi?id=194105
3058         <rdar://problem/47610781>
3059
3060         Reviewed by Alex Christensen.
3061
3062         Add API test coverage.
3063
3064         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3065         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3066
3067 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3068
3069         Revert r238819 which is unneeded and caused a performance regression.
3070         https://bugs.webkit.org/show_bug.cgi?id=192272
3071         <rdar://problem/46664625>
3072
3073         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3074         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3075         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3076
3077 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3078
3079         Formalize WebKitAdditions mechanism of LoadOptimizer
3080         https://bugs.webkit.org/show_bug.cgi?id=193886
3081         <rdar://problem/47696809>
3082
3083         Reviewed by Brent Fulgham.
3084
3085         * MiniBrowser/MiniBrowser.entitlements:
3086         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3087
3088 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3089
3090         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3091         https://bugs.webkit.org/show_bug.cgi?id=194090
3092
3093         Reviewed by Antti Koivisto.
3094
3095         * LayoutReloaded/misc/LFC-passing-tests.txt:
3096
3097 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3098
3099         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3100         https://bugs.webkit.org/show_bug.cgi?id=194074
3101
3102         Reviewed by Antti Koivisto.
3103
3104         * LayoutReloaded/misc/LFC-passing-tests.txt:
3105
3106 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3107
3108         [LFC][BFC] Add support for block level replaced box.
3109         https://bugs.webkit.org/show_bug.cgi?id=194071
3110
3111         Reviewed by Antti Koivisto.
3112
3113         * LayoutReloaded/misc/LFC-passing-tests.txt:
3114
3115 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3116
3117         Fix WebKitTestRunner's testPath with Windows full paths
3118         https://bugs.webkit.org/show_bug.cgi?id=194012
3119
3120         Reviewed by Alex Christensen.
3121
3122         updateTestOptionsFromTestHeader failed to open test files because
3123         testPath returned wrong file paths. It returned a path "/C:/..."
3124         if a URL "file:///C:/..." was given.
3125
3126         * WebKitTestRunner/TestController.cpp:
3127         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3128
3129 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [WPE] Bump font related dependencies to match the GTK+ port
3132         https://bugs.webkit.org/show_bug.cgi?id=194017
3133
3134         Reviewed by Žan Doberšek.
3135
3136         * wpe/jhbuild.modules:
3137         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3138         * wpe/patches/icudata-stdlibs.patch: Added.
3139
3140 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3141
3142         Enable swipe tests on iOS
3143         https://bugs.webkit.org/show_bug.cgi?id=194076
3144
3145         Reviewed by Geoffrey Garen.
3146
3147         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3148         it causes a debug assertion failure in runUIScript.
3149
3150         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3151         (WTR::UIScriptController::beginBackSwipe):
3152         (WTR::UIScriptController::completeBackSwipe):
3153
3154 2019-01-30  Keith Rollin  <krollin@apple.com>
3155
3156         Use correct printf format specifier
3157         https://bugs.webkit.org/show_bug.cgi?id=194062
3158         <rdar://problem/47686167>
3159
3160         Reviewed by Alexey Proskuryakov.
3161
3162         LayoutTestSpellChecker.mm is trying to format a variable of type
3163         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3164         actually an unsigned long long. Fix this by formatting with %llu.
3165
3166         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3167         (-[LayoutTestTextCheckingResult description]):
3168
3169 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3170
3171         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3172         https://bugs.webkit.org/show_bug.cgi?id=193979
3173
3174         Reviewed by Wenson Hsieh.
3175
3176         Fix the test for iOS. Make the test work with iOS UA string.
3177
3178         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3179
3180 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3181
3182         Replace High Sierra LLINT CLoop bot due to hardware failure
3183         https://bugs.webkit.org/show_bug.cgi?id=194066
3184
3185         Reviewed by Aakash Jain.
3186
3187         * BuildSlaveSupport/build.webkit.org-config/config.json:
3188
3189 2019-01-30  Keith Rollin  <krollin@apple.com>
3190
3191         [NSDragItem init] is unavailable
3192         https://bugs.webkit.org/show_bug.cgi?id=194059
3193         <rdar://problem/47685715>
3194
3195         Reviewed by Wenson Hsieh.
3196
3197         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3198         DumpRenderTree and TestWebKitAPI, which both try to create an
3199         NSDragItem in a manner that invokes this method. Address this by using
3200         -initWithPasteboardWriter instead.
3201
3202         Note that the parameter passed to initWithPasteboardWriter is likely
3203         incorrect. In both cases, the object passed does not conform to
3204         NSPasteboardWriting. However, with this fix, we're no worse off than
3205         before, and can now perform builds with newer compilers and SDKs until
3206         a real fix can be crafted. That work is tracked in
3207         https://bugs.webkit.org/show_bug.cgi?id=194060
3208
3209         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3210         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3211         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3212         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3213
3214 2019-01-30  Daniel Bates  <dabates@apple.com>
3215
3216         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3217         https://bugs.webkit.org/show_bug.cgi?id=192824
3218         <rdar://problem/47100332>
3219
3220         Reviewed by Wenson Hsieh.
3221
3222         Fix a bug where the wrong usage code was used for F13 thru F24.
3223
3224         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3225         (keyCodeForDOMFunctionKey):
3226
3227 2019-01-30  Chris Dumez  <cdumez@apple.com>
3228
3229         Regression(PSON) Load hang can occur on history navigation
3230         https://bugs.webkit.org/show_bug.cgi?id=194030
3231         <rdar://problem/47656939>
3232
3233         Reviewed by Antti Koivisto.
3234
3235         Add API test coverage.
3236
3237         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3238
3239 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3240
3241         [LFC] Expand tests coverage.
3242
3243         Unreviewed test gardening.
3244
3245         * LayoutReloaded/misc/LFC-passing-tests.txt:
3246
3247 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3248
3249         [Flatpak] Add openjpeg support
3250         https://bugs.webkit.org/show_bug.cgi?id=194019
3251
3252         Reviewed by Michael Catanzaro.
3253
3254         * flatpak/org.webkit.CommonModules.yaml:
3255
3256 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3257
3258         Unreviewed, rolling out r240708.
3259         https://bugs.webkit.org/show_bug.cgi?id=194022
3260
3261         It broke WPE build (Requested by KaL on #webkit).
3262
3263         Reverted changeset:
3264
3265         "[WPE] Bump font related dependencies to match the GTK+ port"
3266         https://bugs.webkit.org/show_bug.cgi?id=194017
3267         https://trac.webkit.org/changeset/240708
3268
3269 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3270
3271         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3272         https://bugs.webkit.org/show_bug.cgi?id=194001
3273
3274         Reviewed by Antti Koivisto.
3275
3276         * LayoutReloaded/misc/LFC-passing-tests.txt:
3277
3278 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3279
3280         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3281         https://bugs.webkit.org/show_bug.cgi?id=194020
3282
3283         Reviewed by Antti Koivisto.
3284
3285         * LayoutReloaded/misc/LFC-passing-tests.txt:
3286
3287 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3288
3289         AX: Support color well on iOS
3290         https://bugs.webkit.org/show_bug.cgi?id=194010
3291
3292         Reviewed by Joanmarie Diggs.
3293
3294         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3295         (WTR::AccessibilityUIElement::stringAttributeValue):
3296
3297 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3298
3299         [WPE] Bump font related dependencies to match the GTK+ port
3300         https://bugs.webkit.org/show_bug.cgi?id=194017
3301
3302         Reviewed by Žan Doberšek.
3303
3304         * wpe/jhbuild.modules:
3305         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3306         * wpe/patches/icudata-stdlibs.patch: Added.
3307
3308 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3309
3310         [Mac] Update window scale API usage
3311         https://bugs.webkit.org/show_bug.cgi?id=193991
3312         rdar://problem/47614795
3313
3314         Reviewed by Tim Horton.
3315
3316         * DumpRenderTree/mac/DumpRenderTree.mm:
3317         (changeWindowScaleIfNeeded):
3318         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3319         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3320         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3321
3322 2019-01-29  Chris Dumez  <cdumez@apple.com>
3323
3324         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3325         https://bugs.webkit.org/show_bug.cgi?id=193977
3326         <rdar://problem/47643716>
3327
3328         Reviewed by Geoff Garen.
3329
3330         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3331         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3332         to the previous provisional committing *before* we make the last load. 
3333
3334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3335
3336 2019-01-29  Youenn Fablet  <youenn@apple.com>
3337
3338         Adopt new SPI to evaluate server certificate trust
3339         https://bugs.webkit.org/show_bug.cgi?id=193355
3340
3341         Reviewed by Alex Christensen.
3342
3343         Add infrastructure to handle HTTPS server trust evaluation testing.
3344
3345         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3347         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3348         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3349         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3350         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3351         * WebKitTestRunner/TestController.cpp:
3352         (WTR::TestController::resetPreferencesToConsistentValues):
3353         (WTR::TestController::didReceiveAuthenticationChallenge):
3354         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3355         * WebKitTestRunner/TestController.h:
3356         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3357         * WebKitTestRunner/TestInvocation.cpp:
3358         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3359         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3360         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3361
3362 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3363
3364         [ews-build] Add build step to print bot Configuration
3365         https://bugs.webkit.org/show_bug.cgi?id=193887
3366
3367         Reviewed by Lucas Forschler.
3368
3369         * BuildSlaveSupport/ews-build/steps.py:
3370         (PrintConfiguration): Build step to print configuration.
3371         * BuildSlaveSupport/ews-build/factories.py:
3372
3373 2019-01-29  Chris Dumez  <cdumez@apple.com>
3374
3375         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3376         https://bugs.webkit.org/show_bug.cgi?id=193967
3377         <rdar://problem/47635348>
3378
3379         Reviewed by Alex Christensen.
3380
3381         Add API test coverage.
3382
3383         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3384         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3385
3386 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3387
3388         [ews-app] Handle incoming results data
3389         https://bugs.webkit.org/show_bug.cgi?id=193973
3390
3391         Reviewed by Lucas Forschler.
3392
3393         * BuildSlaveSupport/ews-app/ews/views/results.py:
3394
3395 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3396
3397         [ews-app] Make the results url generic
3398         https://bugs.webkit.org/show_bug.cgi?id=193928
3399
3400         Reviewed by Lucas Forschler.
3401
3402         * BuildSlaveSupport/ews-app/ews/urls.py:
3403
3404 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3405
3406         [ews-build] Configure buildbot to send events to ews-app
3407         https://bugs.webkit.org/show_bug.cgi?id=193968
3408
3409         Reviewed by Lucas Forschler.
3410
3411         * BuildSlaveSupport/ews-build/events.py: Added.
3412         * BuildSlaveSupport/ews-build/master.cfg:
3413
3414 2019-01-29  Keith Rollin  <krollin@apple.com>
3415
3416         Add .xcfilelists to Run Script build phases
3417         https://bugs.webkit.org/show_bug.cgi?id=193792
3418         <rdar://problem/47201785>
3419
3420         Reviewed by Alex Christensen.
3421
3422         As part of supporting XCBuild, update the necessary Run Script build
3423         phases in their Xcode projects to refer to their associated
3424         .xcfilelist files.
3425
3426         Note that the addition of these files bumps the Xcode project version
3427         number to something that's Xcode 10 compatible. This change means that
3428         older versions of the Xcode IDE can't read these projects. Nor can it
3429         fully load workspaces that refer to these projects (the updated
3430         projects are shown as non-expandable placeholders). `xcodebuild` can
3431         still build these projects; it's just that the IDE can't open them.
3432
3433         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3434         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3435
3436 2019-01-29  John Wilander  <wilander@apple.com>
3437
3438         Add data abstraction and validation for Ad Click Attribution
3439         https://bugs.webkit.org/show_bug.cgi?id=193916
3440         <rdar://problem/47603481>
3441
3442         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3443
3444         Ad click attribution has two steps. First, the storage of an ad
3445         campaign ID for a click that takes the user to a destination
3446         site. Second, a conversion on the destination site that can be
3447         attributed to the ad click.
3448
3449         This patch adds a class that represents a request for ad click
3450         attribution. Validation makes sure that the bits of entropy
3451         reported through this mechanism is limited.
3452
3453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3454         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3455         (TestWebKitAPI::TEST):
3456
3457 2019-01-29  Chris Dumez  <cdumez@apple.com>
3458
3459         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3460         https://bugs.webkit.org/show_bug.cgi?id=193932
3461         <rdar://problem/47598947>
3462
3463         Reviewed by Brady Eidson.
3464
3465         Add API test coverage.
3466
3467         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3468
3469 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3470
3471         Adding new passing LFC tests.
3472
3473         Unreviewed test gardening.
3474
3475         * LayoutReloaded/misc/LFC-passing-tests.txt:
3476
3477 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3478
3479         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3480         https://bugs.webkit.org/show_bug.cgi?id=193964
3481
3482         Reviewed by Antti Koivisto.
3483
3484         * LayoutReloaded/misc/LFC-passing-tests.txt:
3485
3486 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3487
3488         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3489         https://bugs.webkit.org/show_bug.cgi?id=193954
3490
3491         Reviewed by Antti Koivisto.
3492
3493         * LayoutReloaded/misc/LFC-passing-tests.txt:
3494
3495 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3496
3497         WebDriver: add support for running subtests
3498         https://bugs.webkit.org/show_bug.cgi?id=193904
3499
3500         Reviewed by Michael Catanzaro.
3501
3502         pytest already supports it by passing test.py::subtest, so we can do the same.
3503
3504         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3505         (get_item_name): Made this global.
3506         (CollectRecorder.__init__): Receive the parameter to ignore.
3507         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3508         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3509         (collect): Add parameter to ignore.
3510         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3511         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3512         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3513         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3514         (WebDriverTestRunnerSelenium.run): Ditto.
3515         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3516         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3517         (WebDriverTestRunnerW3C.run): Ditto.
3518
3519 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3520
3521         User agent string override for navigator.userAgent should be site specific quirks
3522         https://bugs.webkit.org/show_bug.cgi?id=193950
3523
3524         Reviewed by Brent Fulgham.
3525
3526         Updated per the _WKWebsitePolicies rename.
3527
3528         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3529         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3530
3531 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3532
3533         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3534         https://bugs.webkit.org/show_bug.cgi?id=193941
3535
3536         Reviewed by Alex Christensen.
3537
3538         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3539         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3540         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3541         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3542         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3543         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3544         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3545         * TestWebKitAPI/Tests/WTF/Time.cpp:
3546         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3547         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3548         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3549         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3550
3551 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3552
3553         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3554
3555         * Scripts/webkitpy/common/config/contributors.json:
3556
3557 2019-01-28  Andy Estes  <aestes@apple.com>
3558
3559         [watchOS] Enable Parental Controls content filtering
3560         https://bugs.webkit.org/show_bug.cgi?id=193939
3561         <rdar://problem/46641912>
3562
3563         Reviewed by Ryosuke Niwa.
3564
3565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3566
3567 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3568
3569         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3570         <https://webkit.org/b/193884>
3571
3572         Reviewed by Jiewen Tan.
3573
3574         * Scripts/webkitpy/style/checkers/cpp.py:
3575         (check_language): Add LocalAuthentication to
3576         `frameworks_with_soft_links`.
3577
3578 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3579
3580         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3581         https://bugs.webkit.org/show_bug.cgi?id=193891
3582
3583         Reviewed by Ross Kirsling.
3584
3585         There were three problems in window sizes of WebView and the host window.
3586         1. The sizes of pixel image output were incorrect.
3587         2. The host window is going to appear after window.resize was invoked.
3588         3. window.resize resized only the host window, not WebView.
3589
3590         This change solves them with a following approach.
3591         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3592         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3593            as well as DumpRenderTree in order to match the client area and the window area.
3594         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3595         d. PlatformWebView::setWindowFrame changes both window sizes.
3596         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3597
3598         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3599         (WTR::PlatformWebView::PlatformWebView): Create the host window
3600         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3601         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3602         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3603
3604 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3605
3606         [ews-app] Add method to save Step data to database
3607         https://bugs.webkit.org/show_bug.cgi?id=193890
3608
3609         Reviewed by Lucas Forschler.
3610
3611         * BuildSlaveSupport/ews-app/ews/models/step.py:
3612         (Step.save_step): Method to save step data.
3613         (Step.update_step): Method to update step data.
3614         (Step.get_existing_step): Method to fetch existing step from database.
3615         (Step.is_valid_result): Method to validate valid step result.
3616
3617 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3618
3619         [ews-app] Add method to save Build data to database
3620         https://bugs.webkit.org/show_bug.cgi?id=193735
3621
3622         Reviewed by Lucas Forschler.
3623
3624         * BuildSlaveSupport/ews-app/ews/models/build.py:
3625         (Build.save_build): Method to save build information to database.
3626         (Build.get_existing_build): Method to fetch existing build from database.
3627         (Build.is_valid_result): Method to validate build result.
3628         * BuildSlaveSupport/ews-app/ews/common/util.py:
3629         (is_valid_int_id): Method to validate valid id.
3630
3631 2019-01-28  Chris Dumez  <cdumez@apple.com>
3632
3633         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3634         https://bugs.webkit.org/show_bug.cgi?id=193915
3635         <rdar://problem/47560907>
3636
3637         Reviewed by Alex Christensen.
3638
3639         Add API test coverage.
3640
3641         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3642
3643 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3644
3645         [ews-app] Rename id variables
3646         https://bugs.webkit.org/show_bug.cgi?id=193883
3647
3648         Reviewed by Lucas Forschler.
3649
3650         * BuildSlaveSupport/ews-app/ews/models/build.py:
3651         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3652         * BuildSlaveSupport/ews-app/ews/models/step.py:
3653         * BuildSlaveSupport/ews-app/ews/urls.py:
3654         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3655         * BuildSlaveSupport/ews-app/ews/views/results.py:
3656         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3657
3658 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3659
3660         [ews-app] Allow certain fields to be empty
3661         https://bugs.webkit.org/show_bug.cgi?id=193892
3662
3663         Reviewed by Lucas Forschler.
3664
3665         * BuildSlaveSupport/ews-app/ews/models/build.py:
3666         * BuildSlaveSupport/ews-app/ews/models/step.py:
3667
3668 2019-01-28  Rob Buis  <rbuis@igalia.com>
3669
3670         Update MIME type parser
3671         https://bugs.webkit.org/show_bug.cgi?id=180526
3672
3673         Reviewed by Frédéric Wang.
3674
3675         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3676         (TestWebKitAPI::TEST):
3677
3678 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3679
3680         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3681         https://bugs.webkit.org/show_bug.cgi?id=193896
3682
3683         Reviewed by Antti Koivisto.
3684
3685         * LayoutReloaded/misc/LFC-passing-tests.txt:
3686
3687 2018-12-15  Darin Adler  <darin@apple.com>
3688
3689         Replace many uses of String::format with more type-safe alternatives
3690         https://bugs.webkit.org/show_bug.cgi?id=192742
3691
3692         Reviewed by Mark Lam.
3693
3694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3695         (WTR::cacheTestRunnerCallback): Use makeString.
3696         * WebKitTestRunner/TestController.cpp:
3697         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3698         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3699
3700 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3701
3702         Use a load optimizer for some sites
3703         https://bugs.webkit.org/show_bug.cgi?id=193881
3704         <rdar://problem/46325455>
3705
3706         Reviewed by Brent Fulgham.
3707
3708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3709         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3710
3711 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3712
3713         AX: Introduce a static accessibility tree
3714         https://bugs.webkit.org/show_bug.cgi?id=193348
3715         <rdar://problem/47203295>
3716
3717         Reviewed by Ryosuke Niwa.