Replace tools32 folder with tools and update WebKit Windows solution accordingly.
[WebKit-https.git] / Tools / ChangeLog
1 2013-06-18  Roger Fong  <roger_fong@apple.com>
2
3         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
4         <rdar://problem/14118143>.
5
6         Rubberstamped by Brent Fulgham.
7
8         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
9         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
10         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
11         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
12         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
13         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
14         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
15         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
16         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
17         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
18         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
19         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
20         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
21         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
22         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
23         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
24         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
25         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
26         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
27         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
28         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
29         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
30         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
31         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
32         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
33         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
34         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
35         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
36         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
37         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
38         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
39         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
40         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
41         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
42         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
43         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
44         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
45         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
46         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
47         * win/record-memory/record-memory.vcxproj:
48         * win/record-memory/record-memoryDebug.props:
49         * win/record-memory/record-memoryDebugWinCairo.props:
50         * win/record-memory/record-memoryProduction.props:
51         * win/record-memory/record-memoryRelease.props:
52         * win/record-memory/record-memoryReleaseWinCairo.props:
53
54 2013-06-17  Kangil Han  <kangil.han@samsung.com>
55
56         Unreviewed. Add my email to a DOM watchlist.
57
58         * Scripts/webkitpy/common/config/watchlist:
59
60 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
61
62         Unreviewed GTK gardening.
63
64         * Scripts/run-gtk-tests:
65         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
66
67 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
68
69         Unreviewed. Reorder my email addresses.
70         https://bugs.webkit.org/show_bug.cgi?id=100122
71
72         * Scripts/webkitpy/common/config/contributors.json:
73
74 2013-06-14  Enrica Casucci  <enrica@apple.com>
75
76         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
77         https://bugs.webkit.org/show_bug.cgi?id=117647
78         <rdar://problem/13881024>
79
80         Reviewed by Darin Adler.
81         
82         The test now uses content with a selection and tests both
83         forwards and backward find as well as the case of a find
84         that has no matches after the user selection.
85
86         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
87         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
88         (TestWebKitAPI::didFindStringMatches):
89         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
90
91 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
92
93         Remove myself from Qt build system watchlist
94
95         Reviewed by Simon Hausmann.
96
97         * Scripts/webkitpy/common/config/watchlist:
98
99 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
100
101         [Qt][Mac] Disable QTKit video on OS X.
102         https://bugs.webkit.org/show_bug.cgi?id=117591
103
104         Reviewed by Tor Arne Vestbø.
105
106         Deployment of Qt binaries to different Mac OS X
107         platform version makes it impossible to link against
108         the correct version of the WebKitSystemInterface library,
109         so we need to disable QTKit for media elements.
110
111         * qmake/mkspecs/features/features.prf:
112
113 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
114
115         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
116         https://bugs.webkit.org/show_bug.cgi?id=116610
117
118         Reviewed by Noam Rosenthal.
119
120         Remove unnecessary code adjusting context menu position to webview position.
121         Now position is calculcated in EwkView.
122
123         * MiniBrowser/efl/main.c:
124         (on_context_menu_show):
125
126 2013-06-12  Roger Fong  <roger_fong@apple.com>
127
128         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
129
130         * Scripts/webkitpy/common/config/ews.json:
131
132 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
133
134         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
135         https://bugs.webkit.org/show_bug.cgi?id=115647
136
137         Reviewed by Martin Robinson.
138
139         Locale resolution is moved to WebKitAccessibleWrapperAtk using
140         AtkObject::get_object_locale() API. Now, implementation of
141         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
142         be leveraged to get_object_locale() of AtkObject.
143
144         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
145         method.
146
147         No new functionality, no new tests.
148
149         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
150         (AccessibilityUIElement::language): Leverage locale resolution to
151         AtkObject::get_object_locale().
152         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
153         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
154         AtkObject::get_object_locale().
155
156 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
157
158         Remove last bits of GYP from build-webkit and update-webkit scripts
159         https://bugs.webkit.org/show_bug.cgi?id=117557
160
161         Reviewed by Ryosuke Niwa.
162
163         * Scripts/build-webkit:
164         * Scripts/update-webkit:
165
166 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
167
168         Remove forgotten unused Tools/Script/make-gypi script
169         https://bugs.webkit.org/show_bug.cgi?id=117558
170
171         Reviewed by Ryosuke Niwa.
172
173         This script isn't used since the GYP removal from WebKit.
174
175         * Scripts/make-gypi: Removed.
176
177 2013-06-12  Andres Gomez  <agomez@igalia.com>
178
179         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
180         https://bugs.webkit.org/show_bug.cgi?id=117533
181
182         Reviewed by Carlos Garcia Campos.
183
184         MiniBrowser now starts automatically the download of the documents
185         that cannot be shown just by WebKit itself on link left clicking.
186
187         * MiniBrowser/gtk/BrowserWindow.c:
188         (webViewDecidePolicy): handled the
189         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
190
191 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
192
193         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
194         https://bugs.webkit.org/show_bug.cgi?id=116723
195
196         Reviewed by Carlos Garcia Campos.
197
198         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
199         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
200         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
201         not expensive and produces a working archive without problems even on incremental builds.
202
203 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
204
205         [EFL] Window resize should close the popupmenu
206         https://bugs.webkit.org/show_bug.cgi?id=117391
207
208         Reviewed by Christophe Dumez.
209         
210         Added the code to close the popup when main window is resized.
211
212         * MiniBrowser/efl/main.c:
213         (on_window_resize):
214
215 2013-06-11  Alex Christensen  <achristensen@apple.com>
216
217         Removed old broken code coverage tool.
218         https://bugs.webkit.org/show_bug.cgi?id=117520
219
220         Reviewed by Sam Weinig.
221
222         * CodeCoverage: Removed.
223         * CodeCoverage/README: Removed.
224         * CodeCoverage/amber.png: Removed.
225         * CodeCoverage/cov.py: Removed.
226         * CodeCoverage/emerald.png: Removed.
227         * CodeCoverage/gcov.css: Removed.
228         * CodeCoverage/glass.png: Removed.
229         * CodeCoverage/regenerate-coverage-display: Removed.
230         * CodeCoverage/ruby.png: Removed.
231         * CodeCoverage/run-generate-coverage-data: Removed.
232         * CodeCoverage/snow.png: Removed.
233
234 2013-06-11  Timothy Hatcher  <timothy@apple.com>
235
236         Have build-webkit build the WebInspectorUI project.
237
238         * Scripts/build-webkit:
239
240 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
241
242         Add an option to run-webkit-tests to skip java dependency check
243         https://bugs.webkit.org/show_bug.cgi?id=117516
244
245         Reviewed by Andreas Kling.
246
247         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
248         (parse_args):
249         * Scripts/webkitpy/port/mac.py:
250         (MacPort._check_port_build):
251
252 2013-06-11  Alex Christensen  <achristensen@apple.com>
253
254         https://bugs.webkit.org/show_bug.cgi?id=117514
255         Removed extra Xcode code coverage flags.
256
257         Reviewed by Sam Weinig.
258
259         * Scripts/webkitdirs.pm:
260         (XcodeCoverageSupportOptions):
261
262 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
263
264         [Windows] Implement 'attributeValue' accessor to support testing
265         https://bugs.webkit.org/show_bug.cgi?id=117513
266
267         Reviewed by Anders Carlsson.
268
269         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
270         (comparableObject): Move earlier in file.
271         (findAccessibleObjectById): New implemenation.
272         (AccessibilityController::accessibleElementById): New implementation.
273
274 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
275
276         Make WTR use its own temporary directory for application cache
277         https://bugs.webkit.org/show_bug.cgi?id=117143
278
279         Reviewed by Alexey Proskuryakov.
280
281         * WebKitTestRunner/TestController.cpp:
282         (WTR::TestController::initialize):
283
284 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
285
286         https://bugs.webkit.org/show_bug.cgi?id=117449
287         Remove dead code for storing fonts in __DATA section
288
289         Reviewed by Dan Bernstein.
290
291         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
292         Don't copy font resources to __DATA, as we don't have any code that reads them
293         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
294
295         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
296         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
297         Removed comments suggesting that we want to restore the old solution.
298
299 2013-06-10  Bear Travis  <betravis@adobe.com>
300
301         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
302         https://bugs.webkit.org/show_bug.cgi?id=117162
303
304         Reviewed by Alexandru Chiculita.
305
306         Adding the WebCore/rendering/shapes directory to the include list.
307
308         * DumpRenderTree/efl/CMakeLists.txt:
309
310 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
311
312         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
313         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
314         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
315         happends in some of the 'accessibility' test cases.
316
317 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
318
319         [WinCairo] TestWebKitAPI fails to link.
320         https://bugs.webkit.org/show_bug.cgi?id=117345
321
322         Reviewed by Brent Fulgham.
323
324         Need to link with WTF.lib.
325
326         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
327
328 2013-06-07  Roger Fong  <roger_fong@apple.com>
329
330         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
331
332         Rubberstamped by Ryousuke Niwa.
333
334         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
335         (RunTest.test_build_check):
336
337 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
338
339         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
340         https://bugs.webkit.org/show_bug.cgi?id=117315
341
342         Reviewed by Benjamin Poulain.
343
344         Qt doesn't use the default values specified on FeatureList since r44681,
345         this patch just remove a bit of noise.
346
347         * Scripts/webkitperl/FeatureList.pm:
348
349 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
350
351         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
352         https://bugs.webkit.org/show_bug.cgi?id=115890
353
354         Reviewed by Christophe Dumez.
355
356         When user clicks HTML5 input type color,
357         color selector window is created on browser object by using elm_colorchooser_add().
358         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
359         The evas_object_color_set() sets a color value returning to browser.
360
361         * MiniBrowser/efl/main.c:
362         (window_free): When we delete parent window, deleting the colorpicker object.
363         (on_color_changed): Change color of rectangle to show color selected by user.
364         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
365         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
366         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
367         (on_color_picker_dismiss): Delete colorpicker object.
368         (on_color_picker_request): Create colorpicker window object.
369         (window_create):
370
371 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
372
373         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
374         https://bugs.webkit.org/show_bug.cgi?id=111066
375
376         Reviewed by Daniel Bates.
377
378         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
379
380         ParseGitDiffHeader() should support the path which line has space characters.
381         To support this, I changed parsing algorithm like the following:
382         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
383         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
384
385         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
386
387         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
388         I added a dummy tab and revision when we convert git diff to svn diff.
389
390         * Scripts/VCSUtils.pm:
391         (parseGitDiffHeader):
392         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
393         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
394         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
395           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
396
397 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
398
399         Add a menu item to MiniBrowser to toggle Transparent windows
400         https://bugs.webkit.org/show_bug.cgi?id=117316
401
402         Reviewed by Anders Carlsson.
403         
404         Add a menu item that toggles "Transparent window" mode, which is exposed
405         via private WebKit API and WebKit2 API.
406
407         * MiniBrowser/mac/BrowserWindowController.h:
408         * MiniBrowser/mac/MainMenu.xib:
409         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
410         * MiniBrowser/mac/WK1BrowserWindowController.m:
411         (-[WK1BrowserWindowController validateMenuItem:]):
412         (-[WK1BrowserWindowController toggleTransparentWindow:]):
413         * MiniBrowser/mac/WK2BrowserWindowController.m:
414         (-[WK2BrowserWindowController validateMenuItem:]):
415         (-[WK2BrowserWindowController toggleTransparentWindow:]):
416         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
417         when testing.
418
419 2013-06-06  Roger Fong  <roger_fong@apple.com>
420
421         Stop copying AAS binaries into build folder.
422         https://bugs.webkit.org/show_bug.cgi?id=117319.
423
424         Rubberstamped by Darin Adler.
425
426         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
427
428 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
429
430         Aligning build-webkit command line switch names to the WebKit flag names
431         https://bugs.webkit.org/show_bug.cgi?id=117254
432
433         Reviewed by Laszlo Gombos.
434
435         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
436
437 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
438
439         AX: iOS ignores ARIA progressbar elements
440         https://bugs.webkit.org/show_bug.cgi?id=116727
441
442         Reviewed by David Kilzer.
443
444         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
445         (AccessibilityUIElement::minValue):
446         (AccessibilityUIElement::maxValue):
447
448 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
449
450         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
451         https://bugs.webkit.org/show_bug.cgi?id=117255
452
453         Reviewed by Daniel Bates.
454
455         Need to update configuration names according to solution file.
456
457         * Scripts/webkitdirs.pm:
458         (determineConfiguration):
459         (determinePassedConfiguration):
460
461 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
462
463         Remove run-performance-tests
464         https://bugs.webkit.org/show_bug.cgi?id=117285
465
466         Reviewed by Andreas Kling.
467         
468         Remove the script since it's not used anywhere.
469
470         * BuildSlaveSupport/run-performance-tests: Removed.
471
472 2013-06-05  Bear Travis  <betravis@adobe.com>
473
474         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
475         https://bugs.webkit.org/show_bug.cgi?id=117172
476
477         Reviewed by Alexandru Chiculita.
478
479         Adding the CSS_SHAPES compile flag.
480
481         * Scripts/webkitperl/FeatureList.pm:
482         * qmake/mkspecs/features/features.pri:
483
484 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
485
486         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
487         to UNIX-style they will not execute properly.
488
489         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
490         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
491
492 2013-06-05  Roger Fong  <roger_fong@apple.com>
493
494         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
495
496         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
497         (RunWebKitTests.start):
498
499 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
500
501         [Windows] Switch to NRWT
502         https://bugs.webkit.org/show_bug.cgi?id=117200
503
504         Reviewed by Anders Carlsson.
505
506         * Scripts/run-webkit-tests:
507         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
508
509 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
510
511         Unreviewed name fix after r150662
512
513         My firstname got duplicated when fixing bug 116737.
514
515         * Scripts/webkitpy/common/config/contributors.json:
516
517 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
518
519         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
520         https://bugs.webkit.org/show_bug.cgi?id=117244
521
522         Reviewed by Daniel Bates.
523
524         Fixed a regression introduced by r151196: not only does webkit.org
525         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
526         infrastructure used by ports such as GTK+ and EFL also use on it for
527         things such as jhbuild.
528
529         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
530         both environment variables.
531
532         * Scripts/webkitdirs.pm:
533         (determineBaseProductDir):
534
535 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
536
537         [GTK] Forwarding headers not generated for incremental build
538         https://bugs.webkit.org/show_bug.cgi?id=117198
539
540         Reviewed by Carlos Garcia Campos.
541
542         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
543
544 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
545
546         [Qt][WK2] Fix layout testing with Qt 5.1
547         https://bugs.webkit.org/show_bug.cgi?id=117203
548
549         Reviewed by Jocelyn Turcotte.
550
551         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
552         go into loading state but directly call handler functions for
553         finished state instead of relying on a connection.
554         Our wrapper QQuickView uses a data URI scheme to create the root
555         item for testing which results in a synchronous request when loading
556         the QML data, therefore the state of the QQuickWindow immediately
557         becomes Ready.
558         Since the final initialization of the root item depended on the
559         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
560         up with a partially initialized wrapper window, thus most of our
561         layout tests were failing.
562         For compatibility with pre-5.1 Qt versions keep the old behaviour
563         in case the WrapperWindow is not ready in the constructor yet.
564
565         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
566         (WTR::WrapperWindow::WrapperWindow):
567         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
568         (TestWebKitAPI::WrapperWindow::WrapperWindow):
569
570 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
571
572         Bad value in tests counter at new-run-webkit-tests
573         in --debug-rwt-logging mode
574         https://bugs.webkit.org/show_bug.cgi?id=116858
575
576         Reviewed by Dirk Pranke.
577
578         Fix by moving counter incrementation, from after printing line,
579         to before printing. Also changed variable name.
580
581         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
582         (LayoutTestRunner.run_tests):
583         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
584         (FakePrinter):
585         * Scripts/webkitpy/layout_tests/views/printing.py:
586         (Printer.__init__):
587         (Printer._test_status_line):
588         (Printer.print_started_test):
589         (Printer.print_finished_test):
590         * Scripts/webkitpy/test/printer.py:
591         (Printer.__init__):
592         (Printer.print_finished_test):
593         (Printer._test_line):
594         (Printer.print_result):
595
596 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
597
598         Move MemoryInfo under window.internals
599         https://bugs.webkit.org/show_bug.cgi?id=117197
600
601         Reviewed by Ryosuke Niwa.
602
603         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
604         the Automake build
605         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
606         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
607
608 2013-06-03  Roger Fong  <roger_fong@apple.com>
609
610         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
611         <rdar://problem/14042021>.
612
613         Reviewed by Brent Fulgham.
614
615         * Scripts/build-api-tests:
616         * Scripts/build-dumprendertree:
617         * Scripts/build-webkit:
618         * Scripts/update-webkit-dependency:
619         * Scripts/update-webkit-support-libs:
620         * Scripts/webkitdirs.pm:
621         (determineBaseProductDir):
622         (setupAppleWinEnv):
623         (setupCygwinEnv):
624
625 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
626
627         [Windows] NRWT is not putting crash logs in proper place (corrections)
628         https://bugs.webkit.org/show_bug.cgi?id=117212
629
630         Reviewed by Dirk Pranke.
631
632         * Scripts/webkitpy/common/system/crashlogs.py:
633         (CrashLogs.__init__): Accept a result directory argument in constructor.
634         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
635         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
636         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
637         (CrashLogsTest.test_find_log_win): Simplify test.
638         * Scripts/webkitpy/common/system/executive.py:
639         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
640         * Scripts/webkitpy/port/win.py:
641         (WinPort._get_crash_log): No longer require 'port' argument.
642
643 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
644
645         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
646
647         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
648
649 2013-06-04  Greg Hughes  <ghughes@apple.com>
650
651         Add "VisibleOnly" key to search predicate
652         https://bugs.webkit.org/show_bug.cgi?id=115491
653
654         Reviewed by Chris Fleizach.
655
656         Added support for accessibility clients to use the search predicate to find only visible elements
657
658         * DumpRenderTree/AccessibilityUIElement.cpp:
659         (uiElementForSearchPredicateCallback):
660         * DumpRenderTree/AccessibilityUIElement.h:
661         (AccessibilityUIElement):
662         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
663         (AccessibilityUIElement::uiElementForSearchPredicate):
664         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
665         (AccessibilityUIElement::uiElementForSearchPredicate):
666         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
667         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
668         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
669         (AccessibilityUIElement):
670         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
671         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
672         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
673
674 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
675
676         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
677         causing build failure.
678
679         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
680         DOS-style CR/LF endings.
681
682 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
683
684         [Windows] Unreviewed test correction.
685
686         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
687         QuartzCore dll's, which are needed by TestWebKitAPI.
688         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
689         with VS2010 will run when linked against VS2005 support libraries.
690
691 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
692
693         Automatically generate WorkerContext constructor attributes
694         https://bugs.webkit.org/show_bug.cgi?id=117183
695
696         Reviewed by Kentaro Hara.
697
698         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
699         tests.
700
701         * Scripts/webkitpy/bindings/main.py:
702         (BindingsTests.generate_supplemental_dependency):
703         (BindingsTests.main):
704
705 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
706
707         [EFL] File dialog of MiniBrowser have broken background.
708         https://bugs.webkit.org/show_bug.cgi?id=117189
709
710         Reviewed by Christophe Dumez.
711
712         * MiniBrowser/efl/main.c:
713         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
714
715 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
716
717         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
718         https://bugs.webkit.org/show_bug.cgi?id=117184
719
720         Reviewed by Gyuyoung Kim.
721
722         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
723         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
724
725         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
726         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
727         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
728
729 2013-06-03  Simon Pena  <simon.pena@samsung.com>
730
731         validate-committer-lists script is now outdated and does not work
732         https://bugs.webkit.org/show_bug.cgi?id=115860
733
734         Reviewed by Brent Fulgham.
735
736         The script validate-committer-lists was outdated, still using the deprecated log
737         system and having the old addresses for the mailing lists, as well as still referring
738         to committers.py, after this was renamed to contributors.json. This patch fixes that
739         so it can be used again.
740
741         * Scripts/validate-committer-lists: Replace calls to log and error with the
742         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
743         to committers.py, which should be contributors.json.
744         (CommitterListFromMailingList):
745         (CommitterListFromMailingList.check_for_emails_missing_from_list):
746         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
747         (CommitterListFromGit._fill_in_emails_for_old_logins):
748         (CommitterListFromGit.print_committers_missing_from_committer_list):
749
750 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
751
752         add a script to dump the tests run most recently by a given worker
753         https://bugs.webkit.org/show_bug.cgi?id=116571
754
755         Reviewed by Brent Fulgham.
756
757         The tests_run*.txt results files in layout-test-results/ were removed
758         in r137356, in favor of collecting more data about how the tests were
759         run and compressing it and storing it in stats.json. However, it was
760         nice to just be able to look at a flat text file.
761
762         This script will extract the tests run by a given worker from a
763         given stats.json file, and should help to address that.
764
765         * Scripts/dump-webkit-tests-run: Added.
766         (main):
767         (convert_trie_to_flat_paths):
768
769 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
770
771         [Windows] NRWT is not putting crash logs in proper place
772         https://bugs.webkit.org/show_bug.cgi?id=117098
773
774         Reviewed by Ryosuke Niwa.
775
776         Provide windows-specific overloads for various Port features needed to create and capture
777         crash logs.  This change makes it possible to view crash logs (when created) as part of the
778         summary report at the end of the NRWT run.
779
780         * Scripts/webkitpy/common/system/crashlogs.py:
781         (CrashLogs.find_newest_log): Add support for win32 crash logs
782         (CrashLogs._find_newest_log_win): Added
783         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
784         (make_mock_crash_report_win): Added
785         (CrashLogsTest.test_find_log_win): Added.
786         * Scripts/webkitpy/common/system/executive.py:
787         (Executive.running_pids): Add support for Cygwin win32 crash logs
788         * Scripts/webkitpy/common/system/executive_mock.py:
789         (MockExecutive.__init__):
790         * Scripts/webkitpy/common/system/filesystem_unittest.py:
791         (RealFileSystemTest.test_read_and_write_file): Add tests for
792         malformed ascii/utf8 handling (i.e., Windows log files)
793         * Scripts/webkitpy/port/base.py:
794         (Port.find_system_pid): Added
795         * Scripts/webkitpy/port/server_process.py:
796         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
797         * Scripts/webkitpy/port/win.py:
798         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
799         for user to hit enter.
800         (WinPort._get_crash_log): Added
801         (WinPort.look_for_new_crash_logs): Added
802         (WinPort.find_system_pid): Added
803         * Scripts/webkitpy/port/win_unittest.py:
804         (WinPortTest.test_get_crash_log): Added test
805
806 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
807
808         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
809         https://bugs.webkit.org/show_bug.cgi?id=116726
810
811         Reviewed by Gyuyoung Kim.
812
813         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
814         the platform (it is not listed in jhbuild moduleset). That version is
815         old-ish and contain deprecated symbols and missing API, that are blocking
816         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
817         moduleset, which is the same version the gtk port uses.
818
819         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
820         why this is needed.
821
822         * efl/jhbuild.modules: Adds ATK module as dependency
823
824 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
825
826         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
827         https://bugs.webkit.org/show_bug.cgi?id=117168
828
829         Reviewed by Martin Robinson.
830
831         The tool generate-gtkdoc internally calls pkg-config.
832         When cross-compiling it shouldn't use pkg-config, but
833         it should use the pkg-config which was detected by
834         the ./configure script (for example this can be
835         i686-w64-mingw32-pkg-config when cross-compiling)
836
837         * GNUmakefile.am:
838         * gtk/gtkdoc.py:
839         (PkgConfigGTKDoc.__init__):
840
841 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
842
843         [Windows] Unreviewed build fix.
844
845         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
846         allow VS2010 builds to use VS2005 runtime libraries as needed.
847
848 2013-06-03  Roger Fong  <roger_fong@apple.com>
849
850         Nuke VS2005 files from the tree.
851         <rdar://problem/14042021>.
852
853         Rubberstamped by Brent Fulgham.
854
855         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
856         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
857         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
858         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
859         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
860         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
861         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
862         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
863         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
864         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
865         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
866         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
867         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
868         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
869         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
870         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
871         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
872         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
873         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
874         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
875         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
876         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
877         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
878         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
879         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
880         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
881         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
882         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
883         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
884         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
885         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
886         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
887         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
888         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
889         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
890         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
891         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
892         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
893         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
894         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
895         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
896         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
897         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
898         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
899         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
900         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
901         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
902         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
903         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
904         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
905         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
906         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
907         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
908         * Scripts/pdevenv: Removed.
909         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
910         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
911         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
912         * WebKitLauncherWin: Removed.
913         * WebKitLauncherWin/Resource.h: Removed.
914         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
915         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
916         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
917         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
918         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
919         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
920         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
921         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
922         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
923         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
924         * WebKitLauncherWin/webkit.ico: Removed.
925         * WinLauncher/WinLauncher.ico: Removed.
926         * WinLauncher/WinLauncher.rc: Removed.
927         * WinLauncher/WinLauncher.vcproj: Removed.
928         * WinLauncher/WinLauncherCommon.vsprops: Removed.
929         * WinLauncher/WinLauncherDebug.vsprops: Removed.
930         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
931         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
932         * WinLauncher/WinLauncherLauncher.rc: Removed.
933         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
934         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
935         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
936         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
937         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
938         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
939         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
940         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
941         * WinLauncher/WinLauncherLauncherResource.h: Removed.
942         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
943         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
944         * WinLauncher/WinLauncherProduction.vsprops: Removed.
945         * WinLauncher/WinLauncherRelease.vsprops: Removed.
946         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
947         * WinLauncher/small.ico: Removed.
948         * record-memory-win: Removed.
949         * record-memory-win/main.cpp: Removed.
950         * record-memory-win/record-memory-win-common.vsprops: Removed.
951         * record-memory-win/record-memory-win.vcproj: Removed.
952         * record-memory-win/record-memory-winDebug.vsprops: Removed.
953         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
954         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
955         * record-memory-win/record-memory-winProduction.vsprops: Removed.
956         * record-memory-win/record-memory-winRelease.vsprops: Removed.
957         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
958
959 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
960
961         AX: MathML multiscripts not exposed in Accessibility
962         https://bugs.webkit.org/show_bug.cgi?id=115069
963
964         Reviewed by Tim Horton.
965
966         Add methods to help output components of math multiscripts for accessibility.
967
968         * DumpRenderTree/AccessibilityUIElement.cpp:
969         (mathPostscriptsDescriptionCallback):
970         (mathPrescriptsDescriptionCallback):
971         (AccessibilityUIElement::getJSClass):
972         * DumpRenderTree/AccessibilityUIElement.h:
973         (AccessibilityUIElement):
974         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
975         (convertMathMultiscriptPairsToString):
976         (AccessibilityUIElement::mathPostscriptsDescription):
977         (AccessibilityUIElement::mathPrescriptsDescription):
978         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
979         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
980         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
981         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
982         (AccessibilityUIElement):
983         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
984         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
985         (WTR::_convertMathMultiscriptPairsToString):
986         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
987         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
988
989 2013-06-03  Commit Queue  <commit-queue@webkit.org>
990
991         Unreviewed, rolling out r151109.
992         http://trac.webkit.org/changeset/151109
993         https://bugs.webkit.org/show_bug.cgi?id=117145
994
995         "Plugins in WK2 aren't implemented yet." (Requested by
996         jturcotte on #webkit).
997
998         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
999         * qmake/mkspecs/features/features.prf:
1000         * qmake/mkspecs/features/unix/default_pre.prf:
1001
1002 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1003
1004         [Qt] Re-enable plugins on Mac.
1005         https://bugs.webkit.org/show_bug.cgi?id=116622
1006
1007         Reviewed by Tor Arne Vestbø.
1008
1009         Plugins on Mac were only enabled if !embedded but the later was set if
1010         QPA is enabled, which is the default since Qt 5.0.
1011
1012         Remove references to 'embedded' and fix various build issues,
1013         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
1014         months.
1015
1016         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1017         * qmake/mkspecs/features/features.prf:
1018         * qmake/mkspecs/features/unix/default_pre.prf:
1019
1020 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
1021
1022         [GTK][WK2] accessibility/placeholder.html is failing
1023         https://bugs.webkit.org/show_bug.cgi?id=106344
1024
1025         Reviewed by Gyuyoung Kim.
1026
1027         Adds support for retrieving attribute value.
1028
1029         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1030         (WTR::coreAttributeToAtkAttribute):
1031         (WTR::AccessibilityUIElement::stringAttributeValue):
1032
1033 2013-06-01  Tim Horton  <timothy_horton@apple.com>
1034
1035         Add a preferred email address and "expertise" for me.
1036
1037         * Scripts/webkitpy/common/config/contributors.json:
1038
1039 2013-05-31  Roger Fong  <roger_fong@apple.com>
1040
1041         Unreviewed. Make windows test bots search in the correct directory for build output.
1042
1043         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1044         (RunWebKitTests.start):
1045         * Scripts/webkitdirs.pm:
1046         (determineConfigurationProductDir):
1047
1048 2013-05-31  Roger Fong  <roger_fong@apple.com>
1049
1050         Unreviewed. Windows build fix...
1051
1052         * BuildSlaveSupport/built-product-archive:
1053         (createZip):
1054
1055 2013-05-31  Roger Fong  <roger_fong@apple.com>
1056
1057         Unreviewed. Windows build fix. One more time!
1058
1059         * BuildSlaveSupport/built-product-archive:
1060         (archiveBuiltProduct):
1061         (extractBuiltProduct):
1062
1063 2013-05-31  Roger Fong  <roger_fong@apple.com>
1064
1065         Unreviewed. Windows build fix.
1066
1067         * Scripts/build-webkit:
1068
1069 2013-05-31  Roger Fong  <roger_fong@apple.com>
1070
1071         Unreviewed. Windows build fix.
1072
1073         * Scripts/build-webkit:
1074
1075 2013-05-31  Roger Fong  <roger_fong@apple.com>
1076
1077         Make build-webkit output VCExpress 2010 build logs properly.
1078         https://bugs.webkit.org/show_bug.cgi?id=117096
1079
1080         Reviewed by Brent Fulgham.
1081
1082         Make it so that output from VCExpress is always printed to console.
1083         Get build log results from AssembleBuildLogs project output.
1084         We don't need those old VCExpress scripts anymore either. 
1085
1086         * Scripts/build-webkit:
1087         * Scripts/print-msvc-project-dependencies: Removed.
1088         * Scripts/print-vse-failure-logs: Removed.
1089
1090 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1091
1092         [Windows] Use WinLauncher to display LayoutTest results
1093         https://bugs.webkit.org/show_bug.cgi?id=117085
1094
1095         Reviewed by Oliver Hunt.
1096
1097         * Scripts/webkitdirs.pm:
1098         (runSafari): Use WinLauncher to display content
1099         * WinLauncher/WinLauncher.cpp:
1100         (dllLauncherEntryPoint): Check for URL argument.
1101
1102 2013-05-31  Roger Fong  <roger_fong@apple.com>
1103
1104         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
1105
1106         * win/AssembleBuildLogs/AssembleLogs.cmd:
1107
1108 2013-05-31  Commit Queue  <commit-queue@webkit.org>
1109
1110         Unreviewed, rolling out r151022.
1111         http://trac.webkit.org/changeset/151022
1112         https://bugs.webkit.org/show_bug.cgi?id=117084
1113
1114         Also breaks build by introducing duplicate symbols (Requested
1115         by bfulgham on #webkit).
1116
1117         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1118
1119 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1120
1121         [Windows] Unreviewed build fix to NRWT
1122
1123         * Scripts/webkitpy/port/win.py:
1124         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
1125
1126 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1127
1128         [Windows] Unreviewed build fix after r151012
1129
1130         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
1131         WTF library to support SHA tests
1132
1133 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1134
1135         [Windows] Unreviewed build fix after r151012
1136
1137         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
1138         snprintf definition for Windows.
1139
1140 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
1141
1142         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
1143         https://bugs.webkit.org/show_bug.cgi?id=116445
1144
1145         Reviewed by Benjamin Poulain.
1146
1147         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
1148
1149         * TestWebKitAPI/CMakeLists.txt:
1150         * TestWebKitAPI/GNUmakefile.am:
1151         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1152         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1154         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
1155         (TestWebKitAPI):
1156         (TestWebKitAPI::expectMD5):
1157         (TestWebKitAPI::TEST):
1158         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
1159         (TestWebKitAPI):
1160         (TestWebKitAPI::expectSHA1):
1161         (TestWebKitAPI::TEST):
1162         * TestWebKitAPI/Tests/WTF/WTF.pro:
1163         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1164
1165 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1166
1167         [Windows] Unreviewed build correction.
1168
1169         * Scripts/webkitpy/port/win.py:
1170         (WinPort.create_debugger_command_file): The directory needs to be
1171         a string, not a temporary directory object.
1172
1173 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1174
1175         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
1176         https://bugs.webkit.org/show_bug.cgi?id=76935
1177
1178         Reviewed by Ryosuke Niwa.
1179
1180         Extend the WinPort class with commands to set and clean up various registry
1181         values needed to invoke the correct debugger to get crash files.
1182
1183         * Scripts/webkitpy/port/win.py:
1184         (WinPort): Added global caches for registry keys and settings
1185         (WinPort._ntsd_location): Added
1186         (WinPort.create_debugger_command_file): Added
1187         (WinPort.read_registry_string): Added
1188         (WinPort.write_registry_string): Added
1189         (WinPort.setup_crash_log_saving): Added
1190         (WinPort.restore_crash_log_saving): Added
1191         (WinPort.setup_test_run): Added overload to add registry settings.
1192         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
1193
1194 2013-05-30  Roger Fong  <roger_fong@apple.com>
1195
1196         Get rid of JavaScript exports file on AppleWin port.
1197         https://bugs.webkit.org/show_bug.cgi?id=117050.
1198
1199         Reviewed by Darin Adler.
1200
1201         Start linking in WTF.lib now that it's a shared library.
1202
1203         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1204         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1205         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1206
1207 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1208
1209         Web Inspector: tests in PerformanceTests/inspector/ are timing out
1210         https://bugs.webkit.org/show_bug.cgi?id=77024
1211
1212         Reviewed by Andreas Kling.
1213
1214         Remove inspector performance tests since they have been disabled for ages,
1215         and they don't use the standard parser-style performance output.
1216
1217         It's adding a lot of code complexity to our infrastructure.
1218
1219         * Scripts/webkitpy/performance_tests/perftest.py:
1220         (SingleProcessPerfTest.__init__):
1221         (PerfTestFactory):
1222         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1223         (TestPerfTestFactory.test_regular_test):
1224         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1225         (TestDriver.run_test):
1226         (MainTest.run_test):
1227         (MainTest._tests_for_runner):
1228         (MainTest.test_run_test_set_kills_drt_per_run):
1229         (MainTest._test_run_with_json_output):
1230         (MainTest):
1231         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1232
1233 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1234
1235         Remove requires_http_server as Chromium Android was the only port that needed this
1236         https://bugs.webkit.org/show_bug.cgi?id=117018
1237
1238         Reviewed by Benjamin Poulain.
1239
1240         Removed the unused code that existed for Chromium Android port.
1241
1242         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1243         (LayoutTestRunner.run_tests):
1244         (LayoutTestRunner._handle_finished_test_list):
1245         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1246         (Manager._run_tests):
1247         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1248         (PerfTestsRunner._collect_tests):
1249         (PerfTestsRunner.run):
1250         * Scripts/webkitpy/port/base.py:
1251         (Port.to.start_helper):
1252         * Scripts/webkitpy/port/base_unittest.py:
1253         (PortTest.test_build_path):
1254
1255 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
1256
1257         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
1258         https://bugs.webkit.org/show_bug.cgi?id=113221
1259
1260         Reviewed by Ryosuke Niwa.
1261
1262         Teach prepare-Changelog to not list the names of modified namespaces, 
1263         classes, or structs in C++ files. Thus, if a change is made 
1264         within a namespace/class/struct yet outside a function, it will 
1265         not be reflected in the ChangeLog entry. 
1266         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
1267         for more details on how ChangeLog entries are affected.
1268
1269         * Scripts/prepare-ChangeLog:
1270         (get_function_line_ranges_for_cpp): 
1271         (delete_namespaces_from_ranges_for_cpp): Added.
1272         (is_function_in_namespace): Added.
1273         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
1274         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
1275
1276 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
1277
1278         Cleanup AudioSourceNode.idl from WebKit build.
1279         https://bugs.webkit.org/show_bug.cgi?id=116905.
1280
1281         Reviewed by Darin Adler.
1282
1283         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
1284         AudioNode is inherited directly in all the audio source nodes.
1285
1286         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1287
1288 2013-05-29  Andrew Lo  <anlo@rim.com>
1289
1290         Add Andrew Lo to contributors.json
1291         https://bugs.webkit.org/show_bug.cgi?id=116981
1292
1293         Reviewed by Rob Buis.
1294
1295         Adding Andrew Lo to contributors.json.
1296
1297         * Scripts/webkitpy/common/config/contributors.json:
1298
1299 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1300
1301         Unreviewed. Adding myself as a committer.
1302
1303         * Scripts/webkitpy/common/config/contributors.json:
1304
1305 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
1306
1307         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
1308         https://bugs.webkit.org/show_bug.cgi?id=116683
1309
1310         Reviewed by Noam Rosenthal.
1311
1312         A coordinates conversion test for WKViewUserViewportToContents was
1313         added to WebKit2 API tests.
1314
1315         * TestWebKitAPI/PlatformEfl.cmake:
1316         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
1317         (TestWebKitAPI):
1318         (TestWebKitAPI::TEST):
1319
1320 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
1321
1322         Unreviewed. Update my info.
1323
1324         * Scripts/webkitpy/common/config/contributors.json:
1325
1326 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
1327
1328         Unreviewed. Add myself as committer in contributors.json.
1329
1330         * Scripts/webkitpy/common/config/contributors.json:
1331
1332 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1333
1334         Unreviewed. Fix make distcheck.
1335
1336         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
1337         DISTCLEANFILES.
1338
1339 2013-05-29  Mary Wu  <mawu@blackberry.com>
1340
1341         Unreviewed: update my email address in contributors.json.
1342
1343         * Scripts/webkitpy/common/config/contributors.json:
1344
1345 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
1346
1347         Unreviewed: Adding myself to committers list.
1348
1349         * Scripts/webkitpy/common/config/contributors.json:
1350
1351 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
1352
1353         Unreviewed: Adding myself to committers list.
1354
1355         * Scripts/webkitpy/common/config/contributors.json:
1356
1357 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
1358
1359         [Windows] Many CSS2.1 tests fail under NRWT.
1360         https://bugs.webkit.org/show_bug.cgi?id=75707
1361
1362         Reviewed by Darin Adler.
1363
1364         * DumpRenderTree/win/DumpRenderTree.cpp:
1365         (findFontFallback): Added
1366         (addFontFallbackIfPresent): Added
1367         (removeFontFallbackIfPresent): Added
1368         (runTest): Set up/remove font fallbacks when needed.
1369
1370 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
1371
1372         [Windows] NRWT reports failure for 'mac' test cases.
1373         https://bugs.webkit.org/show_bug.cgi?id=116698
1374
1375         Reviewed by Ryosuke Niwa.
1376
1377         The Windows port falls back to the Mac port for many test results,
1378         and so adds the mac and mac-wk2 to its set of fallbacks.
1379         Unfortunately, NRWT thinks that this means that tests in these
1380         folders should be executed, resulting in many failures on
1381         Windows.
1382
1383         This change overloads the '_tests_for_other_platforms' method
1384         to return a subset of the result fallback list so that we do
1385         not attempt to execute Mac tests on Windows.
1386
1387         * Scripts/webkitpy/port/base.py:
1388         (Port.test_search_path): Added. Defaults to just calling the
1389         baseline_search_path method, which is how most ports behave.
1390         (Port._test_for_other_platforms): Modified to call the new
1391         test_search_path method.
1392
1393         * Scripts/webkitpy/port/win.py:
1394         (WinPort.test_search_path): Added custom overload. Strips
1395         out mac-specific test paths.
1396
1397 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
1398
1399         Fix GTK+ CMake build
1400
1401         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
1402         library target is simply "WebKit2."
1403
1404 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
1405
1406         [webkitpy] Explicitly specify the reference file extensions
1407         https://bugs.webkit.org/show_bug.cgi?id=116333
1408
1409         Reviewed by Benjamin Poulain.
1410
1411         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
1412         between valid reference files required by reftests and text baselines that have the same extension as
1413         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
1414         that were until this change recognized as reference files).
1415
1416         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
1417
1418         * Scripts/webkitpy/port/base.py:
1419         (Port.reference_files): Iterate through the _supported_reference_extensions set.
1420         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
1421         _supported_reference_extensions set, containing the extensions allowed for reference files.
1422         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
1423         (Port._has_supported_extension): Use _supported_test_extensions.
1424         * Scripts/webkitpy/port/base_unittest.py:
1425         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
1426         Port.is_reference_html_file method.
1427
1428 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1429
1430         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
1431
1432         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1433         (NewCommitBot.next_work_item):
1434
1435 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1436
1437         WKR and webkitbot build fixes.
1438
1439         * Scripts/webkitpy/tool/bot/irc_command.py:
1440         (RollChromiumDEPS.execute):
1441         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1442         (NewCommitBot.next_work_item):
1443
1444 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1445
1446         roll-chromium-deps doesn't repeat the full name.
1447
1448         Rubber-stamped by Andreas Kling.
1449
1450         * Scripts/webkitpy/tool/bot/irc_command.py:
1451         (RollChromiumDEPS.execute):
1452
1453 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1454
1455         Revert another erroneous change.
1456
1457         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1458         (NewCommitBot.next_work_item):
1459
1460 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1461
1462         Revert an erroneous change.
1463
1464         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1465         (SheriffBot):
1466
1467 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1468
1469         Some build fixes for WKR and webkitbot.
1470
1471         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1472         (IRCBotTest.test_help):
1473         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1474         (Agent):
1475         (Agent.__init__):
1476         (Agent.name):
1477         (NewCommitBot):
1478         (NewCommitBot.begin_work_queue):
1479         (NewCommitBot.next_work_item):
1480         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1481         (SheriffBot):
1482
1483 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1484
1485         Teach webkitbot and WKR how to respond to yt?
1486         https://bugs.webkit.org/show_bug.cgi?id=116775
1487
1488         Reviewed by Andreas Kling.
1489
1490         * Scripts/webkitpy/tool/bot/irc_command.py:
1491         (Hi): Fixed the usage string.
1492         (Hi.execute): Made it more generic so that it works in WKR.
1493         (YouThere): Added.
1494         (YouThere.execute): Added.
1495         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1496
1497 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1498
1499         Try to fix the EFL build.
1500         
1501         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1502         (TestRunner::setPageVisibility):
1503
1504 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1505
1506         Unprefix Page Visibility API
1507         https://bugs.webkit.org/show_bug.cgi?id=102340
1508
1509         Reviewed by Tim Horton.
1510         
1511         Rename "preview" state to "unloaded" state, and adjust the tests
1512         to test for it.
1513
1514         * DumpRenderTree/mac/TestRunnerMac.mm:
1515         (TestRunner::setPageVisibility):
1516         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
1517         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1518         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1519         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
1520         (TestWebKitAPI::didRunStep4InStateUnloaded):
1521         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
1522         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1523         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1525         (WTR::TestRunner::setPageVisibility):
1526
1527 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1528
1529         Unreviewed build fix. Don't use new NRWT logic needed
1530         by Windows yet. Activate (and fix test) when we cut over.
1531
1532         * Scripts/webkitpy/port/driver.py:
1533         (Driver._setup_environ_for_driver):
1534         (Driver._start):
1535
1536 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1537
1538         [Windows] Expose database storage and cache locations via preferences.
1539         https://bugs.webkit.org/show_bug.cgi?id=116729
1540
1541         Reviewed by Tim Horton.
1542
1543         Update DumpRenderTree to use CFPreferences to control where WebKit
1544         stores its local databases, URL caches, etc.
1545
1546         * DumpRenderTree/win/DumpRenderTree.cpp:
1547         (libraryPathForDumpRenderTree): Added.
1548         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
1549         * Scripts/webkitpy/port/base.py:
1550         (Port._driver_tempdir): Added (to allow port-specific overload).
1551         (Port._driver_tempdir_for_environment): Ditto
1552         * Scripts/webkitpy/port/driver.py:
1553         (Driver._setup_environ_for_driver): Use new overload to set
1554         environment variable.
1555         (Driver._start): Use new overload for temp directory location.
1556         * Scripts/webkitpy/port/win.py:
1557         (WinPort._driver_tempdir_for_environment): New overload to supply
1558         Windows path to DumpRenderTree environment (while still using
1559         cygwin paths for internal operations.
1560
1561 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1562
1563         Remove custom code for webkitAudioContext global constructor getter
1564         https://bugs.webkit.org/show_bug.cgi?id=116530
1565
1566         Reviewed by Geoffrey Garen.
1567
1568         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
1569         WebAudio feature instead of public ewk_view API since that API was
1570         removed.
1571
1572         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1573         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1574         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1575         (TestRunner::overridePreference):
1576
1577 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
1578
1579         Make team.html have each contributor's area of expertise
1580         https://bugs.webkit.org/show_bug.cgi?id=116737
1581
1582         Reviewed by Benjamin Poulain.
1583
1584         * Scripts/webkitpy/common/config/contributors.json:
1585         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
1586         
1587         Changed formatting of the file because the lines are getting way to
1588         long, and I generated this, so it's easier if the formatting of the
1589         file is regular.
1590
1591 2013-05-24  Simon Pena  <simon.pena@samsung.com>
1592
1593         Update WTF::Vector pretty printers
1594         https://bugs.webkit.org/show_bug.cgi?id=116719
1595
1596         Reviewed by Anders Carlsson.
1597
1598         After r148891, WTF::Vector pretty printers were left outdated, as
1599         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
1600         one as a member. This patch updates the pretty printers so they work
1601         again. 
1602
1603         * gdb/webkit.py:
1604         (WTFVectorPrinter.children):
1605         (WTFVectorPrinter.to_string):
1606
1607 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
1608
1609         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
1610         https://bugs.webkit.org/show_bug.cgi?id=116710
1611
1612         Reviewed by Mark Rowe.
1613
1614         * DumpRenderTree/mac/DumpRenderTree.mm:
1615         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
1616
1617 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
1618
1619         Add missing dependencies to deps script.
1620
1621         [GTK] Missing packages in install-dependencies script.
1622         https://bugs.webkit.org/show_bug.cgi?id=116632
1623
1624         Reviewed by Martin Robinson.
1625
1626         * gtk/install-dependencies:
1627
1628 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1629
1630         [Windows] Unreviewed change for NRWT support.
1631
1632         * Scripts/webkitpy/port/win.py:
1633         (WinPort.default_child_processes): Added a default implementation
1634         that limits NRWT to a single instance.
1635
1636 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1637
1638         Remove meaningless "test_uses_apache" from Python test cases.
1639         https://bugs.webkit.org/show_bug.cgi?id=38756
1640
1641         Reviewed by Ryosuke Niwa.
1642
1643         * Scripts/webkitpy/port/port_testcase.py:
1644         (PortTestCase.test_driver_cmd_line): Remove the meaningless
1645         "test_uses_apache" test case from the Python test infrastructure.
1646         It was hard-coded to true, even though not all ports use
1647         Apache.
1648
1649 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
1650
1651         [Windows] Update new-run-webkit-tests for Windows port.
1652         https://bugs.webkit.org/show_bug.cgi?id=38756
1653
1654         Reviewed by Ryosuke Niwa.
1655
1656         * Scripts/new-run-webkit-httpd:
1657         (run): Switch from 'chromium' to 'win'
1658         * Scripts/webkitpy/port/win.py:
1659         (WinPort): Add support methods for lighttpd server.
1660         (WinPort._uses_apache):
1661         (WinPort._path_to_lighttpd):
1662         (WinPort._path_to_lighttpd_modules):
1663         (WinPort._path_to_lighttpd_php):
1664
1665 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
1666
1667         Make default bug links in buildbot clickable
1668         https://bugs.webkit.org/show_bug.cgi?id=116673
1669
1670         Reviewed by Ryosuke Niwa.
1671
1672         Use changecommentlink of html.WebStatus to make the links clickable.
1673
1674         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1675
1676 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
1677
1678         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
1679         https://bugs.webkit.org/show_bug.cgi?id=116595
1680
1681         Temporarily skip this test.
1682
1683         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1684         (TestWebKitAPI::TEST):
1685
1686 2013-05-22  Alex Christensen  <achristensen@apple.com>
1687
1688         Unreviewed.  Added myself to contributors.json.
1689
1690         * Scripts/webkitpy/common/config/contributors.json:
1691         Added myself.
1692
1693 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1694
1695         [EFL][WK2] Add sub menus to MiniBrowser
1696         https://bugs.webkit.org/show_bug.cgi?id=114728
1697
1698         Reviewed by Christophe Dumez.
1699
1700         Elementary Ctxpopup widget API does not provide support for submenu item.
1701         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
1702         Elementary Menu widget.
1703
1704         * MiniBrowser/efl/main.c:
1705         (_Browser_Window):
1706         (on_window_resize):
1707         (window_free):
1708         (context_menu_item_selected_cb):
1709         (context_menu_populate):
1710         (on_context_menu_show):
1711         (on_context_menu_hide):
1712         (window_create):
1713
1714 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
1715
1716         [EFL] Add command line option to MiniBrowser to set cookies policy.
1717         https://bugs.webkit.org/show_bug.cgi?id=115028
1718
1719         Reviewed by Christophe Dumez.
1720
1721         Add command line option to MiniBrowser EFL to set cookies policy:
1722         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
1723         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
1724
1725         * MiniBrowser/efl/main.c:
1726         (elm_main):
1727
1728 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1729
1730         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
1731         https://bugs.webkit.org/show_bug.cgi?id=116585
1732
1733         Reviewed by Alexey Proskuryakov.
1734
1735         willLoadURLRequest and willLoadDataRequest require the API version 6.
1736
1737         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1738
1739 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1740
1741         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
1742         https://bugs.webkit.org/show_bug.cgi?id=116516
1743
1744         Reviewed by Alexey Proskuryakov.
1745
1746         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
1747
1748         * DumpRenderTree/mac/DumpRenderTree.mm:
1749         (createWebViewAndOffscreenWindow): Match the ordering.
1750         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
1751
1752 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
1753
1754         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
1755         https://bugs.webkit.org/show_bug.cgi?id=116568
1756
1757         Reviewed by Anders Carlsson.
1758
1759         * WebKitTestRunner/WebNotificationProvider.cpp:
1760         (WTR::WebNotificationProvider::~WebNotificationProvider):
1761         * WebKitTestRunner/WebNotificationProvider.h:
1762         When the provider is destroyed, it should no longer be registered with the manager.
1763
1764         * WebKitTestRunner/GeolocationProviderMock.cpp:
1765         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
1766         * WebKitTestRunner/GeolocationProviderMock.h:
1767         I wasn't seeing a crash here, but this code has the same issue as notification
1768         provider, so applying the same fix.
1769
1770         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1771         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
1772         destructor having fixed the above.
1773
1774 2013-05-21  Commit Queue  <commit-queue@webkit.org>
1775
1776         Unreviewed, rolling out r150386 and r150397.
1777         http://trac.webkit.org/changeset/150386
1778         http://trac.webkit.org/changeset/150397
1779         https://bugs.webkit.org/show_bug.cgi?id=116572
1780
1781         Broke a test; Alex is going to try again later. (Requested by
1782         thorton on #webkit).
1783
1784         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1785         (WTR::pathSuitableForTestResult):
1786         (WTR::dumpRequestDescriptionSuitableForTestResult):
1787         (WTR::dumpResponseDescriptionSuitableForTestResult):
1788         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1789         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1790         (WTR::InjectedBundlePage::willSendRequestForFrame):
1791         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1792         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1793         (InjectedBundlePage):
1794
1795 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1796
1797         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
1798
1799         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1800         (AbstractCommitLogCommand._recent_commit_messages):
1801
1802 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
1803
1804         [GTK] [CMake] Add support for building WebKit2
1805         https://bugs.webkit.org/show_bug.cgi?id=116372
1806
1807         Reviewed by Gustavo Noronha Silva.
1808
1809         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
1810         * MiniBrowser/gtk/CMakeLists.txt: Added.
1811
1812 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1813
1814         Revert r149635, it was too optimistic.
1815
1816         Rubber-stamped by Andreas Kling.
1817
1818         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
1819         #ifdefs in WebCore code outside of WebCore/platform.
1820
1821         * Scripts/webkitpy/style/checkers/cpp.py:
1822         (check_invalid_increment):
1823         (process_line):
1824         (CppChecker):
1825         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1826         (CppStyleTest.test_plain_integral_bitfields):
1827
1828 2013-05-21  Jer Noble  <jer.noble@apple.com>
1829
1830         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
1831
1832         * lldb/lldb_webkit.py:
1833         (WTFVectorProvider.num_children):
1834         (WTFVectorProvider.get_child_index):
1835         (WTFVectorProvider.get_child_at_index):
1836         (WTFVectorProvider.update):
1837
1838 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1839
1840         Expose a way to know when forms are added to a page or when form controls are added to a form
1841         in the injected bundle
1842         https://bugs.webkit.org/show_bug.cgi?id=116334
1843
1844         Reviewed by Alexey Proskuryakov.
1845
1846         Add tests for the new callbacks.
1847
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1850
1851         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1852         (TestWebKitAPI::nullJavaScriptCallback):
1853         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1854         being passed in for the callback.
1855         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1856         After receiving the message that didAssociateFormControls callback was invoked from adding
1857         the form in the onload handler, tell the page to add a password field to the form, which
1858         should also invoke didAssociateFormControls callback.
1859         (TestWebKitAPI::setInjectedBundleClient):
1860         Register to receive messages.
1861         (TestWebKitAPI::TEST):
1862         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1863         been invoked for both adding the form and for adding a password field to the form.
1864
1865         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1866         (TestWebKitAPI::shouldNotifyOnFormChanges):
1867         Return true so the didAssociateFormControls callback is invoked.
1868         (TestWebKitAPI::didAssociateFormControls):
1869         Tell the UI process.
1870         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1871         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1872         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1873
1874         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1875         Add a form in response to the onload event. Add a button that will add the password field
1876         for manual testing.
1877
1878 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1879
1880         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
1881         https://bugs.webkit.org/show_bug.cgi?id=106341
1882
1883         Reviewed by Martin Robinson.
1884
1885         Adds support for retrieving accessibility element at exact point.
1886
1887         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1888         (WTR::AccessibilityUIElement::elementAtPoint):
1889
1890 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1891
1892         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
1893         https://bugs.webkit.org/show_bug.cgi?id=112913
1894
1895         Reviewed by Martin Robinson.
1896
1897         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
1898         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
1899         so the leak appears.
1900
1901         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1902         (WTR):
1903         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1904         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1905         (WTR::AccessibilityController::rootElement):
1906         (WTR):
1907         (WTR::AccessibilityController::focusedElement):
1908         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1909         (WTR::checkElementState):
1910         (WTR::indexRangeInTable):
1911         (WTR::alterCurrentValue):
1912         (WTR::AccessibilityUIElement::getChildren):
1913         (WTR::AccessibilityUIElement::getChildrenWithRange):
1914         (WTR::AccessibilityUIElement::childrenCount):
1915         (WTR::AccessibilityUIElement::indexOfChild):
1916         (WTR::AccessibilityUIElement::titleUIElement):
1917         (WTR::AccessibilityUIElement::parentElement):
1918         (WTR::AccessibilityUIElement::allAttributes):
1919         (WTR::AccessibilityUIElement::role):
1920         (WTR::AccessibilityUIElement::title):
1921         (WTR::AccessibilityUIElement::description):
1922         (WTR::AccessibilityUIElement::orientation):
1923         (WTR::AccessibilityUIElement::stringValue):
1924         (WTR::AccessibilityUIElement::language):
1925         (WTR::AccessibilityUIElement::x):
1926         (WTR::AccessibilityUIElement::y):
1927         (WTR::AccessibilityUIElement::width):
1928         (WTR::AccessibilityUIElement::height):
1929         (WTR::AccessibilityUIElement::intValue):
1930         (WTR::AccessibilityUIElement::minValue):
1931         (WTR::AccessibilityUIElement::maxValue):
1932         (WTR::AccessibilityUIElement::isEnabled):
1933         (WTR::AccessibilityUIElement::isFocused):
1934         (WTR::AccessibilityUIElement::isSelected):
1935         (WTR::AccessibilityUIElement::isExpanded):
1936         (WTR::AccessibilityUIElement::isChecked):
1937         (WTR::AccessibilityUIElement::rowCount):
1938         (WTR::AccessibilityUIElement::columnCount):
1939         (WTR::AccessibilityUIElement::rowIndexRange):
1940         (WTR::AccessibilityUIElement::columnIndexRange):
1941         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1942         (WTR::AccessibilityUIElement::increment):
1943         (WTR::AccessibilityUIElement::decrement):
1944         (WTR::AccessibilityUIElement::press):
1945         (WTR::AccessibilityUIElement::documentEncoding):
1946         (WTR::AccessibilityUIElement::documentURI):
1947         (WTR::AccessibilityUIElement::isFocusable):
1948         (WTR::AccessibilityUIElement::isSelectable):
1949         (WTR::AccessibilityUIElement::isMultiSelectable):
1950         (WTR::AccessibilityUIElement::isVisible):
1951
1952 2013-05-20  Lucas Forschler  <lforschler@apple.com>
1953
1954     Rollout 150398.
1955     
1956 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1957
1958         [GTK] Fix concatenations of string literals that are not C++11-compliant
1959         https://bugs.webkit.org/show_bug.cgi?id=116449
1960
1961         Reviewed by Martin Robinson.
1962
1963         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
1964         is simply a matter of separating the string and the string literal that are being concatenated with a space.
1965
1966         * ImageDiff/gtk/ImageDiff.cpp:
1967         (printImage):
1968
1969 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1970
1971         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
1972         https://bugs.webkit.org/show_bug.cgi?id=116450
1973
1974         Reviewed by Martin Robinson.
1975
1976         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
1977         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
1978         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
1979         TestWebKitAPI programs when compiling them.
1980
1981         * TestWebKitAPI/GNUmakefile.am:
1982
1983 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1984
1985         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
1986         https://bugs.webkit.org/show_bug.cgi?id=116492
1987
1988         Reviewed by Dirk Pranke.
1989
1990         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
1991
1992         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
1993         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
1994         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
1995         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
1996         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
1997         to memory pressure on the machine.
1998
1999         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
2000         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
2001         for a subsequent patch just to make things easier to follow.
2002
2003         * Scripts/webkitpy/port/driver.py:
2004         (DriverProxy.__init__):
2005         (DriverProxy.run_test):
2006         (DriverProxy.has_crashed):
2007         (DriverProxy.stop):
2008
2009 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2010
2011         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
2012         https://bugs.webkit.org/show_bug.cgi?id=116423
2013
2014         Reviewed by Ryosuke Niwa.
2015
2016         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
2017
2018         * BuildSlaveSupport/build.webkit.org-config/config.json:
2019
2020 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
2021
2022         Remove remaining link-prerender code
2023         https://bugs.webkit.org/show_bug.cgi?id=116429
2024
2025         Reviewed by Darin Adler.
2026
2027         Link prerendering code was removed in r150356.
2028
2029         * Scripts/webkitperl/FeatureList.pm:
2030         * qmake/mkspecs/features/features.pri:
2031
2032 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
2033
2034         commit-queue should check for oops in changelog entries
2035         https://bugs.webkit.org/show_bug.cgi?id=116395
2036
2037         Reviewed by Martin Robinson.
2038
2039         Make changelog validation fail when it contains oops!.
2040
2041         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2042         (CommitQueueTask._validate_changelog):
2043         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2044         (CommitQueueTaskTest._run_through_task):
2045         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2046         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2047         (ValidateChangeLogs.options):
2048         (ValidateChangeLogs._check_changelog_diff):
2049         (ValidateChangeLogs._changelog_contains_oops):
2050         (ValidateChangeLogs.run):
2051         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2052         (ValidateChangeLogsTest._assert_start_line_produces_output):
2053         (ValidateChangeLogsTest.test_check_changelog_diff):
2054         (ValidateChangeLogsTest):
2055         (ValidateChangeLogsTest.test_changelog_contains_oops):
2056
2057 2013-05-20  Jessie Berlin  <jberlin@apple.com>
2058
2059         Expose a way to know when forms are added to a page or when form controls are added to a form
2060         in the injected bundle
2061         https://bugs.webkit.org/show_bug.cgi?id=116334
2062
2063         Reviewed by Alexey Proskuryakov.
2064
2065         Add tests for the new callbacks.
2066
2067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2068         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
2069
2070         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
2071         (TestWebKitAPI::nullJavaScriptCallback):
2072         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
2073         being passed in for the callback.
2074         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2075         After receiving the message that didAssociateFormControls callback was invoked from adding
2076         the form in the onload handler, tell the page to add a password field to the form, which
2077         should also invoke didAssociateFormControls callback.
2078         (TestWebKitAPI::setInjectedBundleClient):
2079         Register to receive messages.
2080         (TestWebKitAPI::TEST):
2081         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
2082         been invoked for both adding the form and for adding a password field to the form.
2083
2084         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
2085         (TestWebKitAPI::shouldNotifyOnFormChanges):
2086         Return true so the didAssociateFormControls callback is invoked.
2087         (TestWebKitAPI::didAssociateFormControls):
2088         Tell the UI process.
2089         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
2090         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
2091         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
2092
2093         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
2094         Add a form in response to the onload event. Add a button that will add the password field
2095         for manual testing.
2096
2097 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2098
2099         [EFL][JHBUILD] Make sure eet is built before evas
2100         https://bugs.webkit.org/show_bug.cgi?id=116440
2101
2102         Reviewed by Gyuyoung Kim.
2103
2104         Mark eet as a dependency of evas since evas requires eet to enable some of its
2105         functionality.
2106
2107         * efl/jhbuild.modules:
2108
2109 2013-05-20  Alex Christensen  <achristensen@apple.com>
2110
2111         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
2112         https://bugs.webkit.org/show_bug.cgi?id=116125
2113
2114         Reviewed by Tim Horton.
2115
2116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2117         (WTR::pathSuitableForTestResult):
2118         Changed string operations to match _drt_descriptionSuitableForTestResult.
2119         (WTR::dumpRequestDescriptionSuitableForTestResult):
2120         (WTR::dumpResponseDescriptionSuitableForTestResult):
2121         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2122         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2123         (WTR::InjectedBundlePage::willSendRequestForFrame):
2124         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2125         Pass the main frame's URL to pathSuitableForTestResult.
2126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2127         Added WKBundlePageRef to willPerformClientRedirectForFrame.
2128
2129 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
2130
2131         fix w3c test importer unit tests after r150324
2132         https://bugs.webkit.org/show_bug.cgi?id=116459
2133
2134         Reviewed by Ryosuke Niwa.
2135
2136         This patch fixes the unit tests to not actually call out to
2137         'hg' (by using a mock executive) and also changes the real
2138         directory we crawl from Source/WebCore/css to
2139         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
2140         still change this to a mock filesystem, but that's a separate change.
2141
2142         * Scripts/webkitpy/w3c/test_importer.py:
2143         (main):
2144         (TestImporter.__init__):
2145         (TestImporter.load_changeset):
2146         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2147         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
2148         (TestImporterTest.test_import_dir_with_no_tests):
2149
2150 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2151
2152         Unreviewed EFL build fix.
2153
2154         Fix linking errors due to undefined symbols on Ubuntu 13.04.
2155
2156         * DumpRenderTree/efl/CMakeLists.txt:
2157         * EWebLauncher/CMakeLists.txt:
2158         * MiniBrowser/efl/CMakeLists.txt:
2159
2160 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2161
2162         [EFL] Reenabled INDEXED_DATABASE after r150344
2163         https://bugs.webkit.org/show_bug.cgi?id=116430
2164
2165         Reviewed by Gyuyoung Kim.
2166
2167         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
2168         build was fixed in r150344.
2169
2170         * Scripts/webkitperl/FeatureList.pm:
2171
2172 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
2173
2174         [EFL] init/shutdown should be paired in EWebLauncher
2175         https://bugs.webkit.org/show_bug.cgi?id=116427
2176
2177         Reviewed by Christophe Dumez.
2178
2179         Added ecore_file_shutdown() for cleanup of ecore_file.
2180         Removed edje_init and ecore_evas_init because it was in ewk_init().
2181
2182         * EWebLauncher/main.c:
2183         (main):
2184
2185 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
2186
2187         [EFL] Add command line option to MiniBrowser to set user agent
2188         https://bugs.webkit.org/show_bug.cgi?id=116387
2189
2190         Reviewed by Christophe Dumez.
2191
2192         We need this option to compare the rendering differences according to different user agents.
2193
2194         * MiniBrowser/efl/main.c:
2195         (window_create):
2196         (elm_main):
2197
2198 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
2199
2200         Unreviewed, addressing test-webkitpy failures after r150317.
2201
2202         * Scripts/webkitpy/w3c/test_converter.py:
2203         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
2204
2205 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
2206
2207         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
2208         https://bugs.webkit.org/show_bug.cgi?id=114554
2209
2210         Reviewed by Gyuyoung Kim.
2211
2212         Using variables as target names is very uncommon in CMake.
2213         The usual way to specify the name of the resulting binary
2214         is to set the OUTPUT_NAME target property.
2215
2216         * DumpRenderTree/efl/CMakeLists.txt:
2217         * EWebLauncher/CMakeLists.txt:
2218         * ImageDiff/CMakeLists.txt:
2219         * MiniBrowser/efl/CMakeLists.txt:
2220         * TestWebKitAPI/CMakeLists.txt:
2221         * WebKitTestRunner/CMakeLists.txt:
2222         * WebKitTestRunner/PlatformEfl.cmake:
2223         * WinCELauncher/CMakeLists.txt:
2224
2225 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2226
2227         Unreviewed EFL build fix.
2228
2229         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
2230         WK2 build after r150305.
2231
2232         * Scripts/webkitperl/FeatureList.pm:
2233
2234 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
2235
2236         [GTK] Parallel build fails if gtk-doc is enabled
2237         https://bugs.webkit.org/show_bug.cgi?id=116227
2238
2239         Reviewed by Martin Robinson.
2240
2241         * GNUmakefile.am:
2242         Don't use the 'all' target to generate the documentation.
2243         The prerequisites of this target must be files that need to be
2244         built _before_ the actual compilation of WebKit starts. Since the
2245         documentation depends on WebKit being built first, this means in
2246         practice that the code will be built in parallel with the
2247         generation of its dependencies, potentially making the build fail.
2248
2249 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2250
2251         Don't run hg.
2252
2253         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2254         (TestImporterTest):
2255
2256 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
2257
2258         Create a script to import W3C tests
2259         https://bugs.webkit.org/show_bug.cgi?id=111513
2260
2261         Reviewed by Ryosuke Niwa.
2262
2263         This patch attempts to re-land the 'import-w3c-tests'
2264         script and accompanying modules.  The tests and code have
2265         been cleaned up so that we do not log anything to stdout/stderr
2266         while running the tests (thanks to outputcapture) and do not
2267         write into the source tree while running the tests, and much
2268         but not all of the code has been converted over to using the webkitpy
2269
2270         * Scripts/import-w3c-tests: Added.
2271         * Scripts/webkitpy/w3c/__init__.py: Added.
2272         * Scripts/webkitpy/w3c/test_converter.py: Added.
2273         (W3CTestConverter):
2274         (W3CTestConverter.__init__):
2275         (W3CTestConverter.path_from_webkit_root):
2276         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2277         (W3CTestConverter.convert_for_webkit):
2278         (W3CTestConverter.convert_css):
2279         (W3CTestConverter.convert_html):
2280         (W3CTestConverter.convert_testharness_paths):
2281         (W3CTestConverter.convert_prefixed_properties):
2282         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2283         (W3CTestConverter.replace_tag):
2284         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2285         (W3CTestConverterTest):
2286         (W3CTestConverterTest.fake_dir_path):
2287         (W3CTestConverterTest.test_read_prefixed_property_list):
2288         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
2289         (test_convert_for_webkit_harness_only):
2290         (test_convert_for_webkit_properties_only):
2291         (test_convert_for_webkit_harness_and_properties):
2292         (test_convert_test_harness_paths):
2293         (test_convert_prefixed_properties):
2294         (verify_conversion_happened):
2295         (verify_no_conversion_happened):
2296         (verify_test_harness_paths):
2297         (verify_prefixed_properties):
2298         (generate_test_content):
2299         * Scripts/webkitpy/w3c/test_importer.py: Added.
2300         (main):
2301         (parse_args):
2302         (validate_import_directory):
2303         (TestImporter):
2304         (TestImporter.__init__):
2305         (TestImporter.path_from_webkit_root):
2306         (TestImporter.do_import):
2307         (TestImporter.load_changeset):
2308         (TestImporter.find_importable_tests):
2309         (TestImporter.import_tests):
2310         (TestImporter.setup_destination_directory):
2311         (TestImporter.update_test_status):
2312         (TestImporter.remove_deleted_files):
2313         (TestImporter.write_import_log):
2314         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2315         (TestImporterTest):
2316         (TestImporterTest.test_import_dir_with_no_tests):
2317         * Scripts/webkitpy/w3c/test_parser.py: Added.
2318         (TestParser):
2319         (TestParser.__init__):
2320         (TestParser.load_file):
2321         (TestParser.analyze_test):
2322         (TestParser.reference_links_of_type):
2323         (TestParser.is_jstest):
2324         (TestParser.support_files):
2325         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2326         (TestParserTest):
2327         (TestParserTest.test_analyze_test_reftest_one_match):
2328         (test_analyze_test_reftest_multiple_matches):
2329         (test_analyze_test_reftest_match_and_mismatch):
2330         (test_analyze_test_reftest_with_ref_support_Files):
2331         (test_analyze_jstest):
2332         (test_analyze_pixel_test_all_true):
2333         (test_analyze_pixel_test_all_false):
2334         (test_analyze_non_html_file):
2335
2336 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2337
2338         Leaks builders exit early frequently
2339         https://bugs.webkit.org/show_bug.cgi?id=116355
2340
2341         Reviewed by Stephanie Lewis.
2342
2343         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
2344         we tolerate from 20 to 50.
2345
2346         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2347         (RunWebKitTests.start):
2348         * Scripts/webkitpy/port/mac.py:
2349         (MacPort.default_child_processes):
2350
2351 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
2352
2353         Remove chrome-channels command from the webkit-patch
2354         https://bugs.webkit.org/show_bug.cgi?id=116303
2355
2356         Reviewed by Ryosuke Niwa.
2357
2358         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
2359         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
2360         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
2361         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
2362         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
2363         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
2364
2365 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2366
2367         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
2368         Part 3 of 3: <http://webkit.org/b/116247>
2369
2370         Reviewed by Benjamin Poulain.
2371
2372         * Scripts/filter-build-webkit: Change while() loop to for() loop
2373         to track $previousLine, then pass $previousLine into
2374         shouldIgnoreLine().
2375         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
2376         line that begins with four spaces if the previous line is a
2377         linker error message.
2378         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2379         - Add "Ignored: " to test descriptions to document expected
2380           behavior.
2381         - Add comment blocks for various groups of tests.
2382         - Expand "Build settings" tests since we're changing the code in
2383           shouldIgnoreLine() that ignores those lines.
2384         - Add tests for undefined symbols error message.
2385         (description): Add.  Extract from global code.
2386
2387 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2388
2389         Add tests for shouldIgnoreLine() in filter-build-webkit
2390         Part 2 of 3: <http://webkit.org/b/116247>
2391
2392         Reviewed by Benjamin Poulain.
2393
2394         * Scripts/filter-build-webkit:
2395         (shouldIgnoreLine): Add.  Extract code from global scope into
2396         subroutine to make it testable.
2397         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
2398         Tests shouldIgnoreLine() using output from a real build
2399         transcript.
2400
2401 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2402
2403         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
2404         https://bugs.webkit.org/show_bug.cgi?id=116341
2405
2406         Reviewed by Brady Eidson.
2407
2408         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2409
2410 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
2411
2412         [Windows] Don't use pdevenv when building with VS2010.
2413         https://bugs.webkit.org/show_bug.cgi?id=116338.
2414
2415         Reviewed by Adam Roben.
2416
2417         * Scripts/webkitdirs.pm:
2418         (setupCygwinEnv): Check if we are using VS2005, and only use
2419         the 'pdevenv' hack if we are. Otherwise, just build with
2420         our standard project since it uses VS2010+'s native
2421         parallel building features.
2422
2423 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2424
2425         Unreviewed. Disable accelerated compositing until we figure out why it does not work
2426         properly in the 64 bits release bot.
2427
2428         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2429         (resetDefaultsToConsistentValues):
2430
2431 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2432
2433         Make filter-build-webkit testable using LoadAsModule
2434         Part 1 of 3: <http://webkit.org/b/116247>
2435
2436         Reviewed by Benjamin Poulain.
2437
2438         * Scripts/filter-build-webkit: Change global variables that are
2439         used in subroutines from 'my' to 'our' to make it possible to
2440         evaluate the script in a package context in LoadAsModule.pm.
2441
2442 2013-05-14  Sam Weinig  <sam@webkit.org>
2443
2444         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
2445         https://bugs.webkit.org/show_bug.cgi?id=116132
2446
2447         Reviewed by Anders Carlsson.
2448
2449         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
2450         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
2451
2452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2453         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
2454         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
2455         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2456
2457 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
2458
2459         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
2460         https://bugs.webkit.org/show_bug.cgi?id=114781
2461
2462         Reviewed by Christophe Dumez.
2463
2464         Add run_before_unload_confirm and
2465         Print the log message with "CONFIRM NAVIGATION: " in console.
2466
2467         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2468         (onBeforeUnloadConfirm):
2469         (drtViewAdd):
2470
2471 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
2472
2473         Fix Analyze ChangeLog's entry processing
2474         https://bugs.webkit.org/show_bug.cgi?id=116219
2475
2476         Reviewed by Ryosuke Niwa.
2477
2478         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2479         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
2480
2481 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
2482
2483         [Qt] UrlLoader::loadNext is broken in MiniBrowser
2484         https://bugs.webkit.org/show_bug.cgi?id=116099
2485
2486         Reviewed by Jocelyn Turcotte.
2487
2488         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
2489         are not available any more. So, UrlLoader::loadNext was broken
2490         because it failed to connect to those signals.
2491
2492         * MiniBrowser/qt/UrlLoader.cpp:
2493         (UrlLoader::UrlLoader):
2494         (UrlLoader::loadingChanged):
2495         * MiniBrowser/qt/UrlLoader.h:
2496         (UrlLoader):
2497
2498 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
2499
2500         [WebSocket] Update pywebsocket to r760
2501         https://bugs.webkit.org/show_bug.cgi?id=115863
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         Version r760 supports a newer draft of message compression.
2506         We need this update to finish the permessage compression patch in
2507         bug 98840. This patch also fixes failing unit tests after the update.
2508
2509         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
2510         (StreamBase._read):
2511         (StreamBase._read.of):
2512         (StreamBase._write):
2513         (StreamBase.receive_bytes):
2514         (StreamBase._read_until):
2515         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2516         (parse_frame):
2517         (StreamOptions.__init__):
2518         (Stream.__init__):
2519         (Stream._receive_frame_as_frame_object):
2520         (Stream._get_message_from_frame):
2521         (Stream._process_close_message):
2522         (Stream.close_connection):
2523         (Stream.get_last_received_opcode):
2524         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2525         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
2526         (Dispatcher.do_extra_handshake):
2527         (Dispatcher.transfer_data):
2528         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2529         (ExtensionProcessorInterface.__init__):
2530         (ExtensionProcessorInterface.request):
2531         (ExtensionProcessorInterface):
2532         (ExtensionProcessorInterface.name):
2533         (ExtensionProcessorInterface.check_consistency_with_other_processors):
2534         (ExtensionProcessorInterface.set_active):
2535         (ExtensionProcessorInterface.is_active):
2536         (ExtensionProcessorInterface._get_extension_response_internal):
2537         (ExtensionProcessorInterface.get_extension_response):
2538         (ExtensionProcessorInterface._setup_stream_options_internal):
2539         (ExtensionProcessorInterface.setup_stream_options):
2540         (_log_outgoing_compression_ratio):
2541         (_log_incoming_compression_ratio):
2542         (_parse_window_bits):
2543         (_AverageRatioCalculator):
2544         (_AverageRatioCalculator.__init__):
2545         (_AverageRatioCalculator.add_original_bytes):
2546         (_AverageRatioCalculator.add_result_bytes):
2547         (_AverageRatioCalculator.get_average_ratio):
2548         (DeflateFrameExtensionProcessor):
2549         (DeflateFrameExtensionProcessor.__init__):
2550         (DeflateFrameExtensionProcessor._get_extension_response_internal):
2551         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
2552         (DeflateFrameExtensionProcessor._outgoing_filter):
2553         (DeflateFrameExtensionProcessor._incoming_filter):
2554         (CompressionExtensionProcessorBase.for):
2555         (CompressionExtensionProcessorBase.__init__):
2556         (CompressionExtensionProcessorBase._get_extension_response_internal):
2557         (CompressionExtensionProcessorBase._setup_stream_options_internal):
2558         (PerFrameCompressExtensionProcessor):
2559         (PerMessageDeflateExtensionProcessor):
2560         (PerMessageDeflateExtensionProcessor.__init__):
2561         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
2562         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
2563         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
2564         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
2565         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
2566         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
2567         (PerMessageDeflateExtensionProcessor.set_bfinal):
2568         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
2569         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
2570         (_PerMessageDeflateFramer):
2571         (_PerMessageDeflateFramer.__init__):
2572         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
2573         (_PerMessageDeflateFramer._process_incoming_message):
2574         (_PerMessageDeflateFramer._process_outgoing_message):
2575         (_PerMessageDeflateFramer.setup_stream_options):
2576         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
2577         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
2578         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
2579         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
2580         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
2581         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
2582         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
2583         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
2584         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
2585         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
2586         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
2587         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
2588         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
2589         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
2590         (PerMessageCompressExtensionProcessor):
2591         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
2592         (MuxExtensionProcessor.__init__):
2593         (MuxExtensionProcessor.check_consistency_with_other_processors):
2594         (MuxExtensionProcessor):
2595         (MuxExtensionProcessor._get_extension_response_internal):
2596         (MuxExtensionProcessor._setup_stream_options_internal):
2597         (MuxExtensionProcessor.set_quota):
2598         (MuxExtensionProcessor.quota):
2599         (MuxExtensionProcessor.set_extensions):
2600         (MuxExtensionProcessor.extensions):
2601         (is_compression_extension):
2602         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2603         (validate_subprotocol):
2604         (parse_host_header):
2605         (format_header):
2606         (check_request_line):
2607         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2608         (Handshaker.do_handshake):
2609         (Handshaker._create_handshake_response):
2610         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
2611         (_validate_subprotocol):
2612         (_check_header_lines):
2613         (_build_location):
2614         (Handshaker.do_handshake):
2615         (Handshaker._set_subprotocol):
2616         (Handshaker._set_location):
2617         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
2618         (_create_dispatcher):
2619         (headerparserhandler):
2620         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
2621         (_create_add_channel_response):
2622         (_create_drop_channel):
2623         (_create_flow_control):
2624         (_create_new_channel_slot):
2625         (_create_fallback_new_channel_slot):
2626         (_MuxFramePayloadParser._read_number):
2627         (_MuxFramePayloadParser._read_size_and_contents):
2628         (_MuxFramePayloadParser._read_flow_control):
2629         (_MuxFramePayloadParser._read_new_channel_slot):
2630         (_LogicalConnection.__init__):
2631         (_LogicalConnection.write):
2632         (_LogicalConnection.on_write_data_done):
2633         (_LogicalConnection):
2634         (_LogicalConnection.on_writer_done):
2635         (_InnerMessage):
2636         (_InnerMessage.__init__):
2637         (_InnerMessageBuilder):
2638         (_InnerMessageBuilder.that):
2639         (_InnerMessageBuilder.__init__):
2640         (_InnerMessageBuilder._handle_first):
2641         (_InnerMessageBuilder._process_first_fragmented_control):
2642         (_InnerMessageBuilder._process_first_fragmented_message):
2643         (_InnerMessageBuilder._handle_fragmented_control):
2644         (_InnerMessageBuilder._reassemble_fragmented_control):
2645         (_InnerMessageBuilder._handle_fragmented_message):
2646         (_InnerMessageBuilder._reassemble_fragmented_message):
2647         (_InnerMessageBuilder.build):
2648         (_LogicalStream.__init__):
2649         (_LogicalStream._create_inner_frame):
2650         (_LogicalStream._write_inner_frame):
2651         (_LogicalStream.replenish_send_quota):
2652         (_LogicalStream.send_message):
2653         (_LogicalStream._receive_frame):
2654         (_LogicalStream._get_message_from_frame):
2655         (_LogicalStream.stop_sending):
2656         (_PhysicalConnectionWriter.__init__):
2657         (_PhysicalConnectionWriter._write_data):
2658         (_PhysicalConnectionWriter.run):
2659         (_PhysicalConnectionWriter.stop):
2660         (_Worker.run):
2661         (_MuxHandshaker.__init__):
2662         (_MuxHandshaker._create_stream):
2663         (_MuxHandshaker._create_handshake_response):
2664         (_HandshakeDeltaBase.create_headers):
2665         (_MuxHandler.start):
2666         (_MuxHandler.wait_until_done):
2667         (_MuxHandler.notify_write_data_done):
2668         (_MuxHandler._process_drop_channel):
2669         (_MuxHandler._process_logical_frame):
2670         (_MuxHandler.notify_reader_done):
2671         (_MuxHandler):
2672         (_MuxHandler.notify_writer_done):
2673         (_MuxHandler.fail_physical_connection):
2674         (_MuxHandler.fail_logical_channel):
2675         (use_mux):
2676         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2677         (_StandaloneRequest.get_uri):
2678         (_StandaloneRequest.get_unparsed_uri):
2679         (_StandaloneRequest):
2680         (_StandaloneRequest.is_https):
2681         (_import_ssl):
2682         (_import_pyopenssl):
2683         (_StandaloneSSLConnection.for):
2684         (_StandaloneSSLConnection):
2685         (_StandaloneSSLConnection.__getattribute__):
2686         (_StandaloneSSLConnection.__setattr__):
2687         (_StandaloneSSLConnection.makefile):
2688         (_StandaloneSSLConnection.shutdown):
2689         (_StandaloneSSLConnection.recv):
2690         (WebSocketServer.__init__):
2691         (WebSocketServer._create_sockets):
2692         (WebSocketServer.handle_error):
2693         (WebSocketServer.get_request):
2694         (WebSocketServer.get_request.default_callback):
2695         (WebSocketRequestHandler.parse_request):
2696         (_build_option_parser):
2697         (_main):
2698         (_main.if):
2699         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2700         (RepeatedXorMasker.__init__):
2701         (RepeatedXorMasker._mask_using_swig):
2702         (RepeatedXorMasker):
2703         (RepeatedXorMasker._mask_using_array):
2704         (_Deflater.compress_and_finish):
2705         (_RFC1979Deflater.filter):
2706         (DeflateSocket.send):
2707
2708 2013-05-16  Jonathan Liu  <net147@gmail.com>
2709
2710         Fix testing if program exists in PATH
2711         https://bugs.webkit.org/show_bug.cgi?id=116216
2712
2713         Reviewed by Jocelyn Turcotte.
2714
2715         functions.prf incorrectly uses win_cmd_shell to test whether to
2716         add .exe to the executable name when checking if it exists in
2717         the PATH environment variable. This works correctly when
2718         building using Windows Command Prompt but not under MSYS shell.
2719
2720         To resolve this, check the win32 platform scope instead of
2721         win_cmd_shell so that it correctly adds .exe to the executable
2722         name on Windows regardless of the shell used when testing if
2723         it exists in PATH.
2724
2725         * qmake/mkspecs/features/functions.prf:
2726
2727 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
2728
2729         Fix the hard-coded names of EWS bots that run tests.
2730
2731         * Scripts/webkitpy/tool/commands/queues.py:
2732         (CommitQueue.did_pass_testing_ews):
2733
2734 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2735
2736         [GTK] Build Xvfb with jhbuild
2737         https://bugs.webkit.org/show_bug.cgi?id=115907
2738
2739         Reviewed by Martin Robinson.
2740
2741         Build our own Xvfb so that we can avoid problems with the system Xvfb
2742         relying on symbols not present in our jhbuilt libraries such as pixman,
2743         and also to ensure we have the fix for a GLX module crasher.
2744
2745         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2746         (resetDefaultsToConsistentValues): enable accelerated compositing.
2747         * gtk/install-dependencies: list packages required for building Xvfb.
2748         * gtk/jhbuild.modules: add xserver as a jhbuild module.
2749         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
2750         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
2751         initializing the GLX module for Xvfb.
2752
2753 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2754
2755         [jhbuild] Should remove the sources directory as well when cleaning
2756         https://bugs.webkit.org/show_bug.cgi?id=116229
2757
2758         Reviewed by Martin Robinson.
2759
2760         * Scripts/update-webkit-libs-jhbuild:
2761         (cleanJhbuild): remove the Source directory as well when cleaning.
2762
2763 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2764
2765         [EFL] Remove Intel Wk2 Buildbots from Master
2766         https://bugs.webkit.org/show_bug.cgi?id=116149
2767
2768         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
2769         since Gyuyoung Kim from Samsung plans to take over and maintain it.
2770
2771         Reviewed by Benjamin Poulain.
2772
2773         * BuildSlaveSupport/build.webkit.org-config/config.json:
2774
2775 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
2776
2777         [Windows] Update various build tools to understand VS2010 environment.
2778         https://bugs.webkit.org/show_bug.cgi?id=116169.
2779
2780         Reviewed by Anders Carlsson.
2781
2782         * Scripts/build-api-tests: Identify VS2010 environment.
2783         * Scripts/build-dumprendertree: Ditto.
2784         * Scripts/build-webkit: Ditto.
2785         * Scripts/webkitdirs.pm:
2786         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
2787         range of acceptable SDK's.
2788
2789 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2790
2791         Allow http tests on Arch Linux
2792         https://bugs.webkit.org/show_bug.cgi?id=116155
2793
2794         Reviewed by Ryosuke Niwa.
2795
2796         * Scripts/webkitpy/port/base.py:
2797         (Port._is_arch_based): Added check for /etc/arch-release file.
2798         (Port._apache_config_file_name_for_platform): Call the check.
2799         * Scripts/webkitpy/port/port_testcase.py:
2800         (test_linux_distro_detection): Testcase added.
2801
2802 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2803
2804         Remove a leftover v8 file from the watchlist
2805         https://bugs.webkit.org/show_bug.cgi?id=116158
2806
2807         Reviewed by Csaba Osztrogonác.
2808
2809         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
2810
2811 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
2812
2813         [GTK] Fails to build while generating gtkdoc
2814         https://bugs.webkit.org/show_bug.cgi?id=115612
2815
2816         Reviewed by Philippe Normand.
2817
2818         Fix typo in the prerequisites of docs-build.stamp.
2819
2820         * GNUmakefile.am:
2821
2822 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
2823
2824         Unreviewed, fixing the current test-webkitpy failure.
2825
2826         * Scripts/webkitpy/port/mac_unittest.py:
2827         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
2828         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
2829
2830 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
2831
2832         Fix build after r150090.
2833         https://bugs.webkit.org/show_bug.cgi?id=116129
2834
2835         Unreviewed build fix after r150090.
2836
2837         * WebKitTestRunner/TestInvocation.cpp:
2838         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2839
2840 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2841
2842         [Windows, others] Unreviewed build fix after r150090.
2843
2844         * DumpRenderTree/TestRunner.cpp:
2845         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
2846         doesn't exist on other platforms.
2847
2848 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
2849
2850         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
2851         https://bugs.webkit.org/show_bug.cgi?id=115889
2852
2853         Reviewed by Benjamin Poulain.
2854
2855         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2856         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2857
2858 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2859
2860         [Windows] Identify proper run environment for scripts.
2861         https://bugs.webkit.org/show_bug.cgi?id=116114
2862
2863         Reviewed by David Kilzer.
2864
2865         Determine (based on Visual Studio version) which path to use for
2866         executables (bin versus bin32).
2867
2868         * Scripts/webkitdirs.pm:
2869         (determineVisualStudioInstallDir): Added.
2870         (determineVisualStudioVersion): Added.
2871         (determineConfigurationProductDir): Modified to choose proper bin
2872         or bin32 directory.
2873         (visualStudioVersion): Added
2874         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
2875
2876 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2877
2878         [Mac] Add tests for secure event input
2879         https://bugs.webkit.org/show_bug.cgi?id=116121
2880
2881         Reviewed by Mark Rowe.
2882
2883         * DumpRenderTree/TestRunner.cpp:
2884         (getSecureEventInputIsEnabledCallback):
2885         (TestRunner::staticValues):
2886         Expose an accessor for current secure event input state.
2887
2888         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2889         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2890         (WTR::TestRunner::secureEventInputIsEnabled):
2891         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2892         * WebKitTestRunner/TestInvocation.cpp:
2893         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2894         Expose an accessor for current secure event input state. This has to be done in
2895         UI process, as this is where it's changed by WebKit.
2896
2897 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2898
2899         [Mac] Add a testing shim for secure event input functions
2900         https://bugs.webkit.org/show_bug.cgi?id=116122
2901
2902         Reviewed by Mark Rowe.
2903
2904         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
2905         Inject WebCore testing shim library to override system framework functions.
2906
2907 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2908
2909         [Windows] Switch to embedded manifest commands for launcher executables.
2910         https://bugs.webkit.org/show_bug.cgi?id=116109
2911
2912         Reviewed by Darin Adler.
2913
2914         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
2915         now-unused WinLauncher.exe.manifest file.
2916         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2917         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
2918         when building with VS2010 or newer.
2919
2920 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2921
2922         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
2923         https://bugs.webkit.org/show_bug.cgi?id=116079
2924
2925         Reviewed by David Kilzer.
2926
2927         * Scripts/old-run-webkit-tests:
2928         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
2929
2930 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
2931
2932         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
2933         https://bugs.webkit.org/show_bug.cgi?id=115921
2934
2935         Reviewed by Gustavo Noronha Silva.
2936
2937         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
2938         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
2939
2940 2013-05-13  Alex Christensen  <achristensen@apple.com>
2941
2942         Added testRunner.setPrinting.
2943         https://bugs.webkit.org/show_bug.cgi?id=42693
2944         rdar://problem/8213845
2945
2946         Reviewed by Darin Adler.
2947
2948         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2949         Added setPrinting JavaScript function.
2950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2951         (WTR::InjectedBundlePage::dump):
2952         Dump the external representation for printing if setPrinting has been called.
2953         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2954         (WTR::TestRunner::isPrinting): Added.
2955         (WTR::TestRunner::setPrinting): Added.
2956         Added and initialized m_isPrinting member boolean.
2957
2958 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
2959
2960         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
2961         https://bugs.webkit.org/show_bug.cgi?id=116016
2962
2963         Reviewed by Dirk Pranke.
2964
2965         Same fix as in the upstream style checker, but without hg support.
2966         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
2967
2968         * Scripts/webkitpy/style/checkers/cpp.py:
2969         (FileInfo.repository_name):
2970
2971 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
2972
2973         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
2974         https://bugs.webkit.org/show_bug.cgi?id=115918
2975
2976         Reviewed by Gustavo Noronha Silva.
2977
2978         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
2979         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
2980         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
2981         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
2982         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
2983         problems.
2984
2985         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
2986         These are then used as dependencies for the archive creation rule as well as the list from which the archive
2987         file paths are constructed and then used to dump the member files from these archives. The member files are
2988         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
2989         successfully link.
2990
2991         * TestWebKitAPI/GNUmakefile.am:
2992
2993 2013-05-13  Anders Carlsson  <andersca@apple.com>
2994
2995         Remove UnusedParam.h
2996         https://bugs.webkit.org/show_bug.cgi?id=116029
2997
2998         Reviewed by Andreas Kling.
2999
3000         Stop including UnusedParam.h.
3001
3002         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3003         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3004
3005 2013-05-12  Commit Queue  <commit-queue@webkit.org>
3006
3007         Unreviewed, rolling out r149955.
3008         http://trac.webkit.org/changeset/149955
3009         https://bugs.webkit.org/show_bug.cgi?id=115990
3010
3011         Broke lots of tests (Requested by smfr on #webkit).
3012
3013         * Scripts/webkitpy/port/mac.py:
3014
3015 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3016
3017         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
3018         https://bugs.webkit.org/show_bug.cgi?id=115914
3019
3020         Reviewed by Martin Robinson.
3021
3022         * GtkLauncher/main.c:
3023         (createToolbar):
3024         * MiniBrowser/gtk/BrowserWindow.c:
3025         (_BrowserWindow):
3026         (browserWindowSetStatusText):
3027         (fullScreenMessageTimeoutCallback):
3028         (webViewEnterFullScreen):
3029         (webViewLeaveFullScreen):
3030         (browserWindowFinalize):
3031         (browserWindowConstructed):
3032         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3033         (WTR::EventSenderProxy::mouseScrollBy):
3034         (WTR::EventSenderProxy::continuousMouseScrollBy):
3035
3036 2013-05-11  Anders Carlsson  <andersca@apple.com>
3037
3038         Crash when terminating a process that has not been fully launched
3039         https://bugs.webkit.org/show_bug.cgi?id=115962
3040         <rdar://problem/13660916>
3041
3042         Reviewed by Andreas Kling.
3043
3044         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
3045         before the process has had a chance to be fully launched.
3046
3047         * TestWebKitAPI/GNUmakefile.am:
3048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3049         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
3050         (TestWebKitAPI):
3051         (TestWebKitAPI::didFinishLoadForFrame):
3052         (TestWebKitAPI::TEST):
3053         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
3054
3055 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
3056
3057         Remove Mac OS X Leopard (10.5) support
3058         https://bugs.webkit.org/show_bug.cgi?id=107964
3059
3060         Reviewed by Ryosuke Niwa.
3061
3062         Removed the code for 10.5 and removed if-def for 10.6.
3063
3064         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3065         (convertMIMEType):
3066         (createXMLStringFromWebArchiveData):
3067         * DumpRenderTree/mac/TestRunnerMac.mm:
3068         (TestRunner::authenticateSession):
3069         (TestRunner::setTextDirection):
3070         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
3071         (convertMIMEType):
3072         (createXMLStringFromWebArchiveData):
3073
3074 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
3075
3076         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
3077         https://bugs.webkit.org/show_bug.cgi?id=115935
3078
3079         Reviewed by Jer Noble.
3080
3081         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
3082         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
3083         to the new manifest file.
3084         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
3085
3086 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
3087
3088         Fix some compiler warnings (miscellaneous)
3089         https://bugs.webkit.org/show_bug.cgi?id=80790
3090
3091         Reviewed by Rob Buis.
3092
3093         Fix the following warnings for BlackBerry:
3094         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
3095         used as truth value [-Wparentheses].
3096
3097         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3098         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3099
3100 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3101
3102         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
3103         https://bugs.webkit.org/show_bug.cgi?id=115928
3104
3105         Reviewed by Kenneth Rohde Christiansen.
3106
3107         WKViewSetThemePath was moved to WKViewEfl.h.
3108
3109         * TestWebKitAPI/efl/PlatformWebView.cpp:
3110
3111 2013-05-10  Andreas Kling  <akling@apple.com>
3112
3113         I accidentally the Java testing.
3114
3115         * Scripts/webkitpy/port/mac.py:
3116
3117 2013-05-10  Brian Holt  <brian.holt@samsung.com>
3118
3119         [GTK] Module Cairo fails to build under jhbuild
3120         https://bugs.webkit.org/show_bug.cgi?id=115854
3121
3122         Reviewed by Martin Robinson.
3123
3124         Make cairo depend on glib in jhbuild.modules.
3125
3126         * gtk/jhbuild.modules:
3127
3128 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3129
3130         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
3131         https://bugs.webkit.org/show_bug.cgi?id=115904
3132
3133         Reviewed by Martin Robinson.
3134
3135         * ImageDiff/gtk/ImageDiff.cpp:
3136         (main):
3137
3138 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
3139
3140         Add my new address to contributors.json. (Unreviewed)
3141
3142         * Scripts/webkitpy/common/config/contributors.json:
3143
3144 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3145
3146         Unreviewed. Move myself to the reviewers list.
3147
3148         * Scripts/webkitpy/common/config/contributors.json:
3149
3150 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3151
3152         Unreviewed. Add my email to a few watchlists.
3153
3154         * Scripts/webkitpy/common/config/watchlist:
3155
3156 2013-05-10  Simon Pena  <simon.pena@samsung.com>
3157
3158         Unicode support missing from string representation of Contributors in committers.py
3159         https://bugs.webkit.org/show_bug.cgi?id=115859
3160
3161         Reviewed by Darin Adler.
3162
3163         Contributors, in committers.py, provided a string representation in __str__ which
3164         didn't support unicode characters, so printing a contributor would fail in that case.
3165         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
3166         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
3167
3168         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
3169         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
3170         representation.
3171         (Contributor.__str__):
3172         (Contributor):
3173         (Contributor.__unicode__):
3174         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
3175         a contributor with unicode characters can be represented as a string.
3176         (CommittersTest):
3177         (CommittersTest.test_contributor_encoding):
3178
3179 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3180
3181         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
3182         https://bugs.webkit.org/show_bug.cgi?id=92371
3183
3184         Reviewed by Brent Fulgham.
3185
3186         Use JavaScriptThreading.cpp where the same functionality is
3187         implemented too. This reduces the dependency on the pthread
3188         library. Also replace assert() with WebKit ASSERT().
3189
3190         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3191         * DumpRenderTree/win/DumpRenderTree.cpp:
3192         (dumpHistoryItem):
3193         (dumpBackForwardList):
3194         * DumpRenderTree/win/DumpRenderTree.vcproj:
3195
3196 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3197
3198         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
3199         https://bugs.webkit.org/show_bug.cgi?id=92505
3200
3201         Reviewed by Brent Fulgham.
3202
3203         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3204         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
3205         (javaScriptThreadsMutex):
3206         (javaScriptThreads):
3207         (runJavaScriptThread):
3208         (startJavaScriptThreads):
3209         (stopJavaScriptThreads):
3210         * DumpRenderTree/pthreads: Removed.
3211         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
3212
3213 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3214
3215         Unreviewed. Update Simon Pena email on his behalf.
3216
3217         * Scripts/webkitpy/common/config/contributors.json:
3218
3219 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3220
3221         Add support for [NoInterfaceObject] Web IDL extended attribute
3222         https://bugs.webkit.org/show_bug.cgi?id=115714
3223
3224         Reviewed by Kentaro Hara.
3225
3226         Update BindingsTests.generate_supplemental_dependency() to pass an
3227         additional windowConstructorsFile argument to preprocess-idls.pl.
3228
3229         * Scripts/webkitpy/bindings/main.py:
3230         (BindingsTests.generate_supplemental_dependency):
3231         (BindingsTests.main):
3232
3233 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
3234
3235         [GTK][AC] Buildfix after r149694
3236         https://bugs.webkit.org/show_bug.cgi?id=115797
3237
3238         Reviewed by Gustavo Noronha Silva.
3239
3240         Add CLUTTER_LIBS for linking TestWebCore.
3241
3242         * TestWebKitAPI/GNUmakefile.am:
3243
3244 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3245
3246         [EFL] Remove unnecessary pkgs in EFL jhbuild
3247         https://bugs.webkit.org/show_bug.cgi?id=114908
3248
3249         Reviewed by Laszlo Gombos.
3250
3251         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
3252         handle them using jhbuild. We can reduce build time when using --update-efl.
3253
3254         * efl/jhbuild.modules:
3255
3256 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
3257
3258         [EFL] Disable SHADOW DOM feature in FeatureList.pm
3259         https://bugs.webkit.org/show_bug.cgi?id=115834
3260
3261         Reviewed by Gyuyoung Kim.
3262
3263         * Scripts/webkitperl/FeatureList.pm:
3264
3265 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3266
3267         Add Scheduler for Mac MtnLion 32bit Release builder.
3268         
3269         Unreviewed.
3270         
3271         * BuildSlaveSupport/build.webkit.org-config/config.json:
3272
3273 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
3274
3275         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
3276         https://bugs.webkit.org/show_bug.cgi?id=115808
3277
3278         Reviewed by Darin Adler.
3279
3280         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
3281         was left outdated after r127191, when the m_string member was changed
3282         from UString to String. This patch calls the right pretty printer for it.
3283
3284         * gdb/webkit.py:
3285         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
3286         WTFImplPrettyPrinter.
3287
3288 2013-05-08  Andy Estes  <aestes@apple.com>
3289
3290         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
3291         https://bugs.webkit.org/show_bug.cgi?id=115790
3292
3293         Reviewed by Alexey Proskuryakov.
3294
3295         Added two API tests:
3296
3297         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
3298         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
3299
3300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3301         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
3302         (TestWebKitAPI):
3303         (TestWebKitAPI::TEST):
3304         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
3305         (TestWebKitAPI):
3306         (TestWebKitAPI::decidePolicyForNavigationAction):
3307         (CustomProtocolInvalidSchemeTest):
3308         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
3309
3310 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3311
3312         Teach buildbot how to compile 32-bit on Mac.
3313
3314         Reviewed by Ryosuke Niwa.
3315
3316         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3317         (CompileWebKit.start):
3318         (ExtractTestResultsAndLeaks):
3319
3320 2013-05-08  Eli Fidler  <efidler@blackberry.com>
3321
3322         [BlackBerry] Fix usage of BlackBerry::Platform::String
3323         https://bugs.webkit.org/show_bug.cgi?id=115781
3324
3325         Reviewed by Rob Buis.
3326
3327         BlackBerry PRs 304193 and 327181
3328         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
3329
3330         We currently have a problem where we're passing UTF-8 encoded data into
3331         the char* constructors of BlackBerry::Platform::String. This means the string
3332         thinks its data is not UTF-8.
3333
3334         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3335         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3336         (BlackBerry::WebKit::dumpHistoryItem):
3337         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3338         (TestRunner::setUserStyleSheetLocation):
3339         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3340         (LoadHTMLStringItem::invoke):
3341
3342 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
3343
3344         Tools: add new BlackBerry include dirs.
3345         https://bugs.webkit.org/show_bug.cgi?id=115514
3346
3347         Reviewed by Rob Buis.
3348
3349         iType include dirs are missing, and HarfBuzz needs to be fixed.
3350
3351         * Scripts/webkitdirs.pm:
3352         (blackberryCMakeArguments):
3353
3354 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
3355
3356         [GTK] Plumb the Automake build system for the Battery Status API feature
3357         https://bugs.webkit.org/show_bug.cgi?id=115718
3358
3359         Reviewed by Martin Robinson.
3360
3361         * Scripts/webkitdirs.pm:
3362         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
3363         through the --(enable|disable)-battery-status flag passed to configure.
3364
3365 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
3366
3367         new-run-webkit-websocketserver doesn't work after Chromium removal
3368         https://bugs.webkit.org/show_bug.cgi?id=115816
3369
3370         Reviewed by Joseph Pecoraro.
3371
3372         Fix the bug by instantiating the correct port object.
3373
3374         * Scripts/new-run-webkit-websocketserver:
3375         (main):
3376
3377 2013-05-07  Lucas Forschler  <lforschler@apple.com>
3378
3379         Configure buildbot for 32bit builder.
3380         https://bugs.webkit.org/show_bug.cgi?id=115769
3381         
3382         Reviewed by Ryosuke Niwa.
3383
3384         * BuildSlaveSupport/build.webkit.org-config/config.json:
3385
3386 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
3387
3388         Unreviewed. Update to show my apple.com address.
3389
3390         * Scripts/webkitpy/common/config/contributors.json: Added
3391         my apple.com e-mail address.
3392
3393 2013-05-08  David Kilzer  <ddkilzer@apple.com>
3394
3395         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
3396
3397         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3398         (concatenateAttributeAndValue): Switch to appendVector().
3399
3400 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3401
3402         [Qt][WTR] Fix the build on Mac after r149692
3403
3404         Unreviewed build fix.
3405
3406         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3407         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3408
3409 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
3410
3411         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
3412         to the watchlist for Accessibility.
3413
3414         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
3415         * Scripts/webkitpy/common/config/watchlist: Added myself.
3416
3417 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3418
3419         [Qt] Build fails with clang
3420         https://bugs.webkit.org/show_bug.cgi?id=115741
3421
3422         Reviewed by Benjamin Poulain.
3423
3424         Since r149112 std::move is used in AtomicString for compilers that
3425         support rvalue references and this requires a standard library
3426         implementing c++11 move semantics.
3427         We only explicitely require c++11 for WebKit2, but since clang supports
3428         rvalue references the build of subtargets using AtomicString fails because
3429         of missing std::move.
3430         It is safe to add CONFIG += c++11 for the whole project when using clang
3431         since we explicitely disable c++11 for ANGLE that had probems with libc++.
3432
3433         * qmake/mkspecs/features/unix/default_pre.prf:
3434
3435 2013-05-08  Darin Adler  <darin@apple.com>
3436
3437         Fix one more place that needed to use adoptCF/NS
3438         https://bugs.webkit.org/show_bug.cgi?id=115778
3439
3440         Reviewed by Benjamin Poulain.
3441
3442         Not sure why I missed this code last time, but found a bit more code that needs
3443         to switch to the newer style adoptCF/NS.
3444
3445         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
3446         (convertWebResourceDataToString): Use adoptCF.
3447         (convertWebResourceResponseToDictionary): Ditto.
3448         (createXMLStringFromWebArchiveData): Ditto.
3449         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
3450         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
3451
3452 2013-05-08  Commit Queue  <commit-queue@webkit.org>
3453
3454         Unreviewed, rolling out r149271.
3455         http://trac.webkit.org/changeset/149271
3456         https://bugs.webkit.org/show_bug.cgi?id=115780
3457
3458         The mangled symbols are now enforced through LDFLAGS
3459         (Requested by zdobersek on #webkit).
3460
3461         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
3462
3463 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
3464
3465         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
3466         https://bugs.webkit.org/show_bug.cgi?id=115636
3467
3468         Reviewed by Ryosuke Niwa.
3469
3470         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3471         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
3472         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
3473         while Chromium-specific, can't be removed just yet as there's more code that uses it.
3474
3475 2013-05-06  Darin Adler  <darin@apple.com>
3476
3477         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
3478         https://bugs.webkit.org/show_bug.cgi?id=115657
3479
3480         Reviewed by Sam Weinig.
3481
3482         This is similar to my last set of changes, but covers code that I missed with
3483         global replace using the Safari Xcode workspace.
3484
3485         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3486         (convertWebResourceDataToString):
3487         (convertWebResourceResponseToDictionary):
3488         (createXMLStringFromWebArchiveData):
3489         * DumpRenderTree/cg/ImageDiffCG.cpp:
3490         (createImageFromStdin):
3491         (createDifferenceImage):
3492         (main):
3493         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3494         (printPNG):
3495         (dumpBitmap):
3496         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3497         (BitmapContext::BitmapContext):
3498         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3499         (-[MockWebNotificationProvider init]):
3500         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3501         (createBitmapContext):
3502         * DumpRenderTree/mac/TestRunnerMac.mm:
3503         (TestRunner::addDisallowedURL):
3504         (TestRunner::applicationCacheDiskUsageForOrigin):
3505         (TestRunner::localStorageDiskUsageForOrigin):
3506         (TestRunner::clearApplicationCacheForOrigin):
3507         (TestRunner::deleteLocalStorageForOrigin):
3508         (TestRunner::copyDecodedHostName):
3509         (TestRunner::copyEncodedHostName):
3510         (TestRunner::queueLoad):
3511         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3512         (TestRunner::setMockGeolocationPositionUnavailableError):
3513         (TestRunner::setUserStyleSheetLocation):
3514         (TestRunner::setValueForUser):
3515         (TestRunner::overridePreference):
3516         (TestRunner::setPersistentUserStyleSheetLocation):
3517         (TestRunner::execCommand):
3518         (TestRunner::findString):
3519         (TestRunner::isCommandEnabled):
3520         (TestRunner::addOriginAccessWhitelistEntry):
3521         (TestRunner::removeOriginAccessWhitelistEntry):
3522         (TestRunner::addUserScript):
3523         (TestRunner::addUserStyleSheet):
3524         (TestRunner::evaluateInWebInspector):
3525         (TestRunner::evaluateScriptInIsolatedWorld):
3526         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3527         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3528         (TestRunner::authenticateSession):
3529         (TestRunner::grantWebNotificationPermission):
3530         (TestRunner::denyWebNotificationPermission):
3531         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3532         (createCFURLResponseFromResponseData):
3533         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3534         (LoadItem::invoke):
3535         (LoadHTMLStringItem::invoke):
3536         (ScriptItem::invoke):
3537         * DumpRenderTree/win/DumpRenderTree.cpp:
3538         (substringFromIndex):
3539         (urlSuitableForTestResult):
3540         (lastPathComponent):
3541         (sharedCFURLCache):
3542         * DumpRenderTree/win/ImageDiffCairo.cpp:
3543         (createImageFromStdin):
3544         (main):
3545         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3546         (createBitmapContextFromWebView):
3547         * DumpRenderTree/win/TestRunnerWin.cpp:
3548         (TestRunner::setUserStyleSheetLocation):
3549         (TestRunner::setPersistentUserStyleSheetLocation):
3550         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3551         (TestWebKitAPI::TEST):
3552         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
3553         (TestWebKitAPI::TEST):
3554         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3555         (TestWebKitAPI::TEST):
3556         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3557         (TestWebKitAPI::TEST):
3558         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3559         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3560         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
3561         (TestWebKitAPI::createWindow):
3562         (TestWebKitAPI::TEST):
3563         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3564         (TestWebKitAPI::TEST):
3565         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3566         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3567         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3568         (TestWebKitAPI::TEST):
3569         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
3570         (TestWebKitAPI::TEST):
3571         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
3572         (TestWebKitAPI::TEST):
3573         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3574         (TestWebKitAPI::TEST):
3575         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
3576         (TestWebKitAPI::TEST):
3577         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3578         (TestWebKitAPI::TEST):
3579         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
3580         (TestWebKitAPI::TEST):
3581         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3582         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3583         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3584         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
3585         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3586         (TestWebKitAPI::TEST):
3587         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3588         (TestWebKitAPI::TEST):
3589         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3590         (TestWebKitAPI::TEST):
3591         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
3592         (TestWebKitAPI::TEST):
3593         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3594         (TestWebKitAPI::TEST):
3595         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3596         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3597         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
3598         (TestWebKitAPI::TEST):
3599         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3600         (TestWebKitAPI::TEST):
3601         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3602         (TestWebKitAPI::TEST):
3603         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3604         (TestWebKitAPI::TEST):
3605         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
3606         (TestWebKitAPI::TEST):
3607         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3608         (TestWebKitAPI::TEST):
3609         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
3610         (TestWebKitAPI::TEST):
3611         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3612         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3613         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3614         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3615         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3616         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
3617         (WTR::testPathFromURL):
3618         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3619         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3620         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3621         (WTR::createCGContextFromImage):
3622         (WTR::dumpBitmap):
3623         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3624         * WebKitTestRunner/mac/EventSenderProxy.mm:
3625         (WTR::EventSenderProxy::mouseScrollBy):
3626         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3627         (WTR::PlatformWebView::windowSnapshotImage):
3628         * WebKitTestRunner/win/TestControllerWin.cpp:
3629         (WTR::TestController::initializeTestPluginDirectory):
3630         Use adoptCF and adoptNS.
3631
3632 2013-05-07  Alex Christensen  <achristensen@apple.com>
3633
3634         Fix a memory leak introduced in r149692
3635         https://bugs.webkit.org/show_bug.cgi?id=115766
3636
3637         Reviewed by Mark Rowe.
3638
3639         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
3640         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
3641
3642         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3643         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3644         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
3645
3646 2013-05-07  Darin Adler  <darin@apple.com>
3647
3648         [Win] Fix storage leak in Windows DumpRenderTree
3649         https://bugs.webkit.org/show_bug.cgi?id=115651
3650
3651         Reviewed by Sam Weinig.