Tools: Make sure that DataTypes.h is in the binary drop.
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
2
3         Make sure that DataTypes.h is in the binary drop.
4
5         Rubber stamped by Michael Saboff.
6
7         * Scripts/export-llvm-build:
8
9 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
10
11         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
12         https://bugs.webkit.org/show_bug.cgi?id=122566
13
14         Reviewed by Mark Rowe.
15
16         * Scripts/configure-llvm:
17
18 2013-10-10  Mark Rowe  <mrowe@apple.com>
19
20         <rdar://problem/13341666> WebKit should always build against an SDK.
21
22         Have all projects default to building against the OS X Internal SDK for the Production
23         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
24         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
25
26         Reviewed by Dan Bernstein.
27
28         * DumpRenderTree/mac/Configurations/Base.xcconfig:
29         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
30         * MiniBrowser/Configurations/Base.xcconfig:
31         * MiniBrowser/Configurations/DebugRelease.xcconfig:
32         * TestWebKitAPI/Configurations/Base.xcconfig:
33         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
34         * WebKitTestRunner/Configurations/Base.xcconfig:
35         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
36
37 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
38
39         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
40
41         * Scripts/run-gtk-tests:
42         (TestRunner): skip TestInspectorServer.
43
44 2013-10-10  Andres Gomez  <agomez@igalia.com>
45
46         [GTK] Provide search functionality to MiniBrowser
47         https://bugs.webkit.org/show_bug.cgi?id=117631
48
49         Reviewed by Carlos Garcia Campos.
50
51         Adds a search bar to MiniBrowser with the minimum functionality
52         and a new button to the toolbar for showing the new search
53         bar. Typical keyboard shortcuts are also added.
54
55         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
56         (doSearch):
57         (searchNext):
58         (searchPrevious):
59         (searchCloseButtonClickedCallback):
60         (searchEntryMenuIconPressedCallback):
61         (searchEntryClearIconReleasedCallback):
62         (searchEntryChangedCallback):
63         (searchEntryActivatedCallback):
64         (searchPrevButtonClickedCallback):
65         (searchNextButtonClickedCallback):
66         (searchMenuCheckButtonToggledCallback):
67         (browser_search_bar_init):
68         (browserSearchBarFinalize):
69         (browser_search_bar_class_init):
70         (browser_search_bar_new):
71         (browser_search_bar_add_accelerators):
72         (browser_search_bar_open):
73         (browser_search_bar_close):
74         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
75         * MiniBrowser/gtk/BrowserWindow.c:
76         (webViewEnterFullScreen): Closes new search bar.
77         (webViewLeaveFullScreen): Opens new search bar if previously
78         visible.
79         (searchCallback): Added. Shows and hides the new search bar.
80         (browser_window_init): Added search button to the toolbar.
81         (browserWindowConstructed): Creates the new search bar.
82         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
83
84 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
85
86         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
87         https://bugs.webkit.org/show_bug.cgi?id=122552
88
89         Reviewed by Darin Adler.
90
91         * Scripts/webkitpy/common/checkout/commitinfo.py:
92         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
93         will cause UnicodeDecodeError for non-ascii characters.
94
95 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
96
97         Would like a link to dashboard from build.webkit.org main page
98         https://bugs.webkit.org/show_bug.cgi?id=122577
99
100         Reviewed by Tim Hatcher.
101
102         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
103
104 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
105
106         [Win] Check for MathML fonts and warn user if they are missing.
107         https://bugs.webkit.org/show_bug.cgi?id=122568
108
109         Reviewed by Tim Horton.
110
111         * Scripts/webkitdirs.pm:
112         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
113         Windows-specific code I added previously.
114         (fontExists): Added
115         (checkInstalledTools): Add check for MathML fonts.
116
117 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
118
119         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
120         https://bugs.webkit.org/show_bug.cgi?id=122471
121
122         Reviewed by Tim Hatcher.
123
124         Added links to webkitpy, webkitperl and bindings-tests results.
125
126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
127         (Buildbot.prototype.apiTestResultsURLForIteration):
128         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
129         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
130         (Buildbot.prototype.bindingsTestResultsURLForIteration):
131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
132         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
133
134 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
135
136         Move some functions from WebKitBuildbot to Buildbot class.
137
138         Suggested by Tim Hatcher.
139
140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
141         (Buildbot.prototype.javascriptTestResultsURLForIteration):
142         (Buildbot.prototype.apiTestResultsURLForIteration):
143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
144         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
145
146 2013-10-09  Timothy Hatcher  <timothy@apple.com>
147
148         Add API tests to the Dashbord page.
149
150         https://bugs.webkit.org/show_bug.cgi?id=122283
151
152         Reviewed by Timothy Hatcher.
153
154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
155         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
157         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
158
159 2013-10-09  Timothy Hatcher  <timothy@apple.com>
160
161         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
162
163         https://bugs.webkit.org/show_bug.cgi?id=122515
164
165         Reviewed by Alexey Proskuryakov.
166
167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
168         (BuildbotIteration.prototype.update):
169
170 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
171
172         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
173         https://bugs.webkit.org/show_bug.cgi?id=122573
174
175         Reviewed by Tim Hatcher.
176
177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
178         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
179
180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
181         (Buildbot.prototype.buildPageURLForIteration): Added.
182
183 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
184
185         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
186         https://bugs.webkit.org/show_bug.cgi?id=122569
187
188         Reviewed by Tim Hatcher.
189
190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
191         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
192         to be produced by the old Mozilla test harness that we don't use any more.
193
194 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
195
196         Add GTK 64 bits release to the buildbot dashboard
197         https://bugs.webkit.org/show_bug.cgi?id=122548
198
199         Reviewed by Darin Adler.
200
201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
203         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
205         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
206
207 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
208
209         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
210         https://bugs.webkit.org/show_bug.cgi?id=120638
211
212         Reviewed by Gustavo Noronha Silva.
213
214         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
215         can check both the old and new APIs to retrieve text at a given offset.
216
217 2013-10-08  Alex Christensen  <achristensen@webkit.org>
218
219         Improved WinLauncher.
220         https://bugs.webkit.org/show_bug.cgi?id=122536
221
222         Reviewed by Brent Fulgham.
223
224         * WinLauncher/PrintWebUIDelegate.cpp:
225         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
226         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
227         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
228         * WinLauncher/WinLauncher.cpp:
229         (createCrashReport): Use the executable name instead of "WinLauncher".
230         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
231         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
232         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
233
234 2013-10-08  Mark Lam  <mark.lam@apple.com>
235
236         Fix ruby LoadError when running run-javascriptcore-tests.
237         https://bugs.webkit.org/show_bug.cgi?id=122519.
238
239         Reviewed by Mark Hahnenberg.
240
241         The scripts needed to explicitly require 'rubygems' for older versions of ruby
242         (versions before 1.9).
243
244         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
245         * Scripts/run-jsc-stress-tests:
246
247 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
248
249         Unreviewed, add my new email to contributors.json.
250
251         * Scripts/webkitpy/common/config/contributors.json:
252
253 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
254
255         Unreviewed build correction.
256
257         * Scripts/webkitpy/port/win.py:
258         (WinPort.write_registry_value): Use string representation of error message to avoid
259         format conversion problem.
260
261 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
262
263         [Win] Add checks for proper build and test environment
264         https://bugs.webkit.org/show_bug.cgi?id=122466
265
266         Reviewed by Darin Adler.
267
268         This patch makes two changes:
269         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
270            error messages so that people know what to fix to get things working.
271         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
272            the various environment settings are properly configured for our test environment.
273
274         * Scripts/webkitdirs.pm:
275         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
276         caused problems in the past.
277         (setupAppleWinEnv):
278         * Scripts/webkitpy/port/win.py:
279         (WinPort):
280         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
281         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
282         DWORD, etc.)
283         (WinPort.write_registry_string): Revise to call new generic registry write function.
284         (WinPort.setup_crash_log_saving): Revise for new API
285         (WinPort.restore_crash_log_saving): Ditto
286         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
287         servers from running.
288         (WinPort.allow_error_dialogs): Ditto.
289         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
290         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
291
292 2013-10-08  Philippe Normand  <pnormand@igalia.com>
293
294         [GStreamer] enable v4l2 plugin
295         https://bugs.webkit.org/show_bug.cgi?id=122503
296
297         Reviewed by Martin Robinson.
298
299         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
300         we updated our GStreamer version to 1.0.8.
301
302 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
303
304         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
305         https://bugs.webkit.org/show_bug.cgi?id=122104
306
307         Reviewed by Chris Fleizach.
308
309         Updated stringAttributeValue to double check that the exposure of
310         aria-invalid as a state is consistent with its exposure as a text
311         attribute as well, when it applies (implementations of AtkText).
312
313         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
314         (AccessibilityUIElement::stringAttributeValue): Add double check.
315         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
316         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
317
318 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
319
320         run-jsc-stress-tests progress meter should update more quickly on older Rubies
321         https://bugs.webkit.org/show_bug.cgi?id=122459
322
323         Reviewed by Darin Adler.
324
325         * Scripts/run-jsc-stress-tests:
326
327 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
328
329         [buildbot] parse tests that are reported as crashed correctly for GTK+
330         https://bugs.webkit.org/show_bug.cgi?id=122476
331
332         Reviewed by Martin Robinson.
333
334         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
335         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
336         as a failure of the API tests.
337
338 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
339
340         Unreviewed. Skipping API test that is causing the next one to crash,
341         see https://bugs.webkit.org/show_bug.cgi?id=121970.
342
343         * Scripts/run-gtk-tests:
344         (TestRunner):
345
346 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
347
348         [GTK] run-gtk-tests does not distinguish between failure and crashes
349         https://bugs.webkit.org/show_bug.cgi?id=122135
350
351         Reviewed by Martin Robinson.
352
353         The GTK+ API test runner does not distinguish between failures and crashes. This change
354         makes it do that, so it's easier for us to spot the more important/higher priority crash
355         case.
356
357         * Scripts/run-gtk-tests:
358         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
359         so we have more information on how the process ended.
360         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
361         (TestRunner.run_tests): report crashes.
362
363 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
364
365         [GTK] Missing packages for APT on install-dependencies
366         https://bugs.webkit.org/show_bug.cgi?id=121555
367
368         Reviewed by Martin Robinson.
369
370         * gtk/install-dependencies: add packages that are needed for
371         building WebKit itself and the jhbuild dependencies.
372
373 2013-10-07  Anders Carlsson  <andersca@apple.com>
374
375         Fix test failures.
376
377         * Scripts/webkitpy/port/base.py:
378         (Port.to.start_helper):
379         * Scripts/webkitpy/port/mock_drt.py:
380         (MockDRTPort.start_helper):
381
382 2013-10-07  Anders Carlsson  <andersca@apple.com>
383
384         Always force discrete mode when running layout tests
385         https://bugs.webkit.org/show_bug.cgi?id=122465
386
387         Reviewed by Tim Horton.
388
389         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
390         
391         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
392         Link with IOKit.
393
394         * DumpRenderTree/mac/LayoutTestHelper.m:
395         (installLayoutTestColorProfile):
396         Check installColorProfile.
397
398         (restoreUserColorProfile):
399         Check installColorProfile.
400
401         (lockDownDiscreteGraphics):
402         New function to force discrete graphics.
403
404         (main):
405         Add '--install-color-profile' option.
406
407         * Scripts/webkitpy/layout_tests/controllers/manager.py:
408         (Manager._set_up_run):
409         Always start the helper, but pass self._options.pixel_tests to it.
410
411         * Scripts/webkitpy/port/mac.py:
412         (MacPort.start_helper):
413         Pass --install-color-profile' to the helper if pixel_tests is true.
414
415 2013-10-07  Timothy Hatcher  <timothy@apple.com>
416
417         Properly count binding test failures as failures.
418
419         Fix the total for multiple failures in different steps too by avoiding undefined.
420
421         https://bugs.webkit.org/show_bug.cgi?id=122232
422
423         Reviewed by Alexey Proskuryakov.
424
425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
426         (BuildbotTestResults):
427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
428         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
429
430 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
431
432         [GTK] Fails to build with jhbuild with newer system glib
433         https://bugs.webkit.org/show_bug.cgi?id=122132
434
435         Reviewed by Martin Robinson.
436
437         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
438         started relying on. glib is not a dependency that should change test results, and is provided in
439         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
440         should not be an issue.
441
442         * gtk/jhbuild.modules:
443
444 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
445
446         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
447         https://bugs.webkit.org/show_bug.cgi?id=122437
448
449         Reviewed by Antoine Quint.
450
451         * Scripts/run-jsc-stress-tests:
452
453 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
454
455         Unreviewed, fix build on old Rubies.
456
457         * Scripts/run-jsc-stress-tests:
458
459 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
460
461         Unified test infrastructure via the jsc shell
462         https://bugs.webkit.org/show_bug.cgi?id=120696
463
464         Reviewed by Oliver Hunt.
465         
466         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
467         output (silent or noisy) and different styles of test failure (just bad exit code,
468         text diff, filtering for some magical text, etc.). This allows me to get rid of the
469         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
470         running in run-jsc-stress-tests.
471         
472         Also removes all of the code paths that defended against not having shellwords. Just
473         install the shellwords gem if you want to run tests.
474         
475         Also removes the non-parallel test running code. No reason for it to exist anymore.
476         
477         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
478         as part of this patch, and left three more as new bugzillas.
479
480         * Scripts/create-mozilla-js-test-list: Added.
481         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
482         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
483         * Scripts/run-javascriptcore-tests:
484         * Scripts/run-jsc-stress-tests:
485
486 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
487
488         run-jsc-stress-tests should be less verbose
489         https://bugs.webkit.org/show_bug.cgi?id=122397
490
491         Reviewed by Sam Weinig.
492         
493         It now just prints something like:
494         
495          965/1831 ....
496         
497         Where the first number is the number of tests that completed, the second number is the
498         number of tests total, and the dots are the number of tests running right now - which is
499         useful towards the end when you're waiting for the last slow tests to finish.
500         
501         It will also print out the output from failing tests and it will print a line for skipped
502         tests (to annoy you into getting them into a shape where they can be unskipped). For
503         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
504
505         * Scripts/run-jsc-stress-tests:
506
507 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
508
509         Allow skipping of run-jsc-stress-tests that are configured using yaml files
510         https://bugs.webkit.org/show_bug.cgi?id=122385
511
512         Reviewed by Sam Wieinig.
513         
514         Make tests run via YAML be able to do the parse-for-commands trick that allows
515         us to skip tests and do other custom per-test stuff.
516
517         * Scripts/jsc-stress-test-helpers/layout-test-helper:
518         * Scripts/run-jsc-stress-tests:
519
520 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
521
522         Unreviewed, fix tests on older Rubies.
523
524         * Scripts/run-jsc-stress-tests:
525
526 2013-10-05  Anders Carlsson  <andersca@apple.com>
527
528         Don't filter the weak symbols.
529
530         * Scripts/check-for-weak-vtables-and-externals:
531
532 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
533
534         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
535         https://bugs.webkit.org/show_bug.cgi?id=122376
536
537         Reviewed by Mark Hahnenberg.
538
539         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
540         * Scripts/run-javascriptcore-tests:
541         (printThingsFound):
542         * Scripts/run-jsc-stress-tests:
543
544 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
545
546         It should be even easier to run and debug a failing JSC stress test
547         https://bugs.webkit.org/show_bug.cgi?id=122337
548
549         Reviewed by Oliver Hunt.
550         
551         If a test fails, you can now just say:
552
553         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
554
555         and get the reproduction. You don't have to set any environment variables like before.
556         Also if you want to debug the failing test you can now just say:
557
558         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
559
560         Broadly, any arguments passed to the reproduction script are prepended to the command to
561         run the test. This is sort of quirky and won't work for some tests (for example the
562         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
563         them and that's good enough for now.
564
565         * Scripts/run-jsc-stress-tests:
566
567 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
568
569         [Windows] Correct run-path when using 64-bit binaries.
570
571         Reviewed by David Kilzer.
572
573         * Scripts/webkitdirs.pm:
574         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
575         directory. Otherwise use the existing 'bin32' directory.
576
577 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
578
579         Teach webkitdirs.pm to honor the --64-bit flag
580         https://bugs.webkit.org/show_bug.cgi?id=122357
581
582         Reviewed by David Kilzer.
583
584         * Scripts/webkitdirs.pm:
585         (argumentsForConfiguration): Modify to check if --64-bit is supplied
586         by the user.
587         (findMatchingArguments): Added.
588         (hasArgument): Added.
589         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
590         findMatchingArguments subroutine.
591
592 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
593
594         Update svn-config for new Visual Studio extensions
595         https://bugs.webkit.org/show_bug.cgi?id=122344
596
597         Reviewed by Brent Fulgham.
598
599         * svn-config: Add new Visual Studio extensions.
600
601 2013-10-04  Alex Christensen  <achristensen@webkit.org>
602
603         Made WinLauncher have better error handling, crash reporting, and modifiability.
604         https://bugs.webkit.org/show_bug.cgi?id=122319
605
606         Reviewed by Brent Fulgham.
607
608         * WinLauncher/WinLauncher.cpp:
609         (WinLauncherWebHost::didFailProvisionalLoadWithError):
610         Don't display the numerous "Cancelled" messages that are obviously from the user.
611         (createCrashReport): Added.
612         (dllLauncherEntryPoint):
613         Made main loop back into while loop and write a crash report if it crashes.
614         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
615         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
616         Added WinLauncherReplace.h.
617         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
618         Added linking to DbgHelp.lib.
619         * WinLauncher/WinLauncherReplace.h:
620         Added to make modifying WinLauncher behaviour and appearance easy.
621         (processCrashDump): Added.
622
623 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
624
625         remove dpranke from webkitpy watchlist
626         https://bugs.webkit.org/show_bug.cgi?id=122331
627
628         Reviewed by Brent Fulgham.
629
630         * Scripts/webkitpy/common/config/watchlist:
631
632 2013-10-04  Tim Horton  <timothy_horton@apple.com>
633
634         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
635         https://bugs.webkit.org/show_bug.cgi?id=122299
636
637         Reviewed by Beth Dakin.
638
639         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
640         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
641         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
642
643 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
644
645         Watchlist is broken after <http://trac.webkit.org/r156880>
646
647         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
648
649 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
650
651         Remove Qt features from build and test tools
652         https://bugs.webkit.org/show_bug.cgi?id=122312
653
654         Reviewed by Anders Carlsson.
655
656         * Scripts/build-dumprendertree:
657         * Scripts/build-jsc:
658         * Scripts/build-webkit:
659         * Scripts/build-webkittestrunner:
660         * Scripts/old-run-webkit-tests:
661         (openDumpTool):
662         (buildPlatformResultHierarchy):
663         (buildPlatformTestHierarchy):
664         (readSkippedFiles):
665         * Scripts/run-launcher:
666         * Scripts/run-qtwebkit-tests: Removed.
667         * Scripts/run-webkit-tests:
668         (useNewRunWebKitTests):
669         * Scripts/update-webkit:
670         * Scripts/webkit-build-directory:
671         * Scripts/webkitdirs.pm:
672         (argumentsForConfiguration):
673         (jscProductDir):
674         (builtDylibPathForName):
675         (isAppleWebKit):
676         (launcherPath):
677         (launcherName):
678         (checkRequiredSystemConfig):
679         (setupCygwinEnv):
680         (copyInspectorFrontendFiles):
681         (setPathForRunningWebKitApp):
682         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
683         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
684         (BaselineOptimizerTest.test_mac_future):
685         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
686         (BaselineOptimizerTest.test_common_directory_includes_root):
687         (BaselineOptimizerTest.test_virtual_ports_filtered):
688         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
689         (test_parse_reviewer_text):
690         * Scripts/webkitpy/common/config/watchlist:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
692         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
693         * Scripts/webkitpy/port/base.py:
694         (Port.__init__):
695         (Port._port_flag_for_scripts):
696         (Port._wk2_port_name):
697         * Scripts/webkitpy/port/builders.py:
698         * Scripts/webkitpy/port/factory.py:
699         (platform_options):
700         (PortFactory):
701         (PortFactory._default_port):
702         * Scripts/webkitpy/port/factory_unittest.py:
703         (FactoryTest.test_gtk):
704         * Scripts/webkitpy/port/qt.py: Removed.
705         * Scripts/webkitpy/port/qt_unittest.py: Removed.
706         * Scripts/webkitpy/style/checker.py:
707         * Scripts/webkitpy/style/checker_unittest.py:
708         (GlobalVariablesTest.test_path_rules_specifier):
709         * Scripts/webkitpy/style/checkers/cmake.py:
710         (CMakeChecker):
711         * Scripts/webkitpy/style/checkers/cpp.py:
712         (_classify_include):
713         (check_include_line):
714         (check_identifier_name_in_declaration):
715         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
716         (OrderOfIncludesTest.test_classify_include):
717         (WebKitStyleTest.test_names):
718         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
719         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
720         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
721         (TestRebaselineTest.test_baseline_directory):
722         * Scripts/webkitpy/tool/main.py:
723         (WebKitPatch):
724
725 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
726
727         Unreviewed. Add myself to some watchlists.
728
729         * Scripts/webkitpy/common/config/watchlist:
730
731 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
732
733         Remove Qt builders from the flakiness dashboard.
734
735         * TestResultServer/static-dashboards/builders.jsonp:
736         * TestResultServer/static-dashboards/flakiness_dashboard.js:
737         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
738         * TestResultServer/static-dashboards/loader_unittests.js:
739
740 2013-10-03  Tim Horton  <timothy_horton@apple.com>
741
742         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
743         https://bugs.webkit.org/show_bug.cgi?id=122299
744
745         Reviewed by Beth Dakin.
746
747         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
748         Disable threaded scrolling.
749
750         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
751         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
752         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
753
754 2013-10-03  Anders Carlsson  <andersca@apple.com>
755
756         Use numeric strings in the OS version dictionary
757         https://bugs.webkit.org/show_bug.cgi?id=122300
758
759         Reviewed by Mark Rowe.
760
761         * Scripts/webkitpy/common/system/platforminfo.py:
762         (PlatformInfo._determine_mac_version):
763
764 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
765
766         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
767
768         Rubber-stamped by Tim Horton.
769
770         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
771         (LeaksViewer._displayURLPrompt):
772
773 2013-10-03  Dan Bernstein  <mitz@apple.com>
774
775         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
776         https://bugs.webkit.org/show_bug.cgi?id=122260
777
778         Reviewed by Alexey Proskuryakov.
779
780         For the API to work, the tests need to be compiled with a newer version of the LLVM
781         compiler. Until the bots are updated to that version, disable the tests on 10.8.
782
783         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
784
785 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
786
787         [ATK] Expose aria-invalid as a text attribute (not object attribute)
788         https://bugs.webkit.org/show_bug.cgi?id=122015
789
790         Reviewed by Chris Fleizach.
791
792         Adapted DRT and WKTR to check the exposure of the aria-invalid
793         attribute as a text attribute, instead of an object attribute.
794
795         Also, done some refactoring of the code to try to keep things
796         simpler and more coherent, by defining new helper functions,
797         simplifying code, moving static variables and functions into
798         unnammed namespaces and so on, without altering the logic other
799         than for checking the text attribute for aria-invalid.
800
801         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
802         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
803         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
804         Also, never return an empty string if not falling through any of
805         the cases checked here, and return the original attribute instead.
806         (atkAttributeValueToCoreAttributeValue): New helper function to
807         match the attributes values returned by the ATK wrapper with the
808         values expected by the layout tests. Moved the mappings for the
809         values of AXSortDirection here as well.
810         (getAttributeSet): New helper function to retrieve a list of
811         attributes (an AtkAttributeSet) from an AtkObject using the right
812         API depending on whether we want the object attributes or the text
813         attributes (in case the object implements AtkText).
814         (getAttributeSetValueForId): Simplified by using getAttributeSet
815         and atkAttributeValueToCoreAttributeValue. Also, added a new
816         parameter to indicater whether we are interested in object
817         attributes or text attributes.
818         (getAtkAttributeSetAsString): Ditto.
819         (attributesOfElement): Updated to pass the new required parameter
820         to getAtkAttributeSetAsString, indicating that we want the object
821         attributes in this case, for backwards compatibility.
822         (indexRangeInTable): Moved up in the file into the unnammed namespace.
823         (alterCurrentValue): Ditto.
824         (AccessibilityUIElement::stringAttributeValue): After moving most
825         of the code here to the new helper functions, simplified it by
826         just checking whether the required attribute is provided as an
827         object attribute or, if that's not the case, as a text attribute.
828         (AccessibilityUIElement::isAttributeSupported): Ditto.
829         (AccessibilityUIElement::intValue): Updated to pass the new
830         required parameter to getAttributeSetValueForId, indicating that
831         we want the object attributes in this case.
832         (AccessibilityUIElement::hasPopup): Ditto.
833
834         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
835         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
836         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
837         (WTR::getAttributeSet): Ditto.
838         (WTR::getAttributeSetValueForId): Ditto.
839         (WTR::getAtkAttributeSetAsString): Ditto.
840         (WTR::attributesOfElement): Ditto.
841         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
842         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
843         (WTR::AccessibilityUIElement::intValue): Ditto.
844         (WTR::AccessibilityUIElement::hasPopup): Ditto.
845
846 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
847
848         EWS build fix after the Qt EWS removal.
849
850         * QueueStatusServer/model/attachment.py:
851         (Attachment._calculate_queue_positions):
852
853 2013-10-02  Anders Carlsson  <andersca@apple.com>
854
855         Remove Qt code from Tools/
856         https://bugs.webkit.org/show_bug.cgi?id=122227
857
858         Reviewed by Andreas Kling.
859
860         * DumpRenderTree/WorkQueue.cpp:
861         * DumpRenderTree/blackberry/src.pro: Removed.
862         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
863         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
864         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
865         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
866         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
867         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
868         * DumpRenderTree/qt/EventSenderQt.h: Removed.
869         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
870         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
871         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
872         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
873         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
874         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
875         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
876         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
877         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
878         * DumpRenderTree/qt/resources/user.css: Removed.
879         * DumpRenderTree/qt/testplugin.cpp: Removed.
880         * DumpRenderTree/qt/testplugin.h: Removed.
881         * ImageDiff/ImageDiff.pro: Removed.
882         * ImageDiff/qt/ImageDiff.cpp: Removed.
883         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
884         * MiniBrowser/qt/BrowserWindow.h: Removed.
885         * MiniBrowser/qt/MiniBrowser.pro: Removed.
886         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
887         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
888         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
889         * MiniBrowser/qt/UrlLoader.cpp: Removed.
890         * MiniBrowser/qt/UrlLoader.h: Removed.
891         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
892         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
893         * MiniBrowser/qt/icons/contents_width.png: Removed.
894         * MiniBrowser/qt/icons/favicon.png: Removed.
895         * MiniBrowser/qt/icons/find.png: Removed.
896         * MiniBrowser/qt/icons/folder.png: Removed.
897         * MiniBrowser/qt/icons/info.png: Removed.
898         * MiniBrowser/qt/icons/next.png: Removed.
899         * MiniBrowser/qt/icons/plus.png: Removed.
900         * MiniBrowser/qt/icons/previous.png: Removed.
901         * MiniBrowser/qt/icons/refresh.png: Removed.
902         * MiniBrowser/qt/icons/stop.png: Removed.
903         * MiniBrowser/qt/icons/titlebar.png: Removed.
904         * MiniBrowser/qt/icons/touch.png: Removed.
905         * MiniBrowser/qt/icons/touchpoint.png: Removed.
906         * MiniBrowser/qt/icons/up.png: Removed.
907         * MiniBrowser/qt/js/MultiSelect.js: Removed.
908         * MiniBrowser/qt/main.cpp: Removed.
909         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
910         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
911         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
912         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
913         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
914         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
915         * MiniBrowser/qt/qml/Dialog.qml: Removed.
916         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
917         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
918         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
919         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
920         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
921         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
922         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
923         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
924         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
925         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
926         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
927         * MiniBrowser/qt/raw/Target.pri: Removed.
928         * MiniBrowser/qt/raw/View.cpp: Removed.
929         * MiniBrowser/qt/raw/View.h: Removed.
930         * MiniBrowser/qt/utils.cpp: Removed.
931         * MiniBrowser/qt/utils.h: Removed.
932         * QtTestBrowser/QtTestBrowser.pro: Removed.
933         * QtTestBrowser/QtTestBrowser.qrc: Removed.
934         * QtTestBrowser/cookiejar.cpp: Removed.
935         * QtTestBrowser/cookiejar.h: Removed.
936         * QtTestBrowser/favicon.png: Removed.
937         * QtTestBrowser/fpstimer.cpp: Removed.
938         * QtTestBrowser/fpstimer.h: Removed.
939         * QtTestBrowser/launcherwindow.cpp: Removed.
940         * QtTestBrowser/launcherwindow.h: Removed.
941         * QtTestBrowser/locationedit.cpp: Removed.
942         * QtTestBrowser/locationedit.h: Removed.
943         * QtTestBrowser/mainwindow.cpp: Removed.
944         * QtTestBrowser/mainwindow.h: Removed.
945         * QtTestBrowser/qttestbrowser.cpp: Removed.
946         * QtTestBrowser/urlloader.cpp: Removed.
947         * QtTestBrowser/urlloader.h: Removed.
948         * QtTestBrowser/useragentlist.txt: Removed.
949         * QtTestBrowser/utils.cpp: Removed.
950         * QtTestBrowser/utils.h: Removed.
951         * QtTestBrowser/webinspector.h: Removed.
952         * QtTestBrowser/webpage.cpp: Removed.
953         * QtTestBrowser/webpage.h: Removed.
954         * QtTestBrowser/webview.cpp: Removed.
955         * QtTestBrowser/webview.h: Removed.
956         * TestWebKitAPI/DerivedSources.pri: Removed.
957         * TestWebKitAPI/InjectedBundle.pri: Removed.
958         * TestWebKitAPI/PlatformWebView.h:
959         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
960         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
961         * TestWebKitAPI/Tests.pri: Removed.
962         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
963         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
964         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
965         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
966         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
967         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
968         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
969         * TestWebKitAPI/qt/main.cpp: Removed.
970         * Tools.pro: Removed.
971         * WebKitTestRunner/DerivedSources.pri: Removed.
972         * WebKitTestRunner/EventSenderProxy.h:
973         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
974         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
975         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
976         (WTR::InjectedBundlePage::resetAfterTest):
977         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
978         (WTR::InjectedBundlePage::didClearWindowForFrame):
979         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
980         * WebKitTestRunner/InjectedBundle/TestRunner.h:
981         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
982         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
983         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
984         * WebKitTestRunner/PlatformWebView.h:
985         * WebKitTestRunner/Target.pri: Removed.
986         * WebKitTestRunner/TestController.cpp:
987         (WTR::TestController::resetStateToConsistentValues):
988         * WebKitTestRunner/TestController.h:
989         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
990         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
991         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
992         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
993         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
994         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
995         * WebKitTestRunner/qt/main.cpp: Removed.
996         * WebKitTestRunner/qt/resources/user.css: Removed.
997         * qmake/.qmake.cache: Removed.
998         * qmake/.qmake.conf: Removed.
999         * qmake/README: Removed.
1000         * qmake/config.tests/README: Removed.
1001         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1002         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1003         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1004         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1005         * qmake/config.tests/glx/glx.cpp: Removed.
1006         * qmake/config.tests/glx/glx.pro: Removed.
1007         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1008         * qmake/config.tests/gnuld/main.cpp: Removed.
1009         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1010         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1011         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1012         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1013         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1014         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1015         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1016         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1017         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1018         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1019         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1020         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1021         * qmake/dump-features.pl: Removed.
1022         * qmake/mkspecs/features/configure.prf: Removed.
1023         * qmake/mkspecs/features/default_post.prf: Removed.
1024         * qmake/mkspecs/features/default_pre.prf: Removed.
1025         * qmake/mkspecs/features/features.prf: Removed.
1026         * qmake/mkspecs/features/features.pri: Removed.
1027         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1028         * qmake/mkspecs/features/functions.prf: Removed.
1029         * qmake/mkspecs/features/gprof.prf: Removed.
1030         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1031         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1032         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1033         * qmake/mkspecs/features/production_build.prf: Removed.
1034         * qmake/mkspecs/features/rpath.prf: Removed.
1035         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1036         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1037         * qmake/mkspecs/features/unix/icc.prf: Removed.
1038         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1039         * qmake/mkspecs/features/valgrind.prf: Removed.
1040         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1041         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1042         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1043         * qmake/mkspecs/modules/angle.prf: Removed.
1044         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1045         * qmake/mkspecs/modules/webcore.prf: Removed.
1046         * qmake/mkspecs/modules/webkit1.prf: Removed.
1047         * qmake/mkspecs/modules/webkit2.prf: Removed.
1048         * qmake/mkspecs/modules/wtf.prf: Removed.
1049
1050 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1051
1052         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1053         https://bugs.webkit.org/show_bug.cgi?id=121859
1054         <rdar://problem/15069359>
1055
1056         Reviewed by Anders Carlsson.
1057
1058         * WebKitTestRunner/TestInvocation.cpp:
1059         (WTR::shouldUseThreadedScrolling):
1060         (WTR::updateThreadedScrollingForCurrentTest):
1061         (WTR::TestInvocation::invoke):
1062         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1063         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1064         (WTR::PlatformWebView::PlatformWebView):
1065         (WTR::PlatformWebView::viewSupportsOptions):
1066         Rename the tiled drawing switch to threaded scrolling, since that's really
1067         all it switches now that we use tiled drawing everywhere.
1068
1069         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1070         and to more closely match the case we're interested in testing.
1071
1072 2013-10-02  Anders Carlsson  <andersca@apple.com>
1073
1074         Move AHEM____.TTF from qt/fonts/ to fonts/.
1075
1076         Rubber-stamped by Andreas Kling.
1077
1078         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1079         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1080
1081 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1082
1083         Remove Qt bots and EWS from trunk.
1084         https://bugs.webkit.org/show_bug.cgi?id=122210.
1085
1086         Reviewed by Allan Sandfeld Jensen.
1087
1088         Remove Qt buil dbots.
1089
1090         * BuildSlaveSupport/build.webkit.org-config/config.json:
1091         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1092         (appendCustomBuildFlags):
1093         (RunGtkAPITests.getText2):
1094         (Factory.__init__):
1095         (TestFactory.__init__):
1096         (BuildAndTestFactory.__init__):
1097         (loadBuilderConfig):
1098         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1099
1100 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1101
1102         Remove Qt bots and EWS from trunk.
1103         https://bugs.webkit.org/show_bug.cgi?id=122210.
1104
1105         Reviewed by Allan Sandfeld Jensen.
1106
1107         Remove Qt EWS bots.
1108
1109         * QueueStatusServer/config/queues.py:
1110         * Scripts/webkitpy/common/config/ews.json:
1111
1112 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1113
1114         Fix singular labels for test failures.
1115
1116         https://bugs.webkit.org/show_bug.cgi?id=122200
1117
1118         Reviewed by Joseph Pecoraro.
1119
1120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1121         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1122
1123 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1124
1125         Don't keep appending iterations each time the queue updates.
1126
1127         https://bugs.webkit.org/show_bug.cgi?id=122198
1128
1129         Reviewed by Joseph Pecoraro.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1132         (BuildbotQueue.prototype.update):
1133
1134 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1135
1136         Properly sort iterations in the Dashboard by revision for out-of-order queues.
1137
1138         https://bugs.webkit.org/show_bug.cgi?id=122196
1139
1140         Reviewed by Brent Fulgham.
1141
1142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1143         (BuildbotIteration):
1144         (BuildbotIteration.prototype.update):
1145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1146         (BuildbotQueue.prototype.update):
1147         (BuildbotQueue.prototype.sortIterations):
1148
1149 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1150
1151         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
1152
1153         Also fix some URLs to not have extras slashes and add a page title.
1154
1155         https://bugs.webkit.org/show_bug.cgi?id=122192
1156
1157         Reviewed by Joseph Pecoraro.
1158
1159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1160         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1162         (WebKitBuildbot.prototype.buildLogURLForIteration):
1163         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1164         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1166
1167 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
1168
1169         [Mac] Set NSApplication current event while sending events directly to views
1170         https://bugs.webkit.org/show_bug.cgi?id=122179
1171
1172         Reviewed by Darin Adler.
1173
1174         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
1175         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
1176         use the current event.
1177
1178         * DumpRenderTree/mac/EventSendingController.mm:
1179         (-[EventSendingController mouseDown:withModifiers:]):
1180         (-[EventSendingController mouseUp:withModifiers:]):
1181         (-[EventSendingController mouseMoveToX:Y:]):
1182         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1183         (-[EventSendingController contextClick]):
1184         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1185         * WebKitTestRunner/mac/EventSenderProxy.mm:
1186         (WTR::EventSenderProxy::mouseDown):
1187         (WTR::EventSenderProxy::mouseUp):
1188         (WTR::EventSenderProxy::mouseMoveTo):
1189         (WTR::EventSenderProxy::keyDown):
1190         (WTR::EventSenderProxy::mouseScrollBy):
1191         Update the current event. We were already using the SPI in WebKit.
1192
1193 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1194
1195         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
1196         https://bugs.webkit.org/show_bug.cgi?id=122183
1197
1198         Reviewed by Timothy Hatcher.
1199
1200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1201         (BuildbotIteration.prototype.update):
1202
1203 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1204
1205         Tweaks to the Buildbot Dashboard
1206
1207         https://bugs.webkit.org/show_bug.cgi?id=122169
1208
1209         Reviewed by Alexey Proskuryakov.
1210
1211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1212         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1214         (BuildbotQueueView.prototype.revisionLinksForIteration):
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1216         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1220         (WebKitBuildbot.prototype.buildLogURLForIteration):
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1222
1223 2013-10-01  Commit Queue  <commit-queue@webkit.org>
1224
1225         Unreviewed, rolling out r156725.
1226         http://trac.webkit.org/changeset/156725
1227         https://bugs.webkit.org/show_bug.cgi?id=122176
1228
1229         broke all the mismatch tests again (Requested by thorton on
1230         #webkit).
1231
1232         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1233         (WTR::PlatformWebView::PlatformWebView):
1234
1235 2013-10-01  Alex Christensen  <achristensen@webkit.org>
1236
1237         Implemented createWebViewWithRequest in WinLauncher.
1238         https://bugs.webkit.org/show_bug.cgi?id=122069
1239
1240         Reviewed by Brent Fulgham.
1241
1242         * WinLauncher/PrintWebUIDelegate.cpp:
1243         (PrintWebUIDelegate::createWebViewWithRequest): Added.
1244         * WinLauncher/PrintWebUIDelegate.h:
1245         Removed createWebViewWithRequest stub.
1246
1247 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1248
1249         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1250         https://bugs.webkit.org/show_bug.cgi?id=122006
1251         <rdar://problem/15095197>
1252
1253         Reviewed by Dean Jackson.
1254
1255         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1256         (WTR::PlatformWebView::PlatformWebView):
1257         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1258         where the window server snapshot API returns blank snapshots.
1259
1260         Re-landing after r156724, this should not break everything now.
1261
1262 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1263
1264         [mac] 1x emulation on Retina hardware shouldn't use SPI
1265         https://bugs.webkit.org/show_bug.cgi?id=122152
1266         <rdar://problem/15119384>
1267
1268         Reviewed by Anders Carlsson.
1269
1270         * DumpRenderTree/mac/DumpRenderTree.mm:
1271         (createWebViewAndOffscreenWindow):
1272         (main):
1273         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1274         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1275         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1276         (WTR::PlatformWebView::PlatformWebView):
1277         * WebKitTestRunner/mac/main.mm:
1278         (main):
1279         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
1280
1281 2013-09-30  Sam Weinig  <sam@webkit.org>
1282
1283         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
1284         https://bugs.webkit.org/show_bug.cgi?id=116474
1285
1286         Reviewed by Ryosuke Niwa.
1287
1288         * Scripts/webkitpy/style/checkers/cpp.py:
1289         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1290
1291 2013-09-30  Sam Weinig  <sam@webkit.org>
1292
1293         Remove support for DOMFileSystem
1294         https://bugs.webkit.org/show_bug.cgi?id=122137
1295
1296         Reviewed by Anders Carlsson.
1297
1298         * Scripts/webkitperl/FeatureList.pm:
1299         * Scripts/webkitpy/style/checkers/cpp.py:
1300         (check_spacing):
1301         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1302         (CppStyleTest.test_spacing_for_binary_ops):
1303         * qmake/mkspecs/features/features.pri:
1304
1305 2013-09-30  Mark Rowe  <mrowe@apple.com>
1306
1307         More build fixage for builds with SDKs.
1308
1309         * WebKitTestRunner/Configurations/Base.xcconfig:
1310         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1311
1312 2013-09-30  Timothy Hatcher  <timothy@apple.com>
1313
1314         Add initial version of a new Buildbot dashboard view.
1315
1316         https://bugs.webkit.org/show_bug.cgi?id=122131
1317
1318         Reviewed by Alexey Proskuryakov.
1319
1320         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
1321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
1322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
1323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
1324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
1325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
1326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
1327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
1328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
1329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
1330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
1331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
1332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
1333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
1334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
1336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
1338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
1339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
1340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
1341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
1342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
1346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
1349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
1350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
1351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
1352
1353 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
1354
1355         Remove the code guarded by STYLE_SCOPED
1356         https://bugs.webkit.org/show_bug.cgi?id=122123
1357
1358         Reviewed by Anders Carlsson.
1359
1360         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1361         (resetDefaultsToConsistentValues):
1362         * Scripts/webkitperl/FeatureList.pm:
1363         * qmake/mkspecs/features/features.pri:
1364
1365 2013-09-30  Mark Rowe  <mrowe@apple.com>
1366
1367         Fix the build when building against an SDK.
1368
1369         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
1370         the compiler command lines. It can't know to do this for the system framework search paths
1371         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
1372
1373         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
1374         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1375
1376 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
1377
1378         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
1379
1380         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
1381         it to be double-freed.
1382
1383         * WinLauncher/WinLauncher.cpp:
1384         (EditProc): Be explicit about type passed to loadURL.
1385         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
1386         that reallocating the BSTR is done with the knowledge of the smart pointer.
1387
1388 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1389
1390         [Qt] Fix force_static_libs_as_shared in WebKit2
1391         https://bugs.webkit.org/show_bug.cgi?id=121961
1392
1393         Reviewed by Csaba Osztrogonác.
1394
1395         Get rid of the unused WebKit2QML library
1396
1397         * qmake/mkspecs/features/webkit_modules.prf:
1398         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
1399
1400 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
1401
1402         [EFL] Fix incorrect click counting in EventSenderProxy
1403         https://bugs.webkit.org/show_bug.cgi?id=122098
1404
1405         Reviewed by Gyuyoung Kim.
1406
1407         Previously used two types of recording time, which conflicted with each other.
1408
1409         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1410         (WTR::EventSenderProxy::mouseUp):
1411
1412 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
1413
1414         [webkitpy] Make the Xvfb screen depth overridable
1415         https://bugs.webkit.org/show_bug.cgi?id=122089
1416
1417         Reviewed by Gyuyoung Kim.
1418
1419         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
1420         was set. The default value that's used if the variable wasn't set is 24.
1421
1422         * Scripts/webkitpy/port/xvfbdriver.py:
1423         (XvfbDriver._xvfb_screen_depth):
1424         (XvfbDriver._start):
1425         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1426         (XvfbDriverTest.make_driver):
1427         (XvfbDriverTest.test_start_no_pixel_tests):
1428         (XvfbDriverTest.test_start_pixel_tests):
1429         (XvfbDriverTest.test_start_arbitrary_worker_number):
1430         (XvfbDriverTest.test_next_free_display):
1431         (XvfbDriverTest.test_start_next_worker):
1432
1433 2013-09-29  Mark Rowe  <mrowe@apple.com>
1434
1435         Fix the Lion build.
1436
1437         Ensure that C++ and Objective-C++ files build with the right compiler flags.
1438
1439         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
1440         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1441
1442 2013-09-28  Mark Rowe  <mrowe@apple.com>
1443
1444         Fix some failures with newer versions of clang.
1445
1446         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
1447         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
1448         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
1449         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
1450         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
1451
1452         Reviewed by Dan Bernstein.
1453
1454         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1455         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
1456         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1457         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1458         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1459         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1460         * WebKitTestRunner/Configurations/Base.xcconfig:
1461         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
1462         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1463         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1464         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1465
1466 2013-09-27  Commit Queue  <commit-queue@webkit.org>
1467
1468         Unreviewed, rolling out r156569.
1469         http://trac.webkit.org/changeset/156569
1470         https://bugs.webkit.org/show_bug.cgi?id=122035
1471
1472         broke a lot of mismatch tests (Requested by thorton on
1473         #webkit).
1474
1475         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1476         (WTR::PlatformWebView::PlatformWebView):
1477
1478 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
1479
1480         Don't retry failures on Apple MountainLion Release WK1 tester
1481         https://bugs.webkit.org/show_bug.cgi?id=122026
1482
1483         Reviewed by Mark Rowe.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
1486         on this bot.
1487
1488 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
1489
1490         Don't hardcode builder specific configuration in buildbot master.cfg
1491         https://bugs.webkit.org/show_bug.cgi?id=122023
1492
1493         Reviewed by Mark Rowe.
1494
1495         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
1496         property to Qt Mountain Lion Release, making it run pixel tests.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1499         (RunWebKitTests.start): Use additionalArguments.
1500         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
1501
1502 2013-09-27  Tim Horton  <timothy_horton@apple.com>
1503
1504         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1505         https://bugs.webkit.org/show_bug.cgi?id=122006
1506         <rdar://problem/15095197>
1507
1508         Reviewed by Dean Jackson.
1509
1510         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1511         (WTR::PlatformWebView::PlatformWebView):
1512         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1513         where the window server snapshot API returns blank snapshots.
1514
1515 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1516
1517         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
1518         https://bugs.webkit.org/show_bug.cgi?id=106924
1519
1520         Reviewed by Chris Fleizach.
1521
1522         Consider headings levels as values to be returned in intValue()
1523         both in DRT and WKTR, so we can share more tests with other ports.
1524
1525         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1526         (AccessibilityUIElement::intValue): Consider headings too.
1527         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1528         (WTR::AccessibilityUIElement::intValue): Ditto.
1529
1530 2013-09-26  Darin Adler  <darin@apple.com>
1531
1532         rename KURL to URL
1533         https://bugs.webkit.org/show_bug.cgi?id=16214
1534
1535         Reviewed by Andreas Kling.
1536
1537         * many files: Renamed, using script.
1538
1539 2013-09-27  Darin Adler  <darin@apple.com>
1540
1541         Fix Python scripts test failures.
1542
1543         * Scripts/webkitpy/style/checkers/cpp.py:
1544         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
1545         now, not by the checker itself.
1546
1547 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
1548
1549         [GTK][WK2] Logging of accessibility events is not disabled between tests
1550         https://bugs.webkit.org/show_bug.cgi?id=121957
1551
1552         Reviewed by Mario Sanchez Prada.
1553
1554         Fixed an issue in AccessibilityNotificationHandler where the destructor
1555         was not disconnecting accessibility event callbacks if logging was on.
1556         The decision of disconnecting events can solely rely on the existence of
1557         notification handlers because logging uses the global notification
1558         handler.
1559
1560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1561         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
1562         disconnection when logging is on.
1563
1564 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
1565
1566         Add general CMakeLists.txt for DRT
1567         https://bugs.webkit.org/show_bug.cgi?id=119268
1568
1569         Reviewed by Gyuyoung Kim.
1570
1571         The new file allows better sharing between ports.
1572
1573         * CMakeLists.txt:
1574         * DumpRenderTree/CMakeLists.txt: Added.
1575         * DumpRenderTree/PlatformEfl.cmake: Added.
1576         * DumpRenderTree/efl/CMakeLists.txt: Removed.
1577
1578 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1579
1580         [Qt] Fix force_static_libs_as_shared in WebKit2
1581         https://bugs.webkit.org/show_bug.cgi?id=121961
1582
1583         Reviewed by Csaba Osztrogonác.
1584
1585         Reenable force_static_libs_as_shared when building WebKit2.
1586
1587         * qmake/mkspecs/features/default_post.prf:
1588
1589 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1590
1591         [Qt] Mock implementations of positioning and orientation not used
1592         https://bugs.webkit.org/show_bug.cgi?id=121956
1593
1594         Reviewed by Csaba Osztrogonác.
1595
1596         Move production_build checks to sanitizeFeatures where its value is actually known.
1597
1598         * qmake/mkspecs/features/features.prf:
1599         * qmake/mkspecs/features/features.pri:
1600
1601 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1602
1603         [ATK] Normalize checks in entry points for DRT and WKTR
1604         https://bugs.webkit.org/show_bug.cgi?id=121959
1605
1606         Reviewed by Chris Fleizach.
1607
1608         Always check if we have a proper instance of AtkObject,
1609         implementing the interfaces that we might need for each case, at
1610         the entry point of every method of AccessibilityUIElement for ATK,
1611         and do those checks in an uniform way across DRT and WKTR, to
1612         avoid confusion and issues when modifying these files in the future.
1613
1614         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1615         (AccessibilityUIElement::getChildren): Use normalized checks.
1616         (AccessibilityUIElement::getChildrenWithRange): Ditto.
1617         (AccessibilityUIElement::rowCount): Ditto.
1618         (AccessibilityUIElement::columnCount): Ditto.
1619         (AccessibilityUIElement::childrenCount): Ditto.
1620         (AccessibilityUIElement::elementAtPoint): Ditto.
1621         (AccessibilityUIElement::getChildAtIndex): Ditto.
1622         (AccessibilityUIElement::allAttributes): Ditto.
1623         (AccessibilityUIElement::titleUIElement): Ditto.
1624         (AccessibilityUIElement::parentElement): Ditto.
1625         (AccessibilityUIElement::attributesOfChildren): Ditto.
1626         (AccessibilityUIElement::role): Ditto.
1627         (AccessibilityUIElement::title): Ditto.
1628         (AccessibilityUIElement::description): Ditto.
1629         (AccessibilityUIElement::stringValue): Ditto.
1630         (AccessibilityUIElement::language): Ditto.
1631         (AccessibilityUIElement::x): Ditto.
1632         (AccessibilityUIElement::y): Ditto.
1633         (AccessibilityUIElement::width): Ditto.
1634         (AccessibilityUIElement::height): Ditto.
1635         (AccessibilityUIElement::orientation): Ditto.
1636         (AccessibilityUIElement::intValue): Ditto.
1637         (AccessibilityUIElement::minValue): Ditto.
1638         (AccessibilityUIElement::maxValue): Ditto.
1639         (indexRangeInTable): Ditto.
1640         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
1641         (AccessibilityUIElement::stringAttributeValue): Ditto.
1642         (alterCurrentValue): Ditto.
1643         (AccessibilityUIElement::press): Ditto.
1644         (AccessibilityUIElement::documentEncoding): Ditto.
1645         (AccessibilityUIElement::documentURI): Ditto.
1646         (AccessibilityUIElement::hasPopup): Ditto.
1647
1648         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1649         (WTR::indexRangeInTable): Use normalized checks.
1650         (WTR::alterCurrentValue): Ditto.
1651         (WTR::AccessibilityUIElement::getChildren): Ditto.
1652         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
1653         (WTR::AccessibilityUIElement::childrenCount): Ditto.
1654         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
1655         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
1656         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
1657         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
1658         (WTR::AccessibilityUIElement::parentElement): Ditto.
1659         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
1660         (WTR::AccessibilityUIElement::allAttributes): Ditto.
1661         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1662         (WTR::AccessibilityUIElement::role): Ditto.
1663         (WTR::AccessibilityUIElement::title): Ditto.
1664         (WTR::AccessibilityUIElement::description): Ditto.
1665         (WTR::AccessibilityUIElement::orientation): Ditto.
1666         (WTR::AccessibilityUIElement::stringValue): Ditto.
1667         (WTR::AccessibilityUIElement::language): Ditto.
1668         (WTR::AccessibilityUIElement::x): Ditto.
1669         (WTR::AccessibilityUIElement::y): Ditto.
1670         (WTR::AccessibilityUIElement::width): Ditto.
1671         (WTR::AccessibilityUIElement::height): Ditto.
1672         (WTR::AccessibilityUIElement::intValue): Ditto.
1673         (WTR::AccessibilityUIElement::minValue): Ditto.
1674         (WTR::AccessibilityUIElement::maxValue): Ditto.
1675         (WTR::AccessibilityUIElement::rowCount): Ditto.
1676         (WTR::AccessibilityUIElement::columnCount): Ditto.
1677         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
1678         (WTR::AccessibilityUIElement::press): Ditto.
1679         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
1680         (WTR::AccessibilityUIElement::documentURI): Ditto.
1681         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1682
1683 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1684
1685         [ATK] accessibility/aria-sort.html is failing after r156409
1686         https://bugs.webkit.org/show_bug.cgi?id=121947
1687
1688         Reviewed by Chris Fleizach.
1689
1690         Implement AccessibilityUIElement::isSupported for the ATK
1691         platforms, just by checking whether we have an associated object
1692         attribute exposed for the wrapper object matching the required
1693         attribute in the layout test (e.g "AXSortDirection" -> "sort").
1694
1695         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1696         (AccessibilityUIElement::isAttributeSupported): Implemented.
1697         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1698         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
1699
1700 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
1701
1702         [MediaStream] make MediaStream testable
1703         https://bugs.webkit.org/show_bug.cgi?id=121967
1704
1705         Reviewed by Dean Jackson.
1706
1707         * DumpRenderTree/mac/UIDelegate.mm:
1708         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
1709             user media request policy delegate.
1710
1711 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
1712
1713         build-webkit --inspector-frontend should copy WebInspectorUI files
1714         https://bugs.webkit.org/show_bug.cgi?id=117851
1715
1716         Reviewed by Joseph Pecoraro.
1717
1718         Change the --inspector-frontend build option to additionally build/copy 
1719         WebInspectorUI by setting it as the only project that needs to be built.
1720
1721         * Scripts/build-webkit:
1722
1723 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
1724
1725         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
1726         https://bugs.webkit.org/show_bug.cgi?id=121951
1727
1728         Reviewed by Carlos Garcia Campos.
1729
1730         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
1731         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
1732         500 layout tests that trigger accelerated compositing to be used.
1733
1734         * Scripts/webkitpy/port/xvfbdriver.py:
1735         (XvfbDriver._start):
1736         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
1737         (XvfbDriverTest.test_start_no_pixel_tests):
1738         (XvfbDriverTest.test_start_pixel_tests):
1739         (XvfbDriverTest.test_start_arbitrary_worker_number):
1740         (XvfbDriverTest.test_next_free_display):
1741         (XvfbDriverTest.test_start_next_worker):
1742
1743 2013-09-26  Tim Horton  <timothy_horton@apple.com>
1744
1745         Tiled drawing should not imply threaded scrolling
1746         https://bugs.webkit.org/show_bug.cgi?id=121874
1747         <rdar://problem/15071494>
1748
1749         Reviewed by Sam Weinig.
1750
1751         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1752         (WTR::PlatformWebView::PlatformWebView):
1753         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
1754
1755 2013-09-26  Commit Queue  <commit-queue@webkit.org>
1756
1757         Unreviewed, rolling out r156457.
1758         http://trac.webkit.org/changeset/156457
1759         https://bugs.webkit.org/show_bug.cgi?id=121960
1760
1761         Broke webkitpy tests. (Requested by kling on #webkit).
1762
1763         * Scripts/webkitpy/port/xvfbdriver.py:
1764         (XvfbDriver._start):
1765
1766 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
1767
1768         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
1769         https://bugs.webkit.org/show_bug.cgi?id=121951
1770
1771         Reviewed by Carlos Garcia Campos.
1772
1773         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
1774         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
1775         500 layout tests that trigger accelerated compositing to be used.
1776
1777         * Scripts/webkitpy/port/xvfbdriver.py:
1778         (XvfbDriver._start):
1779
1780 2013-09-25  Alex Christensen  <achristensen@webkit.org>
1781
1782         Removed check for Apple Application Support directory in WinCairo port.
1783         https://bugs.webkit.org/show_bug.cgi?id=121869
1784
1785         Reviewed by Brent Fulgham.
1786
1787         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1788         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1789         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1790         Use DLLLauncherWinCairo.props for WinCairo ports.
1791         * win/DLLLauncher/DLLLauncherMain.cpp:
1792         (wWinMain):
1793         Don't call modifyPath to check for AAS in the WinCairo port.
1794         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
1795
1796 2013-09-25  Alex Christensen  <achristensen@webkit.org>
1797
1798         Enabled AssembleBuildLogs on WinCairo port.
1799         https://bugs.webkit.org/show_bug.cgi?id=121923
1800
1801         Reviewed by Brent Fulgham.
1802
1803         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1804         Fixed reference to README, added WinCairo configurations.
1805         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
1806         Fixed reference to README.
1807         * win/AssembleBuildLogs/AssembleLogs.cmd:
1808         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
1809         * win/AssembleBuildLogs/README: Fixed spelling.
1810
1811 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
1812
1813         [WIN] Fix MSVC C4146 compiler warning
1814         https://bugs.webkit.org/show_bug.cgi?id=121838
1815
1816         Reviewed by Brent Fulgham.
1817
1818         Fix some variables from unsinged to int to fix the compiler warning
1819         "unary minus operator applied to unsigned type, result still unsigned".
1820
1821         * DumpRenderTree/WorkQueueItem.h:
1822         (BackItem::BackItem):
1823         (ForwardItem::ForwardItem):
1824         * DumpRenderTree/win/DumpRenderTree.cpp:
1825         (createWebViewAndOffscreenWindow):
1826
1827 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
1828
1829         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
1830         https://bugs.webkit.org/show_bug.cgi?id=121256
1831
1832         Reviewed by Martin Robinson.
1833
1834         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
1835         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
1836
1837         * BuildSlaveSupport/build.webkit.org-config/config.json:
1838
1839 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
1840
1841         Add style checker for CMake lists
1842         https://bugs.webkit.org/show_bug.cgi?id=121764
1843
1844         Reviewed by Ryosuke Niwa.
1845
1846         Add an additional check to make sure that list of files are sorted.
1847         Exclude lists of include directories for now, since the order
1848         can be importent for compilation of some files.
1849
1850         * Scripts/webkitpy/style/checkers/cmake.py:
1851         (CMakeChecker.check):
1852         (CMakeChecker._check_indent):
1853         (CMakeChecker):
1854         (CMakeChecker._check_list_order):
1855         (CMakeChecker._list_item_path):
1856         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1857         (CMakeCheckerTest.test_check):
1858
1859 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
1860
1861         CMakeChecker takes unusually long time to run
1862         https://bugs.webkit.org/show_bug.cgi?id=105662
1863
1864         Reviewed by Ryosuke Niwa.
1865
1866         Move the caching mechanism for regular expression of the C++ checker into
1867         a common file and use it for the CMake and ChangeLog checkers too.
1868
1869         * Scripts/webkitpy/style/checkers/changelog.py:
1870         (ChangeLogChecker.check_entry):
1871         * Scripts/webkitpy/style/checkers/cmake.py:
1872         (CMakeChecker._process_line):
1873         (CMakeChecker._check_no_space_cmds):
1874         (CMakeChecker._check_one_space_cmds):
1875         (CMakeChecker._check_non_lowercase_cmd):
1876         * Scripts/webkitpy/style/checkers/common.py:
1877         (match):
1878         (search):
1879         (searchIgnorecase):
1880         (sub):
1881         (subn):
1882         * Scripts/webkitpy/style/checkers/cpp.py:
1883
1884 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1885
1886         [Qt] Fix build with Qt 5.2 QtPosition module
1887         https://bugs.webkit.org/show_bug.cgi?id=121089
1888
1889         Reviewed by Simon Hausmann.
1890
1891         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
1892         that might depend on them.
1893
1894         * qmake/mkspecs/features/default_pre.prf:
1895         * qmake/mkspecs/features/features.prf:
1896
1897 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
1898
1899         [ATK] Fix style issues in AccessibilityUIElementAtk
1900         https://bugs.webkit.org/show_bug.cgi?id=121898
1901
1902         Reviewed by Chris Fleizach.
1903
1904         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
1905         instead of { 0, { { 0 } } } to initialize a GValue.
1906
1907         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1908         (AccessibilityUIElement::clickPointX): Remove suffix.
1909         (AccessibilityUIElement::clickPointY): Ditto.
1910         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
1911         (AccessibilityUIElement::minValue): Ditto.
1912         (AccessibilityUIElement::maxValue): Ditto.
1913         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
1914         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1915         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
1916         (WTR::AccessibilityUIElement::x): Ditto.
1917         (WTR::AccessibilityUIElement::y): Ditto.
1918         (WTR::AccessibilityUIElement::width): Ditto.
1919         (WTR::AccessibilityUIElement::height): Ditto.
1920         (WTR::AccessibilityUIElement::clickPointX): Ditto.
1921         (WTR::AccessibilityUIElement::clickPointY): Ditto.
1922         (WTR::AccessibilityUIElement::intValue): Ditto.
1923         (WTR::AccessibilityUIElement::minValue): Ditto.
1924         (WTR::AccessibilityUIElement::maxValue): Ditto.
1925
1926 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
1927
1928         [EFL] accessibility/loading-iframe-sends-notification.html is failing
1929         https://bugs.webkit.org/show_bug.cgi?id=112003
1930
1931         Reviewed by Mario Sanchez Prada.
1932
1933         Enabled addNotificationListener and removeNotificationListener for EFL port.
1934
1935         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1936         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1937         (WTR::AccessibilityController::removeNotificationListener):
1938
1939 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
1940
1941         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
1942         https://bugs.webkit.org/show_bug.cgi?id=121844
1943
1944         Reviewed by Mark Hahnenberg.
1945
1946         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
1947
1948 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
1949
1950         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
1951         https://bugs.webkit.org/show_bug.cgi?id=121854
1952
1953         Reviewed by Anders Carlsson.
1954
1955         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1956         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
1957         settings in underlying frameworks.
1958
1959 2013-09-24  Mark Rowe  <mrowe@apple.com>
1960
1961         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
1962
1963         Reviewed by Dan Bernstein.
1964
1965         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1966         * MiniBrowser/Configurations/Base.xcconfig:
1967         * TestWebKitAPI/Configurations/Base.xcconfig:
1968         * WebKitLauncher/Configurations/Base.xcconfig:
1969         * WebKitTestRunner/Configurations/Base.xcconfig:
1970
1971 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
1972
1973         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
1974         https://bugs.webkit.org/show_bug.cgi?id=121674
1975
1976         Reviewed by Mario Sanchez Prada.
1977
1978         Implemented the global notification listener for
1979         AccessibilityController. The signal is generated by
1980         AXObjectCache::postPlatformNotification() and received by
1981         axObjectEventListener(). axObjectEventListener will then invoke
1982         JSObjectCallAsFunction() with the respective callback function.
1983
1984         There is no additional test for this patch since its implementation will
1985         be tested by an accessibility layout test that is currently failing
1986         (accessibility/loading-iframe-sends-notification.html).
1987
1988         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
1989         stub implementations of addNotificationListener and
1990         removeNotificationListener for the GTK port.
1991         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1992         (WTR::AccessibilityController::addNotificationListener): Creates the
1993         notification handler and sets the notification function callback.
1994         (WTR::AccessibilityController::removeNotificationListener): Removes the
1995         global handler.
1996
1997 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1998
1999         [GTK] fast/images/exif-orientation-composited.html is failing
2000         https://bugs.webkit.org/show_bug.cgi?id=119731
2001
2002         Reviewed by Carlos Garcia Campos.
2003
2004         Add handling respect image orientation property in DRT.
2005
2006         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2007         (TestRunner::overridePreference):
2008
2009 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2010
2011         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2012         https://bugs.webkit.org/show_bug.cgi?id=121787
2013
2014         Reviewed by Gustavo Noronha Silva.
2015
2016         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2017         with the Wayland target enabled to version 3.10.0.
2018
2019 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2020
2021         use NOMINMAX instead of #define min min
2022         https://bugs.webkit.org/show_bug.cgi?id=73563
2023
2024         Reviewed by Brent Fulgham.
2025
2026         Use NOMINMAX instead of #define min/max as a cleaner
2027         way of ensuring that Windows system header files don't
2028         define min/max as macro in the first place.
2029
2030         * DumpRenderTree/DumpRenderTreePrefix.h:
2031         * DumpRenderTree/cg/ImageDiffCG.cpp:
2032         * DumpRenderTree/config.h:
2033         * DumpRenderTree/win/ImageDiffCairo.cpp:
2034         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2035         * WebKitTestRunner/config.h:
2036
2037 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2038
2039         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2040         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2041
2042         Reviewed by Alexey Proskuryakov.
2043
2044         Previously, initalizing a WebPreference would change the cache model
2045         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2046         preference file on disk.
2047
2048         This patch fixes the tests by resetting the default, and using the proper
2049         default values after initializing WebPreference.
2050
2051         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2052         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2053         to the previous runs.
2054
2055         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2056         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2057         cache model to the one required.
2058
2059         * TestWebKitAPI/ios/mainIOS.mm:
2060         (main): Reset the preferences before testing.
2061         * TestWebKitAPI/mac/mainMac.mm:
2062         (main): Ditto.
2063
2064 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2065
2066         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2067         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2068
2069         Reviewed by Alexey Proskuryakov.
2070
2071         Previously, initalizing a WebPreference would change the cache model
2072         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2073         preference file on disk.
2074
2075         This patch fixes the tests by resetting the default, and using the proper
2076         default values after initializing WebPreference.
2077
2078         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2079         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2080         to the previous runs.
2081
2082         * TestWebKitAPI/ios/mainIOS.mm:
2083         (main): Reset the preferences before testing.
2084         * TestWebKitAPI/mac/mainMac.mm:
2085         (main): Ditto.
2086
2087 2013-09-23  Anders Carlsson  <andersca@apple.com>
2088
2089         ListHashSet should work with move-only types
2090         https://bugs.webkit.org/show_bug.cgi?id=121802
2091
2092         Reviewed by Andreas Kling.
2093
2094         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2095         (TestWebKitAPI::TEST):
2096         Add a test for move-only types.
2097
2098 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
2099
2100         Added --64-bit option for Windows build.
2101         https://bugs.webkit.org/show_bug.cgi?id=121799
2102
2103         Reviewed by Brent Fulgham.
2104
2105         * Scripts/webkitdirs.pm:
2106         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
2107         (isWin64): Added.
2108         (determineIsWin64): Added.
2109
2110 2013-09-23  Anders Carlsson  <andersca@apple.com>
2111
2112         ListHashSet should use std::reverse_iterator for reverse iterators
2113         https://bugs.webkit.org/show_bug.cgi?id=121795
2114
2115         Reviewed by Antti Koivisto.
2116
2117         Add test for reverse iterators.
2118
2119         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2120         (TestWebKitAPI::TEST):
2121
2122 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
2123
2124         [EFL] accessibility/aria-invalid is failing
2125         https://bugs.webkit.org/show_bug.cgi?id=111986
2126
2127         Reviewed by Mario Sanchez Prada.
2128
2129         Adds possibility to retrieve JS context.
2130         This is part of the implementation of AccessibilityUIElement::addNotificationListener
2131         from 119883 and 120421.
2132
2133         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2134         (axObjectEventListener):
2135         (addAccessibilityNotificationHandler):
2136         (removeAccessibilityNotificationHandler):
2137         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2138         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2139         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2140
2141 2013-09-20  Mark Rowe  <mrowe@apple.com>
2142
2143         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
2144
2145         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
2146
2147         Reviewed by David Kilzer.
2148
2149         * Scripts/webkitdirs.pm:
2150         (checkRequiredSystemConfig):
2151
2152 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2153
2154         [ATK] Do not expose aria-help in ATK based platforms
2155         https://bugs.webkit.org/show_bug.cgi?id=121675
2156
2157         Reviewed by Chris Fleizach.
2158
2159         Remove the implementations for AccessibilityUIElement::helpText()
2160         from DRT and WKTR for GTK and EFL, since they are based on the
2161         AccessibilityObject::helpText() method and the 'aria-help'
2162         attributes, which is wrong since they should not depend on that
2163         but in ATK specific API (see also http://webkit.org/b/121684).
2164
2165         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2166         (AccessibilityUIElement::helpText): Added a new and empty
2167         implementation, now that we are no longer using this in ATK.
2168         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
2169         as the only function provided here was helpText().
2170         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
2171         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
2172         removed from the list of sources to compile.
2173         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
2174         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2175         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
2176         based in DumpRenderTreeSupportGtk with an empty one.
2177
2178 2013-09-20  Dan Bernstein  <mitz@apple.com>
2179
2180         Make extract-localizable-strings available to WebCore clients
2181         https://bugs.webkit.org/show_bug.cgi?id=121699
2182
2183         Reviewed by Darin Adler.
2184
2185         * Scripts/extract-localizable-strings: Copied to
2186         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
2187         executes the script from its new location. This is a temporary measure until certain code
2188         that is external to WebKit is adapted to the new location.
2189         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
2190         from its new location.
2191
2192 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
2193
2194         Nuke remaining VS2005 tools from the tree.
2195         https://bugs.webkit.org/show_bug.cgi?id=121691
2196
2197         Reviewed by Brent Fulgham.
2198
2199         * CLWrapper/CLWrapper.cpp: Removed.
2200         * CLWrapper/CLWrapper.sln: Removed.
2201         * CLWrapper/CLWrapper.vcproj: Removed.
2202         * MIDLWrapper/MIDLWrapper.cpp: Removed.
2203         * MIDLWrapper/MIDLWrapper.sln: Removed.
2204         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
2205         * Scripts/parallelcl: Removed.
2206         * vcbin/cl.exe: Removed.
2207         * vcbin/midl.exe: Removed.
2208
2209 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2210
2211         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
2212         https://bugs.webkit.org/show_bug.cgi?id=121294
2213
2214         Reviewed by Martin Robinson.
2215
2216         Provide a new patch to deal with the issue in the GTK+ module from
2217         the internal jhbuild environment. This issue has been reported
2218         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
2219
2220         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
2221         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
2222
2223 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2224
2225         [ATK][WTR] accessibility/aria-invalid.html times out
2226         https://bugs.webkit.org/show_bug.cgi?id=121668
2227
2228         Reviewed by Mario Sanchez Prada.
2229
2230         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
2231         false in case of aria-invalid event with empty value.
2232
2233         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2234         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
2235         case of aria-invalid event with empty value.
2236
2237 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2238
2239         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
2240         https://bugs.webkit.org/show_bug.cgi?id=120421
2241
2242         Reviewed by Mario Sanchez Prada.
2243
2244         Implemented the notification listener for AccessibilityUIElement for
2245         WebKitTestRunner. The signal is generated by
2246         AXObjectCache::postPlatformNotification() and received by
2247         axObjectEventListener(). axObjectEventListener() will then invoke
2248         JSObjectCallAsFunction() with the respective callback function. The
2249         notification handlers are stored in HashMap in
2250         AccessibilityNotificationHandlerAtk.cpp.
2251
2252         Moved ATK signal handling (printAccessibilityEvent and
2253         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
2254
2255         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
2256         include path.
2257         * WebKitTestRunner/GNUmakefile.am:
2258         Added AccessibilityNotificationHandlerAtk.cpp/h.
2259         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
2260         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2261         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
2262         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2263         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
2264         notification handler for GTK+ and EFL.
2265         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2266         Moved printAccessibilityEvent and axObjectEventListener to
2267         AccessibilityNotificationHandlerAtk.cpp.
2268         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
2269         IDs to AccessibilityNotificationHandlerAtk.cpp.
2270         (WTR::AccessibilityController::resetToConsistentState): Moved listener
2271         IDs to AccessibilityNotificationHandlerAtk.cpp.
2272         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2273         (WTR::printAccessibilityEvent): Prints accessibility events. This
2274         function was moved from AccessibilityControllerAtk.cpp.
2275         (WTR::axObjectEventListener): Callback for signals. This function was
2276         moved from AccessibilityControllerAtk.cpp.
2277         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2278         Initialize element and function callback.
2279         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
2280         Removes handler from HashMap and disconnects callbacks if necessary.
2281         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
2282         logging mode and connects callbacks.
2283         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2284         Sets the notification callback and connects callback to signals.
2285         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2286         Removes the notification callback from HashMap.
2287         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2288         Connects axObjectEventListener to ATK signals.
2289         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2290         Disconnects callback.
2291         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
2292         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
2293         of AccessibilityNotificationHandler.
2294         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
2295         element.
2296         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
2297         element.
2298         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
2299         Gets the notification callback.
2300         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2301         (WTR::AccessibilityUIElement::addNotificationListener): Creates
2302         notification handler, set the platform element and the notification
2303         callback.
2304         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
2305         notification handler.
2306         * WebKitTestRunner/PlatformEfl.cmake:
2307         Added AccessibilityNotificationHandlerAtk.cpp.
2308
2309 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2310
2311         Update features.pri
2312         https://bugs.webkit.org/show_bug.cgi?id=121670
2313
2314         Reviewed by Jocelyn Turcotte.
2315
2316         Remove feature flags that no longer exists and new ones added to FeatureList.pm
2317
2318         * qmake/mkspecs/features/features.pri:
2319
2320 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
2321
2322         [GTK][WK2] accessibility/selection-states.html is failing
2323         https://bugs.webkit.org/show_bug.cgi?id=116972
2324
2325         Reviewed by Mario Sanchez Prada.
2326
2327         isSelectable() was not exposed in Accessibility.
2328
2329         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2330
2331 2013-09-19  Dan Bernstein  <mitz@apple.com>
2332
2333         Attempted build fix after r156114.
2334
2335         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
2336
2337 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
2338
2339         REGRESSION (r129451): run-safari --no-saved-state is broken
2340         https://bugs.webkit.org/show_bug.cgi?id=121566
2341
2342         Undo a last minute change that doesn't actually work.
2343
2344         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
2345         via command line, <rdar://problem/15032886>.
2346
2347 2013-09-19  Dan Bernstein  <mitz@apple.com>
2348
2349         Add a style guideline regarding spacing in range-based for loops
2350         https://bugs.webkit.org/show_bug.cgi?id=121620
2351
2352         Reviewed by Anders Carlsson.
2353
2354         * Scripts/webkitpy/style/checkers/cpp.py:
2355         (check_spacing): Added checking that there are spaces around the colon in a range-based for
2356         loop.
2357         (CppChecker): Added whitespace/colon to the categories set.
2358         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2359         (WebKitStyleTest.test_spacing): Added two tests for the new check.
2360
2361 2013-09-18  Sam Weinig  <sam@webkit.org>
2362
2363         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
2364         https://bugs.webkit.org/show_bug.cgi?id=121588
2365
2366         Reviewed by Anders Carlsson.
2367
2368         * DumpRenderTree/TestRunner.cpp:
2369         * ImageDiff/efl/ImageDiff.cpp:
2370         * TestWebKitAPI/JavaScriptTest.cpp:
2371         * TestWebKitAPI/PlatformUtilities.cpp:
2372         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2373         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2374         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2375         * WebKitTestRunner/StringFunctions.h:
2376         * WebKitTestRunner/TestInvocation.cpp:
2377         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2378         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2379
2380 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
2381
2382         W3C Test Import script reformats test HTML
2383         https://bugs.webkit.org/show_bug.cgi?id=119159
2384
2385         Reviewed by Dirk Pranke.
2386
2387         Completely rewrite the test conversion process to minimize
2388         reformatting when adding prefixes, etc. This isn't 100% perfect, there
2389         are still places where it will end up changing the formatting, but it
2390         is much better than before. Most notably, the public interface to the
2391         test converter has changed: now one calls a method instead of creating
2392         an instance of the test converter class. This is because the test
2393         converter class now has state, so one really needs a new instance for
2394         each test.
2395
2396         Note that this also lays some simple groundwork for being able to use
2397         a MockHost in the tests.
2398
2399         * Scripts/webkitpy/w3c/test_converter.py:
2400         (convert_for_webkit):
2401         (_W3CTestConverter):
2402         (_W3CTestConverter.__init__):
2403         (_W3CTestConverter.output):
2404         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2405         (_W3CTestConverter.convert_style_data):
2406         (_W3CTestConverter.convert_attributes_if_needed):
2407         (_W3CTestConverter.handle_starttag):
2408         (_W3CTestConverter.handle_endtag):
2409         (_W3CTestConverter.handle_startendtag):
2410         (_W3CTestConverter.handle_data):
2411         (_W3CTestConverter.handle_entityref):
2412         (_W3CTestConverter.handle_charref):
2413         (_W3CTestConverter.handle_comment):
2414         (_W3CTestConverter.handle_decl):
2415         (_W3CTestConverter.handle_pi):
2416         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2417         (W3CTestConverterTest):
2418         (W3CTestConverterTest.fake_dir_path):
2419         (W3CTestConverterTest.test_read_prefixed_property_list):
2420         (verify_no_conversion_happened):
2421         * Scripts/webkitpy/w3c/test_importer.py:
2422         (TestImporter.import_tests):
2423
2424 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
2425
2426         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
2427         https://bugs.webkit.org/show_bug.cgi?id=121578
2428
2429         Rubber stamped by Geoffrey Garen.
2430
2431         * Scripts/run-layout-jsc:
2432
2433 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
2434
2435         Unreviewed, fix for Ruby 1.8.
2436
2437         * Scripts/run-jsc-stress-tests:
2438
2439 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
2440
2441         run-jsc-stress-tests should make it easier to look at error spew from tests
2442         https://bugs.webkit.org/show_bug.cgi?id=121531
2443
2444         Reviewed by Mark Hahnenberg.
2445         
2446         This makes two changes:
2447         
2448         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
2449         
2450         - The same spew also goes to the console but is prefixed by the test's name.
2451         
2452         This required some tee and awk hacks, and then some sh hacks to work around the fact
2453         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
2454         operator will only see a failure of bar failed. So to pass output to tee and awk, I
2455         needed to do weird things.
2456
2457         * Scripts/run-jsc-stress-tests:
2458
2459 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
2460
2461         REGRESSION (r129451): run-safari --no-saved-state is broken
2462         https://bugs.webkit.org/show_bug.cgi?id=121566
2463
2464         Reviewed by Mark Rowe.
2465
2466         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
2467         Check arguments, not the newly created empty array. Pass a value that silences warnings.
2468         While at it, removed a check for Snow Leopard.
2469
2470 2013-09-18  Alex Christensen  <achristensen@webkit.org>
2471
2472         Improved WinLauncher's URL handling.
2473         https://bugs.webkit.org/show_bug.cgi?id=121535
2474
2475         Reviewed by Brent Fulgham.
2476
2477         * WinLauncher/WinLauncher.cpp:
2478         (EditProc):
2479         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
2480         (loadURL):
2481         Prepend "http://" to URLs with no scheme.
2482
2483 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
2484
2485         DFG should support Int52 for local variables
2486         https://bugs.webkit.org/show_bug.cgi?id=121064
2487
2488         Reviewed by Oliver Hunt.
2489
2490         * Scripts/run-jsc-stress-tests:
2491
2492 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
2493
2494         [Win] TestWebKitAPI does not compile.
2495         https://bugs.webkit.org/show_bug.cgi?id=121485
2496
2497         Reviewed by Brent Fulgham.
2498
2499         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
2500         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
2501         to return null, which is the case we want to test.
2502
2503         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2504         (TestWebKitAPI::TEST):
2505
2506 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
2507
2508         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
2509         https://bugs.webkit.org/show_bug.cgi?id=121495
2510
2511         Reviewed by Chris Fleizach.
2512
2513         Adapted DRT and WKTR to deal with the new names for the ATK object
2514         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
2515
2516         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2517         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
2518         (AccessibilityUIElement::stringAttributeValue): Ditto.
2519         (AccessibilityUIElement::hasPopup): Ditto.
2520         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2521         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
2522         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2523         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2524
2525 2013-09-18  Commit Queue  <commit-queue@webkit.org>
2526
2527         Unreviewed, rolling out r156019 and r156020.
2528         http://trac.webkit.org/changeset/156019
2529         http://trac.webkit.org/changeset/156020
2530         https://bugs.webkit.org/show_bug.cgi?id=121540
2531
2532         Broke tests (Requested by ap on #webkit).
2533
2534         * Scripts/run-jsc-stress-tests:
2535
2536 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
2537
2538         Unreviewed. Add myself as a committer.
2539
2540         * Scripts/webkitpy/common/config/contributors.json:
2541
2542 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
2543
2544         Unreviewed. Add myself as a committer.
2545
2546         * Scripts/webkitpy/common/config/contributors.json:
2547
2548 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
2549
2550         DFG should support Int52 for local variables
2551         https://bugs.webkit.org/show_bug.cgi?id=121064
2552
2553         Reviewed by Oliver Hunt.
2554
2555         * Scripts/run-jsc-stress-tests:
2556
2557 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
2558
2559         Added back and forward buttons to WinLauncher.
2560         https://bugs.webkit.org/show_bug.cgi?id=121212
2561
2562         Reviewed by Brent Fulgham.
2563
2564         * WinLauncher/WinLauncher.cpp:
2565         (resizeSubViews):
2566         Move new back and forward buttons to correct positions before URL bar.
2567         (dllLauncherEntryPoint): 
2568         Store the default button window procedure and replace with my button procedures.
2569         (EditProc): Updated style and renamed from MyEditProc.
2570         (BackButtonProc): Added.
2571         (ForwardButtonProc): Added.
2572
2573 2013-09-17  Michael Saboff  <msaboff@apple.com>
2574
2575         Unreviewed typo fix after r155999
2576
2577         Changed en_US.UTB-8 to en_US.UTF-8
2578
2579         * Scripts/run-javascriptcore-tests:
2580
2581 2013-09-17  Michael Saboff  <msaboff@apple.com>
2582
2583         run-jsc-stress-tests fails with ruby version 2
2584         https://bugs.webkit.org/show_bug.cgi?id=121521
2585
2586         Reviewed by Jessie Berlin.
2587
2588         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
2589
2590         * Scripts/run-javascriptcore-tests:
2591
2592 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
2593
2594         [Windows] Unreviewed build fix after r155963.
2595
2596         * DumpRenderTree/win/TestRunnerWin.cpp:
2597         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
2598
2599 2013-09-17  Anders Carlsson  <andersca@apple.com>
2600
2601         Fix a typo.
2602
2603         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2604         (TestWebKitAPI::TEST):
2605
2606 2013-09-16  Anders Carlsson  <andersca@apple.com>
2607
2608         HashMap should work with move-only keys
2609         https://bugs.webkit.org/show_bug.cgi?id=121310
2610
2611         Reviewed by Darin Adler.
2612
2613         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2614         (TestWebKitAPI::TEST):
2615         Add test.
2616
2617 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
2618
2619         BrowserMarshal.h build fail
2620         https://bugs.webkit.org/show_bug.cgi?id=102938
2621
2622         Reviewed by Carlos Garcia Campos.
2623
2624         Fix variable name.
2625
2626         * MiniBrowser/gtk/GNUmakefile.am:
2627
2628 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
2629
2630         [Windows] Clean up WinLauncher by using smart pointers
2631         https://bugs.webkit.org/show_bug.cgi?id=121467
2632
2633         Reviewed by Anders Carlsson.
2634
2635         * WinLauncher/PrintWebUIDelegate.cpp:
2636         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
2637         * WinLauncher/WinLauncher.cpp:
2638         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
2639         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
2640         (showLastVisitedSites): Smart pointer updates.
2641         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
2642         (setToDefaultPreferences): Ditto.
2643         (dllLauncherEntryPoint): Ditto.
2644         (PrintView): Ditto.
2645         (LaunchInspector): Ditto.
2646         (NavigateToHistory): Ditto.
2647         (MyEditProc): Ditto.
2648         (loadURL): Ditto.
2649
2650 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
2651
2652         [Windows] Add rudimentary history to WinLauncher.
2653         https://bugs.webkit.org/show_bug.cgi?id=121463
2654
2655         Reviewed by Anders Carlsson.
2656
2657         * WinLauncher/WinLauncher.cpp:
2658         (updateMenuItemForHistoryItem): Added
2659         (showLastVisitedSites): Added
2660         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
2661         a new page has been visited.
2662         (dllLauncherEntryPoint): Deallocate history on exit.
2663         (NavigateToHistory): Added
2664         (WndProc): Add handler for history entries
2665         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
2666         up to 10 history slots.
2667         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
2668         Windows utility library to allow use of _bstr_t type.
2669         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
2670         to hold up to 10 history slots.
2671         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
2672
2673 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
2674
2675         [GTK] Make symbol export filter more strict, and disable for dev/test builds
2676         https://bugs.webkit.org/show_bug.cgi?id=120586
2677
2678         Reviewed by Martin Robinson.
2679
2680         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
2681         makefiles, so they can be included unconditionally.
2682         * GtkLauncher/GNUmakefile.am: added.
2683         * Scripts/webkitdirs.pm:
2684         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
2685         to configure, since we consider builds done through build-webkit to be development
2686         and test builds.
2687         * gtk/GNUmakefile.am: added.
2688         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
2689         it's not necessary and it will not work now that the Scripts directory is not
2690         shipped in the tarball.
2691
2692 2013-09-16  Anders Carlsson  <andersca@apple.com>
2693
2694         WTF::Deque should work with move only types
2695         https://bugs.webkit.org/show_bug.cgi?id=121446
2696
2697         Reviewed by Andreas Kling.
2698
2699         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2700         (TestWebKitAPI::TEST):
2701         Add a test.
2702
2703 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
2704
2705         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
2706         https://bugs.webkit.org/show_bug.cgi?id=98410
2707
2708         Reviewed by Darin Adler.
2709
2710         Add implementation of click() method of objects returned by eventSender.contextClick().
2711
2712         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2713         (MenuItemPrivateData):
2714         (WTR::menuItemClickCallback):
2715         (WTR::getMenuItemTitleCallback):
2716         (WTR::staticMenuItemFinalize):
2717         (WTR::getMenuItemClass):
2718         (WTR::EventSendingController::contextClick):
2719
2720 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
2721
2722         Make the GDB webkit.py script compatible with Python v3
2723         https://bugs.webkit.org/show_bug.cgi?id=121395
2724
2725         Reviewed by Ryosuke Niwa.
2726
2727         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
2728         uses of xrange() in the script are replaced with range(), and the print statements are changed into
2729         the print() function invocations.
2730
2731         * gdb/webkit.py:
2732         (guess_string_length):
2733         (ustring_to_string):
2734         (lstring_to_string):
2735         (WTFCStringPrinter.to_string):
2736         (PrintPathToRootCommand.invoke):
2737
2738 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
2739
2740         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
2741         https://bugs.webkit.org/show_bug.cgi?id=119631
2742
2743         Reviewed by Ryosuke Niwa.
2744
2745         The perf profiler is attached to the test runner after the test runner has been launched,
2746         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
2747         UIProcess, meaning that WebProcess operations will not be profiled.
2748
2749         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
2750         This is done in the scope of already present support for wrapper scripts (such as valgrind)
2751         that are settable through the --wrapper option. This causes the perf profiler to correctly
2752         continue profiling the WebProcess after it was spawned.
2753
2754         When the profiler is launched, a wait process is launched with the profiler's pid as the
2755         argument. This ensures we can check that the profiler exited normally. If it did not, its
2756         output can be corrupted and can cause problems when that output is examined. The after-exit
2757         report is avoided in that case.
2758
2759         * Scripts/webkitpy/common/system/profiler.py:
2760         (Profiler.wrapper_arguments): The method returns an empty list by default.
2761         (Perf.__init__): Remove unnecessary member variables.
2762         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
2763         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
2764         the method returns a list of arguments that should be used as a wrapper for the test runner.
2765         The arguments specify the 'perf record' command, with the output file and the instruction to
2766         construct the call graph given as well.
2767         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
2768         whitespace in the profile lines.
2769         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
2770         running. If it is running even after that, or if the profiler process produced a non-zero exit
2771         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
2772         the top 10 lines of the profile and how to examine the profile further.
2773         * Scripts/webkitpy/port/driver.py:
2774         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
2775         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
2776         or an empty list otherwise.
2777         (Driver.cmd_line):
2778         * Scripts/webkitpy/port/driver_unittest.py:
2779         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
2780         for the testing-specific Port object.
2781         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
2782         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
2783         a parameter.
2784         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
2785         when profiling on the Linux platform with the perf profiler.
2786
2787 2013-09-14  Dan Bernstein  <mitz@apple.com>
2788
2789         [mac] Check For Framework Include Consistency build phase checks the wrong framework
2790         https://bugs.webkit.org/show_bug.cgi?id=121215
2791
2792         Reviewed by Mark Rowe.
2793
2794         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
2795         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
2796         public and private headers folder paths. Also tweaked the error messages’ format to make
2797         Xcode recognize them as errors.
2798
2799 2013-09-14  Alberto Garcia  <berto@igalia.com>
2800
2801         [GTK] Fails to compile if the build directory is in a different partition
2802         https://bugs.webkit.org/show_bug.cgi?id=121296
2803
2804         Reviewed by Martin Robinson.
2805
2806         Instead of using os.symlink() to install the gtk-doc templates,
2807         use os.link() first and fall back to os.symlink() if it fails.
2808
2809         * gtk/gtkdoc.py:
2810         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
2811
2812 2013-09-14  Alberto Garcia  <berto@igalia.com>
2813
2814         [GTK] WebKitGTK+ is linking against libxslt in too many places
2815         https://bugs.webkit.org/show_bug.cgi?id=121356
2816
2817         Reviewed by Martin Robinson.
2818
2819         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
2820         so we don't need to link against it.
2821
2822         * MiniBrowser/gtk/GNUmakefile.am:
2823         * TestWebKitAPI/GNUmakefile.am:
2824         * WebKitTestRunner/GNUmakefile.am:
2825
2826 2013-09-14  Ross Burton  <ross.burton@intel.com>
2827
2828         Uses gtk-doc tools even when --disable-gtk-doc passed
2829         https://bugs.webkit.org/show_bug.cgi?id=91239
2830
2831         Reviewed by Martin Robinson.
2832
2833         Don't run generate-gtkdoc on install if gtk-doc is disabled.
2834
2835         * GNUmakefile.am:
2836
2837 2013-09-14  Alberto Garcia  <berto@igalia.com>
2838
2839         [GTK] Fails to compile if the build directory is in a different partition
2840         https://bugs.webkit.org/show_bug.cgi?id=121296
2841
2842         Reviewed by Carlos Garcia Campos.
2843
2844         Use symlinks instead of hard links to support building on a
2845         different file system.
2846
2847         * gtk/gtkdoc.py:
2848         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
2849
2850 2013-09-13  Darin Adler  <darin@apple.com>
2851
2852         Use a better name than m_invertibleCTM
2853         https://bugs.webkit.org/show_bug.cgi?id=121341
2854
2855         Reviewed by Andreas Kling.
2856
2857         * Scripts/do-webcore-rename: Updated to do this replace as we do.
2858
2859 2013-09-13  Anders Carlsson  <andersca@apple.com>
2860
2861         Pick the correct overload when a const reference is passed to appendSlowCase.
2862         https://bugs.webkit.org/show_bug.cgi?id=121326
2863
2864         Reviewed by Darin Adler.
2865
2866         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2867         (TestWebKitAPI::TEST):
2868
2869 2013-09-13  Darin Adler  <darin@apple.com>
2870
2871         Rename confusingly named "runtimeObject" functions
2872         https://bugs.webkit.org/show_bug.cgi?id=121339
2873
2874         Reviewed by Sam Weinig.
2875
2876         * Scripts/do-webcore-rename: Updated to do this replace as usual.
2877
2878 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
2879
2880         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
2881         https://bugs.webkit.org/show_bug.cgi?id=121330
2882
2883         Reviewed by Mark Hahnenberg and Oliver Hunt.
2884
2885         We should run tests even if they don't have expected files yet.
2886         
2887         * Scripts/run-layout-jsc:
2888
2889 2013-09-13  Anders Carlsson  <andersca@apple.com>
2890
2891         Use nullptr instead of 0 in calls to HashMap::add
2892         https://bugs.webkit.org/show_bug.cgi?id=121322
2893
2894         Reviewed by Sam Weinig.
2895
2896         * DumpRenderTree/mac/TestRunnerMac.mm:
2897         (TestRunner::evaluateScriptInIsolatedWorld):
2898         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2899         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
2900
2901 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2902
2903         [GTK] Move to the new web inspector
2904         https://bugs.webkit.org/show_bug.cgi?id=120647
2905
2906         Reviewed by Carlos Garcia Campos.
2907
2908         * GtkLauncher/main.c:
2909         (main): no longer set WEBKIT_INSPECTOR_PATH.
2910         * MiniBrowser/gtk/main.c:
2911         (main): ditto.
2912         * Scripts/old-run-webkit-tests:
2913         (openDumpTool): ditto.
2914         * Scripts/run-gtk-tests: ditto.
2915         * Scripts/webkitpy/port/gtk.py:
2916         (GtkPort.setup_environ_for_server): ditto.
2917
2918 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2919
2920         [Qt] REGRESSION(r154444): xss-DENIED test results changed
2921         https://bugs.webkit.org/show_bug.cgi?id=120595
2922
2923         Reviewed by Jocelyn Turcotte.
2924
2925         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
2926
2927         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2928         (DumpRenderTree::initJSObjects):
2929
2930 2013-09-13  Darin Adler  <darin@apple.com>
2931
2932         Give actions in Range class NON_SHOUTING_NAMES
2933         https://bugs.webkit.org/show_bug.cgi?id=121280
2934
2935         Reviewed by Andreas Kling.
2936
2937         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
2938         the tradition of checking in the last one we did, along with other
2939         rename ideas for the future.
2940
2941 2013-09-12  Lucas Forschler  <lforschler@apple.com>
2942
2943         Create short build logs for errors and warnings.
2944         https://bugs.webkit.org/show_bug.cgi?id=120614
2945
2946         Reviewed by Ryosuke Niwa.
2947
2948         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2949             -include StringIO 
2950         (CompileWebKit.createSummary):
2951             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
2952
2953 2013-09-12  Roger Fong  <roger_fong@apple.com>
2954
2955         Update cygwin downloader to search for packages in the right location.
2956
2957         * CygwinDownloader/cygwin-downloader.py:
2958         * CygwinDownloader/cygwin-downloader.zip:
2959
2960 2013-09-12  Anders Carlsson  <andersca@apple.com>
2961
2962         Add rudimentary support for move-only types as values in HashMap
2963         https://bugs.webkit.org/show_bug.cgi?id=121226
2964
2965         Reviewed by Andreas Kling.
2966
2967         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2968         (TestWebKitAPI::TEST):
2969         Add a HashMap<unsigned, MoveOnly> test.
2970
2971 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2972
2973         Auto GDB backtrace generation for EFL/GTK/Qt bots.
2974         https://bugs.webkit.org/show_bug.cgi?id=119338
2975
2976         Reviewed by Csaba Osztrogonác.
2977
2978         * Scripts/webkitpy/port/efl.py:
2979         (EflPort.check_sys_deps):
2980         (EflPort):
2981         (EflPort._get_crash_log):
2982         * Scripts/webkitpy/port/efl_unittest.py:
2983         (EflPortTest.test_show_results_html_file):
2984         (EflPortTest):
2985         (EflPortTest.test_get_crash_log):
2986         * Scripts/webkitpy/port/gtk.py:
2987         (GtkPort._get_crash_log):
2988         * Scripts/webkitpy/port/gtk_unittest.py:
2989         (GtkPortTest.test_get_crash_log):
2990         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
2991         (GDBCrashLogGenerator):
2992         (GDBCrashLogGenerator.__init__):
2993         (GDBCrashLogGenerator._get_gdb_output):
2994         (GDBCrashLogGenerator.generate_crash_log):
2995         (GDBCrashLogGenerator.generate_crash_log.match_filename):
2996         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
2997         (GDBCrashLogGeneratorTest):
2998         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2999         (_mock_gdb_output):
3000         * Scripts/webkitpy/port/qt.py:
3001         (QtPort.default_child_processes):
3002         (QtPort):
3003         (QtPort._get_crash_log):
3004         * Scripts/webkitpy/port/qt_unittest.py:
3005         (QtPortTest.test_check_sys_deps):
3006         (QtPortTest):
3007         (QtPortTest.test_get_crash_log):
3008
3009 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
3010
3011         Unreviewed. Moving myself to the commiters list.
3012
3013         * Scripts/webkitpy/common/config/contributors.json:
3014
3015 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
3016
3017         [GTK] Add jhbuild-wayland.modules
3018         https://bugs.webkit.org/show_bug.cgi?id=120455
3019
3020         Reviewed by Gustavo Noronha Silva.
3021
3022         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
3023         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
3024         WEBKIT_EXTRA_MODULESETS.
3025
3026         * gtk/jhbuild-wayland.modules: Added.
3027
3028 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
3029
3030         [GTK][WK2] a11y tests unconditionally launching a11y daemons
3031         https://bugs.webkit.org/show_bug.cgi?id=120299
3032
3033         Reviewed by Carlos Garcia Campos.
3034
3035         Use the right variable name to store a reference to the at-spi2
3036         bus launcher process, so we can be sure we are terminating it when
3037         calling _tear_down_testing_environment().
3038
3039         * Scripts/run-gtk-tests:
3040         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
3041         instead of _ally_bus_launcher.
3042
3043 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3044
3045         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
3046         https://bugs.webkit.org/show_bug.cgi?id=121218
3047
3048         Reviewed by Philippe Normand.
3049
3050         Skipping the entire suite was added to skip tests when they can't
3051         be run because of the environment, for example to skip the a11y
3052         tests when the at-spi daemons fail to start. This is no longer
3053         true for all the cases, so we can disable the tests that are
3054         impossible to run instead of skipping them.
3055
3056         * Scripts/run-gtk-tests:
3057         (TestRunner.__init__): Initialize the skipped tests list.
3058         (TestRunner._setup_testing_environment): Add
3059         TestWebKitAccessibility path to the list of disabled tests when
3060         at-spi daemon fail to start.
3061         (TestRunner._should_run_test_program): Check first if the test
3062         program is disabled and then whether it's skipped honoring the
3063         skipped command line option.
3064
3065 2013-09-12  Samuel White  <samuel_white@apple.com>
3066
3067         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
3068         https://bugs.webkit.org/show_bug.cgi?id=117651
3069
3070         Reviewed by Mario Sanchez Prada.
3071
3072         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
3073
3074         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3075         (AccessibilityUIElement::valueDescription):
3076         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3077         (WTR::AccessibilityUIElement::valueDescription):
3078
3079 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3080
3081         REGRESSION(r154781): accessibility/notification-listeners.html is failing
3082         https://bugs.webkit.org/show_bug.cgi?id=120669
3083
3084         Reviewed by Chris Fleizach.
3085
3086         Fixed 4 problems that were causing notification-listeners.html to fail.
3087
3088         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
3089         implemented in axObjectEventListener().
3090
3091         A notification for AXFocusedUIElementChanged was incorrectly sent when
3092         the element lost focus.
3093
3094         Global notification was not dispatched if an element notification was
3095         present in the HashMap.
3096
3097         connectAccessibilityCallbacks() was connecting signals to callbacks
3098         multiple times because it was not checking if
3099         disconnectAccessibilityCallbacks() had an early return if there were
3100         active handlers.
3101
3102         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
3103         disconnectAccessibilityCallbacks() to inform if the callbacks were
3104         successfully disconnected.
3105         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3106         (axObjectEventListener): Implemented notifications for
3107         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
3108         notification, which was not dispatched if an element notification
3109         existed. Fixed the notification for AXFocusedUIElementChanged that was
3110         incorrectly sent when the element lost focus. In addition, fixed a typo
3111         where TRUE should be true.
3112         (connectAccessibilityCallbacks): Added early return if
3113         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
3114         (disconnectAccessibilityCallbacks): Added a return value to inform if
3115         callbacks were successfully disconnected.
3116
3117 2013-09-11  Anders Carlsson  <andersca@apple.com>
3118
3119         Try to fix GCC builds.
3120
3121         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
3122
3123 2013-09-11  Anders Carlsson  <andersca@apple.com>
3124
3125         Try to fix the build.
3126
3127         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
3128         file in the Tests/ directory in the first place.
3129
3130         * TestWebKitAPI/CMakeLists.txt:
3131         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3132         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3134         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
3135
3136 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3137
3138         [Windows] Build fix for MoveOnly
3139
3140         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
3141         Tests to include search path.
3142         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3143         Ditto.
3144
3145 2013-09-11  Anders Carlsson  <andersca@apple.com>
3146
3147         Add HashSet::take
3148         https://bugs.webkit.org/show_bug.cgi?id=121192
3149
3150         Reviewed by Darin Adler.
3151
3152         Add a test for HashSet::take.
3153
3154         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3155         (TestWebKitAPI::TEST):
3156
3157 2013-09-11  Anders Carlsson  <andersca@apple.com>
3158
3159         HashSet should work with move only types
3160         https://bugs.webkit.org/show_bug.cgi?id=121188
3161
3162         Reviewed by Geoffrey Garen.
3163
3164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3165         * TestWebKitAPI/Tests/MoveOnly.h: Added.
3166         Move the MoveOnly class from Vector out into its own header.
3167
3168         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3169         (TestWebKitAPI::TEST):
3170         Add aHashSet<MoveOnly> test.
3171
3172         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3173         Include MoveOnly.h.
3174
3175 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3176
3177         [Windows] Avoid converting from IntSize->SIZE->IntSize
3178         https://bugs.webkit.org/show_bug.cgi?id=121180
3179
3180         Reviewed by Anders Carlsson.
3181
3182         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3183         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
3184
3185 2013-09-11  Dan Bernstein  <mitz@apple.com>
3186
3187         REGRESSION (r155561): extract-localizable-strings can miss strings
3188         https://bugs.webkit.org/show_bug.cgi?id=121184
3189
3190         Reviewed by Darin Adler.
3191
3192         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
3193         parenthesis or bracket.
3194
3195 2013-09-11  Dan Bernstein  <mitz@apple.com>
3196
3197         update-webkit-localizable-strings is at least 5.8x slower than it should be
3198         https://bugs.webkit.org/show_bug.cgi?id=121178
3199
3200         Reviewed by Darin Adler.
3201
3202         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
3203         Note that this does not change functionality, because the script already does not understand
3204         the line continuation sequence (backslash followed by a newline).
3205
3206 2013-09-11  Anders Carlsson  <andersca@apple.com>
3207
3208         Vector::append doesn't work if element type has overloaded operator&
3209         https://bugs.webkit.org/show_bug.cgi?id=121175
3210
3211         Reviewed by Brent Fulgham.
3212
3213         Add a test case.
3214
3215         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3216         (TestWebKitAPI::TEST):
3217
3218 2013-09-11  Anders Carlsson  <andersca@apple.com>
3219
3220         Implement Vector::append for move-only types
3221         https://bugs.webkit.org/show_bug.cgi?id=120805
3222
3223         Reviewed by Sam Weinig.
3224
3225         Add a test for Vector<MoveOnly>::append.
3226
3227         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3228         (TestWebKitAPI::TEST):
3229
3230 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
3231
3232         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
3233
3234         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3235         (RunAndUploadPerfTests):
3236         (RunAndUploadPerfTests.start):
3237         (RunAndUploadPerfTests.getText2):
3238
3239 2013-09-11  Anders Carlsson  <andersca@apple.com>
3240
3241         The style checker shouldn't complain about returning or passing OwnPtr
3242         https://bugs.webkit.org/show_bug.cgi?id=121163
3243
3244         Reviewed by Antti Koivisto.
3245
3246         * Scripts/webkitpy/style/checkers/cpp.py:
3247         (check_function_definition_and_pass_ptr):
3248         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3249         (PassPtrTest.test_pass_ref_ptr_return_value):
3250         (PassPtrTest.test_own_ptr_parameter_value):
3251
3252 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3253
3254         [GTK] Remove Gail dependency from build system for GTK3
3255         https://bugs.webkit.org/show_bug.cgi?id=119673
3256
3257         Reviewed by Gustavo Noronha Silva.
3258
3259         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
3260         * Scripts/webkitpy/port/gtk.py:
3261         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
3262         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
3263
3264 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3265
3266         Performance tester bots should report the number of failing tests
3267         https://bugs.webkit.org/show_bug.cgi?id=120462
3268
3269         Reviewed by Csaba Osztrogonác.
3270
3271         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3272         (RunAndUploadPerfTests.start.getText):
3273         (RunAndUploadPerfTests.start):
3274         (RunAndUploadPerfTests):
3275         (RunAndUploadPerfTests.start.getText2):
3276
3277 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
3278
3279         [ATK] Adds mapping MenuItemRadioRole to ATK
3280         https://bugs.webkit.org/show_bug.cgi?id=121149
3281
3282         Reviewed by Mario Sanchez Prada.
3283
3284         Adds mapping MenuItemRadioRole to ATK.
3285
3286         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3287         (roleToString):
3288         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3289         (WTR::roleToString):
3290
3291 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
3292
3293         Unreviewed fix after the unreviewed r155498 to unbreak the failure
3294         counter of run-javascriptcore-tests build step on build.webkit.org.
3295
3296         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3297         (RunJavaScriptCoreTests.commandComplete):
3298         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3299
3300 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
3301
3302         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
3303         got a bit overlooked from the fast/js->js refactoring.
3304
3305         * Scripts/run-javascriptcore-tests:
3306
3307 2013-09-10  Daniel Bates  <dabates@apple.com>
3308
3309         [iOS] Upstream text autosizing
3310         https://bugs.webkit.org/show_bug.cgi?id=121111
3311
3312         Reviewed by Andy Estes and Sam Weinig.
3313
3314         Implement infrastructure to test the iOS text autosizing code.
3315
3316         * DumpRenderTree/TestRunner.cpp:
3317         (setTextAutosizingEnabledCallback): Added.
3318         (TestRunner::staticFunctions):
3319         * DumpRenderTree/TestRunner.h:
3320         * DumpRenderTree/mac/DumpRenderTree.mm:
3321         (resetDefaultsToConsistentValues):
3322         * DumpRenderTree/mac/TestRunnerMac.mm:
3323         (TestRunner::setTextAutosizingEnabled): Added.
3324
3325 2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>
3326
3327         run-jsc-stress-tests should have a mode for always running the copy phase
3328         https://bugs.webkit.org/show_bug.cgi?id=121128
3329
3330         Reviewed by Geoffrey Garen.
3331
3332         This will increase test coverage of the copying phase, which might not always get 
3333         triggered normally with our default parameters for required Heap/CopiedBlock utilization.
3334
3335         * Scripts/run-jsc-stress-tests:
3336
3337 2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>
3338
3339         [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
3340         https://bugs.webkit.org/show_bug.cgi?id=121114
3341
3342         Reviewed by Christophe Dumez.
3343
3344         Use a tarball for libseccomp instead of git to avoid network issues on
3345         the buildbots while checking out the git repo. Using tarballs has the
3346         advantage of them being cached if the checksum matches, in which case
3347         there will be no need to download them again.
3348
3349         * efl/jhbuild.modules:
3350
3351 2013-09-10  Mark Lam  <mark.lam@apple.com>
3352
3353         Replace remaining "fast js" names in scripts.
3354         https://bugs.webkit.org/show_bug.cgi?id=120899.
3355
3356         Rubber stamped by Filip Pizlo.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3359         (test_layout_failure_new_output):
3360         (test_layout_crash_new_output):
3361         (test_mozilla_and_layout_failure_new_output):
3362         * Scripts/run-fast-jsc: Removed.
3363         * Scripts/run-javascriptcore-tests:
3364         * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
3365
3366 2013-09-10  Zan Dobersek  <zdobersek@igalia.com>
3367
3368         Enable JSC stress tests for the rest of non-Windows platforms
3369         https://bugs.webkit.org/show_bug.cgi?id=121021
3370
3371         Reviewed by Filip Pizlo.
3372
3373         The JSC stress tests can already be enabled on Linux-based ports.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3376         (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
3377         JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
3378         complete output, with the number of failing or crashing tests properly extracted.
3379         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
3380         output in other unit tests testing the parsing of the output in the new format.
3381         (test_jsc_stress_failure_new_output):
3382         (test_fast_js_crashes_and_jsc_stress_failures_new_output):
3383         * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
3384         * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
3385         variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
3386         of available CPUs so the stress tests can be run in parallel.
3387
3388 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
3389
3390         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
3391         https://bugs.webkit.org/show_bug.cgi?id=120552
3392
3393         Unreviewed build fix.
3394
3395         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3396         (AccessibilityUIElement::classList):
3397
3398 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
3399
3400         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
3401         https://bugs.webkit.org/show_bug.cgi?id=120552
3402
3403         Reviewed by Darin Adler.
3404
3405         * DumpRenderTree/AccessibilityUIElement.cpp:
3406         (getClassListCallback):
3407         (AccessibilityUIElement::getJSClass):
3408         * DumpRenderTree/AccessibilityUIElement.h:
3409         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3410         (AccessibilityUIElement::classList):
3411         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3412         (AccessibilityUIElement::classList):
3413         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3414         (AccessibilityUIElement::classList):
3415         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3416         (AccessibilityUIElement::classList):
3417         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3418         (WTR::AccessibilityUIElement::classList):
3419         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3420         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3421         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3422         (WTR::AccessibilityUIElement::classList):
3423         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3424         (WTR::AccessibilityUIElement::classList):
3425
3426 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
3427
3428         [GTK] accessibility/loading-iframe-sends-notification.html is failing
3429         https://bugs.webkit.org/show_bug.cgi?id=98370
3430
3431         Reviewed by Chris Fleizach.
3432
3433         Added AXLayoutComplete for the GTK platform.
3434
3435         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3436         (axObjectEventListener): Added notification AXLayoutComplete for
3437         layout-complete signal.
3438
3439 2013-09-09  Brent Fulgham  <bfulgham@apple.com>
3440
3441         [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
3442         https://bugs.webkit.org/show_bug.cgi?id=120778
3443
3444         Reviewed by Anders Carlsson.
3445
3446         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3447         (createBitmapContextFromWebView): Use GDIObject.
3448         * Scripts/webkitpy/style/checkers/cpp.py:
3449         (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
3450         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3451         (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
3452         (LeakyPatternTest.test_create_compatible_dc): Ditto.
3453
3454 2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3455
3456         Unreviewed. Add myself as a committer.
3457
3458         * Scripts/webkitpy/common/config/contributors.json:
3459
3460 2013-09-10  Mark Lam  <mark.lam@apple.com>
3461
3462         Move LayoutTests/fast/js to LayoutTests/js.
3463         https://bugs.webkit.org/show_bug.cgi?id=120899.
3464
3465         Rubber stamped by Filip Pizlo.
3466
3467         Changed scripts to reflect the path change.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3470         (RunJavaScriptCoreTests.commandComplete):
3471         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3472         (test_fast_js_failure_new_output):
3473         (test_fast_js_crash_new_output):
3474         (test_mozilla_and_fast_js_failure_new_output):
3475         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3476         (BlackBerry::WebKit::DumpRenderTree::runTests):
3477         * Scripts/make-script-test-wrappers:
3478         (findTemplateFiles):
3479         * Scripts/run-fast-jsc:
3480         * Scripts/run-javascriptcore-tests:
3481         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3482         (TestExpectations):
3483
3484 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
3485
3486         [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
3487         https://bugs.webkit.org/show_bug.cgi?id=70606
3488
3489         Reviewed by Mario Sanchez Prada.
3490
3491         Implemented the global notification listener for
3492         AccessibilityController. The signal is generated by
3493         AXObjectCache::postPlatformNotification() and received by
3494         axObjectEventListener(). axObjectEventListener will then invoke
3495         JSObjectCallAsFunction() with the respective callback function.
3496
3497         There is no additional test for this patch since its implementation will
3498         be tested by a11y layout tests that are currently skipped (e.g. bug
3499         98370).
3500
3501         * DumpRenderTree/AccessibilityController.h: Added a global notification
3502         handler for GTK+.
3503         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3504         (AccessibilityController::AccessibilityController): Initializes the
3505         global handler with 0.
3506         (AccessibilityController::addNotificationListener): Creates the
3507         notification handler and sets the notification function callback.
3508         (AccessibilityController::removeNotificationListener): Removes the
3509         global handler.
3510
3511 2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
3512
3513         [ATK] Incorrect type for holding float value
3514         https://bugs.webkit.org/show_bug.cgi?id=121091
3515
3516         Reviewed by Mario Sanchez Prada.
3517
3518         Variable is not set properly, because of it's type.
3519
3520         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3521         (WTR::alterCurrentValue):
3522
3523 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3524
3525         [Qt] make use of qtHaveModule() 
3526         https://bugs.webkit.org/show_bug.cgi?id=121090
3527
3528         Reviewed by Jocelyn Turcotte.
3529         Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
3530
3531         Use qtHaveModule instead of our own haveQtModule.
3532
3533         * QtTestBrowser/QtTestBrowser.pro:
3534         * qmake/mkspecs/features/configure.prf:
3535         * qmake/mkspecs/features/features.prf:
3536         * qmake/mkspecs/features/functions.prf:
3537
3538 2013-09-10  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3539
3540         Unreviewed. Add myself as a committer.
3541
3542         * Scripts/webkitpy/common/config/contributors.json:
3543
3544 2013-09-10  Radu Stavila  <stavila@adobe.com>
3545
3546         Unreviewed. Added myself as a committer.
3547
3548         * Scripts/webkitpy/common/config/contributors.json:
3549
3550 2013-09-10  Mario Sanchez Prada  <mario.prada@samsung.com>
3551
3552         [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
3553         https://bugs.webkit.org/show_bug.cgi?id=105538
3554
3555         Reviewed by Chris Fleizach.
3556
3557         Unskip passing test getTextInParagraphAndBodyModerate.
3558
3559         * Scripts/run-gtk-tests:
3560         (TestRunner): Unskip pasing test.
3561
3562 2013-09-09  Mark Lam  <mark.lam@apple.com>
3563
3564         Remove more references to the deleted js-test-style.css.
3565         https://bugs.webkit.org/show_bug.cgi?id=120899.
3566
3567         Reviewed by Ryosuke Niwa.
3568
3569         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3570         (translate_includes):
3571
3572 2013-09-09  Mark Lam  <mark.lam@apple.com>
3573
3574         Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
3575         https://bugs.webkit.org/show_bug.cgi?id=120899.
3576
3577         Not reviewed.
3578
3579         The webkitpy test failure that resulted in the rollout is due to
3580         update_webgl_conformance_tests_unittest.py referencing js-test-style.css
3581         which is to be deleted. Deleting that line fixes the issue.
3582
3583         * Scripts/make-new-script-test:
3584         (makePathToSharedSources):
3585         * Scripts/run-fast-jsc:
3586         * Scripts/webkitperl/httpd.pm:
3587         (getDefaultConfigForTestDirectory):
3588         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3589         (LayoutTestApacheHttpd.__init__):
3590         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3591         (Lighttpd.__init__):
3592         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3593         (BaseTest.integration_test_port_and_root):
3594         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3595         (TestHttpServer.test_start_cmd):
3596         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3597         (translate_includes):
3598         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3599         (TestTranslation.test_include_rewriting):
3600
3601 2013-09-09  Mark Lam  <mark.lam@apple.com>
3602
3603         Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
3604         https://bugs.webkit.org/show_bug.cgi?id=120899.
3605
3606         Not reviewed.
3607
3608         * Scripts/make-new-script-test:
3609         (makePathToSharedSources):
3610         * Scripts/run-fast-jsc:
3611         * Scripts/webkitperl/httpd.pm:
3612         (getDefaultConfigForTestDirectory):
3613         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3614         (LayoutTestApacheHttpd.__init__):
3615         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3616         (Lighttpd.__init__):
3617         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3618         (BaseTest.integration_test_port_and_root):
3619         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3620         (TestHttpServer.test_start_cmd):
3621         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3622         (translate_includes):
3623         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3624         (TestTranslation.test_include_rewriting):
3625
3626 2013-09-09  Mark Lam  <mark.lam@apple.com>
3627
3628         Point Tools scripts to LayoutTests/resources.
3629         https://bugs.webkit.org/show_bug.cgi?id=120899.
3630
3631         Reviewed by Ryosuke Niwa.