1 2013-05-10 Brent Fulgham <bfulgham@apple.com>
3 [Windows] Allow VS2010 Build to use VS2005 Support Libraries
4 https://bugs.webkit.org/show_bug.cgi?id=115935
8 * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
9 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
10 to the new manifest file.
11 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
13 2013-05-10 Jacky Jiang <zhajiang@blackberry.com>
15 Fix some compiler warnings (miscellaneous)
16 https://bugs.webkit.org/show_bug.cgi?id=80790
20 Fix the following warnings for BlackBerry:
21 DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
22 used as truth value [-Wparentheses].
24 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
25 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
27 2013-05-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
29 [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
30 https://bugs.webkit.org/show_bug.cgi?id=115928
32 Reviewed by Kenneth Rohde Christiansen.
34 WKViewSetThemePath was moved to WKViewEfl.h.
36 * TestWebKitAPI/efl/PlatformWebView.cpp:
38 2013-05-10 Andreas Kling <akling@apple.com>
40 I accidentally the Java testing.
42 * Scripts/webkitpy/port/mac.py:
44 2013-05-10 Brian Holt <brian.holt@samsung.com>
46 [GTK] Module Cairo fails to build under jhbuild
47 https://bugs.webkit.org/show_bug.cgi?id=115854
49 Reviewed by Martin Robinson.
51 Make cairo depend on glib in jhbuild.modules.
53 * gtk/jhbuild.modules:
55 2013-05-10 Carlos Garcia Campos <cgarcia@igalia.com>
57 [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
58 https://bugs.webkit.org/show_bug.cgi?id=115904
60 Reviewed by Martin Robinson.
62 * ImageDiff/gtk/ImageDiff.cpp:
65 2013-05-10 Balazs Kelemen <kbalazs@webkit.org>
67 Add my new address to contributors.json. (Unreviewed)
69 * Scripts/webkitpy/common/config/contributors.json:
71 2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
73 Unreviewed. Move myself to the reviewers list.
75 * Scripts/webkitpy/common/config/contributors.json:
77 2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
79 Unreviewed. Add my email to a few watchlists.
81 * Scripts/webkitpy/common/config/watchlist:
83 2013-05-10 Simon Pena <simon.pena@samsung.com>
85 Unicode support missing from string representation of Contributors in committers.py
86 https://bugs.webkit.org/show_bug.cgi?id=115859
88 Reviewed by Darin Adler.
90 Contributors, in committers.py, provided a string representation in __str__ which
91 didn't support unicode characters, so printing a contributor would fail in that case.
92 This patch implements __unicode__ and makes __str__ use it to represent a contributor.
93 The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
95 * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
96 to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
98 (Contributor.__str__):
100 (Contributor.__unicode__):
101 * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
102 a contributor with unicode characters can be represented as a string.
104 (CommittersTest.test_contributor_encoding):
106 2013-05-09 Patrick Gansterer <paroga@webkit.org>
108 [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
109 https://bugs.webkit.org/show_bug.cgi?id=92371
111 Reviewed by Brent Fulgham.
113 Use JavaScriptThreading.cpp where the same functionality is
114 implemented too. This reduces the dependency on the pthread
115 library. Also replace assert() with WebKit ASSERT().
117 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
118 * DumpRenderTree/win/DumpRenderTree.cpp:
120 (dumpBackForwardList):
121 * DumpRenderTree/win/DumpRenderTree.vcproj:
123 2013-05-09 Patrick Gansterer <paroga@webkit.org>
125 [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
126 https://bugs.webkit.org/show_bug.cgi?id=92505
128 Reviewed by Brent Fulgham.
130 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
131 * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
132 (javaScriptThreadsMutex):
134 (runJavaScriptThread):
135 (startJavaScriptThreads):
136 (stopJavaScriptThreads):
137 * DumpRenderTree/pthreads: Removed.
138 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
140 2013-05-09 Mario Sanchez Prada <mario.prada@samsung.com>
142 Unreviewed. Update Simon Pena email on his behalf.
144 * Scripts/webkitpy/common/config/contributors.json:
146 2013-05-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
148 Add support for [NoInterfaceObject] Web IDL extended attribute
149 https://bugs.webkit.org/show_bug.cgi?id=115714
151 Reviewed by Kentaro Hara.
153 Update BindingsTests.generate_supplemental_dependency() to pass an
154 additional windowConstructorsFile argument to preprocess-idls.pl.
156 * Scripts/webkitpy/bindings/main.py:
157 (BindingsTests.generate_supplemental_dependency):
158 (BindingsTests.main):
160 2013-05-09 ChangSeok Oh <changseok.oh@collabora.com>
162 [GTK][AC] Buildfix after r149694
163 https://bugs.webkit.org/show_bug.cgi?id=115797
165 Reviewed by Gustavo Noronha Silva.
167 Add CLUTTER_LIBS for linking TestWebCore.
169 * TestWebKitAPI/GNUmakefile.am:
171 2013-05-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
173 [EFL] Remove unnecessary pkgs in EFL jhbuild
174 https://bugs.webkit.org/show_bug.cgi?id=114908
176 Reviewed by Laszlo Gombos.
178 p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
179 handle them using jhbuild. We can reduce build time when using --update-efl.
181 * efl/jhbuild.modules:
183 2013-05-08 Seokju Kwon <seokju.kwon@gmail.com>
185 [EFL] Disable SHADOW DOM feature in FeatureList.pm
186 https://bugs.webkit.org/show_bug.cgi?id=115834
188 Reviewed by Gyuyoung Kim.
190 * Scripts/webkitperl/FeatureList.pm:
192 2013-05-08 Lucas Forschler <lforschler@apple.com>
194 Add Scheduler for Mac MtnLion 32bit Release builder.
198 * BuildSlaveSupport/build.webkit.org-config/config.json:
200 2013-05-08 Denis Nomiyama <d.nomiyama@samsung.com>
202 Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
203 https://bugs.webkit.org/show_bug.cgi?id=115808
205 Reviewed by Darin Adler.
207 The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
208 was left outdated after r127191, when the m_string member was changed
209 from UString to String. This patch calls the right pretty printer for it.
212 (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
213 WTFImplPrettyPrinter.
215 2013-05-08 Andy Estes <aestes@apple.com>
217 [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
218 https://bugs.webkit.org/show_bug.cgi?id=115790
220 Reviewed by Alexey Proskuryakov.
224 1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
225 2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
227 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
228 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
230 (TestWebKitAPI::TEST):
231 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
233 (TestWebKitAPI::decidePolicyForNavigationAction):
234 (CustomProtocolInvalidSchemeTest):
235 (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
237 2013-05-08 Lucas Forschler <lforschler@apple.com>
239 Teach buildbot how to compile 32-bit on Mac.
241 Reviewed by Ryosuke Niwa.
243 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
244 (CompileWebKit.start):
245 (ExtractTestResultsAndLeaks):
247 2013-05-08 Eli Fidler <efidler@blackberry.com>
249 [BlackBerry] Fix usage of BlackBerry::Platform::String
250 https://bugs.webkit.org/show_bug.cgi?id=115781
252 Reviewed by Rob Buis.
254 BlackBerry PRs 304193 and 327181
255 Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
257 We currently have a problem where we're passing UTF-8 encoded data into
258 the char* constructors of BlackBerry::Platform::String. This means the string
259 thinks its data is not UTF-8.
261 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
262 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
263 (BlackBerry::WebKit::dumpHistoryItem):
264 * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
265 (TestRunner::setUserStyleSheetLocation):
266 * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
267 (LoadHTMLStringItem::invoke):
269 2013-05-08 Alberto Garcia <agarcia@igalia.com>
271 Tools: add new BlackBerry include dirs.
272 https://bugs.webkit.org/show_bug.cgi?id=115514
274 Reviewed by Rob Buis.
276 iType include dirs are missing, and HarfBuzz needs to be fixed.
278 * Scripts/webkitdirs.pm:
279 (blackberryCMakeArguments):
281 2013-05-08 José Dapena Paz <jdapena@igalia.com> and Zan Dobersek <zdobersek@igalia.com>
283 [GTK] Plumb the Automake build system for the Battery Status API feature
284 https://bugs.webkit.org/show_bug.cgi?id=115718
286 Reviewed by Martin Robinson.
288 * Scripts/webkitdirs.pm:
289 (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
290 through the --(enable|disable)-battery-status flag passed to configure.
292 2013-05-08 Ryosuke Niwa <rniwa@webkit.org>
294 new-run-webkit-websocketserver doesn't work after Chromium removal
295 https://bugs.webkit.org/show_bug.cgi?id=115816
297 Reviewed by Joseph Pecoraro.
299 Fix the bug by instantiating the correct port object.
301 * Scripts/new-run-webkit-websocketserver:
304 2013-05-07 Lucas Forschler <lforschler@apple.com>
306 Configure buildbot for 32bit builder.
307 https://bugs.webkit.org/show_bug.cgi?id=115769
309 Reviewed by Ryosuke Niwa.
311 * BuildSlaveSupport/build.webkit.org-config/config.json:
313 2013-05-08 Brent Fulgham <bfulgham@webkit.org>
315 Unreviewed. Update to show my apple.com address.
317 * Scripts/webkitpy/common/config/contributors.json: Added
318 my apple.com e-mail address.
320 2013-05-08 David Kilzer <ddkilzer@apple.com>
322 BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
324 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
325 (concatenateAttributeAndValue): Switch to appendVector().
327 2013-05-08 Andras Becsi <andras.becsi@digia.com>
329 [Qt][WTR] Fix the build on Mac after r149692
331 Unreviewed build fix.
333 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
334 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
336 2013-05-08 Mario Sanchez Prada <mario.prada@samsung.com>
338 Unreviewed. Added Anton Obzhirov to the list of contributors and myself
339 to the watchlist for Accessibility.
341 * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
342 * Scripts/webkitpy/common/config/watchlist: Added myself.
344 2013-05-08 Andras Becsi <andras.becsi@digia.com>
346 [Qt] Build fails with clang
347 https://bugs.webkit.org/show_bug.cgi?id=115741
349 Reviewed by Benjamin Poulain.
351 Since r149112 std::move is used in AtomicString for compilers that
352 support rvalue references and this requires a standard library
353 implementing c++11 move semantics.
354 We only explicitely require c++11 for WebKit2, but since clang supports
355 rvalue references the build of subtargets using AtomicString fails because
356 of missing std::move.
357 It is safe to add CONFIG += c++11 for the whole project when using clang
358 since we explicitely disable c++11 for ANGLE that had probems with libc++.
360 * qmake/mkspecs/features/unix/default_pre.prf:
362 2013-05-08 Darin Adler <darin@apple.com>
364 Fix one more place that needed to use adoptCF/NS
365 https://bugs.webkit.org/show_bug.cgi?id=115778
367 Reviewed by Benjamin Poulain.
369 Not sure why I missed this code last time, but found a bit more code that needs
370 to switch to the newer style adoptCF/NS.
372 * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
373 (convertWebResourceDataToString): Use adoptCF.
374 (convertWebResourceResponseToDictionary): Ditto.
375 (createXMLStringFromWebArchiveData): Ditto.
376 * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
377 (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
379 2013-05-08 Commit Queue <commit-queue@webkit.org>
381 Unreviewed, rolling out r149271.
382 http://trac.webkit.org/changeset/149271
383 https://bugs.webkit.org/show_bug.cgi?id=115780
385 The mangled symbols are now enforced through LDFLAGS
386 (Requested by zdobersek on #webkit).
388 * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
390 2013-05-08 Zan Dobersek <zdobersek@igalia.com>
392 [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
393 https://bugs.webkit.org/show_bug.cgi?id=115636
395 Reviewed by Ryosuke Niwa.
397 * TestResultServer/static-dashboards/flakiness_dashboard.js:
398 (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
399 through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
400 while Chromium-specific, can't be removed just yet as there's more code that uses it.
402 2013-05-06 Darin Adler <darin@apple.com>
404 Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
405 https://bugs.webkit.org/show_bug.cgi?id=115657
407 Reviewed by Sam Weinig.
409 This is similar to my last set of changes, but covers code that I missed with
410 global replace using the Safari Xcode workspace.
412 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
413 (convertWebResourceDataToString):
414 (convertWebResourceResponseToDictionary):
415 (createXMLStringFromWebArchiveData):
416 * DumpRenderTree/cg/ImageDiffCG.cpp:
417 (createImageFromStdin):
418 (createDifferenceImage):
420 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
423 * DumpRenderTree/cg/PixelDumpSupportCG.h:
424 (BitmapContext::BitmapContext):
425 * DumpRenderTree/mac/MockWebNotificationProvider.mm:
426 (-[MockWebNotificationProvider init]):
427 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
428 (createBitmapContext):
429 * DumpRenderTree/mac/TestRunnerMac.mm:
430 (TestRunner::addDisallowedURL):
431 (TestRunner::applicationCacheDiskUsageForOrigin):
432 (TestRunner::localStorageDiskUsageForOrigin):
433 (TestRunner::clearApplicationCacheForOrigin):
434 (TestRunner::deleteLocalStorageForOrigin):
435 (TestRunner::copyDecodedHostName):
436 (TestRunner::copyEncodedHostName):
437 (TestRunner::queueLoad):
438 (TestRunner::setDomainRelaxationForbiddenForURLScheme):
439 (TestRunner::setMockGeolocationPositionUnavailableError):
440 (TestRunner::setUserStyleSheetLocation):
441 (TestRunner::setValueForUser):
442 (TestRunner::overridePreference):
443 (TestRunner::setPersistentUserStyleSheetLocation):
444 (TestRunner::execCommand):
445 (TestRunner::findString):
446 (TestRunner::isCommandEnabled):
447 (TestRunner::addOriginAccessWhitelistEntry):
448 (TestRunner::removeOriginAccessWhitelistEntry):
449 (TestRunner::addUserScript):
450 (TestRunner::addUserStyleSheet):
451 (TestRunner::evaluateInWebInspector):
452 (TestRunner::evaluateScriptInIsolatedWorld):
453 (TestRunner::apiTestNewWindowDataLoadBaseURL):
454 (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
455 (TestRunner::authenticateSession):
456 (TestRunner::grantWebNotificationPermission):
457 (TestRunner::denyWebNotificationPermission):
458 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
459 (createCFURLResponseFromResponseData):
460 * DumpRenderTree/mac/WorkQueueItemMac.mm:
462 (LoadHTMLStringItem::invoke):
463 (ScriptItem::invoke):
464 * DumpRenderTree/win/DumpRenderTree.cpp:
465 (substringFromIndex):
466 (urlSuitableForTestResult):
469 * DumpRenderTree/win/ImageDiffCairo.cpp:
470 (createImageFromStdin):
472 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
473 (createBitmapContextFromWebView):
474 * DumpRenderTree/win/TestRunnerWin.cpp:
475 (TestRunner::setUserStyleSheetLocation):
476 (TestRunner::setPersistentUserStyleSheetLocation):
477 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
478 (TestWebKitAPI::TEST):
479 * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
480 (TestWebKitAPI::TEST):
481 * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
482 (TestWebKitAPI::TEST):
483 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
484 (TestWebKitAPI::TEST):
485 * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
486 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
487 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
488 (TestWebKitAPI::createWindow):
489 (TestWebKitAPI::TEST):
490 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
491 (TestWebKitAPI::TEST):
492 * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
493 (TestWebKitAPI::AcceptsFirstMouse::runTest):
494 * TestWebKitAPI/Tests/mac/AttributedString.mm:
495 (TestWebKitAPI::TEST):
496 * TestWebKitAPI/Tests/mac/BackForwardList.mm:
497 (TestWebKitAPI::TEST):
498 * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
499 (TestWebKitAPI::TEST):
500 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
501 (TestWebKitAPI::TEST):
502 * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
503 (TestWebKitAPI::TEST):
504 * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
505 (TestWebKitAPI::TEST):
506 * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
507 (TestWebKitAPI::TEST):
508 * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
509 (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
510 * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
511 (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
512 * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
513 (TestWebKitAPI::TEST):
514 * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
515 (TestWebKitAPI::TEST):
516 * TestWebKitAPI/Tests/mac/InspectorBar.mm:
517 (TestWebKitAPI::TEST):
518 * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
519 (TestWebKitAPI::TEST):
520 * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
521 (TestWebKitAPI::TEST):
522 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
523 (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
524 * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
525 (TestWebKitAPI::TEST):
526 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
527 (TestWebKitAPI::TEST):
528 * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
529 (TestWebKitAPI::TEST):
530 * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
531 (TestWebKitAPI::TEST):
532 * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
533 (TestWebKitAPI::TEST):
534 * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
535 (TestWebKitAPI::TEST):
536 * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
537 (TestWebKitAPI::TEST):
538 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
539 (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
540 * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
541 (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
542 (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
543 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
544 (WTR::testPathFromURL):
545 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
546 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
547 * WebKitTestRunner/cg/TestInvocationCG.cpp:
548 (WTR::createCGContextFromImage):
550 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
551 * WebKitTestRunner/mac/EventSenderProxy.mm:
552 (WTR::EventSenderProxy::mouseScrollBy):
553 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
554 (WTR::PlatformWebView::windowSnapshotImage):
555 * WebKitTestRunner/win/TestControllerWin.cpp:
556 (WTR::TestController::initializeTestPluginDirectory):
557 Use adoptCF and adoptNS.
559 2013-05-07 Alex Christensen <achristensen@apple.com>
561 Fix a memory leak introduced in r149692
562 https://bugs.webkit.org/show_bug.cgi?id=115766
564 Reviewed by Mark Rowe.
566 In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
567 matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
569 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
570 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
571 Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
573 2013-05-07 Darin Adler <darin@apple.com>
575 [Win] Fix storage leak in Windows DumpRenderTree
576 https://bugs.webkit.org/show_bug.cgi?id=115651
578 Reviewed by Sam Weinig.
580 * DumpRenderTree/win/DumpRenderTree.cpp:
581 (lastPathComponent): Added a missing call to adoptCF.
583 2013-05-07 Alex Christensen <achristensen@apple.com>
585 fixed a memory leak introduced by bug 42324 by using a RetainPtr
586 https://bugs.webkit.org/show_bug.cgi?id=115760
588 Reviewed by Tim Horton.
590 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
591 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
592 fixed memory leak, added UNUSED_PARAM macros
594 2013-05-07 Alex Christensen <achristensen@apple.com>
596 WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
597 https://bugs.webkit.org/show_bug.cgi?id=42324
598 <rdar://problem/8193633>
600 Reviewed by Tim Horton.
602 * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
603 Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
604 * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
605 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
606 Added dumpDOMAsWebArchive code that is called when dumping.
607 (WTR::InjectedBundlePage::dump):
608 Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
609 * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
610 (InjectedBundlePage):
611 Added dumpDOMAsWebArchive declaration.
612 * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
613 (WTR::TestRunner::dumpDOMAsWebArchive):
614 Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
615 * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
616 Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
617 * Tools/WebKitTestRunner/cf: Added.
618 * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
619 Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
621 (convertWebResourceDataToString):
622 (normalizeHTTPResponseHeaderFields):
623 (normalizeWebResourceURL):
624 (convertWebResourceResponseToDictionary):
625 (compareResourceURLs):
626 (createXMLStringFromWebArchiveData):
627 * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
628 Copied from Tools/DumpRenderTree/cf for used symbol declarations.
629 * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
630 Copied from Tools/DumpRenderTree/mac for used functions.
631 (createCFURLResponseFromResponseData):
632 (supportedNonImageMIMETypes):
634 2013-05-07 Alex Christensen <achristensen@apple.com>
636 Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
637 https://bugs.webkit.org/show_bug.cgi?id=115745
639 Reviewed by Tim Horton.
641 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
642 (compareResourceURLs):
645 2013-05-06 Ryosuke Niwa <rniwa@webkit.org>
647 Add an 'isReadOnly' member to IDL parse tree structure
648 https://bugs.webkit.org/show_bug.cgi?id=115704
650 Reviewed by Kentaro Hara.
652 Use newly added isReadOnly attribute.
654 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
655 (_generateHeaderFile):
656 (_generateImplementationFile):
657 (_staticValuesGetterImplementation):
659 2013-05-07 Anders Carlsson <andersca@apple.com>
661 Remove AlwaysInline.h from WTF
662 https://bugs.webkit.org/show_bug.cgi?id=115727
664 Reviewed by Brent Fulgham.
666 The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
667 to keep AlwaysInline.h around anymore.
669 * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
670 * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
672 2013-05-07 Andras Becsi <andras.becsi@digia.com>
674 [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
675 https://bugs.webkit.org/show_bug.cgi?id=114808
677 Reviewed by Jocelyn Turcotte.
679 QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
680 (https://codereview.qt-project.org/#change,54234)
682 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
683 (WTR::WrapperWindow::handleStatusChanged):
685 2013-05-06 Christophe Dumez <ch.dumez@sisa.samsung.com>
687 Unreviewed. Add my email to EFL and BindingsScripts watchlists.
689 * Scripts/webkitpy/common/config/watchlist:
691 2013-05-06 Kangil Han <kangil.han@samsung.com>
693 [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
694 https://bugs.webkit.org/show_bug.cgi?id=115645
696 Reviewed by Gyuyoung Kim.
698 To run performance tests in wk1, we need --no-timeout option implementation.
699 So adopt it from gtk+ port.
701 * DumpRenderTree/efl/DumpRenderTree.cpp:
702 (shouldSetWaitToDumpWatchdog):
703 (parseCommandLineOptions):
704 * DumpRenderTree/efl/DumpRenderTreeEfl.h:
705 * DumpRenderTree/efl/TestRunnerEfl.cpp:
706 (TestRunner::setWaitToDump):
708 2013-05-06 Commit Queue <commit-queue@webkit.org>
710 Unreviewed, rolling out r149547.
711 http://trac.webkit.org/changeset/149547
712 https://bugs.webkit.org/show_bug.cgi?id=115682
714 Added unittests that fail on bots and spits out text into
715 stdout (Requested by rniwa on #webkit).
717 * Scripts/import-w3c-tests: Removed.
718 * Scripts/webkitpy/w3c/__init__.py: Removed.
719 * Scripts/webkitpy/w3c/test_converter.py: Removed.
720 * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
721 * Scripts/webkitpy/w3c/test_importer.py: Removed.
722 * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
723 * Scripts/webkitpy/w3c/test_parser.py: Removed.
724 * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
726 2013-05-03 Gustavo Noronha Silva <gns@gnome.org>
728 [jhbuild] bump jhbuild version to take advantage of new improvements
729 https://bugs.webkit.org/show_bug.cgi?id=115558
731 Reviewed by Martin Robinson.
733 One of the important improvements is jhbuild no longer fetches git
734 repositories if they are already at the expected revision, which should
735 make the EWS bots more robust to git servers unavailability.
737 * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
739 2013-05-06 Manuel Rego Casasnovas <rego@igalia.com>
741 [GTK] Add webkit_uri_scheme_request_finish_error
742 https://bugs.webkit.org/show_bug.cgi?id=94316
744 Reviewed by Anders Carlsson.
746 * MiniBrowser/gtk/main.c:
747 (miniBrowserErrorQuark): Add function to create a global quark for
749 (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
750 function webkit_uri_scheme_request_finish_error().
752 2013-05-06 Mike Lattanzio <mlattanzio@blackberry.com>
754 [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
755 https://bugs.webkit.org/show_bug.cgi?id=113808
757 Reviewed by Rob Buis.
759 Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
760 to true for BlackBerry.
762 * Scripts/webkitperl/FeatureList.pm:
764 2013-05-06 Jessie Berlin <jberlin@apple.com>
766 check-webkit-style should complain about a layering violation if platform-specific guards are
767 used in WebCore outside of the platform directory
768 https://bugs.webkit.org/show_bug.cgi?id=115567
770 Reviewed by Benjamin Poulain.
772 * Scripts/webkitpy/style/checkers/cpp.py:
773 (check_for_webcore_platform_layering_violation):
774 If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
776 Add the check_for_webcore_platform_layering_violation.
780 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
781 (CppStyleTest.test_webcore_platform_layering_violation):
784 2013-05-06 David Kilzer <ddkilzer@apple.com>
786 webkit-patch: fix 'upload' command with Bugzilla 4.2.5
787 <http://webkit.org/b/115667>
789 Reviewed by Dirk Pranke.
791 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
792 (Bugzilla._check_create_bug_response): Update regex to work with
793 Bugzilla 3.2.3 and 4.2.5.
794 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
795 (test__check_create_bug_response): Add new test that covers both
796 old and new <title> variations.
798 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
800 [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
801 https://bugs.webkit.org/show_bug.cgi?id=115661
803 Reviewed by Ryosuke Niwa.
805 The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
806 builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
807 and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
809 * TestResultServer/static-dashboards/flakiness_dashboard.js:
810 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
812 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
814 [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
815 https://bugs.webkit.org/show_bug.cgi?id=114603
817 Reviewed by Ryosuke Niwa.
819 * TestResultServer/generate_builders_json.py:
820 (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
821 to represent these to be 'layout-test', for backwards compatibility.
822 (main): Remove all the build.chromium.org masters.
823 * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
824 (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
825 (GenerateBuildersJsonTest):
826 (GenerateBuildersJsonTest.test_generate_json_data):
827 * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
828 test-running builders from the webkit.org master.
830 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
832 [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
833 https://bugs.webkit.org/show_bug.cgi?id=114988
835 Reviewed by Ryosuke Niwa.
837 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
838 and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
839 * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
840 mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
841 once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
843 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
845 [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
846 https://bugs.webkit.org/show_bug.cgi?id=114954
848 Reviewed by Ryosuke Niwa.
850 * TestResultServer/static-dashboards/flakiness_dashboard.js:
851 (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
852 modifier unions in the list of modifiers.
853 (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
854 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
856 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
858 [Flakiness Dashboard] Simplify builder-name-based platform recognition
859 https://bugs.webkit.org/show_bug.cgi?id=114957
861 Reviewed by Ryosuke Niwa.
863 * TestResultServer/static-dashboards/flakiness_dashboard.js:
864 (determineBuilderPlatform): Renamed from nonChromiumPlatform.
865 (chromiumPlatform): Removed, unnecessary.
866 (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
867 to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
868 the builder operates with debug builds, no webkit.org builders are named this way.
869 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
870 (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
872 2013-05-06 Andy Estes <aestes@apple.com>
874 Added two files I neglected to commit in r149589.
876 * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
877 * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
879 2013-05-04 Andy Estes <aestes@apple.com>
881 REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
882 https://bugs.webkit.org/show_bug.cgi?id=115609
884 Reviewed by Oliver Hunt.
888 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889 * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
890 (+[TestDelegate shared]):
891 (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
892 (-[TestDelegate webView:createWebViewWithRequest:]):
894 (TestWebKitAPI::TEST):
895 * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
897 2013-05-06 Antoine Quint <graouts@apple.com>
899 Manage the presentation of the snapshotted plug-in using JavaScript
900 https://bugs.webkit.org/show_bug.cgi?id=115548
902 Reviewed by Dean Jackson.
904 Take into account the new plugInExtraScript method added to support
905 the injection of a JS file from the chrome client to customize the
906 rendering of a snapshotted plug-in's shadow tree.
908 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
909 (WTR::InjectedBundlePage::InjectedBundlePage):
911 2013-05-05 Anders Carlsson <andersca@apple.com>
913 Remove the Vector::append overload that takes a Vector
914 https://bugs.webkit.org/show_bug.cgi?id=115535
916 Reviewed by Andreas Kling.
918 Use Vector::appendVector instead.
920 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
921 (concatenateAttributeAndValue):
922 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
923 (WTR::concatenateAttributeAndValue):
925 2013-05-04 Sam Weinig <sam@webkit.org>
927 REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
928 <rdar://problem/13702008>
929 https://bugs.webkit.org/show_bug.cgi?id=115607
931 Reviewed by Benjamin Poulain.
933 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
934 * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
935 (TestWebKitAPI::didFinishLoadForFrame):
936 (TestWebKitAPI::TEST):
937 Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
939 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
943 * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
945 2013-05-04 Mihnea Ovidenie <mihnea@adobe.com>
947 Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
949 * Scripts/webkitpy/common/config/contributors.json:
951 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
953 [GTK] Catch select.error exceptions in parse_output_lines
954 https://bugs.webkit.org/show_bug.cgi?id=115253
956 Reviewed by Gustavo Noronha Silva.
958 Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
959 output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
960 builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
961 error code and the error message) and the loop is re-entered.
964 (parse_output_lines):
966 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
968 [GTK] Set up the TestWebCore in TestWebKitAPI
969 https://bugs.webkit.org/show_bug.cgi?id=115237
971 Reviewed by Gustavo Noronha Silva.
973 Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
974 Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
975 a workaround for the layer violations and circular dependencies between various static libraries. Linking against
976 either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
977 shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
979 * TestWebKitAPI/GNUmakefile.am:
981 2013-05-03 Rebecca Hauck <rhauck@adobe.com>
983 Create a script to import W3C tests
984 https://bugs.webkit.org/show_bug.cgi?id=111513
986 Reviewed by Dirk Pranke.
988 Script to automate the import of W3C tests into WebKit.
989 For the full description of how it works, see the comments
990 at the top of test_importer.py.
992 * Scripts/import-w3c-tests: Added.
993 * Scripts/webkitpy/w3c/__init__.py: Added.
994 * Scripts/webkitpy/w3c/test_converter.py: Added.
996 (TestConverter.__init__):
997 (TestConverter.load_prefixed_prop_list):
998 (TestConverter.load_file):
999 (TestConverter.convert_for_webkit):
1000 (TestConverter.convert_testharness_paths):
1001 (TestConverter.convert_prefixed_properties):
1002 (TestConverter.scrub_unprefixed_props):
1003 (TestConverter.replace_tag):
1004 * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
1005 (TestConverterTest):
1006 (TestConverterTest.testLoadPrefixedPropList):
1007 (TestConverterTest.test_convertForWebkitNothingToConvert):
1008 (test_convertForWebkitHarnessOnly):
1009 (test_convertForWebkitPropsOnly):
1010 (test_convertForWebkitHarnessAndProps):
1011 (test_convertTestHarnessPaths):
1012 (test_convertPrefixedProperties):
1013 (verifyTestHarnessPaths):
1014 (verifyPrefixedProperties):
1015 (generateTestContent):
1016 * Scripts/webkitpy/w3c/test_importer.py: Added.
1019 (validate_import_directory):
1021 (TestImporter.__init__):
1022 (TestImporter.do_import):
1023 (TestImporter.get_changeset):
1024 (TestImporter.scan_source_directory):
1025 (TestImporter.import_tests):
1026 (TestImporter.setup_destination_directory):
1027 (TestImporter.get_test_status):
1028 (TestImporter.remove_deleted_files):
1029 (TestImporter.write_import_log):
1030 * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
1032 (TestImporterTest.test_ImportDirWithNoTests):
1033 * Scripts/webkitpy/w3c/test_parser.py: Added.
1035 (TestParser.__init__):
1036 (TestParser.load_file):
1037 (TestParser.analyze_test):
1038 (TestParser.get_reftests):
1039 (TestParser.is_jstest):
1040 (TestParser.get_support_files):
1041 * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
1043 (TestParserTest.test_analyzeTestReftestOneMatch):
1044 (test_analyzeTestReftestMultipleMatches):
1045 (test_analyzeTestReftestMatchAndMismatch):
1046 (test_analyzeTestReftestWithRefSupportFiles):
1047 (test_analyzeJSTest):
1048 (test_analyzePixelTestAllTrue):
1049 (test_analyzePixelTestAllFalse):
1050 (test_analyzeNonHTMLFile):
1052 2013-05-03 Christophe Dumez <ch.dumez@sisa.samsung.com>
1054 Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
1056 * Scripts/webkitpy/common/config/contributors.json:
1058 2013-05-02 Nico Weber <thakis@chromium.org>
1060 Remove a stale script file.
1061 https://bugs.webkit.org/show_bug.cgi?id=115521
1063 Reviewed by Anders Carlsson.
1065 This script was added in
1066 https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
1067 Bakefile system that was removed in
1068 https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
1069 script just asserts when it's run and is useless.
1071 * Scripts/update-sources-list.py: Removed.
1073 2013-05-01 Glenn Adams <glenn@skynav.com>
1075 [webkitpy] Need abstract base class for commands that analyze commit logs
1076 https://bugs.webkit.org/show_bug.cgi?id=115391
1078 Reviewed by Benjamin Poulain.
1080 Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
1081 in preparation for adding two new commands that will reuse this functionality along with
1082 suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
1083 https://bugs.webkit.org/show_bug.cgi?id=115388.
1085 No new tests as this patch does not change existing functionality or behavior.
1087 * Scripts/webkitpy/tool/commands/suggestnominations.py:
1088 (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
1089 (AbstractCommitLogCommand.__init__):
1090 (AbstractCommitLogCommand._init_options):
1091 (AbstractCommitLogCommand._parse_commit_message):
1092 (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
1093 (SuggestNominations.__init__):
1094 (SuggestNominations._init_options):
1096 2013-05-01 Seokju Kwon <seokju.kwon@gmail.com>
1098 Web Inspector: Fix check-inspector-strings script and fix localized strings
1099 https://bugs.webkit.org/show_bug.cgi?id=115495
1101 Reviewed by Joseph Pecoraro.
1103 * Scripts/check-inspector-strings:
1105 2013-05-01 Zan Dobersek <zdobersek@igalia.com>
1107 [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
1108 https://bugs.webkit.org/show_bug.cgi?id=115470
1110 Reviewed by Martin Robinson.
1112 In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
1113 not building either of the IOS, Windows or GTK-WK1 platforms.
1115 Up until now the header was included for everything but the IOS and Windows platforms due to
1116 an incorrectly stated condition regarding the GTK platform.
1118 * TestWebKitAPI/config.h:
1120 2013-05-01 Zan Dobersek <zdobersek@igalia.com>
1122 [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
1123 https://bugs.webkit.org/show_bug.cgi?id=115469
1125 Reviewed by Martin Robinson.
1127 Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
1128 for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
1129 for the WebKit2 tests and the injected bundle required by them.
1131 This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
1132 tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
1133 under the WebKit2 code).
1135 The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
1136 while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
1137 TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
1139 * TestWebKitAPI/GNUmakefile.am:
1141 2013-04-30 Glenn Adams <glenn@skynav.com>
1143 Unreviewed. Add myself to watchlist entries.
1145 * Scripts/webkitpy/common/config/watchlist:
1147 2013-04-30 Glenn Adams <glenn@skynav.com>
1149 [webkitpy] suggest-nominations doesn't count all qualified patches
1150 https://bugs.webkit.org/show_bug.cgi?id=115285
1152 Reviewed by Benjamin Poulain.
1154 Fix commit analysis so that patches made by an existing committer are counted towards reviewer
1155 nomination. Improve commit log parsing.
1157 * Scripts/webkitpy/tool/commands/suggestnominations.py:
1159 (CommitLogError.__init__):
1160 (CommitLogMissingReviewer):
1161 (CommitLogMissingReviewer.__init__):
1162 (SuggestNominations):
1163 (SuggestNominations.__init__):
1164 (SuggestNominations._recent_commit_messages):
1165 (SuggestNominations._author_name_from_email):
1166 (SuggestNominations._contributor_from_email):
1167 (SuggestNominations._parse_commit_message):
1168 (SuggestNominations._count_commit):
1169 (SuggestNominations._count_recent_patches):
1170 (SuggestNominations._collect_nominations):
1171 (SuggestNominations._print_nominations):
1172 (SuggestNominations.execute):
1173 * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1175 (test_recent_commit_messages):
1178 2013-04-30 Commit Queue <rniwa@webkit.org>
1180 Unreviewed, rolling out r149309.
1181 http://trac.webkit.org/changeset/149309
1182 https://bugs.webkit.org/show_bug.cgi?id=115430
1184 The patch does not build on WK1-only builds of the GTK port
1185 (Requested by zdobersek on #webkit).
1187 * TestWebKitAPI/GNUmakefile.am:
1189 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
1191 Stop using "in" keyword in IDL files
1192 https://bugs.webkit.org/show_bug.cgi?id=115418
1194 Reviewed by Kentaro Hara.
1196 Remove "in" keyword from IDL files as this is no longer part of the Web
1199 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1200 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
1201 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
1202 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1203 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1204 * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
1205 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1206 * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1208 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
1210 [EFL] Enable scaled cursors
1211 https://bugs.webkit.org/show_bug.cgi?id=106242
1213 Reviewed by Gyuyoung Kim.
1215 Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
1217 * Scripts/webkitperl/FeatureList.pm:
1219 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
1221 Replace "Optional" extended attribute by proper Web IDL "optional" keyword
1222 https://bugs.webkit.org/show_bug.cgi?id=115380
1224 Reviewed by Kentaro Hara.
1226 Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
1229 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1230 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1232 2013-04-30 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
1234 Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
1235 https://bugs.webkit.org/show_bug.cgi?id=114684
1237 Reviewed by Simon Hausmann.
1239 Remove the ANGLE requirement for USE(3D_GRAPHICS).
1240 This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
1242 * qmake/mkspecs/features/features.prf:
1244 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
1246 [GTK] Disable Shadow DOM feature
1247 https://bugs.webkit.org/show_bug.cgi?id=115374
1249 Reviewed by Martin Robinson.
1251 Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
1253 * Scripts/webkitperl/FeatureList.pm:
1255 2013-04-29 Glenn Adams <glenn@skynav.com>
1257 [webkitpy] Add missing contributor email addresses
1258 https://bugs.webkit.org/show_bug.cgi?id=115394
1260 Reviewed by Ryosuke Niwa.
1262 * Scripts/webkitpy/common/config/contributors.json:
1264 2013-04-29 Alberto Garcia <agarcia@igalia.com>
1266 Remove all remaining Skia code
1267 https://bugs.webkit.org/show_bug.cgi?id=115263
1269 Reviewed by Benjamin Poulain.
1271 Remove all remaining references to Skia.
1273 * Scripts/webkitdirs.pm:
1274 (blackberryCMakeArguments):
1275 * Scripts/webkitpy/common/config/contributionareas.py:
1276 * Scripts/webkitpy/common/config/watchlist:
1278 2013-04-29 Seokju Kwon <seokju.kwon@gmail.com>
1280 Get rid of unused options in Tools/Scripts/webkit-build-directory
1281 https://bugs.webkit.org/show_bug.cgi?id=115383
1283 Reviewed by Darin Adler.
1285 * Scripts/webkit-build-directory:
1287 2013-04-29 Alexey Proskuryakov <ap@apple.com>
1289 [WK2][Mac] Test with NetworkProcess enabled.
1291 Fix the build for non-Mac.
1293 * WebKitTestRunner/TestController.cpp:
1294 (WTR::TestController::initialize):
1296 2013-04-29 Alexey Proskuryakov <ap@apple.com>
1298 [WK2][Mac] Test with NetworkProcess enabled.
1300 Reviewed by Sam Weinig.
1302 * WebKitTestRunner/TestController.cpp:
1303 (WTR::TestController::initialize):
1305 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
1307 [GTK] Set up the TestWebCore in TestWebKitAPI
1308 https://bugs.webkit.org/show_bug.cgi?id=115237
1310 Reviewed by Gustavo Noronha Silva.
1312 Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
1313 Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
1314 a workaround for the layer violations and circular dependencies between various static libraries. Linking against
1315 either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
1316 shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
1318 * TestWebKitAPI/GNUmakefile.am:
1320 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
1322 [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
1323 https://bugs.webkit.org/show_bug.cgi?id=115236
1325 Reviewed by Gustavo Noronha Silva.
1327 Set up the TestJavaScriptCore unit test program, consisting of the unit tests
1328 under the TestWebKitAPI/Tests/JavaScriptCore directory.
1330 * TestWebKitAPI/GNUmakefile.am:
1332 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
1334 [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
1335 https://bugs.webkit.org/show_bug.cgi?id=115323
1337 Reviewed by Philippe Normand.
1339 Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
1340 Its presence enforces linkers to output mangled symbols when reporting linking failures
1341 due to unresolved references. People trying to fix the build can then simply copy
1342 the printed mangled symbol into the symbols.filter file instead of doing a manual build
1343 or connecting to the builders to discover the mangled version of the missing symbol.
1345 * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1347 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
1349 Remove Chromium code from Tools/BuildSlaveSupport
1350 https://bugs.webkit.org/show_bug.cgi?id=115325
1352 Reviewed by Benjamin Poulain.
1354 Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
1355 covering archiving test results and built products.
1357 * BuildSlaveSupport/built-product-archive:
1358 (archiveBuiltProduct):
1359 (extractBuiltProduct):
1360 * BuildSlaveSupport/chromium/output-android-device-status: Removed.
1361 * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
1362 * BuildSlaveSupport/test-result-archive:
1363 (archiveTestResults):
1365 2013-04-28 Seokju Kwon <seokju.kwon@gmail.com>
1367 Remove support for Chromium from webkitdirs.pm
1368 https://bugs.webkit.org/show_bug.cgi?id=115338
1370 Reviewed by Darin Adler.
1372 * Scripts/webkitdirs.pm:
1373 (determineBaseProductDir):
1374 (argumentsForConfiguration):
1375 (builtDylibPathForName):
1379 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
1381 Rename TestRunner's setAudioData to setAudioResult
1382 https://bugs.webkit.org/show_bug.cgi?id=115326
1384 Reviewed by Darin Adler.
1386 Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
1387 than the previous one. The change is a simple rename, there's no change in the method's functionality. The
1388 affected tests are adjusted accordingly.
1390 * DumpRenderTree/qt/TestRunnerQt.cpp:
1391 (TestRunnerQt::setAudioResult):
1392 * DumpRenderTree/qt/TestRunnerQt.h:
1394 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1395 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1396 (WTR::TestRunner::setAudioResult):
1397 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1400 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
1402 [WKTR] Tests dumping audio data shouldn't dump pixels
1403 https://bugs.webkit.org/show_bug.cgi?id=115270
1405 Reviewed by Benjamin Poulain.
1407 Prevent dumping the pixel output when Web Audio tests are dumping output data
1408 as the testing output. Pixel output in these tests has no real meaning and is
1409 as such unnecessary.
1411 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1412 (WTR::TestRunner::setAudioData):
1414 2013-04-27 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1416 [EFL] Unreviewed Intel bots fix after r149231.
1418 * efl/jhbuild.modules: Disable the libxml Python bindings since the
1419 bots don't have Python's development files installed. libxml should
1420 detect this kind of thing better.
1422 2013-04-26 Ryuan Choi <ryuan.choi@samsung.com>
1424 [EFL] Build break using jhbuild on ubuntu 13.04
1425 https://bugs.webkit.org/show_bug.cgi?id=115225
1427 Reviewed by Gyuyoung Kim.
1429 libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
1430 libxml 2.9.0 has a bug to make regression which r138422 mentioned.
1431 So this patch bumped libxml version to 2.9.1.
1433 * efl/jhbuild.modules:
1435 2013-04-26 Jeffrey Pfau <jpfau@apple.com>
1437 delete-stale-build-files does not clear .d files
1438 http://bugs.webkit.org/show_bug.cgi?id=115293
1440 Reviewed by Ryosuke Niwa.
1442 * BuildSlaveSupport/delete-stale-build-files:
1443 (main): Add .d to the file type list
1445 2013-04-26 Roger Fong <roger_fong@apple.com>
1447 Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
1448 Make the DebugSuffix configuration use _debug dependencies.
1450 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1451 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
1452 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1453 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
1454 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1455 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1456 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
1457 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
1458 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
1459 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1460 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
1461 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
1462 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1463 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1464 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1465 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1466 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
1467 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
1468 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1469 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
1470 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
1471 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
1472 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1473 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
1474 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1475 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
1476 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
1477 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1478 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1479 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1480 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
1481 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
1482 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1483 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
1484 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1485 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1486 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1487 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
1488 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1489 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
1490 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1491 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1492 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1493 * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
1494 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
1495 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1496 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1497 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
1498 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
1499 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1500 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
1501 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1502 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1503 * win/AssembleBuildLogs/AssembleLogs.cmd:
1504 * win/record-memory/record-memory.vcxproj:
1505 * win/record-memory/record-memoryDebug.props:
1506 * win/record-memory/record-memoryDebugWinCairo.props:
1507 * win/record-memory/record-memoryProduction.props:
1508 * win/record-memory/record-memoryRelease.props:
1509 * win/record-memory/record-memoryReleaseWinCairo.props:
1511 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
1513 [GTK] Clean up the TestWebKitAPI GNUmakefile.am
1514 https://bugs.webkit.org/show_bug.cgi?id=115233
1516 Reviewed by Martin Robinson.
1518 Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
1519 WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
1520 Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
1521 Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
1522 be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
1524 * TestWebKitAPI/GNUmakefile.am:
1526 2013-04-25 Andy Estes <aestes@apple.com>
1528 [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
1529 https://bugs.webkit.org/show_bug.cgi?id=115223
1531 Reviewed by Darin Adler.
1535 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1536 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
1537 (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
1538 when it loads a request with a custom protocol.
1539 * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
1540 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
1541 NSURLProtocol subclass to TestProtocol.{h, mm} and did some
1542 miscellaneous cleanup.
1543 * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
1544 * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
1545 (+[TestProtocol canInitWithRequest:]):
1546 (+[TestProtocol canonicalRequestForRequest:]):
1547 (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
1548 (+[TestProtocol scheme]):
1549 (-[TestProtocol startLoading]):
1550 (-[TestProtocol stopLoading]):
1552 2013-04-26 Martin Robinson <mrobinson@igalia.com>
1554 Remove the remaining Skia #ifdefs
1555 https://bugs.webkit.org/show_bug.cgi?id=114886
1557 Reviewed by Benjamin Poulain.
1559 * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1560 (createBitmapContextFromWebView): Remove Skia #ifdef references.
1562 2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
1564 [BlackBerry] Clean up load interface in WebPage
1565 https://bugs.webkit.org/show_bug.cgi?id=113267
1567 Reviewed by Rob Buis.
1569 Update DumpRenderTree with change of load() interface in WebPage.
1570 RIM Bug# 315535, internally reviewed by Joe Mason.
1572 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1573 (BlackBerry::WebKit::DumpRenderTree::runTest):
1575 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
1577 Remove the HeapGraphSerializer unit test
1578 https://bugs.webkit.org/show_bug.cgi?id=115231
1580 Reviewed by Andreas Kling.
1582 Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
1583 specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
1585 * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1587 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
1589 Remove support for Chromium from build/update scripts
1590 https://bugs.webkit.org/show_bug.cgi?id=115218
1592 Reviewed by Darin Adler.
1594 * Scripts/build-webkit:
1596 * Scripts/update-webkit:
1598 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
1600 Remove support for Chromium from api-test
1601 https://bugs.webkit.org/show_bug.cgi?id=115211
1603 Reviewed by Dirk Pranke.
1605 * Scripts/build-api-tests:
1606 * Scripts/run-api-tests:
1607 (isSupportedPlatform):
1609 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
1611 Get rid of Chromium in build-dumprendertree
1612 https://bugs.webkit.org/show_bug.cgi?id=115212
1614 Reviewed by Dirk Pranke.
1616 * Scripts/build-dumprendertree:
1618 2013-04-25 Alexey Proskuryakov <ap@apple.com>
1620 Pass relatedPage when creating a page in WebKitTestRunner
1621 https://bugs.webkit.org/show_bug.cgi?id=115206
1623 Reviewed by Geoffrey Garen.
1625 To make sure that window.open() opens in the same process even when using multiple processes.
1627 * WebKitTestRunner/PlatformWebView.h:
1628 * WebKitTestRunner/TestController.cpp:
1629 (WTR::TestController::createOtherPage):
1630 (WTR::TestController::createWebViewWithOptions):
1631 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1632 (WTR::PlatformWebView::PlatformWebView):
1633 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1634 (WTR::PlatformWebView::PlatformWebView):
1635 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1636 (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1637 (WTR::PlatformWebView::PlatformWebView):
1638 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1639 (WTR::PlatformWebView::PlatformWebView):
1640 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1641 (WTR::PlatformWebView::PlatformWebView):
1643 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
1645 Fix autocompletion for Benjamin. The Bugzilla email address must come first.
1647 * Scripts/webkitpy/common/config/contributors.json:
1649 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
1651 Build fix. Forgot to merge args.
1653 * Scripts/webkitpy/tool/bot/irc_command.py:
1656 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
1658 webkitbot should recognize its own nickname in greetings.
1659 https://bugs.webkit.org/show_bug.cgi?id=115196
1661 Reviewed by Andreas Kling.
1663 Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
1665 * Scripts/webkitpy/tool/bot/irc_command.py:
1668 2013-04-25 Xavier Castano <xcastanho@igalia.com>
1670 [GTK] Tools/gtk/install-dependencies added ragel dependency
1671 https://bugs.webkit.org/show_bug.cgi?id=115163
1673 Reviewed by Xan Lopez.
1675 The install-dependencies script was missing a dependency on ragel
1676 which is expected when building HarfBuzz.
1678 * gtk/install-dependencies: Added a dependency on ragel for both
1681 2013-04-25 Eduardo Lima Mitev <elima@igalia.com>
1683 [GTK] Remove pango from optional jhbuild dependencies
1684 https://bugs.webkit.org/show_bug.cgi?id=115162
1686 Reviewed by Martin Robinson.
1688 Pango is not needed since revision r148293 that lowers the pango
1689 dependency to 1.30, which is available in most distributions.
1691 * gtk/jhbuild-optional.modules: Removes description of pango module.
1693 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
1695 Remove Chromium-specific cases from FeatureList.pm
1696 https://bugs.webkit.org/show_bug.cgi?id=115169
1698 Reviewed by Andreas Kling.
1700 * Scripts/webkitperl/FeatureList.pm:
1702 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
1704 Remove checking chromium from run-webkit-tests
1705 https://bugs.webkit.org/show_bug.cgi?id=115139
1707 Reviewed by Benjamin Poulain.
1709 * Scripts/run-webkit-tests:
1710 (useNewRunWebKitTests):
1712 2013-04-24 Simon Fraser <simon.fraser@apple.com>
1714 Pixel tests in SVG are all broken in WK2
1715 https://bugs.webkit.org/show_bug.cgi?id=114218
1717 Reviewed by Darin Adler.
1719 Window snapshots in WebKitTestRunner on Mac are window-sized
1720 (800x600), which is wrong for the W3C SVG tests that require a
1723 Fix by resizing the window, as well as the web view in
1724 PlatformWebView::resizeTo() so that window snapshots are correctly
1727 Also do some drive-by cleanup of the window size constants in both
1728 DRT and WTR to remove magic numbers, and make the code more similar.
1730 * DumpRenderTree/TestRunner.cpp:
1731 (TestRunner::setShouldPaintBrokenImage):
1732 * DumpRenderTree/TestRunner.h:
1733 * DumpRenderTree/efl/DumpRenderTree.cpp:
1734 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1735 (webInspectorShowWindow):
1736 * DumpRenderTree/mac/DumpRenderTree.mm:
1737 (createWebViewAndOffscreenWindow):
1738 (sizeWebViewForCurrentTest):
1739 * DumpRenderTree/mac/DumpRenderTreeMac.h:
1740 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1741 (createPagedBitmapContext):
1742 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1743 (DumpRenderTree::DumpRenderTree):
1744 (DumpRenderTree::open):
1745 * DumpRenderTree/qt/TestRunnerQt.cpp:
1746 * DumpRenderTree/qt/TestRunnerQt.h:
1747 * DumpRenderTree/win/DumpRenderTree.cpp:
1748 (sizeWebViewForCurrentTest):
1749 * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1750 * WebKitTestRunner/TestController.cpp:
1751 (WTR::TestController::resetStateToConsistentValues):
1752 * WebKitTestRunner/TestController.h:
1753 * WebKitTestRunner/TestInvocation.cpp:
1754 (WTR::sizeWebViewForCurrentTest):
1755 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1756 (WTR::PlatformWebView::PlatformWebView):
1757 (WTR::PlatformWebView::resizeTo):
1759 2013-04-24 Byungwoo Lee <bw80.lee@samsung.com>
1761 [EFL] Fix build error after r148963.
1762 https://bugs.webkit.org/show_bug.cgi?id=115126
1764 Reviewed by Laszlo Gombos.
1766 Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
1768 * TestWebKitAPI/PlatformEfl.cmake:
1770 2013-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
1772 [GTK] Use stamp files for generate-forwarding-headers makefile rules
1773 https://bugs.webkit.org/show_bug.cgi?id=115118
1775 Reviewed by Martin Robinson.
1777 Use a stamp file for the TestWebKitAPI and WebKitTestRunner
1778 forwarding generator rules and don't call it for soup since there
1779 aren't soup directories in TestWebKitAPI and WebKitTestRunner.
1781 * TestWebKitAPI/GNUmakefile.am:
1782 * WebKitTestRunner/GNUmakefile.am:
1784 2013-04-24 Simon Pena <simon.pena@samsung.com>
1786 [GTK] Update build dependencies
1787 https://bugs.webkit.org/show_bug.cgi?id=115111
1789 Reviewed by Martin Robinson.
1791 The install-dependencies script was missing a dependency on EGL,
1792 which is expected when building Cairo.
1794 * gtk/install-dependencies: Added a dependency on libegl1-mesa
1795 for both apt and yum.
1797 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
1799 Remove the Chromium-specific helper from run_webkit_tests.py
1800 https://bugs.webkit.org/show_bug.cgi?id=114996
1802 Reviewed by Dirk Pranke.
1804 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1807 2013-04-24 Sergio Correia <sergio.correia@openbossa.org>
1809 [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
1810 https://bugs.webkit.org/show_bug.cgi?id=114850
1812 Reviewed by Andreas Kling.
1814 Revision r148312 fixed WebPageProxy cleanup and also changed the process
1815 termination semantics when requested by the user so that a client is not
1816 notified of a crash anymore, since there was no crash anyway.
1818 That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
1819 relied on being notified of a crash after calling WKPageTerminate(). As
1820 a result of not being notified of such non-existent crash, the test would
1821 timeout right after making the terminate call.
1823 This patch adds an InjectedBundle to be used for simulating a crash, by
1824 calling abort() upon receiving a "Crash" message, and thus we are able to
1825 keep testing the crash callback.
1827 This patch also re-enables the WKViewClientWebProcessCallbacks test, which
1828 had been disabled in revisions r148858 and r148855, since it was failing.
1830 * TestWebKitAPI/PlatformEfl.cmake:
1831 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1832 (TestWebKitAPI::TEST):
1833 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
1835 (WKViewClientWebProcessCallbacksTest):
1836 (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
1837 (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
1839 2013-04-24 Christophe Dumez <ch.dumez@sisa.samsung.com>
1841 [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
1842 https://bugs.webkit.org/show_bug.cgi?id=115095
1844 Reviewed by Antonio Gomes.
1846 Use different subfolders under DumpRenderTree Temp folder for every
1847 functionality (icon database, cache, localstorage, ...). This makes
1848 sure there is no conflict between the functionalities.
1850 In EFL's case, libsoup cache was causing problems for the icon
1851 database if sharing the same folder.
1853 * WebKitTestRunner/TestController.cpp:
1854 (WTR::TestController::initialize):
1856 == Rolled over to ChangeLog-2013-04-24 ==