90362a55d4216e0b083b2ac7bc5e286d5f652c6f
[WebKit-https.git] / Tools / ChangeLog
1 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Record subtest values in Dromaeo tests
4         https://bugs.webkit.org/show_bug.cgi?id=124498
5
6         Reviewed by Andreas Kling.
7
8         Supported parsing subtest results.
9
10         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
11         which contains a dictionary with its name and an ordered list of subtest's metrics.
12         (PerfTest.__init__): Initialize _metrics as a list.
13         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
14         (PerfTest._run_with_driver):
15         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
16
17         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
18         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
19         (TestPerfTest.test_parse_output): Ditto.
20         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
21         assertions to ensure subtest results are parsed properly.
22         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
23         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
24
25         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
26         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
27         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
28         adding new results.
29
30         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
31         (TestWithSubtestsData): Added.
32         (TestDriver.run_test):
33         (MainTest.test_run_test_with_subtests): Added.
34
35 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
36
37         Enable HTML template element on Windows ports
38         https://bugs.webkit.org/show_bug.cgi?id=124758
39
40         Reviewed by Andreas Kling.
41
42         * Scripts/webkitperl/FeatureList.pm:
43
44 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
45
46         Remove replay performance tests as it's not actively maintained
47         https://bugs.webkit.org/show_bug.cgi?id=124764
48
49         Reviewed by Andreas Kling.
50
51         Removed the feature.
52
53         * Scripts/webkitpy/performance_tests/perftest.py:
54         (SingleProcessPerfTest.__init__):
55         (PerfTestFactory):
56         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
57         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
58         (PerfTestsRunner._parse_args):
59         (PerfTestsRunner._collect_tests):
60         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
61         (MainTest.test_collect_tests_with_ignored_skipped_list):
62         (MainTest.test_default_args):
63         * Scripts/webkitpy/thirdparty/__init__.py:
64         (AutoinstallImportHook.find_module):
65         (AutoinstallImportHook._install_unittest2):
66         * Scripts/webkitpy/thirdparty/__init___unittest.py:
67         (ThirdpartyTest.test_imports):
68
69 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
70
71         Enable aggressive DFG validation in testing
72         https://bugs.webkit.org/show_bug.cgi?id=124911
73
74         Rubber stamped by Ryosuke Niwa.
75         
76         This enables validation testing in non-concurrent-JIT runs.
77
78         * Scripts/run-jsc-stress-tests:
79
80 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
81
82         Moved methods which belong to Checkout into checkout.py
83         https://bugs.webkit.org/show_bug.cgi?id=124889
84
85         Reviewed by Ryosuke Niwa.
86
87         * Scripts/webkitpy/common/checkout/checkout.py:
88         (Checkout.scripts_directory):
89         (Checkout):
90         (Checkout.script_path):
91         (Checkout.commit_message_for_this_commit):
92         (Checkout.apply_patch):
93         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
94         (test_commit_message_for_this_commit):
95         (CheckoutTest.test_apply_patch):
96         * Scripts/webkitpy/common/checkout/scm/scm.py:
97         (SCM.absolute_path):
98         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
99         (SCMTest._setup_webkittools_scripts_symlink):
100         * Scripts/webkitpy/common/checkout/scm/svn.py:
101         (SVN.create_patch):
102
103 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
104
105         [EFL] Use Config mode of find_package for EFL 1.8
106         https://bugs.webkit.org/show_bug.cgi?id=124555
107
108         Reviewed by Gyuyoung Kim.
109
110         * MiniBrowser/efl/CMakeLists.txt:
111         Added optional config mode and made version requirement optional.
112
113 2013-11-25  Andres Gomez  <agomez@igalia.com>
114
115         [GTK] Search functionality in MiniBrowser provides feedback on search fail
116         https://bugs.webkit.org/show_bug.cgi?id=122681
117
118         Reviewed by Mario Sanchez Prada.
119
120         When using the search functionality in MiniBrowser, if the search
121         fails, the entry background color gets red to report the user
122         about the failing condition. When the entry is cleaned or the
123         search is again succesful the background turns back to its
124         original color.
125
126         * MiniBrowser/gtk/BrowserSearchBar.c:
127         (setFailedStyleForEntry): Added.
128         (doSearch): Sets the entry's background to its original style if
129         there is no text to search.
130         (findControllerFailedToFindTextCallback): Added.
131         (findControllerFoundTextCallback): Added.
132         (browser_search_bar_init): Creates and adds a new CSS provider to
133         the text entry so we can change its style based on the success
134         condition of the search.
135         (browserSearchBarFinalize): Frees the new CSS provider.
136         (browser_search_bar_new): Connects the two new handlers to the
137         "failed-to-find-text" and "found-text" signals emitted by the
138         WebKitFindController.
139
140 2013-11-25  Dan Bernstein  <mitz@apple.com>
141
142         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
143         https://bugs.webkit.org/show_bug.cgi?id=124850
144
145         Reviewed by Brady Eidson.
146
147         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
148
149         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
150         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
151         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
152         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
153         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
154         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
155         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
156
157 2013-11-25  Commit Queue  <commit-queue@webkit.org>
158
159         Unreviewed, rolling out r159752 and r159754.
160         http://trac.webkit.org/changeset/159752
161         http://trac.webkit.org/changeset/159754
162         https://bugs.webkit.org/show_bug.cgi?id=124847
163
164         Broke linux test bots. (Requested by mhahnenberg on #webkit).
165
166         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
167         * Scripts/run-javascriptcore-tests:
168         * Scripts/run-jsc-stress-tests:
169
170 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
171
172         Followup fix after r159752
173
174         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
175
176 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
177
178         run-jsc-stress-tests should be able to package its tests and move them places
179         https://bugs.webkit.org/show_bug.cgi?id=124549
180
181         Reviewed by Filip Pizlo.
182
183         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
184         of grep -i -q
185         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
186         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
187         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
188         All of the generated scripts now are completely relative within the results directory. This allows 
189         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
190         tarball of the generated results directory. Also refactored several portions of the script into 
191         separate functions to make it easier to run them conditionally depending on which mode we're running in.
192
193 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
194
195         EWS creates 0 byte sized log files
196         https://bugs.webkit.org/show_bug.cgi?id=107606
197
198         Reviewed by Ryosuke Niwa.
199
200         There was a modification in r138264, that tried to make less log,
201         because some of the messeges were duplicated. After this the EWS
202         created the log file (with the same name as the bugID) but doesn't
203         write anything into it, even if there were errors during the build.
204         From now only creates the log file only if there is some error.
205
206         * Scripts/webkitpy/tool/bot/queueengine.py:
207         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
208         there is nothing to log. Open the log file only if a ScriptError was raised to
209         avoid to make empty log files for bugs.
210         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
211         because of changes in r138264. Teeing is used for locally testing purposes and
212         this feature is not used anymore.
213         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
214         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
215         change.
216         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
217         (LoggingDelegate): The order of the callbacks was changed by this patch.
218         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
219         so we have to update this test.
220         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
221         this patch.
222         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
223         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
224         to be able to handle it in QueueEngine.run. Without this change, the existing
225         exception handler never run (the process_work_item method never raise ScriptError)
226         We can get the error message only from the ScriptError at this point.
227
228 2013-11-22  Dean Jackson  <dino@apple.com>
229
230         Speculative Mountain Lion build fix.
231
232         * MiniBrowser/mac/AppDelegate.m:
233         (-[BrowserAppDelegate openDocument:]):
234
235 2013-11-22  Anders Carlsson  <andersca@apple.com>
236
237         Fix Mountain Lion bug.
238
239         * MiniBrowser/mac/AppDelegate.m:
240         (-[BrowserAppDelegate openDocument:]):
241
242 2013-11-22  Anders Carlsson  <andersca@apple.com>
243
244         MiniBrowser should use the blocks-based NSOpenPanel API
245         https://bugs.webkit.org/show_bug.cgi?id=124786
246
247         Reviewed by Simon Fraser.
248
249         * MiniBrowser/mac/AppDelegate.m:
250         (-[BrowserAppDelegate frontmostBrowserWindowController]):
251         Account for windows that don't have a BrowserWindowController.
252
253         (-[BrowserAppDelegate openDocument:]):
254
255 2013-11-22  Commit Queue  <commit-queue@webkit.org>
256
257         Unreviewed, rolling out r159690.
258         http://trac.webkit.org/changeset/159690
259         https://bugs.webkit.org/show_bug.cgi?id=124782
260
261         Broke webkitpy tests (Requested by ap on #webkit).
262
263         * Scripts/webkitpy/tool/bot/queueengine.py:
264         (QueueEngine.run):
265         (QueueEngine._open_work_log):
266         (QueueEngine._ensure_work_log_closed):
267         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
268         (AbstractEarlyWarningSystem.review_patch):
269
270 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
271
272         EWS creates 0 byte sized log files
273         https://bugs.webkit.org/show_bug.cgi?id=107606
274
275         Reviewed by Ryosuke Niwa.
276
277         There was a modification in r138264, that tried to make less log, 
278         because some of the messeges were duplicated. After this the EWS 
279         created the log file (with the same name as the bugID) but doesn't 
280         write anything into it, even if there were errors during the build. 
281         From now only creates the log file only if there is some error.
282
283         * Scripts/webkitpy/tool/bot/queueengine.py:
284         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
285         there is nothing to log. Open the log file only if a ScriptError was raised to
286         avoid to make empty log files for bugs.
287         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
288         because of changes in r138264. Teeing is used for locally testing purposes and
289         this feature is not used anymore.
290         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
291         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
292         change.
293         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
294         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
295         to be able to handle it in QueueEngine.run. Without this change, the existing
296         exception handler never run (the process_work_item method never raise ScriptError)
297         We can get the error message only from the ScriptError at this point.
298
299 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
300
301         Remove ENABLE_WORKERS
302         https://bugs.webkit.org/show_bug.cgi?id=105784
303
304         Reviewed by Darin Adler.
305
306         * Scripts/webkitperl/FeatureList.pm:
307
308 2013-11-21  Darin Adler  <darin@apple.com>
309
310         Try to fix buildbot Dashboard for people who have not hidden anything.
311
312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
313         Add a null check for hidden platforms.
314
315 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
316
317         Remove chrome/chromium related things from webkitpy.
318         https://bugs.webkit.org/show_bug.cgi?id=124493
319
320         Reviewed by Darin Adler.
321
322         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
323         (PortTest.assert_mock_port_works):
324         * Scripts/webkitpy/port/base.py:
325         (Port.to.setup_environ_for_server):
326         * Scripts/webkitpy/port/mac_unittest.py:
327         (test_tests_for_other_platforms):
328         * Scripts/webkitpy/port/mock_drt.py:
329         (MockTestShell.output_for_test):
330         * Scripts/webkitpy/tool/bot/irc_command.py:
331         (Restart.execute):
332         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
333         (IRCBotTest.test_help):
334
335 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
336
337         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
338         https://bugs.webkit.org/show_bug.cgi?id=124717
339
340         Reviewed by Ryosuke Niwa.
341
342         * Scripts/webkitpy/style/filereader.py:
343         (TextFileReader.process_file):
344         * Scripts/webkitpy/style/filereader_unittest.py:
345         (TextFileReaderTest.test_process_file__does_not_exist):
346
347 2013-11-21  Mark Rowe  <mrowe@apple.com>
348
349         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
350
351         All modern versions of Xcode set it appropriately for our needs.
352
353         Reviewed by Alexey Proskuryakov.
354
355         * MiniBrowser/Configurations/Base.xcconfig:
356         * WebKitTestRunner/Configurations/Base.xcconfig:
357
358 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
359
360         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
361         https://bugs.webkit.org/show_bug.cgi?id=124676
362
363         Reviewed by Daniel Bates.
364
365         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
366         elements when there were more then one occurrence of that argument.
367         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
368         {b, a}, when it should be {b, c}.
369
370         * Scripts/webkitdirs.pm:
371         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
372         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
373         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
374
375 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
376
377         Update build-webkit after r159550.
378
379         * Scripts/webkitperl/FeatureList.pm:
380
381 2013-11-21  Lucas Forschler  <lforschler@apple.com>
382
383         Bring a new bot online, replacing the previous ones.
384         
385         Unreviewed.
386
387         * BuildSlaveSupport/build.webkit.org-config/config.json:
388
389 2013-11-21  Dean Jackson  <dino@apple.com>
390
391         Don't fetch hidden platforms on build.webkit.org/dashboard
392         https://bugs.webkit.org/show_bug.cgi?id=124750
393
394         Reviewed by Tim Horton.
395
396         If a platform is hidden, don't fetch its data. If it
397         becomes unhidden, try to fetch immediately (unless
398         you've recently fetched).
399
400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
402
403 2013-11-21  Commit Queue  <commit-queue@webkit.org>
404
405         Unreviewed, rolling out r159633.
406         http://trac.webkit.org/changeset/159633
407         https://bugs.webkit.org/show_bug.cgi?id=124726
408
409         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
410
411         * Scripts/webkitpy/style/checker.py:
412         (check_webkit_style_configuration):
413         (CheckerDispatcher.dispatch):
414         (StyleProcessorConfiguration):
415         (StyleProcessorConfiguration.__init__):
416         (StyleProcessorConfiguration.write_style_error):
417
418 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
419
420         Remove the stderr_write attribute from StyleProcessorConfiguration.
421         https://bugs.webkit.org/show_bug.cgi?id=124703
422
423         Reviewed by Brent Fulgham.
424
425         * Scripts/webkitpy/style/checker.py:
426         (check_webkit_style_configuration):
427         (CheckerDispatcher.dispatch):
428         (StyleProcessorConfiguration):
429         (StyleProcessorConfiguration.__init__):
430         (StyleProcessorConfiguration.write_style_error):
431
432 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
433
434         PerfTestRunner._generate_results_dict shouldn't depend on test objects
435         https://bugs.webkit.org/show_bug.cgi?id=124623
436
437         Removed the dependency on test objects from results JSON generation.
438         This allows single test.run to return metrics for multiple tests
439
440         Reviewed by Antti Koivisto.
441
442         * Scripts/webkitpy/performance_tests/perftest.py:
443         (PerfTestMetric.__init__): Takes the test path and test name.
444         (PerfTestMetric.path): Added.
445         (PerfTestMetric.test_file_name): Added.
446         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
447         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
448         The path is going to have the names of subtests at the end once we support them.
449
450         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
451         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
452         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
453         (TestPerfTestMetric.test_has_values): Ditto.
454         (TestPerfTestMetric.test_append): Ditto.
455
456         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
457         (_generate_results_dict): Only use metrics.
458         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
459
460 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
461
462         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
463         https://bugs.webkit.org/show_bug.cgi?id=124697
464
465         Reviewed by Ryosuke Niwa.
466
467         * Scripts/webkitdirs.pm:
468         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
469         before trying to access to the first element.
470
471 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
472
473         [GTK] Mark all deprecated symbols in GObject DOM bindings
474         https://bugs.webkit.org/show_bug.cgi?id=124406
475
476         Reviewed by Gustavo Noronha Silva.
477
478         * Scripts/webkitpy/style/checker.py: Add special case for
479         WebKitDOMDeprecated.
480         * gtk/generate-gtkdoc:
481         (get_webkit2_options): Use the prefix of the methods as namespace,
482         since this is what gtkdoc expects to sort the index.
483         (get_webkit1_options): Ditto.
484         (get_webkitdom_options): Ditto.
485         * gtk/generate-webkitdom-doc-files:
486         (WebKitDOMDocGenerator): Add a global list of deleted objects.
487         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
488         the documentation for classes that are deprecated because they
489         have been removed.
490         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
491         for deleted classes too.
492         (WebKitDOMDocGeneratorSections.__init__): Build a list of
493         deprecated symbols using the given symbols file.
494         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
495         deleted class corresponding to the given function.
496         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
497         dictionary of deprecated symbols for every class.
498         (WebKitDOMDocGeneratorSections.write_section): Add also the
499         deprecated symbols in every section.
500         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
501         sections for deleted classes too.
502
503 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
504
505         check-webkit-style should support C++11 rvalue references.
506         https://bugs.webkit.org/show_bug.cgi?id=123406
507
508         Reviewed by Brent Fulgham.
509
510         * Scripts/webkitpy/style/checkers/cpp.py:
511         (check_style):
512         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
513         (Cpp11StyleTest):
514         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
515
516 2013-11-20  Dean Jackson  <dino@apple.com>
517
518         Allow settings to be shown/hidden on build.webkit.org/dashboard
519         https://bugs.webkit.org/show_bug.cgi?id=124694
520
521         Reviewed by Tim Horton.
522
523         In preparation for more options/buttons, allow the page to
524         show or hide all the interactive things using a little gear icon
525         in the top left corner.
526
527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
529         (Settings.prototype.toggleSettingsDisplay):
530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
531         (div.cellButton.hide):
532         (div.cellButton.unhide):
533         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
534         (.settings):
535         (.settings:hover):
536         (.settings-visible .settings):
537
538 2013-11-20  Dean Jackson  <dino@apple.com>
539
540         No need to base64 SVG on build.webkit.org/dashboard
541         https://bugs.webkit.org/show_bug.cgi?id=124687
542
543         Reviewed by Tim Horton.
544
545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
546         (.status-line.good .bubble.pictogram):
547
548 2013-11-20  Dean Jackson  <dino@apple.com>
549
550         Make links look more like links on build.webkit.org/dashboard
551         https://bugs.webkit.org/show_bug.cgi?id=124686
552
553         Reviewed by Tim Horton.
554
555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
556         (.queue-view .queueLabel:hover):
557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
558         (.status-line.linked .label:hover):
559
560 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
561
562         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
563         https://bugs.webkit.org/show_bug.cgi?id=124581
564
565         Reviewed by Daniel Bates.
566
567         Some subroutines are replicating code from checkForArgument**
568         functions instead of reusing them as is being done by all other functions.
569
570         * Scripts/webkitdirs.pm:
571         (determineXcodeSDK): Added.
572         (determinePassedConfiguration): Added.
573         (determinePassedArchitecture): Added.
574         (checkForArgumentAndRemoveFromARGV): Added.
575         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
576
577 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
578
579         Delete baseline optimizer
580         https://bugs.webkit.org/show_bug.cgi?id=122333
581
582         Reviewed by Ryosuke Niwa.
583
584         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
585         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
586         * Scripts/webkitpy/tool/commands/rebaseline.py:
587         (RebaselineTest.execute):
588         (AbstractParallelRebaselineCommand._files_to_add):
589         (AbstractParallelRebaselineCommand._rebaseline):
590         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
591         (TestRebaselineJson.test_rebaseline_all):
592         (TestRebaselineJson.test_rebaseline_debug):
593         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
594
595 2013-11-20  Anders Carlsson  <andersca@apple.com>
596
597         Enable PageLoadTest assertions again
598         https://bugs.webkit.org/show_bug.cgi?id=124681
599
600         Reviewed by Tim Horton.
601
602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
603         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
604
605 2013-11-20  Mark Rowe  <mrowe@apple.com>
606
607         Remove some obsolete logic from WebKit.app.
608
609         Reviewed by Alexey Proskuryakov.
610
611         * WebKitLauncher/WebKitNightlyEnabler.m:
612         (poseAsWebKitApp): Remove a pre-10.6 codepath.
613         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
614
615 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
616
617         Moved stray urls from svn.py and statusserver.py into common.config.urls
618         https://bugs.webkit.org/show_bug.cgi?id=124650
619
620         Reviewed by Ryosuke Niwa.
621
622         * Scripts/webkitpy/common/checkout/scm/svn.py:
623         (SVNRepository):
624         * Scripts/webkitpy/common/config/urls.py:
625         * Scripts/webkitpy/common/net/statusserver.py:
626         (StatusServer.__init__):
627         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
628         (_generate_results_dict):
629
630 2013-11-20  Commit Queue  <commit-queue@webkit.org>
631
632         Unreviewed, rolling out r159496.
633         http://trac.webkit.org/changeset/159496
634         https://bugs.webkit.org/show_bug.cgi?id=124641
635
636         It caused warning and build break with cmake lower than 2.8.8
637         (Requested by ryuan on #webkit).
638
639         * MiniBrowser/efl/CMakeLists.txt:
640
641 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
642
643         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
644         https://bugs.webkit.org/show_bug.cgi?id=124412
645
646         Reviewed by Gyuyoung Kim.
647
648         Update libseccomp to a newer 2.1.0 version.
649
650         * efl/jhbuild.modules:
651
652 2013-11-19  Mark Rowe  <mrowe@apple.com>
653
654         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
655
656         Gestalt is deprecated on recent OS X versions so we should switch off it.
657
658         Reviewed by Sam Weinig.
659
660         * WebKitLauncher/main.m:
661         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
662         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
663         two components, then join them back up.
664         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
665         the version we care about.
666
667 2013-11-19  Commit Queue  <commit-queue@webkit.org>
668
669         Unreviewed, rolling out r159538.
670         http://trac.webkit.org/changeset/159538
671         https://bugs.webkit.org/show_bug.cgi?id=124627
672
673         it broke run-jsc-stress-tests (Requested by mhahnenberg on
674         #webkit).
675
676         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
677         * Scripts/run-javascriptcore-tests:
678         * Scripts/run-jsc-stress-tests:
679
680 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
681
682         run-jsc-stress-tests should be able to package its tests and move them places
683         https://bugs.webkit.org/show_bug.cgi?id=124549
684
685         Reviewed by Geoff Garen and Filip Pizlo.
686
687         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
688         of grep -i -q 
689         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
690         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
691         other files that those tests require to run in any environment along with a fixed root directory into which these
692         files and their expected directory structure are cloned. The default Bundle class is basically 
693         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
694         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
695         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
696         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
697         to use MovableBundle instead of just Bundle. 
698
699 2013-11-19  Dan Bernstein  <mitz@apple.com>
700
701         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
702
703         Rubber-stamped by Mark Rowe.
704
705         Reverted r156840.
706
707         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
708
709 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
710
711         Yet another build fix. Just allow any character.
712         There are just too many special characters to be listed here.
713
714         * Scripts/webkitpy/performance_tests/perftest.py:
715         (PerfTest._lines_to_ignore_in_parser_result):
716         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
717         (TestPerfTest.test_parse_output_with_subtests)
718
719 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
720
721         Another build fix. Allow ':' in subtest names.
722
723         * Scripts/webkitpy/performance_tests/perftest.py:
724         (PerfTest._lines_to_ignore_in_parser_result):
725         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
726         (TestPerfTest.test_parse_output_with_subtests)
727
728 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
729
730         [EFL] Use Config mode of find_package for EFL 1.8
731         https://bugs.webkit.org/show_bug.cgi?id=124555
732
733         Reviewed by Gyuyoung Kim.
734
735         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
736
737 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
738
739         Build fix. Subtest names need to be more permissive.
740
741         * Scripts/webkitpy/performance_tests/perftest.py:
742         (PerfTest._lines_to_ignore_in_parser_result):
743         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
744         (TestPerfTest.test_parse_output_with_subtests)
745
746 2013-11-18  Mark Rowe  <mrowe@apple.com>
747
748         Use hw.activecpu for determining how many processes to spawn.
749
750         It's documented as the preferred way to determine the number of threads
751         or processes to create in a SMP aware application.
752
753         Rubber-stamped by Tim Horton.
754
755         * Scripts/copy-webkitlibraries-to-product-directory:
756         * Scripts/run-jsc-stress-tests:
757         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
758
759 2013-11-18  Tim Horton  <timothy_horton@apple.com>
760
761         build.webkit.org/dashboard builder headers should link to the builder page
762         https://bugs.webkit.org/show_bug.cgi?id=124553
763
764         Reviewed by Timothy Hatcher.
765
766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
767         (BuildbotQueue.prototype.get overviewURL):
768         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
769
770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
771         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
772         (BuildbotBuilderQueueView.prototype.update):
773         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
774         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
775         (BuildbotTesterQueueView.prototype.update.appendBuild):
776         (BuildbotTesterQueueView.prototype.update):
777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
778         (.queue-view .queueLabel):
779         (.queue-view .queueLabel:not(:first-child)):
780         Make the header a link instead of a label, and wire it up to overviewURL.
781
782 2013-11-18  Samuel White  <samuel_white@apple.com>
783
784         AX: Add ability to fetch only visible table rows.
785         https://bugs.webkit.org/show_bug.cgi?id=124430
786
787         Reviewed by Chris Fleizach.
788
789         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
790         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
791         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
792         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
793         as the test guidelines state, our tests should be more focused and specific about what they test.
794
795         * DumpRenderTree/AccessibilityUIElement.cpp:
796         (uiElementArrayAttributeValueCallback):
797         (AccessibilityUIElement::uiElementArrayAttributeValue):
798         (AccessibilityUIElement::getJSClass):
799         * DumpRenderTree/AccessibilityUIElement.h:
800         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
801         (AccessibilityUIElement::uiElementArrayAttributeValue):
802         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
803         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
804         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
805         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
806         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
807         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
808         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
809         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
810         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
811
812 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
813
814         Simplify and reformat the output of performance tests inside test runners
815         https://bugs.webkit.org/show_bug.cgi?id=124496
816
817         Reviewed by Antti Koivisto.
818
819         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
820         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
821         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
822         the first place.
823
824         Also modernize the output to adopt "metric" concept better and make it forward compatible
825         with subtests.
826
827         With this patch, performance tests written using runner.js only produces empty lines or
828         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
829         <subtest name> -> [<value 1>, <value 2>, ...]
830         :<metric name> -> [<value 1>, <value 2>, ...]
831
832         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
833
834         * Scripts/webkitpy/performance_tests/perftest.py:
835         (PerfTest): Removed a bunch of regular expressions that are no longer used.
836         (PerfTest._run_with_driver): Just parse the values and description and treat everything
837         else as errors.
838
839         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
840         (TestPerfTest.test_parse_output): Removed the junk.
841         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
842         which was removed in favor of the tests below.
843         (TestPerfTest.test_parse_output_with_running_five_times): Added.
844         (TestPerfTest.test_parse_output_with_detailed_info): Added.
845         (TestPerfTest.test_parse_output_with_statistics): Added.
846         (TestPerfTest.test_parse_output_with_description): Removed the junk.
847         (TestPerfTest.test_parse_output_with_subtests): Ditto.
848         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
849
850         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
851         (EventTargetWrapperTestData): Ditto.
852         (SomeParserTestData): Ditto.
853         (MemoryTestData): Ditto.
854
855 2013-11-18  Tim Horton  <timothy_horton@apple.com>
856
857         Occasionally, hundreds of tests fail with small text diffs on Mavericks
858         https://bugs.webkit.org/show_bug.cgi?id=124312
859
860         Reviewed by Simon Fraser.
861
862         * Scripts/webkitpy/layout_tests/controllers/manager.py:
863         (Manager._set_up_run):
864         * Scripts/webkitpy/port/base.py:
865         (Port.to.reset_preferences):
866         * Scripts/webkitpy/port/mac.py:
867         (MacPort.reset_preferences):
868         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
869         returning some of the functionality of 158652 after 159364 removed it.
870
871 2013-11-18  Tim Horton  <timothy_horton@apple.com>
872
873         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
874         https://bugs.webkit.org/show_bug.cgi?id=122909
875
876         Reviewed by Alexey Proskuryakov.
877
878         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
879
880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
881         (.status-line .bubble):
882         (.status-line.good .bubble.pictogram):
883
884 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
885
886         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
887         https://bugs.webkit.org/show_bug.cgi?id=124499
888
889         Reviewed by Csaba Osztrogonác.
890
891         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
892
893         * Scripts/webkitpy/performance_tests/perftest.py:
894         (PerfTest._should_ignore_line):
895         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
896         (TestPerfTest): Removed the unit test.
897
898 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
899
900         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
901         quite as easily.
902         
903         With help from Andy Trick.
904
905         * Scripts/export-llvm-build:
906
907 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
908
909         FTL should have an explicit notion of bytecode liveness
910         https://bugs.webkit.org/show_bug.cgi?id=124181
911
912         Reviewed by Mark Hahnenberg.
913
914         * Scripts/run-jsc-stress-tests:
915
916 2013-11-16  Dan Bernstein  <mitz@apple.com>
917
918         No way for policy client to determine if a the response’s MIME type can be shown
919         https://bugs.webkit.org/show_bug.cgi?id=124445
920
921         Reviewed by Sam Weinig.
922
923         * MiniBrowser/mac/WK2BrowserWindowController.m:
924         (decidePolicyForResponse): Added canShowMIMEType parameter.
925         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
926
927         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
928         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
929
930         * WebKitTestRunner/TestController.cpp:
931         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
932         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
933         * WebKitTestRunner/TestController.h:
934
935 2013-11-16  Tim Horton  <timothy_horton@apple.com>
936
937         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
938         https://bugs.webkit.org/show_bug.cgi?id=122909
939
940         Reviewed by Timothy Hatcher.
941
942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
944         (StatusLineView.prototype.set repeatCount):
945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
946         (.status-line.good .bubble.pictogram):
947         Use an SVG image instead of an obscure font for the checkboxes so they
948         render identically on all platforms.
949
950 2013-11-15  Tim Horton  <timothy_horton@apple.com>
951
952         Occasionally, hundreds of tests fail with small text diffs on Mavericks
953         https://bugs.webkit.org/show_bug.cgi?id=124312
954
955         Reviewed by Alexey Proskuryakov.
956
957         Try reverting the part of r158652 that deleted all of the persistent
958         defaults, in the thought that there might be some sort of race between
959         processes causing some settings to be left in the wrong state.
960
961         * DumpRenderTree/mac/DumpRenderTree.mm:
962         (setDefaultsToConsistentValuesForTesting):
963         * WebKitTestRunner/mac/main.mm:
964         (setDefaultsToConsistentValuesForTesting):
965
966 2013-11-15  Dan Bernstein  <mitz@apple.com>
967
968         Give the policy client the originating frame of a navigation action
969         https://bugs.webkit.org/show_bug.cgi?id=124431
970
971         Reviewed by Anders Carlsson.
972
973         * MiniBrowser/mac/WK2BrowserWindowController.m:
974         (decidePolicyForNavigationAction): Added originatingFrame parameter.
975         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
976         client.
977
978         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
979         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
980         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
981
982         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
983         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
984         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
985
986         * WebKitTestRunner/TestController.cpp:
987         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
988         client.
989         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
990         * WebKitTestRunner/TestController.h:
991
992 2013-11-15  Tim Horton  <timothy_horton@apple.com>
993
994         build.webkit.org/dashboard should provide a way to focus on a subset of bots
995         https://bugs.webkit.org/show_bug.cgi?id=122676
996
997         Reviewed by Timothy Hatcher.
998
999         Add a small 'hide' button next to every platform logo, and a 'show all'
1000         button which only appears when at least one platform is hidden. Hidden
1001         platforms persist using localStorage.
1002
1003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1005         (updateHiddenPlatforms):
1006         (documentReady.unhideButton):
1007         (documentReady.hideButton):
1008         (documentReady):
1009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
1010         (Settings.prototype.setObject):
1011         (Settings.prototype.getObject):
1012         (Settings.prototype.addSettingListener):
1013         (Settings.prototype.fireSettingListener):
1014         (Settings.prototype.toggleHiddenPlatform):
1015         (Settings.prototype.clearHiddenPlatforms):
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1017         (div.cellButton):
1018         (div.cellButton.hide):
1019         (.hidden):
1020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1021
1022 2013-11-15  Jer Noble  <jer.noble@apple.com>
1023
1024         MediaTime addition and subtraction operators have errors when the rhs is infinite.
1025         https://bugs.webkit.org/show_bug.cgi?id=124413
1026
1027         Reviewed by Eric Carlson.
1028
1029         Add a test for operator+ and operator- where an infinite value appears
1030         on the right-hand side:
1031         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1032         (TestWebKitAPI::TEST):
1033
1034         Add a LLDB summary provider for MediaTime which displays the rational
1035         time as well as the value in seconds:
1036         * lldb/lldb_webkit.py:
1037         (__lldb_init_module):
1038         (WTFMediaTime_SummaryProvider):
1039         (WTFHashTableProvider.has_children):
1040         (WTFMediaTimeProvider):
1041         (WTFMediaTimeProvider.__init__):
1042         (WTFMediaTimeProvider.timeValue):
1043         (WTFMediaTimeProvider.timeScale):
1044         (WTFMediaTimeProvider.isInvalid):
1045         (WTFMediaTimeProvider.isPositiveInfinity):
1046         (WTFMediaTimeProvider.isNegativeInfinity):
1047         (WTFMediaTimeProvider.isIndefinite):
1048
1049 2013-11-15  Tim Horton  <timothy_horton@apple.com>
1050
1051         Make it possible to select revision numbers on build.webkit.org/dashboard
1052         https://bugs.webkit.org/show_bug.cgi?id=124400
1053
1054         Reviewed by Timothy Hatcher.
1055
1056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1057         (BuildbotQueueView.prototype.revisionLinksForIteration):
1058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1059         (.selectable):
1060         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
1061         This way, a Dashboard user can highlight revision numbers for easy copying,
1062         and doesn't even have to be precise about the selection.
1063
1064 2013-11-15  Tim Horton  <timothy_horton@apple.com>
1065
1066         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
1067         https://bugs.webkit.org/show_bug.cgi?id=124399
1068
1069         Reviewed by Gustavo Noronha Silva.
1070
1071         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
1072         with the icons adjusted to have solid backgrounds, to not be squished, and to not
1073         intersect the ring, similar to the Mac icons.
1074
1075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
1076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
1077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
1078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
1079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1080         (documentReady.hideButton):
1081         (documentReady):
1082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1083         (table.queue-grid tr.platform.linux-gtk img.logo):
1084         (table.queue-grid tr.platform.linux-efl img.logo):
1085
1086 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
1087
1088         [GStreamer] Add support for Media Source API
1089         https://bugs.webkit.org/show_bug.cgi?id=99065
1090
1091         Reviewed by Philippe Normand.
1092
1093         * Scripts/webkitperl/FeatureList.pm:
1094
1095 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1096
1097         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
1098         https://bugs.webkit.org/show_bug.cgi?id=124360
1099
1100         Reviewed by Philippe Normand.
1101
1102         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
1103
1104 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
1105
1106         [Win] Improve support for command line builds of 64-bit JSC
1107         https://bugs.webkit.org/show_bug.cgi?id=124380
1108
1109         Reviewed by David Kilzer.
1110
1111         * Scripts/webkitdirs.pm:
1112         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
1113         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
1114         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
1115         what the "$configurationForVisualStudio" value is for.
1116
1117 2013-11-14  Oliver Hunt  <oliver@apple.com>
1118
1119         Make CLoop easier to build, and make it work
1120         https://bugs.webkit.org/show_bug.cgi?id=124359
1121
1122         Reviewed by Geoffrey Garen.
1123
1124         Add --cloop support to forcibly enable to CLoop build
1125
1126         * Scripts/build-jsc:
1127         * Scripts/build-webkit:
1128
1129 2013-11-14  Lucas Forschler  <lforschler@apple.com>
1130
1131         Add webkit slave.
1132
1133         Unreviewed.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/config.json:
1136
1137 2013-11-14  Tim Horton  <timothy_horton@apple.com>
1138
1139         build.webkit.org/dashboard can’t open different results in two new tabs
1140         https://bugs.webkit.org/show_bug.cgi?id=124383
1141
1142         Reviewed by Alexey Proskuryakov.
1143
1144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1145         (BuildbotQueueView.prototype.revisionLinksForIteration):
1146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1147         (StatusLineView.prototype._clicked):
1148         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
1149         real pseudo-target and instead acts as a named target and will end up causing all link clicks
1150         to open in the same secondary tab).
1151
1152 2013-11-14  Anders Carlsson  <andersca@apple.com>
1153
1154         Remove duplicate entry.
1155
1156         * Scripts/webkitpy/common/config/contributors.json:
1157
1158 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
1159
1160         [ATK] Change WKTR/DRT AX methods to use nullptr 
1161         https://bugs.webkit.org/show_bug.cgi?id=124352
1162
1163         Reviewed by Anders Carlsson.
1164
1165         Change WKTR/DRT accessibility related methods to use nullptr.
1166
1167         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1168         (AccessibilityController::AccessibilityController):
1169         (AccessibilityController::elementAtPoint):
1170         (AccessibilityController::removeNotificationListener):
1171         (AccessibilityController::childElementById):
1172         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
1173         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
1174         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1175         (AccessibilityUIElement::elementAtPoint):
1176         (AccessibilityUIElement::linkedUIElementAtIndex):
1177         (AccessibilityUIElement::getChildAtIndex):
1178         (AccessibilityUIElement::titleUIElement):
1179         (AccessibilityUIElement::parentElement):
1180         (AccessibilityUIElement::subrole):
1181         (AccessibilityUIElement::roleDescription):
1182         (AccessibilityUIElement::orientation):
1183         (AccessibilityUIElement::ariaDropEffects):
1184         (AccessibilityUIElement::uiElementForSearchPredicate):
1185         (AccessibilityUIElement::cellForColumnAndRow):
1186         (AccessibilityUIElement::disclosedRowAtIndex):
1187         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1188         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1189         (AccessibilityUIElement::selectedRowAtIndex):
1190         (AccessibilityUIElement::rowAtIndex):
1191         (AccessibilityUIElement::disclosedByRow):
1192         (AccessibilityUIElement::removeNotificationListener):
1193         (AccessibilityUIElement::classList):
1194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1195         (WTR::AccessibilityController::logAccessibilityEvents):
1196         (WTR::AccessibilityController::resetToConsistentState):
1197         (WTR::childElementById):
1198         (WTR::AccessibilityController::accessibleElementById):
1199         (WTR::AccessibilityController::removeNotificationListener):
1200         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1201         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1202         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1203         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1204         (WTR::AccessibilityUIElement::elementAtPoint):
1205         (WTR::AccessibilityUIElement::childAtIndex):
1206         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1207         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1208         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1209         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1210         (WTR::AccessibilityUIElement::rowAtIndex):
1211         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1212         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1213         (WTR::AccessibilityUIElement::titleUIElement):
1214         (WTR::AccessibilityUIElement::parentElement):
1215         (WTR::AccessibilityUIElement::disclosedByRow):
1216         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1217         (WTR::AccessibilityUIElement::orientation):
1218         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1219         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1220         (WTR::AccessibilityUIElement::horizontalScrollbar):
1221         (WTR::AccessibilityUIElement::verticalScrollbar):
1222         (WTR::AccessibilityUIElement::removeNotificationListener):
1223         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1224         (WTR::AccessibilityUIElement::previousTextMarker):
1225         (WTR::AccessibilityUIElement::nextTextMarker):
1226         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1227         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1228         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1229         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1230         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1231         (WTR::AccessibilityUIElement::textMarkerForPoint):
1232         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1233         (WTR::AccessibilityUIElement::textMarkerForIndex):
1234         (WTR::AccessibilityUIElement::supportedActions):
1235         (WTR::AccessibilityUIElement::pathDescription):
1236         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1237         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1238         (WTR::AccessibilityUIElement::classList):
1239
1240 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1241
1242         run-perf-tests should warn loudly if you're using a Debug build.
1243         https://bugs.webkit.org/show_bug.cgi?id=105236
1244
1245         Reviewed by Csaba Osztrogonác.
1246
1247         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1248         (PerfTestsRunner.run):
1249
1250 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1251
1252         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
1253         https://bugs.webkit.org/show_bug.cgi?id=124143
1254
1255         Reviewed by Csaba Osztrogonác.
1256
1257         * Scripts/webkitpy/port/factory.py:
1258         (configuration_options):
1259
1260 2013-11-13  Anders Carlsson  <andersca@apple.com>
1261
1262         Add a Vector constructor that takes an std::initializer_list
1263         https://bugs.webkit.org/show_bug.cgi?id=124287
1264
1265         Reviewed by Antti Koivisto.
1266
1267         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1268         (TestWebKitAPI::TEST):
1269
1270 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
1271
1272         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
1273
1274         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1275         (TestRebaselineTest.test_baseline_directory): Updated.
1276
1277 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
1278
1279         [ATK] Support compilation of EFL/GTK without accessibility
1280         https://bugs.webkit.org/show_bug.cgi?id=122448
1281
1282         Reviewed by Chris Fleizach.
1283
1284         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
1285         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
1286
1287         * DumpRenderTree/AccessibilityController.h:
1288         * DumpRenderTree/AccessibilityUIElement.h:
1289         * DumpRenderTree/atk/AccessibilityCallbacks.h:
1290         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
1291         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
1292         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1293         (WTR::AccessibilityController::rootElement):
1294         (WTR::AccessibilityController::focusedElement):
1295         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1296         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1297         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1298         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1299         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1300         * WebKitTestRunner/PlatformEfl.cmake:
1301
1302 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
1303
1304         [EFL] Added libxss-dev to install-dependencies
1305         https://bugs.webkit.org/show_bug.cgi?id=124254
1306
1307         Reviewed by Gyuyoung Kim.
1308
1309         libxss-dev is required to build EFL packages.
1310         see building part in http://www.enlightenment.org/p.php?p=contribute
1311
1312         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
1313
1314 2013-11-12  Tim Horton  <timothy_horton@apple.com>
1315
1316         After http://trac.webkit.org/changeset/159109, update
1317         rebaseline_unittest to use the new GTK bot names.
1318
1319         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1320         (TestRebaselineTest.test_baseline_directory):
1321
1322 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
1323
1324         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
1325         https://bugs.webkit.org/show_bug.cgi?id=124144
1326
1327         Reviewed by Gustavo Noronha Silva.
1328
1329         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
1330         according to http://build.webkit.org/builders.
1331
1332         * Scripts/webkitpy/port/builders.py:
1333
1334 2013-11-11  Samuel White  <samuel_white@apple.com>
1335
1336         AX: support helpText() in DumpRenderTree
1337         https://bugs.webkit.org/show_bug.cgi?id=40194
1338
1339         Reviewed by Chris Fleizach.
1340
1341         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
1342
1343         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1344         (AccessibilityUIElement::helpText):
1345
1346 2013-11-11  Anders Carlsson  <andersca@apple.com>
1347
1348         Remove block based APIs from the WebKit2 C API
1349         https://bugs.webkit.org/show_bug.cgi?id=124157
1350
1351         Reviewed by Sam Weinig.
1352
1353         Update for WK2 changes.
1354
1355         * MiniBrowser/mac/WK2BrowserWindowController.m:
1356         (dumpSource):
1357         (-[WK2BrowserWindowController dumpSourceToConsole:]):
1358
1359 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
1360
1361         The feeder queue will not feed patches older than one week.
1362         https://bugs.webkit.org/show_bug.cgi?id=107152
1363
1364         Reviewed by Csaba Osztrogonác.
1365
1366         The feeder queue will not feed patches older than one week.
1367         Unit test added to this scenario.
1368
1369         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1370         (BugzillaQueries._parse_attachment_ids_request_query):
1371           Handle date parameter.
1372         (BugzillaQueries):
1373         (BugzillaQueries._fetch_attachment_ids_request_query):
1374           Propagate date.
1375         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
1376           Propagate date.
1377         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1378         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
1379           Handle date.
1380         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1381         (test_request_page_parsing):
1382           Unit test added.
1383         * Scripts/webkitpy/tool/bot/feeders.py:
1384         (EWSFeeder.feed):
1385           Query patch ids with date parameter (now - 1 week).
1386
1387 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
1388
1389         Do not shut down ImageDiff server after every diff during the tests.
1390         https://bugs.webkit.org/show_bug.cgi?id=124140
1391
1392         Reviewed by Csaba Osztrogonác.
1393
1394         There was a FIXME: There is no need to shut down the ImageDiff
1395         server after every diff. Shutdown is removed from that point.
1396
1397         * Scripts/webkitpy/port/image_diff.py:
1398         (ImageDiffer._read):
1399
1400 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
1401
1402         Unreviewed. Added myself as a contributor.
1403
1404         * Scripts/webkitpy/common/config/contributors.json:
1405
1406 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
1407
1408         [GTK] accessibility/aria-link-supports-press.html is failing
1409         https://bugs.webkit.org/show_bug.cgi?id=98355
1410
1411         Reviewed by Mario Sanchez Prada.
1412
1413         Checking "jump" action for link elements. Action "jump" occurs when a link 
1414         element is pressed/clicked.
1415
1416         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1417         (AccessibilityUIElement::isPressActionSupported):
1418         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1419         (WTR::AccessibilityUIElement::isPressActionSupported):
1420
1421 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
1422
1423         [JHBUILD] Jhbuild Makefile build bug workaround
1424         https://bugs.webkit.org/show_bug.cgi?id=123971
1425
1426         Reviewed by Ryosuke Niwa.
1427
1428         After Jhbuild repository is cloned (for instance when you use
1429         Tools/Scripts/update-webkitefl-libs) it is built from sources.
1430         If you have GREP_OPTIONS grep env variable set (for instance
1431         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
1432         uses shell grep. For specific GREP_OPTIONS grep output will be
1433         different than expected one by Jhbuild and there is an error
1434         with Jhbuild build. Jhbuild will not be built and then WebKit
1435         source also will not be built. This patch is a workaround to this
1436         issue. It disables GREP_OPTIONS for Jhbuild build time.
1437
1438         * jhbuild/jhbuild-wrapper:
1439         (install_jhbuild):
1440
1441 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1442
1443         [GTK] Ignore deprecated macros when generating gtk-doc
1444         https://bugs.webkit.org/show_bug.cgi?id=123988
1445
1446         Reviewed by Philippe Normand.
1447
1448         * gtk/generate-gtkdoc:
1449         (get_common_options): Ignore also WEBKIT_DEPRECATED and
1450         WEBKIT_DEPRECATED_FOR decorators.
1451
1452 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1453
1454         [GTK] Pass the library namespace to gtkdoc-mkdb
1455         https://bugs.webkit.org/show_bug.cgi?id=123900
1456
1457         Reviewed by Martin Robinson.
1458
1459         This fixes the generation of the index of symbols in the API
1460         documentation.
1461
1462         * gtk/generate-gtkdoc:
1463         (get_webkit2_options): Define namespace as WebKit.
1464         (get_webkit1_options): Ditto.
1465         (get_webkitdom_options): Define namespace as WebKitDOM.
1466         * gtk/gtkdoc.py:
1467         (GTKDoc.__init__): Add namespace option.
1468         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
1469
1470 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
1471
1472         Modify email order list for James Craig so his primary email is first.
1473
1474         * Scripts/webkitpy/common/config/contributors.json:
1475
1476 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
1477
1478         [Gtk] Disable LTO when building cairo
1479         https://bugs.webkit.org/show_bug.cgi?id=123954
1480
1481         Reviewed by Martin Robinson.
1482
1483         Cairo always uses LTO, when it detects compiler support.
1484         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
1485         default. This patch disables LTO when building cairo library.
1486         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
1487
1488         With gcc 4.7.3, for example, the build fails with the following message:
1489         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
1490
1491         * gtk/jhbuild.modules:
1492
1493 2013-11-07  Samuel White  <samuel_white@apple.com>
1494
1495         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
1496         https://bugs.webkit.org/show_bug.cgi?id=123774
1497
1498         Reviewed by Chris Fleizach.
1499
1500         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
1501
1502         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1503         (AccessibilityUIElement::isFocused):
1504         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1505         (WTR::AccessibilityUIElement::isFocused):
1506
1507 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1508
1509         Removed retrieveQMakespecVar function
1510         https://bugs.webkit.org/show_bug.cgi?id=123996
1511
1512         Reviewed by Csaba Osztrogonác.
1513
1514         * Scripts/webkitdirs.pm:
1515
1516 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1517
1518         Removed QMake related filters
1519         https://bugs.webkit.org/show_bug.cgi?id=123992
1520
1521         Reviewed by Csaba Osztrogonác.
1522
1523         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1524         (TestRebaseline.test_rebaseline):
1525         (TestRebaselineExpectations.test_rebaseline_expectations):
1526
1527 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
1528
1529         [Efl] Disable LTO when building cairo
1530         https://bugs.webkit.org/show_bug.cgi?id=123947
1531
1532         Reviewed by Gyuyoung Kim.
1533
1534         Cairo always uses LTO, when it detects compiler support.
1535         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
1536         default. This patch disables LTO when building cairo library.
1537         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
1538
1539         With gcc 4.7.3, for example, the build fails with the following message:
1540         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
1541
1542         * efl/jhbuild.modules:
1543
1544 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
1545
1546         AX: [ATK] Video and audio elements are not properly exposed
1547         https://bugs.webkit.org/show_bug.cgi?id=123894
1548
1549         Reviewed by Chris Fleizach.
1550
1551         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
1552
1553         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
1554         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
1555
1556 2013-11-07  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1557
1558         Change git_commit_from_svn_revision() to work in a pure git checkout
1559         https://bugs.webkit.org/show_bug.cgi?id=111668
1560
1561         Reviewed by Ryosuke Niwa.
1562
1563         * Scripts/webkitpy/common/checkout/scm/git.py:
1564         (Git.git_commit_from_svn_revision):
1565
1566 2013-11-06  Jer Noble  <jer.noble@apple.com>
1567
1568         Unreviewed webkitpy unit test fix; update baselines after r158765
1569
1570         * Scripts/webkitpy/port/win_unittest.py:
1571         (WinPortTest.test_baseline_search_path):
1572
1573 2013-11-06  Jer Noble  <jer.noble@apple.com>
1574
1575         [Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
1576         https://bugs.webkit.org/show_bug.cgi?id=123905
1577
1578         Reviewed by Brent Fulgham.
1579
1580         Now that the mac-lion results have been removed, the win port should fall back to
1581         the mac-mountainlion results.
1582
1583         * Scripts/webkitpy/port/win.py:
1584         (WinPort.default_baseline_search_path):
1585
1586 2013-11-06  Anders Carlsson  <andersca@apple.com>
1587
1588         Fix a Mountain Lion test failure.
1589
1590         NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
1591
1592         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1593         (TestWebKitAPI::TEST):
1594
1595 2013-11-06  Krzysztof Czech  <k.czech@samsung.com>
1596
1597         [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
1598         https://bugs.webkit.org/show_bug.cgi?id=118969
1599
1600         Reviewed by Mario Sanchez Prada.
1601
1602         Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
1603
1604         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1605         (AccessibilityUIElement::attributesOfChildren):
1606         (AccessibilityUIElement::attributesOfColumnHeaders):
1607         (AccessibilityUIElement::attributesOfRowHeaders):
1608         (AccessibilityUIElement::attributesOfVisibleCells):
1609         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1610         (WTR::AccessibilityUIElement::attributesOfChildren):
1611         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1612         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1613         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1614
1615 2013-11-05  Benjamin Poulain  <benjamin@webkit.org>
1616
1617         [WK2] Add a WebKit2 API for Geolocation's highAccuracy
1618         https://bugs.webkit.org/show_bug.cgi?id=123786
1619
1620         Reviewed by Darin Adler.
1621
1622         Add basic testing for the Geolocation API (start, stop and change accuracy).
1623
1624         * TestWebKitAPI/GNUmakefile.am:
1625         * TestWebKitAPI/PlatformEfl.cmake:
1626         * TestWebKitAPI/PlatformGTK.cmake:
1627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1628         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
1629         (TestWebKitAPI::operator<<):
1630         (TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
1631         (TestWebKitAPI::GeolocationStateTracker::eventsChanged):
1632         (TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
1633         (TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
1634         (TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
1635         (TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
1636         (TestWebKitAPI::setupGeolocationProvider):
1637         (TestWebKitAPI::setupView):
1638         (TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
1639         (TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
1640         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
1641         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
1642         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
1643         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1644         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
1645         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1646         (TestWebKitAPI::didFinishLoadForFrame):
1647         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
1648         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
1649         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
1650         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
1651         * WebKitTestRunner/GeolocationProviderMock.cpp:
1652         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1653
1654 2013-11-05  Anders Carlsson  <andersca@apple.com>
1655
1656         Implement more NSCoder methods
1657         https://bugs.webkit.org/show_bug.cgi?id=123815
1658
1659         Reviewed by Dan Bernstein.
1660
1661         Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.
1662
1663         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1664         (TestWebKitAPI::TEST):
1665         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1666         (-[BundleObject testMethodWithArray:dictionary:request:]):
1667         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
1668
1669 2013-11-05  Filip Pizlo  <fpizlo@apple.com>
1670
1671         Update ReducedFTL
1672         https://bugs.webkit.org/show_bug.cgi?id=123805
1673
1674         Reviewed by Sam Weinig.
1675         
1676         - Make ReducedFTL build with debug info.
1677         
1678         - Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding
1679           memory leaks and attaching a profiler.
1680         
1681         - Reorder the passes so that they match the FTL.
1682         
1683         - Make it possible to change the backend opt level and enable the fast isel.
1684
1685         * ReducedFTL/ReducedFTL.c:
1686         (usage):
1687         (roundUpSize):
1688         (mmAllocateCodeSection):
1689         (main):
1690         * ReducedFTL/build.sh:
1691
1692 2013-11-05  Chris Fleizach  <cfleizach@apple.com>
1693
1694         AX: switch DRT AX methods to use nullptr
1695         https://bugs.webkit.org/show_bug.cgi?id=123773
1696
1697         Reviewed by Andreas Kling.
1698
1699         Switch AX related code in DRT and WKTR to use nullptr.
1700
1701         * DumpRenderTree/AccessibilityUIElement.cpp:
1702         (AccessibilityUIElement::startTextMarker):
1703         (AccessibilityUIElement::endTextMarker):
1704         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1705         (findAccessibleObjectById):
1706         (AccessibilityController::accessibleElementById):
1707         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1708         (AccessibilityUIElement::getChildAtIndex):
1709         (AccessibilityUIElement::linkedUIElementAtIndex):
1710         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1711         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1712         (AccessibilityUIElement::disclosedRowAtIndex):
1713         (AccessibilityUIElement::selectedChildAtIndex):
1714         (AccessibilityUIElement::selectedRowAtIndex):
1715         (AccessibilityUIElement::rowAtIndex):
1716         (AccessibilityUIElement::titleUIElement):
1717         (AccessibilityUIElement::parentElement):
1718         (AccessibilityUIElement::disclosedByRow):
1719         (AccessibilityUIElement::stringAttributeValue):
1720         (AccessibilityUIElement::uiElementAttributeValue):
1721         (AccessibilityUIElement::role):
1722         (AccessibilityUIElement::subrole):
1723         (AccessibilityUIElement::roleDescription):
1724         (AccessibilityUIElement::title):
1725         (AccessibilityUIElement::description):
1726         (AccessibilityUIElement::orientation):
1727         (AccessibilityUIElement::stringValue):
1728         (AccessibilityUIElement::language):
1729         (AccessibilityUIElement::helpText):
1730         (AccessibilityUIElement::valueDescription):
1731         (AccessibilityUIElement::speak):
1732         (AccessibilityUIElement::classList):
1733         (AccessibilityUIElement::ariaDropEffects):
1734         (AccessibilityUIElement::rangeForLine):
1735         (AccessibilityUIElement::rangeForPosition):
1736         (AccessibilityUIElement::boundsForRange):
1737         (AccessibilityUIElement::stringForRange):
1738         (AccessibilityUIElement::attributedStringForRange):
1739         (AccessibilityUIElement::uiElementForSearchPredicate):
1740         (AccessibilityUIElement::attributesOfColumnHeaders):
1741         (AccessibilityUIElement::attributesOfRowHeaders):
1742         (AccessibilityUIElement::attributesOfColumns):
1743         (AccessibilityUIElement::attributesOfRows):
1744         (AccessibilityUIElement::attributesOfVisibleCells):
1745         (AccessibilityUIElement::attributesOfHeader):
1746         (AccessibilityUIElement::rowIndexRange):
1747         (AccessibilityUIElement::columnIndexRange):
1748         (AccessibilityUIElement::cellForColumnAndRow):
1749         (AccessibilityUIElement::horizontalScrollbar):
1750         (AccessibilityUIElement::verticalScrollbar):
1751         (AccessibilityUIElement::pathDescription):
1752         (AccessibilityUIElement::selectedTextRange):
1753         (AccessibilityUIElement::url):
1754         (AccessibilityUIElement::textMarkerRangeForElement):
1755         (AccessibilityUIElement::textMarkerForIndex):
1756         (AccessibilityUIElement::previousTextMarker):
1757         (AccessibilityUIElement::nextTextMarker):
1758         (AccessibilityUIElement::stringForTextMarkerRange):
1759         (AccessibilityUIElement::textMarkerRangeForMarkers):
1760         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1761         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1762         (AccessibilityUIElement::endTextMarkerForBounds):
1763         (AccessibilityUIElement::startTextMarkerForBounds):
1764         (AccessibilityUIElement::textMarkerForPoint):
1765         (AccessibilityUIElement::accessibilityElementForTextMarker):
1766         (AccessibilityUIElement::startTextMarker):
1767         (AccessibilityUIElement::endTextMarker):
1768         (AccessibilityUIElement::supportedActions):
1769         (AccessibilityUIElement::mathPostscriptsDescription):
1770         (AccessibilityUIElement::mathPrescriptsDescription):
1771         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1772         (WTR::AccessibilityController::accessibleElementById):
1773         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1774         (WTR::AccessibilityUIElement::startTextMarker):
1775         (WTR::AccessibilityUIElement::endTextMarker):
1776         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1777         (WTR::findAccessibleObjectById):
1778         (WTR::AccessibilityController::accessibleElementById):
1779         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1780         (WTR::AccessibilityUIElement::childAtIndex):
1781         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1782         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1783         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1784         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1785         (WTR::AccessibilityUIElement::rowAtIndex):
1786         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1787         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1788         (WTR::AccessibilityUIElement::titleUIElement):
1789         (WTR::AccessibilityUIElement::parentElement):
1790         (WTR::AccessibilityUIElement::disclosedByRow):
1791         (WTR::AccessibilityUIElement::stringAttributeValue):
1792         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1793         (WTR::AccessibilityUIElement::role):
1794         (WTR::AccessibilityUIElement::subrole):
1795         (WTR::AccessibilityUIElement::roleDescription):
1796         (WTR::AccessibilityUIElement::title):
1797         (WTR::AccessibilityUIElement::description):
1798         (WTR::AccessibilityUIElement::orientation):
1799         (WTR::AccessibilityUIElement::stringValue):
1800         (WTR::AccessibilityUIElement::language):
1801         (WTR::AccessibilityUIElement::helpText):
1802         (WTR::AccessibilityUIElement::valueDescription):
1803         (WTR::AccessibilityUIElement::classList):
1804         (WTR::AccessibilityUIElement::speak):
1805         (WTR::AccessibilityUIElement::ariaDropEffects):
1806         (WTR::AccessibilityUIElement::rangeForLine):
1807         (WTR::AccessibilityUIElement::rangeForPosition):
1808         (WTR::AccessibilityUIElement::boundsForRange):
1809         (WTR::AccessibilityUIElement::stringForRange):
1810         (WTR::AccessibilityUIElement::attributedStringForRange):
1811         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1812         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1813         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1814         (WTR::AccessibilityUIElement::attributesOfColumns):
1815         (WTR::AccessibilityUIElement::attributesOfRows):
1816         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1817         (WTR::AccessibilityUIElement::attributesOfHeader):
1818         (WTR::AccessibilityUIElement::rowIndexRange):
1819         (WTR::AccessibilityUIElement::columnIndexRange):
1820         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1821         (WTR::AccessibilityUIElement::horizontalScrollbar):
1822         (WTR::AccessibilityUIElement::verticalScrollbar):
1823         (WTR::AccessibilityUIElement::selectedTextRange):
1824         (WTR::AccessibilityUIElement::url):
1825         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1826         (WTR::AccessibilityUIElement::previousTextMarker):
1827         (WTR::AccessibilityUIElement::nextTextMarker):
1828         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1829         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1830         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1831         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1832         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1833         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1834         (WTR::AccessibilityUIElement::textMarkerForPoint):
1835         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1836         (WTR::AccessibilityUIElement::textMarkerForIndex):
1837         (WTR::AccessibilityUIElement::startTextMarker):
1838         (WTR::AccessibilityUIElement::endTextMarker):
1839         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1840         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1841         (WTR::AccessibilityUIElement::pathDescription):
1842         (WTR::AccessibilityUIElement::supportedActions):
1843
1844 2013-11-05  László Langó  <laszlo.lango@frontendart.com>
1845
1846         Remove leftover Qt related things from the flakiness_dashboard
1847         https://bugs.webkit.org/show_bug.cgi?id=123800
1848
1849         Reviewed by Anders Carlsson.
1850
1851         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1852         (test):
1853
1854 2013-11-05  Robert Plociennik  <r.plociennik@samsung.com>
1855
1856         [EFL] accessibility/svg-group-element-with-title.html is failing
1857         https://bugs.webkit.org/show_bug.cgi?id=114151
1858
1859         Reviewed by Mario Sanchez Prada.
1860
1861         atk_component_ref_accessible_at_point(), utilized in
1862         AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
1863         accessible child, if one exists, at the coordinate point specified' and not
1864         explicitly return self in case of lack of child elements. This contradicts with
1865         expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
1866         changed to return self regardless of coordinates specified, provided no child
1867         element could be retrieved, effectively mimicing the behaviour of equivalent
1868         Mac implementation in accessibilityHitTest().
1869
1870         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1871         (AccessibilityUIElement::elementAtPoint): Fixed.
1872         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1873         (WTR::AccessibilityUIElement::elementAtPoint): Fixed.
1874
1875 2013-11-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1876
1877         [CSS] Enable css-image-orientation on EFL and GTK ports.
1878         https://bugs.webkit.org/show_bug.cgi?id=123698
1879
1880         Reviewed by Beth Dakin.
1881
1882         r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
1883         when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
1884         and GTK ports by default.
1885
1886         * Scripts/webkitperl/FeatureList.pm:
1887
1888 2013-11-04  Alexey Proskuryakov  <ap@apple.com>
1889
1890         DumpRenderTree should reset its preferences file on launch
1891         https://bugs.webkit.org/show_bug.cgi?id=29751
1892
1893         Reviewed by Dan Bernstein.
1894
1895         Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
1896         and CFPreferencesCopyAppValue family of functions, it doesn't work with
1897         CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
1898
1899         So, now we'll just set defaults in the current application.
1900
1901         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1902         - Delete the defaults.
1903         - Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
1904         - The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
1905
1906         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
1907         Switched to -setValuesForKeysWithDictionary for consistency.
1908
1909 2013-11-04  Filip Pizlo  <fpizlo@apple.com>
1910
1911         Running FTL tests shouldn't reduce coverage on DFG tests
1912         https://bugs.webkit.org/show_bug.cgi?id=123780
1913
1914         Reviewed by Geoffrey Garen.
1915
1916         * Scripts/run-jsc-stress-tests:
1917
1918 2013-11-04  Anders Carlsson  <andersca@apple.com>
1919
1920         More WKRemoteObjectRegistry work
1921         https://bugs.webkit.org/show_bug.cgi?id=123754
1922
1923         Reviewed by Dan Bernstein.
1924
1925         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1926         (TestWebKitAPI::TEST):
1927         Use the correct bundle test name. Call Util::run.
1928
1929         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1930         (-[BundleObject sayHello]):
1931         (-[BundleObject testMethodWithString:double:integer:]):
1932         Add BundleObject implementation. Register the bundle object with
1933         the remote object registry. Call _handleMessageWithName:body: on the incoming message.
1934
1935 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
1936
1937         [EFL] Change ATK version to 2.10.0
1938         https://bugs.webkit.org/show_bug.cgi?id=123727
1939
1940         Reviewed by Mario Sanchez Prada.
1941
1942         Provided new API to retrieve text at a given offset.
1943
1944         * efl/jhbuild.modules:
1945
1946 2013-11-04  Robert Plociennik  <r.plociennik@samsung.com>
1947
1948         [EFL] accessibility/textarea-line-for-index.html is failing
1949         https://bugs.webkit.org/show_bug.cgi?id=112015
1950
1951         Reviewed by Mario Sanchez Prada.
1952
1953         Provided implementation for AccessibilityUIElement::lineForIndex().
1954
1955         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1956         (AccessibilityUIElement::lineForIndex): Implemented.
1957         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1958         (WTR::AccessibilityUIElement::lineForIndex): Implemented.
1959
1960 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
1961
1962         [EFL] accessibility/button-press-action.html
1963         https://bugs.webkit.org/show_bug.cgi?id=111993
1964
1965         Reviewed by Mario Sanchez Prada.
1966
1967         Provided an implementation for AccessibilityUIElement::isPressActionSupported.
1968
1969         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1970         (AccessibilityUIElement::isPressActionSupported):
1971         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1972         (WTR::AccessibilityUIElement::isPressActionSupported):
1973
1974 2013-11-03  Patrick Gansterer  <paroga@webkit.org>
1975
1976         Add test for ListHashSet::removeLast()
1977         https://bugs.webkit.org/show_bug.cgi?id=121810
1978
1979         Reviewed by Anders Carlsson.
1980
1981         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1982         (TestWebKitAPI::TEST):
1983
1984 2013-11-02  Filip Pizlo  <fpizlo@apple.com>
1985
1986         LLVM assertion failures should funnel into WTF's crash handling
1987         https://bugs.webkit.org/show_bug.cgi?id=123682
1988
1989         Reviewed by Geoffrey Garen.
1990         
1991         Need to disable LLVM's crash overrides so that we can do our own crash overrides.
1992
1993         * Scripts/configure-llvm:
1994
1995 2013-11-01  Andy Estes  <aestes@apple.com>
1996
1997         Teach check-for-webkit-framework-include-consistency to ignore stale iOS Private headers that might exist in build directories due to r158443
1998         https://bugs.webkit.org/show_bug.cgi?id=123636
1999
2000         Reviewed by Andreas Kling.
2001
2002         * Scripts/check-for-webkit-framework-include-consistency:
2003
2004 2013-11-01  Anders Carlsson  <andersca@apple.com>
2005
2006         Begin work on encoding argument types
2007         https://bugs.webkit.org/show_bug.cgi?id=123631
2008
2009         Reviewed by Dan Bernstein.
2010
2011         Add another test method.
2012
2013         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2014         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
2015
2016 2013-11-01  Afonso R. Costa Jr.  <afonso.costa@samsung.com>
2017
2018         Expose setApplicationCacheOriginQuota via window.internals
2019         https://bugs.webkit.org/show_bug.cgi?id=87838
2020
2021         Reviewed by Joseph Pecoraro.
2022
2023         * DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota
2024         to window.internals
2025         (TestRunner::staticFunctions):
2026         * DumpRenderTree/TestRunner.h: Ditto.
2027         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
2028         * DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
2029         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
2030         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
2031         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2032         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
2033         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
2034         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2035
2036 2013-10-31  Mark Lam  <mark.lam@apple.com>
2037
2038         REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
2039         https://bugs.webkit.org/show_bug.cgi?id=123383.
2040
2041         Reviewed by Geoffrey Garen.
2042
2043         Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
2044         added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
2045         tests to set appropriate quota settings to exercise quota expansion tests
2046         when needed.
2047
2048         * DumpRenderTree/TestRunner.cpp:
2049         (TestRunner::TestRunner):
2050         (getDatabaseDefaultQuotaCallback):
2051         (getDatabaseMaxQuotaCallback):
2052         (setDatabaseDefaultQuotaCallback):
2053         (setDatabaseMaxQuotaCallback):
2054         (TestRunner::staticValues):
2055         * DumpRenderTree/TestRunner.h:
2056         (TestRunner::databaseDefaultQuota):
2057         (TestRunner::setDatabaseDefaultQuota):
2058         (TestRunner::databaseMaxQuota):
2059         (TestRunner::setDatabaseMaxQuota):
2060         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2061         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
2062         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2063         (onExceededDatabaseQuota):
2064         * DumpRenderTree/mac/UIDelegate.mm:
2065         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2066         * DumpRenderTree/win/UIDelegate.cpp:
2067         (UIDelegate::exceededDatabaseQuota):
2068         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2070         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
2071         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2072         (WTR::TestRunner::TestRunner):
2073         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2074         (WTR::TestRunner::databaseDefaultQuota):
2075         (WTR::TestRunner::setDatabaseDefaultQuota):
2076         (WTR::TestRunner::databaseMaxQuota):
2077         (WTR::TestRunner::setDatabaseMaxQuota):
2078         * WebKitTestRunner/TestController.cpp:
2079         (WTR::TestController::createOtherPage):
2080         (WTR::TestController::createWebViewWithOptions):
2081
2082 2013-10-31  Anders Carlsson  <andersca@apple.com>
2083
2084         Add a WKRemoteObject class
2085         https://bugs.webkit.org/show_bug.cgi?id=123586
2086
2087         Reviewed by Dan Bernstein.
2088
2089         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2090         (TestWebKitAPI::TEST):
2091         Add a conformsToProtocol: test.
2092
2093 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
2094
2095         build.webkit.org should have a clean build button
2096         https://bugs.webkit.org/show_bug.cgi?id=123559
2097
2098         Reviewed by Darin Adler.
2099
2100         Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
2101         step executes clean-build script that removes the WebKitBuild directory.
2102
2103         Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.
2104
2105         * BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
2106         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2107         (CleanBuildIfScheduled): Added.
2108         (CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
2109         the clean build scheduler.
2110         (DeleteStaleBuildFiles): Added.
2111         (DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
2112         the clean build scheduler since everything in the WebKitBuild directory had already been removed.
2113         (Factory.__init__): Always add CleanBuildIfScheduled.  The step itself checks whether to run
2114         clean-build script or hide itself.
2115         (loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
2116         versions of buildbot, builderNames needs to be a list of regular strings.
2117         * BuildSlaveSupport/clean-build: Added.
2118
2119 2013-10-31  Filip Pizlo  <fpizlo@apple.com>
2120
2121         Remove CachedTranscendentalFunction because caching math functions is an ugly idea
2122         https://bugs.webkit.org/show_bug.cgi?id=123574
2123
2124         Reviewed by Mark Hahnenberg.
2125
2126         Make it easier to see that a test doesn't have an -expected file.
2127
2128         * Scripts/run-jsc-stress-tests:
2129
2130 2013-10-31  Tamas Gergely  <gertom@inf.u-szeged.hu>
2131
2132         Run tests as if they are expected to pass when --force is given.
2133         https://bugs.webkit.org/show_bug.cgi?id=112890
2134
2135         Reviewed by Ryosuke Niwa.
2136
2137         The --force switch of new-run-webkit-tests is now forces all tests to
2138         be run with 'PASS' as expected result.
2139
2140         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2141         (Manager.run):
2142         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2143         (TestExpectations.__init__):
2144         (TestExpectations._add_expectations):
2145         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2146         (parse_args):
2147         (_set_up_derived_options):
2148
2149 2013-10-31  Geoffrey Garen  <ggaren@apple.com>
2150
2151         Added Mark Lam as a reviewer.
2152
2153         Unreviewed.
2154
2155         * Scripts/webkitpy/common/config/contributors.json:
2156
2157 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2158
2159         Teach the style checker about ENUM_CLASS
2160         https://bugs.webkit.org/show_bug.cgi?id=123528
2161
2162         Reviewed by Andy Estes.
2163
2164         * Scripts/webkitpy/style/checkers/cpp.py:
2165         (_EnumState.process_clean_line): Make content of an ENUM_CLASS declaration
2166         equivalent to enum content for checking.
2167         (check_braces): Allow semicolon at the end.
2168
2169         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2170         (NoNonVirtualDestructorsTest.test_enum_casing):
2171         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon):
2172         (WebKitStyleTest.test_braces):
2173         Test it.
2174
2175 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
2176
2177         kill-old-processes should kill Web Socket script
2178         https://bugs.webkit.org/show_bug.cgi?id=123546
2179
2180         Reviewed by Benjamin Poulain.
2181
2182         * BuildSlaveSupport/kill-old-processes:
2183         (main):
2184
2185 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2186
2187         Set svn:ignore for .pyc files created for test-webkitpy.
2188
2189         * Scripts/webkitpy/layout_tests/reftests: Added property svn:ignore.
2190         * Scripts/webkitpy/performance_tests: Added property svn:ignore.
2191         * Scripts/webkitpy/to_be_moved: Added property svn:ignore.
2192         * Scripts/webkitpy/w3c: Added property svn:ignore.
2193
2194 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2195
2196         85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode()
2197         when there is a stale WebKitTestRunner preference
2198         https://bugs.webkit.org/show_bug.cgi?id=115115
2199
2200         Reviewed by Darin Adler.
2201
2202         Delete stale preferences on launch.
2203
2204         * WebKitTestRunner/TestController.h:
2205         * WebKitTestRunner/TestController.cpp:
2206         (WTR::TestController::initialize): Now that we don't have preferences stored from
2207         the previous run, we need th reinstate them before creating a WKView. Not all preferences
2208         can be applied to an existing view retroactively.
2209         (WTR::TestController::resetPreferencesToConsistentValues): Split out of resetStateToConsistentValues,
2210         because there is no injected bundle yet when calling this function from initialize().
2211
2212         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Delete
2213         the preferences.
2214
2215         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2216         Added some FIXMEs.
2217
2218 2013-10-30  Anders Carlsson  <andersca@apple.com>
2219
2220         Try to fix the 32-bit build.
2221         
2222         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2223         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
2224
2225 2013-10-30  Anders Carlsson  <andersca@apple.com>
2226
2227         Begin fleshing out an API test for WKRemoteObjectRegistry
2228         https://bugs.webkit.org/show_bug.cgi?id=123531
2229
2230         Reviewed by Andreas Kling.
2231
2232         Add a very simple test that doesn't really test anything for now.
2233
2234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2235         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Added.
2236         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Added.
2237         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Added.
2238
2239 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
2240
2241         Remove unnecessary touch
2242
2243         Rubber stamped by Mark Hahnenberg.
2244
2245         * Scripts/run-jsc-stress-tests:
2246
2247 2013-10-30  Samuel White  <samuel_white@apple.com>
2248
2249         AX: Add samuel_white@apple.com to accessibility watchlist cc rules
2250         https://bugs.webkit.org/show_bug.cgi?id=123515
2251
2252         Reviewed by Chris Fleizach.
2253
2254         Adding myself and jcraig@apple.com (per his request) to the accessibility watchlist. Also
2255         updating contributors.json with permission from bweinstein@apple.com to make this possible.
2256
2257         * Scripts/webkitpy/common/config/contributors.json:
2258         * Scripts/webkitpy/common/config/watchlist:
2259
2260 2013-10-30  Patrick Gansterer  <paroga@webkit.org>
2261
2262         [WIN] Add executable entry points to DRT and WinLauncher
2263         https://bugs.webkit.org/show_bug.cgi?id=121837
2264
2265         Reviewed by Brent Fulgham.
2266
2267         This allows to compile and run the executables without DLLLauncher.
2268
2269         * DumpRenderTree/win/DumpRenderTree.cpp:
2270         (main):
2271         (dllLauncherEntryPoint):
2272         * WinLauncher/WinLauncher.cpp:
2273         (wWinMain):
2274         (dllLauncherEntryPoint):
2275
2276 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
2277
2278         run-jsc-stress-tests should handle ".." in paths and "slow!" in cmd's
2279         https://bugs.webkit.org/show_bug.cgi?id=123521
2280
2281         Reviewed by Mark Hahnenberg.
2282
2283         * Scripts/run-jsc-stress-tests:
2284
2285 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2286
2287         Mavericks: 128 tests are failing due to pixel differences
2288         https://bugs.webkit.org/show_bug.cgi?id=123488
2289
2290         Reviewed by Simon Fraser.
2291
2292         Apple font preferences cannot be fully reset after they've been read, so we
2293         need to set them using CFPreferences before initializing NSApplication.
2294
2295         In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
2296         appear to be. I guess we can figure out the reasons for this difference when/if
2297         any observable problems start to occur.
2298
2299         * DumpRenderTree/mac/DumpRenderTree.mm:
2300         (setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
2301         to prepareConsistentTestingEnvironment().
2302         (main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
2303         (which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
2304         useful to keep in case we change out approach to defaults again).
2305
2306 2013-10-29  Andy Estes  <aestes@apple.com>
2307
2308         Teach the style checker how to handle Objective-C categories and NS_ENUM
2309         https://bugs.webkit.org/show_bug.cgi?id=123482
2310
2311         Reviewed by Dan Bernstein.
2312
2313         * Scripts/webkitpy/style/checkers/cpp.py:
2314         (check_spacing_for_function_call): Allow a space before '(' in a line
2315         starting with @interface or @implementation, since this is defining an
2316         Objective-C category rather than a function.
2317         (check_braces): The opening brace of an NS_ENUM should not be on its
2318         own line.
2319         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests.
2320
2321 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
2322
2323         [EFL] accessibility/textarea-selected-text-range.html is failing
2324         https://bugs.webkit.org/show_bug.cgi?id=112016
2325
2326         Reviewed by Mario Sanchez Prada.
2327
2328         Provided implementation for AccessibilityUIElement::selectedTextRange() and
2329         AccessibilityUIElement::setSelectedTextRange().
2330
2331         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2332         (AccessibilityUIElement::selectedTextRange): Implemented.
2333         (AccessibilityUIElement::setSelectedTextRange): Implemented
2334         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2335         (WTR::AccessibilityUIElement::selectedTextRange): Implemented.
2336         (WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.
2337
2338 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
2339
2340         [GTK] accessibility/svg-remote-element.html is failing
2341         https://bugs.webkit.org/show_bug.cgi?id=101185
2342
2343         Reviewed by Chris Fleizach.
2344
2345         Implemented missing methods by mimicing existing functionality in
2346         AccessibilityObject::clickPoint() using available ATK API.
2347
2348         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2349         (AccessibilityUIElement::clickPointX): Implemented.
2350         (AccessibilityUIElement::clickPointY): Implemented.
2351         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2352         (WTR::AccessibilityUIElement::clickPointX): Implemented.
2353         (WTR::AccessibilityUIElement::clickPointY): Implemented.
2354
2355 2013-10-30  Tamas Gergely  <gertom@inf.u-szeged.hu>
2356
2357         Removed Windows platform configurations from WebKitTestRunner.
2358         https://bugs.webkit.org/show_bug.cgi?id=123152
2359
2360         Reviewed by Csaba Osztrogonác.
2361
2362         Removed Windows specific parts from the source files, Windows specific
2363         subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
2364         as the platform is no longer supported by this tool.
2365
2366         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
2367         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
2368         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
2369         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
2370         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
2371         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
2372         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2373         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2374         (WTR::AccessibilityController::rootElement):
2375         (WTR::AccessibilityController::focusedElement):
2376         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2377         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2378         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2379         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2380         * WebKitTestRunner/PlatformWebView.h:
2381         * WebKitTestRunner/TestController.cpp:
2382         (WTR::TestController::initialize):
2383         * WebKitTestRunner/TestInvocation.cpp:
2384         (WTR::createWKURL):
2385         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2386         * WebKitTestRunner/config.h:
2387         * WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
2388         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
2389         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
2390         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
2391         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
2392         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
2393         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
2394         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
2395         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
2396         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
2397         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
2398         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
2399         * WebKitTestRunner/win/TestControllerWin.cpp: Removed.
2400         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
2401         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
2402         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
2403         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
2404         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
2405         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
2406         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
2407         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
2408         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
2409         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
2410         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
2411         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
2412         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
2413         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
2414         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
2415         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
2416         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
2417         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
2418         * WebKitTestRunner/win/build-generated-files.sh: Removed.
2419         * WebKitTestRunner/win/main.cpp: Removed.
2420
2421 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
2422
2423         Result of focus-option-control-on-page.html depends on system preferences
2424         https://bugs.webkit.org/show_bug.cgi?id=123304
2425
2426         Reviewed by Simon Fraser.
2427
2428         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2429         Override a preference that WebKit reads to decide what Tab does, so that current
2430         user default doesn't affect tests.
2431
2432         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
2433         Ditto.
2434
2435 2013-10-29  Filip Pizlo  <fpizlo@apple.com>
2436
2437         It should be possible to specify extra tests to run-javascriptcore-tests
2438         https://bugs.webkit.org/show_bug.cgi?id=123495
2439
2440         Reviewed by Oliver Hunt.
2441         
2442         This adds two ways to specify additional tests: the option --extra-tests=<blah>, and
2443         the environment variable EXTRA_JSC_TESTS.
2444         
2445         Those two values (the command-line option and the environment variable) are passed
2446         as extra arguments to run-jsc-stress-tests.
2447         
2448         To make this extra super useful, run-jsc-stress-tests now allows yaml configuration
2449         files to be recursive: if a "- collection:" line is found, the string is handled
2450         just as if it was a command-line argument. This allows you to use --extra-tests=file
2451         where file contains a bunch of "- collection:" lines, and this is equivalent to each
2452         of those lines being a command-line argument.
2453
2454         * Scripts/run-javascriptcore-tests:
2455         * Scripts/run-jsc-stress-tests:
2456
2457 2013-10-29  Ryosuke Niwa  <rniwa@webkit.org>
2458
2459         Add Mavericks builders to the old flakiness dashboard.
2460
2461         * TestResultServer/static-dashboards/builders.jsonp:
2462         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2463
2464 2013-10-29  Seokju Kwon  <seokju@webkit.org>
2465
2466         Fix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
2467         https://bugs.webkit.org/show_bug.cgi?id=123478
2468
2469         Reviewed by Anders Carlsson.
2470
2471         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2472         (NPP_Destroy): Add a missing free() for 'obj->evaluateScriptOnMouseDownOrKeyDown'.
2473
2474 2013-10-29  Lucas Forschler  <lforschler@apple.com>
2475
2476         Move the SEO bots from testers to archivers.
2477         
2478         Unreviewed.
2479         
2480         * BuildSlaveSupport/build.webkit.org-config/config.json:
2481
2482 2013-10-29  Hugo Parente Lima  <hugo.lima@openbossa.org>
2483
2484         Adding Nix files in Source/Platform to trunk
2485         https://bugs.webkit.org/show_bug.cgi?id=118331
2486
2487         Reviewed by Benjamin Poulain.
2488
2489         Add a special rule for Nix API files located at Source/Platform/nix.
2490
2491         * Scripts/webkitpy/style/checker.py:
2492
2493  2013-10-29  Nadav Rotem  <nrotem@apple.com>
2494  
2495          Add myself as a comitter.
2496          https://bugs.webkit.org/show_bug.cgi?id=123455
2497  
2498          Reviewed by Anders Carlsson.
2499  
2500          * Scripts/webkitpy/common/config/contributors.json:
2501  
2502 2013-10-29  Lucas Forschler  <lforschler@apple.com>
2503
2504         Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
2505         https://bugs.webkit.org/show_bug.cgi?id=123450
2506
2507         Reviewed by Alexey Proskuryakov.
2508
2509         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2510         (RunWebKit2Tests.start):
2511
2512 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
2513
2514         [Mac] Rationalize user defaults override code
2515         https://bugs.webkit.org/show_bug.cgi?id=123436
2516
2517         Reviewed by Dan Bernstein.
2518
2519         * DumpRenderTree/mac/DumpRenderTree.mm:
2520         (resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
2521         because this function only resets WebPreferences now.
2522         (setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
2523         here, because tests never change them, and they only need to be set once, not
2524         before each test. Removed long obsolete workaround for HIToolbox preferences.
2525         Don't call resetWebPreferencesToConsistentValues, because it will be called before
2526         the first test anyway.
2527         (main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
2528         (resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
2529         and setlocale calls out of resetWebPreferencesToConsistentValues().
2530         Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
2531         also needed in WK1.
2532
2533         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2534         (WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
2535         dictionary.
2536
2537         * WebKitTestRunner/mac/main.mm:
2538         (setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
2539         use NSArgumentDomain for everything.
2540
2541 2013-10-29  Philippe Normand  <pnormand@igalia.com>
2542
2543         [GTK] enable media-stream in build-webkit
2544         https://bugs.webkit.org/show_bug.cgi?id=123144
2545
2546         Reviewed by Martin Robinson.
2547
2548         * Scripts/webkitperl/FeatureList.pm: Enable media-stream build
2549         for the GTK+ port.
2550
2551 2013-10-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2552
2553         EFL 32 bit buildbot doesn't work on dashboard
2554         https://bugs.webkit.org/show_bug.cgi?id=123435
2555
2556         Reviewed by Csaba Osztrogonác.
2557
2558         32 bit buildbot doesn't work on dashboard because name is different from buildbot list.
2559
2560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2561         (WebKitBuildbot):
2562
2563 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2564
2565         Floating left the header broke other pages, and this CSS has no way to customize
2566         per-page.
2567
2568         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2569
2570 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2571
2572         Remove underlines on the bot names in the header.
2573         
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2575         (td.LastBuild a):
2576
2577 2013-10-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2578
2579         Add EFL release bots to the buildbot dashboard
2580         https://bugs.webkit.org/show_bug.cgi?id=123430
2581
2582         Reviewed by Darin Adler.
2583
2584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
2585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2586         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2588         (table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.
2589
2590 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2591
2592         More waterfall tweaking.
2593
2594         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2595         (body > .header):
2596         (td.LastBuild):
2597         (td.LastBuild a):
2598         (td.LastBuild,td.Activity a,td.Change a,td.Builder a):
2599
2600 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2601
2602         More waterfall tweaking.
2603
2604         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2605         (body.interface):
2606         (body > hr):
2607         (div.content h1):
2608         (body > .header):
2609         (td.Activity a,td.Change a,td.Builder a):
2610         (td.Builder):
2611
2612 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2613
2614         Apply changes to default.css, revert buildbot.css which seems to be unused.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
2617         (body):
2618         (body, td):
2619         (a:link,a:visited,a:active):
2620         (td.Time):
2621         (td.Activity):
2622         (.exception, td.offline):
2623         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2624         (body.interface):
2625         (.auth):
2626         (td.LastBuild):
2627         (td.Time):
2628         (td.Activity):
2629         (.offline,td.offline,.retry):
2630
2631 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2632
2633         Prettify the waterfall page, and make it a little more space-efficient.
2634         
2635         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
2636         (body, td):
2637         (body.interface):
2638         (.auth):
2639         (.header):
2640         (div.content h1):
2641         (a):
2642         (a:link,a:active):
2643         (a:link,a:visited,a:active):
2644         (td.LastBuild):
2645         (td.Time):
2646         (td.Activity):
2647         (.exception, td.offline, .retry):
2648
2649 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2650
2651         Fix Lion readableName (spotted by Dan Bernstein).
2652
2653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2654
2655 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2656
2657         Add tooltips to the platform icons in Dashboard
2658         https://bugs.webkit.org/show_bug.cgi?id=123429
2659
2660         Reviewed by Alexey Proskuryakov.
2661         
2662         Add a human readable name to Buildbot.Platform entries, and use it to
2663         show a tooltip on the ring image.
2664
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2667         (documentReady):
2668
2669 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2670
2671         Allow explicit sort order for Dashboard platforms
2672         https://bugs.webkit.org/show_bug.cgi?id=123419
2673
2674         Reviewed by Tim Hatcher.
2675         
2676         Assign a specific sort order to Dashboard platforms, rather than
2677         just using object property order.
2678
2679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2681         (BuildbotQueue):
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2683         (documentReady):
2684
2685 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2686
2687         Tidy up main http://build.webkit.org page
2688         https://bugs.webkit.org/show_bug.cgi?id=123413
2689
2690         Reviewed by Alexey Proskuryakov.
2691         
2692         Break the list of links into sections. Add some font style.
2693
2694         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2695
2696 2013-10-28  Myles C. Maxfield  <mmaxfield@apple.com>
2697
2698         Parsing support for -webkit-text-decoration-skip: ink
2699         https://bugs.webkit.org/show_bug.cgi?id=123358
2700
2701         Reviewed by Dean Jackson.
2702
2703         Adding ENABLE(CSS3_TEXT_DECORATION)
2704
2705         * Scripts/webkitperl/FeatureList.pm:
2706
2707 2013-10-28  Lucas Forschler  <lforschler@apple.com>
2708
2709         Add additional Apple Mavericks test bots.
2710         
2711         Unreviewed.
2712         
2713         * BuildSlaveSupport/build.webkit.org-config/config.json:
2714
2715 2013-10-28  Bastien Nocera <hadess@hadess.net>
2716
2717         Name all the GLib timeout sources
2718         https://bugs.webkit.org/show_bug.cgi?id=123229
2719
2720         Reviewed by Anders Carlsson.
2721
2722         Give a name to GLib timeout sources, this is helpful when
2723         profiling WebKitGTK applications.
2724
2725 2013-10-28  Bastien Nocera <hadess@hadess.net>
2726
2727         Replace 0 timeouts g_timeout_add() by g_idle_add()
2728         https://bugs.webkit.org/show_bug.cgi?id=123260
2729
2730         Reviewed by Carlos Garcia Campos.
2731
2732         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
2733         without the nagging feeling that the wrong API was used.
2734
2735         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
2736         of 0-timer.
2737         (topLoadingFrameLoadFinished):
2738         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
2739         (scheduleAsynchronousClickCallback):
2740         (scheduleAsynchronousKeyDownCallback):
2741
2742 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
2743
2744         [GTK] [WebKit2] CanHandleRequest API test fails
2745         https://bugs.webkit.org/show_bug.cgi?id=88453
2746
2747         Reviewed by Martin Robinson.
2748
2749         * Scripts/run-gtk-tests:
2750         (TestRunner):
2751
2752 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
2753
2754         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
2755
2756         * Scripts/webkitpy/port/base.py:
2757         (Port.repository_paths):
2758
2759 2013-10-25  Jer Noble  <jer.noble@apple.com>
2760
2761         [WTF] Add a multiplication operator (and a few others) to MediaTime
2762         https://bugs.webkit.org/show_bug.cgi?id=123137
2763
2764         Reviewed by Eric Carlson.
2765
2766         Add tests for new MediaTime operators.
2767
2768         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2769         (TestWebKitAPI::TEST):
2770
2771 2013-10-24  Mark Rowe  <mrowe@apple.com>
2772
2773         Remove references to OS X 10.7 from Xcode configuration settings.
2774
2775         Now that we're not building for OS X 10.7 they're no longer needed.
2776
2777         Reviewed by Anders Carlsson.
2778
2779         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2780         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2781         * MiniBrowser/Configurations/Base.xcconfig:
2782         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2783         * TestWebKitAPI/Configurations/Base.xcconfig:
2784         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2785         * WebKitLauncher/Configurations/Base.xcconfig:
2786         * WebKitTestRunner/Configurations/Base.xcconfig:
2787         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2788
2789 2013-10-24  Mark Rowe  <mrowe@apple.com>
2790
2791         <rdar://problem/15312643> Prepare for the mysterious future.
2792
2793         Reviewed by David Kilzer.
2794
2795         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2796         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2797         * MiniBrowser/Configurations/Base.xcconfig:
2798         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2799         * TestWebKitAPI/Configurations/Base.xcconfig:
2800         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2801         * WebKitLauncher/Configurations/Base.xcconfig:
2802         * WebKitTestRunner/Configurations/Base.xcconfig:
2803         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2804
2805 2013-10-24  Daniel Bates  <dabates@apple.com>
2806
2807         Crash in WebCore::NavigationScheduler::startTimer()
2808         https://bugs.webkit.org/show_bug.cgi?id=123288
2809         <rdar://problem/14055644>
2810
2811         Reviewed by Alexey Proskuryakov.
2812
2813         Add API test.
2814
2815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2816         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
2817         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
2818
2819 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2820
2821         [GTK] Disable css-image-orientation
2822         https://bugs.webkit.org/show_bug.cgi?id=123257
2823
2824         Reviewed by Martin Robinson.
2825
2826         CSS image orientation isn't stable yet. So, test regression happen since r157909.
2827         This feature should be enabled again after it is stable.
2828
2829         * Scripts/webkitperl/FeatureList.pm:
2830
2831 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2832
2833         Fix argument passing for jhbuild.
2834         https://bugs.webkit.org/show_bug.cgi?id=123253
2835
2836         Reviewed by Gustavo Noronha Silva.
2837
2838         The update-webkit-libs-jhbuild previously didn't allowed
2839         extra arguments to be passed to jhbuild.
2840
2841         * Scripts/update-webkit-libs-jhbuild:
2842         (runJhbuild):
2843         * Scripts/update-webkitefl-libs:
2844
2845 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
2846
2847         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
2848         https://bugs.webkit.org/show_bug.cgi?id=123251
2849
2850         Reviewed by Csaba Osztrogonác.
2851
2852         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
2853         compilation warning on 64-Bit.
2854
2855         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2856         (onExceededDatabaseQuota):
2857
2858 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
2859
2860         [EFL] Build break with latest EFL 1.8 libraries.
2861         https://bugs.webkit.org/show_bug.cgi?id=123245
2862
2863         Reviewed by Gyuyoung Kim.
2864
2865         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
2866         Eo typedef and splitted header files which contain version macro.
2867
2868         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
2869         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2870         * WebKitTestRunner/PlatformWebView.h: Ditto.
2871
2872 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2873
2874         [GObject bindings] Make EventTarget interface introspectable
2875         https://bugs.webkit.org/show_bug.cgi?id=77835
2876
2877         Reviewed by Gustavo Noronha Silva.
2878
2879         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
2880         GObject DOM bindings headers.
2881
2882 2013-10-23  Lucas Forschler  <lforschler@apple.com>
2883
2884         Add two more mac bots to the Mavericks Test Queue.
2885         
2886         Unreviewed.
2887         
2888         * BuildSlaveSupport/build.webkit.org-config/config.json:
2889
2890 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
2891
2892         Have a way of dealing with slow tests in run-jsc-stress-tests
2893         https://bugs.webkit.org/show_bug.cgi?id=123221
2894
2895         Reviewed by Mark Hahnenberg.
2896         
2897         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
2898         rather than appended to it. This means that slow tests get queued up first and are less likely
2899         to block completion.
2900
2901         * Scripts/run-jsc-stress-tests:
2902
2903 2013-10-23  Alex Christensen  <achristensen@webkit.org>
2904
2905         Explicitly build Win32 or x64 configuration on Windows.
2906         https://bugs.webkit.org/show_bug.cgi?id=123206
2907
2908         Reviewed by Brent Fulgham.
2909
2910         * Scripts/webkitdirs.pm:
2911         (jscPath):
2912         (determineConfigurationForVisualStudio):
2913         (determinePassedConfiguration):
2914         Add |Win32 to the end of 32-bit Visual Studio build configurations.
2915         (safariPath):
2916         * Scripts/build-webkit:
2917         * Scripts/old-run-webkit-tests:
2918         * Scripts/run-api-tests:
2919         (testToolPath):
2920         * Scripts/run-javascriptcore-tests:
2921         (testapiPath):
2922         * Scripts/run-regexp-tests:
2923         (testapiPath):
2924         * Scripts/sunspider-compare-results:
2925         (pathToBuiltJSC):
2926         Use configuration instead of configurationForVisualStudio, which are now always different.
2927
2928 2013-10-23  Mark Lam  <mark.lam@apple.com>
2929
2930         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
2931         https://bugs.webkit.org/show_bug.cgi?id=123131.
2932
2933         Reviewed by Geoffrey Garen.
2934
2935         Updated these files to allow database quotas to grow within a limit for
2936         testing purposes.
2937
2938         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2939         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
2940         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2941         (onExceededDatabaseQuota):
2942         * DumpRenderTree/mac/UIDelegate.mm:
2943         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2944         * DumpRenderTree/win/UIDelegate.cpp:
2945         (UIDelegate::exceededDatabaseQuota):
2946         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2947         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
2948         * WebKitTestRunner/TestController.cpp:
2949         (WTR::exceededDatabaseQuota):
2950
2951 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
2952
2953         It's valid to have a build ID of 0.
2954
2955         Reviewed by Tim Hatcher.
2956
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2958         (BuildbotIteration):
2959
2960 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
2961
2962         Remove Lion bots from the Dashboard.
2963
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2965         (WebKitBuildbot):
2966
2967 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
2968
2969         [GTK] Expose image links properly
2970         https://bugs.webkit.org/show_bug.cgi?id=84044
2971
2972         Reviewed by Chris Fleizach.
2973
2974         Expose the accessible URL if present, as yet another attribute
2975         for the AccessibilityUIElement wrapper. For coherence with what
2976         the Mac port does (and what you would expect as the output of
2977         the layout test), we strip the absolute URL path for relative
2978         references, if it's the case, leaving the base of the URL path
2979         out of the exposed string.
2980
2981         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2982         (attributesOfElement): Print the AXURL, if available.
2983         (AccessibilityUIElement::url): Expose the URL if present. That
2984         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
2985         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2986         (attributesOfElement): Print the AXURL, if available.
2987         (WTR::AccessibilityUIElement::url): Expose the URL if present.
2988         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
2989
2990 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
2991
2992         Remove Lion bots.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/config.json:
2995
2996 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
2997
2998         Dashboard repaints constantly
2999         https://bugs.webkit.org/show_bug.cgi?id=122133
3000
3001         Reviewed by Tim Horton.
3002         
3003         Pulsing shadows are really bad for battery life.
3004
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3006         (.status-line.bad .bubble):
3007         (.status-line.bad .message):
3008
3009 2013-10-22  Commit Queue  <commit-queue@webkit.org>
3010
3011         Unreviewed, rolling out r157835.
3012         http://trac.webkit.org/changeset/157835
3013         https://bugs.webkit.org/show_bug.cgi?id=123192
3014
3015         broke 32-bit builds (Requested by smfr on #webkit).
3016
3017         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3018         (TestWebKitAPI::TEST):
3019
3020 2013-10-22  Jer Noble  <jer.noble@apple.com>
3021
3022         [WTF] Add a multiplication operator (and a few others) to MediaTime
3023         https://bugs.webkit.org/show_bug.cgi?id=123137
3024
3025         Reviewed by Eric Carlson.
3026
3027         Add tests for new MediaTime operators.
3028
3029         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3030         (TestWebKitAPI::TEST):
3031
3032 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
3033
3034         Educate webkitpy about Mavericks.
3035
3036         Reviewed by Ryosuke Niwa.
3037
3038         * Scripts/webkitpy/common/system/platforminfo.py:
3039         (PlatformInfo._determine_mac_version):
3040         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3041         (TestPlatformInfo.test_os_version):
3042         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3043         (TestExpectationParser):
3044         * Scripts/webkitpy/port/builders.py:
3045         * Scripts/webkitpy/port/mac.py:
3046         (MacPort):
3047         * Scripts/webkitpy/port/mac_unittest.py:
3048         (test_versions):
3049         (test_baseline_search_path):
3050         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3051         (TestRebaselineTest.test_baseline_directory):
3052         (TestRebaselineExpectations.test_rebaseline_expectations):
3053
3054 2013-10-22  Stephanie Lewis  <slewis@apple.com>
3055
3056         Update the build trigger list for Mavericks.
3057
3058         Unreviewed.
3059
3060         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3061         (_should_file_trigger_build):
3062
3063 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
3064
3065         Add Mavericks bots to the dashboard.
3066
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3068         (WebKitBuildbot):
3069
3070 2013-10-22  Samuel White  <samuel_white@apple.com>
3071
3072         AX: Add paramAttrs to fetch start and end text markers in a given rect.
3073         https://bugs.webkit.org/show_bug.cgi?id=122164
3074
3075         Reviewed by Chris Fleizach.
3076
3077         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
3078
3079         * DumpRenderTree/AccessibilityUIElement.cpp:
3080         (endTextMarkerForBoundsCallback):
3081         (startTextMarkerForBoundsCallback):
3082         (AccessibilityUIElement::endTextMarkerForBounds):
3083         (AccessibilityUIElement::startTextMarkerForBounds):
3084         (AccessibilityUIElement::getJSClass):
3085         * DumpRenderTree/AccessibilityUIElement.h:
3086         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3087         (AccessibilityUIElement::endTextMarkerForBounds):
3088         (AccessibilityUIElement::startTextMarkerForBounds):
3089         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3090         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3091         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3092         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3093         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3094         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3095         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3096         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3097         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3098         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3099         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3100
3101 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
3102
3103         There should be a way to specify additional repository paths in NRWT
3104         https://bugs.webkit.org/show_bug.cgi?id=123135
3105
3106         Reviewed by Alexey Proskuryakov.
3107
3108         Added --additional-repository-name and --additional-repository-path options to NRWT.
3109         These options allow us to submit addtional repository information, such as of Safari's
3110         to the new flakiness dashboard.
3111
3112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3113         (parse_args):
3114         * Scripts/webkitpy/port/base.py:
3115         (Port.repository_paths):
3116
3117 2013-10-22  Commit Queue  <commit-queue@webkit.org>
3118
3119         Unreviewed, rolling out r157774.
3120         http://trac.webkit.org/changeset/157774
3121         https://bugs.webkit.org/show_bug.cgi?id=123167
3122
3123         causes python test to fail (Requested by smfr on #webkit).
3124
3125         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3126         (Manager.run):
3127         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3128         (TestExpectations.__init__):
3129         (TestExpectations._add_expectations):
3130         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3131         (parse_args):
3132         (_set_up_derived_options):
3133
3134 2013-10-22  Lucas Forschler  <lforschler@apple.com>
3135
3136         Prepare WebKit Buildbot master for Mavericks.
3137         This adds the following bot configurations:
3138             Mavericks Release/Debug builders
3139             Mavericks Release/Debug WK1 Testers
3140             Mavericks Release/Debug WK2 Testers
3141
3142         Unreviewed.
3143         
3144         * BuildSlaveSupport/build.webkit.org-config/config.json:
3145
3146 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
3147
3148         Run tests as if they are expected to pass when --force is given.
3149         https://bugs.webkit.org/show_bug.cgi?id=112890
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         The --force switch of new-run-webkit-tests is now forces all tests to
3154         be run with 'PASS' as expected result.
3155
3156         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3157         (Manager.run):
3158         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3159         (TestExpectations.__init__):
3160         (TestExpectations._add_expectations):
3161         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3162         (parse_args):
3163         (_set_up_derived_options):
3164
3165 2013-10-21  Mark Rowe  <mrowe@apple.com>
3166
3167         Add a version of WebKitSystemInterface for Mavericks.
3168
3169         Reviewed by Ryosuke Niwa.
3170
3171         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3172         * Scripts/copy-webkitlibraries-to-product-directory:
3173         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3174
3175 2013-10-21  Anders Carlsson  <andersca@apple.com>
3176
3177         Navigation policy callback not called when performing the same fragment navigation twice
3178         https://bugs.webkit.org/show_bug.cgi?id=123121
3179         <rdar://problem/15230466>
3180
3181         Reviewed by Beth Dakin.
3182
3183         Add a test.
3184
3185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3186         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
3187         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
3188         (+[WebKit1FragmentNavigationTestDelegate shared]):
3189         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3190         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3191         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
3192         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
3193         (TestWebKitAPI::TEST):
3194
3195 2013-10-21  Dan Bernstein  <mitz@apple.com>
3196
3197         Style checker should allow a space after the @property keyword
3198         https://bugs.webkit.org/show_bug.cgi?id=123117
3199
3200         Reviewed by Anders Carlsson.
3201
3202         * Scripts/webkitpy/style/checkers/cpp.py:
3203         (check_spacing_for_function_call): Allow a space between @property and the following (
3204         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3205         (CppStyleTest.test_spacing_for_fncall): Added a test case.
3206
3207 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
3208
3209         [WinCairo] Build does not start.
3210         https://bugs.webkit.org/show_bug.cgi?id=123059
3211
3212         Reviewed by Csaba Osztrogonác.
3213
3214         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
3215
3216         * Scripts/build-webkit:
3217
3218 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
3219
3220         [Jhbuild] Bump the required Jhbuild revision
3221         https://bugs.webkit.org/show_bug.cgi?id=123089
3222
3223         Reviewed by Carlos Garcia Campos.
3224
3225         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
3226         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
3227         in the Jhbuild source so a more recent revision of it should be used.
3228
3229 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
3230
3231         Mac build fix.
3232
3233         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
3234
3235 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
3236
3237         Enable webaudio/ tests on DRT/Mac
3238         https://bugs.webkit.org/show_bug.cgi?id=86914
3239
3240         Reviewed by Darin Adler.
3241
3242         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
3243         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
3244         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
3245         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
3246
3247         * DumpRenderTree/TestRunner.cpp:
3248         (setAudioResultCallback): 
3249         (TestRunner::staticFunctions):
3250         * DumpRenderTree/TestRunner.h:
3251         (TestRunner::audioResult):
3252         (TestRunner::setAudioResult):
3253         The function has a different name and argument type now, updated accordingly.
3254         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
3255
3256         * DumpRenderTree/mac/DumpRenderTree.mm:
3257         (dumpAudio): Updated for the new name of audioResult accessor.
3258         (dump): Print the result in the format webkitpy currently expects.
3259
3260         * WebKitTestRunner/TestInvocation.cpp:
3261         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
3262         chunks made no sense.
3263
3264         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3265         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
3266
3267         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
3268         so that "SourceProvider.h" can be found.
3269
3270 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
3271
3272         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
3273         https://bugs.webkit.org/show_bug.cgi?id=123070
3274
3275         Reviewed by Alexey Proskuryakov.
3276
3277         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3278         (Manager.run):
3279         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3280         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
3281         in the test expectations when this argument is set to true.
3282
3283 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
3284
3285         Mac DumpRenderTree builds without NDEBUG even in release mode
3286         https://bugs.webkit.org/show_bug.cgi?id=123066
3287
3288         Reviewed by Dan Bernstein.
3289
3290         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3291         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3292         Use the same pattern as WebCore and WebKitTestRunner.
3293
3294 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
3295
3296         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
3297         https://bugs.webkit.org/show_bug.cgi?id=123064
3298
3299         Reviewed by Ryosuke Niwa.
3300
3301         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
3302
3303         * Scripts/webkitpy/common/config/ports.py: Added.
3304         (DeprecatedPort):
3305         (DeprecatedPort.name):
3306         (DeprecatedPort.flag):
3307         (DeprecatedPort.script_path):
3308         (DeprecatedPort.script_shell_command):
3309         (DeprecatedPort.port):
3310         (DeprecatedPort.makeArgs):
3311         (DeprecatedPort.update_webkit_command):
3312         (DeprecatedPort.check_webkit_style_command):
3313         (DeprecatedPort.prepare_changelog_command):
3314         (DeprecatedPort.build_webkit_command):
3315         (DeprecatedPort.run_javascriptcore_tests_command):
3316         (DeprecatedPort.run_webkit_unit_tests_command):
3317         (DeprecatedPort.run_webkit_tests_command):
3318         (DeprecatedPort.run_python_unittests_command):
3319         (DeprecatedPort.run_perl_unittests_command):
3320         (DeprecatedPort.run_bindings_tests_command):
3321         (MacPort):
3322         (MacWK2Port):
3323         (MacWK2Port.run_webkit_tests_command):
3324         (WinPort):
3325         (WinPort.run_bindings_tests_command):
3326         (GtkPort):
3327         (GtkPort.build_webkit_command):
3328         (GtkPort.run_webkit_tests_command):
3329         (GtkWK2Port):
3330         (GtkWK2Port.build_webkit_command):
3331         (GtkWK2Port.run_webkit_tests_command):
3332         (QtPort):
3333         (QtPort.build_webkit_command):
3334         (QtPort.run_webkit_tests_command):
3335         (QtWK2Port):
3336         (QtWK2Port.build_webkit_command):
3337         (QtWK2Port.run_webkit_tests_command):
3338         (EflPort):
3339         (EflPort.build_webkit_command):
3340         (EflWK2Port):
3341         (EflWK2Port.build_webkit_command):
3342         * Scripts/webkitpy/common/config/ports_mock.py: Added.
3343         (MockPort):
3344         (MockPort.name):
3345         (MockPort.check_webkit_style_command):
3346         (MockPort.update_webkit_command):
3347         (MockPort.build_webkit_command):
3348         (MockPort.prepare_changelog_command):
3349         (MockPort.run_python_unittests_command):
3350         (MockPort.run_perl_unittests_command):
3351         (MockPort.run_javascriptcore_tests_command):
3352         (MockPort.run_webkit_unit_tests_command):
3353         (MockPort.run_webkit_tests_command):
3354         (MockPort.run_bindings_tests_command):
3355         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
3356         (DeprecatedPortTest):
3357         (DeprecatedPortTest.test_mac_port):
3358         (DeprecatedPortTest.test_gtk_port):
3359         (DeprecatedPortTest.test_gtk_wk2_port):
3360         (DeprecatedPortTest.test_efl_port):
3361         (DeprecatedPortTest.test_qt_port):
3362         (DeprecatedPortTest.test_qt_wk2_port):
3363         * Scripts/webkitpy/port/base.py:
3364         (Port._port_flag_for_scripts):
3365         (Port._wk2_port_name):
3366         * Scripts/webkitpy/port/base_unittest.py:
3367         (PortTest.test_build_path):
3368         * Scripts/webkitpy/port/efl_unittest.py:
3369         (EflPortTest.test_show_results_html_file):
3370         * Scripts/webkitpy/port/gtk_unittest.py:
3371         (GtkPortTest.test_get_crash_log):
3372         * Scripts/webkitpy/port/mac_unittest.py:
3373         (test_64bit):
3374         * Scripts/webkitpy/port/test.py:
3375         (TestPort.virtual_test_suites):
3376         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3377         (FlakyTestReporter.__init__):
3378         * Scripts/webkitpy/tool/bot/irc_command.py:
3379         (Rollout._update_working_copy):
3380         * Scripts/webkitpy/tool/commands/download_unittest.py:
3381         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3382         (AbstractEarlyWarningSystem.run_command):
3383         * Scripts/webkitpy/tool/commands/queues.py:
3384         (PatchProcessingQueue.begin_work_queue):
3385         (CommitQueue.run_command):
3386         * Scripts/webkitpy/tool/main.py:
3387         (WebKitPatch.__init__):
3388         (WebKitPatch.deprecated_port):
3389         (WebKitPatch.handle_global_options):
3390         * Scripts/webkitpy/tool/mocktool.py:
3391         (MockTool.__init__):
3392         (MockTool.deprecated_port):
3393         * Scripts/webkitpy/tool/steps/build.py:
3394         (Build.build):
3395         * Scripts/webkitpy/tool/steps/checkstyle.py:
3396         (CheckStyle.run):
3397         * Scripts/webkitpy/tool/steps/commit.py:
3398         (Commit._check_test_expectations):
3399         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3400         (PrepareChangeLog.run):
3401         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3402         (PrepareChangeLogForRevert.run):
3403         * Scripts/webkitpy/tool/steps/runtests.py:
3404         (RunTests.run):
3405         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3406         (RunTestsTest.test_webkit_run_unit_tests):
3407         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3408         (StepsTest.test_runtests_args):
3409         * Scripts/webkitpy/tool/steps/update.py:
3410         (Update._update_command):
3411         * Scripts/webkitpy/tool/steps/update_unittest.py:
3412         (UpdateTest.test_update_command_non_interactive):
3413         (UpdateTest.test_update_command_interactive):
3414
3415 2013-10-19  Andreas Kling  <akling@apple.com>
3416
3417         RefPtr::releaseNonNull() incorrectly increments the refcount.
3418         <https://webkit.org/b/123063>
3419
3420         Add an API test to verify that no extra refs are added when calling
3421         RefPtr::releaseNonNull().
3422
3423         Reviewed by Anders Carlsson.
3424
3425 2013-10-18  Rik Cabanier <cabanier@adobe.com>
3426         Add Rik Cabanier to list of committers
3427         https://bugs.webkit.org/show_bug.cgi?id=123031
3428
3429         reviewed by Dirk Schulze.
3430
3431         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
3432
3433 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
3434
3435         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
3436         https://bugs.webkit.org/show_bug.cgi?id=122970
3437
3438         Reviewed by Mario Sanchez Prada.
3439
3440         Removed an invalid signal to set an object state to layout-complete
3441         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
3442
3443         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3444         (axObjectEventListener): Replaced layout-complete with load-complete.
3445         (connectAccessibilityCallbacks): Connect callback to new listener for
3446         ATK:AtkDocument:load-complete.
3447         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
3448         for ATK:AtkDocument:load-complete.
3449         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3450         (axObjectEventListener): Replaced layout-complete with load-complete.
3451         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3452         Connect callback to new listener for ATK:AtkDocument:load-complete.
3453         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3454         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
3455
3456 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3457
3458         [GTK] Generate API documentation for GObject DOM bindings
3459         https://bugs.webkit.org/show_bug.cgi?id=121538
3460
3461         Reviewed by Gustavo Noronha Silva.
3462
3463         The .symbols file that is now generated for checking GObject DOM
3464         bindings API compatibility while building can also be used to
3465         generate the files needed to produce the gtk-doc
3466         documentation. The new script generate-webkitdom-doc-files can
3467         generate the docs.sgml and sections.txt files from the given list
3468         of .symbols files.
3469
3470         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
3471         and webkitdomgtk-sections.txt as well as rules to install the
3472         generated WebKitDOMGTK documentation.
3473         * gtk/generate-gtkdoc:
3474         (webkitdom_docs_html_path): New helper function that returns the
3475         path where the DOM API documentation has been generated.
3476         (get_webkit2_options): Include DOM API docs to the list of xref
3477         dependencies.
3478         (get_webkit1_options): Ditto.
3479         (get_webkitdom_options): Return the gtk-doc options to generate
3480         the DOM API docs.
3481         (get_webkitdom_options.derived_sources_path):
3482         (get_webkitdom_options.src_path):
3483         * gtk/generate-webkitdom-doc-files: Added.
3484         (WebKitDOMDocGenerator):
3485         (WebKitDOMDocGenerator.write_header):
3486         (WebKitDOMDocGenerator.write_section):
3487         (WebKitDOMDocGenerator.write_footer):
3488         (WebKitDOMDocGeneratorDocs):
3489         (WebKitDOMDocGeneratorDocs.write_header):
3490         (write_section):
3491         (write_footer):
3492         (WebKitDOMDocGeneratorSections):
3493         (WebKitDOMDocGeneratorSections.__init__):
3494         (WebKitDOMDocGeneratorSections._dom_class):
3495         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
3496         (WebKitDOMDocGeneratorSections._symbol_list):
3497         (WebKitDOMDocGeneratorSections.write_section):
3498
3499 2013-10-17  Alex Christensen  <achristensen@webkit.org>
3500
3501         Run JavaScriptCore tests again on Windows.
3502         https://bugs.webkit.org/show_bug.cgi?id=122787
3503
3504         Reviewed by Tim Horton.
3505
3506         * Scripts/build-jsc:
3507         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
3508         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
3509         * Scripts/webkitdirs.pm:
3510         (determineConfigurationForVisualStudio):
3511         (determineConfigurationProductDir):
3512         Build directory should end with bin64 and configuration should end with |x64 on Win64.
3513         (isAppleWinWebKit):
3514         (copyInspectorFrontendFiles):
3515         (setPathForRunningWebKitApp):
3516         Separated WinCairo directories and options from AppleWin.
3517
3518 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
3519
3520         Unreviewed. Add myself as a reviewer.
3521
3522         * Scripts/webkitpy/common/config/contributors.json:
3523
3524 2013-10-17  Andreas Kling  <akling@apple.com>
3525
3526         Make it possible to assign a PassRef to a RefPtr.
3527         <https://webkit.org/b/122943>
3528
3529         Added a small API test for RefPtr=(PassRef) so we know this code
3530         will compile (and work.)
3531
3532         Reviewed by Antti Koivisto.
3533
3534 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
3535
3536         We need test coverage for just the Baseline JIT
3537         https://bugs.webkit.org/show_bug.cgi?id=122929
3538
3539         Reviewed by Sam Weinig.
3540         
3541         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
3542         variant.
3543
3544         * Scripts/run-jsc-stress-tests:
3545
3546 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
3547
3548         Support multiple repositories in submitting results to --results-server-host
3549         https://bugs.webkit.org/show_bug.cgi?id=122935
3550
3551         Reviewed by Anders Carlsson.
3552
3553         Remoevd --got-revision and added the logic to extract revision information
3554         from multiple repositories as done in run-perf-tests.
3555
3556         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3557         (Manager.upload_results):
3558         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3559         (parse_args):
3560
3561 2013-10-16  Darin Adler  <darin@apple.com>
3562
3563         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
3564         https://bugs.webkit.org/show_bug.cgi?id=122904
3565
3566         Reviewed by Anders Carlsson.
3567
3568         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
3569
3570 2013-10-16  Darin Adler  <darin@apple.com>
3571
3572         Need tests for RefPtr self-assignment and self-move-assignment.
3573
3574         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
3575
3576 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
3577
3578         [EFL] Minibrowser can't load child window's location
3579         https://bugs.webkit.org/show_bug.cgi?id=122485
3580
3581         Reviewed by Gyuyoung Kim.
3582
3583         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
3584             followed by an explicit call to ewk_view_url_set() where appropriate.
3585         (on_key_down):
3586         (on_window_create):
3587         (window_create):
3588         (elm_main):
3589
3590 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
3591
3592         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
3593         https://bugs.webkit.org/show_bug.cgi?id=122872
3594
3595         Reviewed by Anders Carlsson.
3596
3597         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
3598         failing.
3599
3600 2013-10-15  Dean Jackson  <dino@apple.com>
3601
3602         Add ENABLE_WEB_ANIMATIONS flag
3603         https://bugs.webkit.org/show_bug.cgi?id=122871
3604
3605         Reviewed by Tim Horton.
3606
3607         Eventually might be http://dev.w3.org/fxtf/web-animations/
3608         but this is just engine-internal work at the moment.
3609
3610         * Scripts/webkitperl/FeatureList.pm:
3611
3612 2013-10-15  Darin Adler  <darin@apple.com>
3613
3614         Add some API tests for Vector, RefPtr, and Ref
3615         https://bugs.webkit.org/show_bug.cgi?id=122840
3616
3617         Reviewed by Andreas Kling.
3618
3619         * TestWebKitAPI/CMakeLists.txt: Added new files.
3620         * TestWebKitAPI/GNUmakefile.am: Ditto.
3621         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
3622         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3624
3625         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
3626         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
3627         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
3628         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
3629
3630 2013-10-14  Roger Fong  <roger_fong@apple.com>
3631
3632         Adding myself to CC list for some components.
3633
3634         * Scripts/webkitpy/common/config/watchlist:
3635
3636 2013-10-13  Darin Adler  <darin@apple.com>
3637
3638         Deprecate or remove deleteAllValues functions; there are only a few call sites left
3639         https://bugs.webkit.org/show_bug.cgi?id=122738
3640
3641         Reviewed by Anders Carlsson.
3642
3643         * DumpRenderTree/win/DRTDataObject.cpp:
3644         (DRTDataObject::~DRTDataObject):
3645         * DumpRenderTree/win/UIDelegate.cpp:
3646         (DRTUndoStack::~DRTUndoStack):
3647         (DRTUndoStack::clear):
3648         Renamed deleteAllValues to deprecatedDeleteAllValues.
3649
3650         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
3651
3652 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
3653
3654         build.webkit.org/dashboard incorrectly shows interrupted builds as green
3655         https://bugs.webkit.org/show_bug.cgi?id=122732
3656
3657         Reviewed by Tim Hatcher.
3658
3659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3660         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
3661         I don't see it occur any time in recent history, but judging from what happens for
3662         status 5 (RETRY), we can just finish this function normally.
3663         Record overall text description for iteration as BuildbotIteration.text.
3664
3665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3666         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
3667         but no tests failed, make it yellow, and use buildbot-provided description for it.
3668
3669 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
3670
3671         Remove Chromium specific code from flakiness dashboard
3672         https://bugs.webkit.org/show_bug.cgi?id=122714
3673
3674         Reviewed by Sam Weinig.
3675
3676         Also removed code related to GPU tests and virtual suites.
3677         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
3678
3679         * TestResultServer/model/jsonresults_unittest.py:
3680         * TestResultServer/static-dashboards/builders.js:
3681         * TestResultServer/static-dashboards/dashboard_base.js:
3682         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3683         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3684         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
3685         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3686         * TestResultServer/static-dashboards/history.js:
3687         * TestResultServer/static-dashboards/loader.js:
3688         * TestResultServer/static-dashboards/ui.js:
3689         * TestResultServer/templates/uploadform.html:
3690
3691 2013-10-11  Timothy Hatcher  <timothy@apple.com>
3692
3693         Remove preference support for picking the old Web Inspector.
3694         https://bugs.webkit.org/show_bug.cgi?id=122655
3695
3696         Reviewed by Alexey Proskuryakov.
3697
3698         * WebKitTestRunner/TestController.cpp:
3699         (WTR::TestController::resetStateToConsistentValues):
3700
3701 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
3702
3703         Fix 64-bit build on everything but Windows.
3704
3705         Rubber stamped by Brent Fulgham.
3706
3707         * Scripts/webkitdirs.pm:
3708         (argumentsForConfiguration):
3709
3710 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
3711
3712         Touch a file to see how auto-update works.
3713
3714         Rubber-stamped by Tim Hatcher.
3715
3716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3717
3718 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
3719
3720         LeaksViewer fails to present recent results list if current build is still updating svn
3721         https://bugs.webkit.org/show_bug.cgi?id=122670
3722
3723         Fixed an obvious mistake in the previous patch.
3724
3725         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3726         (RecentBuildsLoader.prototype.start):
3727
3728 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
3729
3730         LeaksViewer fails to present recent results list if current build is still updating svn
3731         https://bugs.webkit.org/show_bug.cgi?id=122670
3732
3733         Reviewed by Adam Roben.
3734
3735         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3736         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
3737
3738 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
3739
3740         Unreviewed build fix for --64-bit target.
3741
3742         * Scripts/webkitdirs.pm:
3743         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
3744         been removed by this point.
3745         (hasArgument): Remove unused temporary.
3746
3747 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3748
3749         webkit-patch failure-reason has a quite low limit for 'too many failures'
3750         https://bugs.webkit.org/show_bug.cgi?id=122556
3751
3752         Reviewed by Darin Adler.
3753
3754         * Scripts/webkitpy/tool/commands/queries.py:
3755         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
3756         to match what the layout test runners use these days.
3757
3758 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3759
3760         webkit-patch failure-reason should allow specifying failures one is interested in
3761         https://bugs.webkit.org/show_bug.cgi?id=122554
3762
3763         Reviewed by Darin Adler.
3764
3765         * Scripts/webkitpy/tool/commands/queries.py:
3766         (FailureReason):
3767         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
3768         loop if the ones we're interested in been explained.
3769         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
3770         (FailureReason.execute): initialize failures to explain and the explained set.
3771
3772 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
3773
3774         Make sure that DataTypes.h is in the binary drop.
3775
3776         Rubber stamped by Michael Saboff.
3777
3778         * Scripts/export-llvm-build:
3779
3780 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
3781
3782         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
3783         https://bugs.webkit.org/show_bug.cgi?id=122566
3784
3785         Reviewed by Mark Rowe.
3786
3787         * Scripts/configure-llvm:
3788
3789 2013-10-10  Mark Rowe  <mrowe@apple.com>
3790
3791         <rdar://problem/13341666> WebKit should always build against an SDK.
3792
3793         Have all projects default to building against the OS X Internal SDK for the Production
3794         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
3795         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
3796
3797         Reviewed by Dan Bernstein.
3798
3799         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3800         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3801         * MiniBrowser/Configurations/Base.xcconfig:
3802         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3803         * TestWebKitAPI/Configurations/Base.xcconfig:
3804         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3805         * WebKitTestRunner/Configurations/Base.xcconfig:
3806         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3807
3808 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
3809
3810         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
3811
3812         * Scripts/run-gtk-tests:
3813         (TestRunner): skip TestInspectorServer.
3814
3815 2013-10-10  Andres Gomez  <agomez@igalia.com>
3816
3817         [GTK] Provide search functionality to MiniBrowser
3818         https://bugs.webkit.org/show_bug.cgi?id=117631
3819
3820         Reviewed by Carlos Garcia Campos.
3821
3822         Adds a search bar to MiniBrowser with the minimum functionality
3823         and a new button to the toolbar for showing the new search
3824         bar. Typical keyboard shortcuts are also added.
3825
3826         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
3827         (doSearch):
3828         (searchNext):
3829         (searchPrevious):
3830         (searchCloseButtonClickedCallback):
3831         (searchEntryMenuIconPressedCallback):
3832         (searchEntryClearIconReleasedCallback):
3833         (searchEntryChangedCallback):
3834         (searchEntryActivatedCallback):
3835         (searchPrevButtonClickedCallback):
3836         (searchNextButtonClickedCallback):
3837         (searchMenuCheckButtonToggledCallback):
3838         (browser_search_bar_init):
3839         (browserSearchBarFinalize):
3840         (browser_search_bar_class_init):
3841         (browser_search_bar_new):
3842         (browser_search_bar_add_accelerators):
3843         (browser_search_bar_open):
3844         (browser_search_bar_close):
3845         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
3846         * MiniBrowser/gtk/BrowserWindow.c:
3847         (webViewEnterFullScreen): Closes new search bar.
3848         (webViewLeaveFullScreen): Opens new search bar if previously
3849         visible.
3850         (searchCallback): Added. Shows and hides the new search bar.
3851         (browser_window_init): Added search button to the toolbar.
3852         (browserWindowConstructed): Creates the new search bar.
3853         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
3854
3855 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3856
3857         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
3858         https://bugs.webkit.org/show_bug.cgi?id=122552
3859
3860         Reviewed by Darin Adler.
3861
3862         * Scripts/webkitpy/common/checkout/commitinfo.py:
3863         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
3864         will cause UnicodeDecodeError for non-ascii characters.
3865
3866 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3867
3868         Would like a link to dashboard from build.webkit.org main page
3869         https://bugs.webkit.org/show_bug.cgi?id=122577
3870
3871         Reviewed by Tim Hatcher.
3872
3873         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
3874
3875 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
3876
3877         [Win] Check for MathML fonts and warn user if they are missing.
3878         https://bugs.webkit.org/show_bug.cgi?id=122568
3879
3880         Reviewed by Tim Horton.
3881
3882         * Scripts/webkitdirs.pm:
3883         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
3884         Windows-specific code I added previously.
3885         (fontExists): Added
3886         (checkInstalledTools): Add check for MathML fonts.
3887
3888 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3889
3890         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
3891         https://bugs.webkit.org/show_bug.cgi?id=122471
3892
3893         Reviewed by Tim Hatcher.
3894
3895         Added links to webkitpy, webkitperl and bindings-tests results.
3896
3897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3898         (Buildbot.prototype.apiTestResultsURLForIteration):
3899         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
3900         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
3901         (Buildbot.prototype.bindingsTestResultsURLForIteration):
3902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3903         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3904
3905 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3906
3907         Move some functions from WebKitBuildbot to Buildbot class.
3908
3909         Suggested by Tim Hatcher.
3910
3911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3912         (Buildbot.prototype.javascriptTestResultsURLForIteration):
3913         (Buildbot.prototype.apiTestResultsURLForIteration):
3914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3915         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
3916
3917 2013-10-09  Timothy Hatcher  <timothy@apple.com>
3918
3919         Add API tests to the Dashbord page.
3920
3921         https://bugs.webkit.org/show_bug.cgi?id=122283
3922
3923         Reviewed by Timothy Hatcher.
3924
3925         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3926         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3928         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
3929
3930 2013-10-09  Timothy Hatcher  <timothy@apple.com>
3931
3932         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
3933
3934         https://bugs.webkit.org/show_bug.cgi?id=122515
3935
3936         Reviewed by Alexey Proskuryakov.
3937
3938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3939         (BuildbotIteration.prototype.update):
3940
3941 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3942
3943         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
3944         https://bugs.webkit.org/show_bug.cgi?id=122573
3945
3946         Reviewed by Tim Hatcher.
3947
3948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3949         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
3950
3951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3952         (Buildbot.prototype.buildPageURLForIteration): Added.
3953
3954 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3955
3956         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
3957         https://bugs.webkit.org/show_bug.cgi?id=122569
3958
3959         Reviewed by Tim Hatcher.
3960
3961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3962         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
3963         to be produced by the old Mozilla test harness that we don't use any more.
3964
3965 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3966
3967         Add GTK 64 bits release to the buildbot dashboard
3968         https://bugs.webkit.org/show_bug.cgi?id=122548
3969
3970         Reviewed by Darin Adler.
3971
3972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
3973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3974         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
3975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3976         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
3977
3978 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3979
3980         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
3981         https://bugs.webkit.org/show_bug.cgi?id=120638
3982
3983         Reviewed by Gustavo Noronha Silva.
3984
3985         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
3986         can check both the old and new APIs to retrieve text at a given offset.
3987
3988 2013-10-08  Alex Christensen  <achristensen@webkit.org>
3989
3990         Improved WinLauncher.
3991         https://bugs.webkit.org/show_bug.cgi?id=122536
3992
3993         Reviewed by Brent Fulgham.
3994
3995         * WinLauncher/PrintWebUIDelegate.cpp:
3996         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
3997         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3998         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
3999         * WinLauncher/WinLauncher.cpp:
4000         (createCrashReport): Use the executable name instead of "WinLauncher".
4001         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
4002         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
4003         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
4004
4005 2013-10-08  Mark Lam  <mark.lam@apple.com>
4006
4007         Fix ruby LoadError when running run-javascriptcore-tests.
4008         https://bugs.webkit.org/show_bug.cgi?id=122519.
4009
4010         Reviewed by Mark Hahnenberg.
4011
4012         The scripts needed to explicitly require 'rubygems' for older versions of ruby
4013         (versions before 1.9).
4014
4015         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
4016         * Scripts/run-jsc-stress-tests:
4017
4018 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4019
4020         Unreviewed, add my new email to contributors.json.
4021
4022         * Scripts/webkitpy/common/config/contributors.json:
4023
4024 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
4025
4026         Unreviewed build correction.
4027
4028         * Scripts/webkitpy/port/win.py:
4029         (WinPort.write_registry_value): Use string representation of error message to avoid
4030         format conversion problem.
4031
4032 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
4033
4034         [Win] Add checks for proper build and test environment
4035         https://bugs.webkit.org/show_bug.cgi?id=122466
4036
4037         Reviewed by Darin Adler.
4038
4039         This patch makes two changes:
4040         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
4041            error messages so that people know what to fix to get things working.
4042         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
4043            the various environment settings are properly configured for our test environment.
4044
4045         * Scripts/webkitdirs.pm:
4046         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
4047         caused problems in the past.
4048         (setupAppleWinEnv):
4049         * Scripts/webkitpy/port/win.py:
4050         (WinPort):
4051         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
4052         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
4053         DWORD, etc.)
4054         (WinPort.write_registry_string): Revise to call new generic registry write function.
4055         (WinPort.setup_crash_log_saving): Revise for new API
4056         (WinPort.restore_crash_log_saving): Ditto
4057         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
4058         servers from running.
4059         (WinPort.allow_error_dialogs): Ditto.
4060         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
4061         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
4062
4063 2013-10-08  Philippe Normand  <pnormand@igalia.com>
4064
4065         [GStreamer] enable v4l2 plugin
4066         https://bugs.webkit.org/show_bug.cgi?id=122503
4067
4068         Reviewed by Martin Robinson.
4069
4070         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
4071         we updated our GStreamer version to 1.0.8.
4072
4073 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
4074
4075         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
4076         https://bugs.webkit.org/show_bug.cgi?id=122104
4077
4078         Reviewed by Chris Fleizach.
4079
4080         Updated stringAttributeValue to double check that the exposure of
4081         aria-invalid as a state is consistent with its exposure as a text
4082         attribute as well, when it applies (implementations of AtkText).
4083
4084         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4085         (AccessibilityUIElement::stringAttributeValue): Add double check.
4086         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4087         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
4088
4089 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
4090
4091         run-jsc-stress-tests progress meter should update more quickly on older Rubies
4092         https://bugs.webkit.org/show_bug.cgi?id=122459
4093
4094         Reviewed by Darin Adler.
4095
4096         * Scripts/run-jsc-stress-tests:
4097
4098 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
4099
4100         [buildbot] parse tests that are reported as crashed correctly for GTK+
4101         https://bugs.webkit.org/show_bug.cgi?id=122476
4102
4103         Reviewed by Martin Robinson.
4104
4105         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4106         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
4107         as a failure of the API tests.
4108
4109 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
4110
4111         Unreviewed. Skipping API test that is causing the next one to crash,
4112         see https://bugs.webkit.org/show_bug.cgi?id=121970.
4113
4114         * Scripts/run-gtk-tests:
4115         (TestRunner):
4116
4117 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4118
4119         [GTK] run-gtk-tests does not distinguish between failure and crashes
4120         https://bugs.webkit.org/show_bug.cgi?id=122135
4121
4122         Reviewed by Martin Robinson.
4123
4124         The GTK+ API test runner does not distinguish between failures and crashes. This change
4125         makes it do that, so it's easier for us to spot the more important/higher priority crash
4126         case.
4127
4128         * Scripts/run-gtk-tests:
4129         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
4130         so we have more information on how the process ended.
4131         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
4132         (TestRunner.run_tests): report crashes.
4133
4134 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
4135
4136         [GTK] Missing packages for APT on install-dependencies
4137         https://bugs.webkit.org/show_bug.cgi?id=121555
4138
4139         Reviewed by Martin Robinson.
4140
4141         * gtk/install-dependencies: add packages that are needed for
4142         building WebKit itself and the jhbuild dependencies.
4143
4144 2013-10-07  Anders Carlsson  <andersca@apple.com>
4145
4146         Fix test failures.
4147
4148         * Scripts/webkitpy/port/base.py:
4149         (Port.to.start_helper):
4150         * Scripts/webkitpy/port/mock_drt.py:
4151         (MockDRTPort.start_helper):
4152
4153 2013-10-07  Anders Carlsson  <andersca@apple.com>
4154
4155         Always force discrete mode when running layout tests
4156         https://bugs.webkit.org/show_bug.cgi?id=122465
4157
4158         Reviewed by Tim Horton.
4159
4160         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
4161         
4162         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4163         Link with IOKit.
4164
4165         * DumpRenderTree/mac/LayoutTestHelper.m:
4166         (installLayoutTestColorProfile):
4167         Check installColorProfile.
4168
4169         (restoreUserColorProfile):
4170         Check installColorProfile.
4171
4172         (lockDownDiscreteGraphics):
4173         New function to force discrete graphics.
4174
4175         (main):
4176         Add '--install-color-profile' option.
4177
4178         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4179         (Manager._set_up_run):
4180         Always start the helper, but pass self._options.pixel_tests to it.
4181
4182         * Scripts/webkitpy/port/mac.py:
4183         (MacPort.start_helper):
4184         Pass --install-color-profile' to the helper if pixel_tests is true.
4185
4186 2013-10-07  Timothy Hatcher  <timothy@apple.com>
4187
4188         Properly count binding test failures as failures.
4189
4190         Fix the total for multiple failures in different steps too by avoiding undefined.
4191
4192         https://bugs.webkit.org/show_bug.cgi?id=122232
4193
4194         Reviewed by Alexey Proskuryakov.
4195
4196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
4197         (BuildbotTestResults):
4198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4199         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4200
4201 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4202
4203         [GTK] Fails to build with jhbuild with newer system glib
4204         https://bugs.webkit.org/show_bug.cgi?id=122132
4205
4206         Reviewed by Martin Robinson.
4207
4208         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
4209         started relying on. glib is not a dependency that should change test results, and is provided in
4210         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
4211         should not be an issue.
4212
4213         * gtk/jhbuild.modules:
4214
4215 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
4216
4217         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
4218         https://bugs.webkit.org/show_bug.cgi?id=122437
4219
4220         Reviewed by Antoine Quint.
4221
4222         * Scripts/run-jsc-stress-tests:
4223
4224 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
4225
4226         Unreviewed, fix build on old Rubies.
4227
4228         * Scripts/run-jsc-stress-tests:
4229
4230 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
4231
4232         Unified test infrastructure via the jsc shell
4233         https://bugs.webkit.org/show_bug.cgi?id=120696
4234
4235         Reviewed by Oliver Hunt.
4236         
4237         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
4238         output (silent or noisy) and different styles of test failure (just bad exit code,
4239         text diff, filtering for some magical text, etc.). This allows me to get rid of the
4240         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
4241         running in run-jsc-stress-tests.
4242         
4243         Also removes all of the code paths that defended against not having shellwords. Just
4244         install the shellwords gem if you want to run tests.
4245         
4246         Also removes the non-parallel test running code. No reason for it to exist anymore.
4247         
4248         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
4249         as part of this patch, and left three more as new bugzillas.
4250
4251         * Scripts/create-mozilla-js-test-list: Added.
4252         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
4253         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
4254         * Scripts/run-javascriptcore-tests:
4255         * Scripts/run-jsc-stress-tests:
4256
4257 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
4258
4259         run-jsc-stress-tests should be less verbose
4260         https://bugs.webkit.org/show_bug.cgi?id=122397
4261
4262         Reviewed by Sam Weinig.
4263         
4264         It now just prints something like:
4265         
4266          965/1831 ....
4267         
4268         Where the first number is the number of tests that completed, the second number is the
4269         number of tests total, and the dots are the number of tests running right now - which is
4270         useful towards the end when you're waiting for the last slow tests to finish.
4271         
4272         It will also print out the output from failing tests and it will print a line for skipped
4273         tests (to annoy you into getting them into a shape where they can be unskipped). For
4274         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
4275
4276         * Scripts/run-jsc-stress-tests:
4277
4278 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
4279
4280         Allow skipping of run-jsc-stress-tests that are configured using yaml files
4281         https://bugs.webkit.org/show_bug.cgi?id=122385
4282
4283         Reviewed by Sam Wieinig.
4284         
4285         Make tests run via YAML be able to do the parse-for-commands trick that allows
4286         us to skip tests and do other custom per-test stuff.
4287
4288         * Scripts/jsc-stress-test-helpers/layout-test-helper:
4289         * Scripts/run-jsc-stress-tests:
4290
4291 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
4292
4293         Unreviewed, fix tests on older Rubies.
4294
4295         * Scripts/run-jsc-stress-tests:
4296
4297 2013-10-05  Anders Carlsson  <andersca@apple.com>
4298
4299         Don't filter the weak symbols.
4300
4301         * Scripts/check-for-weak-vtables-and-externals:
4302
4303 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
4304
4305         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
4306         https://bugs.webkit.org/show_bug.cgi?id=122376
4307
4308         Reviewed by Mark Hahnenberg.
4309
4310         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
4311         * Sc