REGRESSION (r230523): Caps lock indicator not shown in password field
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
2
3         REGRESSION (r230523): Caps lock indicator not shown in password field
4         https://bugs.webkit.org/show_bug.cgi?id=190056
5
6         Reviewed by Ryosuke Niwa.
7
8         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
9         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
10         (WTR::TestRunner::toggleCapsLock):
11         * WebKitTestRunner/InjectedBundle/TestRunner.h:
12         * WebKitTestRunner/TestController.h:
13         * WebKitTestRunner/TestInvocation.cpp:
14         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
15         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
16         (WTR::TestController::toggleCapsLock):
17
18 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
19
20         IndexedDB: WAL file keeps growing
21         https://bugs.webkit.org/show_bug.cgi?id=191294
22         <rdar://problem/41333493>
23
24         Reviewed by Chris Dumez.
25
26         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
28         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
29         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
30         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
31         (TEST):
32
33 2018-11-06  Alex Christensen  <achristensen@webkit.org>
34
35         Fix tests after r237863
36         https://bugs.webkit.org/show_bug.cgi?id=191315
37
38         Reviewed by Chris Dumez.
39
40         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
41         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
42         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
43         to verify that main2.html eventually loads, making this test less timing dependent.
44
45 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
46
47         Unreviewed, rolling out r237834.
48
49         Tests for this change crash on iOS Simulator
50
51         Reverted changeset:
52
53         "Spelling dots are drawn in the wrong place"
54         https://bugs.webkit.org/show_bug.cgi?id=190764
55         https://trac.webkit.org/changeset/237834
56
57 2018-11-05  Alex Christensen  <achristensen@webkit.org>
58
59         [Mac] Implement safe browsing in WebKit
60         https://bugs.webkit.org/show_bug.cgi?id=188871
61
62         Reviewed by Tim Horton.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
65         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
66         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
67         (-[TestLookupContext lookUpURL:completionHandler:]):
68         (simpleURL):
69         (safeBrowsingView):
70         (TEST):
71         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
72         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
73         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
74         * TestWebKitAPI/Utilities.h:
75
76 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
77
78         webkitpy: Generalize trailing SDK specifier (Part 1)
79         https://bugs.webkit.org/show_bug.cgi?id=191275
80         <rdar://problem/45703660>
81
82         Reviewed by Lucas Forschler.
83
84         * Scripts/webkitpy/common/system/platforminfo.py:
85         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
86         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
87         (TestPlatformInfo):
88         (TestPlatformInfo.test_available_sdks):
89
90 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
91
92         Spelling dots are drawn in the wrong place
93         https://bugs.webkit.org/show_bug.cgi?id=190764
94
95         Reviewed by Dean Jackson.
96
97         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
98         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
99         dots to be drawn.
100
101         * WebKitTestRunner/TestController.cpp:
102         (WTR::TestController::resetStateToConsistentValues):
103         (WTR::updateTestOptionsFromTestHeader):
104         (WTR::TestController::platformResetStateToConsistentValues):
105         * WebKitTestRunner/TestController.h:
106         * WebKitTestRunner/TestOptions.h:
107         (WTR::TestOptions::hasSameInitializationOptions const):
108         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
109         (WTR::TestController::cocoaResetStateToConsistentValues):
110         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
111         * WebKitTestRunner/ios/TestControllerIOS.mm:
112         (WTR::TestController::platformResetStateToConsistentValues):
113         * WebKitTestRunner/mac/TestControllerMac.mm:
114         (WTR::TestController::platformResetStateToConsistentValues):
115
116 2018-11-05  Chris Dumez  <cdumez@apple.com>
117
118         Use same limit for page cache and suspended pages
119         https://bugs.webkit.org/show_bug.cgi?id=191266
120
121         Reviewed by Geoffrey Garen.
122
123         Update API tests accordingly.
124
125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
126
127 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
128
129         [style] Exclude style check for auto generated files.
130         https://bugs.webkit.org/show_bug.cgi?id=191118
131
132         Reviewed by Eric Carlson.
133
134         Some files checked in to the repository are generated by other tools. In this patch,
135         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
136         VisualStudio.
137
138         There's no need to check these files because it's not practical to fix the style errors
139         or it's hard to maintain those fixes.
140
141         * Scripts/webkitpy/style/checkers/cpp.py:
142         (is_generated_file):
143         (CppChecker.check):
144
145 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
146
147         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
148         https://bugs.webkit.org/show_bug.cgi?id=190680
149
150         Reviewed by Philippe Normand.
151
152         * flatpak/org.webkit.WebKit.yaml:
153
154 2018-11-05  Daniel Bates  <dabates@apple.com>
155
156         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
157         https://bugs.webkit.org/show_bug.cgi?id=191094
158
159         Reviewed by Andy Estes.
160
161         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
162         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
163         Document summary and add closing brace '}' to both Frame and Document summary strings to make
164         them look pretty.
165
166         * lldb/lldb_webkit.py:
167         (WebCoreFrame_SummaryProvider):
168         (WebCoreDocument_SummaryProvider):
169
170 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
171
172         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
173         https://bugs.webkit.org/show_bug.cgi?id=191240
174         <rdar://problem/44872806>
175
176         Reviewed by Tim Horton.
177
178         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
179         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
180         overriding `-[WKWebView inputAssistantItem]`.
181
182         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
183         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
184         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
185         (+[InputAssistantItemTestingWebView barButtonIcon]):
186         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
187         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
188         (-[InputAssistantItemTestingWebView inputAssistantItem]):
189         (TestWebKitAPI::TEST):
190
191 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
192
193         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
194         https://bugs.webkit.org/show_bug.cgi?id=191226
195         <rdar://problem/45781765>
196
197         Reviewed by Tim Horton.
198
199         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
200         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
201
202         * WebKitTestRunner/TestOptions.h:
203         (WTR::TestOptions::hasSameInitializationOptions const):
204
205 2018-11-05  Commit Queue  <commit-queue@webkit.org>
206
207         Unreviewed, rolling out r237784 and r237788.
208         https://bugs.webkit.org/show_bug.cgi?id=191270
209
210         Caused mediastream layout test failures (Requested by
211         ryanhaddad on #webkit).
212
213         Reverted changesets:
214
215         "[MediaStream] User should not be prompted again after denying
216         getDisplayMedia request"
217         https://bugs.webkit.org/show_bug.cgi?id=191227
218         https://trac.webkit.org/changeset/237784
219
220         "[MediaStream] User should not be prompted again after denying
221         getDisplayMedia request"
222         https://bugs.webkit.org/show_bug.cgi?id=191227
223         https://trac.webkit.org/changeset/237788
224
225 2018-11-05  Lucas Forschler  <lforschler@apple.com>
226
227         https://bugs.webkit.org/show_bug.cgi?id=191268
228         Remove unused bots.
229
230         rubber-stamped by Alexey Proskuryakov.
231
232         * BuildSlaveSupport/build.webkit.org-config/config.json:
233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
234         (WebKitBuildbot):
235
236 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
237
238         [WPE][GTK] API test runner fails to respect default build type
239         https://bugs.webkit.org/show_bug.cgi?id=190247
240
241         Reviewed by Carlos Garcia Campos.
242
243         Problem is it's looking for a release build, even though I've run set-webkit-configuration
244         --debug. It should look for a debug build unless I explicitly pass --release.
245
246         * glib/api_test_runner.py:
247         (TestRunner.__init__):
248
249 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
250
251         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
252         https://bugs.webkit.org/show_bug.cgi?id=190674
253
254         Reviewed by Philippe Normand.
255
256         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
257         it can use to implement encoding for different formats exposing a trimmed down unified API.
258
259         It also adds proper handling of H264 profiles.
260
261         The added files follow GStreamer coding style as we aim at upstreaming the element
262         in the future.
263
264         Reviewed by Philippe Normand.
265
266         * Scripts/webkitpy/style/checker.py:
267
268 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
269
270         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
271         https://bugs.webkit.org/show_bug.cgi?id=191221
272
273         Reviewed by Carlos Garcia Campos.
274
275         This test ensures that MSE is disabled by default, but we now enable it by default, so
276         reverse the semantics of the test.
277
278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
279         (testWebKitSettings):
280
281 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
282
283         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
284         https://bugs.webkit.org/show_bug.cgi?id=191225
285
286         Reviewed by Alejandro G. Castro.
287
288         Fix a memory leak causing this test to fail.
289
290         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
291         (WebViewTest::initializeWebView):
292
293 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
294
295         [webkitpy] Support WPE in the run-web-platform-tests script
296         https://bugs.webkit.org/show_bug.cgi?id=191183
297
298         Reviewed by Alex Christensen.
299
300         * Scripts/webkitpy/w3c/wpt_runner.py:
301         (parse_args): Support `--wpe` as an argument that specifies WPE as the
302         target port. Additionally, the `--display-server` flag now accepts
303         `headless` as a valid value, enabling the WPE WebDriver to run in
304         headless mode.
305
306 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
307
308         [Win] Use C++14, not C++17
309         https://bugs.webkit.org/show_bug.cgi?id=191101
310
311         Reviewed by Alex Christensen.
312
313         std::basic_string::data() returns a read-only const buffer in
314         C++14.
315
316         * MiniBrowser/win/WebKitBrowserWindow.cpp:
317         (createString): Use std::vector instead of std::wstring.
318         (createUTF8String): Use std::vector instead of std::string.
319
320 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
321
322         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
323         https://bugs.webkit.org/show_bug.cgi?id=191231
324
325         Reviewed by Simon Fraser.
326
327         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
328         it can be shared between iOS-family and macOS platforms. See below for more details.
329
330         No change in behavior.
331
332         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
333         (WTR::UIScriptController::overridePreference):
334
335         Add a method stub for DumpRenderTree.
336
337         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
338         * WebKitTestRunner/UIScriptControllerCocoa.mm:
339         (WTR::UIScriptController::doAsyncTask):
340         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
341
342         Unify these method implementations.
343
344         (WTR::UIScriptController::removeViewFromWindow):
345         (WTR::UIScriptController::addViewToWindow):
346
347         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
348         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
349         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
350         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
351
352         (WTR::UIScriptController::overridePreference):
353         (WTR::UIScriptController::findString):
354         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
355
356         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
357
358         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
359         (WTR::UIScriptController::doAsyncTask): Deleted.
360         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
361         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
362         (WTR::UIScriptController::findString): Deleted.
363         (WTR::UIScriptController::removeViewFromWindow): Deleted.
364         (WTR::UIScriptController::addViewToWindow): Deleted.
365         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
366         (WTR::UIScriptController::doAsyncTask): Deleted.
367         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
368         (WTR::UIScriptController::overridePreference): Deleted.
369         (WTR::UIScriptController::findString): Deleted.
370         (WTR::UIScriptController::removeViewFromWindow): Deleted.
371         (WTR::UIScriptController::addViewToWindow): Deleted.
372         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
373
374 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
375
376         [MediaStream] User should not be prompted again after denying getDisplayMedia request
377         https://bugs.webkit.org/show_bug.cgi?id=191227
378         <rdar://problem/45784512>
379
380         Reviewed by Youenn Fablet.
381
382         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
383         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
384         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
385         (TestWebKitAPI::TEST_F):
386
387 2018-11-04  Zalan Bujtas  <zalan@apple.com>
388
389         [LFC][BFC] Add support for percentage height in quirks mode.
390         https://bugs.webkit.org/show_bug.cgi?id=191232
391
392         Reviewed by Antti Koivisto.
393
394         * LayoutReloaded/misc/LFC-passing-tests.txt:
395
396 2018-11-04  Zalan Bujtas  <zalan@apple.com>
397
398         [LFC][BCF] Add support for block level non-replaced inflow height percentage
399         https://bugs.webkit.org/show_bug.cgi?id=191229
400
401         Reviewed by Antti Koivisto.
402
403         * LayoutReloaded/misc/LFC-passing-tests.txt:
404
405 2018-11-02  Zalan Bujtas  <zalan@apple.com>
406
407         [LFC][BFC] Resolve percentage height values.
408         https://bugs.webkit.org/show_bug.cgi?id=191224
409
410         Reviewed by Antti Koivisto.
411
412         * LayoutReloaded/misc/LFC-passing-tests.txt:
413
414 2018-11-03  Alex Christensen  <achristensen@webkit.org>
415
416         Mac production builds should sign the network process xpc service with entitlements
417         https://bugs.webkit.org/show_bug.cgi?id=191209
418         <rdar://problem/45377609>
419
420         Reviewed by Geoff Garen.
421
422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
423         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
424         (TEST):
425
426 2018-11-02  Alex Christensen  <achristensen@webkit.org>
427
428         Unreviewed, rolling out r237761.
429
430         Makes most API tests timeout and WK2 tests crash
431
432         Reverted changeset:
433
434         "Mac production builds should sign the network process xpc
435         service with entitlements"
436         https://bugs.webkit.org/show_bug.cgi?id=191209
437         https://trac.webkit.org/changeset/237761
438
439 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
440
441         Unreviewed API test gardening
442
443         * TestWebKitAPI/glib/TestExpectations.json:
444
445 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
446
447         Add new global object and preliminary Worklets support for CSS painting api
448         https://bugs.webkit.org/show_bug.cgi?id=190979
449
450         Reviewed by Chris Dumez.
451
452         * Scripts/webkitpy/bindings/main.py:
453         (BindingsTests.generate_supplemental_dependency):
454         (BindingsTests.main):
455
456 2018-11-02  Alex Christensen  <achristensen@webkit.org>
457
458         Mac production builds should sign the network process xpc service with entitlements
459         https://bugs.webkit.org/show_bug.cgi?id=191209
460         <rdar://problem/45377609>
461
462         Reviewed by Geoff Garen.
463
464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
465         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
466         (TEST):
467
468 2018-11-02  Lucas Forschler  <lforschler@apple.com>
469
470         Add Windows 10 archive bots
471         https://bugs.webkit.org/show_bug.cgi?id=190964
472         
473         This Change updates the Apple Windows Buildbot configuration.
474         - Add Windows 10 specific builders and testers for release and debug.
475         - Refactor Windows -> Windows 7.
476         - Remove Windows 7 Debug.
477
478         Reviewed by Aakash Jain.
479
480         * BuildSlaveSupport/build.webkit.org-config/config.json:
481
482 2018-11-02  Philippe Normand  <pnormand@igalia.com>
483
484         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
485
486         Rubber-stamped by Michael Catanzaro.
487
488         This variable is useful to get rid of shell color escapes in tests stderr files.
489
490         * Scripts/webkitpy/port/gtk.py:
491         (GtkPort.setup_environ_for_server):
492         * Scripts/webkitpy/port/wpe.py:
493         (WPEPort.setup_environ_for_server):
494
495 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
496
497         Add Basic Django web app for OpenSource EWS
498         https://bugs.webkit.org/show_bug.cgi?id=191091
499
500         Reviewed by Lucas Forschler.
501
502         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
503         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
504         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
505         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
506         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
507         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
508         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
509         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
510         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
511         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
512         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
513         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
514         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
515         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
516
517 2018-11-02  Daniel Bates  <dabates@apple.com>
518
519         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
520         https://bugs.webkit.org/show_bug.cgi?id=190487
521
522         Reviewed by Tim Horton.
523
524         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
525         match my observations when using the simulator to simulate iOS 12 and add support for testing
526         right-hand side modifiers.
527
528         * DumpRenderTree/mac/EventSendingController.mm:
529         (modifierFlags):
530         (-[EventSendingController keyDown:withModifiers:withLocation:]):
531         (-[EventSendingController setTouchModifier:value:]):
532         * WebKitTestRunner/ios/HIDEventGenerator.mm:
533         (hidUsageCodeForCharacter):
534
535 2018-11-02  Chris Dumez  <cdumez@apple.com>
536
537         [PSON] Reuse SuspendedPages' process when possible, for performance
538         https://bugs.webkit.org/show_bug.cgi?id=191166
539
540         Reviewed by Geoffrey Garen.
541
542         Add API test coverage.
543
544         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
545
546 2018-11-02  Zalan Bujtas  <zalan@apple.com>
547
548         [LFC][IFC] Add support for intrinsic width calculation
549         https://bugs.webkit.org/show_bug.cgi?id=191144
550
551         Reviewed by Antti Koivisto.
552
553         * LayoutReloaded/misc/LFC-passing-tests.txt:
554
555 2018-11-01  Philippe Normand  <pnormand@igalia.com>
556
557         [Apache] Self-signed SSL certificate RSA key is considered too weak
558         https://bugs.webkit.org/show_bug.cgi?id=191156
559
560         Reviewed by Michael Catanzaro.
561
562         * Scripts/webkitpy/common/system/pemfile.py:
563
564 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
565
566         Unreviewed follow-up to r237678.
567
568         * wpe/jhbuild.modules: The patch element apparently has to be a child
569         of the branch in order for Jhbuild to properly detect and apply the
570         patch file.
571
572 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
573
574         build-jsc --wincairo should update WinCairo libraries
575         https://bugs.webkit.org/show_bug.cgi?id=191170
576
577         Reviewed by Fujii Hironori.
578
579         * Scripts/build-jsc:
580
581 2018-11-01  John Wilander  <wilander@apple.com>
582
583         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
584         https://bugs.webkit.org/show_bug.cgi?id=191119
585         <rdar://problem/44176965>
586
587         Reviewed by Chris Dumez.
588
589         This is an API test for a WebKitLegacy WebView that is first closed and then
590         JavaScript is handed a keyboard event.
591
592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
593         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
594         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
595         (-[KeyboardEventListener handleEvent:]):
596         (TestWebKitAPI::TEST):
597
598 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
599
600         Add a storage limit for IndexedDB
601         https://bugs.webkit.org/show_bug.cgi?id=190598
602         <rdar://problem/44654715>
603
604         Reviewed by Chris Dumez.
605
606         Add API for testing.
607
608         * DumpRenderTree/TestRunner.cpp:
609         (setIDBPerOriginQuotaCallback):
610         (TestRunner::staticFunctions):
611         * DumpRenderTree/TestRunner.h:
612         * DumpRenderTree/mac/TestRunnerMac.mm:
613         (TestRunner::setIDBPerOriginQuota):
614         * DumpRenderTree/win/TestRunnerWin.cpp:
615         (TestRunner::setIDBPerOriginQuota):
616         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
618         (WTR::TestRunner::setIDBPerOriginQuota):
619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
620         * WebKitTestRunner/TestController.cpp:
621         (WTR::TestController::setIDBPerOriginQuota):
622         * WebKitTestRunner/TestController.h:
623         * WebKitTestRunner/TestInvocation.cpp:
624         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
625
626 2018-11-01  Chris Dumez  <cdumez@apple.com>
627
628         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
629         https://bugs.webkit.org/show_bug.cgi?id=191076
630
631         Reviewed by Geoffrey Garen.
632
633         Add API test coverage.
634
635         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
636         (-[PSONNavigationDelegate init]):
637         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
638
639 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
640
641         Fix build with VIDEO and WEB_AUDIO disabled
642         https://bugs.webkit.org/show_bug.cgi?id=191147
643         <rdar://problem/45726710>
644
645         Unreviewed build fix.
646
647         This adds the missing compilation guards in the WPE MiniBrowser.
648
649         * MiniBrowser/wpe/main.cpp:
650         (main): Condition GST includes and calls.
651
652 2018-10-31  Zalan Bujtas  <zalan@apple.com>
653
654         [LFC][IFC] Add support for inline-block elements.
655         https://bugs.webkit.org/show_bug.cgi?id=191143
656
657         Reviewed by Antti Koivisto.
658
659         * LayoutReloaded/misc/LFC-passing-tests.txt:
660
661 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
662
663         [WPE] Add missing libsoup patch to jhbuild
664         https://bugs.webkit.org/show_bug.cgi?id=191149
665
666         Reviewed by Žan Doberšek.
667
668         * wpe/jhbuild.modules:
669         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
670
671 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
672
673         Fix build with VIDEO and WEB_AUDIO disabled
674         https://bugs.webkit.org/show_bug.cgi?id=191147
675
676         Reviewed by Philippe Normand.
677
678         * MiniBrowser/gtk/main.c:
679         (main): Condition GST includes and calls
680
681 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
682
683         Add Justin Michaud to the list of WebKit Committers
684         https://bugs.webkit.org/show_bug.cgi?id=191142
685
686         * Scripts/webkitpy/common/config/contributors.json:
687
688 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
689
690         Don't run JIT tests on 32-bit platforms
691         https://bugs.webkit.org/show_bug.cgi?id=191074
692
693         Reviewed by Michael Catanzaro.
694
695         * Scripts/run-jsc-stress-tests:
696
697 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
698
699         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
700         https://bugs.webkit.org/show_bug.cgi?id=190530
701         <rdar://problem/45232149>
702
703         Reviewed by Tim Horton.
704
705         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
706         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
707         is equivalent to the original file wrappers used to insert attachments in the first web view.
708
709         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
710         is still backed by the same NSFileWrapper instance.
711
712         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
713         (TestWebKitAPI::TEST):
714
715 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
716
717         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
718         https://bugs.webkit.org/show_bug.cgi?id=190949
719
720         Reviewed by Alex Christensen.
721
722         Visual Studio 2017 Community is the alternative.
723
724         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
725         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
726         (buildVisualStudioProject): Ditto.
727         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
728         (usingVisualStudioExpress): Deleted.
729
730 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
731
732         [Win][Direct2D] Support building DumpRenderTree for Direct2D
733         https://bugs.webkit.org/show_bug.cgi?id=191093
734         <rdar://problem/45685706>
735
736         Unreviewed build fix.
737
738         error C2065: 'renderTarget': undeclared identifier
739
740         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
741         (createBitmapContextFromWebView): Restored the previous implementation.
742
743 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
744
745         [PlayStation] Enable JavaScriptCore
746         https://bugs.webkit.org/show_bug.cgi?id=191072
747
748         Reviewed by Brent Fulgham.
749
750         Add platform scripts for building the PlayStation port.
751         perl Tools/Scripts/build-webkit --playstation
752
753         * Scripts/build-webkit:
754         * Scripts/build-webkittestrunner:
755         * Scripts/webkitdirs.pm:
756         (argumentsForConfiguration):
757         (determineConfigurationProductDir):
758         (isPlayStation): Added.
759         (getMSBuildPlatformArgument): Added.
760         (buildVisualStudioProject):
761         (wrapperPrefixIfNeeded):
762         (generateBuildSystemFromCMakeProject):
763         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
764
765 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
766
767         [Win][Direct2D] Support building DumpRenderTree for Direct2D
768         https://bugs.webkit.org/show_bug.cgi?id=191093
769         <rdar://problem/45685706>
770
771         Reviewed by Alex Christensen.
772
773         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
774         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
775         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
776         (pixelDumpSystemFactory): Added.
777         (printPNG): Create stub.
778         (computeMD5HashStringForBitmapContext): Ditto.
779         (dumpBitmap): Ditto.
780         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
781         (BitmapContext::createByAdoptingBitmapAndContext):
782         (BitmapContext::~BitmapContext):
783         (BitmapContext::platformContext const):
784         (BitmapContext::BitmapContext):
785         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
786         (createBitmapContextFromWebView): Update to support Direct2D.
787         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
788         logo is no longer available at this location. Switch to the new logo.
789
790 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
791
792         webkitpy: Support alternate simctl list outputs
793         https://bugs.webkit.org/show_bug.cgi?id=191090
794         <rdar://problem/45684255>
795
796         Rubber-stamped by Aakash Jain.
797
798         * Scripts/webkitpy/xcode/simulated_device.py:
799         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
800         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
801         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
802         (test_available_devices): Add iOS 12 with alternative availability format.
803
804 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
805
806         Clean up some obsolete MAX_ALLOWED macros
807         https://bugs.webkit.org/show_bug.cgi?id=190916
808
809         Reviewed by Tim Horton.
810
811         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
812         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
813         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
814
815 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
816
817         [GTK][WPE] Fixes to the PublicSuffix implementation
818         https://bugs.webkit.org/show_bug.cgi?id=191031
819
820         Reviewed by Michael Catanzaro.
821
822         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
823         (TestWebKitAPI::TEST_F): Remove a test for a domain
824         that is not registrable and shouldn't be tested there.
825
826 2018-10-29  Tim Horton  <timothy_horton@apple.com>
827
828         Modernize WebKit nibs and lprojs for localization's sake
829         https://bugs.webkit.org/show_bug.cgi?id=190911
830         <rdar://problem/45349466>
831
832         Reviewed by Dan Bernstein.
833
834         * Scripts/check-inspector-strings:
835         * Scripts/update-webkit-localizable-strings:
836         * gtk/manifest.txt.in:
837         * wpe/manifest.txt.in:
838         English->en
839
840 2018-10-29  Daniel Bates  <dabates@apple.com>
841
842         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
843         https://bugs.webkit.org/show_bug.cgi?id=191036
844
845         Reviewed by Andy Estes.
846
847         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
848         by an enum that contains two or more enumerators with the same value. For example, suppose
849         you have the following enum:
850
851         enum Flag {
852             A = 1 << 0,
853             AAlias = A,
854         };
855
856         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
857         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
858         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
859         tend to be used in bounds checks as opposed to code that adds to a set.
860
861         * lldb/lldbWebKitTester/main.cpp:
862         (testSummaryProviders):
863         * lldb/lldb_webkit.py:
864         (WTFOptionSetProvider.update):
865         * lldb/lldb_webkit_unittest.py:
866         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
867         (TestSummaryProviders):
868         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
869
870 2018-10-29  Daniel Bates  <dabates@apple.com>
871
872         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
873         https://bugs.webkit.org/show_bug.cgi?id=191033
874
875         Reviewed by Andy Estes.
876
877         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
878         We display the same details in the summary for a Frame because its Document tends to be the most
879         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
880         and whether the origin has universal access.
881
882         * lldb/lldb_webkit.py:
883         (__lldb_init_module):
884         Register new summary providers.
885
886         (WebCoreSecurityOrigin_SummaryProvider):
887         (WebCoreFrame_SummaryProvider):
888         (WebCoreDocument_SummaryProvider):
889         Add new summary providers.
890
891         (StdOptionalWrapper):
892         (StdOptionalWrapper.__init__):
893         (StdOptionalWrapper.has_value):
894         (StdOptionalWrapper.value):
895         Convenience data type that provides access to the fields of a std::optional<>.
896         
897         (WebCoreSecurityOriginProvider):
898         (WebCoreSecurityOriginProvider.__init__):
899         (WebCoreSecurityOriginProvider.is_unique):
900         (WebCoreSecurityOriginProvider.scheme):
901         (WebCoreSecurityOriginProvider.host):
902         (WebCoreSecurityOriginProvider.port):
903         (WebCoreSecurityOriginProvider.domain):
904         (WebCoreSecurityOriginProvider.has_universal_access):
905         (WebCoreSecurityOriginProvider.to_string):
906         (WebCoreFrameProvider):
907         (WebCoreFrameProvider.__init__):
908         (WebCoreFrameProvider.is_main_frame):
909         (WebCoreFrameProvider.document):
910         (WebCoreDocumentProvider):
911         (WebCoreDocumentProvider.__init__):
912         (WebCoreDocumentProvider.url):
913         (WebCoreDocumentProvider.origin):
914         (WebCoreDocumentProvider.page_cache_state):
915         (WebCoreDocumentProvider.frame):
916
917 2018-10-29  Chris Dumez  <cdumez@apple.com>
918
919         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
920         https://bugs.webkit.org/show_bug.cgi?id=190975
921         <rdar://problem/45059256>
922
923         Reviewed by Antti Koivisto.
924
925         Add API test coverage.
926
927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
928
929 2018-10-29  Zalan Bujtas  <zalan@apple.com>
930
931         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
932         https://bugs.webkit.org/show_bug.cgi?id=191018
933
934         Reviewed by Antti Koivisto.
935
936         * LayoutReloaded/misc/LFC-passing-tests.txt:
937
938 2018-10-29  Zalan Bujtas  <zalan@apple.com>
939
940         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
941         https://bugs.webkit.org/show_bug.cgi?id=191011
942
943         Reviewed by Antti Koivisto.
944
945         * LayoutReloaded/misc/LFC-passing-tests.txt:
946
947 2018-10-29  Zalan Bujtas  <zalan@apple.com>
948
949         Missing from r237549
950
951         Reviewed by Antti Koivisto.
952
953         * LayoutReloaded/misc/LFC-passing-tests.txt:
954
955 2018-10-29  Zalan Bujtas  <zalan@apple.com>
956
957         [LFC][IFC] Add support for simple intruding floats.
958         https://bugs.webkit.org/show_bug.cgi?id=190998
959
960         Reviewed by Antti Koivisto.
961
962         * LayoutReloaded/misc/LFC-passing-tests.txt:
963
964 2018-10-29  Zalan Bujtas  <zalan@apple.com>
965
966         [LFC][IFC] Inline layout produces separate runs when float is present.
967         https://bugs.webkit.org/show_bug.cgi?id=190980
968
969         Reviewed by Antti Koivisto.
970
971         * LayoutReloaded/misc/LFC-passing-tests.txt:
972
973 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
974
975         New bytecode format for JSC
976         https://bugs.webkit.org/show_bug.cgi?id=187373
977         <rdar://problem/44186758>
978
979         Reviewed by Filip Pizlo.
980
981         Do not force ENABLE_JIT=true when $forceCLoop is false.
982
983         * Scripts/build-jsc:
984
985 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
986
987         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
988
989         Unreviewed build fix
990
991         The build fails because of some array-bound check related
992         to strcmp() macro optimizations. Disabling selective Werrors
993         when building xserver-xorg might get past this.
994
995         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
996         configuration.
997
998 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
999
1000         [GTK] Update API test expectations after r237383
1001         https://bugs.webkit.org/show_bug.cgi?id=186913
1002
1003         Unreviewed gardening.
1004
1005         * TestWebKitAPI/glib/TestExpectations.json: Remove
1006         passing TestSSL tests.
1007
1008 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
1009
1010         [WPE] Add the WebKitVersion.h header
1011         https://bugs.webkit.org/show_bug.cgi?id=191015
1012
1013         Reviewed by Michael Catanzaro.
1014
1015         * MiniBrowser/wpe/main.cpp:
1016         (automationStartedCallback): Remove the FIXME and finally enable the
1017         webkit_application_info_set_version() call.
1018         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
1019         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
1020
1021 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1022
1023         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
1024         https://bugs.webkit.org/show_bug.cgi?id=190948
1025
1026         Reviewed by Brent Fulgham.
1027
1028         vcxproj files have been removed in Bug 154388.
1029
1030         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
1031         * Scripts/build-jsc:
1032         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
1033         which is not used because Windows ports are using CMake.
1034
1035 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
1036
1037         HashMap should support selecting a random entry
1038         https://bugs.webkit.org/show_bug.cgi?id=190814
1039
1040         Reviewed by Ryosuke Niwa.
1041
1042         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
1043         IsEvenlyDistributed to reflect the fact that we're only testing the
1044         distribution. Added a test case that covers more table densities and
1045         the remove() operation.
1046
1047 2018-10-27  Charlie Turner  <cturner@igalia.com>
1048
1049         [GTK] Add bubblewrap feature option
1050         https://bugs.webkit.org/show_bug.cgi?id=190981
1051
1052         Reviewed by Xabier Rodriguez-Calvar.
1053
1054         Without this, it was not possible to disable the bubblewrap sandbox
1055         from the webkit build scripts.
1056
1057         * Scripts/webkitperl/FeatureList.pm:
1058
1059 2018-10-26  Commit Queue  <commit-queue@webkit.org>
1060
1061         Unreviewed, rolling out r237479 and r237484.
1062         https://bugs.webkit.org/show_bug.cgi?id=190978
1063
1064         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
1065
1066         Reverted changesets:
1067
1068         "New bytecode format for JSC"
1069         https://bugs.webkit.org/show_bug.cgi?id=187373
1070         https://trac.webkit.org/changeset/237479
1071
1072         "Gardening: Build fix after r237479."
1073         https://bugs.webkit.org/show_bug.cgi?id=187373
1074         https://trac.webkit.org/changeset/237484
1075
1076 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
1077
1078         New bytecode format for JSC
1079         https://bugs.webkit.org/show_bug.cgi?id=187373
1080         <rdar://problem/44186758>
1081
1082         Reviewed by Filip Pizlo.
1083
1084         Do not force ENABLE_JIT=true when $forceCLoop is false.
1085
1086         * Scripts/build-jsc:
1087
1088 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
1089
1090         HashMap should support selecting a random entry
1091         https://bugs.webkit.org/show_bug.cgi?id=190814
1092
1093         Reviewed by Antti Koivisto.
1094
1095         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
1096         more thoroughly test for randomness.
1097
1098 2018-10-26  Antti Koivisto  <antti@apple.com>
1099
1100         hashSet.remove(hashSet.random()) doesn't build
1101         https://bugs.webkit.org/show_bug.cgi?id=190953
1102
1103         Reviewed by Chris Dumez.
1104
1105         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1106         (TestWebKitAPI::TEST):
1107
1108 2018-10-26  Zalan Bujtas  <zalan@apple.com>
1109
1110         [LFC][IFC] Layout floats as part of the inline content
1111         https://bugs.webkit.org/show_bug.cgi?id=190942
1112
1113         Reviewed by Antti Koivisto.
1114
1115         * LayoutReloaded/misc/LFC-passing-tests.txt:
1116
1117 2018-10-26  Alicia Boya García  <aboya@igalia.com>
1118
1119         [MSE][WTF][Media] Invalid MediaTime should be falsy
1120         https://bugs.webkit.org/show_bug.cgi?id=190893
1121
1122         Reviewed by Jer Noble.
1123
1124         This patch adds additional API tests for the conversions from
1125         MediaTime to boolean.
1126
1127         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1128         (TestWebKitAPI::TEST):
1129
1130 2018-10-25  Chris Dumez  <cdumez@apple.com>
1131
1132         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
1133         https://bugs.webkit.org/show_bug.cgi?id=190915
1134         <rdar://problem/45059069>
1135
1136         Reviewed by Geoffrey Garen.
1137
1138         Add API test coverage.
1139
1140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1141
1142 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
1143
1144         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
1145         https://bugs.webkit.org/show_bug.cgi?id=190896
1146
1147         Reviewed by Matt Baker.
1148
1149         * Scripts/webkitpy/common/config/watchlist:
1150
1151 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
1152
1153         HashMap should support selecting a random entry
1154         https://bugs.webkit.org/show_bug.cgi?id=190814
1155
1156         Reviewed by Antti Koivisto.
1157
1158         Unit testing is fun and easy!
1159
1160         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1161         (TestWebKitAPI::ZeroHash::hash):
1162         (TestWebKitAPI::TEST):
1163
1164 2018-10-24  Tim Horton  <timothy_horton@apple.com>
1165
1166         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
1167         https://bugs.webkit.org/show_bug.cgi?id=190897
1168
1169         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1170         (TestWebKitAPI::TEST):
1171         Disable the test for now.
1172
1173 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1174
1175         Clean up some obsolete macOS version guards
1176         https://bugs.webkit.org/show_bug.cgi?id=190887
1177
1178         Reviewed by Dan Bernstein.
1179
1180         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1181         (__simulated_forceClickAssociatedEventsMask):
1182         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
1183         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1184         (WTR::initializeWebViewConfiguration):
1185         * WebKitTestRunner/mac/EventSenderProxy.mm:
1186         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1187
1188 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1189
1190         Turn on Conic Gradients
1191         https://bugs.webkit.org/show_bug.cgi?id=190810
1192
1193         Reviewed by Tim Horton.
1194
1195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1196
1197 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
1198
1199         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
1200         https://bugs.webkit.org/show_bug.cgi?id=190328
1201
1202         Reviewed by Michael Catanzaro.
1203
1204         * TestWebKitAPI/CMakeLists.txt:
1205         * TestWebKitAPI/PlatformWPE.cmake:
1206
1207 2018-10-24  Chris Dumez  <cdumez@apple.com>
1208
1209         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
1210         https://bugs.webkit.org/show_bug.cgi?id=190846
1211         <rdar://problem/45058938>
1212
1213         Reviewed by Antti Koivisto.
1214
1215         Add API test coverage.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1218
1219 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
1220
1221         [GTK] TestSSL failing because of missing libsoup patch
1222         https://bugs.webkit.org/show_bug.cgi?id=190869
1223
1224         Reviewed by Michael Catanzaro.
1225
1226         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
1227         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1228
1229 2018-10-23  Justin Fan  <justin_fan@apple.com>
1230
1231         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
1232         https://bugs.webkit.org/show_bug.cgi?id=190817
1233
1234         Reviewed by Dean Jackson.
1235
1236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1237         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
1238         (TestWebKitAPI::TEST_F):
1239         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1240         (TestWebKitAPI::TEST_F):
1241         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
1242         (TestWebKitAPI::TEST_F):
1243         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1244         (TestWebKitAPI::TEST_F):
1245         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
1246         (TestWebKitAPI::TEST_F):
1247         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
1248
1249 2018-10-23  Chris Dumez  <cdumez@apple.com>
1250
1251         [PSON] Add support for cross-site client-side redirects
1252         https://bugs.webkit.org/show_bug.cgi?id=190806
1253         <rdar://problem/45047344>
1254
1255         Reviewed by Geoffrey Garen.
1256
1257         Add API test coverage.
1258
1259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1260         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
1261         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
1262
1263 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
1264
1265         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
1266         https://bugs.webkit.org/show_bug.cgi?id=190789
1267
1268         Reviewed by Michael Catanzaro.
1269
1270         When the network process serializes certificate data to other
1271         processes through the argument coders, the certificate chain, if
1272         present, is lost. In practice this means that applications using
1273         the public API to process certificate info have no details on the
1274         certificate chain, other than the very basics included in the
1275         certificate. Serialize the entire chain if available in the
1276         certificate.
1277
1278         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1279         (testSSL): Test that the self-signed certificate has no bogus
1280         issuer certificate.
1281
1282 2018-10-22  Tim Horton  <timothy_horton@apple.com>
1283
1284         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
1285         https://bugs.webkit.org/show_bug.cgi?id=190801
1286         <rdar://problem/43674361>
1287
1288         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
1289         (TEST):
1290         Use a parented WKWebView for this test, otherwise none of the assertions
1291         about gesture recognizers work anymore.
1292
1293 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
1294
1295         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
1296         https://bugs.webkit.org/show_bug.cgi?id=187972
1297
1298         Unreviewed test gardening.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1301         (TestWebKitAPI::TEST): Disable the flaky test.
1302
1303 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1304
1305         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
1306         https://bugs.webkit.org/show_bug.cgi?id=190777
1307
1308         Reviewed by Tim Horton.
1309
1310         Implement isShowingDataListSuggestions on iOS. See below for more details.
1311
1312         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1313         (WTR::UIScriptController::isShowingDataListSuggestions const):
1314
1315         Add a stub implementation for DumpRenderTree.
1316
1317         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1318         (WTR::UIScriptController::isShowingDataListSuggestions const):
1319
1320         Move this stub implementation to !PLATFORM(COCOA).
1321
1322         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1323         (WTR::forEachViewInHierarchy):
1324
1325         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
1326
1327         (WTR::UIScriptController::isShowingDataListSuggestions const):
1328
1329         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
1330
1331 2018-10-19  Dan Bernstein  <mitz@apple.com>
1332
1333         [macOS] MiniBrowser has an unused injected bundle
1334         https://bugs.webkit.org/show_bug.cgi?id=190770
1335
1336         Reviewed by Tim Horton.
1337
1338         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
1339         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
1340           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
1341         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
1342         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
1343         * MiniBrowser/mac/Bundle: Removed.
1344
1345 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1346
1347         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
1348         https://bugs.webkit.org/show_bug.cgi?id=190621
1349         <rdar://problem/45310649>
1350
1351         Reviewed by Tim Horton.
1352
1353         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
1354
1355         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1356         (WTR::UIScriptController::resignFirstResponder):
1357         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1358         (WTR::UIScriptController::resignFirstResponder):
1359         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1360         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1361         (WTR::UIScriptController::resignFirstResponder):
1362         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1363         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1364         (WTR::UIScriptController::resignFirstResponder):
1365         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1366         (WTR::PlatformWebView::makeWebViewFirstResponder):
1367
1368         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
1369         responder on the WKWebView when running iOS layout tests.
1370
1371         * WebKitTestRunner/ios/TestControllerIOS.mm:
1372         (WTR::TestController::platformResetStateToConsistentValues):
1373
1374         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
1375
1376 2018-10-19  Dean Jackson  <dino@apple.com>
1377
1378         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
1379         https://bugs.webkit.org/show_bug.cgi?id=186946
1380         <rdar://problem/41724248>
1381
1382         Reviewed by Antoine Quint.
1383
1384         If the incoming test has different enableWebAnimationsCSSIntegration options,
1385         then we need to create a new WebView.
1386
1387         * DumpRenderTree/TestOptions.cpp:
1388         (TestOptions::webViewIsCompatibleWithOptions const):
1389
1390 2018-10-19  Charlie Turner  <cturner@igalia.com>
1391
1392         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
1393         https://bugs.webkit.org/show_bug.cgi?id=190738
1394
1395         Reviewed by Xabier Rodriguez-Calvar.
1396
1397         Add a GStreamer patch to avoid crashing when the run-time logging
1398         level is TRACE. There was a missing null check which caused many
1399         tests to crash.
1400
1401         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
1402
1403 2018-10-18  Alicia Boya García  <aboya@igalia.com>
1404
1405         [Media] Use nanoseconds as MaximumTimeScale
1406         https://bugs.webkit.org/show_bug.cgi?id=190631
1407
1408         Rebased MediaTime tests covering timescales over the maximum.
1409
1410         Reviewed by Jer Noble.
1411
1412         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1413         (TestWebKitAPI::TEST):
1414
1415 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
1416
1417         clean-webkit pulls in many unnecessary dependencies in webkitpy
1418         https://bugs.webkit.org/show_bug.cgi?id=190732
1419
1420         Reviewed by Alexey Proskuryakov.
1421
1422         * Scripts/webkitpy/common/host.py:
1423         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
1424         (Host):
1425         (Host.bugs):
1426         (Host.bugzilla):
1427         (Host.web):
1428
1429 2018-10-18  Chris Dumez  <cdumez@apple.com>
1430
1431         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
1432         https://bugs.webkit.org/show_bug.cgi?id=190721
1433         <rdar://problem/45059699>
1434
1435         Reviewed by Alex Christensen.
1436
1437         Add API test coverage.
1438
1439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1440
1441 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1442
1443         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1444         https://bugs.webkit.org/show_bug.cgi?id=190729
1445
1446         Reviewed by Tim Horton.
1447
1448         * DumpRenderTree/AccessibilityController.h:
1449         * DumpRenderTree/AccessibilityTextMarker.h:
1450         * DumpRenderTree/AccessibilityUIElement.cpp:
1451         (AccessibilityUIElement::getJSClass):
1452         * DumpRenderTree/AccessibilityUIElement.h:
1453         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1454         * DumpRenderTree/TestRunner.cpp:
1455         (getSecureEventInputIsEnabledCallback):
1456         (TestRunner::staticFunctions):
1457         (TestRunner::callUIScriptCallback):
1458         * DumpRenderTree/TestRunner.h:
1459         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1460         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
1461         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1462         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
1463         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1464         * DumpRenderTree/ios/TextInputControllerIOS.m:
1465         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1466         * DumpRenderTree/mac/AppleScriptController.m:
1467         * DumpRenderTree/mac/DumpRenderTree.mm:
1468         (createWebViewAndOffscreenWindow):
1469         (destroyWebViewAndOffscreenWindow):
1470         (resetWebPreferencesToConsistentValues):
1471         (setDefaultsToConsistentValuesForTesting):
1472         (allocateGlobalControllers):
1473         (releaseGlobalControllers):
1474         (addTestPluginsToPluginSearchPath):
1475         (prepareConsistentTestingEnvironment):
1476         (dumpRenderTree):
1477         (DumpRenderTreeMain):
1478         (dumpFrameAsPDF):
1479         (dumpBackForwardListForAllWindows):
1480         (updateDisplay):
1481         (dump):
1482         (resetWebViewToConsistentStateBeforeTesting):
1483         (runTest):
1484         (displayWebView):
1485         (displayAndTrackRepaintsWebView):
1486         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1487         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1488         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1489         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1490         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1491         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1492         (-[DumpRenderTreeWindow close]):
1493         (-[DumpRenderTreeWindow webView]):
1494         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
1495         * DumpRenderTree/mac/EventSendingController.h:
1496         * DumpRenderTree/mac/EventSendingController.mm:
1497         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1498         (+[EventSendingController webScriptNameForSelector:]):
1499         (-[EventSendingController dealloc]):
1500         (-[EventSendingController currentEventTime]):
1501         (-[EventSendingController clearKillRing]):
1502         (modifierFlags):
1503         (-[EventSendingController mouseDown:withModifiers:]):
1504         (-[EventSendingController scalePageBy:atX:andY:]):
1505         (-[EventSendingController mouseUp:withModifiers:]):
1506         (-[EventSendingController mouseMoveToX:Y:]):
1507         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1508         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1509         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1510         (-[FrameLoadDelegate init]):
1511         (-[FrameLoadDelegate dealloc]):
1512         (-[FrameLoadDelegate processWork:]):
1513         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1514         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1515         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1516         * DumpRenderTree/mac/LayoutTestHelper.m:
1517         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1518         (-[MockGeolocationProvider timerFired]):
1519         * DumpRenderTree/mac/TestRunnerMac.mm:
1520         (TestRunner::setMainFrameIsFirstResponder):
1521         (TestRunner::setAutomaticLinkDetectionEnabled):
1522         (TestRunner::setUseDashboardCompatibilityMode):
1523         (TestRunner::isCommandEnabled):
1524         (TestRunner::inspectorTestStubURL):
1525         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1526         (TestRunner::abortModal):
1527         (TestRunner::setTextDirection):
1528         (TestRunner::addChromeInputField):
1529         (TestRunner::removeChromeInputField):
1530         (TestRunner::focusWebView):
1531         (TestRunner::setBackingScaleFactor):
1532         (TestRunner::imageCountInGeneralPasteboard const):
1533         * DumpRenderTree/mac/UIDelegate.h:
1534         * DumpRenderTree/mac/UIDelegate.mm:
1535         (-[UIDelegate modalWindowWillClose:]):
1536         (-[UIDelegate webViewRunModal:]):
1537         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1538         (-[UIDelegate dealloc]):
1539         * Scripts/check-for-inappropriate-objc-class-names:
1540         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1541         * TestRunnerShared/spi/UIKitTestSPI.h:
1542         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
1543         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
1544         (WebCore::operator<<):
1545         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1546         (TestWebKitAPI::TEST):
1547         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1548         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1549         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
1550         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
1551         (TestWebKitAPI::TEST):
1552         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1553         (TestWebKitAPI::TEST):
1554         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
1555         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1556         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1557         (TEST):
1558         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
1559         (TEST):
1560         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
1561         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1562         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1563         (TEST):
1564         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1565         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1566         (createWebViewWithCustomPasteboardDataEnabled):
1567         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
1568         (TEST):
1569         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
1570         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
1571         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1572         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1573         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1574         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
1575         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
1576         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
1577         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
1578         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
1579         (defaultWebsiteCacheDirectory):
1580         (defaultApplicationCacheDirectory):
1581         (TEST):
1582         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
1583         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
1584         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1585         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1586         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1587         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1588         (TestWebKitAPI::TEST):
1589         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
1590         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1591         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
1592         (runTestWithWidth):
1593         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
1594         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
1595         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1596         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
1597         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1598         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
1599         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1600         (platformCopyRichTextWithMultipleAttachments):
1601         (platformCopyRichTextWithImage):
1602         (platformCopyPNG):
1603         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1604         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1605         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1606         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
1607         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1608         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1609         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1610         (TEST):
1611         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1612         (TEST):
1613         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1614         (TEST):
1615         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
1616         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1617         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
1618         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
1619         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1620         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1621         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1622         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1623         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1624         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1625         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1626         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
1627         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
1628         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1629         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1630         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
1631         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1632         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
1633         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
1634         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1635         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
1636         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1637         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1638         (-[WKWebView _test_waitForDidFinishNavigation]):
1639         * TestWebKitAPI/cocoa/TestWKWebView.h:
1640         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1641         * TestWebKitAPI/config.h:
1642         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1643         * TestWebKitAPI/ios/TestWKWebViewController.h:
1644         * TestWebKitAPI/ios/TestWKWebViewController.mm:
1645         * TestWebKitAPI/ios/UIKitSPI.h:
1646         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1647         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1648         (WTR::InjectedBundle::beginTesting):
1649         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1650         (WTR::TestRunner::inspectorTestStubURL):
1651         * WebKitTestRunner/TestController.cpp:
1652         (WTR::TestController::webProcessName):
1653         (WTR::TestController::networkProcessName):
1654         * WebKitTestRunner/TestInvocation.cpp:
1655         (WTR::TestInvocation::invoke):
1656         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1657         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1658         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1659         (WTR::initializeWebViewConfiguration):
1660         (WTR::TestController::platformCreateWebView):
1661         (WTR::TestController::imageCountInGeneralPasteboard const):
1662         (WTR::TestController::addTestKeyToKeychain):
1663         (WTR::TestController::cleanUpKeychain):
1664         (WTR::TestController::keyExistsInKeychain):
1665         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1666         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1667         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1668
1669 2018-10-18  Chris Dumez  <cdumez@apple.com>
1670
1671         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
1672         https://bugs.webkit.org/show_bug.cgi?id=190688
1673         <rdar://problem/45354095>
1674
1675         Reviewed by Antti Koivisto.
1676
1677         Extended API test coverage to confirm that:
1678         - We do not accumulate more than 3 suspended processes.
1679         - We can navigate back 3 times and use the page cache for each of these loads.
1680
1681         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1682
1683 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1684
1685         Enable the datalist element by default on iOS and macOS
1686         https://bugs.webkit.org/show_bug.cgi?id=190594
1687         <rdar://problem/45281159>
1688
1689         Reviewed by Ryosuke Niwa and Tim Horton.
1690
1691         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1692
1693 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
1694
1695         AX: Certain tags should identify their context to iOS API
1696         https://bugs.webkit.org/show_bug.cgi?id=190622
1697         <rdar://problem/45308194>
1698
1699         Reviewed by Zalan Bujtas.
1700
1701         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1702         (AccessibilityUIElement::stringAttributeValue):
1703         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1704         (WTR::AccessibilityUIElement::stringAttributeValue):
1705
1706 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
1707
1708         Add a switch for Web SQL
1709         https://bugs.webkit.org/show_bug.cgi?id=190271
1710
1711         Reviewed by Ryosuke Niwa.
1712
1713         * WebKitTestRunner/TestController.cpp:
1714         (WTR::TestController::resetPreferencesToConsistentValues):
1715
1716 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1717
1718         Remove InjectedBundleBackForwardList
1719         https://bugs.webkit.org/show_bug.cgi?id=190640
1720
1721         Reviewed by Chris Dumez.
1722
1723         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1724         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
1725         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1726         (WTR::InjectedBundlePage::prepare):
1727         (WTR::InjectedBundlePage::dumpHistory):
1728         (WTR::hasPrefix): Deleted.
1729         (WTR::compareByTargetName): Deleted.
1730         (WTR::dumpBackForwardListItem): Deleted.
1731         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
1732         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1733         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1734         (WTR::TestRunner::clearBackForwardList):
1735
1736 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
1737
1738         Unreviewed, added myself to contributors.json.
1739
1740         * Scripts/webkitpy/common/config/contributors.json:
1741
1742 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1743
1744         Implement feature flag and bindings for CSS Painting API
1745         https://bugs.webkit.org/show_bug.cgi?id=190237
1746
1747         Reviewed by Ryosuke Niwa.
1748
1749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1750
1751 2018-10-16  Philippe Normand  <pnormand@igalia.com>
1752
1753         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
1754
1755         * gstreamer/jhbuild.modules:
1756
1757 2018-10-16  Philippe Normand  <pnormand@igalia.com>
1758
1759         [GTK][JHBuild] Disable libmount support in glib
1760
1761         Rubber-stamped by Alejandro G. Castro.
1762
1763         This feature doesn't seem required for our setup.
1764
1765         * gtk/jhbuild.modules:
1766
1767 2018-10-15  Justin Fan  <justin_fan@apple.com>
1768
1769         Add WebGPU 2018 feature flag and experimental feature flag
1770         https://bugs.webkit.org/show_bug.cgi?id=190509
1771
1772         Reviewed by Dean Jackson.
1773
1774         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1775         for the 2018 WebGPU prototype.
1776
1777         * DumpRenderTree/TestOptions.cpp:
1778         (TestOptions::TestOptions):
1779         * DumpRenderTree/TestOptions.h:
1780         * DumpRenderTree/mac/DumpRenderTree.mm:
1781         (setWebPreferencesForTestOptions):
1782         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1783
1784 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
1785
1786         Update bot configuration for Sierra archive queues
1787         https://bugs.webkit.org/show_bug.cgi?id=190605
1788
1789         Reviewed by Aakash Jain.
1790
1791         * BuildSlaveSupport/build.webkit.org-config/config.json:
1792
1793 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1794
1795         Add support for prefers-color-scheme media query
1796         https://bugs.webkit.org/show_bug.cgi?id=190499
1797         rdar://problem/45212025
1798
1799         Reviewed by Dean Jackson.
1800
1801         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
1802         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1803
1804 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
1805
1806         [JHBuild] Add xdg-dbus-proxy module
1807         https://bugs.webkit.org/show_bug.cgi?id=190589
1808
1809         Reviewed by Michael Catanzaro.
1810
1811         * gtk/jhbuild.modules:
1812
1813 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
1814
1815         [GTK] Add new sandboxing dependencies to install-dependencies
1816         https://bugs.webkit.org/show_bug.cgi?id=190588
1817
1818         Reviewed by Michael Catanzaro.
1819
1820         * gtk/install-dependencies:
1821
1822 2018-10-15  Chris Dumez  <cdumez@apple.com>
1823
1824         Experiment: target=_blank on anchors should imply rel=noopener
1825         https://bugs.webkit.org/show_bug.cgi?id=190481
1826
1827         Reviewed by Alex Christensen.
1828
1829         Add API test coverage to make sure we can now swap process when target=_blank
1830         is specified on an anchor but rel=noopener is not.
1831
1832         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1833
1834 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1835
1836         [iOS] Can't select text after dismissing the keyboard when changing focus
1837         https://bugs.webkit.org/show_bug.cgi?id=190563
1838         <rdar://problem/44613559>
1839
1840         Reviewed by Tim Horton.
1841
1842         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1843         (WTR::UIScriptController::isShowingKeyboard const):
1844
1845         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
1846         details.
1847
1848         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1849         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1850         (WTR::UIScriptController::isShowingKeyboard const):
1851         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1852         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1853         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1854
1855         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
1856         `isShowingKeyboard` as the getter method.
1857
1858         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
1859         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
1860         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1861         (WTR::UIScriptController::isShowingKeyboard const):
1862
1863 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
1864
1865         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
1866
1867         * Scripts/run-javascriptcore-tests:
1868         (runJSCStressTests): Remove wsl-tests.yaml.
1869
1870 2018-10-15  Christopher Reid  <chris.reid@sony.com>
1871
1872         [Curl][WinCairo] Add Public Suffix support to WinCairo
1873         https://bugs.webkit.org/show_bug.cgi?id=183060
1874
1875         Reviewed by Alex Christensen.
1876
1877         Share mac's PublicSuffix tests with all ports.
1878
1879         * TestWebKitAPI/PlatformWin.cmake:
1880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1881         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
1882         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
1883
1884 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
1885
1886         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
1887         https://bugs.webkit.org/show_bug.cgi?id=190555
1888
1889         Unreviewed.
1890
1891         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
1892
1893         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
1894         * WebGPUShadingLanguageRI/All.js: Removed.
1895         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
1896         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
1897         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
1898         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
1899         * WebGPUShadingLanguageRI/Assignment.js: Removed.
1900         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
1901         * WebGPUShadingLanguageRI/Block.js: Removed.
1902         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
1903         * WebGPUShadingLanguageRI/Break.js: Removed.
1904         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
1905         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
1906         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
1907         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
1908         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
1909         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
1910         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
1911         * WebGPUShadingLanguageRI/Casts.js: Removed.
1912         * WebGPUShadingLanguageRI/Check.js: Removed.
1913         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
1914         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
1915         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
1916         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
1917         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
1918         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
1919         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
1920         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
1921         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
1922         * WebGPUShadingLanguageRI/Checker.js: Removed.
1923         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
1924         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
1925         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
1926         * WebGPUShadingLanguageRI/Continue.js: Removed.
1927         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
1928         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
1929         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
1930         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
1931         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
1932         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
1933         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
1934         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
1935         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
1936         * WebGPUShadingLanguageRI/EPtr.js: Removed.
1937         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
1938         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
1939         * WebGPUShadingLanguageRI/EnumType.js: Removed.
1940         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
1941         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
1942         * WebGPUShadingLanguageRI/Expression.js: Removed.
1943         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
1944         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
1945         * WebGPUShadingLanguageRI/Field.js: Removed.
1946         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
1947         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
1948         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
1949         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
1950         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
1951         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
1952         * WebGPUShadingLanguageRI/Func.js: Removed.
1953         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
1954         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
1955         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
1956         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
1957         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
1958         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
1959         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
1960         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
1961         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
1962         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
1963         * WebGPUShadingLanguageRI/Inline.js: Removed.
1964         * WebGPUShadingLanguageRI/Inliner.js: Removed.
1965         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
1966         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
1967         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
1968         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
1969         * WebGPUShadingLanguageRI/Lexer.js: Removed.
1970         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
1971         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
1972         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
1973         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
1974         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
1975         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
1976         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
1977         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
1978         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
1979         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
1980         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
1981         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
1982         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
1983         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
1984         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
1985         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
1986         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
1987         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
1988         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
1989         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
1990         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
1991         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
1992         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
1993         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
1994         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
1995         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
1996         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
1997         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
1998         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
1999         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
2000         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
2001         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
2002         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
2003         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
2004         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
2005         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
2006         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
2007         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
2008         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
2009         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
2010         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
2011         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
2012         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
2013         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
2014         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
2015         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
2016         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
2017         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
2018         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
2019         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
2020         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
2021         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
2022         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
2023         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
2024         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
2025         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
2026         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
2027         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
2028         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
2029         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
2030         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
2031         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
2032         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
2033         * WebGPUShadingLanguageRI/NameContext.js: Removed.
2034         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
2035         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
2036         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
2037         * WebGPUShadingLanguageRI/NativeType.js: Removed.
2038         * WebGPUShadingLanguageRI/Node.js: Removed.
2039         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
2040         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
2041         * WebGPUShadingLanguageRI/NullType.js: Removed.
2042         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
2043         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
2044         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
2045         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
2046         * WebGPUShadingLanguageRI/Parse.js: Removed.
2047         * WebGPUShadingLanguageRI/Prepare.js: Removed.
2048         * WebGPUShadingLanguageRI/Program.js: Removed.
2049         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
2050         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
2051         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
2052         * WebGPUShadingLanguageRI/PtrType.js: Removed.
2053         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
2054         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
2055         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
2056         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
2057         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
2058         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
2059         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
2060         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
2061         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
2062         * WebGPUShadingLanguageRI/Return.js: Removed.
2063         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
2064         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
2065         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
2066         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
2067         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
2068         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
2069         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
2070         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
2071         * WebGPUShadingLanguageRI/Sampler.js: Removed.
2072         * WebGPUShadingLanguageRI/Semantic.js: Removed.
2073         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
2074         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
2075         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
2076         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
2077         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
2078         * WebGPUShadingLanguageRI/StructType.js: Removed.
2079         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
2080         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
2081         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
2082         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
2083         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
2084         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
2085         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
2086         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
2087         * WebGPUShadingLanguageRI/Test.html: Removed.
2088         * WebGPUShadingLanguageRI/Test.js: Removed.
2089         * WebGPUShadingLanguageRI/Texture.js: Removed.
2090         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
2091         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
2092         * WebGPUShadingLanguageRI/Type.js: Removed.
2093         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
2094         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
2095         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
2096         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
2097         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
2098         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
2099         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
2100         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
2101         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
2102         * WebGPUShadingLanguageRI/Value.js: Removed.
2103         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
2104         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
2105         * WebGPUShadingLanguageRI/VectorType.js: Removed.
2106         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
2107         * WebGPUShadingLanguageRI/Visitor.js: Removed.
2108         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
2109         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
2110         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
2111         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
2112         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
2113         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
2114         * WebGPUShadingLanguageRI/index.html: Removed.
2115         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
2116         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
2117
2118 2018-10-15  Philippe Normand  <pnormand@igalia.com>
2119
2120         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
2121         https://bugs.webkit.org/show_bug.cgi?id=190581
2122
2123         Reviewed by Michael Catanzaro.
2124
2125         These bots don't use JHBuild and their host GStreamer version is
2126         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
2127
2128         * BuildSlaveSupport/build.webkit.org-config/config.json:
2129
2130 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2131
2132         Use pragma once in WTF
2133         https://bugs.webkit.org/show_bug.cgi?id=190527
2134
2135         Reviewed by Chris Dumez.
2136
2137         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
2138
2139         * DumpRenderTree/TestRunner.cpp:
2140         (TestRunner::queueLoadHTMLString):
2141         (TestRunner::queueLoadAlternateHTMLString):
2142         (TestRunner::queueBackNavigation):
2143         (TestRunner::queueForwardNavigation):
2144         (TestRunner::queueLoadingScript):
2145         (TestRunner::queueNonLoadingScript):
2146         (TestRunner::queueReload):
2147         * DumpRenderTree/WorkQueue.cpp:
2148         (WorkQueue::singleton): Deleted.
2149         (WorkQueue::WorkQueue): Deleted.
2150         (WorkQueue::queue): Deleted.
2151         (WorkQueue::dequeue): Deleted.
2152         (WorkQueue::count): Deleted.
2153         (WorkQueue::clear): Deleted.
2154         (WorkQueue::processWork): Deleted.
2155         * DumpRenderTree/WorkQueue.h:
2156         (WorkQueue::setFrozen): Deleted.
2157         * DumpRenderTree/WorkQueueItem.h:
2158         * DumpRenderTree/mac/DumpRenderTree.mm:
2159         (runTest):
2160         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2161         (-[FrameLoadDelegate processWork:]):
2162         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2163         * DumpRenderTree/mac/TestRunnerMac.mm:
2164         (TestRunner::notifyDone):
2165         (TestRunner::forceImmediateCompletion):
2166         (TestRunner::queueLoad):
2167         * DumpRenderTree/win/DumpRenderTree.cpp:
2168         (runTest):
2169         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2170         (FrameLoadDelegate::processWork):
2171         (FrameLoadDelegate::locationChangeDone):
2172         * DumpRenderTree/win/TestRunnerWin.cpp:
2173         (TestRunner::notifyDone):
2174         (TestRunner::forceImmediateCompletion):
2175         (TestRunner::queueLoad):
2176
2177 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2178
2179         [JSC] Remove Option::useAsyncIterator
2180         https://bugs.webkit.org/show_bug.cgi?id=190567
2181
2182         Reviewed by Saam Barati.
2183
2184         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2185
2186 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
2187
2188         [WPE] Silence a unused-parameter warning
2189
2190         Unreviewed.
2191         * MiniBrowser/wpe/main.cpp:
2192         (decidePermissionRequest):
2193
2194 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
2195
2196         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
2197         https://bugs.webkit.org/show_bug.cgi?id=190537
2198
2199         Reviewed by Alexey Proskuryakov.
2200
2201         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
2202         needs to be split before adding it to the command since it is treated
2203         as a list of args.
2204
2205         * Scripts/webkitpy/common/config/ports.py:
2206         (DeprecatedPort.run_javascriptcore_tests_command):
2207
2208 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2209
2210         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
2211         https://bugs.webkit.org/show_bug.cgi?id=190504
2212         <rdar://problem/45117760>
2213
2214         Reviewed by Tim Horton.
2215
2216         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
2217         macOS and iOS.
2218
2219         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2220         (WTR::UIScriptController::setViewScale):
2221         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2222         (WTR::UIScriptController::setViewScale):
2223         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2224         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2225         (WTR::UIScriptController::setViewScale):
2226         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2227         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
2228
2229         Add a new file for UIScriptController methods on Cocoa platforms.
2230
2231         (WTR::UIScriptController::setViewScale):
2232         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2233         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2234         (WTR::TestController::cocoaResetStateToConsistentValues):
2235
2236         Ensure that _viewScale is reset to 1 after running a layout test.
2237
2238 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
2239
2240         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
2241         https://bugs.webkit.org/show_bug.cgi?id=190536
2242
2243         Reviewed by Alexey Proskuryakov.
2244
2245         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
2246
2247 2018-10-11  Youenn Fablet  <youenn@apple.com>
2248
2249         IOS 12 - Service worker cache not shared when added to homescreen
2250         https://bugs.webkit.org/show_bug.cgi?id=190269
2251         <rdar://problem/45009961>
2252
2253         Reviewed by Alex Christensen.
2254
2255         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2256         Add test to ensure that CacheStorage use the default website data store parameters.
2257
2258 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2259
2260         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
2261         https://bugs.webkit.org/show_bug.cgi?id=190476
2262         <rdar://problem/32757191>
2263
2264         Reviewed by Megan Gardner.
2265
2266         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
2267         (TEST):
2268         Add a test that we don't crash.
2269
2270 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2271
2272         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
2273
2274         * Scripts/webkitpy/tool/steps/options.py:
2275         (Options):
2276         Fix the name of the variable that the --cc-radar option writes into.
2277
2278 2018-10-10  Dean Jackson  <dino@apple.com>
2279
2280         Add --cc-radar option to webkit-patch bug creation
2281         https://bugs.webkit.org/show_bug.cgi?id=190451
2282         <rdar://problem/45176671>
2283
2284         Reviewed by Antoine Quint.
2285
2286         Add a new command line option to automatically
2287         CC radar to new or updated bugs.
2288
2289         * Scripts/webkitpy/tool/commands/commandtest.py:
2290         (CommandsTest.assert_execute_outputs):
2291         * Scripts/webkitpy/tool/commands/upload.py:
2292         (CreateBug.__init__):
2293         (CreateBug.execute):
2294         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2295         (test_prepare_with_cc):
2296         (test_prepare_with_radar):
2297         (test_prepare_with_cc_and_radar):
2298         * Scripts/webkitpy/tool/steps/createbug.py:
2299         (CreateBug.options):
2300         (CreateBug.run):
2301         * Scripts/webkitpy/tool/steps/options.py:
2302         (Options):
2303
2304 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
2305
2306         [GStreamer] Do not build gstgtk plugins
2307         https://bugs.webkit.org/show_bug.cgi?id=190463
2308
2309         Reviewed by Xabier Rodriguez-Calvar.
2310
2311         These plugins pull a GTK+ dependency that, at least in WPE,
2312         is unnecessary. The GTK+ port doesn't need it either, as far
2313         as I can tell.
2314
2315         * gstreamer/jhbuild.modules: Disable gstgtk plugins
2316
2317 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
2318
2319         [GTK][WPE] Add mediaDevices.enumerateDevices support
2320         https://bugs.webkit.org/show_bug.cgi?id=185761
2321
2322         Reviewed by Youenn Fablet.
2323
2324         Added new API test for the mediaDevices.enumerateDevices:
2325         usermedia-enumeratedevices-permission-check. And a new API test
2326         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
2327
2328         * MiniBrowser/gtk/main.c:
2329         (gotWebsiteDataCallback): Added a new section to the about:data
2330         webpage to include the information about the hash salt.
2331         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2332         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
2333         new test checking the enumerateDevices API when permission is
2334         denied and when permission is allowed for the origin.
2335         (beforeAll): Defined the new test.
2336         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2337         (serverCallback): Register a new URI for the enumerateDevices.
2338         (testWebsiteDataConfiguration): Remove the hash salts from the
2339         directories.
2340         (testWebsiteDataDeviceIdHashSalt): New test cheking the
2341         enumerateDevices API.
2342         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
2343         the init structure.
2344         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2345         (WebViewTest::initializeWebView): Make sure the media-stream is
2346         activated in the webView.
2347
2348 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2349
2350         Add WinCairo to the flakiness dashboard
2351         https://bugs.webkit.org/show_bug.cgi?id=188345
2352
2353         Reviewed by Lucas Forschler.
2354
2355         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
2356         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
2357
2358 2018-10-10  Dean Jackson  <dino@apple.com>
2359
2360         [WHSL -> MSL] Annotate semantics correctly in generated MSL
2361         https://bugs.webkit.org/show_bug.cgi?id=190452
2362         <rdar://problem/45178272>
2363
2364         Reviewed by Myles Maxfield.
2365
2366         Correctly label the appropriate semantics as [[position]]
2367         and [[color(N)]].
2368
2369         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
2370         and color attributes. Also use the semantic's index rather than
2371         a counter.
2372         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
2373         output, and only include the actual shader code.
2374
2375 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
2376
2377         build-webkit --inspector-frontend shouldn't have a nonzero exit code
2378         https://bugs.webkit.org/show_bug.cgi?id=190430
2379
2380         Reviewed by Brian Burg.
2381
2382         * Scripts/webkitdirs.pm:
2383         (argumentsForConfiguration):
2384         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
2385         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
2386
2387 2018-10-10  Tim Horton  <timothy_horton@apple.com>
2388
2389         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
2390         https://bugs.webkit.org/show_bug.cgi?id=190420
2391
2392         Reviewed by Simon Fraser.
2393
2394         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2395         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2396         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
2397         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2398         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2399         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2400         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2401         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2402         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
2403         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2404         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2405         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2406         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
2407         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2408         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2409         Change the testing mechanism for the share sheet such that we up-front
2410         set that it should immediately return with a particular state, instead
2411         of programmatically dismissing the sheet.
2412
2413         Otherwise, running the tests on macOS doesn't work, because we pop
2414         a context menu, which spins the runloop and prevents dismissal from
2415         going through.
2416
2417 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2418
2419         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2420         https://bugs.webkit.org/show_bug.cgi?id=190429
2421
2422         Reviewed by Saam Barati.
2423
2424         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
2425         (TestWebKitAPI::TEST_F):
2426
2427 2018-10-10  Chris Dumez  <cdumez@apple.com>
2428
2429         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
2430         https://bugs.webkit.org/show_bug.cgi?id=190418
2431         <rdar://problem/45059769>
2432
2433         Reviewed by Geoffrey Garen.
2434
2435         Add API test coverage.
2436
2437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2438
2439 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
2440
2441         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
2442         https://bugs.webkit.org/show_bug.cgi?id=190191
2443
2444         Reviewed by Michael Catanzaro.
2445
2446         * QueueStatusServer/config/queues.py:
2447         * Scripts/webkitpy/common/config/ews.json:
2448         * Scripts/webkitpy/common/config/ports.py:
2449         (DeprecatedPort.run_javascriptcore_tests_command):
2450         Add the possibility to pass arguments to run-javascriptcore-tests with
2451         the JSCTESTS_OPTIONS environment variable
2452         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2453         (test_ews_name):
2454
2455
2456 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
2457
2458         Allow run-javascriptcore-tests to distribute tests between devices
2459         https://bugs.webkit.org/show_bug.cgi?id=190190
2460
2461         Reviewed by Michael Catanzaro.
2462
2463         * Scripts/run-jsc-stress-tests:
2464         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
2465         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
2466
2467 2018-10-09  Dean Jackson  <dino@apple.com>
2468
2469         Update WHLSL to Metal tester with semantics
2470         https://bugs.webkit.org/show_bug.cgi?id=190416
2471         <rdar://problem/45145139>
2472
2473         Reviewed by Myles Maxfield.
2474
2475         A few small changes to the WHLSL to Metal tools:
2476         - Make it compile by adding some missing JS files :)
2477         - Add semantics to the default shader
2478         - Add FIXMEs to the other shaders
2479         - Create an in-browser test for the WHLSLToMetal codepath
2480         - Fix typos in the semantics checker
2481
2482         * WebGPUShadingLanguageRI/Checker.js:
2483         (Checker.prototype._checkSemantics.checkSemanticTypes):
2484         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
2485         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
2486         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
2487         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
2488         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
2489         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
2490         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
2491
2492 2018-10-09  Jer Noble  <jer.noble@apple.com>
2493
2494         Crash when closing WKWebView during enter fullscreen animation
2495         https://bugs.webkit.org/show_bug.cgi?id=190412
2496
2497         Reviewed by Brian Burg.
2498
2499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2500         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
2501         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
2502         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
2503         (TestWebKitAPI::TEST):
2504
2505 2018-10-09  Chris Dumez  <cdumez@apple.com>
2506
2507         Anchor target should be ignored on activation when the download attribute is set
2508         https://bugs.webkit.org/show_bug.cgi?id=190408
2509
2510         Reviewed by Geoffrey Garen.
2511
2512         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
2513         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
2514         popup blocking.
2515
2516         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2517         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2518         (WTR::TestRunner::setCanOpenWindows):
2519         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2520         * WebKitTestRunner/TestController.cpp:
2521         (WTR::TestController::createOtherPage):
2522         * WebKitTestRunner/TestController.h:
2523         * WebKitTestRunner/TestInvocation.cpp:
2524         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2525         * WebKitTestRunner/TestInvocation.h:
2526
2527 2018-10-09  Jer Noble  <jer.noble@apple.com>
2528
2529         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
2530         https://bugs.webkit.org/show_bug.cgi?id=190098
2531         <rdar://problem/42822671>
2532
2533         Reviewed by Brian Burg.
2534
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
2537         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
2538         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
2539         (TestWebKitAPI::TEST):
2540
2541 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
2542
2543         [WebAuthN] Import CTAP HID message and packet structure from Chromium
2544         https://bugs.webkit.org/show_bug.cgi?id=189289
2545         <rdar://problem/44120310>
2546
2547         Reviewed by Brent Fulgham.
2548
2549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2550         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
2551         (TestWebKitAPI::TEST):
2552
2553 2018-10-09  Chris Dumez  <cdumez@apple.com>
2554
2555         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
2556         https://bugs.webkit.org/show_bug.cgi?id=190378
2557         <rdar://problem/45059466>
2558
2559         Reviewed by Geoffrey Garen.
2560
2561         Add API test coverage.
2562
2563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2564
2565 2018-10-09  Jer Noble  <jer.noble@apple.com>
2566
2567         ISOTrackEncryptionBox returns incorrect defaultKeyID
2568         https://bugs.webkit.org/show_bug.cgi?id=190368
2569
2570         Reviewed by Eric Carlson.
2571
2572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2573         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
2574         (TestWebKitAPI::TEST):
2575
2576 2018-10-09  Philippe Normand  <pnormand@igalia.com>
2577
2578         [JHBuild] Update to GStreamer 1.14.4
2579         https://bugs.webkit.org/show_bug.cgi?id=190395
2580
2581         Reviewed by Xabier Rodriguez-Calvar.
2582
2583         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
2584         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
2585         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
2586         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
2587         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
2588
2589 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2590
2591         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
2592         https://bugs.webkit.org/show_bug.cgi?id=190386
2593
2594         Reviewed by Ryosuke Niwa.
2595
2596         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
2597         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
2598         of macOS.
2599
2600         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2601         (TEST):
2602
2603 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2604
2605         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
2606         https://bugs.webkit.org/show_bug.cgi?id=190342
2607         <rdar://problem/44767118>
2608
2609         Reviewed by Tim Horton.
2610
2611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2612         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2613
2614         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
2615         moving the selection around text inside nested list elements.
2616
2617         (TestWebKitAPI::checkParagraphStyles):
2618
2619         Add a new helper to check an NSParagraphStyle against expected results.
2620
2621         (TestWebKitAPI::webViewForTestingFontAttributes):
2622
2623         Allow each test to pass in the name of the test page to load.
2624
2625         (TestWebKitAPI::TEST):
2626         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
2627
2628         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
2629
2630         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
2631
2632         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
2633
2634 2018-10-08  Justin Fan  <justin_fan@apple.com>
2635
2636         WebGPU: Rename old WebGPU prototype to WebMetal
2637         https://bugs.webkit.org/show_bug.cgi?id=190325
2638         <rdar://problem/44990443>
2639
2640         Reviewed by Dean Jackson.
2641
2642         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2643
2644         * DumpRenderTree/mac/DumpRenderTree.mm:
2645         (enableExperimentalFeatures):
2646         (resetWebPreferencesToConsistentValues):
2647         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2648         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
2649         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
2650         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
2651         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
2652         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
2653         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2654         (WTR::InjectedBundle::beginTesting):
2655         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2656         (WTR::TestRunner::setWebMetalEnabled):
2657         (WTR::TestRunner::setWebGPUEnabled): Deleted.
2658         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2659
2660 2018-10-08  Commit Queue  <commit-queue@webkit.org>
2661
2662         Unreviewed, rolling out r236941.
2663         https://bugs.webkit.org/show_bug.cgi?id=190374
2664
2665         Causing API test failures in new test (Requested by jernoble
2666         on #webkit).
2667
2668         Reverted changeset:
2669
2670         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
2671         https://bugs.webkit.org/show_bug.cgi?id=190368
2672         https://trac.webkit.org/changeset/236941
2673
2674 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2675
2676         Make <input type=color> a runtime enabled (on-by-default) feature
2677         https://bugs.webkit.org/show_bug.cgi?id=189162
2678
2679         Reviewed by Wenson Hsieh and Tim Horton.
2680
2681         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2682
2683 2018-10-08  Jer Noble  <jer.noble@apple.com>
2684
2685         ISOTrackEncryptionBox returns incorrect defaultKeyID
2686         https://bugs.webkit.org/show_bug.cgi?id=190368
2687
2688         Reviewed by Eric Carlson.
2689
2690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2691         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
2692         (TestWebKitAPI::TEST):
2693
2694 2018-10-08  Alex Christensen  <achristensen@webkit.org>
2695
2696         Remove WKBundleFileHandleRef
2697         https://bugs.webkit.org/show_bug.cgi?id=190360
2698
2699         Reviewed by Tim Horton.
2700
2701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2702         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
2703         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
2704
2705 2018-10-08  Dan Bernstein  <mitz@apple.com>
2706
2707         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
2708         https://bugs.webkit.org/show_bug.cgi?id=190250
2709
2710         Reviewed by Anders Carlsson.
2711
2712         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2713
2714         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2715           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2716           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2717
2718         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
2719
2720         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
2721           around deprecated methods or categories on deprecated classes.
2722         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
2723         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2724         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
2725         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2726
2727         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2728           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2729           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2730
2731         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2732
2733         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
2734         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
2735           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
2736
2737         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2738           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
2739           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
2740
2741         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
2742           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
2743
2744         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2745           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2746           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2747           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
2748           many C SPI headers trigger the strict prototypes warning.
2749
2750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2751
2752         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2753         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2754         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2755         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
2756         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2757         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2758         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2759         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2760         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2761         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2762         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2763         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2764         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2765         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2766         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
2767         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
2768         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2769         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
2770         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
2771         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2772         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2773         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2774         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
2775         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
2776         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2777         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
2778
2779         In all of the above, suppressed the deprecated implementations warning where needed.
2780
2781         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
2782           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
2783           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2784           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
2785           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2786           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2787           and GCC_NO_COMMON_BLOCKS.
2788
2789         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2790
2791         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2792         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
2793           the deprecated implementations warning.
2794
2795         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2796         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
2797
2798 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
2799
2800         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
2801         https://bugs.webkit.org/show_bug.cgi?id=189238
2802
2803         Reviewed by Xabier Rodriguez-Calvar.
2804
2805         Modifications on GStreamer, tracked in GStreamer bugzilla:
2806         https://bugzilla.gnome.org/show_bug.cgi?id=797231
2807         https://bugzilla.gnome.org/show_bug.cgi?id=765275
2808
2809         * gstreamer/jhbuild.modules: Add new patches.
2810         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
2811         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
2812         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
2813         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
2814
2815 2018-10-06  Dan Bernstein  <mitz@apple.com>
2816
2817         [Xcode] Never build yasm with ASAN
2818         https://bugs.webkit.org/show_bug.cgi?id=190327
2819
2820         Reviewed by Youenn Fablet.
2821
2822         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
2823           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
2824
2825 2018-10-05  Chris Dumez  <cdumez@apple.com>
2826
2827         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
2828         https://bugs.webkit.org/show_bug.cgi?id=190320
2829         <rdar://problem/45044814>
2830
2831         Reviewed by Geoffrey Garen.
2832
2833         Add API test coverage.
2834
2835         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2836         (TestWebKitAPI::TEST):
2837         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2838         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
2839
2840 2018-10-03  Jer Noble  <jer.noble@apple.com>
2841
2842         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
2843         https://bugs.webkit.org/show_bug.cgi?id=190266
2844
2845         Reviewed by Eric Carlson.
2846
2847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2848         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
2849         (TestWebKitAPI::TEST):
2850
2851 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
2852
2853         Unreviewed, rolling out r236866.
2854
2855         Breaks internal builds.
2856
2857         Reverted changeset:
2858
2859         "Add support for reporting "display composited video frames"
2860         through the VideoPlaybackQuality object."
2861         https://bugs.webkit.org/show_bug.cgi?id=190266
2862         https://trac.webkit.org/changeset/236866
2863
2864 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2865
2866         [WPE][JSC] Use Unified Sources for Platform-specific sources
2867         https://bugs.webkit.org/show_bug.cgi?id=190300
2868
2869         Reviewed by Yusuke Suzuki.
2870
2871         Currently the GTK port already used Unified Sources with the same source files.
2872         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
2873         to the list of libraries to link with.
2874
2875         * TestWebKitAPI/PlatformWPE.cmake:
2876
2877 2018-10-05  Zach Li  <zachli@apple.com>
2878
2879         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
2880         https://bugs.webkit.org/show_bug.cgi?id=190302
2881         <rdar://problem/45031469>
2882
2883         Reviewed by Tim Horton.
2884
2885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2886         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
2887         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
2888         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
2889         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2890         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2891         (TEST):
2892
2893 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2894
2895         [iOS] [WK2] Expose some more editing SPI on WKWebView
2896         https://bugs.webkit.org/show_bug.cgi?id=190232
2897         <rdar://problem/44963368>
2898
2899         Reviewed by Tim Horton.
2900
2901         Adds new API tests to exercise the new SPIs.
2902
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2904         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
2905         (-[TestWKWebView querySelectorExists:]):
2906         (TestWebKitAPI::webViewForEditActionTesting):
2907         (TestWebKitAPI::TEST):
2908         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2909         (-[TestWKWebView collapseToStart]): Deleted.
2910         (-[TestWKWebView collapseToEnd]): Deleted.
2911         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
2912         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
2913         * TestWebKitAPI/cocoa/TestWKWebView.h:
2914         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2915         (-[TestWKWebView stylePropertyAtSelectionStart:]):
2916         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
2917         (-[TestWKWebView collapseToStart]):
2918         (-[TestWKWebView collapseToEnd]):
2919
2920         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
2921
2922 2018-10-04  Jer Noble  <jer.noble@apple.com>
2923
2924         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
2925         https://bugs.webkit.org/show_bug.cgi?id=190266
2926
2927         Reviewed by Eric Carlson.
2928
2929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2930         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
2931         (TestWebKitAPI::TEST):
2932
2933 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2934
2935         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
2936         https://bugs.webkit.org/show_bug.cgi?id=190119
2937         <rdar://problem/44767062>
2938
2939         Reviewed by Tim Horton.
2940
2941         Add a new API test that loads a document containing various rich text styles. This test moves the selection
2942         around the document and checks the last set of font attributes received via the new UI delegate hook.
2943
2944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2945         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
2946         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
2947         (-[FontAttributesListener lastFontAttributes]):
2948         (-[TestWKWebView selectElementWithIdentifier:]):
2949         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
2950         (ColorExpectation::ColorExpectation):
2951         (ShadowExpectation::ShadowExpectation):
2952         (checkColor):
2953         (checkShadow):
2954         (checkFont):
2955         (webViewForTestingFontAttributes):
2956         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
2957
2958 2018-10-04  Alan Coon  <alancoon@apple.com>
2959
2960         Unreviewed, add self as contributor.
2961
2962         * Scripts/webkitpy/common/config/contributors.json:
2963
2964 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2965
2966         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
2967         https://bugs.webkit.org/show_bug.cgi?id=190289
2968         <rdar://problem/45020806>
2969
2970         Reviewed by Ryosuke Niwa.
2971
2972         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
2973         attributes at the current selection.
2974
2975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2976         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
2977         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2978         (webViewForFontManagerTesting):
2979         (TestWebKitAPI::TEST):
2980         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
2981         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
2982
2983         Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
2984         global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
2985         foreground colors, and background colors.
2986
2987         (sharedFontOptionsForTesting):
2988         (+[TestFontOptions sharedInstance]):
2989         (-[TestFontOptions initWithFontOptions:]):
2990         (-[TestFontOptions selectedAttributes]):
2991         (-[TestFontOptions fontOptions]):
2992         (-[TestFontOptions shadowWidth]):
2993         (-[TestFontOptions setShadowWidth:]):
2994         (-[TestFontOptions shadowHeight]):
2995         (-[TestFontOptions setShadowHeight:]):
2996         (-[TestFontOptions setShadowBlurRadius:]):
2997         (-[TestFontOptions setHasShadow:]):
2998         (-[TestFontOptions foregroundColor]):
2999         (-[TestFontOptions setForegroundColor:]):
3000         (-[TestFontOptions backgroundColor]):
3001         (-[TestFontOptions setBackgroundColor:]):
3002         (-[TestFontOptions _dispatchFontAttributeChanges]):
3003         (-[TestFontOptions convertAttributes:]):
3004         (-[TestFontOptions setSelectedAttributes:isMultiple:]):
3005         (-[TestFontOptions forwardInvocation:]):
3006
3007 2018-10-04  Jiewen Tan  <jiewen_tan@apple.com>
3008
3009         [WebAuthN] Move time out control from WebProcess to UIProcess
3010         https://bugs.webkit.org/show_bug.cgi?id=189642
3011         <rdar://problem/44476765>
3012
3013         Reviewed by Chris Dumez.
3014
3015         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3016         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3017
3018 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3019
3020         Runtime flag and IDL for MediaRecorder
3021         https://bugs.webkit.org/show_bug.cgi?id=190018
3022
3023         Reviewed by Youenn Fablet and Chris Dumez.
3024
3025         * DumpRenderTree/mac/DumpRenderTree.mm:
3026         (enableExperimentalFeatures):
3027
3028 2018-10-04  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3029
3030         [LayoutTests][Win] Stop wpt server correctly.
3031         https://bugs.webkit.org/show_bug.cgi?id=190248
3032
3033         Reviewed by Fujii Hironori.
3034
3035         Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
3036         Also refactoring the detection of Windows and cygwin environment check.
3037
3038         * Scripts/webkitpy/common/system/executive.py:
3039         (Executive.__init__): Check environment once.
3040         (Executive._should_close_fds):
3041         (Executive.kill_process):
3042         (Executive.check_running_pid):
3043         (Executive.running_pids):
3044         (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
3045         (Executive.kill_all):
3046         (Executive._child_process_encoding):
3047         (Executive._should_encode_child_process_arguments):
3048         (Executive.popen):
3049         (Executive.run_in_parallel):
3050
3051 2018-10-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3052
3053         Convert tests to use navigation client
3054         https://bugs.webkit.org/show_bug.cgi?id=190153
3055
3056         Reviewed by Alex Christensen.
3057
3058         Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
3059
3060         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3061         (TestWebKitAPI::decidePolicyForNavigationAction):
3062         (TestWebKitAPI::setPagePolicyClient):
3063         * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
3064         (TestWebKitAPI::didCommitNavigationCallback):
3065         (TestWebKitAPI::TEST):
3066         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
3067
3068 2018-10-03  Dan Bernstein  <mitz@apple.com>
3069
3070         [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
3071         https://bugs.webkit.org/show_bug.cgi?id=190270
3072
3073         Reviewed by Wenson Hsieh.
3074
3075         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3076         (TestWebKitAPI::TEST):
3077
3078 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3079
3080         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3081         https://bugs.webkit.org/show_bug.cgi?id=190238
3082
3083         Reviewed by Antti Koivisto.
3084
3085         * DumpRenderTree/TestOptions.h:
3086         * DumpRenderTree/mac/DumpRenderTree.mm:
3087         (resetWebPreferencesToConsistentValues):
3088
3089 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3090
3091         [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
3092         https://bugs.webkit.org/show_bug.cgi?id=179787
3093         <rdar://problem/35593389>
3094
3095         Reviewed by Tim Horton.
3096
3097         Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
3098         menu items.
3099
3100         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3101         (webViewForFontManagerTesting):
3102         (menuItemCellForFontAction):
3103         (TestWebKitAPI::TEST):
3104
3105 2018-10-02  Chris Dumez  <cdumez@apple.com>
3106
3107         REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
3108         https://bugs.webkit.org/show_bug.cgi?id=190176
3109         <rdar://problem/44925871>
3110
3111         Reviewed by Alex Christensen.
3112
3113         Use a URL that is truly recognized as invalid by WebCore's URL parser.
3114
3115         * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
3116         (TEST):
3117
3118 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3119
3120         Remove ParsedURLString
3121         https://bugs.webkit.org/show_bug.cgi?id=190154
3122
3123         Reviewed by Chris Dumez.
3124
3125         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3126         (TestWebKitAPI::TEST_F):
3127         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3128         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3129         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3130         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3131         (TestWebKitAPI::TEST):
3132
3133 2018-10-02  Daniel Bates  <dabates@apple.com>
3134
3135         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
3136         (https://bugs.webkit.org/show_bug.cgi?id=190017)
3137
3138         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
3139             WKWebViewAutofillTests.AutofillRequiresInputSession
3140             DragAndDropTests.ExternalSourceJPEGOnly
3141             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
3142
3143         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
3144         we will look to swizzle this method for all test by default.
3145
3146         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3147         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3148         (TestWebKitAPI::TEST):
3149         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3150         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3151         (TestWebKitAPI::TEST):
3152         * TestWebKitAPI/ios/UIKitSPI.h:
3153
3154 2018-10-02  Dawei Fenton  <realdawei@apple.com>
3155
3156         Unreviewed, rolling out r236751.
3157
3158         broke the iOS Build
3159
3160         Reverted changeset:
3161
3162         "Fix iOS TestWebKitAPI failures following
3163         <https://trac.webkit.org/changeset/236619>"
3164         https://bugs.webkit.org/show_bug.cgi?id=190017
3165         https://trac.webkit.org/changeset/236751
3166
3167 2018-10-02  Daniel Bates  <dabates@apple.com>
3168
3169         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
3170         (https://bugs.webkit.org/show_bug.cgi?id=190017)
3171
3172         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
3173             WKWebViewAutofillTests.AutofillRequiresInputSession
3174             DragAndDropTests.ExternalSourceJPEGOnly
3175             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
3176
3177         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
3178         we will look to swizzle this method for all test by default.
3179
3180         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3181         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3182         (TestWebKitAPI::TEST):
3183         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3184         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
3185         (TestWebKitAPI::TEST):
3186         * TestWebKitAPI/ios/UIKitSPI.h:
3187
3188 2018-10-01  Dean Jackson  <dino@apple.com>
3189
3190         Remove CSS Animation Triggers
3191         https://bugs.webkit.org/show_bug.cgi?id=190175
3192         <rdar://problem/44925626>
3193
3194         Reviewed by Simon Fraser.
3195
3196         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3197
3198 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
3199
3200         [Flatpak] Use our own check of flatpak repos
3201         https://bugs.webkit.org/show_bug.cgi?id=190194
3202
3203         Allowing us to not mess up with user installation
3204         and "--assumeyes" everywhere.
3205
3206         Reviewed by Michael Catanzaro.
3207
3208         * flatpak/flatpakutils.py:
3209         (FlatpakPackage.__init__):
3210         (FlatpakPackage.install):
3211         (FlatpakPackage.update):
3212         (WebkitFlatpak.load_from_args):
3213         (WebkitFlatpak.__init__):
3214         (WebkitFlatpak.clean_args):
3215
3216 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3217
3218         [macOS] Implement a way for the UI process to request typing attributes at the current selection
3219         https://bugs.webkit.org/show_bug.cgi?id=189983
3220         <rdar://problem/44648705>
3221
3222         Reviewed by Ryosuke Niwa.
3223
3224         Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
3225
3226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3227         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
3228         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3229
3230         Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
3231         typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
3232         additionally check that shadowed text and strike-through are reflected in typing attributes.
3233
3234         (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
3235         (-[TestWKWebView typingAttributes]):
3236
3237         Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
3238
3239         (-[TestWKWebView collapseToStart]):
3240         (webViewForFontManagerTesting):
3241         (TestWebKitAPI::TEST):
3242         * TestWebKitAPI/cocoa/TestWKWebView.h:
3243         * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
3244         * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
3245
3246         Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
3247
3248         (-[TestInspectorBarItemController initWithInspectorBar:]):
3249         (-[TestInspectorBarItemController inspectorBar]):
3250         (-[TestInspectorBarItemController updateSelectedAttributes]):
3251         (-[TestInspectorBar initWithWebView:]):
3252         (+[TestInspectorBar standardItemControllerClass]):
3253         (+[TestInspectorBar standardTextItemIdentifiers]):
3254         (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
3255         (-[TestInspectorBar chooseFontSize:]):
3256         (-[TestInspectorBar chooseFontFamily:]):
3257         (-[TestInspectorBar _chooseColor:inColorWell:]):
3258         (-[TestInspectorBar chooseForegroundColor:]):
3259         (-[TestInspectorBar chooseBackgroundColor:]):
3260         (-[TestInspectorBar formatBold:]):
3261         (-[TestInspectorBar formatItalic:]):
3262         (-[TestInspectorBar formatUnderline:]):
3263
3264         Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
3265         styling controls).
3266
3267         (-[TestInspectorBar itemController]):
3268         (-[TestInspectorBar setItemController:]):
3269
3270 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
3271
3272         [Flatpak] Implement icecream and ccache support
3273         https://bugs.webkit.org/show_bug.cgi?id=190146
3274
3275         Reviewed by Alejandro G. Castro.
3276
3277         * flatpak/flatpakutils.py:
3278         (WebkitFlatpak.load_from_args):
3279         (WebkitFlatpak.__init__):
3280         (WebkitFlatpak.clean_args):
3281         (WebkitFlatpak.run_in_sandbox):
3282         (WebkitFlatpak.save_config):
3283         (WebkitFlatpak):
3284         (WebkitFlatpak.setup_ccache):
3285         (WebkitFlatpak.setup_icecc):
3286         (WebkitFlatpak.setup_dev_env):
3287         * flatpak/org.webkit.WebKit.yaml:
3288
3289 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3290
3291         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
3292
3293         * WebKitTestRunner/TestController.cpp:
3294         (WTR::TestController::keyExistsInKeychain):
3295
3296 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3297
3298         [WinCairo] Enable WPT tests environment.
3299         https://bugs.webkit.org/show_bug.cgi?id=190128
3300
3301         Reviewed by Youenn Fablet.
3302
3303         Escaping backslash of the path not to confuse the JSON parser.
3304
3305         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3306         (WebPlatformTestServer._prepare_config):
3307
3308 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
3309
3310         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
3311         https://bugs.webkit.org/show_bug.cgi?id=190150
3312
3313         Reviewed by Fujii Hironori.
3314
3315         * DumpRenderTree/win/DumpRenderTree.cpp:
3316         (setWebPreferencesForTestOptions):
3317         DRT has been recognizing this field, but not propagating its value to WebPreferences.
3318
3319 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3320
3321         Unreviewed, rolling out r236551.
3322
3323         Fails URL validating too aggressively
3324
3325         Reverted changeset:
3326
3327         "URLWithUserTypedString should return nil for URLs deemed to
3328         be invalid by WebCore::URL"
3329         https://bugs.webkit.org/show_bug.cgi?id=189979
3330         https://trac.webkit.org/changeset/236551
3331
3332 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3333
3334         [iOS] Add SPI to customize the input accessory view when focusing an element
3335         https://bugs.webkit.org/show_bug.cgi?id=190152
3336         <rdar://problem/42754975>
3337
3338         Reviewed by Dan Bernstein.
3339
3340         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
3341         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
3342         `-inputAccessoryView`.
3343
3344         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3345         (webViewWithAutofocusedInput):
3346         (TestWebKitAPI::TEST):
3347         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3348         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3349         (-[TestInputDelegate setWillStartInputSessionHandler:]):
3350         (-[TestInputDelegate willStartInputSessionHandler]):
3351         (-[TestInputDelegate _webView:willStartInputSession:]):
3352
3353 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
3354
3355         Remove StorageProcess
3356         https://bugs.webkit.org/show_bug.cgi?id=189975
3357
3358         Reviewed by Geoffrey Garen.
3359
3360         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3361         (TEST):
3362         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3363         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
3364         (TEST):
3365         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3366         (TEST):
3367         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3368         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3369         (WTR::TestRunner::terminateStorageProcess): Deleted.
3370         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3371         * WebKitTestRunner/TestController.cpp:
3372         (WTR::TestController::generatePageConfiguration):
3373         (WTR::TestController::databaseProcessName): Deleted.
3374         (WTR::TestController::databaseProcessDidCrash): Deleted.
3375         (WTR::TestController::terminateStorageProcess): Deleted.
3376         * WebKitTestRunner/TestController.h:
3377         * WebKitTestRunner/TestInvocation.cpp:
3378         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3379
3380 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
3381
3382         [WebAuthN] Import a JS CBOR coder
3383         https://bugs.webkit.org/show_bug.cgi?id=189877
3384         <rdar://problem/44701124>
3385
3386         Reviewed by Chris Dumez.
3387
3388         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
3389         only if acceptAttestation is true.
3390
3391         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3392         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3393
3394 2018-10-01  Chris Dumez  <cdumez@apple.com>
3395
3396         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
3397         https://bugs.webkit.org/show_bug.cgi?id=190052
3398
3399         Reviewed by Ryosuke Niwa.
3400
3401         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
3402         to log those events. It also uses console.log() before sending those events to indicate what the test is about
3403         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
3404         so that it can log the message.
3405         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
3406         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
3407         handler to be transformed into synchronous IPC.
3408         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
3409         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
3410         messages may end up being out of order, leading to flakiness.
3411
3412         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
3413         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
3414         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
3415
3416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3417         (WTR::InjectedBundle::outputText):
3418
3419 2018-10-01  Daniel Bates  <dabates@apple.com>
3420
3421         [iOS] Special keys are misidentified in DOM keyboard events
3422         https://bugs.webkit.org/show_bug.cgi?id=189974
3423
3424         Reviewed by Wenson Hsieh.
3425
3426         Add support for testing keys Forward Delete and Num Lock / Clear.
3427
3428         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3429         (hidUsageCodeForCharacter):
3430
3431 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3432
3433         URL should not use TextEncoding internally
3434         https://bugs.webkit.org/show_bug.cgi?id=190111
3435
3436         Reviewed by Andy Estes.
3437
3438         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3439         (TestWebKitAPI::testUserPass):
3440         (TestWebKitAPI::TEST_F):
3441
3442 2018-10-01  Daniel Bates  <dabates@apple.com>
3443
3444         LLDB tests may use wrong configuration of lldbWebKitTester
3445         https://bugs.webkit.org/show_bug.cgi?id=189011
3446
3447         Reviewed by Dean Jackson.
3448
3449         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
3450         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3451
3452         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
3453         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
3454         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
3455         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
3456         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
3457         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
3458         the Python unittest module, the Python multiprocessing module, and the general principle of unit
3459         tests - to test code in isolation). The unit tests make use of the value of this environment
3460         variable to launch lldbWebKitTester binary.
3461
3462         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
3463         out if this script is invoked for a non-Mac platform.
3464         * Scripts/webkitpy/test/main.py:
3465         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
3466         LLDB_WEBKIT_TESTER_EXECUTABLE.
3467         (_build_lldb_webkit_tester): Deleted.
3468         * lldb/dump_class_layout_unittest.py:
3469         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
3470         this is the only call site that needs the Host object now.
3471         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
3472         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
3473         * lldb/lldbWebKitTester/main.cpp:
3474         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3475         * lldb/lldb_webkit_unittest.py:
3476         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
3477         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
3478         (TestSummaryProviders):
3479         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
3480         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3481         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
3482         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
3483         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
3484         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
3485         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3486
3487 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
3488
3489         [WPE] Update install-dependencies
3490         https://bugs.webkit.org/show_bug.cgi?id=190127
3491
3492         Reviewed by Michael Catanzaro.
3493
3494         * wpe/install-dependencies:
3495         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
3496         It is used by gstvaapidisplay_x11.c.
3497         Add it only for Apt, already ok for Pacman and DNF.
3498
3499         Install libevent-dev for WebRTC (like GTK)
3500
3501         Install libasound2-dev for WebRTC.
3502         Add it only for Apt, already ok for Pacam and DNF.
3503
3504         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
3505
3506 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
3507
3508         [Flatpak] Add libunwind in the sandbox
3509         https://bugs.webkit.org/show_bug.cgi?id=190123
3510
3511         Allowing us to get proper traces in GStreamer trace grabing
3512         debug functions.
3513
3514         Reviewed by Philippe Normand.
3515
3516         * flatpak/org.webkit.WebKit.yaml:
3517
3518 2018-09-29  Commit Queue  <commit-queue@webkit.org>
3519
3520         Unreviewed, rolling out r236631.
3521         https://bugs.webkit.org/show_bug.cgi?id=190112
3522
3523         Caused various eventSender tests, including fast/css/pseudo-
3524         active-style-sharing*, to fail (Requested by smfr on #webkit).
3525
3526         Reverted changeset:
3527
3528         "Regression(r236512): http/tests/navigation/keyboard-events-
3529         during-provisional-navigation.html is flaky"
3530         https://bugs.webkit.org/show_bug.cgi?id=190052
3531         https://trac.webkit.org/changeset/236631
3532
3533 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3534
3535         [WHLSL] Fix build after r236635
3536         https://bugs.webkit.org/show_bug.cgi?id=189210
3537
3538         Unreviewed.
3539
3540         * WebGPUShadingLanguageRI/Intrinsics.js:
3541         (Intrinsics.):
3542         * WebGPUShadingLanguageRI/Test.js:
3543         (tests.atomicsNull):
3544         (tests.numThreads):
3545         (tests.textureDimensionsNull):
3546
3547 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3548
3549         [WHLSL] Allow uniform buffers to be used in the interpreter
3550         https://bugs.webkit.org/show_bug.cgi?id=189210
3551
3552         Reviewed by Filip Pizlo.
3553
3554         Every lvalue is associated with an address space, and the propagation of these address spaces
3555         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
3556         of this, so this patch just goes the last few yards. It also updates the standard library to
3557         allow for writing into all writable address spaces for out-params.
3558
3559         * WebGPUShadingLanguageRI/Checker.js:
3560         (Checker.prototype.visitAssignment):
3561         (Checker.prototype._finishVisitingPropertyAccess):
3562         * WebGPUShadingLanguageRI/Intrinsics.js:
3563         (Intrinsics.):
3564         (Intrinsics.checkFalse):
3565         (Intrinsics):
3566         * WebGPUShadingLanguageRI/StandardLibrary.js:
3567         (let.standardLibrary):
3568         * WebGPUShadingLanguageRI/Test.js:
3569         (tests.threadArrayRefLoad):
3570         (tests.threadArrayRefLoadIntLiteral):
3571         (tests.deviceArrayRefLoad):
3572         (tests.threadArrayRefStore):
3573         (tests.deviceArrayRefStore):
3574         (tests.deviceArrayRefStoreIntLiteral):
3575         (tests.threadPointerLoad):
3576         (tests.threadPointerStore):
3577         (tests.devicePointerLoad):
3578         (tests.devicePointerStore):
3579         (tests.arrayLoad):
3580         (tests.constantAddressSpace):
3581         (tests.standardLibraryDevicePointers):
3582         (tests.threadArrayLoad): Deleted.
3583         (tests.threadArrayLoadIntLiteral): Deleted.
3584         (tests.deviceArrayLoad): Deleted.
3585         (tests.threadArrayStore): Deleted.
3586         (tests.deviceArrayStore): Deleted.
3587         (tests.deviceArrayStoreIntLiteral): Deleted.
3588
3589 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3590
3591         No DOM API to instantiate an attachment for an img element
3592         https://bugs.webkit.org/show_bug.cgi?id=189934
3593         <rdar://problem/44743222>
3594
3595         Reviewed by Ryosuke Niwa.
3596
3597         Adds 3 new API tests in WKAttachmentTests:
3598
3599         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
3600         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
3601
3602         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
3603         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
3604
3605         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
3606         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
3607         then result in an image element with the contents of the _WKAttachment's file wrapper.
3608
3609         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3610         (-[TestWKWebView imageElementSize]):
3611         (-[TestWKWebView waitForImageElementSizeToBecome:]):
3612         (TestWebKitAPI::TEST):
3613         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
3614
3615 2018-09-28  Chris Dumez  <cdumez@apple.com>
3616
3617         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
3618         https://bugs.webkit.org/show_bug.cgi?id=190052
3619
3620         Reviewed by Ryosuke Niwa.
3621
3622         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
3623         to log those events. It also uses console.log() before sending those events to indicate what the test is about
3624         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
3625         so that it can log the message.
3626         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
3627         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
3628         handler to be transformed into synchronous IPC.
3629         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
3630         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
3631         messages may end up being out of order, leading to flakiness.
3632
3633         To address th