Unreviewed follow-up to r215739 and r215740.
[WebKit-https.git] / Tools / ChangeLog
1 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2
3         Unreviewed follow-up to r215739 and r215740.
4
5         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
6         This (and r215740) was supposed to land in r215739, but I managed to
7         specify the previous version of the patch.
8
9 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
10
11         Unreviewed follow-up to r215739.
12
13         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
14         libgcrypt patch that enforces the use of /dev/urandom.
15
16 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
17
18         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
19         https://bugs.webkit.org/show_bug.cgi?id=171270
20
21         Reviewed by Michael Catanzaro.
22
23         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
24         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
25         that use systems that don't yet provide libgcrypt >= 1.7.0.
26
27 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
28
29         [GTK] Improve an unit test for the JHBuild wrapper.
30         https://bugs.webkit.org/show_bug.cgi?id=168036
31
32         Unreviewed follow-up patch after r215727
33
34         * Scripts/webkitpy/port/base_unittest.py:
35         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
36         wasn't there before calling MockFileSystem.maybe_make_directory(), and
37         also that it exists after calling it.
38
39 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
40
41         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
42         https://bugs.webkit.org/show_bug.cgi?id=168036
43
44         Reviewed by Michael Catanzaro.
45
46         Call ImageDiff with the JHBuild wrapper if we should use it.
47         Also add some unit tests for the JHBuild wrapper feature.
48
49         * Scripts/webkitpy/port/base.py:
50         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
51         * Scripts/webkitpy/port/base_unittest.py:
52         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
53         * Scripts/webkitpy/port/image_diff.py:
54         (ImageDiffer._start): The actual fix, use the wrapper if we should.
55         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
56         * Scripts/webkitpy/port/port_testcase.py:
57         (PortTestCase):
58         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
59         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
60         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
61
62 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
63
64         Support reading NSURL titles from the pasteboard when performing data interaction
65         https://bugs.webkit.org/show_bug.cgi?id=171156
66         <rdar://problem/31356937>
67
68         Reviewed by Tim Horton.
69
70         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
71
72         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
73         (TestWebKitAPI::TEST):
74
75 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
76
77         Respect fidelity order when reading web content from item providers
78         https://bugs.webkit.org/show_bug.cgi?id=171155
79         <rdar://problem/31356937>
80
81         Reviewed by Tim Horton.
82
83         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
84         more details.
85
86         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
87         (TestWebKitAPI::TEST):
88
89 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
90
91         SyntaxError fix after r215702.
92         https://bugs.webkit.org/show_bug.cgi?id=168944
93
94         Unreviewed "build" fix.
95
96         * BuildSlaveSupport/built-product-archive:
97         (archiveBuiltProduct):
98
99 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
100
101         Package ImageDiff built with host SDK
102         https://bugs.webkit.org/show_bug.cgi?id=168944
103         <rdar://problem/30745642>
104
105         Reviewed by David Kilzer.
106
107         iOS Simulator and iOS device should archive the ImageDiff built for the host
108         machine.
109
110         * BuildSlaveSupport/built-product-archive:
111         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
112         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
113
114 2017-04-24  Keith Miller  <keith_miller@apple.com>
115
116         ThreadMessage API tests failing on release bots
117         https://bugs.webkit.org/show_bug.cgi?id=171246
118
119         Reviewed by Saam Barati.
120
121         Need to make sure that C++ doesn't optimize away our spin loop.
122
123         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
124         (runThreadMessageTest):
125         (TEST):
126
127 2017-04-24  Alex Christensen  <achristensen@webkit.org>
128
129         Reduce copies and allocations in SharedBuffer::append
130         https://bugs.webkit.org/show_bug.cgi?id=170956
131
132         Reviewed by Andreas Kling.
133
134         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
135         (TestWebKitAPI::TEST_F):
136
137 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
138
139         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
140         https://bugs.webkit.org/show_bug.cgi?id=166680
141
142         Reviewed by Michael Catanzaro.
143
144         Update remote inspector unit tests.
145
146         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
147         (main):
148         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
149         (connectToInspectorServer):
150         (waitUntilInspectorServerIsReady):
151         (startTestServer):
152         (testInspectorServerPageList):
153         (beforeAll):
154
155 2017-04-23  Youenn Fablet  <youenn@apple.com>
156
157         Add a tool to update expected.txt files from EWS bot results
158         https://bugs.webkit.org/show_bug.cgi?id=169538
159
160         Reviewed by Ryosuke Niwa.
161
162         This script updates expected-txt files from bugzilla posted EWS results.
163         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
164         have results different from the generic baseline.
165
166         * Scripts/update-test-expectations-from-bugzilla: Added.
167         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
168         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
169         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
170
171 2017-04-22  Youenn Fablet  <youenn@apple.com>
172
173         Add an option to import tip-of-tree WPT tests
174         https://bugs.webkit.org/show_bug.cgi?id=171152
175
176         Reviewed by Joseph Pecoraro.
177
178         Adding a '-t' option to import tip of tree WPT tests.
179         Updating importer based on the fact that csswg-test is no longer a thing. 
180
181         * Scripts/webkitpy/w3c/test_downloader.py:
182         (TestDownloader.download_tests):
183         * Scripts/webkitpy/w3c/test_importer.py:
184         (configure_logging):
185         (TestImporter.do_import):
186         (TestImporter.write_import_log):
187
188 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
189
190         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
191         https://bugs.webkit.org/show_bug.cgi?id=171177
192         <rdar://problem/31765379>
193
194         Reviewed by Andy Estes.
195
196         Tests uploading a JSON file to a file input.
197
198         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
199         (TestWebKitAPI::TEST):
200
201 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
202
203         Support writing link titles to the pasteboard when beginning data interaction on a link
204         https://bugs.webkit.org/show_bug.cgi?id=171154
205         <rdar://problem/31356937>
206
207         Reviewed by Andy Estes.
208
209         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
210         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
211         matching the title of the link.
212
213         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
214         (TestWebKitAPI::TEST):
215
216 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
217
218         Unreviewed, rolling out r215608.
219
220         Hundreds of test failures on GTK bot
221
222         Reverted changeset:
223
224         "Reduce copies and allocations in SharedBuffer::append"
225         https://bugs.webkit.org/show_bug.cgi?id=170956
226         http://trac.webkit.org/changeset/215608
227
228 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
229
230         [WK2] Add delegate hooks for overriding unhanded data interaction operations
231         https://bugs.webkit.org/show_bug.cgi?id=171005
232         <rdar://problem/31669646>
233
234         Reviewed by Tim Horton.
235
236         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
237         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
238         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
239
240         New API test:
241         DataInteractionTests.OverrideDataInteractionOperation
242
243         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
244         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
245         (TestWebKitAPI::TEST):
246         * TestWebKitAPI/ios/DataInteractionSimulator.h:
247         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
248         (-[DataInteractionSimulator initWithWebView:]):
249         (-[DataInteractionSimulator dealloc]):
250         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
251         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
252         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
253
254 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
255
256         Temporarily disable two flaky API tests.
257
258         Unreviewed test gardening.
259
260         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
261         (TEST):
262         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
263         (TEST):
264
265 2017-04-21  Keith Miller  <keith_miller@apple.com>
266
267         Unreviewed, rolling out r215634.
268
269         underlying build issues should have been fixed
270
271         Reverted changeset:
272
273         "Unreviewed, rolling out r215620 and r215623."
274         https://bugs.webkit.org/show_bug.cgi?id=171139
275         http://trac.webkit.org/changeset/215634
276
277 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
278
279         Bubbles on dashboard doesn't turn red for test262 failures
280         https://bugs.webkit.org/show_bug.cgi?id=171129
281
282         Reviewed by Alexey Proskuryakov.
283
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
285
286 2017-04-21  Commit Queue  <commit-queue@webkit.org>
287
288         Unreviewed, rolling out r215620 and r215623.
289         https://bugs.webkit.org/show_bug.cgi?id=171139
290
291         broke arm64 build (Requested by keith_miller on #webkit).
292
293         Reverted changesets:
294
295         "Add signaling API"
296         https://bugs.webkit.org/show_bug.cgi?id=170976
297         http://trac.webkit.org/changeset/215620
298
299         "Unreviewed, fix Cloop build."
300         http://trac.webkit.org/changeset/215623
301
302 2017-04-20  Keith Miller  <keith_miller@apple.com>
303
304         Add signaling API
305         https://bugs.webkit.org/show_bug.cgi?id=170976
306
307         Reviewed by Filip Pizlo.
308
309         Add tests for ThreadMessages.
310
311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
312         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
313         (runThreadMessageTest):
314         (TEST):
315
316 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
317
318         commit-log-editor should respect the git editor if one is set
319         https://bugs.webkit.org/show_bug.cgi?id=171085
320         <rdar://problem/31745506>
321
322         Reviewed by Daniel Bates.
323
324         * Scripts/commit-log-editor:
325         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
326         deciding which editor to present. We examine the global editor preference since that may be
327         set automatically by installers or third-party tools.
328
329 2017-04-21  Alex Christensen  <achristensen@webkit.org>
330
331         Reduce copies and allocations in SharedBuffer::append
332         https://bugs.webkit.org/show_bug.cgi?id=170956
333
334         Reviewed by Andreas Kling.
335
336         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
337         (TestWebKitAPI::TEST_F):
338
339 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
340
341         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
342         https://bugs.webkit.org/show_bug.cgi?id=171071
343
344         Reviewed by Michael Catanzaro.
345
346         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
347         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
348         be available for all ports.
349
350         * DumpRenderTree/PlatformMac.cmake:
351         * MiniBrowser/mac/CMakeLists.txt:
352         * MiniBrowser/win/CMakeLists.txt:
353         * TestWebKitAPI/PlatformJSCOnly.cmake:
354         * TestWebKitAPI/PlatformMac.cmake:
355         * TestWebKitAPI/PlatformWin.cmake:
356         * WebKitTestRunner/PlatformMac.cmake:
357
358 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
359
360         Test262 bot does not go red with failures
361         https://bugs.webkit.org/show_bug.cgi?id=171044
362
363         Reviewed by Aakash Jain.
364
365         The piped output of run-jsc-stress-tests is different from
366         its non-piped output. Switch to parsing the correct output.
367
368         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
369         (RunTest262Tests.countFailures):
370         Just count the number of lines that start with "FAIL:".
371
372         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
373         (RunTest262TestsTest.test_no_regressions_output):
374         (test_failure_output):
375         (test_failures_output):
376         Updated tests with new sample output produced partially from bots and
377         locally. In cases of failure the return code of run-jsc-stress-tests
378         is still 0 so update the expected return code in the tests.
379
380 2017-04-20  Brady Eidson  <beidson@apple.com>
381
382         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
383         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
384
385         Reviewed by Andy Estes.
386
387         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
388         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
389         (resetToConsistentState):
390         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
391         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
392         (TEST):
393         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
394
395 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
396
397         [ios-simulator] PositionInformationTests API tests are timing out
398         https://bugs.webkit.org/show_bug.cgi?id=171089
399
400         Rubber-stamped by Tim Horton.
401
402         Addresses failures observed in the new position information tests added in r215573 by only running them if the
403         DATA_INTERACTION feature flag is enabled.
404
405         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
406
407 2017-04-20  Brady Eidson  <beidson@apple.com>
408
409         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
410         https://bugs.webkit.org/show_bug.cgi?id=171083
411
412         Unreviewed.
413
414         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
415
416 2017-04-20  Brady Eidson  <beidson@apple.com>
417
418         Add CompletionHandlerCallChecker to SPI added in r215545.
419         https://bugs.webkit.org/show_bug.cgi?id=171067
420
421         Reviewed by Dan Bernstein.
422
423         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
424         (TEST):
425         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
426
427 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
428
429         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
430         https://bugs.webkit.org/show_bug.cgi?id=170922
431         <rdar://problem/31634990>
432
433         Reviewed by Tim Horton.
434
435         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
436         WebKit2 ChangeLog for more details.
437
438         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
439         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
440         (TestWebKitAPI::TEST):
441         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
442
443 2017-04-20  Xan Lopez  <xlopez@igalia.com>
444
445         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
446         https://bugs.webkit.org/show_bug.cgi?id=170942
447
448         Reviewed by Carlos Garcia Campos.
449
450         Update glib and glib-networking to the last stable releases. This
451         is needed to get working TLS certificate verification at all at
452         least in Fedora.
453
454         * gtk/install-dependencies: add libmount, needed for newer glib.
455         * gtk/jhbuild.modules: update glib and glib-networking to last
456         stable releases.
457
458 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
459
460         [ATK] Implement support for DPub ARIA roles
461         https://bugs.webkit.org/show_bug.cgi?id=170679
462
463         Reviewed by Chris Fleizach.
464
465         Add DPub ARIA landmark roles to roleToString().
466
467         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
468
469 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
470
471         Remove WebKitTestRunner code for enabling features that are already enabled by default
472         https://bugs.webkit.org/show_bug.cgi?id=171033
473
474         Reviewed by Ryosuke Niwa.
475
476         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
477         (WTR::InjectedBundle::beginTesting):
478         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
479         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
480         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
481         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
482         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
483         * WebKitTestRunner/InjectedBundle/TestRunner.h:
484
485 2017-04-19  Youenn Fablet  <youenn@apple.com>
486
487         [Mac] Allow customizing H264 encoder
488         https://bugs.webkit.org/show_bug.cgi?id=170829
489
490         Reviewed by Alex Christensen.
491
492         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
493
494 2017-04-19  Brady Eidson  <beidson@apple.com>
495
496         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
497         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
498
499         Reviewed by Tim Horton.
500
501         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
502         (TEST):
503         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
504         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
505
506 2017-04-19  Brady Eidson  <beidson@apple.com>
507
508         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
509         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
510
511         Reviewed by Alex Christensen.
512
513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
514         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
515
516 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
517
518         [WK2] Run tests with ResourceLoadStatistics enabled
519         https://bugs.webkit.org/show_bug.cgi?id=170952
520
521         Reviewed by Andy Estes.
522
523         Excercise the load statistics code during tests.
524
525         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
526         (WTR::initializeWebViewConfiguration):
527
528 2017-04-19  Bill Ming  <mbbill@gmail.com>
529
530         close_fds should be set to False on Windows.
531         https://bugs.webkit.org/show_bug.cgi?id=170838
532
533         Reviewed by Brent Fulgham.
534
535         * Scripts/webkitpy/common/system/executive.py:
536         (Executive._should_close_fds):
537
538 2017-04-19  David Kilzer  <ddkilzer@apple.com>
539
540         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
541         <https://webkit.org/b/170994>
542         <rdar://problem/29889932>
543
544         Reviewed by Brent Fulgham.
545
546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
547         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
548         target.
549         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
550         (TestWebKitAPI::strip): Helper method to set/get environment
551         variable for testing.
552         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
553         tests.
554
555 2017-04-19  JF Bastien  <jfbastien@apple.com>
556
557         WebAssembly: add script which can import GCC torture tests
558         https://bugs.webkit.org/show_bug.cgi?id=170740
559
560         Reviewed by Saam Barati.
561
562         Add a script which can import the GCC torture tests and create a
563         yaml file to run them as part of jsc's WebAssembly regression
564         tests.
565
566         This patch doesn't commit the tests themselves because they're
567         licensed differently.
568
569         * Scripts/run-jsc-stress-tests: learn how to run
570         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
571         the options because WebAssembly is enabled by default.
572         * Scripts/update-wasm-gcc-torture.py: Added.
573         (parse_args):
574         (update_lkgr):
575         (untar_torture):
576         (list_js_files):
577         (waterfall_known_failures):
578         (create_yaml):
579         (main):
580
581 2017-04-19  Youenn Fablet  <youenn@apple.com>
582
583         Import web-platform-tests/tools
584         https://bugs.webkit.org/show_bug.cgi?id=170718
585
586         Reviewed by Alex Christensen.
587
588         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
589         (main):
590         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
591         (WebPlatformTestServer.ports_to_forward):
592         (WebPlatformTestServer._prepare_config):
593         (WebPlatformTestServer._install_modules): Deleted.
594         * Scripts/webkitpy/w3c/test_importer.py:
595         (TestImporter.write_html_files_for_templated_js_tests):
596
597 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
598
599         [WK2] Add infrastructure and unit tests for file uploads using data interaction
600         https://bugs.webkit.org/show_bug.cgi?id=170903
601         <rdar://problem/31314689>
602
603         Reviewed by Tim Horton.
604
605         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
606         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
607         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
608         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
609
610         New tests:
611         DataInteractionTests.ExternalSourceImageToFileInput
612         DataInteractionTests.ExternalSourceHTMLToUploadArea
613         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
614         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
615         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
616
617         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
618         (testIconImage):
619         (temporaryURLForDataInteractionFileLoad):
620         (cleanUpDataInteractionTemporaryPath):
621
622         Creates and tears down temporary file directories for testing data interaction.
623
624         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
625         (TestWebKitAPI::TEST):
626         * TestWebKitAPI/ios/DataInteractionSimulator.h:
627         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
628
629         Make necessary changes to be able to test what happens when data interaction ends over an element with no
630         operation. Previously, we would always simulate performing a data interaction operation when ending the
631         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
632         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
633         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
634         the phase to Cancelled and end the run.
635
636         (-[DataInteractionSimulator _resetSimulatedState]):
637         (-[DataInteractionSimulator runFrom:to:]):
638         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
639         (-[DataInteractionSimulator _advanceProgress]):
640         (-[DataInteractionSimulator externalItemProviders]):
641         (-[DataInteractionSimulator setExternalItemProviders:]):
642
643         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
644         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
645         take multiple item providers.
646
647         (-[DataInteractionSimulator externalItemProvider]): Deleted.
648         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
649
650 2017-04-18  John Wilander  <wilander@apple.com>
651
652         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
653         https://bugs.webkit.org/show_bug.cgi?id=170798
654         <rdar://problem/31595108>
655
656         Reviewed by Alex Christensen.
657
658         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
659         (TestWebKitAPI::TEST_F):
660             Added two negative test cases for WebCore::isPublicSuffix().
661             Added test cases with mixed case domains, localhost, and
662             non-ASCII for WebCore::topPrivatelyControlledDomain().
663
664 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
665
666         Unreviewed, rolling out r215346 and 215361.
667
668         The problem these changes were fixing was addressed in
669         <https://trac.webkit.org/changeset/215416/webkit>.
670
671         Reverted changesets:
672
673         "webkitpy: Ignore previously launched pid when system is under
674         stress"
675         https://bugs.webkit.org/show_bug.cgi?id=170741
676         http://trac.webkit.org/changeset/215346
677         http://trac.webkit.org/changeset/215361
678
679 2017-04-17  Alex Christensen  <achristensen@webkit.org>
680
681         Allow Variants of RetainPtrs
682         https://bugs.webkit.org/show_bug.cgi?id=170923
683
684         Reviewed by Tim Horton and Sam Weinig.
685
686         * TestWebKitAPI/Tests/WTF/Variant.cpp:
687         (TestWebKitAPI::TEST):
688         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
689         work in Variants.
690
691 2017-04-17  Brady Eidson  <beidson@apple.com>
692
693         Make WKHTTPCookieStore public.
694         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
695
696         Reviewed by Geoffrey Garen.
697
698         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
699         (TEST):
700
701 2017-04-17  Youenn Fablet  <youenn@apple.com>
702
703         Disable outdated WritableStream API
704         https://bugs.webkit.org/show_bug.cgi?id=170749
705         <rdar://problem/31446233>
706
707         Reviewed by Alex Christensen.
708
709         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
710         - A STREAMS_API compilation flag.
711         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
712
713         * DumpRenderTree/mac/DumpRenderTree.mm:
714         (enableExperimentalFeatures):
715         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
716         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
717         (WTR::InjectedBundle::beginTesting):
718         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
719         (WTR::TestRunner::setFetchAPIEnabled):
720         (WTR::TestRunner::setWritableStreamAPIEnabled):
721         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
722         * WebKitTestRunner/InjectedBundle/TestRunner.h:
723
724 2017-04-17  Tim Horton  <timothy_horton@apple.com>
725
726         Provide a viewport parameter to disable clipping to the safe area
727         https://bugs.webkit.org/show_bug.cgi?id=170766
728         <rdar://problem/31564634>
729
730         Reviewed by Beth Dakin.
731
732         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
733         (WTR::UIScriptController::setObscuredInsets):
734         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
735         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
736         (WTR::UIScriptController::setObscuredInsets):
737         * TestRunnerShared/UIScriptContext/UIScriptController.h:
738         * WebKitTestRunner/ios/TestControllerIOS.mm:
739         (WTR::TestController::platformResetStateToConsistentValues):
740         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
741         (WTR::UIScriptController::setObscuredInsets):
742         Add a UIScriptController mechanism to install obscured insets
743         on the web view.
744
745 2017-04-17  Dan Bernstein  <mitz@apple.com>
746
747         [Cocoa] Move isNullFunctionPointer down into WTF
748         https://bugs.webkit.org/show_bug.cgi?id=170892
749
750         Reviewed by Sam Weinig.
751
752         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
754         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
755         (TestWebKitAPI::TEST):
756         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
757         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
758         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
759         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
760
761 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
762
763         webkitpy: Correct poll when killing ServerProcess
764
765         Unreviewed infrastructure fix.
766
767         * Scripts/webkitpy/port/server_process.py:
768         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
769
770 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
771
772         [MediaStream] Enable getUserMedia API test
773         https://bugs.webkit.org/show_bug.cgi?id=170901
774         <rdar://problem/31656594>
775
776         Reviewed by Youenn Fablet.
777
778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
779
780         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
781         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
782         (TestWebKitAPI::TEST): Enable capture with mock devices.
783         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
784
785 2017-04-17  Xan Lopez  <xan@igalia.com>
786
787         [GTK] Update the Fedora dependencies for WebKitGTK+
788         https://bugs.webkit.org/show_bug.cgi?id=170590
789
790         Reviewed by Carlos Alberto Lopez Perez.
791
792         * gtk/install-dependencies: add a bunch of modules necessary to
793         get a proper set of GStreamer codecs for WebRTC.
794
795 2017-04-16  Sam Weinig  <sam@webkit.org>
796
797         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
798         https://bugs.webkit.org/show_bug.cgi?id=170843
799
800         Reviewed by Chris Dumez.
801
802         * DumpRenderTree/DerivedSources.make:
803         * WebKitTestRunner/DerivedSources.make:
804         * Scripts/webkitpy/bindings/main.py:
805         (BindingsTests.generate_from_idl):
806         Pass IDLAttributes.json, as it is now mandatory to have one.
807
808 2017-04-14  Mark Lam  <mark.lam@apple.com>
809
810         Update architectures in xcconfig files.
811         https://bugs.webkit.org/show_bug.cgi?id=170867
812         <rdar://problem/31628104>
813
814         Reviewed by Joseph Pecoraro.
815
816         * DumpRenderTree/mac/Configurations/Base.xcconfig:
817         * MobileMiniBrowser/Configurations/Base.xcconfig:
818         * TestWebKitAPI/Configurations/Base.xcconfig:
819         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
820         * WebKitTestRunner/Configurations/Base.xcconfig:
821
822 2017-04-14  Brady Eidson  <beidson@apple.com>
823
824         Fix basic WKURLSchemeHandler bugs.
825         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
826
827         Reviewed by Andy Estes.
828
829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
830         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
831         (-[SchemeHandler initWithData:mimeType:]):
832         (-[SchemeHandler dealloc]):
833         (-[SchemeHandler webView:startTask:]):
834         (-[SchemeHandler webView:stopTask:]):
835         (TEST):
836
837 2017-04-14  Bill Ming  <mbbill@gmail.com>
838
839         webkit-patch failed to detect git repository
840         https://bugs.webkit.org/show_bug.cgi?id=170859
841
842         Reviewed by Daniel Bates.
843
844         Windows cmd does not accept single quoted path. So, using
845         double quotes here will provide better platform compatibility.
846
847         * Scripts/VCSUtils.pm:
848         (isGitDirectory):
849         (isGitSVNDirectory):
850         (svnRevisionForDirectory):
851         (svnInfoForPath):
852
853 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
854
855         Unreviewed, rolling out r215374.
856
857         This change causes LayoutTests to exit early with crashes on
858         Sierra.
859
860         Reverted changeset:
861
862         "webkitpy: Ignore previously launched pid when system is under
863         stress"
864         https://bugs.webkit.org/show_bug.cgi?id=170741
865         http://trac.webkit.org/changeset/215374
866
867 2017-04-14  Dan Bernstein  <mitz@apple.com>
868
869         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
870         https://bugs.webkit.org/show_bug.cgi?id=170856
871
872         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
873
874         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
875
876 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
877
878         webkitpy: Ignore previously launched pid when system is under stress
879         https://bugs.webkit.org/show_bug.cgi?id=170741
880
881         Unreviewed infrastructure fix.
882
883         Drivers are destroyed between failing layout tests, which is not necessary and
884         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
885
886         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
887         (Worker._kill_driver): Do not destroy drivers when they are stopped.
888         * Scripts/webkitpy/port/driver.py:
889         (Driver.stop): Reset driver values set in initializer.
890
891 2017-04-14  Andy Estes  <aestes@apple.com>
892
893         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
894         https://bugs.webkit.org/show_bug.cgi?id=167594
895
896         Re-enabled this API test now that webkit.org/b/161967 is fixed.
897
898         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
899         (TEST):
900
901 2017-04-14  Andy Estes  <aestes@apple.com>
902
903         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
904         https://bugs.webkit.org/show_bug.cgi?id=161967
905
906         Reviewed by Alexey Proskuryakov.
907
908         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
909         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
910
911 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
912
913         Unreviewed, rolling out r215363.
914
915         This change causes LayoutTests to exit early with crashes.
916
917         Reverted changeset:
918
919         "webkitpy: Ignore previously launched pid when system is under
920         stress"
921         https://bugs.webkit.org/show_bug.cgi?id=170741
922         http://trac.webkit.org/changeset/215363
923
924 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
925
926         webkitpy: Ignore previously launched pid when system is under stress
927         https://bugs.webkit.org/show_bug.cgi?id=170741
928
929         Unreviewed infrastructure fix.
930
931         Drivers are destroyed between failing layout tests, which is not necessary and
932         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
933
934         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
935         (Worker._kill_driver): Do not destroy drivers when they are stopped.
936
937 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
938
939         webkitpy: Ignore previously launched pid when system is under stress
940         https://bugs.webkit.org/show_bug.cgi?id=170741
941
942         Unreviewed infrastructure fix.
943
944         Server processes are destroyed in the driver, which is not necessary and prevents
945         the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
946
947         * Scripts/webkitpy/port/driver.py:
948         (Driver.run_test): Do not destroy server process.
949         (Driver._start): Only create the server process if it is None.
950         (Driver.stop): Do not destroy server process.
951
952 2017-04-13  Dan Bernstein  <mitz@apple.com>
953
954         [Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
955         https://bugs.webkit.org/show_bug.cgi?id=170387
956
957         Reviewed by Sam Weinig.
958
959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
960         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.
961         (TEST):
962         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.
963         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
964         (-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
965         (-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):
966         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.
967
968 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
969
970         webkitpy: Ignore previously launched pid when system is under stress
971         https://bugs.webkit.org/show_bug.cgi?id=170741
972
973         Reviewed by David Kilzer.
974
975         We have seen cases where xcrun simctl launch will return a pid of a previous
976         process and the process will appear to be running even though it is crashing.
977         Ensure that the PID that simulator_process is receiving is not the pid of the
978         previously run process.
979
980         * Scripts/webkitpy/port/simulator_process.py:
981         (SimulatorProcess._start): Check to make sure we aren't receiving an old PID.
982
983 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
984
985         Build ImageDiff with host SDK
986         https://bugs.webkit.org/show_bug.cgi?id=168531
987
988         Reviewed by David Kilzer.
989
990         ImageDiff should be built and run with the host SDK, not the target SDK.
991         Build ImageDiff twice, once for the target SDK and once for the host
992         as an intermediate step towards building for only the host SDK.
993
994         * ImageDiff/Makefile: Added.
995         * Makefile: Add ImageDiff to list of targets.
996         * Scripts/build-imagediff: Build bmalloc and WTF for the host.
997         * Scripts/build-webkit: Build ImageDiff for host.
998         * Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.
999         (extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.
1000         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
1001         * Scripts/webkitpy/port/base.py:
1002         (Port.check_build): Attempt to build image diff if not found.
1003         (Port.check_image_diff): Enable logging flag.
1004         (Port._build_image_diff): Allow webkitpy to build image-diff during testing.
1005
1006 2017-04-12  Alex Christensen  <achristensen@webkit.org>
1007
1008         Clean up SharedBuffer public functions
1009         https://bugs.webkit.org/show_bug.cgi?id=170795
1010
1011         Reviewed by Andreas Kling.
1012
1013         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1014         (TestWebKitAPI::TEST_F):
1015
1016 2017-04-12  Dan Bernstein  <mitz@apple.com>
1017
1018         [Mac] Future-proof .xcconfig files
1019         https://bugs.webkit.org/show_bug.cgi?id=170802
1020
1021         Reviewed by Tim Horton.
1022
1023         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1024         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1025         * MiniBrowser/Configurations/Base.xcconfig:
1026         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1027         * TestWebKitAPI/Configurations/Base.xcconfig:
1028         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1029         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1030         * WebKitTestRunner/Configurations/Base.xcconfig:
1031         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1032
1033 2017-04-12  Alex Christensen  <achristensen@webkit.org>
1034
1035         Remove unused SharedBuffer::wrapCFDataArray
1036         https://bugs.webkit.org/show_bug.cgi?id=170794
1037
1038         Reviewed by Brady Eidson.
1039
1040         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1041         (TestWebKitAPI::TEST_F):
1042
1043 2017-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1044
1045         [WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
1046         https://bugs.webkit.org/show_bug.cgi?id=170502
1047
1048         Reviewed by Mark Lam.
1049
1050         Mechanical change. Use Thread:: APIs.
1051
1052         * DumpRenderTree/JavaScriptThreading.cpp:
1053         (runJavaScriptThread):
1054         (startJavaScriptThreads):
1055         (stopJavaScriptThreads):
1056         * DumpRenderTree/mac/DumpRenderTree.mm:
1057         (testThreadIdentifierMap):
1058         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1059         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1060         (TestWebKitAPI::runLockTest):
1061         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1062
1063 2017-04-12  Alex Christensen  <achristensen@webkit.org>
1064
1065         Modernize vector adoption
1066         https://bugs.webkit.org/show_bug.cgi?id=170758
1067
1068         Reviewed by Geoffrey Garen.
1069
1070         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1071         (TestWebKitAPI::TEST_F):
1072
1073 2017-04-11  Dean Jackson  <dino@apple.com>
1074
1075         Disable outdated WritableStream API
1076         https://bugs.webkit.org/show_bug.cgi?id=170749
1077         <rdar://problem/31446233>
1078
1079         Reviewed by Tim Horton.
1080
1081         The API we implement is no longer accurate. Disable it until we
1082         are compatible with the new specification
1083
1084         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1085
1086 2017-04-11  David Quesada  <david_quesada@apple.com>
1087
1088         Add SPI for handling geolocation authorization requests
1089         https://bugs.webkit.org/show_bug.cgi?id=170362
1090         rdar://problem/17508627
1091
1092         Reviewed by Alex Christensen.
1093
1094         Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
1095         to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
1096         provide a stub object to simulate the various configurations of geolocation permissions:
1097         1. The app doesn't have permission to use geolocation.
1098         2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
1099         3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.
1100
1101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1102         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.
1103         (-[TestCoreLocationProvider setListener:]):
1104         (-[TestCoreLocationProvider requestGeolocationAuthorization]):
1105         (-[TestCoreLocationProvider start]):
1106         (-[TestCoreLocationProvider stop]):
1107         (-[TestCoreLocationProvider setEnableHighAccuracy:]):
1108         (expectException):
1109         (-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
1110         (-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1111         (TestWebKitAPI::TEST):
1112         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.
1113
1114 2017-04-10  Matt Rajca  <mrajca@apple.com>
1115
1116         Change autoplay state to "prevented" when media is paused due to restrictions.
1117         https://bugs.webkit.org/show_bug.cgi?id=170686
1118
1119         Reviewed by Alex Christensen.
1120
1121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1122         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
1123         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1124         (TEST):
1125
1126 2017-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
1127
1128         [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
1129         https://bugs.webkit.org/show_bug.cgi?id=170725
1130
1131         Reviewed by Sam Weinig.
1132
1133         * TestWebKitAPI/Tests/WTF/Time.cpp:
1134         (TestWebKitAPI::TEST):
1135
1136 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1137
1138         Revert r215217
1139         https://bugs.webkit.org/show_bug.cgi?id=170703
1140
1141         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1142
1143 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1144
1145         Continue enabling WebRTC
1146         https://bugs.webkit.org/show_bug.cgi?id=170703
1147
1148         Reviewed by Youenn Fablet.
1149
1150         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1151
1152 2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
1153
1154         Have parseRevisionProperty use default repo name as the Buildbot key.
1155         https://bugs.webkit.org/show_bug.cgi?id=170696
1156
1157         Reviewed by Daniel Bates.
1158
1159         Previously, we needed to set a key and a fallbackKey when addressing
1160         Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
1161         that the repo name maps exactly to that key for every repository other
1162         than WebKit.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1165         Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
1166
1167 2017-04-10  Aakash Jain  <aakash_jain@apple.com>
1168
1169         Add test262 JavaScriptCore tests to dashboard
1170         https://bugs.webkit.org/show_bug.cgi?id=170711
1171
1172         Rubber-stamped by Joseph Pecoraro.
1173
1174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1175         (WebKitBuildbot): Added test262 JSC tests to dashboard.
1176
1177 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1178
1179         REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
1180         https://bugs.webkit.org/show_bug.cgi?id=170707
1181         <rdar://problem/27788755>
1182
1183         Reviewed by Tim Horton.
1184
1185         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
1186         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1187         (TEST_F):
1188         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1189         (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1190         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1191         (TEST):
1192
1193 2017-04-10  Alex Christensen  <achristensen@webkit.org>
1194
1195         Add API to get available content extension identifiers in a WKContentExtensionStore
1196         https://bugs.webkit.org/show_bug.cgi?id=170093
1197
1198         Reviewed by Geoffrey Garen.
1199
1200         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
1201         (TEST_F):
1202
1203 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1204
1205         Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
1206         https://bugs.webkit.org/show_bug.cgi?id=170658
1207
1208         Reviewed by Tim Horton.
1209
1210         Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
1211         preparation is synchronous, or passes if it is asynchronous.
1212
1213         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1214         (TestWebKitAPI::TEST):
1215         * TestWebKitAPI/cocoa/TestWKWebView.h:
1216         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1217         (-[TestWKWebView initWithFrame:]):
1218         (-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
1219         (-[TestWKWebView _setUpTestWindow:]):
1220
1221 2017-04-10  Brent Fulgham  <bfulgham@apple.com>
1222
1223         [WK2][macOS] Block access to Apple Events before launch.
1224         https://bugs.webkit.org/show_bug.cgi?id=170626
1225         <rdar://problem/16079334>
1226
1227         Reviewed by Alexey Proskuryakov.
1228
1229         Add a new TestWebKitAPI test that fails if Apple Events are sent.
1230
1231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1232         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
1233         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1234         (TestWebKitAPI::didFinishLoadForFrame):
1235         (TestWebKitAPI::TEST):
1236         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
1237         (TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
1238         (TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
1239
1240 2017-04-10  Guillaume Emont  <guijemont@igalia.com>
1241
1242         [JSC] Do not run FTL stress tests on MIPS
1243         https://bugs.webkit.org/show_bug.cgi?id=170684
1244
1245         Reviewed by Carlos Alberto Lopez Perez.
1246
1247         run-jsc-stress-tests does not correctly detect MIPS platforms, and its
1248         logic to detect if the platform supports FTL ignores that MIPS does
1249         not support FTL. This adds detection of MIPS (with the magic number
1250         determined empirically) and fixes the determination of whether we
1251         support FTL.
1252
1253         * Scripts/run-jsc-stress-tests:
1254
1255 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
1256
1257         webkitpy: Increase estimate for processes run by iOS Simulators
1258         https://bugs.webkit.org/show_bug.cgi?id=170678
1259         <rdar://problem/31534061>
1260
1261         Reviewed by Aakash Jain.
1262
1263         Previously, it was estimated that each simulated iOS device would run about 100
1264         processes.  With newer versions of iOS, this is closer to 125.
1265
1266         * Scripts/webkitpy/port/ios_simulator.py:
1267         (IOSSimulatorPort): Increase process estimate from 100 to 125.
1268
1269 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
1270
1271         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
1272         https://bugs.webkit.org/show_bug.cgi?id=170553
1273
1274         Reviewed by Michael Catanzaro.
1275
1276         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
1277         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
1278         to properly position popup menus, and also avoids using functions
1279         which were deprecated starting at that GTK+ release.
1280
1281         * MiniBrowser/gtk/BrowserSearchBar.c:
1282         (searchEntryMenuIconPressedCallback):
1283         Update MiniBrowser to use gtk_menu_popup_at_pointer().
1284
1285 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1286
1287         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
1288         https://bugs.webkit.org/show_bug.cgi?id=170677
1289         <rdar://problem/31512633>
1290
1291         Reviewed by Tim Horton.
1292
1293         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
1294         to allow dropping URLs to trigger page navigation.
1295
1296         * DumpRenderTree/TestOptions.h:
1297         * DumpRenderTree/TestOptions.mm:
1298         (TestOptions::TestOptions):
1299         * DumpRenderTree/mac/DumpRenderTree.mm:
1300         (resetWebViewToConsistentStateBeforeTesting):
1301         * DumpRenderTree/mac/UIDelegate.h:
1302         * DumpRenderTree/mac/UIDelegate.mm:
1303         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
1304         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
1305
1306 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1307
1308         update-webkit-dependency should report $response->message for diagnose
1309         https://bugs.webkit.org/show_bug.cgi?id=170666
1310
1311         Reviewed by Alex Christensen.
1312
1313         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
1314
1315 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1316
1317         Data interaction on an image enclosed by an anchor should vend the anchor's URL
1318         https://bugs.webkit.org/show_bug.cgi?id=170660
1319         <rdar://problem/31043220>
1320
1321         Reviewed by Tim Horton.
1322
1323         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
1324         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
1325         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
1326         rects, but should not be.
1327
1328         See WebCore ChangeLog for more details.
1329
1330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1331         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
1332         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1333         (TestWebKitAPI::TEST):
1334
1335 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1336
1337         [GTK] Remove the GDK dependency from ImageDiff
1338         https://bugs.webkit.org/show_bug.cgi?id=85299
1339
1340         Reviewed by Žan Doberšek.
1341
1342         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
1343         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
1344         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
1345         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
1346         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
1347         and also add CG implementation.
1348
1349         * ImageDiff/CMakeLists.txt:
1350         * ImageDiff/Cairo.cmake: Added.
1351         * ImageDiff/ImageDiff.cpp: Added.
1352         (main):
1353         * ImageDiff/PlatformGTK.cmake:
1354         * ImageDiff/PlatformImage.cpp: Added.
1355         (ImageDiff::PlatformImage::isCompatible):
1356         (ImageDiff::PlatformImage::difference):
1357         * ImageDiff/PlatformImage.h: Added.
1358         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
1359         (ImageDiff::PlatformImage::createFromStdin):
1360         (ImageDiff::PlatformImage::createFromDiffData):
1361         (ImageDiff::PlatformImage::PlatformImage):
1362         (ImageDiff::PlatformImage::~PlatformImage):
1363         (ImageDiff::PlatformImage::width):
1364         (ImageDiff::PlatformImage::height):
1365         (ImageDiff::PlatformImage::rowBytes):
1366         (ImageDiff::PlatformImage::hasAlpha):
1367         (ImageDiff::PlatformImage::pixels):
1368         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1369         * ImageDiff/gtk/ImageDiff.cpp: Removed.
1370
1371 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1372
1373         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
1374         https://bugs.webkit.org/show_bug.cgi?id=170667
1375
1376         Reviewed by Žan Doberšek.
1377
1378         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
1379         that value.
1380
1381         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1382         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
1383
1384 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1385
1386         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
1387         https://bugs.webkit.org/show_bug.cgi?id=170653
1388
1389         Reviewed by Tim Horton.
1390
1391         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
1392         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
1393         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
1394         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
1395
1396         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
1397         * WebKitTestRunner/TestInvocation.cpp:
1398         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
1399         results were created in the web process.
1400         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
1401         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1402         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
1403         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
1404         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1405         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
1406         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
1407         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
1408         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
1409         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
1410         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1411         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
1412         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
1413         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1414         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
1415         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1416         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1417
1418 2017-04-10  Chris Dumez  <cdumez@apple.com>
1419
1420         Drop Timer::startOneShot() overload taking a double
1421         https://bugs.webkit.org/show_bug.cgi?id=170659
1422
1423         Reviewed by Yusuke Suzuki.
1424
1425         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
1426
1427         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1428         (TestWebKitAPI::TEST):
1429         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1430         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1431
1432 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1433
1434         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
1435         https://bugs.webkit.org/show_bug.cgi?id=170658
1436         <rdar://problem/31431450>
1437
1438         Reviewed by Tim Horton.
1439
1440         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
1441         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
1442         should complete before the unresponsiveness timeout is triggered.
1443
1444         See WebKit2 ChangeLog for more details.
1445
1446         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1447         (TestWebKitAPI::TEST):
1448
1449 2017-04-09  Chris Dumez  <cdumez@apple.com>
1450
1451         Drop Timer::startRepeating() overload taking a double
1452         https://bugs.webkit.org/show_bug.cgi?id=170656
1453
1454         Reviewed by Yusuke Suzuki.
1455
1456         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
1457
1458         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1459         (TestWebKitAPI::TEST):
1460
1461 2017-04-09  Youenn Fablet  <youenn@apple.com>
1462
1463         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
1464         https://bugs.webkit.org/show_bug.cgi?id=170647
1465
1466         Reviewed by Sam Weinig.
1467
1468         * Scripts/webkitpy/common/checkout/scm/git.py:
1469         (Git.fetch): Fetching origin remote in case there is more than one.
1470
1471 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
1472
1473         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
1474         https://bugs.webkit.org/show_bug.cgi?id=170643
1475
1476         Reviewed by Chris Dumez.
1477         
1478         Update the CSSProperties.json style checker to allow:
1479             - comments in codegen_properties
1480             - obsolete-category and obsolete-url in specification blocks
1481             - renamed "done" to "supported"
1482             
1483         Fix some references to codegen_properties to be codegen-properties.
1484
1485         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1486         (JSONCSSPropertiesChecker.validate_status_type):
1487         (JSONCSSPropertiesChecker.validate_property_specification):
1488         (JSONCSSPropertiesChecker.check_codegen_properties):
1489
1490 2017-04-08  Youenn Fablet  <youenn@apple.com>
1491
1492         WebRTC tests gardening
1493         https://bugs.webkit.org/show_bug.cgi?id=170508
1494
1495         Reviewed by Eric Carlson.
1496
1497         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1498
1499 2017-04-07  Keith Miller  <keith_miller@apple.com>
1500
1501         Add a PriorityQueue class
1502         https://bugs.webkit.org/show_bug.cgi?id=170579
1503
1504         Reviewed by Saam Barati.
1505
1506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1507         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
1508         (operator  _z ):
1509         (enqueue):
1510         (dequeue):
1511         (TEST):
1512         (compareMove):
1513
1514 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
1515
1516         Replace ES6SampleBench by ARES-6 in run-benchmark
1517         https://bugs.webkit.org/show_bug.cgi?id=170585
1518
1519         Reviewed by Saam Barati.
1520
1521         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
1522         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
1523
1524         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
1525         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
1526
1527 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
1528
1529         REGRESSION(r211382): Complex text with justification erroneously overflows containers
1530         https://bugs.webkit.org/show_bug.cgi?id=170399
1531         <rdar://problem/31442008>
1532
1533         Reviewed by Simon Fraser.
1534
1535         Check for the invariant that the sum of the advances is equal to m_totalWidth.
1536
1537         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1538         (TestWebKitAPI::TEST_F):
1539
1540 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
1541
1542         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
1543         https://bugs.webkit.org/show_bug.cgi?id=167594
1544
1545         Unreviewed test gardening.
1546
1547         Disable this test because it is still timing out on the bots.
1548
1549         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1550         (TEST):
1551
1552 2017-04-07  Jonathan Bedard  <jbedard@apple.com>
1553
1554         REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
1555         https://bugs.webkit.org/show_bug.cgi?id=170601
1556         <rdar://problem/31492696>
1557
1558         Reviewed by Simon Fraser.
1559
1560         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1561         (setUpIOSLayoutTestCommunication): Skip TCP setup if no port is in the environment.
1562         (tearDownIOSLayoutTestCommunication): Only teardown if TCP was used.
1563
1564 2017-04-07  Aakash Jain  <aakash_jain@apple.com>
1565
1566         Add support for test262 JavaScriptCore tests
1567         https://bugs.webkit.org/show_bug.cgi?id=170523
1568
1569         Reviewed by Daniel Bates.
1570
1571         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bot433 and bot434.
1572         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1573         (RunTest262Tests): Added class to run Test262 tests.
1574         (RunTest262Tests.start): Added.
1575         (RunTest262Tests.countFailures): Method to count the failures.
1576         (Test262Factory): Added Test262 factory class.
1577         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1578         (RunTest262TestsTest): Added unit tests.
1579         (RunTest262TestsTest.assertResults): Helper method.
1580         (RunTest262TestsTest.test_no_regressions_output): Added test case.
1581         (test_failure_output): Same. 
1582         (test_failures_output): Same.
1583
1584 2017-04-07  Caio Lima  <ticaiolima@gmail.com>
1585
1586         [JSC] Change --debug option to --debugger
1587         https://bugs.webkit.org/show_bug.cgi?id=170587
1588
1589         Reviewed by Keith Miller.
1590
1591         * Scripts/run-jsc:
1592
1593         This patch is changing the new debugger flag for Tools/Scripts/run-jsc
1594         to --debugger to avoid shadowing --debug flag used to run JSC with
1595         Debug build.
1596
1597 2017-04-07  Brent Fulgham  <bfulgham@apple.com>
1598
1599         WebKit should percent encode single quotes in query strings
1600         https://bugs.webkit.org/show_bug.cgi?id=170561
1601         <rdar://problem/7415154>
1602
1603         Reviewed by Alex Christensen.
1604
1605         Add a test case for single-quote in the URL query string.
1606
1607         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1608
1609 2017-04-06  Myles C. Maxfield  <mmaxfield@apple.com>
1610
1611         Make FontWithFeatures test font pass OTS
1612         https://bugs.webkit.org/show_bug.cgi?id=169788
1613
1614         Reviewed by Tim Horton.
1615
1616         OTS, or the OpenType Sanitizer, is a check which tells if fonts are properly formed.
1617         Previously, our FontWithFeatures test font did not pass this check. This patch updates
1618         the font to pass the checks. Now, we can use this font on other platforms, and
1619         contribute the font to the W3C for testing the CSS Fonts level 3 spec.
1620
1621         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1622         (Generator::appendCFFTable):
1623         (Generator::Feature::operator<):
1624         (Generator::appendGSUBTable):
1625         (Generator::appendOS2Table):
1626         (Generator::appendFormat4CMAPTable):
1627         (Generator::appendHEADTable):
1628         (Generator::appendHHEATable):
1629         (Generator::NameRecord::operator<):
1630         (Generator::appendNameSubtable):
1631         (Generator::appendNAMETable):
1632
1633 2017-04-06  Alexey Proskuryakov  <ap@apple.com>
1634
1635         Disable flaky WebKit2.ResizeWithHiddenContentDoesNotHang
1636         for https://bugs.webkit.org/show_bug.cgi?id=170195
1637
1638         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1639
1640 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
1641
1642         Unreviewed, rolling out r215046.
1643
1644         This change broke internal builds.
1645
1646         Reverted changeset:
1647
1648         "WebRTC tests gardening"
1649         https://bugs.webkit.org/show_bug.cgi?id=170508
1650         http://trac.webkit.org/changeset/215046
1651
1652 2017-04-06  Youenn Fablet  <youenn@apple.com>
1653
1654         WebRTC tests gardening
1655         https://bugs.webkit.org/show_bug.cgi?id=170508
1656
1657         Reviewed by Eric Carlson.
1658
1659         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1660
1661 2017-04-06  Jonathan Bedard  <jbedard@apple.com>
1662
1663         REGRESSION: Simulators failing to install after launch_app times out
1664         <rdar://problem/31478107>
1665
1666         Unreviewed infrastructure fix.
1667
1668         * Scripts/webkitpy/xcode/simulated_device.py:
1669         (SimulatedDevice.launch_app._install_timeout): Raise RuntimeError, not Exception.
1670
1671 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
1672
1673         test262: module test progressions need updated expectations (@@iterator changes)
1674         https://bugs.webkit.org/show_bug.cgi?id=170535
1675
1676         Reviewed by Saam Barati.
1677
1678         * Scripts/run-jsc-stress-tests:
1679         Add :failDueToOutdatedOrBadTest to distinguish between a test failure
1680         in JavaScriptCore or an outdated or incorrect test262 test.
1681
1682 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
1683
1684         Remove run-jsc-stress-tests benign warning about otool '-S' switch
1685         https://bugs.webkit.org/show_bug.cgi?id=170527
1686
1687         Reviewed by Aakash Jain.
1688
1689         * Scripts/run-jsc-stress-tests:
1690         The switch is not necessary and produces an error.
1691
1692 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
1693
1694         webkitpy: Add pid logging for simulator processes
1695         https://bugs.webkit.org/show_bug.cgi?id=170505
1696
1697         Reviewed by Alexey Proskuryakov.
1698
1699         * Scripts/webkitpy/port/simulator_process.py:
1700         (SimulatorProcess._start.handler): Add pid to exception.
1701         (SimulatorProcess._start): Ditto.
1702         * Scripts/webkitpy/xcode/simulated_device.py:
1703         (SimulatedDevice.launch_app): Log pid when the process fails to launch and when
1704         a pid is successfully returned.
1705
1706 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
1707
1708         Unreviewed, rolling out r214932.
1709
1710         This change broke an internal build.
1711
1712         Reverted changeset:
1713
1714         "[ios-simulator] API test WebKit2.DataDetectionReferenceDate
1715         timing out"
1716         https://bugs.webkit.org/show_bug.cgi?id=161967
1717         http://trac.webkit.org/changeset/214932
1718
1719 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
1720
1721         Unreviewed, rolling out r214962.
1722
1723         Roll r214937 back in because it wasn't at fault for the build
1724         breakage.
1725
1726         Reverted changeset:
1727
1728         "Unreviewed, rolling out r214937."
1729         https://bugs.webkit.org/show_bug.cgi?id=170365
1730         http://trac.webkit.org/changeset/214962
1731
1732 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
1733
1734         Unreviewed, rolling out r214937.
1735
1736         This change broke an internal build.
1737
1738         Reverted changeset:
1739
1740         "REGRESSION (r202472): Data Detection overwrites existing
1741         links in detected ranges"
1742         https://bugs.webkit.org/show_bug.cgi?id=170365
1743         http://trac.webkit.org/changeset/214937
1744
1745 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
1746
1747         Increase timeouts for simulator testing
1748         Unreviewed infrastructure fix.
1749
1750         r214895 was not sufficient, increasing timeouts again.
1751
1752         * Scripts/webkitpy/xcode/simulated_device.py:
1753         (SimulatedDevice.install_app): Increase timeout from 3 to 10 seconds.
1754
1755 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
1756
1757         Formatting fix to remove extra space.
1758
1759         Unreviewed formatting fix.
1760
1761         * Scripts/webkitdirs.pm:
1762         (isEmbeddedWebKit): Remove extra space.
1763
1764 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
1765
1766         Rename isIOSLikeWebKit to isEmbeddedWebKit.
1767
1768         Rubber-stamped by Alexey Proskuryakov. 
1769
1770         * Scripts/webkitdirs.pm:
1771         (isEmbeddedWebKit): Added
1772         (isIOSLikeWebKit): Deleted.
1773
1774 2017-04-05  Alex Christensen  <achristensen@webkit.org>
1775
1776         Fix CMake build.
1777
1778         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1779         * TestRunnerShared/spi/CoreGraphicsSPI.h: Removed.
1780         * TestRunnerShared/spi/CoreGraphicsTestSPI.h: Copied from Tools/TestRunnerShared/spi/CoreGraphicsSPI.h.
1781         There is a CoreGraphicsSPI.h in WebCore and the CMake build was finding the wrong one.
1782         Since we just inherit the include paths from WebCore in the CMake build and since this SPI is only used for testing,
1783         I just renamed CoreGraphicsSPI.h to CoreGraphicsTestSPI.h to avoid any name collisions.
1784         * WebKitTestRunner/PlatformMac.cmake:
1785         Add some missing files.
1786         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1787
1788 2017-04-05  Keith Miller  <keith_miller@apple.com>
1789
1790         Add debug option to run-jsc script
1791         https://bugs.webkit.org/show_bug.cgi?id=170503
1792
1793         Reviewed by Yusuke Suzuki.
1794
1795         Adds a new option to the run-jsc script so that when passed
1796         "--debug" it will wrap the jsc call with an lldb invocation. If
1797         someone wishes to use a different debugger they can set the
1798         DEBUGGER environment variable. Additionally, run-jsc now exits
1799         with the exit status of the jsc call.
1800
1801         * Scripts/run-jsc:
1802
1803 2017-04-05  Andy Estes  <aestes@apple.com>
1804
1805         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
1806         https://bugs.webkit.org/show_bug.cgi?id=170365
1807         <rdar://problem/29205721>
1808
1809         Reviewed by Tim Horton.
1810
1811         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1812         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
1813         (TEST): Re-enabled the test, which now passes.
1814
1815 2017-04-05  Andy Estes  <aestes@apple.com>
1816
1817         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
1818         https://bugs.webkit.org/show_bug.cgi?id=167594
1819
1820         Re-enabled this API test now that webkit.org/b/161967 is fixed.
1821
1822         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1823         (TEST):
1824
1825 2017-04-05  Andy Estes  <aestes@apple.com>
1826
1827         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
1828         https://bugs.webkit.org/show_bug.cgi?id=161967
1829
1830         Reviewed by Alexey Proskuryakov.
1831
1832         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1833         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
1834
1835 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
1836
1837         Various settings in Minibrowser are off by default, and should be on
1838         https://bugs.webkit.org/show_bug.cgi?id=170465
1839         rdar://problem/31421543
1840
1841         Reviewed by Tim Horton.
1842
1843         Explicitly set preferences that should be on by default to enabled, if they have not been
1844         set previously.
1845
1846         * MiniBrowser/mac/SettingsController.m:
1847         (-[SettingsController init]):
1848
1849 2017-04-04  JF Bastien  <jfbastien@apple.com>
1850
1851         Add JF Bastien as reviewer
1852         https://bugs.webkit.org/show_bug.cgi?id=170481
1853
1854         Reviewed by Mark Lam.
1855
1856         * Scripts/webkitpy/common/config/contributors.json:
1857
1858 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
1859
1860         Increase timeouts for simulator testing
1861
1862         Unreviewed infrastructure fix.
1863
1864         * Scripts/webkitpy/port/simulator_process.py:
1865         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
1866         * Scripts/webkitpy/xcode/simulated_device.py:
1867         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
1868
1869 2017-04-04  Tim Horton  <timothy_horton@apple.com>
1870
1871         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
1872         https://bugs.webkit.org/show_bug.cgi?id=165801
1873         <rdar://problem/29649535>
1874
1875         Reviewed by Wenson Hsieh.
1876
1877         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
1878         (TEST):
1879         Add some tests for wrapping finds.
1880
1881 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1882
1883         Add some new patterns to filter-build-webkit
1884         https://bugs.webkit.org/show_bug.cgi?id=170429
1885
1886         Reviewed by Alexey Proskuryakov.
1887
1888         * Scripts/filter-build-webkit:
1889         (setOutputFormatOption):
1890
1891 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1892
1893         Data interaction should register type identifiers in order of priority
1894         https://bugs.webkit.org/show_bug.cgi?id=170428
1895         <rdar://problem/30633296>
1896
1897         Reviewed by Tim Horton.
1898
1899         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
1900         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
1901         test for data interaction from a textarea to an input.
1902
1903         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1904         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
1905         (TestWebKitAPI::TEST):
1906         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1907         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1908         (-[DataInteractionSimulator _advanceProgress]):
1909         (-[DataInteractionSimulator sourceItemProviders]):
1910         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
1911
1912 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1913
1914         [GTK][JHBuild] Update mesa repository url for tarballs
1915         https://bugs.webkit.org/show_bug.cgi?id=170431
1916
1917         Reviewed by Michael Catanzaro.
1918
1919         * gtk/jhbuild.modules:
1920
1921 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1922
1923         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
1924         https://bugs.webkit.org/show_bug.cgi?id=170430
1925
1926         Reviewed by Alexey Proskuryakov.
1927
1928         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
1929         Eliminate one of the copies of Ahem.ttf.
1930
1931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1932         Once eliminated, there is now only one Ahem.ttf that is copied
1933         to the Resources bundle. Drive-by sort the project file.
1934
1935 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
1936
1937         Allow MiniBrowser windows to receive local file drags again
1938         https://bugs.webkit.org/show_bug.cgi?id=170422
1939
1940         Reviewed by Wenson Hsieh.
1941
1942         Adopt the new UIDelegate SPI to allow drops.
1943
1944         * MiniBrowser/mac/WK2BrowserWindowController.m:
1945         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
1946
1947 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1948
1949         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
1950         https://bugs.webkit.org/show_bug.cgi?id=170426
1951
1952         Reviewed by Michael Catanzaro.
1953
1954         * gtk/jhbuild.modules:
1955
1956 2017-04-03  Nan Wang  <n_wang@apple.com>
1957
1958         AX: Expose link children when doing search predication on iOS
1959         https://bugs.webkit.org/show_bug.cgi?id=170424
1960         <rdar://problem/31413335>
1961
1962         Reviewed by Chris Fleizach.
1963
1964         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1965         (AccessibilityUIElement::uiElementForSearchPredicate):
1966         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1967         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1968
1969 2017-04-03  Brian Burg  <bburg@apple.com>
1970
1971         run-safari should support launching with custom language and locale
1972         https://bugs.webkit.org/show_bug.cgi?id=170397
1973
1974         Reviewed by Alexey Proskuryakov.
1975
1976         Hook up -AppleLanguages and -AppleLocale to command line options.
1977
1978         * Scripts/webkitdirs.pm:
1979         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1980         (argumentsForRunAndDebugMacWebKitApp):
1981
1982 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
1983
1984         webkitpy: Provide option to skip install
1985         https://bugs.webkit.org/show_bug.cgi?id=170344
1986
1987         Reviewed by Alexey Proskuryakov.
1988
1989         Installing can take time for on device testing.  Provide an option to skip install
1990         and use whatever driver is currently installed on the device or simulator.
1991
1992         * Scripts/webkitpy/port/base.py:
1993         (Port.check_build): Do not check driver if skipping install.
1994         * Scripts/webkitpy/port/factory.py:
1995         (platform_options): Add '--no-install' option.
1996         * Scripts/webkitpy/port/ios.py:
1997         (IOSPort.setup_test_run): Check install option before installing.
1998
1999 2017-04-03  Keith Miller  <keith_miller@apple.com>
2000
2001         WebAssembly: Update spec tests
2002         https://bugs.webkit.org/show_bug.cgi?id=170361
2003
2004         Rubber-stamped by Saam Barati.
2005
2006         Update the runner to know the new wasm spec test harness code.
2007
2008         * Scripts/run-jsc-stress-tests:
2009
2010 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
2011
2012         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
2013
2014         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
2015         https://bugs.webkit.org/show_bug.cgi?id=170365
2016
2017         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2018
2019 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2020
2021         Mac cmake buildfix after 214586.
2022         https://bugs.webkit.org/show_bug.cgi?id=170381
2023
2024         Unreviewed speculative buildfix.
2025
2026         * WebKitTestRunner/PlatformMac.cmake:
2027
2028 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2029
2030         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
2031         https://bugs.webkit.org/show_bug.cgi?id=161675
2032
2033         * WebKitTestRunner/PlatformMac.cmake:
2034
2035 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
2036
2037         webkitpy: Add target host concept
2038         https://bugs.webkit.org/show_bug.cgi?id=170186
2039         <rdar://problem/31301797>
2040
2041         Reviewed by Alexey Proskuryakov.
2042
2043         Adding the idea of a target host. Target hosts are objects conforming to the
2044         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
2045         Target hosts are the hosts associated with a worker process.
2046
2047         * Scripts/webkitpy/common/system/filesystem.py:
2048         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
2049         host to an absolute path on this host.
2050         (FileSystem.move_to_base_host): Move file from this host to the base host.
2051         (FileSystem.move_from_base_host): Move file from the base host to this host.
2052         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
2053         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
2054         * Scripts/webkitpy/common/system/filesystem_mock.py:
2055         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
2056         host to an absolute path on this host.
2057         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
2058         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
2059         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
2060         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
2061         * Scripts/webkitpy/port/base.py:
2062         (Port.target_host): Return host determined by worker number.
2063         (Port.abspath_for_test): Accept optional target_host argument to return location
2064         of test on a target host.
2065         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
2066         directory on a target host.
2067         (Port.sample_process): Accept optional target_host argument to sample process on
2068         a target host.
2069         * Scripts/webkitpy/port/darwin.py:
2070         (DarwinPort.sample_process): Run sample process on target host.
2071         (DarwinPort.sample_file_path): Accept directory for file.
2072         (DarwinPort.spindump_file_path): Ditto.
2073         * Scripts/webkitpy/port/darwin_testcase.py:
2074         (DarwinTest.test_spindump): Check file movement.
2075         (DarwinTest.test_sample_process): Ditto.
2076         (DarwinTest.test_sample_process_exception):
2077         * Scripts/webkitpy/port/driver.py:
2078         (Driver.__init__): Add and set self._target_host variable.
2079         (Driver._start): Pass target host to _driver_tempdir().
2080         (Driver.stop): Call the target host's rmtree.
2081         (Driver._check_for_driver_timeout): Pass target host to sample_process.
2082         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2083         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
2084         layout test directory to target host.
2085         * Scripts/webkitpy/port/ios.py:
2086         (IOSPort):
2087         (IOSPort.target_host): Replaced device_for_worker_number.
2088         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
2089         (IOSPort.device_for_worker_number): Replaced with target_host.
2090         * Scripts/webkitpy/port/server_process.py:
2091         (ServerProcess.__init__): Accept target_host instead of worker_number.
2092         (ServerProcess._start): Replace _host with _target_host.
2093         (ServerProcess._handle_timeout): Ditto.
2094         (ServerProcess._kill): Ditto.
2095         * Scripts/webkitpy/port/simulator_process.py:
2096         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
2097         (SimulatorProcess._start): Replace _device with _target_host.
2098         (SimulatorProcess.stop): Ditto.
2099         (SimulatorProcess._kill): Deleted.
2100
2101 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
2102
2103         Unreviewed fix after r214569
2104         https://bugs.webkit.org/show_bug.cgi?id=170255
2105
2106         Unreviewed infrastructure fix.
2107
2108         * Scripts/webkitpy/port/ios.py:
2109         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
2110
2111 2017-03-31  Andy Estes  <aestes@apple.com>
2112
2113         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
2114         https://bugs.webkit.org/show_bug.cgi?id=170365
2115         <rdar://problem/29205721>
2116
2117         Reviewed by Tim Horton.
2118
2119         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2120         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
2121         (TEST): Re-enabled the test, which now passes.
2122
2123 2017-03-31  Tim Horton  <timothy_horton@apple.com>
2124
2125         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
2126         https://bugs.webkit.org/show_bug.cgi?id=170326
2127         <rdar://problem/30330395>
2128
2129         Reviewed by Simon Fraser.
2130
2131         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
2132         (TEST):
2133
2134 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2135
2136         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
2137
2138         Fixes: http/tests/ssl/upgrade-origin-usage.html
2139                http/tests/websocket/tests/hybi/network-process-crash-error.html
2140                http/tests/websocket/tests/hybi/simple-wss.html
2141
2142         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2143         (WTR::TestController::platformContext): Return the context.
2144
2145 2017-03-30  Sam Weinig  <sam@webkit.org>
2146
2147         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
2148         https://bugs.webkit.org/show_bug.cgi?id=170315
2149
2150         Reviewed by Simon Fraser.
2151
2152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2153         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
2154         Add test showing the completion handler is called.
2155
2156 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
2157
2158         Air should support linear scan for optLevel<2
2159         https://bugs.webkit.org/show_bug.cgi?id=170161
2160
2161         Reviewed by Saam Barati.
2162         
2163         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
2164         pipeline.
2165
2166         * Scripts/run-jsc-stress-tests:
2167
2168 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
2169
2170         Support tvOS and watchOS in webkitdirs.pm
2171         https://bugs.webkit.org/show_bug.cgi?id=170267
2172
2173         Reviewed by Alexey Proskuryakov.
2174
2175         * Scripts/webkitdirs.pm:
2176         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
2177         (xcodeSDKPlatformName): Added support for tvos and watchos.
2178         (determinePortName): Same.
2179         (isAppleCocoaWebKit): Same.
2180         (willUseAppleTVDeviceSDK): Added.
2181         (willUseAppleTVSimulatorSDK): Added.
2182         (willUseWatchDeviceSDK): Added.
2183         (willUseWatchSimulatorSDK): Added.
2184         (isTVOSWebKit): Added.
2185         (isWATCHOSWebKit): Added.
2186         (isIOSLikeWebKit): Added.
2187
2188 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2189
2190         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
2191         https://bugs.webkit.org/show_bug.cgi?id=170291
2192         <rdar://problem/31301388>
2193
2194         Reviewed by Tim Horton.
2195
2196         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
2197         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
2198         shared UIApplication, and verify that data interaction completes successfully.
2199
2200         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2201         (TestWebKitAPI::TEST):
2202         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2203         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2204         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
2205         (-[DataInteractionSimulator initWithWebView:]):
2206         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
2207         (-[DataInteractionSimulator runFrom:to:]):
2208         (-[DataInteractionSimulator _advanceProgress]):
2209         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
2210
2211 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
2212
2213         [Win] Pass close_fds = True in Python popen call.
2214         https://bugs.webkit.org/show_bug.cgi?id=170172
2215
2216         Reviewed by Brent Fulgham.
2217
2218         This was previously not supported on Windows, but in Python 2.7.10 it is.
2219
2220         * Scripts/webkitpy/common/system/executive.py:
2221         (Executive._should_close_fds):
2222         * Scripts/webkitpy/port/server_process.py:
2223         (ServerProcess._start):
2224
2225 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
2226
2227         Change my status to be a WebKit reviewer.
2228
2229         Unreviewed status update edit.
2230
2231         * Scripts/webkitpy/common/config/contributors.json:
2232
2233 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2234
2235         Change my status to be a WebKit reviewer.
2236
2237         Unreviewed status update edit.
2238
2239         * Scripts/webkitpy/common/config/contributors.json:
2240
2241 2017-03-29  Tim Horton  <timothy_horton@apple.com>
2242
2243         Swipe gesture tests don't work on macOS Sierra
2244         https://bugs.webkit.org/show_bug.cgi?id=161675
2245         <rdar://problem/23379930>
2246
2247         Reviewed by Darin Adler.
2248
2249         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2250         (WTR::UIScriptController::platformPlayBackEventStream):
2251         (WTR::UIScriptController::beginBackSwipe):
2252         (WTR::UIScriptController::completeBackSwipe):
2253         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h: Copied from Tools/DumpRenderTree/mac/UIScriptControllerMac.mm.
2254         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: Added.
2255         (eventIsOfType):
2256         (eventIsOfTypes):
2257         (eventIsOfGestureType):
2258         (eventIsOfGestureTypes):
2259         (+[EventSerializer dictionaryForEvent:relativeToTime:]):
2260         (+[EventSerializer createEventForDictionary:inWindow:relativeToTime:]):
2261         (+[EventSerializer playEventStream:inWindow:completionHandler:]):
2262         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm.
2263         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm: Added.
2264         (beginSwipeBackEventStream):
2265         (completeSwipeBackEventStream):
2266         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2267         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2268         (WTR::UIScriptController::playBackEventStream):
2269         (WTR::UIScriptController::beginBackSwipe):
2270         (WTR::UIScriptController::completeBackSwipe):
2271         (WTR::UIScriptController::platformPlayBackEventStream):
2272         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
2273         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2274         * TestRunnerShared/spi/CoreGraphicsSPI.h: Added.
2275         * TestRunnerShared/spi/IOKitSPI.h: Renamed from Tools/WebKitTestRunner/ios/IOKitSPI.h.
2276         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2277         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2278         (WTR::playBackEvents):
2279         (WTR::UIScriptController::beginBackSwipe):
2280         (WTR::UIScriptController::completeBackSwipe):
2281         (WTR::UIScriptController::platformPlayBackEventStream):
2282
2283 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2284
2285         webkitpy: Robust test clean-up
2286         https://bugs.webkit.org/show_bug.cgi?id=170255
2287
2288         Reviewed by Alexey Proskuryakov.
2289
2290         On-device testing is the motivation for this change.  Failure to run clean-up functions can
2291         result in zombie processes, residual NFS mounts and other undesirable remnants from a failed
2292         test run.  Make an effort to clean-up even if exceptions are thrown during set-up or clean-up.
2293
2294         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2295         (Manager._set_up_run): Clean up test run if set-up fails.
2296         * Scripts/webkitpy/port/ios.py:
2297         (IOSPort.clean_up_test_run): Continue cleaning up devices even after an exception is thrown.
2298
2299 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2300
2301         Simulator testing stops after the first crash
2302         <rdar://problem/31325362>
2303
2304         Unreviewed infrastructure fix.
2305
2306         * Scripts/webkitpy/xcode/simulated_device.py:
2307         (SimulatedDevice):
2308         (SimulatedDevice.launch_app): Increase timeout when attempting to launch app.
2309
2310 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2311
2312         webkitpy: Standardize web-server port definitions
2313         https://bugs.webkit.org/show_bug.cgi?id=170144
2314         <rdar://problem/31284026>
2315
2316         Reviewed by Daniel Bates.
2317
2318         Default web-server ports should be declared in global variables.
2319         Add functions to web-servers which return the ports these servers
2320         are using so that other tools can forward them.
2321
2322         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2323         (LayoutTestApacheHttpd.__init__): Use shared constants in http_server_base.py.
2324         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2325         (TestLayoutTestApacheHttpd.test_start_cmd): Check port_to_forward for expected values.
2326         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2327         (Lighttpd.__init__): Use shared constants in http_server_base.py.
2328         (Lighttpd._prepare_config): Ditto.
2329         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2330         (HttpServerBase): Add default port constants.
2331         (HttpServerBase.ports_to_forward): Add function to return ports used for http server.
2332         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2333         (TestHttpServer.test_start_cmd): Check port_to_forward for expected values.
2334         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2335          (WebPlatformTestServer.ports_to_forward): Add function to return ports used for web-platform tests.
2336         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2337         (PyWebSocket): Make default port values public.
2338         (PyWebSocket.__init__): Use public default port.
2339         (PyWebSocket.ports_to_forward): Return port used in an array.
2340         * Scripts/webkitpy/port/base.py:
2341         (Port.to.ports_to_forward): Return all ports used the various web-servers managed by the port object.
2342         (Port.to.start_websocket_server): Use PyWebSocket port constants.
2343
2344 2017-03-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2345
2346         Links with empty hrefs should not be drag sources
2347         https://bugs.webkit.org/show_bug.cgi?id=170241
2348         <rdar://problem/31305505>
2349
2350         Reviewed by Tim Horton.
2351
2352         Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
2353
2354         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2355         (TestWebKitAPI::TEST):
2356         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2357
2358         Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
2359
2360         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2361         (-[DataInteractionSimulator phase]):
2362
2363 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2364
2365         Use TCP instead of FIFOs for Simulator/Device communication
2366         https://bugs.webkit.org/show_bug.cgi?id=169419
2367         <rdar://problem/30949615>
2368
2369         Reviewed by Alexey Proskuryakov.
2370
2371         Using TCP instead of FIFOs when communicating with devices allows the device being tested
2372         to be on a different machine then the one handling the management of the test run.
2373
2374         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2375         * DumpRenderTree/mac/DumpRenderTree.mm:
2376         (dumpRenderTree): Call setUp/tearDownIOSLayoutTestCommunication() instead of using FIFOs.
2377         * Scripts/webkitpy/port/device.py:
2378         (Device.__init__): Initialize the listening_socket.
2379         (Device.listening_port): Return port of listening socket.
2380         (Device.prepare_for_testing): Open listening socket on an open port, prepare platform device
2381         fro testing.
2382         (Device.finished_testing): Close listening socket associated with this device, call the
2383         platform device's finished_testing function if it exists.
2384         * Scripts/webkitpy/port/ios.py:
2385         (IOSPort.setup_test_run): Prepare each device for testing.
2386         (IOSPort.clean_up_test_run): Notify each device that testing has completed.
2387         * Scripts/webkitpy/port/ios_simulator.py:
2388         (IOSSimulatorPort): Work around device persistence bug.
2389         (IOSSimulatorPort.__init__): Ditto.
2390         * Scripts/webkitpy/port/simulator_process.py:
2391         (SimulatorProcess):
2392         (SimulatorProcess.NonBlockingFileFromSocket): Add to work around shortcomings in
2393         Python 2’s makefile.
2394         (SimulatorProcess.NonBlockingFileFromSocket.__init__): Initialize file with socket.
2395         (SimulatorProcess.ReadFileSocket.close): Close file and then socket;
2396         (SimulatorProcess.__init__): Pass TCP port over environment, remove FIFO names.
2397         (SimulatorProcess.__getattr__): Expose all file attributes.
2398         (SimulatorProcess._accept_connection_create_file): Wait for connection from server and
2399         create and return a file-like object from the incoming connection.
2400         (SimulatorProcess._start): Use TCP connections instead of FIFOs.
2401         (SimulatorProcess._start.handler): Output server port in timeout exception.
2402         (SimulatorProcess._reset): Deleted.
2403         * TestRunnerShared/IOSLayoutTestCommunication.cpp: Added.
2404         (connectToServer): Return socket connected to the provided server address.
2405         (setupiOSLayoutTestCommunication): Connect stdin, stdout and stderr as socket to a
2406         TCP server running on localhost.
2407         (tearDownIOSLayoutTestCommunication): Close stdin, stdout and stderr TCP sockets.
2408         * TestRunnerShared/IOSLayoutTestCommunication.h: Added.
2409         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2410         * WebKitTestRunner/ios/TestControllerIOS.mm:
2411         (WTR::TestController::platformInitialize): Call setUpIOSLayoutTestCommunication()
2412         instead of using FIFOs.
2413         (WTR::TestController::platformDestroy): Call tearDownIOSLayoutTestCommunication().
2414
2415 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
2416
2417         webkitpy: Add IOSDevicePort and IOSPort tests
2418         https://bugs.webkit.org/show_bug.cgi?id=170206
2419         <rdar://problem/31308364>
2420
2421         Reviewed by Alexey Proskuryakov.
2422
2423         * Scripts/webkitpy/port/darwin_testcase.py: Removed unused import.
2424         * Scripts/webkitpy/port/ios_device_unittest.py: Added.
2425         (iosDeviceTest): Contains tests for the IOSDevicePort.
2426         (iosDeviceTest.make_port): Creates an IOSDevicePort with arguments.
2427         (iosDeviceTest.test_operating_system): Check for the correct operating system.
2428         * Scripts/webkitpy/port/ios_simulator_unittest.py: Moved from Tools/Scripts/webkitpy/port/ios_unittest.py.
2429         (iosSimulatorTest): Inherit from ios_testcase.
2430         (iosSimulatorTest.make_port): Ditto.
2431         (iosSimulatorTest.test_get_crash_log): Ditto.
2432         * Scripts/webkitpy/port/ios_testcase.py: Added.
2433         (iOSTest): Contains shared tests for the IOSDevicePort and IOSSimulatorPort.
2434         (iOSTest.test_driver_name): Tests for iOS app driver.
2435         (iOSTest.test_baseline_searchpath): Check that ios and ios-wk1 are in the baseline search path.
2436         * Scripts/webkitpy/port/ios_unittest.py: Moved to ios_simulator_unittest.py.
2437         * Scripts/webkitpy/port/port_testcase.py:
2438         (PortTestCase): Rename is_simulator to disable_setup to more accurately describe it's meaning.
2439         (PortTestCase.test_diff_image): Use disable_setup instead of is_simulator.
2440         (PortTestCase.test_diff_image_crashed): Ditto.
2441
2442 2017-03-28  Jason Marcell  <jmarcell@apple.com>
2443
2444         Fix `index-expected.txt` for dashboard test results.
2445         https://bugs.webkit.org/show_bug.cgi?id=170214
2446
2447         Reviewed by Alexey Proskuryakov.
2448
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:
2450
2451 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
2452
2453         Bot watcher's dashboard has separate settings for "mac" and "macos"
2454         https://bugs.webkit.org/show_bug.cgi?id=170164
2455
2456         Reviewed by Tim Horton.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2459         (Settings.prototype.parsePlatformFamily): Aded a special case for "macos".
2460
2461 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
2462
2463         Fix dashboard test results on the dashboard
2464         https://bugs.webkit.org/show_bug.cgi?id=170158
2465
2466         Reviewed by Tim Horton.
2467
2468         Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
2469         further improved, as it's not super readable, but stdio is entirely useless in this context.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2472         (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
2473
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2475         Fixed a typo in step name, so that it's actually treated as productive.
2476
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2478         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
2479         (BuildbotTesterQueueView.prototype.update):
2480         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2481         Added special handling for dashboard test results.
2482
2483 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
2484
2485         Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
2486         https://bugs.webkit.org/show_bug.cgi?id=170193
2487
2488         Reviewed by Alexey Proskuryakov.
2489
2490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2491         Fixed the order of arguments.
2492
2493 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
2494
2495         Dashboard tests fails to fetch the revision from commits
2496         https://bugs.webkit.org/show_bug.cgi?id=170191
2497
2498         Reviewed by Alexey Proskuryakov.
2499
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2501         Added recordedCommitIndicesByRevisionNumber.
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2503         (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
2504
2505 2017-03-28  Timothy Horton  <timothy_horton@apple.com>
2506
2507         Safari crashes when attempting to close tab that is displaying PDF
2508         https://bugs.webkit.org/show_bug.cgi?id=170201
2509         <rdar://problem/31242019>
2510
2511         Reviewed by Wenson Hsieh.
2512
2513         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2514         (TEST):
2515         Add a test for doAfterNextStablePresentationUpdate just like the existing
2516         non-stable one.
2517
2518 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
2519
2520         webkitpy: Use host pattern for devices
2521         https://bugs.webkit.org/show_bug.cgi?id=170121
2522
2523         Reviewed by Daniel Bates.
2524
2525         Devices should be treated like hosts throughout webkitpy
2526         so that more code can be re-used.  Add the needed properties
2527         and use executive over custom implemented polling/killing
2528         functions.
2529
2530         * Scripts/webkitpy/port/device.py:
2531         (Device):
2532         (Device.executive): Add optional executive property.
2533         (Device.filesystem): Add optional filesystem property.
2534         (Device.user): Add optional user property.
2535         (Device.platform): Add optional platform property.
2536         (Device.workspace): Add optional workspace property.
2537         (Device.poll): Deleted.
2538         * Scripts/webkitpy/port/simulator_process.py:
2539         (SimulatorProcess.Popen.poll): Use the devices executive.
2540         (SimulatorProcess.stop): Ditto.
2541         (SimulatorProcess._kill): Ditto.
2542         * Scripts/webkitpy/xcode/simulated_device.py:
2543         (SimulatedDevice.__init__): Add executive, filesystem, user, platform
2544         and workspace to the platform device.
2545         (SimulatedDevice.poll): Deleted.
2546
2547 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
2548
2549         Dashboard test fails with error: latestIterationGetter is not a function
2550         https://bugs.webkit.org/show_bug.cgi?id=170167
2551
2552         Reviewed by Alexey Proskuryakov.
2553
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2555         (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
2556
2557 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2558
2559         Another test v8.
2560
2561 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2562
2563         Another test v7.
2564
2565 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2566
2567         Another test v6.
2568
2569 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2570
2571         Another test v5.
2572
2573 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2574
2575         Another test v4.
2576
2577 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2578
2579         Another test v3.
2580
2581 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2582
2583         Another test v2.
2584
2585 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2586
2587         Another test.
2588
2589 2017-03-27  Lucas Forschler  <lforschler@apple.com>
2590
2591         <rdar://problem/30949128>
2592         Update build.webkit.org to use port 16000 for PBChangeSource.
2593         
2594         Reviewed by Alexey Proskuryakov.
2595
2596         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2597
2598 2017-03-27  Jason Marcell  <jmarcell@apple.com>
2599
2600         Bots should run the dashboard tests
2601         https://bugs.webkit.org/show_bug.cgi?id=168994
2602
2603         Reviewed by Daniel Bates and David Kilzer.
2604
2605         We pull the `--results-directory` argument value out so that `RunDashboardTests` can override it so that we can separately run the dashboard layout tests.
2606
2607         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2608         (RunWebKitTests): Define a class variable called resultDirectory for the `--results-directory` argument so that subclasses can override this if needed.
2609         (RunWebKitTests.start): Set the `--results-directory` argument value to the value of self.resultDirectory.
2610         (RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
2611         (RunDashboardTests.start): Override the `--layout-tests-directory` to point to the dashboard layout tests.
2612         (ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
2613         (TestFactory.__init__): Update unit tests to account for new RunDashboardTests step.
2614         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2616
2617 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
2618
2619         webkitpy: Look for 'ios' test expectations for IOSPorts
2620         https://bugs.webkit.org/show_bug.cgi?id=169413
2621
2622         Reviewed by Alexey Proskuryakov.
2623
2624         Test expectations for iOS tests should include the 'ios' folder.  Modify
2625         default_baseline_search_path to include 'ios' folder and derivatives for
2626         IOSPort.
2627
2628         * Scripts/webkitpy/port/ios.py:
2629         (IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
2630         (IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
2631         (IOSPort.test_expectations_file_position): Added for testing.
2632         * Scripts/webkitpy/port/ios_simulator.py:
2633         (IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
2634         (IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.
2635
2636 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
2637
2638         REGRESSION: Reseting _device_map on each child process
2639         <rdar://problem/31274476>
2640
2641         Unreviewed infrastructure fix.
2642
2643         * Scripts/webkitpy/port/ios_simulator.py:
2644         (IOSSimulatorPort): Add _DEVICE_MAP class variable.
2645         (IOSSimulatorPort.__init__): Use shared class variable
2646         (IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
2647         (IOSSimulatorPort._create_devices): Ditto.
2648         (IOSSimulatorPort._quit_ios_simulator): Ditto.
2649         (IOSSimulatorPort.clean_up_test_run): Ditto.
2650
2651 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
2652
2653         REGRESSION: Failing to iterate over Simulator.managed_devices map
2654         <rdar://problem/31274476>
2655
2656         Unreviewed infrastructure fix.
2657
2658         * Scripts/webkitpy/port/ios_simulator.py:
2659         (IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.
2660
2661 2017-03-27  Alex Christensen  <achristensen@webkit.org>
2662
2663         Make WebSockets work in network process
2664         https://bugs.webkit.org/show_bug.cgi?id=169930
2665
2666         Reviewed by Youenn Fablet.
2667
2668         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2669         Add terminateNetworkProcess for the new test
2670         http/tests/websocket/tests/hybi/network-process-crash-error.html
2671         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2672         (WTR::TestRunner::setAllowsAnySSLCertificate):
2673         (WTR::TestRunner::terminateNetworkProcess):
2674         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2675         * WebKitTestRunner/TestController.cpp:
2676         (WTR::TestController::setAllowsAnySSLCertificate):
2677         (WTR::TestController::terminateNetworkProcess):
2678         * WebKitTestRunner/TestController.h:
2679         * WebKitTestRunner/TestInvocation.cpp:
2680         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2681         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2682         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2683         (WTR::TestController::platformContext):
2684         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2685         (WTR::TestController::platformContext):
2686         (WTR::TestController::platformLibraryPathForTesting):
2687         Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
2688         which calls testRunner.setAllowsAnySSLCertificate.  It used to only be effective
2689         for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
2690         and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
2691         which tests that wss works, but our test certificate has an invalid certificate chain.
2692         We want production software to not have the ability to have its security weakened, so this
2693         is a test code path that is only implemented in WebKitTestRunner.
2694
2695 2017-03-25  Jonathan Bedard  <jbedard@apple.com>
2696
2697         webkitpy: Use generalized device instead of platform specific one
2698         https://bugs.webkit.org/show_bug.cgi?id=170078
2699
2700         Reviewed by Daniel Bates.
2701
2702         SimulatedDevice is re-created each time 'xcrun simctl list' is called.  Device
2703         should remain persistent.  Changing Device to a more explicit interface.
2704         SimulatedDevice no longer inherits from Device and IOSSimulator returns Devices
2705         wrapping SimulatedDevices.
2706
2707         * Scripts/webkitpy/port/device.py: Added.
2708         (Device):
2709         (Device.__init__): Construct with platform device.
2710         (Device.install_app): Install app at app path on platform device.
2711         (Device.launch_app): Launch app with bundle ID on platform device.
2712         (Device.poll): Poll platform device.
2713         (Device.udid): Access platform device UDID.
2714         (Device.__nonzero__): Check if instantiated with a valid platform device.
2715         (Device.__eq__): Compare by udid.
2716         (Device.__ne__): Ditto.
2717         (Device.__repr__): Print out platform_device representation.
2718         * Scripts/webkitpy/port/ios_simulator.py:
2719         (IOSSimulatorPort.__init__): Initialize the _device_map to an empty dictionary.
2720         (IOSSimulatorPort._device_for_worker_number_map):  Return self._device_map.
2721         (IOSSimulatorPort._create_simulators): Call Simulator.managed_devices directly.
2722         (IOSSimulatorPort._create_devices): Place Simulator.managed_devices into the
2723         device map.
2724         (IOSSimulatorPort._quit_ios_simulator): Reset self._device_map.
2725         * Scripts/webkitpy/xcode/device.py: Removed.
2726         * Scripts/webkitpy/xcode/simulated_device.py:
2727         (SimulatedDevice):
2728         (SimulatedDevice.__init__): Move host, name and did to SimulatedDevice.
2729         (SimulatedDevice.__eq__): Compare two simulated devices.
2730         (SimulatedDevice.__ne__): Ditto.
2731         (SimulatedDevice.__repr__): Print name and udid.
2732
2733 2017-03-25  Adrian Perez de Castro  <aperez@igalia.com>
2734
2735         [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
2736         https://bugs.webkit.org/show_bug.cgi?id=170059
2737
2738         Reviewed by Carlos Garcia Campos.
2739
2740         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration,
2741         the only use of the method in this same file ignores the returned value anyway.
2742
2743 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2744
2745         webkitpy should be able to run API tests
2746         https://bugs.webkit.org/show_bug.cgi?id=170028
2747
2748         Reviewed by Alexey Proskuryakov.
2749
2750         * Scripts/webkitpy/common/config/ports.py:
2751         (DeprecatedPort.run_api_tests_command): Added.
2752         * Scripts/webkitpy/port/base.py:
2753         (Port.api_results_directory): Added.
2754         * Scripts/webkitpy/tool/steps/runtests.py:
2755         (RunTests.run): Check if we should be running API tests.
2756         (RunTests._run_api_tests): Generate script to run API tests with json output.
2757         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
2758
2759 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2760
2761         Add JSON results for API tests
2762         https://bugs.webkit.org/show_bug.cgi?id=170021
2763
2764         Reviewed by Alexey Proskuryakov.
2765
2766         * Scripts/run-api-tests:
2767         (runTestsBySuite): Appends failures and timeouts to JSON data.
2768         (writeJsonDataIfApplicable): Writes JSON data to a file.
2769
2770 2017-03-24  Lucas Forschler  <lforschler@apple.com>
2771
2772         update committer_auth.py to be python 2.7 compliant
2773         https://bugs.webkit.org/show_bug.cgi?id=170063
2774         
2775         Reviewed by Alexey Proskuryakov.
2776
2777         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
2778         (CommitterAuth.authenticate):
2779             convert e.message to e.args[0]
2780
2781 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2782
2783         webkitpy: Parse JSON results from run-api-tests
2784         https://bugs.webkit.org/show_bug.cgi?id=170062
2785
2786         Reviewed by Alexey Proskuryakov.
2787
2788         * Scripts/webkitpy/common/net/apitestresults.py: Added.
2789         (APITestResults): Structure to represent API test results.
2790         (APITestResults.__init__):
2791         (APITestResults.intersection): Return the failures common to both sets of results.
2792         (APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
2793         (APITestResults.equals): Return True if both results were the same.
2794         (APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
2795         (APITestResults.all_passed): Return True if everything passed.
2796         (APITestResults.failing_tests): List of tests that didn't pass.
2797         (APITestResults.did_exceed_test_failure_limit): Always False.
2798         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.
2799         (APITestResultsTest): Unit tests.
2800         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.
2801         (APITestResultsReader): Read contents of JSON results file.
2802
2803 2017-03-24  Alex Christensen  <achristensen@webkit.org>
2804
2805         REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
2806         https://bugs.webkit.org/show_bug.cgi?id=169167
2807
2808         Reviewed by Simon Fraser.
2809
2810         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2811         (TestWebKitAPI::TEST_F):
2812         Test an example of a selector that was incorrectly determined to be invalid.
2813
2814 2017-03-24  Jonathan Bedard  <jbedard@apple.com>
2815
2816         Increase timeout for booting simulators.
2817         <rdar://problem/31080009>
2818
2819         Unreviewed infrastructure fix.
2820
2821         * Scripts/webkitpy/xcode/simulator.py:
2822         (Simulator.wait_until_device_is_booted): Increase timeout.
2823         (Simulator.wait_until_device_is_in_state): Increase timeout.
2824
2825 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2826
2827         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.
2828
2829         Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
2830         in our unit tests to work.
2831
2832         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2833         (testWebViewJavaScriptDialogs):
2834
2835 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2836
2837         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
2838         https://bugs.webkit.org/show_bug.cgi?id=170001
2839
2840         Reviewed by Michael Catanzaro.
2841
2842         Ignore style of xdgmime sources.
2843
2844         * Scripts/webkitpy/tool/steps/checkstyle.py:
2845
2846 2017-03-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2847
2848         Dragging on a large image should not revert to a file icon if data interaction is enabled
2849         https://bugs.webkit.org/show_bug.cgi?id=170018
2850         <rdar://problem/31184508>
2851
2852         Reviewed by Tim Horton.
2853
2854         Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
2855         AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.
2856
2857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2858         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
2859         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2860         (TestWebKitAPI::TEST):
2861
2862 2017-03-23  Fujii Hironori  <Hironori.Fujii@sony.com>
2863
2864         Update WinCairoRequirements.zip
2865         https://bugs.webkit.org/show_bug.cgi?id=169950
2866
2867         Reviewed by Alex Christensen.
2868
2869         * Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
2870
2871 == Rolled over to ChangeLog-2017-03-23 ==