8dafdde02cde4933e59ef846006b0988a95b7d34
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-17  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r245401.
4         https://bugs.webkit.org/show_bug.cgi?id=197990
5
6         Causing internal build failures (Requested by ShawnRoberts on
7         #webkit).
8
9         Reverted changeset:
10
11         "Add SPI to set a list of hosts to which to send custom header
12         fields cross-origin"
13         https://bugs.webkit.org/show_bug.cgi?id=197397
14         https://trac.webkit.org/changeset/245401
15
16 2019-05-17  Commit Queue  <commit-queue@webkit.org>
17
18         Unreviewed, rolling out r245418.
19         https://bugs.webkit.org/show_bug.cgi?id=197989
20
21         New API test causing crashes on Mojave testers (Requested by
22         ShawnRoberts on #webkit).
23
24         Reverted changeset:
25
26         "Add a unit test for client certificate authentication"
27         https://bugs.webkit.org/show_bug.cgi?id=197800
28         https://trac.webkit.org/changeset/245418
29
30 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-build] Add build step to Transfer archive to S3
33         https://bugs.webkit.org/show_bug.cgi?id=197922
34
35         Reviewed by Jonathan Bedard.
36
37         * BuildSlaveSupport/ews-build/steps.py:
38         (TransferToS3):
39         (TransferToS3.finished): Invoke triggers after transfer is successful.
40         (TransferToS3.getResultSummary): Create more readable failure string.
41         (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
42         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
43
44 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
45
46         [GTK] Need WebKitContextMenuItemType to open emoji picker
47         https://bugs.webkit.org/show_bug.cgi?id=176760
48
49         Reviewed by Michael Catanzaro.
50
51         Update context menu test to check insert emoji action is included in default context menu for editable content.
52
53         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
54
55 2019-05-16  Aakash Jain  <aakash_jain@apple.com>
56
57         [ews-build] Download archives from S3
58         https://bugs.webkit.org/show_bug.cgi?id=197949
59
60         Reviewed by Jonathan Bedard.
61
62         * BuildSlaveSupport/ews-build/steps.py:
63         (DownloadBuiltProduct): Updated to use S3 URL.
64         (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
65         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
66
67 2019-05-16  David Kilzer  <ddkilzer@apple.com>
68
69         REGRESSION (r15133): Fix leak of JSStringRef in minidom
70         <https://webkit.org/b/197968>
71         <rdar://problem/50872430>
72
73         Reviewed by Joseph Pecoraro.
74
75         * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
76         (expectScriptValueIsString): Drive-by fix to use adopt() instead
77         of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
78
79 2019-05-16  David Kilzer  <ddkilzer@apple.com>
80
81         REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
82         <https://webkit.org/b/197965>
83
84         Reviewed by Joseph Pecoraro.
85
86         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
87         (WTR::TestRunner::pathToLocalResource): Don't call
88         JSStringRetain() here because the JSRetainPtr<JSStringRef>
89         return type will increment the retain count for us.
90
91 2019-05-16  Alex Christensen  <achristensen@webkit.org>
92
93         Add a unit test for client certificate authentication
94         https://bugs.webkit.org/show_bug.cgi?id=197800
95
96         Reviewed by Youenn Fablet.
97
98         Make better abstractions for reading and writing from/to TCPServer.
99         Add a unit test that causes a client certificate authentication challenge to happen.
100
101         * TestWebKitAPI/TCPServer.cpp:
102         (TestWebKitAPI::TCPServer::TCPServer):
103         (TestWebKitAPI::TCPServer::read):
104         (TestWebKitAPI::TCPServer::write):
105         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
106         (TestWebKitAPI::TCPServer::respondWithOK):
107         * TestWebKitAPI/TCPServer.h:
108         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
109         (credentialWithIdentity):
110         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
111         (TEST):
112         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
113         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
114         (-[ClientCertificateDelegate challengeCount]):
115         (TestWebKitAPI::TEST):
116         (respondWithChallengeThenOK): Deleted.
117         (credentialWithIdentityAndKeychainPath): Deleted.
118         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
119         (TEST):
120         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
123         (TEST):
124         (readRequest): Deleted.
125         (writeResponse): Deleted.
126         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
127         (TestWebKitAPI::TEST):
128         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
129
130 2019-05-16  Alex Christensen  <achristensen@webkit.org>
131
132         Add SPI to set a list of hosts to which to send custom header fields cross-origin
133         https://bugs.webkit.org/show_bug.cgi?id=197397
134
135         Reviewed by Geoff Garen.
136
137         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
138         (TEST):
139         (expectLegacyHeaders):
140         (expectHeaders):
141         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
142         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
143         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
144
145 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
146
147         Replace double-quotes with single quotes in steps.py
148         https://bugs.webkit.org/show_bug.cgi?id=197921
149
150         Reviewed by Jonathan Bedard.
151
152         * BuildSlaveSupport/ews-build/steps.py:
153
154 2019-05-15  Keith Rollin  <krollin@apple.com>
155
156         Rewrite generate-xcfilelists in Python
157         https://bugs.webkit.org/show_bug.cgi?id=197622
158         <rdar://problem/50508222>
159
160         Reviewed by Jonathan Bedard, Alex Christensen.
161
162         For a number of reasons, rewrite generate-xcfilelists in Python:
163
164         - The previous bash script was large and unmaintainable.
165         - We have more internal expertise with Python than with bash.
166         - The bash script used temporary files in /tmp that got stranded and
167           were owned by root, making them awkward to clear out.
168           <rdar://problem/49490262>
169         - We needed to complete support for engineers that built with Xcode
170           rather than the command line.
171         - There are some bugs leading to mildly corrupted .xcfilelist files.
172           It's not apparent the source of the bugs, but one general reason
173           might be due to approaches born of using bash. Rewriting in Python
174           may clear these up.
175
176         * Scripts/generate-xcfilelists:
177         * Scripts/webkitpy/common/attribute_saver.py: Added.
178         (AttributeSaver):
179         (AttributeSaver.__init__):
180         (AttributeSaver.__enter__):
181         (AttributeSaver.__exit__):
182         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
183         (AttributeSaverTest):
184         (AttributeSaverTest.SimpleTestClass):
185         (AttributeSaverTest.SimpleTestClass.__init__):
186         (AttributeSaverTest.test_class):
187         (AttributeSaverTest.test_normal_default):
188         (AttributeSaverTest.test_normal_value):
189         (AttributeSaverTest.test_normal_value_on_exception):
190         (AttributeSaverTest.test_normal_value_on_normal_exit):
191         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
192         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
193         (AttributeSaverTest.test_normal_value_with_else_on_exception):
194         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
195         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
196         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
197         (Application):
198         (Application.__init__):
199         (Application.run):
200         (Application._initialize):
201         (Application._initialize.collect_attributes):
202         (Application._create_parser):
203         (_validate_args):
204         (_cmd_generate):
205         (_cmd_check):
206         (_cmd_subgenerate):
207         (_cmd_help):
208         (_do_generate):
209         (_do_merge):
210         (_report_results):
211         (_report_merge_results):
212         (_report_remediation_steps):
213         (_report_remediation_steps.add_to_message):
214         (_any_have_errors):
215         (_any_have_actions):
216         (_log_progress):
217         (_log_results):
218         (get_generate_xcfilelists_script_path):
219         (_get_root_dir):
220         (get_opensource_dir):
221         (get_build_scripts_dir):
222         (get_extract_dependencies_from_makefile_script):
223         (get_xcode_built_products_dir):
224         (_getenv):
225         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
226         (BaseGenerator):
227         (BaseGenerator.__init__):
228         (BaseGenerator.__str__):
229         (BaseGenerator.generate):
230         (BaseGenerator._sublaunch_under_xcode):
231         (BaseGenerator.subgenerate):
232         (BaseGenerator.merge):
233         (BaseGenerator.pickle_to_file):
234         (BaseGenerator.has_action):
235         (BaseGenerator.has_error):
236         (BaseGenerator.is_valid):
237         (BaseGenerator.report_error):
238         (BaseGenerator._generate_derived):
239         (BaseGenerator._merge_derived):
240         (BaseGenerator._generate_unified):
241         (BaseGenerator._merge_unified):
242         (BaseGenerator._replace):
243         (BaseGenerator._unexpand):
244         (BaseGenerator._find_added_lines):
245         (BaseGenerator._merge_added_lines):
246         (BaseGenerator._get_file_lines):
247         (BaseGenerator._getenv):
248         (BaseGenerator._get_project_file_path):
249         (BaseGenerator._get_project_dir):
250         (BaseGenerator._get_project_file_name):
251         (BaseGenerator._get_project_name):
252         (BaseGenerator._get_sym_root):
253         (BaseGenerator._get_obj_root):
254         (BaseGenerator._get_shared_precomps_dir):
255         (BaseGenerator._get_build_dirs):
256         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
257         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
258         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
259         (BaseGenerator._get_derived_sources_dir):
260         (BaseGenerator._get_xcfilelist_dir):
261         (BaseGenerator._get_input_derived_xcfilelist_project_path):
262         (BaseGenerator._get_output_derived_xcfilelist_project_path):
263         (BaseGenerator._get_input_unified_xcfilelist_project_path):
264         (BaseGenerator._get_output_unified_xcfilelist_project_path):
265         (BaseGenerator._get_generate_derived_sources_script):
266         (BaseGenerator._get_generate_unified_sources_script):
267         (JavaScriptCoreGenerator):
268         (JavaScriptCoreGenerator._get_project_file_path):
269         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
270         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
271         (WebCoreGenerator):
272         (WebCoreGenerator._get_project_file_path):
273         (WebCoreGenerator._get_generate_derived_sources_script):
274         (WebCoreGenerator._get_generate_unified_sources_script):
275         (WebKitGenerator):
276         (WebKitGenerator._get_project_file_path):
277         (WebKitGenerator._get_derived_sources_dir):
278         (WebKitGenerator._get_generate_derived_sources_script):
279         (WebKitGenerator._get_generate_unified_sources_script):
280         (DumpRenderTreeGenerator):
281         (DumpRenderTreeGenerator._get_project_file_path):
282         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
283         (WebKitTestRunnerGenerator):
284         (WebKitTestRunnerGenerator._get_project_file_path):
285         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
286         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
287         (debug_log):
288         (LogEntryHelper):
289         (LogEntryHelper.__init__):
290         (LogEntryHelper.log_entry):
291         (LogEntryHelper.log_result):
292         (LogEntryHelper.log_exception):
293         (LogEntryHelper._print):
294         (LogEntryExit):
295         (LogEntryExit._show_debug_logging):
296         (LogEntryExitClass):
297         (LogEntryExitClass._show_debug_logging):
298         (LogEntryExitGlobal):
299         (LogEntryExitGlobal._show_debug_logging):
300         (subprocess_run):
301         (is_running_under_xcode):
302         (CheckValidItemAction):
303         (CheckValidItemAction.__init__):
304         (CheckValidItemAction.__call__):
305         (CheckValidItemAction.validate_item):
306         (CheckCommandAction):
307         (CheckCommandAction.__call__):
308         (InvalidCommandError):
309         (InvalidArgumentError):
310         (InvalidConfigurationError):
311         (CalledProcessError):
312         (CalledProcessError.__str__):
313         * Scripts/webkitpy/xcode/__init__.py:
314         (xcode_hash_for_path):
315         (xcode_hash_for_path.convert_to_string):
316         * Scripts/webkitpy/xcode/sdk.py: Added.
317         (SDK):
318         (SDK.__init__):
319         (SDK.__repr__):
320         (SDK.as_xcode_specification):
321         (SDK.get_preferred_sdk_for_platform):
322         (SDK._parse_sdk):
323         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
324         (SDKTest):
325
326 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
327
328         [ews-build] Enabling uploading EWS archives to S3
329         https://bugs.webkit.org/show_bug.cgi?id=197914
330
331         Reviewed by Jonathan Bedard.
332
333         * BuildSlaveSupport/Shared: Added.
334         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
335         (archiveExists): Replace tab with space.
336         (main): Added main method.
337         * BuildSlaveSupport/build.webkit.org-config/steps.py:
338         (TransferToS3): Updated path to the script.
339         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
340
341 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
342
343         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
344         https://bugs.webkit.org/show_bug.cgi?id=197916
345         <rdar://problem/50815427>
346
347         Reviewed by Timothy Hatcher.
348
349         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
350         inputmode="numeric".
351
352         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
353         (TestWebKitAPI::TEST):
354
355 2019-05-15  Youenn Fablet  <youenn@apple.com>
356
357         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
358         https://bugs.webkit.org/show_bug.cgi?id=197463
359         <rdar://problem/47403621>
360
361         Reviewed by Alex Christensen.
362
363         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
364         (-[QuotaDelegate init]):
365         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
366         (-[QuotaDelegate quotaDelegateCalled]):
367         (-[QuotaDelegate grantQuota]):
368         (-[StorageSchemes webView:startURLSchemeTask:]):
369         (-[StorageSchemes webView:stopURLSchemeTask:]):
370         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
371         (doTest):
372
373 2019-05-15  Youenn Fablet  <youenn@apple.com>
374
375         Constant crashes under WebPage::isThrottleable() after r245299
376         https://bugs.webkit.org/show_bug.cgi?id=197902
377         <rdar://problem/50793796>
378
379         Reviewed by Alex Christensen.
380
381         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
382
383 2019-05-15  Philippe Normand  <pnormand@igalia.com>
384
385         [GTK][jhbuild] misc cleanups and bumps
386         https://bugs.webkit.org/show_bug.cgi?id=197913
387
388         Reviewed by Xabier Rodriguez-Calvar.
389
390         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
391         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
392
393 2019-05-15  Chris Dumez  <cdumez@apple.com>
394
395         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
396         https://bugs.webkit.org/show_bug.cgi?id=195102
397         <rdar://problem/48456786>
398
399         Reviewed by Alex Christensen.
400
401         Try to wait longer for the number of processes to reach the expected number
402         and before failing.
403
404         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
405
406 2019-05-15  Alex Christensen  <achristensen@webkit.org>
407
408         Allow NSFileCoordinator to be called from WebContent process
409         https://bugs.webkit.org/show_bug.cgi?id=197895
410         <rdar://problem/50107679>
411
412         Reviewed by Brent Fulgham.
413
414         Add a unit test that verifies calling the block succeeds.
415
416         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
417         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
418
419 2019-05-14  Andy Estes  <aestes@apple.com>
420
421         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
422         https://bugs.webkit.org/show_bug.cgi?id=197751
423         <rdar://problem/50631563>
424
425         Reviewed by Alex Christensen.
426
427         Added new API tests.
428
429         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
430         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
431         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
432         (TestWebKitAPI::TEST):
433         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
434         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
435
436 2019-05-14  Youenn Fablet  <youenn@apple.com>
437
438         A service worker process should app nap when all its clients app nap
439         https://bugs.webkit.org/show_bug.cgi?id=185626
440         <rdar://problem/46785908>
441
442         Reviewed by Alex Christensen.
443
444         Allow to enable app nap through test header.
445
446         * WebKitTestRunner/TestController.cpp:
447         (WTR::TestController::resetPreferencesToConsistentValues):
448         (WTR::updateTestOptionsFromTestHeader):
449         * WebKitTestRunner/TestOptions.h:
450         (WTR::TestOptions::hasSameInitializationOptions const):
451
452 2019-05-14  Commit Queue  <commit-queue@webkit.org>
453
454         Unreviewed, rolling out r245281.
455         https://bugs.webkit.org/show_bug.cgi?id=197887
456
457         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
458         (Requested by aakashjain on #webkit).
459
460         Reverted changeset:
461
462         "Add a unit test for client certificate authentication"
463         https://bugs.webkit.org/show_bug.cgi?id=197800
464         https://trac.webkit.org/changeset/245281
465
466 2019-05-14  Youenn Fablet  <youenn@apple.com>
467
468         Add support for webkit-test-runner options to WPT importer
469         https://bugs.webkit.org/show_bug.cgi?id=197826
470
471         Reviewed by Alex Christensen.
472
473         In case of overwriting an existing test, check if the existing test
474         contains a <!-- webkit-test-runner --> comment and insert it back if
475         needed in the new test.
476
477         For exporter, forbid creating a WPT PR if there are changes containing
478         the webkit-test-runner string.
479
480         * Scripts/webkitpy/w3c/test_converter.py:
481         (convert_for_webkit):
482         (_W3CTestConverter.__init__):
483         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
484         (_W3CTestConverter.handle_starttag):
485         (_W3CTestConverter.handle_comment):
486         (_W3CTestConverter.handle_decl):
487         (_W3CTestConverter.handle_pi):
488         * Scripts/webkitpy/w3c/test_exporter.py:
489         (WebPlatformTestExporter.write_git_patch_file):
490         (WebPlatformTestExporter.make_pull_request):
491         * Scripts/webkitpy/w3c/test_importer.py:
492         (TestImporter.webkit_test_runner_options):
493         (TestImporter):
494         (TestImporter.add_webkit_test_runner_options_to_content):
495         (TestImporter.copy_html_file):
496         (TestImporter.write_html_template):
497         (TestImporter.write_html_files_for_templated_js_tests):
498         (TestImporter.import_tests):
499         * Scripts/webkitpy/w3c/test_importer_unittest.py:
500         (test_manual_slow_test):
501         (test_webkit_test_runner_options):
502
503 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
504
505         [ews-app] Status bubble should turn orange when any build step fails
506         https://bugs.webkit.org/show_bug.cgi?id=197812
507
508         Reviewed by Jonathan Bedard.
509
510         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
511         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
512         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
513
514 2019-05-14  Alex Christensen  <achristensen@webkit.org>
515
516         Add a unit test for client certificate authentication
517         https://bugs.webkit.org/show_bug.cgi?id=197800
518
519         Reviewed by Youenn Fablet.
520
521         Make better abstractions for reading and writing from/to TCPServer.
522         Add a unit test that causes a client certificate authentication challenge to happen.
523
524         * TestWebKitAPI/TCPServer.cpp:
525         (TestWebKitAPI::TCPServer::TCPServer):
526         (TestWebKitAPI::TCPServer::read):
527         (TestWebKitAPI::TCPServer::write):
528         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
529         (TestWebKitAPI::TCPServer::respondWithOK):
530         * TestWebKitAPI/TCPServer.h:
531         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
532         (credentialWithIdentity):
533         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
534         (TEST):
535         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
536         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
537         (-[ClientCertificateDelegate challengeCount]):
538         (TestWebKitAPI::TEST):
539         (respondWithChallengeThenOK): Deleted.
540         (credentialWithIdentityAndKeychainPath): Deleted.
541         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
542         (TEST):
543         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
544         (TestWebKitAPI::TEST):
545         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
546         (TEST):
547         (readRequest): Deleted.
548         (writeResponse): Deleted.
549         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
550         (TestWebKitAPI::TEST):
551         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
552
553 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
554
555         [CG] Adding support for HEIF-sequence ('public.heics') images
556         https://bugs.webkit.org/show_bug.cgi?id=197384
557
558         Reviewed by Simon Fraser.
559
560         * DumpRenderTree/TestOptions.cpp:
561         (TestOptions::TestOptions):
562         * DumpRenderTree/TestOptions.h:
563         * DumpRenderTree/mac/DumpRenderTree.mm:
564         (resetWebViewToConsistentStateBeforeTesting):
565         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
566         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
567         the test.
568
569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
570         (WTR::InjectedBundle::stringForKey):
571         (WTR::InjectedBundle::beginTesting):
572         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
573         * WebKitTestRunner/TestController.cpp:
574         (WTR::TestController::resetStateToConsistentValues):
575         (WTR::updateTestOptionsFromTestHeader):
576         * WebKitTestRunner/TestInvocation.cpp:
577         (WTR::TestInvocation::createTestSettingsDictionary):
578         * WebKitTestRunner/TestOptions.h:
579         (WTR::TestOptions::hasSameInitializationOptions const):
580         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
581         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
582         the test.
583
584 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
585
586         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
587         https://bugs.webkit.org/show_bug.cgi?id=197730
588
589         Reviewed by Filip Pizlo.
590
591         * TestWebKitAPI/CMakeLists.txt:
592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
593         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
594         (TestWebKitAPI::TEST):
595         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
596         (TestWebKitAPI::TEST):
597
598 2019-05-10  Chris Dumez  <cdumez@apple.com>
599
600         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
601
602         It became flaky after r245198.
603
604         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
605
606 2019-05-10  Youenn Fablet  <youenn@apple.com>
607
608         A service worker instance should be terminated when its SWServer is destroyed
609         https://bugs.webkit.org/show_bug.cgi?id=197801
610         <rdar://problem/50587270>
611
612         Reviewed by Chris Dumez.
613
614         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
615
616 2019-05-10  Chris Dumez  <cdumez@apple.com>
617
618         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
619         https://bugs.webkit.org/show_bug.cgi?id=197750
620
621         Reviewed by Geoffrey Garen.
622
623         Add API test coverage.
624
625         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
626         (TEST):
627
628 2019-05-10  Keith Miller  <keith_miller@apple.com>
629
630         Remove legacy test262 import script
631         https://bugs.webkit.org/show_bug.cgi?id=197788
632
633         Reviewed by Yusuke Suzuki.
634
635         import-test262-tests doesn't work anymore. We should be using test262-import instead.
636
637         * Scripts/import-test262-tests: Removed.
638
639 2019-05-10  Charlie Turner  <cturner@igalia.com>
640
641         [WPE] Forward libepoxy cflags
642         https://bugs.webkit.org/show_bug.cgi?id=197784
643
644         Reviewed by Žan Doberšek.
645
646         Patch by Zan Dobersek.
647
648         * wpe/backends/CMakeLists.txt: This is required to keep
649         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
650         up trying to include X11 headers even when they're not present in the
651         environment.
652
653 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
654
655         Fix a bunch of compiler warnings
656         https://bugs.webkit.org/show_bug.cgi?id=197785
657
658         Reviewed by Don Olmstead.
659
660         Add preprocessor guards to avoid -Wunused-function warnings.
661
662         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
663         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
664         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
665
666 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
667
668         [WPE][GTK] Add webkit_frame_get_id() API
669         https://bugs.webkit.org/show_bug.cgi?id=197270
670
671         Reviewed by Carlos Garcia Campos.
672
673         This was hard, but I added a test to verify that two different WebKitFrames of the same
674         WebKitWebPage return two different frame IDs.
675
676         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
677         (WebKitFrameTest::willSubmitFormCallback):
678         (WebKitFrameTest::testSubframe):
679         (registerTests):
680         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
681         (testWebKitFrameSubframe):
682         (beforeAll):
683         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
684         (willSubmitFormCallback):
685         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
686         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
687
688 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
689
690         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
691         https://bugs.webkit.org/show_bug.cgi?id=197271
692
693         Reviewed by Youenn Fablet.
694
695         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
696         (formControlsAssociatedForFrameCallback):
697         (pageCreatedCallback):
698         (formControlsAssociatedCallback): Deleted.
699
700 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
701
702         [Flatpak] Use the safe PyYAML loader if available
703         https://bugs.webkit.org/show_bug.cgi?id=197771
704
705         Reviewed by Philippe Normand.
706
707         * flatpak/flatpakutils.py:
708         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
709         still used as fallback when the former is not provided by the module.
710
711 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
712
713         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
714         https://bugs.webkit.org/show_bug.cgi?id=197734
715
716         Reviewed by Don Olmstead.
717
718         * Scripts/webkitpy/port/win.py:
719         (WinCairoPort._search_paths): Add 'wk2' and
720         additional_platform_directory to paths as well as other ports do.
721
722 2019-05-09  Daniel Bates  <dabates@apple.com>
723
724         [iOS] Numpad comma key has incorrect keyIdentifier property
725         https://bugs.webkit.org/show_bug.cgi?id=197753
726         <rdar://problem/50636274>
727
728         Reviewed by Brent Fulgham.
729
730         Recognize "numpadComma" and return the appropriate HID usage code.
731
732         * WebKitTestRunner/ios/HIDEventGenerator.mm:
733         (hidUsageCodeForCharacter):
734
735 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
736
737         Refine AudioSession route sharing policy
738         https://bugs.webkit.org/show_bug.cgi?id=197742
739         <rdar://problem/50590818>
740
741         Reviewed by Darin Adler.
742
743         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
744         (TestWebKitAPI::TEST):
745
746 2019-05-09  Alex Christensen  <achristensen@webkit.org>
747
748         Remove unnecessary test SPI after r244883
749         https://bugs.webkit.org/show_bug.cgi?id=197575
750
751         Reviewed by Tim Horton.
752
753         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
754         (TEST):
755         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
756         (TestWebKitAPI::TEST):
757
758 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
759
760         [ews-app] Add migrations file to repository
761         https://bugs.webkit.org/show_bug.cgi?id=197729
762
763         Reviewed by Jonathan Bedard.
764
765         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
766
767 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
768
769         [ews-build] Fix formatting issues and typos
770         https://bugs.webkit.org/show_bug.cgi?id=197737
771
772         Reviewed by Jonathan Bedard.
773
774         * BuildSlaveSupport/ews-build/steps.py:
775         (CompileWebKit.evaluateCommand): Removed extra empty line.
776         * BuildSlaveSupport/ews-build/steps_unittest.py:
777         (TestRunWebKitPerlTests): Fixed typo.
778         * BuildSlaveSupport/ews-app/ews/models/step.py:
779         (Step.save_step): Changed log level to info so that it is logged in production.
780
781 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
782
783         [ews-app] Production and Development env should configure DEBUG appropriately
784         https://bugs.webkit.org/show_bug.cgi?id=197700
785
786         Reviewed by Jonathan Bedard.
787
788         * BuildSlaveSupport/ews-app/ews-app/settings.py:
789
790 2019-05-09  Xan López  <xan@igalia.com>
791
792         [CMake] Detect SSE2 at compile time
793         https://bugs.webkit.org/show_bug.cgi?id=196488
794
795         Reviewed by Carlos Garcia Campos.
796
797         * Scripts/webkitdirs.pm:
798         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
799         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
800
801 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
802
803         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
804         https://bugs.webkit.org/show_bug.cgi?id=197697
805
806         Reviewed by Žan Doberšek.
807
808         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
809         * wpe/jhbuild.modules: Ditto.
810
811 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
812
813         Update ANGLE
814         https://bugs.webkit.org/show_bug.cgi?id=197676
815
816         Reviewed by Alex Christensen.
817
818         * TestWebKitAPI/PlatformWin.cmake:
819         Remove unnecessary library linkage.
820
821 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
822
823         [Win] build-webkit should be ready for Visual Studio 2019
824         https://bugs.webkit.org/show_bug.cgi?id=196622
825
826         Reviewed by Ross Kirsling.
827
828         1. Accommodated to the new msbuild.exe location of VS 2019.
829         2. Removed the hard coded "Visual Studio 15" generator.
830
831         build-webkit is going to choose a Visual Studio generator version
832         matching with the latest installed VS. If you invoke vcvars.bat
833         before build-webkit, it chooses the corresponding Visual Studio
834         generator version by cheking 'VisualStudioVersion' env var which
835         is set by vcvars.bat.
836
837         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
838         (msBuildPath): When looking for MSBuild, look in
839         "MSBuild\Current\bin" (the new expected location) and fallback
840         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
841         first location.
842         (msBuildInstallDir): Renamed to msBuildPath.
843         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
844         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
845
846 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
847
848         [PlayStation] Update port options
849         https://bugs.webkit.org/show_bug.cgi?id=197723
850
851         Reviewed by Ross Kirsling.
852
853         ICU headers were missing from TestWTF.
854
855         * TestWebKitAPI/PlatformPlayStation.cmake:
856
857 2019-05-08  Alex Christensen  <achristensen@webkit.org>
858
859         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
860         https://bugs.webkit.org/show_bug.cgi?id=197712
861         <rdar://problem/50429770>
862
863         Reviewed by Tim Horton.
864
865         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
866         (TestWebKitAPI::TEST):
867
868 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
869
870         Change my status to be a WebKit reviewer.
871
872         * Scripts/webkitpy/common/config/contributors.json:
873
874 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
875
876         Unreviewed, rolling out r244952.
877
878         Caused inspector to appear blank.
879
880         Reverted changeset:
881
882         "Web Inspector: Provide UIString descriptions to improve
883         localizations"
884         https://bugs.webkit.org/show_bug.cgi?id=195132
885         https://trac.webkit.org/changeset/244952
886
887 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
888
889         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
890         https://bugs.webkit.org/show_bug.cgi?id=197685
891
892         Reviewed by Alex Christensen.
893
894         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
895         completion. See LayoutTests/ChangeLog for more details.
896
897         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
898         (WTR::UIScriptController::platformClearAllCallbacks):
899
900 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
901
902         Unreviewed. Add myself as a committer.
903
904         * Scripts/webkitpy/common/config/contributors.json:
905
906 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
907
908         Unreviewed, rolling out r245038.
909
910         Breaks internal builds.
911
912         Reverted changeset:
913
914         "Add SPI to set a list of hosts to which to send custom header
915         fields cross-origin"
916         https://bugs.webkit.org/show_bug.cgi?id=197397
917         https://trac.webkit.org/changeset/245038
918
919 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
920
921         Unreviewed. Add myself as a committer.
922
923         * Scripts/webkitpy/common/config/contributors.json:
924
925 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
926
927         Define media buffering policy
928         https://bugs.webkit.org/show_bug.cgi?id=196979
929         <rdar://problem/28383861>
930
931         Reviewed by Jer Noble.
932
933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
934         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
935         (waitUntilBufferingPolicyIsEqualTo):
936         (TEST):
937
938 2019-05-07  Alex Christensen  <achristensen@webkit.org>
939
940         Add SPI to set a list of hosts to which to send custom header fields cross-origin
941         https://bugs.webkit.org/show_bug.cgi?id=197397
942
943         Reviewed by Geoff Garen.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
946         (TEST):
947         (expectLegacyHeaders):
948         (expectHeaders):
949         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
950         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
951         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
952
953 2019-05-07  Keith Rollin  <krollin@apple.com>
954
955         Add option to build-webkit to control whether or not XCBuild is used
956         https://bugs.webkit.org/show_bug.cgi?id=197668
957         <rdar://problem/50549728>
958
959         Reviewed by Tim Horton.
960
961         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
962         Also update build-webkit and the makefiles with the foundation for
963         automatically using XCBuild when the conditions allow it. This latter
964         facility is currently turned off until Xcode fully supports building
965         WebKit with XCBuild.
966
967         * Scripts/build-webkit:
968         * Scripts/webkitdirs.pm:
969         (XcodeOptions):
970         (canUseXCBuild):
971
972 2019-05-07  Andy Estes  <aestes@apple.com>
973
974         run-bindings-tests should test global scope constructor generation
975         https://bugs.webkit.org/show_bug.cgi?id=197669
976
977         Reviewed by Alex Christensen.
978
979         * Scripts/webkitpy/bindings/main.py:
980         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
981         invoking preprocess-idls.pl.
982
983 2019-05-07  Youenn Fablet  <youenn@apple.com>
984
985         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
986         https://bugs.webkit.org/show_bug.cgi?id=195997
987         <rdar://problem/50509884>
988
989         Reviewed by Chris Dumez.
990
991         Spin test until successful.
992
993         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
994
995 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
996
997         [Flatpak] webkit-build fails due to missing GTK2 in build environment
998         https://bugs.webkit.org/show_bug.cgi?id=197352
999
1000         Reviewed by Philippe Normand.
1001
1002         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
1003         to build it ourselves on top in order to be able to build the GTK 2.x plugin
1004         process.
1005
1006         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
1007
1008 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1009
1010         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
1011         https://bugs.webkit.org/show_bug.cgi?id=197644
1012         <rdar://problem/50526364>
1013
1014         Reviewed by Tim Horton.
1015
1016         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
1017
1018         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1019         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1020         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1021         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
1022
1023 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1024
1025         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
1026         https://bugs.webkit.org/show_bug.cgi?id=197651
1027
1028         Reviewed by Žan Doberšek.
1029
1030         This is required since the process creation was delayed until something is loaded in the view.
1031
1032         * MiniBrowser/gtk/BrowserWindow.c:
1033         (browser_window_get_or_create_web_view_for_automation):
1034         * MiniBrowser/wpe/main.cpp:
1035         (main):
1036
1037 2019-05-06  Tim Horton  <timothy_horton@apple.com>
1038
1039         _overrideViewportWithArguments does not work when called before loading
1040         https://bugs.webkit.org/show_bug.cgi?id=197638
1041         <rdar://problem/50505111>
1042
1043         Reviewed by Wenson Hsieh.
1044
1045         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1046         (TEST):
1047
1048 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
1049
1050         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1051         https://bugs.webkit.org/show_bug.cgi?id=197510
1052
1053         Reviewed by Alex Christensen.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1056         (TestWebKitAPI::TEST):
1057
1058 2019-05-06  Keith Rollin  <krollin@apple.com>
1059
1060         Temporarily disable generate-xcfilelists
1061         https://bugs.webkit.org/show_bug.cgi?id=197619
1062         <rdar://problem/50507392>
1063
1064         Reviewed by Alex Christensen.
1065
1066         We need to perform a significant update to the generate-xcfilelist
1067         scripts. This work involves coordinated work with another facility. If
1068         the work does not occur in tandem, the build will be broken. To avoid
1069         this, disable the invoking of the scripts during the transition. The
1070         checking will be restored once the new scripts are in place.
1071
1072         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1073         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1074
1075 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1076
1077         Revert r244953 and r244954 because they broke internal builds.
1078         https://bugs.webkit.org/show_bug.cgi?id=197534
1079
1080         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1081         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1082         * DumpRenderTree/mac/DumpRenderTree.mm:
1083         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1084         * DumpRenderTree/mac/TestRunnerMac.mm:
1085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1086         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1087         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1088         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1089         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1090         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1091         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1092         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1093         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1094         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1095         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1096         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1097         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1098         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1099         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1100         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1101         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1102         * TestWebKitAPI/ios/UIKitSPI.h: Added.
1103         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1104         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1105         * WebKitTestRunner/ios/HIDEventGenerator.h:
1106         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1107         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1108         * WebKitTestRunner/ios/TestControllerIOS.mm:
1109         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1110         * WebKitTestRunner/ios/mainIOS.mm:
1111
1112 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1113
1114         Merge the three UIKitSPI.h files into a single one in PAL
1115         https://bugs.webkit.org/show_bug.cgi?id=197534
1116
1117         Reviewed by Darin Adler.
1118
1119         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1120         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1121         * DumpRenderTree/mac/DumpRenderTree.mm:
1122         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1123         * DumpRenderTree/mac/TestRunnerMac.mm:
1124         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1125         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1126         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1127         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1128         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1130         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1131         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1132         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1133         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1134         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1135         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1136         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1137         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1138         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1139         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1140         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1141         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
1142         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1143         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1144         * WebKitTestRunner/ios/HIDEventGenerator.h:
1145         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1146         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1147         * WebKitTestRunner/ios/TestControllerIOS.mm:
1148         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1149         * WebKitTestRunner/ios/mainIOS.mm:
1150
1151 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
1152
1153         Web Inspector: Provide UIString descriptions to improve localizations
1154         https://bugs.webkit.org/show_bug.cgi?id=195132
1155         <rdar://problem/48457817>
1156
1157         Reviewed by Devin Rousso.
1158
1159         Allow WI.UIString to take:
1160         - WI.UIString(string, key, comment)
1161         - WI.UIString(string, comment)
1162         - WI.UIString(string)
1163
1164         * Scripts/extract-localizable-js-strings:
1165
1166 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1167
1168         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
1169         https://bugs.webkit.org/show_bug.cgi?id=197579
1170
1171         Reviewed by Tim Horton.
1172
1173         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
1174         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
1175         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
1176         ensure that the the focused element has been blurred.
1177
1178         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1179
1180 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
1181
1182         Add a tool to block spammer accounts
1183         https://bugs.webkit.org/show_bug.cgi?id=197537
1184
1185         Reviewed by Darin Adler.
1186
1187         Usage: block-spammers email1 email2 ...
1188
1189         The tool finds and hides all bugs and comments from this account. Before any work
1190         is done, these bugs and comments are displayed for confirmation.
1191
1192         * Scripts/block-spammers: Added.
1193         (get_bugzilla_token):
1194         (invalidate_bugzilla_token):
1195         (get_user_info):
1196         (get_user_info_self):
1197         (can_use_this_tool):
1198         (disable_user):
1199         (get_bugs_created_by_user):
1200         (get_bugs_commented_on_by_user):
1201         (get_comments):
1202         (hide_bug):
1203         (hide_comments):
1204         (ask_yes_no):
1205         (sanitized_string):
1206         (main):
1207
1208 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
1209
1210         run-apit-tests: Add --iterations and --repeat-each
1211         https://bugs.webkit.org/show_bug.cgi?id=197563
1212
1213         Reviewed by Aakash Jain.
1214
1215         * Scripts/webkitpy/api_tests/manager.py:
1216         (Manager.run): Add --iterations and --repeat-each/
1217         * Scripts/webkitpy/api_tests/run_api_tests.py:
1218         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
1219
1220 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1221
1222         New EWS: Clicking on white bubble navigates to page with only bubbles
1223         https://bugs.webkit.org/show_bug.cgi?id=197520
1224
1225         Reviewed by Lucas Forschler.
1226
1227         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
1228
1229 2019-05-03  Daniel Bates  <dabates@apple.com>
1230
1231         [lldb-webkit] Support adding pretty-printing for qualified types
1232         https://bugs.webkit.org/show_bug.cgi?id=197518
1233
1234         Reviewed by Darin Adler.
1235
1236         Remove all "::"s from the name of the specified type when computing the name for the Python classes
1237         that will provide summary and synthetic details as LLDB is not happy about registering such classes
1238         when they contain :: in their name.
1239
1240         * lldb/lldb_webkit.py:
1241         (addSummaryAndSyntheticFormattersForRawBitmaskType):
1242
1243 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1244
1245         New EWS: patches on recently added queues listed as #1 for older bugs
1246         https://bugs.webkit.org/show_bug.cgi?id=197496
1247
1248         Reviewed by Lucas Forschler.
1249
1250         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1251         (StatusBubble._build_bubble):
1252         (StatusBubble._queue_position):
1253
1254 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
1255
1256         webkit-patch --no-review upload does not submit patch to New EWS
1257         https://bugs.webkit.org/show_bug.cgi?id=197519
1258         <rdar://problem/50424887>
1259
1260         Reviewed by Lucas Forschler.
1261
1262         * Scripts/webkitpy/tool/steps/submittoews.py:
1263         (SubmitToEWS.run): Submit to both old and new EWS.
1264         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
1265         * Scripts/webkitpy/common/net/ewsserver.py: Added.
1266         (EWSServer._server_url): Method to return server url.
1267         (EWSServer._post_patch_to_ews): Method to post patch to ews.
1268         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
1269         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
1270         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
1271         * Scripts/webkitpy/common/net/statusserver_mock.py:
1272         (MockStatusServer.submit_to_ews): Updated the log text.
1273         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
1274         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
1275         * Scripts/webkitpy/tool/main.py:
1276         (WebKitPatch.__init__): Initialize ews_server. 
1277         * Scripts/webkitpy/tool/mocktool.py:
1278         (MockTool.__init__): Ditto.
1279
1280 2019-05-03  Chris Dumez  <cdumez@apple.com>
1281
1282         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
1283         https://bugs.webkit.org/show_bug.cgi?id=197574
1284         <rdar://problem/50453181>
1285
1286         Reviewed by Tim Horton.
1287
1288         Add API test coverage.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1291         (TEST):
1292
1293 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
1294
1295         [JSC] Generator CodeBlock generation should be idempotent
1296         https://bugs.webkit.org/show_bug.cgi?id=197552
1297
1298         Reviewed by Keith Miller.
1299
1300         * Scripts/run-javascriptcore-tests:
1301         (runJSCStressTests):
1302         * Scripts/run-jsc-stress-tests:
1303
1304 2019-05-03  Commit Queue  <commit-queue@webkit.org>
1305
1306         Unreviewed, rolling out r244881.
1307         https://bugs.webkit.org/show_bug.cgi?id=197559
1308
1309         Breaks compilation of jsconly on linux, breaking compilation
1310         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
1311         guijemont on #webkit).
1312
1313         Reverted changeset:
1314
1315         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
1316         WEBKIT_COPY_FILES"
1317         https://bugs.webkit.org/show_bug.cgi?id=197174
1318         https://trac.webkit.org/changeset/244881
1319
1320 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
1321
1322         Unreviewed WPE build fix after r244898.
1323
1324         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
1325         (WTR::TestController::abortModal): Add the missing (no-op) definition.
1326
1327 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1328
1329         Mark U+01C0 as a homograph of U+006C
1330         https://bugs.webkit.org/show_bug.cgi?id=197526
1331         <rdar://problem/50301904>
1332
1333         Reviewed by Tim Horton.
1334
1335         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1336         (TestWebKitAPI::TEST):
1337
1338 2019-05-02  Chris Dumez  <cdumez@apple.com>
1339
1340         Add test coverage for <rdar://problem/49731231>
1341         https://bugs.webkit.org/show_bug.cgi?id=196730
1342         <rdar://problem/49731231>
1343
1344         Reviewed by Ryosuke Niwa.
1345
1346         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
1347         to match DumpRenderTree.
1348
1349         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1351         (WTR::TestRunner::abortModal):
1352         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1353         * WebKitTestRunner/TestController.cpp:
1354         (WTR::TestController::runModal):
1355         * WebKitTestRunner/TestController.h:
1356         * WebKitTestRunner/TestInvocation.cpp:
1357         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1358         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1359         (WTR::TestController::abortModal):
1360         * WebKitTestRunner/ios/TestControllerIOS.mm:
1361         (WTR::TestController::abortModal):
1362         * WebKitTestRunner/mac/TestControllerMac.mm:
1363         (WTR::TestController::abortModal):
1364         * WebKitTestRunner/win/TestControllerWin.cpp:
1365         (WTR::TestController::abortModal):
1366
1367 2019-05-02  Christopher Reid  <chris.reid@sony.com>
1368
1369         [CMake] Add support for LTO builds
1370         https://bugs.webkit.org/show_bug.cgi?id=188986
1371
1372         Reviewed by Don Olmstead.
1373
1374         Add support to configure --lto-mode with cmake builds.
1375
1376         * Scripts/build-webkit:
1377         * Scripts/webkitdirs.pm:
1378         (generateBuildSystemFromCMakeProject):
1379
1380 2019-05-02  John Wilander  <wilander@apple.com>
1381
1382         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
1383         https://bugs.webkit.org/show_bug.cgi?id=197521
1384         <rdar://problem/49651503>
1385
1386         Reviewed by Brent Fulgham.
1387
1388         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1389         (TestWebKitAPI::TEST):
1390            Added a test for host strings with leading dots since they are
1391            often used for the domain attribute in cookies.
1392
1393 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
1394
1395         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1396         https://bugs.webkit.org/show_bug.cgi?id=197510
1397
1398         Reviewed by Alex Christensen.
1399
1400         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1401         (TestWebKitAPI::TEST):
1402
1403 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
1404
1405         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
1406         https://bugs.webkit.org/show_bug.cgi?id=197174
1407
1408         Reviewed by Alex Christensen.
1409
1410         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
1411
1412         * TestWebKitAPI/PlatformGTK.cmake:
1413         * TestWebKitAPI/PlatformWPE.cmake:
1414
1415 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1416
1417         Build fix for internal branch.
1418
1419         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1420         RetainPtr.h was not explicitly included.
1421
1422 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1423
1424         webkitpy: Ignore errors when shutting down an already shutdown simulator
1425         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1426         <rdar://problem/50390247>
1427
1428         Reviewed by Lucas Forschler.
1429
1430         * Scripts/webkitpy/xcode/simulated_device.py:
1431         (SimulatedDevice._shut_down):
1432
1433 2019-05-02  Frederic Wang  <fwang@igalia.com>
1434
1435         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1436         https://bugs.webkit.org/show_bug.cgi?id=196142
1437
1438         This patch introduces some experimental runtime flag to let users
1439         disable MathML features that are removed from MathML Core [1]. For now,
1440         these features are only disabled on GTK and WPE ports.
1441
1442         [1] https://mathml-refresh.github.io/mathml-core/
1443
1444         Reviewed by Rob Buis.
1445
1446         * DumpRenderTree/TestOptions.cpp:
1447         (TestOptions::TestOptions):
1448         * DumpRenderTree/TestOptions.h:
1449         * DumpRenderTree/mac/DumpRenderTree.mm:
1450         (setWebPreferencesForTestOptions):
1451
1452 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1453
1454         TestWebKitAPI config.h should be aware of what suite is being built
1455         https://bugs.webkit.org/show_bug.cgi?id=196583
1456
1457         Reviewed by Konstantin Tokarev.
1458
1459         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1460         benefit the macro defines BUILDING_* for the executable which allows the includes
1461         of the config.h to be tailored to the test suite being built. Because of that the
1462         dependencies of the Test* executable are specific to the test suite which may
1463         speed up the build.
1464
1465         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1466         when "Utilities.h" is what was needed.
1467
1468         * TestWebKitAPI/CMakeLists.txt:
1469         * TestWebKitAPI/PlatformGTK.cmake:
1470         * TestWebKitAPI/PlatformJSCOnly.cmake:
1471         * TestWebKitAPI/PlatformMac.cmake:
1472         * TestWebKitAPI/PlatformPlayStation.cmake:
1473         * TestWebKitAPI/PlatformUtilities.h:
1474         * TestWebKitAPI/PlatformWPE.cmake:
1475         * TestWebKitAPI/PlatformWin.cmake:
1476         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1477         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1478         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1479         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1480         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1481         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1482         * TestWebKitAPI/config.h:
1483
1484 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1485
1486         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1487         https://bugs.webkit.org/show_bug.cgi?id=181950
1488         <rdar://problem/43357371>
1489
1490         Reviewed by Brent Fulgham.
1491
1492         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1493         (TestWebKitAPI::TEST_F):
1494
1495 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1496
1497         Remove webkitpy and bindings EWS queues from dashboard
1498         https://bugs.webkit.org/show_bug.cgi?id=197475
1499
1500         Reviewed by Alexey Proskuryakov.
1501
1502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1503
1504 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1505
1506         Remove webkitpy and bindings test queues from old EWS
1507         https://bugs.webkit.org/show_bug.cgi?id=197468
1508
1509         Reviewed by Alexey Proskuryakov.
1510
1511         * QueueStatusServer/config/queues.py:
1512
1513 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1514
1515         Fix the WebKitTestRunner build
1516         https://bugs.webkit.org/show_bug.cgi?id=197449
1517         <rdar://problem/50334169>
1518
1519         Reviewed by Alexey Proskuryakov.
1520
1521         * WebKitTestRunner/mac/EventSenderProxy.mm:
1522         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1523         (WTR::EventSenderProxy::mouseForceChanged):
1524         Use some SPI instead of IPI.
1525
1526 2019-04-30  Chris Dumez  <cdumez@apple.com>
1527
1528         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1529         https://bugs.webkit.org/show_bug.cgi?id=197426
1530         <rdar://problem/50256169>
1531
1532         Reviewed by Brady Eidson.
1533
1534         Add API test coverage.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1537         (-[PSONScheme setShouldRespondAsynchronously:]):
1538         (-[PSONScheme webView:startURLSchemeTask:]):
1539         (-[PSONScheme webView:stopURLSchemeTask:]):
1540
1541 2019-04-30  Chris Dumez  <cdumez@apple.com>
1542
1543         Unreviewed, rolling out r244802.
1544
1545         Caused an API test failure
1546
1547         Reverted changeset:
1548
1549         "Regression(PSON) URL scheme handlers can no longer respond
1550         asynchronously"
1551         https://bugs.webkit.org/show_bug.cgi?id=197426
1552         https://trac.webkit.org/changeset/244802
1553
1554 2019-04-30  Chris Dumez  <cdumez@apple.com>
1555
1556         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1557         https://bugs.webkit.org/show_bug.cgi?id=197426
1558         <rdar://problem/50256169>
1559
1560         Reviewed by Brady Eidson.
1561
1562         Add API test coverage.
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1565         (-[PSONScheme setShouldRespondAsynchronously:]):
1566         (-[PSONScheme webView:startURLSchemeTask:]):
1567         (-[PSONScheme webView:stopURLSchemeTask:]):
1568
1569 2019-04-30  Chris Dumez  <cdumez@apple.com>
1570
1571         Only use a related page's process if that page has not been closed yet
1572         https://bugs.webkit.org/show_bug.cgi?id=197393
1573         <rdar://problem/50302423>
1574
1575         Reviewed by Tim Horton.
1576
1577         Add API test coverage.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1580
1581 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1582
1583         [ews-build] Enable Bindings tests queue on new EWS
1584         https://bugs.webkit.org/show_bug.cgi?id=197424
1585
1586         Reviewed by Lucas Forschler.
1587
1588         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1589         (StatusBubble):
1590         * BuildSlaveSupport/ews-build/config.json:
1591
1592 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1593
1594         [ews-build] Configure ews151 for running various tests
1595         https://bugs.webkit.org/show_bug.cgi?id=197419
1596
1597         Reviewed by Lucas Forschler.
1598
1599         * BuildSlaveSupport/ews-build/config.json:
1600
1601 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1602
1603         [ews-build] Parse and display bindings test failures
1604         https://bugs.webkit.org/show_bug.cgi?id=197423
1605
1606         Reviewed by Lucas Forschler.
1607
1608         * BuildSlaveSupport/ews-build/steps.py:
1609         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1610         (RunBindingsTests.start): Initialize log_observer for json output.
1611         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1612         (RunBindingsTests._addToLog): Method to add message to log.
1613         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1614
1615 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1616
1617         Unreviewed. Add myself as a committer.
1618
1619         * Scripts/webkitpy/common/config/contributors.json:
1620
1621 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1622
1623         [ews-build] Enable webkitpy queue on new EWS
1624         https://bugs.webkit.org/show_bug.cgi?id=197396
1625
1626         Reviewed by Lucas Forschler.
1627
1628         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1629         (StatusBubble):
1630         * BuildSlaveSupport/ews-build/config.json:
1631
1632 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-build] Parse and display webkitpy failures
1635         https://bugs.webkit.org/show_bug.cgi?id=197395
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-build/steps.py:
1640         (RunWebKitPyTests.start): Initialize log_observer for json output.
1641         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1642         (RunWebKitPyTests._addToLog): Method to add message to log.
1643         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1644
1645 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1646
1647         <rdar://problem/50299396> Fix internal High Sierra build
1648         https://bugs.webkit.org/show_bug.cgi?id=197388
1649
1650         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1651         * MiniBrowser/Configurations/Base.xcconfig:
1652         * MobileMiniBrowser/Configurations/Base.xcconfig:
1653         * TestWebKitAPI/Configurations/Base.xcconfig:
1654         * WebKitTestRunner/Configurations/Base.xcconfig:
1655
1656 2019-04-29  Youenn Fablet  <youenn@apple.com>
1657
1658         Remove spurious GVA printf logging
1659         https://bugs.webkit.org/show_bug.cgi?id=197368
1660         <rdar://problem/35975256>
1661
1662         Reviewed by Alexey Proskuryakov.
1663
1664         * Scripts/webkitpy/port/mac.py:
1665         (MacPort.logging_patterns_to_strip):
1666
1667 2019-04-29  Youenn Fablet  <youenn@apple.com>
1668
1669         getDisplayMedia should be called on user gesture
1670         https://bugs.webkit.org/show_bug.cgi?id=197356
1671         <rdar://problem/50296074>
1672
1673         Reviewed by Eric Carlson.
1674
1675         Update test configuration to inject internals
1676         so that we can use it to simulate a user click to call getDisplayMedia.
1677
1678         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1679         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1680         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1681
1682 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1683
1684         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1685         https://bugs.webkit.org/show_bug.cgi?id=197339
1686
1687         Reviewed by Dewei Zhu.
1688
1689         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1690         test run for setup steps that are too expensive to do every iteration.
1691
1692         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1693         (BenchmarkRunner._run_benchmark):
1694         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1695         (BrowserDriver):
1696         (BrowserDriver.prepare_initial_env):
1697         (BrowserDriver.restore_env_after_all_testing):
1698         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1699         (LinuxBrowserDriver.prepare_initial_env):
1700         (LinuxBrowserDriver.restore_env_after_all_testing):
1701         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1702         (OSXBrowserDriver.prepare_initial_env):
1703         (OSXBrowserDriver.restore_env_after_all_testing):
1704
1705 2019-04-28  Andy Estes  <aestes@apple.com>
1706
1707         Fix the watchOS engineering build.
1708
1709         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1710         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1711
1712 2019-04-27  Chris Dumez  <cdumez@apple.com>
1713
1714         [WKTR] Move test timeout handling to the UIProcess
1715         https://bugs.webkit.org/show_bug.cgi?id=197333
1716
1717         Reviewed by Darin Adler.
1718
1719         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1720         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1721         every WebContent process in the case of swapping.
1722
1723         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1724         would lead to crashes when firing the timer.
1725
1726         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1727         (WTR::InjectedBundle::didReceiveMessageToPage):
1728         (WTR::InjectedBundle::done):
1729         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1730         (WTR::InjectedBundle::shouldDumpPixels const):
1731         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1732         (WTR::TestRunner::TestRunner):
1733         (WTR::TestRunner::waitUntilDone):
1734         (WTR::TestRunner::setWaitUntilDone):
1735         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1736         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1737         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1738         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1739         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1740         * WebKitTestRunner/TestInvocation.cpp:
1741         (WTR::TestInvocation::TestInvocation):
1742         (WTR::TestInvocation::createTestSettingsDictionary):
1743         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1744         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1745         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1746         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1747         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1748         (WTR::TestInvocation::setWaitUntilDone):
1749         (WTR::TestInvocation::done):
1750         * WebKitTestRunner/TestInvocation.h:
1751
1752 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1753
1754         [JSC] linkPolymorphicCall now does GC
1755         https://bugs.webkit.org/show_bug.cgi?id=197306
1756
1757         Reviewed by Saam Barati.
1758
1759         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1760         To add this test, we add `runWithoutBaseOption`.
1761
1762         * Scripts/run-jsc-stress-tests:
1763
1764 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1765
1766         Update inactive reviewers' status to 'contributor'.
1767
1768         Accidentally skipped one at first.
1769
1770         * Scripts/webkitpy/common/config/contributors.json:
1771
1772 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1773
1774         Update inactive reviewers' status to 'contributor'.
1775
1776         * Scripts/webkitpy/common/config/contributors.json: The change.
1777
1778         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1779         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1780         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1781         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1782         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1783         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1784         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1785         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1786         Sadly, regression tests operate on a crazy mix of mock and live data for
1787         contributors.json. It would be a substantial project to mock all code paths,
1788         so changing the tests instead.
1789
1790 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1791
1792         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1793         https://bugs.webkit.org/show_bug.cgi?id=197171
1794         <rdar://problem/47454979>
1795
1796         Reviewed by Youenn Fablet.
1797
1798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1799         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1800         (TestWebKitAPI::TEST):
1801
1802 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1803
1804         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1805         <https://webkit.org/b/197314>
1806         <rdar://problem/50245252>
1807
1808         Reviewed by Simon Fraser.
1809
1810         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1811         (WTR::UIScriptController::lastUndoLabel const):
1812         (WTR::UIScriptController::firstRedoLabel const):
1813         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1814
1815         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1816         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1817         - Call -autorelease to fix leak of NSDictionary.
1818
1819         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1820         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1821         (WTR::UIScriptController::selectFormPopoverTitle const):
1822         (WTR::UIScriptController::textContentType const):
1823         (WTR::UIScriptController::formInputLabel const):
1824         (WTR::UIScriptController::scrollingTreeAsText const):
1825         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1826
1827 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1828
1829         webkitpy: Running a single test will always use the default device
1830         https://bugs.webkit.org/show_bug.cgi?id=195472
1831         <rdar://problem/48724825>
1832
1833         Reviewed by Lucas Forschler.
1834
1835         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1836         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1837         requested will be run regardless of what shard they are in.
1838
1839         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1840         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1841         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1842         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1843         on the default device type.
1844         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1845         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1846         (RunTest.test_run_part): Ditto.
1847
1848 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1849
1850         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1851         https://bugs.webkit.org/show_bug.cgi?id=197165
1852
1853         Reviewed by Youenn Fablet.
1854
1855         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1856
1857 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1858
1859         Replace iOS build queue hardware
1860         https://bugs.webkit.org/show_bug.cgi?id=197312
1861
1862         Reviewed by Aakash Jain.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/config.json:
1865         Use newer hardware that supports macOS Mojave.
1866
1867 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1868
1869         check-webkit-style complains the first block in while loop.
1870         https://bugs.webkit.org/show_bug.cgi?id=197307
1871
1872         The style checker shouldn't complain about an open brace on
1873         its own line if the last non-whitespace character on the previous
1874         non-blank line is another open brace, because it's likely to
1875         indicate the begining of a nested code block.
1876
1877         Reviewed by Alex Christensen.
1878
1879         * Scripts/webkitpy/style/checkers/cpp.py:
1880         (check_braces):
1881         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1882         (WebKitStyleTest.test_braces):
1883
1884 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1885
1886         Stop IDB transactions to release locked database files when network process is ready to suspend
1887         https://bugs.webkit.org/show_bug.cgi?id=196372
1888         <rdar://problem/48930116>
1889
1890         Reviewed by Brady Eidson.
1891
1892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1893         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1894         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1895         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1896         (runTestAndCheckResult):
1897         (keepNetworkProcessActive):
1898         (TEST):
1899
1900 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1901
1902         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1903         https://bugs.webkit.org/show_bug.cgi?id=188357
1904         <rdar://problem/42986633>
1905
1906         Reviewed by Dean Jackson.
1907
1908         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1909         tests would fall into low memory mode and have different behavior.
1910         
1911         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1912         to Internals, so it's shared by DRT and WTR.
1913         
1914         We no longer need the WK2 C SPI glue.
1915
1916         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1917         (WTR::InjectedBundlePage::prepare):
1918
1919 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1920
1921         webkitpy: Including skipped tests in the final count
1922         https://bugs.webkit.org/show_bug.cgi?id=197298
1923         <rdar://problem/49705424>
1924
1925         Reviewed by Lucas Forschler.
1926
1927         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1928         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1929
1930 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1931
1932         Disable date and time inputs on iOSMac.
1933         https://bugs.webkit.org/show_bug.cgi?id=197287
1934         rdar://problem/46794376
1935
1936         Reviewed by Wenson Hsieh.
1937
1938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1939
1940 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1941
1942         Fix test-webkitpy after r244653
1943         https://bugs.webkit.org/show_bug.cgi?id=197131
1944
1945         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1946         Also use C++17.
1947
1948 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1949
1950         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1951         https://bugs.webkit.org/show_bug.cgi?id=196991
1952         <rdar://problem/45507423>
1953
1954         Reviewed by Alex Christensen.
1955
1956         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1957         (-[NavigationTestDelegate init]):
1958         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1959         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1960         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1961         (TestWebKitAPI::TEST):
1962         (TEST): Deleted.
1963
1964 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1965
1966         Revert some code accidentally committed with r244653
1967         https://bugs.webkit.org/show_bug.cgi?id=197131
1968
1969         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1970         (TestWebKitAPI::TEST):
1971
1972 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1973
1974         Start using C++17
1975         https://bugs.webkit.org/show_bug.cgi?id=197131
1976
1977         Reviewed by Darin Adler.
1978
1979         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1980         * MiniBrowser/Configurations/Base.xcconfig:
1981         * MobileMiniBrowser/Configurations/Base.xcconfig:
1982         * TestWebKitAPI/Configurations/Base.xcconfig:
1983         * WebKitTestRunner/Configurations/Base.xcconfig:
1984
1985 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1986
1987         Unreviewed, rolling out r244627.
1988         https://bugs.webkit.org/show_bug.cgi?id=197282
1989
1990         Causing internal build failures (Requested by ShawnRoberts on
1991         #webkit).
1992
1993         Reverted changeset:
1994
1995         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1996         https://bugs.webkit.org/show_bug.cgi?id=197171
1997         https://trac.webkit.org/changeset/244627
1998
1999 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2000
2001         [GTK] Hardcoded text color in input fields
2002         https://bugs.webkit.org/show_bug.cgi?id=126907
2003
2004         Reviewed by Michael Catanzaro.
2005
2006         Add dark-mode command line option to MiniBrowser.
2007
2008         * MiniBrowser/gtk/main.c:
2009         (main):
2010
2011 2019-04-24  Zalan Bujtas  <zalan@apple.com>
2012
2013         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2014         https://bugs.webkit.org/show_bug.cgi?id=196948
2015         <rdar://problem/49927131>
2016
2017         Reviewed by Tim Horton.
2018
2019         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2020         (TEST):
2021         The expected order of incoming events is
2022         1. didInvalidateIntrinsicContentSize
2023         2. didFirstLayout
2024         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2025         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2026         (and remember, all we care about is ordering).
2027
2028 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
2029
2030         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2031         https://bugs.webkit.org/show_bug.cgi?id=197171
2032         <rdar://problem/47454979>
2033
2034         Reviewed by Youenn Fablet.
2035
2036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2037         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2038         (TestWebKitAPI::TEST):
2039
2040 2019-04-24  Brady Eidson  <beidson@apple.com>
2041
2042         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
2043         https://bugs.webkit.org/show_bug.cgi?id=191362
2044
2045         Reviewed by Alex Christensen.
2046
2047         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
2048           from an XHR to a custom protocol.
2049
2050 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2051
2052         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
2053         https://bugs.webkit.org/show_bug.cgi?id=197273
2054
2055         Reviewed by Dean Jackson.
2056
2057         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
2058         so that WebCoreTestSupport::resetInternalsObject() is always run.
2059
2060         * DumpRenderTree/mac/DumpRenderTree.mm:
2061         (resetWebViewToConsistentStateBeforeTesting):
2062         (runTest):
2063
2064 2019-04-24  John Wilander  <wilander@apple.com>
2065
2066         Age out unconverted Ad Click Attributions after one week.
2067         https://bugs.webkit.org/show_bug.cgi?id=197238
2068         <rdar://problem/50177349>
2069
2070         Reviewed by Chris Dumez.
2071
2072         This patch adds infrastructure to allow tests to expire all unconverted
2073         attributions early.
2074
2075         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2076         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2077         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
2078         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2079         * WebKitTestRunner/TestController.cpp:
2080         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
2081         * WebKitTestRunner/TestController.h:
2082         * WebKitTestRunner/TestInvocation.cpp:
2083         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2084
2085 2019-04-24  Chris Dumez  <cdumez@apple.com>
2086
2087         Fix flaky crashes in a couple of PSON API tests
2088         https://bugs.webkit.org/show_bug.cgi?id=197239
2089
2090         Reviewed by Tim Horton.
2091
2092         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
2093
2094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2095
2096 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
2097
2098         Make it possible to control the renderTreeAsText output by setting options on testRunner
2099         https://bugs.webkit.org/show_bug.cgi?id=197133
2100
2101         Reviewed by Sam Weinig.
2102
2103         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
2104         that make sense in testing (those that don't dump unstable data like addresses), and plumb
2105         these flags through the various framework layers.
2106
2107         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
2108
2109         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
2110         and hand-code DumpRenderTree bindings.
2111
2112         Some cleanup of the TestRunners, using member initializers.
2113
2114         * DumpRenderTree/TestRunner.cpp:
2115         (TestRunner::TestRunner):
2116         (setRenderTreeDumpOptionsCallback):
2117         (TestRunner::staticFunctions):
2118         (TestRunner::setRenderTreeDumpOptions):
2119         * DumpRenderTree/TestRunner.h:
2120         (TestRunner::renderTreeDumpOptions const):
2121         * DumpRenderTree/mac/DumpRenderTree.mm:
2122         (dump):
2123         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2124         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2125         (WTR::InjectedBundlePage::dump):
2126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2127         (WTR::TestRunner::TestRunner):
2128         (WTR::TestRunner::setRenderTreeDumpOptions):
2129         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2130         (WTR::TestRunner::renderTreeDumpOptions const):
2131
2132 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2133
2134         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
2135         https://bugs.webkit.org/show_bug.cgi?id=197078
2136         <rdar://problem/49564348>
2137
2138         Reviewed by Geoff Garen.
2139
2140         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2141         (TEST_F):
2142         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
2143         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
2144         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
2145
2146 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2147
2148         Add unit test for r239322
2149         https://bugs.webkit.org/show_bug.cgi?id=197236
2150
2151         Reviewed by Chris Dumez.
2152
2153         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
2154         May as well add the test infrastructure which was needed before and will be needed in the future.
2155
2156         * TestWebKitAPI/TCPServer.cpp:
2157         (TestWebKitAPI::TCPServer::TCPServer):
2158         * TestWebKitAPI/TCPServer.h:
2159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2160         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2161         (TestWebKitAPI::TEST):
2162         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2163         (TestWebKitAPI::downloadAtRate):
2164         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2165         (TEST):
2166         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
2167         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2168         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2169         (TestWebKitAPI::TEST):
2170         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2171         (TEST):
2172
2173 2019-04-24  Chris Dumez  <cdumez@apple.com>
2174
2175         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
2176         https://bugs.webkit.org/show_bug.cgi?id=197214
2177         <rdar://problem/49237544>
2178
2179         Reviewed by Alex Christensen.
2180
2181         Extend API test coverage.
2182
2183         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2184         (TEST):
2185
2186 2019-04-24  Philippe Normand  <pnormand@igalia.com>
2187
2188         [Build][GStreamer] Update to 1.16.0
2189         https://bugs.webkit.org/show_bug.cgi?id=197157
2190
2191         Reviewed by Xabier Rodriguez-Calvar.
2192
2193         The upstreamed patches were removed and a new one was added for a
2194         regression detected in the scaletempo GStreamer element. The GNOME
2195         Flatpak was migrated to 3.32 and I switched a few modules to Meson
2196         on the way, as it is the preferred build system now in GStreamer
2197         1.16.
2198
2199         * flatpak/files/httpd-autogen.sh:
2200         * flatpak/flatpakutils.py:
2201         (FlatpakPackage.install):
2202         (WebkitFlatpak.run_in_sandbox):
2203         * flatpak/org.webkit.CommonModules.yaml:
2204         * flatpak/org.webkit.WebKit.yaml:
2205         * gstreamer/jhbuild.modules:
2206         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
2207         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
2208         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
2209         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
2210         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
2211         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
2212         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
2213         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
2214         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
2215         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
2216         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
2217         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
2218         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
2219         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
2220         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
2221         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
2222         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
2223         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
2224         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
2225         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
2226         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
2227         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
2228
2229 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2230
2231         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
2232         https://bugs.webkit.org/show_bug.cgi?id=197156
2233
2234         Reviewed by Michael Catanzaro.
2235
2236         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
2237         support was added.
2238
2239         * MiniBrowser/gtk/BrowserTab.c:
2240         (browser_tab_set_background_color): Set the passed in color as web view background color.
2241         * MiniBrowser/gtk/BrowserTab.h:
2242         * MiniBrowser/gtk/BrowserWindow.c:
2243         (browser_window_init): Initialize backgroundColor.
2244         (browser_window_append_view): Call browser_tab_set_background_color().
2245         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
2246         are added.
2247         * MiniBrowser/gtk/main.c:
2248         (main): Call browser_window_set_background_color() before creating the tabs.
2249
2250 2019-04-23  John Wilander  <wilander@apple.com>
2251
2252         Move Ad Click Attribution from internal feature to experimental feature
2253         https://bugs.webkit.org/show_bug.cgi?id=197218
2254         <rdar://problem/47651691>
2255
2256         Reviewed by Brent Fulgham.
2257
2258         * DumpRenderTree/TestOptions.cpp:
2259         (TestOptions::TestOptions):
2260
2261 2019-04-23  Andy Estes  <aestes@apple.com>
2262
2263         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
2264         https://bugs.webkit.org/show_bug.cgi?id=196749
2265         <rdar://problem/35773454>
2266
2267         Reviewed by Daniel Bates.
2268
2269         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
2270
2271         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2272         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
2273         (-[QuickLookDelegate webView:didFinishNavigation:]):
2274         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
2275         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2276         (runTest):
2277         (runTestDecideBeforeLoading):
2278         (runTestDecideAfterLoading):
2279         (TEST):
2280
2281 2019-04-23  John Wilander  <wilander@apple.com>
2282
2283         Remove Ad Click Attribution data when removing website data
2284         https://bugs.webkit.org/show_bug.cgi?id=197215
2285         <rdar://problem/47668988>
2286
2287         Reviewed by Chris Dumez.
2288
2289         This patch adds test infrastructure to delete Ad Click Attribution data
2290         through WebsiteDataStore::removeData().
2291
2292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2294         (WTR::TestRunner::clearAdClickAttribution):
2295         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
2296         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2297         * WebKitTestRunner/TestController.cpp:
2298         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2299         * WebKitTestRunner/TestController.h:
2300         * WebKitTestRunner/TestInvocation.cpp:
2301         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2302
2303 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
2304
2305         webkitpy: Kill unresponsive worker processes
2306         https://bugs.webkit.org/show_bug.cgi?id=197205
2307         <rdar://problem/50104388>
2308
2309         Reviewed by Lucas Forschler.
2310
2311         * Scripts/webkitpy/common/message_pool.py:
2312         (_MessagePool.__init__): Add close timeout.
2313         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
2314
2315 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2316
2317         Add unit tests for WKWebView.serverTrust
2318         https://bugs.webkit.org/show_bug.cgi?id=197202
2319
2320         Reviewed by Youenn Fablet
2321
2322         * TestWebKitAPI/TCPServer.cpp:
2323         (TestWebKitAPI::deleter<BIO>::operator()):
2324         (TestWebKitAPI::deleter<SSL>::operator()):
2325         (TestWebKitAPI::deleter<X509>::operator()):
2326         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
2327         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
2328         (TestWebKitAPI::TCPServer::TCPServer):
2329         (TestWebKitAPI::TCPServer::listenForConnections):
2330         * TestWebKitAPI/TCPServer.h:
2331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2332         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2333         (TestWebKitAPI::TEST):
2334         (verifyCertificateAndPublicKey):
2335         (-[ServerTrustDelegate webView:didFinishNavigation:]):
2336         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2337         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2338         (TestWebKitAPI::downloadAtRate):
2339         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2340         (TEST):
2341         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2342         (TEST):
2343
2344 2019-04-23  Commit Queue  <commit-queue@webkit.org>
2345
2346         Unreviewed, rolling out r244556.
2347         https://bugs.webkit.org/show_bug.cgi?id=197212
2348
2349         Causing build failures on multiple builders (Requested by
2350         ShawnRoberts on #webkit).
2351
2352         Reverted changeset:
2353
2354         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2355         https://bugs.webkit.org/show_bug.cgi?id=197171
2356         https://trac.webkit.org/changeset/244556
2357
2358 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2359
2360         Fix iOS build.
2361         https://bugs.webkit.org/show_bug.cgi?id=195537
2362
2363         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2364         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2365         AdoptWK constructor is private now.  Use adoptWK instead.
2366
2367 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
2368
2369         Accessibility text search and selection API enhancements.
2370         https://bugs.webkit.org/show_bug.cgi?id=197095
2371         <rdar://problem/48181791>
2372
2373         Reviewed by Chris Fleizach.
2374
2375         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
2376
2377         * DumpRenderTree/AccessibilityTextMarker.h:
2378         * DumpRenderTree/AccessibilityUIElement.cpp:
2379         (searchTextWithCriteriaCallback):
2380         (AccessibilityUIElement::getJSClass):
2381         * DumpRenderTree/AccessibilityUIElement.h:
2382         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2383         (convertVectorToObjectArray):
2384         (convertNSArrayToVector):
2385         (searchTextParameterizedAttributeForCriteria):
2386         (AccessibilityUIElement::getLinkedUIElements):
2387         (AccessibilityUIElement::getDocumentLinks):
2388         (AccessibilityUIElement::getChildren):
2389         (AccessibilityUIElement::getChildrenWithRange):
2390         (AccessibilityUIElement::rowHeaders const):
2391         (AccessibilityUIElement::columnHeaders const):
2392         (AccessibilityUIElement::uiElementArrayAttributeValue const):
2393         (AccessibilityUIElement::searchTextWithCriteria):
2394         (AccessibilityUIElement::attributesOfColumnHeaders):
2395         (AccessibilityUIElement::attributesOfRowHeaders):
2396         (AccessibilityUIElement::attributesOfColumns):
2397         (AccessibilityUIElement::attributesOfRows):
2398         (AccessibilityUIElement::attributesOfVisibleCells):
2399         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2400         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2401         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2402         (WTR::convertVectorToObjectArray):
2403         (WTR::convertNSArrayToVector):
2404         (WTR::searchTextParameterizedAttributeForCriteria):
2405         (WTR::AccessibilityUIElement::getLinkedUIElements):
2406         (WTR::AccessibilityUIElement::getDocumentLinks):
2407         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
2408         (WTR::AccessibilityUIElement::getChildren):
2409         (WTR::AccessibilityUIElement::getChildrenWithRange):
2410         (WTR::AccessibilityUIElement::rowHeaders const):
2411         (WTR::AccessibilityUIElement::columnHeaders const):
2412         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2413         (WTR::AccessibilityUIElement::searchTextWithCriteria):
2414         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2415         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2416         (WTR::AccessibilityUIElement::attributesOfColumns):
2417         (WTR::AccessibilityUIElement::attributesOfRows):
2418         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2419         (WTR::convertElementsToObjectArray): Deleted.
2420
2421 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2422
2423         Multiple File Input Icon Set Regardless of File List
2424         https://bugs.webkit.org/show_bug.cgi?id=195537
2425
2426         Reviewed by Alexey Proskuryakov.
2427
2428         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2429         display string in iOS file inputs
2430
2431         * DumpRenderTree/TestRunner.cpp:
2432         (SetOpenPanelFilesMediaIconCallback):
2433         (TestRunner::staticFunctions):
2434         (TestRunner::setOpenPanelFilesMediaIcon):
2435         * DumpRenderTree/TestRunner.h:
2436         (TestRunner::openPanelFilesMediaIcon const):
2437         * DumpRenderTree/mac/UIDelegate.mm:
2438         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2439         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2441         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2442         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2443         * WebKitTestRunner/TestController.cpp:
2444         (WTR::runOpenPanel):
2445         (WTR::TestController::resetStateToConsistentValues):
2446         * WebKitTestRunner/TestController.h:
2447         (WTR::TestController::openPanelFileURLsMediaIcon const):
2448         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2449         * WebKitTestRunner/TestInvocation.cpp:
2450         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2451
2452 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2453
2454         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2455         https://bugs.webkit.org/show_bug.cgi?id=197171
2456         <rdar://problem/47454979>
2457
2458         Reviewed by Youenn Fablet.
2459
2460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2461         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2462         (TestWebKitAPI::TEST):
2463
2464 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2465
2466         [ews-build] Add unit tests for UnApplyPatchIfRequired
2467         https://bugs.webkit.org/show_bug.cgi?id=197197
2468
2469         Reviewed by Lucas Forschler.
2470
2471         * BuildSlaveSupport/ews-build/steps_unittest.py:
2472         (TestUnApplyPatchIfRequired):
2473         (TestUnApplyPatchIfRequired.test_success):
2474         (TestUnApplyPatchIfRequired.test_failure):
2475         (TestUnApplyPatchIfRequired.test_skip):
2476
2477 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2478
2479         [ews-build] Add unit tests for CleanWorkingDirectory
2480         https://bugs.webkit.org/show_bug.cgi?id=197195
2481
2482         Reviewed by Lucas Forschler.
2483
2484         * BuildSlaveSupport/ews-build/steps_unittest.py:
2485         (TestCleanWorkingDirectory):
2486         (TestCleanWorkingDirectory.test_success):
2487         (TestCleanWorkingDirectory.test_failure):
2488
2489 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2490
2491         [ews-build] Use explicit imports instead of wildcard imports
2492         https://bugs.webkit.org/show_bug.cgi?id=197194
2493
2494         Reviewed by Lucas Forschler.
2495
2496         * BuildSlaveSupport/ews-build/factories.py:
2497         * BuildSlaveSupport/ews-build/loadConfig.py:
2498         * BuildSlaveSupport/ews-build/steps_unittest.py:
2499
2500 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2501
2502         [ews-build] Add unit tests for DownloadBuiltProduct
2503         https://bugs.webkit.org/show_bug.cgi?id=197193
2504
2505         Reviewed by Lucas Forschler.
2506
2507         * BuildSlaveSupport/ews-build/steps_unittest.py:
2508         (TestDownloadBuiltProduct):
2509         (TestDownloadBuiltProduct.setUp):
2510         (TestDownloadBuiltProduct.tearDown):
2511         (TestDownloadBuiltProduct.test_success):
2512         (TestDownloadBuiltProduct.test_failure):
2513
2514 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2515
2516         [ews-app] Exception while loading status-bubble when no build step has started
2517         https://bugs.webkit.org/show_bug.cgi?id=196676
2518
2519         Reviewed by Lucas Forschler.
2520
2521         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2522         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2523
2524 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2525
2526         [PlayStation] Support running of JSC tests on remote playstation devices
2527         https://bugs.webkit.org/show_bug.cgi?id=197170
2528
2529         Reviewed by Ross Kirsling.
2530
2531         Script changes
2532
2533         * Scripts/run-javascriptcore-tests:
2534         (runJSCStressTests): Pass arguments for playstation to
2535         run-jsc-stress-tests
2536         * Scripts/run-jsc-stress-tests:
2537         Handle $hostOS=="playstation" for determineArchitecture, turning
2538         off $isFTLPlatform and runProfiler and defaulting test writer.
2539         * Scripts/webkitdirs.pm:
2540         (jscPath): PlayStation WebKit executables have .elf extension
2541         (executableProductDir): PlayStation builds on Windows hosts but
2542         uses bin directory rather than bin64/bin32 for executable output
2543         location.
2544         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2545
2546 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2547
2548         [CMake][Win] Use target oriented design for WebKit
2549         https://bugs.webkit.org/show_bug.cgi?id=197173
2550
2551         Reviewed by Alex Christensen.
2552
2553         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2554         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2555
2556 2019-04-23  Chris Dumez  <cdumez@apple.com>
2557
2558         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2559         https://bugs.webkit.org/show_bug.cgi?id=197097
2560         <rdar://problem/50048318>
2561
2562         Reviewed by Alex Christensen.
2563
2564         Add API test coverage.
2565
2566         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2567         (-[PSONScheme webView:startURLSchemeTask:]):
2568
2569 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2570
2571         [ATK] Implement AtkComponentIface scroll_to methods
2572         https://bugs.webkit.org/show_bug.cgi?id=196856
2573
2574         Reviewed by Michael Catanzaro.
2575
2576         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2577         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2578         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2579         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2580
2581 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2582
2583         [ews-build] Improve summary for UploadBuiltProduct step
2584         https://bugs.webkit.org/show_bug.cgi?id=197182
2585
2586         Reviewed by Lucas Forschler.
2587
2588         * BuildSlaveSupport/ews-build/steps.py:
2589         (UploadBuiltProduct): Added descriptionDone.
2590         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2591         * BuildSlaveSupport/ews-build/steps_unittest.py:
2592         (TestUploadBuiltProduct.test_success): Updated unit-test.
2593         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2594
2595 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2596
2597         [ews-build] Trigger queues only after uploading the archive
2598         https://bugs.webkit.org/show_bug.cgi?id=197180
2599
2600         Reviewed by Lucas Forschler.
2601
2602         * BuildSlaveSupport/ews-build/factories.py:
2603         (Factory.__init__):
2604         (BuildFactory.__init__): Remove trigger step from factories.
2605         (BuildFactory.propertiesToPassToTriggers): Deleted.
2606         * BuildSlaveSupport/ews-build/steps.py:
2607         (ConfigureBuild.__init__): Confiure triggers property.
2608         (Trigger): Step to trigger other queues.
2609         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2610         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2611
2612 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2613
2614         Deprecate WKContextCreateWithInjectedBundlePath
2615         https://bugs.webkit.org/show_bug.cgi?id=197169
2616
2617         Reviewed by Youenn Fablet.
2618
2619         * TestWebKitAPI/PlatformUtilities.cpp:
2620         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2621         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2622
2623 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2624
2625         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2626         https://bugs.webkit.org/show_bug.cgi?id=197093
2627         <rdar://problem/49708268>
2628
2629         Reviewed by Chris Dumez.
2630
2631         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2632         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2633         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2634         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2635         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2636
2637         * TestWebKitAPI/TCPServer.cpp:
2638         (TestWebKitAPI::TCPServer::TCPServer):
2639         (TestWebKitAPI::TCPServer::~TCPServer):
2640         (TestWebKitAPI::TCPServer::socketBindListen):
2641         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2642         * TestWebKitAPI/TCPServer.h:
2643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2644         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2645         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2646         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2647         (respondWithChallengeThenOK):
2648         (TestWebKitAPI::TEST):
2649         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2650         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2651         (TEST):
2652
2653 2019-04-22  Chris Dumez  <cdumez@apple.com>
2654
2655         Delayed WebProcessLaunch may break the _relatedWebView SPI
2656         https://bugs.webkit.org/show_bug.cgi?id=197160
2657
2658         Reviewed by Alex Christensen.
2659
2660         Add API test coverage.
2661
2662         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2663
2664 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2665
2666         Use curl to download packages for webkitpy autoinstaller
2667         https://bugs.webkit.org/show_bug.cgi?id=197164
2668
2669         Reviewed by Darin Adler.
2670
2671         * Scripts/webkitpy/common/system/autoinstall.py:
2672         (AutoInstaller._download): Use curl(1) to download packages necessary for
2673         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2674         errors which are not present when using curl(1).
2675
2676 2019-04-22  Chris Dumez  <cdumez@apple.com>
2677
2678         Unreviewed, rolling out r244502.
2679
2680         Caused crashes on the bots
2681
2682         Reverted changeset:
2683
2684         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2685         https://bugs.webkit.org/show_bug.cgi?id=197160
2686         https://trac.webkit.org/changeset/244502
2687
2688 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2689
2690         Unreviewed, rolling out r244437.
2691
2692         Still breaks internal tests.
2693
2694         Reverted changeset:
2695
2696         "InjectedBundle parameters often need initialization function
2697         called before unarchiving"
2698         https://bugs.webkit.org/show_bug.cgi?id=189709
2699         https://trac.webkit.org/changeset/244437
2700
2701 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2702
2703         [ews-build] Use singular verb in failure description in case of single api test failure
2704         https://bugs.webkit.org/show_bug.cgi?id=197013
2705
2706         Reviewed by Lucas Forschler.
2707
2708         * BuildSlaveSupport/ews-build/steps.py:
2709         (AnalyzeAPITestsResults.analyzeResults):
2710
2711 2019-04-22  Chris Dumez  <cdumez@apple.com>
2712
2713         Delayed WebProcessLaunch may break the _relatedWebView SPI
2714         https://bugs.webkit.org/show_bug.cgi?id=197160
2715
2716         Reviewed by Alex Christensen.
2717
2718         Add API test coverage.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2721
2722 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2723
2724         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2725         https://bugs.webkit.org/show_bug.cgi?id=194630
2726
2727         Reviewed by Michael Catanzaro.
2728
2729         Return early from getAttributeSet() is passed in accessible is nullptr.
2730
2731         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2732
2733 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2734
2735         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2736         https://bugs.webkit.org/show_bug.cgi?id=197145
2737         <rdar://problem/50078170>
2738
2739         Reviewed by Darin Adler.
2740
2741         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2742         focus, or showing the font manager.
2743
2744         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2745         (TestWebKitAPI::TEST):
2746         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2747         (TEST):
2748         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2749         (TestWebKitAPI::TEST):
2750
2751 2019-04-21  Brian Burg  <bburg@apple.com>
2752
2753         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2754         https://bugs.webkit.org/show_bug.cgi?id=197125
2755         <rdar://problem/50061468>
2756
2757         Reviewed by Darin Adler.
2758
2759         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2760         using this class rather than making our own ./wpt serve invocation.
2761
2762         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2763         (WebDriverW3CWebServer):
2764         (WebDriverW3CWebServer.document_root): Expose this to clients.
2765         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2766
2767         (WebDriverW3CWebServer.__enter__):
2768         (WebDriverW3CWebServer.__exit__):
2769         Make it possible to use the web server with a 'with' statement.
2770
2771 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2772
2773         [CMake][Win] Use target oriented design for WebKitLegacy
2774         https://bugs.webkit.org/show_bug.cgi?id=197112
2775
2776         Reviewed by Konstantin Tokarev.
2777
2778         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2779
2780         * DumpRenderTree/CMakeLists.txt:
2781         * DumpRenderTree/PlatformWin.cmake:
2782         * DumpRenderTree/win/EventSender.cpp:
2783
2784 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2785
2786         Update text for old EWS submit button
2787         https://bugs.webkit.org/show_bug.cgi?id=197140
2788
2789         Reviewed by Alexey Proskuryakov.
2790
2791         * QueueStatusServer/templates/statusbubble.html:
2792
2793 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2794
2795         [ews-app] New EWS should poll bugzilla more frequently
2796         https://bugs.webkit.org/show_bug.cgi?id=197138
2797
2798         Reviewed by Alexey Proskuryakov.
2799
2800         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2801         (FetchLoop.__init__):
2802
2803 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2804
2805         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2806         https://bugs.webkit.org/show_bug.cgi?id=197139
2807
2808         Reviewed by Alexey Proskuryakov.
2809
2810         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2811         * QueueStatusServer/templates/statusbubble.html:
2812
2813 2019-04-20  Chris Dumez  <cdumez@apple.com>
2814
2815         Unreviewed, fix iOS build with recent SDKs.
2816
2817         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2818
2819 2019-04-19  Keith Miller  <keith_miller@apple.com>
2820
2821         Add script to merge run_benchmark jsons
2822         https://bugs.webkit.org/show_bug.cgi?id=197107
2823
2824         Reviewed by Michael Saboff.
2825
2826         The script basically recursively decends through all json objects until it gets
2827         to an array or JSON primitive and concats or takes the first value, respectively.
2828
2829         This patch also adds +x bits to the compare-results script so it
2830         can be run directly from the command line. I had to add a new line so that svn
2831         will accept the change... yay svn!
2832
2833         * Scripts/compare-results:
2834         * Scripts/merge-result-jsons: Added.
2835         (readJSONFile):
2836         (deepAppend):
2837         (mergeJSONs):
2838         (main):
2839
2840 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2841
2842         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2843         https://bugs.webkit.org/show_bug.cgi?id=197079
2844
2845         Reviewed by Darin Adler.
2846
2847         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2848
2849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2850         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2851
2852 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2853
2854         Unreviewed, rolling out r244434.
2855         https://bugs.webkit.org/show_bug.cgi?id=197089
2856
2857         caused 1 API test failure (Requested by zalan on #webkit).
2858
2859         Reverted changeset:
2860
2861         "Regression (r244291): Broken API Test
2862         AutoLayoutRenderingProgressRelativeOrdering"
2863         https://bugs.webkit.org/show_bug.cgi?id=196948
2864         https://trac.webkit.org/changeset/244434
2865
2866 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2867
2868         Add new compatibility mode API on WKNavigation
2869         https://bugs.webkit.org/show_bug.cgi?id=197069
2870         <rdar://problem/50025800>
2871
2872         Reviewed by Tim Horton.
2873
2874         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2875
2876         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2877         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2878         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2879
2880 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2881
2882         [CMake] Make WebCore headers copies
2883         https://bugs.webkit.org/show_bug.cgi?id=182512
2884         <rdar://problem/37510435>
2885
2886         Reviewed by Alex Christensen.
2887
2888         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2889         ports.
2890
2891         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2892         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2893
2894         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2895         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2896         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2897         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2898         * TestWebKitAPI/CMakeLists.txt:
2899         * TestWebKitAPI/PlatformWin.cmake:
2900         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2901         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2902         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2903
2904 2019-04-18  Jer Noble  <jer.noble@apple.com>
2905
2906         Add support for parsing FairPlayStreaming PSSH boxes.
2907         https://bugs.webkit.org/show_bug.cgi?id=197064
2908
2909         Reviewed by Eric Carlson.
2910
2911         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2912         (TestWebKitAPI::TEST):
2913
2914 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2915
2916         InjectedBundle parameters often need initialization function called before unarchiving
2917         https://bugs.webkit.org/show_bug.cgi?id=189709
2918         <rdar://problem/44573653>
2919
2920         Reviewed by Ryosuke Niwa.
2921
2922         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2923         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2924
2925 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2926
2927         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2928         https://bugs.webkit.org/show_bug.cgi?id=196948
2929         <rdar://problem/49927131>
2930
2931         Reviewed by Tim Horton.
2932
2933         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2934         (TEST): 
2935         The expected order of incoming events is
2936         1. didInvalidateIntrinsicContentSize
2937         2. didFirstLayout
2938         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2939         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2940         (and remember, all we care about is ordering).
2941
2942 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2943
2944         Unreviewed, rolling out r244299.
2945
2946         Breaks internal tests.
2947
2948         Reverted changeset:
2949
2950         "InjectedBundle parameters often need initialization function
2951         called before unarchiving"
2952         https://bugs.webkit.org/show_bug.cgi?id=189709
2953         https://trac.webkit.org/changeset/244299
2954
2955 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2956
2957         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2958         https://bugs.webkit.org/show_bug.cgi?id=197053
2959
2960         Reviewed by Saam Barati.
2961
2962         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2963         (TestWebKitAPI::TEST):
2964
2965 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2966
2967         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2968         https://bugs.webkit.org/show_bug.cgi?id=197028
2969         <rdar://problem/49985290>
2970
2971         Reviewed by Wenson Hsieh.
2972
2973         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2974         (TEST):
2975         Liberal application of waitForNextPresentationUpdate works around a race
2976         where if the page rapidly changes its viewport arguments (or an API client
2977         rapidly changes its viewport arguments), we'd get stuck thinking that the
2978         user had intentionally zoomed the page, and stop resetting the initial scale.
2979         This deserves a separate bug, but no need to keep the test failing while
2980         we think about it.
2981
2982 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2983
2984         REGRESSION (r241988): Switching tabs is slow
2985         https://bugs.webkit.org/show_bug.cgi?id=197037
2986         <rdar://problem/49951473>
2987
2988         Reviewed by Simon Fraser.
2989
2990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2991         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2992         (TEST):
2993         * TestWebKitAPI/cocoa/TestWKWebView.h:
2994         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2995         (-[TestWKWebView addToTestWindow]):
2996         Add a test that hangs without this fix.
2997
2998 2019-04-17  Truitt Savell  <tsavell@apple.com>
2999
3000         Unreviewed, rolling out r244400.
3001
3002         Caused testing to exit early with assertionon Debug WK2
3003
3004         Reverted changeset:
3005
3006         "UI↔Web deadlock when printing with a JavaScript alert
3007         visible"
3008         https://bugs.webkit.org/show_bug.cgi?id=196839
3009         https://trac.webkit.org/changeset/244400
3010
3011 2019-04-17  Brady Eidson  <beidson@apple.com>
3012
3013         Link clicks in PDFs shouldn't send referrer headers.
3014         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
3015
3016         Reviewed by Tim Horton.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
3020         (putPDFBytesCallback):
3021         (emptyReleaseInfoCallback):
3022         (createPDFWithLinkToURL):
3023         (TEST):
3024
3025 2019-04-17  Tim Horton  <timothy_horton@apple.com>
3026
3027         UI↔Web deadlock when printing with a JavaScript alert visible
3028         https://bugs.webkit.org/show_bug.cgi?id=196839
3029         <rdar://problem/49157642>
3030
3031         Reviewed by Andy Estes.
3032
3033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3034         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
3035         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3036         (TEST):
3037
3038 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3039
3040         WKRetainPtr's adoption constructor should be private
3041         https://bugs.webkit.org/show_bug.cgi?id=197019
3042
3043         Reviewed by Tim Horton.
3044
3045         * DumpRenderTree/mac/DumpRenderTree.mm:
3046         (dumpFramesAsText):
3047         * TestWebKitAPI/InjectedBundleController.cpp:
3048         (TestWebKitAPI::InjectedBundleController::initialize):
3049         * TestWebKitAPI/PlatformUtilities.cpp:
3050         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3051         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
3052         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3053         (TestWebKitAPI::Util::toWK):
3054         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3055         (TestWebKitAPI::TEST):
3056         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3057         (TestWebKitAPI::TEST):
3058         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3059         (TestWebKitAPI::TEST):
3060         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
3061         (TestWebKitAPI::TEST):
3062         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
3063         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
3064         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
3065         (TestWebKitAPI::TEST):
3066         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
3067         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
3068         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
3069         (TestWebKitAPI::TEST):
3070         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
3071         (TestWebKitAPI::TEST):
3072         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3073         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3074         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
3075         (TestWebKitAPI::TEST):
3076         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3077         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3078         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3079         (TestWebKitAPI::TEST):
3080         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3081         (TestWebKitAPI::TEST):
3082         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3083         (TestWebKitAPI::TEST):
3084         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3085         (TestWebKitAPI::TEST):
3086         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3087         (TestWebKitAPI::TEST):
3088         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3089         (TestWebKitAPI::TEST):
3090         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3091         (TestWebKitAPI::TEST):
3092         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
3093         (TestWebKitAPI::TEST):
3094         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3095         (TestWebKitAPI::TEST):
3096         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3097         (TestWebKitAPI::TEST):
3098         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3099         (TestWebKitAPI::TEST):
3100         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3101         (TestWebKitAPI::TEST):
3102         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3103         (TestWebKitAPI::TEST):
3104         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
3105         (TestWebKitAPI::TEST):
3106         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
3107         (TestWebKitAPI::TEST):
3108         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
3109         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3110         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
3111         (TestWebKitAPI::TEST):
3112         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
3113         (TestWebKitAPI::TEST):
3114         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
3115         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
3116         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
3117         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
3118         (TestWebKitAPI::TEST):
3119         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
3120         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
3121         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
3122         (TestWebKitAPI::TEST):
3123         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
3124         (TestWebKitAPI::TEST):
3125         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
3126         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
3127         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3128         (TestWebKitAPI::TEST):
3129         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3130         (TestWebKitAPI::loadAlternateHTMLString):
3131         (TestWebKitAPI::TEST):
3132         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
3133         (TestWebKitAPI::TEST):
3134         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3135         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3136         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3137         (TestWebKitAPI::buildAndPerformTest):
3138         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3139         (TestWebKitAPI::TEST):
3140         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
3141         (TestWebKitAPI::TEST):
3142         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
3143         (TestWebKitAPI::TEST):
3144         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3145         (TestWebKitAPI::TEST):
3146         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3147         (TestWebKitAPI::TEST):
3148         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3149         (TestWebKitAPI::TEST):
3150         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3151         (TestWebKitAPI::TEST):
3152         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3153         (TestWebKitAPI::TEST):
3154         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
3155         (TestWebKitAPI::TEST):
3156         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3157         (TestWebKitAPI::TEST):
3158         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3159         (TestWebKitAPI::TEST):
3160         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3161         (TestWebKitAPI::TEST):
3162         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3163         (TestWebKitAPI::TEST):
3164         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3165         (TestWebKitAPI::TEST):
3166         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3167         (TestWebKitAPI::TEST):
3168         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3169         (TestWebKitAPI::TEST):
3170         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3171         (TestWebKitAPI::TEST):
3172         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3173         (TestWebKitAPI::TEST):
3174         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3175         (TestWebKitAPI::TEST):
3176         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3177         (TestWebKitAPI::TEST):
3178         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
3179         (TestWebKitAPI::TEST):
3180         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
3181         (TestWebKitAPI::TEST):
3182         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3183         (TestWebKitAPI::TEST):
3184         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3185         (TestWebKitAPI::TEST):
3186         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3187         (TestWebKitAPI::TEST):
3188         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3189         (TestWebKitAPI::TEST):
3190         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3191         (TestWebKitAPI::TEST):
3192         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
3193         (TestWebKitAPI::TEST):
3194         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3195         (TestWebKitAPI::TEST):
3196         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
3197         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3198         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
3199         (TestWebKitAPI::TEST):
3200         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
3201         (TestWebKitAPI::TEST):
3202         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
3203         (TestWebKitAPI::TEST):
3204         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
3205         (TestWebKitAPI::TEST):
3206         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3207         (TestWebKitAPI::TEST):
3208         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3209         (TestWebKitAPI::TEST):
3210         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
3211         (TestWebKitAPI::TEST):
3212         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3213         (TestWebKitAPI::TEST):
3214         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3215         (TestWebKitAPI::TEST):
3216         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3217         (TestWebKitAPI::TEST):
3218         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
3219         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
3220         (TEST):
3221         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3222         (TEST):
3223         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3224         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3225         (TEST):
3226         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
3227         (TestWebKitAPI::TEST):
3228         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3229         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3230         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3231         (WTR::getMenuItemTitleCallback):
3232         (WTR::createMouseMessageBody):
3233         (WTR::EventSendingController::mouseDown):
3234         (WTR::EventSendingController::mouseUp):
3235         (WTR::EventSendingController::mouseMoveTo):
3236         (WTR::EventSendingController::mouseForceClick):
3237         (WTR::EventSendingController::startAndCancelMouseForceClick):
3238         (WTR::EventSendingController::mouseForceDown):
3239         (WTR::EventSendingController::mouseForceUp):
3240         (WTR::EventSendingController::mouseForceChanged):
3241         (WTR::EventSendingController::leapForward):
3242         (WTR::EventSendingController::scheduleAsynchronousClick):
3243         (WTR::createKeyDownMessageBody):
3244         (WTR::EventSendingController::keyDown):
3245         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3246         (WTR::EventSendingController::mouseScrollBy):
3247         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3248         (WTR::EventSendingController::continuousMouseScrollBy):
3249         (WTR::EventSendingController::addTouchPoint):
3250         (WTR::EventSendingController::updateTouchPoint):
3251         (WTR::EventSendingController::setTouchModifier):
3252         (WTR::EventSendingController::setTouchPointRadius):
3253         (WTR::EventSendingController::touchStart):
3254         (WTR::EventSendingController::touchMove):
3255         (WTR::EventSendingController::touchEnd):
3256         (WTR::EventSendingController::touchCancel):
3257         (WTR::EventSendingController::clearTouchPoints):
3258         (WTR::EventSendingController::releaseTouchPoint):
3259         (WTR::EventSendingController::cancelTouchPoint):
3260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3261         (WTR::InjectedBundle::didCreatePage):
3262         (WTR::InjectedBundle::didReceiveMessage):
3263         (WTR::InjectedBundle::didReceiveMessageToPage):
3264         (WTR::InjectedBundle::booleanForKey):
3265         (WTR::InjectedBundle::done):
3266         (WTR::InjectedBundle::dumpToStdErr):
3267         (WTR::InjectedBundle::outputText):
3268         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3269         (WTR::InjectedBundle::postAddChromeInputField):
3270         (WTR::InjectedBundle::postRemoveChromeInputField):
3271         (WTR::InjectedBundle::postFocusWebView):
3272         (WTR::InjectedBundle::postSetBackingScaleFactor):
3273         (WTR::InjectedBundle::postSetWindowIsKey):
3274         (WTR::InjectedBundle::postSetViewSize):
3275         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3276         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3277         (WTR::InjectedBundle::setGeolocationPermission):
3278         (WTR::InjectedBundle::setMockGeolocationPosition):
3279         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3280         (WTR::InjectedBundle::isGeolocationProviderActive const):
3281         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
3282         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3283         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
3284         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
3285         (WTR::InjectedBundle::setCustomPolicyDelegate):
3286         (WTR::InjectedBundle::setHidden):
3287         (WTR::InjectedBundle::setCacheModel):
3288         (WTR::InjectedBundle::shouldProcessWorkQueue const):
3289         (WTR::InjectedBundle::processWorkQueue):
3290         (WTR::InjectedBundle::queueBackNavigation):
3291         (WTR::InjectedBundle::queueForwardNavigation):
3292         (WTR::InjectedBundle::queueLoad):
3293         (WTR::InjectedBundle::queueLoadHTMLString):
3294         (WTR::InjectedBundle::queueReload):
3295         (WTR::InjectedBundle::queueLoadingScript):
3296         (WTR::InjectedBundle::queueNonLoadingScript):
3297         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3298         (WTR::frameToStr):
3299         (WTR::InjectedBundlePage::InjectedBundlePage):
3300         (WTR::dumpFrameDescriptionSuitableForTestResult):
3301         (WTR::dumpFrameScrollPosition):
3302         (WTR::dumpDescendantFrameScrollPositions):
3303         (WTR::dumpFrameText):
3304         (WTR::dumpDescendantFramesText):
3305         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3306         (WTR::TestRunner::shouldDumpPixels const):
3307         (WTR::TestRunner::setDumpPixels):
3308         (WTR::TestRunner::whatToDump const):
3309         (WTR::TestRunner::setWhatToDump):
3310         (WTR::TestRunner::setWaitUntilDone):
3311         (WTR::TestRunner::shouldWaitUntilDone const):
3312         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
3313         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3314         (WTR::TestRunner::clearAllDatabases):
3315         (WTR::TestRunner::setIDBPerOriginQuota):
3316         (WTR::TestRunner::originsWithApplicationCache):
3317         (WTR::TestRunner::setCanOpenWindows):
3318         (WTR::TestRunner::setXSSAuditorEnabled):
3319         (WTR::TestRunner::setMediaDevicesEnabled):
3320         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
3321         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
3322         (WTR::TestRunner::setCustomUserAgent):
3323         (WTR::TestRunner::setWebAPIStatisticsEnabled):
3324         (WTR::TestRunner::setModernMediaControlsEnabled):
3325         (WTR::TestRunner::setWebGL2Enabled):
3326         (WTR::TestRunner::setWritableStreamAPIEnabled):
3327         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
3328         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
3329         (WTR::TestRunner::setAllowsAnySSLCertificate):
3330         (WTR::TestRunner::setPluginsEnabled):
3331         (WTR::TestRunner::setValueForUser):
3332         (WTR::TestRunner::setAudioResult):
3333         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3334         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
3335         (WTR::TestRunner::setAlwaysAcceptCookies):
3336         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3337         (WTR::TestRunner::isDoingMediaCapture const):
3338         (WTR::TestRunner::queueLoad):
3339         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3340         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3341         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3342         (WTR::TestRunner::setShouldLogDownloadCallbacks):
3343         (WTR::TestRunner::setAuthenticationUsername):
3344         (WTR::TestRunner::setAuthenticationPassword):
3345         (WTR::TestRunner::secureEventInputIsEnabled const):
3346         (WTR::TestRunner::setBlockAllPlugins):
3347         (WTR::TestRunner::setPluginSupportedMode):
3348         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3349         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
3350         (WTR::TestRunner::setNavigationGesturesEnabled):
3351         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3352         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
3353         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3354         (WTR::TestRunner::terminateNetworkProcess):
3355         (WTR::TestRunner::terminateServiceWorkerProcess):
3356         (WTR::TestRunner::runUIScript):
3357         (WTR::TestRunner::setStatisticsDebugMode):
3358         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
3359         (WTR::TestRunner::setStatisticsLastSeen):
3360         (WTR::TestRunner::setStatisticsPrevalentResource):
3361         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
3362         (WTR::TestRunner::dumpResourceLoadStatistics):
3363         (WTR::TestRunner::isStatisticsPrevalentResource):
3364         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3365         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3366         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3367         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3368         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
3369         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3370         (WTR::TestRunner::setStatisticsGrandfathered):
3371         (WTR::TestRunner::isStatisticsGrandfathered):
3372         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
3373         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
3374         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
3375         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
3376         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
3377         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
3378         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3379         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
3380         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3381         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3382         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3383         (WTR::TestRunner::statisticsSubmitTelemetry):
3384         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3385         (WTR::TestRunner::setStatisticsIsRunningTest):
3386         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3387         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3388         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3389         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3390         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3391         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3392         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3393         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3394         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3395         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3396         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
3397         (WTR::TestRunner::statisticsResetToConsistentState):
3398         (WTR::TestRunner::setStorageAccessAPIEnabled):
3399         (WTR::TestRunner::getAllStorageAccessEntries):
3400         (WTR::TestRunner::addMockMediaDevice):
3401         (WTR::TestRunner::clearMockMediaDevices):
3402         (WTR::TestRunner::removeMockMediaDevice):
3403         (WTR::TestRunner::resetMockMediaDevices):
3404         (WTR::TestRunner::connectMockGamepad):
3405         (WTR::TestRunner::disconnectMockGamepad):
3406         (WTR::TestRunner::setMockGamepadDetails):
3407         (WTR::TestRunner::setMockGamepadAxisValue):
3408         (WTR::TestRunner::setMockGamepadButtonValue):
3409         (WTR::TestRunner::removeAllSessionCredentials):
3410         (WTR::TestRunner::clearDOMCache):
3411         (WTR::TestRunner::clearDOMCaches):
3412         (WTR::TestRunner::hasDOMCache):
3413         (WTR::TestRunner::domCacheSize):
3414         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3415         (WTR::TestRunner::getApplicationManifestThen):
3416         (WTR::TestRunner::injectUserScript):
3417         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3418         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3419         (WTR::TestRunner::addTestKeyToKeychain):
3420         (WTR::TestRunner::cleanUpKeychain):
3421         (WTR::TestRunner::keyExistsInKeychain):
3422         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3423         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3424         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3425         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3426         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3427         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3428         * WebKitTestRunner/TestController.cpp:
3429         (WTR::TestController::initialize):
3430         (WTR::parseStringTestHeaderValueAsRelativePath):
3431         (WTR::updateTestOptionsFromTestHeader):
3432         (WTR::TestController::runTest):
3433         (WTR::TestController::didReceiveLiveDocumentsList):
3434         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3435         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3436         (WTR::TestController::didFinishNavigation):
3437         (WTR::TestController::didReceiveAuthenticationChallenge):
3438         * WebKitTestRunner/TestInvocation.cpp:
3439         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3440         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3441         (WTR::TestInvocation::uiScriptDidComplete):
3442         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3443         * WebKitTestRunner/WebNotificationProvider.cpp:
3444         (WTR::WebNotificationProvider::closeWebNotification):
3445         * WebKitTestRunner/WorkQueueManager.cpp:
3446         (WTR::ScriptItem::ScriptItem):
3447         (WTR::WorkQueueManager::queueLoad):
3448         (WTR::WorkQueueManager::queueLoadHTMLString):
3449
3450 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3451
3452         Add a comment to make my test from r244139 less mysterious.
3453         https://bugs.webkit.org/show_bug.cgi?id=196744
3454
3455         As suggested by Darin Adler.
3456
3457         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3458         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3459
3460 2019-04-17  Chris Dumez  <cdumez@apple.com>
3461
3462         Remember device orientation permission for the duration of the browsing session
3463         https://bugs.webkit.org/show_bug.cgi?id=196992
3464         <rdar://problem/49946067>
3465
3466         Reviewed by Alex Christensen.
3467
3468         Add API test coverage.
3469
3470         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3471         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3472         (TEST):
3473
3474 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3475
3476         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3477         https://bugs.webkit.org/show_bug.cgi?id=196675
3478
3479         Reviewed by Lucas Forschler.
3480
3481         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3482         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3483
3484 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3485
3486         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3487         https://bugs.webkit.org/show_bug.cgi?id=196919
3488         <rdar://problem/41630459>
3489
3490         Reviewed by Tim Horton.
3491
3492         Add iOS support for several new testing hooks. See below for more detail.
3493
3494         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3495         (WTR::UIScriptController::isDismissingMenu const):
3496
3497         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3498         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3499         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3500
3501         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3502         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3503         (WTR::UIScriptController::isDismissingMenu const):
3504         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3505         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3506         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3507         (WTR::InjectedBundle::didReceiveMessageToPage):
3508         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3509         (WTR::TestRunner::setAllowedMenuActions):
3510
3511         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3512         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3513         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3514         against the name of the custom action.
3515
3516         (WTR::TestRunner::installCustomMenuAction):
3517
3518         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3519         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3520         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3521         triggered.
3522
3523         (WTR::TestRunner::performCustomMenuAction):
3524
3525         Invoked when the custom menu action is triggered.
3526
3527         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3528         * WebKitTestRunner/TestController.cpp:
3529         (WTR::TestController::installCustomMenuAction):
3530         (WTR::TestController::setAllowedMenuActions):
3531         * WebKitTestRunner/TestController.h:
3532         * WebKitTestRunner/TestInvocation.cpp:
3533         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3534         (WTR::TestInvocation::performCustomMenuAction):
3535
3536         Add plumbing to call back into the injected bundle when performing the custom action.
3537
3538         * WebKitTestRunner/TestInvocation.h:
3539         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3540         (WTR::TestController::installCustomMenuAction):
3541         (WTR::TestController::setAllowedMenuActions):
3542         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3543         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3544         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3545         (-[TestRunnerWKWebView becomeFirstResponder]):
3546         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3547
3548         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3549         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3550         in the Mail app on iOS.
3551
3552         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3553         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3554         (-[TestRunnerWKWebView resetCustomMenuAction]):
3555         (-[TestRunnerWKWebView performCustomAction:]):
3556         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3557         (-[TestRunnerWKWebView _willHideMenu]):
3558         (-[TestRunnerWKWebView _didHideMenu]):
3559         * WebKitTestRunner/ios/TestControllerIOS.mm:
3560         (WTR::TestController::platformResetStateToConsistentValues):
3561
3562         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3563         if specified.
3564
3565         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3566         (WTR::UIScriptController::isDismissingMenu const):
3567
3568 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3569
3570         Allow sharing from imageSheet on an image document
3571         https://bugs.webkit.org/show_bug.cgi?id=196891
3572         <rdar://problem/25377386>
3573
3574         Reviewed by Tim Horton.
3575
3576         Test to make sure that the correct imageURL is extracted from an image element.
3577
3578         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3579         (TestWebKitAPI::TEST):
3580
3581 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3582
3583         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3584         https://bugs.webkit.org/show_bug.cgi?id=196995
3585
3586         Reviewed by Brady Eidson.
3587
3588         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3589         (TEST):
3590
3591 2019-04-16  Chris Dumez  <cdumez@apple.com>
3592
3593         URL set by document.open() is not communicated to the UIProcess
3594         https://bugs.webkit.org/show_bug.cgi?id=196941
3595         <rdar://problem/49237544>
3596
3597         Reviewed by Geoff Garen.
3598
3599         Add API test coverage.
3600
3601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3602         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3603         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3604         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3605         (TEST):
3606
3607 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3608
3609         Unreviewed, rolling out r244321.
3610         https://bugs.webkit.org/show_bug.cgi?id=196968
3611
3612         Causing all WK2 Debug builds to exit early after Assertion
3613         failures. (Requested by ShawnRoberts on #webkit).
3614
3615         Reverted changeset:
3616
3617         "URL set by document.open() is not communicated to the
3618         UIProcess"
3619         https://bugs.webkit.org/show_bug.cgi?id=196941
3620         https://trac.webkit.org/changeset/244321
3621
3622 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3623
3624         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3625         https://bugs.webkit.org/show_bug.cgi?id=196948
3626
3627         Reviewed by Zalan Bujtas.
3628
3629         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3630         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3631
3632 2019-04-15  Chris Dumez  <cdumez@apple.com>
3633
3634         URL set by document.open() is not communicated to the UIProcess
3635         https://bugs.webkit.org/show_bug.cgi?id=196941
3636         <rdar://problem/49237544>
3637
3638         Reviewed by Geoffrey Garen.
3639
3640         Add API test coverage.
3641
3642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3643         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3644         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3645         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3646         (TEST):
3647
3648 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3649
3650         Using Tools/Scripts/clean-webkit should not install requests
3651         https://bugs.webkit.org/show_bug.cgi?id=196940
3652
3653         Reviewed by Lucas Forschler.
3654
3655         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3656         existing, depending on the path autoinstalled is run through.
3657         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3658         needed.
3659         (Port.configuration_for_upload):
3660         (Port.commits_for_upload):
3661
3662 2019-04-15