testlistjson on the test results server doesn't understand hierarchical results format
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-28  Ojan Vafai  <ojan@chromium.org>
2
3         testlistjson on the test results server doesn't understand hierarchical results format
4         https://bugs.webkit.org/show_bug.cgi?id=73246
5
6         Reviewed by Tony Chang.
7
8         * TestResultServer/model/jsonresults.py:
9         (JsonResults._delete_results_and_times):
10         Instead of just getting the top-level keys, we now walk the tests tree and
11         delete the results and times values.
12
13         * TestResultServer/model/jsonresults_unittest.py:
14         Simplify the test harness to take in the same JSON format for the tests
15         that the actual results.json uses instead of something very similar but
16         needlessly different. This also allows for testing the broken case of
17         results and times values being at non-leaf level.
18
19 2011-11-28  Tony Chang  <tony@chromium.org>
20
21         ews bots should pass --force to update-webkit-chromium
22         https://bugs.webkit.org/show_bug.cgi?id=73230
23
24         Reviewed by Adam Barth.
25
26         This makes it less likely for gclient changes to break the bots (e.g.,
27         if a DEPS repository moves or is switched to a branch).
28
29         Also pass --force when using |build-webkit --update-chromium| since this
30         appears to only be used by the bots.
31
32         * Scripts/update-webkit:
33         * Scripts/webkitdirs.pm:
34         (determineIsChromium): Add --force-update to update-webkit --chromium.
35         (forceChromiumUpdate):
36         (buildChromium): Pass --force to update-webkit-chromium.
37         * Scripts/webkitpy/tool/steps/update.py:
38         (Update.run): Add --force-update if non-interactive (i.e., bots).
39         * Scripts/webkitpy/tool/steps/update_unittest.py:
40
41 2011-11-28  Michael Saboff  <msaboff@apple.com>
42
43         Fixed help message for --exclude-kraken to say that
44         it excludes Kraken and not SunSpider.
45
46         Rubber-stamped by Filip Pizlo.
47
48         * Scripts/bencher:
49
50 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
51
52         Unreviewed, rolling out r101273.
53         http://trac.webkit.org/changeset/101273
54         https://bugs.webkit.org/show_bug.cgi?id=73244
55
56         multiple test failures and timeouts (Requested by tony^work on
57         #webkit).
58
59         * DumpRenderTree/DumpRenderTree.gypi:
60         * DumpRenderTree/chromium/EventSender.cpp:
61         (EventSender::keyDown):
62         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
63         (AlarmHandler):
64         (TestShell::waitTestFinished):
65         (platformInit):
66         (openStartupDialog):
67         (checkLayoutTestSystemDependencies):
68         * DumpRenderTree/chromium/TestShellGtk.cpp:
69         (AlarmHandler):
70         (setupFontconfig):
71         (TestShell::waitTestFinished):
72         (platformInit):
73         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
74         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
75
76 2011-11-28  John Yani  <vanuan@gmail.com>
77
78         new-run-webkit-tests is locale dependent
79         https://bugs.webkit.org/show_bug.cgi?id=68691
80
81         Reviewed and modified by Eric Seidel.
82
83         This is a simpler version of John's patch which I'm landing.
84         This just engages the hacks from the Host constructor on a global
85         basis.
86
87         * Scripts/webkitpy/common/host.py:
88         (Host.__init__):
89         (Host._engage_awesome_locale_hacks):
90
91 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
92
93         [Chromium] Fix broken DRT build for Aura Linux
94         https://bugs.webkit.org/show_bug.cgi?id=72667
95
96         Reviewed by Tony Chang.
97
98         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
99
100         The following changes have been made:
101
102           1. Renamed TestShellAndroid to TestShellLinux.
103           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
104           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
105
106         * DumpRenderTree/DumpRenderTree.gypi:
107         * DumpRenderTree/chromium/EventSender.cpp:
108         (EventSender::keyDown):
109         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
110         * DumpRenderTree/chromium/TestShellGtk.cpp:
111         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
112         (AlarmHandler):
113         (TestShell::waitTestFinished):
114         (setupFontconfig):
115         (platformInit):
116         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
117         (checkLayoutTestSystemDependencies):
118         (openStartupDialog):
119
120 2011-11-28  Eric Seidel  <eric@webkit.org>
121
122         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
123         https://bugs.webkit.org/show_bug.cgi?id=71983
124
125         Reviewed by Adam Barth.
126
127         We'll add more code to Environment overtime,
128         allowing us to mock out more of our direct interactions with os.environ.
129
130         This patch also makes run_command print the passed in environment.
131
132         * Scripts/webkitpy/common/host_mock.py:
133         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
134         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
135         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
136         * Scripts/webkitpy/common/system/executive.py:
137         * Scripts/webkitpy/common/system/executive_mock.py:
138         * Scripts/webkitpy/layout_tests/port/webkit.py:
139         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
140         * Scripts/webkitpy/tool/commands/download_unittest.py:
141         * Scripts/webkitpy/tool/steps/build.py:
142
143 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
144
145         [Qt] Build system fixes against V8.
146
147         Reviewed by Tor Arne Vestbø.
148
149         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
150         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
151         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
152
153 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
154
155         Make sure the useFixedLayout feature is consistently handled
156         https://bugs.webkit.org/show_bug.cgi?id=73212
157
158         Reviewed by Simon Hausmann.
159
160         The web page parameters are set to our Qt defaults and are now altered
161         in the WebKitTestRunner.
162
163         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
164         (WTR::WrapperWindow::WrapperWindow):
165
166 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
167
168         [Qt] WTF should be built as separate static library
169         https://bugs.webkit.org/show_bug.cgi?id=73201
170
171         Reviewed by Tor Arne Vestbø.
172
173         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
174         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
175         thus wtf dependency.
176         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
177         * WebKitTestRunner/Target.pri: Ditto.
178         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
179         consider wtf, too.
180         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
181         moved into wtf.prf.
182         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
183         link in libwtf.
184         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
185
186 2011-11-28  Kentaro Hara  <haraken@chromium.org>
187
188         run-bindings-tests shows diff error for a newly added binding test
189         https://bugs.webkit.org/show_bug.cgi?id=73179
190
191         Reviewed by Adam Barth.
192
193         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
194         run-bindings-tests just shows diff error because reference files
195         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
196
197             FAIL: (V8) V8TestSupplemental.h
198             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
199
200         Instead, this patch treats a non-existent reference file as an empty file and
201         shows the result of the newly added binding test, like this:
202
203             FAIL: (V8) V8TestSupplemental.h
204             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
205             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
206             @@ -0,0 +1,84 @@
207             +/*
208             +    This file is part of the WebKit open source project.
209             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
210             +
211             (omitted)
212
213         * Scripts/run-bindings-tests:
214         (detect_changes): Just added an -N option to the diff command.
215
216 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
217
218         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
219         https://bugs.webkit.org/show_bug.cgi?id=73165
220
221         Reviewed by Philippe Normand.
222
223         Fix some syntax errors in this script and remove an unused variable.
224
225         * gtk/generate-gtkdoc:
226         (get_webkit2_options.src_path): 
227         (get_webkit2_options):
228         (get_webkit1_options.src_path):
229
230 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
231
232         [wx] Unreviewed build fix. Enable the inspector.
233         
234         * waf/build/settings.py:
235
236 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
237
238         Try to fix the build after r101174.
239
240         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
241
242 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
243
244         [GTK] Integrate build-gtkdoc into build-webkit and make
245         https://bugs.webkit.org/show_bug.cgi?id=72626
246
247         Reviewed by Philippe Normand.
248
249         * GNUmakefile.am: Added support for new scripts and "make docs".
250         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
251         (buildAutotoolsProject):
252         * gtk/generate-gtkdoc: Added.
253         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
254
255 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
256
257         [Qt] Add support for using OWRT with Qt5
258         https://bugs.webkit.org/show_bug.cgi?id=72947
259
260         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
261
262         Reviewed by Csaba Osztrogonác.
263
264         * Scripts/old-run-webkit-tests:
265
266 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
267
268         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
269         https://bugs.webkit.org/show_bug.cgi?id=73126
270
271         No need to have a separate client call for this. The front-end can store messages
272         which arrive before front-end loaded and dispatch them later. This happens in layout
273         tests only by the way as all other messages should be initiated by the front-end code.
274
275         Reviewed by Pavel Feldman.
276
277         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
278         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
279         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
280         * DumpRenderTree/chromium/DRTDevToolsClient.h:
281
282 2011-11-24  Kentaro Hara  <haraken@chromium.org>
283
284         Replace subprocess.call() with subprocess.Popen()
285         https://bugs.webkit.org/show_bug.cgi?id=73105
286
287         Reviewed by Adam Barth.
288
289         Currently, the stdout and stderr of the child processes of run-bindings-tests
290         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
291         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
292         between a parent process and a child process. This patch replaces subprocess.call() with
293         subprocess.Popen() and synchronizes the stdout and stderr between them.
294         This patch also makes output messages of run-bindings-tests more readable.
295
296         With this patch, the output messages of run-bindings-tests look like as follows:
297
298             PASS: (CPP) WebDOMTestObj.h
299             PASS: (CPP) WebDOMTestObj.cpp
300             FAIL: (CPP) WebDOMTestInterface.h
301             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
302             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
303             @@ -23,7 +23,7 @@
304              #ifndef WebDOMTestInterface_h
305              #define WebDOMTestInterface_h
306
307             -#if ENABLE(Condition1) || ENABLE(Condition2)
308             +#if ENABLE(Condition1) || ENABLE(Condition3)
309
310              #include <WebDOMObject.h>
311              #include <WebDOMString.h>
312              @@ -53,5 +53,5 @@
313              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
314
315              #endif
316             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
317             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
318             PASS: (CPP) WebDOMFloat64Array.cpp
319             PASS: (CPP) WebDOMFloat64Array.h
320
321             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
322
323         * Scripts/run-bindings-tests:
324         (generate_from_idl):
325         (detect_changes):
326         (run_tests):
327         (main):
328
329 2011-11-24  Kentaro Hara  <haraken@chromium.org>
330
331         Fix the current working directory of run-bindings-tests
332         https://bugs.webkit.org/show_bug.cgi?id=73106
333
334         Reviewed by Adam Barth.
335
336         Currently, run-bindings-tests outputs the following error
337         (although it outputs "all tests passed!" in the end):
338
339             Testing the ObjC generator on TestObj.idl
340             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
341             gcc: warning: '-x objective-c' after last input file has no effect
342             gcc: no input files
343
344         This is because CodeGeneratorObjC.pm assumes that the current working directory
345         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
346         Thus, this patch changes it to WebKit/Source/.
347
348         * Scripts/run-bindings-tests:
349         (generate_from_idl):
350         (main):
351
352 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
353
354         [Qt] Get rid of the buildDirForSource() function in the build system
355
356         At some point the plan was to allow for running qmake on sub-trees
357         of the sources, into the top level build directory, but this is no
358         longer possible, so no reason to keep the convenience function around.
359
360         Reviewed by Simon Hausmann.
361
362         * WebKitTestRunner/DerivedSources.pri:
363         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
364         * qmake/mkspecs/features/default_post.prf:
365         * qmake/mkspecs/features/default_pre.prf:
366         * qmake/mkspecs/features/functions.prf:
367         * qmake/mkspecs/features/javascriptcore.prf:
368         * qmake/mkspecs/features/webcore.prf:
369         * qmake/mkspecs/features/webkit2.prf:
370
371 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
372
373         Unreviewed, rolling out r101107.
374         http://trac.webkit.org/changeset/101107
375         https://bugs.webkit.org/show_bug.cgi?id=73062
376
377         Breaks the commit-queue (Requested by abarth on #webkit).
378
379         * Scripts/webkitpy/common/host.py:
380         (Host._engage_awesome_windows_hacks):
381         * Scripts/webkitpy/common/host_mock.py:
382         (MockHost.__init__):
383         * Scripts/webkitpy/common/system/environment.py: Removed.
384         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
385         * Scripts/webkitpy/common/system/executive.py:
386         (Executive._run_command_with_teed_output):
387         (Executive.run_and_throw_if_fail):
388         * Scripts/webkitpy/common/system/executive_mock.py:
389         (MockExecutive.run_and_throw_if_fail):
390         (MockExecutive.run_command):
391         * Scripts/webkitpy/layout_tests/port/webkit.py:
392         (WebKitPort._driver_build_script_name):
393         (WebKitPort._run_script):
394         (WebKitPort._build_driver):
395         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
396         (test_build_driver):
397         * Scripts/webkitpy/tool/commands/download_unittest.py:
398         * Scripts/webkitpy/tool/steps/build.py:
399         (Build.build):
400
401 2011-11-23  Ojan Vafai  <ojan@chromium.org>
402
403         Unreviewed, rolling out r101110.
404         http://trac.webkit.org/changeset/101110
405         https://bugs.webkit.org/show_bug.cgi?id=73057
406
407         The bots have now cycled and this patch is no longer needed.
408
409         * Scripts/webkitpy/layout_tests/controllers/manager.py:
410         (Manager._upload_json_files):
411
412 2011-11-23  Ojan Vafai  <ojan@chromium.org>
413
414         Temporarily save the incremental results json in order to identify bug
415         https://bugs.webkit.org/show_bug.cgi?id=73057
416
417         Reviewed by Dean Jackson.
418
419         The test results server needed to be rolled back from tip of tree
420         due to a JSON merging bug. It's hard to identify what the bug is without
421         the raw data.
422
423         * Scripts/webkitpy/layout_tests/controllers/manager.py:
424         (Manager._upload_json_files):
425
426 2011-11-23  Ojan Vafai  <ojan@chromium.org>
427
428         Merging two version 4 results hits an error in the test results server
429         https://bugs.webkit.org/show_bug.cgi?id=73042
430
431         Reviewed by Adam Barth.
432
433         The old code assumed that if the aggregate results value was not a leaf
434         value that the incremental results would exist, which is just totally
435         wrong. Added a test for that case as well.
436
437         * TestResultServer/model/jsonresults.py:
438         (JsonResults._merge_tests):
439         * TestResultServer/model/jsonresults_unittest.py:
440         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
441         (JsonResultsTest.test_merge_build_directory_hierarchy):
442
443 2011-11-23  Eric Seidel  <eric@webkit.org>
444
445         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
446         https://bugs.webkit.org/show_bug.cgi?id=71983
447
448         Reviewed by Adam Barth.
449
450         We'll add more code to Environment overtime,
451         allowing us to mock out more of our direct interactions with os.environ.
452
453         This patch also makes run_command print the passed in environment.
454
455         * Scripts/webkitpy/common/host_mock.py:
456         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
457         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
458         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
459         * Scripts/webkitpy/common/system/executive.py:
460         * Scripts/webkitpy/common/system/executive_mock.py:
461         * Scripts/webkitpy/layout_tests/port/webkit.py:
462         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
463         * Scripts/webkitpy/tool/commands/download_unittest.py:
464         * Scripts/webkitpy/tool/steps/build.py:
465
466 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
467
468         [Qt] Re-generate QtWebKit API forwarding headers when API changes
469
470         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
471         so we need sync.profile to live in the same directory as the project file
472         that will be touched when adding/removing API (api.pri in our case).
473
474         Since the WebKit2 APIs live in a separate static library, we have to
475         add the project file for WebKit2 as a dependency of the api.pri file
476         as well, so that any changes to the WebKit2 API will still trigger a
477         run of qmake (and then syncqt).
478
479         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
480         that the forwarding headers are still generated in the root build dir,
481         not in the Source dir along with the internal forwarding headers.
482
483         Reviewed by Andreas Kling.
484
485         * qmake/mkspecs/features/default_pre.prf:
486         * qmake/mkspecs/features/functions.prf:
487
488 2011-11-23  Johnny Ding  <jnd@chromium.org>
489
490         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
491         https://bugs.webkit.org/show_bug.cgi?id=72950
492
493         Reviewed by Tony Chang.
494
495         * DumpRenderTree/chromium/LayoutTestController.cpp:
496         (LayoutTestController::queueLoadHTMLString):
497
498 2011-11-23  Adam Barth  <abarth@webkit.org>
499
500         garden-o-matic should display a message if it can't find results to display
501         https://bugs.webkit.org/show_bug.cgi?id=72991
502
503         Reviewed by Dimitri Glazkov.
504
505         Not all failures (e.g., TIMEOUT) have results that we can display.
506         This patch adds a short message so that the user can see that we're
507         done trying to load the results.
508
509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
512
513 2011-11-23  Adam Barth  <abarth@webkit.org>
514
515         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
516         https://bugs.webkit.org/show_bug.cgi?id=72992
517
518         Reviewed by Dimitri Glazkov.
519
520         This patch also prepares us to list other sorts of failures, like
521         performance and unit test.
522
523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
527
528 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
529
530         Add new Chromium tests to the flakiness dashboard
531         https://bugs.webkit.org/show_bug.cgi?id=72997
532
533         Reviewed by Ojan Vafai.
534
535         * TestResultServer/static-dashboards/dashboard_base.js:
536         ():
537
538 2011-11-23  Adam Barth  <abarth@webkit.org>
539
540         garden-o-matic should support AUDIO failures
541         https://bugs.webkit.org/show_bug.cgi?id=69477
542
543         Reviewed by Dimitri Glazkov.
544
545         This is a first iteration at supporting AUDIO failures in
546         garden-o-matic.  We'll probably need to iterate a bit when we have a
547         real audio failure in the tree to play with.  For example, we'll
548         probably want to add and <audio> element to the "Examine" view to hear
549         the differences, but that all can be done in a subsequent patch.
550
551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
552
553 2011-11-23  Scott Graham  <scottmg@chromium.org>
554
555         Adding gamepad support
556         https://bugs.webkit.org/show_bug.cgi?id=69451
557
558         Reviewed by Darin Fisher.
559
560         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
561         gamepad data that will be retrieved when JS code pulls via API access.
562
563         * DumpRenderTree/DumpRenderTree.gypi:
564         * DumpRenderTree/chromium/GamepadController.cpp: Added.
565         (GamepadController::GamepadController):
566         (GamepadController::bindToJavascript):
567         (GamepadController::reset):
568         (GamepadController::connect):
569         (GamepadController::disconnect):
570         (GamepadController::setId):
571         (GamepadController::setButtonCount):
572         (GamepadController::setButtonData):
573         (GamepadController::setAxisCount):
574         (GamepadController::setAxisData):
575         (GamepadController::fallbackCallback):
576         * DumpRenderTree/chromium/GamepadController.h: Added.
577         * DumpRenderTree/chromium/TestShell.cpp:
578         (TestShell::TestShell):
579         (TestShell::resetTestController):
580         (TestShell::bindJSObjectsToWindow):
581         * DumpRenderTree/chromium/TestShell.h:
582         (TestShell::gamepadController):
583
584 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
585
586         [CMake] Move the top-level logic to the top-level directory.
587         https://bugs.webkit.org/show_bug.cgi?id=72685
588
589         Reviewed by Brent Fulgham.
590
591         * CMakeLists.txt: Added.
592         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
593         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
594         * Scripts/webkitdirs.pm:
595         (generateBuildSystemFromCMakeProject):
596         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
597
598 2011-11-17  Vincent Scheib  <scheib@chromium.org>
599
600         Pointer Lock: Initial Tests for navigator.webkitPonter
601         https://bugs.webkit.org/show_bug.cgi?id=72659
602
603         Reviewed by Darin Fisher.
604
605         * DumpRenderTree/chromium/TestShell.cpp:
606         (TestShell::TestShell):
607             Enabling PointerLock in TestShell
608
609 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
610
611         Update flakiness dashboard for new Chromium builders and tests
612         https://bugs.webkit.org/show_bug.cgi?id=72931
613
614         Reviewed by Ojan Vafai.
615
616         * TestResultServer/static-dashboards/builders.js:
617         * TestResultServer/static-dashboards/dashboard_base.js:
618
619 2011-11-22  Adam Roben  <aroben@apple.com>
620
621         Remove some debugging code I accidentally left in r101005
622
623         * Scripts/prepare-ChangeLog:
624         (get_function_line_ranges_for_python):
625
626 2011-11-22  Adam Roben  <aroben@apple.com>
627
628         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
629
630         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
631         classes/methods in Python source files
632
633         Reviewed by Dan Bates.
634
635         * Scripts/prepare-ChangeLog:
636         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
637         or that use python as their interpreter. Modified the code that extracts the interpreter to
638         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
639         scripts.
640         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
641         for class/def lines and generate ranges based on them.
642
643 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
644
645         [GTK] Enable WebSocket hybi tests
646         https://bugs.webkit.org/show_bug.cgi?id=72870
647
648         Reviewed by Xan Lopez.
649
650         * DumpRenderTree/gtk/DumpRenderTree.cpp:
651         (resetDefaultsToConsistentValues):
652         Reset the setting value to the default value (true).
653         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
654         (LayoutTestController::overridePreference):
655         Change the setting value through a function in DumpRenderTreeSupportGtk.
656
657 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
658
659         ChangeLogEntry should be able to parse entries with multiple authors
660         https://bugs.webkit.org/show_bug.cgi?id=72690
661
662         Reviewed by Eric Seidel.
663
664         Support multi-author change log entries in ChangeLogEntry. Split author names using
665         the same logic as splitting reviewer names. _authors now stores list of dictionaries
666         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
667         accounts because some contributors are never listed in committers.py. 
668
669         * Scripts/webkitpy/common/checkout/changelog.py:
670         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
671         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
672         throws an exception when the argument is None.
673
674 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
675
676         [Qt] Speed up debug builds.
677         https://bugs.webkit.org/show_bug.cgi?id=72882
678
679         Reviewed by Tor Arne Vestbø.
680
681         Introduce a special type of build that replaces the static jsc/wc/wk2
682         static libraries with shared libraries, that individually are much faster
683         to link and don't require relinking into the big library when changing just
684         one file in one module. It can be enabled with
685         --qmakearg="CONFIG+=force_static_libs_as_shared"
686
687         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
688         disable symbol visibility, static linkage and enable rpath.
689         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
690         we need to link the convenience libraries together or not and renamed linkStaticLibrary
691         to just linkLibrary (because linkage is not necessarily static).
692         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
693         link against jsc/wc/wk2 when linking app code against QtWebKit.
694         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
695         function.
696         * qmake/mkspecs/features/webcore.prf: Ditto.
697         * qmake/mkspecs/features/webkit2.prf: Ditto.
698
699 2011-11-21  Adam Klein  <adamk@chromium.org>
700
701         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
702         https://bugs.webkit.org/show_bug.cgi?id=72898
703
704         Reviewed by Ojan Vafai.
705
706         Also removed a comment that was going to be more trouble to keep up to
707         date than seemed worthwhile (the code is now the documentation).
708
709         * TestResultServer/static-dashboards/flakiness_dashboard.html:
710
711 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
712
713         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
714         https://bugs.webkit.org/show_bug.cgi?id=72895
715
716         Reviewed by Chris Fleizach.
717
718         * DumpRenderTree/chromium/WebViewHost.cpp:
719         (WebViewHost::postAccessibilityNotification):
720
721 2011-11-21  Philippe Normand  <pnormand@igalia.com>
722
723         Unreviewed, run-gtk-tests temporary workaround after r98500.
724
725         * Scripts/run-gtk-tests: Try to find the build directory like in
726         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
727
728 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
729
730         [GTK] Add a way to skip unit tests in the bots
731         https://bugs.webkit.org/show_bug.cgi?id=72879
732
733         Reviewed by Philippe Normand.
734
735         Rewrite the script in python to make it easier for everybody to
736         change it and add support for skipping tests.
737
738         * Scripts/run-gtk-tests:
739
740 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
741
742         [EFL] Add more appcache functions to ewk_settings.
743         https://bugs.webkit.org/show_bug.cgi?id=72143
744
745         Reviewed by Kenneth Rohde Christiansen.
746
747         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
748         (LayoutTestController::clearAllApplicationCaches):
749         (LayoutTestController::setAppCacheMaximumSize): Use the right
750         function, this is not related to the memory cache, but rather to the
751         appcache.
752
753 2011-11-18  Adam Roben  <aroben@apple.com>
754
755         Make NRWT consider all lines of output from parse-malloc-history, not just the first
756
757         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
758         found" even when there are more than 1 unique leaks
759
760         Reviewed by Darin Adler.
761
762         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
763         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
764         "^" will be considered to match the beginning of any line, not only the beginning of the
765         string.
766
767         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
768         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
769         fake output and updated expectations to match.
770
771 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
772
773         [Qt] Clean up MiniBrowser project file after recent changes
774         https://bugs.webkit.org/show_bug.cgi?id=72869
775
776         Reviewed by Simon Hausmann.
777
778         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
779
780         * MiniBrowser/qt/MiniBrowser.pro:
781
782 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
783
784         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
785         https://bugs.webkit.org/show_bug.cgi?id=72479
786
787         Reviewed by Chris Fleizach.
788
789         * DumpRenderTree/AccessibilityUIElement.cpp:
790         (getIsSelectedOptionActiveCallback):
791         (AccessibilityUIElement::getJSClass):
792         * DumpRenderTree/AccessibilityUIElement.h:
793         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
794         (AccessibilityUIElement::AccessibilityUIElement):
795         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
796         * DumpRenderTree/chromium/AccessibilityUIElement.h:
797         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
798         (AccessibilityUIElement::isSelectedOptionActive):
799         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
800         (AccessibilityUIElement::isSelectedOptionActive):
801         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
802         (AccessibilityUIElement::isSelectedOptionActive):
803
804 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
805
806         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
807         https://bugs.webkit.org/show_bug.cgi?id=72859
808
809         Reviewed by Eric Seidel.
810         
811         * Scripts/new-run-webkit-websocketserver:
812
813 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
814
815         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
816         https://bugs.webkit.org/show_bug.cgi?id=72655
817
818         Reviewed by Hajime Morita.
819
820         Fixed the calculation of offset.
821
822         * DumpRenderTree/chromium/WebViewHost.cpp:
823         (WebViewHost::finishLastTextCheck):
824
825 2011-11-20  Ojan Vafai  <ojan@chromium.org>
826
827         Change the final place where we use version 3 of the results json output
828         https://bugs.webkit.org/show_bug.cgi?id=72838
829
830         Reviewed by Adam Barth.
831
832         This converts the json from being a flat map of test name --> results
833         to being hierarchical by directory. This will make the json files 
834         considerably smaller.
835
836         Also cleaned up some functions that were returning/checking boolean values
837         that were always True.
838
839         * TestResultServer/model/jsonresults.py:
840         * TestResultServer/model/jsonresults_unittest.py:
841
842 2011-11-20  Ojan Vafai  <ojan@chromium.org>
843
844         Include the master name when querying the test results server.
845         This will soon be required since leaving the master name out mean
846         that multiple files could match the query.
847
848         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
849
850 2011-11-19  Ojan Vafai  <ojan@chromium.org>
851
852         Fix jsonp callback code to add the callback if json content
853         is not jsonp.
854         * TestResultServer/handlers/testfilehandler.py:
855
856 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
857
858         Modify dashboard_base.js to optionally accept version 4 results json.
859
860         Reviewed by Ojan Vafai.
861
862         * TestResultServer/static-dashboards/dashboard_base.js:
863         (ADD_RESULTS):
864         (flattenTrie):
865         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
866         (testFlattenTrie):
867
868 2011-11-19  Ojan Vafai  <ojan@chromium.org>
869
870         Stop storing results files as jsonp in the test results server
871         https://bugs.webkit.org/show_bug.cgi?id=72814
872
873         Reviewed by Adam Barth.
874
875         * TestResultServer/model/jsonresults.py:
876         * TestResultServer/model/jsonresults_unittest.py:
877
878 2011-11-19  Ojan Vafai  <ojan@chromium.org>
879
880         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
881         https://bugs.webkit.org/show_bug.cgi?id=72813
882
883         Reviewed by Adam Barth.
884
885         Once this lands, we can start storing pure json in the test results server and then
886         we can delete the code with all the FIXMEs added here.
887
888         * Scripts/webkitpy/layout_tests/controllers/manager.py:
889         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
890         Only add jsonp for full_results.json.
891         * TestResultServer/model/jsonresults.py:
892         * TestResultServer/model/jsonresults_unittest.py:
893         Accept pure json uploads.
894         * TestResultServer/static-dashboards/dashboard_base.js:
895         (appendJSONScriptElementFor):
896         Use the callback parameter so that the server can start returning pure json if it's left out.
897
898 2011-11-19  Ojan Vafai  <ojan@chromium.org>
899
900         Allow json NRWT downloads to be pure json and not jsonp
901         https://bugs.webkit.org/show_bug.cgi?id=72809
902
903         Reviewed by Adam Barth.
904
905         I'm moving the server to storing and serving up raw json instead of jsonp.
906         You can still get the jsonp by passing a "callback" parameter, but there's no
907         need for run-webkit-tests to get jsonp when all it wants is the raw json.
908
909         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
910         Make the wrapper stripping only happen if the json is actually wrapped.
911         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
912
913 2011-11-18  Daniel Bates  <dbates@rim.com>
914
915         Add CMake build infrastructure for the BlackBerry port
916         https://bugs.webkit.org/show_bug.cgi?id=72768
917
918         Reviewed by Antonio Gomes.
919
920         Add optional --blackberry command line argument to build-webkit to build the
921         BlackBerry port.
922
923         * Scripts/build-webkit:
924         * Scripts/webkitdirs.pm:
925         (determineBaseProductDir):
926         (argumentsForConfiguration):
927         (builtDylibPathForName):
928         (determineIsQt):
929         (isBlackBerry): Added.
930         (determineIsBlackBerry): Added.
931         (blackberryTargetArchitecture): Added.
932         (isAppleWebKit):
933
934 2011-11-18  James Robinson  <jamesr@chromium.org>
935
936         Unreviewed, rolling out r100835.
937         http://trac.webkit.org/changeset/100835
938         https://bugs.webkit.org/show_bug.cgi?id=72778
939
940         Broke some page scale tests
941
942         * DumpRenderTree/chromium/EventSender.cpp:
943         (EventSender::scalePageBy):
944
945 2011-11-18  Adam Barth  <abarth@webkit.org>
946
947         Prepare to move manual-tests out of WebCore
948         https://bugs.webkit.org/show_bug.cgi?id=72782
949
950         Reviewed by Eric Seidel.
951
952         Update this file to refer to the new location of ManualTests.
953
954         * Scripts/webkitpy/common/config/build.py:
955
956 2011-11-18  James Robinson  <jamesr@chromium.org>
957
958         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
959         https://bugs.webkit.org/show_bug.cgi?id=72778
960
961         Reviewed by Kenneth Russell.
962
963         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
964
965         * DumpRenderTree/chromium/EventSender.cpp:
966         (EventSender::scalePageBy):
967
968 2011-11-18  Scott Graham  <scottmg@chromium.org>
969
970         IDL changes for gamepad support
971         https://bugs.webkit.org/show_bug.cgi?id=71753
972
973         Reviewed by Adam Barth.
974
975         Runtime enable gamepad in chromium test shell.
976
977         * DumpRenderTree/chromium/TestShell.cpp:
978         (TestShell::TestShell):
979
980 2011-10-27  Darin Fisher  <darin@chromium.org>
981
982         [chromium] Improve fullscreen API
983         https://bugs.webkit.org/show_bug.cgi?id=70477
984
985         Reviewed by Adam Barth.
986
987         Implement enter/exitFullScreen.  The implementation is asynchronous,
988         via postDelayedTask, to simulate how the browser actually behaves.
989
990         * DumpRenderTree/chromium/WebViewHost.cpp:
991         (WebViewHost::enterFullScreen):
992         (WebViewHost::exitFullScreen):
993         (WebViewHost::setAddressBarURL):
994         (WebViewHost::enterFullScreenNow):
995         (WebViewHost::exitFullScreenNow):
996         * DumpRenderTree/chromium/WebViewHost.h:
997
998 2011-11-18  Adam Roben  <aroben@apple.com>
999
1000         Ignore an ANGLE leak that is not WebKit's fault
1001
1002         * Scripts/old-run-webkit-tests:
1003         (countAndPrintLeaks):
1004         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1005         (LeakDetector._callstacks_to_exclude_from_leaks):
1006         Added ScanFromString to the call stacks to exclude on all OS versions.
1007
1008 2011-11-18  Adam Roben  <aroben@apple.com>
1009
1010         Ignore another Lion-specific leak that is not WebKit's fault
1011
1012         * Scripts/old-run-webkit-tests:
1013         (countAndPrintLeaks):
1014         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1015         (LeakDetector._callstacks_to_exclude_from_leaks):
1016         Added SecTransformExecute to the call stacks to exclude.
1017
1018 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
1019
1020         [Qt] Enable WebSocket hybi tests
1021         https://bugs.webkit.org/show_bug.cgi?id=72687
1022
1023         Reviewed by Simon Hausmann.
1024
1025         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
1026
1027         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1028         (WebCore::WebPage::resetSettings):
1029         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1030         (LayoutTestController::overridePreference):
1031
1032 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
1033
1034         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
1035         https://bugs.webkit.org/show_bug.cgi?id=72707
1036
1037         Reviewed by Philippe Normand.
1038
1039         Make new-run-webkit-tests use the right path to locate the test
1040         plugin used by WebKitTestRunner.
1041
1042         * Scripts/webkitpy/layout_tests/port/gtk.py:
1043
1044 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
1045
1046         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
1047         https://bugs.webkit.org/show_bug.cgi?id=72697
1048
1049         Reviewed by Kenneth Rohde Christiansen.
1050
1051         * Tools.pro: Make WTR linux only for the moment.
1052         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
1053         * WebKitTestRunner/Target.pri: Ditto.
1054         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
1055         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
1056
1057 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1058
1059         [Qt] Change default size of the MiniBrowser
1060
1061         Reviewed by Simon Hausmann.
1062
1063         As we lay out desktop pages using the width of 980, change our default
1064         size to 980x735 so that we are not scaling down by default.
1065
1066         * MiniBrowser/qt/MiniBrowserApplication.h:
1067         (WindowOptions::WindowOptions):
1068
1069 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1070
1071         [EFL] Clean up the use of DATA_DIR in the buildsystem
1072         https://bugs.webkit.org/show_bug.cgi?id=72681
1073
1074         Reviewed by Daniel Bates.
1075
1076         Instead of adding -DDATA_DIR in all scopes, only define it in
1077         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
1078         it.
1079
1080         We can then define DATA_DIR to the generated theme directory for
1081         EWebLauncher, since it's what we want here.
1082
1083         * CMakeListsEfl.txt:
1084
1085 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1086
1087         [EFL] Move platform includes last in DRT's include directories.
1088         https://bugs.webkit.org/show_bug.cgi?id=72684
1089
1090         Reviewed by Daniel Bates.
1091
1092         This is the first step in fixing the build when a platform include (in
1093         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
1094         is included instead of WebKit's.
1095
1096         * DumpRenderTree/efl/CMakeLists.txt:
1097
1098 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
1099
1100         fuzzy_match doesn't recognize "Dan B" or "hyatt"
1101         https://bugs.webkit.org/show_bug.cgi?id=72636
1102
1103         Reviewed by Eric Seidel.
1104
1105         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
1106         and user names of email addreses such as rniwa in rniwa@webkit.org.
1107
1108         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
1109
1110         * Scripts/webkitpy/common/config/committers.py:
1111         * Scripts/webkitpy/common/config/committers_unittest.py:
1112
1113 2011-11-17  Eric Seidel  <eric@webkit.org>
1114
1115         Remove support for running check-webkit-style w/o a webkit checkout
1116         https://bugs.webkit.org/show_bug.cgi?id=72678
1117
1118         Reviewed by Adam Barth.
1119
1120         After talking to Dave Levin we've decided to remove this
1121         code.  I know of no users of check-webkit-style w/o a webkit checkout
1122         and this needlessly adds complexity.
1123
1124         * Scripts/webkitpy/style/main.py:
1125
1126 2011-11-17  Eric Seidel  <eric@webkit.org>
1127
1128         Remove more direct uses of os.path
1129         https://bugs.webkit.org/show_bug.cgi?id=72677
1130
1131         Reviewed by Adam Barth.
1132
1133         Remove more uses of os.path, including refactoring
1134         CommitterValidator to use a Host object instead of
1135         manual hacks to emulate what SCM and FileSystem provide.
1136
1137         * Scripts/webkitpy/common/checkout/changelog.py:
1138         * Scripts/webkitpy/common/config/committervalidator.py:
1139         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1140         * Scripts/webkitpy/common/system/filesystem_mock.py:
1141          - Turns out none of our unittests actually looked at this path.
1142            now I've made it be a valid path.
1143         * Scripts/webkitpy/tool/bot/feeders.py:
1144         * Scripts/webkitpy/tool/commands/queues.py:
1145
1146 2011-11-17  Eric Seidel  <eric@webkit.org>
1147
1148         Teach TextFileReader about FileSystem
1149         https://bugs.webkit.org/show_bug.cgi?id=72673
1150
1151         Reviewed by Adam Barth.
1152
1153         Unfortunately TextFileReader doesn't use FileSystem
1154         everywhere yet, so we can't move the unittests to
1155         using MockFileSystem, but we're close.
1156
1157         * Scripts/webkitpy/style/filereader.py:
1158         * Scripts/webkitpy/style/filereader_unittest.py:
1159         * Scripts/webkitpy/style/main.py:
1160
1161 2011-11-17  Eric Seidel  <eric@webkit.org>
1162
1163         Give check-webkit-style a Host
1164         https://bugs.webkit.org/show_bug.cgi?id=72670
1165
1166         Reviewed by Adam Barth.
1167
1168         * Scripts/webkitpy/common/checkout/scm/detection.py:
1169         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1170          - We don't run these unittests, but this one was looking for the wrong exception.
1171         * Scripts/webkitpy/style/main.py:
1172         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1173          - This was create a new scm object even though it already had one?
1174
1175 2011-11-17  Eric Seidel  <eric@webkit.org>
1176
1177         Move check-webkit-style change_directory code to more modern mocks
1178         https://bugs.webkit.org/show_bug.cgi?id=72664
1179
1180         Reviewed by Adam Barth.
1181
1182         * Scripts/check-webkit-style:
1183         * Scripts/webkitpy/style/main.py:
1184         * Scripts/webkitpy/style/main_unittest.py:
1185
1186 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
1187
1188         [GTK] enable ref tests
1189         https://bugs.webkit.org/show_bug.cgi?id=72601
1190
1191         Re-enable ref tests. Run the driver under evenly numbered display if performing
1192         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
1193         being run in an already used Xvfb instance if pixel tests are disabled.
1194
1195         Reviewed by Tony Chang.
1196
1197         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
1198         after the process is killed
1199
1200 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1201
1202         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
1203         https://bugs.webkit.org/show_bug.cgi?id=72620
1204
1205         Reviewed by David Levin.
1206
1207         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
1208         adding the suffix the cpp file. One example of false positive
1209         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
1210
1211         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
1212         basename contains the cpp's basename.
1213         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1214
1215 2011-11-17  Eric Seidel  <eric@webkit.org>
1216
1217         Move check-webkit-style's guts into webkitpy/style/main.py
1218         https://bugs.webkit.org/show_bug.cgi?id=72657
1219
1220         Reviewed by Adam Barth.
1221
1222         * Scripts/check-webkit-style:
1223         * Scripts/webkitpy/style/main.py:
1224
1225 2011-11-17  Eric Seidel  <eric@webkit.org>
1226
1227         new-run-webkit-tests is locale dependent
1228         https://bugs.webkit.org/show_bug.cgi?id=68691
1229
1230         Reviewed by Adam Barth.
1231
1232         Make NRWT use a clean environment, just like ORWT did.
1233
1234         * Scripts/webkitpy/layout_tests/port/base.py:
1235         * Scripts/webkitpy/layout_tests/port/chromium.py:
1236         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1237         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1238         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1239         * Scripts/webkitpy/layout_tests/port/efl.py:
1240         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1241         * Scripts/webkitpy/layout_tests/port/mac.py:
1242         * Scripts/webkitpy/layout_tests/port/qt.py:
1243         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1244         * Scripts/webkitpy/layout_tests/port/webkit.py:
1245         * Scripts/webkitpy/layout_tests/port/win.py:
1246
1247 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
1248
1249         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
1250         https://bugs.webkit.org/show_bug.cgi?id=72615
1251
1252         Reviewed by James Robinson.
1253
1254         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1255
1256 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
1257
1258         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
1259         https://bugs.webkit.org/show_bug.cgi?id=72595
1260
1261         Reviewed by Noam Rosenthal.
1262
1263         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1264         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
1265         ensure the registration of the DRTNode JS bindings.
1266         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1267         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
1268         registration of QWebElement (now done implicitly through QWebPage ->
1269         QtWebElementRunTime::initialize code path)
1270
1271 2011-11-17  Adam Roben  <aroben@apple.com>
1272
1273         Fix a crash-inducing typo I introduced in r100648
1274
1275         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
1276         handling a crashing test
1277
1278         Reviewed by Adam Barth.
1279
1280         * Scripts/webkitpy/layout_tests/port/chromium.py:
1281         (ChromiumDriver.run_test): Get the driver name from the port.
1282
1283         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1284         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
1285         right crashed process name.
1286
1287 2011-11-17  Adam Roben  <aroben@apple.com>
1288
1289         Fix NRWT's parsing of the number of excluded leaks
1290
1291         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
1292         leaks were excluded
1293
1294         Reviewed by Adam Barth.
1295
1296         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1297         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
1298         regular expression match, not the entire matched string.
1299
1300         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1301         (LeakDetectorTest): Added some example output that shows how things look when leaks are
1302         excluded.
1303         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
1304         correctly.
1305
1306 2011-11-17  Adam Roben  <aroben@apple.com>
1307
1308         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
1309
1310         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
1311         when web process crashes, but WebProcess crash log should get saved instead
1312
1313         Reviewed by Eric Seidel.
1314
1315         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1316         (write_test_result): Simplified a little to share more code between the case where we
1317         crashed when running the test and where we crashed when checking the expected rendering for
1318         a reftest. Changed to pass the crashed process name down to write_crash_report.
1319         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
1320         along to CrashLogs.find_newest_log rather than always using the driver name.
1321
1322         * Scripts/webkitpy/layout_tests/port/chromium.py:
1323         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
1324         crashed.
1325
1326         * Scripts/webkitpy/layout_tests/port/test.py:
1327         (TestInstance.__init__): Initialize new web_process_crash attribute.
1328         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
1329         test this patch adds.
1330         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
1331         specifies that the driver crashed or the web process crashed.
1332
1333         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1334         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
1335         which we pretend the web process crashed rather than the driver process.
1336
1337         (MainTest.test_run_singly_actually_runs_tests):
1338         (MainTest.test_unexpected_failures):
1339         (EndToEndTest.test_end_to_end):
1340         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
1341
1342 2011-11-17  Tony Chang  <tony@chromium.org>
1343
1344         [chromium] stop spamming features warning on every build
1345         https://bugs.webkit.org/show_bug.cgi?id=72629
1346
1347         Reviewed by Ojan Vafai.
1348
1349         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
1350         $mediaStreamSupport is on by default for chromium, make the default
1351         for $blobSupport also on.
1352
1353         * Scripts/build-webkit:
1354
1355 2011-11-17  Adam Roben  <aroben@apple.com>
1356
1357         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
1358
1359         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
1360         that are supposed to be ignored
1361
1362         Reviewed by Adam Barth.
1363
1364         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1365         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
1366         required when passing arguments via the shell (which we aren't doing here). It is not
1367         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
1368
1369         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1370         (LeakDetectorTest.test_leaks_args): Updated expectations.
1371
1372 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1373
1374         Unreviewed, run-bindings-tests fix after r91028.
1375
1376         * Scripts/run-bindings-tests: Use scm.detection module.
1377
1378 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
1379
1380         Silence a warning about control reaching the end of a non-void function
1381         https://bugs.webkit.org/show_bug.cgi?id=72616
1382
1383         Reviewed by Tony Gentilcore.
1384
1385         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1386         (AccessibilityUIElement::verticalScrollbar):
1387
1388 2011-11-17  Adam Roben  <aroben@apple.com>
1389
1390         Ignore some leaks in frameworks we link against on Lion
1391
1392         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
1393         aren't WebKit's fault
1394
1395         Reviewed by Antti Koivisto.
1396
1397         * Scripts/old-run-webkit-tests:
1398         (countAndPrintLeaks):
1399         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1400         (LeakDetector._callstacks_to_exclude_from_leaks):
1401         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
1402
1403         * Scripts/webkitpy/layout_tests/port/mac.py:
1404         (MacPort.is_lion): Added.
1405
1406         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1407         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
1408         methods.
1409
1410 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1411
1412         [GTK] Disable ref tests
1413         https://bugs.webkit.org/show_bug.cgi?id=72599
1414
1415         Reviewed by Xan Lopez.
1416
1417         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
1418         tests to avoid massive flakiness.
1419
1420 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1421
1422         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
1423
1424         A new extension object has been added to QQuickWebView (the same approach should be used
1425         for other API classes that need experimental APIs). The QML extension mechanism is then
1426         built on top of the experimental object.
1427
1428         https://bugs.webkit.org/show_bug.cgi?id=72522
1429
1430         Reviewed by Simon Hausmann.
1431
1432         * MiniBrowser/qt/BrowserWindow.cpp:
1433         (BrowserWindow::BrowserWindow):
1434         (BrowserWindow::webView):
1435         * MiniBrowser/qt/BrowserWindow.h:
1436         * MiniBrowser/qt/UrlLoader.cpp:
1437         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1438         * qmake/mkspecs/features/default_post.prf:
1439         * qmake/mkspecs/features/default_pre.prf:
1440         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
1441         * qmake/mkspecs/features/qtwebkit.prf:
1442
1443 2011-11-17  Adam Barth  <abarth@webkit.org>
1444
1445         Move test_results_uploader.py out of layout_package
1446         https://bugs.webkit.org/show_bug.cgi?id=72590
1447
1448         Reviewed by Eric Seidel.
1449
1450         Most of the lines of code in this file are wrong, but I've restrained
1451         myself and only changed a few of them to generalized this class to the
1452         common package.
1453
1454         This is part of a series of patches to remove layout_package.
1455
1456         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
1457         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1458         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
1459
1460 2011-11-17  Adam Barth  <abarth@webkit.org>
1461
1462         Unreviewed. Fix style nits in printing.py.
1463
1464         * Scripts/webkitpy/layout_tests/views/printing.py:
1465
1466 2011-11-17  Adam Barth  <abarth@webkit.org>
1467
1468         Minor style nits in run_webkit_tests.py
1469         https://bugs.webkit.org/show_bug.cgi?id=72583
1470
1471         Reviewed by Eric Seidel.
1472
1473         This patch just fixes some minor style issues as I work my way back
1474         into this code.
1475
1476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1477
1478 2011-11-17  Adam Barth  <abarth@webkit.org>
1479
1480         Move test_result_writer out of layout_package
1481         https://bugs.webkit.org/show_bug.cgi?id=72586
1482
1483         Rubber-stamped by Eric Seidel.
1484
1485         This is part of a series of patches to remove layout_package.
1486
1487         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1488         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
1489         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
1490         * Scripts/webkitpy/tool/commands/rebaseline.py:
1491
1492 2011-11-17  Adam Barth  <abarth@webkit.org>
1493
1494         svn-apply shouldn't magically move files into Source anymore
1495         https://bugs.webkit.org/show_bug.cgi?id=72579
1496
1497         Reviewed by Eric Seidel.
1498
1499         The Source directory has existed for long enough that we don't need
1500         svn-apply to magically re-write old-style patches anymore.
1501
1502         * Scripts/VCSUtils.pm:
1503         (parseGitDiffHeader):
1504         (parseSvnDiffHeader):
1505
1506 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1507
1508         Add a list of contribution areas
1509         https://bugs.webkit.org/show_bug.cgi?id=72566
1510
1511         Reviewed by Eric Seidel.
1512
1513         Added ContributionAreas class.
1514
1515         * Scripts/webkitpy/common/config/contributionareas.py: Added.
1516         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
1517
1518 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1519
1520         Refactor ChangeLogTest.test_parse_reviewer_text
1521         https://bugs.webkit.org/show_bug.cgi?id=72572
1522
1523         Reviewed by Eric Seidel.
1524
1525         Refactored the test code by introduing two helper functions.
1526
1527         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1528
1529 2011-11-16  Eric Seidel  <eric@webkit.org>
1530
1531         Add SCMDetector object to make scm detection mockable
1532         https://bugs.webkit.org/show_bug.cgi?id=72247
1533
1534         Reviewed by Adam Barth.
1535
1536         I think SCM detection may eventually be rolled into Checkout,
1537         but this patch at least makes it possible to mock code-paths
1538         which rely on scm detection.
1539         In the process of replacing callers of these free-functions
1540         I found that one of the functions was no longer used,
1541         and that one of the callers could instead just use the SCM
1542         object it already had access to through port.host.scm().
1543         I also discovered that I was not calling Host._initialize_scm()
1544         and thus host.scm() was always returning None!
1545
1546         * Scripts/check-webkit-style:
1547         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1548         * Scripts/webkitpy/common/checkout/deps.py:
1549         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1550         * Scripts/webkitpy/common/checkout/scm/detection.py:
1551         * Scripts/webkitpy/common/checkout/scm/git.py:
1552         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1553         * Scripts/webkitpy/common/checkout/scm/svn.py:
1554         * Scripts/webkitpy/common/host.py:
1555         * Scripts/webkitpy/common/host_mock.py:
1556         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1557         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1558         * Scripts/webkitpy/layout_tests/port/base.py:
1559         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1560         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1561         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1562         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1563
1564 2011-11-16  Mark Rowe  <mrowe@apple.com>
1565
1566         Fix the build.
1567
1568         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
1569         Apply the workaround that we use in other projects to WebKitTestRunner.
1570
1571         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
1572         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1573         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
1574
1575 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1576
1577         [Qt] Fix build after WTR AX support
1578         https://bugs.webkit.org/show_bug.cgi?id=72560
1579
1580         Reviewed by Geoffrey Garen.
1581
1582         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1583         * WebKitTestRunner/InjectedBundle/Target.pri:
1584
1585 2011-11-16  Tony Chang  <tony@chromium.org>
1586
1587         repurpose the flexbox bot for grid layout
1588         https://bugs.webkit.org/show_bug.cgi?id=72557
1589
1590         Reviewed by Ryosuke Niwa.
1591
1592         Since new flexbox is enabled everywhere, we don't need this bot
1593         anymore.  However, work on grid layout has begun, so we can use this
1594         bot to compile with ENABLE_CSS_GRID_LAYOUT.
1595
1596         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
1597         the bot on the waterfall, I will change the slave config to enable
1598         the compile flag and tests.
1599
1600 2011-11-11  Adrienne Walker  <enne@google.com>
1601
1602         [chromium] Expose mock scrollbars to window.internals
1603         https://bugs.webkit.org/show_bug.cgi?id=72195
1604
1605         Reviewed by James Robinson.
1606
1607         Because mock scrollbars are a global setting, reset between runs.
1608
1609         * DumpRenderTree/chromium/WebPreferences.cpp:
1610         (WebPreferences::applyTo):
1611
1612 2011-11-16  James Robinson  <jamesr@chromium.org>
1613
1614         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
1615         https://bugs.webkit.org/show_bug.cgi?id=72562
1616
1617         Reviewed by Dirk Pranke.
1618
1619         * DumpRenderTree/chromium/TestShell.cpp:
1620         (TestShell::runFileTest):
1621
1622 2011-11-16  Tony Chang  <tony@chromium.org>
1623
1624         [NRWT] speculative fix for multiple subprocess test on cygwin
1625         https://bugs.webkit.org/show_bug.cgi?id=72518
1626
1627         Reviewed by Adam Barth.
1628
1629         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
1630             tries to emulate posix fd behavior.
1631         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1632
1633 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1634
1635         Revert r100509; change was committed twice (first time as r100491).
1636         Unreviewed, build fix.
1637
1638         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1639
1640 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1641
1642         Run a dummy test in the gpu configurations if there's nothing to do.
1643         https://bugs.webkit.org/show_bug.cgi?id=72498
1644
1645         Reviewed by James Robinson.
1646
1647         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1648
1649 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1650
1651         contributors_by_fuzzy_match is super slow
1652         https://bugs.webkit.org/show_bug.cgi?id=72540
1653
1654         Reviewed by Eric Seidel.
1655
1656         Make contributors_by_name do case insensitive search using a dictionary.
1657
1658         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
1659         because that's the most common case.
1660
1661         * Scripts/webkitpy/common/config/committers.py:
1662         * Scripts/webkitpy/common/config/committers_unittest.py:
1663
1664 2011-11-16  David Levin  <levin@chromium.org>
1665
1666         check-webkit-style should recognize functions even if they have OVERRIDE after them.
1667         https://bugs.webkit.org/show_bug.cgi?id=72515
1668
1669         Reviewed by Adam Barth.
1670
1671         * Scripts/webkitpy/style/checkers/cpp.py:
1672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1673
1674 2011-11-16  Tony Chang  <tony@chromium.org>
1675
1676         [NRWT] refactor drivers to require pixel_tests param
1677         https://bugs.webkit.org/show_bug.cgi?id=72517
1678
1679         Reviewed by Ojan Vafai.
1680
1681         No tests, just a refactoring.
1682
1683         * Scripts/webkitpy/layout_tests/port/chromium.py:
1684         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1685         * Scripts/webkitpy/layout_tests/port/webkit.py:
1686         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1687
1688 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1689
1690         Run a dummy test in the gpu configurations if there's nothing to do.
1691         https://bugs.webkit.org/show_bug.cgi?id=72498
1692
1693         Reviewed by James Robinson.
1694
1695         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1696
1697 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
1698
1699         WebKitTestRunner needs to support accessibility-related DRT APIs
1700         https://bugs.webkit.org/show_bug.cgi?id=42131
1701
1702         Reviewed by Beth Dakin.
1703
1704         Port the AX code in DRT to WKTestRunner by using IDL.
1705
1706         * DumpRenderTree/AccessibilityUIElement.cpp:
1707         (horizontalScrollbarCallback):
1708         (verticalScrollbarCallback):
1709         (AccessibilityUIElement::horizontalScrollbar):
1710         (AccessibilityUIElement::verticalScrollbar):
1711         (AccessibilityUIElement::getJSClass):
1712         * DumpRenderTree/AccessibilityUIElement.h:
1713         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1714         (AccessibilityUIElement::horizontalScrollbar):
1715         (AccessibilityUIElement::verticalScrollbar):
1716         * WebKitTestRunner/DerivedSources.make:
1717         * WebKitTestRunner/GNUmakefile.am:
1718         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
1719         (WTR::AccessibilityController::create):
1720         (WTR::AccessibilityController::AccessibilityController):
1721         (WTR::AccessibilityController::~AccessibilityController):
1722         (WTR::AccessibilityController::makeWindowObject):
1723         (WTR::AccessibilityController::wrapperClass):
1724         (WTR::AccessibilityController::rootElement):
1725         (WTR::AccessibilityController::focusedElement):
1726         (WTR::AccessibilityController::elementAtPoint):
1727         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
1728         (WTR::AccessibilityController::logFocusEvents):
1729         (WTR::AccessibilityController::logValueChangeEvents):
1730         (WTR::AccessibilityController::logScrollingStartEvents):
1731         (WTR::AccessibilityController::logAccessibilityEvents):
1732         (WTR::AccessibilityController::addNotificationListener):
1733         (WTR::AccessibilityController::notificationReceived):
1734         (WTR::AccessibilityController::resetToConsistentState):
1735         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
1736         (WTR::AccessibilityTextMarker::create):
1737         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1738         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
1739         (WTR::AccessibilityTextMarker::platformTextMarker):
1740         (WTR::AccessibilityTextMarker::wrapperClass):
1741         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
1742         (WTR::AccessibilityTextMarker::isEqual):
1743         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
1744         (WTR::AccessibilityTextMarkerRange::create):
1745         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1746         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1747         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
1748         (WTR::AccessibilityTextMarkerRange::wrapperClass):
1749         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
1750         (WTR::AccessibilityTextMarkerRange::isEqual):
1751         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
1752         (WTR::AccessibilityUIElement::create):
1753         (WTR::AccessibilityUIElement::wrapperClass):
1754         (WTR::AccessibilityUIElement::isValid):
1755         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1756         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1757         (WTR::AccessibilityUIElement::isEqual):
1758         (WTR::AccessibilityUIElement::elementAtPoint):
1759         (WTR::AccessibilityUIElement::childAtIndex):
1760         (WTR::AccessibilityUIElement::indexOfChild):
1761         (WTR::AccessibilityUIElement::childrenCount):
1762         (WTR::AccessibilityUIElement::titleUIElement):
1763         (WTR::AccessibilityUIElement::parentElement):
1764         (WTR::AccessibilityUIElement::takeFocus):
1765         (WTR::AccessibilityUIElement::takeSelection):
1766         (WTR::AccessibilityUIElement::addSelection):
1767         (WTR::AccessibilityUIElement::removeSelection):
1768         (WTR::AccessibilityUIElement::allAttributes):
1769         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1770         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1771         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1772         (WTR::AccessibilityUIElement::attributesOfChildren):
1773         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1774         (WTR::AccessibilityUIElement::increment):
1775         (WTR::AccessibilityUIElement::decrement):
1776         (WTR::AccessibilityUIElement::showMenu):
1777         (WTR::AccessibilityUIElement::press):
1778         (WTR::AccessibilityUIElement::stringAttributeValue):
1779         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1780         (WTR::AccessibilityUIElement::numberAttributeValue):
1781         (WTR::AccessibilityUIElement::boolAttributeValue):
1782         (WTR::AccessibilityUIElement::isAttributeSupported):
1783         (WTR::AccessibilityUIElement::isAttributeSettable):
1784         (WTR::AccessibilityUIElement::isActionSupported):
1785         (WTR::AccessibilityUIElement::role):
1786         (WTR::AccessibilityUIElement::subrole):
1787         (WTR::AccessibilityUIElement::roleDescription):
1788         (WTR::AccessibilityUIElement::title):
1789         (WTR::AccessibilityUIElement::description):
1790         (WTR::AccessibilityUIElement::language):
1791         (WTR::AccessibilityUIElement::stringValue):
1792         (WTR::AccessibilityUIElement::accessibilityValue):
1793         (WTR::AccessibilityUIElement::helpText):
1794         (WTR::AccessibilityUIElement::orientation):
1795         (WTR::AccessibilityUIElement::x):
1796         (WTR::AccessibilityUIElement::y):
1797         (WTR::AccessibilityUIElement::width):
1798         (WTR::AccessibilityUIElement::height):
1799         (WTR::AccessibilityUIElement::intValue):
1800         (WTR::AccessibilityUIElement::minValue):
1801         (WTR::AccessibilityUIElement::maxValue):
1802         (WTR::AccessibilityUIElement::valueDescription):
1803         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1804         (WTR::AccessibilityUIElement::selectedTextRange):
1805         (WTR::AccessibilityUIElement::isEnabled):
1806         (WTR::AccessibilityUIElement::isRequired):
1807         (WTR::AccessibilityUIElement::isFocused):
1808         (WTR::AccessibilityUIElement::isFocusable):
1809         (WTR::AccessibilityUIElement::isSelected):
1810         (WTR::AccessibilityUIElement::isSelectable):
1811         (WTR::AccessibilityUIElement::isMultiSelectable):
1812         (WTR::AccessibilityUIElement::setSelectedChild):
1813         (WTR::AccessibilityUIElement::selectedChildrenCount):
1814         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1815         (WTR::AccessibilityUIElement::isExpanded):
1816         (WTR::AccessibilityUIElement::isChecked):
1817         (WTR::AccessibilityUIElement::isVisible):
1818         (WTR::AccessibilityUIElement::isOffScreen):
1819         (WTR::AccessibilityUIElement::isCollapsed):
1820         (WTR::AccessibilityUIElement::isIgnored):
1821         (WTR::AccessibilityUIElement::hasPopup):
1822         (WTR::AccessibilityUIElement::hierarchicalLevel):
1823         (WTR::AccessibilityUIElement::clickPointX):
1824         (WTR::AccessibilityUIElement::clickPointY):
1825         (WTR::AccessibilityUIElement::documentEncoding):
1826         (WTR::AccessibilityUIElement::documentURI):
1827         (WTR::AccessibilityUIElement::url):
1828         (WTR::AccessibilityUIElement::speak):
1829         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1830         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1831         (WTR::AccessibilityUIElement::attributesOfColumns):
1832         (WTR::AccessibilityUIElement::attributesOfRows):
1833         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1834         (WTR::AccessibilityUIElement::attributesOfHeader):
1835         (WTR::AccessibilityUIElement::indexInTable):
1836         (WTR::AccessibilityUIElement::rowIndexRange):
1837         (WTR::AccessibilityUIElement::columnIndexRange):
1838         (WTR::AccessibilityUIElement::rowCount):
1839         (WTR::AccessibilityUIElement::columnCount):
1840         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1841         (WTR::AccessibilityUIElement::disclosedByRow):
1842         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1843         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1844         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1845         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1846         (WTR::AccessibilityUIElement::ariaDropEffects):
1847         (WTR::AccessibilityUIElement::lineForIndex):
1848         (WTR::AccessibilityUIElement::rangeForLine):
1849         (WTR::AccessibilityUIElement::boundsForRange):
1850         (WTR::AccessibilityUIElement::setSelectedTextRange):
1851         (WTR::AccessibilityUIElement::stringForRange):
1852         (WTR::AccessibilityUIElement::attributedStringForRange):
1853         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1854         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1855         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1856         (WTR::AccessibilityUIElement::horizontalScrollbar):
1857         (WTR::AccessibilityUIElement::verticalScrollbar):
1858         (WTR::AccessibilityUIElement::addNotificationListener):
1859         (WTR::AccessibilityUIElement::removeNotificationListener):
1860         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1861         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1862         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1863         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1864         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1865         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1866         (WTR::AccessibilityUIElement::textMarkerForPoint):
1867         (WTR::AccessibilityUIElement::previousTextMarker):
1868         (WTR::AccessibilityUIElement::nextTextMarker):
1869         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1870         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
1871         (WTR::AccessibilityUIElement::platformUIElement):
1872         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
1873         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
1874         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
1875         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
1876         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1878         (WTR::InjectedBundle::beginTesting):
1879         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1880         (WTR::InjectedBundle::accessibilityController):
1881         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1882         (WTR::InjectedBundlePage::didClearWindowForFrame):
1883         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1884         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
1885         (WTR::LayoutTestController::platformName):
1886         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
1887         (WTR::AccessibilityTextMarker::isEqual):
1888         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
1889         (WTR::AccessibilityTextMarkerRange::isEqual):
1890         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
1891         (+[NSString stringWithJSStringRef:]):
1892         (-[NSString createJSStringRef]):
1893         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1894         (-[AccessibilityNotificationHandler dealloc]):
1895         (-[AccessibilityNotificationHandler _notificationReceived:]):
1896         (-[AccessibilityNotificationHandler setCallback:]):
1897         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1898         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1899         (WTR::AccessibilityUIElement::isEqual):
1900         (WTR::descriptionOfValue):
1901         (WTR::attributesOfElement):
1902         (WTR::concatenateAttributeAndValue):
1903         (WTR::convertNSArrayToVector):
1904         (WTR::descriptionOfElements):
1905         (WTR::AccessibilityUIElement::getLinkedUIElements):
1906         (WTR::AccessibilityUIElement::getDocumentLinks):
1907         (WTR::AccessibilityUIElement::getChildren):
1908         (WTR::AccessibilityUIElement::getChildrenWithRange):
1909         (WTR::AccessibilityUIElement::childrenCount):
1910         (WTR::AccessibilityUIElement::elementAtPoint):
1911         (WTR::AccessibilityUIElement::indexOfChild):
1912         (WTR::AccessibilityUIElement::childAtIndex):
1913         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1914         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1915         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1916         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1917         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1918         (WTR::AccessibilityUIElement::selectedChildrenCount):
1919         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1920         (WTR::AccessibilityUIElement::titleUIElement):
1921         (WTR::AccessibilityUIElement::parentElement):
1922         (WTR::AccessibilityUIElement::disclosedByRow):
1923         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1924         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1925         (WTR::AccessibilityUIElement::attributesOfChildren):
1926         (WTR::AccessibilityUIElement::allAttributes):
1927         (WTR::AccessibilityUIElement::stringAttributeValue):
1928         (WTR::AccessibilityUIElement::numberAttributeValue):
1929         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1930         (WTR::AccessibilityUIElement::boolAttributeValue):
1931         (WTR::AccessibilityUIElement::isAttributeSettable):
1932         (WTR::AccessibilityUIElement::isAttributeSupported):
1933         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1934         (WTR::AccessibilityUIElement::role):
1935         (WTR::AccessibilityUIElement::subrole):
1936         (WTR::AccessibilityUIElement::roleDescription):
1937         (WTR::AccessibilityUIElement::title):
1938         (WTR::AccessibilityUIElement::description):
1939         (WTR::AccessibilityUIElement::orientation):
1940         (WTR::AccessibilityUIElement::stringValue):
1941         (WTR::AccessibilityUIElement::language):
1942         (WTR::AccessibilityUIElement::helpText):
1943         (WTR::AccessibilityUIElement::x):
1944         (WTR::AccessibilityUIElement::y):
1945         (WTR::AccessibilityUIElement::width):
1946         (WTR::AccessibilityUIElement::height):
1947         (WTR::AccessibilityUIElement::clickPointX):
1948         (WTR::AccessibilityUIElement::clickPointY):
1949         (WTR::AccessibilityUIElement::intValue):
1950         (WTR::AccessibilityUIElement::minValue):
1951         (WTR::AccessibilityUIElement::maxValue):
1952         (WTR::AccessibilityUIElement::valueDescription):
1953         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1954         (WTR::AccessibilityUIElement::isActionSupported):
1955         (WTR::AccessibilityUIElement::isEnabled):
1956         (WTR::AccessibilityUIElement::isRequired):
1957         (WTR::AccessibilityUIElement::isFocused):
1958         (WTR::AccessibilityUIElement::isSelected):
1959         (WTR::AccessibilityUIElement::isExpanded):
1960         (WTR::AccessibilityUIElement::isChecked):
1961         (WTR::AccessibilityUIElement::hierarchicalLevel):
1962         (WTR::AccessibilityUIElement::speak):
1963         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1964         (WTR::AccessibilityUIElement::ariaDropEffects):
1965         (WTR::AccessibilityUIElement::lineForIndex):
1966         (WTR::AccessibilityUIElement::rangeForLine):
1967         (WTR::AccessibilityUIElement::boundsForRange):
1968         (WTR::AccessibilityUIElement::stringForRange):
1969         (WTR::AccessibilityUIElement::attributedStringForRange):
1970         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1971         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1972         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1973         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1974         (WTR::AccessibilityUIElement::attributesOfColumns):
1975         (WTR::AccessibilityUIElement::attributesOfRows):
1976         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1977         (WTR::AccessibilityUIElement::attributesOfHeader):
1978         (WTR::AccessibilityUIElement::rowCount):
1979         (WTR::AccessibilityUIElement::columnCount):
1980         (WTR::AccessibilityUIElement::indexInTable):
1981         (WTR::AccessibilityUIElement::rowIndexRange):
1982         (WTR::AccessibilityUIElement::columnIndexRange):
1983         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1984         (WTR::AccessibilityUIElement::horizontalScrollbar):
1985         (WTR::AccessibilityUIElement::verticalScrollbar):
1986         (WTR::AccessibilityUIElement::selectedTextRange):
1987         (WTR::AccessibilityUIElement::setSelectedTextRange):
1988         (WTR::AccessibilityUIElement::increment):
1989         (WTR::AccessibilityUIElement::decrement):
1990         (WTR::AccessibilityUIElement::showMenu):
1991         (WTR::AccessibilityUIElement::press):
1992         (WTR::AccessibilityUIElement::setSelectedChild):
1993         (WTR::AccessibilityUIElement::accessibilityValue):
1994         (WTR::AccessibilityUIElement::documentEncoding):
1995         (WTR::AccessibilityUIElement::documentURI):
1996         (WTR::AccessibilityUIElement::url):
1997         (WTR::AccessibilityUIElement::addNotificationListener):
1998         (WTR::AccessibilityUIElement::removeNotificationListener):
1999         (WTR::AccessibilityUIElement::isFocusable):
2000         (WTR::AccessibilityUIElement::isSelectable):
2001         (WTR::AccessibilityUIElement::isMultiSelectable):
2002         (WTR::AccessibilityUIElement::isVisible):
2003         (WTR::AccessibilityUIElement::isOffScreen):
2004         (WTR::AccessibilityUIElement::isCollapsed):
2005         (WTR::AccessibilityUIElement::isIgnored):
2006         (WTR::AccessibilityUIElement::hasPopup):
2007         (WTR::AccessibilityUIElement::takeFocus):
2008         (WTR::AccessibilityUIElement::takeSelection):
2009         (WTR::AccessibilityUIElement::addSelection):
2010         (WTR::AccessibilityUIElement::removeSelection):
2011         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2012         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2013         (WTR::AccessibilityUIElement::previousTextMarker):
2014         (WTR::AccessibilityUIElement::nextTextMarker):
2015         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2016         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2017         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2018         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2019         (WTR::AccessibilityUIElement::textMarkerForPoint):
2020         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2021         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2022         (WTR::LayoutTestController::platformName):
2023         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2024         (WTR::LayoutTestController::platformName):
2025         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2026         (WTR::LayoutTestController::platformName):
2027         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2028         * WebKitTestRunner/win/InjectedBundle.vcproj:
2029
2030 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2031
2032         [Qt] Fix use of config.tests
2033
2034         We were checking @buildArgs to determine if the optional argument was
2035         passed or not, but this is not the right way to do that in Perl. The
2036         right way is to not use a prototype for the function, and to pass
2037         the list as a reference (to avoid list expansion). That way we can
2038         check the number of arguments, and choose the right code path based
2039         on that.
2040
2041         We were also missing a default-value of 0 for any feature that's not
2042         set in features.prf.
2043
2044         Reviewed by Kenneth Rohde Christiansen.
2045
2046         * Scripts/build-webkit:
2047         * Scripts/webkitdirs.pm:
2048         (qtFeatureDefaults):
2049         (buildQMakeProject):
2050
2051 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2052
2053         [Qt] Prospective fix for broken plugin tests
2054
2055         Don't hide symbols for the NPAPI test plugin
2056
2057         Rubber-stamped by Andreas Kling.
2058
2059         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2060
2061 2011-11-16  Adam Roben  <aroben@apple.com>
2062
2063         Move filenames/line numbers off to the right edge in Leaks Viewer
2064
2065         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
2066         because filenames/line numbers are right next to function names
2067
2068         Reviewed by Andreas Kling.
2069
2070         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
2071         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
2072         function name. Use the filename as the profile node's URL (we don't have enough info to
2073         compute a real URL currently) and the line number as the profile node's line number so the
2074         Inspector code will put them on the right side of the callstack graph.
2075
2076         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2077         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
2078         passed here, just filenames.
2079
2080         (WebInspector.linkifyURLAsNode):
2081         (WebInspector.linkifyResourceAsNode):
2082         Copied and slightly modified from inspector.js.
2083
2084 2011-11-16  Adam Roben  <aroben@apple.com>
2085
2086         Make Leaks Viewer load builds from the new Lion Leaks bot
2087
2088         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
2089
2090         Reviewed by Andreas Kling.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2093         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
2094         SnowLeopard one.
2095
2096 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
2097
2098         [EFL] Clean up the offline apps-related functions in ewk_settings.
2099         https://bugs.webkit.org/show_bug.cgi?id=72132
2100
2101         Reviewed by Kenneth Rohde Christiansen.
2102
2103         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
2104         prefixes for code that is related only to the HTML5 app cache
2105         features.
2106
2107         Use `ewk_settings_application_cache' and
2108         `ewk_view_setting_application_cache' instead.
2109
2110         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2111         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2112
2113 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2114
2115         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2116
2117         Reviewed by Tor Arne Vestbø.
2118
2119         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2120         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
2121         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
2122         removes the .so.0.0.0 and just produces .so.
2123
2124 2011-11-16  Peter Beverloo  <peter@chromium.org>
2125
2126         Explicitly include unistd.h in TestNetscapePlugIn
2127         https://bugs.webkit.org/show_bug.cgi?id=72385
2128
2129         This is needed for the sleep() call in the indicateTestFailure method,
2130         which seems to be implicitly available for other platforms. This is not
2131         the case on Android.
2132
2133         Reviewed by Steve Block.
2134
2135         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2136
2137 2011-11-16  Peter Beverloo  <peter@chromium.org>
2138
2139         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
2140         https://bugs.webkit.org/show_bug.cgi?id=72384
2141
2142         Update to Android NDK r7, which was released last Friday. This adds
2143         support for RTTI and the -mimplicit-it gcc flag, which are required to
2144         respectively build ICU and Skia.
2145
2146         Reviewed by Steve Block.
2147
2148         * Scripts/update-webkit-chromium:
2149         * Scripts/webkitdirs.pm:
2150         (buildChromiumMakefile):
2151
2152 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2153
2154         Unreviewed, rolling out r100266.
2155         http://trac.webkit.org/changeset/100266
2156
2157         Broke WTR.
2158
2159         * qmake/mkspecs/features/default_post.prf:
2160
2161 2011-11-16  Eric Seidel  <eric@webkit.org>
2162
2163         check-webkit-style broken by r99773: "Could not determine the port"
2164         https://bugs.webkit.org/show_bug.cgi?id=72275
2165
2166         Reviewed by Adam Barth.
2167
2168         I will continue engaging hacks, until windows improves.
2169
2170         * Scripts/webkitpy/common/host.py:
2171          - Host uses self.executive instead of self._executive like Port does.
2172          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
2173
2174 2011-11-16  Eric Seidel  <eric@webkit.org>
2175
2176         check-webkit-style broken by r99773: "Could not determine the port"
2177         https://bugs.webkit.org/show_bug.cgi?id=72275
2178
2179         Reviewed by Adam Barth.
2180
2181         Engage windows hacks harder.
2182
2183         This is a speculative fix for ChromiumWin.  We're now
2184         creating an SCM object much earlier, so we need to
2185         engage our "awesome" windows hacks earlier.
2186
2187         * Scripts/webkitpy/common/host.py:
2188         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2189
2190 2011-11-15  Darin Adler  <darin@apple.com>
2191
2192         DRT's uiElementAttributeValueCallback function is leaky
2193         https://bugs.webkit.org/show_bug.cgi?id=72453
2194
2195         Reviewed by Dan Bernstein.
2196
2197         * DumpRenderTree/AccessibilityUIElement.cpp:
2198         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
2199
2200 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2201
2202         Implement edit-distance based reviewer recognition algorithm
2203         https://bugs.webkit.org/show_bug.cgi?id=72351
2204
2205         Reviewed by Eric Seidel.
2206
2207         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
2208         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
2209         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
2210         "build fix" to a reviewer's name (e.g. with with edit distance 9).
2211
2212         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
2213         the edit distance is implemented in edit_distance.py.
2214
2215         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
2216         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
2217
2218         * Scripts/webkitpy/common/checkout/changelog.py:
2219         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2220         * Scripts/webkitpy/common/config/committers.py:
2221         * Scripts/webkitpy/common/config/committers_unittest.py:
2222         * Scripts/webkitpy/common/editdistance.py: Added.
2223         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
2224         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2225         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
2226
2227 2011-11-15  Tony Chang  <tony@chromium.org>
2228
2229         Skip a failing webkitpy test on cygwin.
2230
2231         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2232
2233 2011-11-15  Sam Weinig  <sam@webkit.org>
2234
2235         TestWebKitAPI should not put its resources in the root products directory
2236         https://bugs.webkit.org/show_bug.cgi?id=72446
2237
2238         Reviewed by Anders Carlsson.
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
2242         directory.
2243
2244         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2245         (TEST_F):
2246         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2247         (TestWebKitAPI::TEST):
2248         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2249         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2250         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2251         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
2252         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2253         (TestWebKitAPI::Util::createURLForResource):
2254         Update calls to retrieve files from the bundle to look in the newly
2255         created subdirectory.
2256
2257 2011-11-15  Tony Chang  <tony@chromium.org>
2258
2259         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
2260
2261         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2262
2263 2011-11-15  Tony Chang  <tony@chromium.org>
2264
2265         Unreviewed, fix test-webkitpy tests.  Move the check for image results
2266         earlier.
2267
2268         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2269         * Scripts/webkitpy/layout_tests/port/webkit.py:
2270
2271 2011-11-15  James Robinson  <jamesr@chromium.org>
2272
2273         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
2274         https://bugs.webkit.org/show_bug.cgi?id=72444
2275
2276         Reviewed by Adam Barth.
2277
2278         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2279
2280 2011-11-15  Tony Chang  <tony@chromium.org>
2281
2282         Unreviewed, better fix for ref tests failures on SL Intel bot.
2283         Revert the previous change and return None if pixel results from
2284         either the test page or the expected page is missing.
2285
2286         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2287         * Scripts/webkitpy/layout_tests/port/webkit.py:
2288
2289 2011-11-15  James Robinson  <jamesr@chromium.org>
2290
2291         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
2292         https://bugs.webkit.org/show_bug.cgi?id=72402
2293
2294         Reviewed by Dirk Pranke.
2295
2296         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
2297         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
2298         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
2299         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
2300         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
2301         compositing enabled.
2302
2303         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
2304         patch should not impact any tests.
2305
2306         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2307         (main):
2308         * DumpRenderTree/chromium/TestShell.cpp:
2309         (TestShell::TestShell):
2310         (TestShell::resetWebSettings):
2311         * DumpRenderTree/chromium/TestShell.h:
2312         (TestShell::setAcceleratedCompositingForVideoEnabled):
2313         * DumpRenderTree/chromium/WebPreferences.cpp:
2314         (WebPreferences::reset):
2315         (WebPreferences::applyTo):
2316         * DumpRenderTree/chromium/WebPreferences.h:
2317         * Scripts/webkitpy/layout_tests/port/chromium.py:
2318         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2319         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2320
2321 2011-11-15  Tony Chang  <tony@chromium.org>
2322
2323         Unreviewed, try to fix ref tests failures on SL Intel bot.
2324         It looks like ImageDiff isn't returning an image diff.
2325
2326         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2327
2328 2011-11-15  Tony Chang  <tony@chromium.org>
2329
2330         Unreviewed fix of ref-tests on GTK+.
2331         If a driver is never started, _xvfb_process is never set.
2332
2333         * Scripts/webkitpy/layout_tests/port/gtk.py:
2334
2335 2011-11-14  Tony Chang  <tony@chromium.org>
2336
2337         [NRWT] Reftests should run even when pixel tests are disabled.
2338         https://bugs.webkit.org/show_bug.cgi?id=60605
2339
2340         Reviewed by Dirk Pranke.
2341
2342         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
2343             Also add an assert to make sure we get image hashes back when running ref tests.
2344         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
2345         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2346         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
2347         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
2348             of starting a pixel driver if needed.  It handles the logic of sending the test
2349             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
2350         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2351         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
2352         * Scripts/webkitpy/layout_tests/port/webkit.py:
2353         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
2354         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
2355
2356 2011-11-15  David Kilzer  <ddkilzer@apple.com>
2357
2358         Don't use File::Slurp for run-leaks unit tests
2359         <http://webkit.org/b/72356>
2360
2361         Reviewed by Daniel Bates.
2362
2363         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
2364         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2365         Extracted common package logic into RunLeaks.pm.  Fixed call to
2366         RunLeaks::parseLeaksOutput().
2367         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
2368         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
2369
2370 2011-11-15  Peter Kasting  <pkasting@google.com>
2371
2372         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
2373         https://bugs.webkit.org/show_bug.cgi?id=72349
2374
2375         Reviewed by Adam Roben.
2376
2377         * Scripts/VCSUtils.pm:
2378         (isSVNDirectory):
2379
2380 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2381
2382         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2383
2384         Reviewed by Tor Arne Vestbø.
2385
2386         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2387         magic here where we handle all TEMPLATE = lib .pro files.
2388
2389 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2390
2391         [Qt] Unreviewed prospective --minimal build fix.
2392
2393         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
2394         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
2395
2396 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2397
2398         [Qt] Unreviewed --minimal build fix.
2399
2400         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
2401         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
2402         to make moc's preprocessor abort.
2403
2404 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2405
2406         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
2407         https://bugs.webkit.org/show_bug.cgi?id=72156
2408
2409         Reviewed by Daniel Bates.
2410
2411         Similar to --makearg and --qmakearg, --cmakearg lets one pass
2412         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
2413
2414         * Scripts/build-webkit:
2415         * Scripts/webkitdirs.pm:
2416         (generateBuildSystemFromCMakeProject):
2417
2418 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2419
2420         Improve ChangeLogEntry's reviewer parsing algorithm part 2
2421         https://bugs.webkit.org/show_bug.cgi?id=72340
2422
2423         Reviewed by Eric Seidel.
2424
2425         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
2426         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
2427
2428         * Scripts/webkitpy/common/checkout/changelog.py:
2429         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2430
2431 2011-11-14  Eric Seidel  <eric@webkit.org>
2432
2433         check-webkit-style broken by r99773: "Could not determine the port"
2434         https://bugs.webkit.org/show_bug.cgi?id=72275
2435
2436         Reviewed by Adam Barth.
2437
2438         The TestExpectationsChecker was using a generic try/except block
2439         which caught all exceptions, so we didn't notice that failing
2440         to pass a Host to PortFactory was causing an exception in port instantiation.
2441         I've factored out the "lookup the port" logic into a separate function
2442         which I've now unittested.  This should fix the bug and prevent
2443         others like it from occuring the the future.
2444
2445         * Scripts/webkitpy/style/checkers/test_expectations.py:
2446         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2447
2448 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2449
2450         Add --css-grid-layout to build-webkit and the build systems
2451         https://bugs.webkit.org/show_bug.cgi?id=72320
2452
2453         Reviewed by Ojan Vafai.
2454
2455         * Scripts/build-webkit:
2456         Added the option.
2457
2458 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2459
2460         Unreviewed, rolling out r100192.
2461         http://trac.webkit.org/changeset/100192
2462         https://bugs.webkit.org/show_bug.cgi?id=72328
2463
2464         Caused infinite tests to fail (Requested by abarth on
2465         #webkit).
2466
2467         * Scripts/webkitpy/layout_tests/port/base.py:
2468         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2469
2470 2011-11-14  Tony Chang  <tony@chromium.org>
2471
2472         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
2473         https://bugs.webkit.org/show_bug.cgi?id=72196
2474
2475         Reviewed by Ojan Vafai.
2476
2477         * Scripts/build-webkit:
2478
2479 2011-11-14  John Yani  <vanuan@gmail.com>
2480
2481         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
2482         Override LOCALE to en_US.
2483
2484         Reviewed by Eric Seidel.
2485
2486         * Scripts/webkitpy/layout_tests/port/base.py:
2487
2488 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2489
2490         [Chromium] build-webkit silently drops the features flags
2491         https://bugs.webkit.org/show_bug.cgi?id=72293
2492
2493         Reviewed by Tony Chang.
2494
2495         Chromium still ignores @features but now we give a warning!
2496
2497         * Scripts/build-webkit: Check if one of the features is different
2498         from the default and print a warning in this case.
2499
2500 2011-11-14  David Kilzer  <ddkilzer@apple.com>
2501
2502         run-leaks does not work on Lion?
2503         <http://webkit.org/b/71059>
2504         <rdar://problem/10428527>
2505
2506         Reviewed by Adam Roben.
2507
2508         The output of leaks(1) changed again in Lion to move the
2509         "leaks Report Version: 2.0" line from the first line of the
2510         output to just above the "Process " lines that run-leaks is
2511         interested in parsing.  This required using a more generic
2512         algorithm to find the start of the "Process " lines.
2513
2514         * Scripts/run-leaks:
2515         (parseLeaksOutput): Make the code to skip headers more generic.
2516         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
2517         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
2518         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
2519
2520 2011-11-14  Lei Zhang  <thestig@chromium.org>
2521
2522         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
2523         https://bugs.webkit.org/show_bug.cgi?id=72088
2524
2525         Reviewed by Tony Chang.
2526
2527         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2528
2529 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
2530
2531         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
2532         https://bugs.webkit.org/show_bug.cgi?id=72147
2533
2534         Reviewed by Adam Barth.
2535
2536         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2537
2538 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2539
2540         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
2541
2542         Reviewed by Simon Hausmann.
2543
2544         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
2545
2546 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2547
2548         [Qt] Disable plugins on X11 for WK2
2549
2550         Reviewed by Kenneth Rohde Christiansen.
2551
2552         Currently plugins are in-process and they crash in the likely case of
2553         a plugin installation that uses Qt 4, which beautifully clashes with the
2554         Qt 5 based QtWebProcess.
2555
2556         * qmake/mkspecs/features/features.prf:
2557
2558 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2559
2560         [Qt] Add support for config tests for Qt 5
2561
2562         This allows us to build and run configure-tests at build
2563         time to determine if a given platform feature is available.
2564
2565         Reviewed by Simon Hausmann.
2566
2567         * Scripts/build-webkit:
2568         * Scripts/webkitdirs.pm:
2569         (qtFeatureDefaults):
2570         * qmake/configure.pro: Added.
2571         * qmake/mkspecs/features/features.prf:
2572         * qmake/sync.profile: Added.
2573
2574 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2575
2576         [Qt] Remove the QStyle dependency in Qt's mobile theme
2577         https://bugs.webkit.org/show_bug.cgi?id=67773
2578
2579         This refactoring splits up RenderThemeQt with two
2580         subclasses, a QStyle-backed one, and a Mobile version
2581         that uses the old mobile theme for now.
2582
2583         QStyle availability is detected at compile time, and
2584         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2585         environment variable.
2586
2587         Reviewed by Simon Hausmann.
2588
2589         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2590         (WTR::activateFonts):
2591         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2592         based on availability of QtWidgets.
2593         * qmake/mkspecs/features/webcore.prf: cleanup.
2594
2595 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2596
2597         Unreviewed, rolling out r100116.
2598         http://trac.webkit.org/changeset/100116
2599
2600         r100104 was rolled out, so no longer needed
2601
2602         * Scripts/run-bindings-tests:
2603
2604 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2605
2606         Unreviewed, rolling out r100104.
2607         http://trac.webkit.org/changeset/100104
2608         https://bugs.webkit.org/show_bug.cgi?id=72247
2609
2610         broke windows builds
2611
2612         * Scripts/check-webkit-style:
2613         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2614         * Scripts/webkitpy/common/checkout/deps.py:
2615         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2616         * Scripts/webkitpy/common/checkout/scm/detection.py:
2617         * Scripts/webkitpy/common/checkout/scm/git.py:
2618         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2619         * Scripts/webkitpy/common/checkout/scm/svn.py:
2620         * Scripts/webkitpy/common/host.py:
2621         * Scripts/webkitpy/common/host_mock.py:
2622         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2623         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2624         * Scripts/webkitpy/layout_tests/port/base.py:
2625         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2626         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2627         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2628         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2629
2630 2011-11-14  Philippe Normand  <pnormand@igalia.com>
2631
2632         Unreviewed, build fix after r100104. run-binding-tests broke.
2633
2634         * Scripts/run-bindings-tests: Explicitely use scm.detection.
2635
2636 2011-11-13  Eric Seidel  <eric@webkit.org>
2637
2638         Add SCMDetector object to make scm detection mockable
2639         https://bugs.webkit.org/show_bug.cgi?id=72247
2640
2641         Reviewed by Adam Barth.
2642
2643         I think SCM detection may eventually be rolled into Checkout,
2644         but this patch at least makes it possible to mock code-paths
2645         which rely on scm detection.
2646         In the process of replacing callers of these free-functions
2647         I found that one of the functions was no longer used,
2648         and that one of the callers could instead just use the SCM
2649         object it already had access to through port.host.scm().
2650         I also discovered that I was not calling Host._initialize_scm()
2651         and thus host.scm() was always returning None!
2652
2653         * Scripts/check-webkit-style:
2654         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2655         * Scripts/webkitpy/common/checkout/deps.py:
2656         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2657         * Scripts/webkitpy/common/checkout/scm/detection.py:
2658         * Scripts/webkitpy/common/checkout/scm/git.py:
2659         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2660         * Scripts/webkitpy/common/checkout/scm/svn.py:
2661         * Scripts/webkitpy/common/host.py:
2662         * Scripts/webkitpy/common/host_mock.py:
2663         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2664         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2665         * Scripts/webkitpy/layout_tests/port/base.py:
2666         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2668         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2669         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2670
2671 2011-11-13  Gavin Peters  <gavinp@chromium.org>
2672
2673         command line control of webcore log channels in chromium DumpRenderTree
2674         https://bugs.webkit.org/show_bug.cgi?id=72126
2675         
2676         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
2677         what chromium takes.
2678
2679         Reviewed by Kent Tamura.
2680
2681         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2682         (main):
2683
2684 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
2685
2686         [Qt] Fix minor config typo in the build tool documentation
2687         https://bugs.webkit.org/show_bug.cgi?id=72194
2688
2689         Reviewed by Andreas Kling.
2690
2691         * qmake/README:
2692
2693 2011-11-11  Stephen Chenney  <schenney@chromium.org>
2694
2695         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
2696         https://bugs.webkit.org/show_bug.cgi?id=49257
2697
2698         Adds the remaining missing layout test functionality for printing.
2699
2700         Reviewed by Darin Fisher.
2701
2702         * DumpRenderTree/chromium/LayoutTestController.cpp:
2703         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
2704         (parsePageNumber): Method to parse JS arguments for a page number
2705         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
2706         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
2707         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
2708         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
2709         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
2710
2711 2011-11-11  Darin Adler  <darin@apple.com>
2712
2713         Remove all releaseRef implementations except for RetainPtr
2714         https://bugs.webkit.org/show_bug.cgi?id=71423
2715
2716         Reviewed by Julien Chaffraix.
2717
2718         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2719         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
2720
2721 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2722
2723         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
2724         https://bugs.webkit.org/show_bug.cgi?id=72090
2725
2726         Reviewed by Eric Seidel.
2727
2728         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
2729         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
2730
2731         yay! r100002.
2732
2733         * Scripts/webkitpy/common/checkout/changelog.py:
2734         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2735
2736 2011-11-11  Tony Chang  <tony@chromium.org>
2737
2738         Remove --force from gclient sync.  The bots seem to have made it past
2739         the update step.
2740
2741         * Scripts/update-webkit:
2742
2743 2011-11-11  Tony Chang  <tony@chromium.org>
2744
2745         Add --force to gclient sync. Once the cq bots cycle, we can remove
2746         this since it slows down the normal sync.
2747
2748         * Scripts/update-webkit:
2749
2750 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
2751
2752         When --force is used, also use --reset
2753         https://bugs.webkit.org/show_bug.cgi?id=72129
2754
2755         Reviewed by Dimitri Glazkov.
2756
2757         * Scripts/update-webkit-chromium:
2758
2759 2011-11-11  Tony Chang  <tony@chromium.org>
2760
2761         allow two chromium drivers to run at the same time in NRWT
2762         https://bugs.webkit.org/show_bug.cgi?id=72067
2763
2764         Reviewed by Dirk Pranke.
2765
2766         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
2767             posix prevents the subprocesses from sharing the same fd for stdin.
2768             Sharing the same fd prevents us from closing the files unless all references
2769             to the fd are closed.
2770         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
2771             to adding a test for this, speed up a test (from 3sec to 0) by fixing
2772             the timeout override. It looks like it regressed in r95875.
2773
2774 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2775
2776         Unreviewed, rolling out r99964.
2777         http://trac.webkit.org/changeset/99964
2778         https://bugs.webkit.org/show_bug.cgi?id=72124
2779
2780         Broke too many Qt tests (Requested by tronical_ on #webkit).
2781
2782         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2783         (WTR::activateFonts):
2784         * qmake/mkspecs/features/features.prf:
2785         * qmake/mkspecs/features/webcore.prf:
2786
2787 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2788
2789         [Qt] Remove the QStyle dependency in Qt's mobile theme
2790         https://bugs.webkit.org/show_bug.cgi?id=67773
2791
2792         This refactoring splits up RenderThemeQt with two
2793         subclasses, a QStyle-backed one, and a Mobile version
2794         that uses the old mobile theme for now.
2795
2796         QStyle availability is detected at compile time, and
2797         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2798         environment variable.
2799
2800         Reviewed by Simon Hausmann.
2801
2802         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2803         (WTR::activateFonts):
2804         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2805         based on availability of QtWidgets.
2806         * qmake/mkspecs/features/webcore.prf: cleanup.
2807
2808 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2809
2810         [Qt] Add missing include to PlatformWebViewQt
2811
2812         Reviewed by Simon Hausmann.
2813
2814         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2815
2816 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2817
2818         [Qt] Fix incremental builds on Windows after buildsystem refactor
2819
2820         The qmake rules to ensure that we run make on the derived sources
2821         before running qmake on the target were inside a unix-scope, which
2822         resulted in flakey builds on Windows.
2823
2824         We now generate a rule on all platforms that ensures that "make qmake"
2825         will always run make on the derived sources. In addition, on platforms
2826         that have GNU make (where "make incremental" does not run "make qmake",
2827         but only "make"), we add a similar rule that ensures that any time the
2828         target makefile is regenerated we first run qmake and make on the derived
2829         sources. This rule relies on GNU make's order-only-prerequisites to
2830         not trigger a qmake-run of the target every time we run make.
2831
2832         https://bugs.webkit.org/show_bug.cgi?id=71778
2833
2834         Reviewed by Simon Hausmann.
2835
2836         * qmake/mkspecs/features/functions.prf:
2837
2838 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2839
2840         [Qt][WK2] Remove QWebNavigationController
2841         https://bugs.webkit.org/show_bug.cgi?id=72113
2842
2843         Reviewed by Andreas Kling.
2844
2845         Adapt to the move of the QWebNavigationController functions/properties to
2846         QQuickWebView.
2847
2848         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2849         * MiniBrowser/qt/qml/BrowserWindow.qml:
2850
2851 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2852
2853         [Qt] Build system tweak
2854
2855         Reviewed by Tor Arne Vestbø.
2856
2857         Be a good qmake citizen, return true from our linkStaticLibrary
2858         "test" function.
2859
2860         * qmake/mkspecs/features/functions.prf:
2861
2862 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2863
2864         [Qt] Add support for QT += webkit-private
2865
2866         Reviewed by Tor Arne Vestbø.
2867
2868         * qmake/qt_webkit.pri: Declare private headers.
2869
2870 2011-11-11  Philippe Normand  <pnormand@igalia.com>
2871
2872         Unreviewed, build fix attempt after r99907. Since that revision
2873         GTK layout tests were not running at all...
2874
2875         * Scripts/webkitpy/layout_tests/port/gtk.py:
2876
2877 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
2878
2879         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
2880         https://bugs.webkit.org/show_bug.cgi?id=72001
2881
2882         Reviewed by Dirk Pranke.
2883
2884         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2885
2886 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
2887
2888         bencher script should support remote benchmarking
2889         https://bugs.webkit.org/show_bug.cgi?id=71618
2890
2891         Rubber-stamped by Geoff Garen.
2892         
2893         Added the following features:
2894         
2895         - Benchmark report tells you the hostname and machine model (according to
2896           'sysctl hw.model') of the machine you did the run on, and svn revision number
2897           (according to 'svn info') of the VMs you're testing.
2898         
2899         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2900           acceptable, in addition to just host, in which case your username is used)
2901           and it automatically packages the build directories of the VMs you're testing,
2902           sends them to the remote machine along with your copy of the bencher script
2903           and all of the options you passed.  This pretty much seamlessly allows you
2904           to run a set of benchmarks on any machine that is sufficiently compatible with
2905           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2906           must now include a tempPath setting that tells bencher where to put files
2907           when that machine is used as a slave in a remote benchmarking run.
2908           
2909         - Added yet another way of specifying which benchmarks to run. This was sort of
2910           necessary for --remote to work as expected. Previously, you either said what
2911           suites to exclude (for example --exclude-sunspider) or that you only wanted
2912           to run one suite to the exclusion of others (--sunspider-only). But it's
2913           often better to just be able to specify the list of suites you want. This is
2914           now supported. You can say, for example, --v8 --sunspider, which means, just
2915           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2916           still supported.
2917
2918         * Scripts/bencher:
2919
2920 2011-11-10  Tony Chang  <tony@chromium.org>
2921
2922         Lazily start DRT instances in NRWT
2923         https://bugs.webkit.org/show_bug.cgi?id=72038
2924
2925         Reviewed by Eric Seidel.
2926
2927         Just a refactoring, no new tests.
2928
2929         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2930         * Scripts/webkitpy/layout_tests/port/chromium.py:
2931         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2932         * Scripts/webkitpy/layout_tests/port/test.py:
2933         * Scripts/webkitpy/layout_tests/port/webkit.py:
2934
2935 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2936
2937         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2938         https://bugs.webkit.org/show_bug.cgi?id=72057
2939
2940         Reviewed by Eric Seidel.
2941
2942         Make the regular expression more explicit.
2943
2944         * Scripts/webkitpy/common/checkout/changelog.py:
2945         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2946
2947 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2948
2949         [Qt] X11 plugins need to be reworked for Qt5
2950         https://bugs.webkit.org/show_bug.cgi?id=70023
2951
2952         Reviewed by Simon Hausmann.
2953
2954         Rework our basic plugin support in a way that does
2955         not need a bridge between Qt and X. The solution is
2956         based on getting the content drawed by the plugin
2957         from the server as an image and creating a QImage
2958         from it.
2959
2960         * qmake/mkspecs/features/features.prf: Enable X11
2961         plugins if Qt is built with the xcb-xlib backend.
2962
2963 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2964
2965         [Qt] Fix keyboard related layout tests after API refactoring
2966
2967         Reviewed by Tor Arne Vestbø.
2968
2969         Send key events to the handling page item, not the view.
2970
2971         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2972         (WTR::PlatformWebView::sendEvent):
2973         (WTR::PlatformWebView::postEvent):
2974
2975 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2976
2977         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2978         https://bugs.webkit.org/show_bug.cgi?id=71940
2979
2980         Reviewed by Philippe Normand.
2981
2982         * GNUmakefile.am:
2983         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2984         ENABLE_* variables are part of the environment.
2985
2986 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2987
2988         [Qt] Fix focus related layout tests after API refactoring
2989
2990         Reviewed by Tor Arne Vestbø.
2991
2992         Make sure the focus is set on the page now, not on the view
2993         (which doesn't actually handle the focus).
2994
2995         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2996         (WTR::WrapperWindow::WrapperWindow):
2997         (WTR::WrapperWindow::handleStatusChanged):
2998
2999 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
3000
3001         [Qt] Merge QTouchWebView and QDesktopWebView into one class
3002         https://bugs.webkit.org/show_bug.cgi?id=71355
3003
3004         Reviewed by Kenneth Rohde Christiansen.
3005
3006         Make MiniBrowser and WebKitTestRunner work again after the
3007         merge.
3008
3009         * MiniBrowser/qt/BrowserWindow.cpp:
3010         (BrowserWindow::BrowserWindow):
3011         (BrowserWindow::webView):
3012         * MiniBrowser/qt/MiniBrowser.pro:
3013         * MiniBrowser/qt/MiniBrowser.qrc:
3014         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3015         * MiniBrowser/qt/main.cpp:
3016         * MiniBrowser/qt/qml/BrowserWindow.qml:
3017         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
3018         * MiniBrowser/qt/qml/TouchView.qml: Removed.
3019         * WebKitTestRunner/PlatformWebView.h:
3020         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3021         (WTR::PlatformWebView::PlatformWebView):
3022
3023 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3024
3025         [Qt] Change semantics of the haveQt() function to match API promises
3026
3027         Having Qt 5 does not imply that we have Qt 4, from an API point of
3028         view, as a major version can in theory break BC/SC. Our minimum
3029         version of Qt 4 will always be the latest released version of Qt 4,
3030         so the only place we should use haveQt(4, x) is when checking for
3031         the minimum requirements.
3032
3033         Reviewed by Simon Hausmann.
3034
3035         * qmake/mkspecs/features/default_pre.prf:
3036         * qmake/mkspecs/features/features.prf:
3037         * qmake/mkspecs/features/functions.prf:
3038
3039 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
3040
3041         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
3042         https://bugs.webkit.org/show_bug.cgi?id=69411
3043
3044         Reviewed by Martin Robinson.
3045
3046         * WebKitTestRunner/EventSenderProxy.h:
3047         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3048         * WebKitTestRunner/TestController.cpp:
3049         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3050         use the EventSender instead of WebProcess Event Simulation.
3051         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3052         (WTR::WTREventQueueItem::WTREventQueueItem):
3053         (WTR::EventSenderProxy::EventSenderProxy):
3054         (WTR::getMouseButtonModifiers):
3055         (WTR::eventSenderButtonToGDKButton):
3056         (WTR::EventSenderProxy::createMouseButtonEvent):
3057         (WTR::EventSenderProxy::updateClickCountForButton):
3058         (WTR::EventSenderProxy::replaySavedEvents):
3059         (WTR::EventSenderProxy::sendOrQueueEvent):
3060         (WTR::webkitModifiersToGDKModifiers):
3061         (WTR::getGDKKeySymForKeyRef):
3062         (WTR::EventSenderProxy::keyDown):
3063         (WTR::EventSenderProxy::mouseDown):
3064         (WTR::EventSenderProxy::mouseUp):
3065         (WTR::EventSenderProxy::mouseMoveTo):
3066         (WTR::EventSenderProxy::mouseScrollBy):
3067         (WTR::EventSenderProxy::leapForward):
3068
3069 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3070
3071         [Qt] Enable exports and constructor functions in static libs
3072
3073         Reviewed by Tor Arne Vestbø.
3074
3075         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3076         mac/win32-msvc equivalents when linking static libraries into a shared
3077         library or executable.
3078
3079 2011-11-09  Hayato Ito  <hayato@chromium.org>
3080
3081         [NRWT] Make results.html aware of reference filename in reftests.
3082         https://bugs.webkit.org/show_bug.cgi?id=71574
3083
3084         Reviewed by Ryosuke Niwa.
3085
3086         If a reference filename is different from the default one, include that in result summary
3087         so results.html can link to the correct reference file.
3088
3089         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3090         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3091
3092 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3093
3094         [wx] Unreviewed build fix. Update project files and
3095         add LTC stubs for new methods.
3096
3097         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3098         (LayoutTestController::addChromeInputField):
3099         (LayoutTestController::removeChromeInputField):
3100         (LayoutTestController::focusWebView):
3101         (LayoutTestController::setBackingScaleFactor):
3102         * waf/build/settings.py:
3103
3104 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3105
3106         [wx] Unreviewed build fix. Support XCode 4 when building deps.
3107
3108         * wx/install-unix-extras:
3109
3110 2011-11-09  Eric Seidel  <eric@webkit.org>
3111
3112         Remove the concept of platform-dependent unittests
3113         https://bugs.webkit.org/show_bug.cgi?id=71963
3114
3115         Unreviewed.  Fix test-webkitpy on cygwin.
3116
3117         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3118
3119 2011-11-09  Dana Jansens  <danakj@chromium.org>
3120
3121         Add cc-bugs group to watch changes in chromium graphics
3122         https://bugs.webkit.org/show_bug.cgi?id=71690
3123
3124         Reviewed by David Levin.
3125
3126         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
3127         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
3128         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
3129         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
3130
3131 2011-11-09  Eric Seidel  <eric@webkit.org>
3132
3133         Remove more platform-dependent unittests
3134         https://bugs.webkit.org/show_bug.cgi?id=71971
3135
3136         Reviewed by Adam Barth.
3137
3138         Tests which only run on a couple platforms will break.
3139         All tests should run on all platforms where possible.
3140
3141         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3142         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3143         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3144         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3145
3146 2011-11-09  Ojan Vafai  <ojan@chromium.org>
3147
3148         Merge in results to the test results server even if build numbers conflict
3149         https://bugs.webkit.org/show_bug.cgi?id=71967
3150
3151         Reviewed by Tony Chang.
3152
3153         This was initially meant to be a sanity check that we don't
3154         enter duplicate runs, but it turns out that we can reasonably get
3155         in these situations when a builder is clobbered (e.g. the build
3156         numbers start over again from 0).
3157
3158         * TestResultServer/model/jsonresults.py:
3159         * TestResultServer/model/jsonresults_unittest.py:
3160
3161 2011-11-09  Eric Seidel  <eric@webkit.org>
3162
3163         Remove the concept of platform-dependent unittests
3164         https://bugs.webkit.org/show_bug.cgi?id=71963
3165
3166         Reviewed by Adam Barth.
3167
3168         These have been the source of never-ending sadness.
3169         We'd change behavior and forget to update results in
3170         some unittests because they were only run on certain platforms.
3171         This change removes a large source of these platform-dependent
3172         unittests, which was caused by the port_maker stuff.
3173
3174         It's possible that this change will break test-webkitpy
3175         on some platforms, but that will be a one-time cost.
3176         I will fix the breakage by removing the platform-dependantness
3177         of any such broken tests.
3178
3179         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3180         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3181         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3182         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3183         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3184         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3185         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3186         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3187         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3188         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3189         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3190         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3191         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3192
3193 2011-11-09  Eric Seidel  <eric@webkit.org>
3194
3195         Make the Port object have a Host
3196         https://bugs.webkit.org/show_bug.cgi?id=71961
3197
3198         Reviewed by Adam Barth.
3199
3200         This has been a long time coming.
3201         Now that Port has a Host object, it's very easy
3202         to write unittests which use a properly mocked Port.
3203         Soon we will remove the executive, filesystem and user
3204         members of Port and get everything through the Host.
3205
3206         Note how in many callsites we're actually removing
3207         explicit mocks, since we're now always going to get the
3208         correct Executive/User/FileSystem from the
3209         Host and callsites don't need to be careful to pass each one.
3210
3211         This is prep-work for adding a new Environment member to
3212         Host and needing to be able to access the Environment
3213         member from Port functions w/o needing to pass an Environment
3214         object (or appropriate Mock) every place we create a Port object.
3215         Now that we have a single Host object to reach out through, its
3216         simple to add additional functionality (like Environment) while
3217         keeping our unittests properly mocked.
3218
3219         * Scripts/webkitpy/common/host.py:
3220         * Scripts/webkitpy/common/net/credentials_unittest.py:
3221         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3222         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3223         * Scripts/webkitpy/layout_tests/port/apple.py:
3224         * Scripts/webkitpy/layout_tests/port/base.py:
3225         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3226         * Scripts/webkitpy/layout_tests/port/chromium.py:
3227         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3228         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3229         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3230         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3231         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3232         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3233         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3234         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3235         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3236         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3237         * Scripts/webkitpy/layout_tests/port/efl.py:
3238         * Scripts/webkitpy/layout_tests/port/factory.py:
3239         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3240         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3241         * Scripts/webkitpy/layout_tests/port/gtk.py:
3242         * Scripts/webkitpy/layout_tests/port/mac.py:
3243         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3244         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3245         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3246         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3247         * Scripts/webkitpy/layout_tests/port/qt.py:
3248         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3249         * Scripts/webkitpy/layout_tests/port/test.py:
3250         * Scripts/webkitpy/layout_tests/port/webkit.py:
3251         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3252         * Scripts/webkitpy/layout_tests/port/win.py:
3253         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3254         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3255         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3256         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3257         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3258
3259 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
3260
3261         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
3262         https://bugs.webkit.org/show_bug.cgi?id=71561
3263
3264         Reviewed by Dimitri Glazkov.
3265
3266         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3267         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3268
3269 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
3270
3271         Implement dumpProgressFinishedCallback() for Mac layoutTestController
3272         https://bugs.webkit.org/show_bug.cgi?id=66772
3273
3274         Reviewed by Simon Fraser.
3275
3276         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
3277         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
3278
3279         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
3280         in the FrameLoadDelegate and print the output in response to the notification.
3281
3282         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3283         (-[FrameLoadDelegate init]):
3284         (-[FrameLoadDelegate dealloc]):
3285         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
3286
3287 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3288
3289         [GTK][DRT] window internals object is not reset after each test
3290         https://bugs.webkit.org/show_bug.cgi?id=71890
3291
3292         Reviewed by Martin Robinson.
3293
3294         Call WebCoreTestSupport::resetInternalsObject without going
3295         through DumpRenderTreeSupport.
3296
3297         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3298         (runTest):
3299
3300 2011-11-09  Beth Dakin  <bdakin@apple.com>
3301
3302         Build fix.
3303
3304         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3305         (AccessibilityUIElement::uiElementAttributeValue):
3306
3307 2011-11-09  Beth Dakin  <bdakin@apple.com>
3308
3309         Speculative build fix.
3310
3311         * DumpRenderTree/AccessibilityUIElement.h:
3312
3313 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
3314
3315         Unreviewed build fix.
3316
3317         * DumpRenderTree/AccessibilityUIElement.cpp:
3318         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3319         A bad merge added this check that is making the bots sad.
3320
3321 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
3322
3323         AX: crash when accessing selectedTab in a tab list
3324         https://bugs.webkit.org/show_bug.cgi?id=70938
3325
3326         Reviewed by Beth Dakin.
3327
3328         Add the ability to retrieve an element through an arbitrary attribute.
3329
3330         * DumpRenderTree/AccessibilityUIElement.cpp:
3331         (uiElementAttributeValueCallback):
3332         (AccessibilityUIElement::uiElementAttributeValue):
3333         (AccessibilityUIElement::getJSClass):
3334         * DumpRenderTree/AccessibilityUIElement.h:
3335         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3336         (AccessibilityUIElement::uiElementAttributeValue):
3337
3338 2011-11-09  Andy Wingo  <wingo@igalia.com>
3339
3340         Add webkitdirs.pm:getArchitecture implementation for GTK
3341         https://bugs.webkit.org/show_bug.cgi?id=71370
3342
3343         Reviewed by Xan Lopez.
3344
3345         * Scripts/webkitdirs.pm (determineArchitecture): Add an
3346         implementation for ports using autotools, so that a vanilla
3347         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
3348         to build-jsc on x86-64 machines.
3349
3350 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3351
3352         Unreviewed, rolling out r99707.
3353         http://trac.webkit.org/changeset/99707
3354
3355         Re-enable until we can disable it together with tests in one
3356         shot.
3357
3358         * qmake/mkspecs/features/features.prf:
3359
3360 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3361
3362         [Qt] Disable use of QtUiTools if the library/module is not found
3363
3364         We rely on the lookup order of prf files to inject our own uitools.prf
3365         that will verify that QtUiTools is in fact present before allowing the
3366         CONFIG += uitools to have any effect.
3367
3368         Reviewed by Simon Hausmann.
3369
3370         * DumpRenderTree/qt/DumpRenderTree.pro:
3371         * QtTestBrowser/QtTestBrowser.pro:
3372         * qmake/mkspecs/features/uitools.prf: Added.
3373
3374 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3375
3376         Unreviewed, rolling out r99701.
3377         http://trac.webkit.org/changeset/99701
3378
3379         Breaks Qt mac build
3380
3381         * qmake/mkspecs/features/functions.prf:
3382
3383 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3384
3385         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
3386
3387         Reviewed by Tor Arne Vestbø.
3388
3389         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
3390         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
3391         is not up to the task of full XSLT support, so we should disable it.
3392
3393 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3394
3395         [Qt] Enable exports and constructor functions in static libs
3396
3397         Reviewed by Tor Arne Vestbø.
3398
3399         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3400         mac/win32-msvc equivalents when linking static libraries into a shared
3401         library or executable.
3402
3403 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3404
3405         [GTK][DRT] window internals object is not reset after each test
3406         https://bugs.webkit.org/show_bug.cgi?id=71890
3407
3408         Reviewed by Xan Lopez.
3409
3410         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3411         (runTest): reset the Internals object after each test.
3412
3413 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3414
3415         [Qt] Detect presence of QtUiTools and enable it only when available
3416
3417         The disable_uitools option was a workaround for missing detection.
3418
3419         Reviewed by Simon Hausmann.
3420
3421         * QtTestBrowser/QtTestBrowser.pro:
3422         * qmake/mkspecs/features/default_post.prf:
3423         * qmake/mkspecs/features/default_pre.prf:
3424
3425 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3426
3427         [Qt] Don't override config for the build_pass of debug_and_release
3428
3429         Qmake will parse the profile once for each configuration (debug and
3430         release), with the build_pass option set. In that situation we don't
3431         want to override what qmake is setting explicitly, otherwise the
3432         debug-step will end up hitting all the release-scopes.
3433
3434         Reviewed by Simon Hausmann.
3435
3436         * qmake/mkspecs/features/default_pre.prf:
3437
3438 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3439
3440         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
3441
3442         * qmake/mkspecs/features/functions.prf:
3443
3444 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3445
3446         [Qt] Centralize duplicated code for linking the static libs
3447
3448         Reviewed by Tor Arne Vestbø.
3449
3450         * qmake/mkspecs/features/functions.prf:
3451         * qmake/mkspecs/features/javascriptcore.prf:
3452         * qmake/mkspecs/features/webcore.prf:
3453         * qmake/mkspecs/features/webkit2.prf:
3454
3455 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3456
3457         [Qt] Build system cleanup
3458         https://bugs.webkit.org/show_bug.cgi?id=71815
3459
3460         Reviewed by Kenneth Rohde Christiansen.
3461
3462         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
3463         static library.
3464         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
3465         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
3466
3467 2011-11-08  Hayato Ito  <hayato@chromium.org>
3468
3469         [NRWT] Make single_test_runner aware of reference filename of test_input.
3470         https://bugs.webkit.org/show_bug.cgi?id=71567
3471
3472         Reviewed by Ryosuke Niwa.
3473
3474         Make single_test_runner honor a reference filename of given test_input so that
3475         we can use any file as reference html, instead of depending on implicit naming convention.
3476         The typical use case is to support w3c reftests.
3477
3478         No tests since no functional changes until there is a client.
3479         Test should be easily written with future clients.
3480
3481         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3482         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3483         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3484         * Scripts/webkitpy/layout_tests/models/test_input.py:
3485
3486 2011-11-08  Lucas Forschler  <lforschler@apple.com>
3487
3488         https://bugs.webkit.org/show_bug.cgi?id=71839
3489         Update the leaks bot OS to Lion.
3490         Update the config.json to reflect the update.
3491
3492         Reviewed by Stephanie Lewis.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/config.json:
3495
3496 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3497
3498         Unreviewed, rolling out r99626.
3499         http://trac.webkit.org/changeset/99626
3500         https://bugs.webkit.org/show_bug.cgi?id=71866
3501
3502         "C++ exceptions cannot be disabled without influencing the
3503         Objective-C exceptions" (Requested by benjaminp on #webkit).
3504
3505         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3506
3507 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
3508
3509         [Mac] Disable C++ exceptions from DumpRenderTree
3510         https://bugs.webkit.org/show_bug.cgi?id=71834
3511
3512         Reviewed by Darin Adler.
3513
3514         DumpRenderTree Mac does not handle C++ exceptions. When such exception
3515         happens, it tends to cause the AutoReleasePool stack to be corrupted,
3516         which leads to crashes long after the exception was raised.
3517
3518         This patch disabled C++ exceptions in order to catch the problems where
3519         they happen when a C++ exception is raised.
3520
3521         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3522
3523 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
3524
3525         Moved myself to the reviewer list (yay!).
3526
3527         * Scripts/webkitpy/common/config/committers.py:
3528
3529 2011-11-08  Zeno Albisser  <zeno@webkit.org>
3530
3531         Added myself as a committer.
3532
3533         * Scripts/webkitpy/common/config/committers.py:
3534
3535 2011-11-08  Andy Wingo  <wingo@igalia.com>
3536
3537         Skip some ECMAScript tests that fail on Linux in some time zones.
3538         https://bugs.webkit.org/show_bug.cgi?id=71371
3539
3540         Reviewed by Martin Robinson.
3541
3542         * Scripts/run-javascriptcore-tests: Skip some more tests.
3543
3544 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
3545
3546         [Qt] Unreviewed trivial fix after build system refactoring.
3547
3548         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
3549
3550 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3551
3552         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
3553
3554         If a pro file needs to access the OBJECTS_DIR it should use the
3555         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
3556         after defaults_post has been processed.
3557
3558         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
3559         the command line will override whatever we set in defaults_pre.
3560
3561         Reviewed by Simon Hausmann.
3562
3563         * qmake/mkspecs/features/default_post.prf:
3564         * qmake/mkspecs/features/default_pre.prf:
3565
3566 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3567
3568         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
3569
3570         Reviewed by Simon Hausmann.
3571
3572         * qmake/mkspecs/features/default_post.prf:
3573
3574 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
3575
3576         [Qt][WK2] MiniBrowser should use urlFromUserInput()
3577         https://bugs.webkit.org/show_bug.cgi?id=71680
3578
3579         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
3580         complete urls in MiniBrowser.
3581
3582         Reviewed by Tor Arne Vestbø.
3583
3584         * MiniBrowser/qt/BrowserWindow.cpp:
3585         (BrowserWindow::BrowserWindow):
3586         (BrowserWindow::load):
3587         * MiniBrowser/qt/qml/BrowserWindow.qml:
3588         * MiniBrowser/qt/utils.cpp:
3589         (Utils::urlFromUserInput):
3590         * MiniBrowser/qt/utils.h:
3591         (Utils::Utils):
3592
3593 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
3594
3595         Added myself as a committer.
3596
3597         * Scripts/webkitpy/common/config/committers.py:
3598
3599 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3600
3601         Unreviewed webkitpy test fix after r99512.
3602
3603         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3604         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
3605
3606 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3607
3608         Added myself as a committer.
3609
3610         * Scripts/webkitpy/common/config/committers.py:
3611
3612 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3613
3614         Unreviewed, rolling out r99470.
3615         http://trac.webkit.org/changeset/99470
3616         https://bugs.webkit.org/show_bug.cgi?id=71740
3617
3618         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
3619
3620         * Scripts/webkitpy/common/config/watchlist:
3621
3622 2011-11-07  Tony Chang  <tony@chromium.org>
3623
3624         [chromium] update flakiness dashboard to reflect current bots
3625
3626         Reviewed by Ojan Vafai.
3627
3628         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
3629             bots and merged linux debug bots into a single bot.
3630         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3631         (setupExpectationsTest):
3632
3633 2011-11-07  Dana Jansens  <danakj@chromium.org>
3634
3635         Add cc-bugs group to watch changes in chromium graphics
3636         https://bugs.webkit.org/show_bug.cgi?id=71690
3637
3638         Reviewed by James Robinson.
3639
3640  &nb