Subclass Benchmark Runner script for WebDriver support
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2
3         Subclass Benchmark Runner script for WebDriver support
4         https://bugs.webkit.org/show_bug.cgi?id=174390
5
6         Reviewed by Dewei Zhu, Stephanie Lewis.
7
8         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
9
10         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
11         (BenchmarkBuilder.__init__):
12         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
13         (BenchmarkRunner.__init__):
14         (BenchmarkRunner._find_plan_file):
15         (BenchmarkRunner._run_one_test.and):
16         (BenchmarkRunner.execute):
17         (BenchmarkRunner._get_result): Deleted.
18         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
19         (parse_args):
20         (start):
21         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
22         (WebDriverBenchmarkRunner):
23         (WebDriverBenchmarkRunner._get_result):
24         (WebDriverBenchmarkRunner._run_one_test):
25         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
26         (WebServerBenchmarkRunner):
27         (WebServerBenchmarkRunner.__init__):
28         (WebServerBenchmarkRunner._get_result):
29         (WebServerBenchmarkRunner._run_one_test):
30
31 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
32
33         Add BenchmarkRunner patches with WebDriver support for each testing plan
34         https://bugs.webkit.org/show_bug.cgi?id=174443
35
36         Reviewed by Dewei Zhu, Stephanie Lewis.
37
38         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
39         (BenchmarkBuilder.__enter__):
40         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
41         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
42         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
43         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
44         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
45         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
46         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
47         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
48         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
49         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
50         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
51         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
52         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
53         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
54         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
55         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
56         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
57         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
58         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
59         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
60         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
61         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
62         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
63         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
64         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
65         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
66         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
67         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
68         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
69         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
70         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
71         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
72         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
73
74 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
75
76         Add functions to autoinstaller needed for Benchmark Runner script
77         https://bugs.webkit.org/show_bug.cgi?id=174331
78
79         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
80
81         Adds autoinstaller functions to install selenium and webdriver binaries
82         which will be used by the browser driver part of Benchmark Runner.
83
84         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
85         (BrowserDriver.restore_env):
86         (BrowserDriver):
87         (BrowserDriver.get_webdriver_binary_path):
88         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
89         (LinuxChromeDriver.launch_driver):
90         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
91         (LinuxFirefoxDriver.launch_driver):
92         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
93         (OSXChromeDriver.launch_driver):
94         (OSXChromeCanaryDriver.launch_driver):
95         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
96         (OSXFirefoxDriver.launch_driver):
97         (OSXFirefoxNightlyDriver.launch_driver):
98         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
99         * Scripts/webkitpy/benchmark_runner/utils.py:
100         (get_driver_binary_path):
101         * Scripts/webkitpy/common/system/autoinstall.py:
102         (AutoInstaller._unzip):
103         * Scripts/webkitpy/thirdparty/__init__.py:
104         (AutoinstallImportHook.find_module):
105         (AutoinstallImportHook._install_selenium):
106         (AutoinstallImportHook):
107         (AutoinstallImportHook._install_chromedriver):
108         (AutoinstallImportHook._install_geckodriver):
109         (AutoinstallImportHook.get_latest_pypi_url):
110         (AutoinstallImportHook.install_binary):
111         (autoinstall_everything):
112         (get_driver_filename):
113         (get_os_info):
114
115 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
116
117         Add WebDriver support in browser driver part of BenchmarkRunner
118         https://bugs.webkit.org/show_bug.cgi?id=174445
119
120         Reviewed by Stephanie Lewis.
121
122         Adds a launch_driver function to each BrowserDriver subclass. This
123         function sets up the arguments for the webdriver and launches the
124         webdriver specific to that browser.
125
126         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
127         (BrowserDriver.launch_webdriver):
128         (BrowserDriver):
129         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
130         (LinuxBrowserDriver.launch_webdriver):
131         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
132         (LinuxChromeDriver.launch_url):
133         (LinuxChromeDriver):
134         (LinuxChromeDriver.launch_driver):
135         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
136         (EpiphanyBrowserDriver.launch_url):
137         (EpiphanyBrowserDriver):
138         (EpiphanyBrowserDriver.launch_driver):
139         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
140         (LinuxFirefoxDriver):
141         (LinuxFirefoxDriver.launch_url):
142         (LinuxFirefoxDriver.launch_driver):
143         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
144         (GTKMiniBrowserDriver.launch_url):
145         (GTKMiniBrowserDriver):
146         (GTKMiniBrowserDriver.launch_driver):
147         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
148         (OSXBrowserDriver._launch_webdriver):
149         (OSXBrowserDriver):
150         (OSXBrowserDriver._screen_size):
151         (OSXBrowserDriver._insert_url):
152         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
153         (OSXChromeDriver):
154         (OSXChromeDriver.launch_url):
155         (OSXChromeDriver.launch_driver):
156         (OSXChromeCanaryDriver):
157         (OSXChromeCanaryDriver.launch_url):
158         (OSXChromeCanaryDriver.launch_driver):
159         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
160         (OSXFirefoxDriver):
161         (OSXFirefoxDriver.launch_url):
162         (OSXFirefoxDriver.launch_driver):
163         (OSXFirefoxNightlyDriver):
164         (OSXFirefoxNightlyDriver.launch_url):
165         (OSXFirefoxNightlyDriver.launch_driver):
166         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
167         (OSXSafariDriver.launch_driver):
168
169 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
170
171         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
172         https://bugs.webkit.org/show_bug.cgi?id=174793
173
174         Reviewed by Tim Horton.
175
176         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
177         down. Without r219765, this test will dereference null and crash.
178
179         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
180         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
181         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
182         (TEST):
183
184 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
185
186         [Win] Implement Authentication dialog in MiniBrowser
187         https://bugs.webkit.org/show_bug.cgi?id=174662
188
189         Reviewed by Alex Christensen.
190
191         * MiniBrowser/win/Common.cpp:
192         (CustomUserAgent):
193         (DisplayAuthDialog):
194         (AuthDialogProc):
195         * MiniBrowser/win/MiniBrowserLib.rc:
196         * MiniBrowser/win/MiniBrowserLibResource.h:
197         * MiniBrowser/win/ResourceLoadDelegate.cpp:
198         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
199
200 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
201
202         Handle case where line_numbers is None instead of an array of line numbers
203         https://bugs.webkit.org/show_bug.cgi?id=174775
204
205         Reviewed by Aakash Jain.
206
207         Added files set line_numbers to None in process_file.
208
209         * Scripts/webkitpy/style/filereader.py:
210         (TextFileReader.process_file): Handle case where line_number is set to None.
211         * Scripts/webkitpy/style/main_unittest.py:
212         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
213
214 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
215
216         [WPE] Add libepoxy to the Jhbuild moduleset
217         https://bugs.webkit.org/show_bug.cgi?id=174711
218
219         Reviewed by Carlos Alberto Lopez Perez.
220
221         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
222
223 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
224
225         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
226         https://bugs.webkit.org/show_bug.cgi?id=174780
227
228         Reviewed by Carlos Garcia Campos.
229
230         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
231         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
232         in case the eglplatform.h header doesn't provide that macro. This replicates
233         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
234
235 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
236
237         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
238         https://bugs.webkit.org/show_bug.cgi?id=174758
239
240         Reviewed by Dan Bernstein.
241
242         Migrate position-information-related unit tests from the PositionInformationTests suite to
243         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
244
245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
246         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
247         (TestWebKitAPI::checkElementTypeAndBoundingRect):
248         (TestWebKitAPI::TEST):
249         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
250         * TestWebKitAPI/cocoa/TestWKWebView.h:
251         * TestWebKitAPI/cocoa/TestWKWebView.mm:
252         (-[TestWKWebView activatedElementAtPosition:]):
253
254 2017-07-22  Chris Dumez  <cdumez@apple.com>
255
256         REGRESSION(r204565): WKObject is broken
257         https://bugs.webkit.org/show_bug.cgi?id=174736
258         <rdar://problem/33246169>
259
260         Reviewed by Dan Bernstein.
261
262         Add API test that used to crash.
263
264         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
265         (TestWebKitAPI::TEST):
266
267 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
268
269         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
270         https://bugs.webkit.org/show_bug.cgi?id=174705
271
272         Reviewed by Mark Lam.
273
274         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
275         (TestWebKitAPI::testThreadGroup):
276         (TestWebKitAPI::TEST):
277
278 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
279
280         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
281         https://bugs.webkit.org/show_bug.cgi?id=174724
282
283         Reviewed by Aakash Jain.
284
285         * Scripts/webkitpy/port/ios_simulator.py:
286         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
287         simulator. Errors here should be treated the same as no simulators found.
288
289 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
290
291         [CMake] Add an option to stop build after generating project files
292         https://bugs.webkit.org/show_bug.cgi?id=174664
293
294         Reviewed by Konstantin Tokarev.
295
296         Add "--generate-project-only" to stop build after generating project files.
297
298         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
299         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
300         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
301         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
302         (isGenerateProjectOnly): ditto
303
304 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
305
306         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
307         https://bugs.webkit.org/show_bug.cgi?id=174501
308
309         Reviewed by Darin Adler.
310
311         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
312         (TestWebKitAPI::TEST):
313
314 2017-07-20  David Quesada  <david_quesada@apple.com>
315
316         Add SPI to notify WKNavigationDelegate about client redirects
317         https://bugs.webkit.org/show_bug.cgi?id=174680
318         rdar://problem/33184886
319
320         Reviewed by Brady Eidson.
321
322         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
323         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
324         (TEST):
325         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
326
327 2017-07-20  Brady Eidson  <beidson@apple.com>
328
329         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
330         https://bugs.webkit.org/show_bug.cgi?id=174685
331
332         Reviewed by Andy Estes.
333
334         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
335         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
336
337 2017-07-20  Brady Eidson  <beidson@apple.com>
338
339         Deprecate WebIconDatabase in WebKitLegacy/mac.
340         https://bugs.webkit.org/show_bug.cgi?id=174607
341
342         Reviewed by Alex Christensen.
343
344         * DumpRenderTree/mac/TestRunnerMac.mm:
345
346 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
347
348         lint-test-expectations should be run during style checking
349         https://bugs.webkit.org/show_bug.cgi?id=173559
350         <rdar://problem/32854941>
351
352         Reviewed by Aakash Jain.
353
354         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
355         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
356         prevents identifying errors on specific lines in a file.
357         * Scripts/webkitpy/style/main_unittest.py:
358         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
359         case where a linter error is in the file modified, but the line modified is not related to
360         the linter error.
361
362 2017-07-20  Brady Eidson  <beidson@apple.com>
363
364         Remove WebIconDatabase from WebKitLegacy/win.
365         https://bugs.webkit.org/show_bug.cgi?id=174608
366
367         Reviewed by Alex Christensen.
368
369         * DumpRenderTree/win/DumpRenderTree.cpp:
370         (main):
371         * DumpRenderTree/win/TestRunnerWin.cpp:
372         (TestRunner::setIconDatabaseEnabled):
373
374 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
375
376         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
377         https://bugs.webkit.org/show_bug.cgi?id=174671
378
379         Reviewed by Carlos Garcia Campos.
380
381         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
382         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
383         priority for this source in order to have it dispatched on the same
384         priority as the other WebKit-controlled GSource objects.
385
386 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
387
388         lint-test-expectations should be run during style checking
389         https://bugs.webkit.org/show_bug.cgi?id=173559
390         <rdar://problem/32854941>
391
392         Reviewed by Daniel Bates.
393
394         Follow up fix addressing style and a few minor bugs.
395
396         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
397         (TestExpectationParser.__init__): Use lambda x: x instead of str
398         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
399         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
400         reduce the calls of _shorten_filename, fix minor bug in appending the current
401         expectation's line number instead of the previous ones, clarify treatment of None
402         in file-to-line-number mapping.
403         (TestExpectations._report_warnings): Collapse call.
404         * Scripts/webkitpy/style/checkers/test_expectations.py:
405         (TestExpectationsChecker.lint_test_expectations):
406         * Scripts/webkitpy/style/filereader.py: Re-write comment.
407         (TextFileReader.process_file): Add comment explaining treatment of None in
408         file-to-line-number mapping.
409         (TextFileReader.delete_file): Collapse call.
410
411 2017-07-19  Chris Dumez  <cdumez@apple.com>
412
413         Unreviewed attempt to fix API test failure after r219663.
414
415         The test was hard-coding an exception string and the string has changed slightly
416         in r219663.
417
418         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
419         (TEST):
420
421 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
422
423         Don't write file URLs to iOS Pasteboard
424         https://bugs.webkit.org/show_bug.cgi?id=174647
425         <rdar://problem/33199730>
426
427         Reviewed by Wenson Hsieh.
428
429         Updating tests to reflect the lack of file URLs for images.
430
431         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
432         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
433         (checkEstimatedSize):
434         (TestWebKitAPI::TEST):
435
436 2017-07-19  Brady Eidson  <beidson@apple.com>
437
438         iBooks sometimes crashes when closing a book.
439         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
440
441         Reviewed by Oliver Hunt.
442
443         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
444         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
445         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
446         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
447         (TestWebKitAPI::TEST):
448
449         Add a "spin the runloop X number of times" utility:
450         * TestWebKitAPI/Utilities.h:
451         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
452         (TestWebKitAPI::Util::spinRunLoop):
453
454 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
455
456         lint-test-expectations should be run during style checking
457         https://bugs.webkit.org/show_bug.cgi?id=173559
458         <rdar://problem/32854941>
459
460         Reviewed by David Kilzer.
461
462         Running the test expectation linter requires reading both files and lines not in the
463         patch because, for example, deletion of a test can cause a lint failure even though
464         no test expectations where modified. This means that the linter will occasionally warn
465         about lines which were not changed in a given patch but whose error is related to a
466         change made in that patch.
467
468         * Scripts/webkitpy/common/system/filesystem_mock.py:
469         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
470         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
471         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
472         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
473         content, description of the error and the name of the associated test.
474         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
475         (TestExpectationParser.__init__): Pass shorten_filename function to
476         TestExpectationsParser to add a deleted file to the related_files dictionary.
477         (TestExpectationParser._check_test_exists): If the test does not exist, add the
478         missing path to the related_files dictionary.
479         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
480         files and line numbers related to this test expectation line. This will allow
481         tracking linter errors in the style checker occurring across multiple files.
482         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
483         lines to related_files dictionary.
484         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
485         (TestExpectations._report_warnings): Construct warning object instead of string
486         when adding to warnings list.
487         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
488         clean-up log.
489         * Scripts/webkitpy/style/checker.py:
490         (ProcessorBase.do_association_check): Add required function for processor classes.
491         (StyleProcessor):
492         (StyleProcessor.do_association_check): Run the TestExpectations linter when
493         checking for errors between associated files.
494         * Scripts/webkitpy/style/checkers/test_expectations.py:
495         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
496         (TestExpectationsChecker):
497         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
498         of modified files, the current working directory and the host, determine if the linter
499         warning is associated with the changes.
500         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
501         style checker.
502         * Scripts/webkitpy/style/filereader.py:
503         (TextFileReader):
504         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
505         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
506         (TextFileReader.process_file): Track both the number of files changed and which lines
507         in those files were changed.
508         (TextFileReader.do_association_check): Run the processor's association check on all
509         modified or deleted files processed by TextFileReader.
510         (TextFileReader.delete_file): Track deleted files in _files dictionary.
511         (TextFileReader.count_delete_only_file): Deleted.
512         * Scripts/webkitpy/style/filereader_unittest.py:
513         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
514         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
515         * Scripts/webkitpy/style/main.py:
516         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
517         explicitly run the association check on the file reader.
518         * Scripts/webkitpy/style/main_unittest.py:
519         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
520         embedded in the style checker.
521         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
522         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
523         construct the TextFileReader object with a StyleProcessor used to run style checks on
524         specific files.
525         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
526         testing the test expectation linter inside the style checker. This host must contain a
527         mock file system with the basic structure of test expectations.
528         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
529         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
530         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
531         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
532         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
533         * Scripts/webkitpy/style/patchreader.py:
534         (PatchReader.check): Specify which file was deleted, run the association check.
535         * Scripts/webkitpy/style/patchreader_unittest.py:
536         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
537         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
538         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
539
540 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
541
542         [WTF] Implement WTF::ThreadGroup
543         https://bugs.webkit.org/show_bug.cgi?id=174081
544
545         Reviewed by Mark Lam.
546
547         Add WTF::ThreadGroup tests.
548
549         * TestWebKitAPI/CMakeLists.txt:
550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
551         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
552         (TestWebKitAPI::testThreadGroup):
553         (TestWebKitAPI::TEST):
554
555 2017-07-18  Andy Estes  <aestes@apple.com>
556
557         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
558         https://bugs.webkit.org/show_bug.cgi?id=174631
559
560         Reviewed by Tim Horton.
561
562         * DumpRenderTree/mac/Configurations/Base.xcconfig:
563         * MiniBrowser/Configurations/Base.xcconfig:
564         * MobileMiniBrowser/Configurations/Base.xcconfig:
565         * TestWebKitAPI/Configurations/Base.xcconfig:
566         * WebKitTestRunner/Configurations/Base.xcconfig:
567
568 2017-07-18  Andy Estes  <aestes@apple.com>
569
570         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
571         https://bugs.webkit.org/show_bug.cgi?id=174631
572
573         Reviewed by Sam Weinig.
574
575         * DumpRenderTree/mac/Configurations/Base.xcconfig:
576         * MiniBrowser/Configurations/Base.xcconfig:
577         * MobileMiniBrowser/Configurations/Base.xcconfig:
578         * TestWebKitAPI/Configurations/Base.xcconfig:
579         * WebKitTestRunner/Configurations/Base.xcconfig:
580
581 2017-07-18  Daniel Bates  <dabates@apple.com>
582
583         lldb: Add type summary for StringView
584         https://bugs.webkit.org/show_bug.cgi?id=174637
585
586         Reviewed by Sam Weinig.
587
588         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
589         StringView object will print output that has the form:
590
591             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
592               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
593               m_length = 2
594               m_is8Bit = true
595               m_underlyingString = 0x0000614000000a90
596             }
597
598         * lldb/lldb_webkit.py:
599         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
600         (WTFStringView_SummaryProvider):
601         (WTFStringViewProvider):
602         (WTFStringViewProvider.__init__):
603         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
604         (WTFStringViewProvider.get_length): Access field StringView.m_length.
605         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
606         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
607
608 2017-07-18  Andy Estes  <aestes@apple.com>
609
610         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
611         https://bugs.webkit.org/show_bug.cgi?id=174631
612
613         Reviewed by Dan Bernstein.
614
615         * DumpRenderTree/mac/Configurations/Base.xcconfig:
616         * MiniBrowser/Configurations/Base.xcconfig:
617         * MobileMiniBrowser/Configurations/Base.xcconfig:
618         * TestWebKitAPI/Configurations/Base.xcconfig:
619         * WebKitTestRunner/Configurations/Base.xcconfig:
620
621 2017-07-18  Devin Rousso  <drousso@apple.com>
622
623         Web Inspector: Add memoryCost to Inspector Protocol objects
624         https://bugs.webkit.org/show_bug.cgi?id=174478
625
626         Reviewed by Joseph Pecoraro.
627
628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
629         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
630         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
631         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
632         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
633         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
634         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
635         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
636         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
637         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
638         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
639         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
640         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
641         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
642         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
643         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
644         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
645
646 2017-07-18  Andy Estes  <aestes@apple.com>
647
648         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
649         https://bugs.webkit.org/show_bug.cgi?id=174631
650
651         Reviewed by Darin Adler.
652
653         * DumpRenderTree/mac/Configurations/Base.xcconfig:
654         * MiniBrowser/Configurations/Base.xcconfig:
655         * MobileMiniBrowser/Configurations/Base.xcconfig:
656         * TestWebKitAPI/Configurations/Base.xcconfig:
657         * WebKitTestRunner/Configurations/Base.xcconfig:
658
659 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
660
661         Unreviewed, fix the iOS build.
662
663         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
664
665         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
666         (TestWebKitAPI::TEST):
667
668 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
669
670         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
671         https://bugs.webkit.org/show_bug.cgi?id=174585
672         <rdar://problem/33302541>
673
674         Reviewed by Tim Horton.
675
676         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
677         being dragged when initiating a drag.
678
679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
680         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
681         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
682         (TestWebKitAPI::TEST):
683         * TestWebKitAPI/cocoa/TestWKWebView.h:
684
685         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
686
687         * TestWebKitAPI/cocoa/TestWKWebView.mm:
688         (-[TestWKWebView synchronouslyLoadHTMLString:]):
689
690 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
691
692         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
693         https://bugs.webkit.org/show_bug.cgi?id=174547
694
695         Reviewed by Alex Christensen.
696
697         * DumpRenderTree/PlatformWin.cmake:
698         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
699
700 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
701
702         Update style checker to deal with "final"
703         https://bugs.webkit.org/show_bug.cgi?id=174528
704
705         Reviewed by Alex Christensen.
706         
707         check-webkit-style shouldn't complain about an open brace to start a
708         line after a function definition with "final" or "const final".
709
710         * Scripts/webkitpy/style/checkers/cpp.py:
711         (check_braces):
712         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
713         (CppStyleTest.test_brace_at_begin_of_line):
714
715 2017-07-17  Alex Christensen  <achristensen@webkit.org>
716
717         Modernize content extension code
718         https://bugs.webkit.org/show_bug.cgi?id=174588
719
720         Reviewed by Sam Weinig.
721
722         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
723         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
724         (TestWebKitAPI::testRequest):
725         (TestWebKitAPI::makeBackend):
726         (TestWebKitAPI::TEST_F):
727
728 2017-07-17  Brady Eidson  <beidson@apple.com>
729
730         WKHTTPCookieStore observing only works on the default cookie store.
731         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
732
733         Reviewed by Sam Weinig.
734
735         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
736         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
737           called for the default store, a non-persistent store, and a custom store.
738         (TEST):
739
740 2017-07-16  Sam Weinig  <sam@webkit.org>
741
742         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
743         https://bugs.webkit.org/show_bug.cgi?id=174575
744
745         Reviewed by Brady Eidson.
746
747         * Scripts/svn-create-patch:
748         (findModificationType):
749         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
750         default value of "unknown".
751
752         (generateFileList):
753         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
754         for untracked, which matches our old behavior.
755
756 2017-07-17  Charlie Turner  <cturner@igalia.com>
757
758         Add some missing build dependencies on Fedora
759         https://bugs.webkit.org/show_bug.cgi?id=174578
760
761         Unreviewed dependency update.
762
763         * gtk/install-dependencies:
764
765 2017-07-16  Brady Eidson  <beidson@apple.com>
766
767         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
768         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
769
770         Reviewed by Tim Horton.
771
772         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
773         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
774         (TEST):
775
776 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
777
778         [GTK] Sort inspector GResource manifest to ensure reproducible builds
779         https://bugs.webkit.org/show_bug.cgi?id=174540
780
781         Reviewed by Michael Catanzaro.
782
783         * gtk/generate-inspector-gresource-manifest.py:
784         (get_filenames): sort list of input files
785
786 2017-07-15  Brady Eidson  <beidson@apple.com>
787
788         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
789         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
790
791         Reviewed by Tim Horton.
792
793         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
794         (TEST): Make this test more reliable by clearing everything beforehand.
795
796 2017-07-15  David Kilzer  <ddkilzer@apple.com>
797
798         Make it possible to extend check-webkit-style with Apple-internal checkers
799         <https://webkit.org/b/174464>
800         <rdar://problem/25564402>
801
802         Reviewed by Darin Adler.
803
804         * Scripts/webkitpy/style/checker.py: Import apple_additions.
805         (_all_categories): Add categories from apple_additions() if it
806         exists.
807         (CheckerDispatcher._create_checker): Create python checker
808         from apple_additions() if it exists.
809
810 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
811
812         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
813         https://bugs.webkit.org/show_bug.cgi?id=174539
814         <rdar://problem/33307395>
815
816         Reviewed by Darin Adler.
817
818         Adds a new unit test suite to cover action sheet popover presentation.
819
820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
821         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
822         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
823         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
824
825         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
826
827         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
828         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
829
830         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
831
832         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
833         (TestWebKitAPI::TEST):
834
835 2017-07-15  Sam Weinig  <sam@webkit.org>
836
837         [Scripts] Make svn-create-patch work better when called in sub directories
838         https://bugs.webkit.org/show_bug.cgi?id=174551
839
840         Reviewed by Darin Adler.
841
842         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
843           by ensuring that the prefix is applied as is done in generateDiff.
844         - Silence output of explanatory lines from svn stat (" > move to ...")
845           that show up in STDERR when running svn-create-patch.
846         - Add verbose logging that I found useful while debugging this issue.
847
848         * Scripts/svn-create-patch:
849         (findBaseUrl):
850         (findMimeType):
851         (findSourceFileAndRevision):
852         (generateDiff):
853         (generateFileList):
854         (manufacturePatchForAdditionWithHistory):
855
856 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
857
858         Unreviewed build fix after r219537.
859
860         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
861
862 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
863
864         Add iOS 11 SPI
865         https://bugs.webkit.org/show_bug.cgi?id=174430
866         <rdar://problem/33269288>
867
868         Reviewed by Tim Horton.
869
870         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
871         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
872         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
873
874 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
875
876         Failing to install on iPad simulators
877         https://bugs.webkit.org/show_bug.cgi?id=174532
878         <rdar://problem/33328347>
879
880         Reviewed by Stephanie Lewis.
881
882         * Scripts/webkitpy/xcode/simulated_device.py:
883         (SimulatedDevice.install_app): Place install command in retry try-except block.
884
885 2017-07-14  Jeff Miller  <jeffm@apple.com>
886
887         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
888         https://bugs.webkit.org/show_bug.cgi?id=174524
889
890         Reviewed by Sam Weinig.
891
892         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
893         (TEST):
894         Renamed TestParameter to TestParameter1.
895         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
896
897         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
898         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
899         Observe changes for two bundle parameters.
900
901         (-[BundleParametersPlugIn dealloc]):
902         Remove observers for two bundle parameters.
903
904 2017-07-14  Commit Queue  <commit-queue@webkit.org>
905
906         Unreviewed, rolling out r219510.
907         https://bugs.webkit.org/show_bug.cgi?id=174525
908
909         Need to revert length() == 0 check for null string (Requested
910         by yusukesuzuki on #webkit).
911
912         Reverted changeset:
913
914         "[WTF] Newly added AtomicStringImpl should use BufferInternal
915         static string if StringImpl is static"
916         https://bugs.webkit.org/show_bug.cgi?id=174501
917         http://trac.webkit.org/changeset/219510
918
919 2017-07-14  Jer Noble  <jer.noble@apple.com>
920
921         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
922         https://bugs.webkit.org/show_bug.cgi?id=174514
923
924         Reviewed by Sam Weinig.
925
926         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
927         (TestWebKitAPI::TEST_F):
928
929 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
930
931         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
932         https://bugs.webkit.org/show_bug.cgi?id=174501
933
934         Reviewed by Darin Adler.
935
936         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
937         (TestWebKitAPI::TEST):
938
939 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
940
941         Bring mac expectations in-line with other platforms
942         https://bugs.webkit.org/show_bug.cgi?id=174472
943         <rdar://problem/33297388>
944
945         Reviewed by David Kilzer.
946
947         The override order for Mac test expectations does not conform to the pattern used by iOS,
948         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
949
950             platform/mac-wk2
951             platform/wk2
952             platform/mac-elcapitan
953             platform/mac-sierra
954             generic
955
956         After this change, El Capitan's baseline search path looks like this:
957
958             platform/mac-sierra-wk2
959             platform/mac-sierra
960             platform/mac-wk2
961             platform/wk2
962             generic
963
964         * Scripts/webkitpy/port/mac.py:
965         (MacPort.__init__): If a specific version is specified in the port name, use that
966         as the os version.
967         (MacPort.default_baseline_search_path): Expectation search paths should work the
968         same way they do on other ports. Port + version overrides port, port overrides generic
969         and wk1/wk2 should override expectations for the two combined.
970         * Scripts/webkitpy/port/mac_unittest.py:
971         (MacTest.test_tests_for_other_platforms): Deleted.
972         (MacTest._assert_search_path): Deleted.
973         (MacTest.test_baseline_search_path): Deleted.
974         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
975         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
976         (test_rebaseline_test_and_print_scm_changes): Ditto.
977         (test_rebaseline_and_copy_test): Ditto.
978         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
979         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
980         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
981
982 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
983
984         Fix style checker unit test
985
986         Unreviewed WebKit2 => WebKit fixup.
987
988         * Scripts/webkitpy/style/checker_unittest.py:
989         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
990
991 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
992
993         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
994
995         Unreviewed build fix.
996
997         r219492 missed one hunk from its partial revert of r219489.
998         This patch reverts that hunk.
999
1000         * TestWebKitAPI/CMakeLists.txt:
1001
1002 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1003
1004         Use the old WebKit/WebKit2 targets for CMake builds.
1005
1006         Unreviewed build fix.
1007
1008         We can update the target names to match the Framework names in a future patch.
1009         This is a partial revert of r219489.
1010
1011         * TestWebKitAPI/CMakeLists.txt:
1012         WebKitLegacy => WebKit
1013         WebKit => WebKit2
1014
1015 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1016
1017         Fix TestWebKit API.
1018         https://bugs.webkit.org/show_bug.cgi?id=174164
1019         rdar://problem/33137595
1020
1021         Reviewed by Dan Bernstein.
1022
1023         * TestWebKitAPI/CMakeLists.txt:
1024         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1025         * TestWebKitAPI/PlatformGTK.cmake:
1026
1027 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1028
1029         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1030         https://bugs.webkit.org/show_bug.cgi?id=174164
1031         rdar://problem/33137595
1032
1033         Reviewed by Dan Bernstein.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1036         (ShouldBuildTest):
1037         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1038         * Scripts/build-webkit:
1039         * Scripts/do-file-rename:
1040         * Scripts/do-webcore-rename:
1041         * Scripts/update-webkit-localizable-strings:
1042         * Scripts/webkitpy/common/config/watchlist:
1043         * Scripts/webkitpy/style/checker.py:
1044         * Scripts/webkitpy/style/checkers/featuredefines.py:
1045         * gtk/make-dist.py:
1046         (ensure_version_if_possible):
1047         * gtk/manifest.txt.in:
1048
1049 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1050
1051         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1052         https://bugs.webkit.org/show_bug.cgi?id=174162
1053         rdar://problem/33137594
1054
1055         Reviewed by Dan Bernstein.
1056
1057         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1058
1059         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1060         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1061         * EWSTools/configure-clang-linux.sh:
1062         * Scripts/build-webkit:
1063         * Scripts/do-file-rename:
1064         * Scripts/do-webcore-rename:
1065         * Scripts/update-webkit-localizable-strings:
1066         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1067         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1068         * Scripts/webkitpy/style/checkers/featuredefines.py:
1069         * gtk/manifest.txt.in:
1070
1071 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1072
1073         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1074         https://bugs.webkit.org/show_bug.cgi?id=174438
1075         <rdar://problem/33277112>
1076
1077         Reviewed by Aakash Jain.
1078
1079         Given a patch, this will convert the changes from the path to the new directory structure.
1080
1081         * Scripts/rebase-patch-after-webkit-move: Added.
1082         (append_source): Append 'Source' to the provided path.
1083         (is_editable_line): Return true if a line the script expects to modify.
1084         (needs_rebase): Return if a line needs to be rebased based on it's content.
1085         (rebase_line): Rebase the provided line.
1086         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1087         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1088         were provided.
1089
1090 2017-07-12  Nan Wang  <n_wang@apple.com>
1091
1092         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1093         https://bugs.webkit.org/show_bug.cgi?id=174393
1094         <rdar://problem/33248006>
1095
1096         Reviewed by Chris Fleizach.
1097
1098         * DumpRenderTree/AccessibilityUIElement.cpp:
1099         (textMarkerRangeMatchesTextNearMarkersCallback):
1100         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1101         (AccessibilityUIElement::getJSClass):
1102         * DumpRenderTree/AccessibilityUIElement.h:
1103         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1104         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1105         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1106         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1107         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1108         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1109         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1110         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1111
1112 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1113
1114         Unreviewed, rolling out r219409.
1115
1116         The revision caused the Windows builds to fail.
1117
1118         Reverted changeset:
1119
1120         "AX: [iOS] Implement a way to retrieve a text marker range
1121         with desired text that is closest to a position"
1122         https://bugs.webkit.org/show_bug.cgi?id=174393
1123         http://trac.webkit.org/changeset/219409
1124
1125 2017-07-12  Nan Wang  <n_wang@apple.com>
1126
1127         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1128         https://bugs.webkit.org/show_bug.cgi?id=174393
1129         <rdar://problem/33248006>
1130
1131         Reviewed by Chris Fleizach.
1132
1133         * DumpRenderTree/AccessibilityUIElement.cpp:
1134         (textMarkerRangeMatchesTextNearMarkersCallback):
1135         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1136         (AccessibilityUIElement::getJSClass):
1137         * DumpRenderTree/AccessibilityUIElement.h:
1138         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1139         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1140         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1141         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1142         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1143         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1144         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1145         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1146
1147 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1148
1149         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1150         https://bugs.webkit.org/show_bug.cgi?id=174197
1151
1152         Reviewed by Darin Adler.
1153
1154         This bit me the first time I tried to submit a patch to WebKit, and still I have
1155         to manually edit the ChangeLog every time I use the script.
1156
1157         This generates a more convenient and standard ChangeLog entry.
1158
1159         * Scripts/prepare-ChangeLog:
1160         (generateNewChangeLogs):
1161
1162 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1163
1164         Unreviewed, rolling out r219401.
1165
1166         This revision rolled out the previous patch, but after talking
1167         with reviewer, a rebaseline is what was needed.Rolling back in
1168         before rebaseline.
1169
1170         Reverted changeset:
1171
1172         "Unreviewed, rolling out r219379."
1173         https://bugs.webkit.org/show_bug.cgi?id=174400
1174         http://trac.webkit.org/changeset/219401
1175
1176 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1177
1178         Unreviewed, rolling out r219379.
1179
1180         This revision caused a consistent failure in the test
1181         fast/dom/Window/property-access-on-cached-window-after-frame-
1182         removed.html.
1183
1184         Reverted changeset:
1185
1186         "Remove NAVIGATOR_HWCONCURRENCY"
1187         https://bugs.webkit.org/show_bug.cgi?id=174400
1188         http://trac.webkit.org/changeset/219379
1189
1190 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1191
1192         [WPE] Use libepoxy
1193         https://bugs.webkit.org/show_bug.cgi?id=172104
1194
1195         Reviewed by Michael Catanzaro.
1196
1197         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1198         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1199
1200 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1201
1202         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1203         https://bugs.webkit.org/show_bug.cgi?id=174363
1204
1205         Reviewed by Michael Catanzaro.
1206
1207         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1208         between the GTK+ and WPE port. There's no reason for the two ports to apply
1209         different patches over same versions of GStreamer releases.
1210
1211         This aligns the two ports on this specific issue. Next we'll look into
1212         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1213         to keep these patches in a single place, avoiding duplicate files.
1214
1215         * gtk/jhbuild.modules:
1216         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1217         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1218         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1219         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1220
1221 2017-07-11  Dean Jackson  <dino@apple.com>
1222
1223         Remove NAVIGATOR_HWCONCURRENCY
1224         https://bugs.webkit.org/show_bug.cgi?id=174400
1225
1226         Reviewed by Sam Weinig.
1227
1228         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1229
1230 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1231
1232         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1233         https://bugs.webkit.org/show_bug.cgi?id=174239
1234
1235         Reviewed by Brady Eidson.
1236
1237         Create windows with specific features set and make sure those are properly reflected in the
1238         WKWindowFeatures object.
1239
1240         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1241         (resetToConsistentState):
1242         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1243         (TEST):
1244
1245 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1246
1247         Do not duplicate files when deleting directories with svn 1.9
1248         https://bugs.webkit.org/show_bug.cgi?id=174339
1249         <rdar://problem/33226781>
1250
1251         Reviewed by David Kilzer.
1252
1253         * Scripts/svn-create-patch:
1254         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1255         (generateFileList): Determine which files are deleted because they are part of a
1256         directory being deleted.
1257
1258 2017-07-11  Dean Jackson  <dino@apple.com>
1259
1260         Rolling out r219372.
1261
1262         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1263
1264 2017-07-11  Dean Jackson  <dino@apple.com>
1265
1266         Remove NAVIGATOR_HWCONCURRENCY
1267         https://bugs.webkit.org/show_bug.cgi?id=174400
1268
1269         Reviewed by Sam Weinig.
1270
1271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1272
1273 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1274
1275         Teach build workers to fetch archives from S3.
1276         https://bugs.webkit.org/show_bug.cgi?id=174384
1277
1278         Reviewed by Aakash Jain.
1279
1280         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1281         (DownloadBuiltProduct):
1282
1283 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1284
1285         Configure buildbot to transfer all archives to S3.
1286         Previously this was Mac only, but it's time to expand!
1287         https://bugs.webkit.org/show_bug.cgi?id=174378
1288         
1289         Reviewed by Aakash Jain.
1290
1291         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1292         (BuildFactory.__init__):
1293
1294 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1295
1296         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1297         https://bugs.webkit.org/show_bug.cgi?id=174350
1298
1299         Reviewed by Xabier Rodriguez-Calvar.
1300
1301         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1302         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1303         patches are removed. The patches for gst-plugins-good are updated, removing
1304         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1305         rtpbin elements that will help with the EMEv3 development.
1306
1307         * wpe/jhbuild.modules:
1308         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1309         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1310         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1311         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1312         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1313         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1314         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1315         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1316         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1317
1318 2017-07-10  John Wilander  <wilander@apple.com>
1319
1320         Resource Load Statistics: Prune statistics in orders of importance
1321         https://bugs.webkit.org/show_bug.cgi?id=174215
1322         <rdar://problem/33164403>
1323
1324         Reviewed by Chris Dumez.
1325
1326         Nest infrastructure. Adds these functions:
1327         1. testRunner.setStatisticsLastSeen()
1328         2. setStatisticsMaxStatisticsEntries()
1329         3. setStatisticsPruneEntriesDownTo()
1330
1331         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1332         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1333         (WTR::TestRunner::setStatisticsLastSeen):
1334         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1335         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1336         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1337         * WebKitTestRunner/TestController.cpp:
1338         (WTR::TestController::setStatisticsLastSeen):
1339         (WTR::TestController::setMaxStatisticsEntries):
1340         (WTR::TestController::setPruneEntriesDownTo):
1341         * WebKitTestRunner/TestController.h:
1342         * WebKitTestRunner/TestInvocation.cpp:
1343         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1344         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1345         (WTR::TestController::setStatisticsLastSeen):
1346         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1347         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1348
1349 2017-07-03  Brian Burg  <bburg@apple.com>
1350
1351         Web Replay: remove some unused code
1352         https://bugs.webkit.org/show_bug.cgi?id=173903
1353
1354         Rubber-stamped by Joseph Pecoraro.
1355
1356         * Scripts/run-input-generator-tests: Removed.
1357         * Scripts/webkitpy/replay/__init__.py: Removed.
1358         * Scripts/webkitpy/replay/main.py: Removed.
1359
1360 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1361
1362         [WPE] Fix layout test baseline and TestExpectations hierarchy
1363         https://bugs.webkit.org/show_bug.cgi?id=174092
1364
1365         Reviewed by Michael Catanzaro.
1366
1367         Like for the GTK+ port, override the default_baseline_search_path() and
1368         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1369         Both methods operate on a short list of search paths that defaults to 'wpe' and
1370         'wk2', along with any other user-specified platform directory.
1371
1372         The test_expectations_file_position() method is overridden for testing purposes,
1373         and relevant unit tests are added.
1374
1375         * Scripts/webkitpy/port/wpe.py:
1376         (WPEPort._search_paths):
1377         (WPEPort):
1378         (WPEPort.default_baseline_search_path):
1379         (WPEPort._port_specific_expectations_files):
1380         (WPEPort.test_expectations_file_position):
1381         * Scripts/webkitpy/port/wpe_unittest.py:
1382         (WPEPortTest.test_default_baseline_search_path):
1383         (WPEPortTest):
1384         (WPEPortTest.test_port_specific_expectations_files):
1385
1386 2017-07-10  Chris Dumez  <cdumez@apple.com>
1387
1388         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1389         https://bugs.webkit.org/show_bug.cgi?id=174301
1390
1391         Reviewed by Brent Fulgham.
1392
1393         Rename some of the testRunner API for clarity and to better match what it calls
1394         internally.
1395
1396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1398         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1399         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1400         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1401         * WebKitTestRunner/TestController.cpp:
1402         (WTR::TestController::statisticsUpdateCookiePartitioning):
1403         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1404         * WebKitTestRunner/TestController.h:
1405         * WebKitTestRunner/TestInvocation.cpp:
1406         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1407         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1408         (WTR::TestController::statisticsUpdateCookiePartitioning):
1409         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1410
1411 2017-07-10  Charlie Turner  <cturner@igalia.com>
1412
1413         [GStreamer] Live twitch.tv videos do not play
1414         https://bugs.webkit.org/show_bug.cgi?id=174222
1415
1416         Reviewed by Michael Catanzaro.
1417
1418         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1419         fixes videos not playing on twitch.tv.
1420
1421         * gtk/jhbuild.modules:
1422
1423 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1424
1425         Add WebGL2 configuration option to build-webkit
1426         https://bugs.webkit.org/show_bug.cgi?id=174251
1427
1428         Reviewed by Michael Catanzaro.
1429
1430         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1431         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1432         is marked as enabled for the Apple Cocoa ports.
1433
1434 2017-07-08  Chris Dumez  <cdumez@apple.com>
1435
1436         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1437         https://bugs.webkit.org/show_bug.cgi?id=174290
1438
1439         Reviewed by Brent Fulgham.
1440
1441         Rename testRunner API to match the new internal API names.
1442
1443         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1444         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1445         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1446         (WTR::TestRunner::statisticsSubmitTelemetry):
1447         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1450         (WTR::TestController::statisticsSubmitTelemetry):
1451         * WebKitTestRunner/TestController.h:
1452         * WebKitTestRunner/TestInvocation.cpp:
1453         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1454         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1455         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1456         (WTR::TestController::statisticsSubmitTelemetry):
1457
1458 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1459
1460         Drop NOSNIFF compile flag
1461         https://bugs.webkit.org/show_bug.cgi?id=174289
1462
1463         Reviewed by Michael Catanzaro.
1464
1465         * Scripts/webkitperl/FeatureList.pm:
1466         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1467
1468 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1469
1470         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1471         https://bugs.webkit.org/show_bug.cgi?id=174219
1472         <rdar://problem/32083177>
1473
1474         Reviewed by Ryosuke Niwa.
1475
1476         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1477         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1478         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1479         place.
1480
1481         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1482         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1483         no action is taken when dropping.
1484
1485         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1486         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1487         (TestWebKitAPI::TEST):
1488         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1489         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1490         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1491         (-[MockDragDropSession allowsMoveOperation]):
1492         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1493         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1494         (-[DataInteractionSimulator initWithWebView:]):
1495         (-[DataInteractionSimulator runFrom:to:]):
1496         (-[DataInteractionSimulator _advanceProgress]):
1497         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1498         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1499         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1500
1501 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1502
1503         Unreviewed, rolling out r219238, r219239, and r219241.
1504         https://bugs.webkit.org/show_bug.cgi?id=174265
1505
1506         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1507         (Requested by yusukesuzuki on #webkit).
1508
1509         Reverted changesets:
1510
1511         "[WTF] Implement WTF::ThreadGroup"
1512         https://bugs.webkit.org/show_bug.cgi?id=174081
1513         http://trac.webkit.org/changeset/219238
1514
1515         "Unreviewed, build fix after r219238"
1516         https://bugs.webkit.org/show_bug.cgi?id=174081
1517         http://trac.webkit.org/changeset/219239
1518
1519         "Unreviewed, CLoop build fix after r219238"
1520         https://bugs.webkit.org/show_bug.cgi?id=174081
1521         http://trac.webkit.org/changeset/219241
1522
1523 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1524
1525         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1526         https://bugs.webkit.org/show_bug.cgi?id=174250
1527
1528         Reviewed by Carlos Alberto Lopez Perez.
1529
1530         * Scripts/webkitperl/FeatureList.pm:
1531
1532 2017-07-07  Charlie Turner  <cturner@igalia.com>
1533         [GStreamer] vid.me videos do not play
1534         https://bugs.webkit.org/show_bug.cgi?id=172240
1535
1536         Reviewed by Xabier Rodriguez-Calvar.
1537
1538         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1539         have the existing libsoup build against GNOME to avoid header drift
1540         against GStreamer's linked Soup library.
1541
1542         * gtk/jhbuild.modules:
1543
1544 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1545
1546         Write a support script to enable buildbot to upload to S3
1547         https://bugs.webkit.org/show_bug.cgi?id=174196
1548         
1549         Reviewed by Stephanie Lewis.
1550
1551         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1552         (uploadToS3):
1553         (archiveExists):
1554
1555 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1556
1557         Enabling uploading archives to S3.
1558         https://bugs.webkit.org/show_bug.cgi?id=174198
1559         
1560         Reviewed by Stephanie Lewis.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1563         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1564         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1565         (TransferToS3): Transfer full and minified archives to S3
1566
1567 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1568
1569         [WTF] Implement WTF::ThreadGroup
1570         https://bugs.webkit.org/show_bug.cgi?id=174081
1571
1572         Reviewed by Mark Lam.
1573
1574         Add WTF::ThreadGroup tests.
1575
1576         * TestWebKitAPI/CMakeLists.txt:
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1579         (TestWebKitAPI::TEST):
1580
1581 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1582
1583         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1584         https://bugs.webkit.org/show_bug.cgi?id=174150
1585
1586         Reviewed by Mark Lam.
1587
1588         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1589         (TestWebKitAPI::TEST):
1590         * TestWebKitAPI/TestsController.cpp:
1591         (TestWebKitAPI::TestsController::TestsController):
1592
1593 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1594
1595         Enabling uploading archives to S3.
1596         https://bugs.webkit.org/show_bug.cgi?id=174198
1597         
1598         Reviewed by Lucas Forschler.
1599
1600         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1601         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1602         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1603         (TransferToS3): Transfer full and minified archives to S3
1604
1605 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1606
1607         [GTK][WPE] kill-old-process should kill more webkit related process
1608         https://bugs.webkit.org/show_bug.cgi?id=174220
1609
1610         Reviewed by Michael Catanzaro.
1611
1612         Generate list of possible webkit-related process names and add
1613         them to the list of process to kill.
1614         Also update the possible system related process for GTK+/WPE.
1615
1616         * BuildSlaveSupport/kill-old-processes:
1617         (listAllWebKitPrograms):
1618         (main):
1619
1620 2017-07-06  Chris Dumez  <cdumez@apple.com>
1621
1622         FileMonitor should not be ref counted
1623         https://bugs.webkit.org/show_bug.cgi?id=174166
1624
1625         Reviewed by Brent Fulgham.
1626
1627         Update the API tests to reflect the API change.
1628
1629         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1630         (TestWebKitAPI::TEST_F):
1631
1632 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1633
1634         Unreviewed, rolling out r219194.
1635         https://bugs.webkit.org/show_bug.cgi?id=174207
1636
1637         it broke some layout tests (Requested by clopez on #webkit).
1638
1639         Reverted changeset:
1640
1641         "[GStreamer] vid.me videos do not play"
1642         https://bugs.webkit.org/show_bug.cgi?id=172240
1643         http://trac.webkit.org/changeset/219194
1644
1645 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1646
1647         Unreviewed, rolling out r219178.
1648
1649         This caused a consistent failure with the API test
1650         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1651
1652         Reverted changeset:
1653
1654         "[WTF] Clean up StringStatics.cpp by using
1655         LazyNeverDestroyed<> for Atoms"
1656         https://bugs.webkit.org/show_bug.cgi?id=174150
1657         http://trac.webkit.org/changeset/219178
1658
1659 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1660
1661         Add CWD to Perl library path (no longer the default since 5.26.0)
1662         https://bugs.webkit.org/show_bug.cgi?id=174200
1663
1664         Reviewed by Michael Catanzaro.
1665
1666         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1667         (SetupGitClone._get_username_and_email):
1668
1669 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1670
1671         Unreviewed, update my email address.
1672
1673         * Scripts/webkitpy/common/config/contributors.json:
1674
1675 2017-07-06  Charlie Turner  <cturner@igalia.com>
1676         [GStreamer] vid.me videos do not play
1677         https://bugs.webkit.org/show_bug.cgi?id=172240
1678
1679         Reviewed by Xabier Rodriguez-Calvar.
1680
1681         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1682         have the existing libsoup build against GNOME to avoid header drift
1683         against GStreamer's linked Soup library.
1684
1685         * gtk/jhbuild.modules:
1686
1687 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1688
1689         [WTF] Move SoftLinking.h into WTF
1690         https://bugs.webkit.org/show_bug.cgi?id=174000
1691
1692         Reviewed by Alex Christensen.
1693
1694         * DumpRenderTree/mac/TestRunnerMac.mm:
1695         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1696         (test_primary_header):
1697         (ErrorCollector.__init__): Deleted.
1698         (ErrorCollector.__call__): Deleted.
1699         (ErrorCollector.results): Deleted.
1700         (ErrorCollector.result_list): Deleted.
1701         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1702         (MockIo.open): Deleted.
1703         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1704         (CppFunctionsTest.test_create_acronym): Deleted.
1705         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1706         (CppFunctionsTest.test_parameter): Deleted.
1707         (CppFunctionsTest.test_single_line_view): Deleted.
1708         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1709         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1710         (CppFunctionsTest.test_parameter_list): Deleted.
1711         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1712         (CppStyleTestBase.process_file_data): Deleted.
1713         (CppStyleTestBase.perform_lint): Deleted.
1714         (CppStyleTestBase.perform_single_line_lint): Deleted.
1715         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1716         (CppStyleTestBase.perform_language_rules_check): Deleted.
1717         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1718         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1719         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1720         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1721         (CppStyleTestBase.perform_header_guard_check): Deleted.
1722         (CppStyleTestBase.assert_lint): Deleted.
1723         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1724         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1725         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1726         (CppStyleTestBase.assert_language_rules_check): Deleted.
1727         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1728         (CppStyleTestBase.assert_header_guard): Deleted.
1729         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1730         (CppStyleTestBase.assert_positions_equal): Deleted.
1731         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1732         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1733         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1734         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1735         (FunctionDetectionTest.test_ignore_macros): Deleted.
1736         (FunctionDetectionTest.test_non_functions): Deleted.
1737         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1738         (FunctionDetectionTest.test_parameter_list): Deleted.
1739         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1740         (CppStyleTest.test_asm_lines_ignored): Deleted.
1741         (CppStyleTest.test_get_line_width): Deleted.
1742         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1743         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1744         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1745         (CppStyleTest.test_position): Deleted.
1746         (CppStyleTest.test_rfind_in_lines): Deleted.
1747         (CppStyleTest.test_close_expression): Deleted.
1748         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1749         (CppStyleTest.test_cstyle_cast): Deleted.
1750         (CppStyleTest.test_runtime_casting): Deleted.
1751         (CppStyleTest.test_runtime_selfinit): Deleted.
1752         (CppStyleTest.test_runtime_rtti): Deleted.
1753         (CppStyleTest.test_static_cast_readability): Deleted.
1754         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1755         (CppStyleTest.void): Deleted.
1756         (CppStyleTest.test_deprecated_cast): Deleted.
1757         (CppStyleTest.test_mock_method): Deleted.
1758         (CppStyleTest.test_sizeof_type): Deleted.
1759         (CppStyleTest.cases): Deleted.
1760         (CppStyleTest.for): Deleted.
1761         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1762         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1763         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1764         (CppStyleTest.test_include_what_you_use): Deleted.
1765         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1766         (CppStyleTest.test_cleanse_line): Deleted.
1767         (CppStyleTest.test_multi_line_comments): Deleted.
1768         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1769         (CppStyleTest.test_multiline_strings): Deleted.
1770         (CppStyleTest.test_platformh_comments): Deleted.
1771         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1772         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1773         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1774         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1775         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1776         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1777         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1778         (CppStyleTest.test_check_posix_threading): Deleted.
1779         (CppStyleTest.test_insecure_string_operations): Deleted.
1780         (CppStyleTest.test_format_strings): Deleted.
1781         (CppStyleTest.test_insecure_temp_file): Deleted.
1782         (CppStyleTest.test_variable_length_array_detection): Deleted.
1783         (CppStyleTest.test_braces): Deleted.
1784         (CppStyleTest.test_check_check): Deleted.
1785         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1786         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1787         (CppStyleTest.test_spacing_for_fncall): Deleted.
1788         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1789         (CppStyleTest.test_spacing_before_braces): Deleted.
1790         (CppStyleTest.test_spacing_between_braces): Deleted.
1791         (CppStyleTest.test_spacing_before_brackets): Deleted.
1792         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1793         (CppStyleTest.test_objective_c_block): Deleted.
1794         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1795         (CppStyleTest.test_spacing_around_else): Deleted.
1796         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1797         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1798         (CppStyleTest.test_operator_methods): Deleted.
1799         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1800         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1801         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1802         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1803         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1804         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1805         (CppStyleTest.test_space_after_comment_marker): Deleted.
1806         (CppStyleTest.test_newline_at_eof): Deleted.
1807         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1808         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1809         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1810         (CppStyleTest.test_invalid_utf8): Deleted.
1811         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1812         (CppStyleTest.test_is_blank_line): Deleted.
1813         (CppStyleTest.test_blank_lines_check): Deleted.
1814         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1815         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1816         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1817         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1818         (CppStyleTest.test_comma): Deleted.
1819         (CppStyleTest.test_declaration): Deleted.
1820         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1821         (CppStyleTest.test_indent): Deleted.
1822         (CppStyleTest.test_indent.Foo): Deleted.
1823         (CppStyleTest.test_not_alabel): Deleted.
1824         (CppStyleTest.test_tab): Deleted.
1825         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1826         (CppStyleTest.test_build_class): Deleted.
1827         (CppStyleTest.test_build_class.definitions): Deleted.
1828         (CppStyleTest.test_build_class.Foo): Deleted.
1829         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1830         (CppStyleTest.test_build_end_comment): Deleted.
1831         (CppStyleTest.test_build_forward_decl): Deleted.
1832         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1833         (CppStyleTest.test_build_header_guard): Deleted.
1834         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1835         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1836         (CppStyleTest.test_build_printf_format): Deleted.
1837         (CppStyleTest.test_runtime_printf_format): Deleted.
1838         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1839         (CppStyleTest.test_build_storage_class): Deleted.
1840         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1841         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1842         (CppStyleTest.test_build_storage_class.after): Deleted.
1843         (CppStyleTest.test_build_storage_class.is): Deleted.
1844         (CppStyleTest.test_legal_copyright): Deleted.
1845         (CppStyleTest.test_invalid_increment): Deleted.
1846         (CppStyleTest.test_enum_bitfields): Deleted.
1847         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1848         (CleansedLinesTest.test_init_empty): Deleted.
1849         (CleansedLinesTest.test_collapse_strings): Deleted.
1850         (OrderOfIncludesTest.tearDown): Deleted.
1851         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1852         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1853         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1854         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1855         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1856         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1857         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1858         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1859         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1860         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1861         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1862         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1863         (OrderOfIncludesTest.test_primary_header): Deleted.
1864         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1865         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1866         (OrderOfIncludesTest.test_classify_include): Deleted.
1867         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1868         (CheckForFunctionLengthsTest.tearDown): Deleted.
1869         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1870         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1871         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1872         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1873         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1874         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1875         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1876         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1877         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1878         (CheckForFunctionLengthsTest.function_body): Deleted.
1879         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1880         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1881         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1882         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1883         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1884         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1885         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1886         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1887         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1888         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1889         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1890         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1891         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1892         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1893         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1894         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1895         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1896         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1897         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1898         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1899         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1900         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1901         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1902         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1903         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1904         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1905         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1906         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1907         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1908         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1909         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1910         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1911         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1912         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1913         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1914         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1915         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1916         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1917         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1918         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1919         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1920         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1921         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1922         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1923         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1924         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1925         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1926         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1927         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1928         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1929         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1930         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1931         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1932         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1933         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1934         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1935         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1936         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1937         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1938         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1939         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1940         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1941         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1942         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1943         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1944         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1945         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1946         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1947         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1948         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1949         (LeakyPatternTest.test_get_dc): Deleted.
1950         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1951         (LeakyPatternTest.test_own_get_dc): Deleted.
1952         (LeakyPatternTest.test_create_dc): Deleted.
1953         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1954         (WebKitStyleTest.test_indentation): Deleted.
1955         (WebKitStyleTest.test_indentation.Foo): Deleted.
1956         (WebKitStyleTest.test_indentation.Document): Deleted.
1957         (WebKitStyleTest.test_spacing): Deleted.
1958         (WebKitStyleTest.test_line_breaking): Deleted.
1959         (WebKitStyleTest.test_braces): Deleted.
1960         (WebKitStyleTest.test_braces.MyClass): Deleted.
1961         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1962         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1963         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1964         (WebKitStyleTest.test_null_false_zero): Deleted.
1965         (WebKitStyleTest.test_directive_indentation): Deleted.
1966         (WebKitStyleTest.test_using_std): Deleted.
1967         (WebKitStyleTest.test_using_namespace): Deleted.
1968         (WebKitStyleTest.test_max_macro): Deleted.
1969         (WebKitStyleTest.test_min_macro): Deleted.
1970         (WebKitStyleTest.test_wtf_move): Deleted.
1971         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1972         (WebKitStyleTest.test_names): Deleted.
1973         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1974         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1975         (WebKitStyleTest.test_names.declarations): Deleted.
1976         (WebKitStyleTest.test_names.struct): Deleted.
1977         (WebKitStyleTest.test_names.VectorType): Deleted.
1978         (WebKitStyleTest.test_parameter_names): Deleted.
1979         (WebKitStyleTest.test_comments): Deleted.
1980         (WebKitStyleTest.test_webkit_export_check): Deleted.
1981         (WebKitStyleTest.test_member_initialization_list): Deleted.
1982         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1983         (WebKitStyleTest.test_other): Deleted.
1984         (CppCheckerTest.mock_handle_style_error): Deleted.
1985         (CppCheckerTest._checker): Deleted.
1986         (CppCheckerTest.test_init): Deleted.
1987         (CppCheckerTest.test_eq): Deleted.
1988         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1989         (CppCheckerTest.test_ne): Deleted.
1990         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1991         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1992         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1993         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1994         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1995         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1996
1997 2017-07-05  Saam Barati  <sbarati@apple.com>
1998
1999         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2000         https://bugs.webkit.org/show_bug.cgi?id=174188
2001         <rdar://problem/30581423>
2002
2003         Reviewed by Mark Lam.
2004
2005         * Scripts/run-jsc-stress-tests:
2006
2007 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2008
2009         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2010         https://bugs.webkit.org/show_bug.cgi?id=174150
2011
2012         Reviewed by Mark Lam.
2013
2014         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2015         (TestWebKitAPI::TEST):
2016
2017 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2018
2019         Remove copy of ICU headers from WebKit
2020         https://bugs.webkit.org/show_bug.cgi?id=116407
2021
2022         Reviewed by Alex Christensen.
2023
2024         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2025         * TestWebKitAPI/Configurations/Base.xcconfig:
2026         * WebKitTestRunner/Configurations/Base.xcconfig:
2027
2028 2017-07-05  Chris Dumez  <cdumez@apple.com>
2029
2030         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2031         https://bugs.webkit.org/show_bug.cgi?id=174163
2032         <rdar://problem/33067518>
2033
2034         Reviewed by Alex Christensen.
2035
2036         Add API test coverage.
2037
2038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2039         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2040         (TEST):
2041
2042 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2043
2044         When dragging a selection, clearing the selection in dragstart should not crash the web process
2045         https://bugs.webkit.org/show_bug.cgi?id=174142
2046         <rdar://problem/33067501>
2047
2048         Reviewed by Tim Horton.
2049
2050         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2051         drag is starting up.
2052
2053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2054         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2055         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2056         (TestWebKitAPI::TEST):
2057
2058 2017-07-05  Daniel Bates  <dabates@apple.com>
2059
2060         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2061         API navigation
2062         https://bugs.webkit.org/show_bug.cgi?id=174170
2063         <rdar://problem/33140328>
2064
2065         Reviewed by Brady Eidson.
2066
2067         Update tests as needed for the behavior change.
2068
2069         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2070         (TEST):
2071
2072 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2073
2074         Add WebKitPrivateFrameworkStubs for iOS 11
2075         https://bugs.webkit.org/show_bug.cgi?id=173988
2076
2077         Reviewed by David Kilzer.
2078
2079         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2080         should use the same directory for private framework stubs.
2081         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2082
2083 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2084
2085         [MediaStream] Protect request and web view during gUM client callback
2086         https://bugs.webkit.org/show_bug.cgi?id=174096
2087         <rdar://problem/32833102>
2088
2089         Reviewed by Youenn Fablet.
2090
2091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2092         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2093
2094 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2095
2096         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2097
2098         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2099
2100 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2101
2102         Unreviewed, rolling out r219128.
2103
2104         Spoke with engineer who originally submitted, Patch for APi
2105         test to follow.
2106
2107         Reverted changeset:
2108
2109         "Unreviewed, rolling out r219070."
2110         https://bugs.webkit.org/show_bug.cgi?id=174082
2111         http://trac.webkit.org/changeset/219128
2112
2113 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2114
2115         Unreviewed, rolling out r219070.
2116
2117         This revision caused consistent failures of the API test
2118         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2119
2120         Reverted changeset:
2121
2122         "Pasting single words copied to UIPasteboard inserts URLs in
2123         editable areas"
2124         https://bugs.webkit.org/show_bug.cgi?id=174082
2125         http://trac.webkit.org/changeset/219070
2126
2127 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2128
2129         Remove unused EFL logo from bot watcher dashboard
2130         https://bugs.webkit.org/show_bug.cgi?id=174136
2131
2132         Reviewed by Alexey Proskuryakov.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2136
2137 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2138
2139         [GTK] Add more GTK bots to dashboard
2140         https://bugs.webkit.org/show_bug.cgi?id=174129
2141
2142         Reviewed by Carlos Alberto Lopez Perez.
2143
2144         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2145         them.
2146
2147         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2148         less-essential GTK bots.
2149
2150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2152         (WebKitBuildbot):
2153
2154 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2155
2156         [WPE] Add WPE to bot watcher dashboard
2157         https://bugs.webkit.org/show_bug.cgi?id=174119
2158
2159         Reviewed by Alexey Proskuryakov.
2160
2161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2166         (WebKitBuildbot):
2167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2168         (table.queue-grid tr.platform.linux-wpe img.logo):
2169
2170 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2171
2172         https://bugs.webkit.org/show_bug.cgi?id=174105
2173         
2174         Reviewed by Stephanie Lewis.
2175
2176         * BuildSlaveSupport/built-product-archive:
2177         (main): Add a -minify parser option
2178         (createZip): Pass along the optional Minify argument if requested
2179         (minifySource): This will trim down archives, logic limited to Mac platform.
2180
2181 2017-07-03  Matt Rajca  <mrajca@apple.com>
2182
2183         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2184         https://bugs.webkit.org/show_bug.cgi?id=174103
2185
2186         Reviewed by Alex Christensen.
2187
2188         Added an API test.
2189
2190         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2191         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2192         (TEST): Added test.
2193         * TestWebKitAPI/cocoa/TestWKWebView.h:
2194         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2195         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2196
2197 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2198
2199         Unreviewed, rolling out r219103.
2200
2201         Caused multiple build failures.
2202
2203         Reverted changeset:
2204
2205         "Remove copy of ICU headers from WebKit"
2206         https://bugs.webkit.org/show_bug.cgi?id=116407
2207         http://trac.webkit.org/changeset/219103
2208
2209 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2210
2211         Remove copy of ICU headers from WebKit
2212         https://bugs.webkit.org/show_bug.cgi?id=116407
2213
2214         Reviewed by Alex Christensen.
2215
2216         Use WTF's copy of ICU headers.
2217
2218         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2219         * TestWebKitAPI/Configurations/Base.xcconfig:
2220         * WebKitTestRunner/Configurations/Base.xcconfig:
2221
2222 2017-07-03  Brady Eidson  <beidson@apple.com>
2223
2224         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2225         https://bugs.webkit.org/show_bug.cgi?id=174073
2226
2227         Reviewed by Andy Estes.
2228
2229         * DumpRenderTree/mac/TestRunnerMac.mm:
2230         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2231
2232         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2233         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2234
2235 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2236
2237         Unreviewed, rolling out r219083.
2238
2239         The revision caused an API failure on all testing platforms.
2240
2241         Reverted changeset:
2242
2243         "[MediaStream] Protect request and web view during gUM client
2244         callback"
2245         https://bugs.webkit.org/show_bug.cgi?id=174096
2246         http://trac.webkit.org/changeset/219083
2247
2248 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2249
2250         webkitpy: Properly number duplicated crashlogs
2251         https://bugs.webkit.org/show_bug.cgi?id=172002
2252
2253         Reviewed by Aakash Jain.
2254
2255         * Scripts/webkitpy/common/system/crashlogs.py:
2256         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2257         an increasing integer.
2258         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2259         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2260         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2261         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2262
2263 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2264
2265         WebContent processes crash when the network process crashes with pending connection requests
2266         https://bugs.webkit.org/show_bug.cgi?id=174065
2267         <rdar://problem/30359835>
2268
2269         Reviewed by Tim Horton.
2270
2271         Add a API to ensure UI process tries to relaunch a new network process when the network process
2272         crashes with pending network connection requests.
2273
2274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2275         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2276         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2277         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2278         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2279
2280 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2281
2282         [MediaStream] Protect request and web view during gUM client callback
2283         https://bugs.webkit.org/show_bug.cgi?id=174096
2284         <rdar://problem/32833102>
2285
2286         Reviewed by Youenn Fablet.
2287
2288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2289         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2290
2291 2017-07-03  Andy Estes  <aestes@apple.com>
2292
2293         [Xcode] Add an experimental setting to build with ccache
2294         https://bugs.webkit.org/show_bug.cgi?id=173875
2295
2296         Reviewed by Tim Horton.
2297
2298         On systems that already have ccache(1) installed, this patch adds experimental support for
2299         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2300
2301         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2302         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2303         find the toolchain from which to run clang, and then invokes ccache with the required
2304         arguments.
2305
2306         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2307         precompiled headers to work properly [1].
2308
2309         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2310         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2311         during linking.
2312         
2313         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2314
2315         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2316         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2317         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2318         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2319         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2320         * ccache/README.md: Added.
2321         * ccache/ccache-clang: Added.
2322         * ccache/ccache-clang++: Added.
2323         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2324
2325 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2326
2327         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2328         https://bugs.webkit.org/show_bug.cgi?id=174051
2329
2330         Reviewed by Tim Horton.
2331
2332         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2333         (TestWebKitAPI::TEST_F):
2334
2335 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2336
2337         Unreviewed, rolling out r219024.
2338
2339         This patch cause 3 didferent test to fail.
2340
2341         Reverted changeset:
2342
2343         "REGRESSION(r215096) Queries of URLs with non-special schemes
2344         should not percent-encode single quotes"
2345         https://bugs.webkit.org/show_bug.cgi?id=174051
2346         http://trac.webkit.org/changeset/219024
2347
2348 2017-07-03  Chris Dumez  <cdumez@apple.com>
2349
2350         Drop ResourceLoadStatisticsStore's statisticsLock
2351         https://bugs.webkit.org/show_bug.cgi?id=174080
2352
2353         Reviewed by Brent Fulgham.
2354
2355         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2356
2357         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2358         (WTR::TestController::isStatisticsPrevalentResource):
2359         (WTR::TestController::isStatisticsHasHadUserInteraction):
2360         (WTR::TestController::isStatisticsGrandfathered):
2361
2362 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2363
2364         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2365         https://bugs.webkit.org/show_bug.cgi?id=174082
2366         <rdar://problem/33046992>
2367
2368         Reviewed by Tim Horton.
2369
2370         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2371
2372         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2373         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2374         (TestWebKitAPI::TEST):
2375
2376 2017-07-02  Brady Eidson  <beidson@apple.com>
2377
2378         Add API test for all parts of WebKit1 API related to favicons.
2379         https://bugs.webkit.org/show_bug.cgi?id=174069
2380
2381         Reviewed by Andy Estes.
2382
2383         These two API tests cover all WebKit1 API related to icons.
2384         
2385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2386         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2387         (mainResourceData):
2388         (defaultFaviconData):
2389         (customFaviconData):
2390         (imageFromData):
2391         (+[IconLoadingProtocol canInitWithRequest:]):
2392         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2393         (-[IconLoadingProtocol startLoading]):
2394         (-[IconLoadingProtocol stopLoading]):
2395         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2396         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2397         (TestWebKitAPI::TEST):
2398
2399 2017-07-01  Dan Bernstein  <mitz@apple.com>
2400
2401         [iOS] Remove code only needed when building for iOS 9.x
2402         https://bugs.webkit.org/show_bug.cgi?id=174068
2403
2404         Reviewed by Tim Horton.
2405
2406         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2407         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2408         (WTR::initializeWebViewConfiguration):
2409         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2410         (-[HIDEventGenerator _createIOHIDEventType:]):
2411
2412 2017-07-01  Brady Eidson  <beidson@apple.com>
2413
2414         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2415         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2416
2417         Reviewed by Alex Christensen.
2418
2419         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2420
2421 2017-07-01  Dan Bernstein  <mitz@apple.com>
2422
2423         [macOS] Remove code only needed when building for OS X Yosemite
2424         https://bugs.webkit.org/show_bug.cgi?id=174067
2425
2426         Reviewed by Tim Horton.
2427
2428         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2429         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2430         * DumpRenderTree/mac/DumpRenderTree.mm:
2431         (setDefaultsToConsistentValuesForTesting):
2432         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2433         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2434         * MiniBrowser/Configurations/Base.xcconfig:
2435         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2436         * TestWebKitAPI/Configurations/Base.xcconfig:
2437         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2438         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2439         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2440         (TestWebKitAPI::TEST_F):
2441         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2442         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2443         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2444         (TestWebKitAPI::TEST_F):
2445         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2446         (TestWebKitAPI::TEST):
2447         * WebKitTestRunner/Configurations/Base.xcconfig:
2448         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2449         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2450         (WTR::InjectedBundle::platformInitialize):
2451         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2452         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2453
2454 2017-07-01  Chris Dumez  <cdumez@apple.com>
2455
2456         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2457         https://bugs.webkit.org/show_bug.cgi?id=174060
2458
2459         Reviewed by Brent Fulgham.
2460
2461         Port WebKitTestRunner over to the new Cocoa SPI.
2462
2463         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2464         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2465         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2466         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2467         no-ops since this code runs in the WebContent process, not the
2468         UIProcess.
2469
2470         * WebKitTestRunner/TestController.cpp:
2471         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2472
2473 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2474
2475         Unreviewed mac build fix.
2476
2477         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2478         (TestWebKitAPI::TEST):
2479
2480 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2481
2482         Add API to get WKActivatedElementInfo
2483         https://bugs.webkit.org/show_bug.cgi?id=174001
2484         <rdar://problem/29165518>
2485         
2486         Tests for now SPI to get activatedElementInfo.
2487
2488         Reviewed by Tim Horton.
2489
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2492         (TestWebKitAPI::TEST):
2493
2494 2017-06-30  Chris Dumez  <cdumez@apple.com>
2495
2496         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2497         https://bugs.webkit.org/show_bug.cgi?id=174038
2498
2499         Reviewed by Brent Fulgham.
2500
2501         Fix typo in API name.
2502
2503         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2504         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2505         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2506         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2507         * WebKitTestRunner/TestController.cpp:
2508         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2509         * WebKitTestRunner/TestController.h:
2510         * WebKitTestRunner/TestInvocation.cpp:
2511         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2512
2513 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2514
2515         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2516         https://bugs.webkit.org/show_bug.cgi?id=174051
2517         <rdar://problem/33002846>
2518
2519         Reviewed by Tim Horton.
2520
2521         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2522         (TestWebKitAPI::TEST_F):
2523
2524 2017-06-30  Daniel Bates  <dabates@apple.com>
2525
2526         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2527         https://bugs.webkit.org/show_bug.cgi?id=165160
2528         <rdar://problem/29451999>
2529
2530         Reviewed by Brady Eidson.
2531
2532         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2533         for navigations and window creation.
2534
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2537         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2538         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2539         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2540         (TEST):
2541
2542 2017-06-29  Jer Noble  <jer.noble@apple.com>
2543
2544         Make Legacy EME API controlled by RuntimeEnabled setting.
2545         https://bugs.webkit.org/show_bug.cgi?id=173994
2546
2547         Reviewed by Sam Weinig.
2548
2549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2550
2551 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2552
2553         Follow-up fix for r218996
2554
2555         Unreviewed infrastructure fix.
2556
2557         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2558
2559         * Scripts/webkitpy/port/ios_simulator.py:
2560         (IOSSimulatorPort): Memoize ios_version().
2561
2562 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2563
2564         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2565         https://bugs.webkit.org/show_bug.cgi?id=174017
2566         <rdar://problem/32959782>
2567
2568         Reviewed by Simon Fraser.
2569
2570         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2571         changes, the caret would appear outside of the iframe.
2572
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2574         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2575         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2576         (checkDragCaretRectIsContainedInRect):
2577         (TestWebKitAPI::TEST):
2578         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2579         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2580         (-[DataInteractionSimulator _resetSimulatedState]):
2581         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2582         (-[DataInteractionSimulator _advanceProgress]):
2583         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2584
2585 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2586
2587         Add support for different versions of iOS when loading test expectations
2588         https://bugs.webkit.org/show_bug.cgi?id=173774
2589         <rdar://problem/32951132>
2590
2591         Rubber-stamped by Aakash Jain.
2592
2593         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2594
2595         * Scripts/webkitpy/port/ios.py:
2596         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2597         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2598         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2599         * Scripts/webkitpy/port/ios_device.py:
2600         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2601         * Scripts/webkitpy/port/ios_device_unittest.py:
2602         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2603         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2604         (IOSDeviceTest.test_expectations_ordering): Ditto.
2605         * Scripts/webkitpy/port/ios_simulator.py:
2606         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2607         ask the platform.
2608
2609 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2610
2611         Fontconfig build breaks with glibc 2.15+
2612         https://bugs.webkit.org/show_bug.cgi?id=174019
2613
2614         Reviewed by Carlos Alberto Lopez Perez.
2615
2616         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2617
2618         * wpe/jhbuild.modules:
2619         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2620
2621 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2622
2623         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2624         https://bugs.webkit.org/show_bug.cgi?id=174010
2625         <rdar://problem/32597802>
2626
2627         Reviewed by Tim Horton.
2628
2629         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2630         snapshot fails for any reason.
2631
2632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2633         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2634         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2635         (TestWebKitAPI::TEST):
2636
2637 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2638
2639         AX: Cannot call setValue() on contenteditable or ARIA text controls
2640         https://bugs.webkit.org/show_bug.cgi?id=173520
2641
2642         Reviewed by Ryosuke Niwa.
2643
2644         Add setValue() method to WKTR (already existed in DRT).
2645
2646         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2647         (WTR::AccessibilityUIElement::setValue):
2648         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2649         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2650         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2651         (WTR::AccessibilityUIElement::setValue):
2652
2653 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2654
2655         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2656         https://bugs.webkit.org/show_bug.cgi?id=173841
2657         rdar://problem/32983841
2658
2659         Reviewed by Dean Jackson.
2660
2661         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2662         always did text zooming.
2663
2664         * MiniBrowser/mac/WK1BrowserWindowController.m:
2665         (-[WK1BrowserWindowController zoomIn:]):
2666         (-[WK1BrowserWindowController zoomOut:]):
2667         (-[WK1BrowserWindowController canResetZoom]):
2668         (-[WK1BrowserWindowController resetZoom:]):
2669
2670 2017-06-29  John Wilander  <wilander@apple.com>
2671
2672         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2673         https://bugs.webkit.org/show_bug.cgi?id=173940
2674         <rdar://problem/33018125>
2675
2676         Reviewed by Brent Fulgham.
2677
2678         This change allows the TestController to turn off
2679         regular resource load statistics telemetry submission
2680         and to manually control when telemetry is calculated
2681         and submitted.
2682
2683         * WebKitTestRunner/TestController.cpp:
2684         (WTR::TestController::initialize):
2685             Turns off automatic resource load statistics telemetry submission.
2686
2687 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2688
2689         Unreviewed, rolling out r218512.
2690         https://bugs.webkit.org/show_bug.cgi?id=173981
2691
2692         "It changes the behavior of the JS API's JSEvaluateScript
2693         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2694
2695         Reverted changeset:
2696
2697         "test262: Completion values for control flow do not match the
2698         spec"
2699         https://bugs.webkit.org/show_bug.cgi?id=171265
2700         http://trac.webkit.org/changeset/218512
2701
2702 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2703
2704         Add WebKitSystemInterface for iOS 11
2705         https://bugs.webkit.org/show_bug.cgi?id=173936
2706
2707         Reviewed by Lucas Forschler.
2708
2709         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2710
2711 2017-06-28  Keith Miller  <keith_miller@apple.com>
2712
2713         VMTraps has some races
2714         https://bugs.webkit.org/show_bug.cgi?id=173941
2715
2716         Reviewed by Michael Saboff.
2717
2718         Add new testing mode for testing the Watchdog with our stress
2719         tests.
2720
2721         * Scripts/run-jsc-stress-tests:
2722
2723 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2724
2725         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2726         https://bugs.webkit.org/show_bug.cgi?id=173877
2727
2728         Reviewed by Brady Eidson.
2729
2730         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2731         the next tests.
2732
2733         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2734         (testGetFavicon):
2735
2736 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2737
2738         MobileSafari was constantly using 10-15% CPU viewing a PDF
2739         https://bugs.webkit.org/show_bug.cgi?id=173944
2740         <rdar://problem/33039910>
2741
2742         Reviewed by Simon Fraser.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2746         Add a test that we ever call the stable presentation update callback
2747         when we have a WKPDFView up, instead of infinitely looping.
2748
2749 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2750
2751         Prevent displaying URLs with small capital letters
2752         https://bugs.webkit.org/show_bug.cgi?id=173949
2753         <rdar://problem/32952058>
2754
2755         Reviewed by Brent Fulgham.
2756
2757         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2758         (TestWebKitAPI::TEST):
2759
2760 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2761
2762         Unreviewed test fix.
2763
2764         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2765
2766         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2767
2768 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2769
2770         Teach ResourceLoadStatistics to recognize changes in the file system
2771         https://bugs.webkit.org/show_bug.cgi?id=173800
2772         <rdar://problem/32937842>
2773
2774         Reviewed by Chris Dumez.
2775
2776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2777         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2778         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2779         (TestWebKitAPI::handleFileModification):
2780         (TestWebKitAPI::handleFileDeletion):
2781         (TestWebKitAPI::resetTestState):
2782         (TestWebKitAPI::TEST_F):
2783
2784 2017-06-28  Brady Eidson  <beidson@apple.com>
2785
2786         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2787         https://bugs.webkit.org/show_bug.cgi?id=173874
2788
2789         Reviewed by Alex Christensen.
2790
2791         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2792
2793 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2794
2795         Unreviewed, adding Don Olmstead to contributors.json
2796
2797         * Scripts/webkitpy/common/config/contributors.json:
2798
2799 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2800
2801         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2802         https://bugs.webkit.org/show_bug.cgi?id=173886
2803         <rdar://problem/32543191>
2804
2805         Reviewed by Andy Estes.
2806
2807         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2808         (ParsedRange::ParsedRange):
2809         (-[TestSchemeHandler initWithVideoData:]):
2810         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2811         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2812         (TEST):
2813
2814 2017-06-27  JF Bastien  <jfbastien@apple.com>
2815
2816         WebAssembly: running out of executable memory should throw OoM
2817         https://bugs.webkit.org/show_bug.cgi?id=171537
2818         <rdar://problem/32963338>
2819
2820         Reviewed by Saam Barati.
2821
2822         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2823         tests under limited executable memory and avoids non-WebAssembly
2824         code generation so that we more reliably run out of executable
2825         memory in WebAssembly.
2826
2827 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2828
2829         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2830         https://bugs.webkit.org/show_bug.cgi?id=173854
2831         <rdar://problem/32236827>
2832
2833         Reviewed by Ryosuke Niwa and Tim Horton.
2834
2835         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2836
2837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2838         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2839         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2840         (TestWebKitAPI::TEST):
2841
2842 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2843
2844         [PAL] Add symbol export macros for PAL
2845         https://bugs.webkit.org/show_bug.cgi?id=171519
2846
2847         Reviewed by Konstantin Tokarev.
2848
2849         * DumpRenderTree/config.h:
2850         * TestWebKitAPI/CMakeLists.txt:
2851         * TestWebKitAPI/config.h:
2852         * WebKitTestRunner/config.h:
2853
2854 2017-06-27  John Wilander  <wilander@apple.com>
2855
2856         Resource Load Statistics: Add telemetry
2857         https://bugs.webkit.org/show_bug.cgi?id=173499
2858         <rdar://problem/32826094>
2859
2860         Reviewed by Brent Fulgham.
2861
2862         Adds three new testRunner functions:
2863         - installStatisticsDidRunTelemetryCallback()
2864         - statisticsFireTelemetryHandler()
2865         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2866
2867         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2868         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2869         (WTR::InjectedBundle::didReceiveMessageToPage):
2870         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2871         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2872         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2873         (WTR::TestRunner::statisticsFireTelemetryHandler):
2874         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2876         * WebKitTestRunner/TestController.cpp:
2877         (WTR::TestController::resetStateToConsistentValues):
2878         (WTR::TestController::statisticsFireTelemetryHandler):
2879         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2880         * WebKitTestRunner/TestController.h:
2881         * WebKitTestRunner/TestInvocation.cpp:
2882         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2883
2884 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2885
2886         Add missing includes to fix compilation error on FreeBSD
2887         https://bugs.webkit.org/show_bug.cgi?id=172919
2888
2889         Reviewed by Mark Lam.
2890
2891         * ImageDiff/cairo/PlatformImageCairo.cpp:
2892
2893 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2894
2895         Unreviewed, rolling out r218783.
2896
2897         Causing accessibility/mac/setting-attributes-is-
2898         asynchronous.html to crash consistently on mac-wk2 Debug
2899
2900         Reverted changeset:
2901
2902         "AX: Cannot call setValue() on contenteditable or ARIA text
2903         controls"
2904         https://bugs.webkit.org/show_bug.cgi?id=173520
2905         http://trac.webkit.org/changeset/218783
2906
2907 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2908
2909         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2910         https://bugs.webkit.org/show_bug.cgi?id=173825
2911
2912         Reviewed by Saam Barati.
2913
2914         * DumpRenderTree/JavaScriptThreading.cpp:
2915         (runJavaScriptThread):
2916         (startJavaScriptThreads):
2917         * DumpRenderTree/mac/DumpRenderTree.mm:
2918         (runThread):
2919         (runPthread):
2920         (testThreadIdentifierMap):
2921
2922 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2923
2924         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2925         <https://webkit.org/b/173837>
2926
2927         Reviewed by Geoffrey Garen.
2928
2929         The clang static analyzer can't reason about objects that are
2930         assigned to a delegate as +1 retained, and then released
2931         later in a different method when the delegate is cleared.
2932
2933         Instead, use a common idiom where the object setting the
2934         delegate retains it as an instance variable on initialization.
2935         Then the same object clears the delegate and releases its
2936         instance variable during teardown.
2937
2938         Also add EXPECT_TRUE() tests to make sure the delegate objects
2939         match before teardown.
2940
2941         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2942         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2943         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2944         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2945         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2946         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2947
2948 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2949
2950         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2951         <https://webkit.org/b/173836>
2952
2953         Reviewed by Brady Eidson.
2954
2955         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2956         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2957         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2958         objects in this test.
2959
2960 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2961
2962         [ATK] Add support for aria-details and aria-errormessage
2963         https://bugs.webkit.org/show_bug.cgi?id=172588
2964
2965         Reviewed by Chris Fleizach.
2966
2967         Add additional methods to test ARIA properties which are exposed via
2968         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2969         to versions which support the details and error-message relation types.
2970
2971         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2972         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2973         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2974         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2975         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2976         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2977         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2978         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2979         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2980         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2981         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2982         * gtk/jhbuild.modules:
2983
2984 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2985
2986         Unreviewed. Add libfii to GTK+ install dependencies script.
2987
2988         * gtk/install-dependencies:
2989
2990 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2991
2992         Unreviewed, rolling out r215190.
2993
2994         Broke product select element on GNOME Bugzilla
2995
2996         Reverted changeset:
2997
2998         "[GTK] Misplaced right click menu on web page due to
2999         deprecated gtk_menu_popup()"
3000         https://bugs.webkit.org/show_bug.cgi?id=170553
3001         http://trac.webkit.org/changeset/215190
3002
3003 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3004
3005         Remove Reflect.enumerate
3006         https://bugs.webkit.org/show_bug.cgi?id=173806
3007
3008         Reviewed by Yusuke Suzuki.
3009
3010         * Scripts/run-jsc-stress-tests:
3011
3012 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3013
3014         AX: Cannot call setValue() on contenteditable or ARIA text controls
3015         https://bugs.webkit.org/show_bug.cgi?id=173520
3016
3017         Reviewed by Ryosuke Niwa.
3018
3019         Add setValue() method to WKTR (already existed in DRT).
3020
3021         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3022         (WTR::AccessibilityUIElement::setValue):
3023         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3024         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3025         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3026         (WTR::AccessibilityUIElement::setValue):
3027
3028 2017-06-23  Keith Miller  <keith_miller@apple.com>
3029
3030         Switch VMTraps to use halt instructions rather than breakpoint instructions
3031         https://bugs.webkit.org/show_bug.cgi?id=173677
3032
3033         Reviewed by JF Bastien.
3034
3035         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3036         (TEST):
3037
3038 2017-06-23  Youenn Fablet  <youenn@apple.com>
3039
3040         Set getUserMedia permission to true by default on WTR
3041         https://bugs.webkit.org/show_bug.cgi?id=173610
3042
3043         Reviewed by Alex Christensen.
3044
3045         Adding a way to reset the getUserMedia permission to pending.
3046
3047         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3048         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3049         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3050         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3051         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3052         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3053         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3054         * WebKitTestRunner/TestController.cpp:
3055         (WTR::TestController::resetStateToConsistentValues):
3056         (WTR::TestController::setUserMediaPermissionAsUnset):
3057         * WebKitTestRunner/TestController.h:
3058         * WebKitTestRunner/TestInvocation.cpp:
3059         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3060
3061 2017-06-23  Alex Christensen  <achristensen@webkit.org>
3062
3063         Add SPI to WKURLSchemeTask for redirection
3064         https://bugs.webkit.org/show_bug.cgi?id=173730
3065
3066         Reviewed by Brady Eidson.
3067
3068         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3069         (-[SchemeHandler webView:startURLSchemeTask:]):
3070         (-[SchemeHandler webView:stopURLSchemeTask:]):
3071         (TEST):
3072         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
3073         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
3074         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
3075         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
3076         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
3077
3078 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3079
3080         [WPE] Use JSC API to send script messages from web extension in tests
3081         https://bugs.webkit.org/show_bug.cgi?id=173757
3082
3083         Reviewed by Žan Doberšek.
3084
3085         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
3086         to run postMessage().
3087
3088         Fixes: /wpe/WebKitSecurityManager/file-xhr
3089                /wpe/WebKitConsoleMessage/console-api
3090                /wpe/WebKitConsoleMessage/js-exception
3091                /wpe/WebKitConsoleMessage/network-error
3092                /wpe/WebKitConsoleMessage/security-error
3093
3094         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3095         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
3096         (beforeAll): Ditto.
3097         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3098         (testWebContextSecurityFileXHR): Ditto.
3099         (beforeAll): Ditto.
3100         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3101         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
3102         (pageCreatedCallback): Remove ifdefs.
3103
3104 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3105
3106         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
3107
3108         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
3109         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
3110         doesn't exist yet in WPE.
3111
3112         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3113         (testWebViewJavaScriptDialogs):
3114         (testWebViewWindowProperties):
3115
3116 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GTK] Upgrade pixman and cairo in jhbuild
3119         https://bugs.webkit.org/show_bug.cgi?id=173710
3120
3121         Reviewed by Carlos Alberto Lopez Perez.
3122
3123         * gtk/jhbuild.modules:
3124
3125 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3126
3127         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
3128         https://bugs.webkit.org/show_bug.cgi?id=173711
3129
3130         Reviewed by Carlos Alberto Lopez Perez.
3131
3132         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
3133         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
3134
3135         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3136         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
3137
3138 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3139
3140         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
3141         <https://webkit.org/b/173721>
3142
3143         Reviewed by Joseph Pecoraro.
3144
3145         Use RetainPtr<> to create NSMutableDictionary and NSNumber
3146         objects to fix leaks and to avoid the autoreleasepool.
3147
3148         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
3149         (TEST):
3150
3151 2017-06-22  Matt Lewis  <jlewis3@apple.com>
3152
3153         Unreviewed, rolling out r218633.
3154
3155         The test is failing frequently on Sierra Debug and Windows
3156
3157         Reverted changeset:
3158
3159         "AX: Cannot call setValue() on contenteditable or ARIA text
3160         controls"
3161         https://bugs.webkit.org/show_bug.cgi?id=173520
3162         http://trac.webkit.org/changeset/218633
3163
3164 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3165
3166         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
3167         <https://webkit.org/b/173690>
3168
3169         Reviewed by Chris Dumez.
3170
3171         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3172         ownership of malloc()-ed memory, then frees it when it's
3173         released.  These tests were passing global variables into the
3174         method, which is not malloc()-ed memory, which violates the API
3175         contract.
3176
3177         The fix is to switch to use
3178         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3179         NO for the last argument.
3180
3181         Caught by the clang static analyzer.
3182
3183         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3184         (TEST):
3185         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3186         (TEST):
3187
3188 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3189
3190         [GTK] Upgrade Harfbuzz to version 1.4.2
3191         https://bugs.webkit.org/show_bug.cgi?id=173592
3192
3193         Reviewed by Carlos Alberto Lopez Perez.
3194
3195         * gtk/jhbuild.modules:
3196
3197 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3198
3199         [WPE] Update WPEBackend-mesa
3200         https://bugs.webkit.org/show_bug.cgi?id=173705
3201
3202         Reviewed by Carlos Alberto Lopez Perez.
3203
3204         A crash has been fixed, needed for unit tests to work.
3205
3206         * wpe/jhbuild.modules:
3207
3208 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3209
3210         Remove unused coordinated graphics C API
3211         https://bugs.webkit.org/show_bug.cgi?id=173706
3212
3213         Reviewed by Žan Doberšek.
3214
3215         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3216         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3217         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3218         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3219         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3220         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3221
3222 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3223
3224         [WPE] Build glib API tests
3225         https://bugs.webkit.org/show_bug.cgi?id=173702
3226
3227         Reviewed by Žan Doberšek.
3228
3229         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3230         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3231         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3232         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3233         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3234         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3235         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3236         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3237         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3238         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3239         and implement the missing features.
3240
3241         * CMakeLists.txt:
3242         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3243         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3244         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3245         (testAutomationSessionRequestSession):
3246         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3247         (testWebKitWebViewSessionState):
3248         (testWebKitWebViewSessionStateWithFormData):
3249         (testWebKitWebViewNavigationAfterSessionRestore):
3250         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3251         (beforeAll):
3252         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3253         (testCookieManagerEphemeral):
3254         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3255         (testBlobDownload):
3256         (beforeAll):
3257         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3258         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3259         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3260         (testProcessPerWebView):
3261         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3262         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3263         (testWebViewCreateNavigationData):
3264         (testWebViewJavaScriptDialogs):
3265         (testWebViewWindowProperties):
3266         (testWebViewMouseTarget):
3267         (testWebViewGeolocationPermissionRequests):
3268         (testWebViewUserMediaPermissionRequests):
3269         (testWebViewAudioOnlyUserMediaPermissionRequests):
3270         (testWebViewFileChooserRequest):
3271         (beforeAll):
3272         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3273         (beforeAll):
3274         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3275         (testPrivateBrowsing):
3276         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3277         (testFindControllerHide):
3278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3279         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3280         (testWebKitSettings):
3281         (beforeAll):
3282         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3283         (testWebViewNewWithUserContentManager):
3284         (beforeAll):
3285         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3286         (testWebContextEphemeral):
3287         (testWebContextProxySettings):
3288         (beforeAll):
3289         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3290         (testWebViewWebContext):
3291         (testWebViewWebContextLifetime):
3292         (testWebViewEphemeral):
3293         (testWebViewSettings):
3294         (testWebViewCanShowMIMEType):
3295         (testWebViewPageVisibility):
3296         (testWebViewIsPlayingAudio):
3297         (beforeAll):
3298         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3299         (testWebsiteDataEphemeral):
3300         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3301         (documentLoadedCallback):
3302         (pageCreatedCallback):
3303         (methodCallCallback):
3304         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3305         * TestWebKitAPI/glib/CMakeLists.txt:
3306         * TestWebKitAPI/glib/PlatformGTK.cmake:
3307         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3308         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3309         (main):
3310         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3311         (Test::adoptView):
3312         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3313         (WebKitTestBus::run):
3314         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3315         (WebViewTest::~WebViewTest):
3316         (WebViewTest::initializeWebView):
3317         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3318         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3319         (WebViewTest::platformDestroy):
3320         (WebViewTest::platformInitializeWebView):
3321         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3322         (WebViewTest::resizeView):
3323         (WebViewTest::hideView):
3324         (parentWindowMapped):
3325         (WebViewTest::showInWindow):
3326         (WebViewTest::showInWindowAndWaitUntilMapped):
3327         (WebViewTest::mouseMoveTo):
3328         (WebViewTest::clickMouseButton):
3329         (WebViewTest::emitPopupMenuSignal):
3330         (WebViewTest::keyStroke):
3331         (WebViewTest::doMouseButtonEvent):
3332         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3333         (WebViewTest::platformDestroy):
3334         (WebViewTest::platformInitializeWebView):
3335         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3336         (WebViewTest::resizeView):
3337         (WebViewTest::hideView):
3338         (WebViewTest::mouseMoveTo):
3339         (WebViewTest::clickMouseButton):
3340         (WebViewTest::keyStroke):
3341
3342 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3343
3344         [GTK] Move WebKit2 GLib API tests to glib directories
3345         https://bugs.webkit.org/show_bug.cgi?id=173642
3346
3347         Reviewed by Žan Doberšek.
3348
3349         * CMakeLists.txt:
3350         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3351         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3352         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3353         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3354         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3355         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3356         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3357         (testWebKitConsoleMessageNetworkError):
3358         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3359         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3360         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3361         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3362         (testLoadFromGResource):
3363         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3364         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3365         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3366         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3367         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3368         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3369         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3370         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3371         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3372         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3373         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3374         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3375         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3376         (testWebViewRunJavaScript):
3377         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3378         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3379         (registerGResource):
3380         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3381         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3382         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3383         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3384         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3385         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3386         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3387         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3388         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3389         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3390         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3391         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3392         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3393         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3394         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3395         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3396         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3397         (registerGResource):
3398         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3399         (Test::getResourcesDir):
3400         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3401         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3402         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3403         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3404         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3405         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3406
3407 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3408
3409         [WPE] Add initial web extensions API
3410         https://bugs.webkit.org/show_bug.cgi?id=173640
3411
3412         Reviewed by Žan Doberšek.
3413
3414         Add style checker exceptions for WPE web extensions API files.
3415
3416         * Scripts/webkitpy/style/checker.py:
3417
3418 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3419
3420         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3421         https://bugs.webkit.org/show_bug.cgi?id=173659
3422         <rdar://problem/32879788>
3423
3424         Reviewed by Tim Horton.
3425
3426         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3427
3428         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3429
3430         Augment this test page to log dragend and dragstart events on the drag source as well.
3431
3432         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3433         (checkStringArraysAreEqual):
3434         (TestWebKitAPI::TEST):
3435
3436 2017-06-21  Antoine Quint  <graouts@apple.com>
3437
3438         Ensure DRT always logs rAF suspension debugging code
3439         https://bugs.webkit.org/show_bug.cgi?id=173681
3440
3441         Reviewed by Tim "Mr. T" Horton.
3442
3443         * DumpRenderTree/mac/DumpRenderTree.mm:
3444         (resetWebPreferencesToConsistentValues):
3445
3446 2017-06-21  Chris Dumez  <cdumez@apple.com>
3447
3448         Allow constructing a WTF:Function from a function pointer
3449         https://bugs.webkit.org/show_bug.cgi?id=173660
3450
3451         Reviewed by Alex Christensen.
3452
3453         Add API test coverage.
3454
3455         * TestWebKitAPI/Tests/WTF/Function.cpp:
3456         (TestWebKitAPI::returnThree):
3457         (TestWebKitAPI::returnFour):
3458         (TestWebKitAPI::returnPassedValue):
3459         (TestWebKitAPI::TEST):
3460
3461 2017-06-21  Antoine Quint  <graouts@apple.com>
3462
3463         Add logging to identify when the Page suspends scripted animations
3464         https://bugs.webkit.org/show_bug.cgi?id=173626
3465
3466         Reviewed by Tim Horton.
3467
3468         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3469
3470         * DumpRenderTree/mac/DumpRenderTree.mm:
3471         (resetWebPreferencesToConsistentValues):
3472
3473 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3474
3475         AX: Cannot call setValue() on contenteditable or ARIA text controls
3476         https://bugs.webkit.org/show_bug.cgi?id=173520
3477
3478         Reviewed by Ryosuke Niwa.
3479
3480         Add setValue() method to WKTR (already existed in DRT).
3481
3482         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3483         (WTR::AccessibilityUIElement::setValue):
3484         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3485         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3486         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3487         (WTR::AccessibilityUIElement::setValue):
3488
3489 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3490
3491         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3492         as one of the dependencies required to build the product.
3493
3494         Rubber-stamped by Carlos Garcia Campos.
3495
3496         * gtk/install-dependencies:
3497         * wpe/install-dependencies:
3498
3499 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3500
3501         Disable font variations on macOS Sierra and iOS 10
3502         https://bugs.webkit.org/show_bug.cgi?id=173618
3503         <rdar://problem/32879164>
3504
3505         Reviewed by Jon Lee.
3506
3507         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3508
3509 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3510
3511         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3512         https://bugs.webkit.org/show_bug.cgi?id=173578
3513         <rdar://problem/32825028>
3514
3515         Reviewed by Tim Horton.
3516
3517         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3518         a custom popover does not cause dragging to fail when the popover is presented.
3519
3520         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3521         (-[DataInteractionSimulator _advanceProgress]):
3522
3523 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3524
3525         [WPE] Add initial implementation of glib API
3526         https://bugs.webkit.org/show_bug.cgi?id=173546
3527
3528         Reviewed by Žan Doberšek.
3529
3530         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3531         include WPE glib API files.
3532
3533         * Scripts/webkitperl/FeatureList.pm:
3534         * Scripts/webkitpy/style/checker.py:
3535         * Scripts/webkitpy/style/checkers/cpp.py:
3536         (check_identifier_name_in_declaration):
3537
3538 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3539
3540         [GTK] Upgrade to ICU to version 57.1
3541         https://bugs.webkit.org/show_bug.cgi?id=173538
3542
3543         Reviewed by Žan Doberšek.
3544
3545         * gtk/jhbuild.modules:
3546
3547 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3548
3549         [GTK] Remove unneeded modules from the jhbuild
3550         https://bugs.webkit.org/show_bug.cgi?id=170540
3551
3552         Reviewed by Michael Catanzaro.
3553
3554         We are building libxslt and libffi that we don't really need to build from sources.
3555
3556         * gtk/jhbuild.modules:
3557
3558 2017-06-19  Frederic Wang  <fwang@igalia.com>
3559
3560         [Mac] Add an experimental feature setting for async frame scrolling
3561         https://bugs.webkit.org/show_bug.cgi?id=173359
3562
3563         Reviewed by Simon Fraser.
3564
3565         * DumpRenderTree/mac/DumpRenderTree.mm:
3566         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3567         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3568         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3569         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3570
3571 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3572
3573         Unreviewed, adding myself to contributors.json
3574
3575         * Scripts/webkitpy/common/config/contributors.json:
3576
3577 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3578
3579         test262: Completion values for control flow do not match the spec
3580         https://bugs.webkit.org/show_bug.cgi?id=171265
3581
3582         Reviewed by Saam Barati.
3583
3584         * Scripts/run-jsc-stress-tests:
3585         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3586
3587 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3588
3589         Opening certain mails brings up a mail that grows indefinitely.
3590         https://bugs.webkit.org/show_bug.cgi?id=173562
3591         <rdar://problem/32766579>
3592
3593         Reviewed by Tim Horton.
3594
3595         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3596         (TEST):
3597
3598 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3599
3600         [iOS DnD] Support .zip archives for file uploads via drag and drop
3601         https://bugs.webkit.org/show_bug.cgi?id=173511
3602         <rdar://problem/32521025>
3603
3604         Reviewed by Tim Horton.
3605
3606         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3607         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3608