8c76672219766ebf891d1f70b1c1581f43104f36
[WebKit-https.git] / Tools / ChangeLog
1 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
2
3         [Chromium-Android] Virtual test suites fail
4         https://bugs.webkit.org/show_bug.cgi?id=92515
5
6         Reviewed by Dirk Pranke.
7
8         The failure is because our bypassing of DriverProxy.
9         Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
10         and restart DRT when the command line changes.
11
12         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
13         (ChromiumAndroidDriver.__init__):
14         (ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
15         (ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
16         (ChromiumAndroidDriver.start): Restart DRT when the command line changes.
17         (ChromiumAndroidDriver._start_once):
18
19 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
20
21         Remove NRWT --shard-ref-tests
22         https://bugs.webkit.org/show_bug.cgi?id=91539
23
24         This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
25         (https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
26         with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).
27
28         Reviewed by Dirk Pranke.
29
30         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
31         (LayoutTestRunner.run_tests):
32         (Sharder.shard_tests):
33         (Sharder._shard_in_two):
34         (Sharder._shard_by_directory):
35         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
36         (SharderTests):
37         (SharderTests.get_test_input):
38         (SharderTests.get_shards):
39         (SharderTests.test_shard_by_dir):
40         (SharderTests.test_shard_in_two):
41         * Scripts/webkitpy/layout_tests/controllers/manager.py:
42         (Manager._test_input_for_file):
43         (Manager._test_is_slow):
44         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
45         (ChromiumAndroidPort.__init__):
46         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
47         (parse_args):
48
49 2012-08-06  Luciano Wolf  <luciano.wolf@openbossa.org>
50
51         [Qt] Default sizes for input-text and text-area are different when running DRT/WTR
52         https://bugs.webkit.org/show_bug.cgi?id=91990
53
54         Reviewed by Kenneth Rohde Christiansen.
55
56         Initializing TestFonts information into WTR binary. Doing it 
57         later leads to wrong font names usage (Dejavu Serif instead
58         of Liberation Serif).
59
60         * WebKitTestRunner/Target.pri:
61         * WebKitTestRunner/qt/main.cpp:
62         (main):
63
64 2012-08-06  Jeff Timanus  <twiz@chromium.org>
65
66         Add twiz@{chromium|google}.org to the set of non-committer contributors.
67         https://bugs.webkit.org/show_bug.cgi?id=93288
68
69         Reviewed by Adam Barth.
70
71         * Scripts/webkitpy/common/config/committers.py:
72
73 2012-08-06  Adam Barth  <abarth@webkit.org>
74
75         REGRESSION(124789): EWS errors out because --print option is missing
76         https://bugs.webkit.org/show_bug.cgi?id=93299
77
78         Unreviewed.
79
80         The --print option doesn't exist anymore.  Let's try --quiet instead.
81
82         * Scripts/webkitpy/tool/steps/runtests.py:
83         (RunTests.run):
84         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
85
86 2012-08-06  Ryosuke Niwa  <rniwa@webkit.org>
87
88         run-webkit-tests should have ability to add description to its JSON output
89         https://bugs.webkit.org/show_bug.cgi?id=93296
90
91         Reviewed by Dirk Pranke.
92
93         Add --description option.
94
95         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
96         (PerfTestsRunner._parse_args):
97         (PerfTestsRunner._generate_and_show_results):
98         (PerfTestsRunner._generate_results_dict):
99         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
100         (test_run_with_description):
101
102 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
103
104         nrwt: handle errors from image diff better
105         https://bugs.webkit.org/show_bug.cgi?id=92934
106
107         Reviewed by Ojan Vafai.
108
109         Currently if ImageDiff crashes, returns a weird exit code, or
110         produces any stderr output, it's basically swallowed. This
111         change ensures that we log errors to stderr, and also appends
112         the error to the stderr for the test (so it'll show up in
113         results.html).
114
115         Most importantly, it'll cause diff_image() to fail and we'll
116         report ImageHashMismatch ... this may be kinda untrue, but I
117         think it's better than ignoring the error.
118
119         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
120         (SingleTestRunner._compare_image):
121         (SingleTestRunner._compare_output_with_reference):
122         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
123         (write_test_result):
124         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
125         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
126         (TestResultWriterTest):
127         * Scripts/webkitpy/layout_tests/port/base.py:
128         (Port.diff_image):
129         * Scripts/webkitpy/layout_tests/port/chromium.py:
130         (ChromiumPort.diff_image):
131         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
132         (ChromiumPortTestCase.test_diff_image_crashed):
133         * Scripts/webkitpy/layout_tests/port/driver.py:
134         (Driver.run_test):
135         * Scripts/webkitpy/layout_tests/port/image_diff.py:
136         (ImageDiffer.diff_image):
137         (ImageDiffer._read):
138         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
139         (TestImageDiffer.test_diff_image):
140         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
141         (MockDRTPortTest.test_diff_image_crashed):
142         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
143         (PortTestCase.test_diff_image):
144         (PortTestCase):
145         (PortTestCase.test_diff_image_crashed):
146         (PortTestCase.test_diff_image_crashed.make_proc):
147         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
148         (MockServerProcess.__init__):
149         * Scripts/webkitpy/layout_tests/port/test.py:
150         (TestPort.diff_image):
151         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
152         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
153
154 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
155
156         nrwt: clean up printing.py
157         https://bugs.webkit.org/show_bug.cgi?id=93026
158
159         Reviewed by Dirk Pranke.
160
161         This patch cleans up the implementation of printing.py now
162         that we're not using all the original complexity.
163
164         There should be no changes in functionality and everything
165         should be covered by the existing tests.
166
167         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
168         (LayoutTestRunner.run_tests):
169         * Scripts/webkitpy/layout_tests/views/printing.py:
170         (Printer.__init__):
171         (Printer.__del__):
172         (Printer.print_config):
173         (Printer.print_found):
174         (Printer.print_expected):
175         (Printer.print_workers_and_shards):
176         (Printer):
177         (Printer._print_expected_results_of_type):
178         (Printer.print_results):
179         (Printer._print_timing_statistics):
180         (Printer._print_aggregate_test_statistics):
181         (Printer._print_individual_test_times):
182         (Printer._print_test_list_timing):
183         (Printer._print_directory_timings):
184         (Printer._print_statistics_for_test_timings):
185         (Printer._print_result_summary):
186         (Printer._print_result_summary_entry):
187         (Printer._print_one_line_summary):
188         (Printer.print_finished_test):
189         (Printer._print_test_result):
190         (Printer._print_test_trace):
191         (Printer._print_baseline):
192         (Printer._print_unexpected_test_result):
193         (Printer._print_progress):
194         (Printer._print_unexpected_results):
195         (Printer._print_unexpected_results.add_result):
196         (Printer._print_quiet):
197         (Printer._print_default):
198         (Printer._print_debug):
199         (Printer._print_for_bot):
200         (Printer.write_update):
201         (Printer.writeln):
202         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
203         (Testprinter.get_printer):
204         (Testprinter.test_print_config):
205         (Testprinter.test_print_one_line_summary):
206         (Testprinter.test_print_unexpected_results):
207         (test_details):
208
209 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
210
211         change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
212         https://bugs.webkit.org/show_bug.cgi?id=93043
213
214         Reviewed by Ryosuke Niwa.
215
216         in preparation for the cleanup of the logging flags in new-run-webkit-tests.
217
218         * Scripts/run-webkit-tests:
219
220 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
221
222         nrwt: clean up logging, part 1
223         https://bugs.webkit.org/show_bug.cgi?id=93018
224
225         Reviewed by Ojan Vafai.
226
227         remove --print, --help-printing from nrwt, add three new options:
228         --quiet, which just logs warnings,errors, and unexpected results
229         --debug-rwt-logging, a new name for --verbose
230         --details, to get the old --print trace-everything behavior
231
232         This patch does not implement the new "one line per test"
233         --verbose behavior specified in bug 88702, and there's a bunch
234         of internal cleanup I can do in printing.py that I'll defer to
235         a later patch to make things easier to review.
236
237         This patch deletes a lot of unit tests that are no longer
238         necessary since there aren't so many logging combinations.
239
240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
241         (run):
242         (main):
243         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
244         (parse_args):
245         (passing_run):
246         (StreamTestingMixin.assertContains):
247         (MainTest.test_child_processes_2):
248         (MainTest.test_child_processes_min):
249         (MainTest.test_full_results_html):
250         (MainTest.test_no_tests_found):
251         (MainTest.test_no_tests_found_2):
252         (MainTest.test_repeat_each_iterations_num_tests):
253         (MainTest.test_additional_platform_directory):
254         (RebaselineTest.assertBaselines):
255         * Scripts/webkitpy/layout_tests/views/printing.py:
256         (print_options):
257         (Printer.__init__):
258         (Printer.enabled):
259         (Printer.print_unexpected_results):
260         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
261         (TestUtilityFunctions.test_print_options):
262         (Testprinter.get_result_summary):
263         (Testprinter.test_configure_and_cleanup):
264         (Testprinter.test_print_config):
265         (Testprinter.test_print_one_line_summary):
266         (Testprinter.test_print_unexpected_results):
267         (test_details):
268         (test_default):
269         (test_quiet):
270         (test_verbose):
271
272 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
273
274         [Chromium-Android] Store test executable, data and fonts in /data/local/tmp
275         https://bugs.webkit.org/show_bug.cgi?id=91910
276
277         /data/local/tmp is a directory with permission 0777 by default.
278         Place DumpRenderTree resources here so that both the native test app and
279         the NRWT script can access them even if adb shell isn't running as root.
280
281         Reviewed by Adam Barth.
282
283         * DumpRenderTree/chromium/TestShellAndroid.cpp:
284         (createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
285         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
286         (ChromiumAndroidPort.driver_cmd_line):
287         (ChromiumAndroidDriver.__init__):
288         (ChromiumAndroidDriver._setup_test):
289         (ChromiumAndroidDriver._push_executable):
290         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
291         (ChromiumAndroidPortTest.make_port):
292         (ChromiumAndroidPortTest.test_expectations_files):
293         (ChromiumAndroidDriverTest.test_drt_cmd_line):
294
295 2012-08-06  Abhishek Arya  <inferno@chromium.org>
296
297         [Chromium] Re-expose layoutTestController as various fuzzers depend on it
298         https://bugs.webkit.org/show_bug.cgi?id=93282
299
300         Reviewed by Ryosuke Niwa.
301
302         Unfortunately, various fuzzers used in the Chromium project still depends on
303         window.layoutTestController. Re-expose the object while they're making the transition.
304
305         * DumpRenderTree/chromium/TestShell.cpp:
306         (TestShell::bindJSObjectsToWindow):
307
308 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
309
310         WTR should be able to load external resources
311         https://bugs.webkit.org/show_bug.cgi?id=89382
312
313         Reviewed by Ryosuke Niwa.
314
315         Allow to load an external resource as the main frame
316         and allow all subsequent external loads for such a main
317         frame. This behavior is necessary for being able to run
318         performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
319
320         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
321         (WTR::isLocalHost):
322         (WTR):
323         (WTR::isHTTPOrHTTPSScheme):
324         (WTR::InjectedBundlePage::willSendRequestForFrame):
325
326 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
327
328         [WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
329         https://bugs.webkit.org/show_bug.cgi?id=93120
330
331         Reviewed by Csaba Osztrogonác.
332
333         Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
334         so it will be able to detect an unresponsive web process.
335
336         * Scripts/webkitpy/layout_tests/port/base.py:
337         (Port.default_timeout_ms):
338         * WebKitTestRunner/TestController.cpp:
339         (WTR):
340
341 2012-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
342
343         Unreviewed. Fix make distcheck.
344
345         * GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
346
347 2012-08-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
348
349         [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
350         https://bugs.webkit.org/show_bug.cgi?id=82724
351
352         Reviewed by Csaba Osztrogonác.
353
354         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
355         (LayoutTestController::removeAllVisitedLinks):
356
357 2012-08-06  Mario Sanchez Prada  <msanchez@igalia.com>
358
359         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
360         https://bugs.webkit.org/show_bug.cgi?id=90268
361
362         Reviewed by Martin Robinson.
363
364         Ignore WebKitTextChecker.* private files for gtk-doc.
365
366         * gtk/generate-gtkdoc:
367         (get_webkit2_options):
368
369 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
370
371         Unreviewed. Roll out r124728 because of build bot test fail.
372
373         * Scripts/webkitpy/common/config/watchlist:
374
375 2012-08-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
376
377         Unreviewed. Change my email address for watch list.
378
379         * Scripts/webkitpy/common/config/watchlist:
380
381 2012-08-04  Nico Weber  <thakis@chromium.org>
382
383         [Chromium Mac] Tests are exiting early due to failures to load missingImage.png
384         https://bugs.webkit.org/show_bug.cgi?id=93186
385
386         Reviewed by Ryosuke Niwa.
387
388         Add missingImage.png to DumpRenderTree.app's Resource folder.
389         Depends on http://crrev.com/150037 rolling into webkit first.
390
391         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
392
393 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
394
395         Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
396         https://bugs.webkit.org/show_bug.cgi?id=93173
397
398         Reviewed by Adam Barth.
399
400         Don't expose window.layoutTestController since all layout tests use window.testRunner
401         instead of window.layoutTestController as of r124685.
402
403         We can safely rename classes and files to use TestRunner once this patch is landed.
404
405         * DumpRenderTree/LayoutTestController.cpp:
406         (LayoutTestController::makeWindowObject):
407         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
408         (notifyTestCompletion):
409         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
410         (PluginTest::waitUntilDone):
411         (PluginTest::notifyDone):
412         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
413         (ConvertPoint::NPP_SetWindow):
414         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
415         (handleEventCarbon):
416         (handleEventCocoa):
417         (handleEventWin):
418         * DumpRenderTree/chromium/TestShell.cpp:
419         (TestShell::bindJSObjectsToWindow):
420         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
421         (WebCore::DumpRenderTree::initJSObjects):
422         * Scripts/bencher:
423         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
424         (WTR::LayoutTestController::makeWindowObject):
425
426 2012-08-04  Ilya Tikhonovsky  <loislo@chromium.org>
427
428         Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
429         Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.
430
431         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
432         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
433
434 2012-08-03  Yaron Friedman  <yfriedman@chromium.org>
435
436         [Chrome-Android] - Prepare apk tests for switch to checked in SDK.
437         https://bugs.webkit.org/show_bug.cgi?id=92931
438
439         Reviewed by Adam Barth.
440
441         Pass Android-specific gyp variables to the native test generator,
442         avoiding any dependencies on environment variables during build time.
443
444         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
445         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
446
447 2012-08-03  Rick Byers  <rbyers@chromium.org>
448
449         Double tap gesture should send dblclick event
450         https://bugs.webkit.org/show_bug.cgi?id=92412
451
452         Reviewed by Adam Barth.
453
454         Enable EventSender to set the tap count on tap gesture events.  The
455         delta X/Y parameters were not actually being used anymore (used to be
456         used for radius information).
457
458         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
459         (EventSender::gestureEvent):
460
461 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
462
463         run-perf-tests should generate JSON output and results page by default
464         https://bugs.webkit.org/show_bug.cgi?id=93042
465
466         Reviewed by Eric Seidel.
467
468         Generate results JSON and page named PerfTestResults.json and PerfTestResults.html by default.
469
470         * Scripts/webkitpy/layout_tests/port/base.py:
471         (Port.perf_results_directory): Added.
472         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
473         (PerfTestsRunner): Added _DEFAULT_JSON_FILENAME.
474         (PerfTestsRunner._parse_args): Added --no-results option in the case a user doens't want to generate
475         results JSON or results page.
476         (PerfTestsRunner.run):
477         (PerfTestsRunner._generate_and_show_results): Extracted from run. Set the default json file path using
478         port's perf_results_directory and call show_results_html_file at the end if the results page is generated.
479         (PerfTestsRunner._generate_results_dict): Renamed from _generate_output to disambiguate it from
480         _generate_and_show_results.
481         (PerfTestsRunner._generate_output_files): Takes results page's path instead of a boolean indicating
482         whether results page should be generated or not.
483         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
484         (create_runner_and_setup_results_template):
485         (test_run_respects_results_output): Added.
486         (test_run_generates_json_by_default): Added.
487         (test_run_generates_and_show_results_page): Added a check to ensure show_results_html_file is called.
488
489 2012-08-03  Sheriff Bot  <webkit.review.bot@gmail.com>
490
491         Unreviewed, rolling out r124628.
492         http://trac.webkit.org/changeset/124628
493         https://bugs.webkit.org/show_bug.cgi?id=93155
494
495         Causes random crashes of DRT on Chromium bots (Requested by
496         dimich on #webkit).
497
498         * DumpRenderTree/DumpRenderTree.gypi:
499         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
500         (MockWebKitPlatformSupport::createMediaStreamCenter):
501         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
502         (MockWebKitPlatformSupport):
503         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
504         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
505         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Removed.
506         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Removed.
507
508 2012-08-03  Brady Eidson  <beidson@apple.com>
509
510         Small part of "Out-of-process plug-ins should support asynchronous initialization."
511         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
512
513         Reviewed by Anders Carlsson.
514
515         * WebKitTestRunner/TestController.cpp:
516         (WTR::TestController::resetStateToConsistentValues): Reset all preferences related to asynchronous plugin initialization.
517
518 2012-08-02  Jeffrey Pfau  <jpfau@apple.com>
519
520         Add API for enabling blanket third-party data blocking
521         https://bugs.webkit.org/show_bug.cgi?id=93022
522
523         Reviewed by Anders Carlsson.
524
525         Added test for default setting of new third-party storage blocking API.
526
527         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
528         (TestWebKitAPI::TEST):
529
530 2012-08-03  Arvid Nilsson  <anilsson@rim.com>
531
532         Unreviewed, adding self to committers.py after becoming committer.
533
534         * Scripts/webkitpy/common/config/committers.py:
535
536 2012-08-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
537
538         Limited the number of queried cached build infos in URLs used by Garden-o-matic.
539         https://bugs.webkit.org/show_bug.cgi?id=92992.
540
541         Reviewed by Adam Barth.
542
543         I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
544
545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
546         (.):
547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
548
549 2012-08-03  Tommy Widenflycht  <tommyw@google.com>
550
551         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
552         https://bugs.webkit.org/show_bug.cgi?id=93091
553
554         Reviewed by Adam Barth.
555
556         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
557         to complete the infrastructure for RTCPeerConnection.
558
559         * DumpRenderTree/DumpRenderTree.gypi:
560         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
561         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
562         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
563         (MockWebKitPlatformSupport):
564         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
565         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
566         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
567         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
568         (MockWebRTCPeerConnectionHandler::initialize):
569         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
570         (WebKit):
571         (MockWebRTCPeerConnectionHandler):
572         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
573
574 2012-08-03  Hugo Parente Lima  <hugo.lima@openbossa.org>
575
576         [Qt][WK2] There's no way to test the gesture tap on WTR
577         https://bugs.webkit.org/show_bug.cgi?id=92895
578
579         Reviewed by Kenneth Rohde Christiansen.
580
581         WTR doesn't create the QQuickItem from C++, not from QML, so a call
582         to componentComplete() was added to mimic the QML behaviour.
583
584         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
585         (WTR::PlatformWebView::PlatformWebView):
586
587 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
588
589         Unreviewed, rolling out r124567.
590         http://trac.webkit.org/changeset/124567
591         https://bugs.webkit.org/show_bug.cgi?id=89382
592
593         Broke some tests with external resources
594
595         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
596         (WTR::InjectedBundlePage::willSendRequestForFrame):
597
598 2012-08-03  Philippe Normand  <pnormand@igalia.com>
599
600         Unreviewed, rolling out r124614.
601         http://trac.webkit.org/changeset/124614
602         https://bugs.webkit.org/show_bug.cgi?id=91727
603
604         gstreamer core .po files mess up the build again
605
606         * Scripts/webkitdirs.pm:
607         (buildAutotoolsProject):
608         * gtk/jhbuild.modules:
609
610 2012-08-03  Philippe Normand  <pnormand@igalia.com>
611
612         [GTK][jhbuild] Switch to GStreamer 0.11 build
613         https://bugs.webkit.org/show_bug.cgi?id=91727
614
615         Reviewed by Gustavo Noronha Silva.
616
617         Switch build-webkit --gtk to GStreamer 0.11 support and build the
618         necessary GStreamer git modules from JHBuild.
619
620         * Scripts/webkitdirs.pm:
621         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
622         * gtk/jhbuild.modules: GStreamer build support.
623
624 2012-08-03  Nico Weber  <thakis@chromium.org>
625
626         [chromium mac] DumpRenderTree compile fails with warning/error in LayoutTestHelper.mm with 10.7sdk
627         https://bugs.webkit.org/show_bug.cgi?id=92820
628
629         Reviewed by Jochen Eisinger.
630
631         When building with the 10.7 SDK, use newer functions to switch color
632         profiles. Note that these newer functions aren't available on 10.6,
633         but we don't intend to ship DRT to users, and no bots that currently
634         build with the 10.7 SDK ship their binaries to 10.6 testers.
635
636         The new code was copied from Apple's DRT/mac/LayoutTestHelper.m.
637
638         * DumpRenderTree/chromium/LayoutTestHelper.mm:
639         (installLayoutTestColorProfile):
640         (restoreUserColorProfile):
641         (saveCurrentColorProfile):
642
643 2012-08-03  Benjamin Poulain  <benjamin@webkit.org>
644
645         StringImpl created from literal should be BufferInternal
646         https://bugs.webkit.org/show_bug.cgi?id=92940
647
648         Reviewed by Anders Carlsson.
649
650         Add tests for the contruction of strings from literal.
651
652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
653         * TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added.
654         (TestWebKitAPI):
655         (TestWebKitAPI::TEST):
656         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Added.
657         (TestWebKitAPI):
658         (TestWebKitAPI::TEST):
659
660 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
661
662         [nrwt] fix unit tests after turned pixel testing to be a per test setting
663         https://bugs.webkit.org/show_bug.cgi?id=93112
664
665         Reviewed by Csaba Osztrogonác.
666
667         Change unit tests in accordance of per test switching of pixel testing.
668
669         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
670         (ChromiumAndroidDriverTest.test_command_from_driver_input):
671         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
672         (DriverTest.test_no_timeout):
673
674 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
675
676         [Qt] Populate .qmake.cache from the top-level project file
677
678         This makes it possible to build webkit without using the perl build
679         script. The duplicated logic in build-webkit will be removed when we
680         remove the Qt4 code paths. The build-webkit script will then simply
681         call 'qmake WebKit.pro' from WEBKITOUTPUTDIR.
682
683         Reviewed by Tor Arne Vestbø.
684
685         * qmake/mkspecs/features/win32/default_pre.prf:
686
687 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
688
689         [Qt] Move build config default to build-webkit instead of default_pre
690
691         Allows the qmake buildsystem have its own default.
692
693         Reviewed by Tor Arne Vestbø.
694
695         * Scripts/webkitdirs.pm:
696         (buildQMakeProjects):
697         * qmake/mkspecs/features/default_pre.prf:
698
699 2012-08-03  Mario Sanchez Prada  <msanchez@igalia.com>
700
701         Unreviewed build fix for GTK after r124581.
702
703         * DumpRenderTree/gtk/DumpRenderTree.cpp:
704         (runTest): Fix wrong variable name in ASSERT.
705
706 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
707
708         [Qt] Always save CONFIG & DEFINES in default_pre
709
710         Always doing it is cheaper than checking whether it needs to be done.
711         apart from that, it would break configuration initiated from another
712         project.
713
714         Reviewed by Tor Arne Vestbø.
715
716         * qmake/mkspecs/features/default_pre.prf:
717
718 2012-08-03  Joone Hur  <joone.hur@intel.com>
719
720         [EFL][DRT] fast/loader/stop-provisional-loads.html fails
721         https://bugs.webkit.org/show_bug.cgi?id=92219
722
723         Reviewed by Kenneth Rohde Christiansen.
724
725         This patch adds the ability to tell DRT to call ewk_frame_stop 
726         inside of a didStartProvisionalLoadForFrame signal handler.
727         It allows to pass fast/loader/stop-provisional-loads.html.
728
729         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
730         (DumpRenderTreeChrome::onFrameProvisionalLoad):
731
732 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
733
734         [WTR] process unresponsiveness is reported to the wrong test
735         https://bugs.webkit.org/show_bug.cgi?id=88404
736
737         2nd unreviewed buildfix.
738
739         * WebKitTestRunner/TestInvocation.cpp:
740
741 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
742
743         [WTR] process unresponsiveness is reported to the wrong test
744         https://bugs.webkit.org/show_bug.cgi?id=88404
745
746         Unreviewed buildfix. Also made the change on the array size
747         suggested on review because I forgot it when landed.
748
749         * WebKitTestRunner/TestInvocation.cpp:
750         (WTR::TestInvocation::invoke):
751
752 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
753
754         [WTR] process unresponsiveness is reported to the wrong test
755         https://bugs.webkit.org/show_bug.cgi?id=88404
756
757         Reviewed by Zoltan Herczeg.
758
759         Do resetting to consistent state after the finished test,
760         not before the next. This way we can report unresponsiveness
761         to the test that triggered it, and we do a restart before the
762         next test so it will start in a functional state.
763
764         * Scripts/webkitpy/layout_tests/port/webkit.py:
765         (WebKitDriver._check_for_driver_crash):
766         Print the error line for unresponsive web process, otherwise
767         it's hard to tell what happened.
768         * WebKitTestRunner/TestController.cpp:
769         (WTR):
770         Decreased the default short timeout so we can detect unresponsiveness
771         before the timer of the test harness times out. It was unnecessarily
772         high anyway, we should get answer from the web process in those cases
773         when the short timeout is used in less than a second.
774         (WTR::TestController::runTest):
775         (WTR::TestController::run):
776         * WebKitTestRunner/TestController.h:
777         (TestController):
778         * WebKitTestRunner/TestInvocation.cpp:
779         (WTR::TestInvocation::invoke):
780         (WTR::TestInvocation::dump):
781         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
782         * WebKitTestRunner/TestInvocation.h:
783         (TestInvocation): Make the dump function static as it doesn't need an object.
784
785 2012-08-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
786
787         [EFL] (REGRESSION 124581) : EFL 64-bit Debug bot is red and build is exiting early after 20 test crashes
788         https://bugs.webkit.org/show_bug.cgi?id=93084
789
790         Reviewed by Csaba Osztrogonác.
791
792         Fix regression introduced in r124581.
793
794         * DumpRenderTree/efl/DumpRenderTree.cpp:
795         (getFinalTestURL): Convert the path into a full file URL.
796         (runTest):
797
798 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
799
800         All ports should support per test switching of pixel testing
801         https://bugs.webkit.org/show_bug.cgi?id=92398
802
803         Reviewed by Dirk Pranke.
804
805         Teach all test drivers to accept a per test control of whether
806         to dump pixels. Drivers now accept a -p/--pixel-test argument
807         on the standart input that means that running the current
808         test as pixel test is allowed (even if the expected hash is
809         missing). Removed the --pixel-tests command line option since
810         there is no need for it anymore.
811
812         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
813         * DumpRenderTree/DumpRenderTree.gypi:
814         * DumpRenderTree/DumpRenderTree.h:
815         (TestCommand::TestCommand):
816         (TestCommand):
817         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
818         * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
819         (CommandTokenizer):
820         (CommandTokenizer::CommandTokenizer):
821         (CommandTokenizer::pump):
822         (CommandTokenizer::next):
823         (CommandTokenizer::hasNext):
824         (die):
825         (parseInputLine):
826         Common logic to parse the input line from the standard input (or from the command line
827         in standalone mode). Made it somewhat general so we can easily add more arguments if
828         there is a need.
829
830         * DumpRenderTree/chromium/DumpRenderTree.cpp:
831         (runTest):
832         (main):
833
834         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp.
835         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.h.
836         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp.
837         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h.
838         Renamed these files with a Chromium suffix because they were clashing with the common ones used by other ports after adding the root
839         DumpRenderTree directory to the include path.
840
841         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
842         * DumpRenderTree/chromium/TestShell.cpp:
843         (TestShell::TestShell):
844         (TestShell::runFileTest):
845         (TestShell::dump):
846         * DumpRenderTree/chromium/TestShell.h:
847         (TestParams::TestParams):
848         (TestShell):
849         * DumpRenderTree/efl/CMakeLists.txt:
850         * DumpRenderTree/efl/DumpRenderTree.cpp:
851         (parseCommandLineOptions):
852         (runTest):
853         (shouldDumpPixelsAndCompareWithExpected):
854         (main):
855         * DumpRenderTree/gtk/DumpRenderTree.cpp:
856         (initializeGlobalsFromCommandLineOptions):
857         (dump):
858         (runTest):
859         (main):
860         * DumpRenderTree/mac/DumpRenderTree.mm:
861         (initializeGlobalsFromCommandLineOptions):
862         (dumpRenderTree):
863         (dump):
864         (runTest):
865         * DumpRenderTree/qt/DumpRenderTree.pro:
866         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
867         (WebCore::DumpRenderTree::DumpRenderTree):
868         (WebCore::DumpRenderTree::open):
869         (WebCore::DumpRenderTree::processLine):
870         (WebCore::DumpRenderTree::dump):
871         * DumpRenderTree/qt/DumpRenderTreeQt.h:
872         (DumpRenderTree):
873         * DumpRenderTree/qt/main.cpp:
874         (isOption):
875         (printUsage):
876         (main):
877         * DumpRenderTree/win/DumpRenderTree.cpp:
878         (dump):
879         (runTest):
880         (dllLauncherEntryPoint):
881         * DumpRenderTree/win/DumpRenderTree.vcproj:
882         * DumpRenderTree/wscript:
883         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
884         (dump):
885         (runTest):
886         (MyApp::OnInit):
887         * GNUmakefile.am:
888
889         * Scripts/old-run-webkit-tests:
890         * Scripts/old-run-webkit-tests:
891         Pass --pixel-test before the hash.
892
893         * Scripts/webkitpy/layout_tests/port/base.py:
894         (Port.should_run_as_pixel_test): Removed now that all ports supports it.
895         * Scripts/webkitpy/layout_tests/port/driver.py:
896         (Driver.cmd_line): Don't pass --pixel-tests anymore.
897         (Driver._command_from_driver_input):
898         * Scripts/webkitpy/layout_tests/port/qt.py:
899         (QtPort.should_run_as_pixel_test):
900         * Scripts/webkitpy/layout_tests/port/test.py:
901         (TestPort.should_run_as_pixel_test):
902
903         * WebKitTestRunner/TestController.cpp:
904         (WTR::TestController::TestController):
905         (WTR::TestController::initialize):
906         (WTR::TestCommand::TestCommand):
907         (TestCommand):
908         (WTR):
909         (CommandTokenizer):
910         (WTR::CommandTokenizer::CommandTokenizer):
911         (WTR::CommandTokenizer::pump):
912         (WTR::CommandTokenizer::next):
913         (WTR::CommandTokenizer::hasNext):
914         (WTR::die):
915         (WTR::parseInputLine):
916         (WTR::TestController::runTest):
917         * WebKitTestRunner/TestController.h:
918         (TestController):
919         Duplicate the logic for parsing the command line because
920         unfortunately there is no way to share code between
921         WebKitTestRunner and DumpRenderTree.
922
923 2012-08-03  Ilya Tikhonovsky  <loislo@chromium.org>
924
925         Web Inspector: clang plugin for checking native memory instrumentation coverage.
926         https://bugs.webkit.org/show_bug.cgi?id=92650
927
928         Reviewed by Yury Semikhatsky.
929
930         This is the clang plugin for checking native memory instrumentation coverage.
931         The idea: InspectorMemoryAgent traverses through instrumented objects and collects pointers and their sizes and types.
932         It is doing that with help of reportMemoryUsage function that needs to be implemented in each, significant
933         from native memory footprint point of view, WebCore class.
934         This plugin checks that the list of class members is matching with the list of members reported in reportMemoryUsage function
935         and makes a warning for the each member that needs to be reported.
936
937         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Added.
938         * clang/ReportMemoryUsagePlugin/Makefile: Added.
939         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Added.
940         (clang):
941         (AddMemberCallVisitor):
942         (clang::AddMemberCallVisitor::VisitCallExpr):
943         (clang::AddMemberCallVisitor::instrumentedMembers):
944         (ReportMemoryUsageVisitor):
945         (clang::ReportMemoryUsageVisitor::ReportMemoryUsageVisitor):
946         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
947         (clang::ReportMemoryUsageVisitor::emitWarning):
948         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
949         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
950         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
951         (ReportMemoryUsageConsumer):
952         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
953         (clang::ReportMemoryUsageConsumer::HandleTranslationUnit):
954         (ReportMemoryUsageAction):
955         (clang::ReportMemoryUsageAction::CreateASTConsumer):
956         (clang::ReportMemoryUsageAction::ParseArgs):
957         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Added.
958         (aNamespace):
959         (MemoryInstrumentation):
960         (MemoryClassInfo):
961         (aNamespace::MemoryClassInfo::MemoryClassInfo):
962         (aNamespace::MemoryClassInfo::addMember):
963         (aNamespace::MemoryClassInfo::addInstrumentedMember):
964         (OwnPtr):
965         (aNamespace::OwnPtr::OwnPtr):
966         (RefPtr):
967         (aNamespace::RefPtr::RefPtr):
968         (Vector):
969         (String):
970         (NotInstrumentedClass):
971         (InstrumentedClass):
972         (aNamespace::InstrumentedClass::reportMemoryUsage):
973         (InstrumentedChildClass):
974         (aNamespace::InstrumentedChildClass::reportMemoryUsage):
975         (InstrumentedChildChildClass):
976         (InstrumentedChildChildClass::reportMemoryUsage):
977         (main):
978
979 2012-08-03  Joone Hur  <joone.hur@intel.com>
980
981         [EFL][DRT] WebKitAnimation API compile-time disabled
982         https://bugs.webkit.org/show_bug.cgi?id=84593
983
984         Reviewed by Laszlo Gombos.
985
986         Enable ENABLE_ANIMATION_API by default on the Efl port.
987
988         * Scripts/webkitperl/FeatureList.pm:
989
990 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
991
992         WTR should be able to load external resources
993         https://bugs.webkit.org/show_bug.cgi?id=89382
994
995         Reviewed by Ryosuke Niwa.
996
997         Allow to load an external resource as the main frame
998         and allow all subsequent external loads for such a main
999         frame. This behavior is necessary for being able to run
1000         performance tests (wkb.ug/84008).
1001
1002         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1003         (WTR::isLocalHost):
1004         (WTR):
1005         (WTR::isHTTPOrHTTPSScheme):
1006         (WTR::InjectedBundlePage::willSendRequestForFrame):
1007
1008 2012-08-02  Joone Hur  <joone.hur@intel.com>
1009
1010         [GTK] Build break when building DumpRenderTree/gtk/EditingCallbacks.cpp
1011         https://bugs.webkit.org/show_bug.cgi?id=93061
1012
1013         Unreviewed, Fix build break for WebKitGtk+.
1014
1015         Use webkit_dom_element_get_class_name instead of webkit_dom_html_element_get_class_name.
1016
1017         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1018         (shouldShowDeleteInterfaceForElement):
1019
1020 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
1021
1022         test-webkitpy can fail on a clean checkout
1023         https://bugs.webkit.org/show_bug.cgi?id=93039
1024
1025         Reviewed by Adam Barth.
1026
1027         Now that we run tests in parallel that can cause the installer
1028         to try and install packages in parallel (even the same package),
1029         and that probably won't work. We fix this by autoinstalling
1030         everything up front (serially).
1031
1032         * Scripts/webkitpy/test/main.py:
1033         (Tester._run_tests):
1034         * Scripts/webkitpy/thirdparty/__init__.py:
1035         (autoinstall_everything):
1036
1037 2012-06-15  David Barton  <dbarton@mathscribe.com>
1038
1039         MathML: nested square root symbols have varying descenders
1040         https://bugs.webkit.org/show_bug.cgi?id=43819
1041
1042         Reviewed by Eric Seidel.
1043
1044         Allow the STIXGeneral font to be used during layout tests, especially for MathML.
1045
1046         * DumpRenderTree/mac/DumpRenderTree.mm:
1047         (allowedFontFamilySet):
1048         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1049         (WTR::allowedFontFamilySet):
1050
1051 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
1052
1053         test-webkitpy: some tests need to run by themselves
1054         https://bugs.webkit.org/show_bug.cgi?id=92926
1055
1056         Reviewed by Ojan Vafai.
1057
1058         Due to timing issues some of the executive tests will collide
1059         and fail if they're run concurrently. This patch adds support
1060         for writing tests that will be executed one at a time
1061         (serially); to get them, add "serial_" to the front of the test
1062         method name. 
1063
1064         * Scripts/webkitpy/common/system/executive_unittest.py:
1065         (ExecutiveTest.serial_test_kill_process):
1066         (ExecutiveTest.serial_test_kill_all):
1067         (ExecutiveTest.serial_test_check_running_pid):
1068         (ExecutiveTest.serial_test_running_pids):
1069         (ExecutiveTest.serial_test_run_in_parallel):
1070         * Scripts/webkitpy/test/main.py:
1071         (Tester._run_tests):
1072         (Tester._test_names):
1073
1074 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
1075
1076         test-webkitpy: integrate proper support for integration tests
1077         https://bugs.webkit.org/show_bug.cgi?id=92925
1078
1079         Reviewed by Ojan Vafai.
1080
1081         This patch merges the custom loader I used for integration tests
1082         into the main test-webkitpy code. Integration tests are not run
1083         by default yet, but at least they can be run.
1084
1085         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1086         (MockTestShellTest.test_test_shell_parse_options):
1087         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1088         (test_path_to_apache_config_file):
1089         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1090         (WebsocketserverTest):
1091         * Scripts/webkitpy/test/main.py:
1092         (Tester._parse_args):
1093         (Tester._run_tests):
1094         (Tester._test_names):
1095         (Tester._log_exception):
1096         (_Loader):
1097         (_Loader.getTestCaseNames):
1098         (_Loader.getTestCaseNames.isTestMethod):
1099
1100 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
1101
1102         test-webkitpy: clean up runner in preparation for running tests serially as necessary
1103         https://bugs.webkit.org/show_bug.cgi?id=92922
1104
1105         Reviewed by Ojan Vafai.
1106
1107         In order to run some tests by themselves (serially, rather than
1108         in parallel with other tests), we will need to be able to run
1109         multiple test suites; this causes us to move loading the logic
1110         for finding test method names out of the runner and into main.
1111
1112         I'm taking advantage of this to simplify some other stuff from
1113         the runner as well; it is now very simple and doesn't expose its
1114         dependency on unittest.TestResult at all (nor will the Printer
1115         use TestResult).
1116
1117         Subsequent patches will move the custom loader from
1118         port_testcase so that we can properly choose whether to run
1119         integration tests and/or serial tests, and then update the
1120         appropriate tests to run only serially.
1121
1122         * Scripts/webkitpy/test/main.py:
1123         (Tester._run_tests):
1124         (Tester):
1125         (Tester._check_imports):
1126         (Tester._test_names):
1127         (Tester._all_test_names):
1128         * Scripts/webkitpy/test/printer.py:
1129         (Printer.__init__):
1130         (Printer.write_update):
1131         (Printer):
1132         (Printer.print_finished_test):
1133         (Printer.print_result):
1134         * Scripts/webkitpy/test/runner.py:
1135         (unit_test_name):
1136         (Runner.__init__):
1137         (Runner.run):
1138         (Runner.handle):
1139         (_Worker.handle):
1140         * Scripts/webkitpy/test/runner_unittest.py:
1141         (FakeLoader.loadTestsFromName):
1142         (RunnerTest.test_run):
1143
1144 2012-08-02  Adam Barth  <abarth@webkit.org>
1145
1146         Turn on tests for the mac-ews, for realz this time.
1147
1148         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1149         (MacEWS):
1150
1151 2012-08-02  Xianzhu Wang  <wangxianzhu@chromium.org>
1152
1153         [Chromium-Android] Run layout tests on multiple devices in parallel
1154         https://bugs.webkit.org/show_bug.cgi?id=92877
1155
1156         Reviewed by Dirk Pranke.
1157
1158         Moved methods that run command on a particular device from ChromiumAndroidPort to ChromiumAndroidDriver.
1159         The drivers run adb commands with the '-s serial_number' parameter which specifies the device according to the work_number.
1160
1161         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1162         (ChromiumAndroidPort.__init__):
1163         (ChromiumAndroidPort.default_child_processes): Default to the number of attached devices.
1164         (ChromiumAndroidPort.test_expectations): Removed because it is unused. 
1165         (ChromiumAndroidPort.setup_test_run): Most contents moved into ChromiumAndroidDriver._setup_test()
1166         (ChromiumAndroidPort.clean_up_test_run): Now the http server is stopped here.
1167         (ChromiumAndroidPort._get_devices):
1168         (ChromiumAndroidPort._get_device_serial):
1169         (ChromiumAndroidDriver):
1170         (ChromiumAndroidDriver.__init__):
1171         (ChromiumAndroidDriver.__del__):
1172         (ChromiumAndroidDriver._setup_test): Original contents of ChromiumAndroidPort.setup_test_run().
1173         (ChromiumAndroidDriver._push_executable): Moved from ChromiumAndroidPort.
1174         (ChromiumAndroidDriver._push_fonts): Moved from ChromiumAndroidPort.
1175         (ChromiumAndroidDriver._push_test_resources): Moved from ChromiumAndroidPort.
1176         (ChromiumAndroidDriver._synchronize_datetime): Moved from ChromiumAndroidPort.
1177         (ChromiumAndroidDriver._run_adb_command): Moved from ChromiumAndroidPort.
1178         (ChromiumAndroidDriver._teardown_performance): Moved from ChromiumAndroidPort.
1179         (ChromiumAndroidDriver._get_crash_log): Moved from ChromiumAndroidPort.
1180         (ChromiumAndroidDriver.cmd_line):
1181         (ChromiumAndroidDriver._file_exists_on_device):
1182         (ChromiumAndroidDriver._remove_all_pipes):
1183         (ChromiumAndroidDriver._start):
1184         (ChromiumAndroidDriver._start_once):
1185         (ChromiumAndroidDriver.stop):
1186         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1187         (MockRunCommand):
1188         (MockRunCommand.__init__):
1189         (MockRunCommand.mock_run_command_fn):
1190         (MockRunCommand.mock_no_device):
1191         (MockRunCommand.mock_one_device):
1192         (MockRunCommand.mock_two_devices):
1193         (MockRunCommand.mock_no_tombstone_dir):
1194         (MockRunCommand.mock_no_tombstone_file):
1195         (MockRunCommand.mock_ten_tombstones):
1196         (MockRunCommand.mock_logcat):
1197         (ChromiumAndroidPortTest):
1198         (ChromiumAndroidPortTest.make_port):
1199         (ChromiumAndroidPortTest.test_driver_cmd_line):
1200         (ChromiumAndroidPortTest.test_get_devices_no_device):
1201         (ChromiumAndroidPortTest.test_get_devices_one_device):
1202         (ChromiumAndroidPortTest.test_get_devices_two_devices):
1203         (ChromiumAndroidPortTest.test_get_device_serial_no_device):
1204         (ChromiumAndroidPortTest.test_get_device_serial_one_device):
1205         (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
1206         (ChromiumAndroidDriverTest):
1207         (ChromiumAndroidDriverTest.setUp):
1208         (ChromiumAndroidDriverTest.test_get_last_stacktrace):
1209         (ChromiumAndroidDriverTest.test_get_crash_log):
1210         (ChromiumAndroidDriverTest.test_cmd_line):
1211         (ChromiumAndroidDriverTwoDriversTest):
1212         (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
1213         * Scripts/webkitpy/layout_tests/port/driver.py:
1214         (Driver.run_test):
1215         (Driver._get_crash_log): Added to allow subclasses to override.
1216         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1217         (parse_args): Removed the --adb-args command-line parameter because now we select device automatically. Added --adb-device to specify devices.
1218
1219 2012-08-02  Dinu Jacob  <dinu.jacob@nokia.com>
1220
1221         WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled
1222         https://bugs.webkit.org/show_bug.cgi?id=42679
1223
1224         Reviewed by Eric Seidel.
1225
1226         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added 
1227         setUserStyleSheetEnabled and setUserStyleSheetLocation.
1228         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1229         (WTR::LayoutTestController::LayoutTestController): Initialize new members added.
1230         (WTR::LayoutTestController::setUserStyleSheetEnabled): Added.
1231         (WTR::LayoutTestController::setUserStyleSheetLocation): Added.
1232         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added members
1233         userStyleSheetEnabled, and m_userStyleSheetLocation and methods
1234         setUserStyleSheetEnabled, and setUserStyleSheetLocation.
1235
1236 2012-08-02  Hans Wennborg  <hans@chromium.org>
1237
1238         Speech JavaScript API: Fire speech start event at the same time as sound start event
1239         https://bugs.webkit.org/show_bug.cgi?id=92971
1240
1241         Reviewed by Adam Barth.
1242
1243         Update the MockWebSpeechRecognizer to not fire "speech started" events
1244         separately.
1245
1246         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1247         (MockWebSpeechRecognizer::start):
1248
1249 2012-08-02  Philippe Normand  <pnormand@igalia.com>
1250
1251         [GTK] make sometimes using a single core
1252         https://bugs.webkit.org/show_bug.cgi?id=92998
1253
1254         Reviewed by Martin Robinson.
1255
1256         In the GTK 64-bit Release buildbot some builds use a single core
1257         for the make process. I suspect this is because in those cases
1258         nproc reports a single core available. The proposed solution is to
1259         always rely on all the cores available in the machine.
1260
1261         * Scripts/webkitdirs.pm:
1262         (determineNumberOfCPUs):
1263
1264 2012-08-02  Adam Barth  <abarth@webkit.org>
1265
1266         Re-land http://trac.webkit.org/changeset/94441 now that lforschler is ready.
1267
1268         This patch enables testing on the mac-ews bots.
1269
1270         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1271
1272 2012-08-02  Adam Barth  <abarth@webkit.org>
1273
1274         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
1275         https://bugs.webkit.org/show_bug.cgi?id=90920
1276
1277         Reviewed by Tony Chang.
1278
1279         This patch contains the last few small changes to DumpRenderTree.gyp
1280         from the chromium-android branch. After this change, this file will be
1281         fully merged.
1282
1283         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1284
1285 2012-08-02  Peter Beverloo  <peter@chromium.org>
1286
1287         [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI
1288         https://bugs.webkit.org/show_bug.cgi?id=92858
1289
1290         Reviewed by Adam Barth.
1291
1292         Now that the sdk_build variable is available, we can remove these two differences
1293         as well. This goes together with Adam's bug 90920.
1294
1295         After this patch, the whole Tools/ directory will be unforked :-).
1296
1297         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1298
1299 2012-08-02  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1300
1301         [Qt] MSVC specific buildfix for DRT.
1302         https://bugs.webkit.org/show_bug.cgi?id=92978
1303
1304         Reviewed by Simon Hausmann.
1305
1306         DumpRenderTree/qt subdirectory is missing from generated makefile under MSVC build, need to be added to the pro file.
1307
1308         * DumpRenderTree/qt/DumpRenderTree.pro:
1309
1310 2012-08-02  Alexander Shalamov  <alexander.shalamov@intel.com>
1311
1312         [EFL][WK2] WTR is failing when X server is not running
1313         https://bugs.webkit.org/show_bug.cgi?id=92719
1314
1315         Reviewed by Hajime Morita.
1316
1317         EFL's WebKitTestRunner doesn't execute tests when X server is not running.
1318         This patch fixes the problem by checking environment variable before ecore x initialization.
1319
1320         * Scripts/webkitpy/layout_tests/port/efl.py:
1321         (EflPort.setup_environ_for_server):
1322         * WebKitTestRunner/efl/main.cpp:
1323         (main):
1324
1325 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1326
1327         REGRESSION(r123893): Reftest mismatches are run through ImageDiff with 0.1 tolerance
1328         https://bugs.webkit.org/show_bug.cgi?id=92847
1329
1330         Reviewed by Ojan Vafai.
1331
1332         I was failing to distinguish between 'None' and 0 :(. Fixed and added tests.
1333
1334         * Scripts/webkitpy/layout_tests/port/base.py:
1335         (Port.diff_image):
1336         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1337         (PortTestCase.test_diff_image.make_proc):
1338         (PortTestCase.test_diff_image):
1339
1340 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1341
1342         test-webkitpy: clean up handling of tests to skip
1343         https://bugs.webkit.org/show_bug.cgi?id=92909
1344
1345         Reviewed by Ryosuke Niwa.
1346
1347         This change moves the handling of tests to skip into main.py
1348         where it is at least slightly more findable and generic.
1349
1350         Also fix a couple of lint nits.
1351
1352         * Scripts/webkitpy/test/finder.py:
1353         (Finder.__init__):
1354         (Finder.skip):
1355         (Finder._default_names):
1356         * Scripts/webkitpy/test/main.py:
1357         (main):
1358         (Tester.skip):
1359         * Scripts/webkitpy/test/main_unittest.py:
1360         (TesterTest.test_no_tests_found):
1361         * Scripts/webkitpy/test/runner_unittest.py:
1362
1363 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1364
1365         test-webkitpy: remove --skip-integrationtests flag
1366         https://bugs.webkit.org/show_bug.cgi?id=92907
1367
1368         Reviewed by Ryosuke Niwa.
1369
1370         This flag is no longer used since the tests complete quickly.
1371         
1372         Also clean up the unused skip_if_parallel arg in finder, and
1373         make a couple of lint fixes.
1374
1375         * Scripts/webkitpy/test/finder.py:
1376         (Finder.find_names):
1377         (Finder._default_names):
1378         * Scripts/webkitpy/test/finder_unittest.py:
1379         (FinderTest.check_names):
1380         (FinderTest.test_default_names):
1381         * Scripts/webkitpy/test/main.py:
1382         (Tester._parse_args):
1383         (Tester.run):
1384         * Scripts/webkitpy/test/main_unittest.py:
1385         (TesterTest.test_no_tests_found):
1386
1387 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
1388
1389         Generalize SheriffIRCBot to prepare for PerfBot
1390         https://bugs.webkit.org/show_bug.cgi?id=92912
1391
1392         Reviewed by Adam Barth.
1393
1394         Renamed SheriffIRCBot to IRCBot and generalized to support non-sheriffbot IRC bot in the future.
1395         This will be useful when I add an experimental perf EWS IRC bot.
1396
1397         * Scripts/webkitpy/tool/bot/irc_command.py:
1398         (Whois.execute):
1399         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1400         (IRCCommandTest):
1401         * Scripts/webkitpy/tool/bot/ircbot.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py.
1402         (Eliza): Moved from irc_command.
1403         (Eliza.__init__):
1404         (Eliza.execute):
1405         (IRCBot):
1406         (IRCBot.__init__):
1407         (IRCBot.irc_delegate):
1408         (IRCBot._parse_command_and_args):
1409         (IRCBot.process_message):
1410         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py.
1411         (run):
1412         (IRCBotTest):
1413         (IRCBotTest.test_eliza): Moved from IRCCommandTest.
1414         (IRCBotTest.test_parse_command_and_args):
1415         (IRCBotTest.test_exception_during_command):
1416         * Scripts/webkitpy/tool/bot/sheriffircbot.py: Removed.
1417         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Removed.
1418         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1419         (SheriffBot.begin_work_queue):
1420         * Scripts/webkitpy/webkitpy.pyproj:
1421
1422 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1423
1424         nrwt: reenable the test for --verbose working in child processes
1425         https://bugs.webkit.org/show_bug.cgi?id=92894
1426
1427         Reviewed by Ryosuke Niwa.
1428
1429         This change rewrites the test to not use outputcapture, meaning
1430         that the MockHost can propagate to Worker properly and things
1431         work again :).
1432
1433         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1434         (MainTest.test_verbose_in_child_processes):
1435
1436 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
1437
1438         run-perf-tests --build-directory doesn't work
1439         https://bugs.webkit.org/show_bug.cgi?id=92051
1440
1441         Reviewed by Dirk Pranke.
1442
1443         The bug was caused by not prepending build_directory even when one is defined.
1444         Fixed that.
1445
1446         * Scripts/webkitpy/layout_tests/port/base.py:
1447         (Port._build_path):
1448         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1449         (PortTest.test_build_path):
1450
1451 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1452
1453         Unreviewed, rolling out r123865.
1454         http://trac.webkit.org/changeset/123865
1455         https://bugs.webkit.org/show_bug.cgi?id=92891
1456
1457         This patch is causing the style-queue to fall behind
1458         (Requested by abarth on #webkit).
1459
1460         * Scripts/webkitpy/tool/commands/queues.py:
1461         (AbstractReviewQueue.begin_work_queue):
1462         (StyleQueue.__init__):
1463         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1464         (StyleQueueTest.test_style_queue_with_style_exception):
1465         (test_style_queue_with_watch_list_exception):
1466
1467 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
1468
1469         run-perf-tests throws an exception when the output json is malformed
1470         https://bugs.webkit.org/show_bug.cgi?id=92887
1471
1472         Reviewed by Dirk Pranke.
1473
1474         Catch exceptions and gracefully fail. Also split _generate_json into smaller methods.
1475
1476         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1477         (PerfTestsRunner):
1478         (PerfTestsRunner.run):
1479         (PerfTestsRunner._generate_output): Extracted from _generate_json.
1480         (PerfTestsRunner._merge_source_json): Ditto; catch all exceptions since they are too many
1481         exceptions to consder here.
1482         (PerfTestsRunner._merge_outputs): Ditto.
1483         (PerfTestsRunner._generate_output_files): Extracted from _generate_json.
1484         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1485         (_test_run_with_json_output): Don't assert logs when we except an non-zero exit code.
1486         (create_runner_and_setup_results_template): Extracted from test_run_generates_results_page.
1487         (test_run_generates_results_page):
1488         (test_run_with_bad_output_json): Added.
1489         (test_run_with_bad_json_source): Added.
1490         (test_run_with_upload_json):
1491
1492 2012-08-01  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1493
1494         Regression(r124135): nrwt: --verbose logging does not work right on windows
1495         https://bugs.webkit.org/show_bug.cgi?id=92845
1496
1497         Reviewed by Dirk Pranke.
1498
1499         Disabled the failing test. The Workers spawned by this test are using Host()
1500         instead of MockHost() and trying to access the real filesystem instead of the
1501         MockFilesytem.
1502
1503         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1504         (MainTest.disabled_test_verbose):
1505
1506 2012-08-01  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1507
1508         keyring.get_password may raise an exception.
1509         https://bugs.webkit.org/show_bug.cgi?id=92876
1510
1511         Reviewed by Dirk Pranke.
1512
1513         keyring.get_password sometimes raises an exception. We wrap this call,
1514         and also set_password to avoid breaking webkit-patch in that case.
1515
1516         * Scripts/webkitpy/common/net/credentials.py:
1517         (Credentials._offer_to_store_credentials_in_keyring):
1518         (Credentials.read_credentials):
1519
1520 2012-08-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1521
1522         Layout Test fast/text/descent-clip-in-scaled-page.html is failing on linux since it was added
1523         https://bugs.webkit.org/show_bug.cgi?id=91386
1524
1525         Reviewed by Tony Chang.
1526
1527         Added font mapping from SubpixelPositioningAhem to Ahem on Linux and Android
1528         (used in layout test fast/text/descent-clip-in-scaled-page.html).
1529         Added font mapping from SubpixelPositioning to Times New Roman on Android to match Linux
1530         (used in platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html)
1531
1532         * DumpRenderTree/chromium/android_main_fonts.xml:
1533         * DumpRenderTree/chromium/fonts.conf:
1534
1535 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1536
1537         Unreviewed, rolling out r124325.
1538         http://trac.webkit.org/changeset/124325
1539         https://bugs.webkit.org/show_bug.cgi?id=92865
1540
1541         broke android build (Requested by mnaganov on #webkit).
1542
1543         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1544
1545 2012-08-01  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1546
1547         [EFL] Dump a backtrace in case of a crash on the UIProcess
1548         https://bugs.webkit.org/show_bug.cgi?id=92843
1549
1550         Reviewed by Csaba Osztrogonác.
1551
1552         We are already dumping the backtraces when automated tests are
1553         crashing, but only for the WebProcess. This patch adds the same
1554         hooks for the UIProcess.
1555
1556         * TestWebKitAPI/efl/main.cpp:
1557         (main):
1558         * WebKitTestRunner/efl/main.cpp:
1559         (main):
1560
1561 2012-08-01  Adam Barth  <abarth@webkit.org>
1562
1563         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
1564         https://bugs.webkit.org/show_bug.cgi?id=90920
1565
1566         Reviewed by Tony Chang.
1567
1568         This patch contains the last few small changes to DumpRenderTree.gyp
1569         from the chromium-android branch. After this change, this file will be
1570         fully merged.
1571
1572         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1573
1574 2012-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1575
1576         [Qt] ImageDiff should use float division instead of integer
1577         https://bugs.webkit.org/show_bug.cgi?id=92859
1578
1579         Reviewed by Zoltan Herczeg.
1580
1581         * DumpRenderTree/qt/ImageDiff.cpp:
1582         (main):
1583
1584 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1585
1586         Unreviewed, rolling out r124313.
1587         http://trac.webkit.org/changeset/124313
1588         https://bugs.webkit.org/show_bug.cgi?id=92855
1589
1590         Compilation failed on Chromium ports (Requested by yosin on
1591         #webkit).
1592
1593         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1594         * DumpRenderTree/DumpRenderTree.gypi:
1595         * DumpRenderTree/DumpRenderTree.h:
1596         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1597         * DumpRenderTree/DumpRenderTreeCommon.cpp: Removed.
1598         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1599         (runTest):
1600         (main):
1601         * DumpRenderTree/chromium/TestShell.cpp:
1602         (TestShell::TestShell):
1603         (TestShell::runFileTest):
1604         (TestShell::dump):
1605         * DumpRenderTree/chromium/TestShell.h:
1606         (TestParams):
1607         (TestParams::TestParams):
1608         (TestShell):
1609         * DumpRenderTree/efl/CMakeLists.txt:
1610         * DumpRenderTree/efl/DumpRenderTree.cpp:
1611         (parseCommandLineOptions):
1612         (getFinalTestURL):
1613         (getExpectedPixelHash):
1614         (runTest):
1615         (shouldDumpPixelsAndCompareWithExpected):
1616         (main):
1617         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1618         (initializeGlobalsFromCommandLineOptions):
1619         (dump):
1620         (runTest):
1621         (main):
1622         * DumpRenderTree/mac/DumpRenderTree.mm:
1623         (initializeGlobalsFromCommandLineOptions):
1624         (dumpRenderTree):
1625         (dump):
1626         (runTest):
1627         * DumpRenderTree/qt/DumpRenderTree.pro:
1628         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1629         (WebCore::DumpRenderTree::processLine):
1630         * DumpRenderTree/win/DumpRenderTree.cpp:
1631         (dump):
1632         (runTest):
1633         (dllLauncherEntryPoint):
1634         * DumpRenderTree/win/DumpRenderTree.vcproj:
1635         * DumpRenderTree/wscript:
1636         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1637         (dump):
1638         (runTest):
1639         (MyApp::OnInit):
1640         * GNUmakefile.am:
1641         * Scripts/old-run-webkit-tests:
1642         * Scripts/webkitpy/layout_tests/port/base.py:
1643         (Port.supports_switching_pixel_tests_per_test):
1644         (Port):
1645         (Port._supports_switching_pixel_tests_per_test):
1646         (Port.should_run_as_pixel_test):
1647         * Scripts/webkitpy/layout_tests/port/driver.py:
1648         (Driver.cmd_line):
1649         (Driver._command_from_driver_input):
1650         * Scripts/webkitpy/layout_tests/port/qt.py:
1651         (QtPort._supports_switching_pixel_tests_per_test):
1652         * Scripts/webkitpy/layout_tests/port/test.py:
1653         (TestPort.supports_switching_pixel_tests_per_test):
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::TestController::TestController):
1656         (WTR::TestController::initialize):
1657         (WTR::TestController::runTest):
1658         * WebKitTestRunner/TestController.h:
1659         (TestController):
1660
1661 2012-08-01  Balazs Kelemen  <kbalazs@webkit.org>
1662
1663         All ports should support per test switching of pixel testing
1664         https://bugs.webkit.org/show_bug.cgi?id=92398
1665
1666         Reviewed by Dirk Pranke.
1667
1668         Teach all test drivers to accept a per test control of whether
1669         to dump pixels. Drivers now accept a -p/--pixel-test argument
1670         on the standart input that means that running the current
1671         test as pixel test is allowed (even if the expected hash is
1672         missing). Removed the --pixel-tests command line option since
1673         there is no need for it anymore.
1674
1675         * DumpRenderTree/DumpRenderTree.gypi:
1676         * DumpRenderTree/DumpRenderTree.h:
1677         (TestCommand::TestCommand):
1678         (TestCommand):
1679         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1680         * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
1681         (CommandTokenizer):
1682         (CommandTokenizer::CommandTokenizer):
1683         (CommandTokenizer::pump):
1684         (CommandTokenizer::next):
1685         (CommandTokenizer::hasNext):
1686         (die):
1687         (parseInputLine):
1688         Common logic to parse the input line from the standard input (or from the command line
1689         in standalone mode). Made it somewhat general so we can easily add more arguments if
1690         there is a need.
1691         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1692         (runTest):
1693         (main):
1694         * DumpRenderTree/chromium/TestShell.cpp:
1695         (TestShell::TestShell):
1696         (TestShell::runFileTest):
1697         (TestShell::dump):
1698         * DumpRenderTree/chromium/TestShell.h:
1699         (TestParams::TestParams):
1700         (TestShell):
1701         * DumpRenderTree/efl/CMakeLists.txt:
1702         * DumpRenderTree/efl/DumpRenderTree.cpp:
1703         (parseCommandLineOptions):
1704         (runTest):
1705         (shouldDumpPixelsAndCompareWithExpected):
1706         (main):
1707         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1708         (initializeGlobalsFromCommandLineOptions):
1709         (dump):
1710         * DumpRenderTree/mac/DumpRenderTree.mm:
1711         (initializeGlobalsFromCommandLineOptions):
1712         (dumpRenderTree):
1713         * DumpRenderTree/qt/DumpRenderTree.pro:
1714         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1715         (WebCore::DumpRenderTree::processLine):
1716         * DumpRenderTree/win/DumpRenderTree.cpp:
1717         (dump):
1718         (runTest):
1719         (dllLauncherEntryPoint):
1720         * DumpRenderTree/win/DumpRenderTree.vcproj:
1721         * DumpRenderTree/wscript:
1722         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1723         (dump):
1724         (runTest):
1725         (MyApp::OnInit):
1726         * Scripts/old-run-webkit-tests: Pass --pixel-test before the hash.
1727         Changed the separator form ' to : because it don't need to be escaped
1728         when passing manually on the comand line.
1729         * Scripts/webkitpy/layout_tests/port/base.py:
1730         (Port.should_run_as_pixel_test): Removed now that all ports supports it.
1731         * Scripts/webkitpy/layout_tests/port/driver.py:
1732         (Driver.cmd_line): Don't pass --pixel-tests anymore.
1733         (Driver._command_from_driver_input):
1734
1735         * WebKitTestRunner/TestController.cpp:
1736         (WTR::TestController::TestController):
1737         (WTR::TestController::initialize):
1738         (WTR::TestCommand::TestCommand):
1739         (TestCommand):
1740         (WTR):
1741         (CommandTokenizer):
1742         (WTR::CommandTokenizer::CommandTokenizer):
1743         (WTR::CommandTokenizer::pump):
1744         (WTR::CommandTokenizer::next):
1745         (WTR::CommandTokenizer::hasNext):
1746         (WTR::die):
1747         (WTR::parseInputLine):
1748         (WTR::TestController::runTest):
1749         * WebKitTestRunner/TestController.h:
1750         (TestController):
1751         Duplicate the logic for parsing the command line because
1752         unfortunately there is no way to share code between
1753         WebKitTestRunner and DumpRenderTree.
1754
1755 2012-08-01  Martin Robinson  <mrobinson@igalia.com>
1756
1757         Add the jhbuild source directory to the __builtin__ object
1758
1759         Reviewed by Philippe Normand.
1760
1761         It seems that the jhbuild script explicitly looks for the SRCDIR __builtin__ when
1762         initializing. This is necessary for loading the jhbuild from the checkout directory.
1763
1764         * jhbuild/jhbuildutils.py:
1765         (enter_jhbuild_environment_if_available): Set SRCDIR to the source directory.
1766
1767 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1768
1769         nrwt: move actual test-running code into layout_test_runner.py
1770         https://bugs.webkit.org/show_bug.cgi?id=92806
1771
1772         Reviewed by Ryosuke Niwa.
1773
1774         This is the final patch in manager-refactoring series (for now).
1775         This moves all of the logic to actually run the tests into
1776         layout_test_runner (in a new LayoutTestRunner) class. Now
1777         the mechanics of actually executing all of  the tests are
1778         contained in one file (of course the actual work of talking to
1779         DRT/WTR and diff'ing the results is still in single_test_runner).
1780
1781         Now manager is left with setting up and tearing down the test
1782         environment, finding the tests to run, and processing the
1783         results of the tests, which is a pretty managable amount of code
1784         (no pun intended).
1785
1786         The unit tests for manager were split in two and all of the
1787         runner-specific tests moved into layout_test_runner_unittest.
1788         They were significantly cleaned up to be easier to read and
1789         maintain as a part of this.
1790
1791         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1792         (TestRunInterruptedException):
1793         (TestRunInterruptedException.__init__):
1794         (TestRunInterruptedException.__reduce__):
1795         (LayoutTestRunner):
1796         (LayoutTestRunner.__init__):
1797         (LayoutTestRunner.test_key):
1798         (LayoutTestRunner.run_tests):
1799         (LayoutTestRunner.run_tests.worker_factory):
1800         (LayoutTestRunner.run_tests.instead):
1801         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
1802         (LayoutTestRunner._interrupt_if_at_failure_limits):
1803         (LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
1804         (LayoutTestRunner._update_summary_with_result):
1805         (LayoutTestRunner.start_servers_with_lock):
1806         (LayoutTestRunner.stop_servers_with_lock):
1807         (LayoutTestRunner.handle):
1808         (LayoutTestRunner._handle_started_test):
1809         (LayoutTestRunner._handle_finished_test_list):
1810         (LayoutTestRunner._handle_finished_test_list.find):
1811         (LayoutTestRunner._handle_finished_test):
1812         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1813         (FakePrinter):
1814         (FakePrinter.print_workers_and_shards):
1815         (FakePrinter.print_finished_test):
1816         (FakePrinter.write):
1817         (FakePrinter.write_update):
1818         (FakePrinter.flush):
1819         (LockCheckingRunner):
1820         (LockCheckingRunner.__init__):
1821         (LockCheckingRunner.handle_finished_list):
1822         (LayoutTestRunnerTests):
1823         (LayoutTestRunnerTests._runner):
1824         (LayoutTestRunnerTests._result_summary):
1825         (LayoutTestRunnerTests._run_tests):
1826         (LayoutTestRunnerTests.test_http_locking):
1827         (LayoutTestRunnerTests.test_perf_locking):
1828         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1829         (LayoutTestRunnerTests.test_update_summary_with_result):
1830         (LayoutTestRunnerTests.test_servers_started):
1831         (LayoutTestRunnerTests.test_servers_started.start_http_server):
1832         (LayoutTestRunnerTests.test_servers_started.start_websocket_server):
1833         (LayoutTestRunnerTests.test_servers_started.stop_http_server):
1834         (LayoutTestRunnerTests.test_servers_started.stop_websocket_server):
1835         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1836         (summarize_results):
1837         (Manager.__init__):
1838         (Manager._is_http_test):
1839         (Manager):
1840         (Manager._is_websocket_test):
1841         (Manager._websocket_tests):
1842         (Manager._prepare_lists):
1843         (Manager._is_ref_test):
1844         (Manager.run):
1845         (Manager._run_tests):
1846         (Manager._look_for_new_crash_logs):
1847         (Manager._show_results_html_file):
1848         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1849         (ManagerTest.test_look_for_new_crash_logs):
1850         (ResultSummaryTest.summarized_results):
1851         (ResultSummaryTest.test_summarized_results_wontfix):
1852
1853 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1854
1855         nrwt: move sharding logic into layout_test_runner.py
1856         https://bugs.webkit.org/show_bug.cgi?id=92805
1857
1858         Reviewed by Ryosuke Niwa.
1859
1860         The sharding logic is specific to how we actually run the tests,
1861         so it belongs in this file instead of manager.py or finder.py.
1862
1863         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1864         (Worker._run_single_test):
1865         (TestShard):
1866         (TestShard.__init__):
1867         (TestShard.__repr__):
1868         (TestShard.__eq__):
1869         (Sharder):
1870         (Sharder.__init__):
1871         (Sharder.shard_tests):
1872         (Sharder.shard_tests.or):
1873         (Sharder._shard_in_two):
1874         (Sharder._shard_every_file):
1875         (Sharder._shard_by_directory):
1876         (Sharder._resize_shards):
1877         (Sharder._resize_shards.divide_and_round_up):
1878         (Sharder._resize_shards.extract_and_flatten):
1879         (Sharder._resize_shards.split_at):
1880         (Sharder._dir_for_test_input):
1881         (Sharder.test_key):
1882         (Sharder.natural_sort_key):
1883         (Sharder.natural_sort_key.tryint):
1884         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Added.
1885         (SharderTests):
1886         (SharderTests.get_test_input):
1887         (SharderTests.get_shards):
1888         (SharderTests.get_shards.split):
1889         (SharderTests.assert_shards):
1890         (SharderTests.test_shard_by_dir):
1891         (SharderTests.test_shard_by_dir_sharding_ref_tests):
1892         (SharderTests.test_shard_every_file):
1893         (SharderTests.test_shard_in_two):
1894         (SharderTests.test_shard_in_two_sharding_ref_tests):
1895         (SharderTests.test_shard_in_two_has_no_locked_shards):
1896         (SharderTests.test_shard_in_two_has_no_unlocked_shards):
1897         (SharderTests.test_multiple_locked_shards):
1898         (NaturalCompareTest):
1899         (NaturalCompareTest.assert_cmp):
1900         (NaturalCompareTest.test_natural_compare):
1901         (KeyCompareTest):
1902         (KeyCompareTest.setUp):
1903         (KeyCompareTest.setUp.split):
1904         (KeyCompareTest.assert_cmp):
1905         (KeyCompareTest.test_test_key):
1906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1907         (Manager.__init__):
1908         (Manager._prepare_lists):
1909         (Manager._is_ref_test):
1910         (Manager._run_tests):
1911         (Manager._handle_finished_test):
1912         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1913         (ManagerTest.get_options):
1914         (ManagerTest.test_interrupt_if_at_failure_limits):
1915         (ManagerTest.test_update_summary_with_result):
1916         (ManagerTest.test_needs_servers.get_manager_with_tests):
1917         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
1918         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
1919         (ManagerTest.test_servers_started):
1920         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1921         (parse_args):
1922
1923 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1924
1925         nrwt: rename worker.py to layout_test_runner.py
1926         https://bugs.webkit.org/show_bug.cgi?id=92804
1927
1928         Reviewed by Ojan Vafai.
1929
1930         Home stretch of this round of manager refactoring ... I will be
1931         moving all of the actual test-running code (which includes the
1932         code that shards the tests for the workers) into a different
1933         module, and it makes sense for that module to contain the actual
1934         worker code, so I'm renaming worker.py to layout_test_runner.py.
1935
1936         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/worker.py.
1937         (Worker):
1938         (Worker.__init__):
1939         (Worker.__del__):
1940         (Worker.start):
1941         (Worker.handle):
1942         (Worker._update_test_input):
1943         (Worker._run_test):
1944         (Worker.stop):
1945         (Worker._timeout):
1946         (Worker._kill_driver):
1947         (Worker._run_test_with_timeout):
1948         (Worker._clean_up_after_test):
1949         (Worker._run_test_in_another_thread):
1950         (Worker._run_test_in_another_thread.SingleTestThread):
1951         (Worker._run_test_in_another_thread.SingleTestThread.__init__):
1952         (Worker._run_test_in_another_thread.SingleTestThread.run):
1953         (Worker._run_test_in_this_thread):
1954         (Worker._run_single_test):
1955         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1956         (Manager._run_tests.worker_factory):
1957
1958 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1959
1960         nrwt: clean up names in sharding code
1961         https://bugs.webkit.org/show_bug.cgi?id=92785
1962
1963         Reviewed by Ryosuke Niwa.
1964
1965         More refactoring ... this makes the methods use TestInputs
1966         consistently (and updates the names accordingly) and improves
1967         encapsulation a bit. The sharding code is now pretty
1968         self-contained.
1969
1970         This change adds no new functionality and is covered by the
1971         existing (updated) tests.
1972
1973         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1974         (TestShard.visible.__init__):
1975         (TestShard.visible.__repr__):
1976         (Manager._dir_for_test_input):
1977         (Manager._shard_tests):
1978         (Manager._shard_in_two):
1979         (Manager._shard_every_file):
1980         (Manager._shard_by_directory):
1981         (Manager._run_tests):
1982         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1983         (ManagerWrapper._test_input_for_file):
1984         (ShardingTests.get_shards):
1985         * Scripts/webkitpy/layout_tests/models/test_input.py:
1986         (TestInput.__init__):
1987         (TestInput.__repr__):
1988
1989 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1990
1991         nrwt: clean up TestInputs in preparation for cleaning up sharding
1992         https://bugs.webkit.org/show_bug.cgi?id=92784
1993
1994         Reviewed by Ryosuke Niwa.
1995
1996         Currently, in order to shard the tests you need to refer to
1997         state in the manager as well as the state in the TestInputs;
1998         this change embeds the necessary state into the TestInputs so
1999         sharding them can be a standalone operation.
2000
2001         The actual clean up of the sharding will follow in a subsequent patch.
2002
2003         Covered by existing tests; no new functionality. However, I did
2004         rework the sharding tests to be less dependent on the test
2005         scaffolding and easier to follow.
2006
2007         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2008         (Manager._test_input_for_file):
2009         (Manager._shard_in_two):
2010         (Manager._shard_every_file):
2011         (Manager._shard_by_directory):
2012         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2013         (ManagerWrapper._test_input_for_file):
2014         (ShardingTests.assert_shards):
2015         (ShardingTests.test_shard_by_dir):
2016         (ShardingTests.test_shard_by_dir_sharding_ref_tests):
2017         (ShardingTests.test_shard_every_file):
2018         (ShardingTests.test_shard_in_two):
2019         (ShardingTests.test_shard_in_two_sharding_ref_tests):
2020         (ShardingTests.test_shard_in_two_has_no_unlocked_shards):
2021         (ShardingTests.test_multiple_locked_shards):
2022         * Scripts/webkitpy/layout_tests/models/test_input.py:
2023         (TestInput.__init__):
2024         (TestInput.__repr__):
2025
2026 2012-07-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2027
2028         [EFL] Dump a backtrace in case of a crash
2029         https://bugs.webkit.org/show_bug.cgi?id=92489
2030
2031         Reviewed by Csaba Osztrogonác.
2032
2033         Dump a stack trace in case of a unexpected signal. This should
2034         provide a better report at the build bots when WTR crashes.
2035
2036         * DumpRenderTree/efl/DumpRenderTree.cpp:
2037         (main):
2038         * TestWebKitAPI/efl/InjectedBundleController.cpp:
2039         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2040         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
2041         (WTR::InjectedBundle::platformInitialize):
2042
2043 2012-07-31  Joshua Netterfield  <jnetterfield@rim.com>
2044
2045         [BlackBerry] Enable CSS Filter Effects
2046         https://bugs.webkit.org/show_bug.cgi?id=92685
2047
2048         Reviewed by Rob Buis.
2049
2050         Enable CSS filter effects, with the exception of custom effects (CSS shaders) and reference effects (SVG effects)
2051
2052         Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.
2053
2054         * Scripts/webkitperl/FeatureList.pm: Acknowledge CSS filter effects.
2055
2056 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2057
2058         nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
2059         https://bugs.webkit.org/show_bug.cgi?id=92781
2060
2061         Reviewed by Ryosuke Niwa.
2062
2063         More refactoring ... rename prepare_lists_and_print_output to
2064         just prepare_lists so that it only has a single purpose, and
2065         clean up the surrounding code a bit as well.
2066
2067         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2068         (Manager._collect_tests):
2069         (Manager._prepare_lists):
2070         (Manager._set_up_run):
2071         (Manager.run):
2072
2073 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2074
2075         nrwt: clean up self._test_files_list vs. self._test_files, other nits
2076         https://bugs.webkit.org/show_bug.cgi?id=92702
2077
2078         Reviewed by Ojan Vafai.
2079
2080         Get rid of self._test_files, rename self._test_files_list to
2081         self._test_names (removing the confusion between the two fields).
2082
2083         Also inline the one call to _parse_expectations, remove the one
2084         use of more_tests_to_skip, and fix a couple of minor nits.
2085
2086         * Scripts/webkitpy/layout_tests/controllers/finder.py:
2087         (LayoutTestFinder.split_into_chunks):
2088         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2089         (Manager.__init__):
2090         (Manager._collect_tests):
2091         (Manager._http_tests):
2092         (Manager._websocket_tests):
2093         (Manager._is_perf_test):
2094         (Manager.prepare_lists_and_print_output):
2095         (Manager.needs_servers):
2096         (Manager.run):
2097         (Manager._mark_interrupted_tests_as_skipped):
2098         (Manager._update_summary_with_result):
2099         (Manager._upload_json_files):
2100         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2101         (ManagerTest.test_interrupt_if_at_failure_limits):
2102         (ManagerTest.test_needs_servers.get_manager_with_tests):
2103         (ManagerTest.test_servers_started):
2104
2105 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2106
2107         nrwt: --verbose logging does not work right on windows
2108         https://bugs.webkit.org/show_bug.cgi?id=92673
2109
2110         Reviewed by Ojan Vafai.
2111
2112         Add a test for r124090.
2113
2114         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2115         (MainTest.test_verbose):
2116
2117 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2118
2119         REGRESSION(124116): Number of skipped tests isn't printed anymore
2120         https://bugs.webkit.org/show_bug.cgi?id=92736
2121
2122         Reviewed by Tony Chang.
2123
2124         Add the skipped number back in; it was useful ... also clean up
2125         the formatting a little bit.
2126
2127         * Scripts/webkitpy/layout_tests/views/printing.py:
2128         (Printer.print_found):
2129
2130 2012-07-31  Hans Wennborg  <hans@chromium.org>
2131
2132         Speech JavaScript API: Throw exception for start() when already started
2133         https://bugs.webkit.org/show_bug.cgi?id=92756
2134
2135         Reviewed by Adam Barth.
2136
2137         Fix the task queue in MockWebSpeechRecognizer.
2138         It's important that we remove the task from the queue before we run
2139         it, as running the task could alter the queue's state.
2140
2141         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2142         (MockWebSpeechRecognizer::abort):
2143         (MockWebSpeechRecognizer::setError):
2144         (MockWebSpeechRecognizer::clearTaskQueue):
2145         (MockWebSpeechRecognizer::StepTask::runIfValid):
2146         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2147         (MockWebSpeechRecognizer):
2148
2149 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2150
2151         nrwt: move handling the initial list of tests to skip to finder
2152         https://bugs.webkit.org/show_bug.cgi?id=92701
2153
2154         Reviewed by Ryosuke Niwa.
2155
2156         More refactoring of manager ...
2157
2158         * Scripts/webkitpy/layout_tests/controllers/finder.py:
2159         (LayoutTestFinder.skip_tests):
2160         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2161         (Manager._collect_tests):
2162         (Manager.prepare_lists_and_print_output):
2163
2164 2012-07-31  Alexey Proskuryakov  <ap@apple.com>
2165
2166         [WK2] Kill the concept of secondary shared process
2167         https://bugs.webkit.org/show_bug.cgi?id=92676
2168
2169         Reviewed by Sam Weinig.
2170
2171         * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.
2172         Don't create a new context for every view.
2173
2174 2012-07-31  Peter Beverloo  <peter@chromium.org>
2175
2176         [Chromium] Don't use ninja for building Chromium for Android
2177         https://bugs.webkit.org/show_bug.cgi?id=92764
2178
2179         Reviewed by Adam Barth.
2180
2181         When Ninja projects files are generated (which will be done for Android),
2182         make sure that the Android builder doesn't unintentionally switch to
2183         using Ninja. We should make that switch at a predetermined time.
2184
2185         * Scripts/webkitdirs.pm:
2186         (buildChromium):
2187
2188 2012-07-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2189
2190         Add a mechanism to dump the stack trace in case of a crash
2191         https://bugs.webkit.org/show_bug.cgi?id=92666
2192
2193         Reviewed by Csaba Osztrogonác.
2194
2195         Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
2196         and eliminate some duplicated code.
2197
2198         * DumpRenderTree/qt/main.cpp:
2199         (main):
2200         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2201         (WTR::InjectedBundle::platformInitialize):
2202
2203 2012-07-31  Jochen Eisinger  <jochen@chromium.org>
2204
2205         [chromium] move EventSender into TestRunner.a
2206         https://bugs.webkit.org/show_bug.cgi?id=92277
2207
2208         Reviewed by Adam Barth.
2209
2210         * DumpRenderTree/DumpRenderTree.gypi:
2211         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2212         * DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
2213         * DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
2214         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
2215         (TestInterfaces::Internal::eventSender):
2216         (TestInterfaces::Internal):
2217         (TestInterfaces::Internal::Internal):
2218         (TestInterfaces::Internal::~Internal):
2219         (TestInterfaces::Internal::setWebView):
2220         (TestInterfaces::Internal::setDelegate):
2221         (TestInterfaces::Internal::bindTo):
2222         (TestInterfaces::Internal::resetAll):
2223         (TestInterfaces::eventSender):
2224         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
2225         (TestInterfaces):
2226         * DumpRenderTree/chromium/TestShell.cpp:
2227         (TestShell::initialize):
2228         (TestShell::createMainWindow):
2229         (TestShell::~TestShell):
2230         (TestShell::resetTestController):
2231         (TestShell::bindJSObjectsToWindow):
2232         * DumpRenderTree/chromium/TestShell.h:
2233         (TestShell::eventSender):
2234         (TestShell):
2235         * DumpRenderTree/chromium/WebViewHost.cpp:
2236
2237 2012-07-31  Jochen Eisinger  <jochen@chromium.org>
2238
2239         Unreviewed. Update watchlist
2240
2241         * Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped
2242
2243 2012-07-31  Kent Tamura  <tkent@chromium.org>
2244
2245         Unreviewed, update watchlist
2246
2247         * Scripts/webkitpy/common/config/watchlist:
2248         - Improve "Forms" filename pattern.
2249         - tkent stops watching Chromium DRT. It was not so helpful.
2250
2251 2012-07-31  Martin Robinson  <mrobinson@igalia.com>
2252
2253         [jhbuild] Also try to load jhbuild Python module from the source checkout
2254
2255         Reviewed by Philippe Normand.
2256
2257         JHBuild also seems to have an installation mode where it prefers to load its
2258         Python modules from the source checkout. This seems to be used particularly
2259         on the GTK+ 64-bit release bot. We should fall back to this mode.
2260
2261         * jhbuild/jhbuildutils.py:
2262         (enter_jhbuild_environment_if_available): Use the source checkout if there
2263         is no installation path.
2264
2265 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
2266
2267         Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.
2268
2269         * MiniBrowser/win/BrowserView.cpp:
2270         (BrowserView::create):
2271
2272 2012-07-30  Sam Weinig  <sam@webkit.org>
2273
2274         Rename WebKit2.h to WebKit2_C.h
2275         https://bugs.webkit.org/show_bug.cgi?id=92704
2276
2277         Reviewed by Dan Bernstein.
2278
2279         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2280         * MiniBrowser/win/BrowserView.h:
2281         * TestWebKitAPI/config.h:
2282         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2283         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2284         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2285         * WebKitTestRunner/config.h:
2286         Update for changed header file name.
2287
2288 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2289
2290         chromium win compile broken after removing webkit.py
2291         https://bugs.webkit.org/show_bug.cgi?id=92549
2292
2293         Reviewed by Ryosuke Niwa.
2294
2295         Remove the stub file for webkit.py now that it's no longer
2296         necessary.
2297
2298         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
2299
2300 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
2301
2302         Windows build fix attempt after r124092.
2303
2304         * MiniBrowser/win/BrowserView.cpp:
2305         (BrowserView::create):
2306
2307 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
2308
2309         Remove erroneously committed debugging print call from a test.
2310
2311         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2312         (test_run_generates_results_page):
2313
2314 2012-07-30  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2315
2316         webkit-patch: system keyring is not used to read my password
2317         https://bugs.webkit.org/show_bug.cgi?id=92532
2318
2319         Reviewed by Dirk Pranke.
2320
2321         In case no username can be fetched from environment, git or keychain,
2322         prompt for username, and try to get password from keyring associated
2323         with that username.
2324
2325         * Scripts/webkitpy/common/net/credentials.py:
2326         (Credentials.read_credentials):
2327         * Scripts/webkitpy/common/net/credentials_unittest.py:
2328         (test_keyring_without_git_repo_nor_keychain):
2329         (test_keyring_without_git_repo_nor_keychain.MockKeyring):
2330         (test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
2331         (test_keyring_without_git_repo_nor_keychain.FakeCredentials):
2332         (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
2333         (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
2334         (test_keyring_without_git_repo_nor_keychain.FakeUser):
2335         (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
2336         (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):
2337
2338 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2339
2340         nrwt: move the code that identifies the chunk of tests to run into finder
2341         https://bugs.webkit.org/show_bug.cgi?id=92694
2342
2343         Reviewed by Ryosuke Niwa.
2344
2345         Another patch to make manager.py smaller and clearer; this patch moves
2346         the handling of breaking the list of tests into chunks (--run-part,
2347         --run-chunk) from manager.py to finder.py.
2348
2349         There are no functional changes and this is covered by existing tests.
2350
2351         * Scripts/webkitpy/layout_tests/controllers/finder.py:
2352         (Finder.__init__):
2353         (Finder._read_test_files):
2354         (Finder):
2355         (Finder.split_into_chunks_if_necessary):
2356         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2357         (Manager.__init__):
2358         (Manager._collect_tests):
2359         (Manager._parse_expectations):
2360         (Manager.prepare_lists_and_print_output):
2361
2362 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2363
2364         nrwt: split test-finding code out from manager.py
2365         https://bugs.webkit.org/show_bug.cgi?id=92693
2366
2367         Reviewed by Ryosuke Niwa.
2368
2369         In the interest of making manager.py smaller, this patch moves
2370         the code that actually takes the command line arguments and
2371         --test-file lists of tests to run and expands them into an
2372         actual list of tests out into a separate module.
2373
2374         * Scripts/webkitpy/layout_tests/controllers/finder.py: Added.
2375         (LayoutTestFinder):
2376         (LayoutTestFinder.__init__):
2377         (LayoutTestFinder.find_tests):
2378         (LayoutTestFinder._strip_test_dir_prefixes):
2379         (LayoutTestFinder._strip_test_dir_prefix):
2380         (LayoutTestFinder._read_test_names_from_file):
2381         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2382         (Manager._collect_tests):
2383         (Manager._handle_finished_test):
2384         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2385         (strip_comments):
2386
2387 2012-07-30  Adam Barth  <abarth@webkit.org>
2388
2389         commit-queue is corrupting ChangeLogs
2390         https://bugs.webkit.org/show_bug.cgi?id=92681
2391
2392         Reviewed by Tony Chang.
2393
2394         Some commits made with the commit-queue are ending up with duplicate
2395         ChangeLog entries. I've hot-patched the servers to not use a special
2396         merge driver for ChangeLogs, which should fix this issue. This patch
2397         removes the merge driver from our cold-boot.sh script so that we won't
2398         use it on new commit-queue instances.
2399
2400         * EWSTools/cold-boot.sh:
2401
2402 2012-07-28  Sam Weinig  <sam@webkit.org>
2403
2404         Add ability to load from a string to the ObjC WK API
2405         https://bugs.webkit.org/show_bug.cgi?id=92590
2406
2407         Reviewed by Dan Bernstein.
2408
2409         Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
2410         to greatly improve these tests (to test more than just not crashing) when methods to
2411         access page content are added (soon!).
2412
2413         Adds:
2414             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
2415             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
2416             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL
2417
2418         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2419         Adds tests and refactors delegates to not use global state.
2420
2421 2012-07-30  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2422
2423         [CMake] TestWebKitAPI bundle should link with WTF
2424         https://bugs.webkit.org/show_bug.cgi?id=92616
2425
2426         Reviewed by Antonio Gomes.
2427
2428         Fixes build when shared core is disabled.
2429
2430         * TestWebKitAPI/CMakeLists.txt:
2431
2432 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2433
2434         nrwt: clean up handling of 'expected' stats
2435         https://bugs.webkit.org/show_bug.cgi?id=92527
2436
2437         Reviewed by Tony Chang.
2438
2439         This patch alters the way we compute and log the "expected"
2440         results and how we treat skipped tests; we will now log the
2441         number of skipped tests separately from the categories, e.g.:
2442
2443         Found 31607 tests; running 24464.
2444         Expect: 23496 passes   (23496 now,    0 wontfix)
2445         Expect:   548 failures (  543 now,    5 wontfix)
2446         Expect:   420 flaky    (  245 now,  175 wontfix)
2447
2448         (so that the "expect" totals add up to the "running" totals);
2449         in addition, the totals in the one-line-progress reflect the
2450         number of tests we will actually run. If --iterations or
2451         --repeat-each are specified, the number of tests we run are
2452         multiplied as appropriate, but the "expect" numbers are
2453         unchanged, since we don't count multiple invocations of the same
2454         test multiple times. In addition, if we are using --run-part or
2455         --run-chunk, the tests we don't run are treated as skipped
2456         for consistency. We will also log the values for --iterations
2457         and --repeat each as part of the found/running line.
2458
2459         Previously the code had parsed and re-parsed the
2460         TestExpectations files several times in an attempt to come up
2461         with some sane statistics, but this was expensive and lead to
2462         confusing layer; treating files as skipped in the way described
2463         above is more consistent and cleaner.
2464
2465         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2466         (Manager._split_into_chunks_if_necessary):
2467         (Manager.prepare_lists_and_print_output):
2468         (Manager.run):
2469         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2470         (ManagerTest.test_interrupt_if_at_failure_limits):
2471         (ManagerTest.test_update_summary_with_result):
2472         (ManagerTest.test_look_for_new_crash_logs):
2473         (ResultSummaryTest.get_result_summary):
2474         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2475         (ResultSummary.__init__):
2476         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2477         (TestExpectationParser.expectation_for_skipped_test):
2478         (TestExpectations.__init__):
2479         (TestExpectations.add_skipped_tests):
2480           Here we make add_skipped_tests() public, so that we can update
2481           the expectations for tests that we are skipping due to
2482           --run-part or --run-chunk; we use the wontfix flag so that
2483           the tests that are intentionally skipped aren't considered
2484           "fixable".
2485         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2486         (SkippedTests.check):
2487         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2488         (parse_args):
2489         * Scripts/webkitpy/layout_tests/views/printing.py:
2490         (Printer.print_found):
2491         (Printer):
2492         (Printer.print_expected):
2493         (Printer._print_result_summary):
2494         (Printer._print_result_summary_entry):
2495           Here we split out printing the number of tests found and run
2496           from the expected results, to be clearer and so that we don't
2497           have to reparse the expectations to update the stats.
2498         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2499         (Testprinter.get_result_summary):
2500
2501 2012-07-30  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2502
2503         Propagate gesture events to plugins.
2504         https://bugs.webkit.org/show_bug.cgi?id=92281
2505
2506         Reviewed by Adam Barth.
2507
2508         Update TestWebPlugin to receive events, and output logs for the events.
2509
2510         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2511         (TestWebPlugin::handleInputEvent):
2512         * DumpRenderTree/chromium/TestWebPlugin.h:
2513         (TestWebPlugin::acceptsInputEvents):
2514         (TestWebPlugin):
2515
2516 2012-07-30  Raphael Kubo da Costa  <rakuco@webkit.org>
2517
2518         [jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
2519         https://bugs.webkit.org/show_bug.cgi?id=90643
2520
2521         Reviewed by Gustavo Noronha Silva.
2522
2523         The 2.x series of gnutls has a version of Gnulib that is
2524         incompatible with glibc 2.16.0, which now does not define gets()
2525         by default.
2526
2527         After talking to kov, mrobinson and philn, it looks like it makes
2528         sense to simply remove gnutls from jhbuild.modules and rely on the
2529         version installed on the system being recent enough.
2530
2531         This means at least version 2.12.8 for PKCS11 support, or at the
2532         very least 2.11.0 (these are the minimum versions enforced by
2533         glib-networking's configure.ac).
2534
2535         * efl/jhbuild.modules: Do not build gnutls anymore, make
2536         glib-networking depend on glib instead, and move the libgcrypt
2537         dependency to eet, which is what currently needs it.
2538         * gtk/jhbuild.modules: Do not build gnutls anymore.
2539
2540 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2541
2542         nrwt: --verbose logging does not work right on windows
2543         https://bugs.webkit.org/show_bug.cgi?id=92673
2544
2545         Unreviewed, build fix.
2546
2547         The --verbose log level is not being propagated to the worker
2548         processes on windows properly; this has been broken ever since I
2549         refactored logging into the message pool directly :(.
2550
2551         Also, fixing this revealed that outputcapture wasn't saving and
2552         restoring log levels correctly, so I had to fix that as well.
2553
2554         * Scripts/webkitpy/common/message_pool.py:
2555         (_MessagePool._start_workers):
2556         (_MessagePool._worker_log_level):
2557         (_Worker.__init__):
2558         (_Worker._set_up_logging):
2559         (_WorkerLogHandler.__init__):
2560         * Scripts/webkitpy/common/system/outputcapture.py:
2561         (OutputCapture.capture_output):
2562         (OutputCapture.restore_output):
2563
2564 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2565
2566         After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
2567         https://bugs.webkit.org/show_bug.cgi?id=92664
2568
2569         Reviewed by Michael Saboff.
2570
2571         Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).
2572
2573         * Scripts/webkitpy/layout_tests/port/mac.py:
2574         (MacPort.look_for_new_crash_logs):
2575
2576 2012-07-30  Stephen White  <senorblanco@chromium.org>
2577
2578         Added a SkiaGraphics definition to the watchlist file; cc'ed myself
2579         to that group.  Unreviewed.
2580
2581         * Scripts/webkitpy/common/config/watchlist:
2582
2583 2012-07-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2584
2585         Unreviewed, rolling out r123966 and r123967.
2586         http://trac.webkit.org/changeset/123966
2587         http://trac.webkit.org/changeset/123967
2588         https://bugs.webkit.org/show_bug.cgi?id=92656
2589
2590         This patch is causing assertion failures on the debug bot
2591         (also rolling out a dependent patch) (Requested by mrobinson
2592         on #webkit).
2593
2594         * gtk/generate-gtkdoc:
2595         (get_webkit2_options):
2596
2597 2012-07-30  Martin Robinson  <mrobinson@igalia.com>
2598
2599         [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
2600         https://bugs.webkit.org/show_bug.cgi?id=92626
2601
2602         Reviewed by Gustavo Noronha Silva.
2603
2604         Instead of always shelling out to enter a jhbuild environment, add a Python
2605         hook for entering a jhbuild environment directly. This avoids requiring a
2606         script to be wrapped in jhbuild.
2607
2608         * GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
2609         * Scripts/run-gtk-tests: Move most of the logic from run-api-tests here
2610         with additional code for entering a jhbuild environment directly.
2611         * gtk/run-api-tests: Removed.
2612         * jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
2613         * jhbuild/jhbuildutils.py: Add some new helper methods here including
2614         a method which can transform the current environment into a jhbuild-ified one.
2615
2616 2012-07-30  Alexander Pavlov  <apavlov@chromium.org>
2617
2618         Unreviewed, upgrade apavlov to reviewer.
2619         http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html
2620
2621         * Scripts/webkitpy/common/config/committers.py:
2622
2623 2012-07-30  Robin Cao  <robin.cao@torchmobile.com.cn>
2624
2625         [BlackBerry] Adapt to changes in the SharedArray platform API
2626         https://bugs.webkit.org/show_bug.cgi?id=92631
2627
2628         Reviewed by Rob Buis.
2629
2630         Adapt to changes in the SharedArray platform API. No behavioural change.
2631
2632         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2633         (LayoutTestController::webHistoryItemCount):
2634
2635 2012-07-30  Balazs Kelemen  <kbalazs@webkit.org>
2636
2637         [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
2638         https://bugs.webkit.org/show_bug.cgi?id=92627
2639
2640         Reviewed by Noam Rosenthal.
2641
2642         Remove the default behavior I added in r123729 so that we run all tests as pixel
2643         test with -p. It was intentional but it seems like we don't have consensus on
2644         that we want it.
2645
2646         * Scripts/webkitpy/layout_tests/port/qt.py:
2647         (QtPort._supports_switching_pixel_tests_per_test):
2648
2649 2012-07-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2650
2651         [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
2652         https://bugs.webkit.org/show_bug.cgi?id=92366
2653
2654         Reviewed by Antonio Gomes.
2655
2656         Add SHIFT modifier for capital letters as VK_
2657         codes do not distinguish between lows and caps and also to be consistent
2658         with other ports which send caps as lowercase letters with the shift key down.
2659
2660         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2661         (WTR::EventSenderProxy::keyDown):
2662
2663 2012-07-29  Raphael Kubo da Costa  <rakuco@webkit.org>
2664
2665         [EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.
2666         https://bugs.webkit.org/show_bug.cgi?id=92592
2667
2668         Reviewed by Eric Seidel.
2669
2670         Adapt to the changes made to GTK+'s run-with-jhbuild in r123979
2671         and make EFL's run-with-jhbuild call os.execve() instead of
2672         launching a subprocess as well.
2673
2674         This should make it possible to interrupt execution of jhbuild
2675         cleanly.
2676
2677         * efl/run-with-jhbuild:
2678
2679 2012-07-28  Ryosuke Niwa  <rniwa@webkit.org>
2680
2681         run-perf-tests should generate a results page
2682         https://bugs.webkit.org/show_bug.cgi?id=92575
2683
2684         Reviewed by Eric Seidel.
2685
2686         Added the ability to generate a results page that summarizes performance test results from
2687         multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
2688         is not specified. We cannot generate a results page when --test-results-server is specified
2689         because perf-o-matic cannot parse the new JSON format.
2690
2691         The new JSON format is simply an array of the old JSON output. This JSON is then merged into
2692         results-template.html along with jQuery and copied as a HTML file of the same filename as
2693         the output JSON file with a .html extension.
2694
2695         We merge all scripts and the JSON output into the results page as opposed to including them
2696         with the src content attribute to make it standalone so that we may post it on Bugzilla or
2697         e-mail it to someone else without breaking it.
2698
2699         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2700         (PerfTestsRunner.run):
2701         (PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
2702         a results page, and generate the results page from results-template.html merged with jQuery and
2703         the generated JSON output.
2704         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2705         (_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
2706         several test cases.
2707         (_test_run_with_json_output.mock_upload_json): Ditto.
2708         (test_run_with_json_output): Refactored to use _test_run_with_json_output.
2709         (test_run_generates_results_page): Added. Tests the new feature.
2710         (test_run_with_json_source): Refactored to use _test_run_with_json_output.
2711         (test_run_with_multiple_repositories): Ditto.
2712         (test_run_with_upload_json): Ditto.
2713
2714 2012-07-29  Rik Cabanier  <cabanier@adobe.com>
2715
2716         Add ENABLE_CSS_COMPOSITING flag
2717         https://bugs.webkit.org/show_bug.cgi?id=92553
2718
2719         Reviewed by Dirk Schulze.
2720
2721         Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
2722
2723         * Scripts/webkitperl/FeatureList.pm:
2724
2725 2012-07-29  Gustavo Noronha Silva  <gns@gnome.org>
2726
2727         Reviewed by Martin Robinson.
2728
2729         Make the jhbuild wrapper scripts become the jhbuild process
2730         instead of starting it as a child. This should make it possible to
2731         interrupt execution of jhbuild cleanly.
2732
2733         * gtk/run-with-jhbuild:
2734         * jhbuild/jhbuild-wrapper:
2735
2736 2012-07-29  Mike West  <mkwst@chromium.org>
2737
2738         Extend `application/x-webkit-test-netscape` plugins to better support multiple frames.
2739         https://bugs.webkit.org/show_bug.cgi?id=92478
2740
2741         Reviewed by Adam Barth.
2742
2743         DumpRenderTree currently understands
2744         `<object src="data:application/x-webkit-test-netscape,alertwhenloaded">`.
2745         It would be useful if it understood `logifloaded`, which could give
2746         more context regarding test expectations, and can be written in such
2747         as way as to support plugins loaded into multiple iframes in a single
2748         test.
2749
2750         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2751         (NPP_New):
2752             Adding support for `logifloaded`.
2753
2754 2012-07-28  Peter Kasting  <pkasting@google.com>
2755
2756         Fix Chromium/Win compile.
2757         https://bugs.webkit.org/show_bug.cgi?id=88787
2758
2759         Unreviewed, build fix.
2760
2761         Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
2762         The other files in WebKit that define this macro (both in
2763         WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
2764         above the #include of "config.h", so copy that pattern here.
2765
2766         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2767
2768 2012-07-28  Mario Sanchez Prada  <msanchez@igalia.com>
2769
2770         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
2771         https://bugs.webkit.org/show_bug.cgi?id=90268
2772
2773         Reviewed by Martin Robinson.
2774
2775         Ignore WebKitTextChecker.* private files for gtk-doc.
2776
2777         * gtk/generate-gtkdoc:
2778         (get_webkit2_options):
2779
2780 2012-07-28  Philippe Normand  <pnormand@igalia.com>
2781
2782         [GTK] Transparent Media controls timeline and panel
2783         https://bugs.webkit.org/show_bug.cgi?id=85279
2784
2785         Reviewed by Martin Robinson.
2786
2787         * gtk/jhbuild.modules: Provide gnome-themes-standard build
2788         support, this is necessary so the media controls panel colors are
2789         properly initialized from the GTK+ theme.
2790
2791 2012-07-27  Kihong Kwon  <kihong.kwon@samsung.com>
2792
2793         [EFL] Support for HTML media capture
2794         https://bugs.webkit.org/show_bug.cgi?id=91842
2795
2796         Reviewed by Ryosuke Niwa.
2797
2798         Add HTML media capture feature to the feature list.
2799         In addition, enable that on the Efl port.
2800
2801         * Scripts/webkitperl/FeatureList.pm:
2802
2803 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2804
2805         "webkit-patch rebaseline <test>" fails with exit_code 1
2806         https://bugs.webkit.org/show_bug.cgi?id=91560
2807
2808         Reviewed by Adam Barth.
2809
2810         webkit-patch rebaseline-json crashes in an svn checkout if it
2811         tries to add files and there are no files to add; arguably
2812         svn.add() should be robust against this, but rebaseline-json
2813         shouldn't be calling it, either. This patch fixes the latter and
2814         adds better debugging info to garden-o-matic so we can see what
2815         caused the crash.
2816
2817         * Scripts/webkitpy/tool/commands/rebaseline.py:
2818         (AbstractParallelRebaselineCommand._rebaseline):
2819         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2820         (GardeningHTTPRequestHandler.rebaselineall):
2821         (GardeningHTTPRequestHandler.rebaselineall.error_handler):
2822         (GardeningHTTPRequestHandler):
2823
2824 2012-07-27  Brady Eidson  <beidson@apple.com>
2825
2826         Plugins should not be allowed to override standard properties/attributes in non-standard worlds
2827         <rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519
2828
2829         Reviewed by Anders Carlsson.
2830
2831         Add a test plugin which overrides all properties it is asked about:
2832         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
2833         (PluginScriptableObjectOverridesAllProperties):
2834         (PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
2835         (PluginObject):
2836         (PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
2837         (PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
2838         (PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
2839         (PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
2840         (PluginScriptableObjectOverridesAllProperties::NPP_GetValue):
2841
2842         Expose NPN_MemAlloc to the test plugin:
2843         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2844         (PluginTest::NPN_MemAlloc):
2845         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2846         (PluginTest):
2847
2848         * DumpRenderTree/DumpRenderTree.gypi:
2849         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2850         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2851         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2852
2853 2012-07-27  Rafael Brandao  <rafael.lobo@openbossa.org>
2854
2855         "webkit-patch upload" should strip colors from patch if necessary
2856         https://bugs.webkit.org/show_bug.cgi?id=92306
2857
2858         Reviewed by Adam Barth.
2859
2860         * Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
2861
2862 2012-07-27  Eric Seidel  <eric@webkit.org>
2863
2864         clean-pending-commit throws exception when encountering Ossy
2865         https://bugs.webkit.org/show_bug.cgi?id=92534
2866
2867         Reviewed by Adam Barth.
2868
2869         Mark a couple strings as unicode so that reviewers with unicode names do not cause
2870         clean-pending-commit to barf.
2871
2872         * Scripts/webkitpy/tool/commands/upload.py:
2873         (CleanPendingCommit._flags_to_clear_on_patch):
2874         (CleanPendingCommit.execute):
2875         (AssignToCommitter._assign_bug_to_last_patch_attacher):
2876
2877 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2878
2879         chromium win compile broken after removing webkit.py
2880         https://bugs.webkit.org/show_bug.cgi?id=92549
2881
2882         Unreviewed, build fix.
2883
2884         It turns out that this file is listed in the chromium downstream
2885         'browser_tests.isolate' file, and so deleting it broke gyp.
2886         Adding a stub file back in until we can remove the entry from
2887         the file.
2888
2889         * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
2890
2891 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2892
2893         nrwt: remove 'webkit.py' and the 'WebKitPort'
2894         https://bugs.webkit.org/show_bug.cgi?id=92450
2895
2896         Reviewed by Ryosuke Niwa.
2897
2898         This patch finishes the work of merging WebKitPort into Port.
2899         Now Port is way too big :).
2900
2901         This is all cutting and pasting; no new functionality and
2902         no changes in the tests.
2903
2904         * Scripts/webkitpy/layout_tests/port/apple.py:
2905         (ApplePort):
2906         (ApplePort.__init__):
2907         * Scripts/webkitpy/layout_tests/port/base.py:
2908         (Port.skipped_layout_tests):
2909         (Port):
2910         (Port._port_flag_for_scripts):
2911         (Port._arguments_for_configuration):
2912         (Port._run_script):
2913         (Port._build_driver):
2914         (Port._build_driver_flags):
2915         (Port._tests_for_other_platforms):
2916         (Port._runtime_feature_list):
2917         (Port.nm_command):
2918         (Port._modules_to_search_for_symbols):
2919         (Port._symbols_string):
2920         (Port._missing_feature_to_skipped_tests):
2921         (Port._missing_symbol_to_skipped_tests):
2922         (Port._has_test_in_directories):
2923         (Port._skipped_tests_for_unsupported_features):
2924         (Port._wk2_port_name):
2925         (Port._skipped_file_search_paths):
2926         * Scripts/webkitpy/layout_tests/port/chromium.py:
2927         (ChromiumPort):
2928         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2929         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2930         (ChromiumPortTestCase.test_check_build):
2931         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2932         * Scripts/webkitpy/layout_tests/port/efl.py:
2933         (EflPort):
2934         (EflPort.__init__):
2935         * Scripts/webkitpy/layout_tests/port/gtk.py:
2936         (GtkPort):
2937         (GtkPort.setup_environ_for_server):
2938         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2939         (TestWebKitPort):
2940         (TestWebKitPort.__init__):
2941         (TestWebKitPort.all_test_configurations):
2942         (TestWebKitPort._symbols_string):
2943         (TestWebKitPort._tests_for_other_platforms):
2944         (TestWebKitPort._tests_for_disabled_features):
2945         (PortTestCase):
2946         (PortTestCase.test_diff_image):
2947         (PortTestCase.test_path_to_test_expectations_file):
2948         (PortTestCase.test_skipped_directories_for_symbols):
2949         (test_skipped_directories_for_features):
2950         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2951         (test_skipped_tests_for_unsupported_features_empty_test_list):
2952         (test_skipped_layout_tests):
2953         (test_skipped_file_search_paths):
2954         (test_root_option):
2955         (test_test_expectations):
2956         (test_build_driver):
2957         (_assert_config_file_for_platform):
2958         (test_linux_distro_detection):
2959         (test_apache_config_file_name_for_platform):
2960         (test_path_to_apache_config_file):
2961         * Scripts/webkitpy/layout_tests/port/qt.py:
2962         (QtPort):
2963         (QtPort.__init__):
2964         (QtPort.setup_environ_for_server):
2965         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
2966         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
2967         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2968         (get_test_baselines.AllPlatformsPort):
2969         (get_test_baselines.AllPlatformsPort.__init__):
2970         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2971         (get_test_config.TestMacPort):
2972
2973 2012-07-27  Christophe Dumez  <christophe.dumez@intel.com>
2974
2975         [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
2976         https://bugs.webkit.org/show_bug.cgi?id=92228
2977
2978         Reviewed by Anders Carlsson.
2979
2980         Implement LayoutTestController.deliverWebIntent() to
2981         allow test cases to deliver a Web intent and test this
2982         functionality.
2983
2984         This functionality is needed by:
2985         - webintents/web-intents-delivery.html
2986
2987         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2988         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2989         (WTR::LayoutTestController::deliverWebIntent):
2990         (WTR):
2991         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2992         (LayoutTestController):
2993
2994 2012-07-27  Jer Noble  <jer.noble@apple.com>
2995
2996         Unreviewed build fix.
2997
2998         Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.
2999
3000         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3001
3002 2012-07-27  Xianzhu Wang  <wangxianzhu@chromium.org>
3003
3004         [Chromium-Android] NRWT better handling of DRT deadlocks and crashes
3005         https://bugs.webkit.org/show_bug.cgi?id=92299
3006
3007         Reviewed by Dirk Pranke.
3008
3009         1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the
3010            current driver (see the bug for the problem of the reference.
3011         2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
3012         3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
3013         4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
3014
3015         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3016         (ChromiumAndroidPort.__init__):
3017         (ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
3018         (ChromiumAndroidDriver.__init__):
3019         (ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
3020         (ChromiumAndroidDriver._all_pipes_created):
3021         (ChromiumAndroidDriver._remove_all_pipes):
3022         (ChromiumAndroidDriver._start): Changed the retry loop style.
3023         (ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
3024         (ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
3025         (ChromiumAndroidDriver.stop): Changed the loop style.
3026
3027 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
3028
3029         nrwt: move collect_tests(), parse_expectations() into manager
3030         https://bugs.webkit.org/show_bug.cgi?id=92423
3031
3032         Reviewed by Ojan Vafai.
3033
3034         This is the first in a series of patches refactoring
3035         run_webkit_tests.py and manager.py to make them more
3036         maintainable; all this patch does is move a couple of functions
3037         into manager.run_tests() so manager's public interface is
3038         simple.
3039
3040         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3041         (Manager._collect_tests):
3042         (Manager._parse_expectations):
3043         (Manager._split_into_chunks_if_necessary):
3044         (Manager.run):
3045         (read_test_files):
3046         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3047         (ManagerTest.test_http_locking):
3048         (ManagerTest.test_perf_locking):
3049         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
3050         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
3051         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3052         (run):
3053
3054 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
3055
3056         nrwt: print filtered stderr after a crash correctly
3057         https://bugs.webkit.org/show_bug.cgi?id=92428
3058
3059         Reviewed by Adam Barth.
3060
3061         Some ports will run the stderr output from DRT/WTR through a
3062         filter after a crash in order to print a more useful stack
3063         trace; while that gets written to the crash log correctly, we
3064         don't log it to the debug output properly. This change fixes
3065         that and makes it clearer that we're logging stderr, not the
3066         crash log.
3067
3068         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3069         (SingleTestRunner._handle_error):
3070         * Scripts/webkitpy/layout_tests/port/base.py:
3071         (Port._get_crash_log):
3072         * Scripts/webkitpy/layout_tests/port/chromium.py:
3073         (ChromiumPort._get_crash_log):
3074         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3075         (ChromiumAndroidPortTest.test_get_crash_log):
3076         * Scripts/webkitpy/layout_tests/port/driver.py:
3077         (Driver.run_test):
3078         * Scripts/webkitpy/layout_tests/port/gtk.py:
3079         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3080         * Scripts/webkitpy/layout_tests/port/mac.py:
3081         (MacPort._get_crash_log):
3082         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3083         (PortTestCase.test_get_crash_log):
3084
3085 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
3086
3087         nrwt: move image diffing code to a separate module
3088         https://bugs.webkit.org/show_bug.cgi?id=92447
3089
3090         Reviewed by Ryosuke Niwa.
3091
3092         This patch moves the code to talk to ImageDiff into its own
3093         module, and adds more tests for it. In addition, the patch
3094         modifies diff_image() so that we don't automatically stop
3095         ImageDiff after a single invocation, and thus subsequent
3096         diffs may be slightly faster. (Note that the chromium ports
3097         don't use any of this code; that is not changed by this patch).
3098
3099         The main motivation for this change is to move more "generic"
3100         code out of the port/* classes, and in particular to move more
3101         code out of webkit.py so that we can eventually eliminate it by
3102         merging it into base.py.
3103
3104         This patch also splits MockServerProcess out from driver_unittest.py
3105         so that it can be re-used.
3106
3107         * Scripts/webkitpy/layout_tests/port/base.py:
3108         (Port.__init__):
3109         (Port.diff_image):
3110         (Port.clean_up_test_run):
3111         * Scripts/webkitpy/layout_tests/port/driver.py:
3112         (Driver.__init__):
3113         (Driver._start):
3114         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3115         (DriverTest.test_stop_cleans_up_properly):
3116         (DriverTest.test_two_starts_cleans_up_properly):
3117         (DriverTest.test_start_actually_starts):
3118         * Scripts/webkitpy/layout_tests/port/efl.py:
3119         (EflPort.clean_up_test_run):
3120         * Scripts/webkitpy/layout_tests/port/gtk.py:
3121         (GtkPort.clean_up_test_run):
3122         * Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
3123         (ImageDiffer):
3124         (ImageDiffer.__init__):
3125         (ImageDiffer.diff_image):
3126         (ImageDiffer._start):
3127         (ImageDiffer._read):
3128         (ImageDiffer.stop):
3129         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
3130         (for):
3131         (FakePort):
3132         (FakePort.__init__):
3133         (FakePort._path_to_image_diff):
3134         (FakePort.setup_environ_for_server):
3135         (TestImageDiffer):
3136         (TestImageDiffer.test_diff_image):
3137         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3138         (MockDRTPortTest.test_diff_image):
3139         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3140         (PortTestCase.test_diff_image__missing_both):
3141         (PortTestCase.test_diff_image):
3142         (PortTestCase.test_diff_image.make_proc):
3143         * Scripts/webkitpy/layout_tests/port/server_process.py:
3144         (ServerProcess._start):
3145         * Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
3146         (MockServerProcess):
3147         (MockServerProcess.__init__):
3148         (MockServerProcess.write):
3149         (MockServerProcess.has_crashed):
3150         (MockServerProcess.read_stdout_line):
3151         (MockServerProcess.read_stdout):
3152         (MockServerProcess.pop_all_buffered_stderr):
3153         (MockServerProcess.read_either_stdout_or_stderr_line):
3154         (MockServerProcess.start):
3155         (MockServerProcess.stop):
3156         (MockServerProcess.kill):
3157         * Scripts/webkitpy/layout_tests/port/webkit.py:
3158         (WebKitPort._build_driver_flags):
3159         (WebKitPort._symbols_string):
3160
3161 2012-07-27  Tom Hudson  <hudson@google.com>
3162
3163         Activate committer bit granted April 6th so I can garden.
3164         https://bugs.webkit.org/show_bug.cgi?id=92500
3165
3166         Reviewed by Jochen Eisinger.
3167
3168         * Scripts/webkitpy/common/config/committers.py:
3169
3170 2012-07-27  Jer Noble  <jer.noble@apple.com>
3171
3172         Support a rational time class for use by media elements.
3173         https://bugs.webkit.org/show_bug.cgi?id=88787
3174
3175         Add unit tests for the WTF::MediaTime class.
3176
3177         Reviewed by Eric Carlson.
3178
3179         * TestWebKitAPI/GNUmakefile.am:
3180         * TestWebKitAPI/TestWebKitAPI.gypi:
3181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3182         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
3183         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3184         (WTF::operator<<):
3185         (TestWebKitAPI):
3186         (TestWebKitAPI::TEST):
3187
3188 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
3189
3190         [NRWT] should have a way to restrict pixel tests for individual directories
3191         https://bugs.webkit.org/show_bug.cgi?id=91754
3192
3193         Unreviewed attempt to fix the chaos I introduced.
3194
3195         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3196         (WebCore::DumpRenderTree::processLine):
3197
3198 2012-07-27  YoungTaeck Song  <youngtaeck.song@samsung.com>
3199
3200         [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
3201         https://bugs.webkit.org/show_bug.cgi?id=91581
3202
3203         Reviewed by Noam Rosenthal.
3204
3205         Add a MiniBrowser's option for selecting evas engine.
3206
3207         * MiniBrowser/efl/main.c:
3208         (browserCreate):
3209         (main):
3210
3211 2012-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3212
3213         Unreviewed, rolling out r123869.
3214         http://trac.webkit.org/changeset/123869
3215         https://bugs.webkit.org/show_bug.cgi?id=92501
3216
3217         "it did not fix anything but made things even worst"
3218         (Requested by kbalazs on #webkit).
3219
3220         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3221         (WebCore::DumpRenderTree::DumpRenderTree):
3222         (WebCore::DumpRenderTree::open):
3223         (WebCore::DumpRenderTree::processLine):
3224         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
3225         (WebCore::DumpRenderTree::dump):
3226         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3227         (DumpRenderTree):
3228         * DumpRenderTree/qt/main.cpp:
3229         (main):
3230         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3231         (SingleTestRunner._should_fetch_expected_checksum):
3232         (SingleTestRunner._overwrite_baselines):
3233         (SingleTestRunner._compare_output):
3234         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3235         (Worker._update_test_input):
3236         * Scripts/webkitpy/layout_tests/port/base.py:
3237         (Port.supports_switching_pixel_tests_per_test):
3238         (Port):
3239         (Port._supports_switching_pixel_tests_per_test):
3240         (Port.should_run_as_pixel_test):
3241         (Port._should_run_as_pixel_test):
3242         * Scripts/webkitpy/layout_tests/port/driver.py:
3243         (Driver.cmd_line):
3244         (Driver._command_from_driver_input):
3245         * Scripts/webkitpy/layout_tests/port/qt.py:
3246         (QtPort.check_sys_deps):
3247         (QtPort):
3248         (QtPort._supports_switching_pixel_tests_per_test):
3249         (QtPort._should_run_as_pixel_test):
3250         (QtPort._default_pixel_test_directories):
3251         * Scripts/webkitpy/layout_tests/port/test.py:
3252         (TestPort.supports_switching_pixel_tests_per_test):
3253         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3254         (_set_up_derived_options):
3255         (parse_args):
3256         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3257         (MainTest.test_run_singly_actually_runs_tests):
3258         (MainTest.test_pixel_test_directories):
3259         * WebKitTestRunner/TestController.cpp:
3260         (WTR::TestController::TestController):
3261         (WTR::TestController::initialize):
3262         (WTR::TestController::runTest):
3263         * WebKitTestRunner/TestController.h:
3264         (TestController):
3265
3266 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
3267
3268         [NRWT] should have a way to restrict pixel tests for individual directories
3269         https://bugs.webkit.org/show_bug.cgi?id=91754
3270
3271         Reviewed by Zoltan Herczeg.
3272
3273         Rollout r123729 because it made Qt debug bots crasy.
3274
3275         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3276         (WebCore::DumpRenderTree::DumpRenderTree):
3277         (WebCore::DumpRenderTree::open):
3278         (WebCore::DumpRenderTree::processLine):
3279         (WebCore::DumpRenderTree::setDumpPixels):
3280         (WebCore::DumpRenderTree::dump):
3281         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3282         (DumpRenderTree):
3283         * DumpRenderTree/qt/main.cpp:
3284         (main):
3285         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3286         (SingleTestRunner._should_fetch_expected_checksum):
3287         (SingleTestRunner._overwrite_baselines):
3288         (SingleTestRunner._compare_output):
3289         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3290         (Worker._update_test_input):
3291         * Scripts/webkitpy/layout_tests/port/base.py:
3292         (Port.lookup_virtual_test_args):
3293         * Scripts/webkitpy/layout_tests/port/driver.py:
3294         (Driver.cmd_line):
3295         (Driver._command_from_driver_input):
3296         * Scripts/webkitpy/layout_tests/port/qt.py:
3297         (QtPort.check_sys_deps):
3298         * Scripts/webkitpy/layout_tests/port/test.py:
3299         (TestPort.virtual_test_suites):
3300         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3301         (_set_up_derived_options):
3302         (parse_args):
3303         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3304         (MainTest.test_run_singly_actually_runs_tests):
3305         (MainTest.test_missing_and_unexpected_results):
3306         * WebKitTestRunner/TestController.cpp:
3307         (WTR::TestController::TestController):
3308         (WTR::TestController::initialize):
3309         (WTR::TestController::runTest):
3310         * WebKitTestRunner/TestController.h:
3311         (TestController):
3312
3313 2012-07-27  Adam Barth  <abarth@webkit.org>
3314
3315         webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
3316         https://bugs.webkit.org/show_bug.cgi?id=92472
3317
3318         Reviewed by Eric Seidel.
3319
3320         We need to run these command periodically to keep cruft from
3321         accumulating in bugs.webkit.org. Rather than running them manually, we
3322         should just have a bot run them. This patch has the style-queue run the
3323         commands, which admittedly is a bit odd but it doesn't seem worthwhile
3324         to create another bot specifically for this purposes.
3325
3326         * Scripts/webkitpy/tool/commands/queues.py:
3327         (AbstractReviewQueue):
3328         (StyleQueue.begin_work_queue):
3329         (StyleQueue):
3330         (StyleQueue.clean_bugzilla):
3331         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3332         (StyleQueueTest.test_style_queue_with_style_exception):
3333         (test_style_queue_with_watch_list_exception):
3334
3335 2012-07-27  Dominik Röttsches  <dominik.rottsches@intel.com>
3336
3337         [Cairo] Add complex font drawing using HarfbuzzNG
3338         https://bugs.webkit.org/show_bug.cgi?id=91864
3339
3340         Reviewed by Simon Hausmann and Martin Robinson.
3341
3342         Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
3343
3344         * WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
3345         * efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
3346
3347 2012-07-27  KwangYong Choi  <ky0.choi@samsung.com>
3348
3349         [WK2][EFL][WTR] TestNetscapePlugin is required.
3350         https://bugs.webkit.org/show_bug.cgi?id=88756
3351
3352         Reviewed by Simon Hausmann.
3353
3354         libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
3355
3356         * CMakeLists.txt:
3357         * DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
3358
3359 2012-07-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3360
3361         [EFL] Memory leaks in EFL DRT
3362         https://bugs.webkit.org/show_bug.cgi?id=92347
3363
3364         Reviewed by Simon Hausmann.
3365
3366         Fix a memory leak in EFL's DRT code by adopting an allocation
3367         of JSString created with JSStringCreateWithUTF8CString.
3368
3369         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3370         (DumpRenderTreeChrome::onWindowObjectCleared):
3371
3372 2012-07-27  Adam Barth  <abarth@webkit.org>
3373
3374         Simplify ExpectedFailures
3375         https://bugs.webkit.org/show_bug.cgi?id=92216
3376
3377         Reviewed by Eric Seidel.
3378
3379         This patch simplifies the ExpectedFailures class we use to remember
3380         which tests are currently failing on the bots. When we wrote this code
3381         originally, we weren't entirely sure how it would work. Now that we
3382         understand it more clearly, we can write the code more clearly.
3383
3384         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3385         (_has_failures):
3386         (_is_trustworthy):
3387         (ExpectedFailures.__init__):
3388         (ExpectedFailures.failures_were_expected):
3389         (ExpectedFailures.unexpected_failures_observed):
3390         (ExpectedFailures.update):
3391         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3392         (ExpectedFailuresTest._assert_can_trust):
3393         (ExpectedFailuresTest.test_failures_were_expected):
3394         (ExpectedFailuresTest.test_unexpected_failures_observed):
3395         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
3396         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3397         (PatchAnalysisTask._test):
3398         (PatchAnalysisTask._build_and_test_without_patch):
3399         (PatchAnalysisTask._test_patch):
3400
3401 2012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
3402
3403         [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
3404         https://bugs.webkit.org/show_bug.cgi?id=88064
3405
3406         Reviewed by Zoltan Herczeg.
3407
3408         Use resetInternalsObject() instead of injectInternalsObject().
3409
3410         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3411         (WTR::InjectedBundlePage::resetAfterTest):
3412
3413 2012-07-26  Ryuan Choi  <ryuan.choi@samsung.com>
3414
3415         [EFL] Remove forwarding headers from MiniBrowser/Efl.
3416         https://bugs.webkit.org/show_bug.cgi?id=91627
3417
3418         Reviewed by Kentaro Hara.
3419
3420         * MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
3421
3422 2012-07-26  Yoshifumi Inoue  <yosin@chromium.org>
3423
3424         [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
3425         https://bugs.webkit.org/show_bug.cgi?id=92339
3426
3427         Reviewed by Kent Tamura.
3428
3429         This patch enables runtime features for input type datetime, datetime-local,
3430         month, time and week for Chromium DRT.
3431
3432         * DumpRenderTree/chromium/TestShell.cpp:
3433         (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
3434
3435 2012-07-26  Jeffrey Pfau  <jpfau@apple.com>
3436
3437         Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
3438         https://bugs.webkit.org/show_bug.cgi?id=84041
3439
3440         Reviewed by Brady Eidson.
3441
3442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3443         * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
3444         (-[BackForwardListTest webView:didFinishLoadForFrame:]):
3445         (-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
3446         (TestWebKitAPI):
3447         (TestWebKitAPI::TEST):
3448
3449 2012-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3450
3451         Unreviewed, rolling out r123799.
3452         http://trac.webkit.org/changeset/123799
3453         https://bugs.webkit.org/show_bug.cgi?id=92431
3454
3455         broke the Apple Mac build (Requested by bweinstein on
3456         #webkit).
3457
3458         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3459         * DumpRenderTree/chromium/TestWebPlugin.h:
3460         (TestWebPlugin::acceptsInputEvents):
3461         (TestWebPlugin::handleInputEvent):
3462
3463 2012-07-26  Dirk Pranke  <dpranke@chromium.org>
3464
3465         nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
3466         https://bugs.webkit.org/show_bug.cgi?id=92172
3467
3468         Reviewed by Tony Chang.
3469
3470         Right now new-run-webkit-tests --verbose prints out too much
3471         information (it's like --verbose + debugging). I plan to fix
3472         this in bug 88702, and also clean up and simplify all of the
3473         --print options, but in preparation for these changes I need to
3474         pass --verbose twice to get the same level of output
3475         temporarily (for compatibility).
3476
3477         * Scripts/run-webkit-tests:
3478
3479 2012-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3480
3481         Propagate gesture events to plugins.
3482         https://bugs.webkit.org/show_bug.cgi?id=92281
3483
3484         Reviewed by Adam Barth.
3485
3486         Update TestWebPlugin to receive events, and output logs for the events.
3487
3488         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3489         (TestWebPlugin::handleInputEvent):
3490         * DumpRenderTree/chromium/TestWebPlugin.h:
3491         (TestWebPlugin::acceptsInputEvents):
3492         (TestWebPlugin):
3493
3494 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3495
3496         [nrwt] get rid of --skip-pixel-test-if-no-baseline
3497         https://bugs.webkit.org/show_bug.cgi?id=92377
3498
3499         Reviewed by Adam Barth.
3500
3501         Remove the option and all code paths that handled it.
3502
3503         * Scripts/webkitpy/layout_tests/port/base.py:
3504         (Port.should_run_as_pixel_test):
3505         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3506         (_set_up_derived_options):
3507         (parse_args):
3508         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3509         (MainTest.test_repeat_each):
3510
3511 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
3512
3513         Add FastMalloc statistics in window.internals
3514         https://bugs.webkit.org/show_bug.cgi?id=91274
3515
3516         Reviewed by Ryosuke Niwa.
3517
3518         * GNUmakefile.am:
3519
3520 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
3521
3522         Add FastMalloc statistics in window.internals
3523         https://bugs.webkit.org/show_bug.cgi?id=91274
3524
3525         Reviewed by Ryosuke Niwa.
3526
3527         * GNUmakefile.am:
3528
3529 2012-07-20  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3530
3531         buildbot: Remove the configuration of hfreyther*
3532         https://bugs.webkit.org/show_bug.cgi?id=91849
3533
3534         Reviewed by Adam Roben.
3535
3536         The machine running these configs was decommissioned and
3537         there is no replacement at this point. Remove them from the
3538         configuration.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
3541         the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
3542         them too.
3543
3544 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3545
3546         Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.
3547
3548         * WebKitTestRunner/TestController.cpp:
3549         (WTR::TestController::runTest):
3550
3551 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3552
3553         Unreviewed speculative buildfix after r123729.
3554
3555         * WebKitTestRunner/TestController.cpp:
3556         (WTR::TestController::runTest): Fix sign errors.
3557
3558 2012-07-26  Zoltan Nyul  <zoltan.nyul@intel.com>
3559
3560         [EFL] EFL port should use XDG paths
3561         https://bugs.webkit.org/show_bug.cgi?id=91719
3562
3563         Reviewed by Kenneth Rohde Christiansen.
3564
3565         The appcache/localstorage/webdatabase path should be set in the
3566         ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
3567         XDG_CACHE_HOME should be set to different directory for each processes
3568         for the layout-tests.
3569
3570         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3571         (DumpRenderTreeChrome::initialize):
3572         * Scripts/webkitpy/layout_tests/port/efl.py:
3573         (EflPort.setup_environ_for_server):
3574         * efl/jhbuild.modules:
3575
3576 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3577
3578         [NRWT] should have a way to restrict pixel tests for individual directories
3579         https://bugs.webkit.org/show_bug.cgi?id=91754
3580
3581         Reviewed by Dirk Pranke.
3582
3583         Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
3584         If the platform supports this option only tests from these directories will
3585         be executed as pixel tests. Furthermore, platforms can have a default set of
3586         pixel test directories. To support the feature the test harness have to be
3587         able to inform the driver whether to dump pixels for each tests. For this
3588         purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
3589         the standard output and made NRWT use this argument with these drivers.
3590
3591         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3592         (WebCore::DumpRenderTree::DumpRenderTree):
3593         (WebCore::DumpRenderTree::open):
3594         (WebCore::DumpRenderTree::processLine):
3595         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
3596         (WebCore::DumpRenderTree::dump):
3597         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3598         (DumpRenderTree):
3599         * DumpRenderTree/qt/main.cpp:
3600         (main):
3601         Handle the --pixel-test argument.
3602
3603         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3604         (SingleTestRunner._should_fetch_expected_checksum):
3605         (SingleTestRunner._overwrite_baselines):
3606         (SingleTestRunner._compare_output):
3607         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3608         (Worker._update_test_input):
3609         * Scripts/webkitpy/layout_tests/port/base.py:
3610         (Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
3611         the harness that --pixel-test argument is supported. True for WTR, otherwise calls
3612         private version that can be overridden by the actual platform. Only true with WTR
3613         and Qt DRT currently. This supposed to exist only temporary until there are ports
3614         that doesn't support the feature in their DRT's.
3615         (Port):
3616         (Port._supports_switching_pixel_tests_per_test):
3617         (Port.should_run_as_pixel_test):
3618         (Port._should_run_as_pixel_test): Ports can override this to define their
3619         default set of pixel tests directories.
3620         * Scripts/webkitpy/layout_tests/port/driver.py:
3621         (Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
3622         --pixel-test.
3623         (Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
3624         tests are enabled.
3625         * Scripts/webkitpy/layout_tests/port/qt.py:
3626         (QtPort.check_sys_deps):
3627         (QtPort):
3628         (QtPort._supports_switching_pixel_tests_per_test):
3629         (QtPort._should_run_as_pixel_test):
3630         (QtPort._default_pixel_test_directories): Only compositing will be our default pixel
3631         test directory for the time being.
3632         * Scripts/webkitpy/layout_tests/port/test.py:
3633         (TestPort.supports_switching_pixel_tests_per_test):
3634         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3635         (_set_up_derived_options):
3636         (parse_args):
3637         Handle the --pixel-test-directory option. It expect a directory below LayoutTests
3638         and can be specified multiple times. Added fixme's that we should improve how we
3639         handle these arguments.
3640
3641         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3642         (MainTest.test_run_singly_actually_runs_tests):
3643         (MainTest.test_pixel_test_directories):
3644         Added an integration test for the feature.
3645
3646         * WebKitTestRunner/TestController.cpp:
3647         (WTR::TestController::TestController):
3648         (WTR::TestController::initialize):
3649         (WTR::TestController::runTest):
3650         * WebKitTestRunner/TestController.h:
3651         (TestController):
3652         Handle the --pixel-test argument.
3653
3654 2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
3655
3656         [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
3657         https://bugs.webkit.org/show_bug.cgi?id=92349
3658
3659         Reviewed by Kentaro Hara.
3660
3661         Fix crash occurring after r123604, which replaced strdup()
3662         usage with eina_stringshare_add(). Unfortunately, the DRT
3663         was not updated accordingly to use eina_stringshare_del()
3664         instead of free() on the values returned by Ewk_Intent
3665         getters and it was causing
3666         webintents/web-intents-obj-constructor.html to crash.
3667
3668         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3669         (DumpRenderTreeChrome::onFrameIntentNew):
3670
3671 2012-07-26  Adam Barth  <abarth@webkit.org>
3672
3673         Unreviewed attempt to fix the chromium-win build.
3674
3675         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
3676
3677 2012-07-26  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3678
3679         [DRT] LTC:: pageNumberForElementById() could be moved to Internals
3680         https://bugs.webkit.org/show_bug.cgi?id=92091
3681
3682         Reviewed by Adam Barth.
3683
3684         Move the pageNumberForElementById from LayoutTestCotroller to Internals and
3685         remove the old platform specific implementations as it exclusively tests WebCore functionality.
3686
3687         * DumpRenderTree/LayoutTestController.cpp:
3688         (LayoutTestController::staticFunctions):
3689         * DumpRenderTree/LayoutTestController.h:
3690         (LayoutTestController):
3691         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3692         * DumpRenderTree/chromium/LayoutTestController.cpp:
3693         (LayoutTestController::LayoutTestController):
3694         (LayoutTestController::setPrinting):
3695         * DumpRenderTree/chromium/LayoutTestController.h:
3696         (LayoutTestController):
3697         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3698         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3699         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3700         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3701         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3702         (LayoutTestController):
3703         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3704         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3705         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3706         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3707         (WTR):
3708         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3709         (LayoutTestController):
3710
3711 2012-07-25  Adam Barth  <abarth@webkit.org>
3712
3713         TestRunner.a should contain a TestRunner object
3714         https://bugs.webkit.org/show_bug.cgi?id=92313
3715
3716         Reviewed by Kent Tamura.
3717
3718         This patch adds a stub implementation of TestRunner, which is the new
3719         home for our implementation of window.testRunner. A future patch will
3720         migrate functions from LayoutTestController to TestRunner.
3721
3722         * DumpRenderTree/DumpRenderTree.gypi:
3723         * DumpRenderTree/chromium/LayoutTestController.h:
3724         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
3725         * DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
3726
3727 2012-07-25  Wei James  <james.wei@intel.com>
3728
3729         [Chromium] Fix infinite loop issue for chromium android layout test
3730         https://bugs.webkit.org/show_bug.cgi?id=92197
3731
3732         Reviewed by Adam Barth.
3733
3734         The change brought in by r123530 will cause infinite loop when running
3735         Chromium Android Layout Test.
3736         Revert the change for this line only.
3737
3738         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3739         (ChromiumAndroidPort._build_path):
3740
3741 2012-07-25  Adam Barth  <abarth@webkit.org>
3742
3743         Jochen is our a newest reviewer!
3744
3745         * Scripts/webkitpy/common/config/committers.py:
3746
3747 2012-07-25  Jochen Eisinger  <jochen@chromium.org>
3748
3749         [chromium] don't use webkit_support methods directly from test runners but through the test delegate
3750         https://bugs.webkit.org/show_bug.cgi?id=92256
3751
3752         Reviewed by Adam Barth.
3753
3754         This will allow for the content_shell to provide its own implementation
3755         for setting the Gamepad data instead.
3756
3757         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
3758         (GamepadController::setDelegate):
3759         (GamepadController::reset):
3760         (GamepadController::connect):
3761         (GamepadController::disconnect):
3762         (GamepadController::setId):
3763         (GamepadController::setButtonCount):
3764         (GamepadController::setButtonData):
3765         (GamepadController::setAxisCount):
3766         (GamepadController::setAxisData):
3767         * DumpRenderTree/chromium/TestRunner/GamepadController.h:
3768         (GamepadController):
3769         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
3770         (WebKit):
3771         (TestDelegate):
3772         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
3773         (TestInterfaces::Internal):
3774         (TestInterfaces::Internal::~Internal):
3775         (TestInterfaces::Internal::setDelegate):
3776         (TestInterfaces::setDelegate):
3777         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
3778         (TestInterfaces):
3779         * DumpRenderTree/chromium/TestShell.cpp:
3780         (TestShell::createMainWindow):
3781         (TestShell::~TestShell):
3782         * DumpRenderTree/chromium/WebViewHost.cpp:
3783         (WebViewHost::setGamepadData):
3784         * DumpRenderTree/chromium/WebViewHost.h:
3785         (WebViewHost):
3786
3787 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
3788
3789         [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
3790         https://bugs.webkit.org/show_bug.cgi?id=92227
3791
3792         Reviewed by Kenneth Rohde Christiansen.
3793
3794         Implement LayoutTestController.sendWebIntentResponse() so
3795         that a test case can reply to a Web intent request and
3796         test this functionality.
3797
3798         In order to support this functionality, we need to keep
3799         a pointer to the current intent request in
3800         InjectedBundlePage::didReceiveIntentForFrame() so that
3801         we can reuse it later in
3802         LayoutTestController::sendWebIntentResponse().
3803
3804         The following tests need this functionality:
3805         - webintents/web-intents-failure.html
3806         - webintents/web-intents-reply.html
3807
3808         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3809         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3810         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
3811         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3812         (InjectedBundlePage):
3813         (WTR::InjectedBundlePage::currentIntentRequest):
3814         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3815         (WTR::LayoutTestController::sendWebIntentResponse):
3816         (WTR):
3817         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3818         (LayoutTestController):
3819
3820 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3821
3822         [EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
3823         https://bugs.webkit.org/show_bug.cgi?id=92241
3824
3825         Reviewed by Kenneth Rohde Christiansen.
3826
3827         Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
3828         It caused failure of fast/events/keydown-leftright-keys.html test.
3829
3830         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.
3831         (WTR::keyName):
3832
3833 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
3834
3835         [EFL][WK2] Fix timeout issues when debugging WebProcess.
3836         https://bugs.webkit.org/show_bug.cgi?id=92245
3837
3838         Reviewed by Dirk Pranke.
3839
3840         Fix timeout issues when debugging the WebProcess
3841         under valgrind or gdb.
3842
3843         * Scripts/webkitpy/layout_tests/port/efl.py:
3844         (EflPort.default_timeout_ms):
3845         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3846         (WTR::TestController::platformInitialize):
3847
3848 2012-07-25  Xianzhu Wang  <wangxianzhu@chromium.org>
3849
3850         [Chromium-Android] NRWT driver should not restart between reftests
3851         https://bugs.webkit.org/show_bug.cgi?id=92267
3852
3853         Reviewed by Dirk Pranke.
3854
3855         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3856         (ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.
3857
3858 2012-07-25  Tommy Widenflycht  <tommyw@google.com>
3859
3860         MediaStream API: Update MediaStreamTrack to match the specification
3861         https://bugs.webkit.org/show_bug.cgi?id=90180
3862
3863         Reviewed by Adam Barth.
3864
3865         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
3866
3867         * DumpRenderTree/DumpRenderTree.gypi:
3868         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3869         (MockWebKitPlatformSupport::createMediaStreamCenter):
3870         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
3871         (WebKit):
3872         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3873         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
3874         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
3875         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
3876         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
3877         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
3878         (WebKit::MockWebMediaStreamCenter::constructSDP):
3879         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
3880         (WebKit):
3881         (MockWebMediaStreamCenter):
3882         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3883
3884 2012-07-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3885
3886         [NRWT] Rename baseline_search_path() to default_baseline_search_path()
3887         https://bugs.webkit.org/show_bug.cgi?id=92122
3888
3889         Reviewed by Dirk Pranke.
3890
3891         * Scripts/webkitpy/layout_tests/port/base.py:
3892         (Port.baseline_version_dir):
3893         (Port.baseline_search_path):
3894         (Port):
3895         (Port.default_baseline_search_path):
3896         (Port.expected_baselines):
3897         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3898         (PortTest.test_additional_platform_directory):
3899         * Scripts/webkitpy/layout_tests/port/mac.py:
3900         (MacPort.default_baseline_search_path):
3901         * Scripts/webkitpy/layout_tests/port/qt.py:
3902         (QtPort.default_baseline_search_path):
3903         * Scripts/webkitpy/layout_tests/port/win.py:
3904         (WinPort.default_baseline_search_path):
3905
3906 2012-07-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3907
3908         [EFL] Use eina_stringshare_add instead of strdup.
3909         https://bugs.webkit.org/show_bug.cgi?id=92072
3910
3911         Reviewed by Kentaro Hara.
3912
3913         Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
3914         to replace strdup with eina_stringshare_add function.
3915
3916         DumpRenderTree also needs to be modified according to ewk APIs's parameter change.
3917
3918         * DumpRenderTree/efl/DumpRenderTree.cpp:
3919         (dumpFramesAsText):
3920         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3921         (DumpRenderTreeChrome::onFrameIntentNew):
3922         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3923         (onJavaScriptPrompt):
3924
3925 2012-07-25  Alexander Shalamov  <alexander.shalamov@intel.com>
3926
3927         [WTR][EFL] Wheel events are not emitted
3928         https://bugs.webkit.org/show_bug.cgi?id=92094
3929
3930         Reviewed by Csaba Osztrogonác.
3931
3932         Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.
3933
3934         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3935         (WTR::dispatchMouseScrollByEvent):
3936         (WTR::EventSenderProxy::mouseScrollBy):
3937         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3938         (WTR::PlatformWebView::PlatformWebView):
3939         (WTR::PlatformWebView::focus):
3940
3941 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3942
3943         [EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
3944         https://bugs.webkit.org/show_bug.cgi?id=92101
3945
3946         Reviewed by Kenneth Rohde Christiansen.
3947
3948         Added a centralized place for general initialization in UI process for EFL WK2.
3949
3950         * MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.
3951         (main):
3952         * WebKitTestRunner/efl/main.cpp: Ditto.
3953         (main):
3954
3955 2012-07-24  Benjamin Poulain  <bpoulain@apple.com> && Joseph Pecoraro  <pecoraro@apple.com>
3956
3957         QualifiedName's HashSet should be big enough to hold at least all the static names
3958         https://bugs.webkit.org/show_bug.cgi?id=91891
3959
3960         Reviewed by Darin Adler.
3961
3962         Add a test for WTF::hashTableCapacityForSize.
3963
3964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3965         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.
3966         (InitialCapacityTestHashTraits):
3967         (TestWebKitAPI::testInitialCapacity):
3968         (TestWebKitAPI::generateTestCapacityUpToSize):
3969         (TestWebKitAPI::TEST):
3970
3971 2012-07-24  Adam Barth  <abarth@webkit.org>
3972
3973         The EWS bots get flaky when we hit the failure limit
3974         https://bugs.webkit.org/show_bug.cgi?id=92212
3975
3976         Reviewed by Eric Seidel.
3977
3978         Previously we were missing some failure types, which means we didn't
3979         notice that the bots were hitting the failure limit.
3980
3981         * Scripts/webkitpy/common/net/layouttestresults.py:
3982         (LayoutTestResults.failing_test_results):
3983         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3984         (LayoutTestResultsTest.test_results_from_string):
3985         (LayoutTestResultsTest.test_tests_matching_failure_types):
3986
3987 2012-07-24  Raphael Kubo da Costa  <rakuco@webkit.org>
3988
3989         [EFL] Unreviewed build fix.
3990
3991         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h
3992         for usleep(3).
3993
3994 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
3995
3996         make test-webkitpy at least kinda work in parallel on win32
3997         https://bugs.webkit.org/show_bug.cgi?id=91700
3998
3999         Reviewed by Adam Barth.
4000
4001         This change makes the hoop-jumping we have to do to make running
4002         new-run-webkit-tests in parallel on win32 generic so that we can
4003         re-use it for test-webkitpy as well.
4004
4005         * Scripts/new-run-webkit-tests:
4006         * Scripts/test-webkitpy:
4007         * Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
4008         (run):
4009         * Scripts/webkitpy/test/main.py:
4010         (main):
4011         (Tester._log_exception):
4012
4013 2012-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
4014
4015         Unreviewed, rolling out r123499.
4016         http://trac.webkit.org/changeset/123499
4017         https://bugs.webkit.org/show_bug.cgi?id=92161
4018
4019         Android fails to compile (Requested by zhenyao on #webkit).
4020
4021         * DumpRenderTree/DumpRenderTree.gypi:
4022         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
4023         (MockWebKitPlatformSupport::createMediaStreamCenter):
4024         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
4025         (MockWebKitPlatformSupport):
4026         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
4027         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.
4028
4029 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
4030
4031         nrwt: never finds binaries in the 'out' dir on chromium win
4032         https://bugs.webkit.org/show_bug.cgi?id=91890
4033
4034         Reviewed by Tony Chang.
4035
4036         Attempt to fix this bug yet again; it turns out that --root and
4037         --build-directory don't have the same meaning (--root should
4038         include the configuration, --build-directory should not).
4039
4040         * Scripts/webkitpy/layout_tests/port/base.py:
4041         (Port._build_path):
4042         * Scripts/webkitpy/layout_tests/port/chromium.py:
4043         (ChromiumPort._static_build_path):
4044         (ChromiumPort.default_results_directory):
4045         (ChromiumPort._build_path):
4046         (ChromiumPort):
4047         (ChromiumPort._build_path_with_configuration):
4048         (ChromiumPort._build_path_with_configuration.does):
4049         (ChromiumPort._path_to_image_diff):
4050         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4051         (ChromiumAndroidPort._build_path):
4052         (ChromiumAndroidPort):
4053         (ChromiumAndroidPort._build_path_with_configuration):
4054         (ChromiumAndroidPort._path_to_driver):
4055         (ChromiumAndroidPort._path_to_forwarder):
4056         (ChromiumAndroidPort._push_executable):
4057         (ChromiumAndroidPort._push_fonts):
4058         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4059         (ChromiumLinuxPort._determine_driver_path_statically):
4060         (ChromiumLinuxPort._modules_to_search_for_symbols):
4061         (ChromiumLinuxPort._path_to_driver):
4062         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4063         (ChromiumLinuxPortTest.test_build_path):
4064         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4065         (ChromiumMacPort._modules_to_search_for_symbols):
4066         (ChromiumMacPort._path_to_driver):
4067         (ChromiumMacPort._path_to_helper):
4068         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4069         (ChromiumMacPortTest.test_build_path):
4070         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4071         (ChromiumWinPort._path_to_driver):
4072         (ChromiumWinPort._path_to_helper):
4073         (ChromiumWinPort._path_to_image_diff):
4074         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4075         (ChromiumWinTest.test_build_path):
4076         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4077         (parse_args):
4078
4079 2012-07-24  Peter Beverloo  <peter@chromium.org>
4080
4081         Android-chromium layout tests failing with GPU related crash
4082         https://bugs.webkit.org/show_bug.cgi?id=92126
4083
4084         Reviewed by Adam Barth.
4085
4086         Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
4087         as it's not being used by any port anymore, and neither is being passed
4088         on to the test runner. Instead, append the flag directly to DRT for the
4089         Chromium Android port, which does rely on this functionality.
4090
4091         The ChromiumAndroidUnitTest tests didn't catch this as the property was
4092         set to True, but it's unable to detect whether they'll actually be used.
4093         No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
4094         or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
4095
4096         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4097         (ChromiumAndroidPort.__init__):
4098         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
4099         (ChromiumAndroidPortTest.test_attributes):
4100         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4101         (parse_args):
4102
4103 2012-07-24  Alexander Shalamov  <alexander.shalamov@intel.com>
4104
4105         [WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
4106         https://bugs.webkit.org/show_bug.cgi?id=92107
4107
4108         Reviewed by Kenneth Rohde Christiansen.
4109
4110         Fixes mouse click events in EventSenderProxyEfl.
4111
4112         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
4113         (WTR::dispatchMouseDownEvent):
4114         (WTR::EventSenderProxy::dispatchEvent):
4115
4116 2012-07-24  Tommy Widenflycht  <tommyw@google.com>
4117
4118         MediaStream API: Update MediaStreamTrack to match the specification
4119         https://bugs.webkit.org/show_bug.cgi?id=90180
4120
4121         Reviewed by Adam Barth.
4122
4123         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
4124
4125         * DumpRenderTree/DumpRenderTree.gypi:
4126         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
4127         (MockWebKitPlatformSupport::createMediaStreamCenter):
4128         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
4129         (WebKit):
4130         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4131         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
4132         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
4133         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
4134         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
4135         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
4136         (WebKit::MockWebMediaStreamCenter::constructSDP):
4137         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
4138         (WebKit):
4139         (MockWebMediaStreamCenter):
4140         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4141
4142 2012-07-23  Ryosuke Niwa  <rniwa@webkit.org>
4143
4144         Fix regressions in replay performance tests
4145         https://bugs.webkit.org/show_bug.cgi?id=92052
4146
4147         Reviewed by Dirk Pranke.
4148
4149         Fix regression that accumulated over time to make replay tests work again.
4150
4151         * DumpRenderTree/chromium/WebViewHost.cpp:
4152         (WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
4153         URL hadn't been updated yet When requesting a new URL on the main frame.
4154         * Scripts/webkitpy/performance_tests/perftest.py:
4155         (ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
4156         (ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
4157         (ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
4158         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4159         (TestReplayPerfTest.test_run_single):
4160         (TestReplayPerfTest.test_prepare):
4161         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
4162         (TestReplayPerfTest):
4163
4164 2012-07-24  Simon Hausmann  <simon.hausmann@nokia.com>
4165
4166         [Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
4167         https://bugs.webkit.org/show_bug.cgi?id=91229
4168
4169         Reviewed by Jocelyn Turcotte.
4170
4171         In order to successfully link a DLL on Windows we need to have at least
4172         one object file (or compilation unit). The forward export header files were
4173         supposed to be that, but unfortunately the rule in win32/default_post.prf for
4174         creating the header files had some bugs, among others that it did an exists()
4175         check on the depending static library. At the time qmake is ran those libraries
4176         do not exist yet and therefore the corresponding extra compiler rules were never
4177         created, resulting in empty OBJECTS/SOURCES.
4178
4179         Even without such an exists() check, qmake extra compilers require the files
4180         referred to in the .input variable to exist at qmake time. In this case the input
4181         files were the static libraries, which do not exist yet.
4182
4183         This patch solves this by using a qmake extra target instead of extra
4184         compiler, which does not have this limitation. The target is referenced
4185         through the extension of GENERATED_SOURCES.
4186
4187         The patch also adds a d/_debug suffix for debug builds, do allow for separate
4188         symbol exports if necessary.
4189
4190         * Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
4191         consider the last argument to be the output file and everything else input.
4192         * qmake/mkspecs/features/win32/default_post.prf:
4193
4194 2012-07-24  Balazs Kelemen  <kbalazs@webkit.org>
4195
4196         [Qt] Add quirks for running the web process in a profiler shell, like valgrind
4197         https://bugs.webkit.org/show_bug.cgi?id=87672
4198
4199         Reviewed by Jocelyn Turcotte.
4200
4201         Add --no-timeout-at-all command line switch to not time out no matter how
4202         long the web process does it's job. --no-timeout is not enough for profiling
4203         purposes because it only affects the timeout when we are waiting for the end
4204         of the test. We use another timeout to control how much we wait for the web
4205         process to initialize before and reset after the test and it could also easily
4206         expire when running under valgrind. We should keep the behavior of --no-timeout
4207         to not disable this timout check because --no-timeout is used by performace tests
4208         and those should not wait for the web process to initialize and reset more than
4209         normal tests.
4210
4211         * WebKitTestRunner/TestController.cpp:
4212         (WTR::TestController::TestController):
4213         (WTR::TestController::initialize):
4214         (WTR::TestController::runUntil):
4215         * WebKitTestRunner/TestController.h:
4216
4217 2012-07-24  Peter Beverloo  <peter@chromium.org>
4218
4219         [Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
4220         https://bugs.webkit.org/show_bug.cgi?id=92097
4221
4222         Unreviewed build fix.
4223
4224         WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
4225         but TestDelegate.h forward declares it as a class.
4226
4227         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
4228         (WebKit):
4229
4230 2012-07-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
4231
4232         [Qt] Fix compilation against namespaced Qt
4233
4234         Reviewed by Simon Hausmann.
4235
4236         * QtTestBrowser/launcherwindow.h:
4237         * WebKitTestRunner/PlatformWebView.h:
4238
4239 2012-07-24  Peter Beverloo  <peter@chromium.org>
4240
4241         Update a few Chromium Android contributors in committers.py
4242         https://bugs.webkit.org/show_bug.cgi?id=92090
4243
4244         Reviewed by Kent Tamura.
4245
4246         Add Sami Kyostila, who has been doing significant work on Chromium's
4247         compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
4248         remove John Grabowski who changed projects, and add my webkit.org alias.
4249
4250         * Scripts/webkitpy/common/config/committers.py:
4251
4252 2012-07-24  Pierre Rossi  <pierre.rossi@gmail.com>
4253
4254         [Qt] Enable touch slider when touch events are enabled
4255         https://bugs.webkit.org/show_bug.cgi?id=91013
4256
4257         Reviewed by Kenneth Rohde Christiansen.
4258
4259         TOUCH_SLIDER guards are used in WebCore, so we should really
4260         be setting the corresponding ENABLE define in features.prf.
4261
4262         * qmake/mkspecs/features/features.prf:
4263
4264 2012-07-24  Ryuan Choi  <ryuan.choi@samsung.com>
4265
4266         [EFL] EWebLauncher should not require config.h in the style check
4267         https://bugs.webkit.org/show_bug.cgi?id=92070
4268
4269         Reviewed by Kentaro Hara.
4270
4271         * Scripts/webkitpy/style/checker.py:
4272         Remove the include rules from the style-check for EWebLauncher because
4273         EWebLauncher is simple EFL application.
4274
4275 2012-07-24  Jochen Eisinger  <jochen@chromium.or>
4276
4277         [Chromium] EventSender shouldn't know about TestShell
4278         https://bugs.webkit.org/show_bug.cgi?id=91449
4279
4280         Reviewed by Adam Barth.
4281
4282         Original patch by Adam Barth.
4283
4284         This patch removes the dependency from EventSender to TestShell.  Most
4285         of EventSender works directly with a WebView, but there are a handful
4286         of references to WebViewHost.  We don't want to re-use WebViewHost in
4287         ContentShell because we want to use the multi-process embedding
4288         environment for WebViews.
4289
4290         To avoid the dependency on WebViewHost, this patch introduces
4291         TestDelegate, which is an abstract base class for WebViewHost.  In
4292         ContentShell, we'll need another object to implement these functions.
4293
4294         * DumpRenderTree/chromium/EventSender.cpp:
4295         (EventSender::EventSender):
4296         (EventSender::keyDown):
4297         (makeMenuItemStringsFor):
4298   &