8c252b7d1bb68940830f0cec7d1e2f35d35e4292
[WebKit-https.git] / Tools / ChangeLog
1 2016-12-05  Dan Bernstein  <mitz@apple.com>
2
3         Disable a crashing test on iOS.
4
5         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
6
7 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
8
9         Fix a build break on EFL since r209303.
10
11         Unreviewed build fix.
12
13         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
14
15 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
16
17         Refactor SymbolImpl layout
18         https://bugs.webkit.org/show_bug.cgi?id=165247
19
20         Reviewed by Darin Adler.
21
22         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
23         (TestWebKitAPI::TEST):
24
25 2016-12-03  Dan Bernstein  <mitz@apple.com>
26
27         Fixed the build after r209307.
28
29         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
30         (TEST):
31
32 2016-12-03  Dan Bernstein  <mitz@apple.com>
33
34         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
35         https://bugs.webkit.org/show_bug.cgi?id=165276
36         <rdar://problem/29467040>
37
38         Reviewed by Darin Adler.
39
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
42         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
43         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
44         (TEST):
45         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
46         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
47         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
48         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
49         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
50         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
51
52 2016-12-02  Andy Estes  <aestes@apple.com>
53
54         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
55         https://bugs.webkit.org/show_bug.cgi?id=164492
56
57         Reviewed by Dan Bernstein.
58
59         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
60         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
61         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
62         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
63         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
64         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
65         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
66         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
67         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
68         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
69         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
70         com.apple.$(PRODUCT_NAME:rfc1034identifier).
71         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
72         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
73         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
74         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
75         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
76         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
77         com.apple.$(PRODUCT_NAME:rfc1034identifier).
78         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
79         com.apple.$(PRODUCT_NAME:rfc1034identifier).
80         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
81         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
82         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
83         value ${PRODUCT_BUNDLE_IDENTIFIER}.
84         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
85         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
86         com.apple.WebKitTestRunner.InjectedBundle.
87         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
88         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
89         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
90         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
91         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
92         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
93         ${PRODUCT_BUNDLE_IDENTIFIER}.
94
95 2016-12-02  Brady Eidson  <beidson@apple.com>
96
97         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
98         https://bugs.webkit.org/show_bug.cgi?id=165330
99
100         Reviewed by Alex Christensen.
101
102         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
103
104         Problem is that doesn't reliably destroy the view.
105         We should explicitly kill the process instead.
106
107         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
108         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
109
110         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
111         (TEST):
112
113 2016-12-02  Commit Queue  <commit-queue@webkit.org>
114
115         Unreviewed, rolling out r209136.
116         https://bugs.webkit.org/show_bug.cgi?id=165337
117
118         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
119
120         Reverted changeset:
121
122         "Make it possible to use an existing simulator instance for
123         one-off testing"
124         https://bugs.webkit.org/show_bug.cgi?id=164568
125         http://trac.webkit.org/changeset/209136
126
127 2016-12-02  Chris Dumez  <cdumez@apple.com>
128
129         [Mac][WK1] Implement new HTML interactive form validation user interface
130         https://bugs.webkit.org/show_bug.cgi?id=164483
131
132         Reviewed by Simon Fraser.
133
134         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
135         on Mac DRT as this is needed by the HTML form validation layout tests.
136
137         * DumpRenderTree/mac/UIScriptControllerMac.mm:
138         (WTR::UIScriptController::contentsOfUserInterfaceItem):
139
140 2016-12-02  Brady Eidson  <beidson@apple.com>
141
142         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
143         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
144
145         Reviewed by Alexey Proskuryakov.
146
147         These tests had "run-loop races."
148         
149         The test spins the runloop waiting for one message.
150         Two messages might come in from the WebProcess in short succession, and both be delivered to the
151         UIProcess in the same spin of the runloop.
152
153         Therefore by the time the test stops spinning the runloop, notified that a message was received,
154         the first message has been overwritten by the second.
155
156         These tests are fixed by queueing the incoming messages instead of just storing one.
157
158         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
159         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
160         (getNextMessage):
161         (TEST):
162
163         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
164         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
165         (getNextMessage):
166         (TEST):
167
168 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
169
170         Add a runtime flag for SubtleCrypto
171         https://bugs.webkit.org/show_bug.cgi?id=164982
172
173         Reviewed by Brent Fulgham.
174
175         * DumpRenderTree/mac/DumpRenderTree.mm:
176         (resetWebPreferencesToConsistentValues):
177         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
178         (WTR::InjectedBundle::beginTesting):
179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
180         (WTR::TestRunner::setSubtleCryptoEnabled):
181         * WebKitTestRunner/InjectedBundle/TestRunner.h:
182
183 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
184
185         Remove webkitpy dependency on Eliza
186         https://bugs.webkit.org/show_bug.cgi?id=164979
187
188         Reviewed by Daniel Bates.
189
190         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
191
192         * Scripts/webkitpy/thirdparty/__init__.py:
193         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
194         test buildbot instead of eliza.
195         * Scripts/webkitpy/tool/bot/ircbot.py:
196         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
197
198 2016-12-01  Beth Dakin  <bdakin@apple.com>
199
200         Force clicking tests fail on some machines
201         https://bugs.webkit.org/show_bug.cgi?id=165263
202
203         Reviewed by Tim Horton.
204
205         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
206         the user account having this feature enabled. 
207         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
208         (WTR::InjectedBundle::platformInitialize):
209         * WebKitTestRunner/mac/main.mm:
210         (setDefaultsToConsistentValuesForTesting):
211
212 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
213
214         Introduce StringImpl::StaticStringImpl with constexpr constructor
215         https://bugs.webkit.org/show_bug.cgi?id=165093
216
217         Reviewed by Darin Adler.
218
219         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
220         (TestWebKitAPI::TEST):
221
222 2016-11-30  Antoine Quint  <graouts@apple.com>
223
224         [Modern Media Controls] Add an HTML comment flag to turn the feature on
225         https://bugs.webkit.org/show_bug.cgi?id=165226
226
227         Reviewed by Dean Jackson.
228
229         Add a new flag to turn Modern Media Controls on in the test runners.
230
231         * DumpRenderTree/TestOptions.h:
232         * DumpRenderTree/TestOptions.mm:
233         (TestOptions::TestOptions):
234         * DumpRenderTree/mac/DumpRenderTree.mm:
235         (resetWebPreferencesToConsistentValues):
236         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
237         (WTR::InjectedBundle::beginTesting):
238         * WebKitTestRunner/TestController.cpp:
239         (WTR::TestController::resetPreferencesToConsistentValues):
240         (WTR::updateTestOptionsFromTestHeader):
241         * WebKitTestRunner/TestOptions.h:
242         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
243         (WTR::PlatformWebView::viewSupportsOptions):
244         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
245         (WTR::PlatformWebView::viewSupportsOptions):
246
247 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
248
249         Add separate settings and preferences to enable/disable async decoding for large images and animated images
250         https://bugs.webkit.org/show_bug.cgi?id=165177
251
252         Reviewed by Simon Fraser.
253         
254         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
255
256         * MiniBrowser/mac/SettingsController.h:
257         * MiniBrowser/mac/SettingsController.m:
258         (-[SettingsController _populateMenu]):
259         (-[SettingsController validateMenuItem:]):
260         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
261         (-[SettingsController largeImageAsyncDecodingEnabled]):
262         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
263         (-[SettingsController animatedImageAsyncDecodingEnabled]):
264         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
265         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
266         * MiniBrowser/mac/WK1BrowserWindowController.m:
267         (-[WK1BrowserWindowController didChangeSettings]):
268         * MiniBrowser/mac/WK2BrowserWindowController.m:
269         (-[WK2BrowserWindowController didChangeSettings]):
270
271 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
272
273         Make it possible to use an existing simulator instance for one-off testing
274         https://bugs.webkit.org/show_bug.cgi?id=164568
275         <rdar://problem/29189133>
276
277         Reviewed by Daniel Bates.
278
279         With this patch, if a simulator is currently running on the machine and
280         '--dedicated-simulators' is not passed into the application, only one simulator
281         instance will be used, and this instance will be the existing instance.
282         If no simulator is running or '--dedicated-simulators' is passed to the script,
283         previous behavior will be used.
284
285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
286         (parse_args):
287         * Scripts/webkitpy/port/ios.py:
288         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
289         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
290         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
291         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
292         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
293         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
294         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
295         * Scripts/webkitpy/xcode/simulator.py:
296         (Simulator.current_device): Get currently running device.
297
298 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
299
300         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
301         https://bugs.webkit.org/show_bug.cgi?id=164792
302
303         Reviewed by Michael Catanzaro.
304
305         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
306         and adds a new LinuxBrowserDriver with a platform 'linux'.
307
308         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
309
310         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
311
312         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
313         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
314         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
315         This depends on psutil, so this will only be done if psutil is installed.
316
317         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
318         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
319         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
320         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
321         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
322         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
323         (LinuxBrowserDriver.__init__):
324         (LinuxBrowserDriver.prepare_env):
325         (LinuxBrowserDriver.restore_env):
326         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
327         (LinuxBrowserDriver.launch_url):
328         (LinuxBrowserDriver._get_first_executable_path_from_list):
329         (LinuxBrowserDriver._screen_size):
330         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
331         (LinuxChromeDriver):
332         (LinuxChromeDriver.launch_url):
333         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
334         (EpiphanyBrowserDriver):
335         (EpiphanyBrowserDriver.launch_url):
336         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
337         (LinuxFirefoxDriver):
338         (LinuxFirefoxDriver.launch_url):
339         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
340         (GTKMiniBrowserDriver):
341         (GTKMiniBrowserDriver.launch_url):
342         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
343         (SimpleHTTPServerDriver):
344         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
345         (getplatform):
346         (getdefaultbrowser):
347         (parse_args):
348         * Scripts/webkitpy/benchmark_runner/utils.py:
349         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
350         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
351         we can do that by matching against the base_class_file pattern when the list is created.
352
353 2016-11-29  Andy Estes  <aestes@apple.com>
354
355         [Cocoa] Enable two clang warnings recommended by Xcode
356         https://bugs.webkit.org/show_bug.cgi?id=164498
357
358         Reviewed by Mark Lam.
359
360         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
361         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
362         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
363         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
364
365 2016-11-29  Eric Carlson  <eric.carlson@apple.com>
366
367         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
368         https://bugs.webkit.org/show_bug.cgi?id=164760
369         <rdar://problem/29261266>
370
371         Reviewed by Youenn Fablet.
372         
373         Allow scripts to determine the number of times the user has been prompted for capture device access.
374
375         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
376         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
377         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
378         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
379         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
380         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
381         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
382         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
383         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
384         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
385         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
386         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
387         * WebKitTestRunner/InjectedBundle/TestRunner.h:
388         * WebKitTestRunner/TestController.cpp:
389         (WTR::TestController::resetStateToConsistentValues):
390         (WTR::OriginSettings::incrementRequestCount):
391         (WTR::OriginSettings::resetRequestCount):
392         (WTR::OriginSettings::requestCount):
393         (WTR::TestController::saltForOrigin):
394         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
395         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
396         (WTR::TestController::settingsForOrigin):
397         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
398         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
399         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
400         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
401         * WebKitTestRunner/TestController.h:
402         * WebKitTestRunner/TestInvocation.cpp:
403         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
404         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
405
406 2016-11-29  Simon Fraser  <simon.fraser@apple.com>
407
408         intersection-observer-entry-interface.html test fails on the bots
409         https://bugs.webkit.org/show_bug.cgi?id=165133
410
411         Reviewed by Darin Adler.
412         
413         Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
414         would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
415         to see if this option required creating a new web view, so would just use the old view without
416         even resetting preferences.
417         
418         In general, TestController doesn't distinguish properly between options that require the creation
419         of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
420         does.
421         
422         Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
423         just call resetPreferencesToConsistentValues() even when re-use the same view.
424         
425         * WebKitTestRunner/TestController.cpp:
426         (WTR::TestController::resetPreferencesToConsistentValues):
427         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
428         (WTR::PlatformWebView::viewSupportsOptions):
429         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
430         (WTR::PlatformWebView::viewSupportsOptions):
431
432 2016-11-28  Ryan Haddad  <ryanhaddad@apple.com>
433
434         Unreviewed, rolling out r209008.
435
436         This change appears to have caused two fast/mediastrem
437         LayoutTests to fail.
438
439         Reverted changeset:
440
441         "[MediaStream] Don't request user permission for a device if
442         it has already been granted in the current browsing context"
443         https://bugs.webkit.org/show_bug.cgi?id=164760
444         http://trac.webkit.org/changeset/209008
445
446 2016-11-28  Daniel Bates  <dabates@apple.com>
447
448         Teach webkitpy how to read CSSProperties.json r209001
449         https://bugs.webkit.org/show_bug.cgi?id=165108
450
451         Reviewed by Simon Fraser.
452
453         Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
454
455         Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
456         We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
457
458         * Scripts/webkitpy/w3c/test_converter.py:
459         (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
460         variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
461         to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
462         read CSS keyword values from CSSValueKeywords.in.
463         (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
464         (_W3CTestConverter):
465         (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
466         * Scripts/webkitpy/w3c/test_importer_unittest.py:
467         (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
468
469 2016-11-28  Eric Carlson  <eric.carlson@apple.com>
470
471         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
472         https://bugs.webkit.org/show_bug.cgi?id=164760
473         <rdar://problem/29261266>
474
475         Reviewed by Youenn Fablet.
476         
477         Allow scripts to determine the number of times the user has been prompted for capture device access.
478
479         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
480         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
481         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
482         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
483         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
484         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
485         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
486         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
487         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
488         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
489         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
490         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
492         * WebKitTestRunner/TestController.cpp:
493         (WTR::TestController::resetStateToConsistentValues):
494         (WTR::OriginSettings::incrementRequestCount):
495         (WTR::OriginSettings::resetRequestCount):
496         (WTR::OriginSettings::requestCount):
497         (WTR::TestController::saltForOrigin):
498         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
499         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
500         (WTR::TestController::settingsForOrigin):
501         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
502         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
503         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
504         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
505         * WebKitTestRunner/TestController.h:
506         * WebKitTestRunner/TestInvocation.cpp:
507         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
508         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
509
510 2016-11-18  Jer Noble  <jer.noble@apple.com>
511
512         Add some performance tests for various aspects of media loading and playback.
513         https://bugs.webkit.org/show_bug.cgi?id=164977
514
515         Reviewed by Darin Adler.
516
517         Allow callers to pass in extra alias/directory pairs to run-webkit-httpd.
518
519         * Scripts/run-webkit-httpd:
520         (parse_args):
521         (main):
522
523 2016-11-27  Simon Fraser  <simon.fraser@apple.com>
524
525         Another fix for CMake.
526
527         * DumpRenderTree/TestOptions.h:
528         * DumpRenderTree/TestOptions.mm:
529
530 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
531
532         Better fix for the Mac CMake build.
533
534         * DumpRenderTree/PlatformMac.cmake:
535
536 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
537
538         Attempt to fix Mac CMake build.
539
540         * DumpRenderTree/PlatformMac.cmake:
541
542 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
543
544         [WTF] Import std::optional reference implementation as WTF::Optional
545         https://bugs.webkit.org/show_bug.cgi?id=164199
546
547         Reviewed by Saam Barati and Sam Weinig.
548
549         Use WTF::Optional::value_or.
550
551         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
552         (WTR::UIScriptController::stableStateOverride):
553         (WTR::UIScriptController::setStableStateOverride):
554         * TestRunnerShared/Bindings/JSWrappable.h:
555         (WTR::JSValueMakeBooleanOrNull):
556         (WTR::JSValueToNullableBoolean):
557         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
558         (WTR::UIScriptController::stableStateOverride):
559         (WTR::UIScriptController::setStableStateOverride):
560         * TestRunnerShared/UIScriptContext/UIScriptController.h:
561         * TestWebKitAPI/Tests/WTF/Optional.cpp:
562         (TestWebKitAPI::TEST):
563         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
564         (TestWebKitAPI::testParseHTMLInteger):
565         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
566         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
567         (TestWebKitAPI::checkURL):
568         (TestWebKitAPI::checkRelativeURL):
569         (TestWebKitAPI::checkURLDifferences):
570         (TestWebKitAPI::checkRelativeURLDifferences):
571         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
572         (WTR::UIScriptController::stableStateOverride):
573         (WTR::UIScriptController::setStableStateOverride):
574
575 2016-11-26  Sam Weinig  <sam@webkit.org>
576
577         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
578         https://bugs.webkit.org/show_bug.cgi?id=164965
579
580         Reviewed by Simon Fraser.
581
582         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
583         Add new files.
584
585         * DumpRenderTree/TestOptions.h: Added.
586         * DumpRenderTree/TestOptions.mm: Added.
587         (parseBooleanTestHeaderValue):
588         (TestOptions::TestOptions):
589         Port TestOption parsing from WKTR to DRT.
590
591         * DumpRenderTree/mac/DumpRenderTree.mm:
592         (resetWebPreferencesToConsistentValues):
593         (resetWebViewToConsistentStateBeforeTesting):
594         (runTest):
595         * WebKitTestRunner/TestController.cpp:
596         Pass TestOptions down to resetWebPreferencesToConsistentValues to allow setting
597         preferences conditionally.
598
599         (WTR::TestController::resetPreferencesToConsistentValues):
600         (WTR::updateTestOptionsFromTestHeader):
601         * WebKitTestRunner/TestOptions.h:
602         Add a new test option header, enableIntersectionObserver, to enable IntersectionObserver.
603
604 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
605
606         Migrate some layout timer-related code from std::chrono to Seconds and MonotonicTime
607         https://bugs.webkit.org/show_bug.cgi?id=164992
608
609         Reviewed by Darin Adler.
610         
611         Use Seconds::zero().
612
613         * TestWebKitAPI/Tests/WTF/Condition.cpp:
614
615 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
616
617         Add literals for various time units
618         https://bugs.webkit.org/show_bug.cgi?id=165074
619
620         Reviewed by Filip Pizlo.
621         
622         Add tests for new time literals. Add new tests for units.
623
624         * TestWebKitAPI/Tests/WTF/Time.cpp:
625         (TestWebKitAPI::TEST):
626
627 2016-11-25  Csaba Osztrogonác  <ossy@webkit.org>
628
629         Fix compile warnings after r208415
630         https://bugs.webkit.org/show_bug.cgi?id=165061
631
632         Reviewed by Andy Estes.
633
634         * TestWebKitAPI/Tests/WTF/Time.cpp:
635         (TestWebKitAPI::TEST):
636
637 2016-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
638
639         [GTK] Notifications API does not expose or respect the "tag" attribute
640         https://bugs.webkit.org/show_bug.cgi?id=164771
641
642         Reviewed by Gustavo Noronha Silva.
643
644         Verify that showing a notification with the same tag as another notification closes the
645         previous notification before the new notification is shown.
646
647         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
648         (testWebViewNotification):
649
650 2016-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
651
652         Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429.
653
654         Test plugin library was renamed as libTestNetscapePlugIn.so in r208429.
655
656         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
657         (testWebContextGetPlugins): Update the library name.
658
659 2016-11-22  Darin Adler  <darin@apple.com>
660
661         Make normal case fast in the input element limitString function
662         https://bugs.webkit.org/show_bug.cgi?id=165023
663
664         Reviewed by Dan Bernstein.
665
666         * TestWebKitAPI/CMakeLists.txt: Added TextBreakIterator.cpp.
667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
668         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: Added.
669         Contains some tests for the numGraphemeClusters and
670         numCharactersInGraphemeClusters functions that I used to make sure
671         that the new fast paths I added work correctly.
672
673 2016-11-22  Tomas Popela  <tpopela@redhat.com>
674
675         Unreviewed, add myself as a WebKit committer.
676
677         * Scripts/webkitpy/common/config/contributors.json:
678
679 2016-11-21  Mark Lam  <mark.lam@apple.com>
680
681         Hasher::addCharacters() should be able to handle zero length strings.
682         https://bugs.webkit.org/show_bug.cgi?id=165024
683
684         Reviewed by Yusuke Suzuki.
685
686         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
687         (TestWebKitAPI::TEST):
688
689 2016-11-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
690
691         [CMake] build fails after update to cmake 3.7
692         https://bugs.webkit.org/show_bug.cgi?id=165008
693
694         Reviewed by Dan Bernstein.
695
696         When we remove the CMake cache, we should remove both the
697         CMakeCache.txt file and the CMakeFiles directory.
698         See: https://gitlab.kitware.com/cmake/cmake/issues/14820
699
700         * Scripts/webkitdirs.pm:
701         (cmakeFilesPath):
702         (removeCMakeCache):
703
704 2016-11-16  Philippe Normand  <pnormand@igalia.com>
705
706         [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
707         https://bugs.webkit.org/show_bug.cgi?id=164817
708
709         Reviewed by Alejandro G. Castro.
710
711         This is temporary, hopefully. The OpenWebRTC patches will/should
712         be soon reviewed and upstream but meanwhile it makes sense to use
713         the Igalia downstream fork so that the WebRTC testing is easier.
714
715         Recent GStreamer patches are also needed for RTP bundling support
716         and RTP retransmission fixes.
717
718         * gtk/jhbuild.modules:
719         * gtk/openwebrtc.modules: Removed.
720         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Added.
721         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Added.
722         * gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
723
724 2016-11-20  Zan Dobersek  <zdobersek@igalia.com>
725
726         [EncryptedMedia] Make EME API runtime-enabled
727         https://bugs.webkit.org/show_bug.cgi?id=164927
728
729         Reviewed by Jer Noble.
730
731         Enable the EME API via the WKTR InjectedBundle whenever testing
732         commences. This does not have any effect unless the EME feature
733         is enabled at compile-time, but it's still added to match other
734         features and for future use.
735
736         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
737         (WTR::InjectedBundle::beginTesting):
738         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
739         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
740         * WebKitTestRunner/InjectedBundle/TestRunner.h:
741
742 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
743
744         Fix the Mac and iOS bulds.
745
746         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
747         (-[TestRunnerWKWebView _stableStateOverride]):
748         (-[TestRunnerWKWebView _setStableStateOverride:]):
749
750 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
751
752         Make it possible to test non-stable-state scrolling on iOS
753         https://bugs.webkit.org/show_bug.cgi?id=164905
754
755         Reviewed by Dan Bernstein.
756
757         Make it possible for an iOS layout test to force every visible rect update
758         from the UI process to the web process to be in a non-stable state. This emulates
759         what happens during panning and zooming interactions, and allows us to test the
760         scrolling and layer trees in these transient states.
761         
762         This is done by adding a testing property on WKWebView, _stableStateOverride, whose
763         getters and setters are overridden in TestRunnerWKWebView. When non-nil, we _updateVisibleContentRectAfterScrollInView
764         consults the NSNumber's boolValue and uses it to override the stable state.
765         
766         To facilitate this kind of testing, also add immediateScrollToOffset() and
767         immediateZoomToScale() to UIScriptController. Finally, add doAfterPresentationUpdate()
768         which provides a callback that fires after one trip to the web process and back.
769         
770         Add code generation support for optional boolean attributes in IDL.
771
772         Align CodeGeneratorDumpRenderTree.pm and CodeGeneratorTestRunner.pm.
773
774         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
775         (_generateImplementationFile):
776         (_platformTypeConstructor):
777         (_returnExpression):
778         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
779         (WTR::UIScriptController::doAfterPresentationUpdate):
780         (WTR::contentOffsetBoundedInValidRange):
781         (WTR::UIScriptController::scrollToOffset):
782         (WTR::UIScriptController::immediateScrollToOffset):
783         (WTR::UIScriptController::immediateZoomToScale):
784         (WTR::UIScriptController::stableStateOverride):
785         (WTR::UIScriptController::setStableStateOverride):
786         * DumpRenderTree/mac/UIScriptControllerMac.mm:
787         (WTR::UIScriptController::doAfterPresentationUpdate):
788         * TestRunnerShared/Bindings/JSWrappable.h:
789         (WTR::JSValueMakeBooleanOrNull):
790         (WTR::JSValueToNullableBoolean):
791         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
792         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
793         (WTR::UIScriptController::immediateScrollToOffset):
794         (WTR::UIScriptController::immediateZoomToScale):
795         (WTR::UIScriptController::stableStateOverride):
796         (WTR::UIScriptController::setStableStateOverride):
797         * TestRunnerShared/UIScriptContext/UIScriptController.h:
798         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
799         (_classRefGetter):
800         (_platformTypeConstructor):
801         (_returnExpression):
802         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
803         (-[TestRunnerWKWebView dealloc]):
804         (-[TestRunnerWKWebView _stableStateOverride]):
805         (-[TestRunnerWKWebView _setStableStateOverride:]):
806         * WebKitTestRunner/ios/TestControllerIOS.mm:
807         (WTR::TestController::platformResetStateToConsistentValues):
808         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
809         (WTR::UIScriptController::doAsyncTask):
810         (WTR::UIScriptController::doAfterPresentationUpdate):
811         (WTR::UIScriptController::zoomToScale):
812         (WTR::UIScriptController::immediateScrollToOffset):
813         (WTR::UIScriptController::immediateZoomToScale):
814         (WTR::UIScriptController::stableStateOverride):
815         (WTR::UIScriptController::setStableStateOverride):
816         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
817         (WTR::UIScriptController::doAfterPresentationUpdate):
818
819 2016-11-19  Joanmarie Diggs  <jdiggs@igalia.com>
820
821         AX: [ATK] Expose aria-busy via ATK_STATE_BUSY
822         https://bugs.webkit.org/show_bug.cgi?id=164909
823
824         Reviewed by Chris Fleizach.
825
826         Implement boolAttributeValue() for ATK so we can test AXElementBusy.
827
828         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
829         (WTR::AccessibilityUIElement::boolAttributeValue):
830
831 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
832
833         [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override
834         https://bugs.webkit.org/show_bug.cgi?id=164980
835
836         Reviewed by Chris Dumez.
837
838         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
839         (WTR::InjectedBundlePage::prepare):
840
841 2016-11-18  Dean Jackson  <dino@apple.com>
842
843         AX: "(inverted-colors)" media query only matches on page reload; should match on change
844         https://bugs.webkit.org/show_bug.cgi?id=163564
845         <rdar://problem/28807350>
846
847         Reviewed by Simon Fraser.
848
849         Add a UIScriptController method that tricks WebKit into thinking
850         it has received a notification that accessibility settings have
851         changed. Combined with our forced overrides, this allows us to
852         test if a page would react to the notifications.
853
854         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
855         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
856         * DumpRenderTree/mac/UIScriptControllerMac.mm:
857         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
858         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
859         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
860         (WTR::simulateAccessibilitySettingsChangeNotification):
861         * TestRunnerShared/UIScriptContext/UIScriptController.h:
862         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
863         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
864         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
865         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
866
867 2016-11-18  Alex Christensen  <achristensen@webkit.org>
868
869         Fix API test after r208902
870         https://bugs.webkit.org/show_bug.cgi?id=144194
871
872         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
873         (TestWebKitAPI::TEST):
874         The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it
875         to spoof other domains.  https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look 
876         too similar when rendered.
877
878 2016-11-17  Alex Christensen  <achristensen@webkit.org>
879
880         Support IDN2008 with UTS #46 instead of IDN2003
881         https://bugs.webkit.org/show_bug.cgi?id=144194
882
883         Reviewed by Darin Adler.
884
885         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
886         (TestWebKitAPI::TEST_F):
887         Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008.
888         Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text.
889         Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check.
890         Add a test for U+321D and U+321E which have particularly interesting punycode encodings.  We match Firefox here now.
891         Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003.
892         We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests.
893
894 2016-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
895
896         Downloads started by context menu actions should also have a web view associated
897         https://bugs.webkit.org/show_bug.cgi?id=164364
898
899         Reviewed by Michael Catanzaro.
900
901         Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated.
902
903         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
904         (downloadLocalFileSuccessfully):
905         (testDownloadOverwriteDestinationDisallowed):
906         (testDownloadLocalFileError):
907         (testDownloadRemoteFile):
908         (testDownloadRemoteFileError):
909         (testDownloadMIMEType):
910         (contextMenuCallback):
911         (testContextMenuDownloadActions):
912         (beforeAll):
913
914 2016-11-17  Ryosuke Niwa  <rniwa@webkit.org>
915
916         Add an experimental API to find elements across shadow boundaries
917         https://bugs.webkit.org/show_bug.cgi?id=164851
918         <rdar://problem/28220092>
919
920         Reviewed by Sam Weinig.
921
922         Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen.
923
924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
925         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed
926         from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp.
927         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for
928         window.collectMatchingElementsInFlatTree by calling alert() many times.
929         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
930         (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case
931         finishes with a call to alert, and moves testNumber forward.
932         (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html
933         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots
934         and tests that window.collectMatchingElementsInFlatTree is not present when
935         an event named "testnormalworld" is dispatched by the injected bundle.
936
937 2016-11-17  Brady Eidson  <beidson@apple.com>
938
939         Add _WKIconLoadingDelegate SPI.
940         https://bugs.webkit.org/show_bug.cgi?id=164894
941
942         Reviewed by Alex Christensen.
943
944         Add MiniBrowser support for this new SPI, configurable with a setting.
945
946         * MiniBrowser/mac/SettingsController.h:
947         * MiniBrowser/mac/SettingsController.m:
948         (-[SettingsController _populateMenu]):
949         (-[SettingsController validateMenuItem:]):
950         (-[SettingsController loadsAllSiteIcons]):
951         (-[SettingsController toggleLoadsAllSiteIcons:]):
952         * MiniBrowser/mac/WK2BrowserWindowController.m:
953         (-[WK2BrowserWindowController awakeFromNib]):
954         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
955
956 2016-11-17  Caitlin Potter  <caitp@igalia.com>
957
958         [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag
959         https://bugs.webkit.org/show_bug.cgi?id=164879
960
961         Reviewed by Alex Christensen.
962
963         The flag was referenced in FeatureList.pm and in one of the
964         FeatureDefines.xcconfig files, despite being removed.
965
966         * Scripts/webkitperl/FeatureList.pm:
967         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
968
969 2016-11-17  Per Arne Vollan  <pvollan@apple.com>
970
971         [Win] run-api-tests is failing.
972         https://bugs.webkit.org/show_bug.cgi?id=164818
973
974         Reviewed by Alexey Proskuryakov.
975
976         Make sure Visual Studio interprets string literal as utf8.
977  
978         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
979         (TestWebKitAPI::TEST_F):
980
981 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
982
983         [JSC] WTF::TemporaryChange with WTF::SetForScope
984         https://bugs.webkit.org/show_bug.cgi?id=164761
985
986         Reviewed by Saam Barati.
987
988         * TestWebKitAPI/CMakeLists.txt:
989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
990         * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp.
991         (TestWebKitAPI::TEST):
992         * WebKitTestRunner/TestController.cpp:
993         (WTR::TestController::resetStateToConsistentValues):
994
995 2016-11-16  Alexey Proskuryakov  <ap@apple.com>
996
997         REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
998         https://bugs.webkit.org/show_bug.cgi?id=164572
999
1000         Reviewed by Tim Horton.
1001
1002         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues):
1003         Use the correct constant.
1004
1005 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1006
1007         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
1008         https://bugs.webkit.org/show_bug.cgi?id=164827
1009
1010         Reviewed by Ryosuke Niwa.
1011
1012         Enabled ES6 Modules in test runners.
1013
1014         * DumpRenderTree/mac/DumpRenderTree.mm:
1015         (resetWebPreferencesToConsistentValues):
1016         * DumpRenderTree/win/DumpRenderTree.cpp:
1017         (resetWebPreferencesToConsistentValues):
1018         * Scripts/webkitperl/FeatureList.pm:
1019         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1020         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1021         (WTR::InjectedBundle::beginTesting):
1022         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1023         (WTR::TestRunner::setES6ModulesEnabled):
1024         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1025
1026 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
1027
1028         Hard to write reliable UIScriptController scrollingTreeAsText tests
1029         https://bugs.webkit.org/show_bug.cgi?id=164764
1030
1031         Reviewed by Wenson Hsieh.
1032
1033         Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale
1034         and scroll position between tests.
1035
1036         * WebKitTestRunner/ios/TestControllerIOS.mm:
1037         (WTR::TestController::platformResetStateToConsistentValues):
1038
1039 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
1040
1041         UIScriptController: script with no async tasks fails if an earlier script registered a callback
1042         https://bugs.webkit.org/show_bug.cgi?id=164762
1043
1044         Reviewed by Wenson Hsieh.
1045         
1046         Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior.
1047         This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript()
1048         would occur inside the completion callback from the first. This no longer happens.
1049
1050         * DumpRenderTree/TestRunner.cpp:
1051         (TestRunner::callUIScriptCallback):
1052         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1053         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1054
1055 2016-11-16  Ryan Haddad  <ryanhaddad@apple.com>
1056
1057         Unreviewed, rolling out r208770.
1058
1059         The test added with this change is timing out on mac-wk1.
1060
1061         Reverted changeset:
1062
1063         "UIScriptController: script with no async tasks fails if an
1064         earlier script registered a callback"
1065         https://bugs.webkit.org/show_bug.cgi?id=164762
1066         http://trac.webkit.org/changeset/208770
1067
1068 2016-11-16  Per Arne Vollan  <pvollan@apple.com>
1069
1070         [Win] WebCore test is failing.
1071         https://bugs.webkit.org/show_bug.cgi?id=164772
1072
1073         Reviewed by Brent Fulgham.
1074
1075         The value of CGRectInfinite is not the same on Windows as on Mac.
1076
1077         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1078         (TestWebKitAPI::TEST):
1079
1080 2016-11-15  Alexey Proskuryakov  <ap@apple.com>
1081
1082         Update Youenn's e-mail addresses.
1083
1084         * Scripts/webkitpy/common/config/contributors.json:
1085
1086 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
1087
1088         UIScriptController: script with no async tasks fails if an earlier script registered a callback
1089         https://bugs.webkit.org/show_bug.cgi?id=164762
1090
1091         Reviewed by Wenson Hsieh.
1092         
1093         UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't
1094         queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript()
1095         would consider that an outstanding task.
1096         
1097         Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called.
1098
1099         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1100         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1101
1102 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
1103
1104         UIScriptController: setting a callback to undefined should unregister it
1105         https://bugs.webkit.org/show_bug.cgi?id=164796
1106
1107         Reviewed by Dean Jackson.
1108         
1109         "Immediate" UI scripts (those that don't schedule any async tasks) should return
1110         immediately, without the need to call uiScriptComplete(). However, this is broken if
1111         an earlier UI script registered a callback (since no-one clears that callback after the
1112         first script completes).
1113
1114         Make possible the workaround of setting the callback to undefined, which previously did
1115         not clear the callback registration.
1116
1117         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1118         (UIScriptContext::registerCallback):
1119         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1120         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1121         (WTR::UIScriptController::platformClearAllCallbacks):
1122
1123 2016-11-14  Mark Lam  <mark.lam@apple.com>
1124
1125         Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations.
1126         https://bugs.webkit.org/show_bug.cgi?id=164695
1127
1128         Reviewed by Keith Miller.
1129
1130         This gives us more flexibility when specific tests needs to enable special JSC
1131         options in order to exercise specific code paths to be tested.  It also saves us
1132         from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.
1133         We can now just use runFTLNoCJIT in its place.
1134
1135         Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType
1136         so that we have the ability to skip certain tests for release or debug builds.
1137         This will be needed in the upcoming patch for https://webkit.org/b/155145.
1138
1139         * Scripts/run-jsc-stress-tests:
1140
1141 2016-11-14  Joanmarie Diggs  <jdiggs@igalia.com>
1142
1143         AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role
1144         https://bugs.webkit.org/show_bug.cgi?id=164712
1145
1146         Reviewed by Chris Fleizach.
1147
1148         Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine
1149         to DRT and WKTR. Implement it for ATK.
1150
1151         * DumpRenderTree/AccessibilityUIElement.h:
1152         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1153         (AccessibilityUIElement::isSingleLine):
1154         (AccessibilityUIElement::isMultiLine):
1155         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1156         (AccessibilityUIElement::isSingleLine):
1157         (AccessibilityUIElement::isMultiLine):
1158         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1159         (AccessibilityUIElement::isSingleLine):
1160         (AccessibilityUIElement::isMultiLine):
1161         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1162         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1163         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1164         (WTR::AccessibilityUIElement::isSingleLine):
1165         (WTR::AccessibilityUIElement::isMultiLine):
1166         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1167         (WTR::AccessibilityUIElement::isSingleLine):
1168         (WTR::AccessibilityUIElement::isMultiLine):
1169         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1170         (WTR::AccessibilityUIElement::isSingleLine):
1171         (WTR::AccessibilityUIElement::isMultiLine):
1172
1173 2016-11-14  Youenn Fablet  <youenn@apple.com>
1174
1175         Support WPT templated tests
1176         https://bugs.webkit.org/show_bug.cgi?id=164707
1177
1178         Reviewed by Sam Weinig.
1179
1180         * Scripts/webkitpy/w3c/test_importer.py:
1181         (TestImporter.write_html_files_for_templated_js_tests): Generating empty HTML files for templated JS tests.
1182         (TestImporter.import_tests):
1183
1184 2016-11-13  JF Bastien  <jfbastien@apple.com>
1185
1186         Implement WTF::Expected
1187         https://bugs.webkit.org/show_bug.cgi?id=164526
1188
1189         Reviewed by Yusuke Suzuki.
1190
1191         std::expected isn't in C++17, and may be in C++20. It's a nice
1192         complement to std::any / std::optional because it's a type-tagged
1193         union which has a single expected result but could also contain an
1194         error.
1195
1196         This would be useful in the WebAssembly parser, for example.
1197
1198         Using this implementation will allow us to provide feedback to the
1199         standards committee and guide std::expected's design before it
1200         gets standardized. I've already sent a bunch of feedback to the
1201         author based on my experience implementing this.
1202
1203         This could supplement WTF::Either and WTF::ExceptionOr.
1204
1205         * TestWebKitAPI/CMakeLists.txt:
1206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1207         * TestWebKitAPI/Tests/WTF/Expected.cpp: Added.
1208         (WTF::operator<<):
1209         (TestWebKitAPI::TEST):
1210         (TestWebKitAPI::foo::foo):
1211         (TestWebKitAPI::foo::~foo):
1212         (TestWebKitAPI::foo::operator==):
1213         (TestWebKitAPI::operator<<):
1214
1215 2016-11-12  Simon Fraser  <simon.fraser@apple.com>
1216
1217         Add a way to get the UI-side scrolling tree as text via UIScriptController
1218         https://bugs.webkit.org/show_bug.cgi?id=164697
1219
1220         Reviewed by Zalan Bujtas.
1221
1222         Add UIScriptController::scrollingTreeAsText(), which gets the state of the scrolling
1223         tree in the UI process, including the current positions of CALayers. This will be used
1224         to test UI-side scrolling and visual viewports.
1225
1226         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1227         (WTR::UIScriptController::scrollingTreeAsText):
1228         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1229         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1230         (WTR::UIScriptController::scrollingTreeAsText):
1231         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1232         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1233         (WTR::UIScriptController::scrollingTreeAsText):
1234
1235 2016-11-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1236
1237         The main content heuristic should be robust when handling large media elements
1238         https://bugs.webkit.org/show_bug.cgi?id=164676
1239         <rdar://problem/29211503>
1240
1241         Reviewed by Eric Carlson.
1242
1243         Added a new test verifying that enormous video elements are handled gracefully when put through the main
1244         content heuristic.
1245
1246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1247         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1248         (TestWebKitAPI::TEST):
1249         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Added.
1250
1251 2016-11-12  Dan Bernstein  <mitz@apple.com>
1252
1253         run-safari does not work for open source contributors
1254         https://bugs.webkit.org/show_bug.cgi?id=164667
1255         <rdar://problem/29229894>
1256
1257         Reviewed by Joseph Pecoraro.
1258
1259         * Scripts/run-api-tests:
1260         (archCommandLineArgumentsForRestrictedEnvironmentVariables): Moved from here…
1261         * Scripts/webkitdirs.pm:
1262         (archCommandLineArgumentsForRestrictedEnvironmentVariables): …to here
1263         (runMacWebKitApp): Have arch(1) carry the DYLD_* variables we set in our environmet over
1264           to the environment of the app being run.
1265
1266 2016-11-11  Joseph Pecoraro  <pecoraro@apple.com>
1267
1268         Removed unused INCLUDE_OPTIONS_FOR_DEBUGGING
1269         https://bugs.webkit.org/show_bug.cgi?id=164664
1270
1271         Reviewed by Dan Bernstein.
1272
1273         * Scripts/debug-minibrowser:
1274         * Scripts/debug-safari:
1275         * Scripts/debug-test-runner:
1276         * Scripts/webkitdirs.pm:
1277         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1278         There are no debug specific options anymore.
1279
1280 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1281
1282         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1283         https://bugs.webkit.org/show_bug.cgi?id=164538
1284         <rdar://problem/8418711>
1285
1286         Reviewed by Ryosuke Niwa.
1287
1288         Adds support for being able to test autocorrect and autocapitalize attributes in contenteditable areas. To do
1289         this, we add removeAllDynamicDictionaries to UIScriptController in order to ensure that autocorrect suggestions
1290         are reset to their defaults prior to running contenteditable-autocorrect-off.html.
1291
1292         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1293         (WTR::UIScriptController::removeAllDynamicDictionaries):
1294         * Scripts/webkitpy/port/ios.py:
1295         (IOSSimulatorPort._createSimulatorApp):
1296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1297         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1298         (WTR::UIScriptController::removeAllDynamicDictionaries):
1299         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1300         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1301         (-[TestRunnerWKWebView _keyboardDidShow:]):
1302         (-[TestRunnerWKWebView _keyboardDidHide:]):
1303
1304         Work around an issue where consecutive UIKeyboardDidShowNotification would cause keyboard appearance callbacks
1305         to be fired multiple times. This was causing a single key press to cause two characters to be typed. While this
1306         does not affect the correctness of existing tests, the new autocorrection test requires this workaround.
1307
1308         * WebKitTestRunner/ios/UIKitSPI.h:
1309         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1310         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1311         (WTR::UIScriptController::removeAllDynamicDictionaries):
1312
1313 2016-11-11  Alex Christensen  <achristensen@webkit.org>
1314
1315         Build all Mac API tests
1316         https://bugs.webkit.org/show_bug.cgi?id=164633
1317
1318         Reviewed by Gyuyoung Kim.
1319
1320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1321         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
1322
1323 2016-11-11  Alex Christensen  <achristensen@webkit.org>
1324
1325         Allow mutable lambdas in HashMap::ensure
1326         https://bugs.webkit.org/show_bug.cgi?id=164642
1327
1328         Reviewed by Sam Weinig.
1329
1330         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1331         (TestWebKitAPI::TEST):
1332
1333 2016-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1334
1335         Composition state should be cleared when changing focus to a non-editable element
1336         https://bugs.webkit.org/show_bug.cgi?id=164595
1337         <rdar://problem/26412551>
1338
1339         Reviewed by Enrica Casucci.
1340
1341         Adds support for window.textInputController in DumpRenderTree on iOS. So far, only the methods needed for the
1342         new layout test (editing/focus-change-with-marked-text.html) are supported. These are insertText, setMarkedText,
1343         and markedRange.
1344
1345         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1346         * DumpRenderTree/TextInputController.h: Renamed from Tools/DumpRenderTree/mac/TextInputController.h.
1347
1348         Remove the PLATFORM(MAC) guard for defining the TextInputController. Also, move the TextInputController header
1349         out of the /mac platform directory.
1350
1351         * DumpRenderTree/ios/TextInputControllerIOS.m: Added.
1352         (+[TextInputController isSelectorExcludedFromWebScript:]):
1353         (+[TextInputController webScriptNameForSelector:]):
1354         (-[TextInputController initWithWebView:]):
1355         (-[TextInputController markedRange]):
1356         (-[TextInputController insertText:]):
1357         (-[TextInputController setMarkedText:selectedFrom:length:]):
1358
1359         Introduces TextInputControllerIOS.m, which contains an iOS implementation of TextInputController. Only a subset
1360         of the methods available on the Mac version will be available on iOS for now (see above).
1361
1362         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1363
1364         Remove the PLATFORM(MAC) guard for initializing the TextInputController and binding it to the window object.
1365
1366         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1367         * DumpRenderTree/mac/TextInputControllerMac.m: Renamed from Tools/DumpRenderTree/mac/TextInputController.m.
1368         (-[WebHTMLView interpretKeyEvents:]):
1369         (-[WebNSRange initWithNSRange:]):
1370         (-[WebNSRange location]):
1371         (-[WebNSRange length]):
1372         (+[WebNSRange isSelectorExcludedFromWebScript:]):
1373         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
1374         (+[NSMutableAttributedString webScriptNameForSelector:]):
1375         (-[NSMutableAttributedString getLength]):
1376         (-[NSMutableAttributedString ranges]):
1377         (-[NSMutableAttributedString attributeNamesAtIndex:]):
1378         (-[NSMutableAttributedString valueOfAttribute:atIndex:]):
1379         (-[NSMutableAttributedString addAttribute:value:]):
1380         (-[NSMutableAttributedString addAttribute:value:from:length:]):
1381         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]):
1382         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]):
1383         (-[NSMutableAttributedString addFontAttribute:fontName:size:]):
1384         (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]):
1385         (+[TextInputController isSelectorExcludedFromWebScript:]):
1386         (+[TextInputController webScriptNameForSelector:]):
1387         (-[TextInputController initWithWebView:]):
1388         (-[TextInputController dealloc]):
1389         (-[TextInputController textInput]):
1390         (-[TextInputController insertText:]):
1391         (-[TextInputController doCommand:]):
1392         (-[TextInputController setMarkedText:selectedFrom:length:]):
1393         (-[TextInputController unmarkText]):
1394         (-[TextInputController hasMarkedText]):
1395         (-[TextInputController conversationIdentifier]):
1396         (-[TextInputController substringFrom:length:]):
1397         (-[TextInputController attributedSubstringFrom:length:]):
1398         (-[TextInputController legacyAttributedString:]):
1399         (-[TextInputController markedRange]):
1400         (-[TextInputController selectedRange]):
1401         (-[TextInputController firstRectForCharactersFrom:length:]):
1402         (-[TextInputController characterIndexForPointX:Y:]):
1403         (-[TextInputController validAttributesForMarkedText]):
1404         (-[TextInputController attributedStringWithString:]):
1405         (-[TextInputController stringWithUndoGroupingInsertion:]):
1406         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
1407         (-[TextInputController setInputMethodHandler:]):
1408         (-[TextInputController interpretKeyEvents:withSender:]):
1409
1410         Fixes miscellaneous style issues.
1411
1412 2016-11-11  Philippe Normand  <pnormand@igalia.com>
1413
1414         [GTK][JHbuild] bump libnice version in openwebrtc.modules
1415         https://bugs.webkit.org/show_bug.cgi?id=164586
1416
1417         Reviewed by Michael Catanzaro.
1418
1419         Update to a recent libnice git snapshot and remove patches already
1420         upstream or not applying anymore. The patches not upstream yet
1421         will be reported in Phabricator.
1422
1423         * gtk/openwebrtc.modules:
1424         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Removed.
1425         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Removed.
1426         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Removed.
1427         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Removed.
1428         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Removed.
1429
1430 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1431
1432         Fix assertion after r208534.
1433         https://bugs.webkit.org/show_bug.cgi?id=160497
1434
1435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1436         * TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
1437         (TestWebKitAPI::TEST):
1438         Add a regression test.
1439
1440 2016-11-10  Chris Dumez  <cdumez@apple.com>
1441
1442         REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
1443         https://bugs.webkit.org/show_bug.cgi?id=164570
1444
1445         Reviewed by Simon Fraser.
1446
1447         Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
1448         avoid flakiness.
1449
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::TestController::resetStateToConsistentValues):
1452
1453 2016-11-10  Miguel Gomez  <magomez@igalia.com>
1454
1455         Unreviewed. Added myself to the list of committers.
1456
1457         * Scripts/webkitpy/common/config/contributors.json:
1458
1459 2016-10-27  Sergio Villar Senin  <svillar@igalia.com>
1460
1461         [GTK] New API to notify about dynamically added forms
1462         https://bugs.webkit.org/show_bug.cgi?id=164050
1463
1464         Reviewed by Carlos Garcia Campos.
1465
1466         Added a new test case to verify that dinamically added forms correctly trigger the
1467         "form-controls-associated" signal from WebPage.
1468
1469         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1470         (didAssociateFormControlsCallback):
1471         (testWebExtensionFormControlsAssociated):
1472         (beforeAll):
1473         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1474         (DelayedSignal::DelayedSignal):
1475         (emitFormControlsAssociated):
1476         (formControlsAssociatedCallback):
1477         (pageCreatedCallback):
1478
1479 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1480
1481         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1482         https://bugs.webkit.org/show_bug.cgi?id=164501
1483         <rdar://problem/29152282>
1484
1485         Reviewed by Sam Weinig.
1486
1487         * DumpRenderTree/mac/TextInputController.m:
1488         (-[TextInputController legacyAttributedString:]):
1489
1490 2016-11-09  Chris Dumez  <cdumez@apple.com>
1491
1492         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
1493         https://bugs.webkit.org/show_bug.cgi?id=164458
1494         <rdar://problem/28905514>
1495
1496         Reviewed by Darin Adler.
1497
1498         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
1499         tests can request that such resources are downloaded instead of being ignored.
1500
1501         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1502         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1503         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1504         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1505         * WebKitTestRunner/TestController.cpp:
1506         (WTR::TestController::decidePolicyForNavigationResponse):
1507         * WebKitTestRunner/TestController.h:
1508         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
1509         * WebKitTestRunner/TestInvocation.cpp:
1510         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1511
1512 2016-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1513
1514         NetworkSession: Network process crash when converting main resource to download
1515         https://bugs.webkit.org/show_bug.cgi?id=164220
1516
1517         Reviewed by Alex Christensen.
1518
1519         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
1520         converted to a download and another one to test the cancellation as the test was doing before. When doing the
1521         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
1522         download.
1523
1524         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1525         (testPolicyResponseDownload):
1526         (testPolicyResponseDownloadCancel):
1527         (beforeAll):
1528
1529 2016-11-09  KwangHyuk Kim  <hyuki.kim@samsung.com>
1530
1531         [EFL] fix error message caused by eina log
1532         https://bugs.webkit.org/show_bug.cgi?id=164546
1533
1534         Reviewed by Gyuyoung Kim.
1535
1536         Fix error message caused by eina log when MiniBrowser is working with help option.
1537
1538         * MiniBrowser/efl/main.c:
1539         (quit):
1540
1541 2016-11-09  Brent Fulgham  <bfulgham@apple.com>
1542
1543         Unreviewed build fix after r208509.
1544
1545         * DumpRenderTree/win/TestRunnerWin.cpp:
1546         (TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Add missing TestRunner implementation."
1547
1548 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1549
1550         Unreviewed, rolling out r208438.
1551
1552         crashes
1553
1554         Reverted changeset:
1555
1556         "[WK2][NETWORK_SESSION] Add support for downloading file
1557         backed blobs"
1558         https://bugs.webkit.org/show_bug.cgi?id=164458
1559         http://trac.webkit.org/changeset/208438
1560
1561 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1562
1563         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1564         https://bugs.webkit.org/show_bug.cgi?id=155185
1565         <rdar://problem/11101440>
1566
1567         Reviewed by Brady Eidson.
1568
1569         * DumpRenderTree/TestRunner.cpp:
1570         (setNeedsLocalStorageQuirkCallback): Added.
1571         (TestRunner::staticFunctions):
1572         * DumpRenderTree/TestRunner.h:
1573         * DumpRenderTree/mac/DumpRenderTree.mm:
1574         (resetWebPreferencesToConsistentValues): Update for new quirk setting.
1575         * DumpRenderTree/mac/TestRunnerMac.mm:
1576         (TestRunner::setNeedsLocalStorageQuirk):
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
1579         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1580         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm:
1581         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Added.
1582         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Added.
1583         (-[LocalStorageQuirkMessageHandler userContentController:didReceiveScriptMessage:]):
1584         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1585         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1586         (WTR::InjectedBundle::beginTesting): Update for new quirk setting.
1587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1588         (WTR::TestRunner::setNeedsLocalStorageQuirk): Added.
1589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1590
1591 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1592
1593         URLParser should not consider path of URLs with no host to start at the first slash after the colon
1594         https://bugs.webkit.org/show_bug.cgi?id=164555
1595
1596         Reviewed by Tim Horton.
1597
1598         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1599         (TestWebKitAPI::TEST_F):
1600
1601 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
1602
1603         test-webkitpy failing test_create_patch_is_full_patch unit test
1604         https://bugs.webkit.org/show_bug.cgi?id=164385
1605
1606         Reviewed by Darin Adler.
1607
1608         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
1609
1610 2016-11-09  Chris Dumez  <cdumez@apple.com>
1611
1612         [Mac] Stop using deprecated AppKit enumeration values
1613         https://bugs.webkit.org/show_bug.cgi?id=164494
1614
1615         Reviewed by Darin Adler.
1616
1617         Stop using deprecated AppKit enumeration values.
1618
1619         * DumpRenderTree/mac/EventSendingController.mm:
1620         (eventTypeForMouseButtonAndAction):
1621         (modifierFlags):
1622         (-[EventSendingController mouseMoveToX:Y:]):
1623         (-[EventSendingController contextClick]):
1624         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1625         * DumpRenderTree/mac/TextInputController.m:
1626         (-[TextInputController interpretKeyEvents:withSender:]):
1627         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
1628         (simulateCommandArrow):
1629         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1630         (TestWebKitAPI::TEST):
1631         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
1632         (TestWebKitAPI::TEST):
1633         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1634         (TestWebKitAPI::TEST):
1635         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1636         (TEST):
1637         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
1638         (UserInitiatedActionTest::SetUp):
1639         (UserInitiatedActionTest::click):
1640         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1641         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1642         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1643         (TestWebKitAPI::contextMenuCopyLink):
1644         (TestWebKitAPI::TEST):
1645         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
1646         (TestWebKitAPI::TEST):
1647         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1648         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1649         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1650         (TestWebKitAPI::TEST):
1651         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1652         (TestWebKitAPI::Util::isKeyDown):
1653         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1654         (TestWebKitAPI::PlatformWebView::initialize):
1655         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
1656         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1657         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1658         (TestWebKitAPI::eventTypeForButton):
1659         (TestWebKitAPI::modifierFlagsForWKModifiers):
1660         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1661         (__simulated_forceClickAssociatedEventsMask):
1662         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1663         (-[TestWKWebView _setUpTestWindow:]):
1664         (-[TestWKWebView typeCharacter:]):
1665         * WebKitTestRunner/mac/EventSenderProxy.mm:
1666         (WTR::eventTypeForMouseButtonAndAction):
1667         (WTR::buildModifierFlags):
1668         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
1669         (WTR::EventSenderProxy::mouseForceClick):
1670         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1671         (WTR::EventSenderProxy::mouseMoveTo):
1672         (WTR::EventSenderProxy::keyDown):
1673         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1674         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1675         (WTR::PlatformWebView::PlatformWebView):
1676         * WebKitTestRunner/mac/TestControllerMac.mm:
1677         (WTR::TestController::platformResetStateToConsistentValues):
1678
1679 2016-11-09  Beth Dakin  <bdakin@apple.com>
1680
1681         Support TouchBar in WebKit
1682         https://bugs.webkit.org/show_bug.cgi?id=164437
1683         -and corresponding-
1684         rdar://problem/28876524
1685
1686         Reviewed by Darin Adler.
1687
1688         This makes MiniBrowser support TouchBar customization. 
1689
1690         * MiniBrowser/mac/AppDelegate.m:
1691         (-[BrowserAppDelegate awakeFromNib]):
1692
1693 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1694
1695         [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
1696         https://bugs.webkit.org/show_bug.cgi?id=164461
1697
1698         Reviewed by Michael Catanzaro.
1699
1700         As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
1701
1702         * efl/install-dependencies: Add libgcript package dependecy.
1703
1704 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1705
1706         [EFL] Remove unused function in MiniBrowser
1707         https://bugs.webkit.org/show_bug.cgi?id=164398
1708
1709         Reviewed by Darin Adler.
1710
1711         * MiniBrowser/efl/main.c:
1712         (window_find_with_elm_window): Deleted because it is not used anywhere.
1713
1714 2016-11-09  Chris Dumez  <cdumez@apple.com>
1715
1716         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
1717         https://bugs.webkit.org/show_bug.cgi?id=164458
1718         <rdar://problem/28905514>
1719
1720         Reviewed by Darin Adler.
1721
1722         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
1723         tests can request that such resources are downloaded instead of being ignored.
1724
1725         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1726         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1727         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::decidePolicyForNavigationResponse):
1731         * WebKitTestRunner/TestController.h:
1732         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
1733         * WebKitTestRunner/TestInvocation.cpp:
1734         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1735
1736 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
1737
1738         Make rpaths more robust for iOS Simulators
1739         https://bugs.webkit.org/show_bug.cgi?id=164521
1740
1741         Reviewed by Simon Fraser.
1742
1743         * Scripts/webkitpy/port/ios.py:
1744         (IOSSimulatorPort._createSimulatorApp): Added more robust path.
1745
1746 2016-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1747
1748         Fix Tools build on case sensitive file systems
1749         https://bugs.webkit.org/show_bug.cgi?id=164474
1750
1751         Unreviewed buildfix.
1752
1753         * DumpRenderTree/CMakeLists.txt:
1754         * DumpRenderTree/PlatformMac.cmake:
1755         * DumpRenderTree/PlatformWin.cmake:
1756         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1757         * MiniBrowser/mac/CMakeLists.txt:
1758
1759 2016-11-04  Filip Pizlo  <fpizlo@apple.com>
1760
1761         WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
1762         https://bugs.webkit.org/show_bug.cgi?id=152045
1763
1764         Reviewed by Andy Estes.
1765
1766         * TestWebKitAPI/CMakeLists.txt:
1767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1768         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
1771         (TestWebKitAPI::ToUpperConverter::stopProducing):
1772         (TestWebKitAPI::ToUpperConverter::stopConsuming):
1773         * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
1774         (WTF::operator<<):
1775         (TestWebKitAPI::TEST):
1776
1777 2016-11-04  Alex Christensen  <achristensen@webkit.org>
1778
1779         Unreviewed, rolling out r208293.
1780
1781         asserts in API tests.
1782
1783         Reverted changeset:
1784
1785         "NetworkSession: Network process crash when converting main
1786         resource to download"
1787         https://bugs.webkit.org/show_bug.cgi?id=164220
1788         http://trac.webkit.org/changeset/208293
1789
1790 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1791
1792         Add a setting and preferences to enable/disable async image decoding
1793         https://bugs.webkit.org/show_bug.cgi?id=164417
1794
1795         Reviewed by Simon Fraser.
1796
1797         Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
1798
1799         * MiniBrowser/mac/SettingsController.h:
1800         * MiniBrowser/mac/SettingsController.m:
1801         (-[SettingsController _populateMenu]):
1802         (-[SettingsController validateMenuItem:]):
1803         (-[SettingsController toggleAsyncImageDecodingEnabled:]):
1804         (-[SettingsController asyncImageDecodingEnabled]):
1805         * MiniBrowser/mac/WK1BrowserWindowController.m:
1806         (-[WK1BrowserWindowController didChangeSettings]):
1807         * MiniBrowser/mac/WK2BrowserWindowController.m:
1808         (-[WK2BrowserWindowController didChangeSettings]):
1809
1810 2016-11-04  Brady Eidson  <beidson@apple.com>
1811
1812         REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
1813         https://bugs.webkit.org/show_bug.cgi?id=164390
1814
1815         Reviewed by Geoffrey Garen.
1816
1817         Operating under the assumption that the behavior change is okay/desirable, this updates the test.
1818
1819         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1820         (TestWebKitAPI::TEST):
1821
1822 2016-11-04  Joanmarie Diggs  <jdiggs@igalia.com>
1823
1824         AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
1825         https://bugs.webkit.org/show_bug.cgi?id=164331
1826
1827         Reviewed by Chris Fleizach.
1828
1829         Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
1830         Implement it for ATK.
1831
1832         * DumpRenderTree/AccessibilityUIElement.h:
1833         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1834         (AccessibilityUIElement::clearSelectedChildren):
1835         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1836         (AccessibilityUIElement::clearSelectedChildren):
1837         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1838         (AccessibilityUIElement::clearSelectedChildren):
1839         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1840         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1841         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1842         (WTR::AccessibilityUIElement::clearSelectedChildren):
1843         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1844         (WTR::AccessibilityUIElement::clearSelectedChildren):
1845         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1846         (WTR::AccessibilityUIElement::clearSelectedChildren):
1847
1848 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
1849
1850         [Win] Page visibility tests are timing out.
1851         https://bugs.webkit.org/show_bug.cgi?id=164363
1852
1853         Reviewed by Brent Fulgham.
1854
1855         Implement methods to set page visibility.
1856
1857         * DumpRenderTree/win/TestRunnerWin.cpp:
1858         (TestRunner::resetPageVisibility):
1859         (TestRunner::setPageVisibility):
1860
1861 2016-11-03  Simon Fraser  <simon.fraser@apple.com>
1862
1863         Give all the geometry classes a single-argument scale() function for consistency
1864         https://bugs.webkit.org/show_bug.cgi?id=164400
1865
1866         Reviewed by Zalan Bujtas.
1867         
1868         Test single-argument scale().
1869
1870         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
1871         (TestWebKitAPI::TEST):
1872
1873 2016-11-03  Chris Dumez  <cdumez@apple.com>
1874
1875         [WK2][Cocoa] Implement user interface for HTML form validation
1876         https://bugs.webkit.org/show_bug.cgi?id=164143
1877         <rdar://problem/28944652>
1878
1879         Reviewed by Simon Fraser.
1880
1881         Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
1882         on both Mac and iOS to retrieve the currently displayed validation message.
1883
1884         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1885         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1886         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1887         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1888         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1889         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1890         (WTR::UIScriptController::contentsOfUserInterfaceItem):
1891
1892 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
1893
1894         Fixes to build JSCOnly on macOS
1895         https://bugs.webkit.org/show_bug.cgi?id=164379
1896
1897         Reviewed by Michael Catanzaro.
1898
1899         * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
1900         definition to OptionsJSCOnly.cmake
1901
1902 2016-11-03  Dan Bernstein  <mitz@apple.com>
1903
1904         WKWebView’s _observedRenderingProgressEvents not restored after web process crash
1905         https://bugs.webkit.org/show_bug.cgi?id=164368
1906         <rdar://problem/29091954>
1907
1908         Reviewed by Anders Carlsson.
1909
1910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1911         * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
1912         (TEST):
1913
1914 2016-11-03  Alex Christensen  <achristensen@webkit.org>
1915
1916         Purge PassRefPtr from Tools
1917         https://bugs.webkit.org/show_bug.cgi?id=164358
1918
1919         Reviewed by Michael Catanzaro.
1920
1921         * ImageDiff/efl/ImageDiff.cpp:
1922         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1923         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1924         (WTR::AccessibilityController::create):
1925         (WTR::AccessibilityController::rootElement):
1926         (WTR::AccessibilityController::focusedElement):
1927         (WTR::AccessibilityController::elementAtPoint):
1928         (WTR::AccessibilityController::addNotificationListener): Deleted.
1929         (WTR::AccessibilityController::removeNotificationListener): Deleted.
1930         (WTR::AccessibilityController::accessibleElementById): Deleted.
1931         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
1932         (WTR::AccessibilityController::resetToConsistentState): Deleted.
1933         (WTR::AccessibilityController::platformName): Deleted.
1934         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1935         (WTR::AccessibilityController::logAccessibilityEvents):
1936         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1937         (WTR::AccessibilityTextMarker::create):
1938         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
1939         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1940         (WTR::AccessibilityTextMarkerRange::create):
1941         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
1942         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1943         (WTR::AccessibilityUIElement::create):
1944         (WTR::AccessibilityUIElement::linkedElement):
1945         (WTR::AccessibilityUIElement::headerElementAtIndex):
1946         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1947         (WTR::AccessibilityUIElement::characterAtOffset):
1948         (WTR::AccessibilityUIElement::wordAtOffset):
1949         (WTR::AccessibilityUIElement::lineAtOffset):
1950         (WTR::AccessibilityUIElement::sentenceAtOffset):
1951         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1952         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1953         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1954         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1955         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1956         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1957         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1958         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1959         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1960         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1961         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1962         (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
1963         (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
1964         (WTR::AccessibilityUIElement::isEqual): Deleted.
1965         (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
1966         (WTR::AccessibilityUIElement::childAtIndex): Deleted.
1967         (WTR::AccessibilityUIElement::indexOfChild): Deleted.
1968         (WTR::AccessibilityUIElement::childrenCount): Deleted.
1969         (WTR::AccessibilityUIElement::titleUIElement): Deleted.
1970         (WTR::AccessibilityUIElement::parentElement): Deleted.
1971         (WTR::AccessibilityUIElement::takeFocus): Deleted.
1972         (WTR::AccessibilityUIElement::takeSelection): Deleted.
1973         (WTR::AccessibilityUIElement::addSelection): Deleted.
1974         (WTR::AccessibilityUIElement::removeSelection): Deleted.
1975         (WTR::AccessibilityUIElement::allAttributes): Deleted.
1976         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
1977         (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
1978         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
1979         (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
1980         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
1981         (WTR::AccessibilityUIElement::increment): Deleted.
1982         (WTR::AccessibilityUIElement::decrement): Deleted.
1983         (WTR::AccessibilityUIElement::showMenu): Deleted.
1984         (WTR::AccessibilityUIElement::press): Deleted.
1985         (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
1986         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
1987         (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
1988         (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
1989         (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
1990         (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
1991         (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
1992         (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
1993         (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
1994         (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
1995         (WTR::AccessibilityUIElement::role): Deleted.
1996         (WTR::AccessibilityUIElement::subrole): Deleted.
1997         (WTR::AccessibilityUIElement::roleDescription): Deleted.
1998         (WTR::AccessibilityUIElement::computedRoleString): Deleted.
1999         (WTR::AccessibilityUIElement::title): Deleted.
2000         (WTR::AccessibilityUIElement::description): Deleted.
2001         (WTR::AccessibilityUIElement::language): Deleted.
2002         (WTR::AccessibilityUIElement::stringValue): Deleted.
2003         (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
2004         (WTR::AccessibilityUIElement::helpText): Deleted.
2005         (WTR::AccessibilityUIElement::orientation): Deleted.
2006         (WTR::AccessibilityUIElement::x): Deleted.
2007         (WTR::AccessibilityUIElement::y): Deleted.
2008         (WTR::AccessibilityUIElement::width): Deleted.
2009         (WTR::AccessibilityUIElement::height): Deleted.
2010         (WTR::AccessibilityUIElement::intValue): Deleted.
2011         (WTR::AccessibilityUIElement::minValue): Deleted.
2012         (WTR::AccessibilityUIElement::maxValue): Deleted.
2013         (WTR::AccessibilityUIElement::valueDescription): Deleted.
2014         (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
2015         (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
2016         (WTR::AccessibilityUIElement::isEnabled): Deleted.
2017         (WTR::AccessibilityUIElement::isRequired): Deleted.
2018         (WTR::AccessibilityUIElement::isFocused): Deleted.
2019         (WTR::AccessibilityUIElement::isFocusable): Deleted.
2020         (WTR::AccessibilityUIElement::isSelected): Deleted.
2021         (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
2022         (WTR::AccessibilityUIElement::isSelectable): Deleted.
2023         (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
2024         (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
2025         (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
2026         (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
2027         (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
2028         (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
2029         (WTR::AccessibilityUIElement::isExpanded): Deleted.
2030         (WTR::AccessibilityUIElement::isChecked): Deleted.
2031         (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
2032         (WTR::AccessibilityUIElement::isVisible): Deleted.
2033         (WTR::AccessibilityUIElement::isOffScreen): Deleted.
2034         (WTR::AccessibilityUIElement::isCollapsed): Deleted.
2035         (WTR::AccessibilityUIElement::isIgnored): Deleted.
2036         (WTR::AccessibilityUIElement::hasPopup): Deleted.
2037         (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
2038         (WTR::AccessibilityUIElement::clickPointX): Deleted.
2039         (WTR::AccessibilityUIElement::clickPointY): Deleted.
2040         (WTR::AccessibilityUIElement::documentEncoding): Deleted.
2041         (WTR::AccessibilityUIElement::documentURI): Deleted.
2042         (WTR::AccessibilityUIElement::url): Deleted.
2043         (WTR::AccessibilityUIElement::speak): Deleted.
2044         (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
2045         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
2046         (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
2047         (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
2048         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
2049         (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
2050         (WTR::AccessibilityUIElement::indexInTable): Deleted.
2051         (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
2052         (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
2053         (WTR::AccessibilityUIElement::rowCount): Deleted.
2054         (WTR::AccessibilityUIElement::columnCount): Deleted.
2055         (WTR::AccessibilityUIElement::rowHeaders): Deleted.
2056         (WTR::AccessibilityUIElement::columnHeaders): Deleted.
2057         (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
2058         (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
2059         (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
2060         (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
2061         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
2062         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
2063         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
2064         (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
2065         (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
2066         (WTR::AccessibilityUIElement::classList): Deleted.
2067         (WTR::AccessibilityUIElement::lineForIndex): Deleted.
2068         (WTR::AccessibilityUIElement::rangeForLine): Deleted.
2069         (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
2070         (WTR::AccessibilityUIElement::boundsForRange): Deleted.
2071         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
2072         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
2073         (WTR::AccessibilityUIElement::stringForRange): Deleted.
2074         (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
2075         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
2076         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
2077         (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
2078         (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
2079         (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
2080         (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
2081         (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
2082         (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
2083         (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
2084         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
2085         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
2086         (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
2087         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
2088         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
2089         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
2090         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
2091         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
2092         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
2093         (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
2094         (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
2095         (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
2096         (WTR::AccessibilityUIElement::startTextMarker): Deleted.
2097         (WTR::AccessibilityUIElement::endTextMarker): Deleted.
2098         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
2099         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
2100         (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
2101         (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
2102         (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
2103         (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
2104         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
2105         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
2106         (WTR::AccessibilityUIElement::supportedActions): Deleted.
2107         (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
2108         (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
2109         (WTR::AccessibilityUIElement::pathDescription): Deleted.
2110         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2111         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2112         (WTR::EventSendingController::create):
2113         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2114         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2115         (WTR::GCController::create):
2116         * WebKitTestRunner/InjectedBundle/GCController.h:
2117         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2118         (WTR::InjectedBundle::beginTesting):
2119         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2120         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2121         (WTR::TestRunner::create):
2122         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2123         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2124         (WTR::TextInputController::create):
2125         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2126         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2127         (WTR::AccessibilityController::accessibleElementById):
2128         (WTR::AccessibilityController::rootElement):
2129         (WTR::AccessibilityController::focusedElement):
2130         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2131         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
2132         (WTR::AccessibilityNotificationHandler::create):
2133         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2134         (WTR::AccessibilityUIElement::elementAtPoint):
2135         (WTR::AccessibilityUIElement::childAtIndex):
2136         (WTR::accessibilityElementAtIndex):
2137         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2138         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2139         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2140         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2141         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2142         (WTR::AccessibilityUIElement::rowAtIndex):
2143         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2144         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2145         (WTR::AccessibilityUIElement::titleUIElement):
2146         (WTR::AccessibilityUIElement::parentElement):
2147         (WTR::AccessibilityUIElement::disclosedByRow):
2148         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2149         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2150         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2151         (WTR::AccessibilityUIElement::horizontalScrollbar):
2152         (WTR::AccessibilityUIElement::verticalScrollbar):
2153         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2154         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2155         (WTR::AccessibilityUIElement::previousTextMarker):
2156         (WTR::AccessibilityUIElement::nextTextMarker):
2157         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2158         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2159         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2160         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2161         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2162         (WTR::AccessibilityUIElement::textMarkerForPoint):
2163         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2164         (WTR::AccessibilityUIElement::textMarkerForIndex):
2165         (WTR::AccessibilityUIElement::startTextMarker):
2166         (WTR::AccessibilityUIElement::endTextMarker):
2167         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2168         (WTR::AccessibilityController::accessibleElementById):
2169         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2170         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2171         (WTR::AccessibilityUIElement::headerElementAtIndex):
2172         (WTR::AccessibilityUIElement::linkedElement):
2173         (WTR::AccessibilityUIElement::elementAtPoint):
2174         (WTR::AccessibilityUIElement::childAtIndex):
2175         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2176         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2177         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2178         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2179         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2180         (WTR::AccessibilityUIElement::rowAtIndex):
2181         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2182         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2183         (WTR::AccessibilityUIElement::titleUIElement):
2184         (WTR::AccessibilityUIElement::parentElement):
2185         (WTR::AccessibilityUIElement::disclosedByRow):
2186         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2187         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2188         (WTR::AccessibilityUIElement::rangeForLine):
2189         (WTR::AccessibilityUIElement::rangeForPosition):
2190         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2191         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2192         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2193         (WTR::AccessibilityUIElement::horizontalScrollbar):
2194         (WTR::AccessibilityUIElement::verticalScrollbar):
2195         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2196         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2197         (WTR::AccessibilityUIElement::previousTextMarker):
2198         (WTR::AccessibilityUIElement::nextTextMarker):
2199         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2200         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2201         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2202         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2203         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2204         (WTR::AccessibilityUIElement::textMarkerForPoint):
2205         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2206         (WTR::AccessibilityUIElement::textMarkerForIndex):
2207         (WTR::AccessibilityUIElement::startTextMarker):
2208         (WTR::AccessibilityUIElement::endTextMarker):
2209         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2210         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2211         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2212         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2213         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2214         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2215         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2216         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2217         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2218         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2219         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2220         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2221         (WTR::AccessibilityUIElement::supportedActions):
2222         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2223         (WTR::AccessibilityController::accessibleElementById):
2224         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2225         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2226         (makeValueRefForValue):
2227         (-[AccessibilityNotificationHandler _notificationReceived:]):
2228         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2229         (WTR::AccessibilityUIElement::elementAtPoint):
2230         (WTR::AccessibilityUIElement::childAtIndex):
2231         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2232         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2233         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2234         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2235         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2236         (WTR::AccessibilityUIElement::rowAtIndex):
2237         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2238         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2239         (WTR::AccessibilityUIElement::titleUIElement):
2240         (WTR::AccessibilityUIElement::parentElement):
2241         (WTR::AccessibilityUIElement::disclosedByRow):
2242         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2243         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2244         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2245         (WTR::AccessibilityUIElement::horizontalScrollbar):
2246         (WTR::AccessibilityUIElement::verticalScrollbar):
2247         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2248         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2249         (WTR::AccessibilityUIElement::previousTextMarker):
2250         (WTR::AccessibilityUIElement::nextTextMarker):
2251         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2252         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2253         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2254         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2255         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2256         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2257         (WTR::AccessibilityUIElement::textMarkerForPoint):
2258         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2259         (WTR::AccessibilityUIElement::textMarkerForIndex):
2260         (WTR::AccessibilityUIElement::startTextMarker):
2261         (WTR::AccessibilityUIElement::endTextMarker):
2262         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2263         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2264         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2265         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2266         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2267         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2268         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2269         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2270         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2271         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2272         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2273         (WTR::keyPadName):
2274         (WTR::keyName):
2275
2276 2016-11-02  Alex Christensen  <achristensen@webkit.org>
2277
2278         Remove Battery Status API from the tree
2279         https://bugs.webkit.org/show_bug.cgi?id=164213
2280
2281         Reviewed by Sam Weinig.
2282
2283         * Scripts/webkitperl/FeatureList.pm:
2284         * Scripts/webkitpy/common/config/watchlist:
2285
2286 2016-11-02  Olivier Blin  <olivier.blin@softathome.com>
2287
2288         [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
2289         https://bugs.webkit.org/show_bug.cgi?id=163125
2290
2291         Reviewed by Michael Catanzaro.
2292
2293         * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only.
2294         gnutls is useful for glib-networking in jhbuild.
2295
2296 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2297
2298         NetworkSession: Network process crash when converting main resource to download
2299         https://bugs.webkit.org/show_bug.cgi?id=164220
2300
2301         Reviewed by Alex Christensen.
2302
2303         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
2304         converted to a download and another one to test the cancellation as the test was doing before. When doing the
2305         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
2306         download.
2307
2308         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2309         (testPolicyResponseDownload):
2310         (testPolicyResponseDownloadCancel):
2311         (beforeAll):
2312
2313 2016-11-01  Alex Christensen  <achristensen@webkit.org>
2314
2315         Remove PassRefPtr from DumpRenderTree
2316         https://bugs.webkit.org/show_bug.cgi?id=164307
2317
2318         Reviewed by Sam Weinig.
2319
2320         * DumpRenderTree/PixelDumpSupport.h:
2321         * DumpRenderTree/TestRunner.cpp:
2322         (TestRunner::create):
2323         * DumpRenderTree/TestRunner.h:
2324         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2325         (createBitmapContext):
2326         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2327         (BitmapContext::createByAdoptingBitmapAndContext):
2328         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2329         (createBitmapContextFromWebView):
2330         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2331         (createBitmapContextFromWebView):
2332         (createPagedBitmapContext):
2333         * DumpRenderTree/mac/TestRunnerMac.mm:
2334         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2335         (createBitmapContextFromWebView):
2336         * DumpRenderTree/win/TextInputController.h:
2337
2338 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2339
2340         [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
2341         https://bugs.webkit.org/show_bug.cgi?id=161481
2342
2343         Reviewed by Michael Catanzaro.
2344
2345         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
2346         (WebKitTestBus::WebKitTestBus):
2347         (WebKitTestBus::~WebKitTestBus):
2348         (WebKitTestBus::run):
2349         (WebKitTestBus::getOrCreateConnection):
2350         (WebKitTestBus::createProxy):
2351         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
2352
2353 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2354
2355         Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273.
2356
2357         The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots.
2358
2359         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2360         (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path.
2361
2362 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2363
2364         [Readable Streams API] Enable creation of ReadableByteStreamController
2365         https://bugs.webkit.org/show_bug.cgi?id=164014
2366
2367         Reviewed by Youenn Fablet.
2368
2369         Enable the byte stream part of Readable Streams API by default.
2370
2371         * Scripts/webkitperl/FeatureList.pm:
2372         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2373
2374 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
2375
2376         Remove CUSTOM_ELEMENTS build flag
2377         https://bugs.webkit.org/show_bug.cgi?id=164267
2378
2379         Reviewed by Antti Koivisto.
2380
2381         Removed the build flag.
2382
2383         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2384
2385 2016-11-01  Alex Christensen  <achristensen@webkit.org>
2386
2387         Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
2388         https://bugs.webkit.org/show_bug.cgi?id=164290
2389
2390         Reviewed by Tim Horton.
2391
2392         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2393         (TestWebKitAPI::checkRelativeURL):
2394         (TestWebKitAPI::checkURLDifferences):
2395         (TestWebKitAPI::checkRelativeURLDifferences):
2396         Move helper functions to the top so I can use them from any tests.
2397         (TestWebKitAPI::shouldFail):
2398         (TestWebKitAPI::checkURL):
2399         (TestWebKitAPI::TEST_F):
2400
2401 2016-11-01  Hyowon Kim  <hw1008.kim@samsung.com>
2402
2403         [GTK] Failed to generate GeoClue2Interface files.
2404         https://bugs.webkit.org/show_bug.cgi?id=164270
2405
2406         Reviewed by Michael Catanzaro.
2407
2408         To generate codes for D-Bus interfaces,
2409         geoclue-2.0 package including D-Bus introspection XML files should be installed.
2410
2411         * gtk/install-dependencies: add geoclue-2.0 package.
2412
2413 2016-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
2414
2415         [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
2416         https://bugs.webkit.org/show_bug.cgi?id=163868
2417
2418         Reviewed by Michael Catanzaro.
2419
2420         It takes long time for generate-bindings-all.pl to generate all
2421         bindings.  So, it shows the progress while running and
2422         USES_TERMINAL option of add_custom_target have been used to invoke
2423         the command.  However, USES_TERMINAL leaves a noisy line in
2424         Ninja's neat build log of interactive build.
2425
2426         A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
2427         stop using USES_TERMINAL only in case of interactive Ninja build.
2428
2429         * Scripts/webkitdirs.pm:
2430         (generateBuildSystemFromCMakeProject): Enable
2431         SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive
2432         Ninja build.
2433
2434 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
2435
2436         Add basic visual/layout viewport support for fixed position layout
2437         https://bugs.webkit.org/show_bug.cgi?id=164261
2438
2439         Reviewed by Dean Jackson.
2440
2441         Don't give tests in the "visual-viewport" directory a flexible viewport.
2442
2443         * DumpRenderTree/mac/DumpRenderTree.mm:
2444         (shouldMakeViewportFlexible):
2445         * WebKitTestRunner/TestOptions.cpp:
2446         (WTR::shouldMakeViewportFlexible):
2447
2448 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
2449
2450         JSC should support SharedArrayBuffer
2451         https://bugs.webkit.org/show_bug.cgi?id=163986
2452
2453         Reviewed by Keith Miller.
2454         
2455         Use the right kind of typed array API.
2456
2457         * DumpRenderTree/TestRunner.cpp:
2458         (setAudioResultCallback):
2459
2460 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
2461
2462         Make UIScriptController::zoomToScale() work on Mac WK1 and WK2
2463         https://bugs.webkit.org/show_bug.cgi?id=164238
2464
2465         Reviewed by Dean Jackson.
2466
2467         Implement UIScriptController::zoomToScale() for WTR and DRT on Mac.
2468
2469         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2470         (WTR::UIScriptController::zoomToScale):
2471         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2472         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2473         (WTR::UIScriptController::zoomToScale):
2474
2475 2016-10-31  Dewei Zhu  <dewei_zhu@apple.com>
2476
2477         Update twisted version in webkitpy.thirdparty.autoinstalled module.
2478         https://bugs.webkit.org/show_bug.cgi?id=154667
2479
2480         Reviewed by Ryosuke Niwa.
2481
2482         Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test.
2483         Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script.
2484         Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script.
2485
2486         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2487         * Scripts/webkitpy/thirdparty/__init__.py:
2488         (AutoinstallImportHook.find_module):
2489         (AutoinstallImportHook._install_twisted_15_5_0):
2490         (AutoinstallImportHook._install_twisted): Deleted.
2491
2492 2016-10-31  Ryosuke Niwa  <rniwa@webkit.org>
2493
2494         Enable custom elements by default everywhere
2495         https://bugs.webkit.org/show_bug.cgi?id=164242
2496
2497         Reviewed by Antti Koivisto.
2498
2499         Enable custom elements API on every port by default.
2500
2501         * Scripts/webkitperl/FeatureList.pm:
2502
2503 2016-10-31  Nan Wang  <n_wang@apple.com>
2504
2505         AX: aria-sort is not exposed on iOS
2506         https://bugs.webkit.org/show_bug.cgi?id=164245
2507
2508         Reviewed by Chris Fleizach.
2509
2510         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2511         (AccessibilityUIElement::stringAttributeValue):
2512         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2513         (WTR::AccessibilityUIElement::stringAttributeValue):
2514
2515 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
2516
2517         Implement IntersectionObserver
2518         https://bugs.webkit.org/show_bug.cgi?id=159475
2519
2520         Reviewed by Ryosuke Niwa.
2521         
2522         Add ENABLE_INTERSECTION_OBSERVER, enabled by default.
2523
2524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2525
2526 2016-10-31  Ryan Haddad  <ryanhaddad@apple.com>
2527
2528         Unreviewed, rolling out r208154.
2529
2530         This change caused an assertion failure during API tests on
2531         macOS.
2532
2533         Reverted changeset:
2534
2535         "NetworkSession: Network process crash when converting main
2536         resource to download"
2537         https://bugs.webkit.org/show_bug.cgi?id=164220
2538         http://trac.webkit.org/changeset/208154
2539
2540 2016-10-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
2541
2542         Unreviewed, change my status to be a WebKit reviewer
2543
2544         * Scripts/webkitpy/common/config/contributors.json:
2545
2546 2016-10-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2547
2548         NetworkSession: Network process crash when converting main resource to download
2549         https://bugs.webkit.org/show_bug.cgi?id=164220
2550
2551         Reviewed by Alex Christensen.
2552
2553         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
2554         converted to a download and another one to test the cancellation as the test was doing before. When doing the
2555         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
2556         download.
2557
2558         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2559         (testPolicyResponseDownload):
2560         (testPolicyResponseDownloadCancel):
2561         (beforeAll):
2562
2563 2016-10-31  Keith Miller  <keith_miller@apple.com>
2564
2565         Unreviewed, fix watchlist regexp for wasm.
2566
2567         * Scripts/webkitpy/common/config/watchlist:
2568
2569 2016-10-31  Keith Miller  <keith_miller@apple.com>
2570
2571         autogenerated files from wasm.json should be in derived sources.
2572         https://bugs.webkit.org/show_bug.cgi?id=164152
2573
2574         Reviewed by Filip Pizlo.
2575
2576         Add message to make sure that people keep the wasm.jsons up to date.
2577
2578         * Scripts/webkitpy/common/config/watchlist:
2579
2580 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2581
2582         Holding down a key to choose an accented character should fire "insertReplacementText" input events
2583         https://bugs.webkit.org/show_bug.cgi?id=164209
2584         <rdar://problem/29019305>
2585
2586         Reviewed by Darin Adler.
2587
2588         Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g.
2589         'a') to bring up the menu containing accented version of the character, then selecting an accented character to
2590         insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string
2591         and an insertion range.
2592
2593         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2594         (WTR::UIScriptController::insertText):
2595         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2596
2597         Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in
2598         the UI process. The tests end when corresponding input events fired as a result of insertText have been received
2599         in the web process. Please see the new layout tests for more detail.
2600
2601         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2602         (WTR::UIScriptController::insertText):
2603         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2604         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2605         (WTR::nsStringFromJSString):
2606         (WTR::UIScriptController::insertText):
2607
2608 2016-10-30  Sam Weinig  <sam@webkit.org>
2609
2610         [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts
2611         https://bugs.webkit.org/show_bug.cgi?id=164208
2612
2613         Reviewed by Darin Adler.
2614
2615         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2616         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2617         Update for new struct types.
2618
2619 2016-10-29  Darin Adler  <darin@apple.com>
2620
2621         Fix failing ExtendedColor tests.
2622
2623         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:
2624         Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
2625         for the string equality comparisons. This required including WTFStringUtilities.h.
2626         Second, change expected results to match what the code is currently generating,
2627         so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
2628         tests and the code if these results are incorrect.
2629
2630 2016-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2631
2632         UIScriptControllerIOS.mm should not be soft-linking UIKit
2633         https://bugs.webkit.org/show_bug.cgi?id=164171
2634
2635         Reviewed by Darin Adler.
2636
2637         Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.
2638
2639         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2640         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2641
2642 2016-10-28  Darin Adler  <darin@apple.com>
2643
2644         Move all classes in the HTML directory from ExceptionCode to Exception
2645         https://bugs.webkit.org/show_bug.cgi?id=163876
2646
2647         Reviewed by Sam Weinig.
2648
2649         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:
2650         (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
2651         (TestWebKitAPI::TEST): Ditto.
2652
2653 2016-10-28  Devin Rousso  <dcrousso+webkit@gmail.com>
2654
2655         Unreviewed, changed Devin Rousso's email and nick.
2656
2657         * Scripts/webkitpy/common/config/contributors.json:
2658
2659 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2660
2661         Unreviewed, fix the iOS build after r208090.
2662
2663         Use soft-linking as needed in UIScriptControllerIOS.mm.
2664
2665         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2666         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2667
2668 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2669
2670         iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
2671         https://bugs.webkit.org/show_bug.cgi?id=164077
2672         <rdar://problem/28987810>
2673
2674         Reviewed by Simon Fraser.
2675
2676         Adds test support for inserting text candidates on iOS in the form of
2677         UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
2678         index (this needs to be a value between 0-2 on iOS) and fires the callback when done.
2679
2680         To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
2681         given interval) and then tap the center of the text prediction view at the given index.
2682
2683         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2684         (WTR::UIScriptController::selectTextCandidateAtIndex):
2685         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2686         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2687         (WTR::UIScriptController::selectTextCandidateAtIndex):
2688         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2689         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2690         * WebKitTestRunner/ios/UIKitSPI.h:
2691         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2692         (WTR::UIScriptController::selectTextCandidateAtIndex):
2693         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2694
2695 2016-10-28  Commit Queue  <commit-queue@webkit.org>
2696
2697         Unreviewed, rolling out r207700.
2698         https://bugs.webkit.org/show_bug.cgi?id=164168
2699
2700         We are ready after r208086 (Requested by alexchristensen on
2701         #webkit).
2702
2703         Reverted changeset:
2704
2705         "Unreviewed, rolling out r207582."
2706         https://bugs.webkit.org/show_bug.cgi?id=163819
2707         http://trac.webkit.org/changeset/207700
2708
2709 2016-10-28  Alex Christensen  <achristensen@webkit.org>
2710
2711         Partially revert 207805 after resolution in URL spec issue 87
2712         https://bugs.webkit.org/show_bug.cgi?id=164142
2713
2714         Reviewed by Andy Estes.
2715
2716         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2717         (TestWebKitAPI::TEST_F):
2718
2719 2016-10-28  Alex Christensen  <achristensen@webkit.org>
2720
2721         URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
2722         https://bugs.webkit.org/show_bug.cgi?id=164154
2723
2724         Reviewed by Andy Estes.
2725
2726         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2727         (TestWebKitAPI::TEST_F):
2728
2729 2016-10-28  Sam Weinig  <sam@webkit.org>
2730
2731         [WebIDL] Update parser and code generators to only access type information through the type property
2732         https://bugs.webkit.org/show_bug.cgi?id=164141
2733
2734         Reviewed by Anders Carlsson.
2735
2736         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2737         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2738         Update to always access type information through type accessors. Remove use of removed
2739         properties.
2740
2741 2016-10-28  Frederic Wang  <fwang@igalia.com>
2742
2743         [GTK] Upgrade HarfBuzz to version 1.3.3
2744         https://bugs.webkit.org/show_bug.cgi?id=162719
2745
2746         Reviewed by Michael Catanzaro.
2747
2748         * gtk/jhbuild.modules:
2749
2750 2016-10-27  Chris Dumez  <cdumez@apple.com>
2751
2752         Regression(r203601): Caused crashes in iBooks
2753         https://bugs.webkit.org/show_bug.cgi?id=164093
2754         <rdar://problem/28745634>
2755
2756         Reviewed by Darin Adler.
2757
2758         Add API test coverage.
2759
2760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2761         * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
2762         (-[DOMNodeTest webView:didFinishLoadForFrame:]):
2763         (TestWebKitAPI::TEST):
2764
2765 2016-10-27  Sam Weinig  <sam@webkit.org>
2766
2767         [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
2768         https://bugs.webkit.org/show_bug.cgi?id=164089
2769
2770         Reviewed by Alex Christensen.
2771
2772         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2773         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2774         Update for the removal of domSignature::type, and new signatures of helper predicates.
2775
2776 2016-10-27  Commit Queue  <commit-queue@webkit.org>
2777
2778         Unreviewed, rolling out r207992.
2779         https://bugs.webkit.org/show_bug.cgi?id=164070
2780
2781         triggered aclocal version conflict (Requested by mcatanzaro on
2782         #webkit).
2783
2784         Reverted changeset:
2785
2786         "[GTK] Bump glib to 2.50.1 (or find alternative solution to
2787         Gtk+ CUPS build issue)"
2788         https://bugs.webkit.org/show_bug.cgi?id=163689
2789         http://trac.webkit.org/changeset/207992
2790
2791 2016-10-27  Joanmarie Diggs  <jdiggs@igalia.com>
2792
2793         [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
2794         https://bugs.webkit.org/show_bug.cgi?id=163689
2795
2796         Reviewed by Michael Catanzaro.
2797
2798         In order to fix bug #163591, we need to apply an upstream patch to GTK+.
2799         But GTK+ won't build with that patch due to the following error:
2800
2801             m4_copy: won't overwrite defined macro: glib_DEFUN
2802
2803         There is an upstream GLib patch which solves that issue. We should apply
2804         that patch as well, until we bump GLib to 2.50.1 or later.
2805
2806         * gtk/jhbuild.modules: Apply upstream GLib patch.
2807         * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
2808
2809 2016-10-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2810
2811         Unreviewed fix of GTK and EFL test bots.
2812
2813         * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
2814         legacy-encrypted-media by default for GTK and EFL.
2815
2816 2016-10-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2817
2818         [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
2819         https://bugs.webkit.org/show_bug.cgi?id=163846
2820
2821         Reviewed by Michael Catanzaro.
2822
2823         WebAssembly is now developed for Darwin right now.
2824         Disable WASM tests in the other platforms.
2825
2826         * Scripts/run-jsc-stress-tests:
2827
2828 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
2829
2830         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
2831         https://bugs.webkit.org/show_bug.cgi?id=162928
2832
2833         Reviewed by Xabier Rodriguez-Calvar.
2834
2835         Explicitly enable MSE and EME on WebKitGTK+ buildbots.
2836
2837         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
2838
2839         * Scripts/webkitperl/FeatureList.pm:
2840
2841 2016-10-25  Antoine Quint  <graouts@apple.com>
2842
2843         [Modern Media Controls] Media Controller: skip back support
2844         https://bugs.webkit.org/show_bug.cgi?id=163725
2845         <rdar://problem/27989480>
2846
2847         Reviewed by Dean Jackson.
2848
2849         * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
2850         access the modern-media-controls source files through the web server.
2851
2852 2016-10-19  Jer Noble  <jer.noble@apple.com>
2853
2854         Add WKWebView fullscreen delegate SPI
2855         https://bugs.webkit.org/show_bug.cgi?id=163674
2856
2857         Reviewed by Anders Carlsson.
2858
2859         Add a new API test which verifies that the fullscreen delegate receives notifications.
2860
2861         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
2862         (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
2863         (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
2864         (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
2865         (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
2866         (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
2867         (TestWebKitAPI::TEST):
2868
2869 2016-10-24  Alex Christensen  <achristensen@webkit.org>
2870
2871         URLParser should match old URL::parse with %2E in path
2872         https://bugs.webkit.org/show_bug.cgi?id=163929
2873
2874         Reviewed by Alexey Proskuryakov.
2875
2876         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2877         (TestWebKitAPI::TEST_F):
2878
2879 2016-10-24  Ryan Haddad  <ryanhaddad@apple.com>
2880
2881         Unreviewed, rolling out r207795.
2882
2883         Introduced API test failures on iOS and macOS.
2884
2885         Reverted changeset:
2886
2887         "URLParser should match old URL::parse with %2E in path"
2888         https://bugs.webkit.org/show_bug.cgi?id=163929
2889         http://trac.webkit.org/changeset/207795
2890
2891 2016-10-24  Alex Christensen  <achristensen@webkit.org>
2892
2893         URLParser should match old URL::parse with %2E in path
2894         https://bugs.webkit.org/show_bug.cgi?id=163929
2895
2896         Reviewed by Alexey Proskuryakov.
2897
2898         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2899         (TestWebKitAPI::TEST_F):
2900
2901 2016-10-21  Alex Christensen  <achristensen@webkit.org>
2902
2903         URL::port should return Optional<uint16_t>
2904         https://bugs.webkit.org/show_bug.cgi?id=163806
2905
2906         Reviewed by Darin Adler.
2907
2908         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2909         (TestWebKitAPI::TEST_F):
2910         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2911         (TestWebKitAPI::checkURL):
2912         (TestWebKitAPI::checkRelativeURL):
2913         (TestWebKitAPI::checkURLDifferences):
2914         (TestWebKitAPI::checkRelativeURLDifferences):
2915         (TestWebKitAPI::TEST_F):
2916
2917 2016-10-24  Youenn Fablet  <youenn@apple.com>
2918
2919         Activate WEB_RTC compilation flags for Mac bots
2920         https://bugs.webkit.org/show_bug.cgi?id=163886
2921
2922         Reviewed by Eric Carlson.
2923
2924         * Scripts/webkitperl/FeatureList.pm:
2925         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2926
2927 2016-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2928
2929         Unreviewed, add myself as a WebKit reviewer
2930
2931         * Scripts/webkitpy/common/config/contributors.json:
2932
2933 2016-10-22  Dan Bernstein  <mitz@apple.com>
2934
2935         Improve MiniBrowser window titles for URLs without paths and with no title
2936         <https://webkit.org/b/163843>
2937
2938         Reviewed by Darin Adler.
2939
2940         * MiniBrowser/mac/WK1BrowserWindowController.m:
2941         (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
2942           +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
2943           version of this method.
2944         (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
2945           use the entire URL.
2946         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
2947           deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
2948           behavior.
2949
2950         * MiniBrowser/mac/WK2BrowserWindowController.m:
2951         (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
2952           use the entire URL.
2953
2954 2016-10-21  David Kilzer  <ddkilzer@apple.com>
2955
2956         Bug 163762: IntSize::area() should used checked arithmetic
2957         <https://webkit.org/b/163762>
2958
2959         Reviewed by Darin Adler.
2960
2961         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
2962         (TestWebKitAPI::TEST): Call unsafeGet().
2963         * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
2964         (TestWebKitAPI::TEST): Ditto.
2965
2966 2016-10-21  James Craig  <jcraig@apple.com>
2967
2968         Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
2969
2970         * Scripts/webkitpy/common/config/contributors.json:
2971
2972 2016-10-21  Commit Queue  <commit-queue@webkit.org>
2973
2974         Unreviewed, rolling out r207582.
2975         https://bugs.webkit.org/show_bug.cgi?id=163819
2976
2977         Not quite ready rdar://problem/28897179 (Requested by
2978         alexchristensen on #webkit).
2979
2980         Reverted changeset:
2981
2982         "Re-enable URLParser for non-Safari Cocoa apps after r207321"
2983         https://bugs.webkit.org/show_bug.cgi?id=163690
2984         http://trac.webkit.org/changeset/207582
2985
2986 2016-10-21  Jonathan Bedard  <jbedard@apple.com>
2987
2988         WebKitTestRunnerApp packages .idl file
2989         https://bugs.webkit.org/show_bug.cgi?id=163788
2990
2991         Reviewed by Darin Adler.
2992
2993         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
2994
2995 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
2996
2997         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
2998         https://bugs.webkit.org/show_bug.cgi?id=163733
2999
3000         Reviewed by Gyuyoung Kim.
3001
3002         * efl/install-dependencies: Added geoclue-2.0 package.
3003
3004 2016-10-21  Commit Queue  <commit-queue@webkit.org>
3005
3006         Unreviewed, rolling out r207609.
3007         https://bugs.webkit.org/show_bug.cgi?id=163776
3008
3009         As glib bump was rollout, we need to rollout this too
3010         (Requested by rego on #webkit).
3011
3012         Reverted changeset:
3013
3014         "[GTK] Cannot build GTK+ with CUPS 2.* versions"
3015         https://bugs.webkit.org/show_bug.cgi?id=163591
3016         http://trac.webkit.org/changeset/207609
3017
3018 2016-10-20  Chris Dumez  <cdumez@apple.com>
3019
3020         "Download Linked File" context menu action should use 'download' attribute as suggested filename
3021         https://bugs.webkit.org/show_bug.cgi?id=163742
3022         <rdar://problem/28840734>
3023
3024         Reviewed by Darin Adler.
3025
3026         Add API test coverage.
3027
3028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3029         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
3030         * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
3031         (TestWebKitAPI::didFinishLoadForFrame):
3032         (TestWebKitAPI::getContextMenuFromProposedMenu):
3033         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
3034         (TestWebKitAPI::TEST):
3035
3036 2016-10-20  Commit Queue  <commit-queue@webkit.org>
3037
3038         Unreviewed, rolling out r207589.
3039         https://bugs.webkit.org/show_bug.cgi?id=163765
3040
3041         Introduced 17 new layout test failures (Requested by
3042         mcatanzaro on #webkit).
3043
3044         Reverted changeset:
3045
3046         "[GTK] Bump glib to 2.50.1"
3047         https://bugs.webkit.org/show_bug.cgi?id=163689
3048         http://trac.webkit.org/changeset/207589
3049
3050 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3051
3052         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3053         https://bugs.webkit.org/show_bug.cgi?id=163374
3054
3055         Reviewed by Darin Adler.
3056
3057         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3058
3059 2016-10-20  Sam Weinig  <sam@webkit.org>
3060
3061         Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
3062         https://bugs.webkit.org/show_bug.cgi?id=163713
3063
3064         Reviewed by Dan Bernstein.
3065
3066         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3067         Add test for WTF::switchOn()
3068
3069 2016-10-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3070
3071         [CMake] CMake does not support the dep files for implicit dependency
3072         https://bugs.webkit.org/show_bug.cgi?id=161433
3073
3074         Reviewed by Brent Fulgham.
3075
3076         Created a Perl script to generate all IDL bindings for CMake.
3077         This script can regenerate outdated bindings by based on the
3078         supplemental dependency and dep files created by
3079         '--write-dependencies' switch of generate-bindings.pl.
3080
3081         add_custom_target is used to invoke the script instead of
3082         add_custom_command because Ninja deletes all output files before
3083         executing the command in case of add_custom_command.
3084
3085         USES_TERMINAL option of add_custom_target has two effects:
3086         1) Not buffering output of the command
3087         2) Invoking the command in the special Ninja pool which inhibits parallel build
3088         One needs to use CMake 3.2 or later to enable this feature.
3089
3090         * DumpRenderTree/CMakeLists.txt: Specified a target name for
3091         GENERATE_BINDINGS. Added dependency for the target.
3092         * WebKitTestRunner/CMakeLists.txt: Ditto.
3093
3094 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
3095
3096         [GTK] Cannot build GTK+ with CUPS 2.* versions
3097         https://bugs.webkit.org/show_bug.cgi?id=163591
3098
3099         Reviewed by Michael Catanzaro.
3100
3101         GTK+ is wrongly checking about the available CUPS version,
3102         so if you have CUPS 2.* the configure step fails.
3103
3104         This has been already fixed upstream and included in 2.30 series:
3105         https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
3106
3107         Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
3108
3109         * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
3110         as the patch modifies "configure.ac".
3111         * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
3112
3113 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
3114
3115         [GTK] Bump glib to 2.50.1
3116         https://bugs.webkit.org/show_bug.cgi?id=163689
3117
3118         Reviewed by Michael Catanzaro.
3119
3120         This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
3121
3122         * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
3123         Also we don't need the patches anymore.
3124         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
3125         * gtk/patches/glib-warning-fix.patch: Removed.
3126
3127 2016-10-19  Alex Christensen  <achristensen@webkit.org>
3128
3129         Re-enable URLParser for non-Safari Cocoa apps after r207321
3130         https://bugs.webkit.org/show_bug.cgi?id=163690
3131
3132         Reviewed by Darin Adler.
3133
3134         * DumpRenderTree/mac/DumpRenderTree.mm:
3135         (DumpRenderTreeMain):
3136         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3137         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3138         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3139         (TestWebKitAPI::TEST):
3140         * WebKitTestRunner/TestController.cpp:
3141         (WTR::TestController::TestController):
3142
3143 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
3144
3145         Unreviewed, rolling out r207557.
3146
3147         This change caused animations/font-variations tests to time
3148         out on pre-Sierra Macs.
3149
3150         Reverted changeset:
3151
3152         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
3153         iOS 9"
3154         https://bugs.webkit.org/show_bug.cgi?id=163374
3155         http://trac.webkit.org/changeset/207557
3156
3157 2016-10-19  Andy Estes  <aestes@apple.com>
3158
3159         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
3160         https://bugs.webkit.org/show_bug.cgi?id=163476
3161         <rdar://problem/26941395>
3162
3163         Reviewed by Andreas Kling.
3164
3165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3166         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
3167         (TEST): Added an API test that passes a nil MIMEType to
3168         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
3169
3170 2016-10-19  Jer Noble  <jer.noble@apple.com>
3171
3172         Modify testrunner to mute audio during tests
3173         https://bugs.webkit.org/show_bug.cgi?id=162582
3174
3175         Reviewed by Alexey Proskuryakov.
3176
3177         * DumpRenderTree/mac/DumpRenderTree.mm:
3178         (createWebViewAndOffscreenWindow):
3179         * WebKitTestRunner/TestController.cpp:
3180         (WTR::TestController::resetStateToConsistentValues):
3181
3182 2016-10-19  Joseph Pecoraro  <pecoraro@apple.com>
3183
3184         check-webkit-style: fix false-positive warnings about using #pragma once header guard
3185         https://bugs.webkit.org/show_bug.cgi?id=163575
3186
3187         Reviewed by Brady Eidson.
3188
3189         There were some false positive warnings about header guards
3190         for ObjC headers that don't need guards. This changes the
3191         style checker to no longer warn if there is no #pragma once.
3192         It only warns if there are #ifndef that should be #pragma once.
3193
3194         * Scripts/webkitpy/style/checkers/cpp.py:
3195         (check_for_header_guard):
3196         Change when we output an error.
3197
3198         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3199         (CppStyleTest.test_build_header_guard):
3200         Update tests.
3201
3202 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3203
3204         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3205         https://bugs.webkit.org/show_bug.cgi?id=163374
3206
3207         Reviewed by Darin Adler.
3208
3209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3210
3211 2016-10-18  Philippe Normand  <pnormand@igalia.com>
3212
3213         WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
3214         https://bugs.webkit.org/show_bug.cgi?id=163330
3215
3216         Reviewed by Michael Catanzaro.
3217
3218         Bring back the openwebrtc JHBuild moduleset in the time being. It
3219         should be removed after the bump to GStreamer 1.10 is complete and
3220         the libnice patches have been upstreamed. The GStreamer git
3221         snapshots used in this patch are the ones configured in Ericsson's
3222         GStreamer Cerbero fork.
3223
3224         * gtk/openwebrtc.modules: Added.
3225         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
3226         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
3227         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
3228         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
3229         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
3230         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
3231         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
3232
3233 2016-10-18  Sam Weinig  <sam@webkit.org>
3234
3235         Replace std::experimental::variant with WTF::Variant (or similar)
3236         https://bugs.webkit.org/show_bug.cgi?id=163626
3237
3238         Reviewed by Chris Dumez.
3239
3240         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
3241         into the WTF namespace.
3242
3243         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3244         (TestWebKitAPI::TEST):
3245
3246 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
3247
3248         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
3249         https://bugs.webkit.org/show_bug.cgi?id=163627
3250
3251         Reviewed by Dean Jackson.
3252
3253         Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
3254         and WK2 (via new SPI).
3255
3256         * MiniBrowser/mac/BrowserWindowController.h:
3257         * MiniBrowser/mac/BrowserWindowController.m:
3258         (-[BrowserWindowController pageScaleForMenuItemTag:]):
3259         (-[BrowserWindowController setPageScale:]):
3260         (-[BrowserWindowController setViewScale:]):
3261         (-[BrowserWindowController setScale:]): Deleted.
3262         * MiniBrowser/mac/MainMenu.xib:
3263         * MiniBrowser/mac/WK1BrowserWindowController.m:
3264         (-[WK1BrowserWindowController setPageScale:]):
3265         (-[WK1BrowserWindowController setViewScale:]):
3266         (areEssentiallyEqual):
3267         (-[WK1BrowserWindowController validateMenuItem:]):
3268         (-[WK1BrowserWindowController setScale:]): Deleted.
3269         * MiniBrowser/mac/WK2BrowserWindowController.m:
3270         (-[WK2BrowserWindowController setPageScale:]):
3271         (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
3272         (-[WK2BrowserWindowController setViewScale:]):
3273         (areEssentiallyEqual):
3274         (-[WK2BrowserWindowController validateMenuItem:]):
3275         (viewScaleForMenuItemTag): Deleted.
3276         (-[WK2BrowserWindowController setScale:]): Deleted.
3277
3278 2016-10-18  Anders Carlsson  <andersca@apple.com>
3279
3280         Add an beforeunload alert to the WebKitLegacy MiniBrowser
3281         https://bugs.webkit.org/show_bug.cgi?id=163634
3282
3283         Reviewed by Sam Weinig.
3284
3285         * MiniBrowser/mac/WK1BrowserWindowController.m:
3286         (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
3287
3288 2016-10-18  Commit Queue  <commit-queue@webkit.org>
3289
3290         Unreviewed, rolling out r207443.
3291         https://bugs.webkit.org/show_bug.cgi?id=163616
3292
3293         "Caused 5% PLT regression" (Requested by krollin on #webkit).
3294
3295         Reverted changeset:
3296
3297         "Crash in ASCIICaseInsensitiveHash::hash() when a response has
3298         a null MIME type"
3299         https://bugs.webkit.org/show_bug.cgi?id=163476
3300         http://trac.webkit.org/changeset/207443
3301
3302 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
3303
3304         [MediaStream] Resolve constraints and enumerate devices in the UI process
3305         https://bugs.webkit.org/show_bug.cgi?id=162147
3306         <rdar://problem/28803569>
3307
3308         Reviewed by Darin Adler.
3309
3310         * WebKitTestRunner/TestController.cpp:
3311         (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
3312         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
3313
3314 2016-10-17  Megan Gardner  <megan_gardner@apple.com>
3315
3316         Add test and infrastructure for link popover
3317         https://bugs.webkit.org/show_bug.cgi?id=163406
3318
3319         Reviewed by Simon Fraser.
3320
3321         Added functionality test for link popovers.
3322         Can query for what URL is loaded, and that the popover has appeared or has
3323         been dismissed.
3324         Added a link popover test.
3325
3326         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3327         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
3328         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
3329         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
3330         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3331         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3332         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3333         (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
3334         (WTR::UIScriptController::didShowForcePressPreviewCallback):
3335         (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):
3336         (WTR::UIScriptController::didDismissForcePressPreviewCallback):
3337         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
3338         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
3339         (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted.
3340         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
3341         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3342         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3343         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3344         (-[TestRunnerWKWebView dealloc]):
3345         (-[TestRunnerWKWebView didShowForcePressPreview]):
3346         (-[TestRunnerWKWebView didDismissForcePressPreview]):
3347         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3348         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
3349         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
3350         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
3351
3352 2016-10-17  Tim Horton  <timothy_horton@apple.com>
3353
3354         REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
3355         https://bugs.webkit.org/show_bug.cgi?id=163573
3356         <rdar://problem/28744549>
3357
3358         Reviewed by Dan Bernstein.
3359
3360         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
3361         (TEST):
3362         Add a test ensuring that canGoBack returns NO after restoring session state without navigating.
3363
3364 2016-10-17  Andy Estes  <aestes@apple.com>
3365
3366         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
3367         https://bugs.webkit.org/show_bug.cgi?id=163476
3368         <rdar://problem/26941395>
3369
3370         Reviewed by Tim Horton.
3371
3372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3373         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
3374         (TEST): Added an API test that passes a nil MIMEType to
3375         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
3376
3377 2016-10-17  Dean Jackson  <dino@apple.com>
3378
3379         Allow creation of ExtendedColors and make Color immutable
3380         https://bugs.webkit.org/show_bug.cgi?id=163557
3381         <rdar://problem/28805360>
3382
3383         Reviewed by Darin Adler and Dave Hyatt.
3384
3385         API tests for ExtendedColor.
3386
3387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3388         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added.
3389         (TestWebKitAPI::TEST):
3390         (TestWebKitAPI::makeColor):
3391
3392 2016-10-17  JF Bastien  <jfbastien@apple.com>
3393
3394         WebAssembly JS API: implement basic stub
3395
3396         Implement the global WebAssembly JavaScript object, and its constructor +
3397         function properties as described in:
3398           https://github.com/WebAssembly/design/blob/master/JS.md
3399
3400         These don't do anything at the moment, the parent bug will take care of adding
3401         more functionality and associated tests.
3402
3403         WebAssembly JS API: implement basic stub
3404         https://bugs.webkit.org/show_bug.cgi?id=163404
3405
3406         Reviewed by Keith Miller.
3407
3408         * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object.
3409
3410 2016-10-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3411
3412         resolve-ChangeLogs: Specify --no-page to git diff
3413         https://bugs.webkit.org/show_bug.cgi?id=163441
3414
3415         Reviewed by Darin Adler.
3416
3417         resolve-ChangeLogs shows the result after resolving by invoking
3418         'git diff'. It runs a pager for every ChangeLog if it is under
3419         TTY.
3420
3421         * Scripts/resolve-ChangeLogs:
3422         (showStatus): Specify '--no-page' to git diff.
3423
3424 2016-10-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3425
3426         Move user agent quirks to cross-platform location
3427         https://bugs.webkit.org/show_bug.cgi?id=163508
3428
3429         Reviewed by Carlos Garcia Campos.
3430
3431         Move the test to a cross-platform location and improve it to better check the full list of
3432         sites we have defined quirks for.
3433
3434         * TestWebKitAPI/PlatformGTK.cmake:
3435         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
3436         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3437         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3438         (TestWebKitAPI::TEST):
3439
3440 2016-10-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3441
3442         [SOUP] Downloads should always sniff contents
3443         https://bugs.webkit.org/show_bug.cgi?id=163538
3444
3445         Reviewed by Michael Catanzaro.
3446
3447         Add a test case to check that the MIME type is correctly guessed for downloads.
3448
3449         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3450         (writeNextChunk):
3451         (serverCallback):
3452         (testDownloadMIMEType):
3453         (beforeAll):
3454         (writeNextChunkIdle): Deleted.
3455
3456 2016-10-16  Daniel Bates  <dabates@apple.com>
3457
3458         Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
3459         (https://bugs.webkit.org/show_bug.cgi?id=163456)
3460
3461         * Scripts/prepare-ChangeLog:
3462         (actuallyGenerateFunctionLists):
3463
3464 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3465
3466         Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
3467
3468         After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
3469         actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
3470         g_assert_cmpstr for tests.
3471
3472         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3473         (testWebContextLanguages):
3474
3475 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3476
3477         [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
3478         https://bugs.webkit.org/show_bug.cgi?id=163389
3479
3480         Reviewed by Michael Catanzaro.
3481
3482         Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
3483         modified by WebKitWebPage::send-request signal.
3484
3485         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3486         (testWebPageURI):
3487
3488 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3489
3490         Document request not updated after willSendRequest is called for a redirect
3491         https://bugs.webkit.org/show_bug.cgi?id=163436
3492
3493         Reviewed by Michael Catanzaro.
3494
3495         Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
3496         WebKitPage::send-request signal in a web extension.
3497
3498         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3499         (testWebViewActiveURI):
3500         (serverCallback):
3501         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3502         (sendRequestCallback):
3503         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3504         (loadChangedCallback):
3505
3506 2016-10-15  Dan Bernstein  <mitz@apple.com>
3507
3508         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
3509         https://bugs.webkit.org/show_bug.cgi?id=163492
3510         <rdar://problem/28654799>
3511
3512         Reviewed by Darin Adler.
3513
3514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3515         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
3516         (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
3517         (TestWebKitAPI::TEST):
3518
3519 2016-10-15  Daniel Bates  <dabates@apple.com>
3520
3521         prepare-ChangeLog erroneously said that a python __init__ method was deleted
3522         https://bugs.webkit.org/show_bug.cgi?id=163456
3523
3524         Reviewed by Simon Fraser.
3525
3526         Fixes an issue where prepare-ChangeLog may list as deleted functions that are
3527         immediately above added code.
3528
3529         Currently prepare-ChangeLog makes use of the same overlap detection algorithm
3530         to compute the list of deleted functions as it does to compute added and modified
3531         functions. We consider a function deleted if its entire function body and signature
3532         are removed. It is sufficient to compare the list of functions before the patch
3533         is applied and the list of functions are the patch is applied to identify
3534         these functions.
3535
3536         * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
3537         variable names.
3538         (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
3539         compute the list of functions in the file after the patch regardless of whether the
3540         patch only contains deletions. We will compare this list against the list of functions
3541         before the patch was applied to determine the deleted functions.
3542         (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
3543         Removed out argument for the seen functions as we no longer make use of when computing
3544         the list of deleted functions.
3545         (diffCommand): Update comment.
3546         (generateFunctionListsByRanges): Deleted.
3547         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
3548
3549 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
3550
3551         REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
3552         https://bugs.webkit.org/show_bug.cgi?id=163478
3553
3554         Reviewed by Daniel Bates.
3555         
3556         Handle a None other in Contributor.__eq__.
3557
3558         * Scripts/webkitpy/common/config/committers.py:
3559         (Contributor.__eq__):
3560
3561 2016-10-14  JF Bastien  <jfbastien@apple.com>
3562
3563         Basic WebAssembly testing
3564
3565         Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
3566         https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
3567
3568         This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
3569
3570         Details and example in README.md.
3571
3572         Basic WebAssembly testing
3573         https://bugs.webkit.org/show_bug.cgi?id=163267
3574
3575         Reviewed by Keith Miller.
3576
3577         * Scripts/run-javascriptcore-tests:
3578         (runJSCStressTests): run wasm.yaml tests
3579         * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
3580
3581 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
3582
3583         Annotate bots in contributors.json and don't show them on webkit.org/team
3584         https://bugs.webkit.org/show_bug.cgi?id=163317
3585
3586         Reviewed by Daniel Bates.
3587         
3588         Add "class" : "bot" for non-humans in contributors.json and round-trip it.
3589
3590         * Scripts/webkitpy/common/config/committers.py:
3591         (Contributor.__init__):
3592         (Contributor.as_dict):
3593         (Bot):
3594         (Bot.__init__):
3595         (CommitterList.load_json):
3596         * Scripts/webkitpy/common/config/contributors.json:
3597
3598 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
3599
3600         Fix printing in WK2 MiniBrowser
3601         https://bugs.webkit.org/show_bug.cgi?id=163455
3602
3603         Reviewed by Tim Horton.
3604         
3605         Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
3606
3607         * MiniBrowser/mac/WK2BrowserWindowController.m:
3608         (-[WK2BrowserWindowController printWebView:]):
3609
3610 2016-10-14  Commit Queue  <commit-queue@webkit.org>
3611
3612         Unreviewed, rolling out r207335.
3613         https://bugs.webkit.org/show_bug.cgi?id=163445
3614
3615         WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
3616         out on Mac bots (Requested by youenn on #webkit).
3617
3618         Reverted changeset:
3619
3620         "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
3621         ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
3622         builds"
3623         https://bugs.webkit.org/show_bug.cgi?id=163440
3624         http://trac.webkit.org/changeset/207335
3625
3626 2016-10-14  Youenn Fablet  <youenn@apple.com>
3627
3628         Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
3629         https://bugs.webkit.org/show_bug.cgi?id=163440
3630
3631         Unreviewed.
3632
3633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
3634         https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
3635
3636 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3637
3638         Unreviewed. Removed myself from BindingsScripts watch list.
3639
3640         * Scripts/webkitpy/common/config/watchlist:
3641
3642 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3643
3644         WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
3645         https://bugs.webkit.org/show_bug.cgi?id=146306
3646
3647         Reviewed by Darin Adler.
3648
3649         Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
3650
3651         * TestWebKitAPI/CMakeLists.txt:
3652         * TestWebKitAPI/PlatformEfl.cmake:
3653         * TestWebKitAPI/PlatformGTK.cmake:
3654         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
3655         (TestWebKitAPI::didCommitLoadForFrame):
3656         (TestWebKitAPI::TEST):
3657         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
3658         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
3659         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
3660         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
3661
3662 2016-10-13  Alex Christensen  <achristensen@webkit.org>
3663
3664         Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
3665         https://bugs.webkit.org/show_bug.cgi?id=163413
3666
3667         Reviewed by Tim Horton.
3668
3669         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3670         (TestWebKitAPI::TEST_F):
3671         Update parsing results.  There are now fewer differences between the new URLParser and the old URL::parse.
3672
3673 2016-10-13  Alex Christensen  <achristensen@webkit.org>
3674
3675         Rebase API tests after r207305.
3676
3677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3678         Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
3679         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3680         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3681         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3682         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3683         Change results back to what they were before r207162, r207167, and r207184.
3684
3685 2016-10-13  Alex Christensen  <achristensen@webkit.org>
3686
3687         Disable URLParser for non-Safari iOS and Mac apps for now
3688         https://bugs.webkit.org/show_bug.cgi?id=163397
3689
3690         Reviewed by Tim Horton.
3691
3692         * DumpRenderTree/mac/DumpRenderTree.mm:
3693         (DumpRenderTreeMain):
3694         * WebKitTestRunner/TestController.cpp:
3695         Enable the URLParser for testing.
3696         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3697         Link with WebCoreTestSupport so we can find setURLParserEnabled.
3698
3699 2016-10-13  Ryan Haddad  <ryanhaddad@apple.com>
3700
3701         Unreviewed, rolling out r207297.
3702
3703         This change broke the iOS build.
3704
3705         Reverted changeset:
3706
3707         "Disable URLParser for non-Safari iOS and Mac apps for now"
3708         https://bugs.webkit.org/show_bug.cgi?id=163397
3709         http://trac.webkit.org/changeset/207297
3710
3711 2016-10-13  Alex Christensen  <achristensen@webkit.org>
3712
3713         Disable URLParser for non-Safari iOS and Mac apps for now
3714         https://bugs.webkit.org/show_bug.cgi?id=163397
3715
3716         Reviewed by Tim Horton.
3717
3718         * DumpRenderTree/mac/DumpRenderTree.mm:
3719         (DumpRenderTreeMain):
3720         * WebKitTestRunner/ios/mainIOS.mm:
3721         (main):
3722         * WebKitTestRunner/mac/main.mm:
3723         (main):
3724
3725 2016-10-12  Alex Christensen  <achristensen@webkit.org>
3726
3727         Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
3728         https://bugs.webkit.org/show_bug.cgi?id=163376
3729
3730         Reviewed by Saam Barati.
3731
3732         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3733         (TestWebKitAPI::TEST_F):
3734
3735 2016-10-11  Dean Jackson  <dino@apple.com>
3736
3737         Add preliminary support for extended colors to WebCore::Color
3738         https://bugs.webkit.org/show_bug.cgi?id=162878
3739         <rdar://problem/28596413>
3740
3741         Reviewed by Darin Adler.
3742
3743         A new API test for Colors.
3744
3745         * TestWebKitAPI/Tests/WebCore/Color.cpp:
3746         (TestWebKitAPI::TEST):
3747
3748 2016-10-12  Ryan Haddad  <ryanhaddad@apple.com>
3749
3750         Unreviewed, rolling out r207225.
3751
3752         This change causes debug tests to exit early with crashes.
3753
3754         Reverted changeset:
3755
3756         "Optional's move-constructor and move-assignment operator
3757         don't disengage the value being moved from"
3758         https://bugs.webkit.org/show_bug.cgi?id=163309
3759         http://trac.webkit.org/changeset/207225
3760
3761 2016-10-12  Alex Christensen  <achristensen@webkit.org>
3762
3763         Fix assertion after switching to URLParser
3764         https://bugs.webkit.org/show_bug.cgi?id=163350
3765         rdar://problem/28739938
3766
3767         Reviewed by Brady Eidson.
3768
3769         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3770         (TEST):
3771
3772 2016-10-11  Sam Weinig  <sam@webkit.org>
3773
3774         Optional's move-constructor and move-assignment operator don't disengage the value being moved from
3775         https://bugs.webkit.org/show_bug.cgi?id=163309
3776
3777         Reviewed by Anders Carlsson.
3778
3779         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3780         (TestWebKitAPI::TEST):
3781         Add tests for Optional's move-constructor and move-assignment operator.
3782
3783 2016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3784
3785         Now playing media sessions are always cleared for the active foreground tab
3786         https://bugs.webkit.org/show_bug.cgi?id=163310
3787         <rdar://problem/28573301>
3788
3789         Reviewed by Jer Noble.
3790
3791         Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
3792         that media session info is correctly cleared out if the media session itself is no longer eligible for Now
3793         Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
3794         always clear out the information, but this is incorrect, and is the source of the problem.
3795
3796         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3797         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
3798         (TestWebKitAPI::TEST):
3799
3800 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
3801
3802         [Win] Parallel DRTs are sharing preferences and cache.
3803         https://bugs.webkit.org/show_bug.cgi?id=163013
3804
3805         Reviewed by Brent Fulgham.
3806
3807         Use separate cache and preferences for each DRT instance.
3808
3809         * DumpRenderTree/win/DumpRenderTree.cpp:
3810         (applicationId):
3811         (setApplicationId):
3812         (setCacheFolder):
3813         (setDefaultsToConsistentValuesForTesting):
3814         * Scripts/webkitpy/port/win.py:
3815         (WinPort.setup_test_run):
3816
3817 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3818
3819         Update API test expectation after r207162.
3820        ​https://bugs.webkit.org/show_bug.cgi?id=162660
3821
3822         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3823         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3824         Like r207167 but with a WebKit2 test.
3825         "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
3826
3827 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3828
3829         Update API test expectation after r207162.
3830         https://bugs.webkit.org/show_bug.cgi?id=162660
3831
3832         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3833         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3834         "https://www.example.com<>/" was an invalid URL with the old URL parser.
3835         It is now a valid URL, but NSURL still considers it invalid.
3836         This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
3837
3838 2016-10-11  Edward O'Connor  <eoconnor@apple.com>
3839
3840         Update my name in contributors.json
3841         https://bugs.webkit.org/show_bug.cgi?id=163251
3842
3843         Reviewed by Simon Fraser.
3844
3845         * Scripts/webkitpy/common/config/contributors.json:
3846
3847 2016-10-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
3848
3849         Add SynchronizedFixedQueue class
3850         https://bugs.webkit.org/show_bug.cgi?id=162478
3851
3852         Reviewed by Geoffrey Garen.
3853
3854         Add a new test for SynchronizedFixedQueue. The test defines a new class
3855         called ToUpperConverter which converts strings from lower case to upper
3856         case. It creates two threads : (1) produce thread and (2) consume thread.
3857         Here is what each thread does:
3858
3859         1. Main threads: Enqueues lower case strings into m_lowerQueue.
3860         2. Produce thread: Dequeues lower case strings from m_lowerQueue and 
3861            enqueue their upper case strings in the m_upperQueue.
3862         3. Consume thread: Dequeues upper case strings from m_upperQueue.
3863
3864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3865         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
3866         (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
3867         (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
3868         (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
3869         (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
3870         (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
3871         (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
3872         (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
3873         (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
3874         (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
3875         (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
3876         (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
3877         (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
3878         (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
3879         (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
3880         (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
3881         (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
3882         (TestWebKitAPI::TEST):
3883
3884 2016-10-11  Megan Gardner  <megan_gardner@apple.com>
3885
3886         Extend event stream to include interpolated events and add a force press test that uses that interpolation
3887         https://bugs.webkit.org/show_bug.cgi?id=163161
3888
3889         Reviewed by Simon Fraser.
3890
3891         Added functionality to the event stream to allow for interpolated events.
3892         Can now do long press, as well as a better way to do drag and other time-based
3893         events that require a large stream of descrete HID events.
3894         Added a basic force touch test to demostrate this interpolation.
3895         Also updated the script to allow for iPhone 7 specific tests, as force touch
3896         needs to be on a device that had force touch.
3897
3898         * Scripts/webkitpy/port/ios.py:
3899         (IOSSimulatorPort):
3900         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3901         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3902         (linearInterpolation):
3903         (simpleCurveInterpolation):
3904         (calculateNextCurveLocation):
3905         (phaseFromString):
3906         (interpolationFromString):
3907         (-[HIDEventGenerator eventMaskFromEventInfo:]):
3908         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
3909         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
3910         (-[HIDEventGenerator interpolatedEvents:]):
3911         (-[HIDEventGenerator processEventsArray:withStartTime:]):
3912         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3913         (simpleDragCurve): Deleted.
3914         (calculateNextLocation): Deleted.
3915
3916 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3917
3918         URLParser should percent-encode non-ASCII and non-printable characters in fragment
3919         https://bugs.webkit.org/show_bug.cgi?id=163287
3920
3921         Reviewed by Brady Eidson.
3922
3923         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3924         (TestWebKitAPI::TEST_F):
3925
3926 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3927
3928         Remove dead networking code
3929         https://bugs.webkit.org/show_bug.cgi?id=163263
3930
3931         Reviewed by Daniel Bates.
3932
3933         * DumpRenderTree/DumpRenderTree.h:
3934         * DumpRenderTree/config.h:
3935         * DumpRenderTree/win/DumpRenderTree.cpp:
3936         (main):
3937
3938 2016-10-11  John Wilander  <wilander@apple.com>
3939
3940         Modify check-webkit-style to prohibit sensitive phrases
3941         https://bugs.webkit.org/show_bug.cgi?id=163048
3942         <rdar://problem/28289755>
3943
3944         Terms considered or found to be too general to flag:
3945         ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
3946         denial of service, dereference, disclosure, error, exploit,
3947         failure, heap, integer overflow, leak, null dereference,
3948         null pointer dereference, out of bounds, overflow,
3949         race condition, sensitive information, stack, type confusion.
3950
3951         Reviewed by Brent Fulgham.
3952
3953         * Scripts/webkitpy/style/checkers/changelog.py:
3954         (ChangeLogChecker.check_entry):
3955             Now calls ChangeLogChecker.check_for_unwanted_security_terms().
3956         (ChangeLogChecker):
3957         (ChangeLogChecker.check_for_unwanted_security_terms):
3958             New function to check for sensitive terms.
3959         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
3960         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
3961             Convenience class.
3962         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3963         (ChangeLogCheckerTest.test_unwanted_security_terms):
3964
3965 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
3966
3967         Unreviewed, rolling out r207067.
3968
3969         This change caused webkitpy test failures.
3970
3971         Reverted changeset:
3972
3973         "[Win] Parallel DRTs are sharing preferences and cache."
3974         https://bugs.webkit.org/show_bug.cgi?id=163013
3975         http://trac.webkit.org/changeset/207067
3976
3977 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
3978
3979         [Win] Parallel DRTs are sharing preferences and cache.
3980         https://bugs.webkit.org/show_bug.cgi?id=163013
3981
3982         Reviewed by Brent Fulgham.
3983
3984         Use separate cache and preferences for each DRT instance.
3985
3986         * DumpRenderTree/win/DumpRenderTree.cpp:
3987         (applicationId):
3988         (setApplicationId):
3989         (setCacheFolder):
3990         (setDefaultsToConsistentValuesForTesting):
3991         * Scripts/webkitpy/port/win.py:
3992         (WinPort.setup_test_run):
3993
3994 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
3995
3996         Add ENABLE_ENCRYPTED_MEDIA configuration option
3997         https://bugs.webkit.org/show_bug.cgi?id=163219
3998
3999         Reviewed by Darin Adler.
4000
4001         * Scripts/webkitperl/FeatureList.pm:
4002         Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
4003         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4004         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
4005         to enable or disable the new EME implementation at build-time.
4006
4007 2016-10-10  Commit Queue  <commit-queue@webkit.org>
4008
4009         Unreviewed, rolling out r206972.
4010         https://bugs.webkit.org/show_bug.cgi?id=163227
4011
4012         Making EWS flaky (Requested by bfulgham_ on #webkit).
4013
4014         Reverted changeset:
4015
4016         "[CMake] CMake does not support the dep files for implicit
4017         dependency"
4018         https://bugs.webkit.org/show_bug.cgi?id=161433
4019         http://trac.webkit.org/changeset/206972
4020
4021 2016-10-10  Youenn Fablet  <youenn@apple.com>
4022
4023         W3C test downloader should be able to import specific files/sub-directories in a skipped directory
4024         https://bugs.webkit.org/show_bug.cgi?id=161789
4025
4026         Reviewed by Ryosuke Niwa.
4027
4028         Removed tests_directory option and corresponding test.
4029         This option was allowing to import a sub-directory from a test repository.
4030         We can readd it if necessary.
4031
4032         Adding support for finer-grained import rules.
4033         Previously skipped directories were fully removed.
4034         Now, directories may be skipped but sub directories of them may be imported.
4035         This currently happens in web-platform-tests repo.
4036
4037         * Scripts/webkitpy/w3c/test_downloader.py:
4038         (TestDownloader._add_test_suite_paths): Removing tests_directory option.
4039         (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
4040         (TestDownloader.copy_tests.should_copy_dir):
4041         (TestDownloader.copy_tests.should_copy_file):
4042         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4043         (TestImporterTest.test_tests_directory): Deleted.
4044         (TestImporterTest.test_skip_test_import): Added.
4045
4046 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
4047
4048         Make validate-committer-lists show inactive reviewers
4049         https://bugs.webkit.org/show_bug.cgi?id=163193
4050
4051         Reviewed by Sam Weinig.
4052         
4053         In preparation for updating contributors.json with the WebKit policy of retiring
4054         inactive reviewers, make validate-committer-lists show the list of reviewers who
4055         have not reviewed in the past year.
4056         
4057         This list is computed by grepping the output of 'git log --since=1.year" for
4058         the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
4059         which looks for full names, aliases, irc nicks and email addresses.
4060         
4061         Support for aliases is added to Contributor. Aliases are alternates
4062         or misspellings of the reviewer's name. Some common aliases were added to
4063         contributors.json by manual examination of "Reviewed by" lines.
4064
4065         * Scripts/validate-committer-lists:
4066         (CommitterListFromGit.possibly_expired_committers):
4067         (CommitterListFromGit):
4068         (CommitterListFromGit.possibly_inactive_reviewers):
4069         (CommitterListFromGit.print_possibly_expired_committers):
4070         (CommitterListFromGit.print_possibly_inactive_reviewers):
4071         * Scripts/webkitpy/common/config/committers.py:
4072         (Contributor.__init__):
4073         (Contributor.contains_string):
4074         (Contributor.mentioned_in_text):
4075         (Contributor.as_dict):
4076         (Committer.__init__):
4077         (Reviewer.__init__):
4078         (CommitterList.load_json):
4079         * Scripts/webkitpy/common/config/contributors.json:
4080
4081 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
4082
4083         Convert contributors.json to a flat list
4084         https://bugs.webkit.org/show_bug.cgi?id=163183
4085
4086         Reviewed by Darin Adler.
4087         
4088         Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
4089         and moving that data to a "status" property on each contributor.
4090
4091         * Scripts/webkitpy/common/config/committers.py:
4092         (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
4093         (Contributor.as_dict): Include status in the dict.
4094         (CommitterList.__init__): Clean up to make the testing code path more explicit.
4095         (CommitterList.load_json):
4096         (CommitterList.load_test_data):
4097         (CommitterList.as_json):
4098         (Contributor.__unicode__): Deleted.
4099         * Scripts/webkitpy/common/config/contributors.json:
4100         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4101         (IRCCommandTest.test_whois): The ordering here is now alphabetical.
4102
4103 2016-10-09  Fujii Hironori  <Hironori.Fujii@sony.com>
4104
4105         [CMake] CMake does not support the dep files for implicit dependency
4106         https://bugs.webkit.org/show_bug.cgi?id=161433
4107
4108         Reviewed by Brent Fulgham.
4109
4110         Created a Perl script to generate all IDL bindings for CMake.
4111         This script can regenerate outdated bindings by based on the
4112         supplemental dependency and dep files created by
4113         '--write-dependencies' switch of generate-bindings.pl.
4114
4115         add_custom_target is used to invoke the script instead of
4116         add_custom_command because Ninja deletes all output files before
4117         executing the command in case of add_custom_command.
4118
4119         USES_TERMINAL option of add_custom_target has two effects:
4120         1) Not buffering output of the command
4121         2) Invoking the command in the special Ninja pool which inhibits parallel build
4122         One needs to use CMake 3.2 or later to enable this feature.
4123
4124         * DumpRenderTree/CMakeLists.txt: Specified a target name for
4125         GENERATE_BINDINGS. Added dependency for the target.
4126         * WebKitTestRunner/CMakeLists.txt: Ditto.
4127
4128 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
4129
4130         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
4131         https://bugs.webkit.org/show_bug.cgi?id=163177
4132
4133         Follow-up fix.
4134         
4135         For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
4136         Rename it to as_dict().
4137
4138         * Scripts/webkitpy/common/config/committers.py:
4139         (Contributor.as_dict):
4140         (CommitterList._contributor_list_to_dict):
4141         (Contributor.__dict__): Deleted.
4142
4143 2016-10-08  Simon Fraser  <simon.fraser@apple.com>
4144
4145         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
4146         https://bugs.webkit.org/show_bug.cgi?id=163177
4147
4148         Reviewed by Ryosuke Niwa.
4149         
4150         Make it possible to round-trip contributors.json through CommitterList, so we can
4151         support writing out contributors.json in canonical format. This requires saving
4152         the case-preserved email and expertise in Contributor. CommitterList also needs
4153         to be able to generate the "exclusive" lists, since it currently uses lists
4154         that are the union of, say, committers and reviewers.
4155         
4156         If contributors.json is malformed (invalid JSON), catch the Exception, report it
4157         and exit rather than allowing the exception to propagate. With an invalid file,
4158         an exception would be thrown before the JSON style checker reached this file, so
4159         the error was not correctly reported.
4160         
4161         Add style/checker/committer.py for checking that committers.json has the canonical format.
4162         
4163         Add support to validate-committer-lists to dump out the canonical json (-d) or update
4164         the file in-place (-c).
4165
4166         * Scripts/validate-committer-lists:
4167         (CommitterListFromGit._print_three_column_row):
4168         (CommitterListFromGit.possibly_expired_committers):
4169         (CommitterListFromGit):
4170         (CommitterListFromGit.print_possibly_expired_committers):
4171         (main):
4172         * Scripts/webkitpy/common/config/committers.py:
4173         (Contributor.__init__):
4174         (Contributor.__dict__):
4175         (Committer.__init__):
4176         (Reviewer.__init__):
4177         (CommitterList.load_json):
4178         (CommitterList):
4179         (CommitterList._contributor_list_to_dict):
4180         (CommitterList.as_json):
4181         (CommitterList.reformat_in_place):
4182         (CommitterList._exclusive_contributors):
4183         (CommitterList._exclusive_committers):
4184         (Contributor.matches_glob): Deleted.
4185         (CommitterList.contributors): Deleted.
4186         * Scripts/webkitpy/common/config/contributors.json:
4187         * Scripts/webkitpy/style/checker.py:
4188         (CheckerDispatcher._create_checker):
4189         * Scripts/webkitpy/style/checkers/contributors.py: Added.
4190         (ContributorsChecker):
4191         (ContributorsChecker.__init__):
4192         (ContributorsChecker.check):
4193         (ContributorsChecker._unidiff_output):
4194
4195 2016-10-06  Darin Adler  <darin@apple.com>
4196
4197         Next step on moving to modern way to return DOM exceptions
4198         https://bugs.webkit.org/show_bug.cgi?id=163016
4199
4200         Reviewed by Ryosuke Niwa.
4201
4202         * Scripts/do-webcore-rename: Add proposed name change of setDOMException
4203         to propagateException, since this function is primarily used to take an
4204         exception already effectively "thrown" by setting an ExceptionCode out
4205         argument and propagate it into the JavaScript engine's exception machinery.
4206
4207 2016-10-07  Alex Christensen  <achristensen@webkit.org>
4208
4209         Non-special URL fragments should percent-encode non-ASCII characters
4210         https://bugs.webkit.org/show_bug.cgi?id=163153
4211
4212         Reviewed by Tim Horton.
4213
4214         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4215         (TestWebKitAPI::TEST_F):
4216
4217 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
4218
4219         Build fix for “Move functionality common to Darwin ports into a base class”
4220         https://bugs.webkit.org/show_bug.cgi?id=160709
4221
4222         Unreviewed build fix.
4223
4224         * Scripts/webkitpy/port/ios.py:
4225         (IOSSimulatorPort._get_crash_log): Added iOS implementation.
4226         * Scripts/webkitpy/port/mac.py:
4227         (MacPort._get_crash_log): Added Mac implementation.
4228
4229 2016-10-07  Chelsea Pugh  <cpugh@apple.com>
4230
4231         Unreviewed. Added myself to the list of committers.
4232
4233         * Scripts/webkitpy/common/config/contributors.json:
4234
4235 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
4236
4237         Move functionality common to Darwin ports into a base class
4238         https://bugs.webkit.org/show_bug.cgi?id=160709
4239
4240         Reviewed by Darin Adler.
4241
4242         * Scripts/webkitpy/port/apple.py:
4243         (ApplePort.determine_full_port_name): Specific iOS port check.
4244         (ApplePort.__init__): Move leak detector to DarwinPort.
4245         (ApplePort._make_leak_detector): Moved to DarwinPort.
4246         (ApplePort.supports_per_test_timeout): Moved to Port.
4247         (ApplePort.check_for_leaks): Moved to DarwinPort.
4248         (ApplePort.print_leaks_summary): Moved to DarwinPort.
4249         (ApplePort._path_to_webcore_library): Moved to DarwinPort.
4250         (ApplePort.show_results_html_file): Moved to DarwinPort.