Remove an old temporary script that has served its purpose
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2
3         Remove an old temporary script that has served its purpose
4
5         * Scripts/convert-test-expectations: Removed.
6
7 2015-08-28  Jer Noble  <jer.noble@apple.com>
8
9         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
10         https://bugs.webkit.org/show_bug.cgi?id=148579
11
12         Reviewed by Anders Carlsson.
13
14         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
15
16         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
17         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
18
19         * DumpRenderTree/mac/DumpRenderTree.mm:
20         (resetWebPreferencesToConsistentValues):
21         (resetWebViewToConsistentStateBeforeTesting): 
22         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
23         (WTR::initializeWebViewConfiguration):
24
25 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
26
27         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
28         https://bugs.webkit.org/show_bug.cgi?id=148592
29
30         Reviewed by Tim Horton.
31
32         * Scripts/webkitpy/port/base.py:
33         (Port.to.setup_environ_for_server):
34         (Port.to):
35         (Port.to._append_value_colon_separated):
36         (Port.to.show_results_html_file):
37         * Scripts/webkitpy/port/ios.py:
38         (IOSSimulatorPort.setup_environ_for_server):
39         * Scripts/webkitpy/port/mac.py:
40         (MacPort.setup_environ_for_server):
41
42 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
43
44         LICM should be sound even if the CFG has changed
45         https://bugs.webkit.org/show_bug.cgi?id=148259
46
47         Reviewed by Benjamin Poulain.
48
49         Add a utility for creating tests that set some uncommon option.
50
51         * Scripts/run-jsc-stress-tests:
52
53 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
54
55         [Win] Unreviewed EWS correction.
56
57         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
58
59 2015-08-28  Jer Noble  <jer.noble@apple.com>
60
61         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
62         https://bugs.webkit.org/show_bug.cgi?id=147512
63
64         Reviewed by Anders Carlsson.
65
66         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
67         to a consistent (true) value.
68
69         * DumpRenderTree/mac/DumpRenderTree.mm:
70         (setDefaultsToConsistentValuesForTesting):
71         * WebKitTestRunner/TestController.cpp:
72         (WTR::TestController::resetPreferencesToConsistentValues):
73
74 2015-08-28  Tim Horton  <timothy_horton@apple.com>
75
76         Add navigation gesture callbacks to WKPageNavigationClient
77         https://bugs.webkit.org/show_bug.cgi?id=148568
78         <rdar://problem/22371346>
79
80         Reviewed by Anders Carlsson.
81
82         * WebKitTestRunner/TestController.cpp:
83         (WTR::TestController::createOtherPage):
84         (WTR::TestController::createWebViewWithOptions):
85         Add some zeroes.
86
87 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
88
89         [Mac] kill-old-processes should kill more processes
90         https://bugs.webkit.org/show_bug.cgi?id=148577
91
92         Reviewed by Tim Horton.
93
94         * BuildSlaveSupport/kill-old-processes:
95
96 2015-08-28  Jason Marcell  <jmarcell@apple.com>
97
98         The status message for combined builder queues should say "all builds succeeded" if everything
99         built correctly.
100         https://bugs.webkit.org/show_bug.cgi?id=148535
101
102         Reviewed by David Kilzer and Alexey Proskuryakov.
103
104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
105         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
106         say "all builds succeeded" if everything built correctly.
107
108 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
109
110         [GTK] Simplify the internal API to create a WebView
111         https://bugs.webkit.org/show_bug.cgi?id=148570
112
113         Reviewed by Žan Doberšek.
114
115         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
116         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
117         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
118         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
119         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
120         passing the received PageConfiguration.
121         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
122         (WTR::PlatformWebView::PlatformWebView): Create the WebView
123         passing the received PageConfiguration.
124
125 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
126
127         iOS Simulator API tests fails as Simulator is not running
128         https://bugs.webkit.org/show_bug.cgi?id=148501
129         rdar://problem/22447525
130
131         Reviewed by Daniel Bates.
132
133         This change is a workaround for <rdar://problem/22388812>.
134
135          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
136          and quit it on program termination when running tests on the iOS port.
137          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
138          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
139
140 2015-08-27  Alex Christensen  <achristensen@webkit.org>
141
142         Make DLLLauncherMain executables dependent on dll
143         https://bugs.webkit.org/show_bug.cgi?id=148548
144
145         Reviewed by Brent Fulgham.
146
147         * DumpRenderTree/CMakeLists.txt:
148         * DumpRenderTree/PlatformWin.cmake:
149         * MiniBrowser/win/CMakeLists.txt:
150         * TestWebKitAPI/CMakeLists.txt:
151         * TestWebKitAPI/PlatformWin.cmake:
152
153 2015-08-27  Lucas Forschler  <lforschler@apple.com>
154
155         Remove Mac slaves 188/189 after being replaced with 400/401.
156         
157         Unreviewed.
158         
159         * BuildSlaveSupport/build.webkit.org-config/config.json:
160
161 2015-08-27  Lucas Forschler  <lforschler@apple.com>
162
163         Add two bots to the Mac Yosemite queue.
164         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
165         
166         Unreviewed.
167         
168         * BuildSlaveSupport/build.webkit.org-config/config.json:
169
170 2015-08-27  Alex Christensen  <achristensen@webkit.org>
171
172         [Win CMake] Fix incremental build after r188673
173         https://bugs.webkit.org/show_bug.cgi?id=148539
174
175         Reviewed by Brent Fulgham.
176
177         * TestWebKitAPI/PlatformWin.cmake:
178         Copy forwarding headers from WebCore before building in case that was not yet done.
179         It used to be done when running CMake, but now it's a build step.
180
181 2015-08-27  Nan Wang  <n_wang@apple.com>
182
183         AX: Fix accessibility/select-element-at-index.html test
184         https://bugs.webkit.org/show_bug.cgi?id=148516
185
186         Reviewed by Chris Fleizach.
187
188         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
189
190         * DumpRenderTree/AccessibilityUIElement.cpp:
191         (setSelectedChildCallback):
192         (setSelectedChildAtIndexCallback):
193         (removeSelectionAtIndexCallback):
194         (elementAtPointCallback):
195         (sentenceAtOffsetCallback):
196         (stringForSelectionCallback):
197         (AccessibilityUIElement::getJSClass):
198         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
199         (AccessibilityUIElement::setSelectedChild):
200         (AccessibilityUIElement::setSelectedChildAtIndex):
201         (AccessibilityUIElement::removeSelectionAtIndex):
202         (AccessibilityUIElement::accessibilityValue):
203         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
204         (WTR::AccessibilityUIElement::wordAtOffset):
205         (WTR::AccessibilityUIElement::lineAtOffset):
206         (WTR::AccessibilityUIElement::sentenceAtOffset):
207         (WTR::AccessibilityUIElement::isSelectable):
208         (WTR::AccessibilityUIElement::isMultiSelectable):
209         (WTR::AccessibilityUIElement::setSelectedChild):
210         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
211         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
212         (WTR::AccessibilityUIElement::selectedChildrenCount):
213         (WTR::AccessibilityUIElement::selectedChildAtIndex):
214         (WTR::AccessibilityUIElement::isExpanded):
215         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
216         (WTR::AccessibilityUIElement::setSelectedChild):
217         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
218         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
219         (WTR::AccessibilityUIElement::accessibilityValue):
220
221 2015-08-27  Alex Christensen  <achristensen@webkit.org>
222
223         Build fix after r188982
224
225         * MiniBrowser/win/CMakeLists.txt:
226         The directory structure changed in the move.
227
228 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
229
230         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
231
232         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
233
234         * gtk/install-dependencies:
235
236 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
237
238         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
239
240         * Scripts/run-gtk-tests:
241         (TestRunner):
242
243 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
244
245         Fix GTK+ WTR crashes in initializeMainRunLoop()
246
247         Rubber-stamped by Žan Doberšek.
248
249         Initialize threading and main thread before
250         RunLoop::initializeMainRunLoop(), since the GLib implementation of
251         the RunLoop uses isMainThread() to decide whether to create a new
252         GMainContext or use the default one. Also use RunLoop::run() and
253         ::stop() instead of gtk_main/quit.
254
255         * WebKitTestRunner/TestController.cpp:
256         (WTR::TestController::initialize):
257         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
258         (WTR::TestController::notifyDone):
259         (WTR::TestController::platformRunUntil):
260
261 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
262
263         Unreviewed, further shorten a test that times out because it's very long
264         running.
265
266         I've locally run these tests on repeat for 24 hours and found no genuine
267         failures, like deadlocks. So, the timeouts are probably because the test
268         machine is slow and debug is slow. We should just run this test for fewer
269         iterations.
270
271         * TestWebKitAPI/Tests/WTF/Lock.cpp:
272         (TestWebKitAPI::TEST):
273
274 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
275
276         Unreviewed build fix attempt on EFL
277
278         * WebKitTestRunner/PlatformEfl.cmake:
279
280 2015-08-26  Alex Christensen  <achristensen@webkit.org>
281
282         Build fix after r188982
283
284         * MiniBrowser/win/CMakeLists.txt:
285         Find .rc files in correct directory.
286
287 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
288
289         [EFL] Bump cairo version to 1.14.2
290         https://bugs.webkit.org/show_bug.cgi?id=148474
291
292         Reviewed by Csaba Osztrogonác.
293
294         * efl/jhbuild.modules:
295
296 2015-08-26  Andy Estes  <aestes@apple.com>
297
298         Crash when following a Google search link to Twitter with Limit Adult Content enabled
299         https://bugs.webkit.org/show_bug.cgi?id=147651
300
301         Rubber-stamped by Brady Eidson.
302
303         Taught TestRunner how to decide the navigation policy after a delay.
304
305         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
306         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
307         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
309         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
311         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
312         * WebKitTestRunner/TestController.cpp:
313         (WTR::TestController::initialize):
314         (WTR::TestController::resetStateToConsistentValues):
315         (WTR::TestController::decidePolicyForNavigationAction):
316         * WebKitTestRunner/TestController.h:
317         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
318         * WebKitTestRunner/TestInvocation.cpp:
319         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
320
321 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
322
323         [Win] Rename 'WinLauncher' to 'MiniBrowser'
324         https://bugs.webkit.org/show_bug.cgi?id=148485
325
326         Reviewed by Alex Christensen
327
328         Move the WinLauncher project and source files to a subdirectory
329         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
330         source code and project files.
331         
332         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
333         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
334         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
335         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
336         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
337         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
338         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
339         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
340         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
341         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
342         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
343         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
344         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
345         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
346         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
347         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
348         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
349         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
350         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
351         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
352         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
353         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
354         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
355         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
356         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
357         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
358         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
359         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
360         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
361         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
362         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
363         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
364         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
365         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
366         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
367         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
368         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
369         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
370         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
371         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
372         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
373         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
374         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
375         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
376         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
377         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
378         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
379         * MiniBrowser/win: Copied from WinLauncher.
380         * MiniBrowser/win/Common.cpp:
381         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
382         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
383         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
384         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
385         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
386         * MiniBrowser/win/PageLoadTestClient.cpp:
387         * MiniBrowser/win/PageLoadTestClient.h:
388         * MiniBrowser/win/ResourceLoadDelegate.cpp:
389         * MiniBrowser/win/ResourceLoadDelegate.h:
390         * MiniBrowser/win/WinLauncher.cpp: Removed.
391         * MiniBrowser/win/WinLauncher.h: Removed.
392         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
393         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
394         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
395         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
396         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
397         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
398         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
399         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
400         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
401         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
402         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
403         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
404         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
405         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
406         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
407         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
408         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
409         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
410         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
411         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
412         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
413         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
414         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
415         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
416         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
417         * MiniBrowser/win/WinLauncherReplace.h: Removed.
418         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
419         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
420         * MiniBrowser/win/WinMain.cpp:
421         * WinLauncher: Removed.
422         * WinLauncher/AccessibilityDelegate.cpp: Removed.
423         * WinLauncher/AccessibilityDelegate.h: Removed.
424         * WinLauncher/CMakeLists.txt: Removed.
425         * WinLauncher/Common.cpp: Removed.
426         * WinLauncher/DOMDefaultImpl.cpp: Removed.
427         * WinLauncher/DOMDefaultImpl.h: Removed.
428         * WinLauncher/PageLoadTestClient.cpp: Removed.
429         * WinLauncher/PageLoadTestClient.h: Removed.
430         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
431         * WinLauncher/PrintWebUIDelegate.h: Removed.
432         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
433         * WinLauncher/ResourceLoadDelegate.h: Removed.
434         * WinLauncher/WebDownloadDelegate.cpp: Removed.
435         * WinLauncher/WebDownloadDelegate.h: Removed.
436         * WinLauncher/WinLauncher.cpp: Removed.
437         * WinLauncher/WinLauncher.h: Removed.
438         * WinLauncher/WinLauncher.vcxproj: Removed.
439         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
440         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
441         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
442         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
443         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
444         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
445         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
446         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
447         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
448         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
449         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
450         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
451         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
452         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
453         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
454         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
455         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
456         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
457         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
458         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
459         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
460         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
461         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
462         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
463         * WinLauncher/WinLauncherReplace.h: Removed.
464         * WinLauncher/WinLauncherWebHost.cpp: Removed.
465         * WinLauncher/WinLauncherWebHost.h: Removed.
466         * WinLauncher/WinMain.cpp: Removed.
467         * WinLauncher/resource.h: Removed.
468         * WinLauncher/stdafx.cpp: Removed.
469         * WinLauncher/stdafx.h: Removed.
470         * win/AssembleBuildLogs/AssembleLogs.cmd:
471
472 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
473
474         [Win] Simplify menu handling code in WinLauncher
475         https://bugs.webkit.org/show_bug.cgi?id=148461
476
477         Reviewed by Zalan Bujtas.
478
479         Revise 'ToggleMenuItem' to return a boolean value indicating if
480         it handled the message. Revise WndProc to use this to decide if it
481         should pass the message on to the default handler, rather than
482         duplicating the logic in both places.
483         
484         * WinLauncher/Common.cpp:
485         (ToggleMenuItem): Return true if the menu item message was handled.
486         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
487         the message tothe default handler.
488
489 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
490
491         Remove unused code after r188948
492         https://bugs.webkit.org/show_bug.cgi?id=148467
493
494         Reviewed by Gyuyoung Kim.
495
496         * WebKitTestRunner/TestController.cpp:
497         (WTR::TestController::platformPreferences): Deleted.
498
499 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
500
501         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
502         https://bugs.webkit.org/show_bug.cgi?id=148377
503
504         Reviewed by Carlos Garcia Campos.
505
506         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
507         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
508         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
509         EFL and GTK at the moment.
510
511         * WebKitTestRunner/TestController.cpp:
512         (WTR::TestController::platformWillRunTest):
513         * WebKitTestRunner/efl/TestControllerEfl.cpp:
514         (WTR::TestController::platformPreferences):
515         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
516         (WTR::TestController::platformPreferences):
517
518 2015-08-25  Nan Wang  <n_wang@apple.com>
519
520         AX: Enable accessibility/aria-controls.html test for mac
521         https://bugs.webkit.org/show_bug.cgi?id=148458
522
523         Reviewed by Chris Fleizach.
524
525         Implemented ariaControlsElementAtIndex(unsigned index).
526
527         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
528         (AccessibilityUIElement::ariaControlsElementAtIndex):
529         (AccessibilityUIElement::disclosedRowAtIndex):
530         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
531         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
532
533 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
534
535         Remove python tests for PassRefPtr 
536         https://bugs.webkit.org/show_bug.cgi?id=148463
537
538         Reviewed by Andy Estes.
539
540         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
541
542         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
543         (PassPtrTest): Deleted.
544         (PassPtrTest.assert_pass_ptr_check): Deleted.
545         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
546         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
547         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
548         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
549         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
550         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
551
552 2015-08-25  Andy Estes  <aestes@apple.com>
553
554         [iOS] run-webkit-tests fails if watchOS SDK is installed
555         https://bugs.webkit.org/show_bug.cgi?id=148453
556
557         Reviewed by David Kilzer.
558
559         * Scripts/webkitpy/xcode/simulator.py:
560         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
561         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
562
563 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
564
565         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
566         https://bugs.webkit.org/show_bug.cgi?id=148197
567         rdar://problem/22334382
568
569         Reviewed by Daniel Bates.
570
571         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
572         * Scripts/webkitpy/port/ios.py:
573         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
574         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
575         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
576         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
577         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
578
579 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
580
581         Remove PassRefPtr style check rule
582         https://bugs.webkit.org/show_bug.cgi?id=148432
583
584         Reviewed by Andreas Kling.
585
586         PassRefPtr is being removed. Thus style rule needs to be removed as well.
587
588         * Scripts/webkitpy/style/checkers/cpp.py:
589         (_check_parameter_name_against_text): Deleted.
590         (check_function_definition_and_pass_ptr): Deleted.
591         (check_function_definition): Deleted.
592         (check_pass_ptr_usage): Deleted.
593         (process_line): Deleted.
594         (CppChecker): Deleted.
595
596 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
597
598         [Win] Expose "Inverted Colors" option in WinLauncher
599         https://bugs.webkit.org/show_bug.cgi?id=148451
600
601         Reviewed by Tim Horton.
602
603         Add the ability to toggle the "Inverted Colors" preference
604         in WinLauncher.
605         
606         * WinLauncher/Common.cpp:
607         (ToggleMenuItem): Toggle the feature when the menu item
608         is selected.
609         (WndProc): Recognize the new menu option.
610         * WinLauncher/WinLauncher.cpp:
611         (WinLauncher::setToDefaultPreferences): Launch with "Invert
612         Colors" turned off.
613         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
614         entry for "Invert Colors".
615         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
616
617 2015-08-25  Nan Wang  <n_wang@apple.com>
618
619         [Mac] accessibility/document-attributes.html fails
620         https://bugs.webkit.org/show_bug.cgi?id=116636
621
622         Reviewed by Chris Fleizach.
623
624         Implemented documentURI() and documentEncoding().
625
626         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
627         (AccessibilityUIElement::documentEncoding):
628         (AccessibilityUIElement::documentURI):
629         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
630         (WTR::AccessibilityUIElement::documentEncoding):
631         (WTR::AccessibilityUIElement::documentURI):
632
633 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
634
635         [Win] Unreviewed test gardening.
636
637         Fix another case where the logging string is constructed using the variable 'frame',
638         but the method argument is not given a name. This causes the global 'frame' value to
639         be used, producing incorrect output.
640
641         * DumpRenderTree/win/FrameLoadDelegate.cpp:
642         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
643         argument.
644
645 2015-08-24  Tim Horton  <timothy_horton@apple.com>
646
647         (Finally...) get rid of WKViewIOS
648         https://bugs.webkit.org/show_bug.cgi?id=148404
649
650         Reviewed by Anders Carlsson.
651
652         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
653         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
654         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
655         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
656         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
657         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
658         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
659         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
660         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
661         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
662         Mark tests that use WKBrowsingContextController as Mac-only.
663
664         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
665         (WTR::AccessibilityController::addNotificationListener):
666         * WebKitTestRunner/ios/mainIOS.mm:
667         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
668         Import UIKit instead of depending on WKView.h to do so.
669
670 2015-08-24  Jason Marcell  <jmarcell@apple.com>
671
672         Add support to dashboard for displaying Git SHA's as revisions.
673         https://bugs.webkit.org/show_bug.cgi?id=148387
674
675         Reviewed by Daniel Bates.
676
677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
678         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
680         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
681         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
682         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
683
684 2015-08-24  Andy Estes  <aestes@apple.com>
685
686         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
687
688         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
689
690 2015-08-23  Andy Estes  <aestes@apple.com>
691
692         Addressed a missed piece of review feedback from r188851.
693
694         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
695
696 2015-08-23  Andy Estes  <aestes@apple.com>
697
698         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
699         https://bugs.webkit.org/show_bug.cgi?id=147872
700         rdar://problem/22044000
701
702         Reviewed by Dan Bernstein.
703         
704         Added an API test.
705
706         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
709         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
710         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
711         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
712         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
713         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
714         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
715         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
716         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
717
718 2015-08-23  Andy Estes  <aestes@apple.com>
719
720         Fixed the 32-bit Mac build after r188844.
721
722         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
723         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
724
725 2015-08-22  Andy Estes  <aestes@apple.com>
726
727         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
728         https://bugs.webkit.org/show_bug.cgi?id=148317
729
730         Reviewed by Dan Bernstein.
731
732         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
733         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
734         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
735         when creating WKWebViews.
736
737         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
738         added a new API test for bundle parameters.
739
740         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
741         named its executable TestWebKitAPI.bundle.
742         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
744         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
745         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
746         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
747         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
748         bundle parameter and asked for an initial notification.
749         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
750         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
751         mirror its value in the main frame's JSContext.
752         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
753         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
754         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
755         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
756         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
757         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
758         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
759         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
760         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
761         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
762
763 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
764
765         URTBF after r188828.
766
767         * WebKitTestRunner/PlatformWebView.h:
768
769 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
770
771         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
772         https://bugs.webkit.org/show_bug.cgi?id=148356
773
774         Reviewed by Darin Adler.
775
776         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
777         (BuildbotCombinedQueueView.prototype.update):
778
779 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
780
781         build.webkit.org/dashboard: Respect step's hidden flag
782         https://bugs.webkit.org/show_bug.cgi?id=148357
783
784         Reviewed by Darin Adler.
785
786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
787         (BuildbotIteration.prototype._parseData):
788
789 2015-08-23  Nan Wang  <n_wang@apple.com>
790
791         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
792         https://bugs.webkit.org/show_bug.cgi?id=148328
793
794         Reviewed by Darin Adler.
795
796         We should only expose stringValue() when value attribute is set.
797
798         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
799         (AccessibilityUIElement::stringValue):
800         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
801         (WTR::AccessibilityUIElement::stringValue):
802
803 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
804
805         Remove style checking rule regarding OwnPtr and PassOwnPtr
806         https://bugs.webkit.org/show_bug.cgi?id=148360
807
808         Reviewed by Darin Adler.
809
810         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
811         Removed it.
812
813         * Scripts/do-webcore-rename:
814         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
815         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
816         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
817         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
818         (WebKitStyleTest.test_names): Deleted.
819
820 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
821
822         WebKitTestRunner should use WKWebView on OS X and iOS
823         https://bugs.webkit.org/show_bug.cgi?id=143743
824         <rdar://problem/16947123>
825
826         Reviewed by Anders Carlsson.
827         Patch by Enrica Casucci and myself.
828
829         * WebKitTestRunner/PlatformWebView.h:
830         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
831         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
832         instead of WKContext and WKPageGroup.
833
834         Remove the unused, always-true windowSnapshotEnabled().
835         While technically some platforms don't have window snapshotting,
836         they just return null instead of implementing windowSnapshotEnabled().
837
838         * WebKitTestRunner/TestController.h:
839         * WebKitTestRunner/TestController.cpp:
840         (WTR::TestController::createOtherPage):
841         (WTR::TestController::initialize):
842         (WTR::TestController::createWebViewWithOptions):
843         Delegate to the various platforms for creating PlatformWebView instances,
844         for creating WKContexts, and for accessing WKPreferences,
845         so that they can do special things (like, use WKWebView instead!).
846
847         (WTR::TestController::resetPreferencesToConsistentValues):
848         Make explicit WebKitTestRunner's desired default for two preferences
849         which have differing defaults between the antique and modern API,
850         for consistency's sake.
851
852         (WTR::TestController::resetStateToConsistentValues):
853         Add platformResetStateToConsistentValues.
854
855         * WebKitTestRunner/TestInvocation.cpp:
856         (WTR::TestInvocation::dumpResults):
857         Adjust to the aforementioned removal of windowSnapshotEnabled().
858
859         * WebKitTestRunner/ios/TestControllerCocoa.mm:
860         (WTR::TestController::platformResetStateToConsistentValues):
861         (WTR::TestController::platformPreferences):
862         (WTR::TestController::platformCreateWebView):
863         (WTR::TestController::platformCreateOtherPage):
864         (WTR::TestController::platformInitializeConfiguration):
865         Implement the new platform functions for the Modern WebKit2 API,
866         in a new TestControllerCocoa file that is shared between iOS and Mac.
867         
868         For platformMaybeCreateContext, use the trick that we know we can cast
869         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
870         WKWebView's configuration.
871
872         Ditto for WKPreferencesRef and WKPreferences.
873
874         Remove user content filters on the WKWebView's userContentController.
875
876         * WebKitTestRunner/mac/TestControllerMac.mm:
877         * WebKitTestRunner/ios/TestControllerIOS.mm:
878         Move code into TestControllerCocoa.
879
880         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
881         (WTR::InjectedBundle::beginTesting):
882         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
883         (WTR::TestRunner::addUserScript):
884         (WTR::TestRunner::addUserStyleSheet):
885         Adopt WKBundlePage API for user scripts/sheets.
886
887         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
888         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
889         Make and keep a WKWebView instead of a WKView.
890         
891         * WebKitTestRunner/mac/EventSenderProxy.mm:
892         (WTR::EventSenderProxy::mouseUp):
893         (WTR::EventSenderProxy::mouseMoveTo):
894         Reach inside the WKWebView to the WKView when dispatching events.
895         This is fairly ugly and we should come up with a better solution.
896         Also, fix some flipping and style errors.
897
898 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
899
900         Unreviewed, attempt to fix GTK build after r188718
901
902         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
903         (WTR::PlatformWebView::PlatformWebView):
904
905 2015-08-21  Commit Queue  <commit-queue@webkit.org>
906
907         Unreviewed, rolling out r188807, r188813, and r188815.
908         https://bugs.webkit.org/show_bug.cgi?id=148349
909
910         lots of 32-bit build problems, better to resolve separately
911         and try again (Requested by thorton on #webkit).
912
913         Reverted changesets:
914
915         "WebKitTestRunner should use WKWebView on OS X and iOS"
916         https://bugs.webkit.org/show_bug.cgi?id=143743
917         http://trac.webkit.org/changeset/188807
918
919         "Stop building WebKitTestRunner for 32-bit platforms"
920         https://bugs.webkit.org/show_bug.cgi?id=143743
921         http://trac.webkit.org/changeset/188813
922
923         "Stop building WebKitTestRunner for 32-bit platforms"
924         https://bugs.webkit.org/show_bug.cgi?id=143743
925         http://trac.webkit.org/changeset/188815
926
927 2015-08-21  Tim Horton  <timothy_horton@apple.com>
928
929         Stop building WebKitTestRunner for 32-bit platforms
930         https://bugs.webkit.org/show_bug.cgi?id=143743
931         <rdar://problem/16947123>
932
933         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
934         This is a restriction on the valid set, not the desired set.
935
936 2015-08-21  Jason Marcell  <jmarcell@apple.com>
937
938         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
939         to work with these new objects.
940         https://bugs.webkit.org/show_bug.cgi?id=148188
941
942         Reviewed by Daniel Bates.
943
944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
945         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
947         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
948         (repository, "branch name")-pair.
949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
951         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
953         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
954         objects which represent a (repository, "branch name")-pair.
955         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
956         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
957         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
958         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
960         BuildbotQueue.branch to BuildbotQueue.branches.
961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
962         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
963
964 2015-08-21  Tim Horton  <timothy_horton@apple.com>
965
966         Stop building WebKitTestRunner for 32-bit platforms
967         https://bugs.webkit.org/show_bug.cgi?id=143743
968         <rdar://problem/16947123>
969
970         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
971         WKWebView is not available on 32-bit OS X.
972
973 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
974
975         [Win] Unreviewed test correction after r188709.
976
977         I removed a function argument that happened to be mirrored by a global
978         value with the same name. This prevented a compile error, but testing
979         showed that the wrong value was being used in the function.
980
981         * DumpRenderTree/win/FrameLoadDelegate.cpp:
982         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
983         back
984
985 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
986
987         WebKitTestRunner should use WKWebView on OS X and iOS
988         https://bugs.webkit.org/show_bug.cgi?id=143743
989         <rdar://problem/16947123>
990
991         Reviewed by Anders Carlsson.
992         Patch by Enrica Casucci and myself.
993
994         * WebKitTestRunner/PlatformWebView.h:
995         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
996         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
997         instead of WKContext and WKPageGroup.
998
999         Remove the unused, always-true windowSnapshotEnabled().
1000         While technically some platforms don't have window snapshotting,
1001         they just return null instead of implementing windowSnapshotEnabled().
1002
1003         * WebKitTestRunner/TestController.h:
1004         * WebKitTestRunner/TestController.cpp:
1005         (WTR::TestController::createOtherPage):
1006         (WTR::TestController::initialize):
1007         (WTR::TestController::createWebViewWithOptions):
1008         Delegate to the various platforms for creating PlatformWebView instances,
1009         for creating WKContexts, and for accessing WKPreferences,
1010         so that they can do special things (like, use WKWebView instead!).
1011
1012         (WTR::TestController::resetPreferencesToConsistentValues):
1013         Make explicit WebKitTestRunner's desired default for two preferences
1014         which have differing defaults between the antique and modern API,
1015         for consistency's sake.
1016
1017         (WTR::TestController::resetStateToConsistentValues):
1018         Add platformResetStateToConsistentValues.
1019
1020         * WebKitTestRunner/TestInvocation.cpp:
1021         (WTR::TestInvocation::dumpResults):
1022         Adjust to the aforementioned removal of windowSnapshotEnabled().
1023
1024         * WebKitTestRunner/ios/TestControllerCocoa.mm:
1025         (WTR::TestController::platformResetStateToConsistentValues):
1026         (WTR::TestController::platformPreferences):
1027         (WTR::TestController::platformCreateWebView):
1028         (WTR::TestController::platformCreateOtherPage):
1029         (WTR::TestController::platformInitializeConfiguration):
1030         Implement the new platform functions for the Modern WebKit2 API,
1031         in a new TestControllerCocoa file that is shared between iOS and Mac.
1032         
1033         For platformMaybeCreateContext, use the trick that we know we can cast
1034         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1035         WKWebView's configuration.
1036
1037         Ditto for WKPreferencesRef and WKPreferences.
1038
1039         Remove user content filters on the WKWebView's userContentController.
1040
1041         * WebKitTestRunner/mac/TestControllerMac.mm:
1042         * WebKitTestRunner/ios/TestControllerIOS.mm:
1043         Move code into TestControllerCocoa.
1044
1045         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1046         (WTR::InjectedBundle::beginTesting):
1047         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1048         (WTR::TestRunner::addUserScript):
1049         (WTR::TestRunner::addUserStyleSheet):
1050         Adopt WKBundlePage API for user scripts/sheets.
1051
1052         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1053         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1054         Make and keep a WKWebView instead of a WKView.
1055         
1056         * WebKitTestRunner/mac/EventSenderProxy.mm:
1057         (WTR::EventSenderProxy::mouseUp):
1058         (WTR::EventSenderProxy::mouseMoveTo):
1059         Reach inside the WKWebView to the WKView when dispatching events.
1060         This is fairly ugly and we should come up with a better solution.
1061         Also, fix some flipping and style errors.
1062
1063 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
1064
1065         Improve how UI events are dispatched by WebKitTestRunner
1066         https://bugs.webkit.org/show_bug.cgi?id=148326
1067
1068         Reviewed by Anders Carlsson.
1069
1070         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1071         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1072         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
1073         asynchronous (and really, it has always been for the most part).
1074
1075         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1076         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
1077         (WTR::EventSendingController::mouseUp): Ditto.
1078         (WTR::EventSendingController::mouseMoveTo): Ditto.
1079         (WTR::EventSendingController::mouseForceDown): Ditto.
1080         (WTR::EventSendingController::mouseForceUp): Ditto.
1081         (WTR::EventSendingController::mouseForceChanged): Ditto.
1082         (WTR::EventSendingController::leapForward): Ditto.
1083         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
1084         (WTR::EventSendingController::keyDown): Ditto.
1085         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
1086         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
1087         to be done in custom WebKit2 code for test wheel event handling.
1088         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
1089         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
1090         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
1091         (WTR::EventSendingController::addTouchPoint): Ditto.
1092         (WTR::EventSendingController::updateTouchPoint): Ditto.
1093         (WTR::EventSendingController::setTouchModifier): Ditto.
1094         (WTR::EventSendingController::setTouchPointRadius): Ditto.
1095         (WTR::EventSendingController::touchStart): Ditto.
1096         (WTR::EventSendingController::touchMove): Ditto.
1097         (WTR::EventSendingController::touchEnd): Ditto.
1098         (WTR::EventSendingController::touchCancel): Ditto.
1099         (WTR::EventSendingController::clearTouchPoints): Ditto.
1100         (WTR::EventSendingController::releaseTouchPoint): Ditto.
1101         (WTR::EventSendingController::cancelTouchPoint): Ditto.
1102
1103         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1104         (WTR::InjectedBundle::postSetWindowIsKey):
1105         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1106         (WTR::InjectedBundle::isGeolocationProviderActive):
1107         (WTR::InjectedBundle::shouldProcessWorkQueue):
1108         Updated for WKBundlePagePostSynchronousMessage renaming.
1109
1110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1111         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
1112
1113         * WebKitTestRunner/TestController.cpp:
1114         (WTR::TestController::initialize): Allow handling the new test style messages.
1115         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
1116         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
1117         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1118         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
1119         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
1120
1121         * WebKitTestRunner/mac/EventSenderProxy.mm:
1122         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
1123         (WTR::EventSenderProxy::keyDown): Ditto.
1124         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
1125         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1126
1127 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1128
1129         Skip no-llint tests that fail due to running out of executable memory after r188969
1130         https://bugs.webkit.org/show_bug.cgi?id=148273
1131
1132         Reviewed by Michael Saboff.
1133
1134         * Scripts/run-jsc-stress-tests:
1135
1136 2015-08-21  Nan Wang  <n_wang@apple.com>
1137
1138         [Mac] accessibility/selection-states.html fails
1139         https://bugs.webkit.org/show_bug.cgi?id=116637
1140
1141         Reviewed by Chris Fleizach.
1142
1143         Implemented isSelectable() and isMultiSelectable().
1144
1145         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1146         (AccessibilityUIElement::isSelectable):
1147         (AccessibilityUIElement::isMultiSelectable):
1148         (AccessibilityUIElement::isSelectedOptionActive):
1149         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1150         (WTR::AccessibilityUIElement::isSelectable):
1151         (WTR::AccessibilityUIElement::isMultiSelectable):
1152         (WTR::AccessibilityUIElement::isVisible):
1153
1154 2015-08-21  Jason Marcell  <jmarcell@apple.com>
1155
1156         Fix iteration over repositories on bot watcher's dashboard.
1157
1158         Reviewed by Alexey Proskuryakov.
1159
1160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1161         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
1162
1163 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
1164
1165         [EFL] Revise PlatformWebView ctor according to r188718
1166         https://bugs.webkit.org/show_bug.cgi?id=148282
1167
1168         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
1169         instead of WKContextRef and WKPageGroupRef respectively.
1170
1171         Reviewed by Gyuyoung Kim.
1172
1173         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1174         (WTR::PlatformWebView::PlatformWebView):
1175
1176 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
1177
1178         Unreviewed, changed Devin Rousso's email.
1179
1180         * Scripts/webkitpy/common/config/contributors.json:
1181
1182 2015-08-20  Anders Carlsson  <andersca@apple.com>
1183
1184         Use WKPageConfigurationRef in WebKitTestRunner
1185         https://bugs.webkit.org/show_bug.cgi?id=147996
1186
1187         Reviewed by Tim Horton.
1188
1189         * WebKitTestRunner/TestController.cpp:
1190         (WTR::TestController::createOtherPage):
1191         (WTR::TestController::initialize):
1192         (WTR::TestController::createWebViewWithOptions):
1193         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1194         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
1195         (WTR::PlatformWebView::PlatformWebView):
1196         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
1197
1198 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
1199
1200         [Win] Update Windows tools for revised MIDL interfaces
1201         https://bugs.webkit.org/show_bug.cgi?id=148249
1202
1203         Reviewed by Dean Jackson.
1204
1205         This is a follow-up to Bug 148001.
1206
1207         Revise the testing software to use compatible signatures and
1208         implementations to match the requirements of the IDL generated
1209         with the SAL annotations.
1210
1211         * DumpRenderTree/win/DRTDataObject.cpp:
1212         * DumpRenderTree/win/DRTDataObject.h:
1213         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1214         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1215         * DumpRenderTree/win/DRTDropSource.cpp:
1216         * DumpRenderTree/win/DRTDropSource.h:
1217         * DumpRenderTree/win/DumpRenderTree.cpp:
1218         * DumpRenderTree/win/EditingDelegate.cpp:
1219         * DumpRenderTree/win/EditingDelegate.h:
1220         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1221         * DumpRenderTree/win/FrameLoadDelegate.h:
1222         * DumpRenderTree/win/HistoryDelegate.cpp:
1223         * DumpRenderTree/win/HistoryDelegate.h:
1224         * DumpRenderTree/win/PolicyDelegate.cpp:
1225         * DumpRenderTree/win/PolicyDelegate.h:
1226         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1227         * DumpRenderTree/win/ResourceLoadDelegate.h:
1228         * DumpRenderTree/win/TestRunnerWin.cpp:
1229         * DumpRenderTree/win/UIDelegate.cpp:
1230         * DumpRenderTree/win/UIDelegate.h:
1231         * WinLauncher/AccessibilityDelegate.cpp:
1232         * WinLauncher/AccessibilityDelegate.h:
1233         * WinLauncher/Common.cpp:
1234         * WinLauncher/DOMDefaultImpl.cpp:
1235         * WinLauncher/DOMDefaultImpl.h:
1236         * WinLauncher/PageLoadTestClient.cpp:
1237         * WinLauncher/PageLoadTestClient.h:
1238         * WinLauncher/PrintWebUIDelegate.cpp:
1239         * WinLauncher/PrintWebUIDelegate.h:
1240         * WinLauncher/ResourceLoadDelegate.cpp:
1241         * WinLauncher/ResourceLoadDelegate.h:
1242         * WinLauncher/WebDownloadDelegate.cpp:
1243         * WinLauncher/WebDownloadDelegate.h:
1244         * WinLauncher/WinLauncherWebHost.cpp:
1245         * WinLauncher/WinLauncherWebHost.h:
1246         * WinLauncher/WinMain.cpp:
1247         * win/DLLLauncher/DLLLauncherMain.cpp:
1248
1249 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
1250
1251         Unreviewed, shorten a test that runs too long and times out.
1252
1253         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1254         (TestWebKitAPI::TEST):
1255
1256 2015-08-20  Alex Christensen  <achristensen@webkit.org>
1257
1258         Clean up CMake build after r188673
1259         https://bugs.webkit.org/show_bug.cgi?id=148234
1260
1261         Reviewed by Tim Horton.
1262
1263         * DumpRenderTree/PlatformWin.cmake:
1264         * TestWebKitAPI/CMakeLists.txt:
1265         * TestWebKitAPI/PlatformWin.cmake:
1266         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1267         gtest needs to be a static library on Windows to not crash.
1268
1269 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1270
1271         CMake Windows build should not include files directly from other Source directories
1272         https://bugs.webkit.org/show_bug.cgi?id=148198
1273
1274         Reviewed by Brent Fulgham.
1275
1276         * DumpRenderTree/DumpRenderTreePrefix.h:
1277         Include cmakeconfig.h to properly define all enabled features.
1278         * DumpRenderTree/PlatformWin.cmake:
1279         * TestWebKitAPI/PlatformWin.cmake:
1280
1281 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1282
1283         Build TestWTF on Mac with CMake.
1284         https://bugs.webkit.org/show_bug.cgi?id=147972
1285
1286         Reviewed by Tim Horton.
1287
1288         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1289         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1290
1291         * TestWebKitAPI/CMakeLists.txt:
1292         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1293         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1294         * TestWebKitAPI/PlatformMac.cmake: Added.
1295         * TestWebKitAPI/config.h:
1296         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1297
1298 2015-08-19  Brian Burg  <bburg@apple.com>
1299
1300         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1301
1302         * Scripts/webkitpy/common/config/contributors.json:
1303
1304 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1305
1306         REGRESSION(r188548): [GTK] Build broken.
1307         https://bugs.webkit.org/show_bug.cgi?id=148154
1308
1309         Reviewed by Martin Robinson.
1310
1311         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1312         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1313         Even if we don't need to add/override any settings in ViewOptions,
1314         we need to define this as an empty function to make it build.
1315
1316 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1317
1318         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1319         https://bugs.webkit.org/show_bug.cgi?id=148073
1320
1321         Reviewed by Alexey Proskuryakov.
1322
1323         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1324         (TestWebKitAPI::TEST):
1325
1326 2015-08-18  Anders Carlsson  <andersca@apple.com>
1327
1328         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1329
1330         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1331         (TestWebKitAPI::setUpClients):
1332
1333 2015-08-18  Brian Burg  <bburg@apple.com>
1334
1335         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1336         https://bugs.webkit.org/show_bug.cgi?id=147955
1337
1338         Reviewed by Timothy Hatcher.
1339
1340         To enable sharing of common test code between protocol and model tests,
1341         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1342
1343         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1344         protocol-test.js uses to load the inspector frontend stub into its iframe
1345         from an arbitrary local file URL.
1346
1347         * DumpRenderTree/TestRunner.cpp:
1348         (getInspectorTestStubURLCallback):
1349         (TestRunner::staticValues):
1350         * DumpRenderTree/TestRunner.h:
1351         * DumpRenderTree/mac/TestRunnerMac.mm:
1352         (SOFT_LINK_STAGED_FRAMEWORK):
1353         (TestRunner::inspectorTestStubURL):
1354         * DumpRenderTree/win/TestRunnerWin.cpp:
1355         (TestRunner::inspectorTestStubURL):
1356         * WebKitTestRunner/Configurations/Base.xcconfig:
1357         Since WebKitTestRunner now includes WebCore private headers, also search
1358         for the WebCore framework inside the WebKit umbrella framework.
1359
1360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1361         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1362         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1363         (WTR::TestRunner::inspectorTestStubURL):
1364         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1365         (WTR::TestRunner::inspectorTestStubURL):
1366         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1367         (WTR::TestRunner::inspectorTestStubURL):
1368
1369 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1370
1371         Unreviewed, fix GTK build.
1372
1373         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1374         (TestWebKitAPI::TEST):
1375
1376 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1377
1378         Replace all remaining uses of WTF::Mutex with WTF::Lock
1379         https://bugs.webkit.org/show_bug.cgi?id=148089
1380
1381         Reviewed by Geoffrey Garen.
1382
1383         * DumpRenderTree/JavaScriptThreading.cpp:
1384         (javaScriptThreadsMutex):
1385         (runJavaScriptThread):
1386         (startJavaScriptThreads):
1387         (stopJavaScriptThreads):
1388         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1389         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1390         (TestWebKitAPI::TEST):
1391         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1392         (TestWebKitAPI::TEST):
1393
1394 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1395
1396         Unreviewed, rolling out r188539, r188544, r188552, and
1397         r188564.
1398         https://bugs.webkit.org/show_bug.cgi?id=148122
1399
1400         Broke tests and some build styles (Requested by ap on
1401         #webkit).
1402
1403         Reverted changesets:
1404
1405         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1406         bundle"
1407         https://bugs.webkit.org/show_bug.cgi?id=147955
1408         http://trac.webkit.org/changeset/188539
1409
1410         "Web Inspector: split TestStub.js into multiple files and
1411         modernize it"
1412         https://bugs.webkit.org/show_bug.cgi?id=148077
1413         http://trac.webkit.org/changeset/188544
1414
1415         "Web Inspector: InspectorTest should be a subclass of
1416         TestHarness"
1417         https://bugs.webkit.org/show_bug.cgi?id=148079
1418         http://trac.webkit.org/changeset/188552
1419
1420         "Unreviewed internal build fix attempt after r188539."
1421         http://trac.webkit.org/changeset/188564
1422
1423 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1424
1425         [OS X] Remove support for composite fonts
1426         https://bugs.webkit.org/show_bug.cgi?id=147920
1427
1428         Reviewed by Dan Bernstein.
1429
1430         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1431         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1432         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1433         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1434         * DumpRenderTree/mac/DumpRenderTree.mm:
1435         (allowedFontFamilySet): Deleted.
1436         (activateTestingFonts): Deleted.
1437         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1438         (WTR::allowedFontFamilySet): Deleted.
1439         (WTR::activateFonts): Deleted.
1440         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1441         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1442         * WebKitTestRunner/mac/TestControllerMac.mm:
1443         (WTR::allowedFontFamilySet): Deleted.
1444
1445 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1446
1447         Unreviewed internal build fix attempt after r188539.
1448
1449         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1450
1451 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1452
1453         Fix the build
1454
1455         Unreviewed.
1456
1457         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1458
1459 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1460
1461         Build Debug Suffix on Windows with CMake
1462         https://bugs.webkit.org/show_bug.cgi?id=148083
1463
1464         Reviewed by Brent Fulgham.
1465
1466         * TestWebKitAPI/CMakeLists.txt:
1467         * TestWebKitAPI/PlatformWin.cmake:
1468         Add DEBUG_SUFFIX
1469
1470 2015-08-17  Anders Carlsson  <andersca@apple.com>
1471
1472         Simplify how PlatformWebViews are created when view options change
1473         https://bugs.webkit.org/show_bug.cgi?id=148093
1474
1475         Reviewed by Sam Weinig.
1476
1477         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1478
1479         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1480         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1481         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1482
1483         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1484
1485         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1486         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1487
1488         * WebKitTestRunner/TestController.cpp:
1489         (WTR::TestController::ensureViewSupportsOptionsForTest):
1490         (WTR::shouldUseFixedLayout):
1491         (WTR::TestController::viewOptionsForTest):
1492         (WTR::TestController::updateWebViewSizeForTest):
1493         (WTR::TestController::updateWindowScaleForTest):
1494         (WTR::TestController::configureViewForTest):
1495         (WTR::TestController::initialize): Deleted.
1496         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1497         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1498         (WTR::TestController::platformConfigureViewForTest): Deleted.
1499         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1500         (WTR::TestController::run): Deleted.
1501         * WebKitTestRunner/TestController.h:
1502         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1503         (WTR::shouldUseFixedLayout):
1504         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1505         (WTR::TestController::platformConfigureViewForTest):
1506         (WTR::TestController::platformResetPreferencesToConsistentValues):
1507         * WebKitTestRunner/ios/TestControllerIOS.mm:
1508         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1509         * WebKitTestRunner/mac/TestControllerMac.mm:
1510         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1511         (WTR::TestController::platformConfigureViewForTest):
1512
1513 2015-08-17  Sam Weinig  <sam@webkit.org>
1514
1515         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1516         https://bugs.webkit.org/show_bug.cgi?id=148097
1517
1518         Reviewed by Anders Carlsson.
1519
1520         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1521         Add tests for WebsiteDataStores in the WKPageConfiguration.
1522
1523 2015-08-17  Brian Burg  <bburg@apple.com>
1524
1525         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1526         https://bugs.webkit.org/show_bug.cgi?id=147955
1527
1528         Reviewed by Timothy Hatcher.
1529
1530         To enable sharing of common test code between protocol and model tests,
1531         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1532
1533         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1534         protocol-test.js uses to load the inspector frontend stub into its iframe
1535         from an arbitrary local file URL.
1536
1537         * DumpRenderTree/TestRunner.cpp:
1538         (getInspectorTestStubURLCallback):
1539         (TestRunner::staticValues):
1540         * DumpRenderTree/TestRunner.h:
1541         * DumpRenderTree/mac/TestRunnerMac.mm:
1542         (SOFT_LINK_STAGED_FRAMEWORK):
1543         (TestRunner::inspectorTestStubURL):
1544         * DumpRenderTree/win/TestRunnerWin.cpp:
1545         (TestRunner::inspectorTestStubURL):
1546         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1548         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1549         (WTR::TestRunner::inspectorTestStubURL):
1550         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1551         (WTR::TestRunner::inspectorTestStubURL):
1552         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1553         (WTR::TestRunner::inspectorTestStubURL):
1554
1555 2015-08-17  Saam barati  <sbarati@apple.com>
1556
1557         Change email address from saambarati1@gmail.com to sbarati@apple.com
1558
1559         * Scripts/webkitpy/common/config/contributors.json:
1560
1561 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1562
1563         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1564         repositories other than "openSource" and "internal".
1565         https://bugs.webkit.org/show_bug.cgi?id=147961
1566
1567         Reviewed by Daniel Bates.
1568
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1570         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1571         generically with repositories other than "openSource" and "internal".
1572
1573 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1574
1575         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1576         https://bugs.webkit.org/show_bug.cgi?id=148081
1577
1578         Reviewed by Tim Horton.
1579
1580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1581         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1582
1583 2015-08-11  Andy Estes  <aestes@apple.com>
1584
1585         [Cocoa] Add redirect support to CustomProtocolManager
1586         https://bugs.webkit.org/show_bug.cgi?id=147871
1587
1588         Reviewed by Dan Bernstein.
1589
1590         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1591
1592         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1593         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1594         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1595         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1596         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1597         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1598         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1599         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1600         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1601         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1602         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1603         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1604         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1605         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1606
1607 2015-08-13  Andy Estes  <aestes@apple.com>
1608
1609         [Cocoa] Downloads do not start if policy decision is made asynchronously
1610         https://bugs.webkit.org/show_bug.cgi?id=147985
1611
1612         Reviewed by Brady Eidson.
1613
1614         Added a new API test.
1615
1616         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1617         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1618         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1619         (TEST):
1620
1621 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1622
1623         Unreviewed, rolling out r187357.
1624         https://bugs.webkit.org/show_bug.cgi?id=148032
1625
1626         webkit-patch generates incorrect patches that cannot be
1627         applied (Requested by dydz on #webkit).
1628
1629         Reverted changeset:
1630
1631         "Call fixChangeLogPatch when generating patches from webkit-
1632         patch"
1633         https://bugs.webkit.org/show_bug.cgi?id=147248
1634         http://trac.webkit.org/changeset/187357
1635
1636 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1637
1638         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1639         other than "openSource" and "internal".
1640         https://bugs.webkit.org/show_bug.cgi?id=147938
1641
1642         Reviewed by Daniel Bates.
1643
1644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1645         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1646         repositories other than "openSource" and "internal".
1647
1648 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1649
1650         Unreviewed, shorten another test that is timing out.
1651
1652         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1653         (TestWebKitAPI::TEST):
1654
1655 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1656
1657         AppScale: Assertion hit when hovering a webkit-queue bubble
1658         https://bugs.webkit.org/show_bug.cgi?id=147997
1659
1660         Reviewed by Alexey Proskuryakov.
1661
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1663         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1664
1665 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1666
1667         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1668         
1669         Unreviewed.
1670         
1671         * Scripts/copy-webkitlibraries-to-product-directory:
1672
1673 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1674
1675         Run benchmark customized Dromaeo should not assume there is an internet connection.
1676         https://bugs.webkit.org/show_bug.cgi?id=147995
1677
1678         Reviewed by Ryosuke Niwa.
1679
1680         Add several dependency js libs to local.
1681
1682         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1683
1684 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1685
1686         WTF should have a compact Condition object to use with Lock
1687         https://bugs.webkit.org/show_bug.cgi?id=147986
1688
1689         Reviewed by Geoffrey Garen.
1690
1691         Add a test for WTF::Condition.
1692
1693         * TestWebKitAPI/CMakeLists.txt:
1694         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1696         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1697         (TestWebKitAPI::TEST):
1698         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1699         (TestWebKitAPI::runLockTest): Change the name of the thread.
1700
1701 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1702
1703         Unreviewed, shorten another test. It's timing out in debug on some bot.
1704
1705         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1706         (TestWebKitAPI::TEST):
1707
1708 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1709
1710         WTF::Lock should not suffer from the thundering herd
1711         https://bugs.webkit.org/show_bug.cgi?id=147947
1712
1713         Reviewed by Geoffrey Garen.
1714
1715         Add testing that checks that locks return to a pristine state after contention is over.
1716
1717         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1718         (TestWebKitAPI::LockInspector::isFullyReset):
1719         (TestWebKitAPI::runLockTest):
1720         (TestWebKitAPI::TEST):
1721
1722 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1723
1724         Benchmarks supported by run_benchmark script should not assume we have internet access.
1725         https://bugs.webkit.org/show_bug.cgi?id=147959
1726
1727         Reviewed by Ryosuke Niwa.
1728
1729         For JSBench we should not request jquery.min.js from google through the internet.
1730
1731         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1732
1733 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1734
1735         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1736         other than "openSource" and "internal".
1737         https://bugs.webkit.org/show_bug.cgi?id=147796
1738
1739         Reviewed by Daniel Bates.
1740
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1742         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1743         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1744         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1745         and another assertion that, if the previousIteration is non-null, the given repository is in
1746         previousIteration.revision.
1747         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1748         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1749         fragment has at least one child node.
1750
1751 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1752
1753         Add a tool that dumps class and struct member layout, showing padding
1754         https://bugs.webkit.org/show_bug.cgi?id=147898
1755
1756         Reviewed by Zalan Bujtas.
1757         
1758         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1759         about data member layout, and displays it.
1760         
1761         Sample output:
1762
1763               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1764               +0 < 56>     WebCore::URL m_value;
1765               +0 <  8>         WTF::String m_string;
1766               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1767               +0 <  8>                 WTF::StringImpl * m_ptr;
1768               +8 <  1>         bool:1 m_isValid;
1769               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1770               +9 <  3>         <PADDING>
1771              +12 <  4>         int m_schemeEnd;
1772              +16 <  4>         int m_userStart;
1773              +20 <  4>         int m_userEnd;
1774              +24 <  4>         int m_passwordEnd;
1775              +28 <  4>         int m_hostEnd;
1776              +32 <  4>         int m_portEnd;
1777              +36 <  4>         int m_pathAfterLastSlash;
1778              +40 <  4>         int m_pathEnd;
1779              +44 <  4>         int m_queryEnd;
1780              +48 <  4>         int m_fragmentEnd;
1781              +52 <  4>         <PADDING>
1782              +52 <  4>     <PADDING>
1783              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1784              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1785             Total byte size: 72
1786             Total pad bytes: 11
1787             Padding percentage: 15.28 %
1788
1789         * Scripts/dump-class-layout: Added.
1790         (webkit_build_dir):
1791         (developer_dir):
1792         (import_lldb):
1793         (find_build_directory):
1794         (verify_type):
1795         (verify_type_recursive):
1796         (dump_class):
1797         (main):
1798         (main.or):
1799
1800 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1801
1802         Fix Debug CMake builds on Windows
1803         https://bugs.webkit.org/show_bug.cgi?id=147940
1804
1805         Reviewed by Chris Dumez.
1806
1807         * DumpRenderTree/PlatformWin.cmake:
1808         * TestWebKitAPI/PlatformWin.cmake:
1809         The BitmapImage test is not enabled on the AppleWin port.
1810         * WinLauncher/CMakeLists.txt:
1811         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1812
1813 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1814
1815         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1816
1817         In r188125 I added a way to mark tests as slow to use a longer
1818         timeout. But it seems it was not enough for
1819         WTF_Lock.ContendedShortSection, so let's try again with a longer
1820         timeout now.
1821
1822         * Scripts/run-gtk-tests:
1823         (TestRunner._run_google_test):
1824
1825 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1826
1827         Allow --debug option in run-jsc
1828         https://bugs.webkit.org/show_bug.cgi?id=147923
1829
1830         Reviewed by Csaba Osztrogonác.
1831
1832         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1833
1834         * Scripts/run-jsc:
1835
1836 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1837
1838         Fix test after build fix in r188286.
1839         https://bugs.webkit.org/show_bug.cgi?id=147907
1840
1841         Reviewed by Anders Carlsson.
1842
1843         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1844         sleep_for can now be used, but we need to include <thread>
1845
1846 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1847
1848         Always use a byte-sized lock implementation
1849         https://bugs.webkit.org/show_bug.cgi?id=147908
1850
1851         Reviewed by Geoffrey Garen.
1852
1853         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1854         now tests of Lock.
1855
1856         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1857         (TestWebKitAPI::runLockTest):
1858         (TestWebKitAPI::TEST):
1859
1860 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1861
1862         Make ASan build not depend on asan.xcconfig
1863         https://bugs.webkit.org/show_bug.cgi?id=147840
1864         rdar://problem/21093702
1865
1866         Reviewed by Daniel Bates.
1867
1868         * asan/asan.xcconfig:
1869         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1870         are now marked in source code.
1871
1872 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1873
1874         Unreviewed, shorten another test since it timed out.
1875
1876         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1877         (TestWebKitAPI::TEST):
1878
1879 2015-08-11  Mark Lam  <mark.lam@apple.com>
1880
1881         Fix names of Lock tests: should be "Contended", not "Contented".
1882         https://bugs.webkit.org/show_bug.cgi?id=147905
1883
1884         Reviewed by Saam Barati.
1885
1886         We're testing the behavior of lock contention (i.e. when threads contend), not
1887         whether the locks are happy (contented).
1888
1889         * Scripts/run-gtk-tests:
1890         (TestRunner):
1891         (TestRunner.__init__): Deleted.
1892         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1893         (TestWebKitAPI::runLockTest):
1894         (TestWebKitAPI::TEST):
1895
1896 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1897
1898         Update WinCairoRequirements to VS2015.
1899
1900         * Scripts/update-webkit-wincairo-libs:
1901         Update WinCairoRequirements location.
1902
1903 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1904
1905         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1906         for internalTrac.
1907         https://bugs.webkit.org/show_bug.cgi?id=147805
1908
1909         Reviewed by Daniel Bates.
1910
1911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1912         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1913         Dashboard.Repository.Internal.trac for internalTrac.
1914         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1915         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1916         respectively.
1917         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1918         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1919         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1920         internalTrac.
1921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1924         (Analyzer): Ditto.
1925         (Analyzer.prototype.analyze): Ditto.
1926
1927 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1928
1929         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1930
1931         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1932         (TestWebKitAPI::TEST):
1933
1934 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1935
1936         [Win] Switch Windows build to Visual Studio 2015
1937         https://bugs.webkit.org/show_bug.cgi?id=147887
1938         <rdar://problem/22235098>
1939
1940         Reviewed by Alex Christensen.
1941
1942         Update Visual Studio project file settings to use the current Visual
1943         Studio and compiler. Continue targeting binaries to run on our minimum
1944         supported configuration of Windows 7.
1945
1946         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1947         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1948         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1949         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1950         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1951         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1952         prefer the newer MSBuild included in Visual Studio 2015.
1953         (visualStudioInstallDir):
1954         (msBuildInstallDir):
1955         (visualStudioVersion):
1956         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1957         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1958         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1959         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1960         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1961         * win/record-memory/record-memory.vcxproj:
1962
1963 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1964
1965         Another speculative build fix after r188280.
1966
1967         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1968         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1969         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1970
1971 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1972
1973         Unreviewed build fix after r188280.
1974
1975         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1976         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1977
1978 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1979
1980         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1981         https://bugs.webkit.org/show_bug.cgi?id=147665
1982
1983         Reviewed by Mark Lam.
1984
1985         * TestWebKitAPI/CMakeLists.txt:
1986         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1988         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1989         (TestWebKitAPI::TEST):
1990         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1991         (TestWebKitAPI::TEST):
1992
1993 2015-08-11  Brian Burg  <bburg@apple.com>
1994
1995         webkit-patch should not explode when $EDITOR is set incorrectly
1996         https://bugs.webkit.org/show_bug.cgi?id=147884
1997
1998         Reviewed by Darin Adler.
1999
2000         If $EDITOR doesn't exist, log a warning and continue.
2001
2002         * Scripts/webkitpy/common/system/user.py: 
2003         (User.edit):
2004         (User.edit_changelog):
2005
2006 2015-08-11  Dan Bernstein  <mitz@apple.com>
2007
2008         Reverted r188255, because it turned out that delegates do nonot need this information.
2009
2010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2011         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
2012
2013 2015-08-11  Dan Bernstein  <mitz@apple.com>
2014
2015         [Cocoa] The UI delegate can't tell if printing was user-initiated
2016         https://bugs.webkit.org/show_bug.cgi?id=147869
2017
2018         Reviewed by Sam Weinig.
2019
2020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2021         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
2022         (-[PrintFrameController webView:didFinishNavigation:]):
2023         (-[PrintFrameController _webView:printFrame:userInitiated:]):
2024         (TEST):
2025
2026 2015-08-10  Alex Christensen  <achristensen@webkit.org>
2027
2028         Another build fix after r188239.
2029
2030         * TestWebKitAPI/PlatformWin.cmake:
2031         Link with more libraries.
2032         * WinLauncher/CMakeLists.txt:
2033         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
2034
2035 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2036
2037         Build fix after r188237.
2038
2039         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2040         (BenchmarkBuilder.__enter__):
2041
2042 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
2043
2044         Update ReadMe and correct the way to use abstract abstract class.
2045         https://bugs.webkit.org/show_bug.cgi?id=147860
2046
2047         Reviewed by Ryosuke Niwa.
2048
2049         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
2050         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
2051
2052         * Scripts/webkitpy/benchmark_runner/README.md:
2053         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2054         (BrowserDriver):
2055         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2056         (OSXBrowserDriver.restore_env):
2057         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2058         (HTTPServerDriver):
2059         (HTTPServerDriver.set_device_id):
2060         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2061         (SimpleHTTPServerDriver.get_return_code):
2062         (SimpleHTTPServerDriver):
2063         (SimpleHTTPServerDriver.set_device_id):
2064
2065 2015-08-10  Alex Christensen  <achristensen@webkit.org>
2066
2067         Build TestWebKitAPI with CMake on Windows
2068         https://bugs.webkit.org/show_bug.cgi?id=147851
2069
2070         Reviewed by Chris Dumez.
2071
2072         * CMakeLists.txt:
2073         * TestWebKitAPI/CMakeLists.txt:
2074         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
2075         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
2076         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
2077         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
2078         * TestWebKitAPI/PlatformEfl.cmake:
2079         * TestWebKitAPI/PlatformGTK.cmake:
2080         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
2081         I did this without changing the directory structure of the existing EFL and GTK builds.
2082         * TestWebKitAPI/PlatformWin.cmake: Added.
2083         * TestWebKitAPI/win/main.cpp:
2084         (main):
2085         (dllLauncherEntryPoint):
2086         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
2087         * WinLauncher/CMakeLists.txt:
2088         AppleWin port needs /NODEFAULTLIB:MSVCRT.
2089
2090 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
2091
2092         Make cleanup more robust and minor code cleaning in run benchmark script.
2093         https://bugs.webkit.org/show_bug.cgi?id=147800
2094
2095         Reviewed by Ryosuke Niwa.
2096
2097         Use 'finnaly' block to make sure cleanup code is always executed.
2098
2099         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2100         (built_benchmark):
2101         (built_benchmark.__init__):
2102         (built_benchmark.__enter__):
2103         (built_benchmark.__exit__):
2104         (test_environment):
2105         (test_environment.__init__):
2106         (test_environment.__enter__):
2107         (test_environment.__exit__):
2108         (BenchmarkRunner.__init__):
2109         (BenchmarkRunner.execute):
2110         (BenchmarkRunner._dump):
2111         (BenchmarkRunner._wrap):
2112         (BenchmarkRunner): Deleted.
2113         (BenchmarkRunner._cleanup): Deleted.
2114         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2115         (BrowserDriver.close_browsers):
2116         (BrowserDriver):
2117         (BrowserDriver.restore_env):
2118         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2119         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
2120
2121 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2122
2123         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
2124         https://bugs.webkit.org/show_bug.cgi?id=146414
2125
2126         Reviewed by Darin Adler.
2127
2128         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2129         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
2130
2131 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2132
2133         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
2134         https://bugs.webkit.org/show_bug.cgi?id=147727
2135
2136         Reviewed by Sergio Villar Senin.
2137
2138         I think it was not this test in particular, but
2139         /webkit2/WebKitWebView/custom-charset that is affecting the
2140         others. This is because changing the encoding reloads the page,
2141         but we don't wait for the page to be reloaded, so when the test
2142         finishes and other test starts the web process is still reloading
2143         the page.
2144
2145         * Scripts/run-gtk-tests:
2146         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
2147         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2148         (testWebViewCustomCharset): Wait until page is reloaded after
2149         changing the charset.
2150
2151 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2152
2153         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
2154
2155         It's timing out in the bots. My guess is that there's no installer
2156         installed in the bots and gst_install_plugins_supported() returns
2157         false, so we don't even get a permission request because no
2158         installer will be launched.
2159
2160         * Scripts/run-gtk-tests:
2161         (TestRunner):
2162
2163 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2164
2165         [GTK] Another build fix after r188157.
2166
2167         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2168         (WTR::PlatformWebView::viewSupportsOptions):
2169         Name all the things correctly!
2170
2171 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2172
2173         [EFL, GTK] Build fix after r188176.
2174
2175         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2176         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
2177
2178 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2179
2180         [GTK] Speculative build fix after r188157.
2181
2182         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2183         (WTR::PlatformWebView::PlatformWebView):
2184         Update parameter list.
2185
2186 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2187
2188         Build more testing binaries with CMake on Windows
2189         https://bugs.webkit.org/show_bug.cgi?id=147799
2190
2191         Reviewed by Brent Fulgham.
2192
2193         * DumpRenderTree/CMakeLists.txt:
2194         Build TestNetscapePlugin.
2195         * DumpRenderTree/PlatformWin.cmake:
2196         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
2197         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
2198         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
2199         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
2200         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
2201         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
2202         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
2203         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2204         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
2205
2206 2015-08-07  Jason Marcell  <jmarcell@apple.com>
2207
2208         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
2209         https://bugs.webkit.org/show_bug.cgi?id=147667
2210
2211         Reviewed by Daniel Bates.
2212
2213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2214         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
2215         other than "openSource" and "internal".
2216         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2218         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
2219         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2221         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2222         (sortedPlatforms): Deleted.
2223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2224         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2225         (sortedPlatforms): Deleted.
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2227         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2228         and sorts them by this property returning the new sorted array.
2229
2230 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
2231
2232         Lightweight locks should be adaptive
2233         https://bugs.webkit.org/show_bug.cgi?id=147545
2234
2235         Reviewed by Geoffrey Garen.
2236
2237         * TestWebKitAPI/CMakeLists.txt:
2238         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2240         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2241         (TestWebKitAPI::runLockTest):
2242         (TestWebKitAPI::TEST):
2243
2244 2015-08-07  Anders Carlsson  <andersca@apple.com>
2245
2246         Fix a tyop.
2247
2248         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2249         (WTR::PlatformWebView::viewSupportsOptions):
2250
2251 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2252
2253         Update AppEngine app version numbers to the latest commit.
2254
2255         * QueueStatusServer/app.yaml:
2256         * TestResultServer/app.yaml:
2257
2258 2015-08-07  Anders Carlsson  <andersca@apple.com>
2259
2260         Simplify WKTR's view options
2261         https://bugs.webkit.org/show_bug.cgi?id=147791
2262
2263         Reviewed by Sam Weinig.
2264
2265         Instead of using a WKDictionaryRef, just use a struct for the options.
2266
2267         * WebKitTestRunner/PlatformWebView.h:
2268         (WTR::PlatformWebView::options):
2269         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2270         * WebKitTestRunner/TestController.cpp:
2271         (WTR::TestController::initialize):
2272         (WTR::TestController::createWebViewWithOptions):
2273         (WTR::TestController::ensureViewSupportsOptions):
2274         (WTR::TestController::updateLayoutTypeForTest):
2275         * WebKitTestRunner/TestController.h:
2276         * WebKitTestRunner/ViewOptions.h: Added.
2277         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2278         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2279         (WTR::PlatformWebView::PlatformWebView):
2280         (WTR::PlatformWebView::viewSupportsOptions):
2281         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2282         (WTR::PlatformWebView::viewSupportsOptions):
2283         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2284         (WTR::PlatformWebView::viewSupportsOptions):
2285         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2286         (WTR::PlatformWebView::PlatformWebView):
2287         (WTR::PlatformWebView::viewSupportsOptions):
2288         * WebKitTestRunner/mac/TestControllerMac.mm:
2289         (WTR::TestController::platformConfigureViewForTest):
2290
2291 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2292
2293         Running tests for a long time results in some tests running very slowly (throttling)
2294         https://bugs.webkit.org/show_bug.cgi?id=147718
2295
2296         Reviewed by Chris Dumez.
2297
2298         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2299         Although COCOA ports default this setting to be disabled in WebKit1,
2300         we should make both test harnesses disable the setting for consistency.
2301
2302         * DumpRenderTree/mac/DumpRenderTree.mm:
2303         (resetWebPreferencesToConsistentValues):
2304
2305 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2306
2307         Use a specific version of Speedometer in run-benchmark
2308         https://bugs.webkit.org/show_bug.cgi?id=147769
2309
2310         Reviewed by Chris Dumez.
2311
2312         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2313
2314         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2315
2316 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2317
2318         twisted_http_server.py should support --port
2319         https://bugs.webkit.org/show_bug.cgi?id=147771
2320
2321         Reviewed by Chris Dumez.
2322
2323         Added the option. This makes the script more useful on its own.
2324
2325         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2326
2327 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2328
2329         [GTK] WTF unit tests are timing out in the bots
2330         https://bugs.webkit.org/show_bug.cgi?id=147777
2331
2332         Reviewed by Filip Pizlo.
2333
2334         Add a way to mark google unit tests as slow and add
2335         WTF_Lock.ContentedShortSection to the list. In case of slow test
2336         we use the double of the given timeout for that particular test.
2337
2338         * Scripts/run-gtk-tests:
2339         (TestRunner):
2340         (TestRunner._run_google_test):
2341
2342 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2343
2344         [GTK] run-gtk-tests should not stop when a google test case fails
2345         https://bugs.webkit.org/show_bug.cgi?id=147778
2346
2347         Reviewed by Philippe Normand.
2348
2349         For glib based tests we run the test runner with the -k option,
2350         but for google tests we are aborting as soon as we find a failure.
2351
2352         * Scripts/run-gtk-tests:
2353         (TestRunner._run_google_test_suite): Use a global return code that
2354         is set to 1 when any test has failed.
2355
2356 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2357
2358         [GStreamer] Do not automatically show PackageKit codec installation notifications
2359         https://bugs.webkit.org/show_bug.cgi?id=135973
2360
2361         Reviewed by Philippe Normand.
2362
2363         Handle the missing media plugins installation permission request
2364         in MiniBrowser and add a test case for the new API.
2365
2366         * MiniBrowser/gtk/BrowserWindow.c:
2367         (webViewDecidePermissionRequest):
2368         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2369         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2370         (permissionRequestCallback):
2371         (testInstallMissingPluginsPermissionRequest):
2372         (beforeAll):
2373         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2374         (methodCallCallback):
2375
2376 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2377
2378         Running tests for a long time results in some tests running very slowly (throttling)
2379         https://bugs.webkit.org/show_bug.cgi?id=147718
2380
2381         Reviewed by Alexey Proskuryakov.
2382
2383         * WebKitTestRunner/TestController.cpp:
2384         (WTR::TestController::resetPreferencesToConsistentValues):
2385         Ensure throttling settings are disabled for tests for all ports, as
2386         COCOA ports default to having these setting enabled. Note, there is
2387         still other timer throttling not covered by these setting.
2388
2389 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2390
2391         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2392         https://bugs.webkit.org/show_bug.cgi?id=147752
2393
2394         Reviewed by Chris Dumez.
2395
2396         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2397
2398         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2399         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2400
2401         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2402         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2403         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2404         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2405         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2406         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2407         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2408         HTTPServerDriverFactory taking the platform name as an argument.
2409         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2410         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2411         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2412         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2413         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2414         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2415         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2416         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2417         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2418         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2419         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2420         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2421         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2422         (HTTPServerDriver): Replaced name by platforms.
2423         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2424         (SimpleHTTPServerDriver): Ditto.
2425         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2426         (parse_args): Removed --http-server-driver option.
2427         (start): Ditto.
2428
2429 2015-08-06  Chris Dumez  <cdumez@apple.com>
2430
2431         Toggle GPS state based on page visibility to save battery
2432         https://bugs.webkit.org/show_bug.cgi?id=147685
2433
2434         Reviewed by Benjamin Poulain.
2435
2436         Add testRunner.isGeolocationProviderActive() test support function.
2437
2438         * DumpRenderTree/TestRunner.cpp:
2439         (isGeolocationProviderActiveCallback):
2440         (TestRunner::staticFunctions):
2441         * DumpRenderTree/TestRunner.h:
2442         * DumpRenderTree/mac/MockGeolocationProvider.h:
2443         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2444         (-[MockGeolocationProvider isActive]):
2445         * DumpRenderTree/mac/TestRunnerMac.mm:
2446         (TestRunner::isGeolocationProviderActive):
2447         * DumpRenderTree/win/TestRunnerWin.cpp:
2448         (TestRunner::isGeolocationProviderActive):
2449         * WebKitTestRunner/GeolocationProviderMock.h:
2450         (WTR::GeolocationProviderMock::isActive):
2451         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2452         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2453         (WTR::InjectedBundle::isGeolocationProviderActive):
2454         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2455         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2456         (WTR::TestRunner::isGeolocationProviderActive):
2457         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2458         * WebKitTestRunner/TestController.cpp:
2459         (WTR::TestController::isGeolocationProviderActive):
2460         * WebKitTestRunner/TestController.h:
2461         * WebKitTestRunner/TestInvocation.cpp:
2462         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2463
2464 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2465
2466         Automate JSBench with run-benchmark
2467         https://bugs.webkit.org/show_bug.cgi?id=147716
2468
2469         Reviewed by Chris Dumez.
2470
2471         Added JSBench plan to run-benchmark.
2472
2473         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2474         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2475         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2476         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2477         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2478         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2479         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2480         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2481         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2482         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2483         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2484         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2485         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2486         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2487         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2488         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2489
2490 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2491
2492         Pass-through the undefined options in run-jsc
2493         https://bugs.webkit.org/show_bug.cgi?id=147717
2494
2495         Undefined options in run-jsc is just passed to the actual jsc shell.
2496         We can execute `Tools/Scripts/run-jsc -d`.
2497
2498         Reviewed by Csaba Osztrogonác.
2499
2500         * Scripts/run-jsc:
2501
2502 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2503
2504         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2505
2506         It's flaky.
2507
2508         * Scripts/run-gtk-tests:
2509         (TestRunner):
2510
2511 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2512
2513         [EFL] Bump EFL version to 1.15.0
2514         https://bugs.webkit.org/show_bug.cgi?id=147450
2515
2516         Reviewed by Gyuyoung Kim.
2517
2518         * efl/jhbuild.modules:
2519
2520 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2521
2522         Unreviewed. Unksip TestContextMenu GTK+ API test.
2523
2524         This has been skipped for a long time, and it's very
2525         unconvenient. It has never failed for me locally, so let's try
2526         again to see if it works in the bots. I'll skip it again if it
2527         keeps failing.
2528
2529         * Scripts/run-gtk-tests:
2530         (TestRunner):
2531
2532 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2533
2534         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2535
2536         * DumpRenderTree/JavaScriptThreading.cpp:
2537         (javaScriptThreadsMutex):
2538         (runJavaScriptThread):
2539         (startJavaScriptThreads):
2540         (stopJavaScriptThreads):
2541         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2542         (TestWebKitAPI::TEST):
2543         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2544         (TestWebKitAPI::TEST):
2545
2546 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2547
2548         Build DumpRenderTree with CMake.
2549         https://bugs.webkit.org/show_bug.cgi?id=147519
2550
2551         Reviewed by Brent Fulgham.
2552
2553         * CMakeLists.txt:
2554         Build the DumpRenderTree directory now that it builds successfully.
2555         * DumpRenderTree/CMakeLists.txt:
2556         Added missing source file and don't link with WebCore.lib.
2557         * DumpRenderTree/PlatformWin.cmake:
2558         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2559         * WinLauncher/CMakeLists.txt:
2560         We need libcmt now that we are not linking with WebCore.lib.
2561
2562 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2563
2564         AppScale: Use https URLs for subresources and links
2565         https://bugs.webkit.org/show_bug.cgi?id=147686
2566
2567         Reviewed by Ryosuke Niwa.
2568
2569         * QueueStatusServer/filters/webkit_extras.py:
2570         * TestResultServer/static-dashboards/dashboard_base.js:
2571         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2572         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2573         * TestResultServer/static-dashboards/treemap.js:
2574         * TestResultServer/static-dashboards/ui.js:
2575
2576 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2577
2578         Rename Mutex to DeprecatedMutex
2579         https://bugs.webkit.org/show_bug.cgi?id=147675
2580
2581         Reviewed by Geoffrey Garen.
2582
2583         * DumpRenderTree/JavaScriptThreading.cpp:
2584         (javaScriptThreadsMutex):
2585         (runJavaScriptThread):
2586         (startJavaScriptThreads):
2587         (stopJavaScriptThreads):
2588         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2589         (TestWebKitAPI::TEST):
2590         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2591         (TestWebKitAPI::TEST):
2592
2593 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2594
2595         Update the WebKit nightly icon
2596         https://bugs.webkit.org/show_bug.cgi?id=147684
2597
2598         Reviewed by Sam Weinig.
2599
2600         * WebKitLauncher/webkit.icns: Replaced.
2601
2602 2015-08-05  Daniel Bates  <dabates@apple.com>
2603
2604         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2605         https://bugs.webkit.org/show_bug.cgi?id=147678
2606         <rdar://problem/21827815>
2607
2608         Reviewed by Brady Eidson.
2609
2610         Add a test to ensure that we restore the "should open external URLs" policy on
2611         page reload after the web content process crashes.
2612
2613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2614         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2615         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2616         (TEST):
2617
2618 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2619
2620         [EFL] Editing tests have been broken since r186694
2621         https://bugs.webkit.org/show_bug.cgi?id=146888
2622
2623         Reviewed by Brent Fulgham.
2624
2625         Restored some codes for the context click on GTK+ and EFL port.
2626
2627         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2628         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2629
2630 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2631
2632         Install twisted package for http server when necessary.
2633         https://bugs.webkit.org/show_bug.cgi?id=147082
2634
2635         Reviewed by Ryosuke Niwa.
2636
2637         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2638         * Scripts/webkitpy/thirdparty/__init__.py:
2639         (AutoinstallImportHook.find_module):
2640         (AutoinstallImportHook._install_twisted):
2641
2642 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2643
2644         [Win] Update Apple Windows build for VS2015
2645         https://bugs.webkit.org/show_bug.cgi?id=147653
2646
2647         Reviewed by Dean Jackson.
2648
2649         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2650         something older than VS2015, define snprintf as _snprintf.
2651         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2652         Remove unneeded macro definition for snprintf.
2653         * Scripts/webkitpy/common/system/platforminfo.py:
2654         (PlatformInfo._determine_win_version): Recognize Windows 10.
2655         * Scripts/webkitpy/port/win.py:
2656         (WinPort): Ditto.
2657         * Scripts/webkitpy/port/win_unittest.py:
2658         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2659         (WinPortTest._assert_version): Ditto.
2660
2661 2015-08-04  Brian Burg  <bburg@apple.com>
2662
2663         Unreviewed, update email addresses in contributors.json and watchlist.
2664
2665         * Scripts/webkitpy/common/config/contributors.json:
2666         * Scripts/webkitpy/common/config/watchlist:
2667
2668 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2669
2670         Implement NPAPI redirect handling
2671         https://bugs.webkit.org/show_bug.cgi?id=138675
2672         rdar://problem/15779101
2673
2674         Patch by Jeffrey Pfau, updated and tweaked by me.
2675
2676         Reviewed by Anders Carlsson.
2677
2678         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2679         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2680         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2681         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2682         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2683         (PluginTest::NPP_URLNotify):
2684         (PluginTest::NPP_URLRedirectNotify):
2685         (PluginTest::NPP_GetValue):
2686         (PluginTest::NPN_GetURLNotify):
2687         (PluginTest::NPN_PostURLNotify):
2688         (PluginTest::NPN_GetValue):
2689         (PluginTest::NPN_ReleaseVariantValue):
2690         (PluginTest::NPN_URLRedirectResponse):
2691         (PluginTest::NPN_ConvertPoint):
2692         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2693         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2694         (URLRedirect::URLRedirect):
2695         (URLRedirect::ScriptableObject::hasMethod):
2696         (URLRedirect::ScriptableObject::get):
2697         (URLRedirect::ScriptableObject::serviceAsync):
2698         (URLRedirect::ScriptableObject::invoke):
2699         (URLRedirect::NPP_GetValue):
2700         (URLRedirect::NPP_URLNotify):
2701         (URLRedirect::NPP_URLRedirectNotify):
2702         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2703         (NP_GetEntryPoints):
2704         (NPP_URLNotify):
2705         (NPP_URLRedirectNotify):
2706         (NPP_GetValue):
2707
2708 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2709
2710         Move Matt Daiter to committers.
2711
2712         * Scripts/webkitpy/common/config/contributors.json:
2713
2714 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2715
2716         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2717         https://bugs.webkit.org/show_bug.cgi?id=147636
2718
2719         Reviewed by Alex Christensen.
2720         
2721         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2722         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2723         on EWS machines)
2724
2725         * Scripts/build-webkit:
2726
2727 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2728
2729         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2730         https://bugs.webkit.org/show_bug.cgi?id=147280
2731
2732         Reviewed by Daniel Bates.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2735         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2736         Refactored _parseData to handle repositories more generically.
2737         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2739         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2740         "opensourceRevision" and "internalRevision".
2741         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2743         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2744         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2745         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2746         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2747         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2748         and "internalRevision".
2749         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2750         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2751         "opensourceRevision" and "internalRevision".
2752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2753         constants for internal and opensource repositories.
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2755         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2756         instead of "opensourceRevision" and "internalRevision".
2757         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2758         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2759         (Analyzer.prototype._countTimes): Ditto.
2760         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2761         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2762
2763 2015-08-04  Mark Lam  <mark.lam@apple.com>
2764
2765         Removed a local debugging line I accidentally left in from a previous commit.
2766
2767         Not Reviewed.
2768
2769         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2770
2771 2015-08-04  Mark Lam  <mark.lam@apple.com>
2772
2773         Unreviewed. Make Saam Barati a WebKit reviewer.
2774
2775         * Scripts/webkitpy/common/config/contributors.json:
2776
2777 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2778
2779         Unreviewed, updated Streams API watchlist.
2780
2781         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2782
2783 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2784
2785         [CMake] Add an option to build AllInOne files
2786         https://bugs.webkit.org/show_bug.cgi?id=102647
2787
2788         Reviewed by Alex Christensen.
2789
2790         * Scripts/webkitperl/FeatureList.pm:
2791
2792 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2793
2794         AppScale: Add required indices
2795         https://bugs.webkit.org/show_bug.cgi?id=147593
2796
2797         Reviewed by Tim Horton.
2798
2799         * QueueStatusServer/index.yaml:
2800
2801 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2802
2803         Check in LLVM 3.6.2 binary drops for El Capitan
2804         https://bugs.webkit.org/show_bug.cgi?id=147582
2805
2806         Reviewed by Alexey Proskuryakov.
2807         
2808         Recognize 10.11 and use the right drops.
2809
2810         * Scripts/copy-webkitlibraries-to-product-directory:
2811
2812 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2813
2814         [Win] Build fix after r187733.
2815
2816         * WinLauncher/PageLoadTestClient.cpp:
2817         (PageLoadTestClient::dumpRunStatistics):
2818         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2819
2820 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2821
2822         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2823         https://bugs.webkit.org/show_bug.cgi?id=118455
2824
2825         Reviewed by Filip Pizlo.
2826
2827         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2828         (TestWebKitAPI::TEST):
2829
2830 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2831
2832         Prepare for VS2015
2833         https://bugs.webkit.org/show_bug.cgi?id=146579
2834
2835         Reviewed by Jon Honeycutt.
2836
2837         * WinLauncher/stdafx.h:
2838         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2839
2840 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2841
2842         [EFL] Fix pixman build on ARM with GCC 4.9.3
2843         https://bugs.webkit.org/show_bug.cgi?id=147224
2844
2845         Reviewed by Gyuyoung Kim.
2846
2847         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2848
2849 2015-07-30  Anders Carlsson  <andersca@apple.com>
2850
2851         Add support for window.open to WK1BrowserWindowController
2852         https://bugs.webkit.org/show_bug.cgi?id=147474
2853
2854         Reviewed by Dan Bernstein.
2855
2856         * MiniBrowser/mac/WK1BrowserWindowController.m:
2857         (-[WK1BrowserWindowController awakeFromNib]):
2858         Set javaScriptCanOpenWindowsAutomatically to YES. 
2859         If this becomes a nuisance, we can always add a menu item to toggle this.
2860
2861         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2862         Implement this UI delegate method.
2863
2864 2015-07-30  Anders Carlsson  <andersca@apple.com>
2865
2866         Undo stray commit.
2867
2868         * MiniBrowser/mac/WK1BrowserWindowController.m:
2869         (-[WK1BrowserWindowController awakeFromNib]):
2870         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2871
2872 2015-07-29  Dean Jackson  <dino@apple.com>
2873
2874         Don't use (Details) when exposing SPI
2875         https://bugs.webkit.org/show_bug.cgi?id=147426
2876         <rdar://problem/22062407>
2877
2878         Reviewed by Dan Bernstein.
2879
2880         If we are declaring the interface without any implementation,
2881         we should use class extensions.
2882
2883         * DumpRenderTree/mac/DumpRenderTree.mm:
2884         * DumpRenderTree/mac/EventSendingController.mm:
2885         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2886         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2887         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2888         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2889         * WebKitTestRunner/mac/TestControllerMac.mm:
2890
2891 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2892
2893         Replace Google App Engine with AppScale
2894         https://bugs.webkit.org/show_bug.cgi?id=147178
2895
2896         Reviewed by Daniel Bates.
2897
2898         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2899         (RunWebKitTests):
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2905         (.):
2906         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2907         (BubbleQueueServer):
2908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2909         (TestHistory):
2910         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2911         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2912         * TestResultServer/app.yaml: Ditto
2913         * Scripts/webkitpy/common/config/urls.py:
2914         * TestResultServer/main.py:
2915         * TestResultServer/static-dashboards/dashboard_base.js:
2916         * TestResultServer/static-dashboards/loader.js:
2917
2918 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2919
2920         [EFL] Enable IndexedDB based on DatabaseProcess
2921         https://bugs.webkit.org/show_bug.cgi?id=147221
2922
2923         Reviewed by Csaba Osztrogonác.
2924
2925         * Scripts/webkitperl/FeatureList.pm:
2926
2927 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2928
2929         Build AppleWin port with CMake
2930         https://bugs.webkit.org/show_bug.cgi?id=147385
2931
2932         Reviewed by Martin Robinson.
2933
2934         * WinLauncher/CMakeLists.txt:
2935         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2936
2937 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2938
2939         Implement basic types for ECMAScript Internationalization API
2940         https://bugs.webkit.org/show_bug.cgi?id=146926
2941
2942         Reviewed by Benjamin Poulain.
2943
2944         Enable flag now that the basic objects are in place.
2945
2946         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2947
2948 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2949
2950         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2951         https://bugs.webkit.org/show_bug.cgi?id=147108
2952
2953         Reviewed by Gustavo Noronha Silva.
2954
2955         Add test case to check the web process limit.
2956
2957         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2958         (testWebProcessLimit):
2959         (beforeAll):
2960
2961 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2962
2963         [GTK] Missing casts in BrowserWindow.c
2964         https://bugs.webkit.org/show_bug.cgi?id=147395
2965
2966         Reviewed by Carlos Garcia Campos.
2967
2968         * MiniBrowser/gtk/BrowserWindow.c:
2969         (browserWindowSetupEditorToolbar):
2970
2971 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2972
2973         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2974         https://bugs.webkit.org/show_bug.cgi?id=147350
2975
2976         Reviewed by Sam Weinig.
2977
2978         * Scripts/webkitperl/FeatureList.pm:
2979
2980 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2981
2982         [Freetype] Always allow font matching for strong aliases
2983         https://bugs.webkit.org/show_bug.cgi?id=147057
2984
2985         Reviewed by Martin Robinson.
2986
2987         Create family aliases needed for the new layout tests.
2988
2989         * WebKitTestRunner/gtk/fonts/fonts.conf:
2990
2991 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2992
2993         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2994         https://bugs.webkit.org/show_bug.cgi?id=147359
2995
2996         Reviewed by Ryosuke Niwa.
2997
2998         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2999         (NewCommitBot.begin_work_queue):
3000         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3001         (SheriffBot.begin_work_queue):
3002
3003 2015-07-27  Alex Christensen  <achristensen@webkit.org>
3004
3005         Use Ninja on Windows.
3006         https://bugs.webkit.org/show_bug.cgi?id=147228
3007
3008         Reviewed by Martin Robinson.
3009
3010         * WinLauncher/CMakeLists.txt:
3011         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
3012         * Scripts/build-webkit:
3013         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
3014
3015 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
3016
3017         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
3018         highlight after being tapped to style a selection"
3019         https://bugs.webkit.org/show_bug.cgi?id=147278
3020
3021         Reviewed by Ryosuke Niwa.
3022
3023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3024
3025         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
3026         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
3027         (TestWebKitAPI::TEST):
3028         Load a page with the string "Hello, world!", then select "world" and
3029         underline it. Test that the typing attributes for the current selection
3030         include the underline attribute.
3031
3032 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3033
3034         Unreviewed, updated my nick name in contributors.json
3035
3036         * Scripts/webkitpy/common/config/contributors.json:
3037
3038 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
3039
3040         AX: scrollable elements do not allow 3-finger swipe
3041         https://bugs.webkit.org/show_bug.cgi?id=141893
3042
3043         Reviewed by Mario Sanchez Prada.
3044
3045         Support global notification listeners for iOS code.
3046         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
3047         Implement scrollUp/Down/Left/Right.
3048
3049         * DumpRenderTree/AccessibilityController.h:
3050         * DumpRenderTree/AccessibilityUIElement.cpp:
3051         (increaseTextSelectionCallback):
3052         (scrollPageUpCallback):
3053         (scrollPageDownCallback):
3054         (scrollPageLeftCallback):
3055         (scrollPageRightCallback):
3056         (decreaseTextSelectionCallback):
3057         (getElementTextLengthCallback):
3058         (AccessibilityUIElement::getJSClass):
3059         * DumpRenderTree/AccessibilityUIElement.h:
3060         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3061         (AccessibilityController::~AccessibilityController):
3062         (AccessibilityController::elementAtPoint):
3063         (AccessibilityController::addNotificationListener):
3064         (AccessibilityController::platformResetToConsistentState):
3065         (AccessibilityController::removeNotificationListener):
3066         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3067         (AccessibilityUIElement::AccessibilityUIElement):
3068         (AccessibilityUIElement::subrole):
3069         (AccessibilityUIElement::scrollPageUp):
3070         (AccessibilityUIElement::scrollPageDown):
3071         (AccessibilityUIElement::scrollPageLeft):
3072         (AccessibilityUIElement::scrollPageRight):
3073         (AccessibilityUIElement::roleDescription):
3074         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3075         (-[AccessibilityNotificationHandler _notificationReceived:]):
3076         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3077         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3078         (WTR::AccessibilityUIElement::linkedElement):
3079         (WTR::AccessibilityUIElement::headerElementAtIndex):
3080         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3081         (WTR::AccessibilityUIElement::scrollPageUp):
3082         (WTR::AccessibilityUIElement::scrollPageDown):
3083         (WTR::AccessibilityUIElement::scrollPageLeft):
3084         (WTR::AccessibilityUIElement::scrollPageRight):
3085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3086         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3087         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3088         (WTR::AccessibilityController::addNotificationListener):
3089         (WTR::AccessibilityController::removeNotificationListener):
3090         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3091         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3092         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3093         (WTR::AccessibilityUIElement::scrollPageUp):
3094         (WTR::AccessibilityUIElement::scrollPageDown):
3095         (WTR::AccessibilityUIElement::scrollPageLeft):
3096         (WTR::AccessibilityUIElement::scrollPageRight):
3097         (WTR::AccessibilityUIElement::increaseTextSelection):
3098
3099 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
3100
3101         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
3102         https://bugs.webkit.org/show_bug.cgi?id=147279
3103         <rdar://problem/21990767>
3104
3105         Reviewed by Dean Jackson.
3106
3107         * DumpRenderTree/win/TestRunnerWin.cpp:
3108         (TestRunner::addUserScript):
3109         (TestRunner::addUserStyleSheet):
3110         (TestRunner::setDeveloperExtrasEnabled):
3111
3112 2015-07-24  Basile Clement  <basile_clement@apple.com>
3113
3114         Call fixChangeLogPatch when generating patches from webkit-patch
3115         https://bugs.webkit.org/show_bug.cgi?id=147248
3116
3117         Reviewed by Geoffrey Garen.
3118
3119         When two consecutive patches are from the same author, diff tools
3120         create wrong-looking diffs for ChangeLog files where the apparent added
3121         author is actually the previous patch's author line, making it awkward
3122         to read - and things only get worse when committing a patch and a
3123         followup fix for the same bug shortly after.
3124
3125         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
3126         this, which we use in perl scripts (svn-create-patch et al). But it is
3127         not used by webkit-patch, which is a python script, and thus creates
3128         "bad" diffs.
3129
3130         In the long term, we should probably port fixChangeLogPatch to python -
3131         but in the short term, let's make webkit-patch call perl to run
3132         fixChangeLogPatch. We are already making various external calls there
3133         anyway.
3134
3135         * Scripts/webkitpy/common/checkout/scm/git.py:
3136         (Git.create_patch):
3137         * Scripts/webkitpy/common/checkout/scm/scm.py:
3138         (SCM.fix_changelog_patch):
3139         * Scripts/webkitpy/common/checkout/scm/svn.py:
3140         (SVN.create_patch):
3141
3142 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
3143
3144         commit-queue flags in webkit-patch are confusing
3145         https://bugs.webkit.org/show_bug.cgi?id=88694
3146
3147         Reviewed by Csaba Osztrogonác.
3148
3149         * Scripts/webkitpy/tool/steps/options.py:
3150         (Options): Updated help string to be more descriptive.
3151
3152 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
3153
3154         [Win] Implement proper High DPI support features
3155         https://bugs.webkit.org/show_bug.cgi?id=146335
3156         <rdar://problem/21558269>
3157
3158         Reviewed by Alex Christensen.
3159
3160         Update WinLauncher to take device scaling factor into account.
3161
3162         * WinLauncher/Common.cpp:
3163         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
3164         a valid font.
3165         (computeFullDesktopFrame): Handle high DPI desktops.
3166         (WndProc): Make comments more precise.
3167         * WinLauncher/WinLauncher.cpp:
3168         (WinLauncher::init): Determine device scale factor at launch.
3169         (WinLauncher::updateDeviceScaleFactor): Added.
3170         * WinLauncher/WinLauncher.h:
3171         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
3172         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
3173         (wWinMain): Ditto.
3174         * win/DLLLauncher/DLLLauncherMain.cpp:
3175         (wWinMain): Tell Windows we understand high DPI.
3176
3177 2015-07-23  Alex Christensen  <achristensen@webkit.org>
3178
3179         [Win] Unreviewed build fix after r187169.
3180
3181         * Scripts/build-webkit:
3182         Correctly find WebKit.sln.
3183
3184 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3185
3186         [GTK] Add API to allow executing editing commands that require an argument
3187         https://bugs.webkit.org/show_bug.cgi?id=146781
3188
3189         Reviewed by Gustavo Noronha Silva.
3190
3191         Add buttons to insert image/link to the MiniBrowser edit toolbar,
3192         and test cases for insert image/link commands too.
3193
3194         * MiniBrowser/gtk/BrowserWindow.c:
3195         (insertImageCommandCallback):
3196         (insertLinkCommandCallback):
3197         (browserWindowSetupEditorToolbar):
3198         (browserWindowConstructed):
3199         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3200         (testWebViewEditorInsertImage):
3201         (testWebViewEditorCreateLink):
3202         (beforeAll):
3203
3204 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3205
3206         Unregistering and re-registering a user message handler does not work
3207         https://bugs.webkit.org/show_bug.cgi?id=138142
3208
3209         Reviewed by Martin Robinson.
3210
3211         This has probably been fixed in r184846, enable the test case
3212         blocked on it.
3213
3214         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3215         (testUserContentManagerScriptMessageReceived):
3216
3217 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
3218
3219         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
3220         https://bugs.webkit.org/show_bug.cgi?id=147212
3221
3222         Reviewed by Filip Pizlo.
3223
3224         * Scripts/webkitperl/FeatureList.pm:
3225
3226 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
3227
3228         Add --ios-simulator to run-api-tests --help.
3229
3230         Rubber-stamped by Dan Bates.
3231
3232         * Scripts/run-api-tests:
3233
3234 2015-07-22  Jason Marcell  <jmarcell@apple.com>
3235
3236         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
3237         https://bugs.webkit.org/show_bug.cgi?id=147043
3238
3239         Reviewed by Daniel Bates and Alexey Proskuryakov.
3240
3241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3242         (Buildbot.prototype._normalizeQueueInfo):
3243         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
3244         in cases where the queue.branch property is not set and the queue is not a combined queue.
3245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3246         (BuildbotCombinedQueueView):
3247         Ensuring uniformity of repository branches within a combined queue.
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3249         (WebKitBuildbot.prototype.get defaultBranches):
3250         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
3251         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
3252         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
3253         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
3254         implement defaultBranches so that a person can either update the definition of the sub-queue or
3255         implement defaultBranches in the derived Buildbot class they are using.
3256
3257 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3258
3259         Switch WinCairo build to use CMake.
3260         https://bugs.webkit.org/show_bug.cgi?id=147169
3261
3262         Reviewed by Brent Fulgham.
3263
3264         * Scripts/build-webkit:
3265         * Scripts/webkitdirs.pm:
3266         (determineConfiguration):
3267         (determineArchitecture):
3268         (determinePassedConfiguration):
3269         (passedConfiguration):
3270         (jhbuildWrapperPrefixIfNeeded):
3271         (generateBuildSystemFromCMakeProject):
3272         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
3273
3274 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3275
3276         Fix quirks in CMake build on Mac and Windows
3277         https://bugs.webkit.org/show_bug.cgi?id=147174
3278
3279         Reviewed by Gyuyoung Kim.
3280
3281         * CMakeLists.txt:
3282         Don't build DumpRenderTree with CMake for now (until we get that working).
3283         * WinLauncher/CMakeLists.txt:
3284         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3285
3286 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3287
3288         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3289         https://bugs.webkit.org/show_bug.cgi?id=147146
3290
3291         Reviewed by Darin Adler.
3292
3293         * Scripts/webkitpy/style/checkers/cpp.py:
3294         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3295         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3296         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3297
3298 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3299
3300         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3301         https://bugs.webkit.org/show_bug.cgi?id=147154
3302         rdar://problem/21847618
3303
3304         Reviewed by Geoffrey Garen.
3305         
3306         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3307         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3308
3309         * Scripts/run-jsc-stress-tests:
3310
3311 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3312
3313         [GTK] Add API to be notified about editor state changes
3314         https://bugs.webkit.org/show_bug.cgi?id=145875
3315
3316         Reviewed by Gustavo Noronha Silva.
3317
3318         Update the typing attributes toggle buttons state according to the
3319         editor state in MiniBrowser, and add a test case to the
3320         WebViewEditor unit tests.
3321
3322         * MiniBrowser/gtk/BrowserWindow.c:
3323         (browserWindowEditingCommandToggleButtonSetActive):
3324         (typingAttributesChanged):
3325         (browserWindowSetupEditorToolbar):
3326         (browserWindowConstructed):
3327         (browser_window_init):
3328         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3329         (testWebViewEditorEditorStateTypingAttributes):
3330         (beforeAll):
3331
3332 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3333
3334         [GTK] Add selection-changed signal to the WebKit2 API
3335         https://bugs.webkit.org/show_bug.cgi?id=137116
3336
3337         Reviewed by Carlos Garcia Campos.
3338
3339         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3340         (namely the selection-changed signal).
3341
3342         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3343         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3344         (WebKitWebEditorTest::create):
3345         (WebKitWebEditorTest::selectionChangedCallback):
3346         (WebKitWebEditorTest::testSelectionSelectAll):
3347         (WebKitWebEditorTest::testSelectionCollapse):
3348         (WebKitWebEditorTest::testSelectionModifyMove):
3349         (WebKitWebEditorTest::testSelectionModifyExtend):
3350         (WebKitWebEditorTest::testSelectionUnselect):
3351         (registerTests):
3352         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3353         (testWebKitWebEditorSelectionChanged):
3354         (beforeAll):
3355         (afterAll):
3356
3357 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3358
3359         Resurrect CMake build on Windows.
3360         https://bugs.webkit.org/show_bug.cgi?id=147083
3361
3362         Reviewed by Gyuyoung Kim.
3363
3364         * DumpRenderTree/CMakeLists.txt:
3365         * DumpRenderTree/PlatformWin.cmake: Added.
3366         * WinLauncher/CMakeLists.txt:
3367
3368 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3369
3370         [GTK] Enable seccomp filter API tests
3371         https://bugs.webkit.org/show_bug.cgi?id=140071
3372
3373         Reviewed by Žan Doberšek.
3374
3375         These tests will now be run by the run-gtk-tests script.
3376
3377         * TestWebKitAPI/PlatformGTK.cmake:
3378
3379 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3380
3381         [GTK] Add seccomp filters support
3382         https://bugs.webkit.org/show_bug.cgi?id=110014
3383
3384         Reviewed by Žan Doberšek.
3385
3386         Add libseccomp to jhbuild modulesets.
3387
3388         * gtk/jhbuild.modules:
3389
3390 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3391
3392         MiniBrowser window title is just "Window" when page has no <title>
3393         https://bugs.webkit.org/show_bug.cgi?id=147076
3394
3395         Reviewed by Tim Horton.
3396         
3397         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3398         notification.
3399
3400         * MiniBrowser/mac/WK1BrowserWindowController.m:
3401         (-[WK1BrowserWindowController updateTitle:]):
3402         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3403         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3404         * MiniBrowser/mac/WK2BrowserWindowController.m:
3405         (-[WK2BrowserWindowController updateTitle:]):
3406         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3407         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3408
3409 2015-07-17  Andy Estes  <aestes@apple.com>
3410
3411         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3412         https://bugs.webkit.org/show_bug.cgi?id=147044
3413         rdar://problem/21567820
3414
3415         Reviewed by Brady Eidson.
3416
3417         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3418         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3419         This matches the behavior of DumpRenderTree.
3420
3421 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3422
3423         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3424         https://bugs.webkit.org/show_bug.cgi?id=147032
3425
3426         Reviewed by Alex Christensen.
3427
3428         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3429         Test that the useless terms are eliminated by counting
3430         the number of NFA nodes generated.
3431
3432 2015-07-17  Dan Bernstein  <mitz@apple.com>
3433
3434         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3435         https://bugs.webkit.org/show_bug.cgi?id=147040
3436
3437         Reviewed by Dean Jackson.
3438
3439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3440         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3441         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3442         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3443         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3444         (TEST):
3445
3446 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3447
3448         webkit-patch uses incorrect credentials from keychain to login until account lockout
3449         https://bugs.webkit.org/show_bug.cgi?id=146923
3450
3451         Reviewed by Daniel Bates.
3452
3453         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3454         provide incorrect credentials then ask for them to be saved to the keychain
3455         webkit-patch will then use those incorrect credentials until 5 total attempts
3456         have been made to log in. This will lock the user out of Bugzilla for a
3457         half hour.
3458
3459         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3460         (Bugzilla.authenticate): Added argument to read_credentials() that
3461         passes in whether or not to use stored credentials.
3462         * Scripts/webkitpy/common/net/credentials.py:
3463         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3464         that specifies whether or not to use credentials stored on the system. If it
3465         does, we do not auto-fill credentials since either the credentials caused
3466         the failure, or they weren't used in the first place so there is no reason
3467         to try and use them again if a failure happened.
3468         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3469         use_stored_credentials argument.
3470         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3471         retrieve username/password information from the local system (environment, Git, keychain,
3472         keyring) are never called. It also tests that we get back our mocked username and password.
3473         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3474         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3475         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3476         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3477         is never called.
3478         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3479         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3480         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3481         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3482         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3483         against.
3484
3485 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3486
3487         Unreviewed, remove my redundant email information.
3488
3489         * Scripts/webkitpy/common/config/contributors.json:
3490
3491 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3492
3493         Unreviewed. Add Hyungwook Lee as a committer.
3494
3495         * Scripts/webkitpy/common/config/contributors.json:
3496
3497 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3498
3499         Added myself to the list of contributors.
3500
3501         Reviewed by Brent Fulgham.
3502
3503         * Scripts/webkitpy/common/config/contributors.json:
3504
3505 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3506
3507         [Content Extensions] Cache domain actions
3508         https://bugs.webkit.org/show_bug.cgi?id=146817
3509
3510         Reviewed by Benjamin Poulain.
3511
3512         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3513         (TestWebKitAPI::TEST_F):
3514         Test if-domain and unless-domain with multiple load types.
3515
3516 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3517
3518         [Content extensions] Combine suffixes when generating NFAs
3519         https://bugs.webkit.org/show_bug.cgi?id=146961
3520
3521         Reviewed by Alex Christensen.
3522
3523         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3524         (TestWebKitAPI::compareContents):
3525         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3526
3527 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3528
3529         [GTK] Input method filter is always enabled when the view is focused
3530         https://bugs.webkit.org/show_bug.cgi?id=146965
3531
3532         Reviewed by Martin Robinson.
3533
3534         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3535
3536         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3537         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3538
3539 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3540
3541         [EFL] Bump libseccomp version to 2.2.3
3542         https://bugs.webkit.org/show_bug.cgi?id=146980
3543
3544         Reviewed by Gyuyoung Kim.
3545
3546         * efl/jhbuild.modules:
3547
3548 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3549
3550         [Win] Maintain consistent COM Interfaces
3551         https://bugs.webkit.org/show_bug.cgi?id=146983
3552         <rdar://problem/21822278>
3553
3554         Reviewed by Dean Jackson.
3555
3556         Update DumpRenderTree and WinLauncher to use the properly
3557         versioned COM interface objects.
3558
3559         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3560         (AccessibilityController::rootElement):
3561         * DumpRenderTree/win/DumpRenderTree.cpp:
3562         (resetWebPreferencesToConsistentValues):
3563         (resetWebViewToConsistentStateBeforeTesting):
3564         (runTest):
3565         (createWebViewAndOffscreenWindow):
3566         * DumpRenderTree/win/EditingDelegate.cpp:
3567         (EditingDelegate::QueryInterface):
3568         (EditingDelegate::shouldEndEditingInDOMRange):
3569         (EditingDelegate::shouldInsertNode):
3570         * DumpRenderTree/win/EditingDelegate.h:
3571         * DumpRenderTree/win/EventSender.cpp:
3572         (scalePageByCallback):
3573         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3574         (FrameLoadDelegate::didCommitLoadForFrame):
3575         * DumpRenderTree/win/TestRunnerWin.cpp:
3576         (TestRunner::callShouldCloseOnWebView):
3577         (TestRunner::applicationCacheDiskUsageForOrigin):
3578         (TestRunner::clearApplicationCacheForOrigin):
3579         (TestRunner::setDefersLoading):
3580         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3581         (TestRunner::setTabKeyCyclesThroughElements):
3582         (TestRunner::setValueForUser):
3583         (TestRunner::dispatchPendingLoadRequests):
3584         (TestRunner::setWindowIsKey):
3585         (TestRunner::execCommand):
3586         (TestRunner::addOriginAccessWhitelistEntry):
3587         (TestRunner::removeOriginAccessWhitelistEntry):
3588         (TestRunner::addUserScript):
3589         (TestRunner::addUserStyleSheet):
3590         (TestRunner::showWebInspector):
3591         (TestRunner::closeWebInspector):
3592         (TestRunner::evaluateInWebInspector):
3593         (TestRunner::setSerializeHTTPLoads):
3594         * DumpRenderTree/win/TextInputControllerWin.cpp:
3595         (TextInputController::setMarkedText):
3596         (TextInputController::hasMarkedText):
3597         (TextInputController::unmarkText):
3598         (TextInputController::markedRange):
3599         (TextInputController::insertText):
3600         (TextInputController::firstRectForCharacterRange):