Add a private browsing mode to MiniBrowser
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-05  Anders Carlsson  <andersca@apple.com>
2
3         Add a private browsing mode to MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=139308
5
6         Reviewed by Sam Weinig.
7
8         * MiniBrowser/mac/AppDelegate.m:
9         (defaultConfiguration):
10         (-[BrowserAppDelegate newWindow:]):
11         (-[BrowserAppDelegate newPrivateWindow:]):
12         * MiniBrowser/mac/MainMenu.xib:
13         * MiniBrowser/mac/WK2BrowserWindowController.h:
14         * MiniBrowser/mac/WK2BrowserWindowController.m:
15         (-[WK2BrowserWindowController awakeFromNib]):
16         (-[WK2BrowserWindowController initWithConfiguration:]):
17         (-[WK2BrowserWindowController dealloc]):
18         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
19
20 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
21
22         Run http tests parallel
23         https://bugs.webkit.org/show_bug.cgi?id=138958
24
25         Reviewed by Daniel Bates.
26
27         Remove the concept of "locked shard". Now http tests are just like any other tests.
28         We start HTTP and WebSocket servers at the start if we need them, and terminate them
29         when done with all the tests (not when the last http test runs, which is unnecessarily
30         unpredictable).
31
32         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
33         patch, they used to take over 15 minutes.
34
35         As part of the fix, we no longer pass the number of servers to Apache. I don't
36         think that these parameters did what we wanted them to do; Apache handles the load
37         just fine without them.
38
39         The change applies to all platforms. I fixed everything I could find on Mac, and
40         Ossy told me that he's been running http tests in parallel for a long time. If
41         there is increased instability for some ports, it will need to be fixed - there is
42         generally nothing special about http tests at this point, and most code is
43         cross-platform in WebKit2.
44
45         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
46         (LayoutTestRunner.__init__):
47         (LayoutTestRunner.run_tests):
48         (LayoutTestRunner.start_servers_with_lock):
49         (LayoutTestRunner._handle_started_test):
50         (Worker.handle):
51         (Sharder.__init__):
52         (Sharder.shard_tests):
53         (Sharder._shard_every_file):
54         (Sharder._shard_by_directory):
55         (LayoutTestRunner._handle_finished_test_list): Deleted.
56         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
57         (Sharder._shard_in_two): Deleted.
58         (Sharder): Deleted.
59         (Sharder._resize_shards): Deleted.
60         (Sharder._resize_shards.divide_and_round_up): Deleted.
61         (Sharder._resize_shards.extract_and_flatten): Deleted.
62         (Sharder._resize_shards.split_at): Deleted.
63         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
64         (FakePrinter.print_workers_and_shards):
65         (LayoutTestRunnerTests.test_servers_started.start_http_server):
66         (LayoutTestRunnerTests.test_servers_started):
67         (SharderTests.get_shards):
68         (SharderTests.test_shard_by_dir):
69         (SharderTests.test_shard_every_file):
70         (SharderTests): Deleted.
71         (SharderTests.test_shard_in_two): Deleted.
72         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
73         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
74         (SharderTests.test_multiple_locked_shards): Deleted.
75         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
76         (ManagerTest.test_needs_servers.get_manager):
77         (ManagerTest.integration_test_needs_servers.get_manager):
78         (ManagerTest.test_look_for_new_crash_logs.get_manager):
79         (ManagerTest):
80         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
81         (_set_up_derived_options):
82         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
83         (RunTest.test_batch_size):
84         (RunTest.test_max_locked_shards): Deleted.
85         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
86         (LayoutTestApacheHttpd.__init__):
87         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
88         (TestLayoutTestApacheHttpd.test_start_cmd):
89         * Scripts/webkitpy/layout_tests/servers/http_server.py:
90         (Lighttpd.__init__):
91         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
92         (HttpServerBase.__init__):
93         * Scripts/webkitpy/layout_tests/views/printing.py:
94         (Printer.print_workers_and_shards):
95         * Scripts/webkitpy/port/base.py:
96         (Port.default_child_processes):
97         (Port.to.start_http_server):
98         (Port.default_max_locked_shards): Deleted.
99         * Scripts/webkitpy/port/port_testcase.py:
100         (PortTestCase.make_port):
101         (PortTestCase.test_default_max_locked_shards): Deleted.
102         * Scripts/webkitpy/port/test.py:
103         (TestPort.start_http_server):
104
105 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
106
107         Don't lock perf tests in run-webkit-tests
108         https://bugs.webkit.org/show_bug.cgi?id=139264
109
110         Reviewed by Daniel Bates.
111
112         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
113         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
114         * Scripts/webkitpy/layout_tests/controllers/manager.py:
115         * Scripts/webkitpy/layout_tests/models/test_input.py:
116         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
117
118 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
119
120         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
121         https://bugs.webkit.org/show_bug.cgi?id=139243
122
123         Reviewed by Anders Carlsson.
124
125         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
126         chance to allow untrusted certificates.
127
128         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
129         Set up more client objects for secondary windows. We may be able to share some of the
130         code with main view creation function, but it's not exactly the same (notably, we
131         do not focus a secondary window when it's done loading).
132
133 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
134
135         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
136         https://bugs.webkit.org/show_bug.cgi?id=139071
137
138         Reviewed by Chris Fleizach.
139
140         Add string value for ATK_ROLE_STATIC in roleToString.
141
142         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
143
144 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
145
146         check-webkit-style is confused by ternary expression inside first member initializer
147         https://bugs.webkit.org/show_bug.cgi?id=136442
148
149         Reviewed by Csaba Osztrogonác.
150
151         * Scripts/webkitpy/style/checkers/cpp.py:
152         (check_member_initialization_list):
153
154 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
155
156         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
157         https://bugs.webkit.org/show_bug.cgi?id=139220
158
159         Reviewed by Philippe Normand.
160
161         * gtk/jhbuild.modules:
162         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
163
164 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
165
166         Remove unused JSC runtime options
167         https://bugs.webkit.org/show_bug.cgi?id=133070
168
169         Reviewed by Csaba Osztrogonác.
170
171         * Scripts/run-jsc-stress-tests:
172
173 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
174
175         [EFL] Add subtle crypto to the build system
176         https://bugs.webkit.org/show_bug.cgi?id=138612
177
178         Reviewed by Csaba Osztrogonác.
179
180         * Scripts/webkitperl/FeatureList.pm:
181
182 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
183
184         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
185         https://bugs.webkit.org/show_bug.cgi?id=139005
186
187         Reviewed by Chris Fleizach.
188
189         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
190         Add mapping for ATK_ROLE_CAPTION to roleToString
191
192 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
193
194         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
195         https://bugs.webkit.org/show_bug.cgi?id=139149
196
197         Reviewed by Anders Carlsson.
198
199         WebKit2 already cleared application caches between runs (although it wasn't entirely
200         effective without WebCore changes in this patch).
201
202         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
203
204         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
205         function is not implemented on Windows, see below).
206
207         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
208         Ameded a FIXME.
209
210 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
211
212         Generalize PageActivityAssertionToken
213         https://bugs.webkit.org/show_bug.cgi?id=139106
214
215         Reviewed by Sam Weinig.
216
217         Add an API test for WTF::RefCounter.
218
219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
220         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
221         (TestWebKitAPI::TEST):
222             - added RefCounter test.
223
224 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
225
226         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
227         https://bugs.webkit.org/show_bug.cgi?id=139174
228
229         Reviewed by Simon Fraser.
230
231         * DumpRenderTree/TestRunner.cpp:
232         * DumpRenderTree/TestRunner.h:
233         Renamed testPathOrURL to testURL, because this variable always contains a URL.
234
235         * DumpRenderTree/mac/DumpRenderTree.mm:
236         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
237         (testPathFromURL): Moved from FrameLoadDelegate.mm.
238         (runTest): Set crash reporter information here, as we know the exact test URL.
239
240         * DumpRenderTree/mac/FrameLoadDelegate.mm:
241         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
242         reporter information here.
243
244         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
245         * DumpRenderTree/mac/TestRunnerMac.mm:
246         Updated for testPathOrURL renaming.
247
248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
249         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
250         test URL until load starts, so save it into TestRunner now. A new TestRunner object
251         is created for each test.
252
253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
254         (WTR::TestRunner::testURL):
255         (WTR::TestRunner::setTestURL):
256         Make TestRunner know the test name. For now, it's good enough to have it once load
257         starts, but if we ever need it earlier, we can send it with BeginTest message.
258
259         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
260         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
261         Use test URL, not currently loading URL for CrashReporter.
262
263         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
264         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
265         (WebKit1 already had it right).
266
267         * DumpRenderTree/win/DumpRenderTree.cpp:
268         (sizeWebViewForCurrentTest):
269         (runTest):
270         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
271         (ResourceLoadDelegate::willSendRequest):
272         Changed Windows DumpRenderTree to also use URL in TestRunner.
273
274 2014-12-02  Daniel Bates  <dabates@apple.com>
275
276         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
277         https://bugs.webkit.org/show_bug.cgi?id=139143
278
279         Reviewed by David Kilzer.
280
281         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
282         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
283         crashes. Run-webkit-tests will record as crashing the test associated with the
284         DumpRenderTree instance that wrote that string.
285
286         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
287         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
288         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
289         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
290         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
291         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
292         about a crash.
293
294         Additionally, update the crash message format written to standard error when LayoutTestRelay
295         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
296         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
297         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
298         when they crash in their test machinery logic/UI process code.
299
300         * DumpRenderTree/mac/DumpRenderTree.mm:
301         (writeCrashedMessageOnFatalError): Added.
302         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
303         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
304         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
305         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
306         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
307         the crash logs for WebKitTestRunner/DumpRenderTree.app.
308         * Scripts/webkitpy/port/driver.py:
309         (Driver.__init__): Update comment.
310         (Driver._check_for_driver_crash): Ditto.
311         * Scripts/webkitpy/port/ios.py:
312         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
313         regular expression. This constant is used as an optimization to avoid compiling the same
314         regular expression across invocations of _get_crash_log().
315         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
316         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
317         closer to where they are used.
318
319 2014-12-01  Anders Carlsson  <andersca@apple.com>
320
321         Remove WKBundleRemoveAllVisitedLinks
322         https://bugs.webkit.org/show_bug.cgi?id=139163
323
324         Reviewed by Sam Weinig.
325
326         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
327
328         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
329         (WTR::InjectedBundle::beginTesting):
330         * WebKitTestRunner/TestInvocation.cpp:
331         (WTR::TestInvocation::invoke):
332
333 2014-12-02  Anders Carlsson  <andersca@apple.com>
334
335         Fix Windows build.
336
337         * DumpRenderTree/win/DumpRenderTree.cpp:
338         (setAlwaysAcceptCookies):
339
340 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
341
342         [EFL] Remove edbus dependency from jhbuild
343         https://bugs.webkit.org/show_bug.cgi?id=139130
344
345         Reviewed by Gyuyoung Kim.
346
347         After http://trac.webkit.org/changeset/176555 we
348         don't need it anymore.
349
350         * efl/jhbuild.modules:
351
352 2014-12-02  Philippe Normand  <pnormand@igalia.com>
353
354         [jhbuild] wrong Dependencies path
355         https://bugs.webkit.org/show_bug.cgi?id=139176
356
357         Reviewed by Martin Robinson.
358
359         * Scripts/webkitpy/port/base.py:
360         (Port._should_use_jhbuild):
361
362 2014-12-02  Philippe Normand  <pnormand@igalia.com>
363
364         [GStreamer] Bump internal jhbuild versions to 1.4.4
365         https://bugs.webkit.org/show_bug.cgi?id=138866
366
367         Reviewed by Carlos Garcia Campos.
368
369         * gtk/jhbuild.modules:
370         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
371         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
372         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
373
374 2014-12-01  Commit Queue  <commit-queue@webkit.org>
375
376         Unreviewed, rolling out r176566.
377         https://bugs.webkit.org/show_bug.cgi?id=139124
378
379         It broke the GTK performance tests. (Requested by clopez on
380         #webkit).
381
382         Reverted changeset:
383
384         "[GTK] Use GMainLoopSource in WebKitTestRunner"
385         https://bugs.webkit.org/show_bug.cgi?id=138831
386         http://trac.webkit.org/changeset/176566
387
388 2014-11-29  Anders Carlsson  <andersca@apple.com>
389
390         Crash when calling WKPageClose on the originated page from within createNewPage callback
391         https://bugs.webkit.org/show_bug.cgi?id=139099
392         <rdar://problem/19052564>
393
394         Reviewed by Sam Weinig.
395
396         Add a test.
397
398         * TestWebKitAPI/PlatformWebView.h:
399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
400         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
401         (TestWebKitAPI::runJavaScriptAlert):
402         (TestWebKitAPI::createNewPage):
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
405         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
406         (TestWebKitAPI::PlatformWebView::PlatformWebView):
407
408 2014-11-28  Commit Queue  <commit-queue@webkit.org>
409
410         Unreviewed, rolling out r176564.
411         https://bugs.webkit.org/show_bug.cgi?id=139093
412
413         massive failures on release test bot (Requested by philn on
414         #webkit).
415
416         Reverted changeset:
417
418         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
419         https://bugs.webkit.org/show_bug.cgi?id=138866
420         http://trac.webkit.org/changeset/176564
421
422 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
423
424         [GTK] Use GMainLoopSource in WebKitTestRunner
425         https://bugs.webkit.org/show_bug.cgi?id=138831
426
427         Reviewed by Sergio Villar Senin.
428
429         * WebKitTestRunner/InjectedBundle/TestRunner.h:
430         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
431         (WTR::TestRunner::platformInitialize):
432         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
433         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
434         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
435         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
436         (WTR::TestController::notifyDone):
437         (WTR::TestController::platformRunUntil):
438         (WTR::cancelTimeout): Deleted.
439
440 2014-11-24  Philippe Normand  <pnormand@igalia.com>
441
442         [GStreamer] Bump internal jhbuild versions to 1.4.4
443         https://bugs.webkit.org/show_bug.cgi?id=138866
444
445         Reviewed by Carlos Garcia Campos.
446
447         * gtk/jhbuild.modules:
448         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
449         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
450         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
451
452 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
453
454         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
455         https://bugs.webkit.org/show_bug.cgi?id=138834
456
457         Reviewed by Sergio Villar Senin.
458
459         It makes everyting simpler and the tests run faster too, since we
460         don't need to spawn the private bus and wait until the DBus name
461         is registered. The web extension registers a new JavaSCript class
462         with a status method to run the tests, similar to the DBus
463         method. In the UI process side, tests use webkit_web_view_run_java_script()
464         instead of sending a DBus message.
465
466         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
467         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
468         (WebKitDOMNodeFilterTest::create):
469         (WebKitDOMNodeFilterTest::testTreeWalker):
470         (WebKitDOMNodeFilterTest::testNodeIterator):
471         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
472         (WebKitDOMNodeFilterTest::runTest): Deleted.
473         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
474         (WebKitDOMNodeTest::create):
475         (WebKitDOMNodeTest::testHierarchyNavigation):
476         (WebKitDOMNodeTest::testInsertion):
477         (WebKitDOMNodeTest::testTagNames):
478         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
479         (WebKitDOMNodeTest::runTest): Deleted.
480         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
481         (WebKitDOMXPathNSResolverTest::create):
482         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
483         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
484         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
485         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
486         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
487         (WebKitFrameTest::create):
488         (WebKitFrameTest::testMainFrame):
489         (WebKitFrameTest::testURI):
490         (WebKitFrameTest::testJavaScriptContext):
491         (WebKitFrameTest::webPageFromArgs): Deleted.
492         (WebKitFrameTest::runTest): Deleted.
493         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
494         (testWebKitDOMNodeHierarchyNavigation):
495         (testWebKitDOMNodeInsertion):
496         (testWebKitDOMNodeTagNames):
497         (beforeAll):
498         (afterAll):
499         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
500         (runTest):
501         (beforeAll):
502         (afterAll):
503         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
504         (testWebKitDOMXPathNSResolverNative):
505         (testWebKitDOMXPathNSResolverCustom):
506         (beforeAll):
507         (afterAll):
508         (runTest): Deleted.
509         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
510         (webkitFrameTestRun):
511         (beforeAll):
512         (afterAll):
513         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
514         (testsMap):
515         (WebProcessTest::add):
516         (WebProcessTest::create):
517         (runTest):
518         (windowObjectClearedCallback):
519         (webkit_web_extension_initialize):
520         (methodCallCallback): Deleted.
521         (webkit_web_extension_initialize_with_user_data): Deleted.
522         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
523         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
524         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
525         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
526         (WebViewTest::runWebProcessTest):
527         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
528
529 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
530
531         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
532         https://bugs.webkit.org/show_bug.cgi?id=139086
533
534         Reviewed by Gyuyoung Kim.
535
536         * efl/jhbuild.modules:
537         * efl/patches/libseccomp-pick-up-CC.patch: Added.
538
539 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
540
541         [EFL] Add warning if CMake version is too old for building with ninja.
542         https://bugs.webkit.org/show_bug.cgi?id=139055
543
544         Reviewed by Gyuyoung Kim.
545
546         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
547         that version in their repositories.
548
549         * efl/install-dependencies:
550
551 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
552
553         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
554         https://bugs.webkit.org/show_bug.cgi?id=139044
555
556         Reviewed by Chris Fleizach.
557
558         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
559         The proposed solution will enable the use of this method for the object table.
560         Existing test shows the result.
561
562         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
563         (WTR::AccessibilityUIElement::columnHeaders):
564
565 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
566
567         [EFL] Remove E_Dbus dependency
568         https://bugs.webkit.org/show_bug.cgi?id=136355
569
570         Reviewed by Gyuyoung Kim.
571
572         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
573
574 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
575
576         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
577         https://bugs.webkit.org/show_bug.cgi?id=139047
578
579         Reviewed by Carlos Garcia Campos.
580
581         * efl/jhbuild.modules:
582         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
583         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
584         * gtk/jhbuild-optional.modules:
585         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
586         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
587
588 2014-11-25  Tanay C  <tanay.c@samsung.com>
589
590         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
591         https://bugs.webkit.org/show_bug.cgi?id=138090
592
593         Reviewed by Carlos Garcia Campos.
594
595         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
596         (browserWindowZoomIn): Added.
597         (browserWindowZoomOut): Added.
598         (scrollEventCallback): Added.
599         (zoomInCallback): Modified.
600         (zoomOutCallback): Modified.
601         (browserWindowConstructed): Modified.
602
603 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
604
605         [EFL] REGRESSION(r176514): It made performance tests fail
606         https://bugs.webkit.org/show_bug.cgi?id=139037
607
608         Reviewed by Gyuyoung Kim.
609
610         * Scripts/webkitpy/port/efl.py:
611         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
612         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
613         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
614
615 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
616
617         [GTK] update-webkitgtk-libs fails to build fontconfig
618         https://bugs.webkit.org/show_bug.cgi?id=139032
619
620         Reviewed by Martin Robinson.
621
622         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
623         fontconfig will try to generate documentation and fail.
624
625         * gtk/install-dependencies:
626
627 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
628
629         Unreviewed. Fix GTK+ make distcheck.
630
631         * gtk/manifest.txt: Remove deleted files.
632
633 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
634
635         [EFL] Utilize Eail library to support accessibility in EFL
636         https://bugs.webkit.org/show_bug.cgi?id=137742
637
638         Reviewed by Gyuyoung Kim.
639
640         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
641
642         * efl/jhbuild-optional.modules: Added.
643         * efl/jhbuild.modules:
644
645 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
646
647         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
648         https://bugs.webkit.org/show_bug.cgi?id=139023
649
650         Reviewed by Sergio Villar Senin.
651
652         Rename WebKitWebView/default-context as WebKitWebView/web-context
653         and check we are always using the right context for new web views.
654
655         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
656         (testWebViewWebContext):
657         (beforeAll):
658         (testWebViewDefaultContext): Deleted.
659
660 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
661
662         [GTK] Add API to override the default local storage directory
663         https://bugs.webkit.org/show_bug.cgi?id=138828
664
665         Reviewed by Gustavo Noronha Silva.
666
667         Add test to check that the local storage directory is created at
668         the path given on construction.
669
670         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
671         (testWebContextConfiguration):
672         (beforeAll):
673         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
674         (Test::Test):
675         (Test::~Test): Deleted.
676
677 2014-11-21  Zalan Bujtas  <zalan@apple.com>
678
679         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
680         https://bugs.webkit.org/show_bug.cgi?id=138981
681
682         Reviewed by Simon Fraser.
683
684         * MiniBrowser/mac/SettingsController.h:
685         * MiniBrowser/mac/SettingsController.m:
686         (-[SettingsController _populateMenu]):
687         (-[SettingsController validateMenuItem:]):
688         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
689         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
690         * MiniBrowser/mac/WK1BrowserWindowController.m:
691         (-[WK1BrowserWindowController didChangeSettings]):
692         * MiniBrowser/mac/WK2BrowserWindowController.m:
693         (-[WK2BrowserWindowController didChangeSettings]):
694
695 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
696
697         Remove http lock code from webkitperl
698         https://bugs.webkit.org/show_bug.cgi?id=138959
699
700         Reviewed by Alexey Proskuryakov.
701
702         * Scripts/webkitperl/httpd.pm:
703         (cleanUp):
704         (extractLockNumber): Deleted.
705         (getLockFiles): Deleted.
706         (getNextAvailableLockNumber): Deleted.
707         (getLockNumberForCurrentRunning): Deleted.
708         (waitForHTTPDLock): Deleted.
709         (scheduleHttpTesting): Deleted.
710         (getWaitTime): Deleted.
711
712 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
713
714         [EFL] The option value of fixed layout is false in MiniBrowser
715         https://bugs.webkit.org/show_bug.cgi?id=138830
716
717         Reviewed by Gyuyoung Kim.
718
719         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
720
721         * MiniBrowser/efl/main.c:
722
723 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
724
725         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
726         https://bugs.webkit.org/show_bug.cgi?id=138871
727
728         Reviewed by Carlos Garcia Campos.
729
730         Add a test case for the convenience API for posting user messages
731         added to the DOM bindings.
732
733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
734         (testUserContentManagerMessageFromConvenienceDOMBindings):
735         (beforeAll):
736         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
737         (documentLoadedCallback):
738
739 2014-11-19  Dana Burkart  <dburkart@apple.com>
740
741         Work around the fact that different masters may have different names for their codebases.
742         https://bugs.webkit.org/show_bug.cgi?id=138878
743
744         Reviewed by Mark Rowe.
745
746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
747         (parseRevisionProperty): Changed.
748         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
749         opensource / internal codebase naming convention.
750
751 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
752
753         AX: Screen braille input doesn't work on forms.
754         https://bugs.webkit.org/show_bug.cgi?id=138804
755
756         Unreviewed build fix.
757
758         * DumpRenderTree/AccessibilityUIElement.cpp:
759         (AccessibilityUIElement::setValue):
760
761 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
762
763         AX: Screen braille input doesn't work on forms.
764         https://bugs.webkit.org/show_bug.cgi?id=138804
765
766         Reviewed by Mario Sanchez Prada.
767
768         Add a method to setValue through the AX API in DRT.
769
770         * DumpRenderTree/AccessibilityUIElement.cpp:
771         (setValueCallback):
772         (AccessibilityUIElement::getJSClass):
773         * DumpRenderTree/AccessibilityUIElement.h:
774         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
775         (AccessibilityUIElement::setValue):
776         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
777         (AccessibilityUIElement::setValue):
778
779 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
780
781         Remove the WinCairo buildbot
782         https://bugs.webkit.org/show_bug.cgi?id=138805
783
784         Reviewed by Alex Christensen.
785
786         * BuildSlaveSupport/build.webkit.org-config/config.json:
787         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
788         (appendCustomBuildFlags):
789         * BuildSlaveSupport/test-result-archive:
790         (archiveTestResults):
791
792 2014-11-18  Daniel Bates  <dabates@apple.com>
793
794         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
795         SPI are not available in public SDK
796         https://bugs.webkit.org/show_bug.cgi?id=138802
797
798         Reviewed by David Kilzer.
799
800         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
801
802         * DumpRenderTree/mac/CheckedMalloc.cpp:
803
804 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
805
806         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
807
808         Forgot to fix this test before landing.
809
810         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
811         (testWebViewDefaultContext):
812
813 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
814
815         [GTK] Add API to create a WebKitWebContext
816         https://bugs.webkit.org/show_bug.cgi?id=138826
817
818         Reviewed by Gustavo Noronha Silva.
819
820         Use a different WebKitWebContext for every test to ensure test
821         cases are independent to each other. Tests using DBus to
822         communicate with the injected bundle extension now use a unique
823         name for the well known DBus name.
824
825         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
826         (beforeAll): Remove comment about the order of the tests and
827         move the success test before the failed one now that tests don't
828         depend on each others.
829         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
830         (beforeAll): Remove call to set the web extensions directory,
831         since this is now done for all test in the Test constructor.
832         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
833         (beforeAll): Do not create a temporary directory, a temporary data
834         directory is now created for all tests.
835         (afterAll):
836         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
837         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
838         to the web process test runner.
839         (testWebKitDOMNodeInsertion): Ditto.
840         (testWebKitDOMNodeTagNames): Ditto.
841         (beforeAll): Remove call to set the web extensions directory.
842         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
843         (runTest): Pass the web extension ID to the web process test runner.
844         (beforeAll): Remove call to set the web extensions directory.
845         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
846         (runTest): Pass the web extension ID to the web process test runner.
847         (beforeAll): Remove call to set the web extensions directory.
848         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
849         (createFileAtDestination): Use Test::dataDirectory() as base dir
850         for temporary files.
851         (beforeAll): Do not create a temporary directory.
852         (afterAll):
853         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
854         (webkitFrameTestRun): Pass the web extension ID to the web process
855         test runner.
856         (beforeAll): Remove call to set the web extensions directory.
857         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
858         (beforeAll): Remove call to set the web extensions directory.
859         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
860         (testProcessPerWebView): Use local member instead of global variable.
861         (testMultiprocessWebViewCreateReadyClose): Ditto.
862         (beforeAll): Do not connect to initialize-web-extensions, Test now
863         connects to the signal for all tests and calls a virtual method
864         that test can override.
865         (afterAll):
866         (initializeWebExtensions): Deleted.
867         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
868         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
869         for temporary files.
870         (beforeAll): Do not create a temporary directory.
871         (afterAll):
872         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
873         (beforeAll): Remove call to set the web extensions directory.
874         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
875         (beforeAll): Remove comment about the tests order.
876         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
877         (testWebExtensionGetTitle): Build the DBus service name using the
878         web extension ID.
879         (testDocumentLoadedSignal): Ditto.
880         (testWebKitWebViewProcessCrashed): Ditto.
881         (testWebExtensionIsolatedWorld): Ditto.
882         (beforeAll): Remove initialization-user-data test, since now all
883         tests are passing user data to the web extension.
884         (testWebExtensionInitializationUserData): Deleted.
885         (initializeWebExtensions): Deleted.
886         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
887         (testSetDirectory): Use the web context member inherited from Test.
888         (testClearDatabase): Ditto.
889         (testGetFaviconURI): Ditto.
890         (beforeAll): Do not create a temporary directory.
891         (afterAll):
892         (webkitFaviconDatabaseFinalizedCallback): Deleted.
893         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
894         (UserContentManagerTest::UserContentManagerTest):
895         (beforeAll): Remove call to set the web extensions directory.
896         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
897         (testWebContextDefault): Check also that a newly create web
898         context is not the default web context.
899         (testWebContextSpellChecker): Use the web context member inherited
900         from Test.
901         (testWebContextLanguages): Ditto.
902         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
903         (methodCallCallback): Remove GetInitializationUserData method.
904         (webkit_web_extension_initialize_with_user_data): Always create
905         the DBus name using the user data provided.
906         (makeBusName): Deleted.
907         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
908         (webkit_web_extension_initialize_with_user_data): Create the DBus
909         name using the user data provided.
910         (webkit_web_extension_initialize): Deleted.
911         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
912         (Test::dataDirectory): Return the temporary data directory.
913         (removeNonEmptyDirectory): Also remove directories recursively.
914         (main): Remove the disk cache directory initialization, since this
915         is now done in the Test constructor.
916         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
917         (Test::initializeWebExtensionsCallback): Call the virtual method
918         initializeWebExtensions()
919         (Test::Test): Create a new WebKitWebContext and initialize it.
920         (Test::~Test): Disconnect initialize-web-extensions signal.
921         (Test::initializeWebExtensions): Set the web extensions directory
922         and user data.
923         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
924         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
925         (WebProcessTestRunner::runTest): Build the DBus proxy using a
926         unique name created with the Test web extension ID.
927         (WebProcessTestRunner::proxy): Deleted.
928         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
929         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
930         (WebViewTest::WebViewTest): Create the web view with the Test web
931         context.
932         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
933         content manager parameter to the constructor.
934
935 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
936
937         [GTK] Mesa build fails over llvm-3.5
938         https://bugs.webkit.org/show_bug.cgi?id=138825
939
940         Reviewed by Gustavo Noronha Silva.
941
942         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
943
944         * gtk/jhbuild.modules:
945         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
946
947 2014-11-17  Daniel Bates  <dabates@apple.com>
948
949         Unreviewed, rolling out r176232.
950
951         Broke the Mac build. Will investigate offline.
952
953         Reverted changeset:
954
955         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
956         MobileGestalt"
957         https://bugs.webkit.org/show_bug.cgi?id=138802
958         http://trac.webkit.org/changeset/176232
959
960 2014-11-17  Daniel Bates  <dabates@apple.com>
961
962         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
963         SPI are not available in public SDK
964         https://bugs.webkit.org/show_bug.cgi?id=138802
965
966         Reviewed by David Kilzer.
967
968         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
969
970         * DumpRenderTree/mac/CheckedMalloc.cpp:
971
972 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
973
974         Having 30+ flaky failures breaks EWS
975         https://bugs.webkit.org/show_bug.cgi?id=138743
976
977         Reviewed by Alexey Proskuryakov.
978
979         Adds tests to ensure that the problem has been solved.
980         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
981         (test_first_failure_limit):
982         (test_first_failure_limit_with_some_tree_redness):
983         (test_second_failure_limit):
984         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
985         (test_first_and_second_failure_limit):
986         (test_first_and_clean_failure_limit):
987         (test_first_second_and_clean_failure_limit):
988         (test_very_red_tree_retry): Deleted.
989         Really this was renamed to test_first_second_and_clean_failure_limit.
990         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
991         Makes the appropriate changes to PatchAnalysisTask to make sure that
992         even when the first test run hits the failure limit, it will still try
993         a second run.
994         (PatchAnalysisTask._results_failed_different_tests):
995         (PatchAnalysisTask._test_patch):
996         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
997
998 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
999
1000         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
1001         https://bugs.webkit.org/show_bug.cgi?id=136018
1002
1003         Reviewed by Carlos Garcia Campos.
1004
1005         It is possible that the order of -L arguments in the output of
1006         pkg-config is wrong, which causes the linker to find the wrong
1007         version (usually older version) of libraries when running
1008         gtkdoc-scangobj.
1009
1010         * gtk/gtkdoc.py:
1011         (GTKDoc._run_gtkdoc_scangobj):
1012
1013 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1014
1015         Bump EFL version to 1.12.0
1016         https://bugs.webkit.org/show_bug.cgi?id=138733
1017
1018         Reviewed by Gyuyoung Kim.
1019
1020         * efl/jhbuild.modules:
1021
1022 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
1023
1024         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
1025         https://bugs.webkit.org/show_bug.cgi?id=138771
1026
1027         Reviewed by Chris Fleizach.
1028
1029         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
1030
1031         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1032
1033 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
1034
1035         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
1036         https://bugs.webkit.org/show_bug.cgi?id=138767
1037
1038         Reviewed by Chris Fleizach.
1039
1040         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
1041
1042         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1043
1044 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
1045
1046         Add shortcut macros to Mac TestExpectations
1047         https://bugs.webkit.org/show_bug.cgi?id=138729
1048
1049         Reviewed by Simon Fraser.
1050
1051         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
1052         Add version macros for current OS versions.
1053
1054 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
1055
1056         https://bugs.webkit.org/show_bug.cgi?id=138628
1057         A patch that doesn't apply is stuck in commit queue
1058
1059         Rubber-stamped by David Kilzer.
1060
1061         This also hopefully fixes other issues:
1062         - a patch that has cq+ flag set by a non-committer kills commit queue;
1063         - EWS never reports failing tests, and keeps spinning instead.
1064
1065         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1066         (Bugzilla.set_flag_on_attachment):
1067         (Bugzilla.obsolete_attachment):
1068         Apply the fix from r174797 to more places.
1069
1070 2014-11-13  Dan Bernstein  <mitz@apple.com>
1071
1072         Policy client not called for navigations through the page cache
1073         https://bugs.webkit.org/show_bug.cgi?id=138703
1074
1075         Reviewed by Alexey Proskuryakov.
1076
1077         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1078         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
1079         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1080
1081 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
1082
1083         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
1084         https://bugs.webkit.org/show_bug.cgi?id=137867
1085
1086         Reviewed by Chris Fleizach.
1087
1088         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
1089         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
1090         able to test for the presence of ATK_ROLE_INVALID.
1091
1092         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1093         (WTR::AccessibilityUIElement::role):
1094
1095 2014-11-13  Juergen Ributzka  <juergen@apple.com>
1096
1097         Update the "combineModules" script to handel more LLVM metadata.
1098         https://bugs.webkit.org/show_bug.cgi?id=138514
1099
1100         Reviewed by Filip Pizlo.
1101
1102         * ReducedFTL/combineModules.rb:
1103
1104 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1105
1106         Allow constructing a base PassRef with a derived Ref
1107         https://bugs.webkit.org/show_bug.cgi?id=138701
1108
1109         Reviewed by Andreas Kling
1110
1111         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1112         (TestWebKitAPI::passWithPassRef):
1113         (TestWebKitAPI::passWithPassRefPtr):
1114         (TestWebKitAPI::TEST):
1115
1116 2014-11-05  Ada Chan  <adachan@apple.com>
1117
1118         Implement new plug-in API for muting plug-ins
1119         https://bugs.webkit.org/show_bug.cgi?id=138105
1120
1121         Reviewed by Anders Carlsson.
1122
1123         Add a new plug-in test for the mute API.
1124
1125         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1126         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
1127         (SetMuted::SetMuted):
1128         (SetMuted::isMuted):
1129         (SetMuted::cachedIsMuted):
1130         (SetMuted::ScriptableObject::hasProperty):
1131         (SetMuted::ScriptableObject::getProperty):
1132         (SetMuted::ScriptableObject::pluginTest):
1133         (SetMuted::NPP_New):
1134         (SetMuted::NPP_GetValue):
1135         (SetMuted::NPP_SetValue):
1136
1137 2014-11-12  Philippe Normand  <pnormand@igalia.com>
1138
1139         Unreviewed, GTK gardening.
1140
1141         * Scripts/run-gtk-tests:
1142         (TestRunner): Skip the UserMediaBasic test because it depends on
1143         constraints validation which is going to be fixed in bug #136449.
1144
1145 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1146
1147         [GTK] Expose user script messages to GObject DOM bindings
1148         https://bugs.webkit.org/show_bug.cgi?id=138411
1149
1150         Reviewed by Philippe Normand.
1151
1152         Add a test case to check that user script messages sent using the
1153         DOM bindings API are also received in the UI process.
1154
1155         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1156         (UserScriptMessageTest::waitUntilMessageReceived):
1157         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
1158         (testUserContentManagerScriptMessageFromDOMBindings):
1159         (beforeAll):
1160         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1161         (documentLoadedCallback):
1162
1163 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1164
1165         Unreviewed. Fix GTK+ clean build after r175930.
1166
1167         Partial rollout of r175930 to not build the new unit test that
1168         broke clean builds in GTK+ port.
1169
1170         * TestWebKitAPI/PlatformGTK.cmake:
1171
1172 2014-09-01  Philippe Normand  <pnormand@igalia.com>
1173
1174         [WK2] UserMediaClient support
1175         https://bugs.webkit.org/show_bug.cgi?id=123158
1176
1177         Reviewed by Benjamin Poulain.
1178
1179         Simple API test for the UserMedia permission request API. The
1180         required test infrastructure is also added, inspired by the
1181         Geolocation infrastructure.
1182
1183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
1184         Permission request.
1185         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
1186         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1187         (TestWebKitAPI::TEST):
1188         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
1189         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
1190         helper method to set the permission request result without user interaction.
1191         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1192         (WTR::InjectedBundle::setUserMediaPermission):
1193         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
1194         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1195         (WTR::TestRunner::setUserMediaPermission):
1196         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1197         * WebKitTestRunner/TestController.cpp:
1198         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
1199         request handler.
1200         (WTR::TestController::createOtherPage): Enable the new UserMedia
1201         permission request handler.
1202         (WTR::TestController::createWebViewWithOptions): Ditto.
1203         (WTR::TestController::resetPreferencesToConsistentValues): Enable
1204         MediaStream support, this is needed for getUserMedia.
1205         (WTR::TestController::resetStateToConsistentValues): clear
1206         UserMedia permissions list and flags.
1207         (WTR::TestController::setUserMediaPermission): Set permission
1208         request result and distpatch it.
1209         (WTR::TestController::handleUserMediaPermissionRequest): Save
1210         request and dispatch it.
1211         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1212         Dispatch cached permission requests.
1213         * WebKitTestRunner/TestController.h:
1214         * WebKitTestRunner/TestInvocation.cpp:
1215         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1216
1217 2014-11-11  David Kilzer  <ddkilzer@apple.com>
1218
1219         webkit-patch --suggest-reviewers is broken with newer versions of git
1220         <http://webkit.org/b/138627>
1221
1222         Reviewed by Michael Saboff with feedback from Daniel Bates.
1223
1224         * Scripts/webkitpy/common/checkout/scm/git.py:
1225         (Git._changes_files_for_commit): Strip blank lines instead of
1226         assuming there is always a blank line at the beginning of the
1227         list.
1228
1229 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
1230
1231         DRT and WKTR touch disk cache
1232         https://bugs.webkit.org/show_bug.cgi?id=138622
1233
1234         Reviewed by Geoffrey Garen.
1235
1236         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1237         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
1238         because this function uses the shared cache.
1239
1240         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
1241         Create an empty shared cache to prevent a default one from being created on disk.
1242
1243 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
1244
1245         [CSS Grid Layout] Limit the size of explicit/implicit grid
1246         https://bugs.webkit.org/show_bug.cgi?id=136217
1247
1248         Reviewed by Andreas Kling.
1249
1250         Added a new unit test for the CSS parser. Right now it only checks
1251         that we properly clamp the maximum number of tracks on a grid to a
1252         maximum of 1 million.
1253
1254         * TestWebKitAPI/CMakeLists.txt:
1255         * TestWebKitAPI/PlatformEfl.cmake:
1256         * TestWebKitAPI/PlatformGTK.cmake:
1257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1258         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
1259         (TestWebKitAPI::computeNumberOfTracks): Helper function.
1260         (TestWebKitAPI::TEST): Added a
1261         CSSPropertyParserTest.GridTrackLimits test case.
1262
1263 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1264
1265         webkitpy test fix after r175867
1266         https://bugs.webkit.org/show_bug.cgi?id=138607
1267
1268         Reviewed by Philippe Normand.
1269
1270         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1271         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1272
1273 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1274
1275         webkitpy: demangle C++ symbols from crash log stderr
1276         https://bugs.webkit.org/show_bug.cgi?id=138565
1277
1278         Reviewed by Alexey Proskuryakov.
1279
1280         * Scripts/webkitpy/port/linux_get_crash_log.py:
1281         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
1282         with c++filt.
1283
1284 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1285
1286         [GTK] fix up the GDB backtrace report tool
1287         https://bugs.webkit.org/show_bug.cgi?id=138564
1288
1289         Reviewed by Carlos Garcia Campos.
1290
1291         * Scripts/webkitpy/port/gtk.py:
1292         (GtkPort._get_crash_log): Match the process name reported by the
1293         driver with the GTK port WebProcess executable filename.
1294         * Scripts/webkitpy/port/linux_get_crash_log.py:
1295         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
1296         program.
1297         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
1298         pattern to workaround the 16 characters size limit of %e.
1299
1300 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
1301
1302         Unreviewed, moved myself to the list of committers.
1303
1304         * Scripts/webkitpy/common/config/contributors.json:
1305
1306 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1307
1308         [EFL] Fix the test font path after r175555.
1309
1310         Reviewed by Csaba Osztrogonác.
1311
1312         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
1313
1314 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
1315
1316         Fix the exception fuzz helper to generate targets in the correct range
1317         https://bugs.webkit.org/show_bug.cgi?id=138544
1318
1319         Reviewed by Filip Pizlo.
1320
1321         Currently, the script generates exception fuzz targets in the range of
1322         0..($checkCount-1). However, target 0 is never hit, while target 1 is
1323         always outside of the outermost try block of the tests, which therefore
1324         prints unexpected output and results in false failures when fired at.
1325         Additionally, target $checkCount is never generated.
1326
1327         This patch fixes the script to generate targets in the range of
1328         2..$checkCount.
1329
1330         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1331
1332 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1333
1334         make-passwords-json.py should generarate everything needed for testing
1335         https://bugs.webkit.org/show_bug.cgi?id=138503
1336
1337         Reviewed by Ryosuke Niwa.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
1340         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
1341         Additionally generate auth.json, credentials.cfg and committers.cfg too.
1342         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
1343         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1344         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
1345         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
1346
1347 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1348
1349         [GTK] generate-gtkdoc should ignore invalid files
1350         https://bugs.webkit.org/show_bug.cgi?id=138542
1351
1352         Reviewed by Darin Adler.
1353
1354         * gtk/generate-gtkdoc:
1355         (files_to_ignore.file_should_be_ignored): Return True to ignore
1356         invalid files.
1357
1358 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1359
1360         Delete cookies between tests
1361         https://bugs.webkit.org/show_bug.cgi?id=138528
1362
1363         Reviewed by Sam Weinig.
1364
1365         * DumpRenderTree/mac/DumpRenderTree.mm:
1366         (resetWebPreferencesToConsistentValues):
1367         * WebKitTestRunner/TestController.cpp:
1368         (WTR::TestController::resetPreferencesToConsistentValues):
1369         Do it.
1370
1371         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1372         (WTR::InjectedBundle::beginTesting):
1373         Added a FIXME.
1374
1375 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1376
1377         [GTK] Run layout tests using the network process
1378         https://bugs.webkit.org/show_bug.cgi?id=138428
1379
1380         Reviewed by Martin Robinson.
1381
1382         Shared secondary process is the default in the GTK+ port, but we
1383         should run the tests using the network process to ensure
1384         everything works with the network process. In the future, the
1385         shared secondary process model might be a special case of multiple
1386         processes with 1 as maximum number of processes, but always using
1387         the network process.
1388
1389         * WebKitTestRunner/TestController.cpp:
1390         (WTR::TestController::initialize):
1391
1392 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1393
1394         [GTK] Allow to create a view with a related page in WTR
1395         https://bugs.webkit.org/show_bug.cgi?id=138501
1396
1397         Reviewed by Martin Robinson.
1398
1399         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1400         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1401         related page to WKViewCreate.
1402         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1403         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1404         page to WKViewCreate.
1405
1406 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1407
1408         WTR crashes after running a test when NetworkProcess enabled
1409         https://bugs.webkit.org/show_bug.cgi?id=138500
1410
1411         Reviewed by Alexey Proskuryakov.
1412
1413         WebNotificationProvider destructor is calling
1414         WKNotificationManagerSetProvider, but m_notificationManager is
1415         null because removeNotificationManager was already called.
1416
1417         * WebKitTestRunner/WebNotificationProvider.cpp:
1418         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1419         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1420
1421 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1422
1423         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1424         regarding incorrect call to PatchAnalysisTask.report_failure
1425         https://bugs.webkit.org/show_bug.cgi?id=138229
1426
1427         Reviewed by Daniel Bates.
1428
1429         * Scripts/webkitpy/common/net/layouttestresults.py:
1430         Makes sure test_results returns a list.
1431         (LayoutTestResults.test_results):
1432         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1433         Makes unit tests also check to make sure
1434         task.results_from_patch_test_run() and
1435         task.results_from_test_run_without_patch return instances of
1436         LayoutTestResults.
1437         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1438         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1439         Condenses duplicate code into _should_defer_patch_or_throw, and
1440         removes the now-unused _clean_tree_results member.
1441         (PatchAnalysisTask.__init__):
1442         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1443         (PatchAnalysisTask._should_defer_patch_or_throw):
1444         (PatchAnalysisTask._test_patch):
1445         (PatchAnalysisTask.results_from_patch_test_run):
1446         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1447         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1448         Removes needless call to results_from_test_run_without_patch
1449         (AbstractEarlyWarningSystem._failing_tests_message):
1450         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1451         Changes order of test failure messages to be in the order that they
1452         appear.
1453         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1454         * Scripts/webkitpy/tool/commands/queues.py:
1455         Removes needless call to results_from_test_run_without_patch.
1456         (CommitQueue._failing_tests_message):
1457         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1458         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1459
1460 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1461
1462         Unreviewed. Reorder my e-mail addresses in contributors.json
1463
1464         * Scripts/webkitpy/common/config/contributors.json:
1465
1466 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1467
1468         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1469         https://bugs.webkit.org/show_bug.cgi?id=138475
1470
1471         Reviewed by Ryosuke Niwa.
1472
1473         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1474         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1475         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1476         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1477
1478         * Scripts/webkitpy/common/checkout/scm/git.py:
1479         (Git._run_git_svn_find_rev):
1480         Add comment mentioning that svn_revisions need to begin with 'r'.
1481         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1482         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1483         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1484
1485 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1486
1487         [GTK] Add context menu API to Web Process Extensions
1488         https://bugs.webkit.org/show_bug.cgi?id=138311
1489
1490         Reviewed by Gustavo Noronha Silva.
1491
1492         Add tests cases for WebKitWebPage::context-menu signal.
1493
1494         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1495         (testContextMenuWebExtensionMenu):
1496         (testContextMenuWebExtensionNode):
1497         (beforeAll):
1498         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1499         (serializeContextMenu):
1500         (serializeNode):
1501         (contextMenuCallback):
1502         (pageCreatedCallback):
1503
1504 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1505
1506         Unreviewed, rolling out r175690.
1507         https://bugs.webkit.org/show_bug.cgi?id=138460
1508
1509         We are not ready to run layout tests using the network process
1510         yet (Requested by KaL on #webkit).
1511
1512         Reverted changeset:
1513
1514         "[GTK] Run layout tests using the network process"
1515         https://bugs.webkit.org/show_bug.cgi?id=138428
1516         http://trac.webkit.org/changeset/175690
1517
1518 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1519
1520         [GTK] Run layout tests using the network process
1521         https://bugs.webkit.org/show_bug.cgi?id=138428
1522
1523         Reviewed by Martin Robinson.
1524
1525         Shared secondary process is the default in the GTK+ port, but we
1526         should run the tests using the network process to ensure
1527         everything works with the network process. In the future, the
1528         shared secondary process model might be a special case of multiple
1529         processes with 1 as maximum number of processes, but always using
1530         the network process.
1531
1532         * WebKitTestRunner/TestController.cpp:
1533         (WTR::TestController::initialize):
1534
1535 2014-11-05  Dan Bernstein  <mitz@apple.com>
1536
1537         Remove the unused deletion UI feature
1538         https://bugs.webkit.org/show_bug.cgi?id=138442
1539
1540         Rubber-stamped by Alexey Proskuryakov.
1541
1542         * DumpRenderTree/mac/EditingDelegate.mm:
1543         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1544         delegate method that’s been removed.
1545
1546 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1547
1548         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1549         https://bugs.webkit.org/show_bug.cgi?id=138334
1550
1551         Reviewed by Anders Carlsson.
1552
1553         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1554         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1555         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1556         it also needs to reset internal focus explicitly.
1557
1558         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1559         WebKit behavior appears wrong, but it matches Firefox.
1560
1561         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1562         (WTR::InjectedBundlePage::resetAfterTest):
1563
1564 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1565
1566         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1567         https://bugs.webkit.org/show_bug.cgi?id=137862
1568
1569         Reviewed by Gustavo Noronha Silva.
1570
1571         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1572         is emitted when a subresource load fails due to TLS errors.
1573
1574         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1575         (TLSSubresourceTest::resourceLoadStartedCallback):
1576         (TLSSubresourceTest::TLSSubresourceTest):
1577         (TLSSubresourceTest::subresourceFailedCallback):
1578         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1579         (TLSSubresourceTest::subresourceLoadStarted):
1580         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1581         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1582         (testSubresourceLoadFailedWithTLSErrors):
1583         (httpsServerCallback):
1584         (httpServerCallback):
1585         (beforeAll):
1586
1587 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1588
1589         Build fix for some compiler versions.
1590
1591         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1592         unhappy because this is a getter, and these shouldn't have side effects.
1593
1594 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1595
1596         Add a method for performing cherrypick-merges.
1597         https://bugs.webkit.org/show_bug.cgi?id=138375
1598
1599         Reviewed by Ryosuke Niwa.
1600
1601         Adds support for cherrypick-merges.
1602
1603         * Scripts/webkitpy/common/checkout/scm/git.py:
1604         (Git.cherrypick_merge): Added.
1605
1606 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1607
1608         Add a way to ascertain the SVN URL associated with a Git branch.
1609         https://bugs.webkit.org/show_bug.cgi?id=138374
1610
1611         Reviewed by Ryosuke Niwa.
1612
1613         The svn_url method returns the SVN URL associated with the current Git branch.
1614
1615         * Scripts/webkitpy/common/checkout/scm/git.py:
1616         (Git.svn_url): Added.
1617
1618 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1619
1620         Add the ability to search for modifications that are staged for commit.
1621         https://bugs.webkit.org/show_bug.cgi?id=138373
1622
1623         Reviewed by Ryosuke Niwa and Daniel Bates.
1624
1625         This makes is easy to do identify files that require merge post-processing,
1626         in addition to stand-alone utility.
1627
1628         * Scripts/webkitpy/common/checkout/scm/git.py:
1629         (Git.modifications_staged_for_commit): Added.
1630
1631 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1632
1633         Add a branch keyword argument to _run_git_svn_find_rev.
1634         https://bugs.webkit.org/show_bug.cgi?id=138372
1635
1636         Reviewed by Ryosuke Niwa.
1637
1638         The addition of this keyword argument allows clients to determine the Git hash
1639         of commits made on an SVN branch, provided that branch has been fetched locally.
1640
1641         * Scripts/webkitpy/common/checkout/scm/git.py:
1642         (Git._run_git_svn_find_rev):
1643         Add a branch keyword argument that is added to the end of the command, if present.
1644
1645 2014-11-04  Chris Dumez  <cdumez@apple.com>
1646
1647         Add ptr() method to Ref class
1648         https://bugs.webkit.org/show_bug.cgi?id=138361
1649
1650         Reviewed by Darin Adler.
1651
1652         Use the new Ref::ptr() method.
1653
1654         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1655         (TestWebKitAPI::TEST):
1656
1657 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1658
1659         [jhbuild] Make it possible to build GTK/EFL in same repository
1660         https://bugs.webkit.org/show_bug.cgi?id=137448
1661
1662         Reviewed by Martin Robinson.
1663
1664         * Scripts/webkitdirs.pm:
1665         (getJhbuildPath):
1666         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1667         (getPlatformFontsPath):
1668         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1669         (WTR::getFontsPath):
1670         * jhbuild/jhbuild-wrapper:
1671         (determine_platform):
1672         (install_jhbuild):
1673         * jhbuild/jhbuildrc_common.py:
1674         (init):
1675
1676 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1677
1678         [EFL] Bump LLVM to version 3.5.0
1679         https://bugs.webkit.org/show_bug.cgi?id=138312
1680
1681         Reviewed by Csaba Osztrogonác.
1682
1683         * efl/jhbuild.modules:
1684         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1685         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1686
1687 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1688
1689         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1690         https://bugs.webkit.org/show_bug.cgi?id=138257
1691
1692         Reviewed by Tim Horton.
1693         
1694         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1695         the user to toggle region page overlays on and off. Two overlays are available,
1696         for the non-fast scrollable region, and the region of element with wheel
1697         event handlers.
1698
1699         * MiniBrowser/mac/SettingsController.h:
1700         * MiniBrowser/mac/SettingsController.m:
1701         (-[SettingsController _populateMenu]):
1702         (-[SettingsController validateMenuItem:]):
1703         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1704         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1705         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1706         (-[SettingsController toggleDebugOverlay:]):
1707         (-[SettingsController debugOverlayVisible:]):
1708         * MiniBrowser/mac/WK2BrowserWindowController.m:
1709         (-[WK2BrowserWindowController didChangeSettings]):
1710
1711 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1712
1713         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1714         https://bugs.webkit.org/show_bug.cgi?id=138323
1715
1716         Reviewed by Zalan Bujtas.
1717
1718         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1719
1720 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1721
1722         [ninja] Don't remove response files for verbose builds
1723         https://bugs.webkit.org/show_bug.cgi?id=137816
1724
1725         Reviewed by Csaba Osztrogonác.
1726
1727         * Scripts/webkitdirs.pm:
1728         (determineNinjaVersion):
1729         (buildCMakeGeneratedProject):
1730
1731 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1732
1733         [GTK] Fix the build of FTL JIT
1734         https://bugs.webkit.org/show_bug.cgi?id=138298
1735
1736         Reviewed by Carlos Garcia Campos.
1737
1738         * gtk/jhbuild-optional.modules:
1739         Bump up LLVM version to 3.5.0 release and apply patches.
1740         * gtk/patches/llvm-elf-add-stackmaps.patch:
1741         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1742         trunk.
1743         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1744         Added. Ensures that PC-relative relocations in EH frames are not
1745         truncated to 32 bits on x86_64.
1746
1747 2014-10-31  Michael Saboff  <msaboff@apple.com>
1748
1749         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1750         https://bugs.webkit.org/show_bug.cgi?id=138268
1751
1752         Reviewed by Andreas Kling.
1753
1754         Added a --arch and --os option to set or override the values that are
1755         normally computed based on examining the JavaScriptCore we want to test.
1756
1757         * Scripts/run-jsc-stress-tests:
1758
1759 2014-10-31  Dan Bernstein  <mitz@apple.com>
1760
1761         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1762         https://bugs.webkit.org/show_bug.cgi?id=138259
1763
1764         Reviewed by Geoff Garen.
1765
1766         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1767         going to be empty to silence the warning.
1768
1769 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1770
1771         [GTK] Support script message handlers WebKitUserContentManager
1772         https://bugs.webkit.org/show_bug.cgi?id=133730
1773
1774         Reviewed by Carlos Garcia Campos.
1775
1776         Support user script message handlers in WebKitUserContentManager.
1777         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1778         an option is added to the CMake build files. The option is disabled
1779         globally by default, and the WebKitGTK port enables it. On the API
1780         level, two new methods to register and unregister names are provided
1781         in the "window.webkit" namespace, and on message reception the
1782         "WebKitUserContentManager::script-message-received" signal is
1783         emitted, using the registered names as signal detail.
1784
1785         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1786         Add test case for user script message handlers.
1787         (scriptMessageReceived):
1788         (testUserContentManagerScriptMessageReceived):
1789         (beforeAll):
1790
1791 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1792
1793         bisect-builds should support WebKit clients other than Safari
1794         https://bugs.webkit.org/show_bug.cgi?id=138225
1795
1796         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1797
1798         The -a / --application optional argument allows the user to specify which application (or application bundle)
1799         should be run against the WebKit nightly builds.
1800
1801         Reviewed by David Kilzer.
1802
1803         * Scripts/bisect-builds:
1804         Swap out $safariPath for the more general $applicationPath
1805         Leave --safari-path as a commandline option for backwards compatibility
1806         (mountAndRunNightly):
1807         Use File::Spec->cat correctly (one directory per argument)
1808         Use open --wait-apps instead of running the target application directly
1809
1810 2014-10-30  Dana Burkart  <dburkart@apple.com>
1811
1812         <rdar://problem/18821260> Perpare for the mysterious future
1813
1814         Reviewed by Lucas Forschler.
1815
1816         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1817         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1818         * LayoutTestRelay/Configurations/Base.xcconfig:
1819         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1820         * MiniBrowser/Configurations/Base.xcconfig:
1821         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1822         * TestWebKitAPI/Configurations/Base.xcconfig:
1823         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1824         * WebKitLauncher/Configurations/Base.xcconfig:
1825         * WebKitTestRunner/Configurations/Base.xcconfig:
1826         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1827
1828 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1829
1830         Update safariVersion to safariVersionString
1831         https://bugs.webkit.org/show_bug.cgi?id=138193
1832
1833         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1834         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1835
1836         Rubber-stamped by David Kilzer.
1837
1838         * Scripts/bisect-builds:
1839         (makeNightlyList):
1840         Compare safariVersionString to a string literal, instead of safariVersion.
1841
1842 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
1843
1844         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1845         https://bugs.webkit.org/show_bug.cgi?id=137775
1846
1847         Reviewed by Carlos Garcia Campos.
1848
1849         * MiniBrowser/gtk/BrowserWindow.c:
1850         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1851         (browser_window_init):
1852
1853 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
1854
1855         CommitQueue and EWS should reject any patches that result in consistent test
1856         failures that aren't present on the tree.
1857         https://bugs.webkit.org/show_bug.cgi?id=138184
1858
1859         Reviewed by Alexey Proskuryakov.
1860
1861         * Scripts/webkitpy/layout_tests/models/test_results.py:
1862         Adds a simple hashing function to allow for set operations to handle
1863         TestResult objects properly.
1864         (TestResult.__hash__):
1865         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1866         Adds one unit test, and modifies others to agree with the notion that
1867         patches that introduce new test failures (but also have flakyness)
1868         should be rejected rather than spin.
1869         (MockCommitQueue.report_flaky_tests):
1870         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1871         (test_double_flaky_test_failure):
1872         (test_two_flaky_tests):
1873         (test_very_flaky_patch):
1874         (test_very_flaky_patch_with_some_tree_redness):
1875         (test_different_test_failures):
1876         (test_different_test_failures_with_some_tree_redness):
1877         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
1878         (test_mildly_flaky_patch):
1879         (test_mildly_flaky_patch_with_some_tree_redness):
1880         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1881         Makes PatchAnalysisTask reject said patches.
1882         (PatchAnalysisTask._test_patch):
1883
1884 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1885
1886         WinCairoRequirements.zip cannot be downloaded from dropbox
1887         https://bugs.webkit.org/show_bug.cgi?id=138113
1888
1889         Reviewed by Alexey Proskuryakov.
1890
1891         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
1892
1893 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
1894
1895         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
1896         https://bugs.webkit.org/show_bug.cgi?id=138193
1897
1898         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
1899         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
1900
1901         It also does a bit of refactoring, including distinguishing between versions and version strings and
1902         saving versions to local variables instead of using eval in each conditional.
1903
1904         Reviewed by David Kilzer.
1905
1906         * Scripts/bisect-builds:
1907         (makeNightlyList):
1908         Restrict the set of nightlies to r174650 and above when running Yosemite.
1909         Restrict the set of nightlies to r157846 and above when running Mavericks.
1910         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
1911
1912 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1913
1914         [EFL] build-webkit should try harder to avoid re-running cmake
1915         https://bugs.webkit.org/show_bug.cgi?id=137949
1916
1917         Reviewed by Martin Robinson.
1918
1919         * Scripts/webkitdirs.pm:
1920         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
1921         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
1922
1923 2014-10-28  Daniel Bates  <dabates@apple.com>
1924
1925         Unify logic in RunTests.run() to run the Python unit tests
1926         https://bugs.webkit.org/show_bug.cgi?id=138160
1927
1928         Reviewed by Martin Robinson.
1929
1930         Unify the interactive and non-interactive code path for running the Python unit tests
1931         in step RunTests so as to remove duplicate code to compute the the path to the script
1932         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
1933
1934         No new tests since no functionality was changed.
1935
1936         * Scripts/webkitpy/port/base.py:
1937         (Port.python_unittest_results_directory):
1938         * Scripts/webkitpy/tool/steps/runtests.py:
1939         (RunTests.run):
1940
1941 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
1942
1943         Make runtest.py call test-webkitpy with the --json flag when in
1944         non-interactive mode.
1945         https://bugs.webkit.org/show_bug.cgi?id=137667
1946
1947         Reviewed by Daniel Bates.
1948
1949         * Scripts/webkitpy/port/base.py:
1950         Adds the python_unittest_results_directory method.
1951         (Port.python_unittest_results_directory):
1952         * Scripts/webkitpy/tool/steps/runtests.py:
1953         Changes RunTests to call test-webkitpy with the --json flag if the
1954         --non-interactive flag is set.
1955         (RunTests):
1956         (RunTests.run):
1957
1958 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
1959
1960         import-w3c-tests should use re.escape() wherever it's handling file paths
1961         https://bugs.webkit.org/show_bug.cgi?id=137934
1962
1963         This patch adds re.escape() to a few places where we're doing string
1964         conversions. This prevents errors when attribute values coincidentally
1965         have character sequences that can be interpreted as regular expressions.
1966
1967         Reviewed by Bem Jones-Bey.
1968
1969         * Scripts/webkitpy/w3c/test_converter.py:
1970         (_W3CTestConverter.convert_attributes_if_needed):
1971
1972 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1973
1974         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
1975         https://bugs.webkit.org/show_bug.cgi?id=138130
1976
1977         Reviewed by Csaba Osztrogonác.
1978
1979         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1980
1981 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
1982
1983         Fix link to Arch Linux Wiki
1984         https://bugs.webkit.org/show_bug.cgi?id=138010
1985
1986         Reviewed by Benjamin Poulain.
1987
1988         * gtk/install-dependencies:
1989
1990 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
1991
1992         Test regressions are not detected when image result is missing
1993         https://bugs.webkit.org/show_bug.cgi?id=138070
1994
1995         Reviewed by Simon Fraser.
1996
1997         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1998         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1999         Count these as regressions, not as flaky tests.
2000
2001         * Scripts/webkitpy/port/test.py:
2002         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2003         Test it.
2004
2005 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
2006
2007         Add Conrad Shultz to the contributors list.
2008
2009         * Scripts/webkitpy/common/config/contributors.json:
2010
2011 2014-10-24  Dan Bernstein  <mitz@apple.com>
2012
2013         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
2014         https://bugs.webkit.org/show_bug.cgi?id=138046
2015
2016         Reviewed by Alexey Proskuryakov.
2017
2018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2019         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
2020         401. Otherwise, we’ll retry normally in 45 seconds.
2021
2022 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2023
2024         [GTK] Implement is_selected method on WebKitHitTestResult
2025         https://bugs.webkit.org/show_bug.cgi?id=137110
2026
2027         Reviewed by Tim Horton.
2028
2029         Add tests for new context SELECTION on WebKitHitTestResult.
2030
2031         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2032         (testContextMenuDefaultMenu):
2033         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2034         (testWebViewMouseTarget):
2035
2036 2014-10-23  Roger Fong  <roger_fong@apple.com>
2037
2038         [Win] Skip failing JSC tests following r175078
2039         https://bugs.webkit.org/show_bug.cgi?id=130967.
2040
2041         * Scripts/run-javascriptcore-tests:
2042
2043 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2044
2045         commitqueuetask_unittest.py should be made more concise.
2046         https://bugs.webkit.org/show_bug.cgi?id=137985
2047
2048         Reviewed by Alexey Proskuryakov.
2049
2050         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2051         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
2052         (MockCommitQueue.__init__):
2053         (MockCommitQueue.report_flaky_tests):
2054         (MockCommitQueue):
2055         (MockCommitQueue.get_reported_flaky_tests):
2056         (MockSimpleTestPlanCommitQueue.__init__):
2057         (MockSimpleTestPlanCommitQueue.run_command):
2058         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
2059         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2060         (test_land_failure):
2061         (test_failed_archive):
2062         (test_double_flaky_test_failure):
2063         (test_test_failure):
2064         (test_red_test_failure):
2065         (test_very_red_tree_retry):
2066         (test_red_tree_patch_rejection):
2067         (test_one_flaky_test):
2068         (test_tree_more_red_than_patch):
2069         (MockCommitQueue.test_results): Deleted.
2070         (test_simple_flaky_test_failure): Deleted.
2071         (_expect_validate): Deleted.
2072         (_expect_validate.MockDelegate): Deleted.
2073         (_expect_validate.MockDelegate.refetch_patch): Deleted.
2074         (_expect_validate.MockDelegate.expected_failures): Deleted.
2075         (_mock_patch): Deleted.
2076         (test_validate): Deleted.
2077         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2078         Fixes a bug that slipped through the cracks prior to this change.
2079         (PatchAnalysisTask._test_patch):
2080
2081 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
2082
2083         Flakiness dashboard should support OS X Yosemite
2084         https://bugs.webkit.org/show_bug.cgi?id=137986
2085
2086         Reviewed by Ryosuke Niwa.
2087
2088         * TestResultServer/app.yaml:
2089         * TestResultServer/static-dashboards/builders.jsonp:
2090         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2091
2092 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2093
2094         commitqueuetask should include more tests to ensure that the behavior
2095         of PatchAnalysisTask._test_patch() is well defined
2096         https://bugs.webkit.org/show_bug.cgi?id=137977
2097
2098         Reviewed by Alexey Proskuryakov.
2099
2100         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2101         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
2102         and more readable to define tests that are meant to test the behaviour
2103         of PatchAnalysisTask._test_patch(), and adds several unit tests.
2104         (FailingTestCommitQueue.test_results):
2105         (PatchAnalysisResult):
2106         (MockSimpleTestPlanCommitQueue):
2107         (MockSimpleTestPlanCommitQueue.__init__):
2108         (MockSimpleTestPlanCommitQueue.run_command):
2109         (MockSimpleTestPlanCommitQueue._mock_test_result):
2110         (MockSimpleTestPlanCommitQueue.test_results):
2111         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2112         (test_flaky_test_failure):
2113         (test_failed_archive):
2114         (test_two_flaky_tests):
2115         (test_one_flaky_test):
2116         (test_very_flaky_patch):
2117         (test_very_flaky_patch_with_some_tree_redness):
2118         (test_different_test_failures):
2119         (test_different_test_failures_with_some_tree_redness):
2120         (test_mildly_flaky_patch):
2121         (test_mildly_flaky_patch_with_some_tree_redness):
2122         (test_tree_more_red_than_patch):
2123
2124 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2125
2126         PatchAnalysisTask._test_patch() needs refactoring
2127         https://bugs.webkit.org/show_bug.cgi?id=137904
2128
2129         Reviewed by Alexey Proskuryakov.
2130
2131         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2132         Fixes several small bugs, and makes minor changes to accomodate the
2133         changes in PatchAnalysisTask.
2134         (MockCommitQueue.refetch_patch):
2135         (MockCommitQueue.test_results):
2136         (test_flaky_test_failure):
2137         (test_failed_archive):
2138         (test_very_red_tree_retry):
2139         (_expect_validate.MockDelegate.refetch_patch):
2140         (MockCommitQueue.expected_failures): Deleted.
2141         (_expect_validate.MockDelegate.expected_failures): Deleted.
2142         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
2143         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
2144         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2145         Removes the unexpected_failures member, adds the _clean_tree_results
2146         member, adds a helper function for _test_patch, and refactors
2147         _test_patch to be more readable.
2148         (PatchAnalysisTask.__init__):
2149         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2150         (PatchAnalysisTask._test_patch):
2151         (PatchAnalysisTask.results_from_test_run_without_patch):
2152         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2153         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
2154         (AbstractEarlyWarningSystem.begin_work_queue):
2155         (AbstractEarlyWarningSystem._failing_tests_message):
2156         (AbstractEarlyWarningSystem.command_failed):
2157         (AbstractEarlyWarningSystem.expected_failures): Deleted.
2158         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2159         Makes changes to accomodate the changes made to PatchAnalysisTask.
2160         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2161         * Scripts/webkitpy/tool/commands/perfalizer.py:
2162         Removes Perfalizer's dependancy on ExpectedFailures. 
2163         (PerfalizerTask.refetch_patch):
2164         (PerfalizerTask.expected_failures): Deleted.
2165         * Scripts/webkitpy/tool/commands/queues.py:
2166         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
2167         initializer to allow for mock injection.
2168         (CommitQueue.__init__):
2169         (CommitQueue.begin_work_queue):
2170         (CommitQueue.process_work_item):
2171         (CommitQueue._failing_tests_message):
2172         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2173         Removes dependancy on ExpectedFailures, and instead uses mock
2174         injection.
2175         (MockCommitQueueTask):
2176         (MockCommitQueueTask.results_from_patch_test_run):
2177         (MockCommitQueueTask.results_from_test_run_without_patch):
2178         (mock_run_webkit_patch):
2179
2180 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
2181
2182         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
2183         https://bugs.webkit.org/show_bug.cgi?id=136736
2184
2185         Reviewed by Gyuyoung Kim.
2186
2187         * MiniBrowser/efl/main.c:
2188         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
2189         (window_create):
2190
2191 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2192
2193         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
2194         https://bugs.webkit.org/show_bug.cgi?id=137884
2195
2196         Reviewed by Gustavo Noronha Silva.
2197
2198         Move InputMethodFilter test from WebCore tests to WebKit2 tests
2199         and adapt it to use the new InputMethodFilter WebKit class. Instead
2200         of having virtual methods just for testing, it has a testing mode
2201         that logs the events.
2202
2203         * TestWebKitAPI/PlatformGTK.cmake:
2204         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
2205         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
2206         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
2207         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
2208         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
2209         (TestWebKitAPI::TEST):
2210         (TestWebKitAPI::temporaryGetPreeditStringOverride):
2211         (TestWebKitAPI::temporaryResetOverride):
2212         (TestWebKitAPI::verifyCanceledComposition):
2213
2214 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2215
2216         build.webkit.org/dashboard: Cannot click on green tester bubbles
2217         https://bugs.webkit.org/show_bug.cgi?id=137909
2218
2219         Reviewed by Darin Adler.
2220
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2222         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2223
2224 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2225
2226         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
2227         https://bugs.webkit.org/show_bug.cgi?id=137932
2228
2229         Reviewed by Simon Fraser.
2230
2231         This is the first step in moving over to native Windows rendering for our layout tests.
2232         Once this change lands, approximately 300 tests will start failing on Windows. I will
2233         rebaseline these changes against our test hardware and update this bug with the
2234         commits related to that work.
2235
2236         * DumpRenderTree/win/DumpRenderTree.cpp:
2237         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
2238         we use native Windows drawing style.
2239
2240 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2241
2242         Fix FTL Native Inlining for EFL
2243         https://bugs.webkit.org/show_bug.cgi?id=137774
2244
2245         Reviewed by Michael Saboff.
2246
2247         Added Clang as an optional module to jhbuild.
2248
2249         * efl/jhbuild.modules:
2250
2251 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2252
2253         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
2254         https://bugs.webkit.org/show_bug.cgi?id=137832
2255
2256         Reviewed by Carlos Garcia Campos.
2257
2258         Ensure each test sets the TLS errors policy that it really needs.
2259         Have each test except testTLSErrorsPolicy stash and restore the original
2260         TLS errors policy. Update testTLSErrorsPolicy to account for the new
2261         default policy.
2262
2263         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2264         (testSSL):
2265         (testInsecureContent):
2266         (testTLSErrorsPolicy):
2267         (testTLSErrorsRedirect):
2268         (testTLSErrorsHTTPAuth):
2269         (testLoadFailedWithTLSErrors):
2270         (beforeAll):
2271
2272 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2273
2274         Unreviewed. Unskip inspector server unit tests.
2275
2276         They should pass now.
2277
2278         * Scripts/run-gtk-tests:
2279         (TestRunner):
2280
2281 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2282
2283         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
2284         https://bugs.webkit.org/show_bug.cgi?id=132044
2285
2286         Reviewed by Brian Burg.
2287
2288         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2289         (openRemoteDebuggingSession): Remove trailing slash when
2290         concatenating base inspector URL with the page, because the
2291         inspector returns the relative paths with a leading slash.
2292
2293 2014-10-20  Tanay C  <tanay.c@samsung.com>
2294
2295         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
2296         https://bugs.webkit.org/show_bug.cgi?id=137023
2297
2298         Reviewed by Gyuyoung Kim.
2299
2300         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
2301         (search_box_show): Modified.
2302         (search_box_hide): Modified.
2303         (on_search_field_activated): Modified.
2304         (on_search_backward_button_clicked): Modified.
2305         (on_search_forward_button_clicked): Modified.
2306         (on_search_case_option_changed): Added.
2307         (on_search_word_start_option_changed): Added.
2308         (window_create): Modified.
2309
2310 2014-10-20  Tanay C  <tanay.c@samsung.com>
2311
2312         [GTK][Minibrowser] Escape key does not hide the search box
2313         https://bugs.webkit.org/show_bug.cgi?id=137734
2314
2315         Reviewed by Philippe Normand.
2316
2317         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
2318         (stopPageLoad): Modified.
2319
2320 2014-10-18  Antti Koivisto  <antti@apple.com>
2321
2322         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
2323         https://bugs.webkit.org/show_bug.cgi?id=137855
2324
2325         Reviewed by Dan Bernstein.
2326
2327         Test and warn if the dumped response mime type differs from the platform response mime type.
2328
2329         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2330         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2331         (WTR::InjectedBundlePage::platformResponseMimeType):
2332         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2333         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2334         (WTR::InjectedBundlePage::platformResponseMimeType):
2335
2336 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
2337
2338         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
2339         https://bugs.webkit.org/show_bug.cgi?id=137835
2340
2341         Reviewed by Andreas Kling.
2342
2343         * Scripts/run-inspector-perf-tests.py: Removed.
2344         This script is stale, as PerformanceTests/inspector no longer exists.
2345
2346 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2347
2348         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
2349
2350         * Scripts/webkitpy/port/ios.py:
2351         (IOSSimulatorPort.default_baseline_search_path):
2352
2353 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2354
2355         [iOS] Simplify test fallback paths for iOS Simulator testing
2356         https://bugs.webkit.org/show_bug.cgi?id=137830
2357
2358         Reviewed by Zalan Bujtas.
2359         
2360         Make the fallback paths be:
2361             ios-simulator -> generic
2362             ios-simulator-wk2->ios-simulator -> generic
2363         
2364         so don't include mac in the fallback path. Also remove the
2365         version handling for simplicity.
2366
2367         * Scripts/webkitpy/port/ios.py:
2368         (IOSSimulatorPort):
2369         (IOSSimulatorPort.default_baseline_search_path):
2370
2371 2014-10-17  Dana Burkart  <dburkart@apple.com>
2372
2373         Fix typos in the dashboard config file.
2374
2375         Unreviewed.
2376
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2378         (WebKitBuildbot):
2379
2380 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2381
2382         [Win] Allow WinLauncher to specify Custom User Agent strings
2383         https://bugs.webkit.org/show_bug.cgi?id=137828
2384
2385         Reviewed by Dean Jackson.
2386
2387         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2388         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2389         and set the user agent strings.
2390         * WinLauncher/WinLauncher.h:
2391         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2392         resources and dialog for setting custom User Agent strings.
2393         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2394
2395 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2396
2397         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2398         https://bugs.webkit.org/show_bug.cgi?id=137806
2399
2400         Reviewed by Sam Weinig.
2401
2402         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2403         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2404         to disable font autosizing.
2405         
2406         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2407         test controller to set platform-specific prefs.
2408
2409         * WebKitTestRunner/TestController.cpp:
2410         (WTR::TestController::resetPreferencesToConsistentValues):
2411         (WTR::TestController::platformResetPreferencesToConsistentValues):
2412         * WebKitTestRunner/TestController.h:
2413         * WebKitTestRunner/ios/TestControllerIOS.mm:
2414         (WTR::TestController::platformResetPreferencesToConsistentValues):
2415         * WebKitTestRunner/mac/TestControllerMac.mm:
2416         (WTR::TestController::platformResetPreferencesToConsistentValues):
2417
2418 2014-10-16  Dan Bernstein  <mitz@apple.com>
2419
2420         OSObjectPtr is missing leakRef()
2421         https://bugs.webkit.org/show_bug.cgi?id=137798
2422
2423         Reviewed by Sam Weinig.
2424
2425         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2426         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2427
2428 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2429
2430         Update target platform to remove Leopard, Snow Leopard, Lion.
2431         Add Yosemite. 
2432         
2433         Unreviewed.
2434
2435         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2436         (_should_file_trigger_build):
2437
2438 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2439
2440         commit-queue: fails to replace OO-PS! with reviewer name
2441         <http://webkit.org/b/137795>
2442
2443         Reviewed by Alexey Proskuryakov.
2444
2445         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2446         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2447         email addresses to unauthenticated page loads, so we must always
2448         authenticate before getting bug data so we get full email
2449         addresses.
2450
2451 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2452
2453         commit-queue: fails to close bugs after successfully landing patches
2454         <http://webkit.org/b/137794>
2455
2456         Reviewed by Alexey Proskuryakov.
2457
2458         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2459         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2460         tell Mechanize to use the second <textarea> on the page with
2461         name="comment".
2462
2463 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2464
2465         [Win] Update DRT to match Mac Logic
2466         https://bugs.webkit.org/show_bug.cgi?id=137787
2467
2468         Reviewed by Dean Jackson.
2469
2470         * DumpRenderTree/win/DumpRenderTree.cpp:
2471         (initialize): 0 -> nullptr
2472         (runTest): Initialize MSG structure before using.
2473         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2474         Also, cleanly shut down COM when exiting.
2475         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2476         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2477         header and add printf to match Mac.
2478         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2479         * DumpRenderTree/win/FrameLoadDelegate.h:
2480         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2481         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2482         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2483         (isLocalhost): Added.
2484         (hostIsUsedBySomeTestsToGenerateError): Added.
2485         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2486         of certain error and redirect host names.
2487         * DumpRenderTree/win/UIDelegate.cpp:
2488         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2489         anything should be output to the console. This modifies behavior to match the Mac.
2490         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2491         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2492         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2493         (UIDelegate::webViewAddMessageToConsole): Ditto.
2494         * WinLauncher/PageLoadTestClient.cpp:
2495         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2496         added last week.
2497
2498 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2499
2500         Unreviewed, rolling out r174754.
2501         https://bugs.webkit.org/show_bug.cgi?id=137789
2502
2503         Speculative fix for Windows test was ineffective. (Requested
2504         by rfong on #webkit).
2505
2506         Reverted changeset:
2507
2508         "[Windows] Add some more logging to debug Windows test
2509         issues."
2510         http://trac.webkit.org/changeset/174754
2511
2512 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2513
2514         Unreviewed, add myself to CoordinatedGraphics watchers.
2515
2516         * Scripts/webkitpy/common/config/watchlist:
2517
2518 2014-10-15  Roger Fong  <roger_fong@apple.com>
2519
2520         [Windows] Speculative Windows test fix.
2521
2522         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2523
2524 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2525
2526         import-w3c-test rewrites relative src paths in ref files incorrectly
2527         https://bugs.webkit.org/show_bug.cgi?id=137586
2528
2529         This patch fixes a bug in test_converter.py where src paths were getting 
2530         rewritten as ../../some-path instead of <script src="../../some-path>". 
2531         It also adds support for rewriting src paths in style  elements, which was 
2532         missing before and it adds tests for this case.
2533
2534         Reviewed by Bem Jones-Bey.
2535
2536         * Scripts/webkitpy/w3c/test_converter.py:
2537         (_W3CTestConverter.convert_attributes_if_needed):
2538         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2539         (test_convert_attributes_if_needed):
2540         (verify_reference_relative_paths):
2541
2542 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2543
2544         Add --json flag to test-webkitpy to emit JSON formatted test results
2545         to stdout
2546         https://bugs.webkit.org/show_bug.cgi?id=137353
2547
2548         Reviewed by Daniel Bates.
2549
2550         * Scripts/webkitpy/port/server_process_unittest.py:
2551         Adds the read method to MockFile to allow the stdout of test_webkitpy
2552         to be redirected without causing erroneous test failures.
2553         In particular,
2554         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2555         and
2556         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2557         because when redirecting to a file, the
2558         _wait_for_data_and_update_buffers_using_select method in 
2559         server_process.py will find that there is a read file descriptor in
2560         its call to select.select, which eventually leads to it calling read()
2561         on the MockFile object.
2562         (MockFile.read):
2563         * Scripts/webkitpy/test/main.py:
2564         Adds the _print_results_as_json method and the --json flag which
2565         determines whether _print_results_as_json will get called.
2566         (Tester._parse_args):
2567         (Tester._print_results_as_json):
2568         (Tester._print_results_as_json.result_dict_from_tuple):
2569         (Tester._run_tests):
2570
2571 2014-10-13  David Farler  <dfarler@apple.com>
2572
2573         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2574         https://bugs.webkit.org/show_bug.cgi?id=137662
2575
2576         Reviewed by Darin Adler.
2577
2578         The layout test harness can close LayoutTestRelay's subprocess
2579         stdout and stderr in the case of a timeout or if a run is
2580         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2581         finds that no one is listening to its stdout/stderr (broken
2582         pipe), then just exit(1), there is nothing to report.
2583
2584         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2585         (-[LTRelayController didReceiveStdoutData:]):
2586         Add @try/@catch for NSFileHandleOperationException.
2587         (-[LTRelayController didReceiveStderrData:]):
2588         Add @try/@catch for NSFileHandleOperationException.
2589
2590 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2591
2592         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2593         https://bugs.webkit.org/show_bug.cgi?id=137060
2594
2595         Reviewed by Philippe Normand.
2596
2597         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2598
2599         * MiniBrowser/gtk/BrowserWindow.c:
2600         (zoomInCallback):
2601         (zoomOutCallback):
2602         (defaultZoomCallback): Callback for default zoom keyboard support.
2603         (browser_window_init):
2604
2605 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2606
2607         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2608
2609         Reviewed by Alexey Proskuryakov.
2610         
2611         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2612         logging to stderr to get associated with the next test.
2613         
2614         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2615
2616         * DumpRenderTree/mac/DumpRenderTree.mm:
2617         (dumpTestResults):
2618         (runTest):
2619
2620 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2621
2622         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2623
2624         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2625
2626 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2627
2628         [cmake] Fix the make build after r174683
2629         https://bugs.webkit.org/show_bug.cgi?id=137703
2630
2631         Reviewed by Martin Robinson.
2632
2633         * Scripts/webkitdirs.pm:
2634         (buildCMakeGeneratedProject):
2635
2636 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2637
2638         Adding myself to the watchlist to CachedFont
2639
2640         Unreviewed.
2641
2642         * Scripts/webkitpy/common/config/watchlist:
2643
2644 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2645
2646         [EFL][GTK] Make it possible to get verbose output with ninja
2647         https://bugs.webkit.org/show_bug.cgi?id=137606
2648
2649         Reviewed by Csaba Osztrogonác.
2650
2651         * Scripts/webkitdirs.pm:
2652         (buildCMakeGeneratedProject):
2653
2654 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2655
2656         [EFL] Make it possible to use ninja for EFL build too
2657         https://bugs.webkit.org/show_bug.cgi?id=137605
2658
2659         Reviewed by Csaba Osztrogonác.
2660
2661         * Scripts/webkitdirs.pm:
2662         (generateBuildSystemFromCMakeProject):
2663         * efl/install-dependencies:
2664
2665 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2666
2667         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2668         https://bugs.webkit.org/show_bug.cgi?id=137486
2669
2670         Reviewed by Philippe Normand.
2671
2672         * MiniBrowser/gtk/BrowserWindow.c:
2673         (loadHomePage): Callback for home page load.
2674         (browser_window_init):
2675         * MiniBrowser/gtk/BrowserWindow.h:
2676         * MiniBrowser/gtk/main.c:
2677         (main):
2678
2679 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2680
2681         import-w3c-tests doesn't prefix property values
2682         https://bugs.webkit.org/show_bug.cgi?id=137600
2683
2684         Reviewed by Bem Jones-Bey.
2685
2686         Some property values are prefixed in WebKit. Modified the W3C import
2687         script in order to prefix property values and not only properties.
2688         The patch re-uses most of the already existent logic to prefix
2689         properties.
2690
2691         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2692         from CSSValueKeywords.in and adapt converter to modify both properties
2693         and property values.
2694         (convert_for_webkit):
2695         (_W3CTestConverter.__init__):
2696         (_W3CTestConverter.output):
2697         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2698         (_W3CTestConverter):
2699         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2700         (_W3CTestConverter.add_webkit_prefix_following_regex):
2701         (_W3CTestConverter.convert_reference_relpaths):
2702         (_W3CTestConverter.convert_style_data):
2703         (_W3CTestConverter.convert_attributes_if_needed):
2704         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2705         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2706         include checks for property values too.
2707         (W3CTestConverterTest.test_read_prefixed_property_list):
2708         (verify_no_conversion_happened):
2709         (verify_prefixed_properties):
2710         (verify_prefixed_property_values):
2711         (generate_test_content_properties_and_values):
2712         (generate_test_content):
2713         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2714         prefixed property values and inform about them.
2715         (TestImporter.import_tests):
2716         (TestImporter.write_import_log):
2717
2718 2014-10-13  Jer Noble  <jer.noble@apple.com>
2719
2720         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2721         https://bugs.webkit.org/show_bug.cgi?id=137533
2722
2723         Reviewed by Andy Estes.
2724
2725         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2726
2727         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2728         (TestWebKitAPI::isMSEEnabledCallback):
2729         (TestWebKitAPI::TEST):
2730
2731 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2732
2733         [Win] Implement a page load profiling tool
2734         https://bugs.webkit.org/show_bug.cgi?id=137673
2735
2736         Reviewed by Dean Jackson.
2737
2738         Add a tool to capture and summarize page load statistics.
2739
2740         * WinLauncher/Common.cpp:
2741         (parseCommandLine): Move from WinMain.cpp so that it can
2742         be shared with internal tools.
2743         * WinLauncher/PageLoadTestClient.cpp: Added.
2744         (PageLoadTestClient::PageLoadTestClient):
2745         (PageLoadTestClient::pageLoadStartedAtTime):
2746         (PageLoadTestClient::didStartProvisionalLoad):
2747         (PageLoadTestClient::didCommitLoad):
2748         (PageLoadTestClient::didFirstLayoutForMainFrame):
2749         (PageLoadTestClient::didHandleOnLoadEvents):
2750         (PageLoadTestClient::didFinishLoad):
2751         (PageLoadTestClient::didFailLoad):
2752         (PageLoadTestClient::didInitiateResourceLoad):
2753         (PageLoadTestClient::didEndResourceLoad):
2754         (PageLoadTestClient::pageLoadEndedAtTime):
2755         (PageLoadTestClient::endPageLoad):
2756         (PageLoadTestClient::clearPageLoadState):
2757         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2758         (PageLoadTestClient::maybeEndPageLoadSoon):
2759         (PageLoadTestClient::setPageURL):
2760         (PageLoadTestClient::dumpRunStatistics):
2761         * WinLauncher/PrintWebUIDelegate.cpp:
2762         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2763         nullptr URL properly.
2764         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2765         (ResourceLoadDelegate::QueryInterface):
2766         (ResourceLoadDelegate::AddRef):
2767         (ResourceLoadDelegate::Release):
2768         (ResourceLoadDelegate::identifierForInitialRequest):
2769         (ResourceLoadDelegate::willSendRequest):
2770         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2771         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2772         (ResourceLoadDelegate::didReceiveResponse):
2773         (ResourceLoadDelegate::didReceiveContentLength):
2774         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2775         (ResourceLoadDelegate::didFailLoadingWithError):
2776         (ResourceLoadDelegate::plugInFailedWithError):
2777         * WinLauncher/ResourceLoadDelegate.h: Added.
2778         (ResourceLoadDelegate::ResourceLoadDelegate):
2779         * WinLauncher/WinLauncher.cpp:
2780         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2781         page loading statistics.
2782         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2783         and set private load delegate state.
2784         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2785         that sets the view's resource load delegate.
2786         (WinLauncher::loadURL): If no URL is passed, load the test document.
2787         * WinLauncher/WinLauncher.h:
2788         (WinLauncher::pageLoadTestClient):
2789         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2790         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2791         * WinLauncher/WinLauncherWebHost.cpp:
2792         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2793         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2794         it could be used from other source files.
2795         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2796         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2797         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2798         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2799         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2800         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2801         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2802         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2803         * WinLauncher/WinLauncherWebHost.h:
2804         * WinLauncher/WinMain.cpp:
2805         (wWinMain): Create and use new delegates for gathering page load data.
2806         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2807
2808 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2809
2810         Improve the test image diffs page
2811         https://bugs.webkit.org/show_bug.cgi?id=137674
2812
2813         Reviewed by Alexey Proskuryakov.
2814         
2815         Don't treat the input file as a format string, otherwise we have to escape special
2816         characters. Just do a couple of replaces.
2817
2818         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2819         (TestResultWriter.write_image_diff_files):
2820
2821 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2822
2823         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2824         https://bugs.webkit.org/show_bug.cgi?id=137659
2825
2826         Reviewed by Martin Robinson.
2827
2828         * Scripts/webkitpy/port/xvfbdriver.py:
2829         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2830
2831 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2832
2833         Add more detailed wait time information to EWS metrics
2834         https://bugs.webkit.org/show_bug.cgi?id=137649
2835
2836         Reviewed by Daniel Bates.
2837
2838         Added average and worst time (we used to only have median), and also a percentage
2839         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2840
2841         There is always some wait due to the polling nature of the queues, which is well understood
2842         and doesn't need to be measured. What needs to be measured is whether there is enough
2843         bot machines to process patches as soon as they are submitted.
2844
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2846         (Analyzer.prototype._analyzeBubblePerformance):
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2848         (MetricsBubbleView.prototype._update):
2849
2850 2014-10-11  Jer Noble  <jer.noble@apple.com>
2851
2852         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2853         https://bugs.webkit.org/show_bug.cgi?id=137533
2854
2855         Reviewed by Darin Adler.
2856
2857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2858         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2859         (TestWebKitAPI::TEST):
2860         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
2861         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
2862
2863 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2864
2865         iOS DRT snapshots are limited to the page visible area
2866         https://bugs.webkit.org/show_bug.cgi?id=137650
2867
2868         Reviewed by Daniel Bates.
2869         
2870         LegacyTileCache drawing was limited to the window's visible area, found by
2871         crawling up the layer hierarchy to the root layer. This caused test snapshots to
2872         be missing non-composited content outside the iPhone visible area, which hinders
2873         testing.
2874         
2875         Fix by adding a test-only mode where the window visible area is the entire window.
2876         
2877         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2878         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
2879         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2880         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
2881         for the DRT window.
2882         
2883
2884 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
2885
2886         Page not fully rendered in iOS DRT snapshots
2887         https://bugs.webkit.org/show_bug.cgi?id=137638
2888
2889         Reviewed by Tim Horton.
2890         
2891         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
2892         to ensure that the page has laid out and is rendered by the time we take
2893         the snapshot.
2894
2895         * DumpRenderTree/mac/DumpRenderTree.mm:
2896         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
2897         (-[DumpRenderTree _webThreadInvoked]): Moved.
2898         (-[DumpRenderTree _waitForWebThreadThenDump]):
2899         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
2900         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
2901         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
2902         relies on dispatch_async too, and the inner block won't complete until the outer block
2903         has completed.
2904         (dumpTestResults): Move the guts of dump() here.
2905         (runTest): Whitespace.
2906
2907 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
2908
2909         Adding svn:ignore so that .pyc files don't show up as new.
2910
2911         * Scripts/webkitpy/xcode: Added property svn:ignore.
2912
2913 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
2914
2915         [EFL] Introduce EWebKit_Extension
2916         https://bugs.webkit.org/show_bug.cgi?id=134921
2917
2918         Reviewed by Gyuyoung Kim.
2919
2920         * MiniBrowser/efl/main.c: Added x option to test extension path.
2921         (window_create):
2922         (elm_main):
2923         * Scripts/webkitpy/common/config/watchlist:
2924         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2925         * Scripts/webkitpy/style/checker.py:
2926         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2927
2928 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
2929
2930         After r174628 we send the test process a SIGTERM before the SIGKILL.
2931
2932         * Scripts/webkitpy/common/system/executive_unittest.py:
2933         (ExecutiveTest.serial_test_kill_process):
2934
2935 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
2936
2937         [EFL] Enable WebP support.
2938         https://bugs.webkit.org/show_bug.cgi?id=136156
2939
2940         Reviewed by Gyuyoung Kim.
2941
2942         Include libwebp-dev package to support WebP for WK2 Efl.
2943
2944         * efl/install-dependencies:
2945
2946 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2947
2948         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
2949         https://bugs.webkit.org/show_bug.cgi?id=137485
2950
2951         Reviewed by Sergio Villar Senin.
2952
2953         Update GMainLoopSource tests. Most of the tests are now run twice,
2954         first with a GMainLoopSource and then with a
2955         GThreadSafeMainLoopSource, since both should have the same
2956         behaviour. The threading test uses GThreadSafeMainLoopSource and
2957         the delete on destroy test uses GMainLoopSource. The tests
2958         themselves haven't changed, since there's no change in behaviour.
2959
2960         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2961         (TestWebKitAPI::GMainLoopSourceTest::source):
2962         (TestWebKitAPI::basicRescheduling):
2963         (TestWebKitAPI::TEST):
2964         (TestWebKitAPI::reentrantRescheduling):
2965         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2966         (TestWebKitAPI::basicDestroyCallbacks):
2967         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2968         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2969
2970 2014-10-10  Dana Burkart  <dburkart@apple.com>
2971
2972         Fix fat-fingered function name in git-add-reviewer.
2973
2974         Unreviewed.
2975
2976         * Scripts/git-add-reviewer:
2977         (getConfigValue):
2978
2979 2014-10-10  David Farler  <dfarler@apple.com>
2980
2981         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
2982         https://bugs.webkit.org/show_bug.cgi?id=137528
2983
2984         Reviewed by Simon Fraser.
2985
2986         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
2987         and SIGKILL the paired simulator app before exiting cleanly.
2988
2989         webkitpy only uses SIGKILL to kill processes which you cannot
2990         catch. Send SIGTERM to the process and give it chance to do
2991         its thing before sending SIGKILL. Sending a SIGKILL to an already
2992         dead PID is safe.
2993
2994         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2995         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2996         (-[LTRelayController finish]):
2997         * LayoutTestRelay/LayoutTestRelay/main.m:
2998         (receivedSignal):
2999         (main):
3000
3001 2014-10-10  David Farler  <dfarler@apple.com>
3002
3003         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
3004         https://bugs.webkit.org/show_bug.cgi?id=137527
3005
3006         Reviewed by Simon Fraser.
3007
3008         NSFileHandle doesn't notify of EOF in its readability handler.
3009         Use a dispatch_source_t and an event handler that is called when reading is possible.
3010         In the handler block, do a run-of-the-mill read(2) from standard input and
3011         detect EOF in the usual way by checking that zero bytes were read.
3012
3013         Once an EOF is received, the FIFOs are disconnected, the simulator app
3014         is killed, and the relay exits with status 0.
3015
3016         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3017         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3018         (-[LTRelayController didDisconnect]):
3019         (-[LTRelayController didConnect]):
3020         (-[LTRelayController launchApp]):
3021         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
3022         confusion with this new dispatch source, called "standardInputDispatchSource".
3023         (-[LTRelayController finish]): Added.
3024         (-[LTRelayController readFileHandle:]): Deleted.
3025
3026 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3027
3028         [EFL] Crash on facebook.com
3029         https://bugs.webkit.org/show_bug.cgi?id=137562
3030
3031         Reviewed by Chris Dumez.
3032
3033         Crash occurs on the facebook.com when the webview is resized
3034         after the <select> item is clicked but no item is chosen.
3035         This crash is just caused by the reference of invalidated variable.
3036         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
3037         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
3038         on MiniBrowser is called.
3039         As a result, just set ewk_menu to NULL in order to prevent crash condition.
3040
3041         * MiniBrowser/efl/main.c:
3042         (on_popup_menu_hide):
3043
3044 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3045
3046         A small wording change for clarity.
3047
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3049         (MetricsBubbleView.prototype._update):
3050
3051 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3052
3053         Dashboard metrics page should have EWS statistics
3054         https://bugs.webkit.org/show_bug.cgi?id=137626
3055
3056         Reviewed by Ryosuke Niwa.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3059         (BubbleQueue): Put shortName in the object, so that it's actually useful.
3060
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3062         (BubbleQueueServer): Re-ordered queues to match bubble order.
3063         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
3064         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
3065
3066         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3067         Added analysis for bubble queues.
3068
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
3070
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3072         (buildBubbleQueuesTable): Build the UI.
3073
3074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3075         Added JS sources to load.
3076
3077         * QueueStatusServer/app.yaml: To update app version.
3078
3079         * QueueStatusServer/handlers/processingtimesjson.py: Added.
3080
3081         * QueueStatusServer/main.py: Added a handler for processing-times-json.
3082
3083 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3084
3085         REGRESSION: Commit queue doesn't process rollouts
3086         https://bugs.webkit.org/show_bug.cgi?id=137623
3087
3088         Reviewed by Tim Horton.
3089
3090         * QueueStatusServer/app.yaml:
3091         * QueueStatusServer/handlers/updateworkitems.py:
3092         (UpdateWorkItems._work_items_from_request):
3093
3094 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
3095
3096         Fix syntax error after r174601.
3097
3098         * Scripts/run-javascriptcore-tests:
3099
3100 2014-10-10  Michael Saboff  <msaboff@apple.com>
3101
3102         Add ability to select tarfile name in run-jsc-stress-tests
3103         https://bugs.webkit.org/show_bug.cgi?id=137614
3104
3105         Reviewed by Mark Hahnenberg.
3106
3107         Added optional file name argument to the --tarball option.  
3108
3109         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
3110         extra test given after the options wont be used for the optional tarball file name.
3111         * Scripts/run-jsc-stress-tests:
3112
3113 2014-10-10  Chris Dumez  <cdumez@apple.com>
3114
3115         Unreviewed, update my information in contributors.json
3116
3117         Use my preferred first name and update my expertise areas.
3118
3119         * Scripts/webkitpy/common/config/contributors.json:
3120
3121 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
3122
3123         Fix perl scripts to run with env on Linux
3124         https://bugs.webkit.org/show_bug.cgi?id=137601
3125
3126         Reviewed by Csaba Osztrogonác.
3127
3128         Use of arguments in #! is nonstandard and does not behave the same on
3129         different systems. Linux would look for an executable named "perl -w" 
3130         "use warnings;" does the same things in a more portable way.
3131
3132         * Scripts/commit-log-editor:
3133         * Scripts/num-cpus:
3134         * Scripts/prepare-ChangeLog:
3135         * Scripts/run-launcher:
3136         * Scripts/svn-create-patch:
3137
3138 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3139
3140         [jhbuild] We should be able to disable wiping on configuration change
3141         https://bugs.webkit.org/show_bug.cgi?id=137446
3142
3143         Reviewed by Csaba Osztrogonác.
3144
3145         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
3146         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
3147         or passing --no-wipe-on-change command line option.
3148
3149         * Scripts/update-webkit-libs-jhbuild:
3150
3151 2014-10-09  Andy Estes  <aestes@apple.com>
3152
3153         Teach webkitpy about OS X Yosemite
3154         https://bugs.webkit.org/show_bug.cgi?id=137585
3155
3156         Reviewed by Simon Fraser.
3157
3158         * Scripts/webkitpy/common/system/platforminfo.py:
3159         (PlatformInfo._determine_mac_version):
3160         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3161         (TestPlatformInfo.test_os_version):
3162         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3163         (TestExpectationParser):
3164         * Scripts/webkitpy/port/builders.py:
3165         * Scripts/webkitpy/port/mac.py:
3166         (MacPort):
3167         * Scripts/webkitpy/port/mac_unittest.py:
3168         (test_versions):
3169         (test_baseline_search_path):
3170         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3171         (TestRebaselineTest.test_baseline_directory):
3172         (TestRebaselineExpectations.test_rebaseline_expectations):
3173
3174 2014-10-09  Dana Burkart  <dburkart@apple.com>
3175
3176         Add Mac OS Yosemite dashboard support.
3177
3178         Rubber-stamped by Lucas Forschler.
3179
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
3181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
3182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3185
3186 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
3187
3188         Add Babak to contributors.json and add historical email addresses for some contributors
3189         https://bugs.webkit.org/show_bug.cgi?id=137546
3190
3191         Reviewed by Christophe Dumez.
3192
3193         contributors.json is used to analyze historical commit data and change logs.
3194
3195         Add back historical email addresses for some contributors and also add Babak (Shafiei).
3196
3197         * Scripts/webkitpy/common/config/contributors.json:
3198
3199 2014-10-09  Lucas Forschler  <lforschler@apple.com>
3200
3201         Add Mac OS Yosemite webkit build infrastructure.
3202         
3203         This patch adds 15 bots to our build.webkit.org configuration.
3204         We are matching the current Mavericks machines 1:1.
3205         
3206         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
3207         
3208         Reviewed by Matt Hanson.
3209
3210         * BuildSlaveSupport/build.webkit.org-config/config.json:
3211
3212 2014-10-09  Dana Burkart  <dburkart@apple.com>
3213
3214         Don't use backticks when running commands, as we run into sh-related
3215         interpolation issues. Also, fix our usage of system() to properly
3216         retrieve the status code.
3217         https://bugs.webkit.org/show_bug.cgi?id=137541
3218
3219         Reviewed by Darin Adler.
3220
3221         * Scripts/git-add-reviewer:
3222         (interactive):
3223         (nonInteractive):
3224         (requireCleanWorkTree):
3225         (cherryPick):
3226         (commit):
3227         (addReviewerToFile):
3228         (head):
3229         (isAncestor):
3230         (toCommit):
3231         (changeLogsForCommit):
3232         (resetToCommit):
3233         (getConfigValue):
3234         (runCommandWithOutput):
3235
3236 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3237
3238         Add a WebKit1 preference for selection services
3239         https://bugs.webkit.org/show_bug.cgi?id=137498
3240         <rdar://problem/18572699>
3241
3242         Reviewed by Simon Fraser.
3243
3244         * MiniBrowser/mac/WK1BrowserWindowController.m:
3245         (-[WK1BrowserWindowController awakeFromNib]):
3246         Turn on image and selection services in the Legacy WebKit MiniBrowser.
3247
3248 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
3249
3250         Get the patch scripts running on Haiku
3251         https://bugs.webkit.org/show_bug.cgi?id=137559
3252
3253         Reviewed by Benjamin Poulain.
3254
3255         Use /usr/bin/env instead of hardcoding path to perl.
3256         Declare haiku platform in platforminfo.py to avoid check-webkit-style
3257         failure.
3258
3259         * Scripts/commit-log-editor:
3260         * Scripts/num-cpus:
3261         * Scripts/prepare-ChangeLog:
3262         * Scripts/run-launcher:
3263         * Scripts/svn-create-patch:
3264         * Scripts/webkitpy/common/system/platforminfo.py:
3265         (PlatformInfo._determine_os_name):
3266
3267 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
3268
3269         StyleQueue should throw a PatchIsNotValid exception to achieve
3270         consistency with CommitQueue and EWS
3271         https://bugs.webkit.org/show_bug.cgi?id=137500
3272
3273         Reviewed by Alexey Proskuryakov.
3274
3275         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3276         Adds a call to validate() in run().
3277         (StyleQueueTask.run):
3278         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3279         Adds a return False in the patch is not valid exception statement.
3280         (AbstractEarlyWarningSystem.review_patch):
3281         * Scripts/webkitpy/tool/commands/queues.py:
3282         Adds a return False in the patch is not valid exception statement in
3283         commit queue, and adds an except statement to catch PatchIsNotValid
3284         exceptions in style queue.
3285         (CommitQueue.process_work_item):
3286         (StyleQueue.review_patch):
3287
3288 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3289
3290         Race condition with WebKitWebView:is-loading after starting page load
3291         https://bugs.webkit.org/show_bug.cgi?id=136692
3292
3293         Reviewed by Gustavo Noronha Silva.
3294
3295         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3296         (loadChangedCallback): Only check is-loading is false when load
3297         has finished if the load didn't fail due to a cancellation.
3298         (loadFailedCallback): Only check is-loading is false if the load
3299         didn't fail due to a cancellation.
3300         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3301         (WebViewTest::loadURI): Check is-loading is true and active URI is
3302         the requested one rigth after requesting the load.
3303         (WebViewTest::loadHtml): Ditto.
3304         (WebViewTest::loadPlainText): Ditto.
3305         (WebViewTest::loadBytes): Ditto.
3306         (WebViewTest::loadRequest): Ditto.
3307         (WebViewTest::loadAlternateHTML): Ditto.
3308         (WebViewTest::goBack): Ditto.
3309         (WebViewTest::goForward): Ditto.
3310         (WebViewTest::goToBackForwardListItem): Ditto.
3311
3312 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
3313
3314         [Win] Resolve various static analyzer warnings in Tools.
3315         https://bugs.webkit.org/show_bug.cgi?id=137534
3316
3317         Reviewed by Dean Jackson.
3318
3319         * DumpRenderTree/cg/ImageDiffCG.cpp:
3320         (main): User proper printf specifiers.
3321         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3322         (AccessibilityUIElement::childrenCount): Handle possibility that
3323         gcc_accChildCount returns with an error.
3324         (accessibilityState): Ditto for gcc_accState.
3325         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3326         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
3327         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
3328         be treated as such.
3329         * DumpRenderTree/win/DumpRenderTree.cpp:
3330         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
3331         by comparing an unsigned value as being greater-than zero.
3332         * DumpRenderTree/win/EditingDelegate.cpp:
3333         (dump): Pass proper character pointer type to printf.
3334         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
3335         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3336         (EditingDelegate::shouldInsertNode): Ditto.
3337         (EditingDelegate::shouldInsertText): Ditto.
3338         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3339         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3340         (EditingDelegate::shouldApplyStyle): Ditto.
3341         * DumpRenderTree/win/EventSender.cpp:
3342         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
3343         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
3344         system headers.
3345         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
3346         from CreateDIBSection.
3347         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
3348         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
3349         older versions of MSVC we no longer support.
3350         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
3351         for 64-bit builds.
3352         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
3353         * TestWebKitAPI/TestsController.h: Ditto.
3354         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
3355         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
3356         performing bitwise | before the comparison is done.
3357
3358 2014-10-08  Ada Chan  <adachan@apple.com>
3359
3360         Add a test for WKPageIsPlayingAudio().
3361         https://bugs.webkit.org/show_bug.cgi?id=137048
3362
3363         Reviewed by Darin Adler.
3364
3365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3366         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
3367         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
3368         (TestWebKitAPI::nullJavaScriptCallback):
3369         (TestWebKitAPI::didFinishLoadForFrame):
3370         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
3371         (TestWebKitAPI::setUpClients):
3372         (TestWebKitAPI::TEST):
3373         This test loads a page with a video in it. When the page is loaded, we first check that
3374         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3375         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3376         now returns true for the page.
3377         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3378         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3379         This is a video copied from LayoutTests/media/content.
3380
3381 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3382
3383         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3384         https://bugs.webkit.org/show_bug.cgi?id=137516
3385
3386         Reviewed by Alexey Proskuryakov.
3387
3388         * Scripts/webkitpy/thirdparty/__init__.py:
3389         (AutoinstallImportHook._install_irc):
3390
3391 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3392
3393         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3394         https://bugs.webkit.org/show_bug.cgi?id=137520
3395
3396         Reviewed by Philippe Normand.
3397
3398         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3399         For other distributions, we are already installing libjpeg-turbo.
3400         So, do the same for Debian and derivatives.
3401
3402         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3403
3404 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3405
3406         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3407         https://bugs.webkit.org/show_bug.cgi?id=137519
3408
3409         Reviewed by Csaba Osztrogonác.
3410
3411         It was removed by <http://trac.webkit.org/changeset/174266>,
3412         because the comment stated it is a workaround for buggy python
3413         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3414         is still valid with python 2.7 shipped on the latest Ubuntu
3415         (12.04 and 14.04) and OS X 10.9.
3416
3417         * Scripts/webkitpy/common/system/autoinstall.py:
3418         (AutoInstaller):
3419         (AutoInstaller._extract_all):
3420         (AutoInstaller._unzip):
3421
3422 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3423
3424         Unreviewed, rolling out r174335.
3425         https://bugs.webkit.org/show_bug.cgi?id=137515
3426
3427         It broke EFL layout test totally (Requested by gyuyoung on
3428         #webkit).
3429
3430         Reverted changeset:
3431
3432         "[EFL] Introduce EWebKit_Extension"
3433         https://bugs.webkit.org/show_bug.cgi?id=134921
3434         http://trac.webkit.org/changeset/174335
3435
3436 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3437
3438         [GTK] Make forwarding headers generation depend on source code
3439         https://bugs.webkit.org/show_bug.cgi?id=137394
3440
3441         Reviewed by Philippe Normand.
3442
3443         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3444         * TestWebKitAPI/PlatformGTK.cmake: Only run
3445         generate-forwarding-headers.pl when source code changes.
3446         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3447
3448 2014-10-07  Tanay C  <tanay.c@samsung.com>
3449
3450         Remove build warnings in Hashmap API tests
3451         https://bugs.webkit.org/show_bug.cgi?id=137484
3452
3453         Reviewed by Darin Adler.
3454
3455         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3456         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3457
3458 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3459
3460         Commit queue doesn't drop obsolete patches sometimes
3461         https://bugs.webkit.org/show_bug.cgi?id=137460
3462
3463         Reviewed by Alexey Proskuryakov.
3464
3465         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3466         Adds another test patch for use in queues_unittest.py.
3467         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3468         (MockBugzilla):
3469         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3470         Raises a PatchIsNotValid exception in the case of validate() returning
3471         false.
3472         (CommitQueueTask.run):
3473         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3474         Raises a PatchIsNotValid exception in the case of validate() returning
3475         false.
3476         (EarlyWarningSystemTask.run):
3477         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3478         Defines PatchIsNotValid exception. 
3479         (PatchIsNotValid):
3480         (PatchIsNotValid.__init__):
3481         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3482         Remove call to validate() and instead catches the PatchIsNotValid
3483         exception.
3484         (AbstractEarlyWarningSystem.review_patch):
3485         * Scripts/webkitpy/tool/commands/queues.py:
3486         Adds logic to catch the PatchIsNotValid exception.
3487         (CommitQueue.process_work_item):
3488         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3489         Adds the test_non_valid_patch test to ensure that invalid patches are
3490         handled properly, and don't just result in indefinite spinning.
3491         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3492         (test_non_valid_patch):
3493
3494 2014-10-07  Daniel Bates  <dabates@apple.com>
3495
3496         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
3497         https://bugs.webkit.org/show_bug.cgi?id=137499
3498
3499         Reviewed by Simon Fraser.
3500
3501         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
3502         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
3503         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
3504         bit simulator builds of iOS WebKit.
3505
3506         * Scripts/webkitpy/port/ios.py:
3507         (IOSSimulatorPort._generate_all_test_configurations):
3508
3509 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3510
3511         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
3512         https://bugs.webkit.org/show_bug.cgi?id=137482
3513
3514         Reviewed by Martin Robinson.
3515
3516         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
3517
3518 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3519
3520         [SOUP] TLS errors should take precedence over HTTP authentication
3521         https://bugs.webkit.org/show_bug.cgi?id=137300
3522
3523         Reviewed by Sergio Villar Senin.
3524
3525         Add a test case to check that authenticate signal is not emitted
3526         in case of TLS errors, and the load fails instead.
3527
3528         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3529         (webViewAuthenticationCallback):
3530         (testTLSErrorsHTTPAuth):
3531         (httpsServerCallback):
3532         (beforeAll):
3533
3534 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
3535
3536         Make webkit-patch find-users useful
3537         https://bugs.webkit.org/show_bug.cgi?id=137475
3538
3539         Reviewed by Alexey Proskuryakov.
3540
3541         Make find-users use the CommitterList instead of accessing Bugzilla.
3542
3543         This essentially exposes the same functionality as webkitbot's whois command.
3544
3545         * Scripts/webkitpy/tool/commands/findusers.py:
3546         (FindUsers.execute):
3547
3548 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
3549
3550         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3551         https://bugs.webkit.org/show_bug.cgi?id=137289
3552
3553         Unreviewed build fix.
3554
3555         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3556         (AccessibilityUIElement::getChildrenWithRange):
3557
3558 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3559
3560         build.webkit.org/dashboard: Add commit queue
3561         https://bugs.webkit.org/show_bug.cgi?id=137462
3562
3563         Reviewed by Tim Horton.
3564
3565         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3566         Style queue is still invisible, as it doesn't have an associated platform, and also
3567         we never have problems with it anyway, so it's not worth watching.
3568
3569         The UI now allows for adding more bots to the Other column (such as leaks bot).
3570         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3571         sources of data in a cell.
3572
3573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3574         (BubbleQueue):
3575         (BubbleQueue.prototype.get statusPageURL):
3576         (BubbleQueue.prototype.update):
3577         (BubbleQueue.prototype.loadDetailedStatus):
3578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3579         (BubbleQueueServer):
3580         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3581         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3582         (BubbleQueueServer.prototype.queueStatusURL):
3583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3584         (BubbleQueueView):
3585         (BubbleQueueView.prototype.update.appendQueue):
3586         (BubbleQueueView.prototype.update):
3587         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3588         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3589         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3596         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3597         (.bubble-server-popover .latest-status-no-link):
3598         (.bubble-server-popover .bot-status-description):
3599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3600
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3602         (buildAggregateTable):
3603         (buildQueuesTable):
3604         Removed dysfunctional support for EWS for now. It will be different.
3605
3606 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3607
3608         One more case of incorrect comparison in recordpatchevent.py
3609         https://bugs.webkit.org/show_bug.cgi?id=137459
3610
3611         Reviewed by Tim Horton.
3612
3613         * QueueStatusServer/app.yaml:
3614         * QueueStatusServer/loggers/recordpatchevent.py:
3615         (RecordPatchEvent.started):
3616
3617 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3618
3619         webkit-queues PatchLog is incorrect for patches that took less than a second
3620         https://bugs.webkit.org/show_bug.cgi?id=137453
3621
3622         Reviewed by Tim Horton.
3623
3624         * QueueStatusServer/app.yaml: Updated app version.
3625
3626         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3627         Don't bail out for patches that took 0 seconds to process (as frequently happens
3628         when a patch is obsolete).