[CMake] Properly test if compiler supports compiler flags
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [CMake] Properly test if compiler supports compiler flags
4         https://bugs.webkit.org/show_bug.cgi?id=174490
5
6         Reviewed by Konstantin Tokarev.
7
8         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
9         * MiniBrowser/gtk/CMakeLists.txt:
10         * TestRunnerShared/Bindings/JSWrapper.cpp:
11         (WTR::JSWrapper::initialize):
12         * TestWebKitAPI/CMakeLists.txt:
13         * TestWebKitAPI/PlatformGTK.cmake:
14         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
15         (TestWebKitAPI::CheckedArithmeticTester::run):
16         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
17         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
18         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
19         (formControlsAssociatedCallback):
20         * TestWebKitAPI/glib/CMakeLists.txt:
21         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
22         (Test::getResourcesDir):
23         * WebKitTestRunner/CMakeLists.txt:
24         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
25         (WTR::menuItemClickCallback):
26         (WTR::staticConvertMenuItemToType):
27         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
28         (WTR::TestRunner::setUseDashboardCompatibilityMode):
29         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
30         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
31         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
32         (WTR::AccessibilityUIElement::helpText const):
33         (WTR::AccessibilityUIElement::attributedStringForRange):
34         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
35         (WTR::EventSenderProxy::updateTouchPoint):
36         (WTR::EventSenderProxy::releaseTouchPoint):
37
38 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
39
40         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
41         https://bugs.webkit.org/show_bug.cgi?id=175116
42         <rdar://problem/28279301>
43
44         Reviewed by Darin Adler and Ryosuke Niwa.
45
46         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
47         EditorStateTests run on both iOS and Mac.
48
49         * TestWebKitAPI/EditingTestHarness.h: Added.
50         * TestWebKitAPI/EditingTestHarness.mm: Added.
51
52         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
53         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
54         the state of the latest observed EditorState.
55
56         (-[EditingTestHarness initWithWebView:]):
57         (-[EditingTestHarness dealloc]):
58         (-[EditingTestHarness webView]):
59         (-[EditingTestHarness latestEditorState]):
60         (-[EditingTestHarness editorStateHistory]):
61         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
62         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
63         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
64         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
65         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
66         (-[EditingTestHarness toggleBold]):
67         (-[EditingTestHarness toggleItalic]):
68         (-[EditingTestHarness toggleUnderline]):
69         (-[EditingTestHarness setForegroundColor:]):
70         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
71         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
72         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
73         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
74         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
75         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
76         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
77
78         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
79         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
80         keys and values.
81
82         (-[EditingTestHarness latestEditorStateContains:]):
83         (-[EditingTestHarness _webView:editorStateDidChange:]):
84         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
85         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
86         (TestWebKitAPI::setUpEditorStateTestHarness):
87         (TestWebKitAPI::TEST):
88         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
89
90 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
91
92         Prevent domain from being set to a TLD
93         https://bugs.webkit.org/show_bug.cgi?id=175226
94         <rdar://problem/11079948>
95
96         Reviewed by Chris Dumez.
97
98         Extend the public suffix tests to include cases used by the
99         Public Domain 'Public Suffix List'.
100
101         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
102         (TestWebKitAPI::TEST):
103
104 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
105
106         [XCode] webkit-patch should run sort-Xcode-project-file
107         https://bugs.webkit.org/show_bug.cgi?id=174036
108         <rdar://problem/33732709>
109
110         Reviewed by Simon Fraser.
111
112         * Scripts/webkitpy/common/config/ports.py:
113         * Scripts/webkitpy/tool/commands/download.py:
114         * Scripts/webkitpy/tool/commands/download_unittest.py:
115         * Scripts/webkitpy/tool/commands/upload.py:
116         * Scripts/webkitpy/tool/commands/upload_unittest.py:
117         * Scripts/webkitpy/tool/steps/__init__.py:
118         * Scripts/webkitpy/tool/steps/options.py:
119         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
120
121 2017-08-07  Devin Rousso  <drousso@apple.com>
122
123         Web Inspector: Preview Canvas path when viewing a recording
124         https://bugs.webkit.org/show_bug.cgi?id=174967
125
126         Reviewed by Brian Burg.
127
128         * DumpRenderTree/TestOptions.h:
129         * DumpRenderTree/TestOptions.mm:
130         (TestOptions::TestOptions):
131         * DumpRenderTree/mac/DumpRenderTree.mm:
132         (setWebPreferencesForTestOptions):
133         * WebKitTestRunner/TestController.cpp:
134         (WTR::TestController::resetPreferencesToConsistentValues):
135         (WTR::updateTestOptionsFromTestHeader):
136         * WebKitTestRunner/TestOptions.h:
137         (WTR::TestOptions::hasSameInitializationOptions const):
138         Add plumbing for new InspectorAdditions runtime flag.
139
140 2017-08-07  obinna obike  <oobike@apple.com>
141
142         Sorted EWS Queues on Patch page
143         https://bugs.webkit.org/show_bug.cgi?id=173667
144
145         Reviewed by Aakash Jain.
146
147         * QueueStatusServer/handlers/patch.py:
148         (Patch.get): Sorted queue_status.
149         * QueueStatusServer/templates/patch.html:
150         Changed queue_status.items to queue_status because it's a list.
151
152 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
153
154         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
155         https://bugs.webkit.org/show_bug.cgi?id=175286
156
157         Reviewed by Myles C. Maxfield.
158
159         * Scripts/webkitpy/style/checkers/cpp.py:
160         (check_braces):
161         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
162         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
163         (WebKitStyleTest.test_braces):
164         (WebKitStyleTest.test_braces.NS_OPTIONS):
165
166 2017-08-07  Brian Burg  <bburg@apple.com>
167
168         Remove CANVAS_PATH compilation guard
169         https://bugs.webkit.org/show_bug.cgi?id=175207
170
171         Reviewed by Sam Weinig.
172
173         * Scripts/webkitperl/FeatureList.pm:
174         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
175
176 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
177
178         [Win] Use Visual Studio 2017 if installed.
179         https://bugs.webkit.org/show_bug.cgi?id=175188
180
181         Reviewed by Sam Weinig.
182
183         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
184
185         * Scripts/webkitdirs.pm:
186         (visualStudioInstallDir):
187         (msBuildInstallDir):
188
189 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
190
191         [GTK][WPE] Add API to provide browser information required by automation
192         https://bugs.webkit.org/show_bug.cgi?id=175130
193
194         Reviewed by Michael Catanzaro.
195
196         * MiniBrowser/gtk/main.c:
197         (automationStartedCallback): Set browser information when a new automation session is started.
198         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
199         (testAutomationSessionApplicationInfo):
200         (beforeAll):
201
202 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
203
204         Unreviewed, rolling out r220295.
205
206         This change introduced 4 errors in webkitpy tests.
207
208         Reverted changeset:
209
210         "[XCode] webkit-patch should run sort-Xcode-project-file"
211         https://bugs.webkit.org/show_bug.cgi?id=174036
212         http://trac.webkit.org/changeset/220295
213
214 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
215
216         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
217
218         Unreviewed test gardening.
219
220         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
221         (TestWebKitAPI::TEST):
222
223 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
224
225         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
226         https://bugs.webkit.org/show_bug.cgi?id=175083
227
228         Reviewed by Oliver Hunt.
229         
230         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
231         to wait for VM destructions to finish before running the next test. This makes it easier to 
232         understand leaks results from workers tests, and leads to fewer reported leaks.
233
234         * DumpRenderTree/mac/DumpRenderTree.mm:
235         (runTest):
236
237 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
238
239         check-webkit-style: fix path-specific rules for WebKit2 rename
240         https://bugs.webkit.org/show_bug.cgi?id=175182
241
242         Reviewed by David Kilzer.
243
244         * Scripts/webkitpy/style/checker.py:
245
246 2017-08-04  Youenn Fablet  <youenn@apple.com>
247
248         [Cache API] Add Cache and CacheStorage IDL definitions
249         https://bugs.webkit.org/show_bug.cgi?id=175201
250
251         Reviewed by Brady Eidson.
252
253         * DumpRenderTree/mac/DumpRenderTree.mm:
254         (enableExperimentalFeatures):
255         (resetWebPreferencesToConsistentValues):
256         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
257         (WTR::InjectedBundle::beginTesting):
258         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
259         (WTR::TestRunner::setCacheAPIEnabled):
260         * WebKitTestRunner/InjectedBundle/TestRunner.h:
261
262 2017-08-04  John Wilander  <wilander@apple.com>
263
264         Resource Load Statistics: Report user interaction immediately, but only when needed
265         https://bugs.webkit.org/show_bug.cgi?id=175090
266         <rdar://problem/33685546>
267
268         Reviewed by Chris Dumez.
269
270         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
271         (WTR::InjectedBundle::beginTesting):
272             Now calls WebCore::ResourceLoadObserver::clearState().
273
274 2017-08-04  Tim Horton  <timothy_horton@apple.com>
275
276         Add an API test for r220286
277         https://bugs.webkit.org/show_bug.cgi?id=175206
278
279         Reviewed by Simon Fraser.
280
281         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
282         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
283         (createAnimatedResizeWebView):
284         (TEST):
285         Add a test to ensure that we don't call
286         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
287         animated resize.
288
289 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
290
291         [XCode] webkit-patch should run sort-Xcode-project-file
292         https://bugs.webkit.org/show_bug.cgi?id=174036
293
294         Reviewed by Simon Fraser.
295
296         * Scripts/webkitpy/common/config/ports.py:
297         * Scripts/webkitpy/tool/commands/download.py:
298         * Scripts/webkitpy/tool/commands/upload.py:
299         * Scripts/webkitpy/tool/steps/__init__.py:
300         * Scripts/webkitpy/tool/steps/options.py:
301         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
302
303 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
304
305         REGRESSION(r219857): run-benchmark --allplans broken
306         https://bugs.webkit.org/show_bug.cgi?id=175186
307
308         Reviewed by Saam Barati.
309
310         r219857 forgot to update also the calls to BenchmarkRunner() that
311         is done when the script is run with --allplans.
312
313         To fix this (and avoid future issues like this), let's factorize
314         the calls to the benchhmark runner in a run_benchmark_plan()
315         function.
316
317         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
318         (run_benchmark_plan):
319         (start):
320
321 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
322
323         Dashboard bubbles sometimes show failure count instead of crash count
324         https://bugs.webkit.org/show_bug.cgi?id=175157
325         <rdar://problem/33709009>
326
327         Reviewed by Alexey Proskuryakov.
328
329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
330         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
331
332 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
333
334         Add tests for NeverDestroyed
335         https://bugs.webkit.org/show_bug.cgi?id=175146
336
337         Reviewed by Darin Adler.
338
339         * CMakeLists.txt:
340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
341         New files and sort.
342
343         * TestWebKitAPI/Tests/WTF/Logger.h:
344         * TestWebKitAPI/Tests/WTF/Logger.cpp:
345         (TestWebKitAPI::log):
346         (TestWebKitAPI::takeLogStr):
347         * TestWebKitAPI/Tests/WTF/RefLogger.h:
348         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
349         (TestWebKitAPI::log): Deleted.
350         (TestWebKitAPI::takeLogStr): Deleted.
351         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
352
353         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
354         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
355         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
356         (TestWebKitAPI::LifecycleLogger::operator=):
357         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
358         (TestWebKitAPI::LifecycleLogger::setName):
359         (TestWebKitAPI::TEST):
360         Add a class that logs construction / assignment / modifications.
361
362         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
363         (TestWebKitAPI::TEST):
364         (TestWebKitAPI::list):
365         Test construction behavior is as expected both directly and using makeNeverDestroyed.
366
367 2017-08-04  Lucas Forschler  <lforschler@apple.com>
368
369         minification logic is not implemented for ios builds
370         <rdar://problem/33726561>
371
372         Reviewed by Dean Johnson
373
374         * BuildSlaveSupport/built-product-archive:
375         (minifyDirectory): refactor minifySource -> minifyDirectory
376         (archiveBuiltProduct): add ios minification logic
377         (minifySource): Deleted.
378
379 2017-08-04  Matt Lewis  <jlewis3@apple.com>
380
381         Unreviewed, rolling out r220271.
382
383         Rolling out due to Layout Test failing on iOS Simulator.
384
385         Reverted changeset:
386
387         "Remove STREAMS_API compilation guard"
388         https://bugs.webkit.org/show_bug.cgi?id=175165
389         http://trac.webkit.org/changeset/220271
390
391 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
392
393         Unreviewed, rolling out r220268.
394
395         This change caused assertion failures on macOS and iOS Debug
396         WK2.
397
398         Reverted changeset:
399
400         "Resource Load Statistics: Report user interaction
401         immediately, but only when needed"
402         https://bugs.webkit.org/show_bug.cgi?id=175090
403         http://trac.webkit.org/changeset/220268
404
405 2017-08-04  Youenn Fablet  <youenn@apple.com>
406
407         Remove STREAMS_API compilation guard
408         https://bugs.webkit.org/show_bug.cgi?id=175165
409
410         Reviewed by Darin Adler.
411
412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
413
414 2017-08-04  John Wilander  <wilander@apple.com>
415
416         Resource Load Statistics: Report user interaction immediately, but only when needed
417         https://bugs.webkit.org/show_bug.cgi?id=175090
418         <rdar://problem/33685546>
419
420         Reviewed by Chris Dumez.
421
422         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
423         (WTR::InjectedBundle::beginTesting):
424             Now calls WebCore::ResourceLoadObserver::clearState().
425
426 2017-08-03  Brian Burg  <bburg@apple.com>
427
428         Remove ENABLE(WEB_SOCKET) guards
429         https://bugs.webkit.org/show_bug.cgi?id=167044
430
431         Reviewed by Joseph Pecoraro.
432
433         * Scripts/webkitperl/FeatureList.pm:
434         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
435
436 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
437
438         REGRESSION(r219850): run-benchmark script broken on Linux
439         https://bugs.webkit.org/show_bug.cgi?id=175126
440
441         Reviewed by Stephanie Lewis.
442
443         The run-benchmark script dynamically generates the list of supported
444         browsers and platforms (currently Linux and OSX) by loading all
445         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
446         and getting the browser_name and platform variables from the
447         classes defined there.
448
449         This means that this classes should not raise an exception when
450         loaded on other platforms or otherwise they will broke the whole
451         script. Its fine if they raise an exception when executing any of
452         the methods they implement, but not when just loading/importing
453         the class.
454
455         Move the argument variable definitions that call on the platform
456         specific OSXBrowserDriver._screen_size() function from beeing
457         variables that are evaluated when loading the file, to be functions
458         that are only evaluated when the actual functionality needs to be
459         executed.
460
461         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
462         (OSXChromeDriver.launch_url):
463         (OSXChromeCanaryDriver.launch_url):
464         (create_args):
465         (create_chrome_options):
466         (create_window_size_arg):
467         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
468         (OSXFirefoxDriver.launch_url):
469         (OSXFirefoxNightlyDriver.launch_url):
470         (OSXFirefoxNightlyDriver.launch_driver):
471         (create_args):
472
473 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
474
475         [PAL] Move spi/cf directory into PAL
476         https://bugs.webkit.org/show_bug.cgi?id=175057
477
478         Reviewed by Antti Koivisto.
479
480         * Scripts/webkitpy/style/checker.py:
481         * Scripts/webkitpy/style/checker_unittest.py:
482         (GlobalVariablesTest.test_path_rules_specifier):
483
484         Ignore "readability/naming/underscores" style errors for sources
485         under the WebCore/PAL/pal/spi directory.
486
487         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
488
489 2017-08-03  Youenn Fablet  <youenn@apple.com>
490
491         Remove FETCH_API compilation guard
492         https://bugs.webkit.org/show_bug.cgi?id=175154
493
494         Reviewed by Chris Dumez.
495
496         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
497
498 2017-08-03  Lucas Forschler  <lforschler@apple.com>
499
500         Enable archive minification on iOS builds
501         https://bugs.webkit.org/show_bug.cgi?id=174718
502         
503         Reviewed by Aakash Jain.
504
505         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
506         (BuildFactory.__init__):
507
508 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
509
510         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
511         https://bugs.webkit.org/show_bug.cgi?id=175140
512
513         Reviewed by Alexey Proskuryakov.
514
515         We are having lately issues with JSC tests causing problems on
516         the GTK+ and WPE bots due to the high amount of memory some tests
517         need to run.
518
519         The best thing we can do now is to workaround this by disabling
520         all the tests marked as memoryLimited on the GTK and WPE bots.
521         We may revise this on the future.
522
523         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
524         (RunJavaScriptCoreTests.start):
525
526 2017-08-03  Brady Eidson  <beidson@apple.com>
527
528         Add SW IDLs and stub out basic functionality.
529         https://bugs.webkit.org/show_bug.cgi?id=175115
530
531         Reviewed by Chris Dumez.
532
533         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
534
535         * Scripts/webkitpy/bindings/main.py:
536
537 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
538
539         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
540         https://bugs.webkit.org/show_bug.cgi?id=159510
541
542         Reviewed by Daniel Bates.
543
544         Allow any https certificate when running tests.
545
546         * DumpRenderTree/win/DumpRenderTree.cpp:
547         (runTest):
548
549 2017-08-02  Youenn Fablet  <youenn@apple.com>
550
551         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
552         https://bugs.webkit.org/show_bug.cgi?id=175089
553
554         Reviewed by Chris Dumez.
555
556         * DumpRenderTree/TestOptions.mm:
557         (TestOptions::TestOptions): Using absolutePath if available.
558         * DumpRenderTree/mac/DumpRenderTree.mm:
559         (computeTestURL): Removing http/tests/ specific URL computation.
560         * Scripts/webkitpy/port/driver.py:
561         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
562
563 2017-08-02  Lucas Forschler  <lforschler@apple.com>
564
565         download-built-product should allow for a proxy option
566         https://bugs.webkit.org/show_bug.cgi?id=174875
567
568         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
569
570         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
571         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
572         
573
574 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
575
576         check-webkit-style: deleting lines in a file runs the linter on the whole file
577         https://bugs.webkit.org/show_bug.cgi?id=175078
578
579         Reviewed by David Kilzer.
580
581         Deleting lines in a file should not cause linter errors to be blamed on the patch.
582         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
583
584         * Scripts/webkitpy/style/checkers/test_expectations.py:
585         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
586         * Scripts/webkitpy/style/main_unittest.py:
587         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
588         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
589         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
590
591 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
592
593         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
594         https://bugs.webkit.org/show_bug.cgi?id=175075
595
596         Reviewed by David Kilzer.
597
598         We have no way of handling text files with illegal unicode characters. Allow the callers of
599         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
600         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
601
602         * Scripts/webkitpy/common/system/filesystem.py:
603         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
604         (FileSystem.write_text_file): Ditto.
605         * Scripts/webkitpy/common/system/filesystem_mock.py:
606         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
607         (MockFileSystem.write_text_file): Ditto.
608         * Scripts/webkitpy/common/system/filesystem_unittest.py:
609         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
610         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
611
612 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
613
614         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
615         https://bugs.webkit.org/show_bug.cgi?id=175072
616
617         Reviewed by Alexey Proskuryakov.
618
619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
620         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
621
622 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
623
624         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
625         https://bugs.webkit.org/show_bug.cgi?id=175019
626
627         Reviewed by Darin Adler.
628
629         * TestWebKitAPI/CMakeLists.txt:
630
631 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
632
633         Enabling uploading archives to S3
634         https://bugs.webkit.org/show_bug.cgi?id=174198
635
636         Unreviewed unit test fix after r219235.
637
638         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
639
640 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
641
642         Fix JSCOnly ARM buildbots after r220047
643         https://bugs.webkit.org/show_bug.cgi?id=174993
644
645         Unreviewed fix after r220087.
646
647         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
648         (BuildAndRemoteJSCTestsFactory.__init__):
649
650 2017-08-01  Chris Dumez  <cdumez@apple.com>
651
652         Add initial support for navigator.sendBeacon
653         https://bugs.webkit.org/show_bug.cgi?id=175007
654         <rdar://problem/33547728>
655
656         Reviewed by Sam Weinig.
657
658         Enable the Beacon API at runtime in the context of layout tests since the
659         feature is currently disabled by default.
660
661         * DumpRenderTree/mac/DumpRenderTree.mm:
662         (enableExperimentalFeatures):
663         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
664         (WTR::InjectedBundle::beginTesting):
665         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
666         (WTR::TestRunner::setModernMediaControlsEnabled):
667         (WTR::TestRunner::setBeaconAPIEnabled):
668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
669
670 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
671
672         Update Bot Watcher's Dashboard for Buildbot 0.9
673         https://bugs.webkit.org/show_bug.cgi?id=174777
674
675         Reviewed by Daniel Bates.
676
677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
678         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
679         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
680         in a dictionary.
681         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
682         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
684         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
685         (parseRevisionProperty): Ditto.
686         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
687         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
688         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
689         have changed in Buildbot 0.9.
690         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
691         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
692         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
693         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
694         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
695         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
696         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
697         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
698         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
699         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
701         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
702         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
703         (BuildbotQueue.prototype.get overviewURL): Ditto.
704         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
705         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
706         Buildbot 0.8 or 0.9.
707         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
708         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
709         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
710         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
711         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
712         Therefore we are fetching information for fixed number of build. 
713         Also iterating the loop incrementally since the build data is already reverse sorted.
714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
715         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
716         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
717         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
718         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
719
720 2017-08-01  Devin Rousso  <drousso@apple.com>
721
722         Web Inspector: simplify WebInspector with WI
723         https://bugs.webkit.org/show_bug.cgi?id=175058
724
725         Reviewed by Joseph Pecoraro.
726
727         * Scripts/check-inspector-strings:
728         (extract_ui_strings):
729         * Scripts/extract-localizable-js-strings:
730
731 2017-08-01  Youenn Fablet  <youenn@apple.com>
732
733         Layout tests with 'https' suffix should be run over HTTPS
734         https://bugs.webkit.org/show_bug.cgi?id=174992
735
736         Reviewed by Chris Dumez.
737
738         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
739         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
740         Covered by corresponding unit tests.
741
742         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
743         (run_server):
744         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
745         (base_http_url):
746         (base_https_url):
747         (base_url): Deleted.
748         * Scripts/webkitpy/port/base.py:
749         (Port.to.web_platform_test_server_base_http_url):
750         (Port.to):
751         (Port.to.web_platform_test_server_base_https_url):
752         (Port.to.web_platform_test_server_base_url): Deleted.
753         * Scripts/webkitpy/port/driver.py:
754         (Driver.__init__):
755         (Driver.wpt_test_path_to_uri):
756         (Driver):
757         (Driver.http_test_path_to_uri):
758         (Driver.test_to_uri):
759         (Driver.uri_to_test):
760         * Scripts/webkitpy/port/driver_unittest.py:
761         (DriverTest.test_test_to_uri):
762         (DriverTest.test_uri_to_test):
763
764 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
765
766         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
767         https://bugs.webkit.org/show_bug.cgi?id=173998
768
769         Reviewed by Darin Adler.
770
771         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
772         detect mistakes in backward compatibility in the future when we change it.
773
774         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
775         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
776         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
777         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
778         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
779         internal key data slot.
780
781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
782         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
783         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
784         (getNextMessage):
785         (TEST):
786         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
787         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
788         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
789         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
790         These are the pre-baked databases.
791         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
792         This is the actual test that do all the reads and comparisons.
793         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
794         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
795         IndexedDB new stuffs. Then it can be used to bake the database again.
796
797 2017-08-01  Brady Eidson  <beidson@apple.com>
798
799         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
800         https://bugs.webkit.org/show_bug.cgi?id=175030
801
802         Reviewed by Andy Estes.
803
804         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
805         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
806
807 2017-08-01  Brady Eidson  <beidson@apple.com>
808
809         Part 2 of: Rename DatabaseProcess to StorageProcess.
810         https://bugs.webkit.org/show_bug.cgi?id=174880
811
812         Reviewed by Andy Estes.
813
814         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
815         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
816         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
817         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
818         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
819         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
820         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
821         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
822
823 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
824
825         Fix JSCOnly ARM buildbots after r220047
826         https://bugs.webkit.org/show_bug.cgi?id=174993
827
828         Reviewed by Saam Barati.
829
830         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
831         (BuildAndRemoteJSCTestsFactory.__init__):
832
833 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
834
835         [WTF] Introduce Private Symbols
836         https://bugs.webkit.org/show_bug.cgi?id=174935
837
838         Reviewed by Darin Adler.
839
840         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
841         (TestWebKitAPI::TEST):
842
843 2017-07-30  Darin Adler  <darin@apple.com>
844
845         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
846         https://bugs.webkit.org/show_bug.cgi?id=130653
847
848         Reviewed by Antti Koivisto.
849
850         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
851         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
852         when calling frameDidChangeLocation.
853         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
854         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
855         thus causing mysterious failures of a couple of tests. There are two remaining issues:
856         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
857         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
858         same logic flaw that causes "top loading frame" to get set to one of the subframes in
859         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
860         loading, subframe starts loading. It would be good to clean that up some day, but for now
861         this patch makes the two work identically rather than changing both.
862         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
863
864 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
865
866         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
867         https://bugs.webkit.org/show_bug.cgi?id=174963
868
869         Reviewed by Darin Adler.
870
871         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
872         RetainPtr<>. This patch changes them to all use auto.
873
874         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
875         (TestWebKitAPI::TEST):
876
877 2017-07-30  Brady Eidson  <beidson@apple.com>
878
879         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
880         https://bugs.webkit.org/show_bug.cgi?id=174958
881
882         Reviewed by Darin Adler.
883
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
886         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
887         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
888         (runUntilTasksInFlight):
889         (TEST):
890
891 2017-07-28  Commit Queue  <commit-queue@webkit.org>
892
893         Unreviewed, rolling out r219990.
894         https://bugs.webkit.org/show_bug.cgi?id=174961
895
896         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
897         estes on #webkit).
898
899         Reverted changeset:
900
901         "Part 2 of: Rename DatabaseProcess to StorageProcess."
902         https://bugs.webkit.org/show_bug.cgi?id=174880
903         http://trac.webkit.org/changeset/219990
904
905 2017-07-28  Brady Eidson  <beidson@apple.com>
906
907         API tests that use URLSchemeHandler are failing.
908         https://bugs.webkit.org/show_bug.cgi?id=174950
909
910         Reviewed by Alex Christensen.
911
912         Fix the NoMIMEType test to be correct.
913
914         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
915         (-[SchemeHandler initWithData:mimeType:]):
916         (-[SchemeHandler webView:startURLSchemeTask:]):
917         (TEST):
918
919 2017-07-28  Daniel Bates  <dabates@apple.com>
920
921         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
922         https://bugs.webkit.org/show_bug.cgi?id=174876
923
924         Reviewed by Alex Christensen.
925
926         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
927         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
928         they provide a more direct way to test the platform abstraction.
929
930         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
931
932         * Scripts/prepare-ChangeLog:
933         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
934         of the current working directory.
935
936 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
937
938         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
939         https://bugs.webkit.org/show_bug.cgi?id=174930
940
941         Unreviewed test fix.
942
943         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
944
945         * Scripts/prepare-ChangeLog:
946         (get_function_line_ranges_for_cpp):
947
948 2017-07-28  JF Bastien  <jfbastien@apple.com>
949
950         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
951         https://bugs.webkit.org/show_bug.cgi?id=174930
952
953         Reviewed by Daniel Bates.
954
955         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
956         here also teach it about const and volatile overloads. I didn't do
957         reference and rvalue reference overloads because we don't really
958         use them, and the current parser throws away those characters and
959         it doesn't seem worth making it more complex.
960
961         * Scripts/prepare-ChangeLog:
962         (get_function_line_ranges_for_cpp):
963         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
964         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
965         (Foo::Arrow::arrow):
966         (Foo::Arrow::otherArrow):
967         (Foo::Arrow::otherArrow const):
968         (Foo::Arrow::otherArrow volatile):
969         (Foo::Arrow::otherArrow const volatile):
970
971 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
972
973         [GTK] Building with ENABLE_VIDEO=OFF fails
974         https://bugs.webkit.org/show_bug.cgi?id=174940
975
976         Reviewed by Alex Christensen.
977
978         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
979         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
980
981         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
982         (methodCallCallback): Add missing USE(GSTREAMER) guard.
983
984 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
985
986         [WPE] Implement EventSenderProxy in WTR
987         https://bugs.webkit.org/show_bug.cgi?id=173419
988
989         Reviewed by Žan Doberšek.
990
991         Add the implementation of EventSenderProxy to the WTR. This
992         allows us to extend the coverage of the test suite in WKWPE.
993
994         * WebKitTestRunner/EventSenderProxy.h:
995         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
996         libxkbcommon needed to deal with key events.
997         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
998         (WTR::EventSenderProxy::EventSenderProxy):
999         (WTR::senderButtonToWPEButton):
1000         (WTR::EventSenderProxy::mouseDown):
1001         (WTR::EventSenderProxy::mouseUp):
1002         (WTR::EventSenderProxy::mouseMoveTo):
1003         (WTR::EventSenderProxy::mouseScrollBy):
1004         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1005         (WTR::EventSenderProxy::leapForward):
1006         (WTR::wkEventModifiersToWPE):
1007         (WTR::getXKBKeySymForKeyRef):
1008         (WTR::EventSenderProxy::keyDown):
1009         (WTR::EventSenderProxy::addTouchPoint):
1010         (WTR::EventSenderProxy::updateTouchPoint):
1011         (WTR::EventSenderProxy::setTouchModifier):
1012         (WTR::EventSenderProxy::setTouchPointRadius):
1013         (WTR::EventSenderProxy::getUpdatedTouchEvents):
1014         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
1015         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1016         (WTR::EventSenderProxy::touchStart):
1017         (WTR::EventSenderProxy::touchMove):
1018         (WTR::EventSenderProxy::touchEnd):
1019         (WTR::EventSenderProxy::touchCancel):
1020         (WTR::EventSenderProxy::clearTouchPoints):
1021         (WTR::EventSenderProxy::releaseTouchPoint):
1022         (WTR::EventSenderProxy::cancelTouchPoint):
1023
1024 2017-07-27  Brady Eidson  <beidson@apple.com>
1025
1026         Part 2 of: Rename DatabaseProcess to StorageProcess.
1027         https://bugs.webkit.org/show_bug.cgi?id=174880
1028
1029         Reviewed by Andy Estes.
1030
1031         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1032         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1033         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1034         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1035         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1036         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1037         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1038         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1039
1040 2017-07-26  Mark Lam  <mark.lam@apple.com>
1041
1042         Add ability to only run specific tests in run-javascriptcore-tests.
1043         https://bugs.webkit.org/show_bug.cgi?id=174884
1044
1045         Reviewed by Saam Barati.
1046
1047         For example, if we only want to run testapi, we can do so as follows:
1048             $ run-javascriptcore-tests --testapi
1049
1050         Previously, specifying --testapi effectively does nothing because we run all tests
1051         by default.  Only --no-testapi had the effect of disabling the test set.  This
1052         old behavior for --testapi is not very useful or meaningful.  We're now changing
1053         it to mean that we will only run that test.
1054
1055         With this change, we can also run more than one set of tests.  For example, if we
1056         only want to run testmasm and testair, we can do so as follows:
1057             $ run-javascriptcore-tests --testmasm --testair
1058
1059         By default, if no specific test option is specified, run-javascriptcore-tests will
1060         run all tests.
1061
1062         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
1063         the mozilla tests (--mozilla-tests) even though both are run via the lower level
1064         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
1065         the other set will not run.  For example, the following only runs the mozilla tests:
1066             $ run-javascriptcore-tests --mozilla-tests
1067
1068         Note also that --jit-stress-tests is not for choosing a different set of tests.
1069         Instead, it is used for determining whether we run JIT'ed test configurations
1070         on the jsc stress tests and mozilla tests.  As a result, specifying
1071         --jit-stress-tests will not omit other tests.  For example, the following still
1072         runs all tests:
1073             $ run-javascriptcore-tests --jit-stress-tests
1074
1075         * Scripts/run-javascriptcore-tests:
1076         (defaultStringForTestState):
1077         (enableTestOrNot):
1078         (runJSCStressTests):
1079
1080 2017-07-26  Mark Lam  <mark.lam@apple.com>
1081
1082         Make run-javascriptcore-test run testair, testb3, and testmasm.
1083         https://bugs.webkit.org/show_bug.cgi?id=174837
1084         <rdar://problem/33522927>
1085
1086         Reviewed by Saam Barati and Filip Pizlo.
1087
1088         1. Refactors code for running testapi so that we can use it to run other tests.
1089         2. Added running of testmasm, testair, testb3.
1090
1091         Note: the existing testapi invocation code does not support remote invocation of
1092         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
1093         and testb3 also do not support remote invocation.  If we wish to add remote
1094         invocation support, we should do that in a separate patch.
1095
1096         * Scripts/run-javascriptcore-tests:
1097         (testPath):
1098         (runTest):
1099         (testapiPath): Deleted.
1100
1101 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
1102
1103         Remove duplicate code from Buildbot.js in dashboard
1104         https://bugs.webkit.org/show_bug.cgi?id=174870
1105
1106         Reviewed by Daniel Bates.
1107
1108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1109         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
1110         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
1111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
1112         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
1113
1114 2017-07-26  Brady Eidson  <beidson@apple.com>
1115
1116         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
1117         https://bugs.webkit.org/show_bug.cgi?id=174851
1118
1119         Reviewed by Chris Dumez.
1120
1121         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1122         (TEST):
1123
1124 2017-07-26  Brian Burg  <bburg@apple.com>
1125
1126         Remove WEB_TIMING feature flag
1127         https://bugs.webkit.org/show_bug.cgi?id=174795
1128
1129         Reviewed by Alex Christensen.
1130
1131         * Scripts/webkitperl/FeatureList.pm:
1132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1133
1134 2017-07-26  Chris Dumez  <cdumez@apple.com>
1135
1136         Pressing the Escape key should not be a valid user gesture to enter fullscreen
1137         https://bugs.webkit.org/show_bug.cgi?id=174864
1138         <rdar://problem/33009088>
1139
1140         Reviewed by Geoffrey Garen.
1141
1142         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
1143         WKTR.
1144
1145         * DumpRenderTree/mac/EventSendingController.mm:
1146         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1147
1148 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1149
1150         Unreviewed, added Romain Bellessort to contributors.json.
1151
1152         * Scripts/webkitpy/common/config/contributors.json:
1153
1154 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
1155
1156         [WPE] WebGL2 support
1157         https://bugs.webkit.org/show_bug.cgi?id=174249
1158
1159         Reviewed by Alex Christensen.
1160
1161         * Scripts/webkitperl/FeatureList.pm:
1162         Enable WebGL2 for WPE when building through build-webkit.
1163
1164 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1165
1166         Unreviewed. Fix GTK distcheck.
1167
1168         * gtk/make-dist.py:
1169         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
1170
1171 2017-07-25  Brady Eidson  <beidson@apple.com>
1172
1173         ResourceLoadStatistics grandfathering happens much too often.
1174         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
1175
1176         Reviewed by Chris Dumez.
1177
1178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1179         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
1180         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
1181         (TEST):
1182
1183 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
1184
1185         Fix autoinstaller failing on autoinstall_everything
1186         https://bugs.webkit.org/show_bug.cgi?id=174830
1187
1188         Reviewed by Joseph Pecoraro.
1189
1190         * Scripts/webkitpy/thirdparty/__init__.py:
1191         (AutoinstallImportHook.find_module):
1192         (AutoinstallImportHook.install_chromedriver):
1193         (AutoinstallImportHook.install_geckodriver):
1194         (AutoinstallImportHook._install_chromedriver): Deleted.
1195         (AutoinstallImportHook._install_geckodriver): Deleted.
1196
1197 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
1198
1199         Replace --runtime with something for both ios-simulator and ios-device
1200         https://bugs.webkit.org/show_bug.cgi?id=173775
1201         <rdar://problem/32952164>
1202
1203         Reviewed by Aakash Jain.
1204
1205         Add --version flag for both iOS simulator and iOS device.
1206
1207         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1208         (parse_args): Add --version flag and move --no-install.
1209         * Scripts/webkitpy/port/factory.py:
1210         (platform_options): Move --no-intall to run_webkit_tests.py.
1211         * Scripts/webkitpy/port/ios.py:
1212         (IOSPort):
1213         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
1214         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
1215         * Scripts/webkitpy/port/ios_device.py:
1216         (IOSDevicePort.ios_version): Consult --version flag before checking connected
1217         devices for iOS version.
1218         * Scripts/webkitpy/port/ios_device_unittest.py:
1219         (IOSDeviceTest.make_port): Set --version option so that we can generate test
1220         expectation paths without devices connected.
1221         (IOSDeviceTest.test_additional_platform_directory): Deleted.
1222         (IOSDeviceTest.test_baseline_searchpath): Deleted.
1223         (IOSDeviceTest.test_expectations_ordering): Deleted.
1224         * Scripts/webkitpy/port/ios_simulator.py:
1225         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
1226         flag to specify a runtime.
1227         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
1228         flag and then use the default runtime.
1229
1230 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1231
1232         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
1233         https://bugs.webkit.org/show_bug.cgi?id=174815
1234
1235         Reviewed by Carlos Alberto Lopez Perez.
1236
1237         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
1238         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
1239         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
1240         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
1241         think), probably because of a newer CMake version.
1242
1243         * CMakeLists.txt:
1244         * TestWebKitAPI/CMakeLists.txt:
1245         * TestWebKitAPI/PlatformGTK.cmake:
1246
1247 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1248
1249         Fix BenchmarkRunner to only import selenium when needed
1250         https://bugs.webkit.org/show_bug.cgi?id=174808
1251
1252         Reviewed by Stephanie Lewis.
1253
1254         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1255         (LinuxChromeDriver.launch_driver):
1256         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1257         (LinuxFirefoxDriver.launch_driver):
1258         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1259         (OSXChromeDriver.launch_driver):
1260         (OSXChromeCanaryDriver.launch_driver):
1261         (create_chrome_options):
1262         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1263         (OSXFirefoxDriver.launch_driver):
1264         (OSXFirefoxNightlyDriver.launch_driver):
1265         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1266         (OSXSafariDriver.launch_driver):
1267         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1268         (WebDriverBenchmarkRunner._run_one_test):
1269
1270 2017-07-23  Darin Adler  <darin@apple.com>
1271
1272         More NeverDestroyed and related cleanup
1273         https://bugs.webkit.org/show_bug.cgi?id=174745
1274
1275         Reviewed by Alex Christensen.
1276
1277         * DumpRenderTree/JavaScriptThreading.cpp:
1278         (javaScriptThreadsMutex): Use NeverDestroyed instead of
1279         DEPRECATED_DEFINE_STATIC_LOCAL.
1280         (javaScriptThreads): Ditto.
1281
1282 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1283
1284         Subclass Benchmark Runner script for WebDriver support
1285         https://bugs.webkit.org/show_bug.cgi?id=174390
1286
1287         Reviewed by Dewei Zhu, Stephanie Lewis.
1288
1289         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
1290
1291         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1292         (BenchmarkBuilder.__init__):
1293         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1294         (BenchmarkRunner.__init__):
1295         (BenchmarkRunner._find_plan_file):
1296         (BenchmarkRunner._run_one_test.and):
1297         (BenchmarkRunner.execute):
1298         (BenchmarkRunner._get_result): Deleted.
1299         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1300         (parse_args):
1301         (start):
1302         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1303         (WebDriverBenchmarkRunner):
1304         (WebDriverBenchmarkRunner._get_result):
1305         (WebDriverBenchmarkRunner._run_one_test):
1306         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1307         (WebServerBenchmarkRunner):
1308         (WebServerBenchmarkRunner.__init__):
1309         (WebServerBenchmarkRunner._get_result):
1310         (WebServerBenchmarkRunner._run_one_test):
1311
1312 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1313
1314         Add BenchmarkRunner patches with WebDriver support for each testing plan
1315         https://bugs.webkit.org/show_bug.cgi?id=174443
1316
1317         Reviewed by Dewei Zhu, Stephanie Lewis.
1318
1319         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1320         (BenchmarkBuilder.__enter__):
1321         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1322         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1323         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1324         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1325         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1326         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1327         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1328         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1329         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1330         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1331         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1332         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1333         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1334         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1335         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1336         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1337         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1338         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1339         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1340         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1341         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1342         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1343         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1344         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1345         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1346         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1347         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1348         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1349         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1350         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1351         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1352         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1353         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1354
1355 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1356
1357         Add functions to autoinstaller needed for Benchmark Runner script
1358         https://bugs.webkit.org/show_bug.cgi?id=174331
1359
1360         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1361
1362         Adds autoinstaller functions to install selenium and webdriver binaries
1363         which will be used by the browser driver part of Benchmark Runner.
1364
1365         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1366         (BrowserDriver.restore_env):
1367         (BrowserDriver):
1368         (BrowserDriver.get_webdriver_binary_path):
1369         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1370         (LinuxChromeDriver.launch_driver):
1371         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1372         (LinuxFirefoxDriver.launch_driver):
1373         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1374         (OSXChromeDriver.launch_driver):
1375         (OSXChromeCanaryDriver.launch_driver):
1376         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1377         (OSXFirefoxDriver.launch_driver):
1378         (OSXFirefoxNightlyDriver.launch_driver):
1379         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1380         * Scripts/webkitpy/benchmark_runner/utils.py:
1381         (get_driver_binary_path):
1382         * Scripts/webkitpy/common/system/autoinstall.py:
1383         (AutoInstaller._unzip):
1384         * Scripts/webkitpy/thirdparty/__init__.py:
1385         (AutoinstallImportHook.find_module):
1386         (AutoinstallImportHook._install_selenium):
1387         (AutoinstallImportHook):
1388         (AutoinstallImportHook._install_chromedriver):
1389         (AutoinstallImportHook._install_geckodriver):
1390         (AutoinstallImportHook.get_latest_pypi_url):
1391         (AutoinstallImportHook.install_binary):
1392         (autoinstall_everything):
1393         (get_driver_filename):
1394         (get_os_info):
1395
1396 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1397
1398         Add WebDriver support in browser driver part of BenchmarkRunner
1399         https://bugs.webkit.org/show_bug.cgi?id=174445
1400
1401         Reviewed by Stephanie Lewis.
1402
1403         Adds a launch_driver function to each BrowserDriver subclass. This
1404         function sets up the arguments for the webdriver and launches the
1405         webdriver specific to that browser.
1406
1407         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1408         (BrowserDriver.launch_webdriver):
1409         (BrowserDriver):
1410         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1411         (LinuxBrowserDriver.launch_webdriver):
1412         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1413         (LinuxChromeDriver.launch_url):
1414         (LinuxChromeDriver):
1415         (LinuxChromeDriver.launch_driver):
1416         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1417         (EpiphanyBrowserDriver.launch_url):
1418         (EpiphanyBrowserDriver):
1419         (EpiphanyBrowserDriver.launch_driver):
1420         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1421         (LinuxFirefoxDriver):
1422         (LinuxFirefoxDriver.launch_url):
1423         (LinuxFirefoxDriver.launch_driver):
1424         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1425         (GTKMiniBrowserDriver.launch_url):
1426         (GTKMiniBrowserDriver):
1427         (GTKMiniBrowserDriver.launch_driver):
1428         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1429         (OSXBrowserDriver._launch_webdriver):
1430         (OSXBrowserDriver):
1431         (OSXBrowserDriver._screen_size):
1432         (OSXBrowserDriver._insert_url):
1433         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1434         (OSXChromeDriver):
1435         (OSXChromeDriver.launch_url):
1436         (OSXChromeDriver.launch_driver):
1437         (OSXChromeCanaryDriver):
1438         (OSXChromeCanaryDriver.launch_url):
1439         (OSXChromeCanaryDriver.launch_driver):
1440         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1441         (OSXFirefoxDriver):
1442         (OSXFirefoxDriver.launch_url):
1443         (OSXFirefoxDriver.launch_driver):
1444         (OSXFirefoxNightlyDriver):
1445         (OSXFirefoxNightlyDriver.launch_url):
1446         (OSXFirefoxNightlyDriver.launch_driver):
1447         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1448         (OSXSafariDriver.launch_driver):
1449
1450 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1451
1452         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1453         https://bugs.webkit.org/show_bug.cgi?id=174793
1454
1455         Reviewed by Tim Horton.
1456
1457         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1458         down. Without r219765, this test will dereference null and crash.
1459
1460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1461         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1462         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1463         (TEST):
1464
1465 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1466
1467         [Win] Implement Authentication dialog in MiniBrowser
1468         https://bugs.webkit.org/show_bug.cgi?id=174662
1469
1470         Reviewed by Alex Christensen.
1471
1472         * MiniBrowser/win/Common.cpp:
1473         (CustomUserAgent):
1474         (DisplayAuthDialog):
1475         (AuthDialogProc):
1476         * MiniBrowser/win/MiniBrowserLib.rc:
1477         * MiniBrowser/win/MiniBrowserLibResource.h:
1478         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1479         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1480
1481 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1482
1483         Handle case where line_numbers is None instead of an array of line numbers
1484         https://bugs.webkit.org/show_bug.cgi?id=174775
1485
1486         Reviewed by Aakash Jain.
1487
1488         Added files set line_numbers to None in process_file.
1489
1490         * Scripts/webkitpy/style/filereader.py:
1491         (TextFileReader.process_file): Handle case where line_number is set to None.
1492         * Scripts/webkitpy/style/main_unittest.py:
1493         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1494
1495 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1496
1497         [WPE] Add libepoxy to the Jhbuild moduleset
1498         https://bugs.webkit.org/show_bug.cgi?id=174711
1499
1500         Reviewed by Carlos Alberto Lopez Perez.
1501
1502         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1503
1504 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1505
1506         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1507         https://bugs.webkit.org/show_bug.cgi?id=174780
1508
1509         Reviewed by Carlos Garcia Campos.
1510
1511         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1512         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1513         in case the eglplatform.h header doesn't provide that macro. This replicates
1514         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1515
1516 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1517
1518         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1519         https://bugs.webkit.org/show_bug.cgi?id=174758
1520
1521         Reviewed by Dan Bernstein.
1522
1523         Migrate position-information-related unit tests from the PositionInformationTests suite to
1524         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1525
1526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1527         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1528         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1529         (TestWebKitAPI::TEST):
1530         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1531         * TestWebKitAPI/cocoa/TestWKWebView.h:
1532         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1533         (-[TestWKWebView activatedElementAtPosition:]):
1534
1535 2017-07-22  Chris Dumez  <cdumez@apple.com>
1536
1537         REGRESSION(r204565): WKObject is broken
1538         https://bugs.webkit.org/show_bug.cgi?id=174736
1539         <rdar://problem/33246169>
1540
1541         Reviewed by Dan Bernstein.
1542
1543         Add API test that used to crash.
1544
1545         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1546         (TestWebKitAPI::TEST):
1547
1548 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1549
1550         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1551         https://bugs.webkit.org/show_bug.cgi?id=174705
1552
1553         Reviewed by Mark Lam.
1554
1555         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1556         (TestWebKitAPI::testThreadGroup):
1557         (TestWebKitAPI::TEST):
1558
1559 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1560
1561         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1562         https://bugs.webkit.org/show_bug.cgi?id=174724
1563
1564         Reviewed by Aakash Jain.
1565
1566         * Scripts/webkitpy/port/ios_simulator.py:
1567         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1568         simulator. Errors here should be treated the same as no simulators found.
1569
1570 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1571
1572         [CMake] Add an option to stop build after generating project files
1573         https://bugs.webkit.org/show_bug.cgi?id=174664
1574
1575         Reviewed by Konstantin Tokarev.
1576
1577         Add "--generate-project-only" to stop build after generating project files.
1578
1579         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1580         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1581         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1582         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1583         (isGenerateProjectOnly): ditto
1584
1585 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1586
1587         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1588         https://bugs.webkit.org/show_bug.cgi?id=174501
1589
1590         Reviewed by Darin Adler.
1591
1592         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1593         (TestWebKitAPI::TEST):
1594
1595 2017-07-20  David Quesada  <david_quesada@apple.com>
1596
1597         Add SPI to notify WKNavigationDelegate about client redirects
1598         https://bugs.webkit.org/show_bug.cgi?id=174680
1599         rdar://problem/33184886
1600
1601         Reviewed by Brady Eidson.
1602
1603         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1604         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1605         (TEST):
1606         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1607
1608 2017-07-20  Brady Eidson  <beidson@apple.com>
1609
1610         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1611         https://bugs.webkit.org/show_bug.cgi?id=174685
1612
1613         Reviewed by Andy Estes.
1614
1615         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1616         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1617
1618 2017-07-20  Brady Eidson  <beidson@apple.com>
1619
1620         Deprecate WebIconDatabase in WebKitLegacy/mac.
1621         https://bugs.webkit.org/show_bug.cgi?id=174607
1622
1623         Reviewed by Alex Christensen.
1624
1625         * DumpRenderTree/mac/TestRunnerMac.mm:
1626
1627 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1628
1629         lint-test-expectations should be run during style checking
1630         https://bugs.webkit.org/show_bug.cgi?id=173559
1631         <rdar://problem/32854941>
1632
1633         Reviewed by Aakash Jain.
1634
1635         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1636         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1637         prevents identifying errors on specific lines in a file.
1638         * Scripts/webkitpy/style/main_unittest.py:
1639         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1640         case where a linter error is in the file modified, but the line modified is not related to
1641         the linter error.
1642
1643 2017-07-20  Brady Eidson  <beidson@apple.com>
1644
1645         Remove WebIconDatabase from WebKitLegacy/win.
1646         https://bugs.webkit.org/show_bug.cgi?id=174608
1647
1648         Reviewed by Alex Christensen.
1649
1650         * DumpRenderTree/win/DumpRenderTree.cpp:
1651         (main):
1652         * DumpRenderTree/win/TestRunnerWin.cpp:
1653         (TestRunner::setIconDatabaseEnabled):
1654
1655 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1656
1657         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1658         https://bugs.webkit.org/show_bug.cgi?id=174671
1659
1660         Reviewed by Carlos Garcia Campos.
1661
1662         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1663         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1664         priority for this source in order to have it dispatched on the same
1665         priority as the other WebKit-controlled GSource objects.
1666
1667 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1668
1669         lint-test-expectations should be run during style checking
1670         https://bugs.webkit.org/show_bug.cgi?id=173559
1671         <rdar://problem/32854941>
1672
1673         Reviewed by Daniel Bates.
1674
1675         Follow up fix addressing style and a few minor bugs.
1676
1677         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1678         (TestExpectationParser.__init__): Use lambda x: x instead of str
1679         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1680         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1681         reduce the calls of _shorten_filename, fix minor bug in appending the current
1682         expectation's line number instead of the previous ones, clarify treatment of None
1683         in file-to-line-number mapping.
1684         (TestExpectations._report_warnings): Collapse call.
1685         * Scripts/webkitpy/style/checkers/test_expectations.py:
1686         (TestExpectationsChecker.lint_test_expectations):
1687         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1688         (TextFileReader.process_file): Add comment explaining treatment of None in
1689         file-to-line-number mapping.
1690         (TextFileReader.delete_file): Collapse call.
1691
1692 2017-07-19  Chris Dumez  <cdumez@apple.com>
1693
1694         Unreviewed attempt to fix API test failure after r219663.
1695
1696         The test was hard-coding an exception string and the string has changed slightly
1697         in r219663.
1698
1699         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1700         (TEST):
1701
1702 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1703
1704         Don't write file URLs to iOS Pasteboard
1705         https://bugs.webkit.org/show_bug.cgi?id=174647
1706         <rdar://problem/33199730>
1707
1708         Reviewed by Wenson Hsieh.
1709
1710         Updating tests to reflect the lack of file URLs for images.
1711
1712         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1713         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1714         (checkEstimatedSize):
1715         (TestWebKitAPI::TEST):
1716
1717 2017-07-19  Brady Eidson  <beidson@apple.com>
1718
1719         iBooks sometimes crashes when closing a book.
1720         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1721
1722         Reviewed by Oliver Hunt.
1723
1724         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1725         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1726         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1727         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1728         (TestWebKitAPI::TEST):
1729
1730         Add a "spin the runloop X number of times" utility:
1731         * TestWebKitAPI/Utilities.h:
1732         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1733         (TestWebKitAPI::Util::spinRunLoop):
1734
1735 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1736
1737         lint-test-expectations should be run during style checking
1738         https://bugs.webkit.org/show_bug.cgi?id=173559
1739         <rdar://problem/32854941>
1740
1741         Reviewed by David Kilzer.
1742
1743         Running the test expectation linter requires reading both files and lines not in the
1744         patch because, for example, deletion of a test can cause a lint failure even though
1745         no test expectations where modified. This means that the linter will occasionally warn
1746         about lines which were not changed in a given patch but whose error is related to a
1747         change made in that patch.
1748
1749         * Scripts/webkitpy/common/system/filesystem_mock.py:
1750         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1751         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1752         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1753         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1754         content, description of the error and the name of the associated test.
1755         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1756         (TestExpectationParser.__init__): Pass shorten_filename function to
1757         TestExpectationsParser to add a deleted file to the related_files dictionary.
1758         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1759         missing path to the related_files dictionary.
1760         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1761         files and line numbers related to this test expectation line. This will allow
1762         tracking linter errors in the style checker occurring across multiple files.
1763         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1764         lines to related_files dictionary.
1765         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1766         (TestExpectations._report_warnings): Construct warning object instead of string
1767         when adding to warnings list.
1768         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1769         clean-up log.
1770         * Scripts/webkitpy/style/checker.py:
1771         (ProcessorBase.do_association_check): Add required function for processor classes.
1772         (StyleProcessor):
1773         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1774         checking for errors between associated files.
1775         * Scripts/webkitpy/style/checkers/test_expectations.py:
1776         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1777         (TestExpectationsChecker):
1778         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1779         of modified files, the current working directory and the host, determine if the linter
1780         warning is associated with the changes.
1781         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1782         style checker.
1783         * Scripts/webkitpy/style/filereader.py:
1784         (TextFileReader):
1785         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1786         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1787         (TextFileReader.process_file): Track both the number of files changed and which lines
1788         in those files were changed.
1789         (TextFileReader.do_association_check): Run the processor's association check on all
1790         modified or deleted files processed by TextFileReader.
1791         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1792         (TextFileReader.count_delete_only_file): Deleted.
1793         * Scripts/webkitpy/style/filereader_unittest.py:
1794         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1795         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1796         * Scripts/webkitpy/style/main.py:
1797         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1798         explicitly run the association check on the file reader.
1799         * Scripts/webkitpy/style/main_unittest.py:
1800         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1801         embedded in the style checker.
1802         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1803         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1804         construct the TextFileReader object with a StyleProcessor used to run style checks on
1805         specific files.
1806         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1807         testing the test expectation linter inside the style checker. This host must contain a
1808         mock file system with the basic structure of test expectations.
1809         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1810         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1811         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1812         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1813         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1814         * Scripts/webkitpy/style/patchreader.py:
1815         (PatchReader.check): Specify which file was deleted, run the association check.
1816         * Scripts/webkitpy/style/patchreader_unittest.py:
1817         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1818         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1819         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1820
1821 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1822
1823         [WTF] Implement WTF::ThreadGroup
1824         https://bugs.webkit.org/show_bug.cgi?id=174081
1825
1826         Reviewed by Mark Lam.
1827
1828         Add WTF::ThreadGroup tests.
1829
1830         * TestWebKitAPI/CMakeLists.txt:
1831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1832         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1833         (TestWebKitAPI::testThreadGroup):
1834         (TestWebKitAPI::TEST):
1835
1836 2017-07-18  Andy Estes  <aestes@apple.com>
1837
1838         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1839         https://bugs.webkit.org/show_bug.cgi?id=174631
1840
1841         Reviewed by Tim Horton.
1842
1843         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1844         * MiniBrowser/Configurations/Base.xcconfig:
1845         * MobileMiniBrowser/Configurations/Base.xcconfig:
1846         * TestWebKitAPI/Configurations/Base.xcconfig:
1847         * WebKitTestRunner/Configurations/Base.xcconfig:
1848
1849 2017-07-18  Andy Estes  <aestes@apple.com>
1850
1851         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1852         https://bugs.webkit.org/show_bug.cgi?id=174631
1853
1854         Reviewed by Sam Weinig.
1855
1856         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1857         * MiniBrowser/Configurations/Base.xcconfig:
1858         * MobileMiniBrowser/Configurations/Base.xcconfig:
1859         * TestWebKitAPI/Configurations/Base.xcconfig:
1860         * WebKitTestRunner/Configurations/Base.xcconfig:
1861
1862 2017-07-18  Daniel Bates  <dabates@apple.com>
1863
1864         lldb: Add type summary for StringView
1865         https://bugs.webkit.org/show_bug.cgi?id=174637
1866
1867         Reviewed by Sam Weinig.
1868
1869         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1870         StringView object will print output that has the form:
1871
1872             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1873               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1874               m_length = 2
1875               m_is8Bit = true
1876               m_underlyingString = 0x0000614000000a90
1877             }
1878
1879         * lldb/lldb_webkit.py:
1880         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1881         (WTFStringView_SummaryProvider):
1882         (WTFStringViewProvider):
1883         (WTFStringViewProvider.__init__):
1884         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1885         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1886         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1887         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1888
1889 2017-07-18  Andy Estes  <aestes@apple.com>
1890
1891         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1892         https://bugs.webkit.org/show_bug.cgi?id=174631
1893
1894         Reviewed by Dan Bernstein.
1895
1896         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1897         * MiniBrowser/Configurations/Base.xcconfig:
1898         * MobileMiniBrowser/Configurations/Base.xcconfig:
1899         * TestWebKitAPI/Configurations/Base.xcconfig:
1900         * WebKitTestRunner/Configurations/Base.xcconfig:
1901
1902 2017-07-18  Devin Rousso  <drousso@apple.com>
1903
1904         Web Inspector: Add memoryCost to Inspector Protocol objects
1905         https://bugs.webkit.org/show_bug.cgi?id=174478
1906
1907         Reviewed by Joseph Pecoraro.
1908
1909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1910         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1911         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1912         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1913         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1914         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1915         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1916         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1917         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1918         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1919         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1920         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1921         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1922         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1923         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1924         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1925         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1926
1927 2017-07-18  Andy Estes  <aestes@apple.com>
1928
1929         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1930         https://bugs.webkit.org/show_bug.cgi?id=174631
1931
1932         Reviewed by Darin Adler.
1933
1934         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1935         * MiniBrowser/Configurations/Base.xcconfig:
1936         * MobileMiniBrowser/Configurations/Base.xcconfig:
1937         * TestWebKitAPI/Configurations/Base.xcconfig:
1938         * WebKitTestRunner/Configurations/Base.xcconfig:
1939
1940 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1941
1942         Unreviewed, fix the iOS build.
1943
1944         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1945
1946         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1947         (TestWebKitAPI::TEST):
1948
1949 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1950
1951         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1952         https://bugs.webkit.org/show_bug.cgi?id=174585
1953         <rdar://problem/33302541>
1954
1955         Reviewed by Tim Horton.
1956
1957         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1958         being dragged when initiating a drag.
1959
1960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1961         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1962         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1963         (TestWebKitAPI::TEST):
1964         * TestWebKitAPI/cocoa/TestWKWebView.h:
1965
1966         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1967
1968         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1969         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1970
1971 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1972
1973         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1974         https://bugs.webkit.org/show_bug.cgi?id=174547
1975
1976         Reviewed by Alex Christensen.
1977
1978         * DumpRenderTree/PlatformWin.cmake:
1979         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1980
1981 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1982
1983         Update style checker to deal with "final"
1984         https://bugs.webkit.org/show_bug.cgi?id=174528
1985
1986         Reviewed by Alex Christensen.
1987         
1988         check-webkit-style shouldn't complain about an open brace to start a
1989         line after a function definition with "final" or "const final".
1990
1991         * Scripts/webkitpy/style/checkers/cpp.py:
1992         (check_braces):
1993         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1994         (CppStyleTest.test_brace_at_begin_of_line):
1995
1996 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1997
1998         Modernize content extension code
1999         https://bugs.webkit.org/show_bug.cgi?id=174588
2000
2001         Reviewed by Sam Weinig.
2002
2003         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2004         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2005         (TestWebKitAPI::testRequest):
2006         (TestWebKitAPI::makeBackend):
2007         (TestWebKitAPI::TEST_F):
2008
2009 2017-07-17  Brady Eidson  <beidson@apple.com>
2010
2011         WKHTTPCookieStore observing only works on the default cookie store.
2012         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
2013
2014         Reviewed by Sam Weinig.
2015
2016         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2017         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
2018           called for the default store, a non-persistent store, and a custom store.
2019         (TEST):
2020
2021 2017-07-16  Sam Weinig  <sam@webkit.org>
2022
2023         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
2024         https://bugs.webkit.org/show_bug.cgi?id=174575
2025
2026         Reviewed by Brady Eidson.
2027
2028         * Scripts/svn-create-patch:
2029         (findModificationType):
2030         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
2031         default value of "unknown".
2032
2033         (generateFileList):
2034         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
2035         for untracked, which matches our old behavior.
2036
2037 2017-07-17  Charlie Turner  <cturner@igalia.com>
2038
2039         Add some missing build dependencies on Fedora
2040         https://bugs.webkit.org/show_bug.cgi?id=174578
2041
2042         Unreviewed dependency update.
2043
2044         * gtk/install-dependencies:
2045
2046 2017-07-16  Brady Eidson  <beidson@apple.com>
2047
2048         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
2049         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
2050
2051         Reviewed by Tim Horton.
2052
2053         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2054         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
2055         (TEST):
2056
2057 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
2058
2059         [GTK] Sort inspector GResource manifest to ensure reproducible builds
2060         https://bugs.webkit.org/show_bug.cgi?id=174540
2061
2062         Reviewed by Michael Catanzaro.
2063
2064         * gtk/generate-inspector-gresource-manifest.py:
2065         (get_filenames): sort list of input files
2066
2067 2017-07-15  Brady Eidson  <beidson@apple.com>
2068
2069         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
2070         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
2071
2072         Reviewed by Tim Horton.
2073
2074         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2075         (TEST): Make this test more reliable by clearing everything beforehand.
2076
2077 2017-07-15  David Kilzer  <ddkilzer@apple.com>
2078
2079         Make it possible to extend check-webkit-style with Apple-internal checkers
2080         <https://webkit.org/b/174464>
2081         <rdar://problem/25564402>
2082
2083         Reviewed by Darin Adler.
2084
2085         * Scripts/webkitpy/style/checker.py: Import apple_additions.
2086         (_all_categories): Add categories from apple_additions() if it
2087         exists.
2088         (CheckerDispatcher._create_checker): Create python checker
2089         from apple_additions() if it exists.
2090
2091 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2092
2093         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
2094         https://bugs.webkit.org/show_bug.cgi?id=174539
2095         <rdar://problem/33307395>
2096
2097         Reviewed by Darin Adler.
2098
2099         Adds a new unit test suite to cover action sheet popover presentation.
2100
2101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2102         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
2103         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
2104         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
2105
2106         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
2107
2108         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
2109         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2110
2111         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
2112
2113         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2114         (TestWebKitAPI::TEST):
2115
2116 2017-07-15  Sam Weinig  <sam@webkit.org>
2117
2118         [Scripts] Make svn-create-patch work better when called in sub directories
2119         https://bugs.webkit.org/show_bug.cgi?id=174551
2120
2121         Reviewed by Darin Adler.
2122
2123         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
2124           by ensuring that the prefix is applied as is done in generateDiff.
2125         - Silence output of explanatory lines from svn stat (" > move to ...")
2126           that show up in STDERR when running svn-create-patch.
2127         - Add verbose logging that I found useful while debugging this issue.
2128
2129         * Scripts/svn-create-patch:
2130         (findBaseUrl):
2131         (findMimeType):
2132         (findSourceFileAndRevision):
2133         (generateDiff):
2134         (generateFileList):
2135         (manufacturePatchForAdditionWithHistory):
2136
2137 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
2138
2139         Unreviewed build fix after r219537.
2140
2141         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2142
2143 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2144
2145         Add iOS 11 SPI
2146         https://bugs.webkit.org/show_bug.cgi?id=174430
2147         <rdar://problem/33269288>
2148
2149         Reviewed by Tim Horton.
2150
2151         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
2152         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
2153         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
2154
2155 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2156
2157         Failing to install on iPad simulators
2158         https://bugs.webkit.org/show_bug.cgi?id=174532
2159         <rdar://problem/33328347>
2160
2161         Reviewed by Stephanie Lewis.
2162
2163         * Scripts/webkitpy/xcode/simulated_device.py:
2164         (SimulatedDevice.install_app): Place install command in retry try-except block.
2165
2166 2017-07-14  Jeff Miller  <jeffm@apple.com>
2167
2168         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2169         https://bugs.webkit.org/show_bug.cgi?id=174524
2170
2171         Reviewed by Sam Weinig.
2172
2173         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2174         (TEST):
2175         Renamed TestParameter to TestParameter1.
2176         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2177
2178         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2179         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2180         Observe changes for two bundle parameters.
2181
2182         (-[BundleParametersPlugIn dealloc]):
2183         Remove observers for two bundle parameters.
2184
2185 2017-07-14  Commit Queue  <commit-queue@webkit.org>
2186
2187         Unreviewed, rolling out r219510.
2188         https://bugs.webkit.org/show_bug.cgi?id=174525
2189
2190         Need to revert length() == 0 check for null string (Requested
2191         by yusukesuzuki on #webkit).
2192
2193         Reverted changeset:
2194
2195         "[WTF] Newly added AtomicStringImpl should use BufferInternal
2196         static string if StringImpl is static"
2197         https://bugs.webkit.org/show_bug.cgi?id=174501
2198         http://trac.webkit.org/changeset/219510
2199
2200 2017-07-14  Jer Noble  <jer.noble@apple.com>
2201
2202         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
2203         https://bugs.webkit.org/show_bug.cgi?id=174514
2204
2205         Reviewed by Sam Weinig.
2206
2207         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
2208         (TestWebKitAPI::TEST_F):
2209
2210 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2211
2212         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2213         https://bugs.webkit.org/show_bug.cgi?id=174501
2214
2215         Reviewed by Darin Adler.
2216
2217         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2218         (TestWebKitAPI::TEST):
2219
2220 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2221
2222         Bring mac expectations in-line with other platforms
2223         https://bugs.webkit.org/show_bug.cgi?id=174472
2224         <rdar://problem/33297388>
2225
2226         Reviewed by David Kilzer.
2227
2228         The override order for Mac test expectations does not conform to the pattern used by iOS,
2229         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
2230
2231             platform/mac-wk2
2232             platform/wk2
2233             platform/mac-elcapitan
2234             platform/mac-sierra
2235             generic
2236
2237         After this change, El Capitan's baseline search path looks like this:
2238
2239             platform/mac-sierra-wk2
2240             platform/mac-sierra
2241             platform/mac-wk2
2242             platform/wk2
2243             generic
2244
2245         * Scripts/webkitpy/port/mac.py:
2246         (MacPort.__init__): If a specific version is specified in the port name, use that
2247         as the os version.
2248         (MacPort.default_baseline_search_path): Expectation search paths should work the
2249         same way they do on other ports. Port + version overrides port, port overrides generic
2250         and wk1/wk2 should override expectations for the two combined.
2251         * Scripts/webkitpy/port/mac_unittest.py:
2252         (MacTest.test_tests_for_other_platforms): Deleted.
2253         (MacTest._assert_search_path): Deleted.
2254         (MacTest.test_baseline_search_path): Deleted.
2255         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2256         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
2257         (test_rebaseline_test_and_print_scm_changes): Ditto.
2258         (test_rebaseline_and_copy_test): Ditto.
2259         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
2260         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
2261         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
2262
2263 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2264
2265         Fix style checker unit test
2266
2267         Unreviewed WebKit2 => WebKit fixup.
2268
2269         * Scripts/webkitpy/style/checker_unittest.py:
2270         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2271
2272 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2273
2274         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
2275
2276         Unreviewed build fix.
2277
2278         r219492 missed one hunk from its partial revert of r219489.
2279         This patch reverts that hunk.
2280
2281         * TestWebKitAPI/CMakeLists.txt:
2282
2283 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2284
2285         Use the old WebKit/WebKit2 targets for CMake builds.
2286
2287         Unreviewed build fix.
2288
2289         We can update the target names to match the Framework names in a future patch.
2290         This is a partial revert of r219489.
2291
2292         * TestWebKitAPI/CMakeLists.txt:
2293         WebKitLegacy => WebKit
2294         WebKit => WebKit2
2295
2296 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2297
2298         Fix TestWebKit API.
2299         https://bugs.webkit.org/show_bug.cgi?id=174164
2300         rdar://problem/33137595
2301
2302         Reviewed by Dan Bernstein.
2303
2304         * TestWebKitAPI/CMakeLists.txt:
2305         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2306         * TestWebKitAPI/PlatformGTK.cmake:
2307
2308 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2309
2310         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2311         https://bugs.webkit.org/show_bug.cgi?id=174164
2312         rdar://problem/33137595
2313
2314         Reviewed by Dan Bernstein.
2315
2316         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2317         (ShouldBuildTest):
2318         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2319         * Scripts/build-webkit:
2320         * Scripts/do-file-rename:
2321         * Scripts/do-webcore-rename:
2322         * Scripts/update-webkit-localizable-strings:
2323         * Scripts/webkitpy/common/config/watchlist:
2324         * Scripts/webkitpy/style/checker.py:
2325         * Scripts/webkitpy/style/checkers/featuredefines.py:
2326         * gtk/make-dist.py:
2327         (ensure_version_if_possible):
2328         * gtk/manifest.txt.in:
2329
2330 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2331
2332         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2333         https://bugs.webkit.org/show_bug.cgi?id=174162
2334         rdar://problem/33137594
2335
2336         Reviewed by Dan Bernstein.
2337
2338         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2339
2340         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2341         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2342         * EWSTools/configure-clang-linux.sh:
2343         * Scripts/build-webkit:
2344         * Scripts/do-file-rename:
2345         * Scripts/do-webcore-rename:
2346         * Scripts/update-webkit-localizable-strings:
2347         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2348         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2349         * Scripts/webkitpy/style/checkers/featuredefines.py:
2350         * gtk/manifest.txt.in:
2351
2352 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2353
2354         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2355         https://bugs.webkit.org/show_bug.cgi?id=174438
2356         <rdar://problem/33277112>
2357
2358         Reviewed by Aakash Jain.
2359
2360         Given a patch, this will convert the changes from the path to the new directory structure.
2361
2362         * Scripts/rebase-patch-after-webkit-move: Added.
2363         (append_source): Append 'Source' to the provided path.
2364         (is_editable_line): Return true if a line the script expects to modify.
2365         (needs_rebase): Return if a line needs to be rebased based on it's content.
2366         (rebase_line): Rebase the provided line.
2367         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2368         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2369         were provided.
2370
2371 2017-07-12  Nan Wang  <n_wang@apple.com>
2372
2373         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2374         https://bugs.webkit.org/show_bug.cgi?id=174393
2375         <rdar://problem/33248006>
2376
2377         Reviewed by Chris Fleizach.
2378
2379         * DumpRenderTree/AccessibilityUIElement.cpp:
2380         (textMarkerRangeMatchesTextNearMarkersCallback):
2381         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2382         (AccessibilityUIElement::getJSClass):
2383         * DumpRenderTree/AccessibilityUIElement.h:
2384         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2385         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2386         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2387         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2388         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2389         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2390         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2391         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2392
2393 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2394
2395         Unreviewed, rolling out r219409.
2396
2397         The revision caused the Windows builds to fail.
2398
2399         Reverted changeset:
2400
2401         "AX: [iOS] Implement a way to retrieve a text marker range
2402         with desired text that is closest to a position"
2403         https://bugs.webkit.org/show_bug.cgi?id=174393
2404         http://trac.webkit.org/changeset/219409
2405
2406 2017-07-12  Nan Wang  <n_wang@apple.com>
2407
2408         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2409         https://bugs.webkit.org/show_bug.cgi?id=174393
2410         <rdar://problem/33248006>
2411
2412         Reviewed by Chris Fleizach.
2413
2414         * DumpRenderTree/AccessibilityUIElement.cpp:
2415         (textMarkerRangeMatchesTextNearMarkersCallback):
2416         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2417         (AccessibilityUIElement::getJSClass):
2418         * DumpRenderTree/AccessibilityUIElement.h:
2419         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2420         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2421         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2422         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2423         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2424         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2425         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2426         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2427
2428 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2429
2430         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2431         https://bugs.webkit.org/show_bug.cgi?id=174197
2432
2433         Reviewed by Darin Adler.
2434
2435         This bit me the first time I tried to submit a patch to WebKit, and still I have
2436         to manually edit the ChangeLog every time I use the script.
2437
2438         This generates a more convenient and standard ChangeLog entry.
2439
2440         * Scripts/prepare-ChangeLog:
2441         (generateNewChangeLogs):
2442
2443 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2444
2445         Unreviewed, rolling out r219401.
2446
2447         This revision rolled out the previous patch, but after talking
2448         with reviewer, a rebaseline is what was needed.Rolling back in
2449         before rebaseline.
2450
2451         Reverted changeset:
2452
2453         "Unreviewed, rolling out r219379."
2454         https://bugs.webkit.org/show_bug.cgi?id=174400
2455         http://trac.webkit.org/changeset/219401
2456
2457 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2458
2459         Unreviewed, rolling out r219379.
2460
2461         This revision caused a consistent failure in the test
2462         fast/dom/Window/property-access-on-cached-window-after-frame-
2463         removed.html.
2464
2465         Reverted changeset:
2466
2467         "Remove NAVIGATOR_HWCONCURRENCY"
2468         https://bugs.webkit.org/show_bug.cgi?id=174400
2469         http://trac.webkit.org/changeset/219379
2470
2471 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2472
2473         [WPE] Use libepoxy
2474         https://bugs.webkit.org/show_bug.cgi?id=172104
2475
2476         Reviewed by Michael Catanzaro.
2477
2478         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2479         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2480
2481 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2482
2483         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2484         https://bugs.webkit.org/show_bug.cgi?id=174363
2485
2486         Reviewed by Michael Catanzaro.
2487
2488         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2489         between the GTK+ and WPE port. There's no reason for the two ports to apply
2490         different patches over same versions of GStreamer releases.
2491
2492         This aligns the two ports on this specific issue. Next we'll look into
2493         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2494         to keep these patches in a single place, avoiding duplicate files.
2495
2496         * gtk/jhbuild.modules:
2497         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2498         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2499         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2500         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2501
2502 2017-07-11  Dean Jackson  <dino@apple.com>
2503
2504         Remove NAVIGATOR_HWCONCURRENCY
2505         https://bugs.webkit.org/show_bug.cgi?id=174400
2506
2507         Reviewed by Sam Weinig.
2508
2509         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2510
2511 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2512
2513         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2514         https://bugs.webkit.org/show_bug.cgi?id=174239
2515
2516         Reviewed by Brady Eidson.
2517
2518         Create windows with specific features set and make sure those are properly reflected in the
2519         WKWindowFeatures object.
2520
2521         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2522         (resetToConsistentState):
2523         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2524         (TEST):
2525
2526 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2527
2528         Do not duplicate files when deleting directories with svn 1.9
2529         https://bugs.webkit.org/show_bug.cgi?id=174339
2530         <rdar://problem/33226781>
2531
2532         Reviewed by David Kilzer.
2533
2534         * Scripts/svn-create-patch:
2535         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2536         (generateFileList): Determine which files are deleted because they are part of a
2537         directory being deleted.
2538
2539 2017-07-11  Dean Jackson  <dino@apple.com>
2540
2541         Rolling out r219372.
2542
2543         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2544
2545 2017-07-11  Dean Jackson  <dino@apple.com>
2546
2547         Remove NAVIGATOR_HWCONCURRENCY
2548         https://bugs.webkit.org/show_bug.cgi?id=174400
2549
2550         Reviewed by Sam Weinig.
2551
2552         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2553
2554 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2555
2556         Teach build workers to fetch archives from S3.
2557         https://bugs.webkit.org/show_bug.cgi?id=174384
2558
2559         Reviewed by Aakash Jain.
2560
2561         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2562         (DownloadBuiltProduct):
2563
2564 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2565
2566         Configure buildbot to transfer all archives to S3.
2567         Previously this was Mac only, but it's time to expand!
2568         https://bugs.webkit.org/show_bug.cgi?id=174378
2569         
2570         Reviewed by Aakash Jain.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2573         (BuildFactory.__init__):
2574
2575 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2576
2577         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2578         https://bugs.webkit.org/show_bug.cgi?id=174350
2579
2580         Reviewed by Xabier Rodriguez-Calvar.
2581
2582         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2583         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2584         patches are removed. The patches for gst-plugins-good are updated, removing
2585         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2586         rtpbin elements that will help with the EMEv3 development.
2587
2588         * wpe/jhbuild.modules:
2589         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2590         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2591         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2592         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2593         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2594         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2595         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2596         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2597         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2598
2599 2017-07-10  John Wilander  <wilander@apple.com>
2600
2601         Resource Load Statistics: Prune statistics in orders of importance
2602         https://bugs.webkit.org/show_bug.cgi?id=174215
2603         <rdar://problem/33164403>
2604
2605         Reviewed by Chris Dumez.
2606
2607         Nest infrastructure. Adds these functions:
2608         1. testRunner.setStatisticsLastSeen()
2609         2. setStatisticsMaxStatisticsEntries()
2610         3. setStatisticsPruneEntriesDownTo()
2611
2612         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2613         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2614         (WTR::TestRunner::setStatisticsLastSeen):
2615         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2616         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2617         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2618         * WebKitTestRunner/TestController.cpp:
2619         (WTR::TestController::setStatisticsLastSeen):
2620         (WTR::TestController::setMaxStatisticsEntries):
2621         (WTR::TestController::setPruneEntriesDownTo):
2622         * WebKitTestRunner/TestController.h:
2623         * WebKitTestRunner/TestInvocation.cpp:
2624         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2625         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2626         (WTR::TestController::setStatisticsLastSeen):
2627         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2628         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2629
2630 2017-07-03  Brian Burg  <bburg@apple.com>
2631
2632         Web Replay: remove some unused code
2633         https://bugs.webkit.org/show_bug.cgi?id=173903
2634
2635         Rubber-stamped by Joseph Pecoraro.
2636
2637         * Scripts/run-input-generator-tests: Removed.
2638         * Scripts/webkitpy/replay/__init__.py: Removed.
2639         * Scripts/webkitpy/replay/main.py: Removed.
2640
2641 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2642
2643         [WPE] Fix layout test baseline and TestExpectations hierarchy
2644         https://bugs.webkit.org/show_bug.cgi?id=174092
2645
2646         Reviewed by Michael Catanzaro.
2647
2648         Like for the GTK+ port, override the default_baseline_search_path() and
2649         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2650         Both methods operate on a short list of search paths that defaults to 'wpe' and
2651         'wk2', along with any other user-specified platform directory.
2652
2653         The test_expectations_file_position() method is overridden for testing purposes,
2654         and relevant unit tests are added.
2655
2656         * Scripts/webkitpy/port/wpe.py:
2657         (WPEPort._search_paths):
2658         (WPEPort):
2659         (WPEPort.default_baseline_search_path):
2660         (WPEPort._port_specific_expectations_files):
2661         (WPEPort.test_expectations_file_position):
2662         * Scripts/webkitpy/port/wpe_unittest.py:
2663         (WPEPortTest.test_default_baseline_search_path):
2664         (WPEPortTest):
2665         (WPEPortTest.test_port_specific_expectations_files):
2666
2667 2017-07-10  Chris Dumez  <cdumez@apple.com>
2668
2669         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2670         https://bugs.webkit.org/show_bug.cgi?id=174301
2671
2672         Reviewed by Brent Fulgham.
2673
2674         Rename some of the testRunner API for clarity and to better match what it calls
2675         internally.
2676
2677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2678         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2679         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2680         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2681         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2682         * WebKitTestRunner/TestController.cpp:
2683         (WTR::TestController::statisticsUpdateCookiePartitioning):
2684         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2685         * WebKitTestRunner/TestController.h:
2686         * WebKitTestRunner/TestInvocation.cpp:
2687         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2688         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2689         (WTR::TestController::statisticsUpdateCookiePartitioning):
2690         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2691
2692 2017-07-10  Charlie Turner  <cturner@igalia.com>
2693
2694         [GStreamer] Live twitch.tv videos do not play
2695         https://bugs.webkit.org/show_bug.cgi?id=174222
2696
2697         Reviewed by Michael Catanzaro.
2698
2699         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2700         fixes videos not playing on twitch.tv.
2701
2702         * gtk/jhbuild.modules:
2703
2704 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2705
2706         Add WebGL2 configuration option to build-webkit
2707         https://bugs.webkit.org/show_bug.cgi?id=174251
2708
2709         Reviewed by Michael Catanzaro.
2710
2711         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2712         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2713         is marked as enabled for the Apple Cocoa ports.
2714
2715 2017-07-08  Chris Dumez  <cdumez@apple.com>
2716
2717         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2718         https://bugs.webkit.org/show_bug.cgi?id=174290
2719
2720         Reviewed by Brent Fulgham.
2721
2722         Rename testRunner API to match the new internal API names.
2723
2724         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2726         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2727         (WTR::TestRunner::statisticsSubmitTelemetry):
2728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2729         * WebKitTestRunner/TestController.cpp:
2730         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2731         (WTR::TestController::statisticsSubmitTelemetry):
2732         * WebKitTestRunner/TestController.h:
2733         * WebKitTestRunner/TestInvocation.cpp:
2734         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2735         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2736         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2737         (WTR::TestController::statisticsSubmitTelemetry):
2738
2739 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2740
2741         Drop NOSNIFF compile flag
2742         https://bugs.webkit.org/show_bug.cgi?id=174289
2743
2744         Reviewed by Michael Catanzaro.
2745
2746         * Scripts/webkitperl/FeatureList.pm:
2747         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2748
2749 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2750
2751         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2752         https://bugs.webkit.org/show_bug.cgi?id=174219
2753         <rdar://problem/32083177>
2754
2755         Reviewed by Ryosuke Niwa.
2756
2757         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2758         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2759         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2760         place.
2761
2762         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2763         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2764         no action is taken when dropping.
2765
2766         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2767         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2770         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2771         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2772         (-[MockDragDropSession allowsMoveOperation]):
2773         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2774         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2775         (-[DataInteractionSimulator initWithWebView:]):
2776         (-[DataInteractionSimulator runFrom:to:]):
2777         (-[DataInteractionSimulator _advanceProgress]):
2778         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2779         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2780         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2781
2782 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2783
2784         Unreviewed, rolling out r219238, r219239, and r219241.
2785         https://bugs.webkit.org/show_bug.cgi?id=174265
2786
2787         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2788         (Requested by yusukesuzuki on #webkit).
2789
2790         Reverted changesets:
2791
2792         "[WTF] Implement WTF::ThreadGroup"
2793         https://bugs.webkit.org/show_bug.cgi?id=174081
2794         http://trac.webkit.org/changeset/219238
2795
2796         "Unreviewed, build fix after r219238"
2797         https://bugs.webkit.org/show_bug.cgi?id=174081
2798         http://trac.webkit.org/changeset/219239
2799
2800         "Unreviewed, CLoop build fix after r219238"
2801         https://bugs.webkit.org/show_bug.cgi?id=174081
2802         http://trac.webkit.org/changeset/219241
2803
2804 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2805
2806         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2807         https://bugs.webkit.org/show_bug.cgi?id=174250
2808
2809         Reviewed by Carlos Alberto Lopez Perez.
2810
2811         * Scripts/webkitperl/FeatureList.pm:
2812
2813 2017-07-07  Charlie Turner  <cturner@igalia.com>
2814         [GStreamer] vid.me videos do not play
2815         https://bugs.webkit.org/show_bug.cgi?id=172240
2816
2817         Reviewed by Xabier Rodriguez-Calvar.
2818
2819         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2820         have the existing libsoup build against GNOME to avoid header drift
2821         against GStreamer's linked Soup library.
2822
2823         * gtk/jhbuild.modules:
2824
2825 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2826
2827         Write a support script to enable buildbot to upload to S3
2828         https://bugs.webkit.org/show_bug.cgi?id=174196
2829         
2830         Reviewed by Stephanie Lewis.
2831
2832         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2833         (uploadToS3):
2834         (archiveExists):
2835
2836 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2837
2838         Enabling uploading archives to S3.
2839         https://bugs.webkit.org/show_bug.cgi?id=174198
2840         
2841         Reviewed by Stephanie Lewis.
2842
2843         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2844         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2845         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2846         (TransferToS3): Transfer full and minified archives to S3
2847
2848 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2849
2850         [WTF] Implement WTF::ThreadGroup
2851         https://bugs.webkit.org/show_bug.cgi?id=174081
2852
2853         Reviewed by Mark Lam.
2854
2855         Add WTF::ThreadGroup tests.
2856
2857         * TestWebKitAPI/CMakeLists.txt:
2858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2859         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2860         (TestWebKitAPI::TEST):
2861
2862 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2863
2864         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2865         https://bugs.webkit.org/show_bug.cgi?id=174150
2866
2867         Reviewed by Mark Lam.
2868
2869         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2870         (TestWebKitAPI::TEST):
2871         * TestWebKitAPI/TestsController.cpp:
2872         (TestWebKitAPI::TestsController::TestsController):
2873
2874 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2875
2876         Enabling uploading archives to S3.
2877         https://bugs.webkit.org/show_bug.cgi?id=174198
2878         
2879         Reviewed by Lucas Forschler.
2880
2881         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2882         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2883         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2884         (TransferToS3): Transfer full and minified archives to S3
2885
2886 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2887
2888         [GTK][WPE] kill-old-process should kill more webkit related process
2889         https://bugs.webkit.org/show_bug.cgi?id=174220
2890
2891         Reviewed by Michael Catanzaro.
2892
2893         Generate list of possible webkit-related process names and add
2894         them to the list of process to kill.
2895         Also update the possible system related process for GTK+/WPE.
2896
2897         * BuildSlaveSupport/kill-old-processes:
2898         (listAllWebKitPrograms):
2899         (main):
2900
2901 2017-07-06  Chris Dumez  <cdumez@apple.com>
2902
2903         FileMonitor should not be ref counted
2904         https://bugs.webkit.org/show_bug.cgi?id=174166
2905
2906         Reviewed by Brent Fulgham.
2907
2908         Update the API tests to reflect the API change.
2909
2910         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2911         (TestWebKitAPI::TEST_F):
2912
2913 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2914
2915         Unreviewed, rolling out r219194.
2916         https://bugs.webkit.org/show_bug.cgi?id=174207
2917
2918         it broke some layout tests (Requested by clopez on #webkit).
2919
2920         Reverted changeset:
2921
2922         "[GStreamer] vid.me videos do not play"
2923         https://bugs.webkit.org/show_bug.cgi?id=172240
2924         http://trac.webkit.org/changeset/219194
2925
2926 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2927
2928         Unreviewed, rolling out r219178.
2929
2930         This caused a consistent failure with the API test
2931         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2932
2933         Reverted changeset:
2934
2935         "[WTF] Clean up StringStatics.cpp by using
2936         LazyNeverDestroyed<> for Atoms"
2937         https://bugs.webkit.org/show_bug.cgi?id=174150
2938         http://trac.webkit.org/changeset/219178
2939
2940 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2941
2942         Add CWD to Perl library path (no longer the default since 5.26.0)
2943         https://bugs.webkit.org/show_bug.cgi?id=174200
2944
2945         Reviewed by Michael Catanzaro.
2946
2947         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2948         (SetupGitClone._get_username_and_email):
2949
2950 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2951
2952         Unreviewed, update my email address.
2953
2954         * Scripts/webkitpy/common/config/contributors.json:
2955
2956 2017-07-06  Charlie Turner  <cturner@igalia.com>
2957         [GStreamer] vid.me videos do not play
2958         https://bugs.webkit.org/show_bug.cgi?id=172240
2959
2960         Reviewed by Xabier Rodriguez-Calvar.
2961
2962         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2963         have the existing libsoup build against GNOME to avoid header drift
2964         against GStreamer's linked Soup library.
2965
2966         * gtk/jhbuild.modules:
2967
2968 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2969
2970         [WTF] Move SoftLinking.h into WTF
2971         https://bugs.webkit.org/show_bug.cgi?id=174000
2972
2973         Reviewed by Alex Christensen.
2974
2975         * DumpRenderTree/mac/TestRunnerMac.mm:
2976         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2977         (test_primary_header):
2978         (ErrorCollector.__init__): Deleted.
2979         (ErrorCollector.__call__): Deleted.
2980         (ErrorCollector.results): Deleted.
2981         (ErrorCollector.result_list): Deleted.
2982         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2983         (MockIo.open): Deleted.
2984         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2985         (CppFunctionsTest.test_create_acronym): Deleted.
2986         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2987         (CppFunctionsTest.test_parameter): Deleted.
2988         (CppFunctionsTest.test_single_line_view): Deleted.
2989         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2990         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2991         (CppFunctionsTest.test_parameter_list): Deleted.
2992         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2993         (CppStyleTestBase.process_file_data): Deleted.
2994         (CppStyleTestBase.perform_lint): Deleted.
2995         (CppStyleTestBase.perform_single_line_lint): Deleted.
2996         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2997         (CppStyleTestBase.perform_language_rules_check): Deleted.
2998         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2999         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
3000         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
3001         (CppStyleTestBase.perform_include_what_you_use): Deleted.
3002         (CppStyleTestBase.perform_header_guard_check): Deleted.
3003         (CppStyleTestBase.assert_lint): Deleted.
3004         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
3005         (CppStyleTestBase.assert_multi_line_lint): Deleted.
3006         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
3007         (CppStyleTestBase.assert_language_rules_check): Deleted.
3008         (CppStyleTestBase.assert_include_what_you_use): Deleted.
3009         (CppStyleTestBase.assert_header_guard): Deleted.
3010         (CppStyleTestBase.assert_blank_lines_check): Deleted.
3011         (CppStyleTestBase.assert_positions_equal): Deleted.
3012         (FunctionDetectionTest.test_basic_function_detection): Deleted.
3013         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
3014         (FunctionDetectionTest.test_pure_function_detection): Deleted.
3015         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
3016         (FunctionDetectionTest.test_ignore_macros): Deleted.
3017         (FunctionDetectionTest.test_non_functions): Deleted.
3018         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
3019         (FunctionDetectionTest.test_parameter_list): Deleted.
3020         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
3021         (CppStyleTest.test_asm_lines_ignored): Deleted.
3022         (CppStyleTest.test_get_line_width): Deleted.
3023         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
3024         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
3025         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
3026         (CppStyleTest.test_position): Deleted.
3027         (CppStyleTest.test_rfind_in_lines): Deleted.
3028         (CppStyleTest.test_close_expression): Deleted.
3029         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
3030         (CppStyleTest.test_cstyle_cast): Deleted.
3031         (CppStyleTest.test_runtime_casting): Deleted.
3032         (CppStyleTest.test_runtime_selfinit): Deleted.
3033         (CppStyleTest.test_runtime_rtti): Deleted.
3034         (CppStyleTest.test_static_cast_readability): Deleted.
3035         (CppStyleTest.test_check_for_unnamed_params): Deleted.
3036         (CppStyleTest.void): Deleted.
3037         (CppStyleTest.test_deprecated_cast): Deleted.
3038         (CppStyleTest.test_mock_method): Deleted.
3039         (CppStyleTest.test_sizeof_type): Deleted.
3040         (CppStyleTest.cases): Deleted.
3041         (CppStyleTest.for): Deleted.
3042         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
3043         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
3044         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
3045         (CppStyleTest.test_include_what_you_use): Deleted.
3046         (CppStyleTest.test_files_belong_to_same_module): Deleted.
3047         (CppStyleTest.test_cleanse_line): Deleted.
3048         (CppStyleTest.test_multi_line_comments): Deleted.
3049         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
3050         (CppStyleTest.test_multiline_strings): Deleted.
3051         (CppStyleTest.test_platformh_comments): Deleted.
3052         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
3053         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
3054         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
3055         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
3056         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
3057         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
3058         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
3059         (CppStyleTest.test_check_posix_threading): Deleted.
3060         (CppStyleTest.test_insecure_string_operations): Deleted.
3061         (CppStyleTest.test_format_strings): Deleted.
3062         (CppStyleTest.test_insecure_temp_file): Deleted.
3063         (CppStyleTest.test_variable_length_array_detection): Deleted.
3064         (CppStyleTest.test_braces): Deleted.
3065         (CppStyleTest.test_check_check): Deleted.
3066         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
3067         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
3068         (CppStyleTest.test_spacing_for_fncall): Deleted.
3069         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
3070         (CppStyleTest.test_spacing_before_braces): Deleted.
3071         (CppStyleTest.test_spacing_between_braces): Deleted.
3072         (CppStyleTest.test_spacing_before_brackets): Deleted.
3073         (CppStyleTest.test_cpp_lambda_functions): Deleted.
3074         (CppStyleTest.test_objective_c_block): Deleted.
3075         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
3076         (CppStyleTest.test_spacing_around_else): Deleted.
3077         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
3078         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
3079         (CppStyleTest.test_operator_methods): Deleted.
3080         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
3081         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
3082         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
3083         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
3084         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
3085         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
3086         (CppStyleTest.test_space_after_comment_marker): Deleted.
3087         (CppStyleTest.test_newline_at_eof): Deleted.
3088         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
3089         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
3090         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
3091         (CppStyleTest.test_invalid_utf8): Deleted.
3092         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
3093         (CppStyleTest.test_is_blank_line): Deleted.
3094         (CppStyleTest.test_blank_lines_check): Deleted.
3095         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
3096         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
3097         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
3098         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
3099         (CppStyleTest.test_comma): Deleted.
3100         (CppStyleTest.test_declaration): Deleted.
3101         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
3102         (CppStyleTest.test_indent): Deleted.
3103         (CppStyleTest.test_indent.Foo): Deleted.
3104         (CppStyleTest.test_not_alabel): Deleted.
3105         (CppStyleTest.test_tab): Deleted.
3106         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
3107         (CppStyleTest.test_build_class): Deleted.
3108         (CppStyleTest.test_build_class.definitions): Deleted.
3109         (CppStyleTest.test_build_class.Foo): Deleted.
3110         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
3111         (CppStyleTest.test_build_end_comment): Deleted.
3112         (CppStyleTest.test_build_forward_decl): Deleted.
3113         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
3114         (CppStyleTest.test_build_header_guard): Deleted.
3115         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
3116         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
3117         (CppStyleTest.test_build_printf_format): Deleted.
3118         (CppStyleTest.test_runtime_printf_format): Deleted.
3119         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
3120         (CppStyleTest.test_build_storage_class): Deleted.
3121         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
3122         (CppStyleTest.test_build_storage_class.declaration): Deleted.
3123         (CppStyleTest.test_build_storage_class.after): Deleted.
3124         (CppStyleTest.test_build_storage_class.is): Deleted.
3125         (CppStyleTest.test_legal_copyright): Deleted.
3126         (CppStyleTest.test_invalid_increment): Deleted.
3127         (CppStyleTest.test_enum_bitfields): Deleted.
3128         (CppStyleTest.test_plain_integral_bitfields): Deleted.
3129         (CleansedLinesTest.test_init_empty): Deleted.
3130         (CleansedLinesTest.test_collapse_strings): Deleted.
3131         (OrderOfIncludesTest.tearDown): Deleted.
3132         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
3133         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
3134         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
3135         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
3136         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
3137         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
3138         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
3139         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
3140         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
3141         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
3142         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
3143         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
3144         (OrderOfIncludesTest.test_primary_header): Deleted.
3145         (OrderOfIncludesTest.test_public_primary_header): Deleted.
3146         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
3147         (OrderOfIncludesTest.test_classify_include): Deleted.
3148         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
3149         (CheckForFunctionLengthsTest.tearDown): Deleted.
3150         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
3151         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
3152         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
3153         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
3154         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
3155         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
3156         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
3157         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
3158         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
3159         (CheckForFunctionLengthsTest.function_body): Deleted.
3160         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
3161         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
3162         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
3163         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
3164         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
3165         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
3166         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
3167         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
3168         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
3169         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
3170         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
3171         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
3172         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
3173         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
3174         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
3175         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
3176         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
3177         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
3178         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
3179         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
3180         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
3181         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
3182         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
3183         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
3184         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
3185         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
3186         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
3187         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
3188         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
3189         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
3190         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
3191         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
3192         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
3193         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
3194         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
3195         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
3196         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
3197         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
3198         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
3199         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
3200         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
3201         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
3202         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
3203         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
3204         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
3205         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
3206         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
3207         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
3208         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
3209         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
3210         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
3211         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
3212         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
3213         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
3214         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
3215         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
3216         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
3217         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
3218         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
3219         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
3220         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
3221         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
3222         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
3223         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
3224         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
3225         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
3226         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
3227         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
3228         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
3229         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
3230         (LeakyPatternTest.test_get_dc): Deleted.
3231         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
3232         (LeakyPatternTest.test_own_get_dc): Deleted.
3233         (LeakyPatternTest.test_create_dc): Deleted.
3234         (LeakyPatternTest.test_create_compatible_dc): Deleted.
3235         (WebKitStyleTest.test_indentation): Deleted.
3236         (WebKitStyleTest.test_indentation.Foo): Deleted.
3237         (WebKitStyleTest.test_indentation.Document): Deleted.
3238         (WebKitStyleTest.test_spacing): Deleted.
3239         (WebKitStyleTest.test_line_breaking): Deleted.
3240         (WebKitStyleTest.test_braces): Deleted.
3241         (WebKitStyleTest.test_braces.MyClass): Deleted.
3242         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
3243         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
3244         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
3245         (WebKitStyleTest.test_null_false_zero): Deleted.
3246         (WebKitStyleTest.test_directive_indentation): Deleted.
3247         (WebKitStyleTest.test_using_std): Deleted.
3248         (WebKitStyleTest.test_using_namespace): Deleted.
3249         (WebKitStyleTest.test_max_macro): Deleted.
3250         (WebKitStyleTest.test_min_macro): Deleted.
3251         (WebKitStyleTest.test_wtf_move): Deleted.
3252         (WebKitStyleTest.test_ctype_fucntion): Deleted.
3253         (WebKitStyleTest.test_names): Deleted.
3254         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
3255         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
3256         (WebKitStyleTest.test_names.declarations): Deleted.
3257         (WebKitStyleTest.test_names.struct): Deleted.
3258         (WebKitStyleTest.test_names.VectorType): Deleted.
3259         (WebKitStyleTest.test_parameter_names): Deleted.
3260         (WebKitStyleTest.test_comments): Deleted.
3261         (WebKitStyleTest.test_webkit_export_check): Deleted.
3262         (WebKitStyleTest.test_member_initialization_list): Deleted.
3263         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
3264         (WebKitStyleTest.test_other): Deleted.
3265         (CppCheckerTest.mock_handle_style_error): Deleted.
3266         (CppCheckerTest._checker): Deleted.
3267         (CppCheckerTest.test_init): Deleted.
3268         (CppCheckerTest.test_eq): Deleted.
3269         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
3270         (CppCheckerTest.test_ne): Deleted.
3271         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3272         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3273         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3274         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3275         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3276         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3277
3278 2017-07-05  Saam Barati  <sbarati@apple.com>
3279
3280         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
3281         https://bugs.webkit.org/show_bug.cgi?id=174188
3282         <rdar://problem/30581423>
3283
3284         Reviewed by Mark Lam.
3285
3286         * Scripts/run-jsc-stress-tests:
3287
3288 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3289
3290         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3291         https://bugs.webkit.org/show_bug.cgi?id=174150
3292
3293         Reviewed by Mark Lam.
3294
3295         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3296         (TestWebKitAPI::TEST):
3297
3298 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3299
3300         Remove copy of ICU headers from WebKit
3301         https://bugs.webkit.org/show_bug.cgi?id=116407
3302
3303         Reviewed by Alex Christensen.
3304
3305         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3306         * TestWebKitAPI/Configurations/Base.xcconfig:
3307         * WebKitTestRunner/Configurations/Base.xcconfig:
3308
3309 2017-07-05  Chris Dumez  <cdumez@apple.com>
3310
3311         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
3312         https://bugs.webkit.org/show_bug.cgi?id=174163
3313         <rdar://problem/33067518>
3314
3315         Reviewed by Alex Christensen.
3316
3317         Add API test coverage.
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3321         (TEST):
3322
3323 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3324
3325         When dragging a selection, clearing the selection in dragstart should not crash the web process
3326         https://bugs.webkit.org/show_bug.cgi?id=174142
3327         <rdar://problem/33067501>
3328
3329         Reviewed by Tim Horton.
3330
3331         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3332         drag is starting up.
3333
3334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3335         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3336         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3337         (TestWebKitAPI::TEST):
3338
3339 2017-07-05  Daniel Bates  <dabates@apple.com>
3340
3341         Do not pass API::FrameInfo for source frame or clear out page of target frame on
3342         API navigation
3343         https://bugs.webkit.org/show_bug.cgi?id=174170
3344         <rdar://problem/33140328>
3345
3346         Reviewed by Brady Eidson.
3347
3348         Update tests as needed for the behavior change.
3349
3350         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3351         (TEST):
3352
3353 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3354
3355         Add WebKitPrivateFrameworkStubs for iOS 11
3356         https://bugs.webkit.org/show_bug.cgi?id=173988
3357
3358         Reviewed by David Kilzer.
3359
3360         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3361         should use the same directory for private framework stubs.
3362         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3363
3364 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
3365
3366         [MediaStream] Protect request and web view during gUM client callback
3367         https://bugs.webkit.org/show_bug.cgi?id=174096
3368         <rdar://problem/32833102>
3369
3370         Reviewed by Youenn Fablet.
3371
3372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3373         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3374
3375 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3376
3377         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3378
3379         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3380
3381 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3382
3383         Unreviewed, rolling out r219128.
3384
3385         Spoke with engineer who originally submitted, Patch for APi
3386         test to follow.
3387
3388         Reverted changeset:
3389
3390         "Unreviewed, rolling out r219070."
3391         https://bugs.webkit.org/show_bug.cgi?id=174082
3392         http://trac.webkit.org/changeset/219128
3393
3394 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3395
3396         Unreviewed, rolling out r219070.
3397
3398         This revision caused consistent failures of the API test
3399         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3400
3401         Reverted changeset:
3402
3403         "Pasting single words copied to UIPasteboard inserts URLs in
3404         editable areas"
3405         https://bugs.webkit.org/show_bug.cgi?id=174082
3406         http://trac.webkit.org/changeset/219070
3407
3408 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3409
3410         Remove unused EFL logo from bot watcher dashboard
3411         https://bugs.webkit.org/show_bug.cgi?id=174136
3412
3413         Reviewed by Alexey Proskuryakov.
3414
3415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3417
3418 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3419
3420         [GTK] Add more GTK bots to dashboard
3421         https://bugs.webkit.org/show_bug.cgi?id=174129
3422
3423         Reviewed by Carlos Alberto Lopez Perez.
3424
3425         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3426         them.
3427
3428         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3429         less-essential GTK bots.
3430
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3433         (WebKitBuildbot):
3434
3435 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3436
3437         [WPE] Add WPE to bot watcher dashboard
3438         https://bugs.webkit.org/show_bug.cgi?id=174119
3439
3440         Reviewed by Alexey Proskuryakov.
3441
3442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3447         (WebKitBuildbot):
3448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3449         (table.queue-grid tr.platform.linux-wpe img.logo):
3450
3451 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3452
3453         https://bugs.webkit.org/show_bug.cgi?id=174105
3454         
3455         Reviewed by Stephanie Lewis.
3456
3457         * BuildSlaveSupport/built-product-archive:
3458         (main): Add a -minify parser option
3459         (createZip): Pass along the optional Minify argument if requested
3460         (minifySource): This will trim down archives, logic limited to Mac platform.
3461
3462 2017-07-03  Matt Rajca  <mrajca@apple.com>
3463
3464         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3465         https://bugs.webkit.org/show_bug.cgi?id=174103
3466
3467         Reviewed by Alex Christensen.
3468
3469         Added an API test.
3470
3471         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3472         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3473         (TEST): Added test.
3474         * TestWebKitAPI/cocoa/TestWKWebView.h:
3475         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3476         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3477
3478 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3479
3480         Unreviewed, rolling out r219103.
3481
3482         Caused multiple build failures.
3483
3484         Reverted changeset:
3485
3486         "Remove copy of ICU headers from WebKit"
3487         https://bugs.webkit.org/show_bug.cgi?id=116407
3488         http://trac.webkit.org/changeset/219103
3489
3490 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3491
3492         Remove copy of ICU headers from WebKit
3493         https://bugs.webkit.org/show_bug.cgi?id=116407
3494
3495         Reviewed by Alex Christensen.
3496
3497         Use WTF's copy of ICU headers.
3498
3499         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3500         * TestWebKitAPI/Configurations/Base.xcconfig:
3501         * WebKitTestRunner/Configurations/Base.xcconfig:
3502
3503 2017-07-03  Brady Eidson  <beidson@apple.com>
3504
3505         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3506         https://bugs.webkit.org/show_bug.cgi?id=174073
3507
3508         Reviewed by Andy Estes.
3509
3510         * DumpRenderTree/mac/TestRunnerMac.mm:
3511         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3512
3513         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3514         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3515
3516 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3517
3518         Unreviewed, rolling out r219083.
3519
3520         The revision caused an API failure on all testing platforms.
3521
3522         Reverted changeset:
3523
3524         "[MediaStream] Protect request and web view during gUM client
3525         callback"
3526         https://bugs.webkit.org/show_bug.cgi?id=174096
3527         http://trac.webkit.org/changeset/219083
3528
3529 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3530
3531         webkitpy: Properly number duplicated crashlogs
3532         https://bugs.webkit.org/show_bug.cgi?id=172002
3533
3534         Reviewed by Aakash Jain.
3535
3536         * Scripts/webkitpy/common/system/crashlogs.py:
3537         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3538         an increasing integer.
3539         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3540         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3541         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3542         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3543
3544 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3545
3546         WebContent processes crash when the network process crashes with pending connection requests
3547         https://bugs.webkit.org/show_bug.cgi?id=174065
3548         <rdar://problem/30359835>
3549
3550         Reviewed by Tim Horton.
3551
3552         Add a API to ensure UI process tries to relaunch a new network process when the network process
3553         crashes with pending network connection requests.
3554
3555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3556         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3557         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3558         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3559         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3560
3561 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3562
3563         [MediaStream] Protect request and web view during gUM client callback
3564         https://bugs.webkit.org/show_bug.cgi?id=174096
3565         <rdar://problem/32833102>
3566
3567         Reviewed by Youenn Fablet.
3568
3569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3570         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3571
3572 2017-07-03  Andy Estes  <aestes@apple.com>
3573
3574         [Xcode] Add an experimental setting to build with ccache
3575         https://bugs.webkit.org/show_bug.cgi?id=173875
3576
3577         Reviewed by Tim Horton.
3578
3579         On systems that already have ccache(1) installed, this patch adds experimental support for
3580         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3581
3582         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3583         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3584         find the toolchain from which to run clang, and then invokes ccache with the required
3585         arguments.
3586
3587         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3588         precompiled headers to work properly [1].
3589
3590         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3591         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3592         during linking.
3593         
3594         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3595