Source/WebKit:
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
2
3         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
4         https://bugs.webkit.org/show_bug.cgi?id=185831
5
6         Reviewed by Chris Dumez.
7
8         Updated the test to prevent crash after assertion fails.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
11         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
12
13 2018-05-22  Chris Dumez  <cdumez@apple.com>
14
15         Regression(AsyncPolicyDelegates): Box.app login Window is blank
16         https://bugs.webkit.org/show_bug.cgi?id=185832
17         <rdar://problem/40307871>
18
19         Reviewed by Geoffrey Garen.
20
21         Add API test coverage.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
25         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
26         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
27         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
28         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
29         (TestWebKitAPI::TEST):
30         * TestWebKitAPI/cocoa/TestWKWebView.mm:
31         (-[WKWebView _isBackground]):
32
33 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
34
35         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
36         https://bugs.webkit.org/show_bug.cgi?id=185715
37
38         Reviewed by Geoffrey Garen.
39
40         Add API test coverage.
41
42         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
43         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
44         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
45         (TEST):
46
47 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
48
49         Unreviewed, added myself as a WebKit committer.
50
51         * Scripts/webkitpy/common/config/contributors.json:
52
53 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
54
55         Unreviewed, rolling out r232052.
56
57         Breaks internal builds.
58
59         Reverted changeset:
60
61         "Use more C++17"
62         https://bugs.webkit.org/show_bug.cgi?id=185176
63         https://trac.webkit.org/changeset/232052
64
65 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
66
67         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
68         https://bugs.webkit.org/show_bug.cgi?id=185689
69
70         Reviewed by Philippe Normand.
71
72         And update the patches, removing the ones that have been merged upstream.
73
74         * gstreamer/jhbuild.modules:
75         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
76         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
77         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
78         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
79         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
80         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
81         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
82         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
83
84 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
85
86         Use more C++17
87         https://bugs.webkit.org/show_bug.cgi?id=185176
88
89         Reviewed by JF Bastien.
90
91         * DumpRenderTree/mac/Configurations/Base.xcconfig:
92         * ImageDiff/cg/Configurations/Base.xcconfig:
93         * MiniBrowser/Configurations/Base.xcconfig:
94         * MobileMiniBrowser/Configurations/Base.xcconfig:
95         * TestWebKitAPI/Configurations/Base.xcconfig:
96         * WebKitTestRunner/Configurations/Base.xcconfig:
97
98 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
99
100         [WinCairo] Enable WebKit build by default
101         https://bugs.webkit.org/show_bug.cgi?id=185141
102
103         Reviewed by Per Arne Vollan.
104
105         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
106         WebKitForwardingHeaders because config.h includes a header of WK2.
107
108         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
109         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
110
111 2018-05-21  Jer Noble  <jer.noble@apple.com>
112
113         Complete fix for enabling modern EME by default
114         https://bugs.webkit.org/show_bug.cgi?id=185770
115         <rdar://problem/40368220>
116
117         Reviewed by Eric Carlson.
118
119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
120
121 2018-05-18  Christopher Reid  <chris.reid@sony.com>
122
123         Unreviewed, add myself as a WebKit committer.
124
125         * Scripts/webkitpy/common/config/contributors.json:
126
127 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
128
129         Unreviewed, rolling out r222967.
130
131         It's not ready yet
132
133         Reverted changeset:
134
135         "[GTK][WPE] Add API to configure and enable resource load
136         statistics"
137         https://bugs.webkit.org/show_bug.cgi?id=177943
138         https://trac.webkit.org/changeset/222967
139
140 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
141
142         [GTK] MiniBrowser crashes when loading twice quickly
143         https://bugs.webkit.org/show_bug.cgi?id=185763
144
145         Reviewed by Michael Catanzaro.
146
147         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
148         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
149         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
150         leaked, it will crash when scheduled if the window has already been destroyed.
151
152         * MiniBrowser/gtk/BrowserWindow.c:
153         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
154
155 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
156
157         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
158         https://bugs.webkit.org/show_bug.cgi?id=185624
159         <rdar://problem/39111626>
160
161         Reviewed by Chris Dumez.
162
163         Modified expectation to make test more robust as cookies can be returned in different orders.
164
165         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
166         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
167         (TEST):
168
169 2018-05-18  Commit Queue  <commit-queue@webkit.org>
170
171         Unreviewed, rolling out r231982.
172         https://bugs.webkit.org/show_bug.cgi?id=185793
173
174         Caused layout test failures (Requested by realdawei on
175         #webkit).
176
177         Reverted changeset:
178
179         "Complete fix for enabling modern EME by default"
180         https://bugs.webkit.org/show_bug.cgi?id=185770
181         https://trac.webkit.org/changeset/231982
182
183 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
184
185         Handle failure to extend sandbox gracefully
186         https://bugs.webkit.org/show_bug.cgi?id=185779
187         <rdar://problem/40316349>
188
189         Unreviewed, fix test results.
190
191         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
192         (TEST_F):
193
194 2018-05-18  Jer Noble  <jer.noble@apple.com>
195
196         Complete fix for enabling modern EME by default
197         https://bugs.webkit.org/show_bug.cgi?id=185770
198         <rdar://problem/40368220>
199
200         Reviewed by Eric Carlson.
201
202         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
203
204 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
205
206         Handle failure to extend sandbox gracefully
207         https://bugs.webkit.org/show_bug.cgi?id=185779
208         <rdar://problem/40316349>
209
210         Reviewed by Brent Fulgham.
211
212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
213         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
214         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
215         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
216         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
217         (MediaCaptureSimulateFailedSandbox::SetUp):
218         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
219         (TEST_F):
220         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
221
222 2018-05-18  Daniel Bates  <dabates@apple.com>
223
224         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
225         https://bugs.webkit.org/show_bug.cgi?id=185774
226
227         Reviewed by Andy Estes.
228
229         For now, the script debug-safari is not supported for WebKit for iOS. To
230         fix this we differentiate between the Apple Mac port and Apple embedded
231         ports.
232
233         * Scripts/webkitdirs.pm:
234         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
235         (isAppleMacWebKit): Added.
236         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
237         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
238         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
239         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
240         (runSafari): Ditto.
241         (runMiniBrowser): Ditto.
242         (debugMiniBrowser): Ditto.
243         (runWebKitTestRunner): Ditto.
244         (debugWebKitTestRunner): Ditto.
245
246 2018-05-18  Antoine Quint  <graouts@apple.com>
247
248         [Web Animations] Turn Web Animations with CSS integration on for test runners
249         https://bugs.webkit.org/show_bug.cgi?id=184819
250         <rdar://problem/39597337>
251
252         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
253
254         * DumpRenderTree/TestOptions.cpp:
255         (TestOptions::TestOptions):
256         * DumpRenderTree/TestOptions.h:
257         * DumpRenderTree/mac/DumpRenderTree.mm:
258         (runTest):
259         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
260         * WebKitTestRunner/TestController.cpp:
261         (WTR::TestController::resetPreferencesToConsistentValues):
262         (WTR::updateTestOptionsFromTestHeader):
263         * WebKitTestRunner/TestOptions.cpp:
264         (WTR::TestOptions::TestOptions):
265         (WTR::isLegacyAnimationEngineTestPath): Deleted.
266         * WebKitTestRunner/TestOptions.h:
267
268 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
269
270         [Win][MiniBrowser] Create MainWindow even in transparent mode
271         https://bugs.webkit.org/show_bug.cgi?id=185597
272
273         Reviewed by Per Arne Vollan.
274
275         The current implementations doesn't create the MainWindow in
276         transparent mode. The screenshot is in Bug 58300.
277
278         There were three problems:
279         - Can't control the WebView. ie. going backward and forward.
280         - Can't quit the program.
281         - It makes implementation complicated.
282
283         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
284         even in the transparent mode.
285         * MiniBrowser/win/WinMain.cpp:
286         (wWinMain): Create the main window even in the transparent mode.
287
288 2018-05-18  Antoine Quint  <graouts@apple.com>
289
290         [Web Animations] Turn Web Animations with CSS integration on for test runners
291         https://bugs.webkit.org/show_bug.cgi?id=184819
292         <rdar://problem/39597337>
293
294         Reviewed by Jon Lee.
295
296         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
297         integration flag on.
298
299         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
300         comment directly at the top of the file since test runners now set the flag on by default
301         and a dedicated directory exists for tests that need to run with this flag off.
302
303         * DumpRenderTree/TestOptions.cpp:
304         (TestOptions::TestOptions):
305         * DumpRenderTree/TestOptions.h:
306         * DumpRenderTree/mac/DumpRenderTree.mm:
307         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
308         (runTest):
309         * WebKitTestRunner/TestController.cpp:
310         (WTR::TestController::resetPreferencesToConsistentValues):
311         (WTR::updateTestOptionsFromTestHeader):
312         * WebKitTestRunner/TestOptions.cpp:
313         (WTR::isLegacyAnimationEngineTestPath):
314         (WTR::TestOptions::TestOptions):
315         * WebKitTestRunner/TestOptions.h:
316
317 2018-05-17  Nan Wang  <n_wang@apple.com>
318
319         AX: [macOS] Expose the primary screen height through AX API
320         https://bugs.webkit.org/show_bug.cgi?id=185742
321
322         Reviewed by Chris Fleizach.
323
324         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
325         (attributesOfElement):
326         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
327         (WTR::attributesOfElement):
328
329 2018-05-17  Commit Queue  <commit-queue@webkit.org>
330
331         Unreviewed, rolling out r231912.
332         https://bugs.webkit.org/show_bug.cgi?id=185750
333
334         It is prompting the user when there is no WPT changes
335         (Requested by bmac on #webkit).
336
337         Reverted changeset:
338
339         "Export changes to web-platform-test as part of the webkit-
340         patch upload workflow"
341         https://bugs.webkit.org/show_bug.cgi?id=184914
342         https://trac.webkit.org/changeset/231912
343
344 2018-05-17  Valerie R Young  <valerie@bocoup.com>
345
346         test262/Runner.pm: expand $INC to find webkitdirs.pm
347         https://bugs.webkit.org/show_bug.cgi?id=185739
348
349         Reviewed by Michael Saboff.
350
351         * Scripts/test262/Runner.pm:
352         (getBuildPath):
353
354 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
355
356         [WPE] Implement and enable FULLSCREEN_API
357         https://bugs.webkit.org/show_bug.cgi?id=185676
358
359         Reviewed by Žan Doberšek.
360
361         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
362         (testWebViewFullScreen):
363
364 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
365
366         Export changes to web-platform-test as part of the webkit-patch upload workflow
367         https://bugs.webkit.org/show_bug.cgi?id=184914
368
369         Reviewed by Youenn Fablet.
370
371         * Scripts/webkitpy/tool/commands/upload.py:
372         (Upload):
373         (CreateBug.execute):
374         (WPTChangeExport):
375         * Scripts/webkitpy/tool/steps/__init__.py:
376         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
377         (WPTChangeExport):
378         (WPTChangeExport.options):
379         (WPTChangeExport.run):
380         * Scripts/webkitpy/w3c/common.py:
381         * Scripts/webkitpy/w3c/test_exporter.py:
382         (WebPlatformTestExporter):
383         (WebPlatformTestExporter.__init__):
384         (WebPlatformTestExporter.username):
385         (WebPlatformTestExporter.token):
386         (WebPlatformTestExporter._github):
387         (WebPlatformTestExporter._wpt_fork_branch_github_url):
388         (WebPlatformTestExporter._wpt_fork_remote):
389         (WebPlatformTestExporter._wpt_fork_push_url):
390         (WebPlatformTestExporter._git):
391         (WebPlatformTestExporter._branch_name):
392         (WebPlatformTestExporter._public_branch_name):
393         (WebPlatformTestExporter.has_wpt_changes):
394         (WebPlatformTestExporter._create_patch):
395         (WebPlatformTestExporter.create_git_patch):
396         (WebPlatformTestExporter._prompt_for_token):
397         (WebPlatformTestExporter._prompt_for_username):
398         (WebPlatformTestExporter._ensure_username_and_token):
399         (WebPlatformTestExporter._validate_and_save_token):
400         (WebPlatformTestExporter.push_to_wpt_fork):
401         (WebPlatformTestExporter.make_pull_request):
402         (WebPlatformTestExporter.delete_local_branch):
403         (parse_args):
404         (TestExporter): Deleted.
405         (TestExporter.__init__): Deleted.
406         (TestExporter._ensure_wpt_repository): Deleted.
407         (TestExporter._fetch_wpt_repository): Deleted.
408         (TestExporter._ensure_new_branch_name): Deleted.
409         (TestExporter.download_and_commit_patch): Deleted.
410         (TestExporter.clean): Deleted.
411         (TestExporter.create_branch_with_patch): Deleted.
412         (TestExporter.push_to_wpt_fork): Deleted.
413         (TestExporter.make_pull_request): Deleted.
414         (TestExporter.create_wpt_pull_request): Deleted.
415         (TestExporter.delete_local_branch): Deleted.
416         (TestExporter.create_git_patch): Deleted.
417         (TestExporter.create_upload_remote_if_needed): Deleted.
418         (TestExporter.do_export): Deleted.
419         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
420         (TestExporterTest.test_export):
421         (TestExporterTest.test_export_with_specific_branch):
422         (TestExporterTest):
423         (TestExporterTest.test_export_interactive_mode):
424         (TestExporterTest.test_export_invalid_token):
425         (TestExporterTest.test_export_wrong_token):
426
427 2018-05-17  Valerie R Young  <valerie@bocoup.com>
428
429         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
430         https://bugs.webkit.org/show_bug.cgi?id=185650
431
432         Reviewed by Michael Saboff.
433
434         First, use jsc from CLI arg, then try to use webkit-build-directory,
435         if that doesn't work, look for jsc in the $PATH
436
437         * Scripts/test262/Runner.pm:
438         (processCLI):
439         (getBuildPath):
440         (runTest):
441
442 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
443
444         Test262-Runner: Adds a --timeout option
445         https://bugs.webkit.org/show_bug.cgi?id=185696
446
447         Reviewed by Michael Saboff.
448
449         The timeout option is used to set a timeout execution in ms for each test run in JSC.
450         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
451         * Scripts/test262/Runner.pm:
452         (processCLI):
453         (runTest):
454
455 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
456
457         Test262-Runner: Set timer for each test run
458         https://bugs.webkit.org/show_bug.cgi?id=185692
459
460         Reviewed by Michael Saboff.
461
462         Sets a high resolution timer for each execution call of JSC, reporting
463         the time in the results report to allow identifying slow tests.
464         * Scripts/test262/Runner.pm:
465         (main):
466         (processFile):
467         (runTest):
468         (processResult):
469
470 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
471
472         Add support for Intl NumberFormat formatToParts
473         https://bugs.webkit.org/show_bug.cgi?id=185375
474
475         Reviewed by Yusuke Suzuki.
476
477         Add flag for NumberFormat formatToParts.
478
479         * Scripts/webkitperl/FeatureList.pm:
480         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
481
482 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
483
484         [Win] Use C++17 in MSVC
485         https://bugs.webkit.org/show_bug.cgi?id=185232
486
487         Reviewed by Alex Christensen.
488
489         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
490         conflicts with ::byte defined in Windows' header.
491
492         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
493         (WindowedPluginTest::WindowedPluginTest):
494         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
495         (logEventProc):
496         (stringEvent):
497         (AccessibilityController::winNotificationReceived):
498         * DumpRenderTree/win/TextInputController.cpp:
499         (markedRangeCallback):
500         (firstRectForCharacterRangeCallback):
501         (selectedRangeCallback):
502         * DumpRenderTree/win/TextInputController.h:
503         * DumpRenderTree/win/TextInputControllerWin.cpp:
504         (TextInputController::markedRange):
505         (TextInputController::firstRectForCharacterRange):
506         (TextInputController::selectedRange):
507
508 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
509
510         Session cookies aren't reliably set when using default WKWebSiteDataStore
511         https://bugs.webkit.org/show_bug.cgi?id=185624
512         <rdar://problem/39111626>
513
514         Reviewed by Geoffrey Garen.
515
516         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
517
518         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
519         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
520         (TEST):
521
522 2018-05-16  Valerie R Young  <valerie@bocoup.com>
523
524         test262/Runner.pm: save to supplied expectation file if supplied
525         https://bugs.webkit.org/show_bug.cgi?id=185660
526
527         Reviewed by Michael Saboff.
528
529         * Scripts/test262/Runner.pm:
530         (processCLI):
531         (main):
532
533 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
534
535         Unreviewed, rolling out r231763.
536
537         The test added with this change is failing an assertion.
538
539         Reverted changeset:
540
541         "NSEvent event trackers don't work from WebKitTestRunner"
542         https://bugs.webkit.org/show_bug.cgi?id=185383
543         https://trac.webkit.org/changeset/231763
544
545 2018-05-15  David Kilzer  <ddkilzer@apple.com>
546
547         TestWebKitAPI: Fix warnings found by new clang compiler
548         <https://webkit.org/b/185631>
549
550         Reviewed by Michael Catanzaro.
551
552         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
553         (TestWebKitAPI::TEST):
554         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
555         (TestWebKitAPI::TEST):
556         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
557         (TestWebKitAPI::TEST):
558         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
559         (TestWebKitAPI::TEST):
560         - Add #pragma statements to ignore the new
561           -Wself-assign-overloaded warning and to ignore
562           this as an unknown warning on older clang versions.  We want
563           to keep these self assigments as this code is designed to test
564           that use case.
565
566         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
567         (TestWebKitAPI::didFindStringMatches):
568         - Replace the "rect = rect;" statement that was used to avoid an
569           unused variable warning with two expectations.
570
571         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
572         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
573         - Switch from -integerValue to -unsignedIntegerValue when
574           comparing against _WKRectEdgeAll since it's an enum declared
575           as an NSUInteger.
576
577 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
578
579         Unreviewed, rolling out r230749
580
581         This did not work as desired.
582
583         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
584         (TestWebKitAPI::TEST):
585
586 2018-05-15  Antoine Quint  <graouts@apple.com>
587
588         [Web Animations] Expose Web Animations CSS integration as an experimental feature
589         https://bugs.webkit.org/show_bug.cgi?id=185647
590
591         Reviewed by Dean Jackson.
592
593         Rename the Web Animations CSS integration flag.
594
595         * DumpRenderTree/TestOptions.cpp:
596         (TestOptions::TestOptions):
597         * DumpRenderTree/TestOptions.h:
598         * DumpRenderTree/mac/DumpRenderTree.mm:
599         (setWebPreferencesForTestOptions):
600         * WebKitTestRunner/TestController.cpp:
601         (WTR::TestController::resetPreferencesToConsistentValues):
602         (WTR::updateTestOptionsFromTestHeader):
603         * WebKitTestRunner/TestOptions.h:
604         (WTR::TestOptions::hasSameInitializationOptions const):
605
606 2018-05-14  Brady Eidson  <beidson@apple.com>
607
608         Add an API test to guard against regressions while re-entering setDefersLoading:.
609         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
610
611         Reviewed by Chris Dumez.
612
613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
614         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
615         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
616         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
617         (-[DefersScheme initWithBytes:]):
618         (-[DefersScheme webView:startURLSchemeTask:]):
619         (-[DefersScheme webView:stopURLSchemeTask:]):
620         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
621         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
622         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
623         (-[DoubleDefersLoadingPlugIn dealloc]):
624
625 2018-05-14  Daniel Bates  <dabates@apple.com>
626
627         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
628         https://bugs.webkit.org/show_bug.cgi?id=185599
629         <rdar://problem/22493890>
630
631         Reviewed by Simon Fraser.
632
633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
634         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
635         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
636         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
637         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
638         (TestWebKitAPI::TEST):
639         * TestWebKitAPI/ios/set-timeout-function.html: Added.
640
641 2018-05-14  Valerie R Young  <valerie@bocoup.com>
642
643         test262/Runner.pm: small bugs in CLI and error codes
644         https://bugs.webkit.org/show_bug.cgi?id=185629
645
646         Reviewed by Michael Saboff.
647
648         Fix two commandline args with use '-f', correct
649         error code of failures.
650
651         * Scripts/test262/Runner.pm:
652         (processCLI):
653         (main):
654
655 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
656
657         Disable API tests that time out after pointer poisioning was disabled.
658         https://bugs.webkit.org/show_bug.cgi?id=185586
659
660         Unreviewed test gardening.
661
662         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
663         (TestWebKitAPI::TEST):
664         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
665         (TestWebKitAPI::TEST):
666         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
667         (TestWebKitAPI::TEST):
668         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
669         (TestWebKitAPI::TEST):
670
671 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
672
673         Test262-Runner: Fix RegExp for capturing tests metadata"
674         https://bugs.webkit.org/show_bug.cgi?id=185622
675
676         Reviewed by Michael Saboff.
677
678         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
679         both LF and CRLF forms.
680
681         The fix also allows the runner to capture the proper results from two specific files using CR and
682         CRLF line terminators. They are updated in the expectations file.
683         * Scripts/test262/Runner.pm:
684         (parseData):
685
686 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
687
688         NSEvent event trackers don't work from WebKitTestRunner
689         https://bugs.webkit.org/show_bug.cgi?id=185383
690         rdar://problem/40025045
691
692         Reviewed by Simon Fraser.
693
694         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
695         NSEvent swipe tracking is used for webkit swipe navigation.
696
697         * WebKitTestRunner/mac/EventSenderProxy.mm:
698         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
699
700 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
701
702         Test262 Runner should search for the Debug JSC by default
703         https://bugs.webkit.org/show_bug.cgi?id=185562
704
705         Reviewed by Michael Saboff.
706
707         The Test262 Runner is now searching for the Debug build of JSC by
708         default, not the Release build.
709
710         This fix allows a similar call from the previous runner, making
711         it compatible with the current build bot configuration parameters.
712
713         This patch also adds some minor improvements the verbose mode output.
714
715         * Scripts/test262/Runner.pm:
716         (processCLI):
717         (main):
718         (getBuildPath):
719         (processResult):
720
721 2018-05-11  Charles Vazac  <cvazac@gmail.com>
722
723         Runtime feature flag for Server-Timing
724         https://bugs.webkit.org/show_bug.cgi?id=184758
725
726         Reviewed by Youenn Fablet.
727
728         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
729         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
730
731 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
732
733         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
734         https://bugs.webkit.org/show_bug.cgi?id=185418
735
736         Reviewed by Alex Christensen.
737
738         All WK1 related code should be moved into MiniBrowser for the preparation
739         of Bug 184770.
740
741         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
742
743         * MiniBrowser/win/Common.cpp:
744         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
745         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
746         * MiniBrowser/win/Common.h: Added.
747         * MiniBrowser/win/MiniBrowser.cpp:
748         (MiniBrowser::init): Moved the initilization code from wWinMain.
749         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
750         * MiniBrowser/win/MiniBrowser.h:
751         (MiniBrowser::setCacheFolder): Changed to a private method.
752         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
753         * MiniBrowser/win/WinMain.cpp:
754         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
755
756 2018-05-11  Brady Eidson  <beidson@apple.com>
757
758         Make sure history navigations reuse the existing process when necessary.
759         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
760
761         Reviewed by Ryosuke Niwa.
762
763         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
764
765 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
766
767         [JSC][GLIB] Add introspectable alternatives to functions using vargars
768         https://bugs.webkit.org/show_bug.cgi?id=185508
769
770         Reviewed by Michael Catanzaro.
771
772         Add test cases for the new API.
773
774         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
775         (testJSCFunction):
776         (testJSCObject):
777
778 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
779
780         [Build Bot] Restore configuration options to the Test262 Runner
781
782         During the switch from the previous Test262 runner to the new one,
783         a call for an extra configurations options got removed.
784
785         This call is important to inform the script to find the debug or
786         release build of JSC. It's being restored in this patch.
787
788         https://bugs.webkit.org/show_bug.cgi?id=185513
789
790         Reviewed by Yusuke Suzuki.
791
792         * BuildSlaveSupport/build.webkit.org-config/steps.py:
793         (RunTest262Tests):
794
795 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
796
797         REGRESSION (r230998): Cannot stream API test output
798         https://bugs.webkit.org/show_bug.cgi?id=185090
799
800         Reviewed by Ryosuke Niwa.
801
802         Change run-api-tests so that the stdout and stderr of a test will be printed
803         before it's result. If -v is passed, the output of single test runs will be
804         streamed. 
805
806         * Scripts/webkitpy/api_tests/run_api_tests.py:
807         (run): Use print_timestamps flag.
808         (parse_args): Add timestamps option to print timestamps in the log.
809         * Scripts/webkitpy/api_tests/runner.py:
810         (Runner): Add running status.
811         (Runner.__init__): Add number of workers and a flag to detect if a newline
812         is needed at the beginning of a log line.
813         (Runner.run): Turn off most logging coming from server process since it is
814         not constructive for API tests.
815         (Runner.handle): Add new log message to stream stdout and stderr instead of
816         caching values until the test run finished.
817         (_Worker._run_single_test): Log stdout and stderr in real time.
818         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
819         the test.
820         (_Worker.post): Provide a post with explicitly enumerated argument names.
821         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
822         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
823         (MeteredStream.write): Allow for verbose logging without timestamps.
824         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
825         (RegularTest): Add print_timestamps flag.
826         (RegularTest.setUp):
827         (RegularTest.test_logging_not_included):
828         (VerboseTest.test_log_args):
829         (VerboseWithOutTimestamp):
830         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
831
832 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
833
834         build-webkit can erroneously warn about Xcode being too old
835         https://bugs.webkit.org/show_bug.cgi?id=185533
836
837         Reviewed by Dan Bernstein.
838
839         Don't assume the version number is always a single digit.
840
841         * Scripts/webkitdirs.pm:
842         (determineXcodeVersion):
843
844 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
845
846         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
847         https://bugs.webkit.org/show_bug.cgi?id=185528
848
849         Reviewed by Lucas Forschler.
850
851         * BuildSlaveSupport/build.webkit.org-config/factories.py:
852         (TestFactory.__init__):
853         * BuildSlaveSupport/build.webkit.org-config/steps.py:
854         (InstallWinCairoDependencies):
855
856 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
857
858         Fix some -Wstring-op-truncation warnings
859         https://bugs.webkit.org/show_bug.cgi?id=185496
860
861         Reviewed by Alex Christensen.
862
863         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
864         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
865         set the last bucket to NUL.
866
867         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
868         (TestWebKitAPI::testAtomicStringNumber):
869         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
870         (TestWebKitAPI::testStringNumberFixedPrecision):
871         (TestWebKitAPI::testStringNumberFixedWidth):
872         (TestWebKitAPI::testStringNumber):
873
874 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
875
876         [Win][MiniBrowser] Add a separate WndProc for the layered window
877         https://bugs.webkit.org/show_bug.cgi?id=185460
878
879         Reviewed by Brent Fulgham.
880
881         All WK1 related code should be moved into MiniBrowser for the
882         preparation of Bug 184770.
883
884         The layered window was using WndProc of the main window. The
885         layered window is specific only for WK1. the main window will be
886         shared among WK1 and WK2.
887
888         This change add a new WndProc for the layer window.
889
890         * MiniBrowser/win/Common.cpp:
891         (WndProc): Removed code for the layered windows.
892         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
893         * MiniBrowser/win/MiniBrowser.cpp:
894         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
895         (viewWndProc): New WndProc for the layered windows.
896         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
897         * MiniBrowser/win/MiniBrowser.h:
898         (MiniBrowser::hwnd):
899         * MiniBrowser/win/WinMain.cpp:
900         (wWinMain): Added m_viewWnd.
901
902 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
903
904         Support --verbose in run-javascriptcore-tests
905         https://bugs.webkit.org/show_bug.cgi?id=185492
906
907         Reviewed by Daniel Bates.
908
909         * Scripts/run-javascriptcore-tests:
910         (runJSCStressTests):
911
912 2018-05-10  Valerie R Young  <valerie@bocoup.com>
913
914         test262/Runner.pm: --failing-files uses results file not expectations
915         https://bugs.webkit.org/show_bug.cgi?id=185395
916
917         Reviewed by Michael Saboff.
918
919         --failing-files arg now uses results file to find failing tests
920         to rerun. It will look in the test262-results directory from whereever
921         the script is run, or a results.yaml file can be supplied via command
922         line argument.
923         --expectations arg added for suppling expectation file.
924
925         * Scripts/test262/Runner.pm:
926         (processCLI):
927         (main):
928         (loadImportFile):
929         (findAllFailing):
930
931 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
932
933         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
934         https://bugs.webkit.org/show_bug.cgi?id=185506
935
936         Reviewed by Philippe Normand.
937
938         Useful for testing and debugging.
939
940         * MiniBrowser/gtk/main.c:
941         (main):
942
943 2018-05-09  Chris Dumez  <cdumez@apple.com>
944
945         Unreviewed Windows build fix after r231622.
946
947         * DumpRenderTree/win/DumpRenderTree.cpp:
948         (enableExperimentalFeatures):
949
950 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
951
952         Update WebKit.WebsiteDataStoreCustomPaths after r231536
953         https://bugs.webkit.org/show_bug.cgi?id=185486
954         <rdar://problem/37214391>
955
956         Reviewed by Chris Dumez.
957
958         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
959
960         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
961         (TEST):
962
963 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
964
965         Test262-Runner: Improve the verbose output
966         https://bugs.webkit.org/show_bug.cgi?id=185491
967
968         Reviewed by Michael Saboff.
969
970         * Scripts/test262/Import.pm:
971         (transferFiles):
972         * Scripts/test262/Runner.pm:
973         (processResult):
974
975 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
976
977         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
978         https://bugs.webkit.org/show_bug.cgi?id=185488
979
980         Reviewed by Michael Saboff.
981
982         * Scripts/test262/Runner.pm:
983         (processCLI):
984         (getBuildPath):
985         (runTest):
986
987 2018-05-09  Richard Houle  <rhoule@apple.com>
988
989         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
990         https://bugs.webkit.org/show_bug.cgi?id=185260
991         <rdar://problem/39290394>
992
993         Reviewed by Tim Horton.
994
995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
996         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
997         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
998         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
999         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1000         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1001
1002 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
1003
1004         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1005         https://bugs.webkit.org/show_bug.cgi?id=185481
1006
1007         Reviewed by Philippe Normand.
1008
1009         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1010
1011         * Scripts/webkitpy/port/gtk.py:
1012         (GtkPort.setup_environ_for_server):
1013
1014 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1015
1016         Set build.webkit.org to use the new Test262-runner
1017         https://bugs.webkit.org/show_bug.cgi?id=184933
1018
1019         Reviewed by Aakash Jain.
1020
1021         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1022         (RunTest262Tests):
1023         (RunTest262Tests.countFailures):
1024         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1025
1026 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1027
1028         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
1029         https://bugs.webkit.org/show_bug.cgi?id=185461
1030
1031         Reviewed by Michael Catanzaro.
1032
1033         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
1034
1035         * gtk/jhbuild.modules:
1036
1037 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1038
1039         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
1040
1041         * wpe/manifest.txt.in: Distribute the NEWS.
1042
1043 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1044
1045         [WPE] Build cleanly with GCC 8 and ICU 60
1046         https://bugs.webkit.org/show_bug.cgi?id=185462
1047
1048         Reviewed by Carlos Alberto Lopez Perez.
1049
1050         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
1051         sure why this was never noticed until now or why the bots are OK.
1052         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1053         * gtk/patches/glib-cast-function-type.patch: Added.
1054         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1055         * wpe/patches/glib-cast-function-type.patch: Added.
1056
1057 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1058
1059         [JSC][GTK][JSCONLY] Use capstone disassembler
1060         https://bugs.webkit.org/show_bug.cgi?id=185283
1061
1062         Reviewed by Michael Catanzaro.
1063
1064         * gtk/manifest.txt.in:
1065         * wpe/manifest.txt.in:
1066
1067 2018-05-09  Antti Koivisto  <antti@apple.com>
1068
1069         Add OptionSet::operator& and operator bool
1070         https://bugs.webkit.org/show_bug.cgi?id=185306
1071
1072         Reviewed by Anders Carlsson.
1073
1074         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1075         (TestWebKitAPI::TEST):
1076
1077 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1078
1079         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
1080         https://bugs.webkit.org/show_bug.cgi?id=185340
1081
1082         Reviewed by Tim Horton.
1083
1084         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
1085         non-empty text in a contenteditable.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1088         (TestWebKitAPI::TEST):
1089
1090 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1091
1092         test262/Runner.pm: create results dir for results of test262 run
1093         https://bugs.webkit.org/show_bug.cgi?id=185392
1094
1095         Reviewed by Michael Saboff.
1096
1097         New directory test262-results created from where ever script is
1098         called.
1099
1100         * Scripts/test262/Runner.pm:
1101         (processCLI):
1102
1103 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1104
1105         test262/Runner.pm: lower number of processes per core
1106         https://bugs.webkit.org/show_bug.cgi?id=185426
1107
1108         Reviewed by Michael Saboff.
1109
1110         * Scripts/test262/Runner.pm:
1111         (getProcesses):
1112
1113 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
1114
1115         Test262-Runner: Add base Perl UnicodeData
1116         https://bugs.webkit.org/show_bug.cgi?id=185444
1117
1118         Reviewed by Michael Saboff.
1119
1120         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
1121         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
1122
1123 2018-05-08  Daniel Bates  <dabates@apple.com>
1124
1125         Add tests to ensure that the Strong Password appearance is removed on form reset
1126         https://bugs.webkit.org/show_bug.cgi?id=185440
1127
1128         Reviewed by Ryosuke Niwa.
1129
1130         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
1131         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
1132         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1133         (TEST):
1134
1135 2018-05-08  Daniel Bates  <dabates@apple.com>
1136
1137         Resign Strong Password appearance when text field value changes
1138         https://bugs.webkit.org/show_bug.cgi?id=185433
1139         <rdar://problem/39958508>
1140
1141         Reviewed by Ryosuke Niwa.
1142
1143         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
1144         when the field has the Strong Password button and its value changes.
1145
1146         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1147         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1148         (TEST):
1149
1150 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1151
1152         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
1153         https://bugs.webkit.org/show_bug.cgi?id=185365
1154
1155         Reviewed by Saam Barati.
1156         
1157         Make it possible to measure compile times.
1158         
1159         Rolling back in after fixing cloop builds.
1160
1161         * Scripts/run-jsc-benchmarks:
1162
1163 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1164
1165         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
1166         https://bugs.webkit.org/show_bug.cgi?id=185414
1167
1168         Reviewed by Tim Horton.
1169
1170         Adjust a test expectation to check that the resulting DOM contains an attachment element,
1171         anchor element, and another attachment element in that order. This ensures that the test
1172         still passes, even after the anchor element is followed by a line break.
1173
1174         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1175         (TestWebKitAPI::TEST):
1176
1177 2018-05-08  Commit Queue  <commit-queue@webkit.org>
1178
1179         Unreviewed, rolling out r231491.
1180         https://bugs.webkit.org/show_bug.cgi?id=185434
1181
1182         Setting the Created key on a cookie does not work yet, due a
1183         bug in CFNetwork (Requested by ggaren on #webkit).
1184
1185         Reverted changeset:
1186
1187         "[WKHTTPCookieStore getAllCookies] returns inconsistent
1188         creation time"
1189         https://bugs.webkit.org/show_bug.cgi?id=185041
1190         https://trac.webkit.org/changeset/231491
1191
1192 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1193
1194         test262/Runner.pm: move input files to JSTests/test262
1195         https://bugs.webkit.org/show_bug.cgi?id=185389
1196
1197         Reviewed by Michael Saboff.
1198
1199         * Scripts/test262/Runner.pm:
1200         (processCLI):
1201
1202 2018-05-08  Chris Dumez  <cdumez@apple.com>
1203
1204         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
1205
1206         * Scripts/webkitpy/performance_tests/perftest.py:
1207         (PerfTest):
1208
1209 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1210
1211         Unreviewed, rolling out r231468.
1212
1213         Broke the CLoop build
1214
1215         Reverted changeset:
1216
1217         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
1218         any abstract values"
1219         https://bugs.webkit.org/show_bug.cgi?id=185365
1220         https://trac.webkit.org/changeset/231468
1221
1222 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
1223
1224         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1225         https://bugs.webkit.org/show_bug.cgi?id=185041
1226         <rdar://problem/34684214>
1227
1228         Reviewed by Geoffrey Garen.
1229
1230         Add API test Coverage.
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1233         (TEST):
1234
1235 2018-05-08  Chris Dumez  <cdumez@apple.com>
1236
1237         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1238
1239         * Scripts/webkitpy/performance_tests/perftest.py:
1240         (PerfTest):
1241
1242 2018-05-08  Chris Dumez  <cdumez@apple.com>
1243
1244         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1245
1246         * Scripts/webkitpy/performance_tests/perftest.py:
1247         (PerfTest):
1248
1249 2018-05-07  Chris Dumez  <cdumez@apple.com>
1250
1251         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1252
1253         * Scripts/webkitpy/performance_tests/perftest.py:
1254         (PerfTest):
1255
1256 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1257
1258         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
1259         https://bugs.webkit.org/show_bug.cgi?id=185365
1260
1261         Reviewed by Saam Barati.
1262         
1263         Make it possible to measure compile times.
1264
1265         * Scripts/run-jsc-benchmarks:
1266
1267 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
1268
1269         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
1270         https://bugs.webkit.org/show_bug.cgi?id=185390
1271
1272         Reviewed by Michael Saboff.
1273
1274         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
1275
1276 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
1277
1278         Check for com.apple.datamigrator before declaring simulators booted
1279         https://bugs.webkit.org/show_bug.cgi?id=185315
1280         <rdar://problem/39986261>
1281
1282         Reviewed by David Kilzer.
1283
1284         * Scripts/webkitdirs.pm:
1285         (waitUntilProcessNotRunning): Wait until a process is not found.
1286         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
1287         a simulator booted.
1288         * Scripts/webkitpy/common/system/executive_mock.py:
1289         (MockExecutive2.__init__): Define _running_pids.
1290         * Scripts/webkitpy/xcode/simulated_device.py:
1291         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
1292         declaring that devices have been booted, increase the timeout since data migration will frequently
1293         take longer than 60 seconds, especially with multiple simulators booting.
1294         (SimulatedDeviceManager.swap): Ditto.
1295         (SimulatedDeviceManager):
1296         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
1297         processes running.
1298
1299 2018-05-07  Daniel Bates  <dabates@apple.com>
1300
1301         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
1302         https://bugs.webkit.org/show_bug.cgi?id=185054
1303         <rdar://problem/39773209>
1304
1305         Reviewed by Ryosuke Niwa.
1306
1307         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
1308
1309         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
1310         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
1311         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
1312         tests for the port.
1313
1314         * Scripts/webkitpy/port/mac.py:
1315         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
1316         have Apple Additions.
1317         * Scripts/webkitpy/port/mac_unittest.py:
1318         (MacTest.test_factory_with_future_version): Added.
1319         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
1320         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
1321         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
1322         is absent.
1323
1324 2018-05-07  Brian Burg  <bburg@apple.com>
1325
1326         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1327         https://bugs.webkit.org/show_bug.cgi?id=184861
1328         <rdar://problem/39153768>
1329
1330         Reviewed by Timothy Hatcher.
1331
1332         Add a new test that checks whether a new process is used for navigation when
1333         an Inspector is shown. Also check that the behavior reverts to normal after
1334         the Inspector has been closed.
1335
1336         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1337
1338 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1339
1340         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
1341         https://bugs.webkit.org/show_bug.cgi?id=185289
1342         <rdar://problem/35756912>
1343
1344         Reviewed by Tim Horton and Darin Adler.
1345
1346         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
1347         sessions.
1348
1349         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1350         (TestWebKitAPI::TEST):
1351
1352 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1353
1354         Deprecate legacy WebView and friends
1355         https://bugs.webkit.org/show_bug.cgi?id=185279
1356         rdar://problem/33268700
1357
1358         Reviewed by Tim Horton.
1359
1360         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
1361         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
1362
1363 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1364
1365         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
1366         https://bugs.webkit.org/show_bug.cgi?id=185314
1367
1368         Reviewed by Michael Saboff.
1369
1370         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
1371
1372 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
1373
1374         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
1375         https://bugs.webkit.org/show_bug.cgi?id=184196
1376         <rdar://problem/39054481>
1377
1378         Reviewed by Tim Horton.
1379
1380         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
1381         earlier than 11.3. Also re-enables these tests.
1382
1383         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1384         (TestWebKitAPI::TEST):
1385         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
1386         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
1387
1388 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
1389
1390         Text shaping in the simple path is flipped in the y direction
1391         https://bugs.webkit.org/show_bug.cgi?id=185062
1392         <rdar://problem/39778678>
1393
1394         Reviewed by Simon Fraser.
1395
1396         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
1397
1398         * Scripts/webkitpy/common/config/contributors.json:
1399
1400 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1401
1402         Test262-Runner: place the processCLI inside the main call
1403         https://bugs.webkit.org/show_bug.cgi?id=185304
1404
1405         Reviewed by Michael Saboff.
1406
1407         * Scripts/test262/Runner.pm:
1408         (main):
1409
1410 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1411
1412         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
1413         https://bugs.webkit.org/show_bug.cgi?id=174730
1414
1415         Reviewed by Michael Catanzaro.
1416
1417         Update unit tests to check that User-Agent header is included in HTTP download requests.
1418
1419         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1420         (testDownloadRemoteFile):
1421         (testWebViewDownloadURI):
1422         (testPolicyResponseDownload):
1423         (testPolicyResponseDownloadCancel):
1424         (testDownloadMIMEType):
1425         (testContextMenuDownloadActions):
1426
1427 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
1428
1429         [WinCairo] Test archive must use Python zipfile, just like build product.
1430         https://bugs.webkit.org/show_bug.cgi?id=185265
1431
1432         Reviewed by Per Arne Vollan.
1433
1434         * BuildSlaveSupport/test-result-archive:
1435         (archive_test_results):
1436         Copy over Win32-oriented archiving logic from built-product-archive.
1437
1438 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
1439
1440         cleanup modules usage for the Test262-Runner
1441         https://bugs.webkit.org/show_bug.cgi?id=185263
1442
1443         Reviewed by Michael Saboff.
1444
1445         * Scripts/test262-runner:
1446         * Scripts/test262/Runner.pm:
1447         (processCLI):
1448
1449 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1450
1451         test262/Runner.pm: minor fixes
1452         https://bugs.webkit.org/show_bug.cgi?id=185250
1453
1454         Reviewed by Michael Saboff.
1455
1456         Add comments, change output and fix bug: unintended interpolation
1457         of filename when running jsc.
1458
1459         * Scripts/test262/Runner.pm:
1460         (processCLI):
1461         (main):
1462         (runTest):
1463
1464 2018-05-03  Chris Dumez  <cdumez@apple.com>
1465
1466         Load hangs if the WebProcess fails to launch
1467         https://bugs.webkit.org/show_bug.cgi?id=185225
1468         <rdar://problem/38249058>
1469
1470         Reviewed by Geoff Garen.
1471
1472         Add API test coverage.
1473
1474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1475         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
1476         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
1477         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
1478         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1479         (TEST):
1480
1481 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
1482
1483         [WinCairo] Add JSC test bots
1484         https://bugs.webkit.org/show_bug.cgi?id=185234
1485
1486         Reviewed by Per Arne Vollan.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/config.json:
1489         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1490         (RunJavaScriptCoreTests.start):
1491
1492 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1493
1494         WebKit should send fake macOS user agent to docs.google.com
1495         https://bugs.webkit.org/show_bug.cgi?id=185165
1496
1497         Reviewed by Carlos Garcia Campos.
1498
1499         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1500         (TestWebKitAPI::TEST):
1501
1502 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1503
1504         test262/Runner.pm: performance improvements
1505         https://bugs.webkit.org/show_bug.cgi?id=185202
1506
1507         Reviewed by Michael Saboff.
1508
1509         Batch the tests by the number of processes, and give each process
1510         a file to save results to to avoid threading. Do not parallelize
1511         when running small sets of tests.
1512
1513         * Scripts/test262/Runner.pm:
1514         (processCLI):
1515         (main):
1516         (processFile):
1517         (processResult):
1518
1519 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
1520
1521         Unreviewed, rolling out r231253.
1522
1523         The API test added with this change is crashing on the bots.
1524
1525         Reverted changeset:
1526
1527         "Web Inspector: opt out of process swap on navigation if a Web
1528         Inspector frontend is connected"
1529         https://bugs.webkit.org/show_bug.cgi?id=184861
1530         https://trac.webkit.org/changeset/231253
1531
1532 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1533
1534         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
1535         https://bugs.webkit.org/show_bug.cgi?id=183348
1536
1537         Reviewed by Michael Catanzaro.
1538
1539         Add a test case to reproduce the crash.
1540
1541         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1542         (testWebViewCloseQuickly):
1543         (beforeAll):
1544
1545 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
1546
1547         Can't copy and paste URLs that have no title into Mail (macOS)
1548         https://bugs.webkit.org/show_bug.cgi?id=185205
1549         <rdar://problem/36352406>
1550
1551         Reviewed by Tim Horton.
1552
1553         Added test to verify behavior when copying and pasting a URL without a title.
1554
1555         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1556         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1557         (TestWebKitAPI::TEST):
1558
1559 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1560
1561         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
1562         https://bugs.webkit.org/show_bug.cgi?id=184699
1563
1564         Unreviewed follow-up fix after r231230.
1565
1566         * Scripts/generate-jsc-bundle:
1567         (generate_wrapper_script): Quote the arguments passed to jsc.
1568
1569 2018-05-02  Brian Burg  <bburg@apple.com>
1570
1571         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1572         https://bugs.webkit.org/show_bug.cgi?id=184861
1573         <rdar://problem/39153768>
1574
1575         Reviewed by Ryosuke Niwa.
1576
1577         Add a new test that checks whether a new process is used for navigation when
1578         an Inspector is shown. Also check that the behavior reverts to normal after
1579         the Inspector has been closed.
1580
1581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1582
1583 2018-05-02  Valerie R Young  <valerie@bocoup.com>
1584
1585         test262/Runner.pm: save summary to file
1586         https://bugs.webkit.org/show_bug.cgi?id=185200
1587
1588         Reviewed by Michael Saboff.
1589
1590         * Scripts/test262/Runner.pm:
1591         (processCLI):
1592         (main):
1593         (summarizeResults):
1594
1595 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1596
1597         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
1598         https://bugs.webkit.org/show_bug.cgi?id=184699
1599
1600         Reviewed by Gustavo Noronha Silva.
1601
1602         This adds a new step for the GTK 64-bit release build bot and the
1603         GTK 32-bit release build&test bot.
1604
1605         This step will be run as one of the lasts ones (after the product
1606         is built) and will execute the script generate-jsc-bundle.
1607         This script will take care of creating a JSC bundle and uploading
1608         it to a server defined on a configuration file that has to be
1609         deployed on the bots with the required server data and credentials
1610         for this upload.
1611
1612         In this case, the built products should then be accessible at
1613         <https://webkitgtk.org/jsc-built-products>. But the implementation
1614         is not tied to any specific server. All the details about where
1615         to upload the file is done in configuration file that is kept
1616         private on each bot outside of the WebKit source tree.
1617
1618         The script also supports generating a JSC bundle locally and not
1619         uploading it anywhere. This is the default mode of running.
1620         The remote upload will only be activated if a --remote-config-file
1621         parameter is passed (which is done from the buildbot config)
1622
1623         * BuildSlaveSupport/build.webkit.org-config/config.json:
1624         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1625         (BuildFactory):
1626         (BuildFactory.__init__):
1627         (TestFactory):
1628         (TestFactory.__init__):
1629         (BuildAndGenerateJSCBundleFactory):
1630         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
1631         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1632         (GenerateJSCBundle):
1633         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1634         * Scripts/generate-jsc-bundle: Added.
1635         (ldd_get_libs_and_interpreter):
1636         (generate_readme):
1637         (generate_wrapper_script):
1638         (copy_and_remove_rpath):
1639         (createJSCBundle):
1640         (sha256sum):
1641         (uploadJSCBundle):
1642         (main):
1643
1644 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1645
1646         PSON: Make WebKitTestRunner work with process swap on navigation turned on
1647         https://bugs.webkit.org/show_bug.cgi?id=185111
1648
1649         Reviewed by Chris Dumez.
1650
1651         Add the basic support for running layout tests with process-swap-on-navigation turned on.
1652
1653         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
1654         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
1655
1656         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
1657         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
1658         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
1659         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
1660
1661         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1662         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
1663         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
1664         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
1665         beginTesting with BegingTestingMode::Resume when this boolean is set.
1666         (WTR::InjectedBundle::didReceiveMessageToPage):
1667         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
1668         bundle after a process swap on navigation.
1669         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1670         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1671         (WTR::InjectedBundlePage::dump):
1672         (WTR::InjectedBundlePage::frameDidChangeLocation):
1673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1674         (WTR::TestRunner::TestRunner):
1675         (WTR::TestRunner::shouldDumpPixels const): Added.
1676         (WTR::TestRunner::setDumpPixels): Added.
1677         (WTR::TestRunner::dumpAsText):
1678         (WTR::TestRunner::whatToDump const): Added.
1679         (WTR::TestRunner::setWhatToDump): Added.
1680         (WTR::TestRunner::waitUntilDone):
1681         (WTR::TestRunner::setWaitUntilDone): Added.
1682         (WTR::TestRunner::shouldWaitUntilDone): Added.
1683         (WTR::TestRunner::notifyDone):
1684         (WTR::TestRunner::forceImmediateCompletion):
1685         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
1686         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
1687         (WTR::TestRunner::setAudioResult):
1688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1689         (WTR::TestRunner::dumpChildFramesAsText):
1690         (WTR::TestRunner::dumpDOMAsWebArchive):
1691         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
1692         (WTR::TestRunner::whatToDump const): Moved to cpp.
1693         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
1694         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
1695         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
1696         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
1697         * WebKitTestRunner/TestInvocation.cpp:
1698         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
1699         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
1700         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
1701         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
1702         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
1703         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
1704         started as a result of a process swap on navigation (m_startedTesting is true).
1705         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
1706         support initializing the injected bundle in a process swapped after navigation and set/get messages for
1707         the states which must persist across process swaps within a test.
1708         * WebKitTestRunner/TestInvocation.h:
1709         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1710         * Tools/WebKitTestRunner/WhatToDump.h:
1711         (WTR::WhatToDump): Added.
1712
1713 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
1714
1715         Auto save the results for Test262
1716         https://bugs.webkit.org/show_bug.cgi?id=184926
1717
1718         Reviewed by Michael Saboff.
1719
1720         * Scripts/test262/Runner.pm:
1721         (processCLI):
1722         (main):
1723         (parseError):
1724         (processResult):
1725         (summarizeResults):
1726         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
1727
1728 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
1729
1730         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
1731         https://bugs.webkit.org/show_bug.cgi?id=185164
1732
1733         Reviewed by David Kilzer.
1734
1735         * Scripts/webkitpy/common/system/executive.py:
1736         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
1737         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
1738
1739 2018-05-01  Chris Dumez  <cdumez@apple.com>
1740
1741         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
1742         https://bugs.webkit.org/show_bug.cgi?id=184918
1743         <rdar://problem/39705516>
1744
1745         Reviewed by Wenson Hsieh.
1746
1747         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
1748         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
1749         asynchronously because we ask the client if it is OK to do the load and the policy
1750         delegates are asynchronous nowadays.
1751
1752         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1753         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1754         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1755         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1756         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
1757         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
1758         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
1759
1760 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
1761
1762         [WinCairo] Align buildbot test stages with AppleWin.
1763         https://bugs.webkit.org/show_bug.cgi?id=185094
1764
1765         Reviewed by Brent Fulgham.
1766
1767         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1768         (TestFactory.__init__):
1769         Do run API tests, don't run dashboard tests.
1770
1771         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1772         (RunUnitTests):
1773         Call run-api-tests with Python, not Perl (bugfix for r230998).
1774
1775         * Scripts/webkitpy/port/win.py:
1776         (WinPort.environment_for_api_tests):
1777         Retrieve necessary Windows environment variables.
1778
1779 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1780
1781         [MediaStream] remove WK1 support
1782         https://bugs.webkit.org/show_bug.cgi?id=185136
1783
1784         Reviewed by Youenn Fablet.
1785
1786         * DumpRenderTree/mac/UIDelegate.mm:
1787         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
1788
1789 2018-05-01  Chris Dumez  <cdumez@apple.com>
1790
1791         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
1792         https://bugs.webkit.org/show_bug.cgi?id=185157
1793
1794         Reviewed by Geoffrey Garen.
1795
1796         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
1797         common configuration and should therefore be the configuration we test by default.
1798
1799         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1800         (WTR::InjectedBundlePage::decidePolicyForResponse):
1801
1802 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1803
1804         WebAssembly: add support for stream APIs - JavaScript API
1805         https://bugs.webkit.org/show_bug.cgi?id=183442
1806
1807         Reviewed by Yusuke Suzuki and JF Bastien.
1808
1809         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1810
1811 2018-04-30  Mark Lam  <mark.lam@apple.com>
1812
1813         Apply PtrTags to the MetaAllocator and friends.
1814         https://bugs.webkit.org/show_bug.cgi?id=185110
1815         <rdar://problem/39533895>
1816
1817         Reviewed by Saam Barati.
1818
1819         Update the test to match MetaAllocator changes in WTF.
1820
1821         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1822         (TestWebKitAPI::TEST_F):
1823         (WTF::tagForPtr):
1824         (WTF::ptrTagName):
1825
1826 2018-04-30  Alex Christensen  <achristensen@webkit.org>
1827
1828         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
1829         https://bugs.webkit.org/show_bug.cgi?id=180955
1830
1831         Reviewed by Andy Estes.
1832
1833         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1834         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
1835         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
1836
1837 2018-04-30  JF Bastien  <jfbastien@apple.com>
1838
1839         Use some C++17 features
1840         https://bugs.webkit.org/show_bug.cgi?id=185135
1841
1842         Reviewed by Alex Christensen.
1843
1844         * DumpRenderTree/PlatformMac.cmake:
1845         * gtk/ycm_extra_conf.py:
1846         (FlagsForFile):
1847
1848 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1849
1850         Use WordLock instead of std::mutex for Threading
1851         https://bugs.webkit.org/show_bug.cgi?id=185121
1852
1853         Reviewed by Geoffrey Garen.
1854
1855         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1856         (TEST):
1857
1858 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1859
1860         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
1861         https://bugs.webkit.org/show_bug.cgi?id=185103
1862
1863         Reviewed by Carlos Garcia Campos.
1864
1865         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1866         (TestWebKitAPI::TEST):
1867
1868 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
1869
1870         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
1871         https://bugs.webkit.org/show_bug.cgi?id=185052
1872
1873         Reviewed by Geoffrey Garen.
1874
1875         Modified API test to provide correct test cases for HTTPOnly flag.
1876
1877         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1878         (TEST):
1879
1880 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
1881
1882         Token misspelled "tocken" in error message string
1883         https://bugs.webkit.org/show_bug.cgi?id=185030
1884
1885         Reviewed by Saam Barati.
1886
1887         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
1888
1889 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
1890
1891         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
1892         https://bugs.webkit.org/show_bug.cgi?id=185049
1893
1894         Reviewed by Keith Miller.
1895
1896         * Scripts/run-javascriptcore-tests:
1897         (runJSCStressTests):
1898         * Scripts/run-jsc-stress-tests:
1899
1900 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1901
1902         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
1903         https://bugs.webkit.org/show_bug.cgi?id=185066
1904
1905         Reviewed by Youenn Fablet.
1906
1907         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
1908         WebKit should not swap WebContent process in this case.
1909
1910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1911         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1912         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1913
1914 2018-04-27  Nan Wang  <n_wang@apple.com>
1915
1916         AX: Accessibility needs to know which part of the content view is visible on iOS
1917         https://bugs.webkit.org/show_bug.cgi?id=185085
1918         <rdar://problem/39801363>
1919
1920         Reviewed by Chris Fleizach.
1921
1922         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1923         (WTR::AccessibilityUIElement::stringAttributeValue):
1924
1925 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1926
1927         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
1928         https://bugs.webkit.org/show_bug.cgi?id=185050
1929         <rdar://problem/39624038>
1930
1931         Reviewed by Tim Horton.
1932
1933         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
1934         tested by the layout test added in this patch.
1935
1936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1937         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
1938
1939 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1940
1941         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
1942         https://bugs.webkit.org/show_bug.cgi?id=185061
1943
1944         Reviewed by Aakash Jain.
1945
1946         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1947         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
1948         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
1949
1950 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1951
1952         Add release bots for WinCairo.
1953         https://bugs.webkit.org/show_bug.cgi?id=185042
1954
1955         Reviewed by Lucas Forschler.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/config.json:
1958         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
1959
1960 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
1961
1962         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
1963         https://bugs.webkit.org/show_bug.cgi?id=184938
1964         <rdar://problem/34737395>
1965
1966         Reviewed by Geoffrey Garen.
1967
1968         Add API test coverage.
1969
1970         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1971         (TEST):
1972
1973 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1974
1975         WinCairo test bots should run JSC tests with options for Windows command prompt.
1976         https://bugs.webkit.org/show_bug.cgi?id=185019
1977
1978         Reviewed by Per Arne Vollan.
1979
1980         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1981         (RunJavaScriptCoreTests.start):
1982
1983 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1984
1985         WinCairo WKL Debug Test bot is not using DRT.
1986         https://bugs.webkit.org/show_bug.cgi?id=185009
1987
1988         Reviewed by Per Arne Vollan.
1989
1990         * BuildSlaveSupport/build.webkit.org-config/config.json:
1991
1992 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1993
1994         Disable content filtering in minimal simulator mode
1995         https://bugs.webkit.org/show_bug.cgi?id=185027
1996         <rdar://problem/39736091>
1997
1998         Reviewed by Jer Noble.
1999
2000         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2001
2002 2018-04-26  Brady Eidson  <beidson@apple.com>
2003
2004         Add a setting for keeping around all processes and always reusing them per-origin.
2005         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
2006
2007         Reviewed by Andy Estes.
2008
2009         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2010
2011 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2012
2013         [INTL] Implement Intl.PluralRules
2014         https://bugs.webkit.org/show_bug.cgi?id=184312
2015
2016         Reviewed by JF Bastien.
2017
2018         Added Intl.PluralRules feature flag.
2019
2020         * Scripts/webkitperl/FeatureList.pm:
2021         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2022
2023 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2024
2025         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
2026         https://bugs.webkit.org/show_bug.cgi?id=184643
2027
2028         Reviewed by Žan Doberšek.
2029
2030         Add missing INCLUDE_DIRS in many places.
2031
2032         Adapt to single-header WPE includes.
2033
2034         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
2035
2036         * TestWebKitAPI/PlatformWPE.cmake:
2037         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2038         (testWebViewWebBackend):
2039         * TestWebKitAPI/glib/PlatformWPE.cmake:
2040         * WebKitTestRunner/EventSenderProxy.h:
2041         * WebKitTestRunner/PlatformWPE.cmake:
2042         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2043         * wpe/HeadlessViewBackend/CMakeLists.txt:
2044         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
2045         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
2046         * wpe/jhbuild.modules:
2047
2048 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
2049
2050         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
2051         https://bugs.webkit.org/show_bug.cgi?id=184982
2052
2053         Rubber-stamped by Aakash Jain.
2054
2055         Correctly count the number of API test failures.
2056
2057         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2058         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
2059         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2060         * Scripts/webkitpy/api_tests/manager.py:
2061         (Manager.run): Disabled tests are not run.
2062
2063 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2064
2065         Remove access to keychain from the WebContent process
2066         https://bugs.webkit.org/show_bug.cgi?id=184428
2067         <rdar://problem/13150903>
2068
2069         Reviewed by Brent Fulgham.
2070
2071         This patch does the followings:
2072         1. Added an API test for this patch.
2073         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
2074
2075         * DumpRenderTree/mac/UIDelegate.mm:
2076         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
2077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2078         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
2079         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
2080         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
2081         (TestWebKitAPI::TEST_F):
2082         * WebKitTestRunner/TestController.cpp:
2083         (WTR::copySignedPublicKeyAndChallengeString):
2084         (WTR::TestController::createOtherPage):
2085         (WTR::TestController::createWebViewWithOptions):
2086
2087 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2088
2089         [Extra zoom mode] The search field on www.bing.com is missing label text
2090         https://bugs.webkit.org/show_bug.cgi?id=184975
2091         <rdar://problem/39723081>
2092
2093         Reviewed by Tim Horton.
2094
2095         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
2096         focused element in extra zoom mode.
2097
2098         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2099         (WTR::UIScriptController::formInputLabel const):
2100         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2101         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2102         (WTR::UIScriptController::formInputLabel const):
2103         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2104         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2105         (WTR::UIScriptController::formInputLabel const):
2106
2107 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2108
2109         [WPE] Should load injected bundle from builddir in developer builds
2110         https://bugs.webkit.org/show_bug.cgi?id=184983
2111
2112         Reviewed by Carlos Alberto Lopez Perez.
2113
2114         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
2115
2116         * Scripts/run-minibrowser:
2117
2118 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2119
2120         [WPE] libgstggtk.so broken in jhbuild environment
2121         https://bugs.webkit.org/show_bug.cgi?id=184984
2122
2123         Reviewed by Carlos Alberto Lopez Perez.
2124
2125         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
2126         gst-plugins-good.
2127
2128         * wpe/jhbuild.modules:
2129
2130 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2131
2132         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
2133         https://bugs.webkit.org/show_bug.cgi?id=184962
2134
2135         Reviewed by Youenn Fablet.
2136
2137         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2140         (ProcessSwap.SameOriginBlobNavigation): Added.
2141         (ProcessSwap.CrossOriginBlobNavigation): Added.
2142         (ProcessSwap.NavigateToAboutBlank): Added.
2143         (ProcessSwap.NavigateToDataURL): Added.
2144
2145 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2146
2147         [WPE] Remove deprecated functions and properties from the API
2148         https://bugs.webkit.org/show_bug.cgi?id=179295
2149
2150         Reviewed by Žan Doberšek.
2151
2152         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2153         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
2154         to rewrite LoadTrackingTest to not require the web view at construction time.
2155         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2156         (testWebKitSettings): Don't test private browsing setting, which is gone.
2157         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
2158
2159 2018-04-25  Andy Estes  <aestes@apple.com>
2160
2161         [Mac] Number of drop items is always 0 when performing a DHTML drag
2162         https://bugs.webkit.org/show_bug.cgi?id=184943
2163
2164         Reviewed by Ryosuke Niwa.
2165
2166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2167         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2168         (-[DragInfo numberOfValidItemsForDrop]):
2169         (-[DragInfo setNumberOfValidItemsForDrop:]):
2170         (TestWebKitAPI::TEST):
2171         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
2172
2173 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
2174
2175         API test harness should be Python
2176         https://bugs.webkit.org/show_bug.cgi?id=181043
2177         <rdar://problem/36164410>
2178
2179         Reviewed by David Kilzer.
2180
2181         Run API tests from a Python script rather than Perl. The Python API tests have
2182         the same structure as the layout tests.
2183
2184         * Scripts/run-api-tests: Changed from Perl to Python.
2185         * Scripts/webkitpy/api_tests: Added.
2186         * Scripts/webkitpy/api_tests/__init__.py: Added.
2187         * Scripts/webkitpy/api_tests/manager.py: Added.
2188         (Manager):
2189         (Manager.__init__):
2190         (Manager._test_list_from_output): Construct a list of tests from the output of
2191         TestWTF and TestWebKitAPI.
2192         (Manager._find_test_subset): Given a list of all possible tests and command line
2193         arguments, return a list of tests which match the provided arguments.
2194         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
2195         to determine which tests will be run.
2196         (Manager._print_test_result): Formatted print of a test with it's output.
2197         (Manager._print_tests_result_with_status): Print all tests and output for tests
2198         which ran with a specified exit status.
2199         (Manager.run): Collect all tests, run them and then print results from the run.
2200         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
2201         (main): Parse arguments, construct a port, early exit for illegal ports and
2202         then run tests.
2203         (run): Setup logging and printing before using the Manager to run tests.
2204         (parse_args): Use argparse to define all options used by run-api-tests.
2205         * Scripts/webkitpy/api_tests/runner.py: Added.
2206         (Runner):
2207         (Runner.__init__):
2208         (Runner._shard_tests): Split tests so that each suite runs together.
2209         (Runner.command_for_port): Run a command on the device specified by the given
2210         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
2211         this function would be entirely replaced by the server_process factory owned
2212         by the port object.
2213         (Runner.run): Run all shards in the message_pool.
2214         (Runner.handle): Handle reports from child processes.
2215         (Runner.result_map_by_status): Return a mapping of tests to output for tests
2216         which exit with a specific status.
2217         (_Worker):
2218         (_Worker.__init__):
2219         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
2220         (_Worker._run_single_test): Runs a single test in a single child process.
2221         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
2222         child process. If this technique fails, the remaining tests are run singly.
2223         (_Worker.handle): Run the specified shard.
2224         * Scripts/webkitpy/port/base.py:
2225         (Port):
2226         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
2227         (Port.environment_for_api_tests): Return the environment needed to run
2228         the TestWebKitAPI binary.
2229         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
2230         used when running API tests.
2231         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
2232         * Scripts/webkitpy/port/mac.py:
2233         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
2234         * Scripts/webkitpy/port/server_process.py: 
2235         (ServerProcess.pop_all_buffered_stdout):
2236
2237 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2238
2239         Incorrect number of WebDriver test failures shown in the bots
2240         https://bugs.webkit.org/show_bug.cgi?id=184959
2241
2242         Reviewed by Michael Catanzaro.
2243
2244         The regular expression we are using to get the number of failures from the log is matching a particular test
2245         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
2246         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
2247
2248         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2249         (RunWebDriverTests.commandComplete):
2250
2251 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2252
2253         [GTK] Implement MouseEvent.buttons
2254         https://bugs.webkit.org/show_bug.cgi?id=184913
2255
2256         Reviewed by Žan Doberšek.
2257
2258         Include the mouse buttons state in WTR synthesized events.
2259
2260         * WebKitTestRunner/EventSenderProxy.h:
2261         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2262         (WTR::EventSenderProxy::EventSenderProxy):
2263         (WTR::EventSenderProxy::createMouseButtonEvent):
2264         (WTR::EventSenderProxy::mouseDown):
2265         (WTR::EventSenderProxy::mouseUp):
2266         (WTR::EventSenderProxy::mouseMoveTo):
2267
2268 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
2269
2270         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
2271         https://bugs.webkit.org/show_bug.cgi?id=184954
2272
2273         Reviewed by Michael Catanzaro.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/config.json:
2276
2277 2018-04-24  Saam Barati  <sbarati@apple.com>
2278
2279         Keep around a pre-warmed process when doing process swap on navigation
2280         https://bugs.webkit.org/show_bug.cgi?id=184765
2281         <rdar://problem/39685099>
2282
2283         Reviewed by Ryosuke Niwa and Brady Eidson.
2284
2285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2286
2287 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
2288
2289         [build.webkit.org] unit-tests fail when passwords.json is missing
2290         https://bugs.webkit.org/show_bug.cgi?id=180390
2291
2292         Reviewed by Carlos Alberto Lopez Perez.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2295         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
2296         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2297         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
2298         (BuildBotConfigLoader._mock_open): Deleted.
2299         (BuildBotConfigLoader.load_config): Deleted.
2300
2301 2018-04-24  John Wilander  <wilander@apple.com>
2302
2303         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
2304         https://bugs.webkit.org/show_bug.cgi?id=184560
2305         <rdar://problem/38901344>
2306
2307         Reviewed by Youenn Fablet and Daniel Bates.
2308
2309         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
2310         We consume the From-Origin response header and only load the resource if:
2311         - The header is non-existent, empty, or invalid.
2312         - The header specifies 'same' and the resource's origin matches the originating
2313           document's origin and the origins up the frame tree.
2314         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
2315           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
2316
2317         This feature is experimental and off by default.
2318
2319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2320         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
2321         (TestWebKitAPI::TEST):
2322             Tests for From-Origin header parsing.
2323
2324 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2325
2326         Unreviewed. Update W3C WebDriver imported tests.
2327
2328         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2329         (WebDriverW3CExecutor.__init__):
2330
2331 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
2332
2333         [WPE] Remove libgbm dependency
2334         https://bugs.webkit.org/show_bug.cgi?id=184906
2335
2336         Reviewed by Carlos Garcia Campos.
2337
2338         Stop searching for libgbm, using its compiler flags for the
2339         HeadlessViewBackend compilation and linking against the .so object.
2340         This is not necessary anymore after r230562 switched to a different
2341         backend implementation for testing.
2342
2343         * wpe/HeadlessViewBackend/CMakeLists.txt:
2344         * wpe/install-dependencies:
2345
2346 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2347
2348         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
2349         https://bugs.webkit.org/show_bug.cgi?id=184816
2350
2351         Reviewed by Michael Catanzaro.
2352
2353         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
2354         timeout.
2355
2356         * TestWebKitAPI/glib/TestExpectations.json:
2357         * glib/api_test_runner.py:
2358         (TestRunner._run_test_glib.is_slow_test):
2359         (TestRunner._run_test_glib):
2360         * glib/glib_test_runner.py:
2361         (GLibTestRunner.__init__):
2362         (GLibTestRunner._stop_timeout):
2363         (GLibTestRunner._subtest_start):
2364         (GLibTestRunner._subtest_end):
2365
2366 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2367
2368         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
2369         https://bugs.webkit.org/show_bug.cgi?id=184901
2370         <rdar://problem/39664797>
2371
2372         Reviewed by Tim Horton.
2373
2374         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
2375         interacting with the UI. See WebKit ChangeLogs for more detail.
2376
2377         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2378         (WTR::UIScriptController::setTimePickerValue):
2379         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2380         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2381         (WTR::UIScriptController::setTimePickerValue):
2382         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2383         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2384         (WTR::UIScriptController::setTimePickerValue):
2385
2386 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2387
2388         [LayoutFormattingContext] Initial commit.
2389         https://bugs.webkit.org/show_bug.cgi?id=184896
2390
2391         Reviewed by Antti Koivisto.
2392
2393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2394
2395 2018-04-23  Chris Dumez  <cdumez@apple.com>
2396
2397         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
2398         https://bugs.webkit.org/show_bug.cgi?id=184801
2399
2400         Reviewed by Geoffrey Garen.
2401
2402         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
2403         This is a more common configuration and therefore should be the default testing configuration.
2404
2405         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2406         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2407         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
2408         is now asked for the policy decision.
2409
2410 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
2411
2412         [GTK][WPE] Add Debug bots (build and tests) for WPE
2413         https://bugs.webkit.org/show_bug.cgi?id=184887
2414
2415         Reviewed by Carlos Alberto Lopez Perez.
2416
2417         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
2418         wpe-linux-bot-4
2419
2420         Both bots have already the credentials ready to authenticated against
2421         build.webkit.org. They provides the bots for the "debug" configuration over
2422         the "WPE" platform and building for the "x86_64" architecture:
2423         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
2424
2425         * BuildSlaveSupport/build.webkit.org-config/config.json:
2426         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2427
2428 2018-04-23  Chris Dumez  <cdumez@apple.com>
2429
2430         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
2431         https://bugs.webkit.org/show_bug.cgi?id=184848
2432         <rdar://problem/39145306>
2433
2434         Reviewed by Brady Eidson.
2435
2436         Add API test coverage.
2437
2438         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2439         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2440         (TEST):
2441
2442 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2443
2444         [GTK][WPE] TestSSL fails due to additional TLS errors returned
2445         https://bugs.webkit.org/show_bug.cgi?id=184860
2446
2447         Reviewed by Carlos Garcia Campos.
2448
2449         Add script and config file for regenerating the test certificate.
2450         Regenerate it. TestSSL no longer fails on my machine.
2451
2452         I do see a ton of network process crashes and JavaScript errors, none of
2453         which prevent the test from passing, but this commit only claims to fix
2454         the certificate validation portion of the test.
2455
2456         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
2457         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
2458         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
2459
2460 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2461
2462         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
2463         https://bugs.webkit.org/show_bug.cgi?id=184815
2464
2465         Reviewed by Michael Catanzaro.
2466
2467         This is because in the test we are calling both join and detach. We should only call join.
2468
2469         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2470         (testsJSCVirtualMachine):
2471
2472 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         [GLIB] Test /jsc/prototypes crashes in debug
2475         https://bugs.webkit.org/show_bug.cgi?id=184814
2476
2477         Reviewed by Michael Catanzaro.
2478
2479         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
2480
2481         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2482         (barCreate):
2483         (barFree):
2484
2485 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2486
2487         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
2488         https://bugs.webkit.org/show_bug.cgi?id=184804
2489
2490         Reviewed by Carlos Garcia Campos.
2491
2492         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2493         (WebSocketTest::WebSocketTest):
2494         (WebSocketTest::~WebSocketTest):
2495         (WebSocketTest::serverWebSocketCallback):
2496         (WebSocketTest::webSocketTestResultCallback):
2497         (WebSocketTest::connectToServerAndWaitForEvents):
2498         (testWebSocketTLSErrors):
2499         (beforeAll):
2500
2501 2018-04-20  Chris Dumez  <cdumez@apple.com>
2502
2503         Unreviewed, update 2 more API tests after r230876.
2504
2505         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2506         (TEST):
2507         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2508         (TestWebKitAPI::TEST):
2509
2510 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2511
2512         Adjust geolocation feature flag
2513         https://bugs.webkit.org/show_bug.cgi?id=184856
2514
2515         Reviewed by Wenson Hsieh.
2516
2517         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2518
2519 2018-04-20  Chris Dumez  <cdumez@apple.com>
2520
2521         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
2522         https://bugs.webkit.org/show_bug.cgi?id=184210
2523         <rdar://problem/39072354>
2524
2525         Reviewed by Wenson Hsieh.
2526
2527         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
2528         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
2529         Add viewport meta tags.
2530
2531         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2532         (-[WKWebView _test_waitForDidFinishNavigation]):
2533         Update _test_waitForDidFinishNavigation to wait for the next presentation update
2534         to make iOS API tests happy without having to modify each of them.
2535
2536 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2537
2538         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
2539
2540         https://bugs.webkit.org/show_bug.cgi?id=184849
2541         rdar://problem/39386405
2542
2543         Reviewed by Brian Burg.
2544
2545         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
2546         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
2547         CGColor pointer from NSColor each time.
2548
2549 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2550
2551         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
2552         https://bugs.webkit.org/show_bug.cgi?id=184822
2553         <rdar://problem/38807319>
2554
2555         Reviewed by Tim Horton.
2556
2557         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
2558         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
2559         SPI. See other ChangeLogs for more detail.
2560
2561         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2562         (WTR::UIScriptController::enterText):
2563         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2564
2565         Add UIScriptController support for simulating text entry in the currently focused element.
2566
2567         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2568         (WTR::UIScriptController::enterText):
2569         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2571
2572         Add TestRunner bindings for registering injected bundle form client callbacks.
2573
2574         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2575         (WTR::handleTextDidChangeInTextField):
2576         (WTR::handleTextFieldDidBeginEditing):
2577         (WTR::handleTextFieldDidEndEditing):
2578         (WTR::InjectedBundle::didCreatePage):
2579
2580         Set the injected bundle form editor client.
2581
2582         (WTR::InjectedBundle::setUpInjectedBundleClients):
2583         (WTR::InjectedBundle::textDidChangeInTextField):
2584         (WTR::InjectedBundle::textFieldDidBeginEditing):
2585         (WTR::InjectedBundle::textFieldDidEndEditing):
2586         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2588         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
2589         (WTR::TestRunner::textDidChangeInTextFieldCallback):
2590         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
2591         (WTR::TestRunner::textFieldDidBeginEditingCallback):
2592         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
2593         (WTR::TestRunner::textFieldDidEndEditingCallback):
2594         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2595         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2596         (WTR::UIScriptController::enterText):
2597
2598 2018-04-20  Youenn Fablet  <youenn@apple.com>
2599
2600         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
2601         https://bugs.webkit.org/show_bug.cgi?id=184369
2602
2603         Reviewed by Chris Dumez.
2604
2605         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2606         (TEST):
2607
2608 2018-04-20  Daniel Bates  <dabates@apple.com>
2609
2610         Remove Strong Password decoration when text field type changes
2611         https://bugs.webkit.org/show_bug.cgi?id=184795
2612         <rdar://problem/38325108>
2613
2614         Reviewed by Antti Koivisto.
2615
2616         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2617         when the field has the Strong Password button and its type changes.
2618
2619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2620         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
2621         (didResignInputElementStrongPasswordAppearance):
2622         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2623         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2624         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
2625         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2626         (TEST):
2627
2628 2018-04-20  Brady Eidson  <beidson@apple.com>
2629
2630         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
2631         https://bugs.webkit.org/show_bug.cgi?id=184807
2632
2633         Reviewed by Chris Dumez.
2634
2635         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2636         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
2637
2638 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2639
2640         Unreviewed. Mark TestJSC as slow in debug.
2641
2642         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
2643
2644         * TestWebKitAPI/glib/TestExpectations.json:
2645
2646 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2647
2648         [GTK] Local cross references are broken in API documentation
2649         https://bugs.webkit.org/show_bug.cgi?id=184771
2650
2651         Reviewed by Michael Catanzaro.
2652
2653         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
2654         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
2655         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
2656         the cases.
2657
2658         * gtk/gtkdoc.py:
2659         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
2660         anything here.
2661         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
2662         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
2663         which gtkdoc-fixxref always uses absolute paths.
2664         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
2665
2666 2018-04-19  Brady Eidson  <beidson@apple.com>
2667
2668         Make back forward cache work with process swapping.
2669         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
2670
2671         Reviewed by Chris Dumez.
2672
2673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2674
2675 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2676
2677         Enable Objective-C weak references
2678         <https://webkit.org/b/184789>
2679         <rdar://problem/39571716>
2680
2681         Reviewed by Dan Bernstein.
2682
2683         * ContentExtensionTester/Configurations/Base.xcconfig:
2684         (CLANG_ENABLE_OBJC_WEAK): Enable.
2685         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2686         (CLANG_ENABLE_OBJC_WEAK): Enable.
2687         * ImageDiff/cg/Configurations/Base.xcconfig:
2688         (CLANG_ENABLE_OBJC_WEAK): Enable.
2689         * MiniBrowser/Configurations/Base.xcconfig:
2690         (CLANG_ENABLE_OBJC_WEAK): Enable.
2691         * TestWebKitAPI/Configurations/Base.xcconfig:
2692         (CLANG_ENABLE_OBJC_WEAK): Enable.
2693         * WebEditingTester/Configurations/Base.xcconfig:
2694         (CLANG_ENABLE_OBJC_ARC): Re-order.
2695         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
2696         end of file.
2697         (CLANG_ENABLE_OBJC_WEAK): Enable.
2698         * WebKitTestRunner/Configurations/Base.xcconfig:
2699         (CLANG_ENABLE_OBJC_WEAK): Enable.
2700
2701 2018-04-19  Chris Dumez  <cdumez@apple.com>
2702
2703         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
2704         https://bugs.webkit.org/show_bug.cgi?id=184209
2705         <rdar://problem/39145306>
2706
2707         Reviewed by Ryosuke Niwa.
2708
2709         Add API test coverage.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2712         (TEST):
2713
2714 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2715
2716         [WinCairo][EWS] Build bot should clean user temp directory each time.
2717         https://bugs.webkit.org/show_bug.cgi?id=184761
2718
2719         Reviewed by Lucas Forschler.
2720
2721         * EWSTools/Start-Queue.ps1:
2722         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
2723
2724 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2725
2726         Buildbots using Python zipfile should enable compression
2727         https://bugs.webkit.org/show_bug.cgi?id=184759
2728
2729         Reviewed by Lucas Forschler.
2730
2731         * BuildSlaveSupport/built-product-archive:
2732         (createZipManually):
2733         Default is to archive without compressing, so tell it to compress as well. 
2734
2735 2018-04-18  Nan Wang  <n_wang@apple.com>
2736
2737         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
2738         https://bugs.webkit.org/show_bug.cgi?id=184742
2739
2740         Reviewed by Chris Fleizach.
2741
2742         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2743         (AccessibilityUIElement::increment):
2744         (AccessibilityUIElement::decrement):
2745         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2746         (WTR::AccessibilityUIElement::asyncIncrement):
2747         (WTR::AccessibilityUIElement::asyncDecrement):
2748         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2749         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2750         (WTR::AccessibilityUIElement::increment):
2751         (WTR::AccessibilityUIElement::decrement):
2752         (WTR::AccessibilityUIElement::asyncIncrement):
2753         (WTR::AccessibilityUIElement::asyncDecrement):
2754
2755 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2756
2757         Fix archive step for WinCairo build bot.
2758         https://bugs.webkit.org/show_bug.cgi?id=184715
2759
2760         Reviewed by Lucas Forschler.
2761
2762         * BuildSlaveSupport/built-product-archive:
2763         (archiveBuiltProduct):
2764         (extractBuiltProduct):
2765
2766 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
2767
2768         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
2769         https://bugs.webkit.org/show_bug.cgi?id=184570
2770         <rdar://problem/34807323>
2771
2772         Reviewed by Chris Dumez.
2773
2774         Add API test coverage.
2775
2776         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
2777         (TEST):
2778
2779 2018-04-18  Chris Dumez  <cdumez@apple.com>
2780
2781         Add support for converting a local window to a remote window
2782         https://bugs.webkit.org/show_bug.cgi?id=184515
2783         <rdar://problem/39011318>
2784
2785         Reviewed by Ryosuke Niwa.
2786
2787         * MiniBrowser/mac/AppDelegate.m:
2788         (defaultConfiguration):
2789         * MiniBrowser/mac/SettingsController.h:
2790         * MiniBrowser/mac/SettingsController.m:
2791         (-[SettingsController _populateMenu]):
2792         (-[SettingsController validateMenuItem:]):
2793         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
2794         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
2795         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2798         Turn on process swap on cross-origin window.open() for corresponding test and update
2799         test to expect that a new WebProcess is created.
2800
2801         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2802         (WTR::InjectedBundlePage::decidePolicyForResponse):
2803         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
2804         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
2805         In this new process, we have constructed a InjectedBundlePage for the page but we
2806         have not initialized the InjectedBundle members such as testRunner.
2807
2808         * WebKitTestRunner/TestController.cpp:
2809         (WTR::TestController::createWebViewWithOptions):
2810         (WTR::updateTestOptionsFromTestHeader):
2811         * WebKitTestRunner/TestOptions.h:
2812         (WTR::TestOptions::hasSameInitializationOptions const):
2813         Add a way for layout tests to turn on process swap on navigation via a test header.
2814
2815 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2816
2817         Unreviewed, reland r230697, r230720, and r230724.
2818         https://bugs.webkit.org/show_bug.cgi?id=184600
2819
2820         * Scripts/run-jsc-stress-tests:
2821
2822 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2823
2824         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
2825         https://bugs.webkit.org/show_bug.cgi?id=184687
2826
2827         Reviewed by Michael Catanzaro.
2828
2829         Add test cases for the new API.
2830
2831         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2832         (fooCreate):
2833         (fooFree):
2834         (fooGetProperty):
2835         (fooSetProperty):
2836         (testJSCPromises):
2837         (testJSCGarbageCollector):
2838         (testsJSCVirtualMachine):
2839         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2840         (windowObjectClearedCallback):
2841
2842 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2843
2844         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
2845         https://bugs.webkit.org/show_bug.cgi?id=184635
2846         <rdar://problem/39440642>
2847
2848         Reviewed by Tim Horton.
2849
2850         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
2851         dismissing or presenting fullscreen input view controllers in extra zoom mode.
2852
2853         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2854         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2855         (-[TestRunnerWKWebView dealloc]):
2856         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2857         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2858         (-[TestRunnerWKWebView _keyboardDidShow:]):
2859         (-[TestRunnerWKWebView _keyboardDidHide:]):
2860         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
2861         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
2862
2863 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2864
2865         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
2866         https://bugs.webkit.org/show_bug.cgi?id=184573
2867
2868         Reviewed by Carlos Alberto Lopez Perez.
2869
2870         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2871         (TestWebKitAPI::TEST):
2872
2873 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2874
2875         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
2876         https://bugs.webkit.org/show_bug.cgi?id=184524
2877
2878         Reviewed by Alex Christensen.
2879
2880         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
2881
2882         * TestWebKitAPI/PlatformWebView.h:
2883         * TestWebKitAPI/PlatformWin.cmake:
2884         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2885         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2886         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2887         (TestWebKitAPI::Util::moduleDirectory):
2888         (TestWebKitAPI::Util::createInjectedBundlePath):
2889         (TestWebKitAPI::Util::createURLForResource):
2890         (TestWebKitAPI::Util::URLForNonExistentResource):
2891         (TestWebKitAPI::Util::isKeyDown):
2892         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2893         (TestWebKitAPI::PlatformWebView::registerWindowClass):
2894         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2895         (TestWebKitAPI::PlatformWebView::initialize):
2896         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2897         (TestWebKitAPI::PlatformWebView::page const):
2898         (TestWebKitAPI::PlatformWebView::resizeTo):
2899         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2900         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2901         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2902         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2903         (TestWebKitAPI::PlatformWebView::wndProc):
2904         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
2905         (TestWebKitAPI::Util::run):
2906         (TestWebKitAPI::Util::spinRunLoop):
2907         (TestWebKitAPI::Util::sleep):
2908
2909 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2910
2911         Fix hasher tests for system with 32 bit longs
2912         https://bugs.webkit.org/show_bug.cgi?id=184708
2913         <rdar://problem/39459977>
2914
2915         Reviewed by Mark Lam.
2916
2917         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
2918
2919         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
2920         (TestWebKitAPI::TEST):
2921
2922 2018-04-17  Commit Queue  <commit-queue@webkit.org>
2923
2924         Unreviewed, rolling out r230697, r230720, and r230724.
2925         https://bugs.webkit.org/show_bug.cgi?id=184717
2926
2927         These caused multiple failures on the Test262 testers.
2928         (Requested by mlewis13 on #webkit).
2929
2930         Reverted changesets:
2931
2932         "[WebAssembly][Modules] Prototype wasm import"
2933         https://bugs.webkit.org/show_bug.cgi?id=184600
2934         https://trac.webkit.org/changeset/230697
2935
2936         "[WebAssembly][Modules] Implement function import from wasm
2937         modules"
2938         https://bugs.webkit.org/show_bug.cgi?id=184689
2939         https://trac.webkit.org/changeset/230720
2940
2941         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
2942         https://bugs.webkit.org/show_bug.cgi?id=184703
2943         https://trac.webkit.org/changeset/230724
2944
2945 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2946
2947         Unreviewed rollout of r230632. Regression in memory usage.
2948
2949         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2950
2951         * DumpRenderTree/TestOptions.h:
2952         * DumpRenderTree/mac/DumpRenderTree.mm:
2953         (runTest):
2954         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
2955         * WebKitTestRunner/TestController.cpp:
2956         (WTR::TestController::resetPreferencesToConsistentValues):
2957         * WebKitTestRunner/TestOptions.cpp:
2958         (WTR::TestOptions::TestOptions):
2959         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2960         * WebKitTestRunner/TestOptions.h:
2961
2962 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2963
2964         [JSC] Rename runWebAssembly to runWebAssemblySuite
2965         https://bugs.webkit.org/show_bug.cgi?id=184703
2966
2967         Reviewed by JF Bastien.
2968
2969         * Scripts/run-jsc-stress-tests:
2970
2971 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2972
2973         [WebAssembly][Modules] Implement function import from wasm modules
2974         https://bugs.webkit.org/show_bug.cgi?id=184689
2975
2976         Reviewed by JF Bastien.
2977
2978         Add runWebAssemblyDirect, which runs wasm file directly.
2979
2980         * Scripts/run-jsc-stress-tests:
2981
2982 2018-04-17  Saam Barati  <sbarati@apple.com>
2983
2984         Add system trace points for process launch and for initializeWebProcess
2985         https://bugs.webkit.org/show_bug.cgi?id=184669
2986
2987         Reviewed by Simon Fraser.
2988
2989         * Tracing/SystemTracePoints.plist:
2990
2991 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
2992
2993         Add debug bots for WinCairo.
2994         https://bugs.webkit.org/show_bug.cgi?id=184663
2995
2996         Reviewed by Lucas Forschler.
2997
2998         * BuildSlaveSupport/build.webkit.org-config/config.json:
2999         Add a debug build bot and two debug test bots.
3000
3001         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3002         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3003         Add a WinCairo category to build.webkit.org.
3004
3005 2018-04-17  Zalan Bujtas  <zalan@apple.com>
3006
3007         [LayoutReloaded] Set inline-block box position.
3008         https://bugs.webkit.org/show_bug.cgi?id=184690
3009
3010         Reviewed by Antti Koivisto.
3011
3012         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3013         (InlineFormattingContext.prototype._handleInlineBlock):
3014         * LayoutReloaded/Utils.js:
3015         (Utils._dumpBox):
3016         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
3017
3018 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3019
3020         [GLIB] Add API to clear JSCContext uncaught exception
3021         https://bugs.webkit.org/show_bug.cgi?id=184685
3022
3023         Reviewed by Žan Doberšek.
3024
3025         Add test cases for the new API.
3026
3027         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3028         (testJSCExceptions):
3029
3030 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3031
3032         [GLIB] Add API to query, delete and enumerate properties
3033         https://bugs.webkit.org/show_bug.cgi?id=184647
3034
3035         Reviewed by Michael Catanzaro.
3036
3037         Add test cases for the new API.
3038
3039         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3040         (testJSCObject):
3041         (testJSCClass):
3042         (testJSCPrototypes):
3043
3044 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3045
3046         [LayoutReloaded] Add support for replaced box.
3047         https://bugs.webkit.org/show_bug.cgi?id=184680
3048
3049         Reviewed by Antti Koivisto.
3050
3051         Basic support for inline replaced.
3052
3053         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3054         (InlineFormattingContext.prototype._handleInlineBox):
3055         (InlineFormattingContext.prototype._handleInlineBlock):
3056         (InlineFormattingContext.prototype._handleReplaced):
3057         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3058         (Line.prototype.lastLineBox):
3059         (Line.prototype.addInlineBox):
3060         (Line.prototype.addInlineContainerBox): Deleted.
3061         * LayoutReloaded/TreeBuilder.js:
3062         (TreeBuilder.prototype._createAndAttachBox):
3063         * LayoutReloaded/Utils.js:
3064         (Utils._dumpBox):
3065         * LayoutReloaded/test/index.html:
3066         * LayoutReloaded/test/inline-simple-replaced.html: Added.
3067
3068 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3069
3070         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
3071         https://bugs.webkit.org/show_bug.cgi?id=184679
3072
3073         Reviewed by Antti Koivisto.
3074
3075         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3076         (InlineFormattingContext):
3077         (InlineFormattingContext.prototype.layout):
3078         (InlineFormattingContext.prototype._handleInlineContainer):
3079         (InlineFormattingContext.prototype._handleInlineContent):
3080         (InlineFormattingContext.prototype._handleInlineBlock):
3081         (InlineFormattingContext.prototype._handleReplacedBox):
3082         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
3083         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
3084         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
3085
3086 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3087
3088         [LayoutReloaded] Introduce fragmentation state/context.
3089         https://bugs.webkit.org/show_bug.cgi?id=184677
3090
3091         Reviewed by Antti Koivisto.
3092
3093         State/context for fragmented content (multicol, regions, pagination etc).
3094
3095         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
3096         (FragmentationContext):
3097         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
3098         (FragmentationState):
3099         (FragmentationState.prototype.formattingState):
3100
3101 2018-04-16  Andy Estes  <aestes@apple.com>
3102
3103         [iOS] Enable WKPDFView by default
3104         https://bugs.webkit.org/show_bug.cgi?id=184675
3105         <rdar://problem/27885452>
3106
3107         Reviewed by Darin Adler.
3108
3109         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3110
3111 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
3112
3113         Perl-based Test262 runner
3114         https://bugs.webkit.org/show_bug.cgi?id=183343
3115
3116         Reviewed by Michael Saboff.
3117
3118         * Scripts/test262-helpers/README.md: Added.
3119         * Scripts/test262-helpers/agent.js: Added.
3120         (262.getGlobal):
3121         (262.setGlobal):
3122         (262.destroy):
3123         (262.IsHTMLDDA):
3124         * Scripts/test262-helpers/cpanfile: Added.
3125         * Scripts/test262-helpers/cpanfile.snapshot: Added.
3126         * Scripts/test262-helpers/test262-runner.pl: Added.
3127         (main):
3128         (processFile):
3129         (getScenarios):
3130         (addScenario):
3131         (compileTest):
3132         (runTest):
3133         (processResult):
3134         (getTempFile):
3135         (getContents):
3136         (parseData):
3137         (getHarness):
3138         * Scripts/test262-helpers/tests.log: Added.
3139
3140 2018-04-15  Andy Estes  <aestes@apple.com>
3141
3142         [iOS] Add API tests for PDF find-in-page
3143         https://bugs.webkit.org/show_bug.cgi?id=184634
3144
3145         Reviewed by Dan Bernstein.
3146
3147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3148         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
3149         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3150         (-[TestFindDelegate findString]):
3151         (-[TestFindDelegate _webView:didCountMatches:forString:]):
3152         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
3153         (-[TestFindDelegate _webView:didFailToFindString:]):
3154         (loadWebView):
3155         (TEST):
3156
3157 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3158
3159         [LayoutReloaded] Update class documentation
3160         https://bugs.webkit.org/show_bug.cgi?id=184625
3161
3162         Reviewed by Antti Koivisto.
3163
3164         * LayoutReloaded/DisplayTree/Box.js:
3165         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3166         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
3167         * LayoutReloaded/FormattingContext/FloatingContext.js:
3168         * LayoutReloaded/FormattingContext/FormattingContext.js:
3169         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3170         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3171         * LayoutReloaded/FormattingState/BlockFormattingState.js:
3172         * LayoutReloaded/FormattingState/FloatingState.js:
3173         * LayoutReloaded/FormattingState/FormattingState.js:
3174         * LayoutReloaded/FormattingState/InlineFormattingState.js:
3175         * LayoutReloaded/LayoutState.js:
3176         * LayoutReloaded/LayoutTree/BlockContainer.js:
3177         * LayoutReloaded/LayoutTree/Box.js:
3178         * LayoutReloaded/LayoutTree/Container.js:
3179         * LayoutReloaded/LayoutTree/InlineBox.js:
3180         * LayoutReloaded/LayoutTree/InlineContainer.js:
3181         * LayoutReloaded/LayoutTree/Text.js:
3182         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
3183         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
3184         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
3185         * LayoutReloaded/misc/headers/Box.h: Removed.
3186         * LayoutReloaded/misc/headers/Container.h: Removed.
3187         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
3188         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
3189         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
3190         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
3191         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
3192         * LayoutReloaded/misc/headers/Line.h: Removed.
3193         * LayoutReloaded/misc/headers/Text.h: Removed.
3194
3195 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3196
3197         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
3198         https://bugs.webkit.org/show_bug.cgi?id=184621
3199
3200         Reviewed by Antti Koivisto.
3201
3202         This is just a simple, mark ancestors dirty implementation.
3203
3204         * LayoutReloaded/FormattingState/FormattingState.js:
3205         (FormattingState.prototype.markNeedsLayout):
3206         * LayoutReloaded/LayoutState.js:
3207         (LayoutState.prototype.markNeedsLayout):
3208         (LayoutState.prototype.setNeedsLayoutById): Deleted.
3209         (LayoutState.prototype.setNeedsLayout): Deleted.
3210         * LayoutReloaded/TreeBuilder.js:
3211         (TreeBuilder.prototype._createAndAttachBox):
3212         (TreeBuilder.prototype._findBox): Deleted.
3213         * LayoutReloaded/Utils.js:
3214         (Utils.layoutBoxById):
3215         * LayoutReloaded/test/index.html:
3216         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
3217
3218 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3219
3220         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
3221         https://bugs.webkit.org/show_bug.cgi?id=184595
3222
3223         Reviewed by Michael Catanzaro.
3224
3225         Ensure Driver.check_driver() is checked at check_sys_deps() time.
3226
3227         * Scripts/webkitpy/port/wpe.py:
3228         (WPEPort.check_sys_deps):
3229
3230 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3231
3232         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
3233
3234         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3235
3236 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
3237
3238         Boot fewer simulators in CI/EWS machines
3239         https://bugs.webkit.org/show_bug.cgi?id=184594
3240         <rdar://problem/39188082>
3241
3242         Reviewed by Alexey Proskuryakov.
3243
3244         This is a temporary workaround fro <rdar://problem/39393590>.
3245
3246         * Scripts/webkitpy/xcode/simulated_device.py:
3247         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
3248
3249 2018-04-13  Brady Eidson  <beidson@apple.com>
3250
3251         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
3252         https://bugs.webkit.org/show_bug.cgi?id=184559
3253
3254         Reviewed by Alex Christensen.
3255
3256         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3257
3258 2018-04-13  Chris Dumez  <cdumez@apple.com>
3259
3260         input.webkitEntries does not work as expected when folder contains accented chars
3261         https://bugs.webkit.org/show_bug.cgi?id=184517
3262         <rdar://problem/39265537>
3263
3264         Reviewed by Alex Christensen.
3265
3266         Add API test coverage.
3267
3268         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3269         (TestWebKitAPI::TEST_F):
3270
3271 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
3272
3273         Update my emails ordering in contributors.json
3274         https://bugs.webkit.org/show_bug.cgi?id=184587
3275
3276         Rubber-stamped by Philippe Normand.
3277
3278         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
3279
3280         * Scripts/webkitpy/common/config/contributors.json:
3281
3282 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3283
3284         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
3285         https://bugs.webkit.org/show_bug.cgi?id=184388
3286
3287         Reviewed by Carlos Alberto Lopez Perez.
3288
3289         Remove libxkbcommon from the JHBuild environment. We could alternatively add
3290         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
3291         not believe it depends on anything else in the JHBuild environment.
3292
3293         * wpe/install-dependencies:
3294         * wpe/jhbuild.modules:
3295
3296 2018-04-12  Antoine Quint  <graouts@apple.com>
3297
3298         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3299         https://bugs.webkit.org/show_bug.cgi?id=184569
3300         <rdar://problem/38671301>
3301
3302         Reviewed by Jon Lee.
3303
3304         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
3305         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
3306
3307         * DumpRenderTree/TestOptions.h:
3308         * DumpRenderTree/mac/DumpRenderTree.mm:
3309         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
3310         (runTest):
3311         * WebKitTestRunner/TestController.cpp:
3312         (WTR::TestController::resetPreferencesToConsistentValues):
3313         * WebKitTestRunner/TestOptions.cpp:
3314         (WTR::isLegacyAnimationEngineTestPath):
3315         (WTR::TestOptions::TestOptions):
3316         * WebKitTestRunner/TestOptions.h:
3317
3318 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3319
3320         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
3321         https://bugs.webkit.org/show_bug.cgi?id=184531
3322
3323         Reviewed by Michael Catanzaro.
3324
3325         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
3326         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
3327         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
3328         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
3329         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
3330
3331         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3332         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
3333         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
3334         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
3335         (TestWebKitAPI::Util::sleep): Ditto.
3336
3337 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3338
3339         [LayoutReloaded] Add support for incremental layout
3340         https://bugs.webkit.org/show_bug.cgi?id=184578
3341
3342         Reviewed by Antti Koivisto.
3343
3344         * LayoutReloaded/Layout.js:
3345         (layout):
3346         * LayoutReloaded/LayoutState.js:
3347         (LayoutState.prototype.rootContainer):
3348         (LayoutState.prototype.setNeedsLayoutById):
3349         * LayoutReloaded/Utils.js:
3350         (Utils.layoutTreeDump):
3351         * LayoutReloaded/test/TestHarness.js:
3352         (verifyLayout):
3353         (runLayout):
3354         (verifyLayoutTreeDump): Deleted.
3355         * LayoutReloaded/test/index.html:
3356         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
3357
3358 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3359
3360         [LayoutReloaded] Move root container ownership to layout state
3361         https://bugs.webkit.org/show_bug.cgi?id=184575
3362
3363         Reviewed by Antti Koivisto.
3364
3365         Now the root container is on the associated layout state (ICB only at this point though).
3366
3367         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3368         (BlockFormattingContext.prototype.layout):
3369         * LayoutReloaded/FormattingContext/FormattingContext.js:
3370         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3371         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3372         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3373         (InlineFormattingContext.prototype._handleFloatingBox):
3374         * LayoutReloaded/Layout.js:
3375         (layout):
3376         * LayoutReloaded/LayoutState.js:
3377         (LayoutState):
3378         (LayoutState.prototype.formattingContext):
3379         (LayoutState.prototype.establishedFormattingState):
3380         (LayoutState.prototype.formattingStateForBox):
3381         (LayoutState.prototype.needsLayout):
3382         (LayoutState.prototype.displayBox):
3383         (LayoutState.prototype._formattingContext):
3384         (LayoutState.prototype.layout): Deleted.
3385         (LayoutState.prototype.formattingStates): Deleted.
3386         (LayoutState.prototype.initialDisplayBox): Deleted.
3387         * LayoutReloaded/Utils.js:
3388         (Utils._dumpBox):
3389         (Utils._findDisplayBox): Deleted.
3390
3391 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
3392
3393         Fix --build-directory flag for run-webkit-tests
3394         https://bugs.webkit.org/show_bug.cgi?id=184545
3395         <rdar://problem/39385080>
3396
3397         Rubber-stamped by Aakash Jain.
3398
3399         The --build-directory path does not work with iOS-Simulator.
3400
3401         * Scripts/webkitpy/port/base.py:
3402         (Port._build_path): Use the port configuration to calculate the root directory.
3403         * Scripts/webkitpy/port/base_unittest.py:
3404         (PortTest.test_build_path): Test build directories for embedded configurations.
3405
3406 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
3407
3408         pemfile.py should not assume POSIX line endings
3409         https://bugs.webkit.org/show_bug.cgi?id=184507
3410
3411         Reviewed by Daniel Bates.
3412
3413         * Scripts/webkitpy/common/system/pemfile.py:
3414         (_parse_pem_format):
3415         * Scripts/webkitpy/common/system/pemfile_unittest.py:
3416         (PemFileTest.test_parse_crlf):
3417         (PemFileTest.test_parse_cr):
3418
3419 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3420
3421         [LayoutReloaded] Minor cleanup in LayoutSate
3422         https://bugs.webkit.org/show_bug.cgi?id=184546
3423
3424         Reviewed by Antti Koivisto.
3425
3426         * LayoutReloaded/FormattingContext/FormattingContext.js:
3427         (FormattingContext.isInFormattingContext):
3428         * LayoutReloaded/FormattingState/FormattingState.js:
3429         (FormattingState.prototype.displayBoxes):
3430         (FormattingState.prototype.displayBox):
3431         (FormattingState.prototype._markSubTreeNeedsLayout):
3432         (FormattingState):
3433         (FormattingState.prototype.displayBoxMap): Deleted.
3434         * LayoutReloaded/LayoutState.js:
3435         (LayoutState.prototype.formattingStateForBox):
3436         (LayoutState.prototype.needsLayout):
3437         (LayoutState.prototype.displayBox):
3438         (LayoutState.prototype._createFormattingState):
3439         (LayoutState):
3440         * LayoutReloaded/LayoutTree/Box.js:
3441         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
3442         * LayoutReloaded/LayoutTree/Container.js:
3443         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
3444         * LayoutReloaded/Utils.js:
3445         (Utils._findDisplayBox):
3446
3447 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3448
3449         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
3450         https://bugs.webkit.org/show_bug.cgi?id=184538
3451
3452         Reviewed by Antti Koivisto.
3453
3454         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3455         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3456         (BlockFormattingContext):
3457         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
3458         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
3459         * LayoutReloaded/FormattingContext/FormattingContext.js:
3460         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3461         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3462         (FormattingContext):
3463         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3464         (InlineFormattingContext.prototype.layout):
3465         (InlineFormattingContext.prototype._handleInlineContainer):
3466         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3467         (InlineFormattingContext.prototype._handleInlineContent):
3468         (InlineFormattingContext.prototype._clearAndMoveToNext):
3469         (InlineFormattingContext):
3470
3471 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3472
3473         [GStreamer] Speed up GStreamer dependency build by removing examples compilation
3474         https://bugs.webkit.org/show_bug.cgi?id=184528
3475
3476         Reviewed by Philippe Normand.
3477
3478         * gstreamer/jhbuild.modules: Added --disable-examples for GStreamer package.
3479
3480 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
3481
3482         [WPE] Switch testing process to using WPEBackend-fdo
3483         https://bugs.webkit.org/show_bug.cgi?id=184357
3484
3485         Reviewed by Carlos Alberto Lopez Perez.
3486
3487         Switch WPE testing to using the WPEBackend-fdo implementation that
3488         depends on the WL_bind_wayland_display EGL extension, as defined under
3489         the freedesktop.org project.
3490         https://cgit.freedesktop.org/mesa/mesa/tree/docs/specs/WL_bind_wayland_display.spec
3491
3492         HeadlessViewBackend is refactored to use the WPEBackend-fdo API, but
3493         otherwise is not changed in functionality.
3494
3495         Unit tests now have to unconditionally use HeadlessViewBackend as a
3496         wpe_view_backend provider, since WPEBackend-fdo does not provide a
3497         default wpe_view_backend implementation. Unit tests covering that are
3498         adjusted to instead use a mock wpe_view_backend interface.
3499
3500         * Scripts/webkitdirs.pm:
3501         (builtDylibPathForName): Fix the libWPEWebKit.so name to also include
3502         the API version that was added in r230449.
3503         * Scripts/webkitpy/port/waylanddriver.py:
3504         (WaylandDriver._setup_environ_for_test): Export EGL_PLATFORM=wayland.
3505         * Scripts/webkitpy/port/wpe.py:
3506         (WPEPort._driver_class): Use WaylandDriver by default.
3507         * TestWebKitAPI/PlatformWebView.h:
3508         (): Deleted.
3509         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3510         (testWebViewWebBackend):
3511         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3512         (Test::createWebViewBackend):
3513         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
3514         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3515         (TestWebKitAPI::PlatformWebView::initialize):
3516         * wpe/HeadlessViewBackend/CMakeLists.txt:
3517         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3518         (getEGLDisplay):
3519         (HeadlessViewBackend::HeadlessViewBackend):
3520         (HeadlessViewBackend::~HeadlessViewBackend):
3521         (HeadlessViewBackend::backend const):
3522         (HeadlessViewBackend::createSnapshot):
3523         (HeadlessViewBackend::performUpdate):
3524         (HeadlessViewBackend::makeCurrent): Deleted.
3525         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3526         * wpe/jhbuild.modules: Module name cleanup. Dyz version is bumped.
3527
3528 2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3529
3530         [GTK] Switch to use always complex text code path
3531         https://bugs.webkit.org/show_bug.cgi?id=183285
3532
3533         Reviewed by Michael Catanzaro.
3534
3535         Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
3536
3537         * WebKitTestRunner/gtk/main.cpp:
3538         (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
3539
3540 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3541
3542         [GLIB] Handle strings containing null characters
3543         https://bugs.webkit.org/show_bug.cgi?id=184450
3544
3545         Reviewed by Michael Catanzaro.
3546
3547         Add test case for strings with null characters and update all calls to evaluate to pass the script length.
3548
3549         * TestWebKitAPI/PlatformGTK.cmake:
3550         * TestWebKitAPI/PlatformWPE.cmake:
3551         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3552         (testJSCBasic):
3553         (testJSCFunction):
3554         (testJSCObject):
3555         (testJSCClass):
3556         (testJSCPrototypes):
3557         (testJSCExceptions):
3558         (testJSCPromises):
3559         (testJSCGarbageCollector):
3560         (testJSCWeakValue):
3561         (testsJSCVirtualMachine):
3562         (testsJSCAutocleanups):
3563         * TestWebKitAPI/Tests/JavaScriptCore/glib/script.js: Added.
3564         * TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
3565         (DOMElementTest::testAutoFill):
3566         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3567         (WebKitWebEditorTest::testSelectionChanged):
3568         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3569         (WebKitFrameTest::testJavaScriptValues):
3570         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3571         (consoleMessageSentCallback):
3572         (methodCallCallback):
3573
3574 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
3575
3576         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
3577         https://bugs.webkit.org/show_bug.cgi?id=184513
3578
3579         Reviewed by Michael Catanzaro.
3580
3581         Update the WPE-specific testWebViewWebBackend() test case, removing the
3582         test that passes a null WebKitWebViewBackend object to the
3583         webkit_web_view_new() call.
3584
3585         Helper createWebViewBackend() that's called via Test::createWebView()
3586         variations is updated to, in case of not using the headless backend,
3587         return a WebKitWebViewBackend instance that wraps around a
3588         default wpe_view_backend object.
3589
3590         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3591         (testWebViewWebBackend):
3592         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3593         (Test::createWebViewBackend):
3594
3595 2018-04-11  Zalan Bujtas  <zalan@apple.com>
3596
3597         [LayoutReloaded] Introduce needsLayout flag
3598         https://bugs.webkit.org/show_bug.cgi?id=184527
3599
3600         Reviewed by Antti Koivisto.
3601
3602         Use the formatting state to mark boxes dirty.
3603
3604         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3605         (BlockFormattingContext.prototype.layout):
3606         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3607         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3608         (BlockFormattingContext):
3609         * LayoutReloaded/FormattingContext/FormattingContext.js:
3610         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3611         * LayoutReloaded/FormattingState/FormattingState.js:
3612         (FormattingState):
3613         (FormattingState.prototype.markNeedsLayout):
3614         (FormattingState.prototype.clearNeedsLayout):
3615         (FormattingState.prototype.needsLayout):
3616         (FormattingState.prototype.layoutNeeded):
3617         (FormattingState.prototype._markSubTreeNeedsLayout):
3618         * LayoutReloaded/LayoutState.js:
3619         (LayoutState.prototype.formattingStateForBox):
3620         (LayoutState.prototype.setNeedsLayout):
3621         (LayoutState.prototype.needsLayout):
3622         * LayoutReloaded/LayoutTree/Box.js:
3623         (Layout.Box.prototype.isFormattingContextDescendant):
3624         * LayoutReloaded/LayoutTree/Container.js:
3625         (Layout.Container.prototype.isContainingBlockDescendant):
3626
3627 2018-04-11  Jonathan Bedard  <jbedard@apple.com>
3628
3629         Fix TestInvocation class for newer versions of clang.
3630         https://bugs.webkit.org/show_bug.cgi?id=184508
3631         <rdar://problem/39328648>
3632
3633         Reviewed by Alexey Proskuryakov.
3634
3635         Declare TestInvocation to be final so it does not require a virtual destructor.
3636
3637         * WebKitTestRunner/TestInvocation.h:
3638
3639 2018-04-10  Alex Christensen  <achristensen@webkit.org>
3640
3641         IDN spoofing with Hebrew combining characters
3642         https://bugs.webkit.org/show_bug.cgi?id=184472
3643         <rdar://problem/39148687>
3644
3645         Reviewed by Brent Fulgham.
3646
3647         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3648         (TestWebKitAPI::TEST):
3649
3650 2018-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3651
3652         [Extra zoom mode] Missing label when focusing a <select> with a title attribute but no associated <label>
3653         https://bugs.webkit.org/show_bug.cgi?id=184352
3654         <rdar://problem/39237683>
3655
3656         Reviewed by Andy Estes.
3657
3658         Add support for UIScriptController::selectFormPopoverTitle, which returns the title of the current select
3659         popover's UITableViewController (for testing purposes).
3660
3661         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3662         (WTR::UIScriptController::selectFormPopoverTitle const):
3663         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3664         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3665         (WTR::UIScriptController::selectFormPopoverTitle const):
3666         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3667         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3668         (WTR::UIScriptController::selectFormPopoverTitle const):
3669
3670 2018-04-10  Nan Wang  <n_wang@apple.com>
3671
3672         AX: Expose strong password fields on iOS
3673         https://bugs.webkit.org/show_bug.cgi?id=184465
3674         <rdar://problem/39325104>
3675
3676         Reviewed by Chris Fleizach.
3677
3678         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: