8a651f344655809c39531d81ce644c7aa70fce8a
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
2
3         [Qt] Make it possible to build WebKit without QtWidgets
4         https://bugs.webkit.org/show_bug.cgi?id=78109
5
6         Reviewed by Tor Arne Vestbø.
7
8         * Tools.pro: Disable various tools that depend on WK1.
9         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
10         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
11         * qmake/mkspecs/modules/webkit1.prf: Added.
12
13 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
14
15         put vista back for chromium (non-webkit) bots ...
16         https://bugs.webkit.org/show_bug.cgi?id=89929
17
18         Unreviewed, build fix.
19
20         Turns out we've only gotten rid of vista on the webkit tests so
21         far. Put vista back for the other chromium bots ...
22
23         * TestResultServer/static-dashboards/flakiness_dashboard.js:
24         (chromiumPlatform):
25         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
26         (test):
27
28 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
29
30         update flakiness dashboard after removing chromium-vista bots
31         https://bugs.webkit.org/show_bug.cgi?id=89925
32
33         Unreviewed, build fix.
34
35         More changes missed in r121194 :(.
36
37         * TestResultServer/static-dashboards/flakiness_dashboard.js:
38         (chromiumPlatform):
39         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
40         (test):
41
42 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
43
44         remove support for chromium vista from tools
45         https://bugs.webkit.org/show_bug.cgi?id=89915
46
47         Reviewed by Tony Chang.
48
49         This change is all deleting code and updating tests to handle
50         the configuration being gone. All tests now pass except for a
51         few unittests for the flakiness dashboard which were failing
52         before this patch.
53
54         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
55         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
56         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
57         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
58         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
59         (BaselineOptimizerTest.test_complex_shadowing):
60         * Scripts/webkitpy/layout_tests/port/builders.py:
61         * Scripts/webkitpy/layout_tests/port/chromium.py:
62         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
63         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
64         (ChromiumWinPort):
65         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
66         (ChromiumWinTest.test_versions):
67         (ChromiumWinTest.test_baseline_path):
68         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
69         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
70         (BuildCoverageExtrapolatorTest.test_extrapolate):
71
72 2012-06-25  Scott Graham  <scottmg@chromium.org>
73
74         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
75         https://bugs.webkit.org/show_bug.cgi?id=89907
76
77         Not reviewed. Fix build in Chromium.
78
79         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
80         (WebThemeEngineDRTWin::getSize):
81         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
82         (WebThemeEngineDRTWin):
83
84 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
85
86         [EFL] Implement Network Information API
87         https://bugs.webkit.org/show_bug.cgi?id=87067
88
89         Reviewed by Kenneth Rohde Christiansen.
90
91         * efl/jhbuild.modules: Add eeze library dependency.
92
93 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
94
95         [Qt] Fix Win32 debug build
96
97         Reviewed by Tor Arne Vestbø.
98
99         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
100
101         * qmake/mkspecs/features/unix/default_pre.prf:
102         * qmake/mkspecs/features/win32/default_pre.prf: Added.
103
104 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
105
106         [Qt] Enable <input type="color"> support by default
107         https://bugs.webkit.org/show_bug.cgi?id=89653
108
109         Reviewed by Kenneth Rohde Christiansen.
110
111         This feature is complete for Qt WebKit2. Enabling by default
112         will help to mature the implementation.
113
114         * Scripts/webkitperl/FeatureList.pm:
115         * qmake/mkspecs/features/features.pri:
116
117 2012-06-24  Dan Bernstein  <mitz@apple.com>
118
119         Made debug-{minibrowser,safari,test-runner} work with LLDB.
120
121         Reviewed by Sam Weinig.
122
123         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
124         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
125         * Scripts/debug-safari: Ditto.
126         * Scripts/debug-test-runner: Ditto.
127         * Scripts/webkitdirs.pm:
128         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
129         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
130         and to "gdb" otherwise.
131         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
132         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
133         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
134
135 2012-06-24  Adam Barth  <abarth@webkit.org>
136
137         [Chromium] Release media resources after each LayoutTest on Android
138         https://bugs.webkit.org/show_bug.cgi?id=89720
139
140         Reviewed by Eric Carlson.
141
142         The LayoutTests can hang when run on Android because we sometimes run
143         out of media resources. This patch causes us to release our media
144         resources after each test in order to avoid running out of this
145         resource. In production, there are other mechanisms that manage this
146         resource.
147
148         * DumpRenderTree/chromium/TestShell.cpp:
149         (TestShell::resetTestController):
150
151 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
152
153         [Gtk] REGRESSION(r120918): Causes flaky DND tests
154         https://bugs.webkit.org/show_bug.cgi?id=89770
155
156         Reviewed by Martin Robinson.
157
158         Connect to the run-file-chooser signal of the WebKitWebView and
159         return TRUE so no file chooser dialog is run. This prevents certain
160         test failures.
161
162         * DumpRenderTree/gtk/DumpRenderTree.cpp:
163         (webViewRunFileChooser):
164         (createWebView):
165
166 2012-06-23  Dan Bernstein  <mitz@apple.com>
167
168         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
169
170         Reviewed by Sam Weinig.
171
172         * Scripts/webkitdirs.pm:
173         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
174
175 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
176
177         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
178
179         It fails always when running it in Xvfb.
180
181         * gtk/run-api-tests:
182         (TestRunner):
183
184 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
185
186         [GTK][WK2]Mis-spelt defaultWindowTitle
187         https://bugs.webkit.org/show_bug.cgi?id=89808
188
189         Reviewed by Carlos Garcia Campos.
190
191         * MiniBrowser/gtk/BrowserWindow.c:
192
193 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
194
195         [GTK] Add a new webkit2 tests slave bot
196         https://bugs.webkit.org/show_bug.cgi?id=89336
197
198         Reviewed by Csaba Osztrogonác.
199
200         Slave configuration for a new GTK 64 bit release bot that will run
201         WebKit2 tests.
202
203         Also BuildAndTest now accepts the "triggers" parametter,
204         this means that apart from building and testing it can trigger
205         some other build/test sequences in other slaves.
206
207         * BuildSlaveSupport/build.webkit.org-config/config.json:
208         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
209         (BuildAndTestFactory.__init__):
210
211 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
212
213         Unreviewed. Update my email.
214
215         * Scripts/webkitpy/common/config/committers.py:
216
217 2012-06-22  Adam Barth  <abarth@webkit.org>
218
219         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
220         https://bugs.webkit.org/show_bug.cgi?id=89721
221
222         Reviewed by Nate Chapin.
223
224         This patch teaches DumpRenderTree to configure Skia to use the fallback
225         fonts that the LayoutTests assume. This patch reduces the number result
226         differences between chromium-android and chromium-linux.
227
228         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
229         * DumpRenderTree/chromium/TestShellAndroid.cpp:
230         (platformInit):
231         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
232         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
233         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
234
235 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
236
237         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
238         https://bugs.webkit.org/show_bug.cgi?id=89781
239
240         Reviewed by Dean Jackson.
241
242         Added CSS Shaders as enabled by default on Safari for Mac.
243
244         * Scripts/webkitperl/FeatureList.pm:
245
246 2012-06-22  Adam Barth  <abarth@webkit.org>
247
248         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
249         https://bugs.webkit.org/show_bug.cgi?id=89791
250
251         Reviewed by Dirk Pranke.
252
253         Downstream, the chromium-android port maintains a test expectations
254         file to keep track of which tests pass or fail. That causes them to
255         keep a patch in chromium_android.py in their branch.
256
257         This patch teaches chromium_android.py to use test_expectations_android.txt.
258         We don't intend to use this file upstream, but having this code patch
259         upstream lets us unfork webkitpy.
260
261         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
262         (ChromiumAndroidPort.expectations_files):
263
264 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
265
266         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
267         https://bugs.webkit.org/show_bug.cgi?id=89734
268
269         Reviewed by Ryosuke Niwa.
270
271         Fix a crash in ServerProcess if you called .pid() after it
272         crashed during a write(). We had a test for this case but the
273         test wasn't calling pid(), just has_crashed(). Fixed the problem
274         and the test.
275
276         * Scripts/webkitpy/layout_tests/port/server_process.py:
277         (ServerProcess.__init__):
278         (ServerProcess.pid):
279         (ServerProcess._start):
280         (ServerProcess.stop):
281         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
282         (FakeServerProcess._start):
283         (TestServerProcess.test_broken_pipe):
284
285 2012-06-22  Peter Beverloo  <peter@chromium.org>
286
287         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
288         https://bugs.webkit.org/show_bug.cgi?id=88853
289
290         Reviewed by Steve Block.
291
292         The Android exclusions were necessary to fix a gyp generation error, as
293         the gcc_version variable wasn't being defined for Android. Remove these
294         exceptions when Chromium is able to define the gcc_version variable.
295
296         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
297
298 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
299
300         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
301
302         * gtk/run-api-tests:
303         (TestRunner): Unskip WTF.HashMap.
304
305 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
306
307         [Qt] Allow DumpRenderTree to dump about:blank
308         https://bugs.webkit.org/show_bug.cgi?id=89685
309
310         Reviewed by Ryosuke Niwa.
311
312         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
313         additionaly this behavior is required for running WTR performance tests.
314
315         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
316         (WebCore::DumpRenderTree::processLine):
317
318 2012-06-21  Adam Barth  <abarth@webkit.org>
319
320         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
321         https://bugs.webkit.org/show_bug.cgi?id=89718
322
323         Reviewed by Kent Tamura.
324
325         We should reset this WebSetting to its default value so that it behaves
326         consistently across tests.
327
328         * DumpRenderTree/chromium/WebPreferences.cpp:
329         (WebPreferences::reset):
330         (WebPreferences::applyTo):
331         * DumpRenderTree/chromium/WebPreferences.h:
332         (WebPreferences):
333
334 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
335
336         DRT/WTR python interface handles about:blank incorrectly
337         https://bugs.webkit.org/show_bug.cgi?id=89563
338
339         Reviewed by Dirk Pranke.
340
341         Currently DRT/WTR python interface's _command_from_driver_input function
342         puts the test directory path before about:blank. Remove this incorrect behavior.
343
344         * Scripts/webkitpy/layout_tests/port/webkit.py:
345         (WebKitDriver._command_from_driver_input):
346
347 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
348
349         reenable perf tests on win
350         https://bugs.webkit.org/show_bug.cgi?id=89690
351
352         Reviewed by Ryosuke Niwa.
353
354         Only the replay tests don't work, and those are disabled by
355         default. This change also fixes the undefined _log reference
356         that was causing a crash.
357
358         * Scripts/run-perf-tests:
359
360 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
361
362         Unreviewed, rolling out r120937.
363         http://trac.webkit.org/changeset/120937
364         https://bugs.webkit.org/show_bug.cgi?id=89679
365
366         This patch brought buildbot master down (Requested by svillar
367         on #webkit).
368
369         * BuildSlaveSupport/build.webkit.org-config/config.json:
370
371 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
372
373         [GTK] Combine WebKit API tests into fewer binaries
374         https://bugs.webkit.org/show_bug.cgi?id=88458
375
376         Reviewed by Carlos Garcia Campos.
377
378         Instead of creating one binary per-test file, create binaries for each
379         category of tests. Right now this includes WTF and the WebKit2 C API,
380         but later tests can be added for the GTK+ platform layer and the WebKit1
381         and WebKit2 API layers.
382
383         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
384           C API and one for WTF. Refresh the source list to ensure that new test are active.
385         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
386         concept of skipping a test and skipping a suite (program) of tests. Test cases are
387         skipped because of legitimate failures, but entire programs are skipped because of
388         problems in the harness. As of right now a test program is only skipped if the
389         accessibility bus cannot be started.
390         (SkippedTest.__init__): Make the test case a required argument and have one skipped
391         test case per SkippedTest instance.
392         (SkippedTest.__str__): Ditto.
393         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
394         in one directory. Reformat the test list to make it slightly easier to read.
395         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
396         test programs that are skipped.
397         (TestRunner._setup_testing_environment): Use the new member.
398         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
399         the first SkippedTest that matches.
400         (TestRunner._should_run_test_program): Take a look at the new member to make this
401         decision.
402         (TestRunner._run_test_command): Use the name test_program instead of test
403         to disambiguate between test cases and test suites.
404         (TestRunner._run_test_glib): ditto.
405         (TestRunner._run_test_google): Ditto.
406         (TestRunner._run_test): Ditto.
407         (TestRunner.run_tests): Ditto.
408
409 2012-06-21  Yong Li  <yoli@rim.com>
410
411         Unreviewed. Moving myself from committer to reviewer.
412
413         * Scripts/webkitpy/common/config/committers.py:
414
415 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
416
417         [GTK] Add a new webkit2 tests slave bot
418         https://bugs.webkit.org/show_bug.cgi?id=89336
419
420         Reviewed by Philippe Normand.
421
422         Slave configuration for a new GTK bot that will run WebKit2 tests.
423
424         * BuildSlaveSupport/build.webkit.org-config/config.json:
425
426 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
427
428         [Qt] Add a custom Color Chooser widget to MiniBrowser
429         https://bugs.webkit.org/show_bug.cgi?id=87988
430
431         Reviewed by Alexis Menard.
432
433         Added custom color chooser example for the MiniBrowser.
434
435         * MiniBrowser/qt/MiniBrowser.qrc:
436         * MiniBrowser/qt/qml/BrowserWindow.qml:
437         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
438
439 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
440
441         Remove the warning "File not found" in MiniBrowser post-build event
442         https://bugs.webkit.org/show_bug.cgi?id=89601
443
444         Reviewed by Adam Roben.
445
446         * MiniBrowser/MiniBrowserPostBuild.cmd:
447
448 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
449
450         [Qt] DRT in standalone mode hangs after the first test
451         https://bugs.webkit.org/show_bug.cgi?id=89613
452
453         Reviewed by Csaba Osztrogonác.
454
455         Break an inline signal slot chain that ends up in setting
456         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
457         we emit done() which starts the chain that finishes in DumpRenderTree::open().
458         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
459         these two lines but it seems to be wrong in general to start the next load
460         from this call chain. The server mode (when DRT is runned by the test harness)
461         also uses a queued connection to read the next test from stdin.
462
463         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
464         (WebCore::DumpRenderTree::processArgsLine):
465
466 2012-06-20  Hans Wennborg  <hans@chromium.org>
467
468         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
469         https://bugs.webkit.org/show_bug.cgi?id=89217
470
471         Reviewed by Adam Barth.
472
473         Add a method for checking whether the mock speech
474         recognition was aborted.
475
476         Also redo the way the mock posts tasks. Instead of posting them all at once,
477         maintain an internal queue of task objects, and call postTask() for them
478         once at the time. This means that for example when the page is navigated
479         away and abort() is called, that call doesn't end up after a bunch
480         of previously posted events on the event loop.
481
482         * DumpRenderTree/chromium/LayoutTestController.cpp:
483         (LayoutTestController::LayoutTestController):
484         (LayoutTestController::wasMockSpeechRecognitionAborted):
485         * DumpRenderTree/chromium/LayoutTestController.h:
486         (LayoutTestController):
487         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
488         (WebKit::ClientCallTask::ClientCallTask):
489         (WebKit::ResultTask::ResultTask):
490         (WebKit::NoMatchTask::NoMatchTask):
491         (WebKit::ErrorTask::ErrorTask):
492         (MockWebSpeechRecognizer::start):
493         (MockWebSpeechRecognizer::abort):
494         (MockWebSpeechRecognizer::setError):
495         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
496         (MockWebSpeechRecognizer::startTaskQueue):
497         (MockWebSpeechRecognizer::StepTask::runIfValid):
498         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
499         (MockWebSpeechRecognizer::hasBeenAborted):
500         (MockWebSpeechRecognizer):
501         (MockWebSpeechRecognizer::taskList):
502         (Task):
503         (MockWebSpeechRecognizer::Task::Task):
504         (MockWebSpeechRecognizer::Task::~Task):
505         (StepTask):
506         (MockWebSpeechRecognizer::StepTask::StepTask):
507
508 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
509
510         [GTK] Add support for window.showModalDialog in WebKit2GTK+
511         https://bugs.webkit.org/show_bug.cgi?id=79500
512
513         Reviewed by Carlos Garcia Campos.
514
515         Add support for modal dialogs in GTK's MiniBrowser.
516
517         * MiniBrowser/gtk/BrowserWindow.c:
518         (webViewRunAsModal):
519         (webViewCreate):
520         (webViewDecidePolicy):
521         (browser_window_new):
522         * MiniBrowser/gtk/BrowserWindow.h:
523         * MiniBrowser/gtk/main.c:
524         (createBrowserWindow):
525
526 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
527
528         [WinCairo] Unreviewed build fix.
529         The wrapper script that launched new- and old-run-webkit-tests
530         was discarding the --wincairo argument needed to get the proper
531         test infrastructure to build under WinCairo.
532
533         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
534         behavior to chain the --wincairo flag through to the new build
535         and test scripts.
536
537 2012-06-20  Mark Rowe  <mrowe@apple.com>
538
539         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
540
541         Reviewed by Dan Bernstein.
542
543         * Scripts/webkitdirs.pm:
544         (executableHasEntitlements):
545         (safariPathFromSafariBundle):
546
547 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
548
549         Unreviewed, rolling out r120821.
550         http://trac.webkit.org/changeset/120821
551         https://bugs.webkit.org/show_bug.cgi?id=89605
552
553         It made duplicated reviewer entries (Requested by Ossy on
554         #webkit).
555
556         * Scripts/webkitpy/common/checkout/changelog.py:
557         (ChangeLog.set_reviewer):
558         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
559         (test_set_reviewer):
560         (test_set_short_description_and_bug_url):
561
562 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
563
564         nrwt outputs empty files for wdiff output if wdiff is not installed
565         https://bugs.webkit.org/show_bug.cgi?id=88709
566
567         Reviewed by Tony Chang.
568
569         Reviewed by Tony Chang.
570
571         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
572         aren't available, and clean up the handling for them in the port
573         code.
574
575         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
576         (MainTest.test_output_diffs):
577         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
578         (TestResultWriter.create_text_diff_and_write_result):
579         * Scripts/webkitpy/layout_tests/port/base.py:
580         (Port.check_pretty_patch):
581         (Port.check_wdiff):
582         (Port._wdiff_missing_message):
583         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
584         (ChromiumLinuxPort.check_build):
585         (ChromiumLinuxPort._wdiff_missing_message):
586         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
587         (ChromiumMacPort.check_build):
588         (ChromiumMacPort):
589         (ChromiumMacPort._wdiff_missing_message):
590         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
591         (ChromiumMacPortTest):
592
593 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
594
595         nrwt: fix unit tests for ensuring svn revision is correct
596         https://bugs.webkit.org/show_bug.cgi?id=89498
597
598         Reviewed by Eric Seidel.
599
600         Reviewed by Eric Seidel.
601
602         Fix the unit tests for testing that we are embedding the SVN
603         revision in the results json for NRWT properly; this was broken
604         in r120646 but because the MockHost worked differently than the
605         real one (by always initializing the MockSCM object) we didn't
606         notice. Unfortunately, just changing the default breaks all
607         sorts of unit tests ...
608
609         * Scripts/webkitpy/common/host_mock.py:
610         (MockHost.__init__):
611         (MockHost._initialize_scm):
612         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
613         (ResultSummaryTest.test_no_svn_revision):
614         (ResultSummaryTest.test_svn_revision):
615
616 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
617
618         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
619         https://bugs.webkit.org/show_bug.cgi?id=69360
620
621         Reviewed by Eric Seidel.
622
623         Reviewed by Eric Seidel.
624
625         Propagate the 'port_implementation' part of the platform (i.e.,
626         gtk,qt,chromium) to webkit-build-directory so that we can pick
627         up the gtk-specific handling of WEBKITOUTPUTDIR ...
628
629         I didn't write any additional tests for this; testing it
630         properly is an integration test between the python code and the
631         perl code, which I verified by hand.
632
633         * Scripts/webkitpy/layout_tests/port/base.py:
634         (Port.__init__):
635         * Scripts/webkitpy/layout_tests/port/config.py:
636         (Config.__init__):
637         (Config.build_directory):
638         * Scripts/webkitpy/layout_tests/port/config_mock.py:
639         (MockConfig.__init__):
640         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
641         (ConfigTest.test_build_directory_passes_port_implementation):
642
643 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
644
645         Fix import sorting missed in r120846
646
647         Reviewed by Tony Chang.
648
649         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
650
651 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
652
653         Fix chromium win http servers after breakage introduced in r120846.
654
655         Unreviewed, build fix.
656
657         * Scripts/webkitpy/layout_tests/port/base.py:
658         (Port.to.start_http_server):
659         * Scripts/webkitpy/layout_tests/servers/http_server.py:
660         (Lighttpd.__init__):
661
662 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
663
664         tweak output of webkit-patch print-{baselines,expectations}
665         https://bugs.webkit.org/show_bug.cgi?id=89588
666
667         Reviewed by Tony Chang.
668
669         Minor tweaks to the output to make it more readable, including
670         turning off csv by default for print-baselines with multiple ports.
671
672         * Scripts/webkitpy/layout_tests/port/test.py:
673         (TestPort):
674         * Scripts/webkitpy/tool/commands/queries.py:
675         (PrintExpectations.execute):
676         (PrintBaselines.execute):
677         * Scripts/webkitpy/tool/commands/queries_unittest.py:
678         (PrintExpectationsTest.run_test):
679         (PrintExpectationsTest.test_multiple):
680         (PrintBaselinesTest.setUp):
681         (PrintBaselinesTest.test_multiple):
682
683 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
684
685         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
686         https://bugs.webkit.org/show_bug.cgi?id=88134
687
688         Reviewed by Tony Chang.
689
690         Change NRWT to spin up 2*min(child_processes, locked_shards)
691         http servers by default so that we are less likely to get a
692         bunch of http timeouts at the beginning of a test run.
693
694         Note that I had to tweak executive_mock to support mocked stderr
695         because the apache_http_server code reads stderr when starting a
696         process to ensure it started okay.
697
698         * Scripts/webkitpy/common/system/executive_mock.py:
699         (MockProcess.__init__):
700         * Scripts/webkitpy/common/system/outputcapture.py:
701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
702         (Manager._run_tests):
703         (Manager.start_servers_with_lock):
704         * Scripts/webkitpy/layout_tests/port/base.py:
705         (Port.to.start_http_server):
706         * Scripts/webkitpy/layout_tests/port/test.py:
707         (TestPort.start_http_server):
708         (TestPort._path_to_apache):
709         (TestPort):
710         (TestPort._path_to_apache_config_file):
711         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
712         (LayoutTestApacheHttpd.__init__):
713         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
714         (LayoutTestApacheHttpd.__init__):
715         * Scripts/webkitpy/layout_tests/servers/http_server.py:
716         (Lighttpd.__init__):
717         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
718         (HttpServerBase.__init__):
719
720 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
721
722         Unreviewed: Back out accidentally checked in debug print which broke a test
723
724         * Scripts/webkitpy/performance_tests/perftest.py:
725         (PerfTest.parse_output):
726
727 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
728
729         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
730         https://bugs.webkit.org/show_bug.cgi?id=78789
731
732         Reviewed by Ryosuke Niwa.
733
734         Updated parser to include fps as a valid unit.
735
736         * Scripts/webkitpy/performance_tests/perftest.py:
737         (PerfTest):
738         (PerfTest.parse_output):
739
740 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
741
742         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
743         https://bugs.webkit.org/show_bug.cgi?id=67935
744
745         Reviewed by Ryosuke Niwa.
746
747         * Scripts/webkitpy/common/checkout/changelog.py:
748         (ChangeLog.set_reviewer):
749         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
750         (test_set_reviewer):
751         (test_set_short_description_and_bug_url):
752
753 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
754
755         Unreviewed trivial permissions fix.
756
757         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
758
759 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
760
761         [EFL][Regression] Build break after r120786
762         https://bugs.webkit.org/show_bug.cgi?id=89549
763
764         Unreviewed build fix for Efl port.
765
766         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
767
768 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
769
770         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
771         https://bugs.webkit.org/show_bug.cgi?id=64489
772
773         Reviewed by Tony Chang.
774
775         This change changes NRWT so that we don't start the websocket
776         server if we aren't running websocket tests and don't start the
777         HTTP server if we aren't running http tests.
778         
779         * Scripts/webkitpy/layout_tests/controllers/manager.py:
780         (Manager._websocket_tests):
781         (Manager.start_servers_with_lock):
782         (Manager.stop_servers_with_lock):
783         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
784         (ManagerTest.test_servers_started):
785
786 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
787
788         test-webkitpy: add a -p flag to pass through captured output to enable debugging
789         https://bugs.webkit.org/show_bug.cgi?id=89158
790
791         Reviewed by Eric Seidel.
792
793         Normally when outputcapture runs it intercepts stdout/stderr,
794         which makes running under the debugger difficult and mostly
795         pointless (since you can't see any output). This change adds a
796         flag to test-webkitpy (-p) that will cause outputcapture to pass
797         through the output as well as capture it.
798
799         * Scripts/webkitpy/common/system/outputcapture.py:
800         (OutputCapture.stream_wrapper):
801         (OutputCapture._capture_output_with_name):
802         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
803         (OutputCaptureTest.setUp):
804         * Scripts/webkitpy/test/main.py:
805         (Tester._parse_args):
806         (Tester._run_tests):
807         (Tester._log_exception):
808         (_CaptureAndPassThroughStream):
809         (_CaptureAndPassThroughStream.__init__):
810         (_CaptureAndPassThroughStream.write):
811         (_CaptureAndPassThroughStream._message_is_from_pdb):
812         (_CaptureAndPassThroughStream.flush):
813         (_CaptureAndPassThroughStream.getvalue):
814
815 2012-06-19  Adam Barth  <abarth@webkit.org>
816
817         garden-o-matic fails to rebaseline tests with MISSING results
818         https://bugs.webkit.org/show_bug.cgi?id=89521
819
820         Reviewed by Kenneth Russell.
821
822         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
823
824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
825
826 2012-06-19  Adam Barth  <abarth@webkit.org>
827
828         svn.delete_list fails to delete empty parent directories
829         https://bugs.webkit.org/show_bug.cgi?id=89520
830
831         Reviewed by Dirk Pranke.
832
833         These functions were calling scm.delete and scm.add, which already
834         delete the parent directory. We'd get an exception when we tried to
835         delete the parent directory again.
836
837         * Scripts/webkitpy/common/checkout/scm/svn.py:
838         (SVN._add_parent_directories):
839         (SVN._delete_parent_directories):
840
841 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
842
843         webkitpy: Simplify fetch_bugs_matching_search()
844         https://bugs.webkit.org/show_bug.cgi?id=89497
845
846         Reviewed by Adam Barth.
847
848         Removed parameter with default value. It's not being used
849         and the handling of the parameter was wrong. Saves a check.
850
851         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
852         (BugzillaQueries.fetch_bugs_matching_search):
853         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
854         (MockBugzillaQueries.fetch_bugs_matching_search):
855
856 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
857
858         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
859         https://bugs.webkit.org/show_bug.cgi?id=89522
860
861         Reviewed by Eric Seidel.
862
863         They were no longer being used. No tests necessary.
864
865         * Scripts/webkitpy/layout_tests/port/chromium.py:
866
867 2012-06-19  Adam Barth  <abarth@webkit.org>
868
869         Missing results aren't shown in garden-o-matic
870
871         Reviewed by Kenneth Russell.
872
873         Previously we didn't know to look for text and image results when the
874         bot told us that results were missing.
875
876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
877
878 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
879
880         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
881
882         Unreviewed, build fix.
883
884         It turns out that we store the svn revision two different ways
885         in the JSON, and I only caught one of them :(. This should fix
886         the other.
887
888         Also, this part of the code is poorly tested. I will investigate
889         adding at least a basic test for this in a separate fix.
890
891         * Scripts/webkitpy/layout_tests/controllers/manager.py:
892         (summarize_results):
893
894 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
895
896         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
897         https://bugs.webkit.org/show_bug.cgi?id=78127
898
899         Reviewed by Ryosuke Niwa.
900
901         Add the --add-platform-exceptions flag from ORWT, and ensure
902         that --new-baseline is equivalent to --reset-results
903         --add-platform-exceptions. Also fix the default logic for where to
904         put PNGs and render tree dumps if --new-test-results is true:
905         if --add-platform-exceptions is False, baselines should go in
906         the least-specific platform directory (e.g., platform/mac)
907         rather than the most-specific (platform/mac-snowleopard).
908
909         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
910         (SingleTestRunner):
911         (SingleTestRunner.run):
912         (SingleTestRunner._run_rebaseline):
913         (SingleTestRunner._add_missing_baselines):
914         (SingleTestRunner._location_for_new_baseline):
915         (SingleTestRunner._overwrite_baselines):
916         (SingleTestRunner._save_baseline_data):
917         * Scripts/webkitpy/layout_tests/port/base.py:
918         (Port.baseline_path):
919         (Port):
920         (Port.baseline_platform_dir):
921         (Port.baseline_version_dir):
922         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
923         (_set_up_derived_options):
924         (parse_args):
925         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
926         (RebaselineTest.assertBaselines):
927         (RebaselineTest.test_reset_results):
928         (RebaselineTest.test_missing_results):
929         (RebaselineTest.test_new_baseline):
930
931 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
932
933         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
934         https://bugs.webkit.org/show_bug.cgi?id=81379
935
936         Reviewed by Eric Seidel.
937
938         The 'free memory' calculation we were running on the mac seemed
939         to underestimate how many children we can run in parallel, and
940         it was complex. This patch replaces that calculation with a
941         simpler one that reserves 2GB for overhead and assumes 256MB per
942         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
943
944         Also, there was a bug where we were truncating the memory
945         installed on the machine to 4GB by casting to an int instead of
946         a long; this was probably the source of some of the earlier
947         problems when using total memory.
948
949         This patch also removes the no-longer-needed restrictions on the
950         number of workers on beefy Lion boxes for both Apple Mac and Chromium
951         Mac; we should now use all of the cores by default.
952
953         The memory calculations have only been implemented on the mac;
954         having the calculation in base.default_child_processes() was IMO
955         misleading, and so this patch also moves the computation into
956         the MacPort. I have not heard of the # of workers being an issue
957         on any other ports, so this should be fine.
958
959         * Scripts/webkitpy/common/system/platforminfo.py:
960         (PlatformInfo.total_bytes_memory):
961         * Scripts/webkitpy/common/system/platforminfo_mock.py:
962         (PlatformInfo.total_bytes_memory):
963         (PlatformInfo.total_bytes_memory):
964         (PlatformInfo._win_version_tuple_from_cmd):
965         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
966         (TestPlatformInfo.test_total_bytes_memory):
967         * Scripts/webkitpy/layout_tests/port/base.py:
968         (Port.default_child_processes):
969         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
970         (PortTest.test_default_child_processes):
971         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
972         (ChromiumMacPort.operating_system):
973         * Scripts/webkitpy/layout_tests/port/mac.py:
974         (MacPort.default_child_processes):
975         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
976         (TestMacPort.test_default_child_processes):
977
978 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
979
980         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
981         https://bugs.webkit.org/show_bug.cgi?id=85446
982
983         Reviewed by Simon Fraser.
984
985         Embed whether pixel testing was enabled into the results.json.
986
987         * Scripts/webkitpy/layout_tests/controllers/manager.py:
988         (summarize_results):
989
990 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
991
992         [Qt] Modify HTTPS port to 8443 for performance tests
993         https://bugs.webkit.org/show_bug.cgi?id=89442
994
995         Reviewed by Ryosuke Niwa.
996
997         We should be consistent with the default HTTPS port and with the changelog of r119188.
998
999         * Scripts/webkitpy/performance_tests/perftest.py:
1000         (ReplayServer.__init__):
1001
1002 2012-06-19  Mike West  <mkwst@chromium.org>
1003
1004         Introduce ENABLE_CSP_NEXT configuration flag.
1005         https://bugs.webkit.org/show_bug.cgi?id=89300
1006
1007         Reviewed by Adam Barth.
1008
1009         The 1.0 draft of the Content Security Policy spec is just about to
1010         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
1011         this ENABLE flag, disabled by default.
1012
1013         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
1014
1015         * Scripts/webkitperl/FeatureList.pm:
1016         * qmake/mkspecs/features/features.pri:
1017
1018 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
1019
1020         [EFL] EFL's LayoutTestController does not support setTextDirection
1021         https://bugs.webkit.org/show_bug.cgi?id=87481
1022
1023         Reviewed by Hajime Morita.
1024
1025         Implement setTextDirection in EFL's LayoutTestController and
1026         properly reset its value between test cases to avoid flakiness.
1027
1028         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1029         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1030         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1031         (LayoutTestController::setTextDirection):
1032
1033 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1034
1035         [Qt] Temporarily disable xvfb driver in nrwt
1036         https://bugs.webkit.org/show_bug.cgi?id=88414
1037
1038         Reviewed by Csaba Osztrogonác.
1039
1040         * Scripts/webkitpy/layout_tests/port/qt.py:
1041         (QtPort._build_driver):
1042
1043 2012-06-18  Joone Hur  <joone.hur@intel.com>
1044
1045         [EFL] Fontconfig can't be linked properly
1046         https://bugs.webkit.org/show_bug.cgi?id=89418
1047
1048         Unreviewed build fix.
1049
1050         Make Fontconfig be linked correctly.
1051
1052         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
1053
1054 2012-06-18  Joone Hur  <joone.hur@intel.com>
1055
1056         Unreviewed. Updating email for committers.py script.
1057
1058         * Scripts/webkitpy/common/config/committers.py:
1059
1060 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1061
1062         Fix a typo that caused TestFailures to have a syntax error.
1063         
1064         Sadly TestFailures is broken for another reason now too:
1065         https://bugs.webkit.org/show_bug.cgi?id=89419
1066
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1068         (ViewController.prototype._domForBuildName):
1069
1070 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1071
1072         Provide bug links for suspicious commits
1073         https://bugs.webkit.org/show_bug.cgi?id=89408
1074         
1075         Reviewed by Adam Barth.
1076
1077         Add links to bugs for the suspicious commits if we have bug data.
1078
1079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1082         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
1083         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
1084
1085 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
1086
1087         [Chromium] DeviceOrientation Cleanup
1088         https://bugs.webkit.org/show_bug.cgi?id=89354
1089
1090         Reviewed by Kent Tamura.
1091
1092         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
1093         (WebViewHost):
1094
1095 2012-06-18  James Robinson  <jamesr@chromium.org>
1096
1097         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
1098         https://bugs.webkit.org/show_bug.cgi?id=89254
1099
1100         Reviewed by Adrienne Walker.
1101
1102         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
1103         upstream.
1104
1105         * DumpRenderTree/chromium/WebViewHost.cpp:
1106         (WebViewHost::createGraphicsContext3D):
1107
1108 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1109
1110         Minor fix suggested by Adam Barth.
1111
1112         Use $(this._what).empty(); rather than removing children one at a time.
1113         For some reason removeAllChildren() is undefined on this node.
1114         
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1116
1117 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
1118
1119         Show TOT revision in garden-o-matic, and make the revisions into links
1120         https://bugs.webkit.org/show_bug.cgi?id=89396
1121
1122         Reviewed by Adam Barth.
1123
1124         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
1125         where the revisions are links to trac.
1126         
1127         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
1128         the knock-on effect of flipping the target and href attributes for anchors in some test output.
1129
1130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1131         (ViewController.prototype._displayTesters.updateList.list):
1132         (ViewController.prototype._displayTesters.updateList):
1133         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
1134         (ViewController.prototype._domForRegressionRange):
1135         (ViewController.prototype._domForAuxiliaryUIElements):
1136         (ViewController.prototype._domForBuildName):
1137         (ViewController.prototype):
1138         (ViewController.prototype.):
1139         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1144
1145 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
1146
1147         REGRESSION(r100558): NRWT should work without SVN or GIT
1148         https://bugs.webkit.org/show_bug.cgi?id=76630
1149
1150         Reviewed by Dirk Pranke.
1151
1152         NRWT is not supposed to have a requirement that we have an
1153         actual SVN or Git checkout, and we were unnecessarily
1154         initializing the checkout. This patch removes that line :).
1155
1156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1157         (main):
1158
1159 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1160
1161         [garden-o-matic] Add support for the GTK builders
1162         https://bugs.webkit.org/show_bug.cgi?id=89360
1163
1164         Reviewed by Adam Barth.
1165
1166         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
1167         both get their data from build.webkit.org.
1168
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1170         (.):
1171
1172 2012-06-18  Nico Weber  <thakis@chromium.org>
1173
1174         [chromium/mac] Unbreak smooth scrolling.
1175         https://bugs.webkit.org/show_bug.cgi?id=89327
1176
1177         Reviewed by Dimitri Glazkov.
1178
1179         Broken by Sam in r115589 / r115591.
1180
1181         * DumpRenderTree/mac/DumpRenderTree.mm:
1182         (resetDefaultsToConsistentValues):
1183         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1184         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1185         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1186         (WTR::InjectedBundle::platformInitialize):
1187
1188 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1189
1190         Unreviewed, rolling out r120541, r120547, and r120548.
1191         http://trac.webkit.org/changeset/120541
1192         http://trac.webkit.org/changeset/120547
1193         http://trac.webkit.org/changeset/120548
1194         https://bugs.webkit.org/show_bug.cgi?id=89383
1195
1196         This approach doesn't work for WebKit2 (Requested by abarth on
1197         #webkit).
1198
1199         * DumpRenderTree/LayoutTestController.cpp:
1200         (setBackingScaleFactorCallback):
1201         (LayoutTestController::staticFunctions):
1202         * DumpRenderTree/LayoutTestController.h:
1203         (LayoutTestController):
1204         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1205         (LayoutTestController::setBackingScaleFactor):
1206         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1207         (LayoutTestController::setBackingScaleFactor):
1208         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1209         (LayoutTestController::setBackingScaleFactor):
1210         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1211         (LayoutTestController::setBackingScaleFactor):
1212         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1213         (LayoutTestController::setBackingScaleFactor):
1214         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1215         (LayoutTestController::setBackingScaleFactor):
1216         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1217         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1218         (WTR::InjectedBundle::didReceiveMessage):
1219         (WTR::InjectedBundle::postSetBackingScaleFactor):
1220         (WTR):
1221         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1222         (InjectedBundle):
1223         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1224         (WTR::LayoutTestController::setBackingScaleFactor):
1225         (WTR):
1226         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
1227         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1228         (LayoutTestController):
1229         * WebKitTestRunner/TestInvocation.cpp:
1230         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1231
1232 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1233
1234         REGRESSION(r120546): It made 3 webkitpy tests fail
1235         https://bugs.webkit.org/show_bug.cgi?id=89332
1236
1237         Reviewed by Adam Barth.
1238
1239         Update the BaselineOptimizer unittest after r120546.
1240
1241         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1242         (BaselineOptimizerTest.test_no_add_mac_future):
1243         (BaselineOptimizerTest.test_mac_future):
1244         (BaselineOptimizerTest.test_complex_shadowing):
1245
1246 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1247
1248         new-run-webkit-tests output gets confused when logging
1249         https://bugs.webkit.org/show_bug.cgi?id=63793
1250
1251         Reviewed by Adam Barth.
1252
1253         Ship all of the log messages generated in the worker back
1254         to the manager; this allows the messages to be properly
1255         serialized to stderr and for the meter to flush its output correctly.
1256
1257         Note however that this will likely result in messages to be
1258         logged out of order between workers; I'm not sure that there's
1259         an easy way to fix this short of buffering a potentially
1260         unbounded amount of data. It might be better to just log through
1261         stderr unless we're in 'metering' mode, but it's also worth
1262         noting that we already get messages out of order through stderr
1263         on Windows.
1264
1265         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1266         (Manager.handle_done):
1267         (Manager.handle_finished_test):
1268         (Manager._log_messages):
1269         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1270         (Worker.__init__):
1271         (Worker._set_up_logging):
1272         (Worker.run):
1273         (Worker._run_test):
1274         (Worker.cleanup):
1275         (Worker.run_single_test):
1276         (_WorkerLogHandler):
1277         (_WorkerLogHandler.__init__):
1278         (_WorkerLogHandler.emit):
1279         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1280         (MeteredStream.write):
1281         (MeteredStream.writeln):
1282         * Scripts/webkitpy/layout_tests/views/printing.py:
1283         (Printer.writeln):
1284
1285 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
1286
1287         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
1288         https://bugs.webkit.org/show_bug.cgi?id=89362
1289
1290         Reviewed by Simon Fraser.
1291
1292         Replace white spaces, braces and dots in the builder name with underscores. This
1293         way the JQuery tabs will be properly matched with the according container.
1294
1295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1296
1297 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
1298
1299         nrwt: metered output doesn't handle ^C cleanly
1300         https://bugs.webkit.org/show_bug.cgi?id=89249
1301
1302         Reviewed by Tony Chang.
1303
1304         If you ctrl-c a running nrwt (w/o --verbose), then all but
1305         two characters of the last update are erased, and then we print
1306         "interrupted, exiting" as an update, which itself then gets
1307         erased. Fix this so that we flush the meter (making the last
1308         update persistent, so that we print the ^C for a visual clue),
1309         print the interrupt message, and move on ...
1310
1311         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1312         (Manager._run_tests):
1313         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1314         (MeteredStream.flush):
1315         * Scripts/webkitpy/layout_tests/views/printing.py:
1316         (Printer._write):
1317         (Printer):
1318         (Printer.flush):
1319
1320 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
1321
1322         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
1323         https://bugs.webkit.org/show_bug.cgi?id=89228
1324
1325         Reviewed by Tony Chang.
1326
1327         * DumpRenderTree/chromium/LayoutTestController.cpp:
1328         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1329
1330 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
1331
1332         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
1333         https://bugs.webkit.org/show_bug.cgi?id=89226
1334
1335         Reviewed by Martin Robinson.
1336
1337         Implement increment() and decrement() functions in term of the AtkValue interface,
1338         instead of using DumpRenderTreeSupportGtk helper class.
1339
1340         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1341         (AccessibilityUIElement::intValue):
1342         (AccessibilityUIElement::minValue):
1343         (AccessibilityUIElement::maxValue):
1344         (alterCurrentValue):
1345         (AccessibilityUIElement::increment):
1346         (AccessibilityUIElement::decrement):
1347
1348 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
1349
1350         garden-o-matic 'Results' panel is broken for the Apple platform
1351         https://bugs.webkit.org/show_bug.cgi?id=89310
1352
1353         Reviewed by Adam Barth.
1354         
1355         For platforms that don't use accumulated build directories on the server,
1356         carry along buildLocation data with buildInfo, so that we know where to
1357         look for the test results files for a given test.
1358         
1359         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
1360         it now returns an array of objects with buildNumber, revision and url info.
1361         
1362         Fixed results.fetchResultsURLs() to use this data to find results.
1363         
1364         Fixed the results display to not scroll when you click on a test to see the results.
1365         Made the h3s look less ugly
1366         
1367         Don't try to show the flakiness dashboard for the Apple platform.
1368
1369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1375         (.results-view .top-panel):
1376         (.results-view h3):
1377
1378 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
1379
1380         Make garden-o-matic work for the Apple Mac port
1381         https://bugs.webkit.org/show_bug.cgi?id=84642
1382
1383         Reviewed by Adam Barth.
1384         
1385         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
1386         educating the scripts in various ways:
1387         * Wrap up platform-related differences in config.kPlatforms[]
1388         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
1389         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
1390           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
1391           recent build with valid results.
1392         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
1393           try to test a build that has already been deleted). Make walkHistory() more robust here.
1394         * webkit.org uses differently named test result directories, that include the SVN revision as
1395           well as the build number. That forces us to fetch more build info before we can get the
1396           result directory URL.
1397         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
1398           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
1399           dirs.
1400         * Various URLs differ between webkit.org and chromium.org
1401         * Better UI for the failures info, so that some info is visible even when not hovered.
1402
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
1405         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1419         (ol.notifications>li table.failures):
1420         (ol.notifications>li:hover table.failures):
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1422         (#onebar #platform-picker):
1423         * Scripts/webkitpy/layout_tests/port/builders.py:
1424
1425 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1426
1427         Unreviewed, rolling out r120536.
1428         http://trac.webkit.org/changeset/120536
1429         https://bugs.webkit.org/show_bug.cgi?id=89296
1430
1431         Does not compile on chromium-linux (Requested by abarth on
1432         #webkit).
1433
1434         * DumpRenderTree/chromium/LayoutTestController.cpp:
1435         (LayoutTestController::reset):
1436         (LayoutTestController::setTextSubpixelPositioning):
1437         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1438
1439 2012-06-16  Adam Barth  <abarth@webkit.org>
1440
1441         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
1442         https://bugs.webkit.org/show_bug.cgi?id=89274
1443
1444         Reviewed by Levi Weintraub.
1445
1446         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
1447         Note: The WebKit2 API that setBackingScaleFactor exercises is still
1448         tested by API-level tests.
1449
1450         * DumpRenderTree/LayoutTestController.cpp:
1451         (LayoutTestController::staticFunctions):
1452         * DumpRenderTree/LayoutTestController.h:
1453         (LayoutTestController):
1454         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1455         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1456         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1457         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1458         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1459         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1460         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1461         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1462         (WTR::InjectedBundle::didReceiveMessage):
1463         (WTR):
1464         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1465         (InjectedBundle):
1466         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1467         (WTR):
1468         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1469         (LayoutTestController):
1470         * WebKitTestRunner/TestInvocation.cpp:
1471         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1472
1473 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
1474
1475         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1476         https://bugs.webkit.org/show_bug.cgi?id=89228
1477
1478         Reviewed by Tony Chang.
1479
1480         * DumpRenderTree/chromium/LayoutTestController.cpp:
1481         (LayoutTestController::reset):
1482         (LayoutTestController::setTextSubpixelPositioning):
1483         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1484
1485 2012-06-15  Adam Barth  <abarth@webkit.org>
1486
1487         garden-o-matic's results.js should use RequestTracker
1488         https://bugs.webkit.org/show_bug.cgi?id=89257
1489
1490         Reviewed by Dimitri Glazkov.
1491
1492         We wrote results.js before we recognized the RequestTracker pattern.
1493         This patch replaces the manual implementations of RequestTracker with
1494         the real deal.
1495
1496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1497
1498 2012-06-15  Darin Adler  <darin@apple.com>
1499
1500         * Scripts/webkitpy/bindings: Added property svn:ignore.
1501
1502 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1503
1504         Unreviewed, rolling out r120511.
1505         http://trac.webkit.org/changeset/120511
1506         https://bugs.webkit.org/show_bug.cgi?id=89255
1507
1508         Breaks at least Android builder (Requested by wangxianzhu on
1509         #webkit).
1510
1511         * DumpRenderTree/chromium/LayoutTestController.cpp:
1512         (LayoutTestController::reset):
1513         (LayoutTestController::setTextSubpixelPositioning):
1514
1515 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1516
1517         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
1518         https://bugs.webkit.org/show_bug.cgi?id=89228
1519
1520         Reviewed by Tony Chang.
1521
1522         * DumpRenderTree/chromium/LayoutTestController.cpp:
1523         (LayoutTestController::reset):
1524         (LayoutTestController::setTextSubpixelPositioning):
1525
1526 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1527
1528         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1529         https://bugs.webkit.org/show_bug.cgi?id=89135
1530
1531         Re-land change in r120370 with fix in
1532         PortFactory.get_from_builder_name() that changes BuilderOptions
1533         to an actual optparse.Values object.
1534
1535         * Scripts/webkitpy/layout_tests/port/base.py:
1536         (Port.__init__):
1537         (Port.get_option):
1538         (Port.set_option_default):
1539         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1540         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1541         * Scripts/webkitpy/layout_tests/port/factory.py:
1542         (_builder_options):
1543         (PortFactory.get_from_builder_name):
1544         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1545         (FactoryTest.test_get_from_builder_name):
1546         * Scripts/webkitpy/style/checkers/test_expectations.py:
1547         (TestExpectationsChecker._determine_port_from_expectations_path):
1548         * Scripts/webkitpy/tool/mocktool.py:
1549         (MockOptions.ensure_value):
1550
1551 2012-06-15  Bill Budge  <bbudge@chromium.org>
1552
1553         Add bbudge@chromium.org to committers.py
1554
1555         Unreviewed.
1556
1557         * Scripts/webkitpy/common/config/committers.py:
1558
1559 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1560
1561         Unreviewed style fix after r120351.
1562
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1564         (body.interface):
1565
1566 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1567
1568         master.cfg cleanup, remove unnecessary workaround
1569         https://bugs.webkit.org/show_bug.cgi?id=88994
1570
1571         Reviewed by Lucas Forschler.
1572
1573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1574         (loadBuilderConfig):
1575
1576 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
1577
1578         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1579         https://bugs.webkit.org/show_bug.cgi?id=88581
1580
1581         Reviewed by Adam Barth.
1582
1583         Make sure we only optimize the suffixes we rebaselined during
1584         rebaseline-expectations, and not all suffixes for a test.
1585         While optimizing is somewhere between harmless and good, it's also confusing :)
1586
1587         * Scripts/webkitpy/tool/commands/rebaseline.py:
1588         (RebaselineExpectations._rebaseline_port):
1589         (RebaselineExpectations.execute):
1590         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1591
1592 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1593
1594         Update builder.html template for newer buildmaster
1595         https://bugs.webkit.org/show_bug.cgi?id=89207
1596
1597         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
1598
1599         Reviewed by Zoltan Herczeg.
1600
1601         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
1602
1603 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1604
1605         Add ForceScheduler to build.webkit.org
1606         https://bugs.webkit.org/show_bug.cgi?id=88982
1607
1608         Reviewed by Ryosuke Niwa.
1609
1610         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1611         (loadBuilderConfig):
1612
1613 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1614
1615         [EFL][WK2] Add title support to Ewk_View
1616         https://bugs.webkit.org/show_bug.cgi?id=89095
1617
1618         Reviewed by Kenneth Rohde Christiansen.
1619
1620         Update the MiniBrowser so it listens for the "title,change"
1621         signal on the view and keeps the browser window title
1622         up-to-date.
1623
1624         * MiniBrowser/efl/main.c:
1625         (on_title_changed):
1626         (browserCreate):
1627
1628 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1629
1630         [WK2][EFL] Implement navigation back/forward in Ewk_View
1631         https://bugs.webkit.org/show_bug.cgi?id=89173
1632
1633         Reviewed by Kenneth Rohde Christiansen.
1634
1635         Implement navigation back / forward in MiniBrowser. Use
1636         'F1' to navigate back and 'F2' to navigate forward.
1637
1638         * MiniBrowser/efl/main.c:
1639         (on_key_down):
1640
1641 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1642
1643         [EFL] EFL's LayoutTestController does not support titleTextDirection
1644         https://bugs.webkit.org/show_bug.cgi?id=86475
1645
1646         Reviewed by Hajime Morita.
1647
1648         Add titleTextDirection getter and setter to LayoutTestController and
1649         expose its value to JavaScript.
1650         Update the titleTextDirection value from EFL's "title,changed"
1651         callback in DumpRenderTree.
1652
1653         * DumpRenderTree/LayoutTestController.cpp:
1654         (LayoutTestController::LayoutTestController):
1655         (getTitleTextDirectionCallback):
1656         (LayoutTestController::staticValues):
1657         * DumpRenderTree/LayoutTestController.h:
1658         (LayoutTestController::titleTextDirection):
1659         (LayoutTestController::setTitleTextDirection):
1660         (LayoutTestController):
1661         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1662         (DumpRenderTreeChrome::onFrameTitleChanged):
1663
1664 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
1665
1666         [EFL][WK2] Implement reload / stop in Ewk_View
1667         https://bugs.webkit.org/show_bug.cgi?id=89168
1668
1669         Reviewed by Kenneth Rohde Christiansen.
1670
1671         Implement view reload / stop loading in MiniBrowser.
1672         Use 'F5' for reload and 'F6' for stopping the load.
1673
1674         * MiniBrowser/efl/main.c:
1675         (on_key_down):
1676         (browserCreate):
1677
1678 2012-06-15  Hironori Bono  <hbono@chromium.org>
1679
1680         Allow platforms to choose whether to remove markers on editing
1681         https://bugs.webkit.org/show_bug.cgi?id=88838
1682
1683         Reviewed by Hajime Morita.
1684
1685         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
1686         run grammar tests.
1687
1688         * DumpRenderTree/chromium/WebViewHost.cpp:
1689         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
1690         * DumpRenderTree/chromium/WebViewHost.h:
1691         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
1692
1693 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1694
1695         Unreviewed, rolling out r120370.
1696         http://trac.webkit.org/changeset/120370
1697         https://bugs.webkit.org/show_bug.cgi?id=89183
1698
1699         Broke webkit-patch rebaseline (Requested by zdobersek on
1700         #webkit).
1701
1702         * Scripts/webkitpy/layout_tests/port/base.py:
1703         (DummyOptions):
1704         (DummyOptions.__init__):
1705         (DummyOptions.__init__.this):
1706         (Port.__init__):
1707         (Port.get_option):
1708         (Port.set_option_default):
1709         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1710         (ChromiumWinTest.RegisterCygwinOption):
1711         (ChromiumWinTest.RegisterCygwinOption.__init__):
1712         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1713         * Scripts/webkitpy/style/checkers/test_expectations.py:
1714         (TestExpectationsChecker._determine_port_from_expectations_path):
1715         * Scripts/webkitpy/tool/mocktool.py:
1716         (MockOptions.update):
1717
1718 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1719
1720         [Chromium-Android] Initialize font rendering in DumpRenderTree
1721         https://bugs.webkit.org/show_bug.cgi?id=89133
1722
1723         Reviewed by Adam Barth.
1724
1725         * DumpRenderTree/chromium/LayoutTestController.cpp:
1726         (LayoutTestController::reset):
1727         (LayoutTestController::setTextSubpixelPositioning):
1728         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1729         (platformInit):
1730
1731 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
1732
1733         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
1734         https://bugs.webkit.org/show_bug.cgi?id=88622
1735
1736         Reviewed by Philippe Normand.
1737
1738         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
1739         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1740
1741 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
1742
1743         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
1744         https://bugs.webkit.org/show_bug.cgi?id=89124
1745
1746         Reviewed by Dirk Pranke.
1747
1748         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1749         (ChromiumAndroidDriver._start):
1750         (ChromiumAndroidDriver):
1751         (ChromiumAndroidDriver._start_once):
1752
1753 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
1754
1755         Update webpagereplay to 1.1.2
1756         https://bugs.webkit.org/show_bug.cgi?id=89118
1757
1758         This includes the following patch which avoids pkg_resources import errors:
1759         http://code.google.com/p/web-page-replay/source/detail?r=476
1760
1761         Reviewed by Dirk Pranke.
1762
1763         * Scripts/webkitpy/thirdparty/__init__.py:
1764         (AutoinstallImportHook._install_webpagereplay):
1765
1766 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
1767
1768         Get rid of FAIL test expectation
1769         https://bugs.webkit.org/show_bug.cgi?id=89137
1770
1771         Reviewed by Dirk Pranke.
1772
1773         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1774         (ResultSummaryTest.test_summarized_results_wontfix):
1775         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1776         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1777         (JSONLayoutResultsGenerator):
1778         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1779         (result_was_expected):
1780         (suffixes_for_expectations):
1781         (TestExpectationsModel._add_test):
1782         (TestExpectations):
1783         (TestExpectations.get_rebaselining_failures):
1784         (TestExpectations.remove_configuration_from_test):
1785         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1786         (FunctionsTest.test_result_was_expected):
1787         (FunctionsTest.test_suffixes_for_expectations):
1788         (TestExpectationSerializerTests.test_parsed_expectations_string):
1789         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1790         (test_test_expectations):
1791         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1792         (TestExpectationsTestCase.test_valid_expectations):
1793
1794 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1795
1796         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
1797         https://bugs.webkit.org/show_bug.cgi?id=89135
1798
1799         Reviewed by Ryosuke Niwa.
1800
1801         This patch is just some minor cleanup and simplification. There
1802         should be no functional changes here.
1803
1804         * Scripts/webkitpy/layout_tests/port/base.py:
1805         (Port.__init__):
1806         (Port.get_option):
1807         (Port.set_option_default):
1808         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1809         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1810         * Scripts/webkitpy/style/checkers/test_expectations.py:
1811         (TestExpectationsChecker._determine_port_from_expectations_path):
1812         * Scripts/webkitpy/tool/mocktool.py:
1813         (MockOptions.ensure_value):
1814
1815 2012-06-14  Ian Vollick  <vollick@chromium.org>
1816
1817         [chromium] Certain settings in CCSettings could be global
1818         https://bugs.webkit.org/show_bug.cgi?id=88384
1819
1820         Reviewed by James Robinson.
1821
1822         * DumpRenderTree/chromium/TestShell.cpp:
1823         (TestShell::TestShell):
1824         (TestShell::resetWebSettings):
1825         (TestShell::setPerTilePaintingEnabled):
1826         * DumpRenderTree/chromium/TestShell.h:
1827         (TestShell):
1828         * DumpRenderTree/chromium/WebPreferences.cpp:
1829         (WebPreferences::reset):
1830         (WebPreferences::applyTo):
1831         * DumpRenderTree/chromium/WebPreferences.h:
1832         (WebPreferences):
1833
1834 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1835
1836         Unreviewed, rolling out r120352.
1837         http://trac.webkit.org/changeset/120352
1838         https://bugs.webkit.org/show_bug.cgi?id=89120
1839
1840         It seems something is still wrong with it :/ (Requested by
1841         Ossy on #webkit).
1842
1843         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1844         (Factory.__init__):
1845         (BuildFactory.__init__):
1846         (TestFactory.__init__):
1847         (BuildAndTestFactory.__init__):
1848         (BuildAndPerfTestFactory.__init__):
1849         (BuildAndPerfTestWebKit2Factory.__init__):
1850         (DownloadAndPerfTestFactory.__init__):
1851         (DownloadAndPerfTestWebKit2Factory.__init__):
1852
1853 2012-06-14  Jia Pu  <jpu@apple.com>
1854
1855         Mark text with text alternative with blue underline.
1856         https://bugs.webkit.org/show_bug.cgi?id=83047
1857
1858         Reviewed by NOBODY Enrica Casucci.
1859
1860         * DumpRenderTree/mac/TextInputController.m:
1861         (+[TextInputController isSelectorExcludedFromWebScript:]):
1862         (+[TextInputController webScriptNameForSelector:]):
1863         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
1864
1865 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1866
1867         Unreviewed, rolling out r120353.
1868         http://trac.webkit.org/changeset/120353
1869         https://bugs.webkit.org/show_bug.cgi?id=89119
1870
1871         It seems we still need this workaround (Requested by Ossy on
1872         #webkit).
1873
1874         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1875         (loadBuilderConfig):
1876
1877 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1878
1879         master.cfg cleanup, remove unnecessary workaround
1880         https://bugs.webkit.org/show_bug.cgi?id=88994
1881
1882         Reviewed by Lucas Forschler.
1883
1884         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1885         (loadBuilderConfig):
1886
1887 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1888
1889         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
1890         https://bugs.webkit.org/show_bug.cgi?id=89001
1891
1892         Reviewed by Lucas Forschler.
1893
1894         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1895         (Factory.__init__):
1896         (BuildFactory.__init__):
1897         (TestFactory.__init__):
1898         (BuildAndTestFactory.__init__):
1899         (BuildAndPerfTestFactory.__init__):
1900         (BuildAndPerfTestWebKit2Factory.__init__):
1901         (DownloadAndPerfTestFactory.__init__):
1902         (DownloadAndPerfTestWebKit2Factory.__init__):
1903
1904 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
1905
1906         Unhide login form on the build.webkit.org
1907         https://bugs.webkit.org/show_bug.cgi?id=88981
1908
1909         Reviewed by Lucas Forschler.
1910
1911         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1912
1913 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
1914
1915         [Gtk] Add support in DumpRenderTree for tracking repaints
1916         https://bugs.webkit.org/show_bug.cgi?id=87658
1917
1918         Reviewed by Martin Robinson.
1919
1920         Reimplement the displayWebView method in DumpRenderTree - force a
1921         repaint before starting tracking repaints and resetting them.
1922
1923         When gathering pixel output from a web view, if tracking repaints,
1924         paint an overlay over the output with the overlay being clear in the
1925         areas where the repaints occurred.
1926
1927         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1928         (displayWebView):
1929         (resetDefaultsToConsistentValues):
1930         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1931         (paintOverlay):
1932         (fillRepaintOverlayIntoContext):
1933         (createBitmapContextFromWebView):
1934
1935 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1936
1937         new-run-webkit-tests doesn't find similar platform tests for a keyword
1938         https://bugs.webkit.org/show_bug.cgi?id=37956
1939
1940         Reviewed by Ryosuke Niwa.
1941
1942         This patches adds support for NRWT so that if you type
1943         "new-run-webkit-tests foo" it will run all the tests in foo as
1944         well as platform/foo for all of the platforms that are normally
1945         searched (this only applies to directories, not to individual tests).
1946
1947         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1948         (Manager.collect_tests):
1949         * Scripts/webkitpy/layout_tests/port/base.py:
1950         (Port.tests):
1951         (Port):
1952         (Port._expanded_paths):
1953         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1954         (MainTest.test_no_http_tests):
1955         (MainTest):
1956         (MainTest.test_platform_tests_are_found):
1957
1958 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
1959
1960         NRWT should honor --skipped=[default|ignore|only], like ORWT does
1961         https://bugs.webkit.org/show_bug.cgi?id=66308
1962
1963         Reviewed by Ryosuke Niwa.
1964
1965         This patch adds support for ORWT's --skipped=(default|ignore|only)
1966         flag and cleans up the interaction between that and --ignore.
1967
1968         Individual tests (but not directories) explicitly listed on the
1969         command line will always be run regardless of what is passed
1970         for --skipped and --ignore.
1971
1972         This patch also changes the "found" and "running" log messages
1973         since it wasn't clear how the skipped tests were included in those numbers.
1974
1975         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1976         (Manager.__init__):
1977         (Manager.collect_tests):
1978         (Manager.prepare_lists_and_print_output):
1979         * Scripts/webkitpy/layout_tests/port/test.py:
1980         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1981         (_set_up_derived_options):
1982         (parse_args):
1983         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1984         (MainTest.test_ignore_flag):
1985         (MainTest):
1986         (MainTest.test_skipped_flag):
1987
1988 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
1989
1990         new-run-webkit-websocketserver must handle TLS related arguments
1991         https://bugs.webkit.org/show_bug.cgi?id=89079
1992
1993         Reviewed by Dirk Pranke.
1994
1995         PyWebSocket class must accept private_key, certificate, and
1996         ca_certificate arguments and pass them to launching pywebsocket.
1997         Also add ca_certificate handling to new-run-webkit-websocketserver.
1998
1999         * Scripts/new-run-webkit-websocketserver:
2000         (main):
2001         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2002         (PyWebSocket.__init__):
2003         (PyWebSocket._prepare_config):
2004
2005 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2006
2007         Unreviewed. Update my email.
2008
2009         * Scripts/webkitpy/common/config/committers.py:
2010
2011 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
2012
2013         Update pywebsocket to 0.7.6 from 0.7.4
2014         https://bugs.webkit.org/show_bug.cgi?id=88975
2015
2016         Reviewed by Kent Tamura.
2017
2018         This new version of pywebsocket introduce following features.
2019          - Allow handlers to send a close frame with empty body in response of
2020              a client initiated closing handshake
2021          - Implement perframe compression extension
2022          - Support client certificate authentication
2023
2024         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
2025         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2026         (_create_control_frame):
2027         (Stream._receive_frame):
2028         (Stream.send_message):
2029         (Stream.receive_message):
2030         (Stream._send_closing_handshake):
2031         (Stream.close_connection):
2032         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2033         (ExtensionParsingException):
2034         (ExtensionParsingException.__init__):
2035         (_parse_extension_param):
2036         (_parse_extension):
2037         (parse_extensions):
2038         (format_extension):
2039         (format_extensions):
2040         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2041         (_parse_compression_method):
2042         (_create_accepted_method_desc):
2043         (PerFrameCompressionExtensionProcessor):
2044         (PerFrameCompressionExtensionProcessor.__init__):
2045         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
2046         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
2047         (PerFrameCompressionExtensionProcessor.get_extension_response):
2048         (PerFrameCompressionExtensionProcessor.setup_stream_options):
2049         (PerFrameCompressionExtensionProcessor.get_compression_processor):
2050         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2051         (parse_token_list):
2052         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2053         (Handshaker._parse_extensions):
2054         (Handshaker._send_handshake):
2055         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2056         (WebSocketServer._create_sockets):
2057         (_get_logger_from_class):
2058         (_configure_logging):
2059         (_build_option_parser):
2060         (_main.if):
2061         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2062         (RepeatedXorMasker.mask):
2063
2064 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
2065
2066         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
2067
2068         Reviewed by Noam Rosenthal.
2069
2070         * qmake/mkspecs/features/features.prf:
2071
2072 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
2073
2074         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
2075         https://bugs.webkit.org/show_bug.cgi?id=88399
2076
2077         Reviewed by Kenneth Rohde Christiansen.
2078
2079         Update initialization of WKPageLoaderClient.
2080
2081         * MiniBrowser/mac/BrowserWindowController.m:
2082         (-[BrowserWindowController awakeFromNib]):
2083         * WebKitTestRunner/TestController.cpp:
2084         (WTR::TestController::initialize):
2085
2086 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2087
2088         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
2089         https://bugs.webkit.org/show_bug.cgi?id=84577
2090
2091         Reviewed by Ryosuke Niwa.
2092
2093         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
2094         LayoutTestController.
2095
2096         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2097         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2098
2099 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2100
2101         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2102         https://bugs.webkit.org/show_bug.cgi?id=88340
2103
2104         Reviewed by Kenneth Rohde Christiansen.
2105
2106         Update initialization of WKPageLoaderClient.
2107
2108         * MiniBrowser/mac/BrowserWindowController.m:
2109         (-[BrowserWindowController awakeFromNib]):
2110         * WebKitTestRunner/TestController.cpp:
2111         (WTR::TestController::initialize):
2112
2113 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2114
2115         Unreviewed, rolling out r120268.
2116         http://trac.webkit.org/changeset/120268
2117         https://bugs.webkit.org/show_bug.cgi?id=89060
2118
2119         WebCompositor::setPerTilePaintingEnabled hits an assertion in
2120         DEBUG (Requested by dominicc|work on #webkit).
2121
2122         * DumpRenderTree/chromium/WebPreferences.cpp:
2123         (WebPreferences::applyTo):
2124
2125 2012-06-13  Tim Horton  <timothy_horton@apple.com>
2126
2127         REGRESSION (r120252): run-webkit-tests on Mac fails
2128         https://bugs.webkit.org/show_bug.cgi?id=89057
2129
2130         Reviewed by Dan Bernstein.
2131
2132         get_option will happily return None (the default only kicks in if
2133         the option is actually *not set*). We should instead check get_option's
2134         return value and default to "x86_64" architecture ourselves.
2135
2136         * Scripts/webkitpy/layout_tests/port/mac.py:
2137         (MacPort.__init__):
2138
2139 2012-06-13  Ian Vollick  <vollick@chromium.org>
2140
2141         [chromium] Certain settings in CCSettings could be global
2142         https://bugs.webkit.org/show_bug.cgi?id=88384
2143
2144         Reviewed by James Robinson.
2145
2146         * DumpRenderTree/chromium/WebPreferences.cpp:
2147         (WebPreferences::applyTo):
2148
2149 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2150
2151         new-run-webkit-tests does not support --32-bit like ORWT did
2152         https://bugs.webkit.org/show_bug.cgi?id=71634
2153
2154         Reviewed by Ojan Vafai.
2155
2156         This patch adds support for 32-bit apple mac builds, adding the
2157         --32-bit flag for compatibility with ORWT and fixing the port
2158         architecture() definition to actually return the correct values.
2159
2160         * Scripts/webkitpy/layout_tests/port/apple.py:
2161         (ApplePort._generate_all_test_configurations):
2162         * Scripts/webkitpy/layout_tests/port/factory.py:
2163         (port_options):
2164         * Scripts/webkitpy/layout_tests/port/mac.py:
2165         (MacPort):
2166         (MacPort.__init__):
2167         (MacPort._build_driver_flags):
2168         (MacPort.setup_environ_for_server):
2169         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2170         (test_sample_process_throws_exception):
2171         (test_32bit):
2172         (test_32bit.run_script):
2173         (test_64bit):
2174         (test_64bit.run_script):
2175         * Scripts/webkitpy/layout_tests/port/webkit.py:
2176         (WebKitPort._build_driver):
2177         (WebKitPort._build_driver_flags):
2178         * Scripts/webkitpy/layout_tests/port/win.py:
2179         (WinPort):
2180
2181 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2182
2183         Remove webkitpy code to support legacy test_expectations.txt files
2184         https://bugs.webkit.org/show_bug.cgi?id=89038
2185
2186         Reviewed by Dirk Pranke.
2187
2188         * Scripts/webkitpy/layout_tests/port/base.py:
2189         (Port.path_to_test_expectations_file):
2190         (Port.expectations_dict):
2191         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2192         (PortTest.test_uses_test_expectations_file):
2193         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2194         (WebKitPortTest.test_path_to_test_expectations_file):
2195         (test_test_expectations):
2196         * Scripts/webkitpy/style/checker.py:
2197         (CheckerDispatcher.should_skip_without_warning):
2198         (CheckerDispatcher._create_checker):
2199         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2200         (TestExpectationsTestCase._expect_port_for_expectations_path):
2201         * Scripts/webkitpy/tool/steps/commit.py:
2202         (Commit._check_test_expectations):
2203         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2204         (CommitTest.test_check_test_expectations):
2205
2206 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2207
2208         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
2209         https://bugs.webkit.org/show_bug.cgi?id=88948
2210
2211         Reviewed by Ojan Vafai.
2212
2213         In the final patch of this run, we remove the
2214         test_expectations() and test_expectation_overrides() methods
2215         from the Port class - callers must now use just
2216         expectations_dict().
2217
2218         Note that support for the cascade in new-run-webkit-tests is
2219         complete but only Chromium uses it; webkit-patch
2220         rebaseline-expectations still does not support updating entries
2221         in any file other than the first expectations file, however.
2222
2223         * Scripts/webkitpy/layout_tests/port/base.py:
2224         (Port.path_to_test_expectations_file):
2225         (Port.uses_test_expectations_file):
2226         (Port.expectations_files):
2227         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2228         (PortTest.test_additional_expectations):
2229         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2230         (ChromiumPortTest.test_expectations_files):
2231         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2232         (TestGoogleChromePort.test_get_google_chrome_port):
2233         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2234         (test_test_expectations):
2235         (test_legacy_test_expectations):
2236
2237 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2238
2239         nrwt: implement the actual cascade of TestExpectations
2240         https://bugs.webkit.org/show_bug.cgi?id=88947
2241
2242         Reviewed by Ojan Vafai.
2243
2244         This change implements the actual cascade by removing the
2245         concept of 'overrides' from the TestExpectations object and
2246         parsing each file separately.
2247
2248         There is an actual semantic change in this patch, in that
2249         setting an expectation on a directory in one file will override
2250         the expectations on any individual tests set in prior files. The
2251         test_overrides__directory() unit test verifies this.
2252
2253         Otherwise, this patch mostly consists of deleting code :).
2254
2255         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2256         (TestExpectationsModel.__init__):
2257         (TestExpectationsModel.add_expectation_line):
2258         (TestExpectationsModel._add_test):
2259         (TestExpectationsModel._already_seen_better_match):
2260         (TestExpectations.__init__):
2261         (TestExpectations._add_expectations):
2262         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2263         (test_overrides__directory):
2264
2265 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2266
2267         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
2268         https://bugs.webkit.org/show_bug.cgi?id=88946
2269
2270         Reviewed by Ojan Vafai.
2271
2272         In preparation for fully supporting cascading expectations files
2273         and removing the 'overrides' concept.
2274
2275         There should be no functional changes in this patch.
2276
2277         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2278         (ManagerTest.test_update_summary_with_result):
2279         (ResultSummaryTest.get_result_summary):
2280         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2281         (TestExpectations.__init__):
2282         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2283         (parse_exp):
2284         (SkippedTests.check):
2285         (RemoveConfigurationsTest.test_remove):
2286         (test_remove_line):
2287         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2288         (LintTest.test_all_configurations.FakePort.__init__):
2289         (LintTest.test_all_configurations.FakePort.expectations_dict):
2290         (LintTest.test_lint_test_files__errors):
2291         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2292         (test_overrides_are_included_correctly):
2293
2294 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2295
2296         webkitpy: rework the TestExpectations style checker in preparation for the cascade
2297         https://bugs.webkit.org/show_bug.cgi?id=88945
2298
2299         Reviewed by Ojan Vafai.
2300
2301         This patch changes the style checker to call the
2302         TestExpectations parser directly and be oblivious as to what the
2303         port's actual expectations are.
2304
2305         * Scripts/webkitpy/style/checkers/test_expectations.py:
2306         (TestExpectationsChecker.__init__):
2307         (TestExpectationsChecker.check_test_expectations):
2308
2309 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2310
2311         nrwt: restructure the port classes to handle multiple expectations files
2312         https://bugs.webkit.org/show_bug.cgi?id=88944
2313
2314         Reviewed by Ojan Vafai.
2315
2316         This patch restructures the Port classes so that each port
2317         returns a list of TestExpectations files to be used (in a new, public,
2318         expectations_files() method), and the base implementation rolls them
2319         up into the ordered expectations_dict(), which becomes a public
2320         method.
2321
2322         port.path_to_test_expectations_file(), port.test_expectations(),
2323         and port.test_expectations_overrides() are then reimplemented as
2324         wrappers around port.expectations_dict().
2325         port.test_expectations() and port.test_expectations_overrides()
2326         will eventually be removed when the cascade is fully completed,
2327         and port.path_to_test_expectations_file() will be removed when
2328         the rebaselining tool supports the cascade
2329         (expectations_files() may also become private at that point).
2330
2331         There should be no functional changes in this patch, but a bunch
2332         of custom logic gets deleted!
2333
2334         * Scripts/webkitpy/layout_tests/port/base.py:
2335         (Port.expectations_dict):
2336         (Port):
2337         (Port.expectations_files):
2338         (Port.test_expectations):
2339         (Port.test_expectations_overrides):
2340         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2341         (PortTest.test_additional_expectations):
2342         (PortTest.test_uses_test_expectations_file):
2343         * Scripts/webkitpy/layout_tests/port/chromium.py:
2344         (ChromiumPort.all_baseline_variants):
2345         (ChromiumPort.expectations_files):
2346         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2347         (ChromiumPortTest.test_overrides_and_builder_names):
2348         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2349         (_expectations_files):
2350         (GoogleChromeLinux32Port.expectations_files):
2351         (GoogleChromeLinux64Port.expectations_files):
2352         (GoogleChromeMacPort.expectations_files):
2353         (GoogleChromeWinPort.expectations_files):
2354         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2355         (TestGoogleChromePort._verify_expectations_overrides):
2356         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2357         (PortTestCase.test_expectations_ordering):
2358         * Scripts/webkitpy/layout_tests/port/webkit.py:
2359         (WebKitPort._skipped_file_search_paths):
2360         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2361         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2362         (test_rebaseline_updates_expectations_file):
2363         (test_rebaseline_does_not_include_overrides):
2364         (test_rebaseline_expectations):
2365         (test_overrides_are_included_correctly):
2366
2367 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
2368
2369         [WinCairo] Update URL of WinCairoRequirements.zip download.
2370         https://bugs.webkit.org/show_bug.cgi?id=89009
2371
2372         Reviewed by Martin Robinson.
2373
2374         * Tools/Scripts/update-webkit-dependency: Put fallback code
2375         to download a "last update" time from servers that don't properly
2376         report Last-Modified in their HTTP header.
2377         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
2378         for the WinCairo build requirements bundle.
2379
2380 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
2381
2382         nrwt: preliminary cleanup before supporting cascading expectations files
2383         https://bugs.webkit.org/show_bug.cgi?id=88942
2384
2385         Reviewed by Ojan Vafai.
2386
2387         This change just prepares the TestExpectations parser to get filenames
2388         along with the expectations, and improves the warning messages so that
2389         they contain the filenames along with the line numbers.
2390
2391         There should be no functional changes in this patch.
2392
2393         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2394         (TestExpectationEditorTests.make_parsed_expectation_lines):
2395         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2396         (TestExpectationParser.parse):
2397         (TestExpectationParser.expectation_for_skipped_test):
2398         (TestExpectationParser._tokenize):
2399         (TestExpectationParser._tokenize_list):
2400         (TestExpectationLine):
2401         (TestExpectationsModel.__init__):
2402         (TestExpectationsModel._already_seen_better_match):
2403         (TestExpectations.__init__):
2404         (TestExpectations._shorten_filename):
2405         (TestExpectations._report_warnings):
2406         (TestExpectations._add_skipped_tests):
2407         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2408         (TestExpectationParserTests._tokenize):
2409         (TestExpectationParserTests.test_tokenize_blank):
2410         (TestExpectationParserTests.test_tokenize_missing_colon):
2411         (TestExpectationParserTests.test_tokenize_extra_colon):
2412         (TestExpectationParserTests.test_tokenize_empty_comment):
2413         (TestExpectationParserTests.test_tokenize_comment):
2414         (TestExpectationParserTests.test_tokenize_missing_equal):
2415         (TestExpectationParserTests.test_tokenize_extra_equal):
2416         (TestExpectationParserTests.test_tokenize_valid):
2417         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2418         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2419         (TestExpectationParserTests.test_parse_empty_string):
2420         (TestExpectationSerializerTests._tokenize):
2421         (TestExpectationSerializerTests.assert_round_trip):
2422         (TestExpectationSerializerTests.assert_list_round_trip):
2423         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2424         (GardeningExpectationsUpdater.update_expectations):
2425
2426 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
2427
2428         [Gtk] Enable link prefetch support in the developer builds
2429         https://bugs.webkit.org/show_bug.cgi?id=89011
2430
2431         Reviewed by Martin Robinson.
2432
2433         Enable the link prefetch support for Gtk by default in developer
2434         builds.
2435
2436         * Scripts/webkitperl/FeatureList.pm:
2437
2438 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
2439
2440         Update buildbot master in autoinstaller to match build.webkit.org
2441         https://bugs.webkit.org/show_bug.cgi?id=88992
2442
2443         Reviewed by Adam Barth.
2444
2445         * Scripts/webkitpy/thirdparty/__init__.py:
2446         (AutoinstallImportHook._install_buildbot):
2447
2448 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2449
2450         Unreviewed, rolling out r120209.
2451         http://trac.webkit.org/changeset/120209
2452         https://bugs.webkit.org/show_bug.cgi?id=89007
2453
2454         Broke the WebKit2 mac build. (Requested by andersca on
2455         #webkit).
2456
2457         * MiniBrowser/mac/BrowserWindowController.m:
2458         (-[BrowserWindowController awakeFromNib]):
2459         * WebKitTestRunner/TestController.cpp:
2460         (WTR::TestController::initialize):
2461
2462 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
2463
2464         check-webkit-style needs to respect Qt API coding style
2465         https://bugs.webkit.org/show_bug.cgi?id=88995
2466
2467         Reviewed by Csaba Osztrogonác.
2468
2469         Add -whitespace/declaration exception to Qt API files.
2470
2471         * Scripts/webkitpy/style/checker.py:
2472
2473 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
2474
2475         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
2476         https://bugs.webkit.org/show_bug.cgi?id=88340
2477
2478         Reviewed by Kenneth Rohde Christiansen.
2479
2480         Update initialization of WKPageLoaderClient.
2481
2482         * MiniBrowser/mac/BrowserWindowController.m:
2483         (-[BrowserWindowController awakeFromNib]):
2484         * WebKitTestRunner/TestController.cpp:
2485         (WTR::TestController::initialize):
2486
2487 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2488
2489         [Qt] Handle multiple held buttons in touch mocking.
2490         https://bugs.webkit.org/show_bug.cgi?id=88865
2491
2492         Reviewed by Kenneth Rohde Christiansen.
2493
2494         Add handling for multiple held mouse-buttons in the appropiate places.
2495         To do this last-pos and start-pos are now also read from the last recorded
2496         touch-point instead from object-global variables.
2497
2498         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2499         (MiniBrowserApplication::notify):
2500         (MiniBrowserApplication::updateTouchPoint):
2501         * MiniBrowser/qt/MiniBrowserApplication.h:
2502         (MiniBrowserApplication):
2503
2504 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
2505
2506         [Qt] Make it possible to disable -Werror in production builds
2507
2508         Reviewed by Tor Arne Vestbø.
2509
2510         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
2511         something qt5.git's qtwebkit.pri will soon do.
2512
2513         * qmake/mkspecs/features/unix/default_post.prf:
2514
2515 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
2516
2517         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
2518         https://bugs.webkit.org/show_bug.cgi?id=85790
2519
2520         Reviewed by Gustavo Noronha Silva.
2521
2522         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
2523         code in webkitdirs.pm.
2524
2525         * Scripts/webkitdirs.pm:
2526         (jhbuildConfigurationChanged):
2527         (saveJhbuildMd5):
2528         (cleanJhbuild):
2529         (buildAutotoolsProject):
2530         (generateBuildSystemFromCMakeProject):
2531
2532 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
2533
2534         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
2535         https://bugs.webkit.org/show_bug.cgi?id=88763
2536
2537         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
2538         extension.
2539
2540         Reviewed by Simon Hausmann.
2541
2542         * qmake/config.tests/libzlib: Added.
2543         * qmake/config.tests/libzlib/libzlib.cpp: Added.
2544         (main):
2545         * qmake/config.tests/libzlib/libzlib.pro: Added.
2546         * qmake/mkspecs/features/features.prf:
2547         * qmake/sync.profile:
2548
2549 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
2550
2551         [BlackBerry] Enable MEDIA_STREAM by default
2552         https://bugs.webkit.org/show_bug.cgi?id=88849
2553
2554         Reviewed by Antonio Gomes.
2555
2556         * Scripts/webkitperl/FeatureList.pm:
2557
2558 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2559
2560         Prevent stderr output from messing up detection of build path
2561
2562         https://bugs.webkit.org/show_bug.cgi?id=88075
2563
2564         Warnings such as 'perl: warning: Setting locale failed' will otherwise
2565         end up as the build path when calling out to webkit-build-directory.
2566
2567         Reviewed by Ojan Vafai.
2568
2569         * Scripts/webkitpy/layout_tests/port/config.py:
2570         (Config.build_directory):
2571
2572 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
2573
2574         Update the builder name for Apple Lion builders.
2575
2576         * Scripts/webkitpy/layout_tests/port/builders.py:
2577
2578 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
2579
2580         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
2581         https://bugs.webkit.org/show_bug.cgi?id=88874
2582
2583         Reviewed by Simon Hausmann.
2584
2585         Rename main.cpp in QtTestBrowser because on Windows
2586         it conflicts with main.cpp from DumpRenderTree.
2587
2588         * QtTestBrowser/QtTestBrowser.pro:
2589         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
2590         (launcherMain):
2591         (LauncherApplication):
2592         (LauncherApplication::urls):
2593         (LauncherApplication::isRobotized):
2594         (LauncherApplication::robotTimeout):
2595         (LauncherApplication::robotExtraTime):
2596         (LauncherApplication::applyDefaultSettings):
2597         (LauncherApplication::LauncherApplication):
2598         (requiresGraphicsView):
2599         (LauncherApplication::handleUserOptions):
2600         (main):
2601
2602 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2603
2604         Wrap bot types inside ().
2605         https://bugs.webkit.org/show_bug.cgi?id=88893
2606         
2607         Reviewed by Stephanie Lewis.
2608
2609         * BuildSlaveSupport/build.webkit.org-config/config.json:
2610
2611 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2612
2613         [soup] Prevent setting or editing httpOnly cookies from JavaScript
2614         https://bugs.webkit.org/show_bug.cgi?id=88760
2615
2616         Reviewed by Gustavo Noronha Silva.
2617
2618         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
2619         to v2.33.2 for both GTK and EFL ports.
2620
2621         * efl/jhbuild.modules:
2622         * gtk/jhbuild.modules:
2623
2624 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2625
2626         [EFL] Enable SHADOW_DOM flag
2627         https://bugs.webkit.org/show_bug.cgi?id=87732
2628
2629         Reviewed by Kentaro Hara.
2630
2631         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2632         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
2633         SHADOW_DOM by default in DRT.
2634         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2635         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
2636         Chromium and Mac ports.
2637         (drtViewAdd):
2638         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
2639         at compile time for EFL port.
2640
2641 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2642
2643         WinLauncher should show loading errors
2644         https://bugs.webkit.org/show_bug.cgi?id=80760
2645
2646         Reviewed by Brent Fulgham.
2647
2648         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
2649         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2650         * WinLauncher/WinLauncher.h:
2651         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2652         (WinLauncherWebHost):
2653
2654 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
2655
2656         [EFL][WK2] Add MiniBrowserEfl.
2657         https://bugs.webkit.org/show_bug.cgi?id=61850
2658
2659         Reviewed by Chang Shu.
2660
2661         Implement MiniBrowser for EFL.
2662
2663         * CMakeLists.txt:
2664         * MiniBrowser/efl/CMakeLists.txt: Added.
2665         * MiniBrowser/efl/main.c: Added.
2666         (_MiniBrowser):
2667         (main_signal_exit):
2668         (on_ecore_evas_resize):
2669         (browserCreate):
2670         (main):
2671
2672 2012-06-12  Helder Correia  <helder.correia@nokia.com>
2673
2674         Unreviewed. Update my email address in committers.py.
2675
2676         * Scripts/webkitpy/common/config/committers.py:
2677
2678 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
2679
2680         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2681         https://bugs.webkit.org/show_bug.cgi?id=84707
2682
2683         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
2684         use_lib64 variable is preconfigured to True by jhbuild.
2685
2686         Reviewed by Dirk Pranke.
2687
2688         * efl/jhbuildrc:
2689
2690 2012-06-12  Dana Jansens  <danakj@chromium.org>
2691
2692         Add zlieber@chromium.org to contributors list
2693         https://bugs.webkit.org/show_bug.cgi?id=88904
2694
2695         Unreviewed.
2696
2697         * Scripts/webkitpy/common/config/committers.py:
2698
2699 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2700
2701         Rename Apple bots to a standard convention.
2702         https://bugs.webkit.org/show_bug.cgi?id=88893
2703         
2704         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
2705
2706         Reviewed by Simon Fraser.
2707
2708         * BuildSlaveSupport/build.webkit.org-config/config.json:
2709
2710 2012-06-12  Mike West  <mkwst@chromium.org>
2711
2712         Make document.documentURI readonly from JavaScript
2713         https://bugs.webkit.org/show_bug.cgi?id=65187
2714
2715         Reviewed by Alexey Proskuryakov.
2716
2717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2718         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
2719         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
2720         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
2721         (TestWebKitAPI):
2722         (TestWebKitAPI::TEST):
2723
2724 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2725
2726         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
2727         https://bugs.webkit.org/show_bug.cgi?id=88715
2728
2729         Reviewed by Noam Rosenthal.
2730
2731         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
2732
2733         * Scripts/webkitperl/FeatureList.pm:
2734
2735 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2736
2737         [Qt] Fix -Werror for the buildbots
2738         https://bugs.webkit.org/show_bug.cgi?id=88223
2739
2740         Rubber-stamped by Tor Arne Vestbø.
2741
2742         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
2743
2744         * qmake/mkspecs/features/unix/default_post.prf:
2745
2746 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
2747
2748         [REGRESSION][WTR] Build fail with werror after r120054
2749         https://bugs.webkit.org/show_bug.cgi?id=88862
2750
2751         Reviewed by Csaba Osztrogonác.
2752
2753         Some static helpers become unused after counterValueForElementById
2754         has moved to Internals. Let's remove them.
2755
2756         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2757         (WTR):
2758
2759 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2760
2761         [Qt] Slave losts cause build break on bots
2762         https://bugs.webkit.org/show_bug.cgi?id=38980
2763
2764         Minor fix after r59261.
2765
2766         Reviewed by Tor Arne Vestbø.
2767
2768         * Scripts/build-webkit:
2769         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
2770
2771 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2772
2773         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
2774         https://bugs.webkit.org/show_bug.cgi?id=84406
2775
2776         Reviewed by Hajime Morita.
2777
2778         Move the counterValueForElementById from LayoutTestCotroller to Internals and
2779         remove the old platform specific implementations as it exclusively tests WebCore functionality.
2780
2781         * DumpRenderTree/LayoutTestController.cpp:
2782         (LayoutTestController::staticFunctions):
2783         * DumpRenderTree/LayoutTestController.h:
2784         (LayoutTestController):
2785         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2786         * DumpRenderTree/chromium/LayoutTestController.cpp:
2787         (LayoutTestController::LayoutTestController):
2788         (LayoutTestController::setPOSIXLocale):
2789         * DumpRenderTree/chromium/LayoutTestController.h:
2790         (LayoutTestController):
2791         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2792         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2793         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2794         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2795         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2796         (LayoutTestController):
2797         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2798         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2799         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2800         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2801         (WTR):
2802         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2803         (LayoutTestController):
2804
2805 2012-06-11  Hans Wennborg  <hans@chromium.org>
2806
2807         Speech JavaScript API: Make SpeechRecognitionError an Event
2808         https://bugs.webkit.org/show_bug.cgi?id=88784
2809
2810         Reviewed by Adam Barth.
2811
2812         Make it possible to have MockWebSpeechRecognizer fire error events.
2813
2814         * DumpRenderTree/chromium/LayoutTestController.cpp:
2815         (LayoutTestController::LayoutTestController):
2816         (LayoutTestController::setMockSpeechRecognitionError):
2817         * DumpRenderTree/chromium/LayoutTestController.h:
2818         (LayoutTestController):
2819         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2820         (WebKit):
2821         (ErrorTask):
2822         (WebKit::ErrorTask::ErrorTask):
2823         (MockWebSpeechRecognizer::addMockResult):
2824         (MockWebSpeechRecognizer::setError):
2825         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2826         (MockWebSpeechRecognizer):
2827
2828 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2829
2830         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
2831         https://bugs.webkit.org/show_bug.cgi?id=88836
2832
2833         Reviewed by Dirk Pranke.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2837
2838 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
2839
2840         [EFL] Remove CMakeCache.txt before building
2841         https://bugs.webkit.org/show_bug.cgi?id=88717
2842
2843         Reviewed by Antonio Gomes.
2844
2845         Remove CMake cache file before every build to avoid using outdated
2846         build flags when new features get enabled. This will avoid unexpected
2847         failures on the bots due to outdated build flags.
2848
2849         * Scripts/webkitdirs.pm:
2850         (generateBuildSystemFromCMakeProject):
2851
2852 2012-06-11  Vincent Scheib  <scheib@chromium.org>
2853
2854         Add new Pointer Lock spec attribute webkitPointerLockElement.
2855         https://bugs.webkit.org/show_bug.cgi?id=88799
2856
2857         Reviewed by Dimitri Glazkov.
2858
2859         Part of a series of refactoring changes to update pointer lock API to
2860         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
2861
2862         New attribute webkitPointerLockElement added. Follow up patches
2863         will remove the previous isLocked attribute. Tests updated to use
2864         the new attribute.
2865
2866         WebViewHost logic required modification to correctly repond to
2867         a lock, unlock, pointerLockElement call series. Specifically,
2868         unlocking must be queued after a lock command is issued always
2869         as the lock state may not be set yet with a lock request in flight.
2870
2871         * DumpRenderTree/chromium/WebViewHost.cpp:
2872         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
2873         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
2874
2875 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
2876
2877         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
2878         https://bugs.webkit.org/show_bug.cgi?id=88804
2879
2880         Reviewed by Tony Chang.
2881
2882         Protect box-decoration-break behind a feature flag enabled by default.
2883
2884         * Scripts/webkitperl/FeatureList.pm:
2885         * qmake/mkspecs/features/features.pri:
2886
2887 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2888
2889         [CMAKE][EFL] Remove duplicated executable output path
2890         https://bugs.webkit.org/show_bug.cgi?id=88765
2891
2892         Reviewed by Daniel Bates.
2893
2894         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
2895         need to define again because it is already defined in top-level CMake file.
2896
2897         * DumpRenderTree/efl/CMakeLists.txt:
2898         * EWebLauncher/CMakeLists.txt:
2899
2900 2012-06-11  Ojan Vafai  <ojan@chromium.org>
2901
2902         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
2903         https://bugs.webkit.org/show_bug.cgi?id=88816
2904
2905         Reviewed by Dirk Pranke.
2906
2907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2908         Expose a way to clear AsynchronousCaches.
2909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2911         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
2912
2913 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
2914
2915         nrwt exits early too frequently
2916         https://bugs.webkit.org/show_bug.cgi?id=73843
2917
2918         Reviewed by Ryosuke Niwa.
2919
2920         Change the defaults for new-run-webkit-tests for both
2921         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
2922         to zero (i.e., we will never exit early by default).
2923
2924         If people want their buildbots to exit early it is their
2925         responsibility to update their buildbot configs appropriately.
2926
2927         Note that we have tests that ensure that these flags work for
2928         non-zero numbers, but we don't have tests that either test the
2929         default or ensure that zero means "run all of the tests". I
2930         think that's okay but can add tests if others disagree.
2931
2932         Also note that it looks like no changes on the build.webkit.org
2933         master.cfg are necessary; all of the bots seem to be using the
2934         RunWebKitTests wrapper which is already setting the flags. There
2935         is a NewRunWebKitTests wrapper, but that looks to be unused; I
2936         will delete that in a separate patch.
2937
2938         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2939         (parse_args):
2940
2941 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2942
2943         [EFL] [DRT] Reset CacheModel before running each test
2944         https://bugs.webkit.org/show_bug.cgi?id=87534
2945
2946         Reviewed by Gustavo Noronha Silva.
2947
2948         Reset cache model to default before running each test to fix some
2949         flaky tests on EFL build bots. Also fix case value in setCacheModel.
2950
2951         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2952         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2953         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2954         (LayoutTestController::setCacheModel):
2955
2956 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2957
2958         [GTK] Memory leaks in DRT EventSender.cpp
2959         https://bugs.webkit.org/show_bug.cgi?id=88774
2960
2961         Reviewed by Martin Robinson.
2962
2963         Fix a few possible memory leaks in EventSender code.
2964
2965         * DumpRenderTree/gtk/EventSender.cpp:
2966         (contextClickCallback): Free the event returned by gdk_event_new().
2967         (mouseDownCallback): Ditto.
2968         (mouseUpCallback): Ditto.
2969
2970 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2971
2972         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
2973         https://bugs.webkit.org/show_bug.cgi?id=88661
2974
2975         Reviewed by Dirk Pranke.
2976
2977         Pass string length explicitly when creating String object from
2978         non-null-terminated UChar* returned by characters().
2979
2980         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2981         (LayoutTestController::pathToLocalResource):
2982
2983 2012-06-11  David Dorwin  <ddorwin@chromium.org>
2984
2985         [chromium] Provide access to the WebPlugin created by the helper plugin widget
2986         https://bugs.webkit.org/show_bug.cgi?id=88028
2987
2988         Reviewed by Adam Barth.
2989
2990         Added isPlaceholder() to WebPlugin.
2991
2992         * DumpRenderTree/chromium/TestWebPlugin.h:
2993         (TestWebPlugin::isPlaceholder):
2994
2995 2012-06-11  Tony Chang  <tony@chromium.org>
2996
2997         rebaseline from garden-o-matic leaves N processes each time it is run
2998         https://bugs.webkit.org/show_bug.cgi?id=88586
2999
3000         Reviewed by Dirk Pranke.
3001
3002         This appears to only be a problem on python 2.7. Maybe a bug causing
3003         pools to not be garbage collected?
3004
3005         * Scripts/webkitpy/common/system/executive.py:
3006         (Executive.run_in_parallel): close() and join() the process pool.
3007         * Scripts/webkitpy/common/system/executive_unittest.py:
3008         (ExecutiveTest.test_run_in_parallel):
3009
3010 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
3011
3012         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
3013         https://bugs.webkit.org/show_bug.cgi?id=87841
3014
3015         Reviewed by Simon Hausmann.
3016
3017         * qmake/config.tests/libwebp/libwebp.cpp: Added.
3018         (main):
3019         * qmake/config.tests/libwebp/libwebp.pro: Added.
3020         * qmake/sync.profile:
3021
3022 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
3023
3024         Expose layoutTestController as testRunner
3025         https://bugs.webkit.org/show_bug.cgi?id=88210
3026
3027         Reviewed by Darin Adler.
3028
3029         * DumpRenderTree/LayoutTestController.cpp:
3030         (LayoutTestController::makeWindowObject):
3031         * DumpRenderTree/chromium/TestShell.cpp:
3032         (TestShell::bindJSObjectsToWindow):
3033         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3034         (WebCore::DumpRenderTree::initJSObjects):
3035         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3036         (WTR::LayoutTestController::makeWindowObject):
3037
3038 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
3039
3040         [Chromium] Remove JavaScriptCore dependencies from gyp
3041         https://bugs.webkit.org/show_bug.cgi?id=88510
3042
3043         Reviewed by Adam Barth.
3044
3045         Chromium doesn't support JSC any more and there doesn't seem to be
3046         a strong interest in using GYP as the common build system in other
3047         ports.
3048
3049         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3050         * Scripts/generate-project-files: Removed.
3051
3052 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
3053
3054         Add UNDO_MANAGER flag
3055         https://bugs.webkit.org/show_bug.cgi?id=87908
3056
3057         Reviewed by Tony Chang.
3058
3059         * Scripts/webkitperl/FeatureList.pm:
3060         * qmake/mkspecs/features/features.pri:
3061
3062 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3063
3064         webkit-patch land-safely should set cq? if the patch author is not in committers.py
3065         https://bugs.webkit.org/show_bug.cgi?id=88689
3066
3067         Reviewed by Dirk Pranke.
3068
3069         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
3070         in committers.py or the contributor cannot commit. If anything, the contributor can still
3071         set cq+ on thier patches manually so I don't think this will be an issue for people who
3072         don't list their Bugzille email on committers.py.
3073
3074         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3075         (Bugzilla._commit_queue_flag):
3076         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3077         (test_commit_queue_flag):
3078         (test_commit_queue_flag.assert_commit_queue_flag):
3079
3080 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
3081
3082         remove obsolete NewRunWebKitTests buildbot master factory classes
3083         https://bugs.webkit.org/show_bug.cgi?id=88693
3084
3085         Reviewed by Ryosuke Niwa.
3086
3087         I believe these aren't used any more ...
3088
3089         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3090         (RunWebKitTests.getText2):
3091         (BuildAndTestLeaksFactory):
3092
3093 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3094
3095         [Chromium-Android] Build DumpRenderTree with Android SDK
3096         https://bugs.webkit.org/show_bug.cgi?id=88598
3097
3098         Change WebKit side of DRT related code according to some recent changes at chromium side.
3099
3100         Reviewed by Adam Barth.
3101
3102         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3103         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3104         (ChromiumAndroidPort.__init__):
3105         (ChromiumAndroidPort._path_to_driver):
3106
3107 2012-06-08  Wei James  <james.wei@intel.com>
3108
3109         Add app_abi option for DumpRenderTree_apk
3110         https://bugs.webkit.org/show_bug.cgi?id=88626
3111
3112         Reviewed by Adam Barth.
3113
3114         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3115
3116 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GTK] Add API to get the library version to WebKit2 GTK+
3119         https://bugs.webkit.org/show_bug.cgi?id=88426
3120
3121         Reviewed by Martin Robinson.
3122
3123         * gtk/generate-gtkdoc:
3124         (get_webkit2_options): Add built sources to the list of files, but
3125         ignore enum types and marshallers.
3126
3127 2012-06-07  Vincent Scheib  <scheib@chromium.org>
3128
3129         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
3130         https://bugs.webkit.org/show_bug.cgi?id=88604
3131
3132         Reviewed by Kent Tamura.
3133
3134         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
3135         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
3136
3137         * DumpRenderTree/chromium/WebViewHost.cpp:
3138         (WebViewHost::requestPointerUnlock):
3139
3140 2012-06-08  Hans Wennborg  <hans@chromium.org>
3141
3142         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
3143         https://bugs.webkit.org/show_bug.cgi?id=87976
3144
3145         Reviewed by Kent Tamura.
3146
3147         Provide a mock implementation of WebSpeechRecognizer for
3148         DumpRenderTree. This will allow better testing of the API via layout
3149         tests.
3150
3151         * DumpRenderTree/DumpRenderTree.gypi:
3152         * DumpRenderTree/chromium/LayoutTestController.cpp:
3153         (LayoutTestController::LayoutTestController):
3154         (LayoutTestController::addMockSpeechRecognitionResult):
3155         * DumpRenderTree/chromium/LayoutTestController.h:
3156         (LayoutTestController):
3157         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
3158         (MockWebSpeechRecognizer::create):
3159         (MockWebSpeechRecognizer::start):
3160         (MockWebSpeechRecognizer::stop):
3161         (MockWebSpeechRecognizer::abort):
3162         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3163         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3164         (MockWebSpeechRecognizer::ResultTask::runIfValid):
3165         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
3166         (WebKit):
3167         (MockWebSpeechRecognizer):
3168         (MockWebSpeechRecognizer::addMockResult):
3169         (MockWebSpeechRecognizer::taskList):
3170         (ClientCallTask):
3171         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
3172         (ResultTask):
3173         (MockWebSpeechRecognizer::ResultTask::ResultTask):
3174         (NoMatchTask):
3175         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
3176         * DumpRenderTree/chromium/WebViewHost.cpp:
3177         (WebViewHost::speechRecognizer):
3178         * DumpRenderTree/chromium/WebViewHost.h:
3179         (WebViewHost):
3180         (WebViewHost::mockSpeechRecognizer):
3181
3182 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
3183
3184         check-webkit-style needs to be taught about <public/Foo.h>
3185         https://bugs.webkit.org/show_bug.cgi?id=88524
3186
3187         Reviewed by David Levin.
3188
3189         * Scripts/webkitpy/style/checkers/cpp.py:
3190         (_classify_include):
3191         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3192         (OrderOfIncludesTest.test_public_primary_header):
3193         (OrderOfIncludesTest.test_classify_include):
3194
3195 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
3196
3197         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3198         https://bugs.webkit.org/show_bug.cgi?id=67255
3199
3200         Reviewed by Dirk Pranke.
3201
3202         Implement pathToLocalResource to redirect file:///tmp URL's to
3203         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
3204         LayoutTests sub-directory of the WebKit source tree.
3205
3206         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3207         (LayoutTestController::pathToLocalResource):
3208
3209 2012-06-07  Tony Payne  <tpayne@chromium.org>
3210
3211         [chromium] Allow LayoutTests under new git workflow
3212         https://bugs.webkit.org/show_bug.cgi?id=88575
3213
3214         On Windows, chromium indirects through git.bat. Adds the same hack that
3215         is currently used for discovering svn.bat to support the new git
3216         workflow.
3217
3218         Reviewed by Dirk Pranke.
3219
3220         * Scripts/webkitpy/common/checkout/scm/git.py:
3221         (Git): Replaces all hard-coded references to 'git' with the class
3222         variable executable_name.
3223         (Git._check_git_architecture):
3224         (Git.in_working_directory):
3225         (Git.find_checkout_root):
3226         (Git.read_git_config):
3227         (Git.discard_local_commits):
3228         (Git.local_commits):
3229         (Git.working_directory_is_clean):
3230         (Git.clean_working_directory):
3231         (Git.status_command):
3232         (Git.add_list):
3233         (Git.delete_list):
3234         (Git.exists):
3235         (Git._current_branch):
3236         (Git.changed_files):
3237         (Git._changes_files_for_commit):
3238         (Git.revisions_changing_file):
3239         (Git.conflicted_files):
3240         (Git.svn_revision):
3241         (Git.create_patch):
3242         (Git._run_git_svn_find_rev):
3243         (Git.contents_at_revision):
3244         (Git.diff_for_file):
3245         (Git.show_head):
3246         (Git.committer_email_for_revision):
3247         (Git.apply_reverse_diff):
3248         (Git.revert_files):
3249         (Git.commit_with_message):
3250         (Git._commit_on_branch):
3251         (Git.svn_commit_log):
3252         (Git.last_svn_commit_log):
3253         (Git.svn_blame):
3254         (Git._branch_ref_exists):
3255         (Git.delete_branch):
3256         (Git.remote_merge_base):
3257         (Git.commit_locally_with_message):
3258         (Git.push_local_commits_to_server):
3259         (Git.commit_ids_from_commitish_arguments):
3260         (Git.commit_message_for_local_commit):
3261         (Git.files_changed_summary_for_commit):
3262         * Scripts/webkitpy/common/host.py:
3263         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
3264         that duplicates the logic in the existing 'svn.bat' hack.
3265
3266 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3267
3268         Style build architectures like build versions for non-layout test failures
3269         https://bugs.webkit.org/show_bug.cgi?id=88590
3270
3271         Reviewed by Tony Chang.
3272
3273         Since we show the list of failing tests after the architecture, we want the
3274         buildtype and architecture to be grouped together visually.
3275
3276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3277         (.effects a.failing-builder>span.architecture):
3278
3279 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3280
3281         [Chromium] Remove header dependency of ImageDiff to WTF
3282         https://bugs.webkit.org/show_bug.cgi?id=88422
3283
3284         Reviewed by Ryosuke Niwa.
3285
3286         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3287         * DumpRenderTree/chromium/ImageDiff.cpp:
3288         (untestedCompareImages):
3289
3290 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
3291
3292         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
3293         https://bugs.webkit.org/show_bug.cgi?id=88491
3294
3295         Reviewed by Dirk Pranke.
3296
3297         DRT should enable WebAudio when WebAudio feature is enabled,
3298         so that the WebAudio feature could be tested by the Layouttest.
3299
3300         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
3301         (LayoutTestController::overridePreference):
3302
3303 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3304
3305         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
3306         https://bugs.webkit.org/show_bug.cgi?id=88581
3307
3308         Reviewed by Ojan Vafai.
3309
3310         webkit-paptch rebaseline-expectations was ignoring what the
3311         expected results for a test were and pulling down all the result
3312         files from a bot. This could lead to us pulling down old,
3313         incorrect .txt or .png files. With this patch we will now only
3314         pull down expectations of the appropriate file types (so an
3315         IMAGE failure will only pull the png and not the txt file).
3316
3317         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3318         (has_pixel_failures):
3319         (suffixes_for_expectations):
3320         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3321         (FunctionsTest.test_suffixes_for_expectations):
3322         * Scripts/webkitpy/tool/commands/rebaseline.py:
3323         (AbstractRebaseliningCommand.__init__):
3324         (RebaselineExpectations._is_supported_port):
3325         (RebaselineExpectations._update_expectations_file):
3326         (RebaselineExpectations._tests_to_rebaseline):
3327         (RebaselineExpectations._rebaseline_port):
3328         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3329         (test_overrides_are_included_correctly):
3330
3331 2012-06-07  Ojan Vafai  <ojan@chromium.org>
3332
3333         Fix recent null pointer error regression in the flakiness dashboard
3334         https://bugs.webkit.org/show_bug.cgi?id=88573
3335
3336         Reviewed by Dirk Pranke.
3337
3338         * TestResultServer/static-dashboards/builders.js:
3339         (requestBuilderList):
3340         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3341
3342 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
3343
3344         Add Konrad Piascik to committers.py
3345         https://bugs.webkit.org/show_bug.cgi?id=88560
3346
3347         Unreviewed.
3348
3349         * Scripts/webkitpy/common/config/committers.py:
3350
3351 2012-06-07  Tony Chang  <tony@chromium.org>
3352
3353         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
3354         https://bugs.webkit.org/show_bug.cgi?id=77368
3355
3356         Reviewed by Ojan Vafai.
3357
3358         It doesn't look like we ever get a rect with width or height of 0.
3359         I ran css1, css2.1, fast/forms, and tables without any crashes.
3360
3361         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3362         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
3363
3364 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
3365
3366         run-webkit-tests --lint-test-files gives an error when run on linux
3367         https://bugs.webkit.org/show_bug.cgi?id=88551
3368
3369         Reviewed by Ojan Vafai.
3370
3371         We weren't mapping the expectations properly for the
3372         google-chrome ports.
3373
3374         * Scripts/webkitpy/layout_tests/port/base.py:
3375         (Port.path_to_test_expectations_file):
3376         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3377         (TestGoogleChromePort.test_path_to_expectations):
3378
3379 2012-06-07  Daniel Erat  <derat@chromium.org>
3380
3381         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
3382         https://bugs.webkit.org/show_bug.cgi?id=88263
3383
3384         Reviewed by Tony Chang.
3385
3386         * DumpRenderTree/chromium/LayoutTestController.cpp:
3387         (LayoutTestController::LayoutTestController):
3388         (LayoutTestController::reset):
3389         (LayoutTestController::setTextSubpixelPositioning):
3390         * DumpRenderTree/chromium/LayoutTestController.h:
3391         (LayoutTestController):
3392         * DumpRenderTree/chromium/fonts.conf:
3393
3394 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
3395
3396         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
3397         https://bugs.webkit.org/show_bug.cgi?id=88060
3398
3399         Reviewed by Martin Robinson.
3400
3401         Spin the main loop before acquiring the pixel content. This ensures things
3402         like late size allocations are finished before calling gtk_widget_draw,
3403         avoiding assertions and subsequent empty pixel results.
3404
3405         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3406         (createBitmapContextFromWebView):
3407
3408 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3409
3410         [Qt] Improve the visual of the viewport info box
3411         https://bugs.webkit.org/show_bug.cgi?id=88410
3412
3413         Reviewed by Tor Arne Vestbø.
3414
3415         Improve the visual and make it possible to see the content more easy.
3416
3417         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3418
3419 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
3420
3421         [EFL][WK2] Compile webkit1 and webkit2 by default.
3422         https://bugs.webkit.org/show_bug.cgi?id=85041
3423
3424         Reviewed by Chang Shu.
3425
3426         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
3427         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
3428
3429         * Scripts/build-webkit:
3430
3431 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3432
3433         Unreviewed, rolling out r119662.
3434         http://trac.webkit.org/changeset/119662
3435         https://bugs.webkit.org/show_bug.cgi?id=88487
3436
3437         Broke builds (Requested by rniwa on #webkit).
3438
3439         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3440         * DumpRenderTree/chromium/ImageDiff.cpp:
3441         (untestedCompareImages):
3442
3443 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3444
3445         [Chromium] Remove header dependency of ImageDiff to WTF
3446         https://bugs.webkit.org/show_bug.cgi?id=88422
3447
3448         Reviewed by Adam Barth.
3449
3450         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3451         * DumpRenderTree/chromium/ImageDiff.cpp:
3452         (untestedCompareImages):
3453
3454 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
3455
3456         [WebKit] DeviceOrientation cleanup
3457         https://bugs.webkit.org/show_bug.cgi?id=88406
3458
3459         Reviewed by Kent Tamura.
3460
3461         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
3462
3463         * DumpRenderTree/chromium/LayoutTestController.cpp:
3464         (LayoutTestController::setMockDeviceOrientation):
3465
3466 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
3467
3468         webkitpy: add support for an ordered dict of test expectations
3469         https://bugs.webkit.org/show_bug.cgi?id=87802
3470
3471         Reviewed by Ojan Vafai.
3472
3473         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
3474         support a cascaded list of test expectations files. An easy way
3475         to think of this is as an ordered dictionary of name -> contents
3476         for files, where the name is usually a path on disk (I say
3477         usually because we want to support other kinds of expectations
3478         like the compile-time skips for unsupported features in
3479         webkit.py, and we want to continue to support "in-memory" test
3480         expectations that don't require a filesystem).
3481
3482         Conveniently there is an OrderedDict implementation in Python
3483         2.7+ and it is available as a backport, so the first step in
3484         adding this support is to use that implementation. Subsequent
3485         patches will update the test_expectations.py module (and other
3486         callers) to access the dict directly.
3487
3488         This patch just changes the base internal implementation and
3489         provides wrappers for compatibility. The derived ports
3490         (WebKitPort, TestPort, etc.) still need to be updated.
3491
3492         * Scripts/webkitpy/layout_tests/port/base.py:
3493         (Port._expectations_dict):
3494         (Port.test_expectations):
3495         (Port):
3496         (Port._expectations_overrides_dict):
3497         (Port.test_expectations_overrides):
3498         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3499         (PortTestCase.test_expectations_ordering):
3500         (PortTestCase):
3501         (PortTestCase.test_expectations_overrides_ordering):
3502         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
3503         (OrderedDict):
3504         (OrderedDict.__init__):
3505         (OrderedDict.clear):
3506         (OrderedDict.__setitem__):
3507         (OrderedDict.__delitem__):
3508         (OrderedDict.__iter__):
3509         (OrderedDict.__reversed__):
3510         (OrderedDict.popitem):
3511         (OrderedDict.__reduce__):
3512         (OrderedDict.__repr__):
3513         (OrderedDict.copy):
3514         (OrderedDict.fromkeys):
3515
3516 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
3517
3518         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
3519
3520         * gtk/run-api-tests:
3521         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
3522
3523 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3524
3525         nrwt should look in 'out' for binaries on chromium win to support ninja
3526         https://bugs.webkit.org/show_bug.cgi?id=88273
3527
3528         Reviewed by Tony Chang.
3529
3530         This patch standardizes the search algorithm the chromium ports
3531         use to figure out which driver to run. We will look in a
3532         chromium location before a webkit location (e.g., in
3533         Source/WebKit/chromium/out before out/) and we will look in the
3534         "legacy" directory (xcodebuild) before the directory ninja uses
3535         (out).
3536
3537         Unfortunately due to the way the test code is set up testing the
3538         properly requires some duplication of test code. I will fix that
3539         in a followup patch.
3540
3541         * Scripts/webkitpy/layout_tests/port/chromium.py:
3542         (ChromiumPort):
3543         (ChromiumPort._static_build_path):
3544         (ChromiumPort._build_path):
3545         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3546         (ChromiumLinuxPort):
3547         (ChromiumLinuxPort._determine_driver_path_statically):
3548         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3549         (ChromiumLinuxPortTest.test_build_path):
3550         (ChromiumLinuxPortTest):
3551         (ChromiumLinuxPortTest.test_driver_name_option):
3552         (ChromiumLinuxPortTest.path_to_image_diff):
3553         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3554         (ChromiumMacPort):
3555         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3556         (ChromiumMacPortTest.test_build_path):
3557         (ChromiumMacPortTest):
3558         (ChromiumMacPortTest.test_driver_name_option):
3559         (ChromiumMacPortTest.path_to_image_diff):
3560         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3561         (ChromiumPortTest.test_overrides_and_builder_names):
3562         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3563         (ChromiumWinPort):
3564         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3565         (ChromiumWinTest.test_build_path):
3566         (ChromiumWinTest.test_operating_system):
3567         (ChromiumWinTest):
3568         (ChromiumWinTest.test_driver_name_option):
3569         (ChromiumWinPortTest.path_to_image_diff):
3570         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3571         (PortTestCase.assert_build_path):
3572
3573 2012-06-06  Jessie Berlin  <jberlin@apple.com>
3574
3575         Remove very red Windows WebKit2 testers
3576         https://bugs.webkit.org/show_bug.cgi?id=88452
3577
3578         Reviewed by Steve Falkenburg.
3579
3580         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
3581         need to focus on getting the WK1 testers green.
3582
3583         * BuildSlaveSupport/build.webkit.org-config/config.json:
3584
3585 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3586
3587         get rebaselining tools to kinda work with the skia overrides file
3588         https://bugs.webkit.org/show_bug.cgi?id=88456
3589
3590         Reviewed by Ryosuke Niwa.
3591
3592         Update rebaseline-expectations so that we read in the overrides
3593         when looking for tests to rebaseline, but don't read in the
3594         overrides when we are writing the expectations file back out.
3595         This prevents the overrides from getting written into the main
3596         file. This is kind of a hack but will have to do until we
3597         support multiple expectations files properly.
3598
3599         * Scripts/webkitpy/tool/commands/rebaseline.py:
3600         (RebaselineExpectations._expectations):
3601         (RebaselineExpectations._update_expectations_file):
3602         (RebaselineExpectations._tests_to_rebaseline):
3603         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3604         (test_overrides_are_included_correctly):
3605
3606 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3607
3608         webkitpy: two manager_worker_broker_unittest tests are broken
3609         https://bugs.webkit.org/show_bug.cgi?id=88445
3610
3611         Reviewed by Ojan Vafai.
3612
3613         These tests were never updated when we removed the
3614         --worker-model argument, and we were passing 'inline' instead of
3615         1 (for the number of workers) :(. As a result we were creating
3616         multiprocessing queues unnecessarily and that was failing on cygwin.
3617
3618         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3619         (InterfaceTest.test_managerconnection_is_abstract):
3620         (InterfaceTest.test_workerconnection_is_abstract):
3621
3622 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3623
3624         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
3625         https://bugs.webkit.org/show_bug.cgi?id=87406
3626
3627         Reviewed by Dirk Pranke.
3628
3629         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3630         (TestExpectations.__init__):
3631         * Scripts/webkitpy/tool/commands/rebaseline.py:
3632         (RebaselineTest._update_expectations_file):
3633         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3634         (test_rebaseline_does_not_include_overrides):
3635
3636 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
3637
3638         webkitpy: perf tests unit tests fail on chromium win
3639         https://bugs.webkit.org/show_bug.cgi?id=88279
3640
3641         Reviewed by Ryosuke Niwa.
3642
3643         I'm seeing weird failures running the unit tests in my win32
3644         checkout, and we don't really expect webpagereplay to work on
3645         win32 anyway, so I'm skipping the import of that module for now
3646         and adding a warning.
3647
3648         * Scripts/run-perf-tests:
3649         * Scripts/webkitpy/performance_tests/perftest.py:
3650
3651 2012-06-06  Yong Li <yoli@rim.com>
3652
3653         Unreviewed. Update my email address in committers.py.
3654
3655         * Scripts/webkitpy/common/config/committers.py:
3656
3657 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
3658
3659         Add Robert Kroeger  to commiters.py
3660         https://bugs.webkit.org/show_bug.cgi?id=88415
3661
3662         Unreviewed.
3663
3664         * Scripts/webkitpy/common/config/committers.py:
3665
3666 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3667
3668         [EFL][DRT] http/tests/globalhistory testcases do not pass
3669         https://bugs.webkit.org/show_bug.cgi?id=82579
3670
3671         Reviewed by Csaba Osztrogonác.
3672
3673         DRT has provided callbacks for ewk_view "global history delegate" signals.
3674
3675         * DumpRenderTree/efl/DumpRenderTree.cpp:
3676         (isGlobalHistoryTest): Aux function to ident global history testcase.
3677         (createLayoutTestController):
3678         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3679         (DumpRenderTreeChrome::createView):
3680         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
3681         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
3682         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
3683         (DumpRenderTreeChrome::onWebViewClien