Remove duplicate API from WKContext
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-04  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Brian Weinstein.
4
5         Remove duplicate API from WKContext
6         <rdar://problem/8727879>
7         https://bugs.webkit.org/show_bug.cgi?id=57815
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
11         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
12         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
13
14 2011-04-04  Tony Chang  <tony@chromium.org>
15
16         Reviewed by Ojan Vafai.
17
18         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
19         https://bugs.webkit.org/show_bug.cgi?id=57783
20
21         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
22         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
23
24 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
25
26         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
27         from WebKitBuild.
28
29         * Scripts/webkitdirs.pm:
30
31 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
32
33         Reviewed by Gustavo Noronha Silva.
34
35         [GTK] WebGL support
36         https://bugs.webkit.org/show_bug.cgi?id=31517
37
38         Add support to the DRT for turning on WebGL when a layout tests requests it.
39
40         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
41         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
42
43 2011-04-04  Chang Shu  <cshu@webkit.org>
44
45         Reviewed by Darin Adler.
46
47         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
48         https://bugs.webkit.org/show_bug.cgi?id=57572
49
50         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
51         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
52         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
53         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
54
55 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
56
57         Reviewed by Csaba Osztrogonác.
58
59         [Qt] DumpRenderTree breaks compilation in some uClibc environments
60         https://bugs.webkit.org/show_bug.cgi?id=57602
61
62         * DumpRenderTree/qt/main.cpp:
63         (get_backtrace):
64
65 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
66
67         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
68
69         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
70         (LayoutTestController::shadowRoot):
71
72 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
73
74         Unreviewed, fix exception in rebaseline tool.
75
76         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
77
78 2011-04-02  Beth Dakin  <bdakin@apple.com>
79
80         Rubber-stamped by Geoff Garen.
81
82         For Dan!
83         * DumpRenderTree/mac/DumpRenderTree.mm:
84         (resetWebViewToConsistentStateBeforeTesting):
85
86 2011-04-02  Beth Dakin  <bdakin@apple.com>
87
88         Rubber-stamped by Geoff Garen.
89
90         Need to reset the scale, much like zoom.
91         * DumpRenderTree/mac/DumpRenderTree.mm:
92         (resetWebViewToConsistentStateBeforeTesting):
93
94 2011-04-02  Sam Weinig  <sam@webkit.org>
95
96         Reviewed by Beth Dakin.
97
98         https://bugs.webkit.org/show_bug.cgi?id=57605
99         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
100         getClientRects()
101         -and corresponding-
102         <rdar://problem/9194541>
103
104         Add DRT support for the scaleWebView SPI.
105         * DumpRenderTree/mac/EventSendingController.mm:
106         (+[EventSendingController isSelectorExcludedFromWebScript:]):
107         (+[EventSendingController webScriptNameForSelector:]):
108         (-[EventSendingController scalePageBy:atX:andY:]):
109         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
110         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
111         (WTR::EventSendingController::scalePageBy):
112         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
113         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
114         (WTR::InjectedBundlePage::reset):
115
116 2011-04-02  Dominic Cooney  <dominicc@google.com>
117
118         Reviewed by Martin Robinson.
119
120         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
121         https://bugs.webkit.org/show_bug.cgi?id=57551
122
123         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
124         (LayoutTestController::shadowRoot):
125
126 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
127
128         Reviewed by Eric Seidel.
129
130         Remove AbstractStep._run_script and move script names to ports.py
131         https://bugs.webkit.org/show_bug.cgi?id=57704
132
133         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
134
135         * Scripts/webkitpy/common/config/ports.py:
136         * Scripts/webkitpy/tool/commands/download_unittest.py:
137         * Scripts/webkitpy/tool/commands/roll_unittest.py:
138         * Scripts/webkitpy/tool/commands/upload_unittest.py:
139         * Scripts/webkitpy/tool/steps/abstractstep.py:
140         * Scripts/webkitpy/tool/steps/checkstyle.py:
141         * Scripts/webkitpy/tool/steps/preparechangelog.py:
142         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
143         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
144
145 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
146
147         Reviewed by Eric Seidel.
148
149         Emulate shebang on Win32
150         https://bugs.webkit.org/show_bug.cgi?id=55927
151
152         Scripts on Windows work only if they are called with the explicit interpreter.
153         Read the first line of scripts to detect the correct executable.
154
155         * Scripts/webkitpy/common/config/ports.py:
156         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
157         * Scripts/webkitpy/common/system/executive_unittest.py:
158
159 2011-04-01  Adam Barth  <abarth@webkit.org>
160
161         Reviewed by Eric Seidel.
162
163         apos entities shouldn't show up in ChangeLogs when using webkit-patch
164         https://bugs.webkit.org/show_bug.cgi?id=57692
165
166         Previously, we were using BeautifulSoup to process XML from
167         bugs.webkit.org, but that's incorrect.  We should be using
168         BeautifulStoneSoup to process the XML.  We were getting the &apos;
169         entity wrong because &apos; is an XML entity but not an HTML entity.
170
171         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
172         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
173
174 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
175
176         Unreviewed, rolling out r82721.
177         http://trac.webkit.org/changeset/82721
178         https://bugs.webkit.org/show_bug.cgi?id=57687
179
180         This patch introduced assertion failures on the GTK+ bots.
181         (Requested by mrobinson on #webkit).
182
183         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
184         (LayoutTestController::shadowRoot):
185
186 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
187
188         Unreviewed buildfix.
189
190         [Qt][WK2] Build Webkit2 using "-2" option on Qt
191         https://bugs.webkit.org/show_bug.cgi?id=55074
192
193         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
194         (The isWK2() function removes it from @ARGV, but not from @options.)
195
196 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
197
198         Reviewed by Csaba Osztrogonác.
199
200         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
201         https://bugs.webkit.org/show_bug.cgi?id=57666
202
203         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
204
205 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
206
207         Reviewed by Adam Barth.
208
209         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
210
211         We apparently never implemented the code to skip tests based on
212         what was compiled into DRT. Also, change the logic used to skip
213         platform directories to match what old-run-webkit-tests does: 
214         skip every test not in a directory in the baseline search path.
215
216         https://bugs.webkit.org/show_bug.cgi?id=57662
217
218         * Scripts/webkitpy/layout_tests/port/mac.py:
219         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
220         * Scripts/webkitpy/layout_tests/port/webkit.py:
221
222 2011-03-29  Mark Rowe  <mrowe@apple.com>
223
224         Reviewed by Jon Honeycutt.
225
226         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
227
228         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
229
230         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
231         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
232         * Scripts/webkitpy/layout_tests/port/mac.py:
233         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
234
235 2011-04-01  Chang Shu  <cshu@webkit.org>
236
237         Reviewed by Csaba Osztrogonác.
238
239         [Qt][WK2] Build Webkit2 using "-2" option on Qt
240         https://bugs.webkit.org/show_bug.cgi?id=55074
241
242         * Scripts/build-webkit:
243
244 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
245
246         Reviewed by Tony Chang.
247
248         new-run-webkit-tests: remove spurious port version override in webkit.py
249         base.py provides a default implementation so this is just
250         breaking things.
251
252         https://bugs.webkit.org/show_bug.cgi?id=57667
253
254         * Scripts/webkitpy/layout_tests/port/webkit.py:
255         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
256
257 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
258
259         Reviewed by Adam Roben.
260
261         Make view results on waterfall direct link to results.html
262         https://bugs.webkit.org/show_bug.cgi?id=57671
263
264         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
265         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
266
267 2011-04-01  Sam Weinig  <sam@webkit.org>
268
269         Fix windows build.
270
271         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
274         (TestWebKitAPI::flushMessages):
275
276 2011-04-01  Sam Weinig  <sam@webkit.org>
277
278         Reviewed by Adam Roben.
279
280         Add adoptWK to WKRetainPtr.h
281         https://bugs.webkit.org/show_bug.cgi?id=57670
282
283         * TestWebKitAPI/PlatformUtilities.h:
284         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
285         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
286         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
287         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
288         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
289         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
290         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
291         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
292         (TestWebKitAPI::createSessionStateContainingFormData):
293         * WebKitTestRunner/StringFunctions.h:
294         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
295
296 2011-04-01  Sam Weinig  <sam@webkit.org>
297
298         Reviewed by Adam Roben.
299
300         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
301
302         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
303         (WTR::LayoutTestController::shadowRoot):
304         Make judicious use of adoptWK().
305
306 2011-04-01  Sam Weinig  <sam@webkit.org>
307
308         Reviewed by Timothy Hatcher.
309
310         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
311
312         * Scripts/extract-localizable-strings:
313
314 2011-04-01  Anders Carlsson  <andersca@apple.com>
315
316         Reviewed by Sam Weinig.
317
318         Shockwave plug-in doesn't accept mouse events
319         https://bugs.webkit.org/show_bug.cgi?id=57653
320         <rdar://problem/8483273>
321
322         Add a plug-in test.
323
324         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
325         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
326         (PluginTest::indicateTestFailure):
327         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
328
329         (PluginTest::NPN_ConvertPoint):
330         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
331         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
332         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
333         Call indicateTestFailure.
334
335         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
336         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
337         (ConvertPoint::ConvertPoint):
338         (ConvertPoint::testConvert):
339         (ConvertPoint::NPP_New):
340
341 2011-04-01  Dominic Cooney  <dominicc@google.com>
342
343         Reviewed by Martin Robinson.
344
345         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
346         https://bugs.webkit.org/show_bug.cgi?id=57551
347
348         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
349         (LayoutTestController::shadowRoot):
350
351 2011-04-01  Sam Weinig  <sam@webkit.org>
352
353         Reviewed by Anders Carlsson.
354
355         WebKitTestRunner needs layoutTestController.shadowRoot
356         https://bugs.webkit.org/show_bug.cgi?id=57661
357
358         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
359         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
360         (WTR::LayoutTestController::shadowRoot):
361         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
362         Implement layoutTestController.shadowRoot for WebKit2.
363
364 2011-04-01  Chang Shu  <cshu@webkit.org>
365
366         Reviewed by Darin Adler.
367
368         WebKitTestRunner needs layoutTestController.setDatabaseQuota
369         https://bugs.webkit.org/show_bug.cgi?id=57568
370
371         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
372         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
373         (WTR::LayoutTestController::setDatabaseQuota):
374         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
375
376 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
377
378         Reviewed by Tony Chang.
379
380         This patch completes the cleanup of
381         rebaseline-chromium-webkit-tests to work with all of the
382         variants of a platform (we can now rebaseline gpu- and non-gpu
383         files at the same time).
384
385         When the rebaselining is complete, any lines declared as
386         REBASELINE in the expectations file that matches a test that was
387         actually rebaselined will be deleted, even if only one of the
388         variants was actually rebaselined. This may cause odd problems,
389         but is better than where we're at today.
390
391         This change removes the -g flag and deprecates -w. The -g flag is gone
392         because GPU baselines are handled just like any other variant.
393         The -w flag is deprecated because this tool now only works
394         against the canaries, since that's the only place we have a full
395         set of bots. It will be trivial to change this to
396         build.webkit.org if we decide that's where we want them to be.
397
398         Also, this patch deletes a lot of cruft that is no longer needed
399         in the test_expectations code and the port-specific code.
400
401         https://bugs.webkit.org/show_bug.cgi?id=55191
402
403         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
404         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
405         * Scripts/webkitpy/layout_tests/port/base.py:
406         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
407         * Scripts/webkitpy/layout_tests/port/chromium.py:
408         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
409         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
410         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
411         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
412         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
413         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
414         * Scripts/webkitpy/layout_tests/port/mac.py:
415         * Scripts/webkitpy/layout_tests/port/test.py:
416         * Scripts/webkitpy/layout_tests/port/webkit.py:
417         * Scripts/webkitpy/layout_tests/port/win.py:
418         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
419         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
420
421 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
422
423         Reviewed by Adam Barth.
424
425         rebaseline-chromium-webkit-tests does not work correctly with
426         version-specific baselines. This patch updates the tool to use
427         all of the version-specific bots on the canaries, and will now
428         attempt to rebaseline all of the versions by default, although
429         it will not update both GPU and CPU versions.
430         
431         Also, it will no longer modify the test_expectations.txt file
432         *at all*. You will have to manually delete the REBASELINE lines
433         after running the tool and determining that it did what you
434         wanted it to do. This should be fixed in a separate bug - see
435         webkit bug #55191.
436
437         https://bugs.webkit.org/show_bug.cgi?id=55608
438
439         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
440         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
441         * Scripts/webkitpy/layout_tests/port/chromium.py:
442         * Scripts/webkitpy/layout_tests/port/test.py:
443         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
444         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
445
446 2011-03-31  Tony Chang  <tony@chromium.org>
447
448         Reviewed by Ojan Vafai.
449
450         [chromium] update the rebaseline tool to know about pngs with checksums
451         https://bugs.webkit.org/show_bug.cgi?id=57481
452
453         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
454         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
455
456 2011-04-01  Adam Roben  <aroben@apple.com>
457
458         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
459
460         Previously, we were getting the revision of the first revision that triggered a build.
461         Choosing the last revision would have been more accurate. But got_revision is what is used
462         everywhere else on build.webkit.org, and should work even when there were no changes that
463         triggered a build (e.g., if someone clicked the Force Build button).
464
465         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
466         recent builds list
467
468         Reviewed by Anders Carlsson.
469
470         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
471         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
472         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
473
474         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
475         (Array.prototype.first): Added this helper function to return the first element in an array
476         that matches the given predicate, or null if no such element exists.
477
478 2011-03-31  Adam Roben  <aroben@apple.com>
479
480         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
481
482         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
483
484         Reviewed by Darin Adler.
485
486         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
487         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
488         URL on its own line.
489
490         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
491         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
492         progression, and added a new test that uses a short bug URL while I was at it.
493
494 2011-04-01  Adam Roben  <aroben@apple.com>
495
496         Mark .vcproj/.vsprops/.sln files as being Windows-only
497
498         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
499
500         Reviewed by Anders Carlsson.
501
502         * Scripts/webkitpy/common/config/build.py:
503         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
504         directories as Windows-only.
505
506         * Scripts/webkitpy/common/config/build_unittest.py:
507         (ShoulBuildTest): Added test cases for the above.
508
509 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
510
511         Reviewed by Laszlo Gombos.
512
513         [Qt] Build MiniBrowser for Symbian
514         https://bugs.webkit.org/show_bug.cgi?id=56319
515
516         Have MiniBrowser reference it's own copy of useragentlist.txt instead
517         of copying QtTestBrowser's.
518         Remove Tools/MiniBrowser/DerivedSources.pro
519         This reduces complexity in the Tools scripts due to Symbian limitations.
520
521         * DerivedSources.pro:
522         * MiniBrowser/DerivedSources.pro: Removed.
523         * MiniBrowser/MiniBrowser.qrc:
524         * MiniBrowser/qt/MiniBrowser.pro:
525         * Scripts/webkitdirs.pm:
526
527 2011-03-31  Chang Shu  <cshu@webkit.org>
528
529         Reviewed by Darin Adler.
530
531         WebKitTestRunner needs layoutTestController.clearAllDatabases
532         https://bugs.webkit.org/show_bug.cgi?id=42540
533
534         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
535         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
536         (WTR::InjectedBundle::beginTesting):
537         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
538         (WTR::LayoutTestController::clearAllDatabases):
539         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
540
541 2011-03-31  Chang Shu  <cshu@webkit.org>
542
543         Reviewed by Darin Adler.
544
545         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
546         https://bugs.webkit.org/show_bug.cgi?id=42692
547
548         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
549
550 2011-03-31  Darin Adler  <darin@apple.com>
551
552         Reviewed by Sam Weinig.
553
554         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
555         https://bugs.webkit.org/show_bug.cgi?id=57573
556
557         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
558         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
559         Removed fake definitions of keyDown and contextClick.
560
561         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
562         (WTR::operator==): Added. So we can compare two WKPoint structs.
563         (WTR::parseModifier): Added.
564         (WTR::parseModifierArray): Added.
565         (WTR::EventSendingController::EventSendingController): Initialize the
566         new data members.
567         (WTR::EventSendingController::mouseDown): Added. Calls
568         WKBundlePageSimulateMouseDown.
569         (WTR::EventSendingController::mouseUp): Added. Calls
570         WKBundlePageSimulateMouseUp.
571         (WTR::EventSendingController::mouseMoveTo): Added. Calls
572         WKBundlePageSimulateMouseMotion.
573         (WTR::EventSendingController::leapForward): Added.
574         (WTR::EventSendingController::updateClickCount): Added. Used by the
575         mouseDown/Up functions to create a click count.
576
577         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
578         for the changes above.
579
580 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
581
582         Reviewed by Martin Robinson.
583
584         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
585         https://bugs.webkit.org/show_bug.cgi?id=57362
586
587         Do not generate DRT output if willSendRequestReturnsNull is set.
588
589         * DumpRenderTree/gtk/DumpRenderTree.cpp:
590         (willSendRequestCallback):
591
592 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
593
594         Reviewed by Martin Robinson.
595
596         Implement MiniBrowser for Gtk port.
597         https://bugs.webkit.org/show_bug.cgi?id=48512
598
599         Initial implementation of the Gtk MiniBrowser.
600
601         * MiniBrowser/gtk/GNUmakefile.am: Added.
602         * MiniBrowser/gtk/main.c: Added.
603         (activateUriEntryCallback):
604         (destroyCallback):
605         (goBackCallback):
606         (goForwardCallback):
607         (createToolbar):
608         (createWebView):
609         (createWindow):
610         (argumentToURL):
611         (main):
612
613 2011-03-30  Dominic Cooney  <dominicc@google.com>
614
615         Reviewed by Dimitri Glazkov.
616
617         Adds layoutTestController.shadowRoot accessor to Mac DRT.
618         https://bugs.webkit.org/show_bug.cgi?id=57415
619
620         * DumpRenderTree/LayoutTestController.cpp:
621         (shadowRootCallback):
622         (LayoutTestController::staticFunctions):
623         * DumpRenderTree/LayoutTestController.h:
624         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
625         (LayoutTestController::shadowRoot):
626         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
627         (LayoutTestController::shadowRoot):
628
629 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
630
631         Reviewed by Chris Marrin.
632
633         Update fast/canvas tests to avoid dumping the render tree when possible
634         https://bugs.webkit.org/show_bug.cgi?id=57493
635
636         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
637           accelerated drawing and accelerated drawing for canvas
638
639 2011-03-30  Adam Roben  <aroben@apple.com>
640
641         Stop ignoring leaks in CGGradientCreateWithColorStops
642
643         Fixes <rdar://problem/7888547>.
644
645         Rubber-stamped by John Sullivan.
646
647         * Scripts/old-run-webkit-tests:
648         (countAndPrintLeaks): Removed some code to ignore those leaks.
649
650 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
651
652         Reviewed by Alexey Proskuryakov.
653
654         Add some dynamic annotations to JavaScriptCore/wtf
655         https://bugs.webkit.org/show_bug.cgi?id=53747
656
657         By using these annotations we can improve the precision of finding
658         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
659         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
660
661         These files don't add new functionality, so don't need extra tests.
662
663         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
664
665 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
666
667         Reviewed by Adam Roben.
668
669         Share most vsprops between Release and Production builds in releaseproduction.vsprops
670         https://bugs.webkit.org/show_bug.cgi?id=57508
671
672         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
673         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
674         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
675         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
676         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
677         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
678         * DumpRenderTree/win/ImageDiffProduction.vsprops:
679         * DumpRenderTree/win/ImageDiffRelease.vsprops:
680         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
681         * FindSafari/FindSafariProduction.vsprops:
682         * FindSafari/FindSafariRelease.vsprops:
683         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
684         * FindSafari/FindSafariReleasePGO.vsprops:
685         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
686         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
687         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
688         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
689         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
690         * WebKitAPITest/WebKitAPITestProduction.vsprops:
691         * WebKitAPITest/WebKitAPITestRelease.vsprops:
692         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
693         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
694         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
695         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
696         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
697         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
698         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
699         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
700         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
701         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
702         * WinLauncher/WinLauncherProduction.vsprops:
703         * WinLauncher/WinLauncherRelease.vsprops:
704         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
705         * record-memory-win/record-memory-winProduction.vsprops:
706         * record-memory-win/record-memory-winRelease.vsprops:
707         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
708
709 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
710
711         Reviewed by Adam Roben.
712
713         Update Windows production build logic for new production configurations
714         https://bugs.webkit.org/show_bug.cgi?id=57494
715
716         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
717         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
718         * DumpRenderTree/win/ImageDiffProduction.vsprops:
719         * FindSafari/FindSafariProduction.vsprops:
720         * FindSafari/FindSafariReleasePGO.vsprops:
721         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
722         * WebKitAPITest/WebKitAPITestProduction.vsprops:
723         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
724         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
725         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
726         * WinLauncher/WinLauncherProduction.vsprops:
727         * record-memory-win/record-memory-winProduction.vsprops:
728
729 2011-03-30  Robert Hogan  <robert@webkit.org>
730
731         Reviewed by Antonio Gomes.
732
733         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
734         Unskip http/tests/navigation/go-back-to-error-page.html
735
736         Also add the location of DumpRenderTreeSupportQt.h
737         to DRT's include paths.
738
739         https://bugs.webkit.org/show_bug.cgi?id=52614
740
741         * DumpRenderTree/qt/DumpRenderTree.pro:
742         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
743         * DumpRenderTree/qt/DumpRenderTreeQt.h:
744         * DumpRenderTree/qt/GCControllerQt.cpp:
745         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
746         (LayoutTestController::queueLoadHTMLString):
747         * DumpRenderTree/qt/LayoutTestControllerQt.h:
748         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
749         * DumpRenderTree/qt/TextInputControllerQt.cpp:
750         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
751         (LoadAlternateHTMLStringItem::invoke):
752         * DumpRenderTree/qt/WorkQueueItemQt.h:
753         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
754         * QtTestBrowser/QtTestBrowser.pro:
755         * QtTestBrowser/launcherwindow.h:
756
757 2011-03-30  Adam Barth  <abarth@webkit.org>
758
759         Reviewed by Adam Roben.
760
761         SheriffBot rollouts take too long
762         https://bugs.webkit.org/show_bug.cgi?id=57498
763
764         We used to build before landing rollouts via the commit-queue to
765         prevent further breakage, but now that our individual commit-queue
766         machines are slower, building takes too long.  I can't remember the
767         last time a rollout broke compile.  It seems like just landing the
768         patch is the better trade-off.
769
770         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
771         * Scripts/webkitpy/tool/commands/queues_unittest.py:
772
773 2011-03-30  Adam Barth  <abarth@webkit.org>
774
775         Remove platform/chromium-mac-snowleopard
776         https://bugs.webkit.org/show_bug.cgi?id=57486
777
778         This directory no longer exists, so we can remove it from the fallback
779         chain.
780
781         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
782
783 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
784
785         Reviewed by Adam Roben.
786
787         Rename Windows configuration Release_LTCG to Production for clarity
788         https://bugs.webkit.org/show_bug.cgi?id=57465
789
790         * DumpRenderTree/DumpRenderTree.sln:
791         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
792         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
793         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
794         * DumpRenderTree/win/DumpRenderTree.vcproj:
795         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
796         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
797         * DumpRenderTree/win/ImageDiff.vcproj:
798         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
799         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
800         * FindSafari/FindSafari.vcproj:
801         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
802         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
803         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
804         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
805         * MiniBrowser/MiniBrowser.vcproj:
806         * Scripts/webkitdirs.pm:
807         * TestWebKitAPI/win/TestWebKitAPI.sln:
808         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
809         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
810         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
811         * WebKitAPITest/WebKitAPITest.vcproj:
812         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
813         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
814         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
815         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
816         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
817         * WebKitTestRunner/WebKitTestRunner.sln:
818         * WebKitTestRunner/win/InjectedBundle.vcproj:
819         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
820         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
821         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
822         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
823         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
824         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
825         * WinLauncher/WinLauncher.vcproj:
826         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
827         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
828         * record-memory-win/record-memory-win.vcproj:
829         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
830         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
831
832 2011-03-30  MORITA Hajime  <morrita@google.com>
833
834         Reviewed by Dimitri Glazkov.
835
836         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
837         https://bugs.webkit.org/show_bug.cgi?id=56573
838
839         Added LayoutTestController.shadowRoot() to Chromium DRT.
840
841         * DumpRenderTree/chromium/LayoutTestController.cpp:
842         (LayoutTestController::LayoutTestController):
843         (LayoutTestController::shadowRoot):
844         * DumpRenderTree/chromium/LayoutTestController.h:
845
846 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
847
848         Reviewed by Kent Tamura.
849
850         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
851         https://bugs.webkit.org/show_bug.cgi?id=57430
852
853         * DumpRenderTree/chromium/LayoutTestController.cpp:
854         (LayoutTestController::LayoutTestController):
855         (LayoutTestController::setPluginsEnabled):
856         * DumpRenderTree/chromium/LayoutTestController.h:
857
858 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
859
860         Reviewed by Adam Barth.
861
862         make webkit-patch upload respect -d
863         https://bugs.webkit.org/show_bug.cgi?id=57425
864
865         * Scripts/webkitpy/common/checkout/scm.py:
866         * Scripts/webkitpy/tool/steps/commit.py:
867
868 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
869
870         Reviewed by Adam Barth.
871
872         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
873         https://bugs.webkit.org/show_bug.cgi?id=57429
874
875         * Scripts/webkitpy/common/checkout/scm.py:
876
877 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
878
879         Unreviewed, rolling out r82383.
880         http://trac.webkit.org/changeset/82383
881         https://bugs.webkit.org/show_bug.cgi?id=57417
882
883         "nrwt isn't shutting down cleanly" (Requested by dpranke on
884         #webkit).
885
886         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
887         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
888         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
889
890 2011-03-29  Kent Tamura  <tkent@chromium.org>
891
892         Reviewed by Dimitri Glazkov.
893
894         Make validation message bubble testable
895         https://bugs.webkit.org/show_bug.cgi?id=57290
896
897         * DumpRenderTree/mac/DumpRenderTree.mm:
898         (createWebViewAndOffscreenWindow): Change a setting so that validation
899           bubbles isn't hidden automatically.
900
901 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
902
903         Reviewed by Ojan Vafai.
904
905         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
906
907         It's a bit unclear whether multiple threads or multiple
908         processes will be a better model on windows. This change will
909         test threads for now while we're still working out the bugs in
910         multiple-processes.
911
912         https://bugs.webkit.org/show_bug.cgi?id=57410
913
914         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
915         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
916         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
917
918 2011-03-29  David Levin  <levin@chromium.org>
919
920         Reviewed by Shinichiro Hamaji.
921
922         check-webkit-style confused by two ChangeLog entries in a row from same user
923         https://bugs.webkit.org/show_bug.cgi?id=57250
924
925         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
926         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
927         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
928           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
929           checking more than that would be very messey.
930         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
931         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
932
933 2011-03-29  Kent Tamura  <tkent@chromium.org>
934
935         Reviewed by Dimitri Glazkov.
936
937         [Mac] Enable interactive-validation tests on Mac DRT
938         https://bugs.webkit.org/show_bug.cgi?id=57308
939
940         * DumpRenderTree/mac/DumpRenderTree.mm:
941         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
942
943 2011-03-29  Chang Shu  <cshu@webkit.org>
944
945         Reviewed by Kenneth Rohde Christiansen.
946
947         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
948         https://bugs.webkit.org/show_bug.cgi?id=42692
949
950         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
951         (WTR::InjectedBundle::beginTesting):
952         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
953         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
954         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
955
956 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
957
958         Reviewed by Xan Lopez.
959
960         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
961         https://bugs.webkit.org/show_bug.cgi?id=57067
962
963         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
964         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
965         update DRT and pixel results as hundreds of results will need to be updated.
966
967         * DumpRenderTree/gtk/DumpRenderTree.cpp:
968         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
969         by overriding the theme RC/CSS files.
970
971 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
972
973         Reviewed by Adam Roben.
974
975         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
976         https://bugs.webkit.org/show_bug.cgi?id=57394
977
978         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
979         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
980         the IDE. To avoid this, add a separate vsprops file for each project configuration that
981         contains the required inherited property sheets.
982
983         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
984         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
985         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
986         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
987         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
988         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
989         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
990         * DumpRenderTree/win/DumpRenderTree.vcproj:
991         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
992         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
993         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
994         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
995         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
996         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
997         * DumpRenderTree/win/ImageDiff.vcproj:
998         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
999         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
1000         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
1001         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
1002         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
1003         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
1004         * FindSafari/FindSafari.vcproj:
1005         * FindSafari/FindSafariDebug.vsprops: Added.
1006         * FindSafari/FindSafariDebugAll.vsprops: Added.
1007         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
1008         * FindSafari/FindSafariRelease.vsprops: Added.
1009         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
1010         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
1011         * FindSafari/FindSafariReleasePGO.vsprops: Added.
1012         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
1013         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
1014         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
1015         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
1016         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
1017         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
1018         * MiniBrowser/MiniBrowser.vcproj:
1019         * WebKitAPITest/WebKitAPITest.vcproj:
1020         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
1021         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
1022         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
1023         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
1024         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
1025         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
1026         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1027         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
1028         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
1029         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
1030         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
1031         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
1032         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
1033         * WebKitTestRunner/win/InjectedBundle.vcproj:
1034         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
1035         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
1036         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
1037         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
1038         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
1039         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
1040         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1041         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
1042         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
1043         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
1044         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
1045         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
1046         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
1047         * WinLauncher/WinLauncher.vcproj:
1048         * WinLauncher/WinLauncherDebug.vsprops: Added.
1049         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
1050         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
1051         * WinLauncher/WinLauncherRelease.vsprops: Added.
1052         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
1053         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
1054         * record-memory-win/record-memory-win.vcproj:
1055         * record-memory-win/record-memory-winDebug.vsprops: Added.
1056         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
1057         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
1058         * record-memory-win/record-memory-winRelease.vsprops: Added.
1059         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
1060         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
1061
1062 2011-03-29  Adam Barth  <abarth@webkit.org>
1063
1064         Reviewed by Darin Adler.
1065
1066         test_runner2.py can crash due to undefined variable
1067         https://bugs.webkit.org/show_bug.cgi?id=57356
1068
1069         Replace reference to undefined variable with a variable that's actually
1070         defined.  AFAICT, there's no way to test this code.
1071
1072         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1073
1074 2011-03-29  Tony Chang  <tony@chromium.org>
1075
1076         Reviewed by Eric Seidel.
1077
1078         cleanup rebaseline-chromium-webkit-tests
1079         https://bugs.webkit.org/show_bug.cgi?id=57375
1080
1081         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1082             - Split _extract_and_add_new_baselines into 3 functions
1083             - Reduce the amount of line wrapping (the file already has lines
1084               over 80 col, so may as well try to make the file consistent)
1085             - Remove unnecessary ()s
1086
1087 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
1088
1089         Reviewed by Adam Roben.
1090
1091         Make WinCairo a core builder.
1092         https://bugs.webkit.org/show_bug.cgi?id=57373
1093
1094         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
1095         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
1096
1097 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1098
1099         Update update-webkit-localizable-strings to understand that WebKit and
1100         WebKit2 strings go in WebCore.
1101
1102         Also make extract-localizable-strings optionally use an exclude file. No individual
1103         warnings are produced about unlocalized strings when there is no exclude file. This
1104         is needed for WebCore, since there are too many bare strings.
1105
1106         https://webkit.org/b/57354
1107
1108         Reviewed by Sam Weinig.
1109
1110         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
1111         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
1112
1113 2011-03-29  Darin Adler  <darin@apple.com>
1114
1115         Reviewed by Adam Roben.
1116
1117         WebKit2 bundle page needs to offer generated file hooks
1118         https://bugs.webkit.org/show_bug.cgi?id=57279
1119
1120         (Land missing part of the original patch after r82289.)
1121
1122         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1123         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
1124
1125 2011-03-29  Tony Chang  <tony@chromium.org>
1126
1127         Reviewed by Ojan Vafai.
1128
1129         [chromium] NRWT should be able to read checksums from png comments
1130         https://bugs.webkit.org/show_bug.cgi?id=57280
1131
1132         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
1133             from a file.
1134         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
1135         * Scripts/webkitpy/common/system/filesystem_mock.py:
1136         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
1137             if the -checksum.txt file doesn't exist, try looking in the png.
1138         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1139         * Scripts/webkitpy/layout_tests/port/test.py:
1140         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
1141             2k for a png comment with the checksum
1142         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
1143
1144 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1145
1146         Rubber-stamped by Gustavo Noronha Silva.
1147
1148         [GTK] http/tests/uri/username-with-no-hostname.html fails
1149         https://bugs.webkit.org/show_bug.cgi?id=57325
1150
1151         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1152         (willSendRequestCallback): URI host value check done case-insensitively.
1153
1154 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1155
1156         Reviewed by Martin Robinson.
1157
1158         [GTK] http/tests/uri/username-with-no-hostname.html fails
1159         https://bugs.webkit.org/show_bug.cgi?id=57325
1160
1161         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1162         (willSendRequestCallback): Check URI before submitting the request
1163         to WebCore.
1164
1165 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
1166
1167         Reviewed by Ojan Vafai.
1168
1169         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
1170         https://bugs.webkit.org/show_bug.cgi?id=57303
1171
1172         * DumpRenderTree/chromium/EventSender.cpp:
1173         (EventSender::doDragDrop):
1174         (EventSender::beginDragWithFiles):
1175
1176 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
1177
1178         Reviewed by Andreas Kling.
1179
1180         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
1181         https://bugs.webkit.org/show_bug.cgi?id=57314
1182
1183         Provide possibility to print loaded urls to the standard output.
1184
1185         * MiniBrowser/qt/BrowserWindow.cpp:
1186         (BrowserWindow::BrowserWindow):
1187         (BrowserWindow::printURL):
1188         * MiniBrowser/qt/BrowserWindow.h:
1189         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1190         (MiniBrowserApplication::handleUserOptions):
1191         * MiniBrowser/qt/MiniBrowserApplication.h:
1192         (WindowOptions::WindowOptions):
1193         * QtTestBrowser/launcherwindow.cpp:
1194         (LauncherWindow::initializeView):
1195         (LauncherWindow::printURL):
1196         (LauncherWindow::cloneWindow):
1197         * QtTestBrowser/launcherwindow.h:
1198         (WindowOptions::WindowOptions):
1199         * QtTestBrowser/main.cpp:
1200         (LauncherApplication::handleUserOptions):
1201
1202 2011-03-29  Gabor Loki  <loki@webkit.org>
1203
1204         Rubber-stamped by Csaba Osztrogonác.
1205
1206         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1207         https://bugs.webkit.org/show_bug.cgi?id=56918
1208
1209         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
1210
1211 2011-03-28  Gabor Loki  <loki@webkit.org>
1212
1213         Reviewed by Csaba Osztrogonác.
1214
1215         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1216         https://bugs.webkit.org/show_bug.cgi?id=56918
1217
1218         * Scripts/build-jsc:
1219         * Scripts/webkitdirs.pm:
1220
1221 2011-03-28  Andrew Foster  <andrewf@chromium.org>
1222
1223         Reviewed by Ojan Vafai.
1224
1225         webkit-patch should be more intelligent about whether a bug applies to a patch
1226         Create a new function, parse_bug_id_from_changelog() which determines
1227         that a bug is related to a patch by parsing the output generated from
1228         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
1229         the description of a patch.
1230         https://bugs.webkit.org/show_bug.cgi?id=56989
1231
1232         * Scripts/webkitpy/common/checkout/api.py:
1233         * Scripts/webkitpy/common/checkout/changelog.py:
1234         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
1235         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1236         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1237         * Scripts/webkitpy/style/checkers/changelog.py:
1238         * Scripts/webkitpy/tool/commands/upload.py:
1239
1240 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
1241
1242         Revert accidentally commited change.
1243
1244         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1245         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1246
1247 2011-03-28  Tony Chang  <tony@chromium.org>
1248
1249         Reviewed by Adam Barth.
1250
1251         [chromium] have DRT write the png checksum into a png comment
1252         https://bugs.webkit.org/show_bug.cgi?id=57255
1253
1254         * DumpRenderTree/chromium/TestShell.cpp:
1255         (TestShell::dumpImage):
1256
1257 2011-03-28  Adele Peterson  <adele@apple.com>
1258
1259         Removing Qt stub, since it doesn't use the same header as the others.
1260
1261         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1262
1263 2011-03-28  Adele Peterson  <adele@apple.com>
1264
1265         Added a few more stubs.
1266
1267         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1268         (LayoutTestController::hasGrammarMarker):
1269         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1270         (LayoutTestController::hasGrammarMarker):
1271         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1272         (LayoutTestController::hasGrammarMarker):
1273
1274 2011-03-28  Adele Peterson  <adele@apple.com>
1275
1276         Build fix.
1277
1278         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1279         (LayoutTestController::hasGrammarMarker):
1280
1281 2011-03-28  Adele Peterson  <adele@apple.com>
1282
1283         Reviewed by Eric Seidel.
1284
1285         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1286         https://bugs.webkit.org/show_bug.cgi?id=57173
1287
1288         * DumpRenderTree/LayoutTestController.cpp:
1289         (hasGrammarMarkerCallback): Added.
1290         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
1291         * DumpRenderTree/LayoutTestController.h:
1292         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
1293         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
1294
1295 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1296
1297         Reviewed by Benjamin Poulain.
1298
1299         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1300         https://bugs.webkit.org/show_bug.cgi?id=57087
1301
1302         Trivial typo fix after r82082.
1303
1304         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1305         (WTR::activateFonts):
1306
1307 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
1308
1309         Reviewed by Andreas Kling.
1310
1311         Add myself to the committers list.
1312
1313         * Scripts/webkitpy/common/config/committers.py:
1314
1315 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
1316
1317         Reviewed by Sam Weinig.
1318
1319         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
1320         to link against WebKit.framework for now.
1321
1322         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1323
1324 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1325
1326         Reviewed by Andreas Kling.
1327
1328         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1329         https://bugs.webkit.org/show_bug.cgi?id=57087
1330
1331         Disable QT_ASCII_CAST_WARNINGS for applications.
1332
1333         * DumpRenderTree/qt/DumpRenderTree.pro:
1334         * DumpRenderTree/qt/ImageDiff.pro:
1335         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1336         * MiniBrowser/qt/MiniBrowser.pro:
1337         * QtTestBrowser/QtTestBrowser.pro:
1338         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1339
1340 2011-03-28  Andreas Kling  <kling@webkit.org>
1341
1342         Reviewed by Kenneth Rohde Christiansen.
1343
1344         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1345         https://bugs.webkit.org/show_bug.cgi?id=57224
1346
1347         * QtTestBrowser/mainwindow.cpp:
1348         (MainWindow::buildUI):
1349         (MainWindow::onTitleChanged):
1350         * QtTestBrowser/mainwindow.h:
1351
1352 2011-03-27  Jer Noble  <jer.noble@apple.com>
1353
1354         Reviewed by Maciej Stachowiak.
1355
1356         Full Screen: disable keyboard access by default
1357         https://bugs.webkit.org/show_bug.cgi?id=56684
1358
1359         Accept the withKeyboard parameter to supportsFullScreenForElement.
1360
1361         * DumpRenderTree/mac/UIDelegate.mm:
1362         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1363
1364 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1365
1366         Reviewed by David Levin.
1367
1368         check-webkit-style should check ChangeLog for a valid bug number
1369         https://bugs.webkit.org/show_bug.cgi?id=57184
1370
1371         * Scripts/webkitpy/style/checker.py:
1372         * Scripts/webkitpy/style/checker_unittest.py:
1373         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1374         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1375
1376 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1377
1378         Reviewed by Andreas Kling.
1379
1380         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1381         https://bugs.webkit.org/show_bug.cgi?id=57087
1382
1383         Use explicit conversion for string to avoid depending on the default codec
1384         installed by the user code.
1385
1386         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1387         (WTR::activateFonts):
1388
1389 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1390
1391         Revert inadvertantly committed changes.
1392
1393         * Scripts/old-run-webkit-tests:
1394         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1395
1396 2011-03-26  Andreas Kling  <kling@webkit.org>
1397
1398         Reviewed by Kenneth Rohde Christiansen.
1399
1400         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1401         https://bugs.webkit.org/show_bug.cgi?id=57162
1402
1403         * QtTestBrowser/QtTestBrowser.qrc:
1404         * QtTestBrowser/favicon.png: Added.
1405         * QtTestBrowser/locationedit.cpp:
1406         (defaultPageIcon):
1407         (LocationEdit::LocationEdit):
1408         (LocationEdit::setPageIcon):
1409         (LocationEdit::resizeEvent):
1410         (LocationEdit::updateInternalGeometry):
1411         * QtTestBrowser/locationedit.h:
1412         * QtTestBrowser/mainwindow.cpp:
1413         (MainWindow::buildUI):
1414         (MainWindow::onIconChanged):
1415         (MainWindow::onLoadStarted):
1416         * QtTestBrowser/mainwindow.h:
1417
1418 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1419
1420         Reviewed by Xan Lopez.
1421
1422         [GTK] Force DumpRenderTree to use 96 DPI
1423         https://bugs.webkit.org/show_bug.cgi?id=56866
1424
1425         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1426         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1427
1428         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1429         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1430         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1431         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1432
1433 2011-03-25  Andy Estes  <aestes@apple.com>
1434
1435         Reviewed by Adele Peterson.
1436
1437         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1438         https://bugs.webkit.org/show_bug.cgi?id=49016
1439
1440         TestNetscapePlugIn needs to register support for an image MIME type so
1441         we can test that the embed tag prefers plug-ins to render image MIME
1442         types.
1443
1444         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1445         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1446         (NP_GetMIMEDescription): Ditto.
1447         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1448
1449 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1450
1451         Reviewed by Sam Weinig.
1452
1453         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1454         https://bugs.webkit.org/show_bug.cgi?id=50780
1455
1456         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1457
1458         The test is named "CookieManager" so that we can eventually exercise more of the
1459         CookieManager functionality in the test.
1460
1461         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1462         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1463         Assert that the policy returned is equal to the policy set in
1464         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1465         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1466         Set the policy to something different than the user's policy and get the policy again.
1467         (TestWebKitAPI::didFinishLoadForFrame):
1468         Get the user's policy so that it can be restored at the end of the test.
1469         (TestWebKitAPI::TEST):
1470         Load about:blank so that the Web Process gets instatiated (needed to get the
1471         CookieManager).
1472
1473         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1474         Add CookieManager.cpp.
1475
1476 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1477
1478         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1479
1480         * wx/build/settings.py:
1481
1482 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1483
1484         Reviewed by Adam Roben.
1485
1486         Implement layoutTestController.setAutoFilled in DRT on Windows
1487         https://bugs.webkit.org/show_bug.cgi?id=56828
1488
1489         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1490         (LayoutTestController::setAutofilled): Implemented.
1491
1492 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1493
1494         Unreviewed build correction.
1495
1496         Correct vsprops file for Debug variant of the CFLite build.
1497         Disable a CFNETWORK-specific test when building for CFLite.
1498
1499         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1500         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1501
1502 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1503
1504         Reviewed by Adam Barth.
1505
1506         fix regressions introduced in 81908 - there were a couple of
1507         code paths that only fired under python 2.5 that I missed.
1508
1509         Also change a couple of 'python' references to sys.executable
1510         in order to handle runing test-webkitpy with a binary other than
1511         something called 'python'.
1512
1513         https://bugs.webkit.org/show_bug.cgi?id=57063
1514
1515         * Scripts/webkitpy/layout_tests/port/mac.py:
1516         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1517         * Scripts/webkitpy/test/cat.py:
1518         * Scripts/webkitpy/test/echo.py:
1519
1520 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1521
1522         Unreviewed build correction.
1523
1524         Add a stub implementation of the TestInvocation dumping logic.
1525         Update project files to reflect new file.
1526
1527         * WebKitTestRunner/cairo: Added.
1528         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1529         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1530         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1531
1532 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1533
1534         Reviewed by Tony Chang.
1535
1536         new-run-webkit-tests: clean up worker model defaults. This
1537         changes the default behavior to 'threads' instead of
1538         'old-threads', and clarifies that chromium-win-* and
1539         chromium-mac-leopard are exceptions.
1540
1541         https://bugs.webkit.org/show_bug.cgi?id=56971
1542
1543         * Scripts/webkitpy/layout_tests/port/base.py:
1544         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1545         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1546         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1547         * Scripts/webkitpy/layout_tests/port/test.py:
1548         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1549
1550 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1551
1552         Reviewed by Darin Adler.
1553
1554         Media Stream API: fix the order of the options in build-webkit.
1555         https://bugs.webkit.org/show_bug.cgi?id=56949
1556
1557         Fix the order of the options in build-webkit.
1558
1559         * Scripts/build-webkit:
1560
1561 2011-03-23  Adam Klein  <adamk@chromium.org>
1562
1563         Reviewed by Mihai Parparita.
1564
1565         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1566         https://bugs.webkit.org/show_bug.cgi?id=56884
1567
1568         This option will be utilized by Chromium's ui_tests to allow
1569         referencing js-test-resources from a layout test over HTTP.
1570
1571         * Scripts/new-run-webkit-httpd:
1572         Added --layout_tests_dir option.
1573         * Scripts/webkitpy/layout_tests/port/http_server.py:
1574         Plumbed through as layout_tests_dir param.
1575
1576 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1577
1578         Reviewed by Mihai Parparita.
1579
1580         new-run-webkit-tests: run tests in ascending alphabetical order per
1581         dir. This is a second attempt at the fix; the first attempt, in 
1582         r81597, broke the behavior on the old-inline and old-threads
1583         worker models.
1584
1585         https://bugs.webkit.org/show_bug.cgi?id=56760
1586
1587         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1588         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1589         * Scripts/webkitpy/layout_tests/port/test.py:
1590         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1591
1592 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1593
1594         Reviewed by Martin Robinson.
1595
1596         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1597         https://bugs.webkit.org/show_bug.cgi?id=56953
1598
1599         Print the string for the detail of 'property-change' signal.
1600
1601         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1602         (axObjectEventListener): Print the detail string.
1603
1604 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1605
1606         Reviewed by Pavel Feldman.
1607
1608         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1609         https://bugs.webkit.org/show_bug.cgi?id=56843
1610
1611         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1612         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1613
1614 2011-03-22  Eric Seidel  <eric@webkit.org>
1615
1616         Reviewed by Adam Barth.
1617
1618         Teach update-webkit about gyp
1619         https://bugs.webkit.org/show_bug.cgi?id=56881
1620
1621         This makes it possible for someone who builds from Xcode
1622         to just run update-webkit --gyp and have the project files
1623         generated after update automatically.
1624
1625         I also added a stand-alone "generate-project-files" script
1626         wrapping Source/gyp/configure.  This makes running gyp simpler
1627         since most people will not have gyp or Source/gyp in their path.
1628
1629         * Scripts/build-webkit:
1630         * Scripts/generate-project-files: Added.
1631         * Scripts/update-webkit:
1632
1633 2011-03-22  Anton D'Auria  <adauria@apple.com>
1634
1635         Reviewed by Alexey Proskuryakov.
1636
1637         Add +[WebApplicationCache getOriginsWithCache]
1638         https://bugs.webkit.org/show_bug.cgi?id=56722
1639
1640         * DumpRenderTree/LayoutTestController.cpp:
1641         (originsWithApplicationCacheCallback):
1642         (LayoutTestController::staticFunctions):
1643         * DumpRenderTree/LayoutTestController.h:
1644         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1645         (LayoutTestController::originsWithApplicationCache):
1646         * DumpRenderTree/chromium/LayoutTestController.h:
1647         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1648         (LayoutTestController::originsWithApplicationCache):
1649         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1650         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1651         (LayoutTestController::originsWithApplicationCache):
1652         (LayoutTestController::originsWithLocalStorage):
1653         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1654         (LayoutTestController::originsWithApplicationCache):
1655         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1656         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1657         (LayoutTestController::originsWithApplicationCache):
1658         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1659         (LayoutTestController::originsWithApplicationCache):
1660
1661 2011-03-22  Eric Seidel  <eric@webkit.org>
1662
1663         Reviewed by Adam Barth.
1664
1665         Add support to build-webkit for building with gyp-generated project files
1666         https://bugs.webkit.org/show_bug.cgi?id=56877
1667
1668         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1669         Eventually we'll want to support gyp-generated projects in a more general manner.
1670
1671         * Scripts/build-webkit:
1672
1673 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1674
1675         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1676
1677         Reviewed by Joseph Pecoraro.
1678
1679         * Scripts/build-webkit: Updated usage statement to include
1680         --dsym.
1681         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1682         (generateDsym): Added. Call determineGenerateDsym() and
1683         return $generateDsym.
1684         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1685         $generateDsym.
1686         (argumentsForXcode): Added.  Returns additional arguments for
1687         xcodebuild based on command-line switches.
1688         (XcodeOptions): Updated to include argumentsForXcode() in the
1689         array returned.
1690
1691 2011-03-22  Adam Roben  <aroben@apple.com>
1692
1693         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1694
1695         These bots are consistently green again.
1696
1697         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1698         core builders
1699
1700         Rubber-stamped by Antti Koivisto.
1701
1702         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1703         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1704
1705         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1706         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1707
1708 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1709
1710         Unreviewed, rolling out r81597.
1711         http://trac.webkit.org/changeset/81597
1712         https://bugs.webkit.org/show_bug.cgi?id=56801
1713
1714         Change results in lots of unexpected flaky on the dashboard.
1715         (Requested by pfeldman on #webkit).
1716
1717         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1718         * Scripts/webkitpy/layout_tests/port/test.py:
1719         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1720
1721 2011-03-21  Sam Weinig  <sam@webkit.org>
1722
1723         Fix failing tests on the WebKit2 bots.
1724
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::TestController::resetStateToConsistentValues):
1727
1728 2011-03-21  Daniel Sievers  <sievers@google.com>
1729
1730         Reviewed by Simon Fraser.
1731
1732         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1733         https://bugs.webkit.org/show_bug.cgi?id=56139
1734
1735         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1736         (main):
1737         * DumpRenderTree/chromium/LayoutTestController.cpp:
1738         (LayoutTestController::LayoutTestController):
1739         (LayoutTestController::layerTreeAsText):
1740         * DumpRenderTree/chromium/LayoutTestController.h:
1741         (LayoutTestController::setShowDebugLayerTree):
1742         * DumpRenderTree/chromium/TestShell.cpp:
1743         (TestShell::runFileTest):
1744         (TestShell::dump):
1745         * DumpRenderTree/chromium/TestShell.h:
1746         (TestParams::TestParams):
1747
1748 2011-03-21  Adam Roben  <aroben@apple.com>
1749
1750         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1751
1752         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1753         output as plain text
1754
1755         Reviewed by David Kilzer.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1758         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1759         to the master.
1760         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1761         since we're running on the build master, not the slave. Instead, turn the raw source of
1762         actual.html which the build slave uploaded into an HTML log.
1763
1764 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1765
1766         Reviewed by Mihai Parparita.
1767
1768         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1769         https://bugs.webkit.org/show_bug.cgi?id=56760
1770
1771         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1772         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1773         * Scripts/webkitpy/layout_tests/port/test.py:
1774
1775 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1776
1777         Reviewed by Steve Block.
1778
1779         Media Stream API patch 0: adding compilation guards.
1780         https://bugs.webkit.org/show_bug.cgi?id=56458
1781
1782         Adding options to enable the media stream API feature in Chromium.
1783
1784         * Scripts/build-webkit:
1785
1786 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1787
1788         Reviewed by Laszlo Gombos.
1789
1790         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1791         https://bugs.webkit.org/show_bug.cgi?id=56323
1792
1793         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1794         "--stdout" or "--stderr" option.
1795
1796         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1797         (WebCore::DumpRenderTree::~DumpRenderTree):
1798         (WebCore::DumpRenderTree::processArgsLine):
1799         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1800         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1801         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1802         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1803         * DumpRenderTree/qt/main.cpp:
1804         (isOption):
1805         (takeOptionValue):
1806         (printUsage):
1807         (main):
1808
1809 2011-03-21  Adam Roben  <aroben@apple.com>
1810
1811         Fix exceptions on the buildbot due to my last change
1812
1813         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1814         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1815
1816 2011-03-21  Adam Roben  <aroben@apple.com>
1817
1818         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1819
1820         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1821         output as plain text
1822
1823         Reviewed by Darin Adler.
1824
1825         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1826         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1827         logs.
1828         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1829         the build master. This will correctly treat it as HTML.
1830
1831 2011-03-20  Bill Budge  <bbudge@chromium.org>
1832
1833         Reviewed by Adam Barth.
1834
1835         Rename ThreadSafeShared to ThreadSafeRefCounted
1836         https://bugs.webkit.org/show_bug.cgi?id=56714
1837
1838         No new tests. Exposes no new functionality.
1839
1840         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1841         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1842         * Scripts/do-webcore-rename:
1843
1844 2011-03-19  Anton D'Auria  <adauria@apple.com>
1845
1846         Reviewed by Dan Bernstein.
1847
1848         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1849         https://bugs.webkit.org/show_bug.cgi?id=56719
1850
1851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1852         (LayoutTestController::clearApplicationCacheForOrigin):
1853
1854 2011-03-19  Anton D'Auria  <adauria@apple.com>
1855
1856         Reviewed by Alexey Proskuryakov.
1857
1858         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1859         https://bugs.webkit.org/show_bug.cgi?id=56415
1860
1861         * DumpRenderTree/LayoutTestController.cpp:
1862         (clearApplicationCacheForOriginCallback):
1863         (LayoutTestController::staticFunctions):
1864         * DumpRenderTree/LayoutTestController.h:
1865         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1866         (LayoutTestController::LayoutTestController):
1867         (LayoutTestController::clearAllApplicationCaches):
1868         (LayoutTestController::clearApplicationCacheForOrigin): 
1869         * DumpRenderTree/chromium/LayoutTestController.h:
1870         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1871         (LayoutTestController::clearApplicationCacheForOrigin):
1872         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1873         (LayoutTestController::clearApplicationCacheForOrigin):
1874         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1875         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1876         (LayoutTestController::clearApplicationCacheForOrigin):
1877         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1878         (LayoutTestController::clearApplicationCacheForOrigin):
1879
1880 2011-03-18  Dan Bernstein  <mitz@apple.com>
1881
1882         Revised build fix for r81135.
1883
1884         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1885         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1886
1887 2011-03-18  Adam Roben  <aroben@apple.com>
1888
1889         Windows build fix
1890
1891         * WebKitTestRunner/config.h: Add a missing #endif.
1892
1893 2011-03-18  Andreas Kling  <kling@webkit.org>
1894
1895         Unbreak Qt build after r81494.
1896
1897         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1898         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1899
1900 2011-03-18  Sam Weinig  <sam@webkit.org>
1901
1902         Fix windows build. This was really Adam Roben's fault. I swear!
1903
1904         * WebKitTestRunner/config.h:
1905
1906 2011-03-18  Sam Weinig  <sam@webkit.org>
1907
1908         Reviewed by Adam Roben.
1909
1910         Pixel tests don't work in WebKitTestRunner on Windows
1911         https://bugs.webkit.org/show_bug.cgi?id=56630
1912
1913         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1914         built-in snapshotting instead of using the window server on the Mac.
1915
1916         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1917         (WTR::InjectedBundle::InjectedBundle):
1918         (WTR::InjectedBundle::didReceiveMessage):
1919         (WTR::InjectedBundle::beginTesting):
1920         (WTR::InjectedBundle::done):
1921         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1922         (WTR::InjectedBundle::setPixelResult):
1923         (WTR::InjectedBundle::shouldDumpPixels):
1924         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1925         (WTR::InjectedBundlePage::dump):
1926         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1927
1928         * WebKitTestRunner/TestInvocation.cpp:
1929         (WTR::TestInvocation::invoke):
1930         (WTR::TestInvocation::dump):
1931         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1932         * WebKitTestRunner/TestInvocation.h:
1933         * WebKitTestRunner/cg: Added.
1934         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1935         (WTR::createCGContextFromImage):
1936         (WTR::computeMD5HashStringForContext):
1937         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1938         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1939         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1940
1941         * WebKitTestRunner/win/TestInvocationWin.cpp:
1942         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1943         Keep stub for Cairo build.
1944
1945         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1946         Add CG configuration.
1947
1948         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1949         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1950         Add new files.
1951
1952 2011-03-18  Adam Roben  <aroben@apple.com>
1953
1954         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1955
1956         Rubber-stamped by Simon Fraser.
1957
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1959         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1960         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1961
1962 2011-03-18  Adam Roben  <aroben@apple.com>
1963
1964         Don't ellipsize long or indented function names in Leaks Viewer
1965
1966         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1967         scrollbar
1968
1969         Reviewed by Simon Fraser.
1970
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1972         (.data-grid .data-container):
1973         (.data-grid td > div, .data-grid th > div):
1974         Allow the contents to extend to the right.
1975
1976 2011-03-18  Adam Roben  <aroben@apple.com>
1977
1978         Fix some leaks in DRT seen on the leaks bot
1979
1980         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1981         setWillSendRequestClearHeaderCallback in DRT are leaky
1982
1983         Reviewed by Alexey Proskuryakov.
1984
1985         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1986
1987         * DumpRenderTree/LayoutTestController.cpp:
1988         (addURLToRedirectCallback):
1989         (setWillSendRequestClearHeaderCallback):
1990         Use OwnArrayPtr to cause the strings to be deleted.
1991
1992 2011-03-18  Adam Roben  <aroben@apple.com>
1993
1994         Fix a NSURLCredential leak seen on the leaks bot
1995
1996         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1997         connection:didReceiveAuthenticationChallenge:] is leaky
1998
1999         Reviewed by John Sullivan.
2000
2001         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2002         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
2003         cause the NSURLCredential to be released.
2004
2005 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
2006
2007         Unreviewed.
2008
2009         Remove unnecessary brackets around my email address.
2010
2011         * Scripts/webkitpy/common/config/committers.py:
2012
2013 2011-03-18  Adam Roben  <aroben@apple.com>
2014         
2015         Remove some files I accidentally added in r81454
2016
2017         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2018         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2019
2020 2011-03-18  Adam Roben  <aroben@apple.com>
2021
2022         Ignore an NSNumberFormatter leak on SnowLeopard
2023
2024         * Scripts/old-run-webkit-tests:
2025         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
2026         getObjectValue:forString:errorDescription:].
2027
2028 2011-03-18  Adam Roben  <aroben@apple.com>
2029
2030         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
2031
2032         Rubber-stamped by Mark Rowe.
2033
2034         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2035         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
2036         released.
2037
2038 2011-03-17  Adam Roben  <aroben@apple.com>
2039
2040         Address a review comment I missed in r81445
2041
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2043         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
2044         leaked bytes to speed up searching on long lines.
2045
2046 2011-03-17  Adam Roben  <aroben@apple.com>
2047
2048         Mark leaky builds orange, even if all regression tests passed
2049
2050         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
2051         build.webkit.org when all tests pass even though there are still leaks
2052
2053         Reviewed by Dan Bernstein.
2054
2055         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2056         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
2057         be marked orange if this build step generates warnings.
2058
2059 2011-03-17  Adam Roben  <aroben@apple.com>
2060
2061         Allow values in Leaks Viewer to be shown as percentages
2062
2063         Double-clicking on a column will toggle between showing percentages and showing real values.
2064
2065         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
2066         number of leaked bytes in Leaks Viewer
2067
2068         Reviewed by Joe Pecoraro.
2069
2070         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2071         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
2072         node's totalTime, which is used in calculating percentages.
2073
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2075         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
2076         showing them as percentages.
2077
2078 2011-03-17  Adam Roben  <aroben@apple.com>
2079
2080         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
2081
2082         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
2083         the number of leaked allocations. And the new Average column shows the average number of
2084         leaked bytes per call.
2085
2086         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
2087         just how many allocations
2088
2089         Reviewed by Joe Pecoraro.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2092         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
2093         line and store it with the leak stack.
2094         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
2095         properties.
2096         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
2097         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
2098         .numberOfCalls now holds the number of leaked allocations.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2101         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
2102         appear.
2103         (monkeyPatchInspectorObjects): Format the values as bytes.
2104
2105 2011-03-17  Adam Roben  <aroben@apple.com>
2106
2107         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
2108
2109         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
2110         regression tests
2111
2112         Reviewed by James Robinson.
2113
2114         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2115         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
2116         is always populated, even when all regression tests pass.
2117
2118 2011-03-10  Hayato Ito  <hayato@chromium.org>
2119
2120         Reviewed by Tony Chang.
2121
2122         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
2123
2124         https://bugs.webkit.org/show_bug.cgi?id=56076
2125
2126         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2127
2128 2011-03-17  Adam Roben  <aroben@apple.com>
2129
2130         Skip a compositing-sensitive test when accelerated compositing is disabled
2131
2132         Reviewed by Sam Weinig.
2133
2134         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
2135         accelerated compositing is disabled.
2136
2137 2011-03-17  Adam Roben  <aroben@apple.com>
2138
2139         Start using PlatformSpecificScheduler for the Mac builders
2140
2141         The current set of file/directory patterns should work for Mac builders. We may discover
2142         that there are more files and directories we can exclude from the Mac builds, but they can
2143         be added later.
2144
2145         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
2146
2147         Reviewed by Mark Rowe.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
2150         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
2151
2152         * Scripts/webkitpy/common/config/build.py:
2153         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
2154         cleaned up patterns a little bit.
2155
2156         * Scripts/webkitpy/common/config/build_unittest.py:
2157         (ShouldBuildTest): Fixed some expected results.
2158         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
2159         platforms.
2160
2161 2011-03-17  Jeff Miller  <jeffm@apple.com>
2162
2163         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
2164         
2165         *.mode*
2166         *.pbxuser
2167         *.perspective*
2168         project.xcworkspace
2169         xcuserdata
2170
2171         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2172         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2173         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2174         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2175         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2176
2177 2011-03-17  Adam Roben  <aroben@apple.com>
2178
2179         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
2180
2181         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
2182         mac-wk2
2183
2184         Reviewed by Anders Carlsson.
2185
2186         * Scripts/old-run-webkit-tests:
2187         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
2188         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
2189         we're running in WebKit2 mode.
2190
2191 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
2192
2193         Reviewed by Yury Semikhatsky.
2194
2195         Web Inspector: Clean up Inspector strings.
2196         https://bugs.webkit.org/show_bug.cgi?id=56557
2197
2198         Modify the script to deal correctly with "\xNN" escapes, and to
2199         check strings in Chromium's DevTools.js.
2200
2201         * Scripts/check-inspector-strings:
2202
2203 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
2204
2205         Reviewed by Benjamin Poulain.
2206
2207         Update autoinstall to install mechanize 0.2.4
2208         https://bugs.webkit.org/show_bug.cgi?id=56499
2209
2210         Newer versions of mechanize support HTTPS proxies, which is necessary
2211         for people using webkit-patch behind firewalls.
2212
2213         * Scripts/webkitpy/common/system/autoinstall.py:
2214         * Scripts/webkitpy/thirdparty/__init__.py:
2215
2216 2011-03-16  Sam Weinig  <sam@webkit.org>
2217
2218         Reviewed by Adam Roben.
2219
2220         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
2221         https://bugs.webkit.org/show_bug.cgi?id=56541
2222
2223         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2224         (WTR::InjectedBundlePage::willSendRequestForFrame):
2225         Check for an empty host in addition to a null host.  This bug was introduced
2226         when porting off of the KURL code and onto the WKURLRef version.
2227
2228 2011-03-16  Sam Weinig  <sam@webkit.org>
2229
2230         Reviewed by Adam Roben.
2231
2232         Add Lucas Forschler to the list of WebKit committers.
2233
2234         * Scripts/webkitpy/common/config/committers.py:
2235
2236 2011-03-16  Sam Weinig  <sam@webkit.org>
2237
2238         Reviewed upon and dictated through Adam Roben.
2239
2240         Escape crashing function names in results.html. This fixes an issue
2241         when a crash involves a type with templates.
2242
2243         * Scripts/old-run-webkit-tests:
2244
2245 2011-03-16  Daniel Sievers  <sievers@google.com>
2246
2247         Reviewed by James Robinson.
2248
2249         Add setting to always force compositing mode
2250         https://bugs.webkit.org/show_bug.cgi?id=56156
2251
2252         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2253         (main):
2254         * DumpRenderTree/chromium/TestShell.cpp:
2255         (TestShell::TestShell):
2256         (TestShell::resetWebSettings):
2257         * DumpRenderTree/chromium/TestShell.h:
2258         (TestShell::setForceCompositingMode):
2259         * DumpRenderTree/chromium/WebPreferences.cpp:
2260         (WebPreferences::reset):
2261         (WebPreferences::applyTo):
2262         * DumpRenderTree/chromium/WebPreferences.h:
2263
2264 2011-03-15  Hayato Ito  <hayato@chromium.org>
2265
2266         Reviewed by Ojan Vafai.
2267
2268         Ignore files that will be used by reftests in old-run-webkit-tests.
2269
2270         https://bugs.webkit.org/show_bug.cgi?id=55936
2271
2272         * Scripts/old-run-webkit-tests:
2273
2274 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
2275
2276         Reviewed by Adam Roben.
2277
2278         Function relativeScriptsDir doesn't return the correct relative
2279         Scripts directory.
2280
2281         * Scripts/webkitdirs.pm:
2282         (relativeScriptsDir): Ensure we use the directory that contains
2283         webkitdirs.pm, not the one that contains the original script that
2284         was invoked.
2285
2286 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2287
2288         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
2289         fix to link against the Security framework after recent WebKitSystemInterface changes.
2290
2291         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2292         (LayoutTestController::originsWithLocalStorage):
2293         * wx/build/settings.py:
2294         * wx/build/waf_extensions.py:
2295
2296 2011-03-15  Sam Weinig  <sam@webkit.org>
2297
2298         Reviewed by Darin Adler.
2299
2300         Add script to convert a patch to a prettypatch and show in the default browser
2301         https://bugs.webkit.org/show_bug.cgi?id=56416
2302
2303         This can be used either like
2304             $ svn-create-patch | show-pretty-diff
2305         or
2306             $ show-pretty-diff patch.diff
2307
2308         * Scripts/show-pretty-diff: Added.
2309
2310 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
2311
2312         Rubber-stamped by Adam Roben.
2313
2314         Adding myself as a reviewer.
2315
2316         * Scripts/webkitpy/common/config/committers.py:
2317
2318 2011-03-15  Anders Carlsson  <andersca@apple.com>
2319
2320         Try to fix the Windows build.
2321
2322         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2323         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2324
2325 2011-03-15  Anders Carlsson  <andersca@apple.com>
2326
2327         Reviewed by Sam Weinig.
2328
2329         Make sure that NP_Shutdown is always the last NPP function called
2330         https://bugs.webkit.org/show_bug.cgi?id=56391
2331
2332         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
2333
2334         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2335         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2336         (PluginTest::PluginTest):
2337         (PluginTest::NP_Shutdown):
2338         (PluginTest::registerNPShutdownFunction):
2339         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2340         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2341         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2342         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2343         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2344         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2345         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2346         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2347         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2348         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2349         (NP_Shutdown):
2350         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2351         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2352         * GNUmakefile.am:
2353
2354 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2355
2356         Reviewed by Tony Chang.
2357
2358         Autofilled form elements are assigned fixed background color but not text color
2359         https://bugs.webkit.org/show_bug.cgi?id=48382
2360
2361         * DumpRenderTree/LayoutTestController.cpp:
2362         (setAutofilledCallback): Added.
2363         (LayoutTestController::staticFunctions):
2364         * DumpRenderTree/LayoutTestController.h:
2365         * DumpRenderTree/chromium/LayoutTestController.cpp:
2366         (LayoutTestController::LayoutTestController):
2367         (LayoutTestController::setAutofilled): Added.
2368         * DumpRenderTree/chromium/LayoutTestController.h:
2369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2370         (LayoutTestController::setAutofilled): Added.
2371         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2372         (LayoutTestController::setAutofilled): Added.
2373         (LayoutTestController::setValueForUser): Style tweak.
2374         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2375         (LayoutTestController::setAutofilled): Added (stub).
2376         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2377         (LayoutTestController::setAutofilled): Added (stub).
2378
2379 2011-03-15  Dan Bernstein  <mitz@apple.com>
2380
2381         Build fix after r81135.
2382
2383         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2384
2385 2011-03-15  Dan Bernstein  <mitz@apple.com>
2386
2387         Build fix after r81135.
2388
2389         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2390         * WebKitTestRunner/mac/TestControllerMac.mm:
2391         * WebKitTestRunner/mac/TestInvocationMac.mm:
2392         * WebKitTestRunner/mac/main.mm:
2393
2394 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2395
2396         Reviewed by Adam Barth.
2397
2398         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2399         https://bugs.webkit.org/show_bug.cgi?id=56349
2400
2401         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2402         on platforms where we use it. Copied from DumpRenderTree.pro.
2403
2404 2011-03-15  Dan Bernstein  <mitz@apple.com>
2405
2406         Build fix after r81135.
2407
2408         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2409         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2410
2411 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2412
2413         Reviewed by Darin Adler.
2414
2415         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2416         info into the headers rather than in export symbol definition files, but disable it on 
2417         all platforms initially so we can deal with port build issues one port at a time.
2418         
2419         https://bugs.webkit.org/show_bug.cgi?id=27551
2420
2421         * DumpRenderTree/cg/ImageDiffCG.cpp:
2422         * DumpRenderTree/chromium/config.h:
2423         * DumpRenderTree/config.h:
2424         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2425         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2426         * WebKitAPITest/HostWindow.cpp:
2427         * WebKitAPITest/TestsController.cpp:
2428         * WebKitAPITest/config.h: Added.
2429         * WebKitAPITest/main.cpp:
2430         * WebKitAPITest/tests/WebViewDestruction.cpp:
2431         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2432         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2433         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2434         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2435         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2436         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2437         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2438         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2439         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2440         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2441         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2442         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2443         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2444         * WebKitTestRunner/TestController.cpp:
2445         * WebKitTestRunner/TestInvocation.cpp:
2446         * WebKitTestRunner/config.h: Added.
2447         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2448         * WebKitTestRunner/qt/TestControllerQt.cpp:
2449         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2450         * WebKitTestRunner/qt/main.cpp:
2451         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2452         * WebKitTestRunner/win/TestControllerWin.cpp:
2453         * WebKitTestRunner/win/TestInvocationWin.cpp:
2454         * WebKitTestRunner/win/main.cpp:
2455         * wx/build/settings.py:
2456
2457 2011-03-15  Hayato Ito  <hayato@chromium.org>
2458
2459         Reviewed by Shinichiro Hamaji.
2460
2461         [NRWT] Add support for reftests to new-run-webkit-tests.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=55457
2464
2465         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2466         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2467         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2468         * Scripts/webkitpy/layout_tests/port/base.py:
2469         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2470         * Scripts/webkitpy/layout_tests/port/test.py:
2471         * Scripts/webkitpy/layout_tests/port/test_files.py:
2472         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2473
2474 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2475
2476         Reviewed by Martin Robinson.
2477
2478         [GTK] Fix compilation warning after r80892
2479         https://bugs.webkit.org/show_bug.cgi?id=56302
2480
2481         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2482         (LayoutTestController::originsWithLocalStorage):
2483
2484 2011-03-15  Robert Hogan  <robert@webkit.org>
2485
2486         Reviewed by Adam Barth.
2487
2488         Document the qmakearg argument, and hint how to build webkit2 on Qt
2489         https://bugs.webkit.org/show_bug.cgi?id=56326
2490
2491         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2492
2493 2011-03-15  Adam Roben  <aroben@apple.com>
2494
2495         Make Windows 7 Release (Tests) a core builder
2496
2497         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2498         give it a few more days of greenness first.
2499
2500         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2501
2502         Reviewed by Sam Weinig.
2503
2504         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2505         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2506
2507         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2508         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2509         Updated the core regexps to match the buildbot module. Updated the expected results to match
2510         the current set of core builders.
2511
2512 2011-03-14  Adam Roben  <aroben@apple.com>
2513
2514         Add forgotten file from r81116
2515
2516         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2517
2518 2011-03-14  Sam Weinig  <sam@webkit.org>
2519
2520         Reviewed by Adam Roben.
2521
2522         about:blank fake responses don't get serialized when sent the UIProcess
2523         <rdar://problem/9108119>
2524         https://bugs.webkit.org/show_bug.cgi?id=56357
2525
2526         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2527         (TestWebKitAPI::decidePolicyForResponse):
2528         (TestWebKitAPI::TEST):
2529         Add test that loads of about:blank have a response with a MIMEType of text/html.
2530
2531         * TestWebKitAPI/PlatformUtilities.h:
2532         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2533         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2534         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2535         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2536         Add helper to get the MIMEType from a WKURLResponse.
2537
2538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2539         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2540         Add new files.
2541
2542 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2543
2544         Reviewed by Kenneth Rohde Christiansen.
2545
2546         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2547         https://bugs.webkit.org/show_bug.cgi?id=56006
2548
2549         * QtTestBrowser/launcherwindow.cpp:
2550         (LauncherWindow::initializeView):
2551         * QtTestBrowser/main.cpp:
2552         (LauncherApplication::handleUserOptions):
2553
2554 2011-03-14  James Kozianski  <koz@chromium.org>
2555
2556         Reviewed by Ojan Vafai.
2557
2558         Add method to make BuildBot return test outputs
2559         https://bugs.webkit.org/show_bug.cgi?id=54374
2560
2561         The Builder.latest_cached_build will be used by the new rebaseline
2562         script to determine the build to use baselines from.
2563
2564         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2565         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2566
2567 2011-03-14  Adam Roben  <aroben@apple.com>
2568
2569         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2570
2571         Reviewed by Sam Weinig.
2572
2573         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2574         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2575         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2576         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2577         ensure the web process is initialized, then ask the bundle to run the test and assert that
2578         it succeeded.
2579
2580         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2581         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2582         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2583         handle a given URL.
2584         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2585         URL type cannot be handled).
2586         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2587         result.
2588
2589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2590         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2591         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2592         Added new files to the project.
2593
2594 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2595
2596         Unreviewed, rolling out r81094.
2597         http://trac.webkit.org/changeset/81094
2598         https://bugs.webkit.org/show_bug.cgi?id=56355
2599
2600         Broke the chromium DRT related build. (Requested by dave_levin
2601         on #webkit).
2602
2603         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2604         (main):
2605         * DumpRenderTree/chromium/LayoutTestController.cpp:
2606         (LayoutTestController::LayoutTestController):
2607         (LayoutTestController::layerTreeAsText):
2608         * DumpRenderTree/chromium/LayoutTestController.h:
2609         * DumpRenderTree/chromium/TestShell.cpp:
2610         (TestShell::runFileTest):
2611         (TestShell::dump):
2612         * DumpRenderTree/chromium/TestShell.h:
2613         (TestParams::TestParams):
2614
2615 2011-03-14  Daniel Sievers  <sievers@google.com>
2616
2617         Reviewed by Simon Fraser.
2618
2619         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2620         https://bugs.webkit.org/show_bug.cgi?id=56139
2621
2622         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2623         (main):
2624         * DumpRenderTree/chromium/LayoutTestController.cpp:
2625         (LayoutTestController::LayoutTestController):
2626         (LayoutTestController::layerTreeAsText):
2627         * DumpRenderTree/chromium/LayoutTestController.h:
2628         (LayoutTestController::setShowDebugLayerTree):
2629         * DumpRenderTree/chromium/TestShell.cpp:
2630         (TestShell::runFileTest):
2631         (TestShell::dump):
2632         * DumpRenderTree/chromium/TestShell.h:
2633         (TestParams::TestParams):
2634
2635 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2636
2637         Reviewed by Adam Roben.
2638
2639         [Qt][WK2]Unbreak InjectedBundle on Qt
2640         https://bugs.webkit.org/show_bug.cgi?id=54109
2641
2642         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2643         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2644         API's instead of KURL to analyze the URL.
2645         * WebKitTestRunner/StringFunctions.h:
2646         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2647         in the WebKitTestRunner project.
2648         (WTR::toWK): Use adoptWK.
2649         (WTR::operator<<): Added helper for printing a WKURL.
2650         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2651         against WebCore.
2652
2653 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2654
2655         Reviewed by Kenneth Rohde Christiansen.
2656
2657         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2658         https://bugs.webkit.org/show_bug.cgi?id=56321
2659
2660         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2661         to the list of exceptions for WebKit2 C API headers.
2662
2663 2011-03-14  Adam Roben  <aroben@apple.com>
2664
2665         Show the list of recent leaky builds in reverse chronological order
2666
2667         Previously they were being shown in a deterministic but surprising order based on
2668         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2669
2670         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2671
2672         Reviewed by Darin Adler.
2673
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2675         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2676         callback.
2677
2678 2011-03-14  Adam Roben  <aroben@apple.com>
2679
2680         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2681
2682         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2683         analyze
2684
2685         Reviewed by David Kilzer and Joe Pecoraro.
2686
2687         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2688         (#url-prompt): Made this a bit taller to make room for the list of builds.
2689
2690         (#recent-builds-loading-indicator):
2691         (#recent-builds-list):
2692         Added styles for the build list and loading indicator.
2693
2694         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2695         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2696         it. This will unescape it.
2697         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2698         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2699         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2700         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2701         prompt UI.
2702         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2703         now also used when a recent build is clicked.
2704
2705         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2706         (RecentBuildsLoader): Store the callback.
2707         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2708         builder. Find the revision number, leak count, and results URL for each one. Pass the
2709         resulting info to our callback.
2710
2711         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2712         (range): Added this helper function to return an array containing the integers [0, n).
2713
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2715         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2716
2717 2011-03-14  Mark Rowe  <mrowe@apple.com>
2718
2719         Reviewed by Adam Roben.
2720
2721         Fix two memory leaks within LayoutTestController's storage support.
2722
2723         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2724         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2725         by JSStringCreateWithCFString.
2726         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2727         allocate.
2728
2729 2011-03-14  Mark Rowe  <mrowe@apple.com>
2730
2731         Reviewed by Oliver Hunt.
2732
2733         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2734
2735         * DumpRenderTree/LayoutTestController.cpp:
2736         (LayoutTestController::staticFunctions): Remove duplicate entries.
2737
2738 2011-03-14  Alice Liu  <alice.liu@apple.com>
2739
2740         Reviewed by Dan Bernstein.
2741
2742         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2743
2744         * DumpRenderTree/mac/PerlSupport/Makefile:
2745         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2746
2747 2011-03-14  Daniel Bates  <dbates@rim.com>
2748
2749         https://bugs.webkit.org/show_bug.cgi?id=55438
2750         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2751         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2752
2753         * Scripts/build-webkit:
2754
2755 2011-03-14  Daniel Bates  <dbates@rim.com>
2756
2757         Reviewed by David Kilzer.
2758
2759         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2760         https://bugs.webkit.org/show_bug.cgi?id=55438
2761
2762         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2763         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2764         CMake arguments for feature defines.
2765
2766         * Scripts/build-webkit:
2767           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2768           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2769           - Sorted forward declarations.
2770           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2771             Modified call sites as needed.
2772         * Scripts/webkitdirs.pm:
2773           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2774           - Added buildCMakeGeneratedProject() to build using generated build system.
2775           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2776           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2777             a CMake project.
2778           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2779
2780 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2781
2782         Reviewed by Steve Block.
2783
2784         Detach Geolocation from Frame when Page destroyed.
2785         https://bugs.webkit.org/show_bug.cgi?id=52877
2786
2787         Extend the layout test controller to expose the number of pending
2788         geolocation requests, so that we can test that the requests have
2789         been cancelled on page close.
2790
2791         * DumpRenderTree/LayoutTestController.cpp:
2792         (numberOfPendingGeolocationPermissionRequestsCallback):
2793         (LayoutTestController::staticFunctions):
2794         * DumpRenderTree/LayoutTestController.h:
2795         * DumpRenderTree/chromium/LayoutTestController.cpp:
2796         (LayoutTestController::LayoutTestController):
2797         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2798         * DumpRenderTree/chromium/LayoutTestController.h:
2799         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2800         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2801         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2802         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2803         * DumpRenderTree/mac/UIDelegate.h:
2804         * DumpRenderTree/mac/UIDelegate.mm:
2805         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2806         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2807         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2808         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2809         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2810         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2811         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2812         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2813
2814
2815 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2816
2817         Unreviewed. Modify my email address in committers.py.
2818
2819         * Scripts/webkitpy/common/config/committers.py:
2820
2821 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2822
2823         Reviewed by Kenneth Rohde Christiansen.
2824
2825         [Qt] QtLauncher does not load the same set of fonts as the DRT
2826         https://bugs.webkit.org/show_bug.cgi?id=34959
2827
2828         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2829         When this option is used the webkit fonts are loaded the same
2830         as they are in DumpRenderTree.  This option can be used on
2831         QtTestBrowser and run-launcher.  It can only be used
2832         on Linux systems with FcInit and is configured as such.
2833
2834         * QtTestBrowser/launcherwindow.h:
2835         (WindowOptions::WindowOptions):
2836         * QtTestBrowser/main.cpp:
2837         (initWebKitTestFonts):
2838         (launcherMain):
2839         (LauncherApplication::handleUserOptions):
2840
2841 2011-03-12  Dan Bernstein  <mitz@apple.com>
2842
2843         Reviewed by Mark Rowe.
2844
2845         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2846         DumpRenderTree is being built for.
2847
2848         * DumpRenderTree/mac/PerlSupport/Makefile:
2849
2850 2011-03-12  Dan Bernstein  <mitz@apple.com>
2851
2852         Suggested by Mark Rowe.
2853
2854         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2855         as they were before r80915.
2856
2857 2011-03-12  Anders Carlsson  <andersca@apple.com>
2858
2859         Reviewed by Sam Weinig.
2860
2861         Should be able to download a PDF to the Downloads folder
2862         https://bugs.webkit.org/show_bug.cgi?id=56256
2863
2864         * MiniBrowser/mac/BrowserWindowController.m:
2865         (-[BrowserWindowController awakeFromNib]):
2866         * WebKitTestRunner/TestController.cpp:
2867         (WTR::TestController::createOtherPage):
2868         (WTR::TestController::initialize):
2869         Update for API changes.
2870
2871 2011-03-11  Anton D'Auria  <adauria@apple.com>
2872
2873         Reviewed and landed by Brady Eidson.
2874
2875         https://bugs.webkit.org/show_bug.cgi?id=51878
2876         Add WebKit1 API to view and delete local storage
2877
2878         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2879
2880         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2881         * DumpRenderTree/LayoutTestController.cpp:
2882         (syncLocalStorageCallback):
2883         (observeStorageTrackerNotificationsCallback):
2884         (deleteAllLocalStorageCallback):
2885         (deleteLocalStorageForOriginCallback):
2886         (originsWithLocalStorageCallback):
2887         (LayoutTestController::staticFunctions):
2888         * DumpRenderTree/LayoutTestController.h:
2889         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2890         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2891         (-[StorageTrackerDelegate init]):
2892         (-[StorageTrackerDelegate logNotifications:controller:]):
2893         (-[StorageTrackerDelegate originModified:]):
2894         (-[StorageTrackerDelegate dealloc]):
2895         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2896         * DumpRenderTree/chromium/LayoutTestController.cpp:
2897         (LayoutTestController::LayoutTestController):
2898         (LayoutTestController::deleteAllLocalStorage):
2899         (LayoutTestController::originsWithLocalStorage):
2900         (LayoutTestController::deleteLocalStorageForOrigin):
2901         (observeStorageTrackerNotifications):
2902         (syncLocalStorage):
2903         * DumpRenderTree/chromium/LayoutTestController.h:
2904         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2905         (LayoutTestController::originsWithLocalStorage):
2906         (LayoutTestController::deleteAllLocalStorage):
2907         (LayoutTestController::deleteLocalStorageForOrigin):
2908         (LayoutTestController::observeStorageTrackerNotifications):
2909         (LayoutTestController::syncLocalStorage):
2910         * DumpRenderTree/mac/DumpRenderTree.mm:
2911         (resetDefaultsToConsistentValues):
2912         (allocateGlobalControllers):
2913         (releaseGlobalControllers):
2914         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2915         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2916         (LayoutTestController::syncLocalStorage):
2917         (LayoutTestController::observeStorageTrackerNotifications):
2918         (LayoutTestController::deleteAllLocalStorage):
2919         (LayoutTestController::originsWithLocalStorage):
2920         (LayoutTestController::deleteLocalStorageForOrigin):
2921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2922         (LayoutTestController::originsWithLocalStorage):
2923         (LayoutTestController::deleteAllLocalStorage):
2924         (LayoutTestController::deleteLocalStorageForOrigin):
2925         (LayoutTestController::observeStorageTrackerNotifications):
2926         (LayoutTestController::syncLocalStorage):
2927         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2928         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2929         (LayoutTestController::clearAllApplicationCaches):
2930         (LayoutTestController::syncLocalStorage):
2931         (LayoutTestController::observeStorageTrackerNotifications):
2932         (LayoutTestController::clearAllDatabases):
2933         (LayoutTestController::deleteAllLocalStorage):
2934         (LayoutTestController::originsWithLocalStorage):
2935         (LayoutTestController::deleteLocalStorageForOrigin):
2936         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2937         (LayoutTestController::syncLocalStorage):
2938         (LayoutTestController::observeStorageTrackerNotifications):
2939         (LayoutTestController::clearAllDatabases):
2940         (LayoutTestController::deleteAllLocalStorage):
2941         (LayoutTestController::originsWithLocalStorage):
2942         (LayoutTestController::deleteLocalStorageForOrigin):
2943
2944 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2945
2946         Reviewed by Adam Roben.
2947
2948         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2949         Process has finished launching.
2950         https://bugs.webkit.org/show_bug.cgi?id=56208
2951
2952         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2953         (TestWebKitAPI::TEST):
2954         Test that calling WKContextClearResourceCaches works with both options when called before
2955         the Web Process is valid.
2956
2957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2958         Add the new test.
2959         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2960         Ditto.
2961
2962 2011-03-11  Adam Roben  <aroben@apple.com>
2963
2964         Make it possible to view all leaks from a build at once in Leaks Viewer
2965
2966         You can now give Leaks Viewer the URL of a build results page (e.g.,
2967         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2968         will load all the leaks files from that build.
2969
2970         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2971         files from a particular build at once, rather than one at a time
2972
2973         Reviewed by David Kilzer.
2974
2975         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2976         (LeaksLoader): Initialize our properties.
2977         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2978         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2979         from that page.
2980         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2981         so it can provide feedback. Then load each one and pass it to the client.
2982         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2983         it into a DOM, pull out all the links to leaks files, and load each one.
2984
2985         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2986         (LeaksParser): Initialize our worker.
2987         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2988
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2990         This code mostly came from Worker.js.
2991         (LeaksParserWorker): Initialize our profile.
2992         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2993         profile.
2994         (LeaksParserWorker.prototype._parseLeaks):
2995         (LeaksParserWorker.prototype._createNode):
2996         (LeaksParserWorker.prototype._incorporateLeaks):
2997         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2998         version of createProfile which adds to this.profile instead of making a new profile each
2999         time.
3000         (onmessage): Parse the file and send back the new profile.
3001
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3003         (#loading-indicator):
3004         (#spinner):
3005         (#loading-indicator-label):
3006         Tweaked styles to accomodate a longer label.
3007
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3009         (LeaksViewer.loaded): Set up a loader and parser.
3010
3011         (LeaksViewer.get filesLeftToParse):
3012         (LeaksViewer.set filesLeftToParse):
3013         Added these simple accessors.
3014
3015         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
3016         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
3017         the parser.
3018         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
3019         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
3020         _loadLeaksFromURL function).
3021         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
3022         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
3023         loading indicator, including the number of files being loaded.
3024         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
3025         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
3026         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
3027         _loadingIndicatorText.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
3030         (getResource): Moved here from LeaksViewer.js.
3031
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
3033         LeaksParserWorker.js.
3034
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
3036         files, added a #loading-indicator-label element, and tweaked the prompt wording.
3037
3038 2011-03-11  Adam Roben  <aroben@apple.com>
3039
3040         Don't trigger a build when build.webkit.org's HTML files are modified
3041
3042         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
3043
3044         Reviewed by Dan Bernstein.
3045
3046         * Scripts/webkitpy/common/config/build.py:
3047         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
3048         directories that shouldn't trigger builds. Re-sorted the list.
3049
3050         * Scripts/webkitpy/common/config/build_unittest.py:
3051         (ShouldBuildTest): Added a test to cover the above change.
3052
3053 2011-03-11  Adam Roben  <aroben@apple.com>
3054
3055         Roll out r80848
3056
3057         It was accidentally committed.
3058
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3060         (LeaksViewer._loadLeaksFromURL):
3061
3062 2011-03-11  Tony Chang  <tony@chromium.org>
3063
3064         Reviewed by Ojan Vafai.
3065
3066         kill hung lighttpd processes on the chromium win bot
3067         https://bugs.webkit.org/show_bug.cgi?id=56152
3068
3069         Sometimes this process doesn't exit and it holds on to
3070         a log file that we can't delete or copy, causing the tests
3071         to go red.
3072
3073         * BuildSlaveSupport/win/kill-old-processes:
3074
3075 2011-03-11  Ilya Sherman  <isherman@chromium.org>
3076
3077         Reviewed by Kent Tamura.
3078
3079         [Chromium] missing HTMLInputElement::setValueForUser() to tests
3080         https://bugs.webkit.org/show_bug.cgi?id=55854
3081
3082         * DumpRenderTree/chromium/LayoutTestController.cpp:
3083         (LayoutTestController::LayoutTestController):
3084         (LayoutTestController::setValueForUser): Added.
3085         * DumpRenderTree/chromium/LayoutTestController.h:
3086
3087 2011-03-10  Peter Kasting  <pkasting@google.com>
3088
3089         Reviewed by Dimitri Glazkov.
3090
3091         Clean up some gross code in TestShellWin.cpp.  No functional change.
3092         https://bugs.webkit.org/show_bug.cgi?id=56048
3093
3094         * DumpRenderTree/chromium/TestShellWin.cpp:
3095         (checkLayoutTestSystemDependencies):
3096
3097 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
3098
3099         Reviewed by Laszlo Gombos.
3100
3101         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
3102
3103         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3104         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
3105
3106 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3107
3108         Reviewed by Kenneth Rohde Christiansen.
3109
3110         [EFL] Make single backing store the default for EWebLauncher
3111         https://bugs.webkit.org/show_bug.cgi?id=55753
3112
3113         Set single backing store the default for EWebLauncher.
3114
3115         * EWebLauncher/main.c:
3116         (main):
3117
3118 2011-03-10  Adam Roben  <aroben@apple.com>
3119
3120         Ignore errors from files being held open when creating a test result archive
3121
3122         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
3123         fails to delete the results directory
3124
3125         Reviewed by Mark Rowe.
3126
3127         * BuildSlaveSupport/test-result-archive:
3128         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
3129         thrown when a process is holding a file open.
3130
3131 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3132
3133         Unreviewed, rolling out r80701.
3134         http://trac.webkit.org/changeset/80701
3135         https://bugs.webkit.org/show_bug.cgi?id=56126
3136
3137         fast/dom/Geolocation/window-close-crash.html fails on Snow
3138         Leopard release builds (Requested by mihaip on #webkit).
3139
3140         * DumpRenderTree/LayoutTestController.cpp:
3141         (LayoutTestController::staticFunctions):
3142         * DumpRenderTree/LayoutTestController.h:
3143         * DumpRenderTree/chromium/LayoutTestController.cpp:
3144         (LayoutTestController::LayoutTestController):
3145         * DumpRenderTree/chromium/LayoutTestController.h:
3146         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3147         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3148         * DumpRenderTree/mac/UIDelegate.h:
3149         * DumpRenderTree/mac/UIDelegate.mm:
3150         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3151         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3152         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3153         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3154
3155 2011-03-10  Philippe Normand  <pnormand@igalia.com>
3156
3157         Reviewed by Gustavo Noronha Silva.
3158
3159         [GTK] run-gtk-tests doesn't fail if a test crashes
3160         https://bugs.webkit.org/show_bug.cgi?id=56089
3161
3162         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
3163         even if a test crashes. So run the tests individually and if a
3164         test fails remember its exit code so run-gtk-test fails too, if
3165         required.
3166
3167 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3168
3169         Reviewed by Dmitry Titov.
3170
3171         Detach Geolocation from Frame when Page destroyed.
3172         https://bugs.webkit.org/show_bug.cgi?id=52877
3173
3174         Extend the layout test controller to expose the number of pending
3175         geolocation requests, so that we can test that the requests have
3176         been cancelled on page close.
3177
3178         * DumpRenderTree/LayoutTestController.cpp:
3179         (numberOfPendingGeolocationPermissionRequestsCallback):
3180         (LayoutTestController::staticFunctions):
3181         * DumpRenderTree/LayoutTestController.h:
3182         * DumpRenderTree/chromium/LayoutTestController.cpp:
3183         (LayoutTestController::LayoutTestController):
3184         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3185         * DumpRenderTree/chromium/LayoutTestController.h:
3186         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3187         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3188         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3189         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3190         * DumpRenderTree/mac/UIDelegate.h:
3191         * DumpRenderTree/mac/UIDelegate.mm:
3192         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3193         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3194         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3195         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3196         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3197         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3198         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3199         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3200
3201
3202 2011-03-09  Adam Roben  <aroben@apple.com>
3203
3204         Hide Leaks Viewer's URL prompt by default
3205
3206         We will show it as needed. I think I left it visible by default by accident after doing some
3207         testing.
3208
3209         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
3210         URL is passed as a query parameter, but does
3211
3212         Reviewed by Simon Fraser.
3213
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3215
3216 2011-03-09  Adam Roben  <aroben@apple.com>
3217
3218         Don't use Element.classList or box-shadow in Leaks Viewer
3219
3220         They aren't supported by Safari 5. Luckily we have substitutes for them!
3221
3222         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
3223
3224         Reviewed by Simon Fraser.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3227         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
3228
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3230         (LeaksViewer.urlPromptButtonClicked):
3231         (LeaksViewer._displayURLPrompt):
3232         (LeaksViewer._setLoadingIndicatorHidden):
3233         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
3234
3235 2011-03-09  Adam Roben  <aroben@apple.com>
3236
3237         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
3238
3239         Rubber-stamped by David Kilzer.
3240
3241         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3242
3243 2011-03-09  Adam Roben  <aroben@apple.com>
3244
3245         Add a Leaks Viewer tool to build.webkit.org
3246
3247         This tool parses leaks from the files generated by the leaks bot and displays them in a
3248         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
3249         code).
3250
3251         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
3252         be passed to the tool via the "url" query parameter.
3253
3254         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
3255         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
3256         Inspector's Heavy profile view. But it's still pretty useful as-is.
3257
3258         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
3259
3260         Reviewed by Darin Adler.
3261
3262         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
3263         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
3264         (#url-prompt): This is the prompt itself.
3265
3266         (#loading-indicator):
3267         (#loading-indicator > img):
3268         These show a spinner in the bottom-right when we're loading a leaks file.
3269
3270         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
3271         as percentages.
3272
3273         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
3274         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
3275         URL if one wasn't given to us as a query parameter).
3276
3277         (LeaksViewer.get loading):
3278         (LeaksViewer.set loading):
3279         (LeaksViewer.get url):
3280         (LeaksViewer.set url):
3281         Pretty simple accessors.
3282
3283         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
3284         prompt.
3285         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
3286         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
3287         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
3288         the profile to the Web Inspector code once it's been created.
3289         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
3290         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
3291         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
3292         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
3293
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
3295         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
3296         (ProfilerAgent.getProfile): Store the callback.
3297         (ProfilerAgent.profileReady): Call the callback.
3298         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
3299         count and total leak counts as real values, not percentages or milliseconds.
3300
3301         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
3302         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
3303         (parseLeaks): Extract call stacks out of a leaks file.
3304         (createNode): Helper function to create a new empty profile node.
3305         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
3306         WebInspector.ProfileView.
3307
3308         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
3309
3310 2011-03-09  Dan Bernstein  <mitz@apple.com>
3311
3312         Reviewed by Adam Roben.
3313
3314         Combine multiple --ignore-tests values
3315         https://bugs.webkit.org/show_bug.cgi?id=56016
3316
3317         * Scripts/old-run-webkit-tests:
3318
3319 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
3320
3321         Reviewed by David Levin.
3322
3323         Adding myself to the committer file.
3324
3325         * Scripts/webkitpy/common/config/committers.py:
3326
3327 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3328
3329         Rubber-stamped by Adam Roben.
3330
3331         Fix two leaks I introduced into the API tests.
3332
3333         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3334         (TestWebKitAPI::TEST):
3335
3336 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3337
3338         Reviewed by Anders Carlsson.
3339
3340         Crash in CFNetwork visiting google.com
3341         https://bugs.webkit.org/show_bug.cgi?id=55958
3342
3343         Add a test for not trying to copy a null CFURLResponse.
3344
3345         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
3346         (TestWebKitAPI::TEST):
3347         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3348
3349 2011-03-08  Hayato Ito  <hayato@chromium.org>
3350
3351         Reviewed by Ojan Vafai.
3352
3353         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3354
3355         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3356
3357         https://bugs.webkit.org/show_bug.cgi?id=55450
3358
3359         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3360
3361 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3362
3363         Reviewed by Martin Robinson.
3364
3365         [GTK] Add layoutTestController.setValueForUser() after r80412
3366         https://bugs.webkit.org/show_bug.cgi?id=55862
3367
3368         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3369         (LayoutTestController::setValueForUser): Implement setValueForUser()
3370
3371 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3372
3373         Reviewed by Adam Barth.
3374
3375         Add script_shell_command to WebKitPort
3376         https://bugs.webkit.org/show_bug.cgi?id=55925
3377
3378         Add a central place where we generate the shell command from the script name.
3379         This function will be used later to detect the correct script interpreter on Win32.
3380
3381         * Scripts/webkitpy/common/config/ports.py:
3382         * Scripts/webkitpy/layout_tests/port/base.py:
3383         * Scripts/webkitpy/tool/steps/abstractstep.py:
3384         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3385
3386 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3387
3388         Reviewed by Adam Barth.
3389
3390         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3391         https://bugs.webkit.org/show_bug.cgi?id=55749
3392
3393         * Scripts/webkitpy/tool/commands/upload.py:
3394         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3395         * Scripts/webkitpy/tool/steps/__init__.py:
3396         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3397         * Scripts/webkitpy/tool/steps/options.py:
3398
3399 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3400
3401         Reviewed by David Levin.
3402
3403         Add support for DataTransferItems
3404         https://bugs.webkit.org/show_bug.cgi?id=55115
3405
3406         Enable data transfer items in DRT.
3407
3408         * DumpRenderTree/chromium/TestShell.cpp:
3409         (TestShell::TestShell):
3410
3411 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3412
3413         Reviewed by Tony Chang.
3414
3415         [test dashboard] pull treemap files
3416         https://bugs.webkit.org/show_bug.cgi?id=55852
3417
3418         * TestResultServer/handlers/dashboardhandler.py:
3419
3420 2011-03-03  Hayato Ito  <hayato@chromium.org>
3421
3422         Reviewed by Mihai Parparita.
3423
3424         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3425         previous image should not be used in the ChromiumDriver.
3426
3427         Also make sure that output image from the ChromiumDriver should be ''
3428         (empty string) if a test crashes for consistency with the WebKitDriver
3429         implementation.
3430
3431         https://bugs.webkit.org/show_bug.cgi?id=55746
3432
3433         * Scripts/webkitpy/layout_tests/port/chromium.py:
3434
3435 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3436
3437         Reviewed by Martin Robinson.
3438
3439         [Gtk] fast/js/navigator-language.html fails locally
3440         https://bugs.webkit.org/show_bug.cgi?id=55880
3441
3442         Add LANG variable to the clean environment when running
3443         old-run-webkit-tests script.
3444
3445         * Scripts/old-run-webkit-tests:
3446
3447 2011-03-07  Tony Chang  <tony@chromium.org>
3448
3449         Reviewed by Mihai Parparita.
3450
3451         [Chromium] Find .checksum files without .pngs and vice-versa
3452         https://bugs.webkit.org/show_bug.cgi?id=55236
3453
3454         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3455             mismatched results.
3456
3457 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3458
3459         Reviewed by Beth Dakin.
3460
3461         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3462         https://bugs.webkit.org/show_bug.cgi?id=55706
3463
3464         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3465
3466         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3467         (AccessibilityController::focusedElement):
3468            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
3469            because it could change at any time.
3470         (AccessibilityController::rootElement):
3471
3472 2011-03-07  Sam Weinig  <sam@webkit.org>
3473
3474         Reviewed by Anders Carlsson.
3475
3476         Add unableToImplementPolicy callback for WebKit2 policy client
3477         <rdar://problem/9071902>
3478         https://bugs.webkit.org/show_bug.cgi?id=55884
3479
3480         * MiniBrowser/mac/BrowserWindowController.m:
3481         (-[BrowserWindowController awakeFromNib]):
3482         Update policy client initialization struct for new member.
3483
3484 2011-03-07  Sam Weinig  <sam@webkit.org>
3485
3486         Reviewed by Anders Carlsson.
3487
3488         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3489         https://bugs.webkit.org/show_bug.cgi?id=55827
3490
3491         * MiniBrowser/mac/BrowserWindowController.m:
3492         (decidePolicyForResponse):
3493         (-[BrowserWindowController awakeFromNib]):
3494         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3495         (TestWebKitAPI::decidePolicyForResponse):
3496         (TestWebKitAPI::TEST):
3497         Update tools for new name.
3498
3499 2011-03-06  Daniel Bates  <dbates@rim.com>
3500
3501         Reviewed by Eric Seidel and David Kilzer.
3502
3503         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3504         https://bugs.webkit.org/show_bug.cgi?id=55503
3505
3506         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3507         in checkForJavaSDK().
3508
3509         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3510
3511         * Scripts/build-webkit:
3512
3513 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3514
3515         Reviewed by Sam Weinig.
3516
3517         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3518
3519         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3520         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3521             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3522
3523 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3524
3525         Reviewed by Darin Adler.
3526
3527         HTMLInputElement::setValue() should schedule change event when the element is focused
3528         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3529         https://bugs.webkit.org/show_bug.cgi?id=53160
3530
3531         * DumpRenderTree/LayoutTestController.cpp:
3532         (setValueForUserCallback):
3533         (LayoutTestController::staticFunctions):
3534         * DumpRenderTree/LayoutTestController.h:
3535         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3536         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3537         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3538         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3539         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3540         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3541         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3542         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3543         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3544         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3545
3546 2011-03-04  Mark Rowe  <mrowe@apple.com>
3547
3548         Reviewed by Alexey Proskuryakov.
3549
3550         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3551
3552         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3553         
3554         * DumpRenderTree/mac/CheckedMalloc.cpp:
3555         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3556         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3557         and then restore the initial protection flags when we're done.
3558
3559 2011-03-04  Evan Martin  <evan@chromium.org>
3560
3561         Reviewed by Tony Chang.
3562
3563         [gdb] pretty-print KURL in gdb
3564         https://bugs.webkit.org/show_bug.cgi?id=55788
3565
3566         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3567         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3568         pretty-printing.
3569
3570 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3571
3572         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3573
3574         Reviewed by Darin Adler.
3575
3576         * TestWebKitAPI/JavaScriptTest.cpp:
3577         (TestWebKitAPI::javaScriptCallback):
3578         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3579         (TestWebKitAPI::didRunJavaScript):
3580         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3581         (TestWebKitAPI::nullJavaScriptCallback):
3582         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3583         (TestWebKitAPI::didRunJavaScript):
3584
3585 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3586
3587         Make run-api-tests show failed if a test fails.
3588
3589         https://webkit.org/b/55725
3590
3591         Reviewed by Sam Weinig.
3592
3593         * Scripts/run-api-tests:
3594         (runTest): Remove "my" from the nested $result assignment so the
3595         check outside the condition sees the real result.
3596
3597 2011-03-02  MORITA Hajime  <morrita@google.com>
3598
3599         Reviewed by Kent Tamura.
3600
3601         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3602         https://bugs.webkit.org/show_bug.cgi?id=55434
3603
3604         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3605         and passed the object webkit_support::PostDelayedTask directly.
3606
3607         Note that the change keeps postTask() as is because it has a
3608         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3609         the main thread.
3610
3611         * DumpRenderTree/chromium/Task.cpp:
3612         (postDelayedTask):
3613         * DumpRenderTree/chromium/Task.h:
3614         (WebTask::Run):
3615
3616 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3617
3618         Reviewed by Kenneth Rohde Christiansen.
3619
3620         [QT] Implement mock client-based geolocation for layout testing
3621         https://bugs.webkit.org/show_bug.cgi?id=54334
3622
3623         Implement testing for Client-Based geolocation for QtWebkit.
3624
3625         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3626         (WebCore::DumpRenderTree::DumpRenderTree):
3627         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3628         (LayoutTestController::reset):
3629         (LayoutTestController::setGeolocationPermission):
3630         (LayoutTestController::setMockGeolocationError):
3631         (LayoutTestController::setMockGeolocationPosition):
3632
3633 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3634
3635         Unreviewed, rolling out r80237.
3636         http://trac.webkit.org/changeset/80237
3637         https://bugs.webkit.org/show_bug.cgi?id=55714
3638
3639         Windows bots aren't ready to be core (Requested by aroben on
3640         #webkit).
3641
3642         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3643         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3644
3645 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3646
3647         Reviewed by Tony Chang.
3648
3649         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'