2011-02-11 Dirk Pranke <dpranke@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-11  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         This patch adds to NRWT most of the support needed to run the new
6         message-based workers in separate threads or processes. The code
7         isn't fully complete yet because we don't support cancel() or
8         is_alive().
9
10         https://bugs.webkit.org/show_bug.cgi?id=54070
11
12         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
13         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
14         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
15         * Scripts/webkitpy/layout_tests/port/base.py:
16         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
17         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
18
19 2011-02-11  Sailesh Agrawal  <sail@chromium.org>
20
21         Reviewed by Kenneth Russell.
22
23         plugins/invalidate_rect.html fails on chromium-mac
24         https://bugs.webkit.org/show_bug.cgi?id=54051
25
26         This change fixes the invalidate_rect.html test failure on Windows.
27
28         There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.
29
30         The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.
31
32         This change also updates the build path in chromium_win.py to use the new Source directory.
33
34         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
35         (invalidateRect):
36         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
37         (NPP_New):
38         (handleEventWin):
39         (NPP_HandleEvent):
40         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
41
42 2011-02-11  Csaba Osztrogonác  <ossy@webkit.org>
43
44         Reviewed by Andreas Kling.
45
46         [Qt] Increase the timeout of Qt API tests to 120 seconds.
47
48         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
49
50 2011-02-10  Zhenyao Mo  <zmo@google.com>
51
52         Unreviewed, build fix.
53
54         * DumpRenderTree/DumpRenderTree.gypi:
55
56 2011-02-10  Dirk Pranke  <dpranke@chromium.org>
57
58         Reviewed by Tony Chang.
59
60         This patch adds the bulk of the remaining functionality for
61         the NRWT message-passing implementation. The patch adds a new
62         Worker class that will eventually replace the TestShellThread
63         class in dump_render_tree_thread.py, and implements enough of
64         TestRunner2 and the inline version of the manager_worker_broker
65         to actually be able to send a full set of messages back and
66         forth. The Worker stubs do not actually run tests, and there's
67         lots of error handling and stats needed, but this is the core
68         logic.
69
70         https://bugs.webkit.org/show_bug.cgi?id=54068
71
72         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
73         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
74         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
75         * Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
76         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
77
78 2011-02-10  Zhenyao Mo  <zmo@google.com>
79
80         Unreviewed, build fix.
81
82         * DumpRenderTree/DumpRenderTree.gypi:
83
84 2011-02-10  Zhenyao Mo  <zmo@google.com>
85
86         Unreviewed, build fix.
87
88         * DumpRenderTree/DumpRenderTree.gypi:
89
90 2011-02-10  Zhenyao Mo  <zmo@google.com>
91
92         Unreviewed, attempt to fix crashing plugin tests.
93
94         * DumpRenderTree/DumpRenderTree.gypi:
95
96 2011-02-10  Zhenyao Mo  <zmo@google.com>
97
98         Unreviewed, build fix.
99
100         * DumpRenderTree/DumpRenderTree.gypi:
101
102 2011-02-10  Sam Weinig  <sam@webkit.org>
103
104         Try and fix some crashing tests on the chromium build bot.
105
106         * DumpRenderTree/DumpRenderTree.gypi:
107
108 2011-02-10  Anders Carlsson  <andersca@apple.com>
109
110         Reviewed by Sam Weinig.
111
112         Log an error if a plug-in test can't be found
113         https://bugs.webkit.org/show_bug.cgi?id=54252
114
115         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
116         (PluginTest::create):
117         Return null if the test wasn't found.
118
119         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
120         (NPP_New):
121         Report an error if PluginTest::create returns null.
122
123 2011-02-10  Robert Hogan  <robert@webkit.org>
124
125         Reviewed by Laszlo Gombos.
126
127         [Qt] Return menu items from eventSender.contextMenu()
128         https://bugs.webkit.org/show_bug.cgi?id=53039
129
130         * DumpRenderTree/qt/EventSenderQt.cpp:
131         (EventSender::contextClick):
132         * DumpRenderTree/qt/EventSenderQt.h:
133
134 2011-02-10  Adam Roben  <aroben@apple.com>
135
136         Test showing and hiding the find indicator on Windows
137
138         Test for <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in
139         FindIndicator::contentImage when scrolling page
140
141         Reviewed by Steve Falkenburg.
142
143         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added.
144         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
145         (TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the
146         bitmap.
147         (TestWebKitAPI::initialize): Hook up our callbacks.
148         (TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash.
149
150         * TestWebKitAPI/PlatformWebView.h:
151         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
152         (TestWebKitAPI::PlatformWebView::page):
153         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
154         (TestWebKitAPI::PlatformWebView::page):
155         Made page a const member function.
156
157         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
158
159 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
160
161         Reviewed by Martin Robinson.
162
163         [GTK] Log signals from AtkDocument interface also in AccessibilityController
164         https://bugs.webkit.org/show_bug.cgi?id=54198
165
166         Trace AtkDocument's signals emission through AccessibilityController.
167
168         Also, taken the code related to adding and removing global
169         listeners for ATK signals out to a separate file, for the sake of
170         clarity and to ease future additions.
171
172         * DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
173         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added
174         (printAccessibilityEvent): Print information about an event.
175         (axObjectEventListener): Global listener for AtkObject's signals.
176         (axDocumentEventListener): Global listener for AtkDocument's signals.
177         (connectAccessibilityCallbacks): Connect all global listeners.
178         (disconnectAccessibilityCallbacks): Disconnect all global listeners.
179
180         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
181         (AccessibilityController::setLogAccessibilityEvents): Call to
182         connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.
183
184         * GNUmakefile.am: Added new files.
185
186 2011-02-09  Martin Robinson  <mrobinson@igalia.com>
187
188         Reviewed by Gustavo Noronha Silva.
189
190         [GTK] Default error page is interfering with tests which require failed loads
191         https://bugs.webkit.org/show_bug.cgi?id=54157
192
193         Disable the default error page during DRT runs. This prevents unexpected loads
194         from interfering with tests that have planned failed loads.
195
196         * DumpRenderTree/gtk/DumpRenderTree.cpp:
197         (webViewLoadError): Added, disable default handler.
198         (createWebView): Connect the new load-error handler.
199
200 2011-02-10  Zoltan Horvath  <zoltan@webkit.org>
201
202         Reviewed by Andreas Kling.
203
204         [Qt] Add UrlLoader and command line argument handling to MiniBrowser
205         https://bugs.webkit.org/show_bug.cgi?id=54192
206  
207         Copy and modify files from QtTestBrowser's implementation.
208
209         * MiniBrowser/qt/BrowserWindow.cpp:
210         (BrowserWindow::BrowserWindow):
211         (BrowserWindow::newWindow):
212         * MiniBrowser/qt/BrowserWindow.h:
213         * MiniBrowser/qt/MiniBrowser.pro:
214         * MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp
215         (MiniBrowserApplication::MiniBrowserApplication):
216         (MiniBrowserApplication::handleUserOptions):
217         * MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h
218         (WindowOptions::WindowOptions):
219         (MiniBrowserApplication::urls):
220         (MiniBrowserApplication::isRobotized):
221         (MiniBrowserApplication::robotTimeout):
222         (MiniBrowserApplication::robotExtraTime):
223         * MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp
224         (UrlLoader::UrlLoader):
225         (UrlLoader::loadNext):
226         (UrlLoader::checkIfFinished):
227         (UrlLoader::frameLoadStarted):
228         (UrlLoader::frameLoadFinished):
229         (UrlLoader::loadUrlList):
230         (UrlLoader::getUrl):
231         * MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h 
232         * MiniBrowser/qt/main.cpp:
233         (main):
234         * MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp 
235         (takeOptionValue):
236         (formatKeys):
237         (enumToKeys):
238         (appQuit):
239         (urlFromUserInput):
240         * MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h
241
242 2011-02-10  Zoltan Horvath  <zoltan@webkit.org>
243
244         Reviewed by Andreas Kling.
245
246         check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
247         https://bugs.webkit.org/show_bug.cgi?id=54200
248
249         * Scripts/webkitpy/style/checker.py:
250         * Scripts/webkitpy/style/checker_unittest.py:
251
252 2011-02-10  Peter Varga  <pvarga@webkit.org>
253
254         Reviewed by Csaba Osztrogonác.
255
256         Remove PCRE source from trunk
257         https://bugs.webkit.org/show_bug.cgi?id=54188
258
259         * wx/build/settings.py:
260
261 2011-02-10  David Levin  <levin@chromium.org>
262
263         Reviewed by Shinichiro Hamaji.
264
265         check-webkit-style should be able to figure out function modifiers and return type.
266         https://bugs.webkit.org/show_bug.cgi?id=54124
267
268         * Scripts/webkitpy/style/checkers/cpp.py:
269         (_rfind_in_lines): A way to search backwards in lines.
270         (_FunctionState.modifiers_and_return_type):
271         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.
272
273 2011-02-09  Adam Roben  <aroben@apple.com>
274
275         Test that WM_PRINT doesn't trigger an assertion
276
277         Test for <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new
278         drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds)
279
280         Reviewed by Darin Adler.
281
282         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added.
283         (TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView.
284
285 2011-02-09  Adam Roben  <aroben@apple.com>
286
287         Test that having a WKView paint after being resized while hidden doesn't cause a crash
288
289         Test for <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in
290         DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden
291
292         Reviewed by Darin Adler.
293
294         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
295         (TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden.
296
297 2011-02-09  Adam Roben  <aroben@apple.com>
298
299         Add a test that resizes a WKView while it's hidden
300
301         Test for <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size,
302         performs badly if is resized while hidden (assertion fails in
303         BackingStore::incorporateUpdate in Debug builds)
304
305         Reviewed by Darin Adler.
306
307         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added.
308         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
309         (TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback.
310         (TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures
311         that all pending messages have been handled by the UI and web process.
312         (TestWebKitAPI::timerCallback): Kill the timer and record that it fired.
313         (TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires.
314         (TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a
315         chance to display, then flush all pending messages.
316         (TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for
317         the backing store to update. This triggers the assertion from bug 54141.
318
319         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
320         (TestWebKitAPI::PlatformWebView::resizeTo): Implemented.
321
322         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
323
324 2011-02-10  Philippe Normand  <pnormand@igalia.com>
325
326         Unreviewed, GTK build fix after roll out of r78157...
327
328         * GNUmakefile.am:
329
330 2011-02-10  Eric Seidel  <eric@webkit.org>
331
332         Unreviewed, rolling out r78157.
333         http://trac.webkit.org/changeset/78157
334         https://bugs.webkit.org/show_bug.cgi?id=54150
335
336         Fails on a bunch of bots
337
338         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
339         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed.
340         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
341         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
342
343 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
344
345         Reviewed by Xan Lopez.
346
347         [GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
348         https://bugs.webkit.org/show_bug.cgi?id=54185
349
350         * DumpRenderTree/gtk/DumpRenderTree.cpp:
351         (resetDefaultsToConsistentValues):
352
353 2011-02-10  Philippe Normand  <pnormand@igalia.com>
354
355         Unreviewed GTK build fix.
356
357         Adding
358         Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp
359         in the build, fixing the
360         plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html
361         test.
362
363         * GNUmakefile.am:
364
365 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
366
367         Reviewed by Chris Fleizach.
368
369         [GTK] Add support in DRT to log "accessibility events"
370         https://bugs.webkit.org/show_bug.cgi?id=54116
371
372         Added a way to log accessibility related events, in a
373         platform-dependant way.
374
375         Add new function to AccessibilityController.
376
377         * DumpRenderTree/AccessibilityController.h:
378         * DumpRenderTree/AccessibilityController.cpp:
379         (logAccessibilityEventsCallback): New callback.
380         (AccessibilityController::getJSClass): Added new function.
381         (AccessibilityController::resetToConsistentState): Initialized
382         calling setLogAccessibilityEvents(false).
383
384         Provided implementation for the GTK port.
385
386         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
387         (accessibility_event_listener): Common listener for logging
388         information about all the signals emitted by any AtkObject.
389         (AccessibilityController::setLogAccessibilityEvents): Add or
390         remove listeners for signals, as specified by the parameter.
391
392         Provide dummy implementations for mac and win ports.
393
394         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
395         (AccessibilityController::setLogAccessibilityEvents):
396         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
397         (AccessibilityController::setLogAccessibilityEvents):
398
399 2011-02-09  Hayato Ito  <hayato@chromium.org>
400
401         Reviewed by Tony Chang.
402
403         [NRWT] Remove encoding parameters where we can assume data can be
404         written in binary mode.
405
406         https://bugs.webkit.org/show_bug.cgi?id=54066
407
408         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
409         * Scripts/webkitpy/layout_tests/port/base.py:
410
411 2011-02-09  Dirk Pranke  <dpranke@chromium.org>
412
413         Reviewed by Tony Chang.
414
415         nrwt multiprocessing: minor cleanup prior to implementing the new worker
416
417         This patch renames AbstractManager to ManagerConnection and
418         changes some argument names to be more consistent between
419         manager_worker_broker and message_broker. It also fixes a couple
420         of typos in message_broker. These changes will be tested by code
421         introduced in the next patch.
422        
423         https://bugs.webkit.org/show_bug.cgi?id=54067
424
425         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
426         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
427
428 2011-02-09  Anders Carlsson  <andersca@apple.com>
429
430         Reviewed by Sam Weinig.
431
432         Repro crash with Sony Google TV ad at Gizmodo
433         https://bugs.webkit.org/show_bug.cgi?id=54150
434         <rdar://problem/8782346>
435
436         Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.
437
438         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
439         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added.
440         (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream):
441         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy):
442         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
443         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
444         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
445
446 2011-02-09  David Levin  <levin@chromium.org>
447
448         Reviewed by Eric Seidel.
449
450         check-webkit-style: The error message about NULL should be more clear for comments.
451         https://bugs.webkit.org/show_bug.cgi?id=53786
452
453         * Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
454         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
455
456 2011-02-09  Nebojsa Ciric  <cira@chromium.org>
457
458         Reviewed by Darin Fisher.
459
460         Implements Locale object of JavaScript internationalization API proposal, as an
461         v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
462         and in this patch we just provide flags, tests and build rules for chromium port.
463         https://bugs.webkit.org/show_bug.cgi?id=49414
464
465         * DumpRenderTree/chromium/TestShell.cpp:
466         (TestShell::TestShell):
467
468 2011-02-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
469
470         Reviewed by Kenneth Rohde Christiansen.
471
472         [Qt] Remove UiTools dependency from MiniBrowser
473         https://bugs.webkit.org/show_bug.cgi?id=54096
474
475         * MiniBrowser/qt/MiniBrowser.pro:
476
477 2011-02-08  Hayato Ito  <hayato@chromium.org>
478
479         Reviewed by Tony Chang.
480
481         [NRWT] Pull up rebaseline code from compare_output() function defined
482         in text_diff.py and image_diff.py into a SingleTestRunner.
483
484         This patch is a first step for eliminating test_type/* classes.
485
486         https://bugs.webkit.org/show_bug.cgi?id=53071
487
488         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
489         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
490         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
491         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
492
493 2011-02-07  Ojan Vafai  <ojan@chromium.org>
494
495         Reviewed by Mihai Parparita.
496
497         stop generating results.json files
498         https://bugs.webkit.org/show_bug.cgi?id=53977
499
500         We've only used incremental_results.json for a while now
501         and there are plans to start generating a results.json file that matches
502         the format of unexpected_results.json.
503
504         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
505         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
506         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
507         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
508         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
509
510 2011-02-08  Sailesh Agrawal  <sail@chromium.org>
511
512         Reviewed by Kenneth Russell.
513
514         Invalidate rect doesn't work for windowless plugins on Chromium
515         https://bugs.webkit.org/show_bug.cgi?id=53117
516
517         Added two new utility methods.
518         - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
519         - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect
520         This is used to test that invalidating a rect correctly causes a repaint of the plugin.
521
522         * DumpRenderTree/LayoutTestController.cpp:
523         (displayInvalidatedRegionCallback):
524         (LayoutTestController::staticFunctions):
525         * DumpRenderTree/LayoutTestController.h:
526         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
527         (invalidateRect):
528         (pluginInvoke):
529         * DumpRenderTree/chromium/LayoutTestController.cpp:
530         (LayoutTestController::LayoutTestController):
531         (LayoutTestController::displayInvalidatedRegion):
532         * DumpRenderTree/chromium/LayoutTestController.h:
533         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
534
535 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
536
537         Reviewed by Tony Chang.
538
539         new-run-webkit-tests: move the logic that starts and stops the
540         servers from dump_render_tree_thread into single_test_runner
541         so that we can reuse it in the new multiprocessing worker class
542         as well.
543
544         https://bugs.webkit.org/show_bug.cgi?id=53840
545
546         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
547         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
548  
549 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
550
551         Reviewed by Mihai Parparita.
552
553         new-run-webkit-tests: split out thread stack logging code into a sharable module
554
555         This patch splits out the code used to find and log thread
556         stacks from NRWT-specific packages to something generic and
557         shareable by other python modules. It will be shared in the near
558         future by the manager_worker_broker module, for example.
559
560         https://bugs.webkit.org/show_bug.cgi?id=53656
561
562         * Scripts/webkitpy/common/system/stack_utils.py: Added.
563         * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
564         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
565         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
566
567 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
568
569         Reviewed by Tony Chang.
570
571         new-run-webkit-tests: move a bunch of testing logic out of
572         dump_render_tree_thread and into single_test_runner so that we
573         will be able to reuse it in the new multiprocessing worker class as well.
574
575         https://bugs.webkit.org/show_bug.cgi?id=53838
576
577         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
578         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
579
580         
581 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
582
583         Reviewed by Ojan Vafai.
584
585         new-run-webkit-tests: remove no longer needed WatchableThread
586         class.
587
588         https://bugs.webkit.org/show_bug.cgi?id=53839
589
590         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
591
592 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
593
594         Reviewed by Tony Chang.
595
596         new-run-webkit-tests: add stubs for the Manager objects that
597         will abstract the concurrency implementation (inline / threads /
598         processes). These classes do nothing yet and are not wired up to
599         anything.
600
601         https://bugs.webkit.org/show_bug.cgi?id=53477
602
603         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
604         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
605
606 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
607
608         Reviewed by Tony Chang.
609
610         new-run-webkit-tests: add simplified message broker for new-style
611         messaging. This change adds a very simple message broker that
612         will be used to shuttle messages between the TestRunner2 manager
613         thread and the Worker threads. For now the class is not used by
614         anything, but the eventual usage can be seen in the patches
615         attached to bug 49566.
616
617         https://bugs.webkit.org/show_bug.cgi?id=53158
618
619         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
620         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
621
622 2011-02-08  Adam Barth  <abarth@webkit.org>
623
624         Reviewed by Dimitri Glazkov.
625
626         chromium-win builder shouldn't run python or perl tests
627         https://bugs.webkit.org/show_bug.cgi?id=54032
628
629         These tests don't pass on this builder because the builder isn't
630         running in cygwin.  There isn't really any point in running them and
631         making the bot red forever.
632
633         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
634
635 2011-02-08  Brady Eidson  <beidson@apple.com>
636
637         Reviewed by Darin Adler.
638
639         <rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
640         didChangeBackForwardList should include some context about what changed
641
642         * MiniBrowser/mac/BrowserWindowController.m:
643         (didChangeBackForwardList):
644
645 2011-02-08  Sam Weinig  <sam@webkit.org>
646
647         Reviewed by Anders Carlsson.
648
649         WK2: Add ability to pass context to policy delegate methods
650         https://bugs.webkit.org/show_bug.cgi?id=54031
651
652         * MiniBrowser/mac/BrowserWindowController.m:
653         (decidePolicyForNavigationAction):
654         (decidePolicyForNewWindowAction):
655         (decidePolicyForMIMEType):
656         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
657         (TestWebKitAPI::decidePolicyForNavigationAction):
658         (TestWebKitAPI::decidePolicyForNewWindowAction):
659         (TestWebKitAPI::decidePolicyForMIMEType):
660         Update policy client for new API.
661
662 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
663
664         Reviewed by Xan Lopez.
665
666         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
667         https://bugs.webkit.org/show_bug.cgi?id=54033
668
669         Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
670         call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
671
672         * DumpRenderTree/gtk/DumpRenderTree.cpp:
673         (resetDefaultsToConsistentValues): Turn off the icon database.
674         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
675         (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk
676         method.
677
678 2011-02-08  Kundu Suchismita  <suchi.kundu@nokia.com>
679
680         Reviewed by Laszlo Gombos.
681
682         Local Storage settings can be enable/disable from "Develop" menu
683         https://bugs.webkit.org/show_bug.cgi?id=52296
684
685         * QtTestBrowser/launcherwindow.cpp:
686         (LauncherWindow::createChrome):
687         (LauncherWindow::toggleLocalStorage):
688         (LauncherWindow::toggleOfflineStorageDatabase):
689         (LauncherWindow::toggleOfflineWebApplicationCache):
690         (LauncherWindow::setOfflineStorageDefaultQuota):
691         * QtTestBrowser/launcherwindow.h:
692         (WindowOptions::WindowOptions):
693         * QtTestBrowser/main.cpp:
694         (LauncherApplication::handleUserOptions):
695
696 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
697
698         Reviewed by Eric Seidel.
699
700         [GTK] EventSender.keyDown does not support non-array modifier arguments
701         https://bugs.webkit.org/show_bug.cgi?id=53962
702
703         Support handling either an array or a string for the modifier argument
704         to EventSender.keyDown.
705
706         * DumpRenderTree/gtk/EventSender.cpp:
707         (gdkModifierFromJSValue): Added this helper which factors out the
708         string comparison bits.
709         (gdkModifersFromJSValue): Test up front whether the value is a string,
710         to handle it specially.
711
712 2011-02-08  Benjamin Poulain  <ikipou@gmail.com>
713
714         Reviewed by Csaba Osztrogonác.
715
716         openDatabaseSync() stop responding after too many call
717         https://bugs.webkit.org/show_bug.cgi?id=53945
718
719         Reset the database quota to a known state between each test.
720
721         Define a quota for the known origins at each test run and delete
722         all the databases.
723         This way, the database related test do not depend on previous
724         allocations.
725
726         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
727         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
728         (WebCore::DumpRenderTree::dumpDatabaseQuota):
729         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
730         (LayoutTestController::reset):
731
732 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
733
734         Reviewed by Martin Robinson.
735
736         [GTK] DRT's TextInputController is unimplemented on GTK
737         https://bugs.webkit.org/show_bug.cgi?id=52997
738
739         Initial implementation of TextInputController for GTK port.
740
741         * DumpRenderTree/gtk/DumpRenderTree.cpp:
742         (webViewWindowObjectCleared):
743         * DumpRenderTree/gtk/TextInputController.cpp: Added.
744         (setMarkedTextCallback):
745         (insertTextCallback):
746         (unmarkTextCallback):
747         (firstRectForCharacterRangeCallback):
748         (selectedRangeCallback):
749         (getClass):
750         (makeTextInputController):
751         * DumpRenderTree/gtk/TextInputController.h: Added.
752         * GNUmakefile.am:
753
754 2011-02-07  Tony Chang  <tony@chromium.org>
755
756         Reviewed by Adam Barth.
757
758         clean up python imports
759         https://bugs.webkit.org/show_bug.cgi?id=53966
760
761         Convert "import A.B.C.D as D" to "from A.B.C import D" and
762         make some imports absolute as required by PEP-8
763
764         * Scripts/webkitpy/common/checkout/scm.py:
765         * Scripts/webkitpy/common/net/irc/ircbot.py:
766         * Scripts/webkitpy/common/system/logutils.py:
767         * Scripts/webkitpy/common/system/logutils_unittest.py:
768         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
769         * Scripts/webkitpy/layout_tests/port/chromium.py:
770         * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
771         * Scripts/webkitpy/layout_tests/port/webkit.py:
772         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
773         * Scripts/webkitpy/tool/bot/irc_command.py:
774         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
775         * Scripts/webkitpy/tool/commands/download.py:
776         * Scripts/webkitpy/tool/commands/prettydiff.py:
777         * Scripts/webkitpy/tool/commands/queries.py:
778         * Scripts/webkitpy/tool/commands/roll.py:
779         * Scripts/webkitpy/tool/commands/stepsequence.py:
780         * Scripts/webkitpy/tool/commands/upload.py:
781         * Scripts/webkitpy/tool/main.py:
782
783 2011-02-07  James Robinson  <jamesr@chromium.org>
784
785         Reviewed by Adam Barth.
786
787         Teach do-webcore-rename about the WebKit move to Source/
788         https://bugs.webkit.org/show_bug.cgi?id=53967
789
790         * Scripts/do-webcore-rename:
791
792 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
793
794         Reviewed by Dan Bernstein.
795
796         Add resource load client for injected bundle and move willSendRequest there
797         https://bugs.webkit.org/show_bug.cgi?id=53972
798
799         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
800         (didCreatePage):
801         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
802         (WTR::InjectedBundlePage::InjectedBundlePage):
803         (WTR::InjectedBundlePage::didInitiateLoadForResource):
804         (WTR::InjectedBundlePage::didReceiveResponseForResource):
805         (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
806         (WTR::InjectedBundlePage::didFinishLoadForResource):
807         (WTR::InjectedBundlePage::didFailLoadForResource):
808         (WTR::InjectedBundlePage::willSendRequestForFrame):
809         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
810
811 2011-02-07  Adam Barth  <abarth@webkit.org>
812
813         Add Leopard Debug back to the core builders.
814
815         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
816         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
817
818 2011-02-07  Adam Klein  <adamk@chromium.org>
819
820         Reviewed by Jian Li.
821
822         [chromium] Remove deprecated method WebNotification::dir
823         https://bugs.webkit.org/show_bug.cgi?id=53735
824
825         * DumpRenderTree/chromium/NotificationPresenter.cpp:
826         (NotificationPresenter::show):
827
828 2011-02-07  Adam Barth  <abarth@webkit.org>
829
830         Reviewed by Eric Seidel.
831
832         Remove Leopard Debug as a core builder
833         https://bugs.webkit.org/show_bug.cgi?id=53971
834
835         The Leopard Debug builder has been failing to compile for several days.
836         My understanding is that folks are working on fixing the build, but for
837         the time being we should probably remove it from the list of core
838         builders so that the core waterfall can be green.  We can certainly add
839         it back once the build is fixed.
840
841         Also, I've removed the Tiger builders because those no longer appear to
842         be attached to the buildbot master.
843
844         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
845         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
846
847 2011-02-01  Ojan Vafai  <ojan@chromium.org>
848
849         Reviewed by Adam Roben.
850
851         include svn revisions in git diffs for the code review tool to use
852         https://bugs.webkit.org/show_bug.cgi?id=53569
853
854         * Scripts/webkitpy/common/checkout/scm.py:
855         * Scripts/webkitpy/common/checkout/scm_unittest.py:
856
857 2011-02-03  MORITA Hajime  <morrita@google.com>
858
859         Reviewed by Darin Fisher.
860
861         [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
862         https://bugs.webkit.org/show_bug.cgi?id=51013
863
864         Gave DRT implementation for requestTextCheck().
865
866         * DumpRenderTree/chromium/LayoutTestController.cpp:
867         (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
868         * DumpRenderTree/chromium/WebViewHost.cpp:
869         (invokeFinishLastTextCheck): Added.
870         (WebViewHost::requestTextCheck): Added.
871         (WebViewHost::finishLastTextCheck): Added.
872         * DumpRenderTree/chromium/WebViewHost.h:
873
874 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
875
876         Reviewed by Martin Robinson.
877
878         [Gtk] Implement layoutTestController.findString
879         https://bugs.webkit.org/show_bug.cgi?id=50237
880
881         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
882         (LayoutTestController::findString):
883
884 2011-02-07  Chang Shu  <chang.shu@nokia.com>
885
886         Reviewed by Darin Adler.
887
888         We should disable spatial navigation explicitly during the initialization
889         of DumpRenderTree.
890         https://bugs.webkit.org/show_bug.cgi?id=53928
891
892         * DumpRenderTree/mac/DumpRenderTree.mm:
893         (resetDefaultsToConsistentValues):
894
895 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
896
897         Not reviewed.
898
899         Fix WebKitTestRunner build on the SL bot.
900
901         * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
902         of ICU headers.
903
904 2011-02-07  Csaba Osztrogonác  <ossy@webkit.org>
905
906         Unreviewed.
907
908         [Qt][WK2] Buildfix after r77794.
909
910        WebKitTestRunner does not block remote resources or complain about them
911        https://bugs.webkit.org/show_bug.cgi?id=42139
912        <rdar://problem/8183942>
913
914         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
915
916 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
917
918         Not reviewed.
919
920         More bot appeasement.
921
922         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
923
924 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
925
926         Not reviewed.
927
928         Remove accidental references to directories on my laptop.
929
930         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
931
932 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
933
934         Reviewed by Antti Koivisto.
935
936         WebKitTestRunner does not block remote resources or complain about them
937         https://bugs.webkit.org/show_bug.cgi?id=42139
938         <rdar://problem/8183942>
939
940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
941         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
942         checks (using KURL, to avoid need to invent a whole URL API).
943         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
944         directly to get at KURL symbols.
945
946 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
947
948         Reviewed by Daniel Bates.
949
950         Add WebKit2 bot to list of expected builders in Python regression test results.
951         https://bugs.webkit.org/show_bug.cgi?id=53905
952
953         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
954
955 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
956
957         Reviewed by Ryosuke Niwa.
958
959         Update test expectations for new core builder
960         https://bugs.webkit.org/show_bug.cgi?id=53904
961
962         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
963
964 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
965
966         Reviewed by David Levin.
967
968         Add WebKit2 test bot to core builders
969         https://bugs.webkit.org/show_bug.cgi?id=53901
970
971         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
972
973 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
974
975         Another unreviewed Chromium build fix.
976
977         * DumpRenderTree/chromium/LayoutTestController.cpp:
978         (LayoutTestController::pathToLocalResource):
979
980 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
981
982         Unreviewed Chromium build fix.
983
984         * DumpRenderTree/chromium/LayoutTestController.cpp:
985         (LayoutTestController::pathToLocalResource):
986
987 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
988
989         Reviewed by Darin Adler.
990
991         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
992         https://bugs.webkit.org/show_bug.cgi?id=52867
993
994         * DumpRenderTree/chromium/ImageDiff.cpp:
995         (Image::craeteFromStdin): Call adoptArrayPtr.
996
997 2011-02-06  James Kozianski  <koz@chromium.org>
998
999         Reviewed by Ojan Vafai.
1000
1001         Add classes for representing test outputs.
1002         https://bugs.webkit.org/show_bug.cgi?id=52136
1003
1004         These classes will make it easier to write scripts that deal with test
1005         outputs such as rebaselining and deduping scripts. The intent is that
1006         eventually we will be have buildbot return TestOutputs for a
1007         particular build which can be compared with TestOutputs derived from a
1008         local LayoutTests directory.
1009
1010         * Scripts/webkitpy/common/net/testoutput.py: Added.
1011         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
1012         * Scripts/webkitpy/common/net/testoutputset.py: Added.
1013         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
1014         * Scripts/webkitpy/common/system/zip_mock.py: Added.
1015
1016 2011-02-06  Robert Hogan  <robert@webkit.org>
1017
1018         Reviewed by Andreas Kling.
1019
1020         [Qt] Clear page's groupName even when not in DRT
1021         https://bugs.webkit.org/show_bug.cgi?id=53874
1022
1023         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1024         (WebCore::DumpRenderTree::windowCloseRequested):
1025
1026 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
1027
1028         Reviewed by Andreas Kling.
1029
1030         [CMake] Add dependencies for Visual Studio projects
1031         https://bugs.webkit.org/show_bug.cgi?id=53773
1032
1033         Add a WebKit dependecy to WinCELauncher, so CMake can 
1034         generate the correct build order for the solution.
1035
1036         * CMakeListsWinCE.txt:
1037
1038 2011-02-06  Andreas Kling  <kling@webkit.org>
1039
1040         Reviewed by Antonio Gomes.
1041
1042         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
1043         https://bugs.webkit.org/show_bug.cgi?id=53869
1044
1045         * MiniBrowser/qt/BrowserView.cpp:
1046         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
1047         * MiniBrowser/qt/BrowserWindow.cpp:
1048         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
1049         * MiniBrowser/qt/BrowserWindow.h:
1050
1051 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
1052
1053         Reviewed by Dan Bernstein.
1054
1055         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
1056         https://bugs.webkit.org/show_bug.cgi?id=42690
1057         <rdar://problem/8213851>
1058
1059         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1060         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1061         (WTR::InjectedBundlePage::willSendRequestForFrame):
1062         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1063         (WTR::LayoutTestController::LayoutTestController):
1064         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1065         (WTR::LayoutTestController::willSendRequestReturnsNull):
1066         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
1067
1068 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1069
1070         Unreviewed, rolling out r77720.
1071         http://trac.webkit.org/changeset/77720
1072         https://bugs.webkit.org/show_bug.cgi?id=53854
1073
1074         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
1075         #webkit).
1076
1077         * Scripts/webkitpy/common/system/executive.py:
1078
1079 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1080
1081         Unreviewed, rolling out r77725.
1082         http://trac.webkit.org/changeset/77725
1083         https://bugs.webkit.org/show_bug.cgi?id=53844
1084
1085         It broke Qt minimal build (Requested by Ossy_ on #webkit).
1086
1087         * QtTestBrowser/launcherwindow.cpp:
1088         (LauncherWindow::createChrome):
1089         * QtTestBrowser/launcherwindow.h:
1090         (WindowOptions::WindowOptions):
1091         * QtTestBrowser/main.cpp:
1092         (LauncherApplication::handleUserOptions):
1093
1094 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
1095
1096         Reviewed by Adam Barth.
1097
1098         [GTK] plugins/plugin-document-back-forward.html fails
1099         https://bugs.webkit.org/show_bug.cgi?id=53833
1100
1101         Add the new "alert on load" functionality for the Unix version of the
1102         test plugin. This functionality was originally introduced in r77706.
1103
1104         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1105         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
1106
1107 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
1108
1109         Reviewed by Andreas Kling.
1110
1111         Local Storage settings can be enable/disable from "Develop" menu
1112         https://bugs.webkit.org/show_bug.cgi?id=52296
1113
1114         * QtTestBrowser/launcherwindow.cpp:
1115         (LauncherWindow::createChrome):
1116         (LauncherWindow::toggleLocalStorage):
1117         (LauncherWindow::toggleOfflineStorageDatabase):
1118         (LauncherWindow::toggleOfflineWebApplicationCache):
1119         (LauncherWindow::setOfflineStorageDefaultQuota):
1120         * QtTestBrowser/launcherwindow.h:
1121         (WindowOptions::WindowOptions):
1122         * QtTestBrowser/main.cpp:
1123         (LauncherApplication::handleUserOptions):
1124
1125 2011-02-04  Tony Chang  <tony@chromium.org>
1126
1127         Reviewed by Eric Seidel.
1128
1129         get test-webkitpy running on win32 python
1130         https://bugs.webkit.org/show_bug.cgi?id=53822
1131
1132         The test harness crashes with a WindowsError because it can't find
1133         'svn' when using subprocess.Popen.  This gets us past the error
1134         so we can see the failing tests on the Chromium Win Release Tests
1135         bot.
1136
1137         * Scripts/webkitpy/common/system/executive.py:
1138
1139 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
1140
1141         Reviewed by Gustavo Noronha Silva.
1142
1143         [GTK] fast/events/pagehide-timeout.html fails
1144         https://bugs.webkit.org/show_bug.cgi?id=53771
1145
1146         Add knowledge of the document browser cache model the DRT. When resetting
1147         WebKit settings to consistent values between tests, default to the document
1148         browser cache model.
1149
1150         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1151         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
1152         cache model between tests.
1153         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1154         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
1155         document browser cache model.
1156
1157 2011-02-04  Adam Barth  <abarth@webkit.org>
1158
1159         Reviewed by Eric Seidel.
1160
1161         PluginDocuments don't create widgets for plugins on back/forward
1162         https://bugs.webkit.org/show_bug.cgi?id=53474
1163
1164         Teach the test plugin how to call alert on load.
1165
1166         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1167         (NPP_New):
1168
1169 2011-02-04  Adam Roben  <aroben@apple.com>
1170
1171         Add a test case for encode/decode of FormData/FormDataElement
1172
1173         If the fix made in r77401 is broken, this new test will crash.
1174
1175         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
1176
1177         Reviewed by Sam Weinig.
1178
1179         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
1180         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
1181
1182         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
1183         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
1184         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
1185         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
1186         form, an return the session state data.
1187         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
1188         and restore it into another WKPage.
1189
1190         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
1191
1192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1193         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1194         * TestWebKitAPI/win/copy-resources.cmd:
1195         Added new files.
1196
1197 2011-02-04  Adam Roben  <aroben@apple.com>
1198
1199         Move code to run JavaScript tests into its own files
1200
1201         This will allow other tests to use this mechanism.
1202
1203         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
1204         world
1205
1206         Reviewed by Sam Weinig.
1207
1208         * TestWebKitAPI/JavaScriptTest.cpp: Added.
1209         * TestWebKitAPI/JavaScriptTest.h: Added.
1210         Moved code here...
1211
1212         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
1213
1214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1215         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1216         Added the new files.
1217
1218 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
1219
1220         Reviewed by Mihai Parparita.
1221
1222         merge test expectations for chromium, chromium-gpu. The
1223         chromium-gpu port will no longer maintain its own
1224         test expectations file.
1225
1226         Also add in a graphics_type() call on the port object to
1227         determine what graphics type to use in the test configuration,
1228         and log the configuration as a config setting.
1229
1230         https://bugs.webkit.org/show_bug.cgi?id=53562
1231
1232         * Scripts/webkitpy/layout_tests/port/base.py:
1233         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1234         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1235         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1236
1237 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
1238
1239         Reviewed by Pavel Feldman.
1240
1241         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
1242         https://bugs.webkit.org/show_bug.cgi?id=53781
1243
1244         * Scripts/check-inspector-strings:
1245
1246 2011-02-04  Adam Roben  <aroben@apple.com>
1247
1248         Include the crashing function in the link to a crash log on Mac
1249
1250         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
1251         function that crashed on Mac
1252
1253         Reviewed by David Kilzer.
1254
1255         * Scripts/old-run-webkit-tests:
1256         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
1257         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
1258         the crash log.
1259
1260 2011-02-04  Adam Roben  <aroben@apple.com>
1261
1262         Link to Mac crash logs from results.html
1263
1264         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
1265         results.html
1266
1267         Reviewed by David Kilzer.
1268
1269         * Scripts/old-run-webkit-tests:
1270         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
1271         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
1272
1273 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
1274
1275         Reviewed by Dan Bernstein.
1276
1277         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
1278         https://bugs.webkit.org/show_bug.cgi?id=52897
1279         <rdar://problem/8898294>
1280
1281         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1282         (WTR::InjectedBundlePage::InjectedBundlePage):
1283         (WTR::InjectedBundlePage::willSendRequestForFrame):
1284         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1285
1286 2011-02-03  Ivan Krstić  <ike@apple.com>
1287
1288         Unreviewed.
1289
1290         Adding myself to committers.py.
1291
1292         * Scripts/webkitpy/common/config/committers.py:
1293
1294 2011-02-03  James Kozianski  <koz@chromium.org>
1295
1296         Reviewed by Dimitri Glazkov.
1297
1298         Add navigator.registerProtocolHandler behind a flag.
1299         https://bugs.webkit.org/show_bug.cgi?id=52609
1300
1301         * Scripts/build-webkit:
1302
1303 2011-02-03  Hayato Ito  <hayato@chromium.org>
1304
1305         Reviewed by Eric Seidel.
1306
1307         [NRWT] Remove TestArgs class, which is wrongly used.
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=53063
1310
1311         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1312         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1313         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1314         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1315         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1316         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1317
1318 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
1319
1320         Reviewed by Kenneth Russell.
1321
1322         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
1323         https://bugs.webkit.org/show_bug.cgi?id=53714
1324
1325         * Scripts/build-webkit: change --3d-canvas build option
1326           to set ENABLE_WEBGL
1327
1328 2011-02-03  Hayato Ito  <hayato@chromium.org>
1329
1330         Reviewed by Tony Chang.
1331
1332         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
1333         move _run_single_test() and _process_output() functions from
1334         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
1335
1336         This is clean up and acts as a preparation for elimination of test_types/*
1337         classes. These classes will move to the single_test_runner module introduced
1338         in this patch.
1339
1340         https://bugs.webkit.org/show_bug.cgi?id=53004
1341
1342         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1343         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
1344         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1345         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
1346         * Scripts/webkitpy/layout_tests/port/base.py:
1347         * Scripts/webkitpy/layout_tests/port/chromium.py:
1348         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1349         * Scripts/webkitpy/layout_tests/port/test.py:
1350         * Scripts/webkitpy/layout_tests/port/webkit.py:
1351         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1352         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1353         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1354
1355 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1356
1357         Unreviewed, build fix.
1358
1359         Delete a line that was accidentally missed in r77586; without it
1360         there is still a race between the two threads.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=51572
1363
1364         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1365
1366 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1367
1368         Reviewed by Tony Chang.
1369
1370         nrwt: handle "broken pipe" notifications from DRT more cleanly.
1371
1372         https://bugs.webkit.org/show_bug.cgi?id=52927
1373
1374         * Scripts/webkitpy/layout_tests/port/server_process.py:
1375         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1376
1377 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1378
1379         Reviewed by Kenneth Russell.
1380
1381         Update, resubmit change to bug 51572. I think the race that was
1382         fixed in r76703 caused the hang that caused us to roll this
1383         patch out before, so I'd like to try again.
1384
1385         https://bugs.webkit.org/show_bug.cgi?id=51572
1386
1387         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1388         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1389
1390 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
1391
1392         Unreviewed.
1393
1394         Adding myself to committers.py.
1395
1396         * Scripts/webkitpy/common/config/committers.py:
1397
1398 2011-02-03  Adam Roben  <aroben@apple.com>
1399
1400         Include the crashing function in the link to a crash log
1401
1402         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
1403         function that crashed
1404
1405         Reviewed by David Kilzer.
1406
1407         * Scripts/old-run-webkit-tests:
1408         (crashLocation): Added. Returns the location of the crash.
1409         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
1410         could be determined.
1411
1412 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1413
1414         Unreviewed, build fix.
1415
1416         Actually make the changes suggested by Mihai in his review
1417         of bug 53720 :(
1418
1419         https://bugs.webkit.org/show_bug.cgi?id=53720
1420
1421         * Scripts/webkitpy/layout_tests/port/test_files.py:
1422         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1423
1424 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1425
1426         Reviewed by Mihai Parparita.
1427
1428         new-run-webkit-tests: Fix bug introduced in r77434 that was
1429         causing us to run the canvas GPU tests on the Mac GPU port. This
1430         bug revealed that we were not setting the port.name() field
1431         properly in many cases, so I've cleaned up all of that code, and
1432         removed a few comments about "version-specific" GPU ports that
1433         don't exist and just confused things.
1434
1435         Testing also revealed that port.abspath_for_test() wasn't
1436         normalizing paths on Windows properly, so I fixed that as well.
1437
1438         https://bugs.webkit.org/show_bug.cgi?id=53719
1439
1440         * Scripts/webkitpy/layout_tests/port/base.py:
1441         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1442         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1443
1444 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1445
1446         Reviewed by Mihai Parparita.
1447
1448         new-run-webkit-tests: fix normalization of paths on windows when gathering files
1449
1450         r77434 introduced a bug that was causing the test expectations
1451         for the GPU ports to not be treated properly. It turns out that
1452         when we gathered the list of test files on Windows, we would
1453         return paths of the form "c:\LayoutTests/fast/canvas", and the
1454         mixture of backslashes and forward slashes was confusing things.
1455
1456         This patch normalizes all of the filenames returned from
1457         test_files.find(), and adds better tests for this (fixing a
1458         couple of other bugs found in the meantime).
1459
1460         https://bugs.webkit.org/show_bug.cgi?id=53720
1461
1462         * Scripts/webkitpy/layout_tests/port/test.py:
1463         * Scripts/webkitpy/layout_tests/port/test_files.py:
1464         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1465
1466 2011-02-03  Adam Roben  <aroben@apple.com>
1467
1468         Add links to Windows crash logs in results.html
1469
1470         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
1471         results.html
1472
1473         Reviewed by David Kilzer.
1474
1475         * Scripts/old-run-webkit-tests:
1476         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
1477         createDebuggerCommandFile).
1478         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
1479         tool has exited.
1480         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
1481         it into the test results directory tree. Only implemented for Cygwin currently.
1482         (findNewestFileMatchingGlob): Added. Does what it says.
1483         (htmlForResultsSection): Only link to files that exist.
1484         (linksForErrorTest): Add a link to the crash log.
1485         (deleteExpectedAndActualResults): Delete any old crash log for this test.
1486         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
1487         hardcoding it here.
1488
1489 2011-02-03  Adam Roben  <aroben@apple.com>
1490
1491         Tell the debugger the path to the WebKit source tree when saving a crash log
1492
1493         This allows the debugger to include the crashing line of code in the log.
1494
1495         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
1496         of code
1497
1498         Reviewed by Sam Weinig.
1499
1500         * Scripts/old-run-webkit-tests:
1501         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
1502         file and returns the path to that file. The commands we pass came from
1503         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
1504         WebKit source code lives.
1505         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
1506         line using -c, save them to a file and specify the path to that file using -cf. This works
1507         around what is presumably a bug in Windows's command line parsing, where having multiple
1508         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
1509         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
1510         together to make them easier to modify in the future.
1511
1512 2011-02-02  Sam Weinig  <sam@webkit.org>
1513
1514         Reviewed by Anders Carlsson.
1515
1516         Add notification of the end of a rubber band.
1517         <rdar://problem/8940648>
1518
1519         * MiniBrowser/mac/BrowserWindowController.m:
1520         (-[BrowserWindowController awakeFromNib]):
1521         * WebKitTestRunner/TestController.cpp:
1522         (WTR::TestController::createOtherPage):
1523         (WTR::TestController::initialize):
1524         Stub out the new WKUIClient function.
1525
1526 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
1527
1528         Unreviewed.
1529
1530         Adding myself to committers.py.
1531
1532         * Scripts/webkitpy/common/config/committers.py:
1533
1534 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
1535
1536         Reviewed by Csaba Osztrogonác.
1537
1538         [Qt][WK2] MiniBrowser's window size should be 800x600
1539         https://bugs.webkit.org/show_bug.cgi?id=53670
1540
1541         Make layout test failure debugging easier.
1542         * MiniBrowser/qt/BrowserWindow.cpp:
1543         (BrowserWindow::BrowserWindow):
1544
1545 2011-02-02  Andy Estes  <aestes@apple.com>
1546
1547         Reviewed by Mark Rowe.
1548
1549         'update-webkit' should handle OpenSource and Internal using different
1550         VCSs.
1551
1552         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
1553         Internal directory.
1554
1555 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1556
1557         Reviewed by Mihai Parparita.
1558
1559         new-run-webkit-tests: hardcode the directories to scan for tests
1560         for GPU bots instead of SKIPping them. See bug 53562 for some
1561         context, but we will now hard-code the list of directories to
1562         use by default instead of skipping over directories in the
1563         expectations file. We do this so that we will be able to merge
1564         the expectations files without getting conflicting SKIP
1565         directives. Note that this change will reduce the # of tests
1566         being run on the Mac GPU bots, because we're accidentally
1567         including some today.
1568
1569         https://bugs.webkit.org/show_bug.cgi?id=53631
1570
1571         * Scripts/webkitpy/layout_tests/port/base.py:
1572         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1573         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1574
1575 2011-02-02  Sam Weinig  <sam@webkit.org>
1576
1577         Reviewed by Beth Dakin.
1578
1579         Add ChromeClient function to paint custom overhang areas.
1580         https://bugs.webkit.org/show_bug.cgi?id=53639
1581
1582         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1583         (WTR::InjectedBundlePage::InjectedBundlePage):
1584         Stub out new callback.
1585
1586 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1587
1588         Reviewed by Tony Chang.
1589
1590         new-run-webkit-tests: support chromium code paths in mock_drt
1591
1592         https://bugs.webkit.org/show_bug.cgi?id=53471
1593
1594         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1595         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1596
1597 2011-02-02  Adam Klein  <adamk@chromium.org>
1598
1599         Reviewed by Tony Chang.
1600
1601         Update new-run-webkit-tests --chromium to put output under Source/...
1602         https://bugs.webkit.org/show_bug.cgi?id=53612
1603
1604         * BuildSlaveSupport/test-result-archive:
1605         * Scripts/webkitpy/layout_tests/port/chromium.py:
1606
1607 2011-01-28  Tony Chang  <tony@chromium.org>
1608
1609         Reviewed by Eric Seidel.
1610
1611         [chromium] remove --use-test-shell from NRWT
1612         https://bugs.webkit.org/show_bug.cgi?id=53346
1613
1614         I've already started removing some of the bindings like eventSender so
1615         this already doesn't work isn't useful.  Also updated some comments to
1616         refer to DRT instead of test_shell.
1617
1618         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1619         * Scripts/webkitpy/layout_tests/port/chromium.py:
1620         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1621         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1622         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1623         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1624         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1625         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1626
1627 2011-02-02  Steve Lacey  <sjl@chromium.org>
1628
1629         Reviewed by Eric Carlson.
1630
1631         Implement basic media statistics on media elements.
1632         https://bugs.webkit.org/show_bug.cgi?id=53322
1633
1634         * Scripts/build-webkit:
1635
1636 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1637
1638         [wx] Build fixes for wxWebKit.
1639
1640         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1641         (LayoutTestController::setSerializeHTTPLoads):
1642         * wx/browser/wscript:
1643         * wx/build/build_utils.py:
1644         * wx/build/settings.py:
1645
1646 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1647
1648         Reviewed by Mihai Parparita.
1649
1650         new-run-webkit-tests: stop skipping so many tests
1651
1652         r77163 introduced a regression where we weren't resetting test
1653         expectations properly and were skipping too many tests as a
1654         result. This patch fixes that and adds a test for it.
1655
1656         https://bugs.webkit.org/show_bug.cgi?id=53551
1657
1658         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1659         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1660
1661 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1662
1663         Reviewed by Tony Chang.
1664
1665         new-run-webkit-tests: add first stub of test_runner2. This
1666         will add support for the 'inline', 'threads', and 'processes'
1667         flags to --worker-model, but for now the implementatios just
1668         fall back on the old ones.
1669
1670         https://bugs.webkit.org/show_bug.cgi?id=53157
1671
1672         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1673         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1674
1675 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
1676
1677         Reviewed by James Robinson.
1678
1679         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
1680         https://bugs.webkit.org/show_bug.cgi?id=53522
1681
1682         * Scripts/run-chromium-webkit-unit-tests:
1683
1684 2011-02-01  Adam Barth  <abarth@webkit.org>
1685
1686         Reviewed by Mihai Parparita.
1687
1688         Using Control-C to cancel webkit-patch or other python tools causes
1689         unpleasant traceback console spew
1690         https://bugs.webkit.org/show_bug.cgi?id=53462
1691
1692         Catch the exception and don't print the stack trace.
1693
1694         * Scripts/webkit-patch:
1695
1696 2011-02-01  Scott Cameron  <sccameron@rim.com>
1697
1698         Reviewed by Daniel Bates.
1699
1700         Use Windows format for MinGW HTTPD path.
1701         https://bugs.webkit.org/show_bug.cgi?id=53503
1702
1703         * Scripts/webkitperl/httpd.pm:
1704           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
1705             so that we don't have to escape the space characters in the path. Also,
1706             changed path to Windows-style path and removed FIXME comment.
1707
1708 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
1709
1710         Reviewed by Andreas Kling.
1711
1712         [Qt][WK2] Add a way to use shared process model in MiniBrowser
1713         https://bugs.webkit.org/show_bug.cgi?id=53090
1714
1715         * MiniBrowser/qt/BrowserView.cpp:
1716         (BrowserView::BrowserView): Removed the m_context member.
1717         From now the context is guaranteed to be non-null and we
1718         don't need to store that in the object.
1719         * MiniBrowser/qt/BrowserView.h:
1720         * MiniBrowser/qt/BrowserWindow.cpp:
1721         Added static bool to determine that new windows need to be
1722         created with their own context or not. Use the same context
1723         and web process by default to be inilne with the other ports.
1724         (BrowserWindow::BrowserWindow):
1725         (BrowserWindow::newWindow):
1726         * MiniBrowser/qt/BrowserWindow.h:
1727         * MiniBrowser/qt/main.cpp:
1728         (main): Added command line switch to be able to use the
1729         non-shared process model. Simplify the handling of the command line
1730         switches a little bit.
1731
1732 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1733
1734         Reviewed by Andreas Kling.
1735
1736         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
1737         https://bugs.webkit.org/show_bug.cgi?id=53491
1738
1739         * MiniBrowser/qt/BrowserWindow.cpp:
1740         (BrowserWindow::BrowserWindow):
1741         (BrowserWindow::toggleFullScreenMode):
1742         * MiniBrowser/qt/BrowserWindow.h:
1743
1744 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1745
1746         Reviewed by Andreas Kling.
1747
1748         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
1749         https://bugs.webkit.org/show_bug.cgi?id=53489
1750
1751         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
1752         to Settings menu.
1753
1754         * MiniBrowser/qt/BrowserWindow.cpp:
1755         (BrowserWindow::BrowserWindow):
1756         (BrowserWindow::toggleFrameFlattening):
1757         (BrowserWindow::toggleDisableJavaScript):
1758         (BrowserWindow::toggleAutoLoadImages):
1759         * MiniBrowser/qt/BrowserWindow.h:
1760
1761 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
1762
1763         Reviewed by Tony Chang.
1764
1765         [Chromium] Switch chromium-mac to use ChromiumDriver
1766         https://bugs.webkit.org/show_bug.cgi?id=53461
1767         
1768         For the sake of consistency with the other Chromium platforms (and so
1769         that chromium-mac picks up special flags like --enable-hardware-gpu),
1770         switch chromium-mac from the WebKitDriver to ChromiumDriver.
1771
1772         * Scripts/webkitpy/layout_tests/port/chromium.py:
1773
1774 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
1775
1776         Reviewed by Mihai Parparita.
1777
1778         The current modifier parsing code in test_expectations is
1779         fragile and hard-coded, so it's not easy to understand the logic
1780         or easily add new types of modifiers (like GPU vs. CPU testing
1781         for graphics tests, or 32-bit vs. 64-bit differences).
1782
1783         This is the first of two patches that will add in more generic
1784         support and then eliminate the GPU-specific test expectations
1785         files for Chromium.
1786
1787         This patch adds two standalone objects for handling modifiers. The
1788         rules for interpreting modifiers, precedence, and conflicts are
1789         given in the docstring to the ModifierMatcher class, which
1790         returns ModifierMatchResult objects.
1791         
1792         This patch also adds routines to the Port interface and a
1793         default set of values in the base object, in order to obtain the
1794         values needed on a given test run. These values are then passed
1795         to the expectation parser. This also allows us to clean up the
1796         logic used to lint all of the different configurations in a
1797         single test_expectations.txt file.
1798
1799         The next patch will merge in the separate GPU expectations file.
1800
1801         https://bugs.webkit.org/show_bug.cgi?id=51222
1802
1803         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1804         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1805         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1806         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1807         * Scripts/webkitpy/layout_tests/port/base.py:
1808         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1809         * Scripts/webkitpy/layout_tests/port/chromium.py:
1810         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1811         * Scripts/webkitpy/layout_tests/port/test.py:
1812         * Scripts/webkitpy/layout_tests/port/webkit.py:
1813         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1814         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1815         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1816         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
1817         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1818
1819 2011-01-31  Scott Cameron  <sccameron@rim.com>
1820
1821         Reviewed by Daniel Bates.
1822
1823         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
1824         https://bugs.webkit.org/show_bug.cgi?id=50036
1825
1826         This will add an Apache2.2 configuration file and modifies scripts to allow
1827         running an httpd server in an MSYS environment.
1828
1829         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
1830         in order to allow for simple installation/execution.  Simply install the latest
1831         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
1832         be able to execute run-webkit-httpd.
1833         
1834
1835         * Scripts/run-webkit-httpd:
1836         * Scripts/webkitperl/httpd.pm:
1837
1838 2011-01-31  Tony Chang  <tony@chromium.org>
1839
1840         Reviewed by Eric Seidel.
1841
1842         mac DRT should report RTL scroll offset relative to top right corner
1843         https://bugs.webkit.org/show_bug.cgi?id=53324
1844
1845         * DumpRenderTree/mac/DumpRenderTree.mm:
1846         (dumpFrameScrollPosition):
1847
1848 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
1849
1850         Reviewed by Andreas Kling.
1851
1852         [Qt] Add Take Screen Shot action to MiniBrowser
1853         https://bugs.webkit.org/show_bug.cgi?id=53422
1854
1855         Add Take Screen Shot action to MiniBrowser's view menu.
1856
1857         * MiniBrowser/qt/BrowserWindow.cpp:
1858         (BrowserWindow::BrowserWindow):
1859         (BrowserWindow::screenshot):
1860         * MiniBrowser/qt/BrowserWindow.h:
1861
1862 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1863
1864         Reviewed by Xan Lopez.
1865
1866         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
1867         https://bugs.webkit.org/show_bug.cgi?id=53379
1868
1869         Remove left over #ifdef's. I thought all of the conditional code
1870         had been freed from the condition, but I forgot to check DRT.
1871
1872         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1873         (resetDefaultsToConsistentValues):
1874         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1875         (LayoutTestController::setAlwaysAcceptCookies):
1876
1877 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1878
1879         Unreviewed, build fix.
1880
1881         Fix regression introduced in r77093 - path.rsplit() doesn't
1882         take keyword arguments.
1883
1884         https://bugs.webkit.org/show_bug.cgi?id=53326
1885
1886         * Scripts/webkitpy/common/system/filesystem_mock.py:
1887
1888 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1889
1890         Reviewed by Mihai Parparita.
1891
1892         Add more unit tests for rebaseline-chromium-webkit-tests. This
1893         change involves restructuring a bunch of r-c-w-t code to make it
1894         more testable as well. We also add wrapper classes for handling
1895         testing zip files and fetching URLs.
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=53040
1898
1899         * Scripts/webkitpy/common/system/urlfetcher.py:
1900         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
1901         * Scripts/webkitpy/common/system/zipfileset_mock.py:
1902         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1903         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1904         * Scripts/webkitpy/tool/mocktool.py:
1905
1906 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1907
1908         Reviewed by Eric Seidel.
1909
1910         Clean up of the filesystem-related modules used in webkitpy.
1911         I've added relpath() to the filesystem interface, modified
1912         ospath.relpath() so that it could work with the filesystem
1913         interface, and modified the fileset* routines to use the
1914         filesystem interface consistently.
1915
1916         This patch also adds a close() routine to the fileset routines
1917         to indicate that the caller is done with the fileset. This
1918         allows zipfileset to clean up after itself when it creates
1919         tempfiles to store downloads.
1920
1921         https://bugs.webkit.org/show_bug.cgi?id=53326
1922
1923         * Scripts/webkitpy/common/system/directoryfileset.py:
1924         * Scripts/webkitpy/common/system/fileset.py:
1925         * Scripts/webkitpy/common/system/filesystem.py:
1926         * Scripts/webkitpy/common/system/filesystem_mock.py:
1927         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1928         * Scripts/webkitpy/common/system/ospath.py:
1929         * Scripts/webkitpy/common/system/zipfileset.py:
1930         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1931
1932 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
1933
1934         Reviewed by Csaba Osztrogonác.
1935
1936         [Qt][WK2]REGRESSION (r76991): Fix build errors
1937         https://bugs.webkit.org/show_bug.cgi?id=53400
1938
1939         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
1940         and remove WebKit2Prefix.h from the build.
1941         * MiniBrowser/qt/MiniBrowser.pro:
1942
1943 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1944
1945         Unreviewed.
1946
1947         [Qt][WK2] Buildfix.
1948
1949         * MiniBrowser/qt/MiniBrowser.pro:
1950
1951 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1952
1953         Reviewed by Adam Roben.
1954         
1955         define NOMINMAX when building ImageDiff, as we do elsewhere.
1956
1957         Add various clampToInt() methods to MathExtras.h
1958         https://bugs.webkit.org/show_bug.cgi?id=52910
1959
1960         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1961
1962 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1963
1964         Reviewed by Darin Adler.
1965
1966         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1967         https://bugs.webkit.org/show_bug.cgi?id=42682
1968
1969         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1970         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1971         (WTR::InjectedBundle::resetLocalSettings):
1972         (WTR::InjectedBundle::didReceiveMessage):
1973         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1974         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1975         (WTR::LayoutTestController::setPOSIXLocale):
1976         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1977
1978 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1979  
1980          Reviewed by Mihai Parparita.
1981  
1982          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1983  
1984          This patch re-enables this test and changes it to
1985          handle all of the mac platform versions, not just the one
1986          it is running on.
1987  
1988          https://bugs.webkit.org/show_bug.cgi?id=53356
1989  
1990          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1991  
1992 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1993
1994         Unreviewed, build fix.
1995
1996         Take two. The fix in 77023 didn't work, because we were
1997         still calling path.abspath_to_uri, which calls _cygpath under
1998         the covers, and it appears the cygpath on the bots does
1999         something different than it does on my machine. This patch
2000         removes the calls to path.abspath_to_uri, so it should be safe.
2001         If it doesn't work, I'll roll it out along with r76982 and 77023.
2002
2003         https://bugs.webkit.org/show_bug.cgi?id=53126
2004
2005         * Scripts/webkitpy/layout_tests/port/test.py:
2006
2007 2011-01-28  David Kilzer  <ddkilzer@apple.com>
2008
2009         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
2010         <http://webkit.org/b/53353>
2011
2012         Reviewed by Mark Rowe.
2013
2014         * Scripts/webkitdirs.pm:
2015         (checkRequiredSystemConfig): Check the Xcode marketing version
2016         in addition to the DevCoreTools build version before complaining
2017         about an old version of Xcode.  Also make the Mac OS X version
2018         check use Perl's built-in version string comparitor.
2019
2020 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2021
2022         Unreviewed, build fix.
2023
2024         Work around breakage on Win 7 Release bot caused by r76982
2025         and the fact that windows ports use "file:////" instead of
2026         "file:///". Ideally the test code should be isolated from
2027         this, but it isn't yet. Will fix properly in a bit.
2028
2029         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2030
2031 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2032
2033         Reviewed by Tony Chang.
2034
2035         new-run-webkit-tests: change worker model values to
2036         "old-inline", "old-threads" in preparation for test_runner2 /
2037         multiprocessing changes.
2038
2039         https://bugs.webkit.org/show_bug.cgi?id=53156
2040
2041         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2042         * Scripts/webkitpy/layout_tests/port/base.py:
2043         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2044         * Scripts/webkitpy/layout_tests/port/mac.py:
2045         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2046
2047 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2048
2049         Reviewed by Tony Chang.
2050
2051         committers.py - add an IRC nickname for dpranke
2052         https://bugs.webkit.org/show_bug.cgi?id=53335
2053
2054         * Scripts/webkitpy/common/config/committers.py:
2055
2056 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2057
2058         Reviewed by Tony Chang.
2059
2060         new-run-webkit-tests: add a "mock DRT" port implementation
2061         and a separate class that emulates what we expect the
2062         DumpRenderTree behavior to be.
2063
2064         This will eventually replace port/dryrun.py and allow us to get
2065         better test coverage of the new-run-webkit-tests code as well as
2066         a reference for what new-run-webkit-tests expects from DRT.
2067
2068         This is the first attempt at this, and it is pretty bare-boned. It
2069         really only has been tested on the 'mac' port (and a little on
2070         the 'chromium-mac' port.
2071
2072         https://bugs.webkit.org/show_bug.cgi?id=53126
2073
2074         * Scripts/webkitpy/common/system/filesystem_mock.py:
2075         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2076         * Scripts/webkitpy/layout_tests/port/factory.py:
2077         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
2078         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
2079         * Scripts/webkitpy/layout_tests/port/test.py:
2080
2081 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2082
2083         Unreviewed. Removing .swp file checked in by mistake.
2084
2085         * Scripts/.webkitdirs.pm.swp: Removed.
2086
2087 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2088
2089         Reviewed by David Kilzer.
2090
2091         Space not necessary for undefined feature
2092         https://bugs.webkit.org/show_bug.cgi?id=53317
2093
2094         * Scripts/build-webkit:
2095
2096 2011-01-28  Chang Shu  <chang.shu@nokia.com>
2097
2098         Reviewed by Andreas Kling.
2099
2100         Reset NetworkAccessManager to clean up credentials from previous tests.
2101         This change causes no performance overhead either.
2102         https://bugs.webkit.org/show_bug.cgi?id=36688
2103
2104         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2105         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2106         (WebCore::DumpRenderTree::open):
2107         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2108
2109 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
2110
2111         Reviewed by Andreas Kling.
2112
2113         [Qt] Add Zoom Text Only action to MiniBrowser
2114         https://bugs.webkit.org/show_bug.cgi?id=53297
2115
2116         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
2117
2118         * MiniBrowser/qt/BrowserWindow.cpp:
2119         (BrowserWindow::BrowserWindow):
2120         (BrowserWindow::zoomIn):
2121         (BrowserWindow::zoomOut):
2122         (BrowserWindow::resetZoom):
2123         (BrowserWindow::toggleZoomTextOnly):
2124         (BrowserWindow::applyZoom):
2125         * MiniBrowser/qt/BrowserWindow.h:
2126
2127 2011-01-28  Adam Barth  <abarth@webkit.org>
2128
2129         Reviewed by Eric Seidel.
2130
2131         Add webkit-patch roll-chromium-deps
2132         https://bugs.webkit.org/show_bug.cgi?id=53288
2133
2134         This command updates the Source/WebKit/chromium/DEPS file with the
2135         last-known good revision of Chromium (or a revision specified on the
2136         command line).  I'd eventually like to turn this into a SheriffBot
2137         command, but this is the first step.
2138
2139         This patch somewhat sprawled because I needed to move a bunch of code
2140         out of ChangeLog that should never have been there in the first place.
2141         Also, I had to fix a bug in MockUser in order to test the new command.
2142
2143         * Scripts/webkitpy/common/checkout/api.py:
2144         * Scripts/webkitpy/common/checkout/changelog.py:
2145         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2146         * Scripts/webkitpy/common/checkout/deps.py: Added.
2147         * Scripts/webkitpy/common/config/urls.py:
2148         * Scripts/webkitpy/tool/commands/__init__.py:
2149         * Scripts/webkitpy/tool/commands/download_unittest.py:
2150         * Scripts/webkitpy/tool/commands/roll.py: Added.
2151         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
2152         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2153         * Scripts/webkitpy/tool/mocktool.py:
2154         * Scripts/webkitpy/tool/steps/__init__.py:
2155         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
2156         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2157         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
2158         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2159         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
2160         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2161
2162 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
2163
2164         Reviewed by Laszlo Gombos.
2165
2166         Get rid of prefix header dependency for WebKit2 build system
2167         https://bugs.webkit.org/show_bug.cgi?id=50174
2168
2169         Change the style checker so that it enforces config.h include for
2170         WebKit2.
2171
2172         * Scripts/webkitpy/style/checker.py:
2173
2174 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
2175
2176         Reviewed by Darin Adler.
2177
2178         execCommand("Paste") doesn't work in WebKitTestRunner
2179         https://bugs.webkit.org/show_bug.cgi?id=52785
2180
2181         Enable both of the settings needed to allow paste.
2182         
2183         * WebKitTestRunner/TestController.cpp:
2184         (WTR::TestController::resetStateToConsistentValues):
2185
2186 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
2187
2188         Reviewed by Andreas Kling.
2189
2190         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
2191         https://bugs.webkit.org/show_bug.cgi?id=48440
2192
2193         Preserve user input when toggling use of QGraphicsView
2194
2195         * QtTestBrowser/launcherwindow.cpp:
2196         (LauncherWindow::initializeView):
2197         (LauncherWindow::loadFinished):
2198         * QtTestBrowser/launcherwindow.h:
2199         * QtTestBrowser/mainwindow.cpp:
2200         (MainWindow::addressUrl):
2201         * QtTestBrowser/mainwindow.h:
2202
2203 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
2204
2205         Reviewed by Mihai Parparita.
2206
2207         new-run-webkit-tests: turn off pixel tests correctly by default
2208         for webkit-based ports. r70013 (bug 47510) used
2209         port.set_option_default() to attempt to set default values, but
2210         that didn't work correctly. I have removed set_option_default
2211         for now since it was only being used in two places and in three
2212         useless unit tests. There is a separate bug open to fix the
2213         option parsing (48095), so this workaround is fine for now.
2214
2215         https://bugs.webkit.org/show_bug.cgi?id=53217
2216
2217         * Scripts/webkitpy/layout_tests/port/webkit.py:
2218         * Scripts/webkitpy/layout_tests/port/base.py:
2219         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2220
2221 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
2222
2223         Rubber-stamped by Ariya Hidayat.
2224
2225         Trivial crash fix in WTR.
2226
2227         * WebKitTestRunner/TestController.cpp:
2228         (WTR::TestController::initialize): Increase the size
2229         of the vector by one to be able to store the null character.
2230
2231 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
2232
2233         Reviewed by Csaba Osztrogonác.
2234
2235         [Qt][WK2] WTR should be initialized in the same way as DRT
2236         https://bugs.webkit.org/show_bug.cgi?id=53240
2237
2238         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2239         (WTR::activateFonts): Added missing initialization steps.
2240
2241 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
2242
2243         Unreviewed. 
2244
2245         Adding myself to committers.py.
2246
2247         * Scripts/webkitpy/common/config/committers.py:
2248
2249 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2250
2251         Reviewed by Csaba Osztrogonác.
2252
2253         [Qt] [Symbian] Move project files into Source
2254         https://bugs.webkit.org/show_bug.cgi?id=52891
2255
2256         Fix the Symbian build after the project files
2257         are moved to Source directory. On Symbian qmake
2258         needs to run in the same directory where the main
2259         pro files (WebKit.pro, Tools.pro) are located.
2260
2261         * Scripts/webkitdirs.pm: Change to the directory where the pro file
2262         is located before running qmake for Symbian. Qmake on Symbian
2263         does not properly honor the "-o" option, work it around by setting
2264         the name of the Makefile to bld.inf.
2265
2266 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
2267
2268         Reviewed by Andreas Kling.
2269
2270         [Qt] Add simple zooming features to MiniBrowser
2271         https://bugs.webkit.org/show_bug.cgi?id=53231
2272
2273         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
2274
2275         * MiniBrowser/qt/BrowserWindow.cpp:
2276         (BrowserWindow::BrowserWindow):
2277         (BrowserWindow::zoomIn):
2278         (BrowserWindow::zoomOut):
2279         (BrowserWindow::resetZoom):
2280         (BrowserWindow::updateUserAgentList):
2281         (BrowserWindow::applyZoom):
2282         * MiniBrowser/qt/BrowserWindow.h:
2283
2284 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
2285
2286         Reviewed by Dan Bernstein.
2287
2288         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
2289         https://bugs.webkit.org/show_bug.cgi?id=42319
2290         
2291         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
2292
2293         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2294         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2295         (WTR::LayoutTestController::showWebInspector):
2296         (WTR::LayoutTestController::closeWebInspector):
2297         (WTR::LayoutTestController::evaluateInWebInspector):
2298         (WTR::LayoutTestController::setTimelineProfilingEnabled):
2299         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2300         * WebKitTestRunner/TestInvocation.cpp:
2301         (WTR::shouldOpenWebInspector):
2302         (WTR::TestInvocation::invoke):
2303         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2304
2305 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
2306
2307         Reviewed by Xan Lopez.
2308
2309         [GTK] Pixel dumps do not include scrollbars in output images
2310         https://bugs.webkit.org/show_bug.cgi?id=53216
2311
2312         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
2313         that have scrollbars.
2314
2315         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2316         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
2317         instead of the web view itself.
2318
2319 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
2320
2321         Reviewed by Mihai Parparita.
2322
2323         Fix regression introduced in r76322 ... new-run-webkit-tests
2324         was attempting to save the image diff output as a UTF-8-encoded
2325         file.
2326
2327         https://bugs.webkit.org/show_bug.cgi?id=53210
2328
2329         * Scripts/webkitpy/layout_tests/port/webkit.py:
2330
2331 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2332
2333         Unreviewed, rolling out r76709.
2334         http://trac.webkit.org/changeset/76709
2335         https://bugs.webkit.org/show_bug.cgi?id=53194
2336
2337         "broke python tests on non-snowleopard platforms" (Requested
2338         by dpranke on #webkit).
2339
2340         * Scripts/webkitpy/layout_tests/port/factory.py:
2341         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
2342         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
2343
2344 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
2345
2346         Reviewed by Tony Chang.
2347
2348         new-run-webkit-tests: add a "mock DRT" port implementation
2349         and a separate class that emulates what we expect the
2350         DumpRenderTree behavior to be.
2351
2352         This will eventually replace port/dryrun.py and allow us to get
2353         better test coverage of the new-run-webkit-tests code as well as
2354         a reference for what new-run-webkit-tests expects from DRT.
2355
2356         This is the first attempt at this, and it is pretty bare-boned. It
2357         really only has been tested on the 'mac' port (and a little on
2358         the 'chromium-mac' port.
2359
2360         https://bugs.webkit.org/show_bug.cgi?id=53126
2361
2362         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
2363         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
2364         * Scripts/webkitpy/layout_tests/port/factory.py:
2365
2366 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
2367
2368         Reviewed by Tony Chang.
2369
2370         Add '--no-timeout' option to Chromium DRT to ease debugging.
2371         https://bugs.webkit.org/show_bug.cgi?id=52873
2372
2373         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2374         (main):
2375
2376 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2377
2378         Reviewed by Andreas Kling.
2379
2380         [Qt] Fix qt_minimal build
2381         https://bugs.webkit.org/show_bug.cgi?id=53172
2382
2383         * QtTestBrowser/locationedit.h:
2384
2385 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
2386
2387         Reviewed by Antonio Gomes.
2388
2389         QtTestBrowser should have a UI Setting to disable plugins
2390         https://bugs.webkit.org/show_bug.cgi?id=52408
2391         
2392         Added a new action item named "Disable Plugins"
2393         under the "Settings" menu. 
2394
2395         * QtTestBrowser/launcherwindow.cpp:
2396         (LauncherWindow::createChrome):
2397         (LauncherWindow::togglePlugins):
2398         * QtTestBrowser/launcherwindow.h:
2399
2400 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2401
2402         Reviewed by Adam Barth.
2403
2404         Move main CMakeLists.txt into Source directory
2405         https://bugs.webkit.org/show_bug.cgi?id=52888
2406
2407         * Scripts/webkitdirs.pm:
2408
2409 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2410
2411         Reviewed by Eric Seidel.
2412
2413         Improve label text in submit-to-ews
2414         https://bugs.webkit.org/show_bug.cgi?id=53130
2415
2416         * QueueStatusServer/templates/submittoews.html:
2417
2418 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
2419
2420         Reviewed by Antonio Gomes.
2421
2422         QtTestBrowser should have a UI Settings to prevent loading images
2423         https://bugs.webkit.org/show_bug.cgi?id=52409
2424         
2425         Added a new action item named "DisableAutoLoadImages"
2426         under the "Settings" menu 
2427
2428         * QtTestBrowser/launcherwindow.cpp:
2429         (LauncherWindow::createChrome):
2430         (LauncherWindow::toggleAutoLoadImages):
2431         * QtTestBrowser/launcherwindow.h:
2432
2433 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
2434
2435         Reviewed by Tony Chang.
2436
2437         Minor bug fixes and cleanup for filesystem wrappers, port/* test
2438         classes, test_expectations.py. This change adds "test-win" and
2439         "test-mac" variants to the test port so that we can better test
2440         rebaselining, and adds a MockUser() object for reuse in testing.
2441
2442         https://bugs.webkit.org/show_bug.cgi?id=53036
2443
2444         * Scripts/webkitpy/common/system/filesystem.py:
2445         * Scripts/webkitpy/common/system/filesystem_mock.py:
2446         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2447         * Scripts/webkitpy/layout_tests/port/factory.py:
2448         * Scripts/webkitpy/layout_tests/port/base.py:
2449         * Scripts/webkitpy/layout_tests/port/test.py:
2450         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2451         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2452         * Scripts/webkitpy/tool/mocktool.py:
2453
2454 2011-01-25  Tony Chang  <tony@chromium.org>
2455
2456         Reviewed by Dimitri Glazkov.
2457
2458         [chromium] remove unused layoutTestController callback
2459         https://bugs.webkit.org/show_bug.cgi?id=53103
2460
2461         This method is used by a test_shell_test, but not needed by DRT.
2462
2463         * DumpRenderTree/chromium/LayoutTestController.cpp:
2464         (LayoutTestController::LayoutTestController):
2465         * DumpRenderTree/chromium/LayoutTestController.h:
2466
2467 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2468
2469         Reviewed by Andreas Kling.
2470
2471         [GTK] Remove 64 bits release bot from the buildbot master
2472         https://bugs.webkit.org/show_bug.cgi?id=52899
2473
2474         Removes the 64 bits release slave from the buildbot configuration,
2475         so that we can use it as an EWS.
2476
2477         * BuildSlaveSupport/build.webkit.org-config/config.json:
2478
2479 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2480
2481         Reviewed by Dan Bernstein.
2482
2483         Implement database quota callback to fix storage tests on WebKit2 bot
2484         https://bugs.webkit.org/show_bug.cgi?id=53064
2485
2486         * WebKitTestRunner/TestController.cpp:
2487         (WTR::exceededDatabaseQuota):
2488         (WTR::TestController::createOtherPage):
2489         (WTR::TestController::initialize):
2490
2491 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2492
2493         Reviewed by Anders Carlsson.
2494
2495         Use designated temp directory for the database for WebKit2
2496         https://bugs.webkit.org/show_bug.cgi?id=53052
2497         
2498         Adopt the new WK2 API for this.
2499
2500         * WebKitTestRunner/TestController.cpp:
2501         (WTR::TestController::libraryPathForTesting):
2502         (WTR::TestController::initialize):
2503         * WebKitTestRunner/TestController.h:
2504         * WebKitTestRunner/mac/TestControllerMac.mm:
2505         (WTR::TestController::platformLibraryPathForTesting):
2506         * WebKitTestRunner/qt/TestControllerQt.cpp:
2507         (WTR::TestController::platformLibraryPathForTesting):
2508         * WebKitTestRunner/win/TestControllerWin.cpp:
2509         (WTR::TestController::platformLibraryPathForTesting):
2510
2511 2011-01-24  Lucas Forschler  <lforschler@apple.com>
2512
2513         Reviewed by Stephanie Lewis.
2514
2515         Add a new Leopard test bot.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/config.json:
2518
2519 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2520
2521         Reviewed by Adam Barth.
2522
2523         Add EFL Builder to core waterfall
2524         https://bugs.webkit.org/show_bug.cgi?id=52704
2525
2526         Add EFL Builder to the core waterfall again.
2527
2528         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2529         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2530
2531 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
2532
2533         Reviewed by Tony Chang.
2534
2535         new-run-webkit-tests fails to start HTTP server if there are proxy settings
2536         https://bugs.webkit.org/show_bug.cgi?id=52872
2537
2538         Force disabling proxy to resolve the problem.
2539
2540         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2541         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2542
2543 2011-01-24  Andreas Kling  <kling@webkit.org>
2544
2545         Reviewed by Darin Adler.
2546
2547         check-webkit-style: Update exemptions following Source/ move.
2548         https://bugs.webkit.org/show_bug.cgi?id=53017
2549
2550         * Scripts/webkitpy/style/checker.py:
2551         * Scripts/webkitpy/style/checker_unittest.py:
2552
2553 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2554
2555         Rubber-stamped by Csaba Osztrogonác.
2556
2557         [Qt] Move project files into Source
2558         https://bugs.webkit.org/show_bug.cgi?id=52891
2559
2560         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
2561
2562 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
2563
2564         Reviewed by Yury Semikhatsky.
2565
2566         Web Inspector: Find duplicate strings in localizedStrings.js
2567
2568         https://bugs.webkit.org/show_bug.cgi?id=53005
2569
2570         * Scripts/check-inspector-strings:
2571
2572 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
2573
2574         Reviewed by Andreas Kling.
2575
2576         [Qt] Regroup MiniBrowser's menubar and add open file action
2577         https://bugs.webkit.org/show_bug.cgi?id=53000
2578
2579         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
2580
2581         * MiniBrowser/qt/BrowserWindow.cpp:
2582         (BrowserWindow::BrowserWindow):
2583         (BrowserWindow::openFile):
2584         (BrowserWindow::~BrowserWindow):
2585         * MiniBrowser/qt/BrowserWindow.h:
2586
2587 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
2588
2589         Unreviewed fix after r76496
2590
2591         [Qt] Move project files into Source
2592         https://bugs.webkit.org/show_bug.cgi?id=52891
2593
2594         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
2595         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
2596         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2597
2598 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2599
2600         Reviewed by Csaba Osztrogonác.
2601
2602         [Qt] Move project files into Source
2603         https://bugs.webkit.org/show_bug.cgi?id=52891
2604
2605         * DerivedSources.pro: Renamed from DerivedSources.pro.
2606         * DumpRenderTree/qt/DumpRenderTree.pro:
2607         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2608         * MiniBrowser/DerivedSources.pro:
2609         * MiniBrowser/qt/MiniBrowser.pro:
2610         * QtTestBrowser/QtTestBrowser.pro:
2611         * Scripts/webkitdirs.pm:
2612         * Tools.pro: Added.
2613         * WebKitTestRunner/DerivedSources.pro:
2614         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2615         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2616
2617 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
2618
2619         Reviewed by Dan Bernstein.
2620
2621         Beefed up --threaded mode to catch even more kinds of errors.
2622         https://bugs.webkit.org/show_bug.cgi?id=52971
2623
2624         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
2625         context group to force JSC to mark multiple threads. (This used to be
2626         the default, but it changed in SnowLeopard.)
2627         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
2628         to give threading mistakes more chances to show themselves.
2629         (startJavaScriptThreads):
2630         (stopJavaScriptThreads):
2631
2632 2011-01-22  Robert Hogan  <robert@webkit.org>
2633
2634         Reviewed by Andreas Kling.
2635
2636         [Qt] Support layoutTestController.addURLToRedirect()
2637         https://bugs.webkit.org/show_bug.cgi?id=52956
2638
2639         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2640         (LayoutTestController::addURLToRedirect):
2641         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2642
2643 2011-01-22  Robert Hogan  <robert@webkit.org>
2644
2645         Reviewed by Kenneth Rohde Christiansen.
2646
2647         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
2648         https://bugs.webkit.org/show_bug.cgi?id=49802
2649
2650         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2651         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2652         (WebCore::DumpRenderTree::open):
2653
2654 2011-01-21  Adam Barth  <abarth@webkit.org>
2655
2656         Reviewed by Maciej Stachowiak.
2657
2658         Disable mac_unittest.py that fails on some of the Mac bots
2659         https://bugs.webkit.org/show_bug.cgi?id=52947
2660
2661         As noted in the comment, this test does not appear to be correct
2662         because the function this test is testing returns different results
2663         depending on which flavor of Mac the test is run on.  This patch
2664         disable the test.  Hopefully we can re-enable the test once we've
2665         probably insulated the test from its environment.
2666
2667         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2668
2669 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2670
2671         Reviewed by Mihai Parparita.
2672
2673         Fix bug introduced in r76322 that caused NRWT to not actually
2674         read the Skipped files properly.
2675
2676         https://bugs.webkit.org/show_bug.cgi?id=52771
2677
2678         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2679         * Scripts/webkitpy/layout_tests/port/webkit.py:
2680         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2681
2682 2011-01-21  Sam Weinig  <sam@webkit.org>
2683
2684         Reviewed by Geoffrey Sean Garen and Mark Rowe.
2685
2686         WebKitTestRunner needs the HOME environment variable to be set.
2687         <rdar://problem/8896573>
2688
2689         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
2690         it exists.
2691
2692 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2693
2694         Reviewed by Eric Seidel.
2695
2696         Suppress a few remaining integration tests so that none of the
2697         layout_test unit tests ever read from the filesystem or launch
2698         subprocesses that aren't part of the unit tests.
2699
2700         Also fix a minor bug in the printing unit tests that was
2701         incorrectly relying on sys.argv.
2702
2703         https://bugs.webkit.org/show_bug.cgi?id=52863
2704
2705         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2706         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2707         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2708
2709 2011-01-21  Darin Adler  <darin@apple.com>
2710
2711        Fix Mac build.
2712
2713         * MiniBrowser/mac/BrowserWindowController.m:
2714         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
2715
2716 2011-01-20  Darin Adler  <darin@apple.com>
2717
2718         Reviewed by Dan Bernstein.
2719
2720         WebKit2: Implement showModalDialog
2721         https://bugs.webkit.org/show_bug.cgi?id=52855
2722
2723         This fixes WebKitTestRunner to compile, but more work is probably
2724         needed to get it to pass the tests.
2725
2726         * WebKitTestRunner/TestController.cpp:
2727         (WTR::TestController::runModal): Added. Calls through to the
2728         platform-specific version of runModal.
2729         (WTR::TestController::createOtherPage): Changed to be a private
2730         static member function so it can refer to runModal, which is
2731         a private static member function.
2732         (WTR::TestController::initialize): Pass 0 for the runModal
2733         function since we don't need to run the main window modal.
2734         I suspect this is wrong and will need to change.
2735         * WebKitTestRunner/TestController.h: Added declarations for
2736         the functions added above.
2737         * WebKitTestRunner/mac/TestControllerMac.mm:
2738         (WTR::TestController::runModal): Added. Untested implementation.
2739         * WebKitTestRunner/qt/TestControllerQt.cpp:
2740         (WTR::TestController::runModal): Added.
2741         * WebKitTestRunner/win/TestControllerWin.cpp:
2742         (WTR::TestController::runModal): Added.
2743
2744 2011-01-21  Eric Seidel  <eric@webkit.org>
2745
2746         Reviewed by Adam Barth.
2747
2748         Split Host object off from WebKitPatch for easier re-use
2749         https://bugs.webkit.org/show_bug.cgi?id=52284
2750
2751         new-run-webkit-tests and other tools are eventually going to want one of these.
2752         Basically you need to inherit from this class if you want to pretend to be a
2753         self.tool object for Steps/Commands.
2754
2755         * Scripts/webkitpy/common/host.py: Added.
2756         * Scripts/webkitpy/tool/main.py:
2757
2758 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2759
2760         Reviewed by Adam Barth.
2761
2762         Disable the tests that start and stop the http server and web
2763         server, so that we don't have to worry about port collisions on
2764         the bots.
2765
2766         https://bugs.webkit.org/show_bug.cgi?id=52861
2767
2768         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2769
2770 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2771
2772         Reviewed by Eric Seidel.
2773
2774         nrwt: rewrite google_chrome_unittest to use mock filesystem.
2775         
2776         https://bugs.webkit.org/show_bug.cgi?id=52772
2777         
2778         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2779
2780 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2781
2782         Reviewed by Eric Siedel.
2783
2784         nrwt: clean up almost all remaining port references, remove
2785         unnecessary import clauses. The only remaining references are
2786         in places where a mock filesystem makes no sense or can't be
2787         used, and in one routine in port/google_chrome_unittest that
2788         I'll rewrite in a separate patch.
2789
2790         https://bugs.webkit.org/show_bug.cgi?id=52771
2791
2792         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2793         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2794         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2795         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2796         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2797         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2798         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2799         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2800         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2801         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2802         * Scripts/webkitpy/layout_tests/port/gtk.py:
2803         * Scripts/webkitpy/layout_tests/port/mac.py:
2804         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2805         * Scripts/webkitpy/layout_tests/port/qt.py:
2806         * Scripts/webkitpy/layout_tests/port/webkit.py:
2807         * Scripts/webkitpy/layout_tests/port/win.py:
2808         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2809
2810 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2811
2812         Reviewed by Mihai Parparita.
2813
2814         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
2815
2816         https://bugs.webkit.org/show_bug.cgi?id=52762
2817
2818         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2819         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2820
2821 2011-01-20  Tony Chang  <tony@chromium.org>
2822
2823         Reviewed by Ojan Vafai.
2824
2825         [chromium] fix the paths used for the rebaseline tool
2826         https://bugs.webkit.org/show_bug.cgi?id=52857
2827
2828         Some of the bots were renamed so the path to grab the results zip
2829         file has changed.
2830
2831         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2832
2833 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2834
2835         Reviewed by Tony Chang.
2836
2837         Fix bug introduced in r72688 / bug 52768 that broke the
2838         generation of the output filename links in the results.html
2839         output. Apparently none of the unit tests actually checked to
2840         make sure the generated links were correct :(
2841
2842         https://bugs.webkit.org/show_bug.cgi?id=52854
2843
2844         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2845         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2846
2847 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
2848
2849         Reviewed by Darin Adler.
2850
2851         https://bugs.webkit.org/show_bug.cgi?id=52849
2852         Make window.print work with WebKit2
2853
2854         * MiniBrowser/mac/BrowserWindowController.m:
2855         (-[BrowserWindowController awakeFromNib]):
2856         * WebKitTestRunner/TestController.cpp:
2857         (WTR::createOtherPage):
2858         (WTR::TestController::initialize):
2859         Added zeroes to WKPageUIClient structures to avoid build failures.
2860
2861 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2862
2863         Reviewed by Eric Seidel.
2864
2865         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=52756
2868
2869         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2870         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2871         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2872         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2873         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2874         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2875
2876 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
2877
2878         Reviewed by Antonio Gomes.
2879
2880         QtTestBrowser should have a seperate menu for Settings
2881         https://bugs.webkit.org/show_bug.cgi?id=52817
2882         
2883         Added a new menu item named "Settings"
2884         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
2885
2886         * QtTestBrowser/launcherwindow.cpp:
2887         (LauncherWindow::createChrome):
2888
2889 2011-01-20  Sam Weinig  <sam@webkit.org>
2890
2891         Reviewed by John Sullivan.
2892
2893         Update update-webkit-localizable-strings with new path to WebKit.
2894
2895         * Scripts/update-webkit-localizable-strings:
2896
2897 2011-01-20  James Robinson  <jamesr@chromium.org>
2898
2899         Reviewed by Darin Fisher.
2900
2901         Implement mozilla's requestAnimationFrame API
2902         https://bugs.webkit.org/show_bug.cgi?id=51218
2903
2904         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2905
2906         * DumpRenderTree/chromium/WebViewHost.cpp:
2907         (invokeScheduleComposite):
2908         (WebViewHost::scheduleAnimation):
2909         (WebViewHost::paintInvalidatedRegion):
2910         * DumpRenderTree/chromium/WebViewHost.h:
2911
2912 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
2913
2914         Reviewed by Adam Roben.
2915
2916         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
2917         https://bugs.webkit.org/show_bug.cgi?id=42327
2918
2919         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
2920         for methods that take their normal arguments but also a JSContextRef.
2921         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
2922         for evaluateScriptInIsolatedWorld.
2923         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2924         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
2925         this call is for an isolated world.
2926         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2927         (WTR::worldMap): Helper to create a world map.
2928         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
2929         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
2930         added LayoutTestController API.
2931         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2932
2933 2011-01-19  Adam Roben  <aroben@apple.com>
2934
2935         Convert paths in environment variables back to msys-style inside commit-log-editor
2936
2937         When this script gets run from inside git commit, msys-style paths in the environment will
2938         have been turned into Windows-style paths with forward slashes. This screws up functions
2939         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
2940         the paths back to msys-style before doing anything else.
2941
2942         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
2943         using msysgit's Perl and multiple ChangeLogs have been edited
2944
2945         Reviewed by David Kilzer.
2946
2947         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2948         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2949         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2950
2951 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2952
2953         [Win] Unreviewed build fix after r76248.
2954
2955         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2956
2957 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2958
2959         Reviewed by Csaba Osztrogonác.
2960
2961         Refactoring of the custom allocation framework
2962         https://bugs.webkit.org/show_bug.cgi?id=49897
2963
2964         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2965         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2966         equivalent macro implementation at the necessary places.
2967 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2968
2969         Unreviewed. 
2970
2971         Adding myself to committers.py.
2972
2973         * Scripts/webkitpy/common/config/committers.py:
2974
2975 2011-01-20  Adam Barth  <abarth@webkit.org>
2976
2977         Reviewed by Tony Chang.
2978
2979         Chromium builders don't delete unversioned directories when DEPS change
2980         https://bugs.webkit.org/show_bug.cgi?id=52745
2981
2982         If we pass this option to gclient sync, gclient will delete directories
2983         that are no longer part of DEPS instead of leaving them around to
2984         confuse us later.  Apparently, the downstream buildbots use this option
2985         already.
2986
2987         * Scripts/update-webkit-chromium:
2988
2989 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2990
2991         Unreviewed, build fix - I pulled this patch in to fix an issue
2992         revealed by r76195 running on some new bots). Also fix a couple
2993         of other issues revealed in testing.
2994
2995         nrwt: remove fs refs from layout_package/json*
2996
2997         https://bugs.webkit.org/show_bug.cgi?id=52754
2998
2999         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3000         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3001         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3002         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3003         * Scripts/webkitpy/layout_tests/port/base.py:
3004
3005 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3006
3007         Unreviewed, build fix.
3008
3009         Fix a couple of minor bugs discovered while bringing up new bots
3010         for testing.
3011
3012         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3013         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3014
3015 2011-01-19  James Robinson  <jamesr@chromium.org>
3016
3017         Unreviewed, rolling out r76194.
3018         http://trac.webkit.org/changeset/76194
3019         https://bugs.webkit.org/show_bug.cgi?id=51218
3020
3021         Caused mysterious compile failure on the chromium win
3022         build.webkit.org bots
3023
3024         * DumpRenderTree/chromium/WebViewHost.cpp:
3025         (WebViewHost::paintInvalidatedRegion):
3026         * DumpRenderTree/chromium/WebViewHost.h:
3027
3028 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3029
3030         Reviewed by Mihai Parparita.
3031
3032         remove fs refs from test_runner, dump_render_tree_thread
3033
3034         https://bugs.webkit.org/show_bug.cgi?id=52753
3035
3036         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3037         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3038         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3039         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3040
3041 2011-01-19  James Robinson  <jamesr@chromium.org>
3042
3043         Reviewed by Darin Fisher.
3044
3045         Implement mozilla's requestAnimationFrame API
3046         https://bugs.webkit.org/show_bug.cgi?id=51218
3047
3048         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
3049
3050         * DumpRenderTree/chromium/WebViewHost.cpp:
3051         (invokeScheduleComposite):
3052         (WebViewHost::scheduleAnimation):
3053         (WebViewHost::paintInvalidatedRegion):
3054         * DumpRenderTree/chromium/WebViewHost.h:
3055
3056 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3057
3058         Unreviewed, build fix.
3059
3060         Fix a few incorrect "self._filesystem" references introduced in
3061         r76184.
3062
3063         * Scripts/webkitpy/layout_tests/port/chromium.py:
3064         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3065
3066 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3067
3068         Reviewed by Mihai Parparita.
3069
3070         add a .sep property, abspath(), isabs(), mtime(), and
3071         open_text_file_for_writing() to filesystem modules. Some of
3072         these properties are not needed in this patch but will be needed
3073         in subsequent patches (I'm doing this to avoid having to track
3074         multiple versions of a single file).
3075
3076         Also, change most of the port/* modules to use the filesystem
3077         objects instead of referencing the filesystem directly.
3078
3079         https://bugs.webkit.org/show_bug.cgi?id=52748
3080
3081         * Scripts/webkitpy/common/system/filesystem.py:
3082         * Scripts/webkitpy/common/system/filesystem_mock.py:
3083         * Scripts/webkitpy/layout_tests/port/__init__.py:
3084         * Scripts/webkitpy/layout_tests/port/base.py:
3085         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3086         * Scripts/webkitpy/layout_tests/port/chromium.py:
3087         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3088         * Scripts/webkitpy/layout_tests/port/config.py:
3089         * Scripts/webkitpy/layout_tests/port/test.py:
3090         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3091
3092 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
3093
3094         Reviewed by Anders Carlsson.
3095
3096         If resetting between tests times out, treat it as a WebProcess crash
3097         https://bugs.webkit.org/show_bug.cgi?id=52757
3098
3099         * WebKitTestRunner/TestController.cpp:
3100         (WTR::TestController::runTest):
3101
3102 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
3103
3104         Reviewed by Darin Adler.
3105
3106         https://bugs.webkit.org/show_bug.cgi?id=52739
3107         Make it possible for a WebKit2 client to print headers and footers
3108
3109         Added dummy implementations for new printing UIClient calls.
3110
3111         * MiniBrowser/mac/BrowserWindowController.m:
3112         (-[BrowserWindowController awakeFromNib]):
3113         * WebKitTestRunner/TestController.cpp:
3114         (WTR::createOtherPage):
3115         (WTR::TestController::initialize):
3116
3117 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3118
3119         Reviewed by Ojan Vafai.
3120
3121         Change webkitpy/layout_tests/port/test.py to use the
3122         in-memory filesystem for cleaner unit testing. This
3123         change allows us to kill a lot of code that was
3124         specific to the test port, at the cost of being a
3125         little less clear about how things would work if
3126         you didn't have a filesystem.
3127
3128         https://bugs.webkit.org/show_bug.cgi?id=52605
3129
3130         * Scripts/webkitpy/layout_tests/port/test.py:
3131
3132 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3133
3134         Unreviewed, build fix.
3135
3136         Fix test failure caused by committing attachment 79368 instead
3137         of attachment 79461 on bug 52604.
3138
3139         * Scripts/webkitpy/common/system/filesystem_mock.py:
3140
3141 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3142
3143         Reviewed by Mihai Parparita.
3144
3145         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
3146         unit testing. os.walk() is too much of a hassle to implement on
3147         top of the in-memory mock filesystem and adding the necessary
3148         interface to files_under() gives clients a cleaner API anyway
3149         (for this particular usage model).
3150
3151         https://bugs.webkit.org/show_bug.cgi?id=52691
3152
3153         * Scripts/webkitpy/common/system/filesystem.py:
3154         * Scripts/webkitpy/common/system/filesystem_mock.py:
3155         * Scripts/webkitpy/layout_tests/port/test_files.py:
3156         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3157
3158 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3159
3160         Reviewed by Tony Chang.
3161
3162         Change more modules in the layout-tests code to use the
3163         filesystem wrapper for cleaner unit testing.
3164
3165         This patch also adds the glob() wrapper to the filesystem
3166         abstraction.
3167         
3168         https://bugs.webkit.org/show_bug.cgi?id=52604
3169
3170         * Scripts/webkitpy/layout_tests/port/test_files.py:
3171         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3172         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3173         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3174         * Scripts/webkitpy/common/system/filesystem.py:
3175         * Scripts/webkitpy/common/system/filesystem_mock.py:
3176
3177 2011-01-19  Levi Weintraub  <leviw@chromium.org>
3178
3179         Unreviewed.
3180
3181         Updating my email addresses and irc nick.
3182
3183         * Scripts/webkitpy/common/config/committers.py:
3184
3185 2011-01-19  Tony Chang  <tony@chromium.org>
3186
3187         Reviewed by Mihai Parparita.
3188
3189         [chromium] [linux] if check-sys-deps fails, output the failure reason
3190         https://bugs.webkit.org/show_bug.cgi?id=52671
3191
3192         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
3193             error handler functions.
3194         * Scripts/webkitpy/layout_tests/port/chromium.py:
3195             output the error text from --check-sys-deps
3196         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3197
3198 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
3199
3200         Reviewed by Andreas Kling.
3201
3202         [Qt] QtTestBrowser crashes when closing if Facebook is opened
3203         https://bugs.webkit.org/show_bug.cgi?id=52554
3204         
3205         QtNetworkAccessManager is created in a thread and set as
3206         member variable in QWebPage. When the thread is destroyed
3207         the object is still used. So fix will set the object to
3208         NULL once the thread is destroyed.
3209
3210         * QtTestBrowser/launcherwindow.cpp:
3211         (LauncherWindow::~LauncherWindow):
3212
3213 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
3214
3215         Rubber stamped by Csaba Osztrogonac
3216
3217         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
3218
3219 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3220
3221         Reviewed by Tony Chang.
3222
3223         new-run-webkit-tests: add a --build-directory command line argument
3224
3225         Official Google Chrome builds use a non-standard build directory
3226         location. This patch adds a --build-directory argument that
3227         allows that location to be specified on the command line. Only
3228         Chromium-based builds will use this flag for now, but anyone can
3229         in the future.
3230
3231         There are no unit tests for this since it's difficult to test
3232         until mock filesystems are fully supported in the code. This was
3233         tested by hand for now.
3234
3235         https://bugs.webkit.org/show_bug.cgi?id=52694
3236
3237         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3238         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3239         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3241
3242 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
3243
3244         Not reviewed. Bot fix.
3245
3246         Remove an inadvertently committed debugging print.
3247
3248         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3249         (LayoutTestController::notifyDone):
3250
3251 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
3252
3253         Reviewed by Sam Weinig.
3254
3255         WebKitTestRunner should track loading more like DumpRenderTree
3256         https://bugs.webkit.org/show_bug.cgi?id=52692
3257
3258         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
3259         This makes some tests that call notifyDone multiple times pass.
3260         
3261         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3262         (WTR::InjectedBundle::InjectedBundle):
3263         (WTR::InjectedBundle::done):
3264         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3265         (WTR::InjectedBundle::topLoadingFrame):
3266         (WTR::InjectedBundle::setTopLoadingFrame):
3267         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3268         (WTR::InjectedBundlePage::InjectedBundlePage):
3269         (WTR::InjectedBundlePage::stopLoading):
3270         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3271         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3272         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3273         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3274         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3275         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3276         (WTR::LayoutTestController::notifyDone):
3277         * WebKitTestRunner/TestController.cpp:
3278         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3279
3280 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
3281
3282         Reviewed by Kent Tamura.
3283
3284         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
3285         https://bugs.webkit.org/show_bug.cgi?id=52678
3286         
3287         Update path now that WebKit is inside Source.
3288
3289         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3290
3291 2011-01-18  Robert Hogan  <robert@webkit.org>
3292
3293         Reviewed by Simon Hausmann.
3294
3295         [Qt] http/tests/incremental/slow-utf8-text.pl fails
3296         https://bugs.webkit.org/show_bug.cgi?id=44282
3297
3298         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3299         (WebCore::DumpRenderTree::dump):
3300
3301 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3302
3303         Reviewed by Mihai Parparita.
3304
3305         Fix a small race condition that could cause the unit tests for
3306         new-run-webkit-tests to fail in a multithreaded environment.
3307         There was a small window in the code where one thread would
3308         check to see if a thread had raised an exception, do something,
3309         and then check to see if the thread was alive. If the other
3310         thread raised an exception and exited in between these two
3311         steps, the exception would be lost. Flipping the order of the
3312         two checks fixes the race, since we will now always check for an
3313         exception on the thread before exiting.
3314
3315         https://bugs.webkit.org/show_bug.cgi?id=51579
3316
3317         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3318
3319 2011-01-18  Eric Seidel  <eric@webkit.org>
3320
3321         Reviewed by Adam Barth.
3322
3323         commit-queue dies when test archiving fails
3324         https://bugs.webkit.org/show_bug.cgi?id=52617
3325
3326         I looked at the machine and it had 10 archives already
3327         thus find_unused_name was returning None.  I've upped
3328         the limit to 100 (per bug) and tested the case where
3329         find_unused_name returns None (making archive return None).
3330
3331         * Scripts/webkitpy/common/system/workspace.py:
3332         * Scripts/webkitpy/common/system/workspace_unittest.py:
3333         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3334         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3335         * Scripts/webkitpy/tool/commands/queues.py:
3336
3337 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3338
3339         Reviewed by Ojan Vafai.
3340
3341         Update rebaseline-chromium-webkit-tests unit tests to use a mock
3342         filesystem. Also fix a couple of "with" statements missed by
3343         r76050.
3344
3345         https://bugs.webkit.org/show_bug.cgi?id=52487
3346
3347         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3348
3349 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
3350
3351         Reviewed by Martin Robinson.
3352
3353         [Gtk] Build fixes for gtk3 build
3354         https://bugs.webkit.org/show_bug.cgi?id=52648
3355
3356         * DumpRenderTree/gtk/EventSender.cpp:
3357         (beginDragWithFilesCallback):
3358
3359 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3360
3361         Reviewed by Mihai Parparita.
3362
3363         Update rebaseline-chromium-webkit-tests to use filesystem objects
3364         instead of direct references to os.path, shutil, tempfile, etc.
3365
3366         This patch doesn't change anything, but will allow subsequent
3367         patches to change the unit tests to no longer use the real
3368         filesystem.
3369
3370         This patch adds a bunch more methods to the filesystem object as
3371         well.
3372
3373         https://bugs.webkit.org/show_bug.cgi?id=52482
3374
3375         * Scripts/webkitpy/common/system/filesystem.py:
3376         * Scripts/webkitpy/common/system/filesystem_mock.py:
3377         * Scripts/webkitpy/tool/commands/queues.py:
3378         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3379         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3380
3381 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3382
3383         Reviewed by Mihai Parparita.
3384
3385         new-run-webkit-tests shouldn't crash when you try to run a
3386         directory containing only skipped files.
3387
3388         https://bugs.webkit.org/show_bug.cgi?id=52478
3389         
3390         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3391         * Scripts/webkitpy/layout_tests/port/test.py:
3392         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3393
3394 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
3395
3396         Reviewed by Gustavo Noronha Silva.
3397
3398         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
3399         https://bugs.webkit.org/show_bug.cgi?id=40833
3400
3401         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
3402         GTK+ event sender.
3403         (dragWithFilesDragDataGetCallback): Added.
3404         (dragWithFilesDragEndCallback): Added.
3405         (beginDragWithFilesCallback): Added.
3406
3407 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3408
3409         Reviewed by Adam Barth.
3410
3411         ews: Add additional watcher to efl ews
3412         https://bugs.webkit.org/show_bug.cgi?id=52613
3413
3414         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
3415
3416         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3417
3418 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
3419
3420         Reviewed by Alexey Proskuryakov.
3421
3422         Fix some headers with missing or misspelled #ifndef guards
3423         https://bugs.webkit.org/show_bug.cgi?id=52545
3424
3425         * DumpRenderTree/chromium/TestEventPrinter.h:
3426         * DumpRenderTree/chromium/WebPreferences.h:
3427
3428 2011-01-17  Jessie Berlin  <jberlin@apple.com>
3429
3430         Reviewed by Anders Carlsson.
3431
3432         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
3433         navigating back to an unreachable URL
3434         https://bugs.webkit.org/show_bug.cgi?id=52388
3435
3436         Add a third parameter (unreachableURL) to queueLoadHTMLString.
3437
3438         * DumpRenderTree/LayoutTestController.cpp:
3439         (queueLoadHTMLStringCallback):
3440         (LayoutTestController::queueLoadHTMLString):
3441         (LayoutTestController::queueLoadAlternateHTMLString):
3442         * DumpRenderTree/LayoutTestController.h:
3443
3444         * DumpRenderTree/WorkQueueItem.h:
3445         (LoadHTMLStringItem::LoadHTMLStringItem):
3446
3447         * DumpRenderTree/chromium/LayoutTestController.cpp:
3448         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3449         (WorkItemLoadHTMLString::run):
3450         (LayoutTestController::queueLoadHTMLString):
3451
3452         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3453         (LoadHTMLStringItem::invoke):
3454         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3455         (LoadHTMLStringItem::invoke):
3456         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3457         (LoadHTMLStringItem::invoke):
3458
3459 2011-01-17  Dan Bernstein  <mitz@apple.com>
3460
3461         Rubber-stamped by Mark Rowe.
3462
3463         Update xcodeproj svn:ignore to include xcuserdata.
3464
3465         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3466         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3467         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3468         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3469         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3470
3471 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
3472
3473         Unreviewed fix after r75908.
3474
3475         Move WebKit into Source
3476         https://bugs.webkit.org/show_bug.cgi?id=52530
3477
3478         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
3479
3480 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
3481
3482         Unreviewed.
3483
3484         Remove accidentally committed debug printing after r75908.
3485
3486         * Scripts/webkitdirs.pm:
3487
3488 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3489
3490         Unreviewed.
3491
3492         Add myself to committers list
3493         https://bugs.webkit.org/show_bug.cgi?id=52566
3494
3495         * Scripts/webkitpy/common/config/committers.py:
3496
3497 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3498
3499         Reviewed by Jeremy Orlow.
3500
3501         GeolocationController should call stopUpdating on destruction
3502         https://bugs.webkit.org/show_bug.cgi?id=52216
3503
3504         fast/dom/Geolocation/window-close-crash.html requires that a
3505         Geolocation watch be started in a secondary window. Consequently,
3506         we need to allow geolocation permission and provide a mock
3507         geolocation position for the secondary window's
3508         GeolocationClientMock.
3509
3510         * DumpRenderTree/chromium/LayoutTestController.cpp:
3511         (LayoutTestController::setGeolocationPermission):
3512         (LayoutTestController::setMockGeolocationPosition):
3513         (LayoutTestController::setMockGeolocationError):
3514         * DumpRenderTree/chromium/TestShell.h:
3515         (TestShell::windowList):
3516
3517 2011-01-16  Adam Barth  <abarth@webkit.org>
3518
3519         Update more include paths to reflect WebKit move.
3520
3521         * DumpRenderTree/chromium/EventSender.cpp:
3522         (EventSender::keyDown):
3523         (EventSender::needsShiftModifier):
3524         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3525         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3526
3527 2011-01-16  Kent Tamura  <tkent@chromium.org>
3528
3529         Unreviewed, Chromium build fix.
3530
3531         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
3532
3533 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
3534
3535         Build fix for GTK+ after source directory movement.
3536
3537         * GNUmakefile.am: Correct include paths.
3538
3539 2011-01-16  Adam Barth  <abarth@webkit.org>
3540
3541         Teach svn-apply about WebKit move.
3542
3543         * Scripts/VCSUtils.pm:
3544
3545 2011-01-16  Adam Barth  <abarth@webkit.org>
3546
3547         Rubber-stamped by Eric Seidel.
3548
3549         Move WebKit into Source
3550         https://bugs.webkit.org/show_bug.cgi?id=52530
3551
3552         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3553         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3554         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3555         * DumpRenderTree/qt/GCControllerQt.cpp:
3556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3557         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3558         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3559         * DumpRenderTree/wscript:
3560         * QtTestBrowser/launcherwindow.h:
3561         * Scripts/build-webkit:
3562         * Scripts/webkitdirs.pm:
3563
3564 2011-01-15  Adam Barth  <abarth@webkit.org>
3565
3566         Teach svn-apply about WebKit2 move.
3567
3568         * Scripts/VCSUtils.pm:
3569
3570 2011-01-15  Adam Barth  <abarth@webkit.org>
3571
3572         Rubber-stamped by Eric Seidel.
3573
3574         Move WebKit2 into Source
3575         https://bugs.webkit.org/show_bug.cgi?id=52438
3576
3577         * MiniBrowser/qt/MiniBrowser.pro:
3578         * Scripts/build-webkit:
3579         * Scripts/do-file-rename:
3580         * Scripts/do-webcore-rename:
3581         * Scripts/test-webkitpy:
3582         * Scripts/webkitdirs.pm:
3583         * Scripts/webkitpy/style/checker.py:
3584         * WebKitTestRunner/DerivedSources.pro:
3585         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3586         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3587
3588 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
3589
3590         Reviewed by David Levin.
3591
3592         [chromium] remove obsolete createView method
3593         https://bugs.webkit.org/show_bug.cgi?id=52437
3594
3595         * DumpRenderTree/chromium/WebViewHost.cpp:
3596         (WebViewHost::createView):
3597         * DumpRenderTree/chromium/WebViewHost.h:
3598
3599 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
3600
3601         Reviewed by Geoff Garen.
3602
3603         ShouldLoadResourceForFrame should use strings, not URLs.
3604         https://bugs.webkit.org/show_bug.cgi?id=52476
3605
3606         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3607         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
3608         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3609
3610 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
3611
3612         Reviewed by David Levin.
3613
3614         Add Tony Gentilcore as a reviewer
3615         https://bugs.webkit.org/show_bug.cgi?id=52480
3616
3617         * Scripts/webkitpy/common/config/committers.py:
3618
3619 2011-01-14  David Levin  <levin@chromium.org>
3620
3621         Reviewed by Eric Seidel.
3622
3623         check-webkit-style: _FunctionState should keep track of where the function name starts.
3624         https://bugs.webkit.org/show_bug.cgi?id=52454
3625
3626         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
3627         _FunctionState and logic for setting it correctly.
3628         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
3629
3630 2011-01-14  Vincent Scheib  <scheib@chromium.org>
3631
3632         Reviewed by David Levin.
3633
3634         Add support to DumpRenderTree to use the GPU rather than software renderer
3635         https://bugs.webkit.org/show_bug.cgi?id=52333
3636
3637         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3638         (main):
3639         * Scripts/webkitpy/layout_tests/port/chromium.py:
3640         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3641
3642 2011-01-14  Tony Chang  <tony@chromium.org>
3643
3644         Reviewed by Kent Tamura.
3645
3646         [chromium] update fonts.conf to fix 6 linux tests in drt
3647         https://bugs.webkit.org/show_bug.cgi?id=52411
3648
3649         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
3650             chromium's src/webkit/tools/test_shell/resources/fonts.conf
3651
3652 2011-01-14  Eric Seidel  <eric@webkit.org>
3653
3654         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
3655
3656         Reviewed by Adam Barth.
3657
3658         Fix when running Tools/Scripts/check-webkit-style without arguments.
3659         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
3660
3661         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
3662         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3663
3664 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
3665
3666         Reviewed by David Levin.
3667
3668         Store the tempdir object in a variable so it doesn't get deleted too early.
3669         https://bugs.webkit.org/show_bug.cgi?id=51875
3670
3671         * Scripts/update-webkit-auxiliary-libs:
3672         * Scripts/update-webkit-support-libs:
3673
3674 2011-01-14  Eric Seidel  <eric@webkit.org>
3675
3676         Unreviewed.  Make it work in python 2.5.
3677
3678         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3679         https://bugs.webkit.org/show_bug.cgi?id=49158
3680
3681         * Scripts/webkitpy/common/checkout/api_unittest.py:
3682
3683 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3684
3685         Unreviewed, rolling out r75774.
3686         http://trac.webkit.org/changeset/75774
3687         https://bugs.webkit.org/show_bug.cgi?id=52431
3688
3689         gtk builds were broken (Requested by loislo2 on #webkit).
3690
3691         * Scripts/webkitpy/common/checkout/scm.py:
3692
3693 2011-01-14  David Levin  <levin@chromium.org>
3694
3695         Reviewed by Shinichiro Hamaji.
3696
3697         check-webkit-style: _FunctionState should detect pure functions.
3698         https://bugs.webkit.org/show_bug.cgi?id=52428
3699
3700         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
3701         is a pure virtual function.
3702         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
3703         virtual functions are correctly detected.
3704
3705 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
3706
3707         Reviewed by Yury Semikhatsky.
3708
3709         Just small fix for problem with check-webkit-style.
3710         It just didn't work for this patch.
3711         Old code can't concatenate a list of strings with None.
3712
3713         * Scripts/webkitpy/common/checkout/scm.py:
3714
3715 2011-01-13  David Levin  <levin@chromium.org>
3716
3717         Reviewed by Shinichiro Hamaji.