Provide a sensible default architecture when building on iOS SDKs
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-31  David Farler  <dfarler@apple.com>
2
3         Provide a sensible default architecture when building on iOS SDKs
4         https://bugs.webkit.org/show_bug.cgi?id=108395
5
6         Reviewed by Joseph Pecoraro.
7
8         * Scripts/webkitdirs.pm:
9         (determineArchitecture):
10         Check for iphoneos and iphonesimulator SDKs for a default arch.
11         (determineXcodeSDK): Added.
12         (xcodeSDK): Added.
13         (XcodeOptions): Add ARCHS= if defined.
14
15 2013-01-31  Christopher Cameron  <ccameron@chromium.org>
16
17         Fix rubber-band effect on non-scrollable pages
18         https://bugs.webkit.org/show_bug.cgi?id=107611
19
20         Add mouseWheelBegin function to EventSender to allow
21         event-based rubber-banding tests.
22
23         Reviewed by Antonio Gomes.
24
25         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
26         (WebTestRunner):
27         (WebTestRunner::EventSender::EventSender):
28         (WebTestRunner::EventSender::mouseDragBegin):
29         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
30         (EventSender):
31
32 2013-01-31  James Robinson  <jamesr@chromium.org>
33
34         [chromium] Notify the WebWidget when the WebViewHost is about to tear down compositing support
35         https://bugs.webkit.org/show_bug.cgi?id=108518
36
37         Reviewed by Adrienne Walker.
38
39         * DumpRenderTree/chromium/WebViewHost.cpp:
40         (WebViewHost::shutdown):
41
42 2013-01-31  Pratik Solanki  <psolanki@apple.com>
43
44         DumpRenderTree should put NSSound calls inside USE(APPKIT)
45         https://bugs.webkit.org/show_bug.cgi?id=108499
46
47         Reviewed by Andy Estes.
48
49         * DumpRenderTree/mac/DumpRenderTree.mm:
50         (dumpRenderTree):
51
52 2013-01-30  Brian Weinstein  <bweinstein@apple.com>
53
54         Add a call to the page UI client to determine if a plug-in should load
55         https://bugs.webkit.org/show_bug.cgi?id=108407
56         <rdar://problem/13066332>
57
58         Add entries for the new function in the necessary structs.
59
60         Reviewed by Anders Carlsson.
61
62         * MiniBrowser/mac/WK2BrowserWindowController.m:
63         (-[WK2BrowserWindowController awakeFromNib]):
64         * WebKitTestRunner/TestController.cpp:
65         (WTR::TestController::createOtherPage):
66         (WTR::TestController::createWebViewWithOptions):
67
68 2013-01-31  Florin Malita  <fmalita@chromium.org>
69
70         [Chromium] Unreviewed gardening.
71
72         Win build fix after http://trac.webkit.org/changeset/141471.
73
74         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
75         (MockSpellCheck::spellCheckWord):
76
77 2013-01-31  Enrica Casucci  <enrica@apple.com>
78
79         WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
80         https://bugs.webkit.org/show_bug.cgi?id=108396.
81         <rdar://problem/12920461>
82
83         Reviewed by Alexey Proskuryakov.
84         
85         Adding new WebKit2 test with relevant bundle, to test the new APIs.
86
87         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
88         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Added.
89         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
90         (TestWebKitAPI::setInjectedBundleClient):
91         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Added.
92         (PasteboardNotificationsTest):
93         (TestWebKitAPI::willWriteToPasteboard):
94         (TestWebKitAPI::getPasteboardDataForRange):
95         (TestWebKitAPI::didWriteToPasteboard):
96         (TestWebKitAPI::PasteboardNotificationsTest::PasteboardNotificationsTest):
97         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
98         * TestWebKitAPI/Tests/WebKit2/execCopy.html: Added.
99         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Updated to reflect
100         changes in InjectedBundleEditorClient.
101         (WTR::InjectedBundlePage::InjectedBundlePage):
102
103 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
104
105         [Chromium] Add two-word misspelling to mock spellchecker
106         https://bugs.webkit.org/show_bug.cgi?id=108498
107
108         Reviewed by Tony Chang.
109
110         Some layout tests verify spellcheck behavior when multiple words are
111         marked as a single misspelling. This change adds a two-word misspelling
112         'upper case' to the mock spellchecker used by layout tests.
113
114         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
115         (MockSpellCheck::spellCheckWord): Modified to handle spaces in misspellings.
116         (MockSpellCheck::initializeIfNeeded):  Modified to use a vector instead of a hash table.
117         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
118         (MockSpellCheck): Changed misspellings container from hash table to vector.
119
120 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
121
122         [Qt] Prospective build fix.
123
124         Reviewed by Jocelyn Turcotte.
125
126         Don't create .prl files for intermediate libs as their contents get
127         injected within -Wl,-whole-archive -lFoo -wl,-no-whole-archive.
128
129         * qmake/mkspecs/features/default_post.prf:
130
131 2013-01-31  Alan Cutter  <alancutter@chromium.org>
132
133         EWS graphs have unusual data for patch waiting times
134         https://bugs.webkit.org/show_bug.cgi?id=108427
135
136         Reviewed by Eric Seidel.
137
138         The max_patches_waiting QueueLog property may have missed recording patches waiting in idle times when no events are fired to update it. I added a cron job to take care of this issue.
139         The patch wait duration in PatchLogs was being incorrectly updated after a patch expired and was picked up again from the queue. That period should really count towards the processing time instead.
140         Added a WarningLog to record if any erroneous situations occur due to invalid contents in the datastore. These basically highlight if any "impossible" execution paths get executed.
141
142         * QueueStatusServer/app.yaml:
143         * QueueStatusServer/cron.yaml:
144         * QueueStatusServer/handlers/syncqueuelogs.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
145         (SyncQueueLogs):
146         (SyncQueueLogs.get):
147         * QueueStatusServer/loggers/recordpatchevent.py:
148         (RecordPatchEvent.added):
149         (RecordPatchEvent.retrying):
150         (RecordPatchEvent.started):
151         (RecordPatchEvent.stopped):
152         (RecordPatchEvent.updated):
153         * QueueStatusServer/main.py:
154         * QueueStatusServer/model/patchlog.py:
155         (PatchLog.lookup):
156         (PatchLog):
157         (PatchLog.lookup_if_exists):
158         (PatchLog.calculate_process_duration):
159         (PatchLog._generate_key):
160         * QueueStatusServer/model/queuelog.py:
161         (QueueLog.update_max_patches_waiting):
162         (QueueLog._get_or_create_txn):
163         (QueueLog):
164         (QueueLog._get_patches_waiting):
165         * QueueStatusServer/model/warninglog.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
166         (WarningLog):
167         (WarningLog.record):
168
169 2013-01-31  Anders Carlsson  <andersca@apple.com>
170
171         Remove Web Intents code from WebKit2
172         https://bugs.webkit.org/show_bug.cgi?id=108506
173
174         Reviewed by Simon Fraser.
175
176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
177         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
178         (WTR::InjectedBundlePage::InjectedBundlePage):
179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
180         (InjectedBundlePage):
181         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
183         (TestRunner):
184
185 2013-01-31  Tommy Widenflycht  <tommyw@google.com>
186
187         [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
188         https://bugs.webkit.org/show_bug.cgi?id=108458
189
190         Reviewed by Adam Barth.
191
192         Only renames, no other code changes.
193
194         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
195         (MockWebMediaStreamCenter::didEnableMediaStreamTrack):
196         (MockWebMediaStreamCenter::didDisableMediaStreamTrack):
197         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
198         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
199         (MockWebMediaStreamCenter::didStopLocalMediaStream):
200         (MockWebMediaStreamCenter::didCreateMediaStream):
201         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
202         (MockWebMediaStreamCenter):
203         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
204         (MockWebRTCPeerConnectionHandler::addStream):
205         (MockWebRTCPeerConnectionHandler::removeStream):
206         (MockWebRTCPeerConnectionHandler::getStats):
207         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
208         (MockWebRTCPeerConnectionHandler):
209         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
210         (UserMediaRequestTask::UserMediaRequestTask):
211         (WebUserMediaClientMock::requestUserMedia):
212
213 2013-01-31  Zan Dobersek  <zdobersek@igalia.com>
214
215         REGRESSION (r141402): incorrectly set injected bundle path when running GTK unit tests
216         https://bugs.webkit.org/show_bug.cgi?id=108496
217
218         Reviewed by Philippe Normand.
219
220         * Scripts/run-gtk-tests:
221         (TestRunner.__init__): Add the build type as a member on the TestRunner interface.
222         (TestRunner._setup_testing_environment): Use the build type member to determine correct path
223         to the injected bundle.
224
225 2013-01-31  Christophe Dumez  <dchris@gmail.com>
226
227         [EFL] Disable Web Intents
228         https://bugs.webkit.org/show_bug.cgi?id=108457
229
230         Reviewed by Alexey Proskuryakov.
231
232         Remove EFL DRT code related to Web intents.
233
234         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
235         (DumpRenderTreeChrome::createView):
236         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
237         (DumpRenderTreeChrome::onFrameCreated):
238         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
239         (DumpRenderTreeChrome):
240         * DumpRenderTree/efl/TestRunnerEfl.cpp:
241         (TestRunner::sendWebIntentResponse):
242         (TestRunner::deliverWebIntent):
243         * Scripts/webkitperl/FeatureList.pm: Turn off WEB_INTENTS flag
244         for EFL port.
245
246 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
247
248         [Qt] Disable force_static_libs_as_shared in developer builds if wk2 is enabled
249
250         Reviewed by Jocelyn Turcotte.
251
252         This is a temporary workaround during the development of #108471, where we move files around
253         but some link time dependencies might remain.
254
255         * qmake/mkspecs/features/default_post.prf:
256
257 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
258
259         [Qt] Make it possible to compile WebKit2 Qt related files without access to internal WK2 C++ API
260         https://bugs.webkit.org/show_bug.cgi?id=108472
261
262         Reviewed by Andreas Kling.
263
264         Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
265         that doesn't depend on WebKit2 internals.
266
267         * qmake/mkspecs/features/webkit_modules.prf:
268         * qmake/mkspecs/modules/webkit2qml.prf: Copied from Source/WebKit2/WebKit2.pro.
269
270 2013-01-31  James Robinson  <jamesr@chromium.org>
271
272         [chromium] Remove dead transitional code from WebViewImpl
273         https://bugs.webkit.org/show_bug.cgi?id=107889
274
275         Reviewed by Adam Barth.
276
277         ScrollingCoordinatorChromiumTests need to initialize compositing, so its implementation of
278         WebWidgetClient has to support the new compositor initialization path.
279
280         * DumpRenderTree/chromium/WebViewHost.cpp:
281         (WebViewHost::initializeLayerTreeView):
282         (WebViewHost::setWebWidget):
283
284 2013-01-31  Gustavo Noronha Silva  <gns@gnome.org>
285
286         [GTK] run-gtk-tests does not respect the -d argument
287         https://bugs.webkit.org/show_bug.cgi?id=107822
288
289         Reviewed by Philippe Normand.
290
291         * Scripts/run-gtk-tests:
292         (TestRunner.__init__): use the value for the debug option to decide what
293         build_type to request a path for.
294         * gtk/common.py:
295         (get_build_path): now accepts a build_type argument instead of trying both
296         Release and Debug in order, defaults to release.
297         (build_path): takes and passes a build_type argument, no default value.
298
299 2013-01-31  Christophe Dumez  <dchris@gmail.com>
300
301         Update Christophe Dumez's email address
302         https://bugs.webkit.org/show_bug.cgi?id=108453
303
304         Reviewed by Kenneth Rohde Christiansen.
305
306         Update my email address in committers.py.
307
308         * Scripts/webkitpy/common/config/committers.py:
309
310 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
311
312         [chromium] move runModalBeforeUnloadDialog to TestRunner library
313         https://bugs.webkit.org/show_bug.cgi?id=108442
314
315         Reviewed by Adam Barth.
316
317         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
318         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
319         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
320         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
321         * DumpRenderTree/chromium/WebViewHost.cpp:
322         * DumpRenderTree/chromium/WebViewHost.h:
323
324 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
325
326         [chromium] move postMessage related methods to TestRunner library
327         https://bugs.webkit.org/show_bug.cgi?id=108343
328
329         Reviewed by Adam Barth.
330
331         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
332         (WebKit):
333         (WebTestProxyBase):
334         (WebTestRunner::WebTestProxy::willCheckAndDispatchMessageEvent):
335         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
336         (WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):
337         (WebTestRunner):
338         * DumpRenderTree/chromium/WebViewHost.cpp:
339         (WebViewHost::willCheckAndDispatchMessageEvent):
340
341 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
342
343         [chromium] move remaining resource load related methods to TestRunner library
344         https://bugs.webkit.org/show_bug.cgi?id=108334
345
346         Reviewed by Adam Barth.
347
348         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
349         (WebTestRunner::WebTestDelegate::allowExternalPages):
350         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
351         (WebKit):
352         (WebTestProxyBase):
353         (WebTestRunner::WebTestProxy::canHandleRequest):
354         (WebTestRunner::WebTestProxy::cannotHandleRequestError):
355         (WebTestRunner::WebTestProxy::didCreateDataSource):
356         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
357         (WebTestRunner::WebTestProxyBase::canHandleRequest):
358         (WebTestRunner):
359         (WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
360         (WebTestRunner::WebTestProxyBase::didCreateDataSource):
361         (WebTestRunner::WebTestProxyBase::willSendRequest):
362         * DumpRenderTree/chromium/WebViewHost.cpp:
363         (WebViewHost::canHandleRequest):
364         (WebViewHost::didCreateDataSource):
365         (WebViewHost::willSendRequest):
366         (WebViewHost::allowExternalPages):
367         * DumpRenderTree/chromium/WebViewHost.h:
368
369 2013-01-30  Hajime Morrita  <morrita@google.com>
370
371         Unreviewed test failure fix for r141341.
372
373         * Scripts/webkitpy/tool/steps/runtests.py:
374         (RunTests.run):
375         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
376
377 2013-01-30  Levi Weintraub  <leviw@chromium.org>
378
379         [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
380         https://bugs.webkit.org/show_bug.cgi?id=108381
381
382         Reviewed by James Robinson.
383
384         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
385         tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
386
387 2013-01-30  Julie Parent  <jparent@chromium.org>
388
389         Add a concept of dashboard parameters that invalidate others
390         https://bugs.webkit.org/show_bug.cgi?id=108362
391
392         Reviewed by Dirk Pranke.
393
394         There are certain parameters to the dashboards, that when selected,
395         invalidate others, such as selecting the test type invalidates the
396         builder group. Add this concept to dashboard_base and allow specifc
397         dashboard to add their own invalidating parameters.
398         
399         The result is that when the user takes a specific action, like changing
400         the test type, the builder would get reset to the default for the new
401         test type, rather than erroring or not matching the query param, as is
402         the current behavior.
403         
404         Also deletes some unused code (selectBuilder).
405         
406         * TestResultServer/static-dashboards/dashboard_base.js:
407         (invalidateQueryParameters):
408         (setQueryParameter):
409         * TestResultServer/static-dashboards/flakiness_dashboard.js:
410         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
411         * TestResultServer/static-dashboards/timeline_explorer.html:
412         * TestResultServer/static-dashboards/treemap.html:
413
414 2013-01-30  Kiran Muppala  <cmuppala@apple.com>
415
416         Disable process suppression of DumpRenderTree on Mac
417         https://bugs.webkit.org/show_bug.cgi?id=108400
418
419         Reviewed by Jessie Berlin.
420
421         * DumpRenderTree/mac/DumpRenderTree.mm:
422         (prepareConsistentTestingEnvironment): Take assertion to prevent
423         process suppression.
424
425 2013-01-30  Roger Fong  <roger_fong@apple.com>
426
427         Enable tests for Windows EWS!
428         https://bugs.webkit.org/show_bug.cgi?id=107968.
429         Patch by Lucas Forschler.
430
431         Reviewed by Adam Barth.
432
433         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
434         (WinEWS):
435
436 2013-01-30  Christophe Dumez  <christophe.dumez@intel.com>
437
438         Add a StringTypeAdapter for ASCIILiteral
439         https://bugs.webkit.org/show_bug.cgi?id=108338
440
441         Reviewed by Benjamin Poulain.
442
443         Add API tests for operator+() taking an ASCIILiteral.
444
445         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
446         (TestWebKitAPI::TEST):
447
448 2013-01-30  Roger Fong  <roger_fong@apple.com>
449
450         Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.
451
452         Rubberstamped by Timothy Horton.
453
454         * Scripts/webkitpy/tool/steps/runtests.py:
455         (RunTests.run):
456
457 2013-01-30  Sheriff Bot  <webkit.review.bot@gmail.com>
458
459         Unreviewed, rolling out r141205.
460         http://trac.webkit.org/changeset/141205
461         https://bugs.webkit.org/show_bug.cgi?id=108353
462
463         Command for running tests on windows needs to be investigated.
464         (Requested by lforschler on #webkit).
465
466         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
467         (WinEWS):
468
469 2013-01-30  Tony Chang  <tony@chromium.org>
470
471         [Chromium] Enable textarea resize corner for tests
472         https://bugs.webkit.org/show_bug.cgi?id=108385
473
474         Reviewed by Ojan Vafai.
475
476         We should test what we ship. Also, this makes us pass more tests in content_shell.
477
478         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
479         (WebTestRunner::WebPreferences::reset): Turn on resize corner.
480
481 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
482
483         [chromium] move custom policy delegate to TestRunner library
484         https://bugs.webkit.org/show_bug.cgi?id=108328
485
486         Reviewed by Adam Barth.
487
488         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
489         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
490         (WebTestProxyBase):
491         (WebTestRunner::WebTestProxy::decidePolicyForNavigation):
492         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
493         (WebTestRunner::WebTestRunner::policyDelegateEnabled):
494         (WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
495         (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
496         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
497         (WebTestRunner::TestRunner::reset):
498         (WebTestRunner::TestRunner::policyDelegateEnabled):
499         (WebTestRunner):
500         (WebTestRunner::TestRunner::policyDelegateIsPermissive):
501         (WebTestRunner::TestRunner::policyDelegateShouldNotifyDone):
502         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
503         (WebTestRunner::TestRunner::waitForPolicyDelegate):
504         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
505         (TestRunner):
506         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
507         (WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
508         (WebTestRunner):
509         * DumpRenderTree/chromium/WebViewHost.cpp:
510         (WebViewHost::decidePolicyForNavigation):
511         (WebViewHost::reset):
512         * DumpRenderTree/chromium/WebViewHost.h:
513         (WebViewHost):
514
515 2013-01-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
516
517         [Qt][WK1] Support better testing of Web Notifications
518         https://bugs.webkit.org/show_bug.cgi?id=107696
519
520         Reviewed by Jocelyn Turcotte.
521
522         Do not dump notification output to the console by default, instead allow the 
523         tests that need this feature to enable it.
524
525         Implement denyWebNotificationPermission and removeAllWebNotificationPermissions.
526         Remove unused m_desktopNotificationAllowedOrigins variable.
527
528         * DumpRenderTree/qt/TestRunnerQt.cpp:
529         (TestRunner::TestRunner):
530         (TestRunner::reset):
531         (TestRunner::dumpNotifications):
532         (TestRunner::grantWebNotificationPermission):
533         (TestRunner::denyWebNotificationPermission):
534         (TestRunner::removeAllWebNotificationPermissions):
535         * DumpRenderTree/qt/TestRunnerQt.h:
536         (TestRunner):
537
538 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
539
540         [chromium] move methods from WebTestDelegate to WebTestRunner
541         https://bugs.webkit.org/show_bug.cgi?id=108309
542
543         Reviewed by Adam Barth.
544
545         By moving more logic to the TestRunner library, we can share more
546         code with content shell.
547
548         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
549         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
550         (WebTestProxyBase):
551         (WebTestRunner::WebTestProxy::createView):
552         (WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled):
553         (WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled):
554         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
555         (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
556         (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
557         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
558         (WebTestRunner::TestRunner::reset):
559         (WebTestRunner::TestRunner::isSmartInsertDeleteEnabled):
560         (WebTestRunner):
561         (WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled):
562         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
563         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
564         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
565         (TestRunner):
566         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
567         (WebTestRunner::WebTestProxyBase::createView):
568         (WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
569         (WebTestRunner):
570         (WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
571         * DumpRenderTree/chromium/TestShell.h:
572         (TestShell):
573         * DumpRenderTree/chromium/WebViewHost.cpp:
574         (WebViewHost::createView):
575         (WebViewHost::didStartLoading):
576         (WebViewHost::didStopLoading):
577         (WebViewHost::isSmartInsertDeleteEnabled):
578         (WebViewHost::isSelectTrailingWhitespaceEnabled):
579         (WebViewHost::reset):
580         * DumpRenderTree/chromium/WebViewHost.h:
581         (WebViewHost):
582
583 2013-01-30  Kwang Yul Seo  <skyul@company100.net>
584
585         Unreviewed. Add Jae Hyun Park to contributor list.
586
587         * Scripts/webkitpy/common/config/committers.py:
588
589 2013-01-29  Alan Cutter  <alancutter@chromium.org>
590
591         Need a cr-linux debug EWS bot
592         https://bugs.webkit.org/show_bug.cgi?id=98957
593
594         Reviewed by Eric Seidel.
595
596         Added cr-linux-debug-ews bot to webkit-patch, QueueStatusServer and GCE build scripts.
597
598         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Added.
599         * QueueStatusServer/app.yaml:
600         * QueueStatusServer/config/queues.py: Added.
601         * QueueStatusServer/model/queues.py:
602         (Queue.__init__):
603         (Queue.queue_with_name):
604         (Queue.all):
605         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
606         (ChromiumLinuxDebugEWS):
607
608 2013-01-29  Alan Cutter  <alancutter@chromium.org>
609
610         Tidy up Sheriffbot's Sheriffs command's unit tests
611         https://bugs.webkit.org/show_bug.cgi?id=108262
612
613         Reviewed by Eric Seidel.
614
615         Added the use of MockWeb instead of the filesystem to test the sheriffs command.
616
617         * Scripts/webkitpy/tool/bot/irc_command.py:
618         (Sheriffs._retrieve_webkit_sheriffs):
619         (Sheriffs.execute):
620         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
621         (IRCCommandTest.test_sheriffs):
622         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Removed.
623         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Removed.
624         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Removed.
625         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Removed.
626         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Removed.
627
628 2013-01-29  Lucas Forschler  <lforschler@apple.com>
629
630         Enable tests for Windows EWS!
631         https://bugs.webkit.org/show_bug.cgi?id=107968
632         
633         Reviewed by Adam Barth.
634
635         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
636         (WinEWS):
637
638 2013-01-29  Alan Cutter  <alancutter@chromium.org>
639
640         MockWeb should be able to serve mock web content
641         https://bugs.webkit.org/show_bug.cgi?id=108240
642
643         Reviewed by Dirk Pranke.
644
645         Added the ability to have MockWeb serve mock web data.
646
647         * Scripts/webkitpy/common/host_mock.py:
648         (MockHost.__init__):
649         * Scripts/webkitpy/common/net/web_mock.py:
650         (MockWeb.__init__):
651         (MockWeb.get_binary):
652
653 2013-01-29  Jessie Berlin  <jberlin@apple.com>
654
655         run-api-tests should have an option to specify root
656         https://bugs.webkit.org/show_bug.cgi?id=108210
657
658         Reviewed by Ryosuke Niwa.
659
660         * Scripts/run-api-tests:
661         Add the option and use it to set the configuration product directory. Since it is supposed
662         to point to the built products, do not build the products if root is specified (this mimics
663         the behavior of run-javascriptcore-tests).
664
665 2013-01-29  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
666
667         [EFL] Add Toggle fullscreen (F11) to MiniBrowser
668         https://bugs.webkit.org/show_bug.cgi?id=108122
669
670         Reviewed by Antonio Gomes.
671
672         Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
673
674         * MiniBrowser/efl/main.c:
675         (on_key_down): Add 'F11' key handler.
676
677 2013-01-29  Patrick Gansterer  <paroga@webkit.org>
678
679         [CMake] Use offical Windows CE support
680         https://bugs.webkit.org/show_bug.cgi?id=108061
681
682         Reviewed by Laszlo Gombos.
683
684         Recent version of CMake has added Windows CE support, but uses a
685         slightly different interface than the patched version used before.
686         Change the command line parameters to use the offical CMake binaries.
687
688         * Scripts/webkitdirs.pm:
689         (cmakeBasedPortArguments):
690
691 2013-01-29  Alan Cutter  <alancutter@chromium.org>
692
693         QueueStatusServer needs pages to display historical queue data
694         https://bugs.webkit.org/show_bug.cgi?id=107659
695
696         Reviewed by Eric Seidel.
697
698         Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
699
700         * QueueStatusServer/app.yaml:
701         * QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
702         (get_time_unit):
703         * QueueStatusServer/filters/webkit_extras.py:
704         (webkit_linkify):
705         (webkit_bug_id):
706         (webkit_attachment_id):
707         (results_link):
708         (queue_status_link):
709         (queue_charts_link):
710         * QueueStatusServer/handlers/queuecharts.py: Added.
711         (QueueCharts):
712         (QueueCharts.get):
713         (QueueCharts._get_min_med_max):
714         (QueueCharts._get_patch_data):
715         (QueueCharts._get_patch_logs):
716         (QueueCharts._get_queue_data):
717         (QueueCharts._get_queue_logs):
718         (QueueCharts._get_time_unit):
719         (QueueCharts._get_timestamp):
720         (QueueCharts._get_view_range):
721         * QueueStatusServer/handlers/queuestatus.py:
722         (QueueStatus.get):
723         * QueueStatusServer/index.yaml:
724         * QueueStatusServer/main.py:
725         * QueueStatusServer/model/queuelog.py:
726         (QueueLog):
727         (QueueLog.create_key):
728         (QueueLog.get_at):
729         (QueueLog.get_current):
730         (QueueLog.get_or_create):
731         (QueueLog._get_or_create_txn):
732         * QueueStatusServer/stylesheets/charts.css: Added.
733         (.chart):
734         (.choices):
735         * QueueStatusServer/templates/queuecharts.html: Added.
736         * QueueStatusServer/templates/queuestatus.html:
737
738 2013-01-29  Mario Sanchez Prada  <mario.prada@samsung.com>
739
740         [GTK] Missing build flags when building with Harfbuzz
741         https://bugs.webkit.org/show_bug.cgi?id=108174
742
743         Reviewed by Martin Robinson.
744
745         Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
746         parameter will be added to linking lines when needed.
747
748         * GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
749         * MiniBrowser/gtk/GNUmakefile.am: Ditto.
750         * TestWebKitAPI/GNUmakefile.am: Ditto.
751
752 2013-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
753
754         [GTK] Implement resources API using injected bundle
755         https://bugs.webkit.org/show_bug.cgi?id=107457
756
757         Reviewed by Sam Weinig.
758
759         * Scripts/run-gtk-tests:
760         (TestRunner): Unksip resources unit tests.
761
762 2013-01-29  Michael Brüning  <michael.bruning@digia.com>
763
764         Unreviewed, updated my email information.
765
766         * Scripts/webkitpy/common/config/committers.py:
767
768 2013-01-29  Jochen Eisinger  <jochen@chromium.org>
769
770         [chromium] delete DRTTestRunner
771         https://bugs.webkit.org/show_bug.cgi?id=108082
772
773         Reviewed by Adam Barth.
774
775         * DumpRenderTree/DumpRenderTree.gypi:
776         * DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
777         * DumpRenderTree/chromium/DRTTestRunner.h: Removed.
778         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
779         (WebTestRunner::WebTestDelegate::testFinished):
780         (WebTestRunner::WebTestDelegate::testTimedOut):
781         (WebTestRunner::WebTestDelegate::isBeingDebugged):
782         (WebTestRunner::WebTestDelegate::layoutTestTimeout):
783         (WebTestRunner::WebTestDelegate::closeRemainingWindows):
784         (WebTestRunner::WebTestDelegate::navigationEntryCount):
785         (WebTestRunner::WebTestDelegate::windowCount):
786         (WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
787         (WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
788         (WebTestRunner::WebTestDelegate::goToOffset):
789         (WebTestRunner::WebTestDelegate::reload):
790         (WebTestRunner::WebTestDelegate::loadURLForFrame):
791         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
792         (WebTestRunner::WebTestRunner::policyDelegateDone):
793         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
794         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
795         (WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
796         (WebTestRunner):
797         (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
798         (WebTestRunner::TestRunner::WorkQueue::processWork):
799         (WebTestRunner::TestRunner::WorkQueue::reset):
800         (WebTestRunner::TestRunner::WorkQueue::addWork):
801         (WebTestRunner::TestRunner::TestRunner):
802         (WebTestRunner::TestRunner::reset):
803         (WebTestRunner::TestRunner::policyDelegateDone):
804         (WebTestRunner::TestRunner::shouldInterceptPostMessage):
805         (WebTestRunner::TestRunner::waitUntilDone):
806         (WebTestRunner::TestRunner::notifyDone):
807         (WebTestRunner::TestRunner::completeNotifyDone):
808         (WorkItemBackForward):
809         (WebTestRunner::WorkItemBackForward::WorkItemBackForward):
810         (WebTestRunner::WorkItemBackForward::run):
811         (WebTestRunner::TestRunner::queueBackNavigation):
812         (WebTestRunner::TestRunner::queueForwardNavigation):
813         (WorkItemReload):
814         (WebTestRunner::WorkItemReload::run):
815         (WebTestRunner::TestRunner::queueReload):
816         (WorkItemLoadingScript):
817         (WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
818         (WebTestRunner::WorkItemLoadingScript::run):
819         (WorkItemNonLoadingScript):
820         (WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
821         (WebTestRunner::WorkItemNonLoadingScript::run):
822         (WebTestRunner::TestRunner::queueLoadingScript):
823         (WebTestRunner::TestRunner::queueNonLoadingScript):
824         (WorkItemLoad):
825         (WebTestRunner::WorkItemLoad::WorkItemLoad):
826         (WebTestRunner::WorkItemLoad::run):
827         (WebTestRunner::TestRunner::queueLoad):
828         (WorkItemLoadHTMLString):
829         (WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
830         (WebTestRunner::WorkItemLoadHTMLString::run):
831         (WebTestRunner::TestRunner::queueLoadHTMLString):
832         (WebTestRunner::TestRunner::locationChangeDone):
833         (WebTestRunner::TestRunner::windowCount):
834         (WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
835         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
836         (WebTestRunner::TestRunner::waitForPolicyDelegate):
837         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
838         (TestRunner):
839         (WorkItem):
840         (WebTestRunner::TestRunner::WorkItem::~WorkItem):
841         (WorkQueue):
842         (WebTestRunner::TestRunner::WorkQueue::WorkQueue):
843         (WebTestRunner::TestRunner::WorkQueue::setFrozen):
844         (WebTestRunner::TestRunner::WorkQueue::isEmpty):
845         (WebTestRunner::TestRunner::WorkQueue::taskList):
846         * DumpRenderTree/chromium/TestShell.cpp:
847         (TestShell::initialize):
848         (TestShell::runFileTest):
849         (TestShell::loadURL):
850         (TestShell::createNewWindow):
851         * DumpRenderTree/chromium/TestShell.h:
852         (TestShell::testRunner):
853         (TestShell):
854         * DumpRenderTree/chromium/WebViewHost.cpp:
855         (WebViewHost::testFinished):
856         (WebViewHost::testTimedOut):
857         (WebViewHost::isBeingDebugged):
858         (WebViewHost::layoutTestTimeout):
859         (WebViewHost::closeRemainingWindows):
860         (WebViewHost::navigationEntryCount):
861         (WebViewHost::windowCount):
862         (WebViewHost::setCustomPolicyDelegate):
863         (WebViewHost::waitForPolicyDelegate):
864         (WebViewHost::goToOffset):
865         (WebViewHost::reload):
866         (WebViewHost::loadURLForFrame):
867         (WebViewHost::shutdown):
868         (WebViewHost::testRunner):
869         * DumpRenderTree/chromium/WebViewHost.h:
870         (WebTestRunner):
871         (WebViewHost):
872
873 2013-01-28  Timothy Loh  <timloh@chromium.com>
874
875         Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
876         https://bugs.webkit.org/show_bug.cgi?id=107903
877
878         Reviewed by Eric Seidel.
879
880         To make ChangeLog and PrepareChangeLog easier to test, we can use
881         FileSystem objects instead of just passing around paths.
882
883         * Scripts/webkitpy/common/checkout/changelog.py:
884         (ChangeLog.__init__):
885         (ChangeLog.parse_latest_entry_from_file):
886         (ChangeLog.parse_entries_from_file):
887         (ChangeLog.latest_entry):
888         (ChangeLog.update_with_unreviewed_message):
889         (ChangeLog.set_reviewer):
890         (ChangeLog.set_short_description_and_bug_url):
891         (ChangeLog.delete_entries):
892         (ChangeLog.prepend_text):
893         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
894         (ChangeLogTest):
895         (test_parse_log_entries_from_changelog):
896         (test_latest_entry_parse_single_entry):
897         (test_set_reviewer):
898         (test_set_short_description_and_bug_url):
899         (test_delete_entries):
900         (test_prepend_text):
901         * Scripts/webkitpy/common/system/filesystem_mock.py:
902         (ReadableTextFileObject.__init__):
903         * Scripts/webkitpy/tool/steps/preparechangelog.py:
904         (PrepareChangeLog._ensure_bug_url):
905         (PrepareChangeLog._resolve_existing_entry):
906         (PrepareChangeLog.run):
907         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
908         (test_ensure_bug_url):
909         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
910         (_assert_message_for_revert_output):
911
912 2013-01-28  Raymond Toy  <rtoy@google.com>
913
914         Add myself to committers.py
915         https://bugs.webkit.org/show_bug.cgi?id=107992
916
917         Reviewed by kbr@google.com.
918
919         * Scripts/webkitpy/common/config/committers.py:
920
921 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
922
923         [Mac] Update PageVisibilityState when WebView is hidden / visible
924         https://bugs.webkit.org/show_bug.cgi?id=107509
925
926         Reviewed by Sam Weinig.
927
928         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
929         automatically changes between hidden and visible as the view is added
930         and removed from window, or when it is in a window that changes
931         visibility, for instance by minimizing / deminimizing.
932
933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
934         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
935         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
936         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
937         (runJavaScriptAlert):
938         (PageVisibilityStateWithWindowChanges):
939         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
940         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
941         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
942         (TestWebKitAPI::TEST_F):
943         Test visibility state of a page in a WebView/WKView with different window states.
944
945         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
946         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
947         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
948         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
949         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
950         Add a WK1 and WK2 teardownView to balance initializeView.
951
952 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
953
954         Improve PageVisibility API with enums
955         https://bugs.webkit.org/show_bug.cgi?id=107364
956
957         Reviewed by Sam Weinig.
958
959         * DumpRenderTree/mac/TestRunnerMac.mm:
960         (TestRunner::resetPageVisibility):
961         (TestRunner::setPageVisibility):
962         Update the WK1 test code to use the new WK1 enums.
963
964         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
965         (WTR::InjectedBundle::setVisibilityState):
966         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
967         (InjectedBundle):
968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
969         (WTR::TestRunner::setPageVisibility):
970         (WTR::TestRunner::resetPageVisibility):
971         * WebKitTestRunner/TestController.cpp:
972         (WTR::TestController::setVisibilityState):
973         * WebKitTestRunner/TestController.h:
974         (TestController):
975         * WebKitTestRunner/TestInvocation.cpp:
976         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
977         Update the WK2 test code to use the new WK2 API and enums.
978
979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
980         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
981         (TestWebKitAPI):
982         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
983         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
984         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
985         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
986         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
987         (TestWebKitAPI::didRunStep4InStatePreview):
988         (TestWebKitAPI::TEST):
989         Test the new WK2 API with all enum types.
990
991 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
992
993         [chromium] remove temporary define used for updating TestRunner API
994
995         Unreviewed. Clean-up change.
996
997         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
998
999 2013-01-28  James Craig  <james@cookiecrook.com>
1000
1001         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
1002         https://bugs.webkit.org/show_bug.cgi?id=107650
1003
1004         Reviewed by Chris Fleizach.
1005
1006         Updating accessibility strings and accessors for DL/DT/DD.
1007
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
1009         (createDescriptionList):
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1011         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1012
1013 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1014
1015         [GTK][WTR] Update layoutTestController.pathToLocalResource
1016         https://bugs.webkit.org/show_bug.cgi?id=107538
1017
1018         Reviewed by Martin Robinson.
1019
1020         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1021         (WTR::TestRunner::pathToLocalResource): Update implementation based on
1022         DRT code.
1023
1024 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1025
1026         [GTK][WTR] Move getTopLevelPath() to utilities file
1027         https://bugs.webkit.org/show_bug.cgi?id=107541
1028
1029         Reviewed by Martin Robinson.
1030
1031         * WebKitTestRunner/GNUmakefile.am: Add new files.
1032         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1033         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
1034         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
1035         (WTR):
1036         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
1037         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
1038         (WTR): Add new method header and documentation.
1039
1040 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1041
1042         [EFL] Include Ecore_Getopt.h in MiniBrowser.
1043         https://bugs.webkit.org/show_bug.cgi?id=108067
1044
1045         Reviewed by Kenneth Rohde Christiansen.
1046
1047         Be explicit and include Ecore_Getopt.h since we use it for parsing
1048         command line options. It is safer than relying on other headers
1049         including it for us.
1050
1051         * MiniBrowser/efl/main.c:
1052
1053 2013-01-28  Renata Hodovan  <reni@webkit.org>
1054
1055         [WK2] Putting QtWebProcess into a chrooted sandbox
1056         https://bugs.webkit.org/show_bug.cgi?id=90005
1057
1058         Reviewed by Anders Carlsson and  Zoltan Herczeg.
1059
1060         Add feature flag for suid sandbox in linux.
1061
1062         * Scripts/webkitperl/FeatureList.pm:
1063
1064 2013-01-27  David Farler  <dfarler@apple.com>
1065
1066         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
1067         https://bugs.webkit.org/show_bug.cgi?id=108028
1068
1069         Reviewed by Dan Bernstein.
1070
1071         * DumpRenderTree/Makefile: Reverted.
1072         * Makefile: Reverted.
1073         * Scripts/webkitdirs.pm: Reverted.
1074
1075 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1076
1077         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
1078         https://bugs.webkit.org/show_bug.cgi?id=106740
1079
1080         Reviewed by Benjamin Poulain.
1081
1082         * DumpRenderTree/config.h:
1083         * WinLauncher/stdafx.h:
1084
1085 2013-01-26  David Farler  <dfarler@apple.com>
1086
1087         Makefiles should work for arbitrary SDKs and architectures on Apple ports
1088         https://bugs.webkit.org/show_bug.cgi?id=107863
1089
1090         Reviewed by David Kilzer.
1091
1092         * Makefile:
1093         Added temporary filters for projects not yet building on iOS.
1094         * DumpRenderTree/Makefile:
1095         Building with iOS SDKs -> -target All-iOS
1096         * Scripts/webkitdirs.pm:
1097         (determineConfiguration):
1098         Added --configuration switch detection.
1099         (determineArchitecture):
1100         Added --architecture and ARCH=(.*) switch detection.
1101         (argumentsForConfiguration):
1102         (determineXcodeSDK):
1103         Look for --device, --simulator, and --sdk switches.
1104         (xcodeSDK):
1105         Added.
1106         (XcodeOptions):
1107         Determine Xcode SDK and generate -arch switches.
1108
1109 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
1110
1111         [chromium] move tracking of the top loading frame to TestRunner library
1112         https://bugs.webkit.org/show_bug.cgi?id=107948
1113
1114         Reviewed by Adam Barth.
1115
1116         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1117         (DRTTestRunner::WorkQueue::processWorkSoon):
1118         (DRTTestRunner::WorkQueue::processWork):
1119         (DRTTestRunner::completeNotifyDone):
1120         * DumpRenderTree/chromium/DRTTestRunner.h:
1121         (DRTTestRunner):
1122         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1123         (WebTestProxyBase):
1124         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1125         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
1126         (WebTestRunner::WebTestRunner::topLoadingFrame):
1127         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1128         (WebTestRunner::TestRunner::TestRunner):
1129         (WebTestRunner::TestRunner::reset):
1130         (WebTestRunner::TestRunner::setTopLoadingFrame):
1131         (WebTestRunner):
1132         (WebTestRunner::TestRunner::topLoadingFrame):
1133         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1134         (TestRunner):
1135         (WebTestRunner::TestRunner::locationChangeDone):
1136         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1137         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1138         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1139         (WebTestRunner::WebTestProxyBase::didFailLoad):
1140         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1141         (WebTestRunner::WebTestProxyBase::locationChangeDone):
1142         (WebTestRunner):
1143         * DumpRenderTree/chromium/WebViewHost.cpp:
1144         (WebViewHost::reset):
1145         (WebViewHost::updateURL):
1146         * DumpRenderTree/chromium/WebViewHost.h:
1147         (WebViewHost):
1148
1149 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1150
1151         Unreviewed, rolling out r140774.
1152         http://trac.webkit.org/changeset/140774
1153         https://bugs.webkit.org/show_bug.cgi?id=107932
1154
1155          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
1156         and fastScrollingForFixedPosition are failing (Requested by
1157         keishi on #webkit).
1158
1159         * DumpRenderTree/chromium/WebViewHost.cpp:
1160         (WebViewHost::initializeLayerTreeView):
1161         (WebViewHost::setWebWidget):
1162
1163 2013-01-25  Alan Cutter  <alancutter@chromium.org>
1164
1165         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
1166         https://bugs.webkit.org/show_bug.cgi?id=107905
1167
1168         Reviewed by Eric Seidel.
1169
1170         Added line to EWS loop to clear /tmp of known Chromium test leak.
1171         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
1172
1173         * EWSTools/start-queue.sh:
1174
1175 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1176
1177         Update Anne's email address
1178         https://bugs.webkit.org/show_bug.cgi?id=107866
1179
1180         Reviewed by Adam Barth.
1181
1182         * Scripts/webkitpy/common/config/committers.py:
1183
1184 2013-01-24  Alan Cutter  <alancutter@chromium.org>
1185
1186         HTTP 500 error between QueueStatusServer and bot(s)
1187         https://bugs.webkit.org/show_bug.cgi?id=107184
1188
1189         Reviewed by Adam Barth.
1190
1191         Removed the use of memcache which was the source of the exception.
1192
1193         * QueueStatusServer/handlers/updatestatus.py:
1194         (UpdateStatus.post):
1195         * QueueStatusServer/model/attachment.py:
1196         (Attachment):
1197         (Attachment.summary):
1198
1199 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1200
1201         Unreviewed, rolling out r140653.
1202         http://trac.webkit.org/changeset/140653
1203         https://bugs.webkit.org/show_bug.cgi?id=107916
1204
1205         Causes a temp file leak on the bots (Requested by abarth on
1206         #webkit).
1207
1208         * DumpRenderTree/chromium/TestShell.cpp:
1209         (TestShell::resetTestController):
1210
1211 2013-01-24  Eric Seidel  <eric@webkit.org>
1212
1213         Skip haslanded_unittest.py on systems which do not have interdiff installed
1214         https://bugs.webkit.org/show_bug.cgi?id=106402
1215
1216         Unreviewed.
1217
1218         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1219         (HasLandedTest):
1220
1221 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1222
1223         Disable the failing webkitpy test for now.
1224
1225         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1226
1227 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
1228
1229         Fixing the diff_parser to correctly identify git diffs even with leading comments.
1230         https://bugs.webkit.org/show_bug.cgi?id=107871
1231
1232         Reviewed by Eric Seidel.
1233
1234         * Scripts/webkitpy/common/checkout/diff_parser.py:
1235         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1236         * Scripts/webkitpy/tool/steps/haslanded.py:
1237
1238 2013-01-24  James Robinson  <jamesr@chromium.org>
1239
1240         [chromium] Remove dead transitional code from WebViewImpl
1241         https://bugs.webkit.org/show_bug.cgi?id=107889
1242
1243         Reviewed by Adrienne Walker.
1244
1245         * DumpRenderTree/chromium/WebViewHost.cpp:
1246         (WebViewHost::initializeLayerTreeView):
1247         (WebViewHost::setWebWidget):
1248
1249 2013-01-24  Joshua Bell  <jsbell@chromium.org>
1250
1251         Add watchlist for IndexedDB development, and add myself and others.
1252
1253         Unreviewed.
1254
1255         * Scripts/webkitpy/common/config/watchlist:
1256
1257 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
1258
1259         Abstract the logic for appending a UChar32 onto StringBuilder
1260         https://bugs.webkit.org/show_bug.cgi?id=107505
1261
1262         Reviewed by Darin Adler.
1263
1264         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1265         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
1266
1267 2013-01-24  Erik Arvidsson  <arv@chromium.org>
1268
1269         Unreviewed, rolling out r140703.
1270         http://trac.webkit.org/changeset/140703
1271         https://bugs.webkit.org/show_bug.cgi?id=107556
1272
1273         r140561 was not the reason for the Android breakage
1274
1275         * DumpRenderTree/chromium/TestShell.cpp:
1276         (TestShell::~TestShell):
1277         (TestShell::closeWindow):
1278         * DumpRenderTree/chromium/WebViewHost.cpp:
1279         (WebViewHost::WebViewHost):
1280         (WebViewHost::~WebViewHost):
1281         (WebViewHost::shutdown):
1282         * DumpRenderTree/chromium/WebViewHost.h:
1283         (WebViewHost):
1284
1285 2013-01-24  Dean Jackson  <dino@apple.com>
1286
1287         Allow some plugin snapshot UI content to come from Injected Bundle
1288         https://bugs.webkit.org/show_bug.cgi?id=107852
1289
1290         Reviewed by Anders Carlsson.
1291
1292         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
1293         plugInExtraStyleSheet.
1294
1295         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1296         (WTR::InjectedBundlePage::InjectedBundlePage):
1297
1298 2013-01-24  Erik Arvidsson  <arv@chromium.org>
1299
1300         Unreviewed, rolling out r140561.
1301         http://trac.webkit.org/changeset/140561
1302         https://bugs.webkit.org/show_bug.cgi?id=107556
1303
1304         Suspected to break Android which prevens WebKit roll
1305
1306         * DumpRenderTree/chromium/TestShell.cpp:
1307         (TestShell::~TestShell):
1308         (TestShell::closeWindow):
1309         * DumpRenderTree/chromium/WebViewHost.cpp:
1310         (WebViewHost::WebViewHost):
1311         (WebViewHost::~WebViewHost):
1312         * DumpRenderTree/chromium/WebViewHost.h:
1313         (WebViewHost):
1314
1315 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
1316
1317         Adding "has-landed" command to webkit-patch which compares a
1318         committed patch to the changes which exist locally (ignoring the
1319         ChangeLog file).
1320
1321         https://bugs.webkit.org/show_bug.cgi?id=106402
1322
1323         Reviewed by Eric Seidel.
1324
1325         * Scripts/webkitpy/common/checkout/diff_parser.py:
1326         (git_diff_to_svn_diff):
1327         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1328         (Bug.commit_revision):
1329         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1330         (BugTest.test_is_in_comments):
1331         (BugTest):
1332         (BugTest.test_commit_revision):
1333         * Scripts/webkitpy/tool/commands/upload.py:
1334         (HasLanded):
1335         * Scripts/webkitpy/tool/steps/__init__.py:
1336         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
1337         (HasLanded):
1338         (HasLanded.convert_to_svn):
1339         (HasLanded.strip_change_log):
1340         (run):
1341
1342         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1343         (Bug.commit_revision):
1344         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1345         (BugTest.test_is_in_comments):
1346         (BugTest):
1347         (BugTest.test_commit_revision):
1348         * Scripts/webkitpy/tool/commands/upload.py:
1349         (HasLanded):
1350         * Scripts/webkitpy/tool/steps/__init__.py:
1351         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
1352         (HasLanded):
1353         (HasLanded.convert_to_svn):
1354         (HasLanded.strip_change_log):
1355         (HasLanded.diff_diff):
1356         (HasLanded.run):
1357         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
1358         (HasLandedTest):
1359         (HasLandedTest.test_run):
1360         (test_convert_to_svn_and_strip_change_log):
1361
1362 2013-01-24  Dan Carney  <dcarney@google.com>
1363
1364         [chromium] move most WebViewHost printf calls to WebTestProxy
1365         https://bugs.webkit.org/show_bug.cgi?id=107553
1366
1367         Reviewed by Jochen Eisinger.
1368
1369         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1370         (WebKit):
1371         (WebTestProxyBase):
1372         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
1373         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
1374         (WebTestRunner::WebTestProxy::runModalAlertDialog):
1375         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
1376         (WebTestRunner::WebTestProxy::runModalPromptDialog):
1377         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
1378         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1379         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1380         (WebTestRunner::WebTestProxyBase::reset):
1381         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
1382         (WebTestRunner):
1383         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
1384         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
1385         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
1386         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
1387         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
1388         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
1389         * DumpRenderTree/chromium/TestShell.cpp:
1390         (TestShell::showDevTools):
1391         * DumpRenderTree/chromium/WebViewHost.cpp:
1392         (WebViewHost::didAddMessageToConsole):
1393         (WebViewHost::runModalAlertDialog):
1394         (WebViewHost::runModalConfirmDialog):
1395         (WebViewHost::runModalPromptDialog):
1396         (WebViewHost::runModalBeforeUnloadDialog):
1397         (WebViewHost::unableToImplementPolicyWithError):
1398         (WebViewHost::reset):
1399         * DumpRenderTree/chromium/WebViewHost.h:
1400         (WebViewHost):
1401
1402 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
1403
1404         [Chromium] Give webkit_support a chance to reset state between layout test runs
1405         https://bugs.webkit.org/show_bug.cgi?id=107132
1406
1407         Reviewed by Adam Barth.
1408
1409         We currently only have need for this on OS(ANDROID), but now it
1410         would be useful to have a hook for resetting state on all
1411         platforms. Will soon be using this for IDBFactory initialization.
1412
1413         * DumpRenderTree/chromium/TestShell.cpp:
1414         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
1415
1416 2013-01-23  Alan Cutter  <alancutter@chromium.org>
1417
1418         QueueStatusServer crashes in production on next-patch
1419         https://bugs.webkit.org/show_bug.cgi?id=107775
1420
1421         Reviewed by Adam Barth.
1422
1423         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
1424
1425         * QueueStatusServer/app.yaml:
1426         * QueueStatusServer/model/patchlog.py:
1427         (PatchLog.calculate_wait_duration):
1428         (PatchLog.calculate_process_duration):
1429         (PatchLog):
1430         (PatchLog._time_delta_to_seconds):
1431
1432 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1433
1434         The previous patch wasn't complete. Finish reverting r139998 for real.
1435
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1437         (ProfilerAgent.getProfile):
1438
1439 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1440
1441         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
1442
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1444         (ProfilerAgent.getProfile):
1445
1446 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
1447
1448         [Chromium] Remove unused header files in chromium/public/platform/
1449         https://bugs.webkit.org/show_bug.cgi?id=107741
1450
1451         Reviewed by James Robinson.
1452
1453         These header files have migrated to the new Platform directory.
1454         This patch updates the remaining #include references and removes
1455         the old files that did nothing but redirect to the new ones.
1456
1457         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
1458         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
1459
1460 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
1461
1462         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
1463         https://bugs.webkit.org/show_bug.cgi?id=107727
1464
1465         Reviewed by Gustavo Noronha Silva.
1466
1467         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
1468         We are using the git repository now that github has deprecated the downloads feature.
1469
1470 2013-01-23  Tony Chang  <tony@chromium.org>
1471
1472         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
1473
1474         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
1475         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
1476         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
1477         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
1478
1479 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
1480
1481         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
1482         https://bugs.webkit.org/show_bug.cgi?id=107145
1483
1484         Reviewed by Adam Barth.
1485
1486         Part of a larger refactoring series; see tracking bug 82948.
1487         
1488         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1489         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1490         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1491         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1492         * DumpRenderTree/chromium/DRTTestRunner.h:
1493         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
1494         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1495         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
1496         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1497         * DumpRenderTree/chromium/TestNavigationController.h:
1498         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
1499         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1500         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
1501         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1502         (WebTestRunner):
1503         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1504         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
1505         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1506         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1507         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1508         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1509         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
1510         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
1511         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
1512         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1513         * DumpRenderTree/chromium/TestShell.cpp:
1514         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1515         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1516         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1517         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1518         * DumpRenderTree/chromium/WebViewHost.cpp:
1519
1520 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
1521
1522         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
1523         https://bugs.webkit.org/show_bug.cgi?id=107556
1524
1525         Reviewed by Tony Chang.
1526
1527         WebViewHost initiates a navigation to about:blank in its destructor.
1528         However, since WebTestProxy inherits from WebViewHost, at this point
1529         the WebViewClient and WebFrameClient interfaces are already partially
1530         destructed resulting in the use after free.
1531
1532         This does not affect the chromium implementation since it doesn't
1533         invoke WebKit API methods in its destructor.
1534
1535         * DumpRenderTree/chromium/TestShell.cpp:
1536         (TestShell::~TestShell):
1537         (TestShell::closeWindow):
1538         * DumpRenderTree/chromium/WebViewHost.cpp:
1539         (WebViewHost::WebViewHost):
1540         (WebViewHost::~WebViewHost):
1541         (WebViewHost::shutdown):
1542         * DumpRenderTree/chromium/WebViewHost.h:
1543         (WebViewHost):
1544
1545 2013-01-23  Andrei Bucur  <abucur@adobe.com>
1546
1547         [CSS Regions] Create Regions watchlist
1548         https://bugs.webkit.org/show_bug.cgi?id=107281
1549
1550         Reviewed by Adam Barth.
1551
1552         This patch adds 4 new definitions:
1553         - RegionsDevelopment - used to track the development progress for regions
1554         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
1555         - RegionsUsage - used to track changes that make use of regions in all the code base
1556
1557         For now, the Adobe internal tracker is the only email address listening for these patterns.
1558
1559         * Scripts/webkitpy/common/config/watchlist:
1560
1561 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
1562
1563         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
1564         https://bugs.webkit.org/show_bug.cgi?id=107523
1565
1566         Reviewed by Yury Semikhatsky.
1567
1568         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1569         (DRTDevToolsClient::isUnderTest):
1570         (DRTDevToolsClient::call):
1571         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1572         (DRTDevToolsClient):
1573
1574 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
1575
1576         Removing command line shortening as it makes it difficult to see the command during errors.
1577         https://bugs.webkit.org/show_bug.cgi?id=107643
1578
1579         Reviewed by Eric Seidel.
1580
1581         * Scripts/webkitpy/common/system/executive.py:
1582         (ScriptError):
1583         (ScriptError.__init__):
1584         * Scripts/webkitpy/common/system/executive_unittest.py:
1585
1586 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
1587
1588         Adding myself as contributor in committers.py (as requested by eseidel).
1589         https://bugs.webkit.org/show_bug.cgi?id=107647
1590
1591         Reviewed by Eric Seidel.
1592
1593         * Scripts/webkitpy/common/config/committers.py:
1594
1595 2013-01-22  Alan Cutter  <alancutter@chromium.org>
1596
1597         Add monitoring of patches and queues to the QueueStatusServer
1598         https://bugs.webkit.org/show_bug.cgi?id=107612
1599
1600         Reviewed by Adam Barth.
1601
1602         Created classes for recording events into the datastore and integrated them into the existing handlers.
1603         Code for presenting the recorded data will come in a separate patch.
1604
1605         * QueueStatusServer/app.yaml:
1606         * QueueStatusServer/config/__init__.py: Added.
1607         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1608         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1609         * QueueStatusServer/handlers/nextpatch.py:
1610         (NextPatch.get):
1611         (NextPatch._assign_patch):
1612         * QueueStatusServer/handlers/releasepatch.py:
1613         (ReleasePatch.post):
1614         * QueueStatusServer/handlers/updatestatus.py:
1615         (UpdateStatus.post):
1616         * QueueStatusServer/handlers/updateworkitems.py:
1617         (UpdateWorkItems._parse_work_items_string):
1618         (UpdateWorkItems):
1619         (UpdateWorkItems._update_work_items_from_request):
1620         (UpdateWorkItems._queue_from_request):
1621         (UpdateWorkItems.post):
1622         * QueueStatusServer/loggers/__init__.py: Added.
1623         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1624         (RecordBotEvent):
1625         (RecordBotEvent.activity):
1626         * QueueStatusServer/loggers/recordpatchevent.py: Added.
1627         (RecordPatchEvent):
1628         (RecordPatchEvent.added):
1629         (RecordPatchEvent.retrying):
1630         (RecordPatchEvent.started):
1631         (RecordPatchEvent.stopped):
1632         (RecordPatchEvent.updated):
1633         (RecordPatchEvent._get_patches_waiting):
1634         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1635         (PatchLog):
1636         (PatchLog.lookup):
1637         (PatchLog.calculate_wait_duration):
1638         (PatchLog.calculate_process_duration):
1639         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
1640         (QueueLog):
1641         (QueueLog.get_current):
1642         (QueueLog.create_key):
1643         * QueueStatusServer/model/queuestatus.py:
1644         (QueueStatus.is_retry_request):
1645
1646 2013-01-22  Timothy Loh  <timloh@chromium.com>
1647
1648         prepare-Changelog should support updating the list of changed files
1649         https://bugs.webkit.org/show_bug.cgi?id=74358
1650
1651         Reviewed by Eric Seidel.
1652
1653         Needing to re-make ChangeLog entries when the list of files/functions
1654         changes is a bit annoying, it'd be nice to have this more automated.
1655         This patch makes `webkit-patch update' update the date line and bug
1656         description if needed, and if the list of changed files/functions has
1657         changed, either updates the list (if there are no annotations), or
1658         otherwise appends the new list below.
1659
1660         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1661         (PrepareChangeLog._resolve_existing_entry):
1662         (PrepareChangeLog):
1663         (PrepareChangeLog._merge_entries):
1664         (PrepareChangeLog.run):
1665         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1666         (PrepareChangeLogTest.test_resolve_existing_entry):
1667         (make_entry):
1668         (test_ensure_bug_url):
1669
1670 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1671
1672         Use Python 2.7 unittest syntax in our unittests
1673         https://bugs.webkit.org/show_bug.cgi?id=105607
1674
1675         Reviewed by Eric Seidel.
1676
1677         * Scripts/webkitpy/**/*_unittest.py:
1678
1679 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1680
1681         Convert disable-msg to disable for new pylint.
1682         https://bugs.webkit.org/show_bug.cgi?id=107627
1683
1684         Reviewed by Eric Seidel.
1685
1686         * Scripts/webkitpy/common/checkout/scm/svn.py:
1687         (SVNRepository.has_authorization_for_realm):
1688         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1689         (Builder.force_build):
1690         * Scripts/webkitpy/common/system/executive_mock.py:
1691         (MockExecutive2.run_command):
1692         * Scripts/webkitpy/layout_tests/port/base.py:
1693         (Port.reference_files):
1694         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1695         (ChromiumPortTestCase.test_default_configuration):
1696         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1697         (PortTestCase.test_expectations_ordering):
1698         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1699         (HttpServerBase._check_that_all_ports_are_available):
1700         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1701         (AbstractLocalServerCommand.execute):
1702         * Scripts/webkitpy/tool/commands/download.py:
1703         (AbstractPatchProcessingCommand):
1704         * Scripts/webkitpy/tool/commands/rebaseline.py:
1705         (AbstractRebaseliningCommand):
1706         (AbstractParallelRebaselineCommand):
1707         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1708         (_BaseTestCase.setUp):
1709         (TestAnalyzeBaselines.setUp):
1710
1711 2013-01-22  Frank Farzan  <frankf@chromium.org>
1712
1713         Flakiness dashboard: update builders.jsonp
1714         https://bugs.webkit.org/show_bug.cgi?id=107610
1715
1716         Reviewed by Ojan Vafai.
1717
1718         * TestResultServer/static-dashboards/builders.jsonp:
1719
1720 2013-01-22  Frank Farzan  <frankf@chromium.org>
1721
1722         Add Android instrumentation tests from ChromiumLinux waterfall
1723         https://bugs.webkit.org/show_bug.cgi?id=107597
1724
1725         Reviewed by Ojan Vafai.
1726
1727         * TestResultServer/static-dashboards/builders.js:
1728         (loadBuildersList):
1729
1730 2013-01-21  Kentaro Hara  <haraken@chromium.org>
1731
1732         Implement UIEvent constructor
1733         https://bugs.webkit.org/show_bug.cgi?id=107430
1734
1735         Reviewed by Adam Barth.
1736
1737         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
1738
1739         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
1740         which is enabled on Safari and Chromium for now.
1741
1742         * Scripts/webkitperl/FeatureList.pm:
1743
1744 2013-01-22  Timothy Loh  <timloh@chromium.com>
1745
1746         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
1747         https://bugs.webkit.org/show_bug.cgi?id=107478
1748
1749         Reviewed by Eric Seidel.
1750
1751         On the road to resolving Bug 74358, we need a few more functions in
1752         changelog.py.
1753         To make things easier to mock, change @staticmethods to @classmethods.
1754
1755         * Scripts/webkitpy/common/checkout/changelog.py:
1756         (ChangeLogEntry):
1757         (ChangeLogEntry._parse_reviewer_text):
1758         (ChangeLogEntry._split_contributor_names):
1759         (ChangeLogEntry._parse_author_name_and_email):
1760         (ChangeLogEntry._parse_author_text):
1761         (ChangeLogEntry._parse_touched_functions):
1762         (ChangeLogEntry._parse_bug_description):
1763         (ChangeLogEntry._parse_entry):
1764         (ChangeLogEntry.date_line):
1765         (ChangeLogEntry.bug_description):
1766         (ChangeLogEntry.touched_functions):
1767         (ChangeLogEntry.touched_files_text):
1768         (ChangeLogEntry.is_touched_files_text_clean):
1769         (ChangeLog):
1770         (ChangeLog.parse_latest_entry_from_file):
1771         (ChangeLog._separate_revision_and_line):
1772         (ChangeLog.parse_entries_from_file):
1773         (ChangeLog.set_short_description_and_bug_url):
1774         (ChangeLog.delete_entries):
1775         (ChangeLog.prepend_text):
1776         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1777         (test_parse_log_entries_from_changelog):
1778         (test_latest_entry_parse):
1779         (test_set_short_description_and_bug_url):
1780         (test_delete_entries):
1781         (test_prepend_text):
1782
1783 2013-01-22  Lucas Forschler  <lforschler@apple.com>
1784
1785         Create a MAC EWS startup shell script.
1786
1787         Reviewed by Ryosuke Niwa.
1788
1789         * EWSTools/start-queue-mac.sh: Added.
1790
1791 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
1792
1793         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
1794         https://bugs.webkit.org/show_bug.cgi?id=107230
1795
1796         Reviewed by David Kilzer.
1797
1798         * DumpRenderTree/mac/TestRunnerMac.mm:
1799         (TestRunner::resetPageVisibility):
1800         Fix a typo in the original implementation. resetPageVisibility should
1801         pass initialState YES so an event is not dispatched, which causes
1802         issues in multiple tests. This now matches other ports.
1803
1804 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1805
1806         [GTK] Enable CSS Image Orientation feature
1807         https://bugs.webkit.org/show_bug.cgi?id=99040
1808
1809         Reviewed by Martin Robinson.
1810
1811         Enable the CSS Image Orientation feature in the development
1812         builds of the GTK port. The feature is still disabled in the release
1813         builds.
1814
1815         * Scripts/webkitperl/FeatureList.pm:
1816
1817 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1818
1819         [GTK] Enable the <template> element support in development builds
1820         https://bugs.webkit.org/show_bug.cgi?id=106575
1821
1822         Reviewed by Martin Robinson.
1823
1824         Enable the <template> element support in the development builds of the GTK port.
1825
1826         * Scripts/webkitperl/FeatureList.pm:
1827
1828 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1829
1830         Prettify the output of the override-feature-defines script
1831         https://bugs.webkit.org/show_bug.cgi?id=106542
1832
1833         Reviewed by Martin Robinson.
1834
1835         The output now clearly lists the feature defines being overridden
1836         along with the default and overriding values for each feature define.
1837
1838         * gtk/override-feature-defines:
1839         (adjust_feature_defines_makefile):
1840         (adjust_feature_defines_makefile.override_feature_define):
1841
1842 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
1843
1844         Remove uses of deprecated unittest.TestCase aliases
1845         https://bugs.webkit.org/show_bug.cgi?id=102252
1846
1847         Reviewed by Adam Barth.
1848
1849         Replace the deprecated assertEquals method of the TestCase interface
1850         used in some webkitpy unittests with the assertEqual method.
1851
1852         * Scripts/webkitpy/common/system/profiler_unittest.py:
1853         (ProfilerFactoryTest._assert_default_profiler_name):
1854         (ProfilerFactoryTest.test_default_profiler_output):
1855         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1856         (GtkPortTest.test_expectations_files):
1857         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1858         (TestHttpServer.test_win32_start_and_stop):
1859
1860 2013-01-22  Jer Noble  <jer.noble@apple.com>
1861
1862         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
1863         https://bugs.webkit.org/show_bug.cgi?id=107562
1864
1865         Rubber-stamped by Alexy Proskuryakov.
1866
1867         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
1868
1869         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1870         (WTR::PlatformWebView::PlatformWebView):
1871         (WTR::PlatformWebView::viewSupportsOptions):
1872
1873 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
1874
1875         One is not allowed to use commit-queue to make oneself a committer.
1876
1877         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
1878
1879 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
1880
1881         Add myself to commiters.py
1882         https://bugs.webkit.org/show_bug.cgi?id=107546
1883
1884         Reviewed by Kentaro Hara.
1885
1886         * Scripts/webkitpy/common/config/committers.py:
1887
1888 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
1889
1890         [GTK] Implement TestRunner::setTextDirection
1891         https://bugs.webkit.org/show_bug.cgi?id=107131
1892
1893         Reviewed by Philippe Normand.
1894
1895         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1896         (resetDefaultsToConsistentValues): Reset direction to default value.
1897         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1898         (TestRunner::setTextDirection): Implement method using
1899         gtk_widget_set_direction.
1900
1901 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
1902
1903         [chromium] move spell checking mocks to TestRunner library
1904         https://bugs.webkit.org/show_bug.cgi?id=107455
1905
1906         Reviewed by Kent Tamura.
1907
1908         The content module doesn't provide its own WebSpellCheckClient.
1909
1910         * DumpRenderTree/DumpRenderTree.gypi:
1911         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1912         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
1913         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1914         (WebKit):
1915         (WebTestRunner):
1916         (WebTestProxyBase):
1917         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1918         (WebTestRunner):
1919         (WebTestRunner::makeMenuItemStringsFor):
1920         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
1921         (MockGrammarCheck::checkGrammarOfString):
1922         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
1923         (WebKit):
1924         (MockGrammarCheck):
1925         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
1926         (MockSpellCheck::MockSpellCheck):
1927         (MockSpellCheck::~MockSpellCheck):
1928         (isNotASCIIAlpha):
1929         (MockSpellCheck::spellCheckWord):
1930         (MockSpellCheck::fillSuggestionList):
1931         (MockSpellCheck::initializeIfNeeded):
1932         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
1933         (MockSpellCheck):
1934         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
1935         (WebTestRunner::SpellCheckClient::SpellCheckClient):
1936         (WebTestRunner):
1937         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
1938         (WebTestRunner::SpellCheckClient::setDelegate):
1939         (WebTestRunner::SpellCheckClient::spellCheck):
1940         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
1941         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
1942         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
1943         (WebTestRunner::SpellCheckClient::autoCorrectWord):
1944         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
1945         (WebTestRunner):
1946         (SpellCheckClient):
1947         (WebTestRunner::SpellCheckClient::taskList):
1948         (WebTestRunner::SpellCheckClient::mockSpellCheck):
1949         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1950         (TestDelegate):
1951         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1952         (WebTestInterfaces::Internal):
1953         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1954         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1955         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
1956         (WebTestRunner::WebTestProxyBase::setDelegate):
1957         (WebTestRunner::WebTestProxyBase::spellCheckClient):
1958         (WebTestRunner):
1959         * DumpRenderTree/chromium/WebViewHost.cpp:
1960         (WebViewHost::WebViewHost):
1961         (WebViewHost::setWebWidget):
1962         * DumpRenderTree/chromium/WebViewHost.h:
1963         (WebViewHost):
1964
1965 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
1966
1967         [EFL] Adds Accessibility support to wk1
1968         https://bugs.webkit.org/show_bug.cgi?id=107440
1969
1970         Reviewed by Gyuyoung Kim.
1971
1972         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
1973
1974 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
1975
1976         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
1977         https://bugs.webkit.org/show_bug.cgi?id=107506
1978
1979         Reviewed by Dan Bernstein.
1980
1981         * MiniBrowser/mac/WK1BrowserWindowController.m:
1982         (-[WK1BrowserWindowController dealloc]):
1983
1984 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
1985
1986         Add build flag for Canvas's Path object (disabled by default)
1987         https://bugs.webkit.org/show_bug.cgi?id=107473
1988
1989         Reviewed by Dean Jackson.
1990
1991         Add CANVAS_PATH build flag to build systems.
1992
1993         * Scripts/webkitperl/FeatureList.pm:
1994
1995 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
1996
1997         [EFL][WK2] Add APIs to set/get view source mode
1998         https://bugs.webkit.org/show_bug.cgi?id=106633
1999
2000         Reviewed by Gyuyoung Kim.
2001
2002         Added a shotcut 'F8' in Minibrowser to display a source code
2003         of the web page in a new window.
2004
2005        * MiniBrowser/efl/main.c:
2006         (on_key_down):
2007         (on_window_create):
2008         (window_create):
2009         (elm_main):
2010
2011 2013-01-21  Nico Weber  <thakis@chromium.org>
2012
2013         [chromium] Don't archive generated source files.
2014         https://bugs.webkit.org/show_bug.cgi?id=106736
2015
2016         Reviewed by Eric Seidel.
2017
2018         They shouldn't be needed to run tests. They don't need a lot of space,
2019         but add many lines to the "extracting" stdout. This attempts to reduce
2020         that noise a bit.
2021
2022         * BuildSlaveSupport/built-product-archive:
2023         (archiveBuiltProduct):
2024
2025 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
2026
2027         Mac DumpRenderTree's installSignalHandlers() is unreachable code
2028         https://bugs.webkit.org/show_bug.cgi?id=107383
2029
2030         Reviewed by Sam Weinig.
2031
2032         The CrashHandler of DumpRenderTree were originally used for restoring
2033         the color profile of the main display even if DRT crashes.
2034
2035         That feature was later limited to pixel tests only in r29999.
2036
2037         In r104351, the DRT was changed to use device color space. Making the crash
2038         handlers useless, but they were left in the code since the error reporting
2039         code was still reachable.
2040
2041         Later, r124581 refactored the code and dumpPixelsForCurrentTest
2042         is being used before being assigned its value.
2043         This did cause any regression because the code had become useless with the previous change.
2044
2045         * DumpRenderTree/mac/DumpRenderTree.mm:
2046         Remove crashHandler() and installSignalHandlers() as they have become useless and
2047         have been unreachable code for 6 months.
2048         (dumpRenderTree):
2049         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
2050         at those points.
2051
2052 2013-01-21  Nico Weber  <thakis@chromium.org>
2053
2054         Make ninja the default build system for build-webkit --chromium on mac
2055         https://bugs.webkit.org/show_bug.cgi?id=106737
2056
2057         Reviewed by Eric Seidel.
2058
2059         * Scripts/update-webkit-chromium:
2060
2061 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2062
2063         Regression(r140262): Causes a lot of flakiness
2064         https://bugs.webkit.org/show_bug.cgi?id=107454
2065
2066         Reviewed by Alexey Proskuryakov.
2067
2068         r140262 introduced a lot of flakiness due to fixed layout mode
2069         not getting disabled on the view after being enabled for
2070         specific test cases. This patch makes sure fixed layout mode
2071         properly gets reset in WebKitTestRunner to avoid flakiness.
2072
2073         * WebKitTestRunner/TestInvocation.cpp:
2074         (WTR::updateLayoutType):
2075
2076 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
2077
2078         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
2079         https://bugs.webkit.org/show_bug.cgi?id=107421
2080
2081         Unreviewed build fix.
2082
2083         * Scripts/run-gtk-tests:
2084         (TestRunner): skip Resource tests.
2085
2086 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2087
2088         [EFL][WKTR] platformRunUntil() should keep the main loop running
2089         https://bugs.webkit.org/show_bug.cgi?id=107442
2090
2091         Reviewed by Noam Rosenthal.
2092
2093         EFL's implementation of platformRunUntil() should keep the main loop
2094         running and avoid calling sleep() between calls to
2095         ecore_main_loop_iterate(). This call to sleep seems to be a source
2096         of deadlocks (see Bug 106884).
2097
2098         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2099         (WTR::TestController::platformRunUntil):
2100
2101 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
2102
2103         QtTestBrowser should provide way to clear selected elements
2104         https://bugs.webkit.org/show_bug.cgi?id=107437
2105
2106         Reviewed by Simon Hausmann.
2107
2108         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
2109         Invoke the clearSelection prior to highlighting new elements.
2110
2111         * QtTestBrowser/launcherwindow.cpp:
2112         (ElementHighlight):
2113         (LauncherWindow::createChrome):
2114         (LauncherWindow::selectElements):
2115         (LauncherWindow::clearSelection):
2116         * QtTestBrowser/launcherwindow.h:
2117         (LauncherWindow):
2118
2119 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
2120
2121         [chromium] move methods interacting with willSendRequest to TestRunner
2122         https://bugs.webkit.org/show_bug.cgi?id=107270
2123
2124         Reviewed by Kent Tamura.
2125
2126         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2127         (DRTTestRunner::DRTTestRunner):
2128         (DRTTestRunner::waitForPolicyDelegate):
2129         * DumpRenderTree/chromium/DRTTestRunner.h:
2130         (DRTTestRunner):
2131         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2132         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2133         (WebTestRunner::WebTestRunner::httpHeadersToClear):
2134         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
2135         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
2136         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2137         (WebTestRunner::TestRunner::TestRunner):
2138         (WebTestRunner::TestRunner::reset):
2139         (WebTestRunner::TestRunner::httpHeadersToClear):
2140         (WebTestRunner):
2141         (WebTestRunner::TestRunner::shouldBlockRedirects):
2142         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
2143         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
2144         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2145         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
2146         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2147         (TestRunner):
2148         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2149         (WebTestRunner::WebTestProxyBase::willSendRequest):
2150         * DumpRenderTree/chromium/WebViewHost.cpp:
2151         (WebViewHost::willSendRequest):
2152         (WebViewHost::reset):
2153         * DumpRenderTree/chromium/WebViewHost.h:
2154         (WebViewHost):
2155
2156 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
2157
2158         [GTK] Stop building WebKit2 on GTK EWSs
2159         https://bugs.webkit.org/show_bug.cgi?id=107435
2160
2161         Reviewed by Philippe Normand.
2162
2163         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
2164         so stop building it on GTK EWSs.
2165
2166         * Scripts/webkitpy/common/config/ports.py:
2167         (GtkPort.build_webkit_command):
2168         * Scripts/webkitpy/common/config/ports_unittest.py:
2169         (DeprecatedPortTest.test_gtk_port):
2170
2171 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
2172
2173         MediaStream API: Update the RTCPeerConnection states to match the latest specification
2174         https://bugs.webkit.org/show_bug.cgi?id=107120
2175
2176         Reviewed by Adam Barth.
2177
2178         Updating mock to use the new states.
2179
2180         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2181         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
2182         (MockWebRTCPeerConnectionHandler::initialize):
2183         (MockWebRTCPeerConnectionHandler::updateICE):
2184
2185 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
2186
2187         Extend diff_parser to support the --full-index output.
2188         https://bugs.webkit.org/show_bug.cgi?id=107408
2189
2190         Reviewed by Maciej Stachowiak.
2191
2192         * Scripts/webkitpy/common/checkout/diff_parser.py:
2193         (git_diff_to_svn_diff):
2194         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2195         (DiffParserTest):
2196         (DiffParserTest.test_git_diff_to_svn_diff):
2197         (git_diff_to_svn_diff):
2198
2199 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
2200
2201         Dragging over an element with scrollbars should scroll the element when dragging near edges
2202         https://bugs.webkit.org/show_bug.cgi?id=39725
2203
2204         Reviewed by Hajime Morita.
2205
2206         This patch introduces canceling drag-and-drop by escape key for testing
2207         behavior after cancellation drag-and-drop.
2208
2209         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2210         (WebTestRunner):
2211         (WebTestRunner::EventSender::doMouseUp):
2212         (WebTestRunner::EventSender::finishDragAndDrop):
2213         (WebTestRunner::EventSender::keyDown):
2214         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2215         (EventSender):
2216         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
2217
2218 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2219
2220         [chromium] move frame generation related methods to TestRunner
2221         https://bugs.webkit.org/show_bug.cgi?id=107268
2222
2223         Reviewed by Adam Barth.
2224
2225         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2226         (DRTTestRunner::DRTTestRunner):
2227         (DRTTestRunner::setWillSendRequestReturnsNull):
2228         * DumpRenderTree/chromium/DRTTestRunner.h:
2229         (DRTTestRunner):
2230         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2231         (WebTestRunner::WebTestDelegate::display):
2232         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
2233         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2234         (WebTestRunner::TestRunner::TestRunner):
2235         (WebTestRunner::TestRunner::display):
2236         (WebTestRunner):
2237         (WebTestRunner::TestRunner::displayInvalidatedRegion):
2238         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2239         (TestRunner):
2240         * DumpRenderTree/chromium/WebViewHost.cpp:
2241         (WebViewHost::display):
2242         (WebViewHost::displayInvalidatedRegion):
2243         * DumpRenderTree/chromium/WebViewHost.h:
2244
2245 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2246
2247         [chromium] move speech related methods to TestRunner library
2248         https://bugs.webkit.org/show_bug.cgi?id=107266
2249
2250         Reviewed by Adam Barth.
2251
2252         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2253         (DRTTestRunner::DRTTestRunner):
2254         (DRTTestRunner::displayInvalidatedRegion):
2255         * DumpRenderTree/chromium/DRTTestRunner.h:
2256         (DRTTestRunner):
2257         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2258         (WebTestDelegate):
2259         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
2260         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
2261         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
2262         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
2263         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
2264         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2265         (WebTestRunner::TestRunner::TestRunner):
2266         (WebTestRunner):
2267         (WebTestRunner::TestRunner::addMockSpeechInputResult):
2268         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
2269         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
2270         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
2271         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
2272         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2273         (TestRunner):
2274         * DumpRenderTree/chromium/WebViewHost.cpp:
2275         (WebViewHost::addMockSpeechInputResult):
2276         (WebViewHost::setMockSpeechInputDumpRect):
2277         (WebViewHost::addMockSpeechRecognitionResult):
2278         (WebViewHost::setMockSpeechRecognitionError):
2279         (WebViewHost::wasMockSpeechRecognitionAborted):
2280         * DumpRenderTree/chromium/WebViewHost.h:
2281
2282 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2283
2284         [chromium] move notification related methods to TestRunner
2285         https://bugs.webkit.org/show_bug.cgi?id=107269
2286
2287         Reviewed by Adam Barth.
2288
2289         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2290         (DRTTestRunner::DRTTestRunner):
2291         * DumpRenderTree/chromium/DRTTestRunner.h:
2292         (DRTTestRunner):
2293         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2294         (WebTestDelegate):
2295         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
2296         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
2297         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2298         (WebTestRunner::TestRunner::TestRunner):
2299         (WebTestRunner):
2300         (WebTestRunner::TestRunner::grantWebNotificationPermission):
2301         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
2302         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2303         (TestRunner):
2304         * DumpRenderTree/chromium/WebViewHost.cpp:
2305         (WebViewHost::grantWebNotificationPermission):
2306         (WebViewHost::simulateLegacyWebNotificationClick):
2307         * DumpRenderTree/chromium/WebViewHost.h:
2308
2309 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2310
2311         [chromium] move geolocation related methods to TestRunner
2312         https://bugs.webkit.org/show_bug.cgi?id=107267
2313
2314         Reviewed by Adam Barth.
2315
2316         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2317         (DRTTestRunner::DRTTestRunner):
2318         * DumpRenderTree/chromium/DRTTestRunner.h:
2319         (DRTTestRunner):
2320         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2321         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
2322         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
2323         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
2324         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
2325         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2326         (WebTestRunner::TestRunner::TestRunner):
2327         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
2328         (WebTestRunner):
2329         (WebTestRunner::TestRunner::setGeolocationPermission):
2330         (WebTestRunner::TestRunner::setMockGeolocationPosition):
2331         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
2332         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2333         (TestRunner):
2334         * DumpRenderTree/chromium/WebViewHost.cpp:
2335         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
2336         (WebViewHost::setGeolocationPermission):
2337         (WebViewHost::setMockGeolocationPosition):
2338         (WebViewHost::setMockGeolocationPositionUnavailableError):
2339         * DumpRenderTree/chromium/WebViewHost.h:
2340
2341 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
2342
2343         Unreviewed build fix for Qt WK2 after r140258.
2344         Use the size_t type instead of unsigned for the variable
2345         which holds the position of the first null character in the
2346         console message.
2347
2348         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2349         (WTR::InjectedBundlePage::willAddMessageToConsole):
2350
2351 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2352
2353         Unreviewed, rolling out r140260.
2354         http://trac.webkit.org/changeset/140260
2355         https://bugs.webkit.org/show_bug.cgi?id=107387
2356
2357         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
2358         nothing else) (Requested by thakis__ on #webkit).
2359
2360         * Scripts/update-webkit-chromium:
2361
2362 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2363
2364         Delegated scrolling: Assertion on attempt to show a CSS sticky element
2365         https://bugs.webkit.org/show_bug.cgi?id=106890
2366
2367         Reviewed by Kenneth Rohde Christiansen.
2368
2369         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
2370
2371         * WebKitTestRunner/TestInvocation.cpp:
2372         (WTR::shouldUseFixedLayout):
2373         (WTR):
2374         (WTR::updateLayoutType):
2375
2376 2013-01-19  Nico Weber  <thakis@chromium.org>
2377
2378         Make ninja the default build system for build-webkit --chromium on mac
2379         https://bugs.webkit.org/show_bug.cgi?id=106737
2380
2381         Reviewed by Eric Seidel.
2382
2383         * Scripts/update-webkit-chromium:
2384
2385 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
2386
2387         [WK2] svg/dom/fuzz-path-parser.html is failing
2388         https://bugs.webkit.org/show_bug.cgi?id=107133
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         Console messages can contain null characters before the end of string.
2393         Appending such message to the StringBuilder as a WTFString appends the
2394         complete string, including the null character. This later cuts off everything
2395         after the null character when the string is being printed out to the test
2396         output.
2397
2398         To avoid this, truncate the string up to the first null character. This
2399         preserves the newline character appended immediately after this and
2400         stops giving incorrect output.
2401
2402         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2403         (WTR::InjectedBundlePage::willAddMessageToConsole):
2404
2405 2013-01-19  Eric Seidel  <eric@webkit.org>
2406
2407         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
2408         https://bugs.webkit.org/show_bug.cgi?id=107367
2409
2410         Reviewed by Ryosuke Niwa.
2411
2412         Using srcdoc instead of document.write changes the error output
2413         ever so slightly.  Clearly we were already trying to ignore these
2414         messages, just not succeeding.  This change makes this new test "pass" correctly.
2415
2416         * Scripts/webkitpy/performance_tests/perftest.py:
2417         (PerfTest):
2418
2419 2013-01-18  Dan Winship  <danw@gnome.org>
2420
2421         REGRESSION (r139071): run-webkit-httpd complains at launch
2422         https://bugs.webkit.org/show_bug.cgi?id=107310
2423
2424         Reviewed by Alexey Proskuryakov.
2425
2426         * Scripts/webkitperl/httpd.pm:
2427         (getApacheVersion): use preferred perl syntax
2428
2429 2013-01-18  Julie Parent  <jparent@chromium.org>
2430
2431         Add back 'group' as a default cross dashboard parameter, but with null as its value.
2432         https://bugs.webkit.org/show_bug.cgi?id=107336
2433
2434         We need to have 'group' listed as a parameter, else we never parse it,
2435         as we only parse parameters with defaults.
2436         
2437         Reviewed by Ojan Vafai.
2438
2439         * TestResultServer/static-dashboards/dashboard_base.js:
2440
2441 2013-01-18  Emil A Eklund  <eae@chromium.org>
2442
2443         Update LayoutUnit rounding unit test
2444         https://bugs.webkit.org/show_bug.cgi?id=107322
2445
2446         Reviewed by Levi Weintraub.
2447         
2448         Update the LayoutUnitRounding test to use fromFloatRound for
2449         values that cannot accurately be represented as a LayoutUnit
2450         (the default behavior is to floor the value to the nearest
2451         LayoutUnit).
2452
2453         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2454         (TestWebKitAPI::TEST):
2455
2456 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2457
2458         VCSUtils.pm: Stop calling git repo-config.
2459         https://bugs.webkit.org/show_bug.cgi?id=107294
2460
2461         Reviewed by Dirk Pranke.
2462
2463         The `repo-config' git command has been deprecated since early
2464         2008, and recent versions have started warning it is deprecated.
2465
2466         Basically revert r27870 and use the `config' command all the time.
2467
2468         * Scripts/VCSUtils.pm:
2469         (gitConfig):
2470
2471 2013-01-18  Levi Weintraub  <leviw@chromium.org>
2472
2473         LayoutUnit should round half consistently, not away from zero
2474         https://bugs.webkit.org/show_bug.cgi?id=107208
2475
2476         Reviewed by Eric Seidel.
2477
2478         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
2479         cover this change in rounding behavior.
2480
2481 2013-01-18  Tim Horton  <timothy_horton@apple.com>
2482
2483         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
2484         https://bugs.webkit.org/show_bug.cgi?id=107234
2485
2486         Reviewed by Simon Fraser.
2487
2488         * DumpRenderTree/mac/DumpRenderTree.mm:
2489         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
2490         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2491         (WTR::PlatformWebView::PlatformWebView): Ditto.
2492
2493 2013-01-18  Tim Horton  <timothy_horton@apple.com>
2494
2495         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
2496         https://bugs.webkit.org/show_bug.cgi?id=107251
2497
2498         Reviewed by Simon Fraser.
2499
2500         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
2501
2502         * DumpRenderTree/mac/DumpRenderTree.mm:
2503         (dumpRenderTree):
2504         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2505         (WTR::InjectedBundle::platformInitialize):
2506
2507 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
2508
2509         [GTK] Enable indexed database for development builds
2510         https://bugs.webkit.org/show_bug.cgi?id=107299
2511
2512         Reviewed by Gustavo Noronha Silva.
2513
2514         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
2515         for GTK+ development builds.
2516
2517 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
2518
2519         AX: Improve table-guessing heuristics
2520         https://bugs.webkit.org/show_bug.cgi?id=107042
2521
2522         Reviewed by Chris Fleizach.
2523
2524         Implement parentElementCallback on Chromium to make testing easier.
2525
2526         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2527         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
2528
2529 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
2530
2531         [GTK] Add property for IndexedDB database path to WebKitGTK+
2532         https://bugs.webkit.org/show_bug.cgi?id=106136
2533
2534         Reviewed by Gustavo Noronha Silva.
2535
2536         During testing, set the web database directory to DUMPRENDERTREE_TEMP
2537         before falling back to the old default. This is necessary because
2538         indexed database tests require that each DRT shard is using a different
2539         IDB database location.
2540
2541         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2542         (temporaryDatabaseDirectory): Added this helper for getting the
2543         database directory.
2544         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
2545
2546 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2547
2548         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
2549         https://bugs.webkit.org/show_bug.cgi?id=107264
2550
2551         Reviewed by Laszlo Gombos.
2552
2553         Enable API test InjectedBundleFrameHitTest for hit-testing,
2554         since it is now passing on both Debug and Release builds.
2555
2556         * TestWebKitAPI/CMakeLists.txt:
2557         * TestWebKitAPI/PlatformEfl.cmake:
2558
2559 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
2560
2561         [GTK] Implement TestRunner::addUserScript
2562         https://bugs.webkit.org/show_bug.cgi?id=107275
2563
2564         Reviewed by Philippe Normand.
2565
2566         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2567         (TestRunner::addUserScript): Implement method using
2568         DumpRenderTreeSupportGtk::addUserScript.
2569
2570 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2571
2572         Unreviewed, add my secondary email address to the list.
2573
2574         * Scripts/webkitpy/common/config/committers.py:
2575
2576 2013-01-18  Dan Carney  <dcarney@google.com>
2577
2578         [chromium] move pointerlock functions to TestRunner library
2579         https://bugs.webkit.org/show_bug.cgi?id=107241
2580
2581         Reviewed by Jochen Eisinger.
2582
2583         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2584         (DRTTestRunner::DRTTestRunner):
2585         * DumpRenderTree/chromium/DRTTestRunner.h:
2586         (DRTTestRunner):
2587         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2588         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
2589         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
2590         (WebTestRunner::WebTestDelegate::didLosePointerLock):
2591         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
2592         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
2593         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2594         (WebTestRunner::TestRunner::TestRunner):
2595         (WebTestRunner):
2596         (WebTestRunner::TestRunner::didAcquirePointerLock):
2597         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
2598         (WebTestRunner::TestRunner::didLosePointerLock):
2599         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
2600         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
2601         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2602         (TestRunner):
2603         * DumpRenderTree/chromium/WebViewHost.h:
2604         (WebViewHost):
2605
2606 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
2607
2608         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
2609         https://bugs.webkit.org/show_bug.cgi?id=106774
2610
2611         Reviewed by Martin Robinson.
2612
2613         In order to fix a long standing linespacing/font ascent & descent issue
2614         we found that FreeType commit b0962ac34e660 solves that problem.
2615         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
2616         maintainer recommending several security updates after that said commit.
2617
2618         Also, in order to avoid extra rebaselining, let's activate subpixel
2619         layout at the same time.
2620
2621         * efl/jhbuild.modules: New freetype 2.4.11
2622
2623 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2624
2625         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
2626         https://bugs.webkit.org/show_bug.cgi?id=107107
2627         PR 282192
2628
2629         Reviewed by Rob Buis.
2630
2631         The DRT application will convert relative/absolute file path to
2632         file://<real-file-path> format, so we only check for http/file prefix.
2633
2634         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2635         (BlackBerry::WebKit::isFullUrl):
2636         (WebKit):
2637         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
2638
2639 2013-01-17  Frank Farzan  <frankf@chromium.org>
2640
2641         Flakiness dashboard: Add ChromiumFYI master
2642         https://bugs.webkit.org/show_bug.cgi?id=107180
2643
2644         Reviewed by Ojan Vafai.
2645
2646         This is needed to enable Chrome Android bots
2647         to upload results for instrumentation tests.
2648
2649         * TestResultServer/generate_builders_json.py:
2650         (main):
2651         * TestResultServer/static-dashboards/builders.jsonp:
2652
2653 2013-01-17  Frank Farzan  <frankf@chromium.org>
2654
2655         Add Chrome on Android instrumentation test types to flakiness dashboard
2656         https://bugs.webkit.org/show_bug.cgi?id=106964
2657
2658         Reviewed by Ojan Vafai.
2659
2660         Specifically, add these test types:
2661         
2662          androidwebview_instrumentation_tests
2663          chromiumtestshell_instrumentation_tests
2664          contentshell_instrumentation_tests
2665         
2666         Also, add ChromiumFYI to the list of masters.
2667
2668         * TestResultServer/static-dashboards/builders.js:
2669         (loadBuildersList):
2670         * TestResultServer/static-dashboards/dashboard_base.js:
2671         (currentBuilderGroupCategory):
2672
2673 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
2674
2675         Fixing webkitpy's SCM unit tests.
2676         https://bugs.webkit.org/show_bug.cgi?id=106429
2677
2678         Reviewed by Eric Seidel.
2679
2680         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2681         (SCMDetectorTest.test_detect_scm_system):
2682         * Scripts/webkitpy/common/checkout/scm/git.py:
2683         (Git.in_working_directory):
2684         (Git.read_git_config):
2685         (Git._assert_can_squash):
2686         (Git.remote_branch_ref):
2687         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2688         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
2689         (GitTestWithMock):
2690         (GitTestWithMock.make_scm):
2691         (GitTestWithMock.test_create_patch):
2692         * Scripts/webkitpy/common/system/outputcapture.py:
2693         (OutputCapture.assert_outputs):
2694         (OutputCaptureTestCaseBase):
2695         * Scripts/webkitpy/test/printer.py:
2696         (Printer.configure):
2697
2698 2013-01-17  Julie Parent  <jparent@chromium.org>
2699
2700         Flakiness dashboard assumes there must be ToT tests
2701         https://bugs.webkit.org/show_bug.cgi?id=107155
2702
2703         Remove group as a default parameter, since we can't actually know
2704         the name of a group initially.  Instead, introduces 
2705         currentBuilderGroupName which returns the current builder group
2706         if it has been explicitly set, or picks the first one available
2707         as a default. Allows us to remove some extra code tracking this
2708         stuff as well.
2709         
2710         Reviewed by Ojan Vafai.
2711
2712         * TestResultServer/static-dashboards/dashboard_base.js:
2713         (parseCrossDashboardParameters):
2714         (currentBuilderGroupName):
2715         (currentBuilderGroup):
2716         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2717         (platformAndBuildType):
2718         * TestResultServer/static-dashboards/loader.js:
2719         (.):
2720
2721 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2722
2723         Remove NodeListsNodeData when it's no longer needed
2724         https://bugs.webkit.org/show_bug.cgi?id=107074
2725
2726         Reviewed by Darin Adler.
2727
2728         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
2729
2730         * Scripts/webkitpy/performance_tests/perftest.py:
2731         (PerfTest):
2732
2733 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
2734
2735         Ref test images are upside-down in WebKit2
2736         https://bugs.webkit.org/show_bug.cgi?id=105457
2737
2738         Reviewed by Sam "Speedy" Weinig.
2739         
2740         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
2741         from the window snapshot contained a flipped copy of the image, causing all ref
2742         and pixel images to be upside-down.
2743
2744         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2745         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2746
2747 2013-01-17  Timothy Loh  <timloh@google.com>
2748
2749         Replaced specifiers variable with is_debug in builders.py
2750         https://bugs.webkit.org/show_bug.cgi?id=107057
2751
2752         Reviewed by Dirk Pranke.
2753
2754         Replaced specifiers variable with is_debug in builders.py to simplify
2755         Bug 106259. The other specifiers are not used elsewhere in the code.
2756         Fixed builder_name_for_port_name to return a debug builder if we don't
2757         have a release builder.
2758
2759         * Scripts/webkitpy/layout_tests/port/builders.py:
2760         (all_port_names):
2761         (builder_name_for_port_name):
2762         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2763         (TestRebaselineExpectations.test_rebaseline_expectations):
2764
2765 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
2766
2767         [GTK] Build with LevelDB when IndexedDB is enabled
2768         https://bugs.webkit.org/show_bug.cgi?id=103220
2769
2770         Reviewed by Gustavo Noronha Silva.
2771
2772         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
2773         as it does not conform to WebKit style.
2774
2775 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2776
2777         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
2778         https://bugs.webkit.org/show_bug.cgi?id=107119
2779
2780         Reviewed by Laszlo Gombos.
2781
2782         Do not use ASSERT on ecore_evas_init(), since the expression inside
2783         the macro compiles out of release builds.
2784
2785         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
2786         * TestWebKitAPI/efl/PlatformWebView.cpp:
2787         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
2788
2789 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
2790
2791         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
2792         https://bugs.webkit.org/show_bug.cgi?id=104545
2793
2794         Reviewed by Yury Semikhatsky.
2795
2796         Adopt signature changes.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2799         (ProfilerAgent.getCPUProfile): Renamed.
2800         (ProfilerAgent.getHeapSnapshot): Added.
2801
2802 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
2803
2804         [GTK][EFL] NWRT should check that Xvfb is installed
2805         https://bugs.webkit.org/show_bug.cgi?id=71767
2806
2807         Reviewed by Dirk Pranke.
2808
2809         EFL and GTK ports now check that Xvfb is installed before running
2810         layout tests. The command line used to check whether Xvfb is present
2811         is a simple `which Xvfb` that should return 0 as the exit code upon
2812         success.
2813
2814         * Scripts/webkitpy/layout_tests/port/efl.py:
2815         (EflPort.show_results_html_file):
2816         (EflPort):
2817         (EflPort.check_sys_deps):
2818         * Scripts/webkitpy/layout_tests/port/gtk.py:
2819         (GtkPort.check_sys_deps):
2820         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2821         (XvfbDriver):
2822         (XvfbDriver.check_xvfb):
2823
2824 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2825
2826         sheriffbot can't tell me who "kov" is
2827         https://bugs.webkit.org/show_bug.cgi?id=106184
2828
2829         Reviewed by Eric Seidel.
2830
2831         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
2832
2833         * Scripts/webkitpy/common/config/committers.py:
2834         (Account.matches_glob):
2835         (CommitterList.contributors_by_search_string):
2836         * Scripts/webkitpy/common/config/committers_unittest.py:
2837         (CommittersTest.test_committer_lookup):
2838         * Scripts/webkitpy/tool/bot/irc_command.py:
2839         (Whois):
2840
2841 2013-01-16  David Kilzer  <ddkilzer@apple.com>
2842
2843         Use xcrun to find path to make for Mac port
2844         <http://webkit.org/b/107091>
2845
2846         Reviewed by Dan Bernstein.
2847
2848         * Scripts/webkitpy/layout_tests/port/mac.py:
2849         (MacPort._build_java_test_support): Call self.make_command().
2850         (MacPort.make_command): Add.  Call xcrun_find().
2851         (MacPort.nm_command): Use self.xcrun_find().
2852         (MacPort.xcrun_find): Add.  Extract from nm_command().
2853
2854 2013-01-16  Sam Weinig  <sam@webkit.org>
2855
2856         Make debug-safari --target-web-process work again
2857         https://bugs.webkit.org/show_bug.cgi?id=107088
2858
2859         Reviewed by Anders Carlsson.
2860
2861         * Scripts/webkitdirs.pm:
2862         (execMacWebKitAppForDebugging):
2863         The shim is now called SecItemShim.
2864
2865 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2866
2867         GCE build scripts don't take working directory into account when calling findzone.sh
2868         https://bugs.webkit.org/show_bug.cgi?id=106962
2869
2870         Reviewed by Adam Barth.
2871
2872         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2873         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2874         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2875
2876 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2877
2878         start-queue.sh does not pass remaining parameters correctly
2879         https://bugs.webkit.org/show_bug.cgi?id=107054
2880
2881         Reviewed by Adam Barth.
2882
2883         start-queue.sh now passes all remaining params to the webkit-patch command.
2884         Previously only one additional queue parameter could be sent.
2885
2886         * EWSTools/start-queue.sh:
2887
2888 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
2889
2890         check-webkit-style script cannot running in Chinese windows.
2891         https://bugs.webkit.org/show_bug.cgi?id=87548
2892
2893         Reviewed by Darin Adler.
2894
2895         * Scripts/webkitpy/common/system/platforminfo.py:
2896         (PlatformInfo._win_version_tuple_from_cmd):
2897
2898 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
2899
2900         Delete an extraneous print statement.
2901         https://bugs.webkit.org/show_bug.cgi?id=106562
2902
2903         Delete the extraneous print statement introduced in r139841.
2904
2905         * Scripts/webkitpy/layout_tests/views/printing.py:
2906         (Printer.print_found):
2907
2908 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
2909
2910         Please reinstate --pixel
2911         https://bugs.webkit.org/show_bug.cgi?id=101995
2912
2913         Reviewed by Dirk Pranke.
2914
2915         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
2916         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
2917         Some developers are still used to these options that were available in the ORWT.
2918
2919         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2920         (parse_args):
2921
2922 2013-01-16  Eric Seidel  <eric@webkit.org>
2923
2924         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
2925         https://bugs.webkit.org/show_bug.cgi?id=99512
2926
2927         Reviewed by Darin Adler.
2928
2929         * Scripts/run-sunspider:
2930
2931 2013-01-16  Eric Seidel  <eric@webkit.org>
2932
2933         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
2934         https://bugs.webkit.org/show_bug.cgi?id=106036
2935
2936         Reviewed by Darin Adler.
2937
2938         * Scripts/webkitpy/webkitpy.pyproj: Removed.
2939         * Scripts/webkitpy/webkitpy.sln: Removed.
2940
2941 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
2942
2943         [Chromium] Remove hardcoded chromium_*.jar in gyp files
2944         https://bugs.webkit.org/show_bug.cgi?id=104049
2945
2946         Reviewed by Eric Seidel.
2947
2948         Targets with dependencies (direct/indirect) on a java target receive
2949         the chromium_*.jar paths in the variable input_jars_paths. Targets
2950         should use that rather than hardcoding where they think the jar will
2951         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
2952         than as --jars to generate_native_test.py.
2953
2954         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2955         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2956
2957 2013-01-16  Dan Carney  <dcarney@google.com>
2958
2959         [chromium] move setMockDeviceOrientation to TestRunner library
2960         https://bugs.webkit.org/show_bug.cgi?id=106895
2961
2962         Reviewed by Jochen Eisinger.
2963
2964         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2965         (DRTTestRunner::DRTTestRunner):
2966         * DumpRenderTree/chromium/DRTTestRunner.h:
2967         (DRTTestRunner):
2968         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2969         (WebKit):
2970         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
2971         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2972         (WebTestRunner::TestRunner::TestRunner):
2973         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2974         (WebTestRunner):
2975         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2976         (TestRunner):
2977         * DumpRenderTree/chromium/WebViewHost.cpp:
2978         (WebViewHost::setDeviceOrientation):
2979         * DumpRenderTree/chromium/WebViewHost.h:
2980         (WebViewHost):
2981
2982 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2983
2984         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2985         https://bugs.webkit.org/show_bug.cgi?id=106904
2986
2987         Reviewed by Adam Barth.
2988
2989         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2990         (DRTTestRunner::DRTTestRunner):
2991         (DRTTestRunner::notifyDone):
2992         (DRTTestRunner::reset):
2993         * DumpRenderTree/chromium/DRTTestRunner.h:
2994         (DRTTestRunner):
2995         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2996         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2997         (WebTestRunner::WebTestDelegate::setFocus):
2998         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2999         (WebTestRunner::WebTestDelegate::pathToLocalResource):
3000         (WebTestRunner::WebTestDelegate::setLocale):
3001         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3002         (WebTestRunner::TestRunner::TestRunner):
3003         (WebTestRunner::TestRunner::reset):
3004         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
3005         (WebTestRunner):
3006         (WebTestRunner::TestRunner::setWindowIsKey):
3007         (WebTestRunner::TestRunner::pathToLocalResource):
3008         (WebTestRunner::TestRunner::setBackingScaleFactor):
3009         (WebTestRunner::TestRunner::setPOSIXLocale):
3010         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3011         (WebTestRunner::TestRunner::taskList):
3012         (TestRunner):
3013         * DumpRenderTree/chromium/WebViewHost.cpp:
3014         (WebViewHost::setDeviceScaleFactor):
3015         (WebViewHost::setFocus):
3016         (WebViewHost::setAcceptAllCookies):
3017         (WebViewHost::pathToLocalResource):
3018         (WebViewHost::setLocale):
3019         * DumpRenderTree/chromium/WebViewHost.h:
3020         (WebViewHost):
3021
3022 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
3023
3024         [GTK] build-webkit fails if the jhbuild wrapper is not used
3025         https://bugs.webkit.org/show_bug.cgi?id=106769
3026
3027         Reviewed by Martin Robinson.
3028
3029         Return an empty array instead of "" in
3030         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
3031         will not be recognized as a valid command when the returned array
3032         is directly passed to perl's system() call.
3033
3034         * Scripts/webkitdirs.pm:
3035         (jhbuildWrapperPrefixIfNeeded):
3036
3037 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
3038
3039         [chromium] add title text direction attribute to TestRunner
3040         https://bugs.webkit.org/show_bug.cgi?id=106907
3041
3042         Reviewed by Adam Barth.
3043
3044         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3045         (DRTTestRunner::DRTTestRunner):
3046         (DRTTestRunner::reset):
3047         * DumpRenderTree/chromium/DRTTestRunner.h:
3048         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3049         (WebTestRunner::WebTestRunner::setTitleTextDirection):
3050         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3051         (WebTestRunner::TestRunner::TestRunner):
3052         (WebTestRunner::TestRunner::reset):
3053         (WebTestRunner::TestRunner::setTitleTextDirection):
3054         (WebTestRunner):
3055         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3056         (TestRunner):
3057         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3058         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3059         * DumpRenderTree/chromium/WebViewHost.cpp:
3060         (WebViewHost::didReceiveTitle):
3061
3062 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3063
3064         NRWT still confused about test count with --repeat-each and --iterations
3065         https://bugs.webkit.org/show_bug.cgi?id=106562
3066
3067         Reviewed by Dirk Pranke.
3068
3069         Fix the printed unique test count and skipped count. This
3070         seems to have broken in r127688 ("NRWT lies about the number
3071         of tests that it's skipping when used with --repeat-each").
3072
3073         Also add a test for print_found()
3074
3075         * Scripts/webkitpy/layout_tests/views/printing.py:
3076         (Printer.print_found):
3077         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3078         (Testprinter.test_details):
3079         (Testprinter):
3080         (Testprinter.test_found):
3081
3082 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3083
3084         Unreviewed follow-up to r139769.
3085
3086         Note that omitting the WebKit1 code from the build now
3087         works for GTK as well.
3088
3089         * Scripts/build-webkit:
3090
3091 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3092
3093         test-webkitpy: truncate output to the terminal width when necessary
3094         https://bugs.webkit.org/show_bug.cgi?id=106973
3095
3096         Reviewed by Ojan Vafai.
3097
3098         this implements the same logic for test-webkitpy that we have
3099         for run-webkit-tests (and ninja).
3100
3101         No tests written as this is exercised by running test-webkitpy itself.
3102
3103         * Scripts/webkitpy/test/printer.py:
3104         (Printer.configure):
3105         (Printer._test_line):
3106
3107 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3108
3109         remove extraneous output in test-webkitpy
3110         https://bugs.webkit.org/show_bug.cgi?id=106971
3111
3112         Reviewed by Ojan Vafai.
3113
3114         We weren't ignoring or capturing the echoed output from
3115         these two tests, and getting noise in the logs as a result.
3116
3117         * Scripts/webkitpy/common/system/executive_unittest.py:
3118         (ExecutiveTest.test_auto_stringify_args):
3119         (ExecutiveTest.test_popen_args):
3120
3121 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3122
3123         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
3124         https://bugs.webkit.org/show_bug.cgi?id=106974
3125
3126         Reviewed by Ryosuke Niwa.
3127
3128         I forgot to stub out the call to check to ensure that the ports were
3129         available, so this test could fail if something was listening on 8000 or
3130         8443 on the machine.
3131
3132         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3133         (TestHttpServer.test_win32_start_and_stop):
3134
3135 2013-01-15  Levi Weintraub  <leviw@chromium.org>
3136
3137         Unreviewed, rolling out r139792.
3138         http://trac.webkit.org/changeset/139792
3139         https://bugs.webkit.org/show_bug.cgi?id=106970
3140
3141         Broke the windows build.
3142
3143         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3144         (DRTTestRunner::DRTTestRunner):
3145         (DRTTestRunner::notifyDone):
3146         (DRTTestRunner::reset):
3147         (DRTTestRunner::setAlwaysAcceptCookies):
3148         (DRTTestRunner::setWindowIsKey):
3149         (DRTTestRunner::pathToLocalResource):
3150         (DRTTestRunner::setPOSIXLocale):
3151         (InvokeCallbackTask):
3152         (InvokeCallbackTask::InvokeCallbackTask):
3153         (InvokeCallbackTask::runIfValid):
3154         (DRTTestRunner::setBackingScaleFactor):
3155         * DumpRenderTree/chromium/DRTTestRunner.h:
3156         (DRTTestRunner):
3157         (DRTTestRunner::taskList):
3158         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3159         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
3160         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3161         (WebTestRunner::TestRunner::TestRunner):
3162         (WebTestRunner::TestRunner::reset):
3163         (WebTestRunner::TestRunner::setDatabaseQuota):
3164         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3165         (TestRunner):
3166         * DumpRenderTree/chromium/WebViewHost.cpp:
3167         (WebViewHost::setPendingExtraData):
3168         (WebViewHost::setDeviceScaleFactor):
3169         * DumpRenderTree/chromium/WebViewHost.h:
3170         (WebViewHost):
3171
3172 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
3173
3174         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
3175
3176         * Scripts/webkitpy/common/config/ports.py:
3177         (MacWK2Port):
3178
3179 2013-01-15  Alan Cutter  <alancutter@chromium.org>
3180
3181         Extend sheriffbot's "help" command to be able to get help on individual commands
3182         https://bugs.webkit.org/show_bug.cgi?id=106629
3183
3184         Reviewed by Eric Seidel.
3185
3186         Added a help command to sheriffbot.
3187         Fixed some style issues and ordered the commands alphabetically.
3188
3189         * Scripts/webkitpy/tool/bot/irc_command.py:
3190         (IRCCommand):
3191         (IRCCommand.execute):
3192         (IRCCommand.usage):
3193         (IRCCommand.help):
3194         (CreateBug):
3195         (CreateBug.execute):
3196         (Help):
3197         (Help.execute):
3198         (Help._post_command_help):
3199         (Hi):
3200         (Hi.execute):
3201         (Restart):
3202         (RollChromiumDEPS):
3203         (RollChromiumDEPS._parse_args):
3204         (RollChromiumDEPS._expand_irc_nickname):
3205         (RollChromiumDEPS.execute):
3206         (Rollout):
3207         (Rollout._extract_revisions):
3208         (Rollout.execute):
3209         (Sheriffs):
3210         (Sheriffs.execute):
3211         (Whois):
3212         (Whois.execute):
3213         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3214         (IRCBotTest.test_help):
3215
3216 2013-01-15  Enrica Casucci  <enrica@apple.com>
3217
3218         Add a new set of WebKit2 APIs for text search and
3219         search results management.
3220         https://bugs.webkit.org/show_bug.cgi?id=106834.
3221         <rdar://problem/12597159>
3222
3223         Added new test for the new WebKit2 API for
3224         text search.
3225         
3226         Reviewed by Simon Fraser.
3227
3228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3229         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
3230
3231 2013-01-15  Levi Weintraub  <leviw@chromium.org>
3232
3233         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3234         https://bugs.webkit.org/show_bug.cgi?id=106904
3235
3236         Reverting 139794. It broke the build. It appears that a header file,
3237         WebTextDirection.h, was left out.
3238
3239         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3240         (DRTTestRunner::DRTTestRunner):
3241         (DRTTestRunner::reset):
3242         * DumpRenderTree/chromium/DRTTestRunner.h:
3243         (DRTTestRunner::setTitleTextDirection):
3244         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3245         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3246         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3247         (WebTestRunner::TestRunner::TestRunner):
3248         (WebTestRunner::TestRunner::reset):
3249         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3250         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3251         (TestRunner):
3252         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3253         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3254         * DumpRenderTree/chromium/WebViewHost.cpp:
3255         (WebViewHost::didReceiveTitle):
3256
3257 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3258
3259         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3260         https://bugs.webkit.org/show_bug.cgi?id=106904
3261
3262         Reviewed by Adam Barth.
3263
3264         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3265         (DRTTestRunner::DRTTestRunner):
3266         (DRTTestRunner::notifyDone):
3267         (DRTTestRunner::reset):
3268         * DumpRenderTree/chromium/DRTTestRunner.h:
3269         (DRTTestRunner):
3270         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3271         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
3272         (WebTestRunner::WebTestDelegate::setFocus):
3273         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
3274         (WebTestRunner::WebTestDelegate::pathToLocalResource):
3275         (WebTestRunner::WebTestDelegate::setLocale):
3276         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3277         (WebTestRunner::TestRunner::TestRunner):
3278         (WebTestRunner::TestRunner::reset):
3279         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
3280         (WebTestRunner):
3281         (WebTestRunner::TestRunner::setWindowIsKey):
3282         (WebTestRunner::TestRunner::pathToLocalResource):
3283         (WebTestRunner::TestRunner::setBackingScaleFactor):
3284         (WebTestRunner::TestRunner::setPOSIXLocale):
3285         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3286         (WebTestRunner::TestRunner::taskList):
3287         (TestRunner):
3288         * DumpRenderTree/chromium/WebViewHost.cpp:
3289         (WebViewHost::setDeviceScaleFactor):
3290         (WebViewHost::setFocus):
3291         (WebViewHost::setAcceptAllCookies):
3292         (WebViewHost::pathToLocalResource):
3293         (WebViewHost::setLocale):
3294         * DumpRenderTree/chromium/WebViewHost.h:
3295         (WebViewHost):
3296
3297 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3298
3299         Tests with WontFix expectation are (indirectly) skipped
3300         https://bugs.webkit.org/show_bug.cgi?id=105860
3301
3302         Reviewed by Dirk Pranke.
3303
3304         Only skip the WontFix expectation if there are no other layout test
3305         expectations (like Failure, ImageOnlyFailure) listed for the test.
3306         This makes it possible to run an expected failure for which there
3307         is no reason or interest to fix. There are some ports that would like
3308         to exercise this behavior as well as specific test cases that should use
3309         such expectations.
3310
3311         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3312         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
3313         WONTFIX test if there are no expectations listed. The warning is adjusted
3314         to reflect the new behavior.
3315         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
3316         and adjust test cases for these changes.
3317         (ExpectationSyntaxTests.test_wontfix):
3318         (SemanticTests.test_skip_and_wontfix):
3319
3320 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3321
3322         [chromium] add title text direction attribute to TestRunner
3323         https://bugs.webkit.org/show_bug.cgi?id=106907
3324
3325         Reviewed by Adam Barth.
3326
3327         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3328         (DRTTestRunner::DRTTestRunner):
3329         (DRTTestRunner::reset):
3330         * DumpRenderTree/chromium/DRTTestRunner.h:
3331         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3332         (WebTestRunner::WebTestRunner::setTitleTextDirection):
3333         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3334         (WebTestRunner::TestRunner::TestRunner):
3335         (WebTestRunner::TestRunner::reset):
3336         (WebTestRunner::TestRunner::setTitleTextDirection):
3337         (WebTestRunner):
3338         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3339         (TestRunner):
3340         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3341         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3342         * DumpRenderTree/chromium/WebViewHost.cpp:
3343         (WebViewHost::didReceiveTitle):
3344
3345 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3346
3347         nrwt: change the default # of locked shards on chromium_win to 1
3348         https://bugs.webkit.org/show_bug.cgi?id=106938
3349
3350         Reviewed by Eric Seidel.
3351
3352         It looks like LigHTTPd might be buggy or unstable if we are
3353         running multiple http tests in parallel; see
3354         http://code.google.com/p/chromium/issues/detail?id=169530 for more
3355         context as well. This change will stop running http tests in parallel
3356         and we can see if this fixes things.
3357
3358         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3359         (ChromiumWinPort.default_max_locked_shards):
3360         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3361         (ChromiumWinTest.test_path_to_image_diff):
3362         (ChromiumWinTest):
3363         (ChromiumWinTest.test_default_max_locked_shards):
3364
3365 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3366
3367         [chromium] move WebDatabase related methods to TestRunner library
3368         https://bugs.webkit.org/show_bug.cgi?id=106905
3369
3370         Reviewed by Adam Barth.
3371
3372         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3373         (DRTTestRunner::DRTTestRunner):
3374         (DRTTestRunner::reset):
3375         * DumpRenderTree/chromium/DRTTestRunner.h:
3376         (DRTTestRunner):
3377         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3378         (WebTestRunner::WebTestDelegate::clearAllDatabases):
3379         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
3380         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3381         (WebTestRunner::TestRunner::TestRunner):
3382         (WebTestRunner::TestRunner::reset):
3383         (WebTestRunner::TestRunner::clearAllDatabases):
3384         (WebTestRunner):
3385         (WebTestRunner::TestRunner::setDatabaseQuota):
3386         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3387         (TestRunner):
3388         * DumpRenderTree/chromium/WebViewHost.cpp:
3389         (WebViewHost::clearAllDatabases):
3390         (WebViewHost::setDatabaseQuota):
3391         * DumpRenderTree/chromium/WebViewHost.h:
3392         (WebViewHost):
3393
3394 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
3395
3396         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
3397         functionality match the name.
3398         https://bugs.webkit.org/show_bug.cgi?id=106870
3399
3400         Reviewed by Adam Barth.
3401
3402         * Scripts/webkitpy/tool/commands/download.py:
3403         (Clean):
3404         (Update):
3405         (Build):
3406         (BuildAndTest):
3407         (CheckStyle):
3408         (BuildAttachment):
3409         (BuildAndTestAttachment):
3410         (AbstractPatchApplyingCommand):
3411         (ApplyWatchList):
3412         (AbstractPatchLandingCommand):
3413         (CreateRollout):
3414         * Scripts/webkitpy/tool/steps/__init__.py:
3415         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3416         (CleanWorkingDirectory.options):
3417         (CleanWorkingDirectory.run):
3418         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3419         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3420         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
3421
3422 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3423
3424         [Autotools] Add support for WebKit2-only builds
3425         https://bugs.webkit.org/show_bug.cgi?id=106889
3426
3427         Reviewed by Gustavo Noronha Silva.
3428
3429         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
3430         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
3431         building the GTK port through build-webkit.
3432         * Scripts/webkitdirs.pm:
3433         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
3434         arguments when not building WebKit1.
3435         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
3436         through the Autotools build system.
3437
3438 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3439
3440         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
3441         https://bugs.webkit.org/show_bug.cgi?id=106197
3442
3443         Reviewed by Martin Robinson.
3444
3445         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
3446         features. Enable them on GTK, meaning they will be enabled in development builds
3447         (i.e. when building with build-webkit).
3448
3449 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3450
3451         [GTK] Enable CSS Image Resolution feature
3452         https://bugs.webkit.org/show_bug.cgi?id=99038
3453
3454         Reviewed by Gustavo Noronha Silva.
3455
3456         Enable the CSS Image Resolution feature for the development
3457         builds of the GTK port.
3458
3459         * Scripts/webkitperl/FeatureList.pm:
3460
3461 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3462
3463         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
3464         https://bugs.webkit.org/show_bug.cgi?id=106579
3465
3466         Reviewed by Gustavo Noronha Silva.
3467
3468         The --enable-unstable-features flag is not required to be passed anymore
3469         to the configure script as it was removed in r138252.
3470
3471         * Scripts/webkitdirs.pm:
3472         (buildAutotoolsProject):
3473
3474 2013-01-15  Tony Chang  <tony@chromium.org>
3475
3476         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
3477
3478         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3479         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
3480         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3481         (TestHttpServer.test_win32_start_and_stop):
3482
3483 2013-01-15  Joshua Bell  <jsbell@chromium.org>
3484
3485         Unreviewed. Adding Michael Pruett as contributor.
3486
3487         * Scripts/webkitpy/common/config/committers.py:
3488
3489 2013-01-15  Victor Carbune  <victor@rosedu.org>
3490
3491         Unreviewed. Update my email addresses.
3492
3493         * Scripts/webkitpy/common/config/committers.py:
3494
3495 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3496
3497         [GTK] Waiting on the gdb process will lead to deadlock
3498         https://bugs.webkit.org/show_bug.cgi?id=106906
3499
3500         Reviewed by Philippe Normand.
3501
3502         Use communicate() rather than wait() on the Popen object that's running the gdb
3503         command. This avoids the deadlock that occurs on the GTK builders.
3504
3505         * Scripts/webkitpy/layout_tests/port/gtk.py:
3506         (GtkPort._get_gdb_output):
3507
3508 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3509
3510         [GTK] Limit the number of frames printed out when backtracing with gdb
3511         https://bugs.webkit.org/show_bug.cgi?id=106901
3512
3513         Reviewed by Philippe Normand.
3514
3515         Printing an unlimited number of frames when dumping the gdb backtracing
3516         output can cause timeouts in the builders. This patch limits the number
3517         of frames that are printed out to 1024.
3518
3519         * Scripts/webkitpy/layout_tests/port/gtk.py:
3520         (GtkPort._get_gdb_output):
3521
3522 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
3523
3524         [Qt] Fix ImageDiff's image format conversion
3525         https://bugs.webkit.org/show_bug.cgi?id=106880
3526
3527         Reviewed by Csaba Osztrogonác.
3528
3529         Besides actually doing the conversion this also silences the suspicious warning:
3530         "ignoring return value of function declared with warn_unused_result attribute".
3531
3532         * ImageDiff/qt/ImageDiff.cpp:
3533         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
3534         copy of the image in the given format and does not alter the image itself.
3535
3536 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3537
3538         [chromium] move remaining methods that just set a boolean flag to TestRunner library
3539         https://bugs.webkit.org/show_bug.cgi?id=106823
3540
3541         Reviewed by Darin Fisher.
3542
3543         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3544         (DRTTestRunner::DRTTestRunner):
3545         (DRTTestRunner::reset):
3546         * DumpRenderTree/chromium/DRTTestRunner.h:
3547         (DRTTestRunner):
3548         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3549         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
3550         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
3551         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
3552         (WebTestRunner::WebTestRunner::testRepaint):
3553         (WebTestRunner::WebTestRunner::sweepHorizontally):
3554         (WebTestRunner::WebTestRunner::isPrinting):
3555         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3556         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3557         (WebTestRunner::TestRunner::TestRunner):
3558         (WebTestRunner::TestRunner::reset):
3559         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
3560         (WebTestRunner):
3561         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
3562         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
3563         (WebTestRunner::TestRunner::testRepaint):
3564         (WebTestRunner::TestRunner::sweepHorizontally):
3565         (WebTestRunner::TestRunner::isPrinting):
3566         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3567         (WebTestRunner::TestRunner::dumpBackForwardList):
3568         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
3569         (WebTestRunner::TestRunner::dumpSelectionRect):
3570         (WebTestRunner::TestRunner::repaintSweepHorizontally):
3571         (WebTestRunner::TestRunner::setPrinting):
3572         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
3573         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3574         (TestRunner):
3575
3576 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3577
3578         nrwt: stub out show_results_html for mock ports
3579         https://bugs.webkit.org/show_bug.cgi?id=106848
3580
3581         Reviewed by Ojan Vafai.
3582
3583         We were accidentally using the underlying ports'
3584         show_results_html_file() implementation, which would, unsurprisingly,
3585         fail in many cases (e.g., running mock-efl on the mac).
3586
3587         No test added since we don't generally add tests for the mock
3588         implementation.
3589
3590         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3591         (MockDRTPort.show_results_html_file):
3592
3593 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
3594
3595         Changing clean_working_directory/clean_local_commits and related
3596         functions to have consistent naming.
3597
3598         https://bugs.webkit.org/show_bug.cgi?id=104198
3599
3600         Reviewed by Adam Barth.
3601
3602         * Scripts/webkitpy/common/checkout/scm/git.py:
3603         * Scripts/webkitpy/common/checkout/scm/scm.py:
3604         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3605         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3606         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3607         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3608
3609 2013-01-14  Alan Cutter  <alancutter@chromium.org>
3610
3611         Fix EWS GCE build scripts to detect which zone is available
3612         https://bugs.webkit.org/show_bug.cgi?id=106524
3613
3614         Reviewed by Adam Barth.
3615
3616         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3617         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3618         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3619         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
3620
3621 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
3622
3623         Adding an error string to AmbiguousCommitError.
3624         https://bugs.webkit.org/show_bug.cgi?id=106846
3625
3626         Reviewed by Adam Barth.
3627
3628         * Scripts/webkitpy/common/checkout/scm/git.py:
3629         (AmbiguousCommitError.__init__):
3630
3631 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3632
3633         kill whole lighttpd process tree for chromium win
3634         https://bugs.webkit.org/show_bug.cgi?id=106838
3635
3636         Reviewed by Tony Chang.
3637
3638         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
3639         I think a test is causing a httpd server child process to wedge and
3640         killing the parent httpd server process isn't sufficient to ensure
3641         that the children are also killed.
3642
3643         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3644         (Lighttpd._check_and_kill):
3645         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3646         (TestHttpServer.test_start_cmd):
3647         (TestHttpServer):
3648         (TestHttpServer.test_win32_start_and_stop):
3649         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
3650         (TestHttpServer.test_win32_start_and_stop.mock_returns):
3651         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
3652
3653 2013-01-14  Nico Weber  <thakis@chromium.org>
3654
3655         [chromium] Enable `update-webkit --chromium --ninja` on windows
3656         https://bugs.webkit.org/show_bug.cgi?id=106836
3657
3658         Reviewed by Eric Seidel.
3659
3660         After running this, build-webkit --chromium will use ninja to build.
3661         Apparently there are some minor issues with that still, so it's
3662         not quite ready for use yet.
3663
3664         * Scripts/webkitdirs.pm:
3665         (determineIsChromiumNinja):
3666         (buildChromium):
3667
3668 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3669
3670         nrwt: use the same search path for baselines and TestExpectations on apple mac
3671         https://bugs.webkit.org/show_bug.cgi?id=105599
3672
3673         Reviewed by Ryosuke Niwa.
3674
3675         Bug 105583 revealed some confusion due to the fact that the Apple
3676         Mac port used a different list of directories to search for baselines
3677         and TestExpectations files (actually, pretty much every port does).
3678
3679         It seems like a good idea to use the same list for both by default, but
3680         making this happen will affect every port in slightly different ways, so
3681         we'll try this on the Apple Mac port first.
3682
3683         Note that the effective changes for this are that:
3684         1) The apple mac port will look in platform/wk2 for baselines where
3685         it didn't before (it will look after looking in mac-wk2 but before
3686         the non-wk2 dirs)
3687         2) The apple mac-snowleopard port will use the expectations in