1 2016-02-15 Alex Christensen <achristensen@webkit.org>
3 Fix internal Windows build of projects built after WebKit
4 https://bugs.webkit.org/show_bug.cgi?id=154249
5 rdar://problem/24644805
7 Reviewed by Chris Dumez.
9 * DumpRenderTree/PlatformWin.cmake:
10 * MiniBrowser/win/CMakeLists.txt:
11 Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
12 more like projects built internally after WebKit. They should only need to use what
13 is in ForwardingHeaders/WebKit.
15 2016-02-12 Nan Wang <n_wang@apple.com>
17 AX: Implement paragraph related text marker functions using TextIterator
18 https://bugs.webkit.org/show_bug.cgi?id=154098
19 <rdar://problem/24269675>
21 Reviewed by Chris Fleizach.
23 * DumpRenderTree/AccessibilityUIElement.cpp:
24 (nextWordEndTextMarkerForTextMarkerCallback):
25 (paragraphTextMarkerRangeForTextMarkerCallback):
26 (previousParagraphStartTextMarkerForTextMarkerCallback):
27 (nextParagraphEndTextMarkerForTextMarkerCallback):
28 (setSelectedVisibleTextRangeCallback):
29 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
30 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
31 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
32 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
33 (AccessibilityUIElement::getJSClass):
34 * DumpRenderTree/AccessibilityUIElement.h:
35 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
36 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
37 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
38 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
39 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
40 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
41 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
42 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
43 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
44 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
45 (AccessibilityUIElement::supportedActions):
46 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
47 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
48 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
49 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
50 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
51 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
52 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
53 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
54 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
55 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
56 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
57 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
58 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
59 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
60 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
61 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
62 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
63 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
64 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
65 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
66 (WTR::_convertMathMultiscriptPairsToString):
68 2016-02-12 Jason Marcell <jmarcell@apple.com>
70 Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
71 https://bugs.webkit.org/show_bug.cgi?id=154180
73 Reviewed by Alexey Proskuryakov.
75 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
78 2016-02-12 Jer Noble <jer.noble@apple.com>
80 [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
81 https://bugs.webkit.org/show_bug.cgi?id=154136
83 Reviewed by Alex Christensen.
85 Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
87 Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
88 to GCC_PREPROCESSOR_DEFINES.
90 * TestWebKitAPI/Configurations/Base.xcconfig:
91 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
92 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
93 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
94 (TestWebKitAPI::TEST_F):
96 2016-02-11 Dana Burkart <dburkart@apple.com>
98 Large logs can bring down the webkit master
99 https://bugs.webkit.org/show_bug.cgi?id=122112
101 Reviewed by Lucas Forschler.
103 Implement the suggested fix of throwing away stdout / stderr.
105 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
106 (RunWebKit1LeakTests):
108 2016-02-10 Jason Marcell <jmarcell@apple.com>
110 Remove calls to parseInt in order to work with non-integer revisions
111 https://bugs.webkit.org/show_bug.cgi?id=153820
113 Reviewed by Daniel Bates.
115 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
116 (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
118 (BuildbotIteration.prototype._parseData): Ditto.
119 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
120 (BuildbotQueue.prototype.update): Ditto.
121 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
122 (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
123 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
124 (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
125 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
126 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
128 2016-02-10 Jason Marcell <jmarcell@apple.com>
130 Teach dashboard code to compare non-integer revisions
131 https://bugs.webkit.org/show_bug.cgi?id=152345
133 Reviewed by Daniel Bates.
135 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
136 (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
137 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
138 (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
139 revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
140 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
141 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
142 revisions. Also uses new Trac.nextRevision method to calculate a revision range.
143 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
144 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
145 (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
147 (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
148 (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
149 (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
150 (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
151 (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
152 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
154 2016-02-09 Nan Wang <n_wang@apple.com>
156 AX: Implement word related text marker functions using TextIterator
157 https://bugs.webkit.org/show_bug.cgi?id=153939
158 <rdar://problem/24269605>
160 Reviewed by Chris Fleizach.
162 * DumpRenderTree/AccessibilityUIElement.cpp:
163 (endTextMarkerCallback):
164 (leftWordTextMarkerRangeForTextMarkerCallback):
165 (rightWordTextMarkerRangeForTextMarkerCallback):
166 (previousWordStartTextMarkerForTextMarkerCallback):
167 (nextWordEndTextMarkerForTextMarkerCallback):
168 (setSelectedVisibleTextRangeCallback):
169 (AccessibilityUIElement::setSelectedVisibleTextRange):
170 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
171 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
172 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
173 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
174 (AccessibilityUIElement::getJSClass):
175 * DumpRenderTree/AccessibilityUIElement.h:
176 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
177 (AccessibilityUIElement::setSelectedVisibleTextRange):
178 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
179 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
180 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
181 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
182 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
183 (AccessibilityUIElement::setSelectedVisibleTextRange):
184 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
185 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
186 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
187 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
188 (AccessibilityUIElement::supportedActions):
189 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
190 (WTR::AccessibilityUIElement::setBoolAttributeValue):
191 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
192 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
193 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
194 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
195 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
196 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
197 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
198 (WTR::AccessibilityUIElement::endTextMarker):
199 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
200 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
201 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
202 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
203 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
204 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
205 (WTR::AccessibilityUIElement::endTextMarker):
206 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
207 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
208 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
209 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
210 (WTR::_convertMathMultiscriptPairsToString):
212 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
214 [EFL] Remove eail related cruft after r195725
215 https://bugs.webkit.org/show_bug.cgi?id=154030
217 Reviewed by Alex Christensen.
221 2016-02-09 Csaba Osztrogonác <ossy@webkit.org>
223 [EFL] Remove LLVM related cruft after r196077
224 https://bugs.webkit.org/show_bug.cgi?id=154031
226 Reviewed by Alex Christensen.
228 * efl/jhbuild.modules:
229 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
230 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
231 * efl/patches/llvm-version-arm64.patch: Removed.
233 2016-02-05 Aakash Jain <aakash_jain@apple.com>
235 tests fail if display sleeps while run-webkit-tests is running
236 https://bugs.webkit.org/show_bug.cgi?id=153919
238 Reviewed by Alexey Proskuryakov.
240 * DumpRenderTree/mac/LayoutTestHelper.m:
241 (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
242 (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
243 (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
245 2016-02-05 Alex Christensen <achristensen@webkit.org>
247 Fix iOS API tests after r196082
248 https://bugs.webkit.org/show_bug.cgi?id=153900
250 Reviewed by Jer Noble.
252 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
253 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
254 [WebView initialize] doesn't call JSC::initializeThreading on iOS.
256 2016-02-04 Jason Marcell <jmarcell@apple.com>
258 The status message for passing combined builder queues should say "all builds succeeded" when expanded.
259 https://bugs.webkit.org/show_bug.cgi?id=153882
261 Reviewed by Alexey Proskuryakov.
263 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
264 (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
267 2016-02-03 Filip Pizlo <fpizlo@apple.com>
269 run-jsc-stress-tests should be better at telling you details about test failures
270 https://bugs.webkit.org/show_bug.cgi?id=153845
272 Reviewed by Geoffrey Garen.
274 Here's an example of the contents of results/resultsByFamily, one of the new files that this
275 generates, for some local testing I'm doing. Notice how it groups families of tests together.
277 You won't see this unless you cat results/resultsByFamily.
279 regress.yaml/Regress/radar-24289839.js:
280 regress.yaml/Regress/radar-24289839.js.default: PASS
281 regress.yaml/Regress/radar-24289839.js.ftl: PASS
282 regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
283 regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
285 regress.yaml/Regress/radar-24290639.js:
286 regress.yaml/Regress/radar-24290639.js.default: PASS
287 regress.yaml/Regress/radar-24290639.js.ftl: PASS
288 regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
289 regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
291 regress.yaml/Regress/radar-24290670.js: FAILED
293 * Scripts/run-jsc-stress-tests:
295 2016-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
297 [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
298 https://bugs.webkit.org/show_bug.cgi?id=153835
300 Reviewed by Martin Robinson.
302 WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
303 the context menu event is not handled, but we are using the
304 returned value without null checking it.
306 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
307 (WTR::EventSendingController::contextClick):
309 2016-02-03 Jason Marcell <jmarcell@apple.com>
311 Format revisions for display according to repository type
312 https://bugs.webkit.org/show_bug.cgi?id=153818
314 Reviewed by Alexey Proskuryakov.
316 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
317 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
319 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
320 (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
321 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
322 _formatRevisionForDisplay function.
324 2016-02-03 Aakash Jain <aakash_jain@apple.com>
326 Logs/CoreSimulator filling up OS disk on WebKit testers
327 https://bugs.webkit.org/show_bug.cgi?id=153853
328 <rdar://problem/24496003>
330 Reviewed by Alexey Proskuryakov.
332 * Scripts/webkitpy/port/ios.py:
333 (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
335 2016-02-03 Brian Burg <bburg@apple.com>
337 git-add-reviewer should work when run from a subdirectory within the repository
338 https://bugs.webkit.org/show_bug.cgi?id=153842
340 Reviewed by David Kilzer.
342 There are two problems that needed to be fixed:
344 - We can't assume .git is in $PWD/.git
345 - We can't specify absolute paths to `git commit`
347 Fix these problems using the helpers in VCSUtils that were added to
348 fix this same issue for prepare-changeCogs.
350 * Scripts/VCSUtils.pm: Export gitDirectory()
351 * Scripts/git-add-reviewer:
352 (nonInteractive): Cache gitDirectory() result.
355 (changeLogsForCommit): Make paths relative.
357 2016-02-03 Jer Noble <jer.noble@apple.com>
359 Yet another Yosemite build fix.
361 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
363 2016-02-03 Jer Noble <jer.noble@apple.com>
365 iOS build fix after Yosemite build fix broke iOS build.
367 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
369 2016-02-03 Jer Noble <jer.noble@apple.com>
371 Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
373 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
375 2016-02-03 Joonghun Park <jh718.park@samsung.com>
377 [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
378 https://bugs.webkit.org/show_bug.cgi?id=153827
380 Reviewed by Michael Catanzaro.
382 When an array is passed to subroutines as argument in perl,
383 a list containing its element is returned from the array.
384 Currently @$ arguments are being passed, then it is going to be one list
385 including all the elements not only from @ but also from $.
386 As a result, --cmakeargs option's value is included in @cmakeArgs
387 at generateBuildSystemFromCMakeProject subroutine,
388 so $additionalCMakeArgs doesn't needed anymore.
390 * Scripts/webkitdirs.pm:
391 (generateBuildSystemFromCMakeProject):
393 2016-02-03 Jer Noble <jer.noble@apple.com>
395 [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
396 https://bugs.webkit.org/show_bug.cgi?id=153669
398 Reviewed by Alex Christensen.
400 Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
401 calling appropriate NSURLSessionDelegate callbacks.
403 Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore
404 header files will not match the one used when compiling WebCore, leading to strange crashes and weird
405 inconsistencies when calling, e.g., inline methods.
407 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
408 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
409 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
410 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
411 (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
412 (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
413 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
414 (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
415 (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
416 (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
417 (TestWebKitAPI::TEST_F):
419 2016-02-03 Konstantin Tokarev <annulen@yandex.ru>
421 [webkitdirs] Clarify logic behind is{PortName} functions.
422 https://bugs.webkit.org/show_bug.cgi?id=153554
424 Reviewed by Michael Catanzaro.
426 * Scripts/webkitdirs.pm:
427 (prohibitUnknownPort): This function makes determinePortName()
429 (determinePortName): Added new function which decides which port are
430 we building based on command line switches and platform defaults.
431 (portName): Added getter for determined $portName.
432 (isEfl): Modified to use portName().
435 (isAppleMacWebKit): Ditto.
436 (isAppleWinWebKit): Ditto.
437 (isIOSWebKit): Ditto.
438 (cmakeBasedPortName): Return portName() with capitalized first letter.
439 (determineIsEfl): Deleted.
440 (determineIsGtk): Deleted.
441 (determineIsWinCairo): Deleted.
443 * Scripts/build-jsc: Call prohibitUnknownPort().
444 * Scripts/run-minibrowser: Ditto.
445 * Scripts/webkitperl/FeatureList.pm: Ditto.
446 * Scripts/update-webkit: Call determinePortName() instead of
447 determineIsWinCairo().
449 2016-02-02 Dan Bernstein <mitz@apple.com>
451 Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
452 https://bugs.webkit.org/show_bug.cgi?id=153683
454 Reviewed by Darin Adler.
456 * Scripts/webkitpy/port/driver.py:
457 (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
458 used by any code in the Web Content process. If that ever changed, we should send it over
459 as a bundle parameter.
461 * Scripts/webkitpy/port/ios.py:
462 (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
464 * Scripts/webkitpy/port/mac.py:
465 (MacPort.setup_environ_for_server): Ditto.
467 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
468 (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
469 environment. This is early enough that libxml2 has not been initialized yet.
471 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
472 (WTR::InjectedBundle::platformInitialize): Ditto.
474 2016-02-02 Dan Bernstein <mitz@apple.com>
476 Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
477 https://bugs.webkit.org/show_bug.cgi?id=153683
479 Reviewed by Alexey Proskuryakov.
481 Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
483 * Scripts/webkitpy/port/driver.py:
484 (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
485 * Scripts/webkitpy/port/ios.py:
486 (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
487 * Scripts/webkitpy/port/mac.py:
488 (MacPort.setup_environ_for_server): Ditto.
490 2016-01-29 Grzegorz Czajkowski <g.czajkowski@samsung.com>
492 [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
493 https://bugs.webkit.org/show_bug.cgi?id=153009
495 Reviewed by Gyuyoung Kim.
497 On mobile, virtual keyboard represented by ecore_imf module appears on
498 the top of application layer usually covering bottom part of the screen.
499 If the web page contains the editable content on the bottom of the page
500 it will be overlapped by keyboard which prevents user from seeing the
503 Pack MiniBrowser layout into conformant widget to allow EFL to guess
504 the space that will be required by the keyboard, finally resizing it
505 to the desired size. As a result, webview gets resized and scrolled
506 into focused elements which makes the editable elements visible while
509 More details about elm_conformant widger can be found at:
510 https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
511 https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
513 * MiniBrowser/efl/main.c:
514 (window_create): pack a box into conformant widget.
516 2016-02-02 Alejandro G. Castro <alex@igalia.com>
518 [GTK][EFL] Upgrade OpenWebRTC dependency
519 https://bugs.webkit.org/show_bug.cgi?id=153489
521 Reviewed by Philippe Normand.
523 * Scripts/run-gtk-tests:
524 (TestRunner): Avoid running the mediastream API test.
525 * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
526 default for gtk and efl.
527 * gtk/jhbuild-webrtc.modules: Added modules files with
528 dependencies required to compile and test the mediastream.
530 2016-02-01 Jason Marcell <jmarcell@apple.com>
532 Add code to parse the git branches out of the Trac RSS feed
533 https://bugs.webkit.org/show_bug.cgi?id=153624
535 Reviewed by Daniel Bates.
537 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
538 (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
539 (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
540 "branches" and updated the code to work with an array instead of a string.
541 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
542 (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
543 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
544 fixture that contains XML with a Git branch.
545 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
546 branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
548 2016-02-01 Brady Eidson <beidson@apple.com>
550 Add command line flag to DRT to output the number of tests completed in server mode.
551 https://bugs.webkit.org/show_bug.cgi?id=153750
553 Reviewed by Darin Adler.
555 * DumpRenderTree/mac/DumpRenderTree.mm:
556 (initializeGlobalsFromCommandLineOptions):
557 (runTestingServerLoop):
559 2016-02-01 Jason Marcell <jmarcell@apple.com>
561 Improvements to botwatcher's dashboard unit tests.
562 https://bugs.webkit.org/show_bug.cgi?id=153621
564 Reviewed by Darin Adler.
566 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
567 (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
568 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
569 (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
570 _popoverLinesForCommitRange have to traverse commits from different branches.
571 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
572 in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
573 _revisionContentWithPopoverForIteration.
575 2016-02-01 Jason Marcell <jmarcell@apple.com>
577 Refactor to add event listeners and start periodic updates for all trac instances.
578 https://bugs.webkit.org/show_bug.cgi?id=153609
580 Reviewed by Darin Adler.
582 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
583 (BuildbotQueueView): Adding event listeners for all trac instances.
584 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
585 for all trac instances.
587 2016-01-31 Darin Adler <darin@apple.com>
589 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
590 https://bugs.webkit.org/show_bug.cgi?id=153639
592 Reviewed by Filip Pizlo.
594 * Scripts/do-webcore-rename: Use script to do this rename.
596 2016-01-30 Commit Queue <commit-queue@webkit.org>
598 Unreviewed, rolling out r195911.
599 https://bugs.webkit.org/show_bug.cgi?id=153723
601 Caused frequent assertion failures on bots (Requested by ap on
606 "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
607 https://bugs.webkit.org/show_bug.cgi?id=153639
608 http://trac.webkit.org/changeset/195911
610 2016-01-30 Darin Adler <darin@apple.com>
612 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
613 https://bugs.webkit.org/show_bug.cgi?id=153639
615 Reviewed by Filip Pizlo.
617 * Scripts/do-webcore-rename: Use script to do this rename.
619 2016-01-30 Ryosuke Niwa <rniwa@webkit.org>
621 TouchList should be retargeted
622 https://bugs.webkit.org/show_bug.cgi?id=149592
624 Reviewed by Antti Koivisto.
626 Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
627 multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
629 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
630 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
631 (WTR::UIScriptController::touchDownAtPoint): Added.
632 (WTR::UIScriptController::liftUpAtPoint): Added.
633 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
634 * WebKitTestRunner/ios/HIDEventGenerator.h:
635 * WebKitTestRunner/ios/HIDEventGenerator.mm:
636 (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
637 (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
638 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
639 (WTR::UIScriptController::touchDownAtPoint): Added.
640 (WTR::UIScriptController::liftUpAtPoint): Added.
642 2016-01-30 Yusuke Suzuki <utatane.tea@gmail.com>
644 Enable SamplingProfiler on POSIX environment
645 https://bugs.webkit.org/show_bug.cgi?id=153584
647 Reviewed by Michael Saboff.
649 * Scripts/run-jsc-stress-tests:
651 2016-01-29 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
653 update-webkit-dependency fails to fetch updates through firewall on Windows
654 https://bugs.webkit.org/show_bug.cgi?id=153619
656 Reviewed by Myles C. Maxfield.
658 On Windows, when a firewall is present we need to read proxy settings
659 from environment variables.
661 This patch relies on the following environment variables being set:
665 * Scripts/update-webkit-dependency:
667 2016-01-28 Dan Bernstein <mitz@apple.com>
669 [Cocoa] Use the non-Development variants of XPC services for development
670 https://bugs.webkit.org/show_bug.cgi?id=152545
672 Reviewed by Darin Adler.
674 * Scripts/webkitdirs.pm:
675 (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
677 * Scripts/webkitpy/port/driver.py:
678 (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
679 set in the XPC services as well.
681 * Scripts/webkitpy/port/ios.py:
682 (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
683 Guard Malloc are enabled in XPC services as well.
685 * Scripts/webkitpy/port/mac.py:
686 (MacPort.setup_environ_for_server): Ditto.
688 2016-01-28 Csaba Osztrogonác <ossy@webkit.org>
690 Unreviewed buildfix after r195743.
692 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
693 (WTR::AccessibilityUIElement::isPressActionSupported):
695 2016-01-12 Jer Noble <jer.noble@apple.com>
697 Custom protocol loading through AVFoundation does not support byte-range requests.
698 https://bugs.webkit.org/show_bug.cgi?id=152919
699 <rdar://problem/23664657>
701 Reviewed by Alex Christensen.
703 Add tests for new ParsedContntRange class.
705 * TestWebKitAPI/PlatformWin.cmake:
706 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
707 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
708 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
709 * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
710 (TestWebKitAPI::TEST):
712 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
714 Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
715 https://bugs.webkit.org/show_bug.cgi?id=153594
717 Reviewed by Alex Christensen.
719 * Scripts/webkitdirs.pm:
720 (determineNumberOfCPUs):
724 (wrapperPrefixIfNeeded):
725 (cmakeGeneratedBuildfile):
726 (generateBuildSystemFromCMakeProject):
727 * Scripts/webkitperl/features.pm:
728 (libraryContainsSymbol):
730 2016-01-28 Chris Dumez <cdumez@apple.com>
732 Unreviewed, rolling out r195742.
738 "[webkitdirs] Clarify logic behind is{PortName} functions."
739 https://bugs.webkit.org/show_bug.cgi?id=153554
740 http://trac.webkit.org/changeset/195742
742 2016-01-28 Darin Adler <darin@apple.com>
744 Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
745 https://bugs.webkit.org/show_bug.cgi?id=153411
747 Reviewed by Ryosuke Niwa.
749 * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
750 have removed the function instead.
752 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
753 (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
754 added overloads for const char*.
756 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
757 (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
758 (WTR::AccessibilityUIElement::hasPopup): Ditto.
759 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
760 (WTR::testPathFromURL): Ditto.
762 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
764 [webkitdirs] Clarify logic behind is{PortName} functions.
765 https://bugs.webkit.org/show_bug.cgi?id=153554
767 Reviewed by Darin Adler.
769 * Scripts/webkitdirs.pm:
770 (determinePortName): Added new function which decides which port are
771 we building based on command line switches and platform defaults.
772 (portName): Added getter for determined $portName.
773 (isEfl): Modified to use portName().
776 (isAppleMacWebKit): Ditto.
777 (isAppleWinWebKit): Ditto.
778 (isIOSWebKit): Ditto.
779 (cmakeBasedPortName): Code replaced with portName() call.
780 (determineIsEfl): Deleted.
781 (determineIsGtk): Deleted.
782 (determineIsWinCairo): Deleted.
784 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
786 [webkitdirs] Don't pass cmakeBasedPortName around.
787 https://bugs.webkit.org/show_bug.cgi?id=153589
789 Reviewed by Darin Adler.
791 It should be local function of webkitdirs.pm instead.
793 * Scripts/build-jsc: Don't pass cmakeBasedPortName to
794 buildCMakeProjectOrExit().
795 * Scripts/build-webkit: Don't pass cmakeBasedPortName to
796 buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
797 * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
798 generateBuildSystemFromCMakeProject().
799 * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
800 (generateBuildSystemFromCMakeProject): Removed $port argument as we
801 can get it from cmakeBasedPortName().
802 (buildCMakeProjectOrExit): Ditto.
804 2016-01-28 Gwang Yoon Hwang <yoon@igalia.com>
806 [GStreamer] Clean up includes and headers related with GStreamerGL
807 https://bugs.webkit.org/show_bug.cgi?id=153590
809 Reviewed by Philippe Normand.
811 * Scripts/webkitpy/style/checker.py: Skips
812 include_order check for MediaPlayerPrivateGStreamerBase.cpp
813 Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
815 2016-01-27 Krzysztof Czech <k.czech@samsung.com>
817 [EFL] Remove unused accessibility related code
818 https://bugs.webkit.org/show_bug.cgi?id=153543
820 Reviewed by Darin Adler.
822 Removed reference to EAIL library.
823 It not going to be support anymore. There have been changes in
824 EFL/Elementary in terms of the accessibility and we should
827 * efl/jhbuild-optional.modules:
829 2016-01-27 Daniel Bates <dabates@apple.com>
831 Remove WebKitSystemInterface for iOS SDK < 9
832 https://bugs.webkit.org/show_bug.cgi?id=153570
834 Reviewed by Andy Estes.
836 * Scripts/copy-webkitlibraries-to-product-directory:
838 2016-01-27 Jason Marcell <jmarcell@apple.com>
840 Fix bugs caused by incorrect usage of "branch" vs. "branchName".
841 https://bugs.webkit.org/show_bug.cgi?id=153330
843 Reviewed by Daniel Bates.
845 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
846 "branchName" implies that the variable or property in question is simply a string. We fixed some
847 inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
848 spotted in BuildbotQueueView.js.
850 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
851 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
852 Changed branchName to branch.name in call to commitsOnBranch.
853 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
854 _popoverLinesForCommitRange.
855 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
856 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
857 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
860 2016-01-27 Ryosuke Niwa <rniwa@webkit.org>
862 Add API to access closed shadowRoot in InjectedBundle
863 https://bugs.webkit.org/show_bug.cgi?id=153533
865 Reviewed by Antti Koivisto.
867 Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
869 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
871 (TestWebKitAPI::runJavaScriptAlert):
872 (TestWebKitAPI::TEST):
873 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
874 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
875 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
877 2016-01-27 Jason Marcell <jmarcell@apple.com>
879 Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
880 https://bugs.webkit.org/show_bug.cgi?id=153332
882 Reviewed by Alexey Proskuryakov.
884 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
885 (Trac.prototype._xmlTimelineURL): Uses new function.
886 (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
887 logic for parsing git hashes.
888 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
889 Trac._parseRevisionFromURL.
891 2016-01-27 Alexey Proskuryakov <ap@apple.com>
893 Remove Mavericks from the flakiness dashboard
894 https://bugs.webkit.org/show_bug.cgi?id=153521
896 Reviewed by Dan Bernstein.
898 * TestResultServer/static-dashboards/builders.jsonp:
899 * TestResultServer/static-dashboards/flakiness_dashboard.js:
901 2016-01-27 Alexey Proskuryakov <ap@apple.com>
903 Remove ENABLE_CURRENTSRC
904 https://bugs.webkit.org/show_bug.cgi?id=153545
906 Reviewed by Simon Fraser.
908 * Scripts/webkitperl/FeatureList.pm:
910 2016-01-26 Jason Marcell <jmarcell@apple.com>
912 Sort incoming commits via date instead of revision number.
913 https://bugs.webkit.org/show_bug.cgi?id=153467
915 Reviewed by Alexey Proskuryakov.
917 Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
918 for sorting revisions. Instead we use the commit date to sort revisions chronologically.
920 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
921 (Trac.prototype._loaded): Sort via date instead of revision number.
922 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
923 (MockTrac): Fix up the mock data to look more like real-world data.
924 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
925 Fake RSS feed that adds three more commits.
926 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
929 2016-01-26 I-Ting Liu <iting_liu@apple.com>
931 Add a test for WebKit::stringMatchesWildcardString.
932 https://bugs.webkit.org/show_bug.cgi?id=153090
934 Reviewed by Darin Adler.
936 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
937 Add the file to the project.
939 * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
940 (TestWebKitAPI::TEST):
941 Test that a string matches another string that may contain wildcard characters.
943 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
945 [webkitdirs] Removed check for bison, gperf, and flex.
946 https://bugs.webkit.org/show_bug.cgi?id=153496
948 Reviewed by Alex Christensen.
950 This prerequisites are checked in WebKitCommon.cmake and don't
953 * Scripts/webkitdirs.pm:
954 (checkRequiredSystemConfig):
956 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
958 [webkitdirs] isCMakeBuild should be true by default
959 https://bugs.webkit.org/show_bug.cgi?id=153497
961 Reviewed by Michael Catanzaro.
963 * Scripts/webkitdirs.pm:
966 2016-01-26 Daniel Bates <dabates@apple.com>
968 Add WebKitSystemInterface for iOS 9.2
969 https://bugs.webkit.org/show_bug.cgi?id=153355
971 Rubber-stamped by David Kilzer.
973 * Scripts/copy-webkitlibraries-to-product-directory:
975 2016-01-26 Daniel Bates <dabates@apple.com>
977 WebKitTestRunner: Credential cache is not cleared between tests
978 https://bugs.webkit.org/show_bug.cgi?id=153407
979 <rdar://problem/24280834>
981 Reviewed by Alexey Proskuryakov.
983 * WebKitTestRunner/TestController.cpp:
984 (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
985 to clear cached credentials.
987 2016-01-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
989 kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
990 https://bugs.webkit.org/show_bug.cgi?id=153483
992 Reviewed by Csaba Osztrogonác.
994 * BuildSlaveSupport/kill-old-processes:
995 (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
997 2016-01-25 Simon Fraser <simon.fraser@apple.com>
999 Give the layout test results file a <title> showing the date and time the tests were run
1000 https://bugs.webkit.org/show_bug.cgi?id=153187
1002 Reviewed by Darin Adler.
1004 Include a 'date' property in the JSON with the date and time the tests completed.
1006 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1007 (summarize_results):
1009 2016-01-25 Commit Queue <commit-queue@webkit.org>
1011 Unreviewed, rolling out r195543.
1012 https://bugs.webkit.org/show_bug.cgi?id=153451
1014 regressed performance of test bots by ~6% (Requested by dydz
1019 "WebKitTestRunner: Credential cache is not cleared between
1021 https://bugs.webkit.org/show_bug.cgi?id=153407
1022 http://trac.webkit.org/changeset/195543
1024 2016-01-25 Aakash Jain <aakash_jain@apple.com>
1026 Failing to upload to flakiness dashboard should not be a hard error
1027 https://bugs.webkit.org/show_bug.cgi?id=153444
1028 <rdar://problem/22146294>
1030 Reviewed by Alexey Proskuryakov.
1032 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1033 (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
1035 2016-01-25 Daniel Bates <dabates@apple.com>
1037 WebKitTestRunner: Credential cache is not cleared between tests
1038 https://bugs.webkit.org/show_bug.cgi?id=153407
1039 <rdar://problem/24280834>
1041 Reviewed by Brady Eidson.
1043 * WebKitTestRunner/TestController.cpp:
1044 (WTR::TestController::resetStateToConsistentValues): Reset testing network session
1045 to clear cached credentials.
1047 2016-01-24 Dan Bernstein <mitz@apple.com>
1049 Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
1051 * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
1053 2016-01-22 Enrica Casucci <enrica@apple.com>
1055 Unreviewed build fix after http://trac.webkit.org/changeset/195474.
1057 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1058 (WTR::TestController::platformCreateWebView):
1060 2016-01-22 Tim Horton <timothy_horton@apple.com>
1062 Add a test for iOS arrow-key repeat
1063 https://bugs.webkit.org/show_bug.cgi?id=152857
1064 <rdar://problem/24017380>
1066 Reviewed by Darin Adler.
1068 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1069 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1070 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
1071 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
1072 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1073 * WebKitTestRunner/ios/HIDEventGenerator.h:
1074 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1075 (-[HIDEventGenerator keyPress:completionBlock:]):
1076 (-[HIDEventGenerator keyDown:completionBlock:]):
1077 (-[HIDEventGenerator keyUp:completionBlock:]):
1078 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1079 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1080 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
1081 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
1082 Make it possible to independently send keyUp/keyDown, instead of just paired.
1084 2016-01-22 Tim Horton <timothy_horton@apple.com>
1086 Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
1087 https://bugs.webkit.org/show_bug.cgi?id=153193
1088 <rdar://problem/24222034>
1090 Reviewed by Darin Adler.
1092 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1093 (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
1095 Add a test that exhibits the problems we're fixing here.
1096 Before, it would both log and assert in debug, and crash in release.
1097 Now it runs happily to completion.
1099 2016-01-22 Enrica Casucci <enrica@apple.com>
1101 Add support for testing data detection.
1102 https://bugs.webkit.org/show_bug.cgi?id=153360
1104 Reviewed by Tim Horton.
1106 Adding a new testing option (useDataDetection) to turn on
1107 data detection when running the a test.
1109 * WebKitTestRunner/TestController.cpp:
1110 (WTR::updateTestOptionsFromTestHeader):
1111 * WebKitTestRunner/TestOptions.h:
1112 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1113 (WTR::TestController::platformCreateWebView):
1115 2016-01-21 Simon Fraser <simon.fraser@apple.com>
1117 Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
1118 https://bugs.webkit.org/show_bug.cgi?id=153334
1120 Reviewed by Zalan Bujtas.
1122 Evaluating expressions in the LayoutUnit summary provider seems to cause
1123 re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
1126 * lldb/lldb_webkit.py:
1127 (WebCoreLayoutUnitProvider.to_string):
1129 2016-01-21 Filip Pizlo <fpizlo@apple.com>
1131 display-profiler-output should be able to display code blocks sorted by machine counts
1132 https://bugs.webkit.org/show_bug.cgi?id=153298
1134 Reviewed by Oliver Hunt.
1136 * Scripts/display-profiler-output:
1138 2016-01-21 Julien Isorce <j.isorce@samsung.com>
1140 Ensure to use compatible liborc version with wanted gstreamer version
1141 https://bugs.webkit.org/show_bug.cgi?id=153276
1143 For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
1144 The user may have a very recent liborc installed on his system.
1146 Reviewed by Philippe Normand.
1148 * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
1149 * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
1151 2016-01-21 Nan Wang <n_wang@apple.com>
1153 AX: [IOS] Implement next/previous text marker functions using TextIterator
1154 https://bugs.webkit.org/show_bug.cgi?id=153292
1155 <rdar://problem/24268243>
1157 Reviewed by Chris Fleizach.
1159 Made text marker tests available on iOS.
1161 * DumpRenderTree/AccessibilityTextMarker.h:
1162 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1163 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
1164 (AccessibilityTextMarker::AccessibilityTextMarker):
1165 (AccessibilityTextMarker::~AccessibilityTextMarker):
1166 (AccessibilityTextMarker::isEqual):
1167 (AccessibilityTextMarker::platformTextMarker):
1168 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1169 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1170 (AccessibilityTextMarkerRange::isEqual):
1171 (AccessibilityTextMarkerRange::platformTextMarkerRange):
1172 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1173 (AccessibilityUIElement::pathDescription):
1174 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1175 (AccessibilityUIElement::textMarkerRangeForElement):
1176 (AccessibilityUIElement::selectedTextMarkerRange):
1177 (AccessibilityUIElement::resetSelectedTextMarkerRange):
1178 (AccessibilityUIElement::textMarkerRangeLength):
1179 (AccessibilityUIElement::textMarkerRangeForMarkers):
1180 (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1181 (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1182 (AccessibilityUIElement::accessibilityElementForTextMarker):
1183 (AccessibilityUIElement::endTextMarkerForBounds):
1184 (AccessibilityUIElement::startTextMarkerForBounds):
1185 (AccessibilityUIElement::textMarkerForPoint):
1186 (AccessibilityUIElement::previousTextMarker):
1187 (AccessibilityUIElement::nextTextMarker):
1188 (AccessibilityUIElement::stringForTextMarkerRange):
1189 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1190 (AccessibilityUIElement::indexForTextMarker):
1191 (AccessibilityUIElement::isTextMarkerValid):
1192 (AccessibilityUIElement::textMarkerForIndex):
1193 (AccessibilityUIElement::startTextMarker):
1194 (AccessibilityUIElement::endTextMarker):
1195 (AccessibilityUIElement::setSelectedVisibleTextRange):
1196 (AccessibilityUIElement::getLinkedUIElements):
1197 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1198 (AccessibilityTextMarkerRange::platformTextMarkerRange):
1199 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1200 (AccessibilityUIElement::removeSelection):
1201 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1202 (AccessibilityUIElement::setSelectedVisibleTextRange):
1203 (AccessibilityUIElement::supportedActions):
1204 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1205 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1206 (WTR::AccessibilityUIElement::textMarkerRangeLength):
1207 (WTR::AccessibilityUIElement::previousTextMarker):
1208 (WTR::AccessibilityUIElement::nextTextMarker):
1209 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1210 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1211 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1212 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1213 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1214 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1215 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1217 2016-01-20 Filip Pizlo <fpizlo@apple.com>
1219 Unreviewed, revert accidental unreviewed commit.
1221 * Scripts/display-profiler-output:
1223 2016-01-20 Jason Marcell <jmarcell@apple.com>
1225 Refactor compareIterations to remove duplicate code.
1226 https://bugs.webkit.org/show_bug.cgi?id=152913
1228 Reviewed by Daniel Bates.
1230 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1231 (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
1232 (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
1233 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
1234 the same behavior before and after refactor.
1236 2016-01-20 Dana Burkart <dburkart@apple.com>
1238 Botwatcher's dashboard should show an 'X' when the build is broken
1239 https://bugs.webkit.org/show_bug.cgi?id=152507
1241 Reviewed by David Kilzer.
1243 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1244 (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
1245 (BuildbotStaticAnalyzerQueueView.prototype.update):
1247 2016-01-19 Jason Marcell <jmarcell@apple.com>
1249 Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
1250 https://bugs.webkit.org/show_bug.cgi?id=153262
1252 Reviewed by Alexey Proskuryakov.
1254 Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
1255 such cases this revisionContentForIteration method does not have any content to return, thus the
1258 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1259 (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
1261 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
1263 [GTK] Runtime critical warnings when loading a URL after a session restore
1264 https://bugs.webkit.org/show_bug.cgi?id=153233
1266 Reviewed by Michael Catanzaro.
1270 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1272 (testWebKitWebViewNavigationAfterSessionRestore):
1275 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
1277 [GTK] Remove jhbuild-optional.modules
1278 https://bugs.webkit.org/show_bug.cgi?id=152964
1280 Reviewed by Alex Christensen.
1282 * gtk/jhbuild-optional.modules: Removed.
1283 * gtk/jhbuild.modules:
1285 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
1287 [GTK] Add support to load/save session in MiniBrowser
1288 https://bugs.webkit.org/show_bug.cgi?id=153201
1290 Reviewed by Michael Catanzaro.
1292 It makes it easier to test the new WebView session API.
1294 * MiniBrowser/gtk/BrowserWindow.c:
1295 (browserWindowFinalize): Free the session file path.
1296 (browserWindowSaveSession): Save the current WebView session if
1297 there's a session file path.
1298 (browserWindowDeleteEvent): Call browserWindowSaveSession().
1299 (browser_window_load_session): Try to load the session from the
1300 given file path, otherwise fall back to homepage and keep the
1301 session file to save the session on window close.
1302 * MiniBrowser/gtk/BrowserWindow.h:
1303 * MiniBrowser/gtk/main.c:
1304 (createBrowserWindow): Pass the given session file path when
1305 shouldLoadSession is TRUE.
1306 (main): Only allow to restore/save session when MiniBrowser is
1307 launched without URL arguments.
1309 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
1311 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
1313 Geolocation is no longer allowed for unique origins after r195075.
1315 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1316 (testWebViewGeolocationPermissionRequests):
1318 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
1320 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
1321 https://bugs.webkit.org/show_bug.cgi?id=153216
1323 Reviewed by Michael Catanzaro.
1325 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
1326 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
1328 2016-01-18 Nan Wang <n_wang@apple.com>
1330 AX: [Mac] Implement next/previous text marker functions using TextIterator
1331 https://bugs.webkit.org/show_bug.cgi?id=152728
1333 Reviewed by Chris Fleizach.
1335 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1336 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1338 2016-01-18 Csaba Osztrogonác <ossy@webkit.org>
1340 [cmake] Add testair to the build system
1341 https://bugs.webkit.org/show_bug.cgi?id=153126
1343 Reviewed by Michael Catanzaro.
1345 * Scripts/build-jsc:
1347 2016-01-16 Myles C. Maxfield <mmaxfield@apple.com>
1349 Remove TextRun::allowsRoundingHacks()
1350 https://bugs.webkit.org/show_bug.cgi?id=153185
1352 Reviewed by Simon Fraser.
1354 * DumpRenderTree/mac/DumpRenderTree.mm:
1355 (resetWebViewToConsistentStateBeforeTesting): Deleted.
1357 2016-01-15 Konstantin Tokarev <annulen@yandex.ru>
1359 [webkitdirs] Avoid list form of open because it broke WinCairo
1360 https://bugs.webkit.org/show_bug.cgi?id=153106
1362 Reviewed by Alex Christensen.
1364 * Scripts/webkitdirs.pm:
1365 (determineArchitecture):
1367 2016-01-15 Simon Fraser <simon.fraser@apple.com>
1369 Add kdebug_trace signposts for a few WebCore operations
1370 https://bugs.webkit.org/show_bug.cgi?id=153136
1371 rdar://problem/24208487
1373 Reviewed by Sam Weinig.
1375 Plist used by kdebug_trace() viewing tools.
1377 * Tracing/SystemTracePoints.plist: Added.
1379 2016-01-14 Konstantin Tokarev <annulen@yandex.ru>
1381 [webkitdirs] Replaced grep invocation with perl code
1382 https://bugs.webkit.org/show_bug.cgi?id=153106
1384 Reviewed by Alex Christensen.
1386 * Scripts/webkitdirs.pm:
1387 (determineArchitecture):
1389 2016-01-14 Brian Burg <bburg@apple.com>
1391 prepare-changelog does not read paths containing spaces properly
1392 https://bugs.webkit.org/show_bug.cgi?id=137982
1394 Reviewed by Joseph Pecoraro.
1396 Escape whitespace in filenames before passing the file path to other functions.
1398 * Scripts/prepare-ChangeLog:
1399 (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
1401 2016-01-14 Jason Marcell <jmarcell@apple.com>
1403 Standardize the usage of "branch" vs. "branchName".
1404 https://bugs.webkit.org/show_bug.cgi?id=152982
1406 Reviewed by Daniel Bates.
1408 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
1409 "branchName" implies that the variable or property in question is simply a string.
1411 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1412 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
1413 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
1414 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
1415 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1416 (Trac.prototype.commitsOnBranch): Change branch to branchName.
1417 (Trac.prototype._convertCommitInfoElementToObject): Ditto.
1418 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1421 2016-01-14 Jason Marcell <jmarcell@apple.com>
1423 Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
1424 https://bugs.webkit.org/show_bug.cgi?id=152910
1426 Reviewed by Daniel Bates.
1428 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
1429 (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
1430 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
1431 (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
1432 the need to talk to a real Buildbot server.
1433 (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
1434 without the need to talk to a real Buildbot server.
1435 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
1436 (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
1438 (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
1439 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
1440 (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
1441 trying to talk to Trac.
1442 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
1444 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
1446 2016-01-14 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
1448 [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
1449 https://bugs.webkit.org/show_bug.cgi?id=132599
1451 Reviewed by Michael Catanzaro.
1453 Check if cmake Ninja generators are installed.
1455 * Scripts/webkitdirs.pm:
1456 (canUseNinjaGenerator):
1457 (canUseEclipseNinjaGenerator):
1458 (generateBuildSystemFromCMakeProject):
1459 (canUseEclipse): Deleted.
1461 2016-01-13 Myles C. Maxfield <mmaxfield@apple.com>
1463 [Cocoa] Testing with font family name "System Font" is unused
1464 https://bugs.webkit.org/show_bug.cgi?id=153073
1465 <rdar://problem/24091683>
1467 Reviewed by Brent Fulgham.
1469 * DumpRenderTree/mac/DumpRenderTree.mm:
1470 (allowedFontFamilySet): Deleted.
1471 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1472 (WTR::allowedFontFamilySet): Deleted.
1473 * WebKitTestRunner/mac/TestControllerMac.mm:
1474 (WTR::allowedFontFamilySet): Deleted.
1476 2016-01-13 Daniel Bates <dabates@apple.com>
1478 [XSS Auditor] Add test when XSS payload is in the path portion of the URL
1479 https://bugs.webkit.org/show_bug.cgi?id=152871
1481 Reviewed by Brent Fulgham.
1483 Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
1484 <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
1486 * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
1488 2016-01-08 Andy Estes <aestes@apple.com>
1490 [Content Filtering] Lazily load platform frameworks
1491 https://bugs.webkit.org/show_bug.cgi?id=152881
1492 rdar://problem/23270886
1494 Reviewed by Brady Eidson.
1496 Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
1497 expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
1498 loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
1499 and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
1500 is loaded after an HTTPS request.
1502 To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
1503 Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
1504 WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
1505 also re-enabled on iOS after mistakenly being disabled by r188892.
1507 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1508 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1509 (TestWebKitAPI::TEST):
1510 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
1511 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
1512 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1515 (-[LazilyLoadPlatformFrameworksController init]):
1516 (-[LazilyLoadPlatformFrameworksController webView]):
1517 (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
1518 (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
1519 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1520 (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1521 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
1522 (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
1523 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1524 (TestWebKitAPI::TEST):
1525 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1526 (TestWebKitAPI::TEST): Deleted.
1527 * TestWebKitAPI/cocoa/TestProtocol.h:
1528 * TestWebKitAPI/cocoa/TestProtocol.mm:
1529 (+[TestProtocol registerWithScheme:]):
1530 (+[TestProtocol unregister]):
1532 2016-01-12 Dewei Zhu <dewei_zhu@apple.com>
1534 Fix the Sunpider converage in slow device.
1535 https://bugs.webkit.org/show_bug.cgi?id=152938
1536 <rdar://problem/22511411>
1538 Reviewed by Ryosuke Niwa.
1540 Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
1542 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
1544 2016-01-12 Ryosuke Niwa <rniwa@webkit.org>
1546 Add a build flag for custom element
1547 https://bugs.webkit.org/show_bug.cgi?id=153005
1549 Reviewed by Alex Christensen.
1551 Added --custom-elements option to enable custom elements support.
1553 * Scripts/webkitperl/FeatureList.pm:
1555 2016-01-12 Benjamin Poulain <bpoulain@apple.com>
1557 [JSC] Add a help message when run-jsc-stress-tests fails
1558 https://bugs.webkit.org/show_bug.cgi?id=153014
1560 Reviewed by Csaba Osztrogonác.
1562 * Scripts/run-jsc-stress-tests:
1564 2016-01-11 Saam barati <sbarati@apple.com>
1566 run-jsc-stress-tests should try to figure out a JSC path
1567 https://bugs.webkit.org/show_bug.cgi?id=152971
1569 Reviewed by Yusuke Suzuki.
1571 This patch now allows run-jsc-stress-tests to be run
1572 without a "--jsc <jsc-path>" argument. It tries
1573 to take its best guess at a <jsc-path> automagically.
1575 This makes it much easier to just run run-jsc-stress-tests
1576 with a directory or a yaml file as an argument.
1577 You now just do this:
1578 `run-jsc-stress-tests <path-to-yaml>`
1580 `run-jsc-stress-tests <path-to-directory-of-js-files>`
1582 I wrote this patch because I'd often find myself hacking the
1583 run-javascriptcore-tests file just to run a particular subset of tests.
1584 Because I always forget the arguments to run-jsc-stress-tests (which means
1585 I always forgot to provide a --jsc argument), I always found it easier to
1586 just hack on that file instead of calling run-jsc-stress-tests directly.
1587 No longer is this true!
1589 * Scripts/run-jsc-stress-tests:
1591 2016-01-09 Andy Estes <aestes@apple.com>
1593 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1594 https://bugs.webkit.org/show_bug.cgi?id=152950
1595 rdar://problem/24066652
1597 Reviewed by Tim Horton.
1601 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1602 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1603 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1604 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1605 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1606 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1607 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1608 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1611 2016-01-11 Commit Queue <commit-queue@webkit.org>
1613 Unreviewed, rolling out r194866.
1614 https://bugs.webkit.org/show_bug.cgi?id=152986
1616 This change broke the mac build (Requested by ryanhaddad on
1621 "[Cocoa] Add SPI to opt out a URL scheme from the memory
1623 https://bugs.webkit.org/show_bug.cgi?id=152950
1624 http://trac.webkit.org/changeset/194866
1626 2016-01-11 Andy Estes <aestes@apple.com>
1628 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1629 https://bugs.webkit.org/show_bug.cgi?id=152950
1630 rdar://problem/24066652
1632 Reviewed by Tim Horton.
1636 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1637 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1638 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1639 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1640 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1641 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1642 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1643 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1646 2016-01-11 Konstantin Tokarev <annulen@yandex.ru>
1648 [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
1649 https://bugs.webkit.org/show_bug.cgi?id=152959
1651 Reviewed by Brent Fulgham.
1653 * Scripts/webkitdirs.pm:
1654 (determineArchitecture):
1656 2016-01-11 Michael Catanzaro <mcatanzaro@igalia.com>
1658 [GTK] W3C CSS2.1 anonymous table tests are failing
1659 https://bugs.webkit.org/show_bug.cgi?id=152455
1661 Reviewed by Mario Sanchez Prada.
1663 Add shared-mime-info to the jhbuild environment, since it affects the results of layout
1664 tests. Add upstream patches to fix detection of XHTML files.
1666 * gtk/jhbuild.modules:
1667 * gtk/patches/shared-mime-info-xht-glob.patch: Added.
1668 * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
1670 2016-01-10 Saam barati <sbarati@apple.com>
1672 Implement a sampling profiler
1673 https://bugs.webkit.org/show_bug.cgi?id=151713
1675 Reviewed by Filip Pizlo.
1677 * Scripts/run-jsc-stress-tests:
1679 2016-01-10 Konstantin Tokarev <annulen@yandex.ru>
1681 [webkitdirs] Try arch and uname commands on non-windows OS
1682 https://bugs.webkit.org/show_bug.cgi?id=152958
1684 Reviewed by Michael Catanzaro.
1686 Right now, determineArchitecture() uses `arch` and `uname -m`
1687 commands to determine architecture in case of condition (isGtk() ||
1688 isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
1689 instead, because this code is applicable to any non-windows OS WebKit
1690 supports (even Haiku which once was supported is moderately
1691 POSIX-compliant and has uname command).
1693 * Scripts/webkitdirs.pm:
1694 (determineArchitecture):
1696 2016-01-08 Aakash Jain <aakash_jain@apple.com>
1698 run-webkit-tests mis-counts totals when there are other crashes
1699 https://bugs.webkit.org/show_bug.cgi?id=152894
1700 <rdar://problem/24098697>
1702 Reviewed by Alexey Proskuryakov.
1704 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1705 (TestRunResults.add): Do not update result counters for other crashes.
1707 2016-01-08 Youenn Fablet <youenn.fablet@crf.canon.fr>
1709 webkit-patch build-and-test should have an option to iterate over new tests
1710 https://bugs.webkit.org/show_bug.cgi?id=143093
1712 Reviewed by Michael Catanzaro.
1714 This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
1715 It allows running run-webkit-tests on modified or new paths in LayoutTests.
1716 Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
1717 It implements the translation of -expected.* paths to their related tests.
1718 It also implements the removal of skipped tests.
1720 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1721 (LayoutTestFinder.find_touched_tests):
1722 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
1724 (MockPort.__init__):
1726 (LayoutTestFinderTests):
1727 (LayoutTestFinderTests.touched_files):
1728 (LayoutTestFinderTests.test_touched_test):
1729 (LayoutTestFinderTests.test_expected_touched_test):
1730 (LayoutTestFinderTests.test_platform_expected_touched_test):
1731 (LayoutTestFinderTests.test_platform_duplicate_touched_test):
1732 (LayoutTestFinderTests.test_touched_but_skipped_test):
1733 * Scripts/webkitpy/port/base.py:
1734 (Port.potential_test_names_from_expected_file):
1735 * Scripts/webkitpy/tool/commands/download_unittest.py:
1736 (DownloadCommandsTest._default_options):
1737 * Scripts/webkitpy/tool/steps/options.py:
1739 * Scripts/webkitpy/tool/steps/runtests.py:
1743 (RunTests._new_or_modified_tests):
1744 (RunTests._run_webkit_tests):
1745 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1746 (RunTestsTest.test_webkit_run_unit_tests):
1747 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1748 (StepsTest._step_options):
1750 2016-01-07 Joseph Pecoraro <pecoraro@apple.com>
1752 prepare-ChangeLog should include radar number
1753 https://bugs.webkit.org/show_bug.cgi?id=152839
1754 <rdar://problem/24093563>
1756 Reviewed by Daniel Bates.
1758 When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
1759 starts with a "<rdar://problem/####>" URL. If found, include that radar URL
1760 in the ChangeLog description after the bug URL.
1762 * Scripts/prepare-ChangeLog:
1763 (main): Update signatures.
1764 (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
1765 (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
1766 (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
1767 (generateNewChangeLogs): Include radar URL if we found one.
1769 * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
1770 Tests for the radar URL extraction.
1772 2016-01-07 Alexey Proskuryakov <ap@apple.com>
1774 testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
1775 https://bugs.webkit.org/show_bug.cgi?id=152390
1776 <rdar://problem/23948321>
1778 Reviewed by Simon Fraser.
1780 Fix two use-after-frees.
1782 1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
1783 but we may have already progressed to another test by the time the callback fires,
1784 having destroyed the TestInvocation.
1785 2. UIScriptController is a RefCounted object, but it has a raw pointer to
1786 UIScriptContext which has the same lifetime as a TestInvocation.
1787 As a result, completion blocks of UIScriptController actions would use a destroyed
1790 * WebKitTestRunner/TestInvocation.cpp:
1791 (WTR::TestInvocation::~TestInvocation):
1792 (WTR::TestInvocation::url):
1793 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1794 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1795 (WTR::TestInvocation::runUISideScript):
1796 * WebKitTestRunner/TestInvocation.h:
1797 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1798 (UIScriptContext::UIScriptContext):
1799 (UIScriptContext::~UIScriptContext):
1800 (UIScriptContext::runUIScript):
1801 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1802 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1803 (WTR::UIScriptController::UIScriptController):
1804 (WTR::UIScriptController::contextDestroyed):
1805 (WTR::UIScriptController::makeWindowObject):
1806 (WTR::UIScriptController::setWillBeginZoomingCallback):
1807 (WTR::UIScriptController::willBeginZoomingCallback):
1808 (WTR::UIScriptController::setDidEndZoomingCallback):
1809 (WTR::UIScriptController::didEndZoomingCallback):
1810 (WTR::UIScriptController::setDidEndScrollingCallback):
1811 (WTR::UIScriptController::didEndScrollingCallback):
1812 (WTR::UIScriptController::setDidShowKeyboardCallback):
1813 (WTR::UIScriptController::didShowKeyboardCallback):
1814 (WTR::UIScriptController::setDidHideKeyboardCallback):
1815 (WTR::UIScriptController::didHideKeyboardCallback):
1816 (WTR::UIScriptController::uiScriptComplete):
1817 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1818 (WTR::UIScriptController::create):
1819 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1820 (WTR::UIScriptController::doAsyncTask):
1821 (WTR::UIScriptController::zoomToScale):
1822 (WTR::UIScriptController::singleTapAtPoint):
1823 (WTR::UIScriptController::doubleTapAtPoint):
1824 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1825 (WTR::UIScriptController::contentVisibleRect):
1826 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1827 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1828 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1829 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1830 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
1831 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1832 (WTR::UIScriptController::doAsyncTask):
1834 2016-01-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
1836 [buildbot] clean-build script should remove untracked files and revert local changes too
1837 https://bugs.webkit.org/show_bug.cgi?id=142400
1839 Reviewed by Ryosuke Niwa.
1841 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1842 A helper routine SCM.discard_untracked_files is added for that purpose.
1844 * BuildSlaveSupport/clean-build:
1845 (main): Making call to Scripts/clean-webkit
1846 * Scripts/clean-webkit: Added.
1847 (main): Revert changes and delete untracked files.
1848 * Scripts/webkitpy/common/checkout/scm/scm.py:
1849 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1850 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1851 (SCMTest._shared_test_discard_untracked_files):
1852 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1854 2016-01-06 Simon Fraser <simon.fraser@apple.com>
1856 Add a setting and preferences to enable display-list drawing. Does nothing yet.
1857 https://bugs.webkit.org/show_bug.cgi?id=152807
1859 Reviewed by Zalan Bujtas.
1861 Add an item to the Settings menu to toggle display-list drawing.
1863 * MiniBrowser/mac/SettingsController.h:
1864 * MiniBrowser/mac/SettingsController.m:
1865 (-[SettingsController _populateMenu]):
1866 (-[SettingsController validateMenuItem:]):
1867 (-[SettingsController toggleDisplayListDrawingEnabled:]):
1868 (-[SettingsController displayListDrawingEnabled]):
1869 * MiniBrowser/mac/WK2BrowserWindowController.m:
1870 (-[WK2BrowserWindowController didChangeSettings]):
1872 2016-01-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
1874 Python SCM should be able to retrieve untracked files - Add GIT support
1875 https://bugs.webkit.org/show_bug.cgi?id=143135
1877 Reviewed by Michael Catanzaro.
1879 * Scripts/webkitpy/common/checkout/scm/git.py:
1880 (Git.untracked_files): Adding support for git.
1881 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1883 (GitTest.test_untracked_files): Adding test.
1885 2016-01-05 Mark Lam <mark.lam@apple.com>
1887 Rename badly named JSC_timeout env var to JSCTEST_timeout.
1888 https://bugs.webkit.org/show_bug.cgi?id=152748
1890 Reviewed by Geoffrey Garen.
1892 Now that we validate JSC options, the badly named JSC_timeout env var causes the
1893 bots to have a bad time.
1895 * Scripts/run-javascriptcore-tests:
1896 * Scripts/run-jsc-stress-tests:
1898 2016-01-04 Carlos Garcia Campos <cgarcia@igalia.com>
1900 [GTK] Allow to save and restore session
1901 https://bugs.webkit.org/show_bug.cgi?id=115600
1903 Reviewed by Michael Catanzaro.
1905 Add test case to check the new session API.
1907 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1908 (testWebKitWebViewSessionState):
1909 (testWebKitWebViewSessionStateWithFormData):
1912 2016-01-04 Csaba Osztrogonác <ossy@webkit.org>
1914 [EFL] Bump EFL version to 1.16.1
1915 https://bugs.webkit.org/show_bug.cgi?id=152688
1917 Reviewed by Gyuyoung Kim.
1919 * efl/jhbuild.modules:
1921 2016-01-04 Aakash Jain <aakash_jain@apple.com>
1923 error running layout tests on iOS simulator on latest build
1924 https://bugs.webkit.org/show_bug.cgi?id=152719
1925 <rdar://problem/24009549>
1927 Reviewed by Alexey Proskuryakov.
1929 * Scripts/webkitpy/xcode/simulator.py:
1930 (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1931 before running simctl spawn command.
1933 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
1935 Unreviewed, move Frédéric Wang to committers list
1937 He seems to be on the contributors list by accident. He has been landing his own commits for
1938 about two years now.
1940 * Scripts/webkitpy/common/config/contributors.json:
1942 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
1944 Unreviewed, move Sebastian Dröge to committers list harder
1946 He accidentally added himself to the reviewers list because the file is confusing. Then I
1947 accidentially moved him to the contributors list because the file is confusing, even though
1948 I knew the contributors list existed in this file and was attempting to add him to the
1949 committers list. Really move him to the committers list now.
1951 * Scripts/webkitpy/common/config/contributors.json:
1953 2016-01-02 Youenn Fablet <youenn.fablet@crf.canon.fr>
1955 Python SCM should be able to retrieve untracked files - Add SVN support
1956 https://bugs.webkit.org/show_bug.cgi?id=152546
1958 Reviewed by Michael Catanzaro.
1960 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1961 (test_untracked_files): Activating test for SVN.
1962 * Scripts/webkitpy/common/checkout/scm/svn.py:
1963 (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1965 2015-12-31 Andy Estes <aestes@apple.com>
1967 Replace WTF::move with WTFMove
1968 https://bugs.webkit.org/show_bug.cgi?id=152601
1970 Reviewed by Brady Eidson.
1972 * DumpRenderTree/TestRunner.h:
1973 (TestRunner::setAllowedHosts):
1974 * DumpRenderTree/win/DRTDataObject.cpp:
1975 (DRTDataObject::SetData):
1976 * TestWebKitAPI/Tests/WTF/Deque.cpp:
1977 (TestWebKitAPI::TEST):
1978 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1979 (TestWebKitAPI::TEST):
1980 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1981 (TestWebKitAPI::TEST):
1982 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1983 (TestWebKitAPI::TEST):
1984 * TestWebKitAPI/Tests/WTF/Ref.cpp:
1985 (TestWebKitAPI::passWithRef):
1986 (TestWebKitAPI::TEST):
1987 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1988 (TestWebKitAPI::TEST):
1989 * TestWebKitAPI/Tests/WTF/Vector.cpp:
1990 (TestWebKitAPI::TEST):
1991 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1992 (TestWebKitAPI::TEST):
1993 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1994 (TestWebKitAPI::TEST):
1995 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1996 (TestWebKitAPI::createTestValue):
1997 (TestWebKitAPI::TEST):
1998 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1999 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2000 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2001 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2002 (TestWebKitAPI::createNFAs):
2003 (TestWebKitAPI::TEST_F):
2004 * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
2005 (TestWebKitAPI::combine):
2006 * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
2007 (TestWebKitAPI::createNFAs):
2008 * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
2010 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2011 (WebProcessTest::add):
2013 2016-01-01 Michael Catanzaro <mcatanzaro@igalia.com>
2015 [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
2016 https://bugs.webkit.org/show_bug.cgi?id=152634
2018 Reviewed by Carlos Garcia Campos.
2020 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2021 (testLoadFromGResource): Added test.
2023 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2024 (registerGResource): Added.
2025 (webkit_web_extension_initialize_with_user_data): Load the test gresource.
2026 * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
2027 * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
2029 2015-12-31 David Kilzer <ddkilzer@apple.com>
2031 REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
2032 <https://bugs.webkit.org/show_bug.cgi?id=152601>
2034 Ignore unknown pragmas on older clangs. Fixes the following
2037 Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
2038 #pragma clang diagnostic ignored "-Wself-move"
2042 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2043 (TestWebKitAPI::TEST):
2044 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2045 (TestWebKitAPI::TEST):
2047 2015-12-31 Andy Estes <aestes@apple.com>
2049 Update the style checker to advise using WTFMove() instead of WTF::move()
2050 https://bugs.webkit.org/show_bug.cgi?id=152601
2052 Reviewed by Daniel Bates.
2054 * Scripts/webkitpy/style/checkers/cpp.py:
2056 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2057 (WebKitStyleTest.test_wtf_move):
2059 2015-12-31 Andy Estes <aestes@apple.com>
2061 Fix warnings uncovered by migrating to WTF_MOVE
2062 https://bugs.webkit.org/show_bug.cgi?id=152601
2064 Reviewed by Daniel Bates.
2066 Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
2067 self-move, even if doing so would trigger a warning.
2069 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2070 (TestWebKitAPI::TEST):
2071 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2072 (TestWebKitAPI::TEST):
2074 2015-12-31 Martin Robinson <mrobinson@igalia.com>
2076 [GTK] The install-dependencies script has a syntax error
2077 https://bugs.webkit.org/show_bug.cgi?id=152613
2079 Reviewed by Michael Catanzaro.
2081 * gtk/install-dependencies: Add the missing 'then.'
2083 2015-12-30 Philippe Normand <pnormand@igalia.com>
2085 [Mac][GTK] Jhbuild support for OSX
2086 https://bugs.webkit.org/show_bug.cgi?id=150799
2088 Reviewed by Michael Catanzaro.
2090 * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
2091 * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
2092 * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
2093 * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
2095 2015-12-28 Michael Catanzaro <mcatanzaro@igalia.com>
2097 Unreviewed, move Sebastian Dröge to committers list
2099 He accidentally added himself to the reviewers list because the file is confusing.
2101 * Scripts/webkitpy/common/config/contributors.json:
2103 2015-12-24 Simon Fraser <simon.fraser@apple.com>
2105 Remove the unused #define _USE_MATH_DEFINES
2106 https://bugs.webkit.org/show_bug.cgi?id=152034
2108 Reviewed by Tim Horton.
2110 Update this test to use piDouble from MathExtras.h, and
2111 std::numeric_limits<>.
2113 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2115 2015-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
2117 Python SCM should be able to retrieve untracked files - Generic changes
2118 https://bugs.webkit.org/show_bug.cgi?id=152536
2120 Reviewed by Brent Fulgham.
2122 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2123 No support is yet added to GIT and SVN specific implementations.
2125 * Scripts/webkitpy/common/checkout/scm/scm.py:
2126 (SCM.untracked_files):
2127 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2128 (SCMTest._shared_test_untracked_files):
2130 2015-12-23 Dewei Zhu <dewei_zhu@apple.com>
2132 SVN checkout used by RunBenchmark should be non-interactive
2133 https://bugs.webkit.org/show_bug.cgi?id=152542
2135 Reviewed by Ryosuke Niwa.
2137 RunBenchmark should not require user interaction while running.
2139 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2140 (BenchmarkBuilder._checkout_with_subversion):
2142 2015-12-23 Brent Fulgham <bfulgham@apple.com>
2144 Web Inspector: add support for running protocol-test.js tests on Windows
2145 https://bugs.webkit.org/show_bug.cgi?id=148037
2146 <rdar://problem/22292237>
2148 Reviewed by Simon Fraser.
2150 * DumpRenderTree/win/TestRunnerWin.cpp:
2151 (TestRunner::inspectorTestStubURL): Provide implementation.
2153 2015-12-23 Eric Carlson <eric.carlson@apple.com>
2155 [MediaStream] MediaDeviceInfo.label must be empty in some situations
2156 https://bugs.webkit.org/show_bug.cgi?id=152000
2158 Reviewed by Brent Fulgham.
2160 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2161 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2162 (WTR::InjectedBundle::setUserMediaPermission):
2163 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
2164 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2166 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2167 (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
2168 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2170 * WebKitTestRunner/TestController.cpp:
2171 (WTR::TestController::setUserMediaPermissionForOrigin):
2172 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
2173 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
2174 persistent permission for origin, that can be done from script now.
2175 * WebKitTestRunner/TestController.h:
2177 * WebKitTestRunner/TestInvocation.cpp:
2178 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
2179 SetUserMediaPermissionForOrigin.
2181 2015-12-23 Brent Fulgham <bfulgham@apple.com>
2183 [Win] Unreviewed build fix: Recognize Windows 10 variants.
2185 * Scripts/webkitpy/common/system/platforminfo.py:
2186 (PlatformInfo._determine_win_version):
2188 2015-12-23 Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
2190 Content blockers should be able to promote http to https
2191 https://bugs.webkit.org/show_bug.cgi?id=148966
2193 Reviewed by Benjamin Poulain.
2195 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2196 (WebCore::ContentExtensions::operator<<):
2197 (TestWebKitAPI::TEST_F):
2199 2015-12-22 Hunseop Jeong <hs85.jeong@samsung.com>
2201 [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
2202 https://bugs.webkit.org/show_bug.cgi?id=152516
2204 Reviewed by Gyuyoung Kim.
2206 * MiniBrowser/efl/main.c:
2208 2015-12-22 Brent Fulgham <bfulgham@apple.com>
2210 Unreviewed: Add John Wilander as a contributor.
2212 * Scripts/webkitpy/common/config/contributors.json:
2214 2015-12-22 Chris Fleizach <cfleizach@apple.com>
2216 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
2217 https://bugs.webkit.org/show_bug.cgi?id=152482
2219 Reviewed by Brent Fulgham.
2221 vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
2222 for the same property. On WK2, the element returned will not be valid, but is still present and
2223 that can lead to looping.
2225 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2226 (AccessibilityUIElement::horizontalScrollbar):
2227 (AccessibilityUIElement::verticalScrollbar):
2228 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2229 (WTR::AccessibilityUIElement::horizontalScrollbar):
2230 (WTR::AccessibilityUIElement::verticalScrollbar):
2232 2015-12-22 Xabier Rodriguez Calvar <calvaris@igalia.com>
2236 * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
2238 2015-12-21 Hunseop Jeong <hs85.jeong@samsung.com>
2240 [EFL] test_ewk2_context failed after r192808
2241 https://bugs.webkit.org/show_bug.cgi?id=151846
2243 Reviewed by Gyuyoung Kim.
2245 Used the added ewk_context_web_process_count_limit_set api
2246 instead of the deprecated ewk_context_process_model_set.
2248 * MiniBrowser/efl/main.c:
2251 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
2253 Unreviewed, move myself to reviewer list.
2255 * Scripts/webkitpy/common/config/contributors.json:
2257 2015-12-21 Aakash Jain <aakash_jain@apple.com>
2259 Unreviewed, add myself to the committers list.
2261 * Scripts/webkitpy/common/config/contributors.json:
2263 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
2265 [GTK] jquery.min.js violates DFSG
2266 https://bugs.webkit.org/show_bug.cgi?id=152428
2268 Reviewed by Joseph Pecoraro.
2270 Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
2271 into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
2273 * gtk/manifest.txt.in:
2275 2015-12-19 Dan Bernstein <mitz@apple.com>
2277 [Mac] WebKit contains dead source code for OS X Mavericks and earlier
2278 https://bugs.webkit.org/show_bug.cgi?id=152462
2280 Reviewed by Alexey Proskuryakov.
2282 - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
2285 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2286 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2287 * MiniBrowser/Configurations/DebugRelease.xcconfig:
2288 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2289 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2291 - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
2292 never getting compiled:
2294 * DumpRenderTree/mac/TextInputController.m:
2295 * MiniBrowser/mac/BrowserWindowController.m:
2296 * TestWebKitAPI/Tests/mac/AttributedString.mm:
2297 * WebKitTestRunner/mac/EventSenderProxy.mm:
2299 2015-12-18 Michael Catanzaro <mcatanzaro@igalia.com>
2301 Unreviewed, add WebKitGTK+ Bugzilla email to committers list
2303 This is to make it easy to CC it on Bugzilla.
2305 * Scripts/webkitpy/common/config/contributors.json:
2307 2015-12-18 Aakash Jain <aakash_jain@apple.com>
2309 Pasteboard get messed up after running kill-old-processes
2310 https://bugs.webkit.org/show_bug.cgi?id=152426
2312 Reviewed by Alexey Proskuryakov.
2314 * BuildSlaveSupport/kill-old-processes:
2315 (main): Do not kill pasteboard anymore.
2317 2015-12-17 Aakash Jain <aakash_jain@apple.com>
2319 run-webkit-tests shouldn't start multiple iOS simulators while only running one test
2320 https://bugs.webkit.org/show_bug.cgi?id=152157
2321 <rdar://problem/23851817>
2323 Reviewed by Alexey Proskuryakov.
2325 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2326 (LayoutTestRunner.get_worker_count): Calculate required number of workers.
2327 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2328 (Manager._get_test_inputs): Common method to calculate test_inputs.
2329 (Manager._update_worker_count): Calculate and update required number of workers.
2331 2015-12-16 Aakash Jain <aakash_jain@apple.com>
2333 run-webkit-tests fails to delete Simulator device during cleanup
2334 https://bugs.webkit.org/show_bug.cgi?id=152363
2336 Reviewed by Alexey Proskuryakov.
2338 * Scripts/webkitpy/xcode/simulator.py:
2339 (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
2341 2015-12-16 Tim Horton <timothy_horton@apple.com>
2343 [mac-wk2] fast/events force click tests crashing
2344 https://bugs.webkit.org/show_bug.cgi?id=152339
2346 Reviewed by Beth Dakin.
2348 * WebKitTestRunner/mac/EventSenderProxy.mm:
2349 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2350 Set the NSEvent's _type member in addition to overriding -type,
2351 because there are assertions in touch event handling code that depend on it.
2353 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
2355 Enforce temporarily bots to sync WebKit and WPT testharness.js
2356 https://bugs.webkit.org/show_bug.cgi?id=152334
2358 Reviewed by Darin Adler.
2360 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2361 (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
2363 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
2365 [Fetch API] Add fetch API compile time flag
2366 https://bugs.webkit.org/show_bug.cgi?id=152254
2368 Reviewed by Darin Adler.
2370 * Scripts/webkitperl/FeatureList.pm:
2372 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
2376 Added files that have impact in building Streams API to the watchlist.
2378 * Scripts/webkitpy/common/config/watchlist:
2380 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
2384 Added imported tests to Streams API watchlist.
2386 * Scripts/webkitpy/common/config/watchlist:
2388 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
2390 Remove default copy of wpt testharness.js when launching wpt server
2391 https://bugs.webkit.org/show_bug.cgi?id=152298
2393 Reviewed by Darin Adler.
2395 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2396 (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
2398 2015-12-15 David Kilzer <ddkilzer@apple.com>
2400 REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
2401 <http://webkit.org/b/152314>
2403 Reviewed by Daniel Bates.
2405 The change to DumpRenderTreeMain.mm in r192375 caused the iOS
2406 code path to exit immediately when calling main().
2407 Unfortunately, DumpRenderTreeMain.mm was used for both
2408 DumpRenderTree command-line binary and DumpRenderTree.app, which
2409 meant that the app would exit immediately with no error code
2412 The workaround is to introduce a separate source file called
2413 DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
2416 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
2417 DumpRenderTreeAppMain.mm to the project. Make it the only
2418 compiled source for the DumpRenderTree.app target.
2419 * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
2420 (main): Call DumpRenderTreeMain() on iOS. Assert on OS X in
2421 case someone tries mistakenly to use the app.
2422 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2423 Link to JavaScriptCore.framework on iOS for the assert.
2424 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2425 Link to JavaScriptCore.framework on OS X for the assert. Remove
2426 unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
2427 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
2428 (main): Add assert for iOS so that a crash occurs if someone
2429 tries to run the wrong command.
2431 2015-12-14 Tim Horton <timothy_horton@apple.com>
2433 Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
2434 https://bugs.webkit.org/show_bug.cgi?id=152266
2435 <rdar://problem/22092676>
2437 Reviewed by Simon Fraser.
2439 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2440 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
2441 Add a test that crashed before this change, and doesn't crash after.
2443 2015-12-14 Chris Fleizach <cfleizach@apple.com>
2445 AX: iOS: Text field variations do not have the correct traits
2446 https://bugs.webkit.org/show_bug.cgi?id=152237
2448 Reviewed by Mario Sanchez Prada.
2450 Add iOS calls for determing if an object is a search field or a text area.
2452 * DumpRenderTree/AccessibilityUIElement.cpp:
2453 (getIsSearchFieldCallback):
2454 (getIsTextAreaCallback):
2455 (stringForSelectionCallback):
2456 (AccessibilityUIElement::getJSClass):
2457 * DumpRenderTree/AccessibilityUIElement.h:
2458 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2459 (AccessibilityUIElement::identifier):
2460 (AccessibilityUIElement::isTextArea):
2461 (AccessibilityUIElement::isSearchField):
2462 (AccessibilityUIElement::traits):
2463 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2464 (WTR::AccessibilityUIElement::scrollPageRight):
2465 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
2466 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2467 (WTR::AccessibilityUIElement::isSearchField):
2468 (WTR::AccessibilityUIElement::isTextArea):
2469 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2470 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2471 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2472 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2473 (WTR::AccessibilityUIElement::isTextArea):
2474 (WTR::AccessibilityUIElement::isSearchField):
2475 (WTR::AccessibilityUIElement::rowCount):
2477 2015-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
2479 [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
2480 https://bugs.webkit.org/show_bug.cgi?id=152252
2482 Reviewed by Sergio Villar Senin.
2484 * gtk/install-dependencies: Add libtool-bin to the list of packages required
2485 for building the JHBuild on Debian systems.
2487 2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
2489 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
2490 https://bugs.webkit.org/show_bug.cgi?id=152156
2492 Reviewed by Dan Bernstein.
2494 Our frameworks should appropriately prefix all ObjC classes,
2495 not just external symbols.
2497 * Scripts/check-for-inappropriate-objc-class-names:
2498 Remove the -g switch to check all ObjC class names.
2500 2015-12-10 Eric Carlson <eric.carlson@apple.com>
2502 [MediaStream] Expose media capture devices persistent permissions to WebCore
2503 https://bugs.webkit.org/show_bug.cgi?id=152087
2505 Add support for the new user media permission checker page UI client method.
2507 Reviewed by Chris Dumez.
2509 * WebKitTestRunner/TestController.cpp:
2510 (WTR::decidePolicyForUserMediaPermissionRequest):
2511 (WTR::checkUserMediaPermissionForOrigin):
2512 (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
2513 (WTR::TestController::createWebViewWithOptions): Ditto.
2514 (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
2515 (WTR::originUserVisibleName): New, create a string for the origin.
2516 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
2517 according to the state of the origin permission map.
2518 (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
2519 request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
2520 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
2521 origin permission map.
2522 * WebKitTestRunner/TestController.h:
2524 2015-12-10 Alex Christensen <achristensen@webkit.org>
2526 REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
2527 https://bugs.webkit.org/show_bug.cgi?id=152022
2528 rdar://problem/23763584
2530 Reviewed by Darin Adler.
2532 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2533 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2534 (WTR::InjectedBundlePage::willSendRequestForFrame):
2535 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2536 (WTR::TestRunner::setWillSendRequestReturnsNull):
2537 (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
2538 (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2539 (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
2540 (WTR::TestRunner::willSendRequestHTTPBody):
2541 Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
2543 2015-12-10 Aakash Jain <aakash_jain@apple.com>
2545 Remove additional simulator checks before running layout-tests
2546 https://bugs.webkit.org/show_bug.cgi?id=152146
2548 Reviewed by Darin Adler.
2550 * Scripts/webkitpy/port/ios.py:
2551 (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
2552 * Scripts/webkitpy/xcode/simulator.py:
2553 (Simulator._boot_and_shutdown_simulator_device): Deleted.
2554 (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
2556 2015-12-09 Aakash Jain <aakash_jain@apple.com>
2558 Run atleast one simulator even if max process limit is low
2559 https://bugs.webkit.org/show_bug.cgi?id=152081
2560 <rdar://problem/23819694>
2562 Reviewed by Alexey Proskuryakov.
2564 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
2566 [GTK] Crash in WebProcess when loading large content with custom URI schemes
2567 https://bugs.webkit.org/show_bug.cgi?id=144262
2569 Reviewed by Carlos Garcia Campos.
2571 Added new unit test to check the additional scenarios we now
2572 handle for custom URI schemes.
2574 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2575 (generateHTMLContent): New helper function to generate big enough content.
2576 (testWebContextURIScheme): New unit test.
2578 2015-12-09 Ryuan Choi <ryuan.choi@navercorp.com>
2580 [EFL] Fix unhandled web process message when launching MiniBrowser
2581 https://bugs.webkit.org/show_bug.cgi?id=152048
2583 Reviewed by Gyuyoung Kim.
2585 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2586 (TestWebKitAPI::TEST):
2588 2015-12-09 Carlos Garcia Campos <cgarcia@igalia.com>
2590 [GTK] Add API to handle beforeunload events
2591 https://bugs.webkit.org/show_bug.cgi?id=139090
2593 Reviewed by Gustavo Noronha Silva.
2595 * MiniBrowser/gtk/BrowserWindow.c:
2596 (browserWindowConstructed):
2597 (browserWindowDeleteEvent):
2598 (browser_window_class_init):
2599 Handle delete-event to prevent the window from being closed when
2600 the page has beforeunload handlers. Use
2601 webkit_web_view_try_close() when the window is requested to be
2603 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2604 (testWebViewJavaScriptDialogs):
2605 Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
2608 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
2610 Refactored initialization code in LoadTrackingTest.
2612 Rubber-stamped by Carlos Garcia Campos.
2614 Small refactoring to make sure that the state of a LoadTrackingTest
2615 gets properly reset before loading new web content.
2617 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2618 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2619 (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
2620 functions and reset the remaining local variables.
2621 (LoadTrackingTest::loadURI): Call reset();
2622 (LoadTrackingTest::loadHtml): Ditto.
2623 (LoadTrackingTest::loadPlainText): Ditto.
2624 (LoadTrackingTest::loadBytes): Ditto.
2625 (LoadTrackingTest::loadRequest): Ditto.
2626 (LoadTrackingTest::reload): Ditto.
2627 (LoadTrackingTest::goBack): Ditto.
2628 (LoadTrackingTest::goForward): Ditto.
2630 2015-12-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2632 [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
2633 https://bugs.webkit.org/show_bug.cgi?id=151942
2635 Reviewed by Darin Adler.
2637 * MiniBrowser/efl/main.c:
2638 (window_create): Enable offline web application cache feature on MiniBrowser.
2641 2015-12-08 Aakash Jain <aakash_jain@apple.com>
2643 https://bugs.webkit.org/show_bug.cgi?id=151243
2644 <rdar://problem/22955197>
2646 Reviewed by Alexey Proskuryakov.
2648 * LayoutTestRelay/LayoutTestRelay/main.m:
2649 (getTestingSimDevice): Use separate testing device for each worker.
2650 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2651 (Manager.run): Perform cleanup even if setup fails.
2652 * Scripts/webkitpy/port/ios.py:
2653 (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
2654 (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
2655 (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
2656 (IOSSimulatorPort._quit_ios_simulator): Same
2657 (IOSSimulatorPort.clean_up_test_run): Same
2658 (IOSSimulatorPort.check_sys_deps): Same
2659 (IOSSimulatorPort.testing_device): Same
2660 (IOSSimulatorPort.reset_preferences): Same
2661 (IOSSimulatorPort.get_simulator_path): Return simulator path.
2662 (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
2663 * Scripts/webkitpy/xcode/simulator.py:
2664 (Device.delete): Delete the simulator device.
2665 (Simulator.delete_device): Same
2666 (Simulator.wait_until_device_is_booted): Wait for device booting.
2668 2015-12-08 Ryuan Choi <ryuan.choi@navercorp.com>
2670 [EFL] Add API to provide preferences before creating ewk_view
2671 https://bugs.webkit.org/show_bug.cgi?id=151587
2673 Reviewed by Gyuyoung Kim.
2675 * MiniBrowser/efl/main.c:
2679 Moved settings related code to configuration() not to update settings
2680 whenever ewk_view is created.
2684 2015-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
2686 Unreviewed. Fix GTK+ API tests after r193639.
2688 The new jhbuild version needs some more variables ot be present in
2689 the builtin dict, even if they are set to None.
2691 * jhbuild/jhbuildutils.py:
2692 (enter_jhbuild_environment_if_available):
2694 2015-12-07 Gustavo Noronha Silva <gns@gnome.org>
2696 [GTK] Notify WebCore when notification is clicked
2697 https://bugs.webkit.org/show_bug.cgi?id=151951
2699 Reviewed by Carlos Garcia Campos.
2701 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2702 (testWebViewNotification): test the new API.
2704 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
2706 'jhbuild build' should fail immediately when building any module fails
2707 https://bugs.webkit.org/show_bug.cgi?id=145697
2709 Reviewed by Carlos Garcia Campos.
2711 * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2712 * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2713 Everything is placed under lib instead of lib64 now.
2714 * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
2715 --exit-on-error when running 'jhbuild build'.
2716 * jhbuild/jhbuildrc_common.py:
2717 (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
2718 jhbuild should be able to handle these for us without breaking things....
2720 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
2722 Add support to import w3c tests from a repository with a different root that the main repo dir
2723 https://bugs.webkit.org/show_bug.cgi?id=151751
2725 Reviewed by Ryosuke Niwa and Youenn Fablet.
2727 We should be able to import tests from repositories that are not pure test repositories and where tests are kept
2728 in a different directory than the repository root.
2730 This patch introduces a new parameter tests_directory that we will use as root directory to search for
2731 tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
2732 requires having the copy_path lists including tuples of origin and destination directories.
2734 * Scripts/webkitpy/w3c/test_downloader.py:
2735 (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
2736 (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
2737 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2738 (TestImporterTest.test_tests_directory): Test.
2740 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
2742 Mock TestRepositories in W3C importer tests
2743 https://bugs.webkit.org/show_bug.cgi?id=151938
2745 Reviewed by Youenn Fablet.
2747 The test importer tests should use a fake repository instead of using the real one. The reason why this happened
2748 is because the test repository method reading the file was using the filesystem directly instead of taking the
2749 host one. This patch changes that.
2751 * Scripts/webkitpy/w3c/test_downloader.py:
2752 (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
2754 (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
2755 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2756 (TestImporterTest.test_harnesslinks_conversion):
2757 (TestImporterTest.test_submodules_generation): Use a fake test repository file.
2759 2015-12-07 David Kilzer <ddkilzer@apple.com>
2761 TestNetscapePlugIn: Address review comment on 193607
2762 <http://webkit.org/b/151881>
2764 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2765 (testSetStatus): Initializing std::unique_ptr<char[]> with
2766 nullptr is redundant.
2768 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2770 [GTK] Add webkit_uri_request_get_http_method
2771 https://bugs.webkit.org/show_bug.cgi?id=151601
2773 Reviewed by Martin Robinson.
2775 Add test case to check HTTP method of WebKitURIRequest.
2777 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2778 (testURIRequestHTTPMethod):
2781 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2782 (sendRequestCallback):
2784 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2786 [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
2787 https://bugs.webkit.org/show_bug.cgi?id=79918
2789 Reviewed by Gustavo Noronha Silva.
2791 Add unit tests to check the different console messages.
2793 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2794 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
2795 (ConsoleMessageTest::ConsoleMessage::operator==):
2796 (ConsoleMessageTest::consoleMessageReceivedCallback):
2797 (ConsoleMessageTest::ConsoleMessageTest):
2798 (ConsoleMessageTest::~ConsoleMessageTest):
2799 (ConsoleMessageTest::waitUntilConsoleMessageReceived):
2800 (testWebKitConsoleMessageConsoleAPI):
2801 (testWebKitConsoleMessageJavaScriptException):
2802 (testWebKitConsoleMessageNetworkError):
2803 (testWebKitConsoleMessageSecurityError):
2806 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2807 (consoleMessageSentCallback):
2808 (pageCreatedCallback):
2810 2015-12-07 Ryuan Choi <ryuan.choi@navercorp.com>
2812 [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
2813 https://bugs.webkit.org/show_bug.cgi?id=151934
2815 Reviewed by Csaba Osztrogonác.
2817 * MiniBrowser/efl/main.c:
2818 (on_window_deletion): Revert the changes of r192767.
2820 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
2822 [GTK] update-webkitgtk-libs cannot build mesa
2823 https://bugs.webkit.org/show_bug.cgi?id=151535
2825 Reviewed by Martin Robinson.
2827 Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
2828 dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
2829 on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
2830 does not have a stable API and we cannot expect mesa to be buildable unless we control the
2831 LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
2832 --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
2834 * gtk/jhbuild.modules:
2836 2015-12-07 Philippe Normand <pnormand@igalia.com>
2838 [GTK][Mac] libWebExtensionTest link error
2839 https://bugs.webkit.org/show_bug.cgi?id=150802
2841 Reviewed by Carlos Garcia Campos.
2843 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
2845 2015-12-06 David Kilzer <ddkilzer@apple.com>
2847 TestNetscapePlugIn: Fix leaks found by static analyzer
2848 <http://webkit.org/b/151881>
2850 Reviewed by Darin Adler.
2852 Fixes the following leaks found by the static analyzer:
2853 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
2856 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
2859 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
2863 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2864 (toCString): Switch to returning std::unique_ptr<char[]>. Add
2865 early return if allocation fails.
2866 (testPostURLFile): Switch to using std::unique_ptr<char[]>.
2867 Make sure to call fclose() on filehandle, even for an early
2869 (testSetStatus): Switch to using std::unique_ptr<char[]>.
2871 2015-12-05 David Kilzer <ddkilzer@apple.com>
2873 prepare-ChangeLog: Fix some warning messages when using svn
2874 <http://webkit.org/b/151914>
2876 Reviewed by Daniel Bates.
2878 * Scripts/prepare-ChangeLog:
2879 (generateFunctionLists): Simplify logic so that we never call
2880 normalizePath() with an undefined value.
2881 (attributeCommand): Quote $subPath for the shell so that we
2882 don't try to run "svn propget" on invalid paths.
2884 2015-12-04 David Kilzer <ddkilzer@apple.com>
2886 TestNetscapePlugIn: Fix remaining static analyzer warnings
2887 <http://webkit.org/b/151888>
2889 Reviewed by Alexey Proskuryakov.
2891 Fixes the following static analyzer warnings:
2892 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2895 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2896 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2898 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2899 return obj->pluginTest->NPP_SetWindow(window);
2901 2 warnings generated.
2903 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2904 (CRASH): Use __builtin_trap() for gcc/clang.
2905 (NPP_SetWindow): Add early return if obj is nullptr.
2907 2015-12-03 Carlos Garcia Campos <cgarcia@igalia.com>
2909 [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2910 https://bugs.webkit.org/show_bug.cgi?id=151797
2912 Reviewed by Martin Robinson.
2914 Since we switched to use the network process to run the unit tests
2915 the test /webkit2/WebKitWebResource/get-data sometimes fails and
2916 sometimes passes. We are now also getting the notification for the
2917 css image. Since we wait for 3 resources, sometimes the css image
2918 is loaded before and then checkResourceData is called for it, but
2919 not handled. When the css image is the last one loaded the test
2920 passes. So, we just need to wait for the 4 resources.
2922 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2923 (testWebResourceGetData):
2925 2015-12-03 David Kilzer <ddkilzer@apple.com>
2927 DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2928 <http://webkit.org/b/151845>
2930 Reviewed by Simon Fraser.
2932 Fixes the following static analyzer warning:
2933 DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2934 WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2935 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2937 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2938 (createBitmapContext): Free 'buffer' after using it in logging
2939 to fix the use-after-free. Assign a value of nullptr to buffer
2940 so we don't return with it set to a freed address.
2942 2015-12-03 Jer Noble <jer.noble@apple.com>
2944 Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2945 https://bugs.webkit.org/show_bug.cgi?id=151830
2947 Reviewed by Anders Carlsson.
2949 Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2951 * DumpRenderTree/mac/DumpRenderTree.mm:
2952 (resetWebPreferencesToConsistentValues):
2953 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2954 (WTR::initializeWebViewConfiguration):
2956 2015-12-03 Anders Carlsson <andersca@apple.com>
2958 Remove Objective-C GC support
2959 https://bugs.webkit.org/show_bug.cgi?id=151819
2960 rdar://problem/23746991
2962 Reviewed by Dan Bernstein.
2964 * asan/asan.xcconfig:
2966 2015-12-02 Yusuke Suzuki <utatane.tea@gmail.com>
2968 Allow nil for unspecified benchmark pathes
2969 https://bugs.webkit.org/show_bug.cgi?id=151784
2971 Reviewed by Filip Pizlo.
2973 `Pathname.new(nil)` will raise an error.
2974 Only generate Pathname if the benchmark path is specified.
2976 * Scripts/run-jsc-benchmarks:
2978 2015-12-02 Brent Fulgham <bfulgham@apple.com>
2980 [Win] Run non-http tests without Cygwin
2981 https://bugs.webkit.org/show_bug.cgi?id=151721
2983 Reviewed by Andy Estes.
2985 Support native 32-bit and 64-bit Python (and Perl) builds
2988 1. Use "startswith('win')", rather than "== 'win32'" to support
2989 various Windows build types.
2990 2. Supply full path for some native Windows utilities, since the
2991 path environment does not always have the specified, and they are
2992 guaranteed to exist in those specific locations.
2993 3. Make sure native Windows Python test runs pass proper environment
2994 variables to run programs.
2995 4. Append 'exe' suffix when running Windows executables.
2996 5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2997 command doesn't exist.
2999 * Scripts/update-webkit: Use Perl $^X command to refer to the path of
3000 the current Perl executable, rather than requiring a new path search.
3001 * Scripts/webkitpy/common/find_files_unittest.py:
3002 (TestWinNormalize.test_win): Use startswith('win').
3003 * Scripts/webkitpy/common/prettypatch_unittest.py:
3004 (test_pretty_diff_encodings): Ditto.
3005 * Scripts/webkitpy/common/system/executive.py:
3006 (Executive._should_close_fds): Ditto.
3007 (Executive.shell_command_for_script): Use startswith('win').
3008 (Executive.kill_process): Use full path to killall executable.
3009 (Executive.check_running_pid): Use startswith('win').
3010 (Executive.running_pids): Ditto.
3011 (Executive.kill_all): Ditto. Also use path to 'killall' executable when
3012 running under native Windows Python.
3013 (Executive._child_process_encoding): Use startswith('win').
3014 (Executive._should_encode_child_process_arguments): Ditto.
3015 (Executive.popen): Recognize proper script engine on Windows, since it
3016 does not support the shebang syntax.
3017 (Executive.run_in_parallel): Use startswith('win').
3018 * Scripts/webkitpy/common/system/executive_unittest.py:
3019 (never_ending_command): Ditto.
3020 (ExecutiveTest.test_run_command_with_unicode): Ditto.
3021 (ExecutiveTest.serial_test_kill_process): Ditto.
3022 (ExecutiveTest.serial_test_kill_all): Ditto.
3023 (ExecutiveTest.serial_test_check_running_pid): Ditto.
3024 (ExecutiveTest.serial_test_run_in_parallel): Ditto.
3026 * Scripts/webkitpy/common/system/file_lock.py:
3027 (FileLock._create_lock): Ditto.
3028 (FileLock._remove_lock): Ditto.
3029 * Scripts/webkitpy/common/system/filesystem_unittest.py:
3030 (RealFileSystemTest.test_chdir): Ditto.
3031 (RealFileSystemTest.test_chdir__notexists): Ditto.
3032 (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
3033 * Scripts/webkitpy/common/system/path_unittest.py:
3034 (AbspathTest.test_abspath_to_uri_win): Ditto.
3035 * Scripts/webkitpy/common/system/platforminfo.py:
3036 (PlatformInfo._determine_os_name): Ditto.
3037 * Scripts/webkitpy/common/system/user.py: Ditto.
3038 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3039 (ManagerTest.integration_test_needs_servers): Ditto.
3040 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3041 (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
3043 (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
3044 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3045 (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
3046 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3047 (HttpServerBase._check_that_all_ports_are_available): Ditto.
3048 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3049 (TestHttpServer.test_start_cmd): Ditto.
3050 * Scripts/webkitpy/port/base.py:
3051 (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
3052 and 'SYSTEMROOT' in environment passed to test runners.
3053 (Port._apache_config_file_name_for_platform): Use startswith('win').
3054 (Port._build_path): Ditto.
3055 (Port._path_to_driver): Include 'exe' suffix when running under native
3057 * Scripts/webkitpy/port/driver.py:
3058 (Driver._setup_environ_for_driver): Explicitly make some environment
3060 * Scripts/webkitpy/port/server_process.py:
3061 (ServerProcess.__init__): Use startswith('win').
3062 * Scripts/webkitpy/port/win.py:
3063 (WinPort): Use the win32 registry utilities on Windows, and appropriate
3064 registry key formats.
3065 (WinPort._ntsd_location): Revise tool search paths for Windows 10.
3066 (WinPort.read_registry_value): Revise to use _winreg library on Windows,
3067 and regtool on Cygwin.
3068 (WinPort.write_registry_value): Ditto.
3069 (WinPort.setup_crash_log_saving): Ditto.
3070 (WinPort.restore_crash_log_saving): Ditto.
3071 (WinPort.prevent_error_dialogs): Ditto.
3072 (WinPort.allow_error_dialogs): Ditto.
3073 (WinPort.find_system_pid): Revise to use Windows management
3074 infrastructure on native Windows, continue using 'ps' on Cygwin.
3075 (WinPort.read_registry_string): Deleted.
3076 (WinPort.write_registry_string): Deleted.
3077 * Scripts/webkitpy/test/main.py:
3078 (main): Use startswith('win').
3079 (Tester._parse_args): Ditto.
3081 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
3083 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
3084 https://bugs.webkit.org/show_bug.cgi?id=150792
3086 Reviewed by Saam Barati.
3088 * Scripts/webkitperl/FeatureList.pm:
3090 2015-12-01 Commit Queue <commit-queue@webkit.org>
3092 Unreviewed, rolling out r192914.
3093 https://bugs.webkit.org/show_bug.cgi?id=151734
3095 JSC tests for this change are failing on 32 and 64-bit bots
3096 (Requested by ryanhaddad on #webkit).
3100 "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
3101 enable this feature"
3102 https://bugs.webkit.org/show_bug.cgi?id=150792
3103 http://trac.webkit.org/changeset/192914
3105 2015-12-01 David Kilzer <ddkilzer@apple.com>
3107 EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
3108 <http://webkit.org/b/151726>
3110 Reviewed by Simon Fraser.
3112 * WebKitTestRunner/mac/EventSenderProxy.mm:
3113 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3114 Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
3116 2015-12-01 Myles C. Maxfield <mmaxfield@apple.com>
3118 Give String and AtomicString an existingHash() function
3119 https://bugs.webkit.org/show_bug.cgi?id=151717
3121 Reviewed by Andreas Kling.
3123 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3124 (TestWebKitAPI::TEST):
3125 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3126 (TestWebKitAPI::TEST):
3128 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
3130 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
3131 https://bugs.webkit.org/show_bug.cgi?id=150792
3133 Reviewed by Saam Barati.
3135 * Scripts/webkitperl/FeatureList.pm:
3137 2015-12-01 Sam Weinig <sam@webkit.org>
3139 Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
3140 <rdar://problem/23320863>
3141 https://bugs.webkit.org/show_bug.cgi?id=151708
3143 Reviewed by Anders Carlsson.
3145 * WebKitTestRunner/TestController.cpp:
3146 (WTR::TestController::createOtherPage):
3147 (WTR::TestController::createWebViewWithOptions):
3148 Update for new WKPageUIClient.
3150 2015-12-01 Anders Carlsson <andersca@apple.com>
3152 Remove WebKit2.framework
3153 https://bugs.webkit.org/show_bug.cgi?id=151715
3155 Reviewed by Dan Bernstein.
3157 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
3158 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
3159 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3160 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3161 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3162 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3163 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3165 2015-12-01 Joseph Pecoraro <pecoraro@apple.com>
3167 Unreviewed common typo fix "occurance" => "occurrence".
3169 * Scripts/webkitpy/tool/commands/queries.py:
3170 (FindFlakyTests._print_statistics):
3172 2015-11-30 Alex Christensen <achristensen@webkit.org>
3174 Make ProcessModel always MultipleSecondaryProcesses
3175 https://bugs.webkit.org/show_bug.cgi?id=151662
3177 Reviewed by Antti Koivisto.
3179 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3180 (TestWebKitAPI::TEST):
3181 * WebKitTestRunner/TestController.cpp:
3182 (WTR::TestController::generatePageConfiguration):
3184 2015-11-30 Alex Christensen <achristensen@webkit.org>
3186 Make usesNetworkProcess always true
3187 https://bugs.webkit.org/show_bug.cgi?id=151580
3189 Reviewed by Darin Adler.
3191 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3192 (TestWebKitAPI::TEST):
3193 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3194 (TestWebKitAPI::TEST):
3195 * WebKitTestRunner/TestController.cpp:
3196 (WTR::TestController::generatePageConfiguration):
3198 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
3200 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
3202 Add a way to skip unit tests only for Debug or Release builds and
3203 skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
3205 * Scripts/run-gtk-tests:
3207 (SkippedTest.__init__):
3208 (SkippedTest.__str__):
3209 (SkippedTest.skip_entire_suite):
3210 (SkippedTest.skip_for_build_type):
3212 (TestRunner.__init__):
3214 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
3216 Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
3218 It's an assert hit because we are reloading a view loaded with
3219 HTML data which is not supported. Use loadURI instead.
3221 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3222 (testWebViewCustomCharset):
3224 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
3226 [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
3227 https://bugs.webkit.org/show_bug.cgi?id=151633
3229 Reviewed by Csaba Osztrogonác.
3231 * TestWebKitAPI/PlatformGTK.cmake:
3232 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
3234 2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com>
3236 [GTK] Remove the remaining uses of GMainLoopSource
3237 https://bugs.webkit.org/show_bug.cgi?id=151632
3239 Reviewed by Žan Doberšek.
3241 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3242 (testWebViewSyncRequestOnMaxConns):
3243 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3244 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3245 (WTR::TestRunner::TestRunner):
3246 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3247 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3248 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3249 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3250 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3251 (WTR::timeoutSource):
3252 (WTR::TestController::notifyDone):
3253 (WTR::TestController::platformRunUntil):
3255 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
3257 [cmake] Add testb3 to the build system
3258 https://bugs.webkit.org/show_bug.cgi?id=151619
3260 Reviewed by Gyuyoung Kim.
3262 * Scripts/build-jsc:
3264 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
3266 [jhbuild] Fix pixman build with clang
3267 https://bugs.webkit.org/show_bug.cgi?id=151441
3269 Reviewed by Carlos Garcia Campos.
3271 * efl/jhbuild.modules:
3272 * gtk/jhbuild.modules:
3274 2015-11-26 David Kilzer <ddkilzer@apple.com>
3276 Extract prependToEnvironmentVariableList
3277 <http://webkit.org/b/151536>
3279 Reviewed by Daniel Bates.
3281 Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
3282 webkitdirs_unittest/prependToEnvironmentVariableList.pl
3284 * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
3285 and prependToEnvironmentVariableList.
3286 (appendToEnvironmentVariableList): Simplify variable name.
3287 Switch to use $Config{path_sep}.
3288 (prependToEnvironmentVariableList): Add new method.
3289 (setupMacWebKitEnvironment): Switch to use
3290 prependToEnvironmentVariableList().
3291 (setupIOSWebKitEnvironment): Ditto.
3293 * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
3294 * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
3296 2015-11-24 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3298 REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
3299 https://bugs.webkit.org/show_bug.cgi?id=151567
3301 Reviewed by Darin Adler.
3303 * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
3304 (on_window_deletion):
3306 2015-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
3308 [GTK] Use the network process unconditionally
3309 https://bugs.webkit.org/show_bug.cgi?id=151541
3311 Reviewed by Alex Christensen.
3313 Fix TestInspectorServer test. Do not assume we already have the
3314 title we want when the page has been loaded, since the title is
3315 changed afterwards. So, check if the title has already been set,
3316 and if not wait for it.
3318 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3319 (openRemoteDebuggingSession):
3321 2015-11-23 Alex Christensen <achristensen@webkit.org>
3323 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
3324 https://bugs.webkit.org/show_bug.cgi?id=151532
3326 Reviewed by Benjamin Poulain.
3328 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3329 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
3330 (TestWebKitAPI::TEST):
3331 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
3332 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
3333 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
3334 Properly load about:blank in all WebViews to clean up. Without this change, we had a
3335 Geolocation provider stopping after its state tracker was destroyed with its stack frame,
3336 so it was calling a function on a test object that had gone out of scope.
3337 Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
3338 but that will become the default soon and that call will be removed.
3340 2015-11-22 David Kilzer <ddkilzer@apple.com>
3342 run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
3343 <http://webkit.org/b/151542>
3345 Reviewed by Daniel Bates.
3347 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3348 (base_url): Use the Port object (already passed in) to give us
3349 the path to the LayoutTests directory, which already checks for a
3350 --layout-tests-directory command-line switch.
3351 (WebPlatformTestServer.__init__): Remove layout_test_results_dir
3352 argument since we can get this from the Port object already
3353 passed in via Port.results_directory(). Also switch to use
3354 Port.layout_tests_dir() to get the LayoutTests directory.
3356 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3357 (TestWebPlatformTestServer.test_custom_layout_tests_directory):
3358 Add test case for custom LayoutTests directory.
3359 (TestWebPlatformTestServer.test_previously_spawned_instance):
3360 Update Port object to set mock results directory as if it was
3361 set on the command-line. Remove unneeded argument from
3362 WebPlatformTestServer constructor.
3363 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
3365 * Scripts/webkitpy/port/base.py:
3366 (Port.to.start_web_platform_test_server): Remove unneeded
3367 argument from WebPlatformTestServer constuctor.
3369 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
3371 [GTK] Some unit tests fail when using the network process
3372 https://bugs.webkit.org/show_bug.cgi?id=151490
3374 Reviewed by Martin Robinson.
3376 Run the soup server in a separate thread in TestResources test to
3379 This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
3380 /webkit2/WebKitWebResource/get-data when using the network process.
3382 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3383 (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
3384 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
3385 (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
3386 present, create a WorkQueue to run the server.
3387 (WebKitTestServer::run): Run the server in the work queue if it
3389 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
3390 type into server options as flags.
3392 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
3394 [GTK] ImageDiff should normalize the diff image
3395 https://bugs.webkit.org/show_bug.cgi?id=151261
3397 Reviewed by Sergio Villar Senin.
3399 * ImageDiff/gtk/ImageDiff.cpp:
3400 (readPixbufFromStdin): Fix memory leak.
3401 (differenceImageFromDifferenceBuffer): Normalize diff buffer.
3402 (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
3404 == Rolled over to ChangeLog-2015-11-21 ==