Add standalone script that filters the output of build-webkit to be more human-readable
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
2
3         Add standalone script that filters the output of build-webkit to be more human-readable
4         https://bugs.webkit.org/show_bug.cgi?id=44081
5
6         Reviewed by Daniel Bates.
7
8         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
9         a build script (e.g. build-webkit) and it spits out a prettier version.
10         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
11         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
12
13 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
14
15         Add myself to committers.py                 
16         https://bugs.webkit.org/show_bug.cgi?id=67696
17
18         Reviewed by Kent Tamura.
19
20         * Scripts/webkitpy/common/config/committers.py:
21
22 2011-09-07  Adam Barth  <abarth@webkit.org>
23
24         rebaseline button in garden-o-matic details view should work
25         https://bugs.webkit.org/show_bug.cgi?id=67738
26
27         Reviewed by Dimitri Glazkov.
28
29         This patch wires up the rebaseline button in garden-o-matic results
30         details view.  The button is current per-test, so there isn't a way to
31         rebaseline individual bots.  This is a place to start.  If we decide we
32         want per-bot rebaselining, we'll need to think of some better UI.
33
34         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
35         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
36         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
37         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
38
39 2011-09-07  Eric Seidel  <eric@webkit.org>
40
41         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
42         https://bugs.webkit.org/show_bug.cgi?id=67737
43
44         Reviewed by Adam Barth.
45
46         I got a little over-eager when deprecating host.port_factory in the previous commit.
47         Turns out that Host.port_factory was already the "modern" port/factory.py
48         it was just the Module object.  I un-deprecated the variable, and changed it from
49         being the module to being an actual PortFactory, passing it a host object.
50         I also taught PortFactory how to set user/executive/filesystem in the kwargs
51         when instantiating a new Port object.
52         This magically fixed the test_rebaseline test, since its now no longer talking
53         to the real filesystem.
54
55         * Scripts/webkitpy/common/host.py:
56         * Scripts/webkitpy/layout_tests/port/factory.py:
57         * Scripts/webkitpy/tool/commands/queries.py:
58         * Scripts/webkitpy/tool/mocktool.py:
59
60 2011-09-07  Eric Seidel  <eric@webkit.org>
61
62         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
63         https://bugs.webkit.org/show_bug.cgi?id=67734
64
65         Reviewed by Adam Barth.
66
67         Right now every place that creates a Port object has to be very careful
68         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
69         The correct fix is for port/factory.py (which creates most port objects)
70         to know how to pass these in automatically.  However, currently all port/factory.py
71         functions are free functions instead of being on an object.  This patch
72         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
73
74         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
75         pass along the proper scm/user/filesystem to the Port object.
76
77         * Scripts/webkitpy/common/host.py:
78         * Scripts/webkitpy/layout_tests/port/factory.py:
79         * Scripts/webkitpy/tool/commands/queries.py:
80         * Scripts/webkitpy/tool/mocktool.py:
81
82 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
83
84         Unreviewed, rolling out r94441.
85         http://trac.webkit.org/changeset/94441
86         https://bugs.webkit.org/show_bug.cgi?id=67731
87
88         "MacEWSes are backed up due to new machines not able to reach
89         git.webkit.org.  Disabling tests for now" (Requested by
90         eseidel2 on #webkit).
91
92         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
93
94 2011-09-07  Elliot Poger  <epoger@google.com>
95
96         filter test_expectations properly for chromium-mac vs chromium-cg-mac
97         https://bugs.webkit.org/show_bug.cgi?id=67324
98
99         Reviewed by Dirk Pranke.
100
101         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
102         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
103         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
104         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
105         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
106
107 2011-09-07  Eric Boren  <borenet@gmail.com>
108
109         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
110         https://bugs.webkit.org/show_bug.cgi?id=66800
111
112         Reviewed by Darin Fisher.
113
114         * DumpRenderTree/chromium/EventSender.cpp:
115         (EventSender::sendCurrentTouchEvent):
116
117 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
118
119         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
120         https://bugs.webkit.org/show_bug.cgi?id=67254
121
122         Reviewed by Csaba Osztrogonác.
123
124         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
125         derived from the running location of DumpRenderTree binary.
126
127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
128         (LayoutTestController::pathToLocalResource):
129         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
130
131 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
132
133         REGRESSION(r94288) build-webkit doesn't work on Symbian
134         https://bugs.webkit.org/show_bug.cgi?id=67706
135
136         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
137         (buildQMakeProject):
138
139 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
140
141         REGRESSION(r94288) build-webkit doesn't work on Windows
142         https://bugs.webkit.org/show_bug.cgi?id=67646
143
144         Roll back r94655 with a small fix.
145
146         * Scripts/webkitdirs.pm:
147         (buildQMakeProject):
148
149 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
150
151         Unreviewed, rolling out r94635.
152         http://trac.webkit.org/changeset/94635
153         https://bugs.webkit.org/show_bug.cgi?id=67704
154
155         Linux Touch build is failing to compile this change.
156         (Requested by loislo on #webkit).
157
158         * DumpRenderTree/chromium/EventSender.cpp:
159         (EventSender::sendCurrentTouchEvent):
160
161 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
162
163         Unreviewed, rolling out r94655.
164         http://trac.webkit.org/changeset/94655
165         https://bugs.webkit.org/show_bug.cgi?id=67703
166
167         It broke Leopard debug bot (Requested by ossy on #webkit).
168
169         * Scripts/webkitdirs.pm:
170
171 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
172
173         REGRESSION(r94288) build-webkit doesn't work on Windows
174         https://bugs.webkit.org/show_bug.cgi?id=67646
175
176         Reviewed by Csaba Osztrogonác.
177
178         * Scripts/webkitdirs.pm:
179
180 2011-09-06  Eric Boren  <borenet@gmail.com>
181
182         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
183         https://bugs.webkit.org/show_bug.cgi?id=66800
184
185         Reviewed by Darin Fisher.
186
187         * DumpRenderTree/chromium/EventSender.cpp:
188         (EventSender::sendCurrentTouchEvent):
189
190 2011-09-06  Adam Barth  <abarth@webkit.org>
191
192         garden-o-matic details view should having working rebaseline and next/previous buttons
193         https://bugs.webkit.org/show_bug.cgi?id=67659
194
195         Reviewed by Dimitri Glazkov.
196
197         This patch wires up basic back/forward buttons that let you traverse
198         through the results we're examining in the details view.  This ended up
199         being more code than I expected, but I wanted to keep all the state
200         information in the DOM itself.
201
202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
205
206 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
207
208         fix MockFileSystem.glob(), refactor filesystem tests
209         https://bugs.webkit.org/show_bug.cgi?id=67462
210
211         Reviewed by Eric Seidel.
212
213         In debugging why my proposed change for MockFileSystem.glob()
214         in bug 66228 didn't work, I stumbled across two real bugs
215         that cancelled each other out for the unit tests. I fixed those
216         (glob shouldn't recurse into subdirs, and we weren't populating
217         self.dirs from self.files properly).
218
219         I have also created a "mixin" class for tests that can be shared
220         between the real filesystem and the mock filesystem - MockFileSystem
221         is being used enough it needs its own tests.
222
223         * Scripts/webkitpy/common/system/filesystem_mock.py:
224         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
225         * Scripts/webkitpy/common/system/filesystem_unittest.py:
226
227 2011-09-06  Anders Carlsson  <andersca@apple.com>
228
229         Move NPAPI headers in bridge to plugins
230         https://bugs.webkit.org/show_bug.cgi?id=67661
231
232         Update forwarding headers.
233
234         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
235         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
236
237 2011-09-06  Tony Chang  <tony@chromium.org>
238
239         [chromium] Check in 'build' for compiled binaries first
240         https://bugs.webkit.org/show_bug.cgi?id=67549
241
242         Reviewed by Dirk Pranke.
243
244         I'm working on moving the windows build output to a common location
245         rather than relative to the sln file.  Because of that, we need to
246         check those build locations first for DumpRenderTree.exe.
247
248         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
249
250 2011-09-06  Adam Barth  <abarth@webkit.org>
251
252         Use a hierarchial structure for the garden-o-matic results view
253         https://bugs.webkit.org/show_bug.cgi?id=67620
254
255         Reviewed by Dimitri Glazkov.
256
257         This patch re-organizes the results view to use a hierachial structure
258         for selection.  At the top-level are sections for each test.  Expanding
259         the test section shows a tab selector for builders.
260
261         This structure prepares us for wiring up various actions to this view.
262
263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
264         (.):
265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
266         ():
267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
268         (.):
269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
271         (.results-view>.toolbar):
272         (.results-view>.toolbar ul.actions):
273         (.results-view>.toolbar ul.actions li):
274         (.results-grid table):
275         (.results-grid table td, .results-view table th):
276         (.results-grid table th):
277         (.results-grid .text-result):
278         (.results-grid .image-result):
279
280 2011-09-06  Adam Barth  <abarth@webkit.org>
281
282         garden-o-matic's base.probe generates spam in the JavaScript console
283         https://bugs.webkit.org/show_bug.cgi?id=67622
284
285         Reviewed by Dimitri Glazkov.
286
287         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
288         instead of HTMLScriptElement to test whether results exist.  This
289         reduces the console.log spam and saves bandwidth because we can use a
290         HEAD request instead of a GET request.
291
292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
293
294 2011-09-05  Adam Barth  <abarth@webkit.org>
295
296         Add a tab to garden-o-matic for viewing expected failures
297         https://bugs.webkit.org/show_bug.cgi?id=67619
298
299         Reviewed by Dimitri Glazkov.
300
301         This patch adds a basic tab to garden-o-matic that shows all the tests
302         failing on the bots, including the expected failures.  This patch
303         mostly involves refactoring existing classes to allow new subclasses.
304
305         This view is useful for when gardeners mark tests as expected to fail
306         and then rebaseline them later.
307
308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
315
316 2011-09-05  Adam Barth  <abarth@webkit.org>
317
318         Fix global variable leak in garden-o-matic
319         https://bugs.webkit.org/show_bug.cgi?id=67617
320
321         Reviewed by Dimitri Glazkov.
322
323         Caught by running the unit tests with noglobals turned on.
324
325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
326
327 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
328
329         [Qt][WK2] Add pixel test support
330         https://bugs.webkit.org/show_bug.cgi?id=66283
331
332         Reviewed by Andreas Kling.
333
334         Implemented pixel result generation by reusing the logic
335         that we have in DumpRenderTree.
336         * WebKitTestRunner/qt/TestInvocationQt.cpp:
337         (WTR::dumpImage):
338         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
339
340 2011-09-04  Robin Dunn  <robin@alldunn.com>
341
342         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
343         https://bugs.webkit.org/show_bug.cgi?id=67577
344
345         Reviewed by Kevin Ollivier.
346
347         * waf/build/settings.py:
348
349 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
350
351         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
352
353         * waf/build/settings.py:
354
355 2011-09-03  Dan Bernstein  <mitz@apple.com>
356
357         32-bit build fix.
358
359         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
360         (TestWebKitAPI::Util::toSTD):
361
362 2011-09-03  Dan Bernstein  <mitz@apple.com>
363
364         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
365         https://bugs.webkit.org/show_bug.cgi?id=67559
366
367         Reviewed by Darin Adler.
368
369         * DumpRenderTree/mac/DumpRenderTree.mm:
370         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
371         the call to it.
372         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
374         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
375         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
376         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
377         (TestWebKitAPI::Util::toSTD): Added.
378
379 2011-09-03  Adam Barth  <abarth@webkit.org>
380
381         garden-o-matic results view should have a better results selector
382         https://bugs.webkit.org/show_bug.cgi?id=67542
383
384         Reviewed by Dimitri Glazkov.
385
386         This patch adds a basic grid-based results selector to the results
387         view.  Currently, this grid just shows how the tests fail on the
388         various bots.  A future patch will let you select which failure to view
389         and to mark the failures for rebaselining.
390
391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
393           - Add some more basic functions for manipulating dictionaries.
394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
397
398 2011-09-03  Adam Barth  <abarth@webkit.org>
399
400         garden-o-matic results view should show Actual and Expected results for text failures
401         https://bugs.webkit.org/show_bug.cgi?id=67536
402
403         Reviewed by Eric Seidel.
404
405         In the past, we didn't show actual and expected text results (we just
406         showed the diff) because we didn't have the awesome six-by-two results
407         grid.  Now that we do, we can move show these results.
408
409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
411           - Fixed some typos that were preventing these unit tests from running.
412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
413         (.):
414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
415           - Report -actual.txt and -expected.txt as possible results URLs.
416
417 2011-09-03  Adam Barth  <abarth@webkit.org>
418
419         garden-o-matic shows "ghost" failures that are already fixed
420         https://bugs.webkit.org/show_bug.cgi?id=67535
421
422         Reviewed by Eric Seidel.
423
424         About 10% of writes fail to stick on test-results.appspot.com.  This
425         patch causes us to fetch the full_results.json blob directly from
426         build.chromium.org rather than relying upon AppEngine.
427
428         Unforuntately, we still need to get historical information from
429         AppEngine.  That will take several patches to fix becuase I need to
430         change the bots to write the full_results.json file to the
431         build-specific directory in addition to the zip file.
432
433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
436
437 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
438
439         Unreviewed, rolling out r94458.
440         http://trac.webkit.org/changeset/94458
441         https://bugs.webkit.org/show_bug.cgi?id=67558
442
443         Caused appcache test to fail on various bots (Requested by
444         rniwa on #webkit).
445
446         * Scripts/webkitpy/layout_tests/port/webkit.py:
447         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
448
449 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
450
451         Unreviewed, rolling out r94453.
452         http://trac.webkit.org/changeset/94453
453         https://bugs.webkit.org/show_bug.cgi?id=67557
454
455         Caused appcache test to fail on various bots (Requested by
456         rniwa on #webkit).
457
458         * Scripts/webkitpy/layout_tests/port/webkit.py:
459
460 2011-09-02  Michael Saboff  <msaboff@apple.com>
461
462         Add JSC:RegExp functional tests
463         https://bugs.webkit.org/show_bug.cgi?id=67339
464
465         New perl script to build JavaScriptCore and run the RegExp tests.
466
467         Reviewed by Gavin Barraclough.
468
469         * Scripts/run-regexp-tests: Added.
470
471 2011-09-02  Michael Saboff  <msaboff@apple.com>
472
473         Add JSC:RegExp functional tests
474         https://bugs.webkit.org/show_bug.cgi?id=67339
475
476         New perl script to build JavaScriptCore and run the RegExp tests.
477
478         Reviewed by Gavin Barraclough.
479
480         * Scripts/run-regexp-tests: Added.
481
482 2011-09-02  Eric Seidel  <eric@webkit.org>
483
484         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
485         https://bugs.webkit.org/show_bug.cgi?id=67530
486
487         Unreviewed.  Fixing typo from previous commit.
488
489         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
490         which exercises the code I previously made a typo in.
491
492         * Scripts/webkitpy/layout_tests/port/webkit.py:
493         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
494
495 2011-09-02  Eric Seidel  <eric@webkit.org>
496
497         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
498         https://bugs.webkit.org/show_bug.cgi?id=67530
499
500         Reviewed by Adam Barth.
501
502         No functional change, just reshuffling code.
503
504         * Scripts/webkitpy/layout_tests/port/webkit.py:
505
506 2011-09-02  Darin Adler  <darin@apple.com>
507
508         Added Subversion ignore for .pyc generated files.
509
510         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
511         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
512         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
513
514 2011-09-02  Adam Barth  <abarth@webkit.org>
515
516         Enable testing on mac-ews
517         https://bugs.webkit.org/show_bug.cgi?id=67505
518
519         Reviewed by Eric Seidel.
520
521         This patch enables testing on the Mac EWS, which should help
522         contributors not turn the Mac bots red.
523
524         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
525
526 2011-09-01  Beth Dakin  <bdakin@apple.com>
527
528         https://bugs.webkit.org/show_bug.cgi?id=67451
529         Add a test for going back to a cached page after changing the device scale factor
530
531         Reviewed by Adam Roben.
532
533         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
535         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
536         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
537         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
538         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
539         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
540         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
541         (TestWebKitAPI::TEST_F):
542
543         Added new function to WebKitAgnosticTest to goBack. Separated 
544         waitForLoadToFinish() into its own function (instead of being a part of 
545         loadAndWaitUntilFinished()) so that it can be called from goBack as 
546         well. Also added initializeView() so we can set the cache model.
547         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
548         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
549         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
550         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
551         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
552         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
553         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
554         (TestWebKitAPI::WebKitAgnosticTest::goBack):
555         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
556
557 2011-09-02  Anders Carlsson  <andersca@apple.com>
558
559         Build fix.
560
561         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
562         (PrivateBrowsing::ScriptableObject::pluginTest):
563
564 2011-09-02  Anders Carlsson  <andersca@apple.com>
565
566         Move private browsing test to a PluginTest subclass
567         https://bugs.webkit.org/show_bug.cgi?id=67498
568
569         Reviewed by Darin Adler.
570
571         * DumpRenderTree/DumpRenderTree.gypi:
572         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
573         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
574         (pluginGetProperty):
575         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
576         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
577         (PluginTest::NPP_SetValue):
578         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
579         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
580         (PrivateBrowsing::PrivateBrowsing):
581         (PrivateBrowsing::privateBrowsingEnabled):
582         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
583         (PrivateBrowsing::ScriptableObject::hasProperty):
584         (PrivateBrowsing::ScriptableObject::getProperty):
585         (PrivateBrowsing::ScriptableObject::pluginTest):
586         (PrivateBrowsing::NPP_New):
587         (PrivateBrowsing::NPP_GetValue):
588         (PrivateBrowsing::NPP_SetValue):
589         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
590         (NPP_New):
591         (NPP_SetValue):
592         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
593         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
594         * GNUmakefile.am:
595
596 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
597
598         [Qt] Build dependency problems
599         https://bugs.webkit.org/show_bug.cgi?id=38054
600
601         Trivial fix after r94288.
602
603         Rubber-stamped by Andras Becsi.
604
605         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
606         (buildQMakeProject):
607
608 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
609
610         Remove my old e-mail address and add my new one.
611
612         Rubber-stamped by Tor Arne Vestbø.
613
614         * Scripts/webkitpy/common/config/committers.py:
615
616 2011-09-02  Philippe Normand  <pnormand@igalia.com>
617
618         [GTK] run-gtk-tests leaves a zombie Xvfb process
619         https://bugs.webkit.org/show_bug.cgi?id=67389
620
621         Reviewed by Martin Robinson.
622
623         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
624         child process instead of doing shell redirection.
625
626 2011-09-01  Mark Rowe  <mrowe@apple.com>
627
628         Fix the build by adding some more missing return types.
629
630         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
631         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
632
633 2011-09-01  Eric Seidel  <eric@webkit.org>
634
635         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
636         https://bugs.webkit.org/show_bug.cgi?id=66228
637
638         Reviewed by Dirk Pranke.
639
640         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
641         The LeaksViewer tool globs for all *-leaks.txt files.
642         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
643
644         In order to test this I had to fix a limitation in our MockFileSystem.glob
645         method.  However, doing so uncovered a typo and bug in the integration tests.
646         I've disabled the offending integration tests.
647
648         * Scripts/webkitpy/common/system/filesystem_mock.py:
649         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
650         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
651
652 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
653
654         Adds a LayoutTestController method to make it possible to test
655         starting speech input via an API call.
656         https://bugs.webkit.org/show_bug.cgi?id=60170
657
658         Reviewed by Dimitri Glazkov.
659
660         * DumpRenderTree/LayoutTestController.h:
661         * DumpRenderTree/chromium/LayoutTestController.cpp:
662         (LayoutTestController::LayoutTestController):
663         (LayoutTestController::startSpeechInput):
664         * DumpRenderTree/chromium/LayoutTestController.h:
665         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
666         (LayoutTestController::startSpeechInput):
667         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
668         (LayoutTestController::startSpeechInput):
669         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
670         (LayoutTestController::startSpeechInput):
671         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
672         (LayoutTestController::startSpeechInput):
673         * DumpRenderTree/qt/LayoutTestControllerQt.h:
674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
675         (LayoutTestController::startSpeechInput):
676         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
677         (LayoutTestController::startSpeechInput):
678
679 2011-09-01  Tim Horton  <hortont424@gmail.com>
680
681         Fix TestWebKitAPI build on clang-2.0
682
683         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
684
685 2011-09-01  Adam Barth  <abarth@webkit.org>
686
687         Remove unused "extension" parameter from rebaseline gardeningserver handler
688         https://bugs.webkit.org/show_bug.cgi?id=67384
689
690         Reviewed by James Robinson.
691
692         This parameter hasn't done anything in a while.
693
694         * Scripts/webkitpy/tool/commands/rebaseline.py:
695         * Scripts/webkitpy/tool/servers/gardeningserver.py:
696         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
697
698 2011-09-01  Eric Seidel  <eric@webkit.org>
699
700         Unreviewed.
701
702         Fix a typo in unittests.  Unfortunately fixing it
703         caused several assertions.  Just disabling the test
704         instead, since it was providing no value before due to the typo.
705
706         * Scripts/webkitpy/layout_tests/port/test.py:
707
708 2011-09-01  Adam Barth  <abarth@webkit.org>
709
710         Add a "rebaseline" button to the garden-o-matic summary page
711         https://bugs.webkit.org/show_bug.cgi?id=67382
712
713         Reviewed by Dimitri Glazkov.
714
715         As much as we might wish folks to not rebaseline entire test groups at
716         once, the truth is that doing so is a common operation.  Adding a
717         button for this operation is likely to make folks happy.
718
719         This patch also cleans up a bunch of plumbing surrounding failureInfo
720         objects.
721
722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
732
733 2011-09-01  Adam Barth  <abarth@webkit.org>
734
735         garden-o-matic should let the gardener assign blame for a group of test failures
736         https://bugs.webkit.org/show_bug.cgi?id=67379
737
738         Reviewed by Dimitri Glazkov.
739
740         If a group of test failures has a large revision range, the gardener
741         might wish to blame a specific revision for the failure.  Currently,
742         this only effect of assigning blame in this way is to hide the other
743         suspect commits.
744
745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
748
749 2011-09-01  Adam Barth  <abarth@webkit.org>
750
751         Hide garden-o-matic failure table until hover
752         https://bugs.webkit.org/show_bug.cgi?id=67376
753
754         Reviewed by Dimitri Glazkov.
755
756         This patch removes the failure table for build failures (because it
757         does not make sense) and hides the failure table for test groups until
758         the user hovers over the test failure block, reducing visual noise.
759
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
763
764 2011-09-01  Adam Barth  <abarth@webkit.org>
765
766         Switch garden-o-matic from commitData.title to commitData.summary
767         https://bugs.webkit.org/show_bug.cgi?id=67375
768
769         Reviewed by Dimitri Glazkov.
770
771         commitData.title is a string provided by Trac, which isn't great in all
772         cases.  commitData.summary is my attempt to find the most important
773         one-line summary of the commit.  This patch switches garden-o-matic
774         over to summary.
775
776         Also, this patch tweaks a bunch of CSS to tighten up the summary page
777         and reduce visual noise.
778
779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
782
783 2011-09-01  Adam Barth  <abarth@webkit.org>
784
785         Group failing tests in garden-o-matic if there are more than three in a folder
786         https://bugs.webkit.org/show_bug.cgi?id=67373
787
788         Reviewed by Dimitri Glazkov.
789
790         Sometimes a failure will cause many tests in a given directory to fail.
791         When that happens, it's better to list the directory as a single item
792         (with a count) rather than spamming all the test names.
793
794         (This patch also updates a bunch of unit test expected results after my last commit.)
795
796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
801
802 2011-09-01  Adam Barth  <abarth@webkit.org>
803
804         Lower the visual noise from the failing builders display
805         https://bugs.webkit.org/show_bug.cgi?id=67369
806
807         Reviewed by Dimitri Glazkov.
808
809         This patch ensures that the "Building" row in the failing builders
810         display is always last and dims it by 50% to reduce visual noise.  This
811         lets the gardener focus on the actual failures.
812
813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
816
817 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
818
819         [Qt] Build dependency problems
820         https://bugs.webkit.org/show_bug.cgi?id=38054
821
822         Make clean build after the defines are changed.
823
824         Reviewed by Csaba Osztrogonác.
825
826         * Scripts/webkitdirs.pm:
827         (buildQMakeProject):
828
829 2011-08-31  Adam Barth  <abarth@webkit.org>
830
831         Move DumpRenderTree to WebKitPlatformSupport
832         https://bugs.webkit.org/show_bug.cgi?id=67331
833
834         Reviewed by Darin Fisher.
835
836         This patch update DumpRenderTree to account for the WebKitClient =>
837         WebKitPlatformSupport rename.
838
839         * DumpRenderTree/chromium/NotificationPresenter.cpp:
840         (NotificationPresenter::show):
841         * DumpRenderTree/chromium/Task.cpp:
842         (postTask):
843
844 2011-08-31  Eric Seidel  <eric@webkit.org>
845
846         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
847         https://bugs.webkit.org/show_bug.cgi?id=67314
848
849         Reviewed by Adam Barth.
850
851         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
852         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
853         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
854
855         I also moved a bunch of code into dashboard.css which belonged there.
856
857         * QueueStatusServer/handlers/activebots.py: Added.
858         * QueueStatusServer/main.py:
859         * QueueStatusServer/stylesheets/dashboard.css:
860         (.queue_bubble):
861         (.queue_name):
862         (.last_heard_from):
863         (.status_text):
864         (.alive):
865         (.behind):
866         (.dead):
867         * QueueStatusServer/templates/activebots.html: Added.
868         * QueueStatusServer/templates/dashboard.html:
869         * QueueStatusServer/templates/recentstatus.html:
870
871 2011-08-31  Oliver Hunt  <oliver@apple.com>
872
873         Move CheckedArithmeticOperations.cpp to the intended location
874
875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
876         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
877
878 2011-08-31  Elliot Poger  <epoger@google.com>
879
880         add unittest to validate the complete set of Chromium configurations
881         https://bugs.webkit.org/show_bug.cgi?id=67211
882
883         Reviewed by Adam Barth.
884
885         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
886
887 2011-08-31  Nico Weber  <thakis@chromium.org>
888
889         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
890         https://bugs.webkit.org/show_bug.cgi?id=67297
891
892         Reviewed by Tony Chang.
893
894         Explicitly disable smooth scrolling in chromium's DRT.
895
896         * DumpRenderTree/chromium/WebPreferences.cpp:
897         (WebPreferences::applyTo):
898
899 2011-08-31  Oliver Hunt  <oliver@apple.com>
900
901         Add Checked<> tests to windows build
902
903         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
904
905 2011-08-30  Oliver Hunt  <oliver@apple.com>
906
907         Add support for checked arithmetic
908         https://bugs.webkit.org/show_bug.cgi?id=67095
909
910         Reviewed by Sam Weinig.
911
912         Add test cases for Checked<>
913
914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
915         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
916
917 2011-08-31  Adam Barth  <abarth@webkit.org>
918
919         Move summary.html to garden-o-matic.html.
920
921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
925
926 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
927
928         [chromium] DRT linux should pass nativeKeyCode to plugins
929         https://bugs.webkit.org/show_bug.cgi?id=66679
930
931         Reviewed by Tony Chang.
932
933         * DumpRenderTree/chromium/EventSender.cpp:
934         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
935         (simulated) nativeKeyCode for the given input keyboard code.
936
937 2011-08-31  Adam Barth  <abarth@webkit.org>
938
939         Tighen up UI for garden-o-matic tab strip
940         https://bugs.webkit.org/show_bug.cgi?id=67266
941
942         Reviewed by Dimitri Glazkov.
943
944         This patch add CSS to move the tab strip to the edges of the page and
945         to remove some gratuitous border-radius.
946
947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
949
950 2011-08-31  Adam Barth  <abarth@webkit.org>
951
952         garden-o-matic results view shouldn't be horrifically ugly
953         https://bugs.webkit.org/show_bug.cgi?id=67264
954
955         Reviewed by Dimitri Glazkov.
956
957         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
958
959         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
960         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
962
963 2011-08-31  Adam Barth  <abarth@webkit.org>
964
965         garden-o-matic needs a tabstrip
966         https://bugs.webkit.org/show_bug.cgi?id=67263
967
968         Reviewed by Dimitri Glazkov.
969
970         This patch adds a basic tabstrip to garden-o-matic.  The results
971         details view now opens in the "Results" tab, and the user can flip back
972         and forth between the Summary and the Results tab quickly.  There's
973         also a stub for a "Commits" tab, which is disabled.
974
975         This patch isn't the most beautiful in the world, but it gets the ball
976         rolling on a multi-modal UI.
977
978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
983
984 2011-08-31  Ai Makabi  <makabi@google.com>
985
986         Extract reference links from reftest test file.
987         https://bugs.webkit.org/show_bug.cgi?id=66838
988
989         Reviewed by Shinichiro Hamaji.
990
991         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
992         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
993         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
994
995 2011-08-03  Philippe Normand  <pnormand@igalia.com>
996
997         [webkitpy] missing log import in common/net/resultsjsonparser.py
998         https://bugs.webkit.org/show_bug.cgi?id=65606
999
1000         Reviewed by Martin Robinson.
1001
1002         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
1003
1004 2011-08-30  Philippe Normand  <pnormand@igalia.com>
1005
1006         [stylechecker] complains about NULL usage in some gst_structure_ calls
1007         https://bugs.webkit.org/show_bug.cgi?id=67194
1008
1009         Reviewed by Martin Robinson.
1010
1011         Don't warn about NULL in some gst_structure_ calls. 0 can't be
1012         used for these, a proper sentinel is required.
1013
1014         * Scripts/webkitpy/style/checkers/cpp.py:
1015         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1016
1017 2011-08-30  Adam Barth  <abarth@webkit.org>
1018
1019         Remove old-style UI from garden-o-matic
1020         https://bugs.webkit.org/show_bug.cgi?id=67257
1021
1022         Reviewed by Dimitri Glazkov.
1023
1024         This code is nowhere near as awesome as the new hotness.  Let's remove
1025         it so it doesn't weigh us down.
1026
1027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
1028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
1032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
1033
1034 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1035
1036         [WebSocket] update pywebsocket to 0.6b5.
1037         https://bugs.webkit.org/show_bug.cgi?id=66924
1038
1039         Reviewed by Kent Tamura.
1040
1041         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1042         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
1043         0.6b3 or later supports a closing handshake handler and it is useful to
1044         verify client's closing handshake implementation.
1045         0.6b4 supports AbortedByUserException. It is useful to eliminate
1046         unnecessary server warning messages on intended abnormal closures.
1047         0.6b5 supports Python 2.5.1 or Mac 10.5.
1048
1049         * Scripts/webkitpy/thirdparty/__init__.py:
1050         Update download URL and directory path.
1051
1052 2011-08-30  Dan Bernstein  <mitz@apple.com>
1053
1054         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
1055         https://bugs.webkit.org/show_bug.cgi?id=67230
1056
1057         Reviewed by Darin Adler.
1058
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1060         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
1061         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
1062         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
1063         (TestWebKitAPI::TEST):
1064
1065 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
1066
1067         Add MediaSource API to HTMLMediaElement
1068         https://bugs.webkit.org/show_bug.cgi?id=64731
1069
1070         Reviewed by Eric Carlson.
1071
1072         * Scripts/build-webkit:
1073
1074 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1075
1076         Emit last progress notification before calling dispatchDidFinishLoad
1077         https://bugs.webkit.org/show_bug.cgi?id=28851
1078
1079         Reviewed by Adam Barth.
1080
1081         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
1082         Chromium and GTK ports. The first two were simple changes.
1083
1084         Some refactoring was needed in GTK port to assure that the dumps are emitted
1085         correctly and the processing after the page load finished is in the right place.
1086
1087         To detect the load finished, we use the callback for the "load-status" notifier
1088         signal of the top loading frame. And we use the deprecated "load-finished" signal
1089         for dumping (if enabled) the progress finished expected output.
1090
1091         * DumpRenderTree/LayoutTestController.cpp:
1092         (LayoutTestController::LayoutTestController):
1093         (dumpProgressFinishedCallbackCallback):
1094         (LayoutTestController::staticFunctions):
1095         * DumpRenderTree/LayoutTestController.h:
1096         (LayoutTestController::dumpProgressFinishedCallback):
1097         (LayoutTestController::setDumpProgressFinishedCallback):
1098         * DumpRenderTree/chromium/LayoutTestController.cpp:
1099         (LayoutTestController::LayoutTestController):
1100         (LayoutTestController::dumpProgressFinishedCallback):
1101         (LayoutTestController::reset):
1102         * DumpRenderTree/chromium/LayoutTestController.h:
1103         (LayoutTestController::shouldDumpProgressFinishedCallback):
1104         (LayoutTestController::setShouldDumpProgressFinishedCallback):
1105         * DumpRenderTree/chromium/WebViewHost.cpp:
1106         (WebViewHost::didStopLoading):
1107         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1108         (webViewLoadFinished):
1109         (topLoadingFrameLoadFinished):
1110         (webFrameLoadStatusNotified):
1111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1112         (LayoutTestController::reset):
1113         (LayoutTestController::dumpProgressFinishedCallback):
1114         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1115
1116 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
1117
1118         JavaScriptCore does not have a good mechanism for performance
1119         regression testing
1120         https://bugs.webkit.org/show_bug.cgi?id=67177
1121
1122         Reviewed by Darin Adler.
1123         
1124         Added a new script, which allows for testing one, two, or more VMs
1125         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
1126         are interleaved at random to minimize systematics.  The results
1127         that bencher prints includes all possible relevant information about
1128         how bencher was invoked.  Bencher can be easily used to measure
1129         performance changes down to fractions of a percent.
1130         
1131         Bencher also includes experimental support for running benchmarks in
1132         a DumpRenderTree release build.  This works in SunSpider and V8, but
1133         not yet in Kraken.  Running benchmarks in DumpRenderTree more
1134         closely mimics the performance when running in browser.
1135
1136         * Scripts/bencher: Added.
1137
1138 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
1139
1140         DumpRenderTree should begin each test with an empty cookie store
1141         https://bugs.webkit.org/show_bug.cgi?id=63545
1142         <rdar://problem/5666907>
1143
1144         Reviewed by Darin Adler.
1145
1146         * DumpRenderTree/mac/DumpRenderTree.mm:
1147         (resetDefaultsToConsistentValues):
1148         (setDefaultsToConsistentValuesForTesting):
1149         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1150         (LayoutTestController::setAlwaysAcceptCookies):
1151         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1152         (WTR::InjectedBundle::beginTesting):
1153         Use new SPIs to manipulate sessions.
1154
1155 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1156
1157         Unreviewed, rolling out r94055 and r94057.
1158         http://trac.webkit.org/changeset/94055
1159         http://trac.webkit.org/changeset/94057
1160         https://bugs.webkit.org/show_bug.cgi?id=67191
1161
1162         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
1163
1164         * Scripts/webkitpy/thirdparty/__init__.py:
1165
1166 2011-08-30  Adam Barth  <abarth@webkit.org>
1167
1168         Chromium Android should not be a core builder
1169         https://bugs.webkit.org/show_bug.cgi?id=67184
1170
1171         Reviewed by Ryosuke Niwa.
1172
1173         This bot hasn't been consistently green yet because it has never actually run!
1174
1175         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1176         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1177
1178 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1179
1180         [WebSocket] update pywebsocket to 0.6b4.
1181         https://bugs.webkit.org/show_bug.cgi?id=66924
1182
1183         Reviewed by Kent Tamura.
1184
1185         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1186         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
1187         0.6b3 or later supports a closing handshake handler and it is useful to
1188         verify client's closing handshake implementation.
1189         0.6b4 supports AbortedByUserException. It is useful to eliminate
1190         unnecessary server warning messages on intended abnormal closures.
1191
1192         * Scripts/webkitpy/thirdparty/__init__.py:
1193         Update download URL and directory path.
1194
1195 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
1196
1197         sheriffbot "usage" help statements are wrong
1198         https://bugs.webkit.org/show_bug.cgi?id=67170
1199
1200         Reviewed by Adam Barth.
1201
1202         * Scripts/webkitpy/tool/bot/irc_command.py:
1203         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1204         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1205
1206 2011-08-29  Adam Barth  <abarth@webkit.org>
1207
1208         Add support for chomium-mac (non-CoreGraphics) baselines
1209         https://bugs.webkit.org/show_bug.cgi?id=67163
1210
1211         Reviewed by Eric Seidel.
1212
1213         This patch teaches the non-CG chromium-mac bots to look at non-CG
1214         baselines.  However, the patch still leaves CG as the default set of
1215         baselines.
1216
1217         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1218         * Scripts/webkitpy/common/config/build.py:
1219         * Scripts/webkitpy/common/config/build_unittest.py:
1220         * Scripts/webkitpy/layout_tests/port/builders.py:
1221         * Scripts/webkitpy/layout_tests/port/chromium.py:
1222         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1223         * Scripts/webkitpy/layout_tests/port/factory.py:
1224         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1225         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1226         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1227         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1228
1229 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
1230
1231         Small fix in chromium port of new-run-webkit-tests.
1232         https://bugs.webkit.org/show_bug.cgi?id=67078
1233
1234         Reviewed by Dirk Pranke.
1235
1236         * Scripts/webkitpy/layout_tests/port/chromium.py:
1237
1238 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1239
1240         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
1241         r93999.
1242         http://trac.webkit.org/changeset/93987
1243         http://trac.webkit.org/changeset/93992
1244         http://trac.webkit.org/changeset/93995
1245         http://trac.webkit.org/changeset/93998
1246         http://trac.webkit.org/changeset/93999
1247         https://bugs.webkit.org/show_bug.cgi?id=67147
1248
1249         Many failing tests (Requested by ap on #webkit).
1250
1251         * DumpRenderTree/mac/DumpRenderTree.mm:
1252         (setDefaultsToConsistentValuesForTesting):
1253         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1254         (WTR::InjectedBundle::beginTesting):
1255
1256 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
1257
1258         DumpRenderTree should begin each test with an empty cookie store
1259         https://bugs.webkit.org/show_bug.cgi?id=63545
1260         <rdar://problem/5666907>
1261
1262         Reviewed by Darin Adler.
1263
1264         * DumpRenderTree/mac/DumpRenderTree.mm:
1265         (setDefaultsToConsistentValuesForTesting):
1266         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1267         (WTR::InjectedBundle::beginTesting):
1268         Tell WebCore to use a temporary session, starting with a clean cookie store.
1269
1270 2011-08-23  Chris Marrin  <cmarrin@apple.com>
1271
1272         [mac] requestAnimationFrame support for mac port
1273         https://bugs.webkit.org/show_bug.cgi?id=59146
1274
1275         Reviewed by Simon Fraser.
1276
1277         Add support for request-animation-callback flag
1278
1279         * Scripts/build-webkit:
1280
1281 2011-08-27  Peter Beverloo  <peter@chromium.org>
1282
1283         Add a build bot for Chromium with OS(ANDROID)
1284         https://bugs.webkit.org/show_bug.cgi?id=66687
1285
1286         Reviewed by Adam Barth.
1287
1288         * BuildSlaveSupport/build.webkit.org-config/config.json:
1289
1290 2011-08-27  Peter Beverloo  <peter@chromium.org>
1291
1292         Update the master build bot configuration script to properly
1293         deal with the --chromium-android switch.
1294         https://bugs.webkit.org/show_bug.cgi?id=66687
1295
1296         The --chromium-android switch is needed when running
1297         update-webkit-chromium and build-webkit, as it'll tell the
1298         scripts to pull in the right dependencies and cross-compile
1299         WebKit using the Android NDK.
1300
1301         Reviewed by Adam Barth.
1302
1303         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1304
1305 2011-08-27  Peter Beverloo  <peter@chromium.org>
1306
1307         Teach the update and build scripts how to handle dependencies
1308         and cross-compiling rules for the Chromium port on OS(ANDROID).
1309         https://bugs.webkit.org/show_bug.cgi?id=66687
1310
1311         Reviewed by Adam Barth.
1312
1313         * Scripts/build-webkit:
1314         * Scripts/update-webkit:
1315         * Scripts/update-webkit-chromium:
1316         * Scripts/webkitdirs.pm:
1317         (argumentsForConfiguration):
1318         (isChromium):
1319         (isChromiumAndroid):
1320         (determineIsChromiumAndroid):
1321         (buildChromium):
1322
1323 2011-08-26  Adam Barth  <abarth@webkit.org>
1324
1325         garden-o-matic should let me know that I need to run the local server
1326         https://bugs.webkit.org/show_bug.cgi?id=66985
1327
1328         Reviewed by Dimitri Glazkov.
1329
1330         The patch triggers an alert dialog whenever the user tries to use a
1331         feature that requires the local server.
1332
1333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1336
1337 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1338
1339         garden-o-matic summary view should have pretty commit data information.
1340         https://bugs.webkit.org/show_bug.cgi?id=67069
1341
1342         Reviewed by Adam Barth.
1343
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
1346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
1348
1349 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1350
1351         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
1352         https://bugs.webkit.org/show_bug.cgi?id=67066
1353
1354         Reviewed by Adam Barth.
1355
1356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
1357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1358
1359 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
1360
1361         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
1362         https://bugs.webkit.org/show_bug.cgi?id=67041
1363
1364         Reviewed by Martin Robinson.
1365
1366         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
1367         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
1368         when the GTK+ port was being built.
1369
1370         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1371
1372 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1373
1374         Clean up and line up layout in garden-o-matic summary view.
1375         https://bugs.webkit.org/show_bug.cgi?id=67057
1376
1377         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
1378         2) Rearranged DOM structure a bit to accommodate recent changes;
1379         3) Added minimal CSS to line things up.
1380
1381         Reviewed by Adam Barth.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
1384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
1387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
1388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
1390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
1391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
1392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1393
1394 2011-08-26  Alice Liu  <alice.liu@apple.com>
1395
1396         https://bugs.webkit.org/show_bug.cgi?id=66823
1397         Add the request info to the WebPageProxy::CreateNewPage message
1398
1399         Reviewed by Anders Carlsson.
1400
1401         Update function declarations with additional parameter:
1402         * MiniBrowser/gtk/BrowserWindow.c:
1403         (createNewPage):
1404         * MiniBrowser/mac/BrowserWindowController.m:
1405         (createNewPage):
1406         * MiniBrowser/win/BrowserView.cpp:
1407         (createNewPage):
1408         * WebKitTestRunner/TestController.cpp:
1409         (WTR::TestController::createOtherPage):
1410         * WebKitTestRunner/TestController.h:
1411
1412 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
1413
1414         Make show-pretty-diff work on linux
1415         https://bugs.webkit.org/show_bug.cgi?id=67017
1416
1417         Reviewed by Adam Barth.
1418
1419         * Scripts/show-pretty-diff:
1420
1421 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1422
1423         Reorganize garden-o-matic CSS files to match JS-built views.
1424         https://bugs.webkit.org/show_bug.cgi?id=66998
1425
1426         Reviewed by Adam Barth.
1427
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
1429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
1430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
1432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1434
1435 2011-08-25  Adam Barth  <abarth@webkit.org>
1436
1437         garden-o-matic should be able to roll out patches
1438         https://bugs.webkit.org/show_bug.cgi?id=66982
1439
1440         Reviewed by Dimitri Glazkov.
1441
1442         This patch just wires the rollout event through the controller to the
1443         local server, which is already set up to perform rollouts.
1444
1445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1449
1450 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1451
1452         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
1453         https://bugs.webkit.org/show_bug.cgi?id=66951
1454
1455         Reviewed by Andreas Kling.
1456
1457         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
1458         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
1459
1460         * MiniBrowser/qt/BrowserView.cpp:
1461         (BrowserView::resizeEvent):
1462
1463 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1464
1465         garden-o-matic summary view should provide information on builders still in flight.
1466         https://bugs.webkit.org/show_bug.cgi?id=66992
1467
1468         Reviewed by Adam Barth.
1469
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
1472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
1473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
1474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1475
1476 2011-08-25  Adam Barth  <abarth@webkit.org>
1477
1478         webkit-patch rebaseline-expectations don't work when run outside the root
1479         https://bugs.webkit.org/show_bug.cgi?id=66966
1480
1481         Reviewed by Eric Seidel.
1482
1483         Turns out tool.path() used to be relative, which caused problems when
1484         running webkit-patch outside the root directory.  This patch makes it
1485         absolute.  I checked all callers, and they all appear to want this
1486         behavior.
1487
1488         It was unclear to me how to test this change because we only really
1489         have a testing strategy for webkitpy, not for the main script.
1490
1491         * Scripts/webkit-patch:
1492
1493 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1494
1495         garden-o-matic summary needs a mock view that could be used for working on styling
1496         https://bugs.webkit.org/show_bug.cgi?id=66971
1497
1498         Reviewed by Adam Barth.
1499
1500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
1501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
1502
1503 2011-08-25  Anders Carlsson  <andersca@apple.com>
1504
1505         Return the correct value for NPNVsupportsCarbonBool
1506         https://bugs.webkit.org/show_bug.cgi?id=66964
1507
1508         Add a test.
1509
1510         Reviewed by Adam Roben.
1511
1512         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1513         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
1514         (SupportsCarbonEventModel::SupportsCarbonEventModel):
1515         (SupportsCarbonEventModel::testConvert):
1516         (SupportsCarbonEventModel::runTest):
1517         (SupportsCarbonEventModel::NPP_New):
1518
1519 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1520
1521         garden-o-matic summary view should not be broken.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1524         (table.comparison): Added more specificity.
1525
1526 2011-08-25  Adam Barth  <abarth@webkit.org>
1527
1528         This command has been broken for a while.  This patch updates the
1529         callsite to the new API.
1530
1531         * Scripts/webkitpy/tool/commands/rebaseline.py:
1532
1533 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1534
1535         garden-o-matic needs a way to report where and how tests are failing in the summary view.
1536         https://bugs.webkit.org/show_bug.cgi?id=66955
1537
1538         Introduce FailureGrid, your one-stop failure-indicating destination. 
1539
1540         Reviewed by Adam Barth.
1541
1542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
1543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
1544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
1545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
1546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
1548
1549 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
1550
1551         Add myself to the committers list
1552         https://bugs.webkit.org/show_bug.cgi?id=66941
1553
1554         Reviewed by Andreas Kling.
1555
1556         * Scripts/webkitpy/common/config/committers.py:
1557
1558 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1559
1560         Unreviewed, rolling out r93767.
1561         http://trac.webkit.org/changeset/93767
1562         https://bugs.webkit.org/show_bug.cgi?id=66931
1563
1564         Broke Qt bot. (Requested by yutak on #webkit).
1565
1566         * Scripts/webkitpy/thirdparty/__init__.py:
1567
1568 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
1569
1570         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
1571         https://bugs.webkit.org/show_bug.cgi?id=66924
1572
1573         Reviewed by Kent Tamura.
1574
1575         * Scripts/webkitpy/thirdparty/__init__.py:
1576
1577 2011-08-24  Adam Barth  <abarth@webkit.org>
1578
1579         The user can't close the details view in garden-o-matic
1580         https://bugs.webkit.org/show_bug.cgi?id=66911
1581
1582         Reviewed by Dimitri Glazkov.
1583
1584         In addition to adding a close button, this patch changes the test
1585         selector to use a <select> element and refactors the test selector to
1586         share code with the builder selector.
1587
1588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1592
1593 2011-08-24  James Robinson  <jamesr@chromium.org>
1594
1595         [chromium] Stacktrace not in test output when a test crashes
1596         https://bugs.webkit.org/show_bug.cgi?id=66806
1597
1598         Reviewed by Dirk Pranke.
1599
1600         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
1601         trace.
1602
1603         * Scripts/webkitpy/layout_tests/port/chromium.py:
1604
1605 2011-08-24  Adam Barth  <abarth@webkit.org>
1606
1607         Remove empty directory.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
1610
1611 2011-08-24  Adam Barth  <abarth@webkit.org>
1612
1613         Finish writing up details-view in garden-o-matic
1614         https://bugs.webkit.org/show_bug.cgi?id=66891
1615
1616         Reviewed by Dimitri Glazkov.
1617
1618         This patch mostly just copies a bunch of CSS from main.css to
1619         summary.css.  Presumably we'll delete main.css soon.
1620
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1626
1627 2011-08-24  James Robinson  <jamesr@chromium.org>
1628
1629         Some compositing LayoutTests flakily crashing on Mac 10.6
1630         https://bugs.webkit.org/show_bug.cgi?id=66740
1631
1632         Reviewed by Adam Barth.
1633
1634         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
1635         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
1636         chromium configuration.
1637
1638         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1639         (NPP_Destroy):
1640
1641 2011-08-24  Anton D'Auria  <adauria@apple.com>
1642
1643         No review necessary.
1644
1645         Adding myself to list of committers.
1646
1647         * Scripts/webkitpy/common/config/committers.py:
1648
1649 2011-08-24  Avi Drissman  <avi@google.com>
1650
1651         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
1652         https://bugs.webkit.org/show_bug.cgi?id=66875
1653
1654         Reviewed by James Robinson.
1655
1656         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1657         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1658
1659 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1660
1661         Make notifications appear in time order again.
1662         https://bugs.webkit.org/show_bug.cgi?id=66815
1663
1664         Reviewed by Adam Barth.
1665
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
1667         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
1668
1669 2011-08-23  James Robinson  <jamesr@chromium.org>
1670
1671         [chromium] Need a way to test lost compositor context recovery
1672         https://bugs.webkit.org/show_bug.cgi?id=66820
1673
1674         Reviewed by Kenneth Russell.
1675
1676         Exposes a LayoutTestController interface in chromium to simulate a
1677         lost compositor context.
1678
1679         * DumpRenderTree/chromium/LayoutTestController.cpp:
1680         (LayoutTestController::LayoutTestController):
1681         (LayoutTestController::loseCompositorContext):
1682         * DumpRenderTree/chromium/LayoutTestController.h:
1683
1684 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1685
1686         Change garden-o-matic frontend builder array to be a configuration map.
1687         https://bugs.webkit.org/show_bug.cgi?id=66816
1688
1689         Reviewed by Adam Barth.
1690
1691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
1692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
1693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
1694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
1695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
1696
1697 2011-08-23  Cary Clark  <caryclark@google.com>
1698
1699         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
1700         https://bugs.webkit.org/show_bug.cgi?id=66803
1701
1702         This fixes the WebKit Canaries, in particular avoids a crash on tests
1703         like css1/basic/comments.html.
1704
1705         Reviewed by James Robinson.
1706
1707         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1708         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1709         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
1710         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
1711         and treated it as if it were a CGContextRef.
1712
1713 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1714
1715         Fix mergeChangeLogs test on native windows
1716         https://bugs.webkit.org/show_bug.cgi?id=66797
1717
1718         Reviewed by Adam Roben.
1719
1720         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
1721         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
1722
1723         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1724         (writeTempFile):
1725
1726 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1727
1728         garden-o-matic relative time is wrong and updates too frequently.
1729         https://bugs.webkit.org/show_bug.cgi?id=66802
1730
1731         Reviewed by Adam Barth.
1732
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
1735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
1736
1737 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1738
1739         Add missing quotes around filenames in mergeChangeLogs
1740         https://bugs.webkit.org/show_bug.cgi?id=66794
1741
1742         Reviewed by Adam Roben.
1743
1744         * Scripts/VCSUtils.pm:
1745         (mergeChangeLogs):
1746
1747 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1748
1749         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
1750         https://bugs.webkit.org/show_bug.cgi?id=49080
1751
1752         Reviewed by Adam Roben.
1753
1754         Use the string form of pipe open instead (like we do at all other places).
1755
1756         * Scripts/VCSUtils.pm:
1757         (mergeChangeLogs):
1758
1759 2011-08-23  Adam Barth  <abarth@webkit.org>
1760
1761         garden-o-matic summary should be able to examine failures
1762         https://bugs.webkit.org/show_bug.cgi?id=66748
1763
1764         Reviewed by Dimitri Glazkov.
1765
1766         This patch refactors a bunch of code from summary.js to independent
1767         controllers in controllers.js.  This patch also contains the first
1768         iteration of binding the "examine" event to a the behavior showing the
1769         details view for the tests.  There's more work to do here to make this
1770         work properly (and elegantly), but this patch is a start.
1771
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1781
1782 2011-08-23  Adam Barth  <abarth@webkit.org>
1783
1784         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
1785         https://bugs.webkit.org/show_bug.cgi?id=66737
1786
1787         Reviewed by Steve Block.
1788
1789         This directory doesn't exist anymore now that the Android port shares
1790         more code with Chromium.
1791
1792         * Scripts/webkitpy/common/config/build.py:
1793
1794 2011-08-22  Eric Seidel  <eric@webkit.org>
1795
1796         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
1797         I won't have ssh access to the bot again for a couple days, so
1798         attempting to fix by changing this script.  If this doesn't
1799         work we'll just live with the it hung for now.
1800
1801         Unreviewed.
1802
1803         * EWSTools/start-queue.sh:
1804
1805 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1806
1807         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
1808         https://bugs.webkit.org/show_bug.cgi?id=66727
1809
1810         Reviewed by Adam Barth.
1811
1812         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
1813             in which case the serializer treats all expectations as unparsed.
1814         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
1815
1816 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1817
1818         Update unit test expectations after r93530.
1819
1820         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
1821         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1822
1823 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1824
1825         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
1826         https://bugs.webkit.org/show_bug.cgi?id=66705
1827
1828         Reviewed by Adam Barth.
1829
1830         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
1831         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
1832
1833 2011-08-22  James Robinson  <jamesr@chromium.org>
1834
1835         [chromium] Update builder names for chromium gpu bots due to CG switchover
1836         https://bugs.webkit.org/show_bug.cgi?id=66693
1837
1838         Reviewed by Dirk Pranke.
1839
1840         Update the port and builder names for the chromium mac gpu bots to
1841         account for the CG transition.
1842
1843         * Scripts/webkitpy/layout_tests/port/builders.py:
1844
1845 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
1846
1847         fix the GPU bot names on the layout test dashboard
1848         https://bugs.webkit.org/show_bug.cgi?id=66697
1849
1850         Reviewed by Dimitri Glazkov.
1851
1852         * TestResultServer/static-dashboards/builders.js:
1853
1854 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1855
1856         garden-o-matic's relative time display should be updated regularly.
1857         https://bugs.webkit.org/show_bug.cgi?id=66682
1858
1859         Reviewed by Adam Barth.
1860
1861         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
1862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
1863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
1864
1865 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1866
1867         Pass --makeargs of build-webkit to chromium linux builder
1868         https://bugs.webkit.org/show_bug.cgi?id=66361
1869
1870         Reviewed by Tony Chang.
1871
1872         * Scripts/build-webkit:
1873         * Scripts/webkitdirs.pm:
1874         (buildChromiumMakefile):
1875         (buildChromium):
1876
1877 2011-08-22  Peter Beverloo  <peter@chromium.org>
1878
1879         Add myself to the contributor list.
1880         https://bugs.webkit.org/show_bug.cgi?id=66674
1881
1882         Reviewed by Tony Gentilcore.
1883
1884         * Scripts/webkitpy/common/config/committers.py:
1885
1886 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
1887
1888         [Qt] ImageDiff does not consider --tolerance
1889         https://bugs.webkit.org/show_bug.cgi?id=66299
1890
1891         Reviewed by Csaba Osztrogonác.
1892
1893         * DumpRenderTree/qt/ImageDiff.cpp:
1894         (main):
1895
1896 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
1897
1898         Update contributor list.
1899
1900         Reviewed by Zoltan Herczeg.
1901
1902         * Scripts/webkitpy/common/config/committers.py:
1903
1904 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1905
1906         [ORWT] Fix --reset-results --add-platform-exceptions combo
1907         https://bugs.webkit.org/show_bug.cgi?id=65464
1908
1909         Reviewed by Csaba Osztrogonác.
1910
1911         * Scripts/old-run-webkit-tests:
1912
1913 2011-08-20  Adam Barth  <abarth@webkit.org>
1914
1915         garden-o-matic summary.html should have UI for examining failures
1916         https://bugs.webkit.org/show_bug.cgi?id=66625
1917
1918         Reviewed by Dimitri Glazkov.
1919
1920         This patch introduces the notion of UI actions and converts our
1921         existing manual <button> manipulation with this new abstraction.  The
1922         patch also adds an Examine button to failure notifications.  In a
1923         future patch, I'll add a controller that wires this button up to
1924         something useful.
1925
1926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
1930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1934
1935 2011-08-20  Adam Barth  <abarth@webkit.org>
1936
1937         garden-o-matic summary page should indiciate compile failures
1938         https://bugs.webkit.org/show_bug.cgi?id=66624
1939
1940         Reviewed by Dimitri Glazkov.
1941
1942         This patch creates a notification-based UI for build failures.  The new
1943         UI displays the same information that used to be displayed in the
1944         infobar.  There's lots of room for improvement in surfacing more
1945         information, but this is a start.
1946
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1950
1951 2011-08-19  James Robinson  <jamesr@chromium.org>
1952
1953         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
1954         https://bugs.webkit.org/show_bug.cgi?id=66606
1955
1956         Reviewed by Dirk Pranke.
1957
1958         The chromium GPU configuration does not (currently) contain any tests
1959         incompatible with --experimental-fully-parallel, and this flag is a
1960         significan speedup because of the directory canvas/philip/tests which
1961         contains 802 tests in the same directory. Setting this option by
1962         default on this configuration is a 2x speed in release, 44s to 22s,
1963         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
1964
1965         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1966         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1967         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1968
1969 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1970
1971         Unreviewed, rolling out r93426.
1972         http://trac.webkit.org/changeset/93426
1973         https://bugs.webkit.org/show_bug.cgi?id=66607
1974
1975         Broke the Mac build by not building gtest.framework anymore
1976         (Requested by andersca on #webkit).
1977
1978         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1979
1980 2011-08-19  James Robinson  <jamesr@chromium.org>
1981
1982         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
1983         https://bugs.webkit.org/show_bug.cgi?id=66603
1984
1985         Reviewed by Dirk Pranke.
1986
1987         The various ChromiumGpu ports should use the same child worker
1988         selection logic as other ports so they can run with full
1989         parallelization on multicore systems.
1990
1991         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1992         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1993
1994 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
1995
1996         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
1997         https://bugs.webkit.org/show_bug.cgi?id=66570
1998
1999         Reviewed by Mihai Parparita.
2000
2001         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2002         (WebThemeControlDRTWin::draw):
2003         (WebThemeControlDRTWin::drawTextField):
2004         (WebThemeControlDRTWin::drawProgressBar):
2005         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2006
2007 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2008
2009         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
2010         https://bugs.webkit.org/show_bug.cgi?id=66521
2011
2012         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
2013
2014         Reviewed by David Levin.
2015
2016         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
2017
2018 2011-08-19  Adam Roben  <aroben@apple.com>
2019
2020         Add project file changes I left out in r93417
2021
2022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2023
2024 2011-08-19  Adam Roben  <aroben@apple.com>
2025
2026         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
2027
2028         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
2029         NSScreen
2030
2031         Reviewed by Anders Carlsson.
2032
2033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2034
2035         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2036         (-[SimpleObject setValue:]): Original implementation.
2037
2038         (TestWebKitAPI::setValue2):
2039         (TestWebKitAPI::setValue3):
2040         Swizzled implementations.
2041
2042         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
2043         instance method.
2044
2045         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
2046         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2047         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
2048         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
2049
2050 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
2051
2052         Fix _path_to_apache() error reporting
2053         https://bugs.webkit.org/show_bug.cgi?id=66486
2054
2055         Reviewed by Ryosuke Niwa.
2056
2057         * Scripts/webkitpy/layout_tests/port/webkit.py:
2058
2059 2011-08-19  Adam Roben  <aroben@apple.com>
2060
2061         Windows build fix after r93404
2062
2063         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
2064
2065 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
2066
2067         Add leandrogracia to the committers list
2068         https://bugs.webkit.org/show_bug.cgi?id=66552
2069
2070         Also fix line endings in file.
2071
2072         No reviewed required.
2073
2074         * Scripts/webkitpy/common/config/committers.py:
2075
2076 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
2077
2078         Fix compilation issue in WebKitTestRunner
2079         https://bugs.webkit.org/show_bug.cgi?id=66554
2080
2081         Reviewed by Martin Robinson.
2082
2083         * WebKitTestRunner/PixelDumpSupport.cpp:
2084
2085 2011-08-19  Adam Roben  <aroben@apple.com>
2086
2087         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
2088
2089         This will make it easier to write other WebKit-agnostic tests
2090
2091         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
2092         code in other WebKit-agnostic tests
2093
2094         Reviewed by Anders Carlsson.
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2097
2098         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
2099         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
2100         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
2101         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
2102         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
2103         WebKitAgnosticTest handles for us.
2104         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
2105
2106         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
2107         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
2108         DynamicDeviceScaleFactor::runTest.
2109
2110         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
2111         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
2112         DynamicDeviceScaleFactor.WebKit.
2113         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
2114         DynamicDeviceScaleFactor.WebKit2.
2115
2116 2011-08-19  Adam Roben  <aroben@apple.com>
2117
2118         Clean up #includes in TestWebKitAPI
2119
2120         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
2121
2122         Reviewed by Anders Carlsson.
2123
2124         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
2125         files and WebKit/WebKit.h for ObjC files.
2126
2127         * TestWebKitAPI/InjectedBundleController.cpp:
2128         * TestWebKitAPI/JavaScriptTest.h:
2129         * TestWebKitAPI/PlatformUtilities.h:
2130         * TestWebKitAPI/PlatformWebView.h:
2131         * TestWebKitAPI/Test.h:
2132         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2133         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2134         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2135         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2136         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2137         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2138         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2139         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2140         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2141         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2142         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2143         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2144         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2145         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2146         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2147         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2148         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2149         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2150         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2151         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2152         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2153         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2154         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2155         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2156         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2157         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2158         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2159         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2160         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2161         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2162         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2163         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2164         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2165         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2166         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2167         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2168         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2169         * TestWebKitAPI/TestsController.cpp:
2170         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2171         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
2172         #includes since it is no longer a special header.
2173
2174 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
2175
2176         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
2177         https://bugs.webkit.org/show_bug.cgi?id=64886
2178
2179         Temporarily disable the http locking to work around the issue.
2180         I'm not actually sure if this is going to work or improve things
2181         much.
2182
2183         Reviewed by Ryosuke Niwa.
2184
2185         * Scripts/webkitpy/layout_tests/port/mac.py:
2186
2187 2011-08-18  Tony Chang  <tony@chromium.org>
2188
2189         add embedded png checksums to WebKitTestRunner
2190         https://bugs.webkit.org/show_bug.cgi?id=66494
2191
2192         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
2193         some code from DRT and adds it to the WebKitTestRunner.
2194
2195         Reviewed by Darin Adler.
2196
2197         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
2198         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
2199         * WebKitTestRunner/GNUmakefile.am: Add new files
2200         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
2201         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
2202         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
2203         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2204         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2205         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2206         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2207         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2208         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2209         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
2210
2211 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
2212
2213         https://bugs.webkit.org/show_bug.cgi?id=47240
2214
2215         Fixed a cygwin path problem in the chromium port of diff_image;
2216         Also made the return values of the diff_image function more consistent.
2217
2218         Reviewed by Dirk Pranke.
2219
2220         * Scripts/webkitpy/layout_tests/port/chromium.py:
2221
2222 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
2223
2224         [GTK] Fix compilation problems with deprecations in gtk+
2225         https://bugs.webkit.org/show_bug.cgi?id=66073
2226
2227         Reviewed by Martin Robinson.
2228
2229         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2230         (main): G_CONST_RETURN was deprecated
2231         * GtkLauncher/main.c:
2232         (createWindow): Added gtk_box_new conditional compilation for
2233         gtk+-3.
2234         * MiniBrowser/gtk/BrowserWindow.c:
2235         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
2236         are just supporting gtk+-3 for WebKit2.
2237
2238 2011-08-18  Anders Carlsson  <andersca@apple.com>
2239
2240         Fix libc++ C++0x build
2241         https://bugs.webkit.org/show_bug.cgi?id=66479
2242
2243         Reviewed by Adam Roben.
2244
2245         Add missing includes.
2246
2247         * DumpRenderTree/LayoutTestController.cpp:
2248         * DumpRenderTree/mac/CheckedMalloc.cpp:
2249
2250 2011-08-18  Adam Roben  <aroben@apple.com>
2251
2252         Test that WebKit updates style when a WebView is moved between differently-scaled windows
2253
2254         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2255         WebView is moved between windows with different backing scale factors
2256
2257         Reviewed by Anders Carlsson.
2258
2259         * TestWebKitAPI/JavaScriptTest.cpp:
2260         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
2261         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
2262         gtest's built-in error messages.
2263
2264         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
2265         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
2266         those overloads.
2267
2268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2269
2270         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
2271         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
2272         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
2273         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
2274         (TestWebKitAPI::setPageLoaderClient): Set up the client.
2275         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
2276         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
2277         SyntheticBackingScaleFactorWindow and returns it.
2278         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
2279         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
2280         window, is moved to a differently-scaled window, and is taken out of the window.
2281         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
2282         WebKit1 and WebKit2.
2283         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
2284
2285         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
2286
2287         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
2288         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
2289
2290         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
2291         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
2292         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
2293         initializer.
2294         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
2295
2296         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
2297         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
2298         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
2299
2300 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2301
2302         https://bugs.webkit.org/show_bug.cgi?id=66425
2303         check-webkit-style should detect incorrectly formatted file change descriptions.
2304         Description, if present, should be separated from colon with a space.
2305
2306         Reviewed by David Levin.
2307
2308         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
2309         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
2310
2311 2011-08-18  Adam Barth  <abarth@webkit.org>
2312
2313         webkit-patch pretty-diff should be shown in main help
2314         https://bugs.webkit.org/show_bug.cgi?id=66404
2315
2316         Reviewed by Dimitri Glazkov.
2317
2318         As requested by dglazkov.
2319
2320         * Scripts/webkitpy/tool/commands/prettydiff.py:
2321
2322 2011-08-17  Dmitry Lomov  <dslomov@google.com>
2323
2324         https://bugs.webkit.org/show_bug.cgi?id=66400
2325         Fix TestWebKitAPI build on Mac OS.
2326
2327         Reviewed by David Levin.
2328
2329         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
2330
2331 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2332
2333         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
2334         https://bugs.webkit.org/show_bug.cgi?id=66427
2335
2336         Reviewed by Adam Barth.
2337
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
2339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
2340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
2341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
2343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
2352         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
2353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
2354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
2355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
2356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
2357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
2360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
2367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
2375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
2401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
2421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
2425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
2430         ():
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
2438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
2439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
2440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
2441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
2442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
2443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
2451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
2452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
2453
2454 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
2455
2456         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
2457         https://bugs.webkit.org/show_bug.cgi?id=65877
2458
2459         Reviewed by Eric Seidel.
2460
2461         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2462
2463 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2464
2465         Remove base.keys and replace it with Object.keys.
2466         https://bugs.webkit.org/show_bug.cgi?id=66422
2467
2468         Reviewed by Adam Barth.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
2473
2474 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2475
2476         garden-o-matic Summary view should have items in descending chronological order.
2477         https://bugs.webkit.org/show_bug.cgi?id=66403
2478
2479         Reviewed by Adam Barth.
2480
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
2484
2485 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2486
2487         Fix a few errors in garden-o-matic frontend unit tests.
2488         https://bugs.webkit.org/show_bug.cgi?id=66421
2489
2490         Reviewed by Adam Barth.
2491
2492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
2493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
2495
2496 2011-08-17  Adam Barth  <abarth@webkit.org>
2497
2498         Update Tools to account for (CG) being added to Chromium builder names
2499         https://bugs.webkit.org/show_bug.cgi?id=66410
2500
2501         Reviewed by Adam Barth.
2502
2503         Some of these names will change back once we turn on Skia bots.
2504
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2508         * Scripts/webkitpy/layout_tests/port/builders.py:
2509         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2510         * TestResultServer/static-dashboards/builders.js:
2511         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2512
2513 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2514
2515         Wire up relative time to garden-o-matic summary view.
2516         https://bugs.webkit.org/show_bug.cgi?id=66343
2517
2518         Reviewed by Adam Barth.
2519
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
2522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
2523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
2524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
2525
2526 2011-08-17  Adam Roben  <aroben@apple.com>
2527
2528         Make run-api-tests run tests in alphabetical order
2529
2530         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
2531
2532         Reviewed by David Kilzer.
2533
2534         * Scripts/run-api-tests:
2535         (runAllTests):
2536         (runAllTestsInSuite):
2537         Sort the lists of tests and suites before iterating over them.
2538
2539 2011-08-17  Adam Barth  <abarth@webkit.org>
2540
2541         garden-o-matic should be able to rebaseline expected failures
2542         https://bugs.webkit.org/show_bug.cgi?id=66204
2543
2544         Reviewed by Dimitri Glazkov.
2545
2546         This patch introduces a new view for displaying expect, actual, and
2547         differences between results.  The new view also has a fledgling
2548         controller that handles some basic operations.  The new view is
2549         exercised by rebaseline.html, which lets you rebaselines expected
2550         failures, but the new view is not fully integrated into
2551         garden-o-matic.html
2552
2553         More patches will be required to make this stuff fully working, but
2554         this patch was already somewhat spiraling out of control.  Hopefully
2555         this patch will serve as a good starting point for further development.
2556
2557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
2559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
2560         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
2564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2565         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2566         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
2568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
2569
2570 2011-08-16  Chang Shu  <cshu@webkit.org>
2571
2572         Support reset in WebCore::Internals
2573         https://bugs.webkit.org/show_bug.cgi?id=66307
2574
2575         Reviewed by Dimitri Glazkov.
2576
2577         Added call to resetInternalsObject in DRT.
2578
2579         * DumpRenderTree/chromium/TestShell.cpp:
2580         (TestShell::resetTestController):
2581         * DumpRenderTree/mac/DumpRenderTree.mm:
2582         (resetWebViewToConsistentStateBeforeTesting):
2583         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2584         (WebCore::WebPage::resetSettings):
2585
2586 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
2587
2588         Add a new build slave for the Qt port on Mac OS SnowLeopard.
2589         https://bugs.webkit.org/show_bug.cgi?id=66392
2590
2591         Modify the config file to include the new build slave.
2592
2593         Reviewed by Adam Roben.
2594
2595         * BuildSlaveSupport/build.webkit.org-config/config.json:
2596
2597 2011-08-17  Sam White  <samuel.white@rochester.edu>
2598
2599         AccessibilityObject levels are inconsistent
2600         https://bugs.webkit.org/show_bug.cgi?id=66180
2601         
2602         Added the ability to get numeric attribute values using numberAttributeValue. This
2603         function complements the existing stringAttributeValue and boolAttributeValue functions.
2604         The addition of numberAttributeValue was necessary because the stringAttributeValue
2605         function does a type check and will only return strings. This limitation made it
2606         impossible to get values for attributes that returned an NSNumber.
2607
2608         Reviewed by Chris Fleizach.
2609
2610         * DumpRenderTree/AccessibilityUIElement.cpp:
2611         (numberAttributeValueCallback):
2612         (AccessibilityUIElement::getJSClass):
2613         * DumpRenderTree/AccessibilityUIElement.h:
2614         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2615         (AccessibilityUIElement::numberAttributeValue):
2616         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2617         (AccessibilityUIElement::numberAttributeValue):
2618         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2619         (AccessibilityUIElement::numberAttributeValue):
2620
2621 2011-08-17  Adam Roben  <aroben@apple.com>
2622
2623         Tell Trac logs always to display all specified revisions in a single page
2624
2625         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
2626         revisions than that.
2627
2628         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
2629         relevant revisions
2630
2631         Reviewed by Daniel Bates.
2632
2633         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2634         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
2635         a single page.
2636
2637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
2639         Updated tests for the above.
2640
2641 2011-08-17  Adam Roben  <aroben@apple.com>
2642
2643         Fix TestFailures's link to file a bug about TestFailures itself
2644
2645         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
2646         bug about itself is broken
2647
2648         Reviewed by Dan Bates.
2649
2650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2651         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
2652         the host from the path.
2653
2654 2011-08-17  Adam Roben  <aroben@apple.com>
2655
2656         Teach TestFailures to ignore unbelievably short test runs
2657
2658         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
2659         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
2660
2661         Reviewed by Dan Bates.
2662
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2664         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
2665         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
2666         that caused it not to run any tests at all (as happened for a while due to
2667         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
2668
2669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2670         Test for the above.
2671
2672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2673         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
2674
2675 2011-08-16  Adam Barth  <abarth@webkit.org>
2676
2677         Add a CG qualifier similar to the GPU qualifier
2678         https://bugs.webkit.org/show_bug.cgi?id=66359
2679
2680         Reviewed by Eric Seidel.
2681
2682         Once we have a Skia configuration on Chromium Mac, we'll use this CG
2683         qualifier to note that expectations apply only to the CG configuration.
2684
2685         * Scripts/webkitpy/layout_tests/port/chromium.py:
2686         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2687
2688 2011-08-16  Eric Seidel  <eric@webkit.org>
2689
2690         REGRESSION(92717): WinPort needs to parse version information from port_name
2691         https://bugs.webkit.org/show_bug.cgi?id=66325
2692
2693         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
2694
2695         * Scripts/webkitpy/layout_tests/port/mac.py:
2696         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2697
2698 2011-08-16  Adam Barth  <abarth@webkit.org>
2699
2700         Change webkit-patch analyze-baselines to print in a more unix-friendly way
2701         https://bugs.webkit.org/show_bug.cgi?id=66349
2702
2703         Reviewed by James Robinson.
2704
2705         As requested by jamesr.
2706
2707         * Scripts/webkitpy/tool/commands/rebaseline.py:
2708
2709 2011-08-16  Eric Seidel  <eric@webkit.org>
2710
2711         REGRESSION(92717): WinPort needs to parse version information from port_name
2712         https://bugs.webkit.org/show_bug.cgi?id=66325
2713
2714         Reviewed by Adam Barth.
2715
2716         WinPort didn't have any port_name parsing logic.
2717         Seemed it was best to just share the logic from MacPort.
2718         Sharing the logic from MacPort seemed easiest with a shared superclass.
2719         Once I created ApplePort (the superclass) there was a bunch of logic to share.
2720         I found LeakDetector was just in the way when switching back and forth
2721         between win.py and mac.py so I moved it into its own file.
2722
2723         The only logic change here is that WinPort should now be
2724         able to parse port_name values like MacPort (and other ports)
2725         can.  The fact that ports do this in their constructors is
2726         wrong and a source of many bugs.  But at least now WinPort
2727         matches the status-quo.
2728
2729         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
2730         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
2731         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
2732         * Scripts/webkitpy/layout_tests/port/mac.py:
2733         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2734         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2735         * Scripts/webkitpy/layout_tests/port/win.py:
2736         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2737
2738 2011-08-16  Adam Barth  <abarth@webkit.org>
2739
2740         Add webkit-patch analyze-baselines, as requested by jamesr.
2741
2742         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2743         * Scripts/webkitpy/tool/commands/rebaseline.py:
2744
2745 2011-08-16  Adam Barth  <abarth@webkit.org>
2746
2747         Fold bulk-optimize-baselines into optimize-baselines
2748         https://bugs.webkit.org/show_bug.cgi?id=66345
2749
2750         Reviewed by James Robinson.
2751
2752         bulk-optimize-baselines is now a superset of optimize-baselines, so
2753         they can be combined.
2754
2755         * Scripts/webkitpy/tool/commands/rebaseline.py:
2756
2757 2011-08-16  Adam Barth  <abarth@webkit.org>
2758
2759         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
2760         https://bugs.webkit.org/show_bug.cgi?id=66334
2761
2762         Reviewed by Tony Chang.
2763
2764         This patch moves us closer to switching the Chromium port from
2765         CoreGraphics to Skia.  This patch teaches our tools that the current
2766         Chromium Mac configuration is actually chromium-cg-mac, which makes
2767         room for a future chromium-mac configuration that uses Skia.
2768
2769         Shortly after this patch lands, I'll do a server-side move of the
2770         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
2771         and chromium-cg-mac-leopard.
2772
2773         * BuildSlaveSupport/build.webkit.org-config/config.json:
2774         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2775         * Scripts/webkitpy/common/config/build.py:
2776         * Scripts/webkitpy/common/config/build_unittest.py:
2777         * Scripts/webkitpy/layout_tests/port/base.py:
2778         * Scripts/webkitpy/layout_tests/port/builders.py:
2779         * Scripts/webkitpy/layout_tests/port/chromium.py:
2780         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2781         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2782         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2783         * Scripts/webkitpy/layout_tests/port/factory.py:
2784         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2785         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2786         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2787         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2788         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2789         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2790         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2791
2792 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2793
2794         garden-o-matic frontend needs a friendly relative time description method.
2795         https://bugs.webkit.org/show_bug.cgi?id=66324
2796
2797         Reviewed by Adam Barth.
2798
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
2800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
2801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
2802
2803 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2804
2805         Summary view should not add multiple entries for the same test failure.
2806         https://bugs.webkit.org/show_bug.cgi?id=66318
2807
2808         Reviewed by Adam Barth.
2809
2810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
2811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
2812             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
2813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2814
2815 2011-08-16  Adam Roben  <aroben@apple.com>
2816
2817         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
2818
2819         The basic strategy here is that once a test has failed or passed many times in a row we
2820         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
2821         in many fewer false positives than our current behavior.
2822
2823         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
2824         flaky, including tests that failed for a while but then were fixed
2825
2826         Reviewed by Dan Bates.
2827
2828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
2829         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
2830         number of non-too-many-failure builds we've seen.
2831         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
2832         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
2833         tests, keep track of how many times they have passed or failed in a row. If they pass or
2834         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
2835         considered flaky it doesn't matter how many times it passes or fails.)
2836
2837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
2838         Added tests for the above.
2839
2840 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2841
2842         garden-o-matic needs a summary view with actions for each problem.
2843         https://bugs.webkit.org/show_bug.cgi?id=66144
2844
2845         Reviewed by Adam Barth.
2846
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
2853
2854 2011-08-16  Dean Jackson  <dino@apple.com>
2855
2856         Adding Ted "hober" O'Connor as a non-committing contributor.
2857
2858         * Scripts/webkitpy/common/config/committers.py:
2859
2860 2011-08-16  Adam Roben  <aroben@apple.com>
2861
2862         Teach TestFailures how to interpret unfinished test runs
2863
2864         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
2865         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
2866
2867         Reviewed by David Kilzer.
2868
2869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2870         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
2871         rather than "isStarted" so that we don't count builds for which the test run never finished.
2872         Bumped the cache version to evict old, buggy cached data.
2873
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2875         Added a test for the above, and made a somewhat synthetic test more realistic by including
2876         more of the actual JSON data from build.webkit.org.
2877
2878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2879         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
2880         cached data.
2881
2882 2011-08-16  Adam Roben  <aroben@apple.com>
2883
2884         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
2885
2886         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
2887         should match Lion's behavior.
2888
2889         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
2890         but doesn't use Lion results
2891
2892         Reviewed by David Kilzer.
2893
2894         * Scripts/old-run-webkit-tests:
2895         (expectedDirectoryForTest):
2896         * Scripts/webkitpy/layout_tests/port/win.py:
2897         (WinPort.baseline_search_path):
2898         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2899         (WinPortTest.test_baseline_search_path):
2900         Replaced mac-snowleopard with mac-lion.
2901
2902         * Scripts/webkitpy/common/config/build.py:
2903         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
2904         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
2905         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
2906         will no longer look there for results.
2907
2908         * Scripts/webkitpy/common/config/build_unittest.py:
2909         (ShouldBuildTest.test_should_build): Tests for the above changes.
2910
2911 2011-08-16  Dean Jackson  <dino@apple.com>
2912
2913         Move me from contributor to reviewer.
2914
2915         * Scripts/webkitpy/common/config/committers.py:
2916
2917 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2918
2919         garden-o-matic frontend needs model.commitDataForRevisionRange function.
2920         https://bugs.webkit.org/show_bug.cgi?id=66252
2921
2922         Reviewed by Adam Barth.
2923
2924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
2925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
2926
2927 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2928
2929         garden-o-matic frontend needs a generic way to track updates.
2930         https://bugs.webkit.org/show_bug.cgi?id=66245
2931
2932         Reviewed by Adam Barth.
2933
2934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
2935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2936
2937 2011-08-15  Adam Roben  <aroben@apple.com>
2938
2939         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
2940
2941         Failures now give output of the form: foo should be bar but is baz
2942
2943         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
2944         test is in TestWebKitAPI's output
2945
2946         Reviewed by David Levin.
2947
2948         * TestWebKitAPI/JavaScriptTest.cpp:
2949         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
2950         members.
2951         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
2952         object, rather than doing any testing of it here.
2953         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
2954         to use a pretty error message when the test fails.
2955
2956         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
2957         gtest-style macros that wrap it.
2958
2959         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
2960
2961         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2962         (TestWebKitAPI::TEST): Changed to use the new macros.
2963
2964         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2965         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
2966         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
2967         the test passes, though. Returning early seems to have been an unnecessary optimization.
2968
2969         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2970         (TestWebKitAPI::TEST): Changed to use the new macros.
2971
2972 2011-08-15  Eric Seidel  <eric@webkit.org>
2973
2974         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
2975
2976         Unreviewed.
2977
2978         * Scripts/run-webkit-tests:
2979         (usingLeaks):
2980         (useNewRunWebKitTests):
2981
2982 2011-08-14  Adam Barth  <abarth@webkit.org>
2983
2984         Switch results detail view over to new-style object-oriented UI widgets
2985         https://bugs.webkit.org/show_bug.cgi?id=66200
2986
2987         Reviewed by Dimitri Glazkov.
2988
2989         This patch replaces my goofy template-based UI for the results
2990         comparison screen with new object-oriented UI widgets.
2991
2992         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2993         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2999
3000 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
3001
3002         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
3003         https://bugs.webkit.org/show_bug.cgi?id=66166
3004
3005         Also changed base.RequestTracker to:
3006         a) fire callback immediately if requestsInFlight is 0;
3007         b) not barf if callback is not supplied.
3008
3009         Reviewed by Adam Barth.
3010
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
3015
3016 2011-08-12  Mark Rowe  <mrowe@apple.com>
3017
3018         Be more forward-looking in the choice of compiler.
3019
3020         Rubber-stamped by Jon Honeycutt.
3021
3022         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3023         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
3024         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
3025         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3026
3027 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3028
3029         DRT: Add support for gesture events.
3030         https://bugs.webkit.org/show_bug.cgi?id=66105
3031
3032         Reviewed by Darin Fisher.
3033
3034         * DumpRenderTree/chromium/EventSender.cpp:
3035         (EventSender::EventSender):
3036         (EventSender::gestureScrollBegin):
3037         (EventSender::gestureScrollEnd):
3038         (EventSender::gestureTap):
3039         (EventSender::gestureEvent):
3040         * DumpRenderTree/chromium/EventSender.h:
3041
3042 2011-08-12  Andy Estes  <aestes@apple.com>
3043
3044         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
3045         https://bugs.webkit.org/show_bug.cgi?id=66158
3046
3047         Reviewed by Dan Bernstein.
3048
3049         * DumpRenderTree/LayoutTestController.cpp:
3050         (allowRoundingHacksCallback): The third argument is the 'this'
3051         JSObjectRef, not the second.
3052
3053 2011-08-12  Andy Estes  <aestes@apple.com>
3054
3055         Cancel in onbeforeunload dialog sometime causes a button to stop working.
3056         https://bugs.webkit.org/show_bug.cgi?id=26211
3057
3058         Reviewed by Alexey Proskuryakov.
3059
3060         Implement a new LayoutTestController method that a test can call to set
3061         the return value of DumpRenderTree's beforeunload UI delegate.
3062
3063         * DumpRenderTree/LayoutTestController.cpp:
3064         (LayoutTestController::LayoutTestController): Initialize
3065         m_shouldStayOnPageAfterHandlingBeforeUnload.
3066         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
3067         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
3068         (LayoutTestController::staticFunctions): Register
3069         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
3070         * DumpRenderTree/LayoutTestController.h: 
3071         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3072         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3073         * DumpRenderTree/chromium/LayoutTestController.cpp:
3074         (LayoutTestController::LayoutTestController): Initialize
3075         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
3076         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
3077         (LayoutTestController::reset): Reset
3078         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
3079         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3080         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
3081         from JavaScript.
3082         * DumpRenderTree/chromium/LayoutTestController.h:
3083         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3084         * DumpRenderTree/chromium/WebViewHost.cpp:
3085         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
3086         return the inverse of
3087         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
3088         * DumpRenderTree/mac/UIDelegate.mm:
3089         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
3090         * DumpRenderTree/win/UIDelegate.cpp:
3091         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3092         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3093         Define setShouldStayOnPageAfterHandlingBeforeUnload().
3094         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3095         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
3096         to the Test Controller telling it what value it should return in its
3097         onbeforeunload UI delegate.
3098         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3099         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3100         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3101         Call InjectedBundle::postNewBeforeUnloadReturnValue().
3102         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::TestController::TestController): Initialize
3105         m_beforeUnloadReturnValue to true.
3106         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
3107         the value of TestController::beforeUnloadReturnValue().
3108         (WTR::TestController::resetStateToConsistentValues): Reset
3109         m_beforeUnloadReturnValue to true.
3110         * WebKitTestRunner/TestController.h:
3111         (WTR::TestController::beforeUnloadReturnValue):
3112         (WTR::TestController::setBeforeUnloadReturnValue):
3113         * WebKitTestRunner/TestInvocation.cpp:
3114         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
3115         message posted from the injected bundle by retrieving the message body
3116         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
3117
3118 2011-08-12  Sam Weinig  <sam@webkit.org>
3119
3120         Move compiler specific macros to their own header
3121         https://bugs.webkit.org/show_bug.cgi?id=66119
3122
3123         Reviewed by Anders Carlsson.
3124
3125         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
3126
3127 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3128
3129         Add a way to extend DOM objects in garden-o-matic.
3130         https://bugs.webkit.org/show_bug.cgi?id=66096
3131
3132         Reviewed by Adam Barth.
3133
3134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
3135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
3136
3137 2011-08-11  MORITA Hajime  <morrita@google.com>
3138
3139         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
3140         https://bugs.webkit.org/show_bug.cgi?id=45438
3141
3142         Reviewed by Kent Tamura.
3143
3144         MockSpellCheck was assuming the input of spellCheckWord() is a word.
3145         But it can be a series of word. This change made spellCheckWord()
3146         understand simple word boundary which appears in tests.
3147         
3148         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3149         (MockSpellCheck::spellCheckWord):
3150
3151 2011-08-11  Mark Rowe  <mrowe@apple.com>
3152
3153         Rework some Makefile logic to remove a double-negative.
3154
3155         Reviewed by Jon Honeycutt.
3156
3157         * DumpRenderTree/mac/PerlSupport/Makefile:
3158
3159 2011-08-11  Anders Carlsson  <andersca@apple.com>
3160
3161         Add a FIXME.
3162
3163         * TestWebKitAPI/TestsController.cpp:
3164         (TestWebKitAPI::TestsController::TestsController):
3165
3166 2011-08-11  Anders Carlsson  <andersca@apple.com>
3167
3168         Initialize threading before running any tests
3169         https://bugs.webkit.org/show_bug.cgi?id=66112
3170
3171         Reviewed by Adam Barth.
3172
3173         * TestWebKitAPI/TestsController.cpp:
3174         (TestWebKitAPI::TestsController::TestsController):
3175
3176 2011-08-11  Adam Barth  <abarth@webkit.org>
3177
3178         Add unexpected-passes.html to TestFailures for marking tests as passing
3179         https://bugs.webkit.org/show_bug.cgi?id=66102
3180
3181         Reviewed by Dimitri Glazkov.
3182
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3185             - Move some code into the library so it can be shared.
3186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3189             - Add round-trip unit tests.
3190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
3192             - I'm not entirely sure this feature should remain a separate HTML
3193               file, but it seemed better than cluttering up the main HTML file
3194               with too much extra stuff.
3195         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3196         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3197             - The gardening server couldn't handle adding PASS expectations.  Now it can.
3198
3199 2011-08-11  Eric Seidel  <eric@webkit.org>
3200
3201         NRWT has wrong fallback order for Mac now that Lion exists
3202         https://bugs.webkit.org/show_bug.cgi?id=66093
3203
3204         Reviewed by Adam Barth.
3205
3206         ORWT used a different system for fallback orders than NRWT did.
3207         I moved win.py to match ORWT fallback orders in bug 64486.
3208         This bug moves mac.py to match ORWT fallback order
3209         and adds 'lion' as a supported OS version.
3210
3211         Because ChromiumMac shares OS version detection code with AppleMac
3212         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
3213
3214         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3215         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3216         * Scripts/webkitpy/layout_tests/port/mac.py:
3217         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3218         * Scripts/webkitpy/layout_tests/port/win.py:
3219
3220 2011-08-11  Adam Barth  <abarth@webkit.org>
3221
3222         Update test results now that we use absolute URLs.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
3225
3226 2011-08-11  Adam Barth  <abarth@webkit.org>
3227
3228         garden-o-matic should be able to determine when tests unexpectedly pass
3229         https://bugs.webkit.org/show_bug.cgi?id=66092
3230
3231         Reviewed by Dimitri Glazkov.
3232
3233         This patch just contains the library methods for extracting this
3234         information.  I'll add some UI in a subsequent patch.
3235
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
3238
3239 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3240
3241         New expectation entries should be placed next to existing ones.
3242         https://bugs.webkit.org/show_bug.cgi?id=66066
3243
3244         Reviewed by Adam Barth.
3245
3246         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
3247             which is computed as the last found reference to the same test.
3248         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
3249
3250 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3251
3252         Unreviewed, rolling out r92847.
3253         http://trac.webkit.org/changeset/92847
3254         https://bugs.webkit.org/show_bug.cgi?id=65986
3255
3256         Broke check-webkit-style
3257
3258         * Scripts/webkitpy/style/checker.py:
3259         * Scripts/webkitpy/style/checker_unittest.py:
3260
3261 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3262
3263         Unreviewed, rolling out r92847.
3264         http://trac.webkit.org/changeset/92847
3265         https://bugs.webkit.org/show_bug.cgi?id=65986
3266
3267         Broke check-webkit-style
3268
3269         * Scripts/webkitpy/style/checker.py:
3270         * Scripts/webkitpy/style/checker_unittest.py:
3271
3272 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
3273
3274         [Qt] autotests shouldn't require config.h in the style check
3275         https://bugs.webkit.org/show_bug.cgi?id=65986
3276
3277         Remove the include rules from the style-check for Qt tests.
3278         Since for the most part it's just a matter of using the
3279         API provided by QtWebKit, enforcing the WebCore set of rules
3280         only seems to make sense in the case of MIMESniffing.
3281
3282         Reviewed by Benjamin Poulain.
3283
3284         * Scripts/webkitpy/style/checker.py:
3285         * Scripts/webkitpy/style/checker_unittest.py:
3286
3287 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3288
3289         [WK2] Implement waitForPolicyDelegate
3290         https://bugs.webkit.org/show_bug.cgi?id=42330
3291
3292         Reviewed by Csaba Osztrogonác.
3293
3294         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3295         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3296         (WTR::navigationTypeToString):
3297         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3298         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3299         (WTR::LayoutTestController::LayoutTestController):
3300         (WTR::LayoutTestController::setCustomPolicyDelegate):
3301         (WTR::LayoutTestController::waitForPolicyDelegate):
3302         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3303         (WTR::LayoutTestController::isPolicyDelegateEnabled):
3304         (WTR::LayoutTestController::isPolicyDelegatePermissive):
3305
3306 2011-08-11  Adam Barth  <abarth@webkit.org>
3307
3308         rebaseline-expectations should use the release bots, not the debug
3309         bots.  The debug bots don't all run all the tests.  Also, delay
3310         updating test_expectations a long as possible to avoid clearing out
3311         lines that we'll need for other ports.
3312
3313         * Scripts/webkitpy/layout_tests/port/builders.py:
3314         * Scripts/webkitpy/tool/commands/rebaseline.py:
3315         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3316
3317 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3318
3319         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
3320         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
3321
3322         * BuildSlaveSupport/build.webkit.org-config/config.json:
3323
3324 2011-08-10  Eric Seidel  <eric@webkit.org>
3325
3326         new-run-webkit-test's WinPort has no fallback logic
3327         https://bugs.webkit.org/show_bug.cgi?id=64486
3328
3329         Unreviewed.
3330
3331         Turns out that we've long had a subtle bug whereby if you didn't
3332         already have DumpRenderTree built, we might end up running unsupported tests
3333         because the DumpRenderTree --print-supported-features check would silently fail.
3334
3335         When I moved the call from using popen to using Executive.run_command, this silent
3336         failure became noisy.  (Breaking some bots.)
3337
3338         This re-orders our steps so that we always build DRT before collecting expectations,
3339         as well as adds a warning message when DumpRenderTree can't be found.
3340
3341         * Scripts/webkitpy/layout_tests/port/webkit.py:
3342         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3343
3344 2011-08-10  Eric Seidel  <eric@webkit.org>
3345
3346         new-run-webkit-test's WinPort has no fallback logic
3347         https://bugs.webkit.org/show_bug.cgi?id=64486
3348
3349         Unreviewed.  Fix test-webkitpy under Python 2.5.
3350
3351         * Scripts/webkitpy/layout_tests/port/win.py:
3352
3353 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
3354
3355         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
3356         https://bugs.webkit.org/show_bug.cgi?id=65875
3357
3358         Reviewed by Kenneth Rohde Christiansen.
3359
3360         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
3361
3362         This causes mouse events to be sent twice in some cases. We work around the problem
3363         by defining the first touch point to be a primary touch point (case which hit some
3364         weird condition in QWidget, skipping the generation of fake mouse events).
3365
3366         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3367         (MiniBrowserApplication::notify):
3368
3369 2011-08-10  David Hyatt  <hyatt@apple.com>
3370
3371         https://bugs.webkit.org/show_bug.cgi?id=66004
3372
3373         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
3374         the code on by default.
3375
3376         Reviewed by Adam Roben.
3377
3378         * BuildSlaveSupport/build.webkit.org-config/config.json:
3379         * Scripts/build-webkit:
3380
3381 2011-08-10  Oliver Hunt  <oliver@apple.com>
3382
3383         JSEvaluteScript does not return the correct object when given JSONP data
3384         https://bugs.webkit.org/show_bug.cgi?id=66003
3385
3386         Reviewed by Gavin Barraclough.
3387
3388         Add a test case.
3389
3390         * DumpRenderTree/mac/DumpRenderTree.mm:
3391         (testStringByEvaluatingJavaScriptFromString):
3392
3393 2011-08-10  Eric Seidel  <eric@webkit.org>
3394
3395         WIN: NRWT runs compositing tests on configurations that don't support compositing
3396         https://bugs.webkit.org/show_bug.cgi?id=64472
3397
3398         Reviewed by Adam Barth.
3399
3400         I think the code was just wrong.  It was never splitting the string
3401         into list pieces before.
3402         I've now tested the supported_features code and theoretically it
3403         should now work with Windows DRT.
3404
3405         I also made the list-lookup functions always return lists, to make
3406         it possible to clean up the list-transform code in the future
3407         (I opted not to do that cleanup in this patch, but at least now
3408         both types of feature lookup functions match return types.)
3409
3410         * Scripts/webkitpy/layout_tests/port/webkit.py:
3411         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3412
3413 2011-08-10  Eric Seidel  <eric@webkit.org>
3414
3415         Clean up ChromiumDriver a little
3416         https://bugs.webkit.org/show_bug.cgi?id=65995
3417
3418         Unreviewed.
3419
3420         Fix NRWT for chromium.  Silly python.
3421
3422         * Scripts/webkitpy/layout_tests/port/chromium.py:
3423
3424 2011-08-10  Eric Seidel  <eric@webkit.org>
3425
3426         Clean up ChromiumDriver a little
3427         https://bugs.webkit.org/show_bug.cgi?id=65995
3428
3429         Reviewed by Adam Barth.
3430
3431         - We no longer support threading, so remove threading specific code.
3432         - Add FIXMEs about using ServerProcess instead.
3433         - Condense option-mapping if-cascade into a for loop.
3434         - Unindent long if blocks by using early return.
3435         - Unwrap lines which are needlessly wrapped.
3436
3437         There should be no functional changes here, just code cleanup/dead-code removal.
3438
3439         * Scripts/webkitpy/layout_tests/port/chromium.py:
3440
3441 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3442
3443         Unmuddle construction options for TestConfiguration.
3444         https://bugs.webkit.org/show_bug.cgi?id=65988
3445
3446         The TestConfiguration instance is now constructed only using actual values.
3447         Port-based construction is split into a "from_port" class method.
3448
3449         Reviewed by Eric Seidel.
3450
3451         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
3452         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
3453         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3454         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
3455         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
3456
3457 2011-08-10  Eric Seidel  <eric@webkit.org>
3458
3459         Leaks bot shows python logging prefixes as part of summary display
3460         https://bugs.webkit.org/show_bug.cgi?id=65931
3461
3462         Reviewed by Adam Barth.
3463
3464         The big part of this change is adding a unittesting system for
3465         master.cfg, so mere-mortals can make changes to build.webkit.org
3466         with greatly-reduced risk of breaking the world.
3467
3468         Turns out that in typing up my trival logging fix I made 2 typos,
3469         so hopefully the hour spent getting master.cfg to load was worth it. :)
3470
3471         I also tried to make mastercfg_unittest run as part of test-webkitpy
3472         but right now test-webkitpy requires that unittest files be located in
3473         a module-name-compatible directory.  'build.webkit.org-config' is not
3474         a valid module name.
3475
3476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3477          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
3478            by using a new _strip_python_logging_prefix function.
3479          - Also fixed this function to file to work with a more modern
3480            simplejson version (which returns unicode objects instead of str objects)
3481            and filed a related bug with buildbot.net due to their handling of unicode builder names.
3482         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
3483          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
3484          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
3485         * Scripts/webkitpy/thirdparty/__init__.py:
3486          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
3487
3488 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
3489
3490         garden-o-matic should extrapolate failures given a set of known results
3491         https://bugs.webkit.org/show_bug.cgi?id=65882
3492
3493         Reviewed by Adam Barth.
3494
3495         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
3496         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
3497             adjusted all call sites.
3498         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
3499             makes wider net for specific failures.
3500         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
3501
3502 2011-08-10  Adam Barth  <abarth@webkit.org>
3503
3504         The URL we were computing for retrieving baselines was missing a slash
3505         character because our mocks had an extra slash character.  I've
3506         corrected both the code and the mock.
3507
3508         * Scripts/webkitpy/tool/commands/rebaseline.py:
3509         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3510         * Scripts/webkitpy/tool/mocktool.py:
3511
3512 2011-08-09  Adam Barth  <abarth@webkit.org>
3513
3514         Move the quote mark to the right place.
3515
3516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3517
3518 2011-08-09  Adam Barth  <abarth@webkit.org>
3519
3520         garden-o-matic should use huerstics to narrow regression range
3521         https://bugs.webkit.org/show_bug.cgi?id=65948
3522
3523         Reviewed by Dimitri Glazkov.
3524
3525         When analyzing a regression range, if one of the commit messages
3526         mentions the test in question, we now hueristically assume that
3527         revision caused the failure.  (I'm shamelessly stealing this idea from
3528         TestFailures.)
3529
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3531
3532 2011-07-13  Eric Seidel  <eric@webkit.org>
3533
3534         new-run-webkit-test's WinPort has no fallback logic
3535         https://bugs.webkit.org/show_bug.cgi?id=64486
3536
3537         Reviewed by Adam Roben.
3538
3539         I've tried to write a patch for bug 64439 twice now, and both times
3540         I've ended up re-writing half the port system.  So I'm breaking
3541         things up into smaller pieces, this being the first.
3542
3543         WinPort still does not have any port_name parsing, so when instantiated
3544         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
3545         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
3546
3547         Otherwise this should "just work" for windows.  I've not been able to test the
3548         version detection on my mac, but the unit tests show the code behaving as designed.
3549
3550         * Scripts/webkitpy/layout_tests/port/win.py:
3551         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
3552
3553 2011-08-09  Adam Barth  <abarth@webkit.org>
3554
3555         Teach build.webkit.org's garden-o-matic how to talk to the local server
3556         https://bugs.webkit.org/show_bug.cgi?id=65940
3557
3558         Reviewed by Dimitri Glazkov.
3559
3560         After this patch, the version of garden-o-matic on build.webkit.org is
3561         fully functional.  It can interact with the local server via CORS.
3562
3563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3565       &nb