1 2016-02-01 Jason Marcell <jmarcell@apple.com>
3 Add code to parse the git branches out of the Trac RSS feed
4 https://bugs.webkit.org/show_bug.cgi?id=153624
6 Reviewed by Daniel Bates.
8 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
9 (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
10 (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
11 "branches" and updated the code to work with an array instead of a string.
12 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
13 (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
14 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
15 fixture that contains XML with a Git branch.
16 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
17 branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
19 2016-02-01 Brady Eidson <beidson@apple.com>
21 Add command line flag to DRT to output the number of tests completed in server mode.
22 https://bugs.webkit.org/show_bug.cgi?id=153750
24 Reviewed by Darin Adler.
26 * DumpRenderTree/mac/DumpRenderTree.mm:
27 (initializeGlobalsFromCommandLineOptions):
28 (runTestingServerLoop):
30 2016-02-01 Jason Marcell <jmarcell@apple.com>
32 Improvements to botwatcher's dashboard unit tests.
33 https://bugs.webkit.org/show_bug.cgi?id=153621
35 Reviewed by Darin Adler.
37 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
38 (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
39 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
40 (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
41 _popoverLinesForCommitRange have to traverse commits from different branches.
42 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
43 in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
44 _revisionContentWithPopoverForIteration.
46 2016-02-01 Jason Marcell <jmarcell@apple.com>
48 Refactor to add event listeners and start periodic updates for all trac instances.
49 https://bugs.webkit.org/show_bug.cgi?id=153609
51 Reviewed by Darin Adler.
53 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
54 (BuildbotQueueView): Adding event listeners for all trac instances.
55 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
56 for all trac instances.
58 2016-01-31 Darin Adler <darin@apple.com>
60 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
61 https://bugs.webkit.org/show_bug.cgi?id=153639
63 Reviewed by Filip Pizlo.
65 * Scripts/do-webcore-rename: Use script to do this rename.
67 2016-01-30 Commit Queue <commit-queue@webkit.org>
69 Unreviewed, rolling out r195911.
70 https://bugs.webkit.org/show_bug.cgi?id=153723
72 Caused frequent assertion failures on bots (Requested by ap on
77 "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
78 https://bugs.webkit.org/show_bug.cgi?id=153639
79 http://trac.webkit.org/changeset/195911
81 2016-01-30 Darin Adler <darin@apple.com>
83 Replace CaseFoldingHash with ASCIICaseInsensitiveHash
84 https://bugs.webkit.org/show_bug.cgi?id=153639
86 Reviewed by Filip Pizlo.
88 * Scripts/do-webcore-rename: Use script to do this rename.
90 2016-01-30 Ryosuke Niwa <rniwa@webkit.org>
92 TouchList should be retargeted
93 https://bugs.webkit.org/show_bug.cgi?id=149592
95 Reviewed by Antti Koivisto.
97 Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
98 multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
100 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
101 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
102 (WTR::UIScriptController::touchDownAtPoint): Added.
103 (WTR::UIScriptController::liftUpAtPoint): Added.
104 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
105 * WebKitTestRunner/ios/HIDEventGenerator.h:
106 * WebKitTestRunner/ios/HIDEventGenerator.mm:
107 (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
108 (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
109 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
110 (WTR::UIScriptController::touchDownAtPoint): Added.
111 (WTR::UIScriptController::liftUpAtPoint): Added.
113 2016-01-30 Yusuke Suzuki <utatane.tea@gmail.com>
115 Enable SamplingProfiler on POSIX environment
116 https://bugs.webkit.org/show_bug.cgi?id=153584
118 Reviewed by Michael Saboff.
120 * Scripts/run-jsc-stress-tests:
122 2016-01-29 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
124 update-webkit-dependency fails to fetch updates through firewall on Windows
125 https://bugs.webkit.org/show_bug.cgi?id=153619
127 Reviewed by Myles C. Maxfield.
129 On Windows, when a firewall is present we need to read proxy settings
130 from environment variables.
132 This patch relies on the following environment variables being set:
136 * Scripts/update-webkit-dependency:
138 2016-01-28 Dan Bernstein <mitz@apple.com>
140 [Cocoa] Use the non-Development variants of XPC services for development
141 https://bugs.webkit.org/show_bug.cgi?id=152545
143 Reviewed by Darin Adler.
145 * Scripts/webkitdirs.pm:
146 (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
148 * Scripts/webkitpy/port/driver.py:
149 (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
150 set in the XPC services as well.
152 * Scripts/webkitpy/port/ios.py:
153 (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
154 Guard Malloc are enabled in XPC services as well.
156 * Scripts/webkitpy/port/mac.py:
157 (MacPort.setup_environ_for_server): Ditto.
159 2016-01-28 Csaba Osztrogonác <ossy@webkit.org>
161 Unreviewed buildfix after r195743.
163 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
164 (WTR::AccessibilityUIElement::isPressActionSupported):
166 2016-01-12 Jer Noble <jer.noble@apple.com>
168 Custom protocol loading through AVFoundation does not support byte-range requests.
169 https://bugs.webkit.org/show_bug.cgi?id=152919
170 <rdar://problem/23664657>
172 Reviewed by Alex Christensen.
174 Add tests for new ParsedContntRange class.
176 * TestWebKitAPI/PlatformWin.cmake:
177 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
178 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
179 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
180 * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
181 (TestWebKitAPI::TEST):
183 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
185 Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
186 https://bugs.webkit.org/show_bug.cgi?id=153594
188 Reviewed by Alex Christensen.
190 * Scripts/webkitdirs.pm:
191 (determineNumberOfCPUs):
195 (wrapperPrefixIfNeeded):
196 (cmakeGeneratedBuildfile):
197 (generateBuildSystemFromCMakeProject):
198 * Scripts/webkitperl/features.pm:
199 (libraryContainsSymbol):
201 2016-01-28 Chris Dumez <cdumez@apple.com>
203 Unreviewed, rolling out r195742.
209 "[webkitdirs] Clarify logic behind is{PortName} functions."
210 https://bugs.webkit.org/show_bug.cgi?id=153554
211 http://trac.webkit.org/changeset/195742
213 2016-01-28 Darin Adler <darin@apple.com>
215 Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
216 https://bugs.webkit.org/show_bug.cgi?id=153411
218 Reviewed by Ryosuke Niwa.
220 * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
221 have removed the function instead.
223 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
224 (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
225 added overloads for const char*.
227 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
228 (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
229 (WTR::AccessibilityUIElement::hasPopup): Ditto.
230 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
231 (WTR::testPathFromURL): Ditto.
233 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
235 [webkitdirs] Clarify logic behind is{PortName} functions.
236 https://bugs.webkit.org/show_bug.cgi?id=153554
238 Reviewed by Darin Adler.
240 * Scripts/webkitdirs.pm:
241 (determinePortName): Added new function which decides which port are
242 we building based on command line switches and platform defaults.
243 (portName): Added getter for determined $portName.
244 (isEfl): Modified to use portName().
247 (isAppleMacWebKit): Ditto.
248 (isAppleWinWebKit): Ditto.
249 (isIOSWebKit): Ditto.
250 (cmakeBasedPortName): Code replaced with portName() call.
251 (determineIsEfl): Deleted.
252 (determineIsGtk): Deleted.
253 (determineIsWinCairo): Deleted.
255 2016-01-28 Konstantin Tokarev <annulen@yandex.ru>
257 [webkitdirs] Don't pass cmakeBasedPortName around.
258 https://bugs.webkit.org/show_bug.cgi?id=153589
260 Reviewed by Darin Adler.
262 It should be local function of webkitdirs.pm instead.
264 * Scripts/build-jsc: Don't pass cmakeBasedPortName to
265 buildCMakeProjectOrExit().
266 * Scripts/build-webkit: Don't pass cmakeBasedPortName to
267 buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
268 * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
269 generateBuildSystemFromCMakeProject().
270 * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
271 (generateBuildSystemFromCMakeProject): Removed $port argument as we
272 can get it from cmakeBasedPortName().
273 (buildCMakeProjectOrExit): Ditto.
275 2016-01-28 Gwang Yoon Hwang <yoon@igalia.com>
277 [GStreamer] Clean up includes and headers related with GStreamerGL
278 https://bugs.webkit.org/show_bug.cgi?id=153590
280 Reviewed by Philippe Normand.
282 * Scripts/webkitpy/style/checker.py: Skips
283 include_order check for MediaPlayerPrivateGStreamerBase.cpp
284 Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
286 2016-01-27 Krzysztof Czech <k.czech@samsung.com>
288 [EFL] Remove unused accessibility related code
289 https://bugs.webkit.org/show_bug.cgi?id=153543
291 Reviewed by Darin Adler.
293 Removed reference to EAIL library.
294 It not going to be support anymore. There have been changes in
295 EFL/Elementary in terms of the accessibility and we should
298 * efl/jhbuild-optional.modules:
300 2016-01-27 Daniel Bates <dabates@apple.com>
302 Remove WebKitSystemInterface for iOS SDK < 9
303 https://bugs.webkit.org/show_bug.cgi?id=153570
305 Reviewed by Andy Estes.
307 * Scripts/copy-webkitlibraries-to-product-directory:
309 2016-01-27 Jason Marcell <jmarcell@apple.com>
311 Fix bugs caused by incorrect usage of "branch" vs. "branchName".
312 https://bugs.webkit.org/show_bug.cgi?id=153330
314 Reviewed by Daniel Bates.
316 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
317 "branchName" implies that the variable or property in question is simply a string. We fixed some
318 inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
319 spotted in BuildbotQueueView.js.
321 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
322 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
323 Changed branchName to branch.name in call to commitsOnBranch.
324 (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
325 _popoverLinesForCommitRange.
326 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
327 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
328 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
331 2016-01-27 Ryosuke Niwa <rniwa@webkit.org>
333 Add API to access closed shadowRoot in InjectedBundle
334 https://bugs.webkit.org/show_bug.cgi?id=153533
336 Reviewed by Antti Koivisto.
338 Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
340 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
341 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
342 (TestWebKitAPI::runJavaScriptAlert):
343 (TestWebKitAPI::TEST):
344 * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
345 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
346 (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
348 2016-01-27 Jason Marcell <jmarcell@apple.com>
350 Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
351 https://bugs.webkit.org/show_bug.cgi?id=153332
353 Reviewed by Alexey Proskuryakov.
355 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
356 (Trac.prototype._xmlTimelineURL): Uses new function.
357 (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
358 logic for parsing git hashes.
359 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
360 Trac._parseRevisionFromURL.
362 2016-01-27 Alexey Proskuryakov <ap@apple.com>
364 Remove Mavericks from the flakiness dashboard
365 https://bugs.webkit.org/show_bug.cgi?id=153521
367 Reviewed by Dan Bernstein.
369 * TestResultServer/static-dashboards/builders.jsonp:
370 * TestResultServer/static-dashboards/flakiness_dashboard.js:
372 2016-01-27 Alexey Proskuryakov <ap@apple.com>
374 Remove ENABLE_CURRENTSRC
375 https://bugs.webkit.org/show_bug.cgi?id=153545
377 Reviewed by Simon Fraser.
379 * Scripts/webkitperl/FeatureList.pm:
381 2016-01-26 Jason Marcell <jmarcell@apple.com>
383 Sort incoming commits via date instead of revision number.
384 https://bugs.webkit.org/show_bug.cgi?id=153467
386 Reviewed by Alexey Proskuryakov.
388 Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
389 for sorting revisions. Instead we use the commit date to sort revisions chronologically.
391 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
392 (Trac.prototype._loaded): Sort via date instead of revision number.
393 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
394 (MockTrac): Fix up the mock data to look more like real-world data.
395 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
396 Fake RSS feed that adds three more commits.
397 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
400 2016-01-26 I-Ting Liu <iting_liu@apple.com>
402 Add a test for WebKit::stringMatchesWildcardString.
403 https://bugs.webkit.org/show_bug.cgi?id=153090
405 Reviewed by Darin Adler.
407 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
408 Add the file to the project.
410 * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
411 (TestWebKitAPI::TEST):
412 Test that a string matches another string that may contain wildcard characters.
414 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
416 [webkitdirs] Removed check for bison, gperf, and flex.
417 https://bugs.webkit.org/show_bug.cgi?id=153496
419 Reviewed by Alex Christensen.
421 This prerequisites are checked in WebKitCommon.cmake and don't
424 * Scripts/webkitdirs.pm:
425 (checkRequiredSystemConfig):
427 2016-01-26 Konstantin Tokarev <annulen@yandex.ru>
429 [webkitdirs] isCMakeBuild should be true by default
430 https://bugs.webkit.org/show_bug.cgi?id=153497
432 Reviewed by Michael Catanzaro.
434 * Scripts/webkitdirs.pm:
437 2016-01-26 Daniel Bates <dabates@apple.com>
439 Add WebKitSystemInterface for iOS 9.2
440 https://bugs.webkit.org/show_bug.cgi?id=153355
442 Rubber-stamped by David Kilzer.
444 * Scripts/copy-webkitlibraries-to-product-directory:
446 2016-01-26 Daniel Bates <dabates@apple.com>
448 WebKitTestRunner: Credential cache is not cleared between tests
449 https://bugs.webkit.org/show_bug.cgi?id=153407
450 <rdar://problem/24280834>
452 Reviewed by Alexey Proskuryakov.
454 * WebKitTestRunner/TestController.cpp:
455 (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
456 to clear cached credentials.
458 2016-01-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
460 kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
461 https://bugs.webkit.org/show_bug.cgi?id=153483
463 Reviewed by Csaba Osztrogonác.
465 * BuildSlaveSupport/kill-old-processes:
466 (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
468 2016-01-25 Simon Fraser <simon.fraser@apple.com>
470 Give the layout test results file a <title> showing the date and time the tests were run
471 https://bugs.webkit.org/show_bug.cgi?id=153187
473 Reviewed by Darin Adler.
475 Include a 'date' property in the JSON with the date and time the tests completed.
477 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
480 2016-01-25 Commit Queue <commit-queue@webkit.org>
482 Unreviewed, rolling out r195543.
483 https://bugs.webkit.org/show_bug.cgi?id=153451
485 regressed performance of test bots by ~6% (Requested by dydz
490 "WebKitTestRunner: Credential cache is not cleared between
492 https://bugs.webkit.org/show_bug.cgi?id=153407
493 http://trac.webkit.org/changeset/195543
495 2016-01-25 Aakash Jain <aakash_jain@apple.com>
497 Failing to upload to flakiness dashboard should not be a hard error
498 https://bugs.webkit.org/show_bug.cgi?id=153444
499 <rdar://problem/22146294>
501 Reviewed by Alexey Proskuryakov.
503 * Scripts/webkitpy/layout_tests/controllers/manager.py:
504 (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
506 2016-01-25 Daniel Bates <dabates@apple.com>
508 WebKitTestRunner: Credential cache is not cleared between tests
509 https://bugs.webkit.org/show_bug.cgi?id=153407
510 <rdar://problem/24280834>
512 Reviewed by Brady Eidson.
514 * WebKitTestRunner/TestController.cpp:
515 (WTR::TestController::resetStateToConsistentValues): Reset testing network session
516 to clear cached credentials.
518 2016-01-24 Dan Bernstein <mitz@apple.com>
520 Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
522 * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
524 2016-01-22 Enrica Casucci <enrica@apple.com>
526 Unreviewed build fix after http://trac.webkit.org/changeset/195474.
528 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
529 (WTR::TestController::platformCreateWebView):
531 2016-01-22 Tim Horton <timothy_horton@apple.com>
533 Add a test for iOS arrow-key repeat
534 https://bugs.webkit.org/show_bug.cgi?id=152857
535 <rdar://problem/24017380>
537 Reviewed by Darin Adler.
539 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
540 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
541 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
542 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
543 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
544 * WebKitTestRunner/ios/HIDEventGenerator.h:
545 * WebKitTestRunner/ios/HIDEventGenerator.mm:
546 (-[HIDEventGenerator keyPress:completionBlock:]):
547 (-[HIDEventGenerator keyDown:completionBlock:]):
548 (-[HIDEventGenerator keyUp:completionBlock:]):
549 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
550 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
551 (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
552 (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
553 Make it possible to independently send keyUp/keyDown, instead of just paired.
555 2016-01-22 Tim Horton <timothy_horton@apple.com>
557 Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
558 https://bugs.webkit.org/show_bug.cgi?id=153193
559 <rdar://problem/24222034>
561 Reviewed by Darin Adler.
563 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
564 (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
566 Add a test that exhibits the problems we're fixing here.
567 Before, it would both log and assert in debug, and crash in release.
568 Now it runs happily to completion.
570 2016-01-22 Enrica Casucci <enrica@apple.com>
572 Add support for testing data detection.
573 https://bugs.webkit.org/show_bug.cgi?id=153360
575 Reviewed by Tim Horton.
577 Adding a new testing option (useDataDetection) to turn on
578 data detection when running the a test.
580 * WebKitTestRunner/TestController.cpp:
581 (WTR::updateTestOptionsFromTestHeader):
582 * WebKitTestRunner/TestOptions.h:
583 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
584 (WTR::TestController::platformCreateWebView):
586 2016-01-21 Simon Fraser <simon.fraser@apple.com>
588 Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
589 https://bugs.webkit.org/show_bug.cgi?id=153334
591 Reviewed by Zalan Bujtas.
593 Evaluating expressions in the LayoutUnit summary provider seems to cause
594 re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
597 * lldb/lldb_webkit.py:
598 (WebCoreLayoutUnitProvider.to_string):
600 2016-01-21 Filip Pizlo <fpizlo@apple.com>
602 display-profiler-output should be able to display code blocks sorted by machine counts
603 https://bugs.webkit.org/show_bug.cgi?id=153298
605 Reviewed by Oliver Hunt.
607 * Scripts/display-profiler-output:
609 2016-01-21 Julien Isorce <j.isorce@samsung.com>
611 Ensure to use compatible liborc version with wanted gstreamer version
612 https://bugs.webkit.org/show_bug.cgi?id=153276
614 For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
615 The user may have a very recent liborc installed on his system.
617 Reviewed by Philippe Normand.
619 * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
620 * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
622 2016-01-21 Nan Wang <n_wang@apple.com>
624 AX: [IOS] Implement next/previous text marker functions using TextIterator
625 https://bugs.webkit.org/show_bug.cgi?id=153292
626 <rdar://problem/24268243>
628 Reviewed by Chris Fleizach.
630 Made text marker tests available on iOS.
632 * DumpRenderTree/AccessibilityTextMarker.h:
633 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
634 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
635 (AccessibilityTextMarker::AccessibilityTextMarker):
636 (AccessibilityTextMarker::~AccessibilityTextMarker):
637 (AccessibilityTextMarker::isEqual):
638 (AccessibilityTextMarker::platformTextMarker):
639 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
640 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
641 (AccessibilityTextMarkerRange::isEqual):
642 (AccessibilityTextMarkerRange::platformTextMarkerRange):
643 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
644 (AccessibilityUIElement::pathDescription):
645 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
646 (AccessibilityUIElement::textMarkerRangeForElement):
647 (AccessibilityUIElement::selectedTextMarkerRange):
648 (AccessibilityUIElement::resetSelectedTextMarkerRange):
649 (AccessibilityUIElement::textMarkerRangeLength):
650 (AccessibilityUIElement::textMarkerRangeForMarkers):
651 (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
652 (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
653 (AccessibilityUIElement::accessibilityElementForTextMarker):
654 (AccessibilityUIElement::endTextMarkerForBounds):
655 (AccessibilityUIElement::startTextMarkerForBounds):
656 (AccessibilityUIElement::textMarkerForPoint):
657 (AccessibilityUIElement::previousTextMarker):
658 (AccessibilityUIElement::nextTextMarker):
659 (AccessibilityUIElement::stringForTextMarkerRange):
660 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
661 (AccessibilityUIElement::indexForTextMarker):
662 (AccessibilityUIElement::isTextMarkerValid):
663 (AccessibilityUIElement::textMarkerForIndex):
664 (AccessibilityUIElement::startTextMarker):
665 (AccessibilityUIElement::endTextMarker):
666 (AccessibilityUIElement::setSelectedVisibleTextRange):
667 (AccessibilityUIElement::getLinkedUIElements):
668 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
669 (AccessibilityTextMarkerRange::platformTextMarkerRange):
670 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
671 (AccessibilityUIElement::removeSelection):
672 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
673 (AccessibilityUIElement::setSelectedVisibleTextRange):
674 (AccessibilityUIElement::supportedActions):
675 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
676 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
677 (WTR::AccessibilityUIElement::textMarkerRangeLength):
678 (WTR::AccessibilityUIElement::previousTextMarker):
679 (WTR::AccessibilityUIElement::nextTextMarker):
680 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
681 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
682 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
683 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
684 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
685 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
686 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
688 2016-01-20 Filip Pizlo <fpizlo@apple.com>
690 Unreviewed, revert accidental unreviewed commit.
692 * Scripts/display-profiler-output:
694 2016-01-20 Jason Marcell <jmarcell@apple.com>
696 Refactor compareIterations to remove duplicate code.
697 https://bugs.webkit.org/show_bug.cgi?id=152913
699 Reviewed by Daniel Bates.
701 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
702 (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
703 (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
704 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
705 the same behavior before and after refactor.
707 2016-01-20 Dana Burkart <dburkart@apple.com>
709 Botwatcher's dashboard should show an 'X' when the build is broken
710 https://bugs.webkit.org/show_bug.cgi?id=152507
712 Reviewed by David Kilzer.
714 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
715 (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
716 (BuildbotStaticAnalyzerQueueView.prototype.update):
718 2016-01-19 Jason Marcell <jmarcell@apple.com>
720 Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
721 https://bugs.webkit.org/show_bug.cgi?id=153262
723 Reviewed by Alexey Proskuryakov.
725 Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
726 such cases this revisionContentForIteration method does not have any content to return, thus the
729 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
730 (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
732 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
734 [GTK] Runtime critical warnings when loading a URL after a session restore
735 https://bugs.webkit.org/show_bug.cgi?id=153233
737 Reviewed by Michael Catanzaro.
741 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
743 (testWebKitWebViewNavigationAfterSessionRestore):
746 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
748 [GTK] Remove jhbuild-optional.modules
749 https://bugs.webkit.org/show_bug.cgi?id=152964
751 Reviewed by Alex Christensen.
753 * gtk/jhbuild-optional.modules: Removed.
754 * gtk/jhbuild.modules:
756 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
758 [GTK] Add support to load/save session in MiniBrowser
759 https://bugs.webkit.org/show_bug.cgi?id=153201
761 Reviewed by Michael Catanzaro.
763 It makes it easier to test the new WebView session API.
765 * MiniBrowser/gtk/BrowserWindow.c:
766 (browserWindowFinalize): Free the session file path.
767 (browserWindowSaveSession): Save the current WebView session if
768 there's a session file path.
769 (browserWindowDeleteEvent): Call browserWindowSaveSession().
770 (browser_window_load_session): Try to load the session from the
771 given file path, otherwise fall back to homepage and keep the
772 session file to save the session on window close.
773 * MiniBrowser/gtk/BrowserWindow.h:
774 * MiniBrowser/gtk/main.c:
775 (createBrowserWindow): Pass the given session file path when
776 shouldLoadSession is TRUE.
777 (main): Only allow to restore/save session when MiniBrowser is
778 launched without URL arguments.
780 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
782 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
784 Geolocation is no longer allowed for unique origins after r195075.
786 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
787 (testWebViewGeolocationPermissionRequests):
789 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
791 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
792 https://bugs.webkit.org/show_bug.cgi?id=153216
794 Reviewed by Michael Catanzaro.
796 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
797 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
799 2016-01-18 Nan Wang <n_wang@apple.com>
801 AX: [Mac] Implement next/previous text marker functions using TextIterator
802 https://bugs.webkit.org/show_bug.cgi?id=152728
804 Reviewed by Chris Fleizach.
806 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
807 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
809 2016-01-18 Csaba Osztrogonác <ossy@webkit.org>
811 [cmake] Add testair to the build system
812 https://bugs.webkit.org/show_bug.cgi?id=153126
814 Reviewed by Michael Catanzaro.
818 2016-01-16 Myles C. Maxfield <mmaxfield@apple.com>
820 Remove TextRun::allowsRoundingHacks()
821 https://bugs.webkit.org/show_bug.cgi?id=153185
823 Reviewed by Simon Fraser.
825 * DumpRenderTree/mac/DumpRenderTree.mm:
826 (resetWebViewToConsistentStateBeforeTesting): Deleted.
828 2016-01-15 Konstantin Tokarev <annulen@yandex.ru>
830 [webkitdirs] Avoid list form of open because it broke WinCairo
831 https://bugs.webkit.org/show_bug.cgi?id=153106
833 Reviewed by Alex Christensen.
835 * Scripts/webkitdirs.pm:
836 (determineArchitecture):
838 2016-01-15 Simon Fraser <simon.fraser@apple.com>
840 Add kdebug_trace signposts for a few WebCore operations
841 https://bugs.webkit.org/show_bug.cgi?id=153136
842 rdar://problem/24208487
844 Reviewed by Sam Weinig.
846 Plist used by kdebug_trace() viewing tools.
848 * Tracing/SystemTracePoints.plist: Added.
850 2016-01-14 Konstantin Tokarev <annulen@yandex.ru>
852 [webkitdirs] Replaced grep invocation with perl code
853 https://bugs.webkit.org/show_bug.cgi?id=153106
855 Reviewed by Alex Christensen.
857 * Scripts/webkitdirs.pm:
858 (determineArchitecture):
860 2016-01-14 Brian Burg <bburg@apple.com>
862 prepare-changelog does not read paths containing spaces properly
863 https://bugs.webkit.org/show_bug.cgi?id=137982
865 Reviewed by Joseph Pecoraro.
867 Escape whitespace in filenames before passing the file path to other functions.
869 * Scripts/prepare-ChangeLog:
870 (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
872 2016-01-14 Jason Marcell <jmarcell@apple.com>
874 Standardize the usage of "branch" vs. "branchName".
875 https://bugs.webkit.org/show_bug.cgi?id=152982
877 Reviewed by Daniel Bates.
879 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
880 "branchName" implies that the variable or property in question is simply a string.
882 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
883 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
884 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
885 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
886 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
887 (Trac.prototype.commitsOnBranch): Change branch to branchName.
888 (Trac.prototype._convertCommitInfoElementToObject): Ditto.
889 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
892 2016-01-14 Jason Marcell <jmarcell@apple.com>
894 Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
895 https://bugs.webkit.org/show_bug.cgi?id=152910
897 Reviewed by Daniel Bates.
899 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
900 (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
901 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
902 (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
903 the need to talk to a real Buildbot server.
904 (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
905 without the need to talk to a real Buildbot server.
906 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
907 (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
909 (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
910 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
911 (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
912 trying to talk to Trac.
913 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
915 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
917 2016-01-14 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
919 [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
920 https://bugs.webkit.org/show_bug.cgi?id=132599
922 Reviewed by Michael Catanzaro.
924 Check if cmake Ninja generators are installed.
926 * Scripts/webkitdirs.pm:
927 (canUseNinjaGenerator):
928 (canUseEclipseNinjaGenerator):
929 (generateBuildSystemFromCMakeProject):
930 (canUseEclipse): Deleted.
932 2016-01-13 Myles C. Maxfield <mmaxfield@apple.com>
934 [Cocoa] Testing with font family name "System Font" is unused
935 https://bugs.webkit.org/show_bug.cgi?id=153073
936 <rdar://problem/24091683>
938 Reviewed by Brent Fulgham.
940 * DumpRenderTree/mac/DumpRenderTree.mm:
941 (allowedFontFamilySet): Deleted.
942 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
943 (WTR::allowedFontFamilySet): Deleted.
944 * WebKitTestRunner/mac/TestControllerMac.mm:
945 (WTR::allowedFontFamilySet): Deleted.
947 2016-01-13 Daniel Bates <dabates@apple.com>
949 [XSS Auditor] Add test when XSS payload is in the path portion of the URL
950 https://bugs.webkit.org/show_bug.cgi?id=152871
952 Reviewed by Brent Fulgham.
954 Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
955 <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
957 * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
959 2016-01-08 Andy Estes <aestes@apple.com>
961 [Content Filtering] Lazily load platform frameworks
962 https://bugs.webkit.org/show_bug.cgi?id=152881
963 rdar://problem/23270886
965 Reviewed by Brady Eidson.
967 Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
968 expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
969 loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
970 and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
971 is loaded after an HTTPS request.
973 To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
974 Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
975 WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
976 also re-enabled on iOS after mistakenly being disabled by r188892.
978 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
979 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
980 (TestWebKitAPI::TEST):
981 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
982 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
983 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
986 (-[LazilyLoadPlatformFrameworksController init]):
987 (-[LazilyLoadPlatformFrameworksController webView]):
988 (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
989 (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
990 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
991 (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
992 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
993 (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
994 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
995 (TestWebKitAPI::TEST):
996 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
997 (TestWebKitAPI::TEST): Deleted.
998 * TestWebKitAPI/cocoa/TestProtocol.h:
999 * TestWebKitAPI/cocoa/TestProtocol.mm:
1000 (+[TestProtocol registerWithScheme:]):
1001 (+[TestProtocol unregister]):
1003 2016-01-12 Dewei Zhu <dewei_zhu@apple.com>
1005 Fix the Sunpider converage in slow device.
1006 https://bugs.webkit.org/show_bug.cgi?id=152938
1007 <rdar://problem/22511411>
1009 Reviewed by Ryosuke Niwa.
1011 Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
1013 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
1015 2016-01-12 Ryosuke Niwa <rniwa@webkit.org>
1017 Add a build flag for custom element
1018 https://bugs.webkit.org/show_bug.cgi?id=153005
1020 Reviewed by Alex Christensen.
1022 Added --custom-elements option to enable custom elements support.
1024 * Scripts/webkitperl/FeatureList.pm:
1026 2016-01-12 Benjamin Poulain <bpoulain@apple.com>
1028 [JSC] Add a help message when run-jsc-stress-tests fails
1029 https://bugs.webkit.org/show_bug.cgi?id=153014
1031 Reviewed by Csaba Osztrogonác.
1033 * Scripts/run-jsc-stress-tests:
1035 2016-01-11 Saam barati <sbarati@apple.com>
1037 run-jsc-stress-tests should try to figure out a JSC path
1038 https://bugs.webkit.org/show_bug.cgi?id=152971
1040 Reviewed by Yusuke Suzuki.
1042 This patch now allows run-jsc-stress-tests to be run
1043 without a "--jsc <jsc-path>" argument. It tries
1044 to take its best guess at a <jsc-path> automagically.
1046 This makes it much easier to just run run-jsc-stress-tests
1047 with a directory or a yaml file as an argument.
1048 You now just do this:
1049 `run-jsc-stress-tests <path-to-yaml>`
1051 `run-jsc-stress-tests <path-to-directory-of-js-files>`
1053 I wrote this patch because I'd often find myself hacking the
1054 run-javascriptcore-tests file just to run a particular subset of tests.
1055 Because I always forget the arguments to run-jsc-stress-tests (which means
1056 I always forgot to provide a --jsc argument), I always found it easier to
1057 just hack on that file instead of calling run-jsc-stress-tests directly.
1058 No longer is this true!
1060 * Scripts/run-jsc-stress-tests:
1062 2016-01-09 Andy Estes <aestes@apple.com>
1064 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1065 https://bugs.webkit.org/show_bug.cgi?id=152950
1066 rdar://problem/24066652
1068 Reviewed by Tim Horton.
1072 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1073 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1074 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1075 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1076 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1077 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1078 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1079 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1082 2016-01-11 Commit Queue <commit-queue@webkit.org>
1084 Unreviewed, rolling out r194866.
1085 https://bugs.webkit.org/show_bug.cgi?id=152986
1087 This change broke the mac build (Requested by ryanhaddad on
1092 "[Cocoa] Add SPI to opt out a URL scheme from the memory
1094 https://bugs.webkit.org/show_bug.cgi?id=152950
1095 http://trac.webkit.org/changeset/194866
1097 2016-01-11 Andy Estes <aestes@apple.com>
1099 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1100 https://bugs.webkit.org/show_bug.cgi?id=152950
1101 rdar://problem/24066652
1103 Reviewed by Tim Horton.
1107 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1108 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1109 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1110 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1111 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1112 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1113 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1114 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1117 2016-01-11 Konstantin Tokarev <annulen@yandex.ru>
1119 [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
1120 https://bugs.webkit.org/show_bug.cgi?id=152959
1122 Reviewed by Brent Fulgham.
1124 * Scripts/webkitdirs.pm:
1125 (determineArchitecture):
1127 2016-01-11 Michael Catanzaro <mcatanzaro@igalia.com>
1129 [GTK] W3C CSS2.1 anonymous table tests are failing
1130 https://bugs.webkit.org/show_bug.cgi?id=152455
1132 Reviewed by Mario Sanchez Prada.
1134 Add shared-mime-info to the jhbuild environment, since it affects the results of layout
1135 tests. Add upstream patches to fix detection of XHTML files.
1137 * gtk/jhbuild.modules:
1138 * gtk/patches/shared-mime-info-xht-glob.patch: Added.
1139 * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
1141 2016-01-10 Saam barati <sbarati@apple.com>
1143 Implement a sampling profiler
1144 https://bugs.webkit.org/show_bug.cgi?id=151713
1146 Reviewed by Filip Pizlo.
1148 * Scripts/run-jsc-stress-tests:
1150 2016-01-10 Konstantin Tokarev <annulen@yandex.ru>
1152 [webkitdirs] Try arch and uname commands on non-windows OS
1153 https://bugs.webkit.org/show_bug.cgi?id=152958
1155 Reviewed by Michael Catanzaro.
1157 Right now, determineArchitecture() uses `arch` and `uname -m`
1158 commands to determine architecture in case of condition (isGtk() ||
1159 isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
1160 instead, because this code is applicable to any non-windows OS WebKit
1161 supports (even Haiku which once was supported is moderately
1162 POSIX-compliant and has uname command).
1164 * Scripts/webkitdirs.pm:
1165 (determineArchitecture):
1167 2016-01-08 Aakash Jain <aakash_jain@apple.com>
1169 run-webkit-tests mis-counts totals when there are other crashes
1170 https://bugs.webkit.org/show_bug.cgi?id=152894
1171 <rdar://problem/24098697>
1173 Reviewed by Alexey Proskuryakov.
1175 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1176 (TestRunResults.add): Do not update result counters for other crashes.
1178 2016-01-08 Youenn Fablet <youenn.fablet@crf.canon.fr>
1180 webkit-patch build-and-test should have an option to iterate over new tests
1181 https://bugs.webkit.org/show_bug.cgi?id=143093
1183 Reviewed by Michael Catanzaro.
1185 This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
1186 It allows running run-webkit-tests on modified or new paths in LayoutTests.
1187 Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
1188 It implements the translation of -expected.* paths to their related tests.
1189 It also implements the removal of skipped tests.
1191 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1192 (LayoutTestFinder.find_touched_tests):
1193 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
1195 (MockPort.__init__):
1197 (LayoutTestFinderTests):
1198 (LayoutTestFinderTests.touched_files):
1199 (LayoutTestFinderTests.test_touched_test):
1200 (LayoutTestFinderTests.test_expected_touched_test):
1201 (LayoutTestFinderTests.test_platform_expected_touched_test):
1202 (LayoutTestFinderTests.test_platform_duplicate_touched_test):
1203 (LayoutTestFinderTests.test_touched_but_skipped_test):
1204 * Scripts/webkitpy/port/base.py:
1205 (Port.potential_test_names_from_expected_file):
1206 * Scripts/webkitpy/tool/commands/download_unittest.py:
1207 (DownloadCommandsTest._default_options):
1208 * Scripts/webkitpy/tool/steps/options.py:
1210 * Scripts/webkitpy/tool/steps/runtests.py:
1214 (RunTests._new_or_modified_tests):
1215 (RunTests._run_webkit_tests):
1216 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1217 (RunTestsTest.test_webkit_run_unit_tests):
1218 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1219 (StepsTest._step_options):
1221 2016-01-07 Joseph Pecoraro <pecoraro@apple.com>
1223 prepare-ChangeLog should include radar number
1224 https://bugs.webkit.org/show_bug.cgi?id=152839
1225 <rdar://problem/24093563>
1227 Reviewed by Daniel Bates.
1229 When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
1230 starts with a "<rdar://problem/####>" URL. If found, include that radar URL
1231 in the ChangeLog description after the bug URL.
1233 * Scripts/prepare-ChangeLog:
1234 (main): Update signatures.
1235 (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
1236 (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
1237 (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
1238 (generateNewChangeLogs): Include radar URL if we found one.
1240 * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
1241 Tests for the radar URL extraction.
1243 2016-01-07 Alexey Proskuryakov <ap@apple.com>
1245 testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
1246 https://bugs.webkit.org/show_bug.cgi?id=152390
1247 <rdar://problem/23948321>
1249 Reviewed by Simon Fraser.
1251 Fix two use-after-frees.
1253 1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
1254 but we may have already progressed to another test by the time the callback fires,
1255 having destroyed the TestInvocation.
1256 2. UIScriptController is a RefCounted object, but it has a raw pointer to
1257 UIScriptContext which has the same lifetime as a TestInvocation.
1258 As a result, completion blocks of UIScriptController actions would use a destroyed
1261 * WebKitTestRunner/TestInvocation.cpp:
1262 (WTR::TestInvocation::~TestInvocation):
1263 (WTR::TestInvocation::url):
1264 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1265 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1266 (WTR::TestInvocation::runUISideScript):
1267 * WebKitTestRunner/TestInvocation.h:
1268 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1269 (UIScriptContext::UIScriptContext):
1270 (UIScriptContext::~UIScriptContext):
1271 (UIScriptContext::runUIScript):
1272 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1273 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1274 (WTR::UIScriptController::UIScriptController):
1275 (WTR::UIScriptController::contextDestroyed):
1276 (WTR::UIScriptController::makeWindowObject):
1277 (WTR::UIScriptController::setWillBeginZoomingCallback):
1278 (WTR::UIScriptController::willBeginZoomingCallback):
1279 (WTR::UIScriptController::setDidEndZoomingCallback):
1280 (WTR::UIScriptController::didEndZoomingCallback):
1281 (WTR::UIScriptController::setDidEndScrollingCallback):
1282 (WTR::UIScriptController::didEndScrollingCallback):
1283 (WTR::UIScriptController::setDidShowKeyboardCallback):
1284 (WTR::UIScriptController::didShowKeyboardCallback):
1285 (WTR::UIScriptController::setDidHideKeyboardCallback):
1286 (WTR::UIScriptController::didHideKeyboardCallback):
1287 (WTR::UIScriptController::uiScriptComplete):
1288 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1289 (WTR::UIScriptController::create):
1290 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1291 (WTR::UIScriptController::doAsyncTask):
1292 (WTR::UIScriptController::zoomToScale):
1293 (WTR::UIScriptController::singleTapAtPoint):
1294 (WTR::UIScriptController::doubleTapAtPoint):
1295 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1296 (WTR::UIScriptController::contentVisibleRect):
1297 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1298 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1299 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1300 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1301 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
1302 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1303 (WTR::UIScriptController::doAsyncTask):
1305 2016-01-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
1307 [buildbot] clean-build script should remove untracked files and revert local changes too
1308 https://bugs.webkit.org/show_bug.cgi?id=142400
1310 Reviewed by Ryosuke Niwa.
1312 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1313 A helper routine SCM.discard_untracked_files is added for that purpose.
1315 * BuildSlaveSupport/clean-build:
1316 (main): Making call to Scripts/clean-webkit
1317 * Scripts/clean-webkit: Added.
1318 (main): Revert changes and delete untracked files.
1319 * Scripts/webkitpy/common/checkout/scm/scm.py:
1320 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1321 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1322 (SCMTest._shared_test_discard_untracked_files):
1323 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1325 2016-01-06 Simon Fraser <simon.fraser@apple.com>
1327 Add a setting and preferences to enable display-list drawing. Does nothing yet.
1328 https://bugs.webkit.org/show_bug.cgi?id=152807
1330 Reviewed by Zalan Bujtas.
1332 Add an item to the Settings menu to toggle display-list drawing.
1334 * MiniBrowser/mac/SettingsController.h:
1335 * MiniBrowser/mac/SettingsController.m:
1336 (-[SettingsController _populateMenu]):
1337 (-[SettingsController validateMenuItem:]):
1338 (-[SettingsController toggleDisplayListDrawingEnabled:]):
1339 (-[SettingsController displayListDrawingEnabled]):
1340 * MiniBrowser/mac/WK2BrowserWindowController.m:
1341 (-[WK2BrowserWindowController didChangeSettings]):
1343 2016-01-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
1345 Python SCM should be able to retrieve untracked files - Add GIT support
1346 https://bugs.webkit.org/show_bug.cgi?id=143135
1348 Reviewed by Michael Catanzaro.
1350 * Scripts/webkitpy/common/checkout/scm/git.py:
1351 (Git.untracked_files): Adding support for git.
1352 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1354 (GitTest.test_untracked_files): Adding test.
1356 2016-01-05 Mark Lam <mark.lam@apple.com>
1358 Rename badly named JSC_timeout env var to JSCTEST_timeout.
1359 https://bugs.webkit.org/show_bug.cgi?id=152748
1361 Reviewed by Geoffrey Garen.
1363 Now that we validate JSC options, the badly named JSC_timeout env var causes the
1364 bots to have a bad time.
1366 * Scripts/run-javascriptcore-tests:
1367 * Scripts/run-jsc-stress-tests:
1369 2016-01-04 Carlos Garcia Campos <cgarcia@igalia.com>
1371 [GTK] Allow to save and restore session
1372 https://bugs.webkit.org/show_bug.cgi?id=115600
1374 Reviewed by Michael Catanzaro.
1376 Add test case to check the new session API.
1378 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1379 (testWebKitWebViewSessionState):
1380 (testWebKitWebViewSessionStateWithFormData):
1383 2016-01-04 Csaba Osztrogonác <ossy@webkit.org>
1385 [EFL] Bump EFL version to 1.16.1
1386 https://bugs.webkit.org/show_bug.cgi?id=152688
1388 Reviewed by Gyuyoung Kim.
1390 * efl/jhbuild.modules:
1392 2016-01-04 Aakash Jain <aakash_jain@apple.com>
1394 error running layout tests on iOS simulator on latest build
1395 https://bugs.webkit.org/show_bug.cgi?id=152719
1396 <rdar://problem/24009549>
1398 Reviewed by Alexey Proskuryakov.
1400 * Scripts/webkitpy/xcode/simulator.py:
1401 (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1402 before running simctl spawn command.
1404 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
1406 Unreviewed, move Frédéric Wang to committers list
1408 He seems to be on the contributors list by accident. He has been landing his own commits for
1409 about two years now.
1411 * Scripts/webkitpy/common/config/contributors.json:
1413 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
1415 Unreviewed, move Sebastian Dröge to committers list harder
1417 He accidentally added himself to the reviewers list because the file is confusing. Then I
1418 accidentially moved him to the contributors list because the file is confusing, even though
1419 I knew the contributors list existed in this file and was attempting to add him to the
1420 committers list. Really move him to the committers list now.
1422 * Scripts/webkitpy/common/config/contributors.json:
1424 2016-01-02 Youenn Fablet <youenn.fablet@crf.canon.fr>
1426 Python SCM should be able to retrieve untracked files - Add SVN support
1427 https://bugs.webkit.org/show_bug.cgi?id=152546
1429 Reviewed by Michael Catanzaro.
1431 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1432 (test_untracked_files): Activating test for SVN.
1433 * Scripts/webkitpy/common/checkout/scm/svn.py:
1434 (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1436 2015-12-31 Andy Estes <aestes@apple.com>
1438 Replace WTF::move with WTFMove
1439 https://bugs.webkit.org/show_bug.cgi?id=152601
1441 Reviewed by Brady Eidson.
1443 * DumpRenderTree/TestRunner.h:
1444 (TestRunner::setAllowedHosts):
1445 * DumpRenderTree/win/DRTDataObject.cpp:
1446 (DRTDataObject::SetData):
1447 * TestWebKitAPI/Tests/WTF/Deque.cpp:
1448 (TestWebKitAPI::TEST):
1449 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1450 (TestWebKitAPI::TEST):
1451 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1452 (TestWebKitAPI::TEST):
1453 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1454 (TestWebKitAPI::TEST):
1455 * TestWebKitAPI/Tests/WTF/Ref.cpp:
1456 (TestWebKitAPI::passWithRef):
1457 (TestWebKitAPI::TEST):
1458 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1459 (TestWebKitAPI::TEST):
1460 * TestWebKitAPI/Tests/WTF/Vector.cpp:
1461 (TestWebKitAPI::TEST):
1462 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1463 (TestWebKitAPI::TEST):
1464 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1465 (TestWebKitAPI::TEST):
1466 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1467 (TestWebKitAPI::createTestValue):
1468 (TestWebKitAPI::TEST):
1469 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1470 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1471 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1472 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1473 (TestWebKitAPI::createNFAs):
1474 (TestWebKitAPI::TEST_F):
1475 * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1476 (TestWebKitAPI::combine):
1477 * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1478 (TestWebKitAPI::createNFAs):
1479 * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1481 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1482 (WebProcessTest::add):
1484 2016-01-01 Michael Catanzaro <mcatanzaro@igalia.com>
1486 [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1487 https://bugs.webkit.org/show_bug.cgi?id=152634
1489 Reviewed by Carlos Garcia Campos.
1491 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1492 (testLoadFromGResource): Added test.
1494 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1495 (registerGResource): Added.
1496 (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1497 * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1498 * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1500 2015-12-31 David Kilzer <ddkilzer@apple.com>
1502 REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1503 <https://bugs.webkit.org/show_bug.cgi?id=152601>
1505 Ignore unknown pragmas on older clangs. Fixes the following
1508 Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1509 #pragma clang diagnostic ignored "-Wself-move"
1513 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1514 (TestWebKitAPI::TEST):
1515 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1516 (TestWebKitAPI::TEST):
1518 2015-12-31 Andy Estes <aestes@apple.com>
1520 Update the style checker to advise using WTFMove() instead of WTF::move()
1521 https://bugs.webkit.org/show_bug.cgi?id=152601
1523 Reviewed by Daniel Bates.
1525 * Scripts/webkitpy/style/checkers/cpp.py:
1527 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1528 (WebKitStyleTest.test_wtf_move):
1530 2015-12-31 Andy Estes <aestes@apple.com>
1532 Fix warnings uncovered by migrating to WTF_MOVE
1533 https://bugs.webkit.org/show_bug.cgi?id=152601
1535 Reviewed by Daniel Bates.
1537 Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1538 self-move, even if doing so would trigger a warning.
1540 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1541 (TestWebKitAPI::TEST):
1542 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1543 (TestWebKitAPI::TEST):
1545 2015-12-31 Martin Robinson <mrobinson@igalia.com>
1547 [GTK] The install-dependencies script has a syntax error
1548 https://bugs.webkit.org/show_bug.cgi?id=152613
1550 Reviewed by Michael Catanzaro.
1552 * gtk/install-dependencies: Add the missing 'then.'
1554 2015-12-30 Philippe Normand <pnormand@igalia.com>
1556 [Mac][GTK] Jhbuild support for OSX
1557 https://bugs.webkit.org/show_bug.cgi?id=150799
1559 Reviewed by Michael Catanzaro.
1561 * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1562 * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1563 * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1564 * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1566 2015-12-28 Michael Catanzaro <mcatanzaro@igalia.com>
1568 Unreviewed, move Sebastian Dröge to committers list
1570 He accidentally added himself to the reviewers list because the file is confusing.
1572 * Scripts/webkitpy/common/config/contributors.json:
1574 2015-12-24 Simon Fraser <simon.fraser@apple.com>
1576 Remove the unused #define _USE_MATH_DEFINES
1577 https://bugs.webkit.org/show_bug.cgi?id=152034
1579 Reviewed by Tim Horton.
1581 Update this test to use piDouble from MathExtras.h, and
1582 std::numeric_limits<>.
1584 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1586 2015-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
1588 Python SCM should be able to retrieve untracked files - Generic changes
1589 https://bugs.webkit.org/show_bug.cgi?id=152536
1591 Reviewed by Brent Fulgham.
1593 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1594 No support is yet added to GIT and SVN specific implementations.
1596 * Scripts/webkitpy/common/checkout/scm/scm.py:
1597 (SCM.untracked_files):
1598 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1599 (SCMTest._shared_test_untracked_files):
1601 2015-12-23 Dewei Zhu <dewei_zhu@apple.com>
1603 SVN checkout used by RunBenchmark should be non-interactive
1604 https://bugs.webkit.org/show_bug.cgi?id=152542
1606 Reviewed by Ryosuke Niwa.
1608 RunBenchmark should not require user interaction while running.
1610 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1611 (BenchmarkBuilder._checkout_with_subversion):
1613 2015-12-23 Brent Fulgham <bfulgham@apple.com>
1615 Web Inspector: add support for running protocol-test.js tests on Windows
1616 https://bugs.webkit.org/show_bug.cgi?id=148037
1617 <rdar://problem/22292237>
1619 Reviewed by Simon Fraser.
1621 * DumpRenderTree/win/TestRunnerWin.cpp:
1622 (TestRunner::inspectorTestStubURL): Provide implementation.
1624 2015-12-23 Eric Carlson <eric.carlson@apple.com>
1626 [MediaStream] MediaDeviceInfo.label must be empty in some situations
1627 https://bugs.webkit.org/show_bug.cgi?id=152000
1629 Reviewed by Brent Fulgham.
1631 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1632 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1633 (WTR::InjectedBundle::setUserMediaPermission):
1634 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1635 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1637 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1638 (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1639 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1641 * WebKitTestRunner/TestController.cpp:
1642 (WTR::TestController::setUserMediaPermissionForOrigin):
1643 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1644 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
1645 persistent permission for origin, that can be done from script now.
1646 * WebKitTestRunner/TestController.h:
1648 * WebKitTestRunner/TestInvocation.cpp:
1649 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1650 SetUserMediaPermissionForOrigin.
1652 2015-12-23 Brent Fulgham <bfulgham@apple.com>
1654 [Win] Unreviewed build fix: Recognize Windows 10 variants.
1656 * Scripts/webkitpy/common/system/platforminfo.py:
1657 (PlatformInfo._determine_win_version):
1659 2015-12-23 Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1661 Content blockers should be able to promote http to https
1662 https://bugs.webkit.org/show_bug.cgi?id=148966
1664 Reviewed by Benjamin Poulain.
1666 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1667 (WebCore::ContentExtensions::operator<<):
1668 (TestWebKitAPI::TEST_F):
1670 2015-12-22 Hunseop Jeong <hs85.jeong@samsung.com>
1672 [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1673 https://bugs.webkit.org/show_bug.cgi?id=152516
1675 Reviewed by Gyuyoung Kim.
1677 * MiniBrowser/efl/main.c:
1679 2015-12-22 Brent Fulgham <bfulgham@apple.com>
1681 Unreviewed: Add John Wilander as a contributor.
1683 * Scripts/webkitpy/common/config/contributors.json:
1685 2015-12-22 Chris Fleizach <cfleizach@apple.com>
1687 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1688 https://bugs.webkit.org/show_bug.cgi?id=152482
1690 Reviewed by Brent Fulgham.
1692 vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1693 for the same property. On WK2, the element returned will not be valid, but is still present and
1694 that can lead to looping.
1696 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1697 (AccessibilityUIElement::horizontalScrollbar):
1698 (AccessibilityUIElement::verticalScrollbar):
1699 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1700 (WTR::AccessibilityUIElement::horizontalScrollbar):
1701 (WTR::AccessibilityUIElement::verticalScrollbar):
1703 2015-12-22 Xabier Rodriguez Calvar <calvaris@igalia.com>
1707 * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1709 2015-12-21 Hunseop Jeong <hs85.jeong@samsung.com>
1711 [EFL] test_ewk2_context failed after r192808
1712 https://bugs.webkit.org/show_bug.cgi?id=151846
1714 Reviewed by Gyuyoung Kim.
1716 Used the added ewk_context_web_process_count_limit_set api
1717 instead of the deprecated ewk_context_process_model_set.
1719 * MiniBrowser/efl/main.c:
1722 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
1724 Unreviewed, move myself to reviewer list.
1726 * Scripts/webkitpy/common/config/contributors.json:
1728 2015-12-21 Aakash Jain <aakash_jain@apple.com>
1730 Unreviewed, add myself to the committers list.
1732 * Scripts/webkitpy/common/config/contributors.json:
1734 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
1736 [GTK] jquery.min.js violates DFSG
1737 https://bugs.webkit.org/show_bug.cgi?id=152428
1739 Reviewed by Joseph Pecoraro.
1741 Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1742 into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1744 * gtk/manifest.txt.in:
1746 2015-12-19 Dan Bernstein <mitz@apple.com>
1748 [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1749 https://bugs.webkit.org/show_bug.cgi?id=152462
1751 Reviewed by Alexey Proskuryakov.
1753 - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1756 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1757 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1758 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1759 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1760 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1762 - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1763 never getting compiled:
1765 * DumpRenderTree/mac/TextInputController.m:
1766 * MiniBrowser/mac/BrowserWindowController.m:
1767 * TestWebKitAPI/Tests/mac/AttributedString.mm:
1768 * WebKitTestRunner/mac/EventSenderProxy.mm:
1770 2015-12-18 Michael Catanzaro <mcatanzaro@igalia.com>
1772 Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1774 This is to make it easy to CC it on Bugzilla.
1776 * Scripts/webkitpy/common/config/contributors.json:
1778 2015-12-18 Aakash Jain <aakash_jain@apple.com>
1780 Pasteboard get messed up after running kill-old-processes
1781 https://bugs.webkit.org/show_bug.cgi?id=152426
1783 Reviewed by Alexey Proskuryakov.
1785 * BuildSlaveSupport/kill-old-processes:
1786 (main): Do not kill pasteboard anymore.
1788 2015-12-17 Aakash Jain <aakash_jain@apple.com>
1790 run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1791 https://bugs.webkit.org/show_bug.cgi?id=152157
1792 <rdar://problem/23851817>
1794 Reviewed by Alexey Proskuryakov.
1796 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1797 (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1798 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1799 (Manager._get_test_inputs): Common method to calculate test_inputs.
1800 (Manager._update_worker_count): Calculate and update required number of workers.
1802 2015-12-16 Aakash Jain <aakash_jain@apple.com>
1804 run-webkit-tests fails to delete Simulator device during cleanup
1805 https://bugs.webkit.org/show_bug.cgi?id=152363
1807 Reviewed by Alexey Proskuryakov.
1809 * Scripts/webkitpy/xcode/simulator.py:
1810 (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1812 2015-12-16 Tim Horton <timothy_horton@apple.com>
1814 [mac-wk2] fast/events force click tests crashing
1815 https://bugs.webkit.org/show_bug.cgi?id=152339
1817 Reviewed by Beth Dakin.
1819 * WebKitTestRunner/mac/EventSenderProxy.mm:
1820 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1821 Set the NSEvent's _type member in addition to overriding -type,
1822 because there are assertions in touch event handling code that depend on it.
1824 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1826 Enforce temporarily bots to sync WebKit and WPT testharness.js
1827 https://bugs.webkit.org/show_bug.cgi?id=152334
1829 Reviewed by Darin Adler.
1831 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1832 (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1834 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1836 [Fetch API] Add fetch API compile time flag
1837 https://bugs.webkit.org/show_bug.cgi?id=152254
1839 Reviewed by Darin Adler.
1841 * Scripts/webkitperl/FeatureList.pm:
1843 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1847 Added files that have impact in building Streams API to the watchlist.
1849 * Scripts/webkitpy/common/config/watchlist:
1851 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1855 Added imported tests to Streams API watchlist.
1857 * Scripts/webkitpy/common/config/watchlist:
1859 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1861 Remove default copy of wpt testharness.js when launching wpt server
1862 https://bugs.webkit.org/show_bug.cgi?id=152298
1864 Reviewed by Darin Adler.
1866 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1867 (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1869 2015-12-15 David Kilzer <ddkilzer@apple.com>
1871 REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1872 <http://webkit.org/b/152314>
1874 Reviewed by Daniel Bates.
1876 The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1877 code path to exit immediately when calling main().
1878 Unfortunately, DumpRenderTreeMain.mm was used for both
1879 DumpRenderTree command-line binary and DumpRenderTree.app, which
1880 meant that the app would exit immediately with no error code
1883 The workaround is to introduce a separate source file called
1884 DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1887 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1888 DumpRenderTreeAppMain.mm to the project. Make it the only
1889 compiled source for the DumpRenderTree.app target.
1890 * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1891 (main): Call DumpRenderTreeMain() on iOS. Assert on OS X in
1892 case someone tries mistakenly to use the app.
1893 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1894 Link to JavaScriptCore.framework on iOS for the assert.
1895 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1896 Link to JavaScriptCore.framework on OS X for the assert. Remove
1897 unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1898 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1899 (main): Add assert for iOS so that a crash occurs if someone
1900 tries to run the wrong command.
1902 2015-12-14 Tim Horton <timothy_horton@apple.com>
1904 Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1905 https://bugs.webkit.org/show_bug.cgi?id=152266
1906 <rdar://problem/22092676>
1908 Reviewed by Simon Fraser.
1910 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1911 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1912 Add a test that crashed before this change, and doesn't crash after.
1914 2015-12-14 Chris Fleizach <cfleizach@apple.com>
1916 AX: iOS: Text field variations do not have the correct traits
1917 https://bugs.webkit.org/show_bug.cgi?id=152237
1919 Reviewed by Mario Sanchez Prada.
1921 Add iOS calls for determing if an object is a search field or a text area.
1923 * DumpRenderTree/AccessibilityUIElement.cpp:
1924 (getIsSearchFieldCallback):
1925 (getIsTextAreaCallback):
1926 (stringForSelectionCallback):
1927 (AccessibilityUIElement::getJSClass):
1928 * DumpRenderTree/AccessibilityUIElement.h:
1929 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1930 (AccessibilityUIElement::identifier):
1931 (AccessibilityUIElement::isTextArea):
1932 (AccessibilityUIElement::isSearchField):
1933 (AccessibilityUIElement::traits):
1934 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1935 (WTR::AccessibilityUIElement::scrollPageRight):
1936 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1937 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1938 (WTR::AccessibilityUIElement::isSearchField):
1939 (WTR::AccessibilityUIElement::isTextArea):
1940 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1941 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1942 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1943 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1944 (WTR::AccessibilityUIElement::isTextArea):
1945 (WTR::AccessibilityUIElement::isSearchField):
1946 (WTR::AccessibilityUIElement::rowCount):
1948 2015-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
1950 [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1951 https://bugs.webkit.org/show_bug.cgi?id=152252
1953 Reviewed by Sergio Villar Senin.
1955 * gtk/install-dependencies: Add libtool-bin to the list of packages required
1956 for building the JHBuild on Debian systems.
1958 2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
1960 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1961 https://bugs.webkit.org/show_bug.cgi?id=152156
1963 Reviewed by Dan Bernstein.
1965 Our frameworks should appropriately prefix all ObjC classes,
1966 not just external symbols.
1968 * Scripts/check-for-inappropriate-objc-class-names:
1969 Remove the -g switch to check all ObjC class names.
1971 2015-12-10 Eric Carlson <eric.carlson@apple.com>
1973 [MediaStream] Expose media capture devices persistent permissions to WebCore
1974 https://bugs.webkit.org/show_bug.cgi?id=152087
1976 Add support for the new user media permission checker page UI client method.
1978 Reviewed by Chris Dumez.
1980 * WebKitTestRunner/TestController.cpp:
1981 (WTR::decidePolicyForUserMediaPermissionRequest):
1982 (WTR::checkUserMediaPermissionForOrigin):
1983 (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1984 (WTR::TestController::createWebViewWithOptions): Ditto.
1985 (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1986 (WTR::originUserVisibleName): New, create a string for the origin.
1987 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1988 according to the state of the origin permission map.
1989 (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1990 request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1991 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1992 origin permission map.
1993 * WebKitTestRunner/TestController.h:
1995 2015-12-10 Alex Christensen <achristensen@webkit.org>
1997 REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1998 https://bugs.webkit.org/show_bug.cgi?id=152022
1999 rdar://problem/23763584
2001 Reviewed by Darin Adler.
2003 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2004 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2005 (WTR::InjectedBundlePage::willSendRequestForFrame):
2006 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2007 (WTR::TestRunner::setWillSendRequestReturnsNull):
2008 (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
2009 (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2010 (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
2011 (WTR::TestRunner::willSendRequestHTTPBody):
2012 Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
2014 2015-12-10 Aakash Jain <aakash_jain@apple.com>
2016 Remove additional simulator checks before running layout-tests
2017 https://bugs.webkit.org/show_bug.cgi?id=152146
2019 Reviewed by Darin Adler.
2021 * Scripts/webkitpy/port/ios.py:
2022 (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
2023 * Scripts/webkitpy/xcode/simulator.py:
2024 (Simulator._boot_and_shutdown_simulator_device): Deleted.
2025 (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
2027 2015-12-09 Aakash Jain <aakash_jain@apple.com>
2029 Run atleast one simulator even if max process limit is low
2030 https://bugs.webkit.org/show_bug.cgi?id=152081
2031 <rdar://problem/23819694>
2033 Reviewed by Alexey Proskuryakov.
2035 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
2037 [GTK] Crash in WebProcess when loading large content with custom URI schemes
2038 https://bugs.webkit.org/show_bug.cgi?id=144262
2040 Reviewed by Carlos Garcia Campos.
2042 Added new unit test to check the additional scenarios we now
2043 handle for custom URI schemes.
2045 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2046 (generateHTMLContent): New helper function to generate big enough content.
2047 (testWebContextURIScheme): New unit test.
2049 2015-12-09 Ryuan Choi <ryuan.choi@navercorp.com>
2051 [EFL] Fix unhandled web process message when launching MiniBrowser
2052 https://bugs.webkit.org/show_bug.cgi?id=152048
2054 Reviewed by Gyuyoung Kim.
2056 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2057 (TestWebKitAPI::TEST):
2059 2015-12-09 Carlos Garcia Campos <cgarcia@igalia.com>
2061 [GTK] Add API to handle beforeunload events
2062 https://bugs.webkit.org/show_bug.cgi?id=139090
2064 Reviewed by Gustavo Noronha Silva.
2066 * MiniBrowser/gtk/BrowserWindow.c:
2067 (browserWindowConstructed):
2068 (browserWindowDeleteEvent):
2069 (browser_window_class_init):
2070 Handle delete-event to prevent the window from being closed when
2071 the page has beforeunload handlers. Use
2072 webkit_web_view_try_close() when the window is requested to be
2074 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2075 (testWebViewJavaScriptDialogs):
2076 Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
2079 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
2081 Refactored initialization code in LoadTrackingTest.
2083 Rubber-stamped by Carlos Garcia Campos.
2085 Small refactoring to make sure that the state of a LoadTrackingTest
2086 gets properly reset before loading new web content.
2088 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2089 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2090 (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
2091 functions and reset the remaining local variables.
2092 (LoadTrackingTest::loadURI): Call reset();
2093 (LoadTrackingTest::loadHtml): Ditto.
2094 (LoadTrackingTest::loadPlainText): Ditto.
2095 (LoadTrackingTest::loadBytes): Ditto.
2096 (LoadTrackingTest::loadRequest): Ditto.
2097 (LoadTrackingTest::reload): Ditto.
2098 (LoadTrackingTest::goBack): Ditto.
2099 (LoadTrackingTest::goForward): Ditto.
2101 2015-12-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2103 [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
2104 https://bugs.webkit.org/show_bug.cgi?id=151942
2106 Reviewed by Darin Adler.
2108 * MiniBrowser/efl/main.c:
2109 (window_create): Enable offline web application cache feature on MiniBrowser.
2112 2015-12-08 Aakash Jain <aakash_jain@apple.com>
2114 https://bugs.webkit.org/show_bug.cgi?id=151243
2115 <rdar://problem/22955197>
2117 Reviewed by Alexey Proskuryakov.
2119 * LayoutTestRelay/LayoutTestRelay/main.m:
2120 (getTestingSimDevice): Use separate testing device for each worker.
2121 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2122 (Manager.run): Perform cleanup even if setup fails.
2123 * Scripts/webkitpy/port/ios.py:
2124 (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
2125 (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
2126 (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
2127 (IOSSimulatorPort._quit_ios_simulator): Same
2128 (IOSSimulatorPort.clean_up_test_run): Same
2129 (IOSSimulatorPort.check_sys_deps): Same
2130 (IOSSimulatorPort.testing_device): Same
2131 (IOSSimulatorPort.reset_preferences): Same
2132 (IOSSimulatorPort.get_simulator_path): Return simulator path.
2133 (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
2134 * Scripts/webkitpy/xcode/simulator.py:
2135 (Device.delete): Delete the simulator device.
2136 (Simulator.delete_device): Same
2137 (Simulator.wait_until_device_is_booted): Wait for device booting.
2139 2015-12-08 Ryuan Choi <ryuan.choi@navercorp.com>
2141 [EFL] Add API to provide preferences before creating ewk_view
2142 https://bugs.webkit.org/show_bug.cgi?id=151587
2144 Reviewed by Gyuyoung Kim.
2146 * MiniBrowser/efl/main.c:
2150 Moved settings related code to configuration() not to update settings
2151 whenever ewk_view is created.
2155 2015-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
2157 Unreviewed. Fix GTK+ API tests after r193639.
2159 The new jhbuild version needs some more variables ot be present in
2160 the builtin dict, even if they are set to None.
2162 * jhbuild/jhbuildutils.py:
2163 (enter_jhbuild_environment_if_available):
2165 2015-12-07 Gustavo Noronha Silva <gns@gnome.org>
2167 [GTK] Notify WebCore when notification is clicked
2168 https://bugs.webkit.org/show_bug.cgi?id=151951
2170 Reviewed by Carlos Garcia Campos.
2172 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2173 (testWebViewNotification): test the new API.
2175 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
2177 'jhbuild build' should fail immediately when building any module fails
2178 https://bugs.webkit.org/show_bug.cgi?id=145697
2180 Reviewed by Carlos Garcia Campos.
2182 * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2183 * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2184 Everything is placed under lib instead of lib64 now.
2185 * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
2186 --exit-on-error when running 'jhbuild build'.
2187 * jhbuild/jhbuildrc_common.py:
2188 (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
2189 jhbuild should be able to handle these for us without breaking things....
2191 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
2193 Add support to import w3c tests from a repository with a different root that the main repo dir
2194 https://bugs.webkit.org/show_bug.cgi?id=151751
2196 Reviewed by Ryosuke Niwa and Youenn Fablet.
2198 We should be able to import tests from repositories that are not pure test repositories and where tests are kept
2199 in a different directory than the repository root.
2201 This patch introduces a new parameter tests_directory that we will use as root directory to search for
2202 tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
2203 requires having the copy_path lists including tuples of origin and destination directories.
2205 * Scripts/webkitpy/w3c/test_downloader.py:
2206 (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
2207 (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
2208 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2209 (TestImporterTest.test_tests_directory): Test.
2211 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
2213 Mock TestRepositories in W3C importer tests
2214 https://bugs.webkit.org/show_bug.cgi?id=151938
2216 Reviewed by Youenn Fablet.
2218 The test importer tests should use a fake repository instead of using the real one. The reason why this happened
2219 is because the test repository method reading the file was using the filesystem directly instead of taking the
2220 host one. This patch changes that.
2222 * Scripts/webkitpy/w3c/test_downloader.py:
2223 (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
2225 (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
2226 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2227 (TestImporterTest.test_harnesslinks_conversion):
2228 (TestImporterTest.test_submodules_generation): Use a fake test repository file.
2230 2015-12-07 David Kilzer <ddkilzer@apple.com>
2232 TestNetscapePlugIn: Address review comment on 193607
2233 <http://webkit.org/b/151881>
2235 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2236 (testSetStatus): Initializing std::unique_ptr<char[]> with
2237 nullptr is redundant.
2239 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2241 [GTK] Add webkit_uri_request_get_http_method
2242 https://bugs.webkit.org/show_bug.cgi?id=151601
2244 Reviewed by Martin Robinson.
2246 Add test case to check HTTP method of WebKitURIRequest.
2248 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2249 (testURIRequestHTTPMethod):
2252 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2253 (sendRequestCallback):
2255 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
2257 [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
2258 https://bugs.webkit.org/show_bug.cgi?id=79918
2260 Reviewed by Gustavo Noronha Silva.
2262 Add unit tests to check the different console messages.
2264 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2265 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
2266 (ConsoleMessageTest::ConsoleMessage::operator==):
2267 (ConsoleMessageTest::consoleMessageReceivedCallback):
2268 (ConsoleMessageTest::ConsoleMessageTest):
2269 (ConsoleMessageTest::~ConsoleMessageTest):
2270 (ConsoleMessageTest::waitUntilConsoleMessageReceived):
2271 (testWebKitConsoleMessageConsoleAPI):
2272 (testWebKitConsoleMessageJavaScriptException):
2273 (testWebKitConsoleMessageNetworkError):
2274 (testWebKitConsoleMessageSecurityError):
2277 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2278 (consoleMessageSentCallback):
2279 (pageCreatedCallback):
2281 2015-12-07 Ryuan Choi <ryuan.choi@navercorp.com>
2283 [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
2284 https://bugs.webkit.org/show_bug.cgi?id=151934
2286 Reviewed by Csaba Osztrogonác.
2288 * MiniBrowser/efl/main.c:
2289 (on_window_deletion): Revert the changes of r192767.
2291 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
2293 [GTK] update-webkitgtk-libs cannot build mesa
2294 https://bugs.webkit.org/show_bug.cgi?id=151535
2296 Reviewed by Martin Robinson.
2298 Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
2299 dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
2300 on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
2301 does not have a stable API and we cannot expect mesa to be buildable unless we control the
2302 LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
2303 --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
2305 * gtk/jhbuild.modules:
2307 2015-12-07 Philippe Normand <pnormand@igalia.com>
2309 [GTK][Mac] libWebExtensionTest link error
2310 https://bugs.webkit.org/show_bug.cgi?id=150802
2312 Reviewed by Carlos Garcia Campos.
2314 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
2316 2015-12-06 David Kilzer <ddkilzer@apple.com>
2318 TestNetscapePlugIn: Fix leaks found by static analyzer
2319 <http://webkit.org/b/151881>
2321 Reviewed by Darin Adler.
2323 Fixes the following leaks found by the static analyzer:
2324 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
2327 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
2330 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
2334 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2335 (toCString): Switch to returning std::unique_ptr<char[]>. Add
2336 early return if allocation fails.
2337 (testPostURLFile): Switch to using std::unique_ptr<char[]>.
2338 Make sure to call fclose() on filehandle, even for an early
2340 (testSetStatus): Switch to using std::unique_ptr<char[]>.
2342 2015-12-05 David Kilzer <ddkilzer@apple.com>
2344 prepare-ChangeLog: Fix some warning messages when using svn
2345 <http://webkit.org/b/151914>
2347 Reviewed by Daniel Bates.
2349 * Scripts/prepare-ChangeLog:
2350 (generateFunctionLists): Simplify logic so that we never call
2351 normalizePath() with an undefined value.
2352 (attributeCommand): Quote $subPath for the shell so that we
2353 don't try to run "svn propget" on invalid paths.
2355 2015-12-04 David Kilzer <ddkilzer@apple.com>
2357 TestNetscapePlugIn: Fix remaining static analyzer warnings
2358 <http://webkit.org/b/151888>
2360 Reviewed by Alexey Proskuryakov.
2362 Fixes the following static analyzer warnings:
2363 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2366 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2367 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2369 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2370 return obj->pluginTest->NPP_SetWindow(window);
2372 2 warnings generated.
2374 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2375 (CRASH): Use __builtin_trap() for gcc/clang.
2376 (NPP_SetWindow): Add early return if obj is nullptr.
2378 2015-12-03 Carlos Garcia Campos <cgarcia@igalia.com>
2380 [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2381 https://bugs.webkit.org/show_bug.cgi?id=151797
2383 Reviewed by Martin Robinson.
2385 Since we switched to use the network process to run the unit tests
2386 the test /webkit2/WebKitWebResource/get-data sometimes fails and
2387 sometimes passes. We are now also getting the notification for the
2388 css image. Since we wait for 3 resources, sometimes the css image
2389 is loaded before and then checkResourceData is called for it, but
2390 not handled. When the css image is the last one loaded the test
2391 passes. So, we just need to wait for the 4 resources.
2393 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2394 (testWebResourceGetData):
2396 2015-12-03 David Kilzer <ddkilzer@apple.com>
2398 DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2399 <http://webkit.org/b/151845>
2401 Reviewed by Simon Fraser.
2403 Fixes the following static analyzer warning:
2404 DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2405 WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2406 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2408 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2409 (createBitmapContext): Free 'buffer' after using it in logging
2410 to fix the use-after-free. Assign a value of nullptr to buffer
2411 so we don't return with it set to a freed address.
2413 2015-12-03 Jer Noble <jer.noble@apple.com>
2415 Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2416 https://bugs.webkit.org/show_bug.cgi?id=151830
2418 Reviewed by Anders Carlsson.
2420 Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2422 * DumpRenderTree/mac/DumpRenderTree.mm:
2423 (resetWebPreferencesToConsistentValues):
2424 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2425 (WTR::initializeWebViewConfiguration):
2427 2015-12-03 Anders Carlsson <andersca@apple.com>
2429 Remove Objective-C GC support
2430 https://bugs.webkit.org/show_bug.cgi?id=151819
2431 rdar://problem/23746991
2433 Reviewed by Dan Bernstein.
2435 * asan/asan.xcconfig:
2437 2015-12-02 Yusuke Suzuki <utatane.tea@gmail.com>
2439 Allow nil for unspecified benchmark pathes
2440 https://bugs.webkit.org/show_bug.cgi?id=151784
2442 Reviewed by Filip Pizlo.
2444 `Pathname.new(nil)` will raise an error.
2445 Only generate Pathname if the benchmark path is specified.
2447 * Scripts/run-jsc-benchmarks:
2449 2015-12-02 Brent Fulgham <bfulgham@apple.com>
2451 [Win] Run non-http tests without Cygwin
2452 https://bugs.webkit.org/show_bug.cgi?id=151721
2454 Reviewed by Andy Estes.
2456 Support native 32-bit and 64-bit Python (and Perl) builds
2459 1. Use "startswith('win')", rather than "== 'win32'" to support
2460 various Windows build types.
2461 2. Supply full path for some native Windows utilities, since the
2462 path environment does not always have the specified, and they are
2463 guaranteed to exist in those specific locations.
2464 3. Make sure native Windows Python test runs pass proper environment
2465 variables to run programs.
2466 4. Append 'exe' suffix when running Windows executables.
2467 5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2468 command doesn't exist.
2470 * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2471 the current Perl executable, rather than requiring a new path search.
2472 * Scripts/webkitpy/common/find_files_unittest.py:
2473 (TestWinNormalize.test_win): Use startswith('win').
2474 * Scripts/webkitpy/common/prettypatch_unittest.py:
2475 (test_pretty_diff_encodings): Ditto.
2476 * Scripts/webkitpy/common/system/executive.py:
2477 (Executive._should_close_fds): Ditto.
2478 (Executive.shell_command_for_script): Use startswith('win').
2479 (Executive.kill_process): Use full path to killall executable.
2480 (Executive.check_running_pid): Use startswith('win').
2481 (Executive.running_pids): Ditto.
2482 (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2483 running under native Windows Python.
2484 (Executive._child_process_encoding): Use startswith('win').
2485 (Executive._should_encode_child_process_arguments): Ditto.
2486 (Executive.popen): Recognize proper script engine on Windows, since it
2487 does not support the shebang syntax.
2488 (Executive.run_in_parallel): Use startswith('win').
2489 * Scripts/webkitpy/common/system/executive_unittest.py:
2490 (never_ending_command): Ditto.
2491 (ExecutiveTest.test_run_command_with_unicode): Ditto.
2492 (ExecutiveTest.serial_test_kill_process): Ditto.
2493 (ExecutiveTest.serial_test_kill_all): Ditto.
2494 (ExecutiveTest.serial_test_check_running_pid): Ditto.
2495 (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2497 * Scripts/webkitpy/common/system/file_lock.py:
2498 (FileLock._create_lock): Ditto.
2499 (FileLock._remove_lock): Ditto.
2500 * Scripts/webkitpy/common/system/filesystem_unittest.py:
2501 (RealFileSystemTest.test_chdir): Ditto.
2502 (RealFileSystemTest.test_chdir__notexists): Ditto.
2503 (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2504 * Scripts/webkitpy/common/system/path_unittest.py:
2505 (AbspathTest.test_abspath_to_uri_win): Ditto.
2506 * Scripts/webkitpy/common/system/platforminfo.py:
2507 (PlatformInfo._determine_os_name): Ditto.
2508 * Scripts/webkitpy/common/system/user.py: Ditto.
2509 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2510 (ManagerTest.integration_test_needs_servers): Ditto.
2511 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2512 (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2514 (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2515 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2516 (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2517 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2518 (HttpServerBase._check_that_all_ports_are_available): Ditto.
2519 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2520 (TestHttpServer.test_start_cmd): Ditto.
2521 * Scripts/webkitpy/port/base.py:
2522 (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2523 and 'SYSTEMROOT' in environment passed to test runners.
2524 (Port._apache_config_file_name_for_platform): Use startswith('win').
2525 (Port._build_path): Ditto.
2526 (Port._path_to_driver): Include 'exe' suffix when running under native
2528 * Scripts/webkitpy/port/driver.py:
2529 (Driver._setup_environ_for_driver): Explicitly make some environment
2531 * Scripts/webkitpy/port/server_process.py:
2532 (ServerProcess.__init__): Use startswith('win').
2533 * Scripts/webkitpy/port/win.py:
2534 (WinPort): Use the win32 registry utilities on Windows, and appropriate
2535 registry key formats.
2536 (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2537 (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2538 and regtool on Cygwin.
2539 (WinPort.write_registry_value): Ditto.
2540 (WinPort.setup_crash_log_saving): Ditto.
2541 (WinPort.restore_crash_log_saving): Ditto.
2542 (WinPort.prevent_error_dialogs): Ditto.
2543 (WinPort.allow_error_dialogs): Ditto.
2544 (WinPort.find_system_pid): Revise to use Windows management
2545 infrastructure on native Windows, continue using 'ps' on Cygwin.
2546 (WinPort.read_registry_string): Deleted.
2547 (WinPort.write_registry_string): Deleted.
2548 * Scripts/webkitpy/test/main.py:
2549 (main): Use startswith('win').
2550 (Tester._parse_args): Ditto.
2552 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
2554 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2555 https://bugs.webkit.org/show_bug.cgi?id=150792
2557 Reviewed by Saam Barati.
2559 * Scripts/webkitperl/FeatureList.pm:
2561 2015-12-01 Commit Queue <commit-queue@webkit.org>
2563 Unreviewed, rolling out r192914.
2564 https://bugs.webkit.org/show_bug.cgi?id=151734
2566 JSC tests for this change are failing on 32 and 64-bit bots
2567 (Requested by ryanhaddad on #webkit).
2571 "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2572 enable this feature"
2573 https://bugs.webkit.org/show_bug.cgi?id=150792
2574 http://trac.webkit.org/changeset/192914
2576 2015-12-01 David Kilzer <ddkilzer@apple.com>
2578 EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2579 <http://webkit.org/b/151726>
2581 Reviewed by Simon Fraser.
2583 * WebKitTestRunner/mac/EventSenderProxy.mm:
2584 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2585 Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2587 2015-12-01 Myles C. Maxfield <mmaxfield@apple.com>
2589 Give String and AtomicString an existingHash() function
2590 https://bugs.webkit.org/show_bug.cgi?id=151717
2592 Reviewed by Andreas Kling.
2594 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2595 (TestWebKitAPI::TEST):
2596 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2597 (TestWebKitAPI::TEST):
2599 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
2601 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2602 https://bugs.webkit.org/show_bug.cgi?id=150792
2604 Reviewed by Saam Barati.
2606 * Scripts/webkitperl/FeatureList.pm:
2608 2015-12-01 Sam Weinig <sam@webkit.org>
2610 Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2611 <rdar://problem/23320863>
2612 https://bugs.webkit.org/show_bug.cgi?id=151708
2614 Reviewed by Anders Carlsson.
2616 * WebKitTestRunner/TestController.cpp:
2617 (WTR::TestController::createOtherPage):
2618 (WTR::TestController::createWebViewWithOptions):
2619 Update for new WKPageUIClient.
2621 2015-12-01 Anders Carlsson <andersca@apple.com>
2623 Remove WebKit2.framework
2624 https://bugs.webkit.org/show_bug.cgi?id=151715
2626 Reviewed by Dan Bernstein.
2628 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2629 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2630 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2631 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2632 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2633 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2634 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2636 2015-12-01 Joseph Pecoraro <pecoraro@apple.com>
2638 Unreviewed common typo fix "occurance" => "occurrence".
2640 * Scripts/webkitpy/tool/commands/queries.py:
2641 (FindFlakyTests._print_statistics):
2643 2015-11-30 Alex Christensen <achristensen@webkit.org>
2645 Make ProcessModel always MultipleSecondaryProcesses
2646 https://bugs.webkit.org/show_bug.cgi?id=151662
2648 Reviewed by Antti Koivisto.
2650 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2651 (TestWebKitAPI::TEST):
2652 * WebKitTestRunner/TestController.cpp:
2653 (WTR::TestController::generatePageConfiguration):
2655 2015-11-30 Alex Christensen <achristensen@webkit.org>
2657 Make usesNetworkProcess always true
2658 https://bugs.webkit.org/show_bug.cgi?id=151580
2660 Reviewed by Darin Adler.
2662 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2663 (TestWebKitAPI::TEST):
2664 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2665 (TestWebKitAPI::TEST):
2666 * WebKitTestRunner/TestController.cpp:
2667 (WTR::TestController::generatePageConfiguration):
2669 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2671 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2673 Add a way to skip unit tests only for Debug or Release builds and
2674 skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2676 * Scripts/run-gtk-tests:
2678 (SkippedTest.__init__):
2679 (SkippedTest.__str__):
2680 (SkippedTest.skip_entire_suite):
2681 (SkippedTest.skip_for_build_type):
2683 (TestRunner.__init__):
2685 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2687 Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2689 It's an assert hit because we are reloading a view loaded with
2690 HTML data which is not supported. Use loadURI instead.
2692 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2693 (testWebViewCustomCharset):
2695 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2697 [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2698 https://bugs.webkit.org/show_bug.cgi?id=151633
2700 Reviewed by Csaba Osztrogonác.
2702 * TestWebKitAPI/PlatformGTK.cmake:
2703 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2705 2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com>
2707 [GTK] Remove the remaining uses of GMainLoopSource
2708 https://bugs.webkit.org/show_bug.cgi?id=151632
2710 Reviewed by Žan Doberšek.
2712 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2713 (testWebViewSyncRequestOnMaxConns):
2714 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2715 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2716 (WTR::TestRunner::TestRunner):
2717 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2718 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2719 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2720 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2721 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2722 (WTR::timeoutSource):
2723 (WTR::TestController::notifyDone):
2724 (WTR::TestController::platformRunUntil):
2726 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
2728 [cmake] Add testb3 to the build system
2729 https://bugs.webkit.org/show_bug.cgi?id=151619
2731 Reviewed by Gyuyoung Kim.
2733 * Scripts/build-jsc:
2735 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
2737 [jhbuild] Fix pixman build with clang
2738 https://bugs.webkit.org/show_bug.cgi?id=151441
2740 Reviewed by Carlos Garcia Campos.
2742 * efl/jhbuild.modules:
2743 * gtk/jhbuild.modules:
2745 2015-11-26 David Kilzer <ddkilzer@apple.com>
2747 Extract prependToEnvironmentVariableList
2748 <http://webkit.org/b/151536>
2750 Reviewed by Daniel Bates.
2752 Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2753 webkitdirs_unittest/prependToEnvironmentVariableList.pl
2755 * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2756 and prependToEnvironmentVariableList.
2757 (appendToEnvironmentVariableList): Simplify variable name.
2758 Switch to use $Config{path_sep}.
2759 (prependToEnvironmentVariableList): Add new method.
2760 (setupMacWebKitEnvironment): Switch to use
2761 prependToEnvironmentVariableList().
2762 (setupIOSWebKitEnvironment): Ditto.
2764 * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2765 * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2767 2015-11-24 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2769 REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2770 https://bugs.webkit.org/show_bug.cgi?id=151567
2772 Reviewed by Darin Adler.
2774 * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2775 (on_window_deletion):
2777 2015-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
2779 [GTK] Use the network process unconditionally
2780 https://bugs.webkit.org/show_bug.cgi?id=151541
2782 Reviewed by Alex Christensen.
2784 Fix TestInspectorServer test. Do not assume we already have the
2785 title we want when the page has been loaded, since the title is
2786 changed afterwards. So, check if the title has already been set,
2787 and if not wait for it.
2789 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2790 (openRemoteDebuggingSession):
2792 2015-11-23 Alex Christensen <achristensen@webkit.org>
2794 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2795 https://bugs.webkit.org/show_bug.cgi?id=151532
2797 Reviewed by Benjamin Poulain.
2799 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2800 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2801 (TestWebKitAPI::TEST):
2802 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2803 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2804 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2805 Properly load about:blank in all WebViews to clean up. Without this change, we had a
2806 Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2807 so it was calling a function on a test object that had gone out of scope.
2808 Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2809 but that will become the default soon and that call will be removed.
2811 2015-11-22 David Kilzer <ddkilzer@apple.com>
2813 run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2814 <http://webkit.org/b/151542>
2816 Reviewed by Daniel Bates.
2818 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2819 (base_url): Use the Port object (already passed in) to give us
2820 the path to the LayoutTests directory, which already checks for a
2821 --layout-tests-directory command-line switch.
2822 (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2823 argument since we can get this from the Port object already
2824 passed in via Port.results_directory(). Also switch to use
2825 Port.layout_tests_dir() to get the LayoutTests directory.
2827 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2828 (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2829 Add test case for custom LayoutTests directory.
2830 (TestWebPlatformTestServer.test_previously_spawned_instance):
2831 Update Port object to set mock results directory as if it was
2832 set on the command-line. Remove unneeded argument from
2833 WebPlatformTestServer constructor.
2834 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2836 * Scripts/webkitpy/port/base.py:
2837 (Port.to.start_web_platform_test_server): Remove unneeded
2838 argument from WebPlatformTestServer constuctor.
2840 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2842 [GTK] Some unit tests fail when using the network process
2843 https://bugs.webkit.org/show_bug.cgi?id=151490
2845 Reviewed by Martin Robinson.
2847 Run the soup server in a separate thread in TestResources test to
2850 This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2851 /webkit2/WebKitWebResource/get-data when using the network process.
2853 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2854 (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2855 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2856 (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2857 present, create a WorkQueue to run the server.
2858 (WebKitTestServer::run): Run the server in the work queue if it
2860 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2861 type into server options as flags.
2863 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2865 [GTK] ImageDiff should normalize the diff image
2866 https://bugs.webkit.org/show_bug.cgi?id=151261
2868 Reviewed by Sergio Villar Senin.
2870 * ImageDiff/gtk/ImageDiff.cpp:
2871 (readPixbufFromStdin): Fix memory leak.
2872 (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2873 (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2875 == Rolled over to ChangeLog-2015-11-21 ==