Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-29  Brady Eidson  <beidson@apple.com>
2
3         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
4         https://bugs.webkit.org/show_bug.cgi?id=182229
5
6         Reviewed by Chris Dumez.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
10
11 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
12
13         WebDriver: properly recover w3c tests after a webdriver server crash
14         https://bugs.webkit.org/show_bug.cgi?id=182242
15
16         Reviewed by Carlos Alberto Lopez Perez.
17
18         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
19         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
20         relaunching the server after every test failure, because other failures, even when not crashing the server,
21         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
22         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
23
24         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
25         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
26         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
27         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
28         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
29         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
30         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
31         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
32
33 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
34
35         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
36         https://bugs.webkit.org/show_bug.cgi?id=181204
37         <rdar://problem/36256274>
38
39         Reviewed by Ryosuke Niwa.
40
41         Implement 'testRunner.forceImmediateCompletion()' for WK1.
42
43         * DumpRenderTree/TestRunner.cpp:
44         (forceImmediateCompletionCallback):
45         (TestRunner::staticFunctions):
46
47 2018-01-29  Frederic Wang  <fwang@igalia.com>
48
49         Unreviewed, add myself to some watch lists.
50
51         * Scripts/webkitpy/common/config/watchlist:
52
53 2018-01-27  Dan Bernstein  <mitz@apple.com>
54
55         HaveInternalSDK includes should be "#include?"
56         https://bugs.webkit.org/show_bug.cgi?id=179670
57
58         * DumpRenderTree/mac/Configurations/Base.xcconfig:
59
60 2018-01-26  Chris Dumez  <cdumez@apple.com>
61
62         Make sure service worker code does not launch a StorageProcess unnecessarily
63         https://bugs.webkit.org/show_bug.cgi?id=182192
64         <rdar://problem/36927427>
65
66         Reviewed by Geoffrey Garen.
67
68         Add API test coverage.
69
70         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
71
72 2018-01-26  Chris Dumez  <cdumez@apple.com>
73
74         Offlined content does not work for apps on home screen
75         https://bugs.webkit.org/show_bug.cgi?id=182070
76         <rdar://problem/36843906>
77
78         Reviewed by Youenn Fablet.
79
80         Add API test coverage to make sure an already registered service worker is able to intercept
81         the very first load.
82
83         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
84         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
85
86 2018-01-26  Chris Nardi  <cnardi@chromium.org>
87
88         Addressing post-review comments after r226614
89         https://bugs.webkit.org/show_bug.cgi?id=182151
90
91         Reviewed by Myles C. Maxfield.
92
93         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
94         (TestWebKitAPI::TEST):
95
96 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
97
98         Unreviewed, rolling out r224920.
99
100         Some Win EWS bots are not coming back up after starting reboot.
101
102         * EWSTools/start-queue-win.sh:
103
104 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
105
106         WebDriver: simplify the tests json report
107         https://bugs.webkit.org/show_bug.cgi?id=182171
108
109         Reviewed by Carlos Alberto Lopez Perez.
110
111         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
112         form the subtest name. We should do the same for simplicity and compatibility with WPT.
113
114         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
115         (WebDriverTestRunner.dump_results_to_json_file):
116
117 2018-01-25  Alex Christensen  <achristensen@webkit.org>
118
119         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
120         https://bugs.webkit.org/show_bug.cgi?id=182152
121
122         Reviewed by Joseph Pecoraro.
123
124         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
125         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
126         (TEST):
127
128 2018-01-25  Youenn Fablet  <youenn@apple.com>
129
130         WebPluginInfoProvider should handle null host queries
131         https://bugs.webkit.org/show_bug.cgi?id=182112
132
133         Reviewed by Chris Dumez.
134
135         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
136         (TEST):
137
138 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
139
140         [webkitpy] Stop modifying path information only when running on Cygwin
141         https://bugs.webkit.org/show_bug.cgi?id=182136
142
143         On LayoutTestApacheHttpd, some path configuration is modified when platform
144         is Windows. This modification is only required for AppleWin running on Cygwin.
145         WinCairo uses native Windows environment, so the condition should be changed.
146
147         Reviewed by Per Arne Vollan.
148
149         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
150         (LayoutTestApacheHttpd.__init__):
151         (LayoutTestApacheHttpd._get_apache_config_file_path):
152
153 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
154
155         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
156         https://bugs.webkit.org/show_bug.cgi?id=182038
157         <rdar://problem/36812083>
158
159         Reviewed by Jer Noble.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
162         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
163
164 2018-01-24  Daniel Bates  <dabates@apple.com>
165
166         webkit-patch upload emits irrelevant simulator warnings
167         https://bugs.webkit.org/show_bug.cgi?id=181702
168         <rdar://problem/36556359>
169
170         Reviewed by Aakash Jain.
171
172         Remove warning when a person explicitly passes --child-processes with a value greater than
173         the default number of simulator instances webkitpy would have used had --child-processes
174         been omitted. Moreover, the placement of the warning logic to support printing such a message
175         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
176
177         By default, webkitpy will parallelize running tests using the maximum number of simulator
178         instances that can be supported based on available system resources at the time run-webkit-tests
179         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
180         by specifying --child-processes knows what they are doing. The effects of picking a large
181         value be obvious, the system may become sluggish.
182
183         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
184         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
185
186         * Scripts/webkitpy/port/ios_simulator.py:
187         (IOSSimulatorPort.__init__):
188
189 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
190
191         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
192         https://bugs.webkit.org/show_bug.cgi?id=182102
193
194         Reviewed by Carlos Garcia Campos.
195
196         * MiniBrowser/gtk/main.c:
197         (main): Removed the call to set_enable_webvr().
198
199 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
200
201         WebDriver: add support for slow tests
202         https://bugs.webkit.org/show_bug.cgi?id=182095
203
204         Reviewed by Carlos Alberto Lopez Perez.
205
206         Add timeout mark to slow tests.
207
208         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
209         (TestExpectationsMarker.__init__): Save the timeout.
210         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
211         (run): Pass timeout to TestExpectationsMarker constructor.
212
213 2018-01-24  Alex Christensen  <achristensen@webkit.org>
214
215         Gracefully recover from NetworkProcess crashes in private browsing
216         https://bugs.webkit.org/show_bug.cgi?id=182073
217         <rdar://problem/36572023>
218
219         Reviewed by Geoff Garen.
220
221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
222         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
223         (-[CrashDelegate webView:didFinishNavigation:]):
224         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
225         (-[CrashDelegate webView:didFailNavigation:withError:]):
226         (TEST):
227
228 2018-01-24  Ali Juma  <ajuma@chromium.org>
229
230         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
231         https://bugs.webkit.org/show_bug.cgi?id=182052
232
233         Reviewed by Simon Fraser.
234
235         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
236         immediately.
237
238         Test: fast/visual-viewport/viewport-dimensions.html
239
240         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
241         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
242
243 2018-01-24  Alex Christensen  <achristensen@webkit.org>
244
245         Remove pre-Sierra-OS-specific code in Tools
246         https://bugs.webkit.org/show_bug.cgi?id=182034
247
248         Reviewed by Tim Horton.
249
250         * DumpRenderTree/mac/DumpRenderTree.mm:
251         (setDefaultsToConsistentValuesForTesting):
252         * MiniBrowser/mac/BrowserWindowController.m:
253         (-[BrowserWindowController windowDidLoad]):
254         (-[BrowserWindowController share:]):
255         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
256         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
257         (-[EventStreamPlayer playbackTimerFired:]):
258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
259         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
260         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
261         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
262         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
263         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
264         (WTR::InjectedBundle::platformInitialize):
265         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
266         (WTR::initializeWebViewConfiguration):
267
268 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
269
270         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
271         https://bugs.webkit.org/show_bug.cgi?id=181400
272         <rdar://problem/36358768>
273
274         Reviewed by Joseph Pecoraro.
275
276         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
277
278         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
279         Always disable poisoning when running with --leaks, as this should work locally,
280         not just on bots.
281
282 2018-01-24  Daniel Bates  <dabates@apple.com>
283
284         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
285         https://bugs.webkit.org/show_bug.cgi?id=181993
286         <rdar://problem/36421080>
287
288         Reviewed by David Hyatt.
289
290         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
291         as we no longer support this strategy.
292
293         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
294
295 2018-01-24  David Kilzer  <ddkilzer@apple.com>
296
297         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
298         <https://webkit.org/b/182015>
299         <rdar://problem/36449728>
300
301         Reviewed by Tim Horton.
302
303         * Scripts/webkitpy/style/checkers/cpp.py:
304         (regex_for_lambdas_and_blocks): Update regex to include
305         optional return type for block argument in Objective-C.
306         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
307         (WebKitStyleTest.test_braces): Add test.
308
309 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
310
311         WPE-focused test gardening.
312         https://bugs.webkit.org/show_bug.cgi?id=182051
313
314         Unreviewed test gardening.
315
316         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
317
318 2018-01-23  Mark Lam  <mark.lam@apple.com>
319
320         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
321         https://bugs.webkit.org/show_bug.cgi?id=182017
322         <rdar://problem/36795513>
323
324         Reviewed by Filip Pizlo and JF Bastien.
325
326         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
327         (TestWebKitAPI::TEST):
328         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
329         (TestWebKitAPI::TEST):
330         (TestWebKitAPI::passWithRef):
331         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
332         (TestWebKitAPI::TEST):
333         (TestWebKitAPI::f1):
334         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
335         (TestWebKitAPI::TEST):
336         (TestWebKitAPI::poisonedPtrFoo):
337         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
338         (TestWebKitAPI::TEST):
339         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
340         (TestWebKitAPI::TEST):
341
342 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
343
344         [WebVR] Add OpenVR to the tree and to the build
345         https://bugs.webkit.org/show_bug.cgi?id=177298
346
347         Reviewed by Žan Doberšek.
348
349         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
350         with reduced style checks.
351
352 2018-01-24  Chris Nardi  <cnardi@chromium.org>
353
354         Add Chris Nardi to contributors list
355         https://bugs.webkit.org/show_bug.cgi?id=182029
356
357         Reviewed by Antti Koivisto.
358
359         * Scripts/webkitpy/common/config/contributors.json:
360
361 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
362
363         Mac Sierra perf bots have been failing due to CG errors
364         https://bugs.webkit.org/show_bug.cgi?id=181955
365
366         Reviewed by Antti Koivisto.
367
368         Ignore the CoreGraphics error messages on macOS Sierra.
369
370         Also added tests for ignoring lines in stdout and stderr.
371
372         * Scripts/webkitpy/performance_tests/perftest.py:
373         (PerfTest.run_failed): Refactored for clarity.
374         (PerfTest):
375         (PerfTest.filter_ignored_lines): Added.
376         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
377         are now used to ignore lines in other kinds of tests than parser tests.
378         (PerfTest._errors_to_ignore_in_sierra): Added.
379         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
380         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
381         (test_parse_output_with_ignored_stdout): Added.
382         (test_parse_output_with_ignored_stderr): Added.
383         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
384
385 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
386
387         Resign NowPlaying status when no media element is eligible
388         https://bugs.webkit.org/show_bug.cgi?id=181914
389         <rdar://problem/35294116>
390
391         Reviewed by Jer Noble.
392
393         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
394         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
395         (TestWebKitAPI::TEST):
396         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
397
398 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
399
400         [WinCairo] Use 64-bit toolset
401         https://bugs.webkit.org/show_bug.cgi?id=181979
402
403         Reviewed by Alex Christensen.
404
405         Use 64-bit toolset for 64-bit build in order to improve build time. 
406
407         * Scripts/webkitdirs.pm:
408         (generateBuildSystemFromCMakeProject):
409
410 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
411
412         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
413         https://bugs.webkit.org/show_bug.cgi?id=181741
414         rdar://problem/36593581
415
416         Reviewed by Tim Horton.
417         
418         If zoomToScale:animated: is called with the current zoom level, call the callback
419         rather than doing nothing.
420
421         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
422         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
423
424 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
425
426         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
427         https://bugs.webkit.org/show_bug.cgi?id=180820
428
429         Reviewed by David Kilzer.
430
431         * Scripts/webkitpy/common/checkout/scm/git.py:
432         (Git.in_working_directory):
433         (Git.clone):
434         (Git.read_git_config):
435         (Git.apply_reverse_diff):
436         * Scripts/webkitpy/common/checkout/scm/scm.py:
437         (SCM.run):
438         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
439         * Scripts/webkitpy/common/checkout/scm/svn.py:
440         (SVNRepository.has_authorization_for_realm):
441         * Scripts/webkitpy/common/net/credentials_unittest.py:
442         * Scripts/webkitpy/common/system/abstractexecutive.py:
443         (AbstractExecutive.run_command):
444         * Scripts/webkitpy/common/system/executive.py:
445         (Executive.kill_process.is):
446         (Executive.running_pids):
447         (Executive.kill_all):
448         (Executive.run_command):
449         * Scripts/webkitpy/common/system/executive_mock.py:
450         (MockExecutive.run_command):
451         (MockExecutive2.run_command):
452         * Scripts/webkitpy/common/system/executive_unittest.py:
453         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
454         * Scripts/webkitpy/common/system/platforminfo.py:
455         (PlatformInfo.xcode_sdk_version):
456         * Scripts/webkitpy/layout_tests/servers/http_server.py:
457         (Lighttpd._check_and_kill):
458         * Scripts/webkitpy/port/base.py:
459         (Port._symbols_string):
460         * Scripts/webkitpy/port/gtk.py:
461         (GtkPort.setup_environ_for_server):
462         * Scripts/webkitpy/port/win.py:
463         (WinPort._runtime_feature_list):
464         (WinPort.read_registry_value):
465         * Scripts/webkitpy/port/win_unittest.py:
466         (WinPortTest.test_runtime_feature_list):
467         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
468         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
469
470 2018-01-23  Commit Queue  <commit-queue@webkit.org>
471
472         Unreviewed, rolling out r227279 and r227373.
473         https://bugs.webkit.org/show_bug.cgi?id=181988
474
475         The LayoutTest crash fix introduced an API test failure.
476         (Requested by ryanhaddad on #webkit).
477
478         Reverted changesets:
479
480         "Resign NowPlaying status when no media element is eligible"
481         https://bugs.webkit.org/show_bug.cgi?id=181914
482         https://trac.webkit.org/changeset/227279
483
484         "Resign NowPlaying status when no media element is eligible"
485         https://bugs.webkit.org/show_bug.cgi?id=181914
486         https://trac.webkit.org/changeset/227373
487
488 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
489
490         Unreviewed. Add test case for slow in test_expectations.py.
491
492         I forgot to also check slow tests in test_expectations.py unit tests.
493
494         * Scripts/webkitpy/common/test_expectations_unittest.py:
495         (assert_slow):
496         (test_build_type):
497         (test_slow):
498
499 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
500
501         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
502
503         * TestWebKitAPI/glib/TestExpectations.json:
504
505 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
506
507         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
508         https://bugs.webkit.org/show_bug.cgi?id=181616
509         <rdar://problem/36484908>
510
511         Reviewed by Wenson Hsieh.
512
513         Added tests to make sure we sanitize plain HTML, not just web archives,
514         when and only when custom pasteboard data is enabled.
515
516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
517         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
518         (writeHTMLToPasteboard): Added.
519         (createWebViewWithCustomPasteboardDataSetting): Added.
520
521 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
522
523         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
524         https://bugs.webkit.org/show_bug.cgi?id=181400
525         rdar://problem/36358768
526
527         Reviewed by JF Bastien.
528
529         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
530
531 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
532
533         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
534         https://bugs.webkit.org/show_bug.cgi?id=181929
535
536         Reviewed by Michael Catanzaro.
537
538         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
539         the website data completion callback is not called immediately, and a new file is created when the operation
540         finishes. We need to check that the file was removing after calling clear.
541
542         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
543         (fileChangedCallback):
544         (testWebsiteDataResourceLoadStatistics):
545
546 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
547
548         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
549
550         * TestWebKitAPI/glib/TestExpectations.json:
551
552 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
553
554         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
555
556         Partially revert r226782, the fix was wrong for the GLib version we currently use.
557
558         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
559         (testWebKitConsoleMessageNetworkError):
560
561 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
562
563         Unreviewed. Remove unused verbose mode from GLib API tests runner.
564
565         * glib/api_test_runner.py:
566         (add_options):
567
568 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
569
570         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
571         https://bugs.webkit.org/show_bug.cgi?id=181918
572
573         Reviewed by Tim Horton.
574
575         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
576
577         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
578
579 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
580
581         Resign NowPlaying status when no media element is eligible
582         https://bugs.webkit.org/show_bug.cgi?id=181914
583         <rdar://problem/35294116>
584
585         Reviewed by Jer Noble.
586
587         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
588         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
589         (TestWebKitAPI::TEST):
590         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
591
592 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
593
594         Fix broken unit-tests after r227192
595         https://bugs.webkit.org/show_bug.cgi?id=181909
596
597         Reviewed by Carlos Garcia Campos.
598
599         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
600
601 2018-01-20  Chris Dumez  <cdumez@apple.com>
602
603         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
604         https://bugs.webkit.org/show_bug.cgi?id=174984
605         <rdar://problem/33665676>
606
607         Reviewed by Alexey Proskuryakov.
608
609         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
610
611         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
612         (TEST):
613
614 2018-01-20  Brian Burg  <bburg@apple.com>
615
616         WebDriver: fix some nits that prevent running W3C tests on Mac
617         https://bugs.webkit.org/show_bug.cgi?id=181864
618
619         Reviewed by Carlos Garcia Campos.
620
621         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
622         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
623         as we assume that the property exists later.
624
625         (WebDriverW3CWebServer.stop): If the temporary file doesn't
626         exist for some reason, the remove call will raise and exception.
627         Gracefully handle the case where the file isn't created due to
628         a problem/exception that happened elsewhere.
629
630 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
631
632         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
633         https://bugs.webkit.org/show_bug.cgi?id=181881
634
635         Reviewed by Alexey Proskuryakov.
636
637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
638         (BubbleQueueServer):
639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
641         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
642
643 2018-01-19  Youenn Fablet  <youenn@apple.com>
644
645         Do not go to the storage process when registering a service worker client if there is no service worker registered
646         https://bugs.webkit.org/show_bug.cgi?id=181740
647         <rdar://problem/36650400>
648
649         Reviewed by Chris Dumez.
650
651         Add support for internals inside API tests.
652
653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
654         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
655         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
656         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
657         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
658         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
659         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
660         (setConfigurationInjectedBundlePath):
661         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
662
663 2018-01-19  John Wilander  <wilander@apple.com>
664
665         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
666         https://bugs.webkit.org/show_bug.cgi?id=181822
667         https://bugs.webkit.org/show_bug.cgi?id=175263
668         https://bugs.webkit.org/show_bug.cgi?id=178536
669         https://bugs.webkit.org/show_bug.cgi?id=181223
670         https://bugs.webkit.org/show_bug.cgi?id=181482
671         <rdar://problem/33491222>
672         <rdar://problem/33805293>
673         <rdar://problem/36332683>
674         <rdar://problem/36549026>
675
676         Reviewed by Alex Christensen.
677
678         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
679         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
680         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
681         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
682         * WebKitTestRunner/InjectedBundle/TestRunner.h:
683         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
684         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
685         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
686
687 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
688
689         run-webkit-tests fails when there is a curly brace in Xcode build output
690         https://bugs.webkit.org/show_bug.cgi?id=181254
691         <rdar://problem/36453374>
692
693         Reviewed by Daniel Bates.
694
695         * Scripts/webkitpy/port/base.py:
696         (Port._run_script): Encode script output before logging it.
697
698 2018-01-19  Chris Dumez  <cdumez@apple.com>
699
700         Service worker registrations restored from disk may not be reused when the JS calls register() again
701         https://bugs.webkit.org/show_bug.cgi?id=181810
702         <rdar://problem/36591711>
703
704         Reviewed by Youenn Fablet.
705
706         Add API test coverage.
707
708         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
709         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
710         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
711
712 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
713
714         Remove El Capitan queues from flakiness dashboard
715         https://bugs.webkit.org/show_bug.cgi?id=181860
716
717         Reviewed by Aakash Jain.
718
719         * TestResultServer/static-dashboards/builders.jsonp:
720
721 2018-01-19  Keith Miller  <keith_miller@apple.com>
722
723         HaveInternalSDK includes should be "#include?"
724         https://bugs.webkit.org/show_bug.cgi?id=179670
725
726         Reviewed by Dan Bernstein.
727
728         * MiniBrowser/Configurations/Base.xcconfig:
729         * MobileMiniBrowser/Configurations/Base.xcconfig:
730         * TestWebKitAPI/Configurations/Base.xcconfig:
731         * WebKitTestRunner/Configurations/Base.xcconfig:
732
733 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
734
735         WebDriver: driver environment not passed to pytest when running w3c tests
736         https://bugs.webkit.org/show_bug.cgi?id=181852
737
738         Reviewed by Carlos Alberto Lopez Perez.
739
740         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
741
742         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
743         (WebDriverW3CExecutor.run):
744
745 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
746
747         [GTK] WebDriver: wayland display no used in wayland bot
748         https://bugs.webkit.org/show_bug.cgi?id=181851
749
750         Reviewed by Carlos Alberto Lopez Perez.
751
752         We need to handle the additionalArguments property in the WebDriverTests step.
753
754         * BuildSlaveSupport/build.webkit.org-config/steps.py:
755         (RunWebDriverTests.start):
756
757 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
758
759         [GTK] TERM environment variable is not passed to the test driver.
760         https://bugs.webkit.org/show_bug.cgi?id=181847
761
762         Rubber-stamped by by Carlos Garcia Campos.
763
764         * Scripts/webkitpy/port/base.py:
765         (Port.to.setup_environ_for_server):
766
767 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
768
769         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
770         https://bugs.webkit.org/show_bug.cgi?id=181844
771
772         Reviewed by Carlos Alberto Lopez Perez.
773
774         We always try to create the directory where to store the json file, but when the filename is given directly,
775         like in the bots, the current dir is used.
776
777         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
778         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
779         empty string.
780
781 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
782
783         [GTK] WebDriver tests are running outside the jhbuild env
784         https://bugs.webkit.org/show_bug.cgi?id=181842
785
786         Reviewed by Žan Doberšek.
787
788         We need to enter jhbuild env in run-webdriver-tests.
789
790         * Scripts/run-webdriver-tests:
791
792 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
793
794         [GTK] Run WebDriver tests in the bots
795         https://bugs.webkit.org/show_bug.cgi?id=181787
796
797         Reviewed by Michael Catanzaro.
798
799         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
800         factory for the GTK port for now.
801
802         * BuildSlaveSupport/build.webkit.org-config/factories.py:
803         (TestFactory.__init__):
804         * BuildSlaveSupport/build.webkit.org-config/steps.py:
805         (RunWebDriverTests):
806         (RunWebDriverTests.start):
807         (RunWebDriverTests.commandComplete):
808         (RunWebDriverTests.evaluateCommand):
809         (RunWebDriverTests.getText):
810         (RunWebDriverTests.getText2):
811
812 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
813
814         [WinCairo] Pass correct url for http test to test driver.
815         https://bugs.webkit.org/show_bug.cgi?id=181814
816
817         Reviewed by Alex Christensen.
818
819         * Scripts/webkitpy/port/driver.py:
820         (Driver):
821         (Driver.http_test_path_to_uri):
822         (Driver.is_secure_path):
823         (Driver.http_base_url):
824         (Driver.uri_to_test):
825
826 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
827
828         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
829
830         * BuildSlaveSupport/build.webkit.org-config/config.json:
831
832 2018-01-18  Dan Bernstein  <mitz@apple.com>
833
834         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
835         https://bugs.webkit.org/show_bug.cgi?id=181803
836
837         Reviewed by Tim Horton.
838
839         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
840         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
841         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
842         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
843         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
844         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
845         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
846         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
847         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
848           helpers.
849         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
850           settings useful for defining settings that depend on the target macOS version.
851         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
852         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
853
854 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
855
856         Remove Opensource El Capitan queues from buildbot
857         https://bugs.webkit.org/show_bug.cgi?id=181712
858
859         Reviewed by Aakash Jain.
860
861         * BuildSlaveSupport/build.webkit.org-config/config.json:
862         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
863         (WebKitBuildbot):
864         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
865
866 2018-01-18  Chris Dumez  <cdumez@apple.com>
867
868         Service Workers restored from persistent storage have 'redundant' state
869         https://bugs.webkit.org/show_bug.cgi?id=181749
870         <rdar://problem/36556486>
871
872         Reviewed by Youenn Fablet.
873
874         Add API test coverage.
875
876         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
877         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
878
879 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
880
881         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
882         https://bugs.webkit.org/show_bug.cgi?id=176796
883
884         Reviewed by Chris Fleizach.
885
886         Add sanity check that we have a URL before calling g_strstr_len().
887
888         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
889         (WTR::AccessibilityUIElement::url):
890
891 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
892
893         Add triggers for Sierra test262 and perf queues
894         https://bugs.webkit.org/show_bug.cgi?id=181799
895
896         Reviewed by Aakash Jain.
897
898         * BuildSlaveSupport/build.webkit.org-config/config.json:
899
900 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
901
902         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
903         https://bugs.webkit.org/show_bug.cgi?id=181783
904         <rdar://problem/35785445>
905
906         Reviewed by Ryosuke Niwa.
907
908         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
909         copying an image contains a relevant title.
910
911         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
912         (TestWebKitAPI::TEST):
913         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
914         * TestWebKitAPI/ios/UIKitSPI.h:
915
916 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
917
918         WebDriver: ignore the driver in selenium test names when getting expectations
919         https://bugs.webkit.org/show_bug.cgi?id=181738
920
921         Reviewed by Carlos Alberto Lopez Perez.
922
923         In selenium tests, the driver is added as a parameter to every test which results in tests names like
924         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
925         driver name in the test expectations file, so we need to remove it when querying the expectations.
926
927         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
928         (TestExpectationsMarker.__init__): Save the param to ignore.
929         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
930         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
931         (run): Pass param to ignore to TestExpectationsMarker().
932         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
933         (WebDriverSeleniumExecutor.__init__): Save the driver name.
934         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
935
936 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
937
938         [GTK][WPE] Show unit tests unexpectedly passing in the bots
939         https://bugs.webkit.org/show_bug.cgi?id=181726
940
941         Reviewed by Michael Catanzaro.
942
943         Now that we have the info, let's show it also in the bots.
944
945         * BuildSlaveSupport/build.webkit.org-config/steps.py:
946         (RunGLibAPITests.commandComplete):
947
948 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
949
950         Fix broken unittest after r227048
951         https://bugs.webkit.org/show_bug.cgi?id=181760
952
953         Reviewed by Aakash Jain.
954
955
956 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
957
958         WEBKIT_FRAMEWORK should not modify file-global include directories
959         https://bugs.webkit.org/show_bug.cgi?id=181656
960
961         Reviewed by Konstantin Tokarev.
962
963         * TestWebKitAPI/PlatformWPE.cmake:
964         * TestWebKitAPI/glib/CMakeLists.txt:
965
966 2018-01-17  Alicia Boya García  <aboya@igalia.com>
967
968         Unreviewed, mark Alicia as committer in contributors.json
969
970         * Scripts/webkitpy/common/config/contributors.json:
971
972 2018-01-17  Youenn Fablet  <youenn@apple.com>
973
974         Put fetch Request.keepalive behind a runtime flag
975         https://bugs.webkit.org/show_bug.cgi?id=181592
976
977         Reviewed by Chris Dumez.
978
979         * DumpRenderTree/mac/DumpRenderTree.mm:
980         (enableExperimentalFeatures):
981         * DumpRenderTree/win/DumpRenderTree.cpp:
982         (enableExperimentalFeatures):
983         * WebKitTestRunner/TestController.cpp:
984         (WTR::TestController::resetPreferencesToConsistentValues):
985
986 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
987
988         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
989         https://bugs.webkit.org/show_bug.cgi?id=181637
990         <rdar://problem/36508471>
991
992         Reviewed by Tim Horton.
993
994         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
995         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
996
997         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
998         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
999         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
1000
1001         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
1002         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1005         (webViewForTestingAttachments):
1006         (-[TestWKWebView tagsInBody]):
1007         (-[TestWKWebView expectElementTagsInOrder:]):
1008         (-[TestWKWebView expectElementTag:toComeBefore:]):
1009
1010         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
1011         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
1012
1013         (TestWebKitAPI::TEST):
1014         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1015         (WTR::InjectedBundlePage::InjectedBundlePage):
1016
1017 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1018
1019         WebDriver: add support for test expectations
1020         https://bugs.webkit.org/show_bug.cgi?id=180420
1021
1022         Reviewed by Carlos Alberto Lopez Perez.
1023
1024         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
1025
1026         * Scripts/run-webdriver-tests: Get the retval from process_results().
1027         * Scripts/webkitpy/thirdparty/__init__.py:
1028         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
1029         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1030         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
1031         (TestExpectationsMarker.__init__): Initialize expectations.
1032         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
1033         (run): Create and use TestExpectationsMarker plugin.
1034         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1035         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
1036         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1037         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
1038         (WebDriverTestRunner.run): Do not count results here.
1039         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
1040         amount of failures. Printing the test summary while processing results will be made optional in a follow up
1041         patch.
1042         (WebDriverTestRunner.process_results.report): Return the amount of failures.
1043         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1044         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
1045         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
1046         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
1047         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1048         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
1049         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
1050         (WebDriverTestRunnerW3C._scan_directory): Ditto.
1051         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
1052         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1053         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
1054
1055 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1056
1057         Unreviewed WPE gardening. Mark some known unit test failures.
1058
1059         * TestWebKitAPI/glib/TestExpectations.json:
1060
1061 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1062
1063         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
1064         https://bugs.webkit.org/show_bug.cgi?id=181724
1065
1066         Reviewed by Philippe Normand.
1067
1068         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
1069         reason to use different names. This way we can refer to the same test names for both and we can share the
1070         expectations in the TestExpectations.json file.
1071
1072         * TestWebKitAPI/glib/TestExpectations.json:
1073         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
1074
1075 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1076
1077         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
1078
1079         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
1080         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
1081
1082         * glib/api_test_runner.py:
1083         (TestRunner._run_test_glib):
1084         (TestRunner._run_google_test):
1085
1086 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1087
1088         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
1089         https://bugs.webkit.org/show_bug.cgi?id=179914
1090
1091         Reviewed by Žan Doberšek.
1092
1093         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
1094         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
1095         all symbols listed in the script are present in the library.
1096
1097         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
1098         (bss_symbols):
1099         * Scripts/check-for-invalid-symbols-in-version-script: Added.
1100         (script_symbols):
1101         * Scripts/make-dist:
1102         (Distcheck.build):
1103         (Distcheck):
1104         (Distcheck.check_symbols):
1105         (Distcheck.check):
1106
1107 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1108
1109         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
1110         https://bugs.webkit.org/show_bug.cgi?id=181722
1111
1112         Reviewed by Žan Doberšek.
1113
1114         I forgot to pass the parameters to run() when restarting.
1115
1116         * glib/glib_test_runner.py:
1117         (GLibTestRunner.run):
1118
1119 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1120
1121         [CMake] Remove WebCoreDerivedSources library target
1122         https://bugs.webkit.org/show_bug.cgi?id=181664
1123
1124         Reviewed by Carlos Garcia Campos.
1125
1126         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
1127         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1128
1129 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
1130
1131         Move Debug Test262, Release Test262 and Performance queues to Sierra
1132         https://bugs.webkit.org/show_bug.cgi?id=181692
1133
1134         Unreviewed
1135
1136 2018-01-16  Zach Li  <zachli@apple.com>
1137
1138         Add pop-up policy support in website policies.
1139         https://bugs.webkit.org/show_bug.cgi?id=181544.
1140         rdar://problem/30521400.
1141
1142         Reviewed by Alex Christensen.
1143
1144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1145         Added pop-up-check.html.
1146
1147         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1150         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1151         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1152         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1153         (TEST):
1154
1155 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1156
1157         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
1158         https://bugs.webkit.org/show_bug.cgi?id=181638
1159         <rdar://problem/36508702>
1160
1161         Reviewed by Dan Bernstein.
1162
1163         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
1164         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
1165
1166         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1167         (-[AttachmentUpdateObserver init]):
1168         (-[AttachmentUpdateObserver sourceForIdentifier:]):
1169         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
1170         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
1171         (TestWebKitAPI::TEST):
1172         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
1173
1174 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1175
1176         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
1177
1178         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
1179
1180         * glib/api_test_runner.py:
1181         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
1182         * glib/glib_test_runner.py:
1183         (GLibTestRunner.run): Use given env.
1184
1185 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1186
1187         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
1188         https://bugs.webkit.org/show_bug.cgi?id=181676
1189
1190         Reviewed by Carlos Alberto Lopez Perez.
1191
1192         The option was removed in r226967.
1193
1194         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1195         (RunGtkAPITests):
1196         (RunWPEAPITests):
1197
1198 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1199
1200         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
1201
1202         The bots are still passing that option and the step is failing because it was removed in r226967.
1203
1204         * glib/api_test_runner.py:
1205         (add_options):
1206
1207 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1208
1209         [GTK][WPE] Improve the way glib tests are run
1210         https://bugs.webkit.org/show_bug.cgi?id=181674
1211
1212         Reviewed by Žan Doberšek.
1213
1214         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
1215         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
1216         tests failing due to an expected assert in the test and unexpected crashes.
1217         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
1218         not showing the subtest name in stdout in case of timeouts.
1219         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
1220         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
1221         of every test case.
1222
1223         * glib/api_test_runner.py:
1224         (TestRunner._run_test_glib): Use GLibTestRunner.
1225         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
1226         (add_options):
1227         * glib/glib_test_runner.py: Added.
1228         (TestTimeout):
1229         (Message):
1230         (Message.__init__):
1231         (Message.create):
1232         (Message.create.read_unsigned):
1233         (Message.create.read_double):
1234         (Message.create.read_string):
1235         (GLibTestRunner):
1236         (GLibTestRunner.__init__):
1237         (GLibTestRunner._process_data):
1238         (GLibTestRunner._process_message):
1239         (GLibTestRunner._read_from_pipe):
1240         (GLibTestRunner._read_from_stderr):
1241         (GLibTestRunner._start_timeout):
1242         (GLibTestRunner._start_timeout._alarm_handler):
1243         (GLibTestRunner._stop_timeout):
1244         (GLibTestRunner._subtest_start):
1245         (GLibTestRunner._subtest_message):
1246         (GLibTestRunner._subtest_stderr):
1247         (GLibTestRunner._subtest_end):
1248         (GLibTestRunner.run):
1249
1250 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1251
1252         Unreviewed, add Thibault to contributors.json
1253
1254         It's a bit weird to add someone here before their first contribution, but this affects
1255         Bugzilla autocomplete, and that is serious business.
1256
1257         * Scripts/webkitpy/common/config/contributors.json:
1258
1259 2018-01-15  JF Bastien  <jfbastien@apple.com>
1260
1261         Remove makePoisonedUnique
1262         https://bugs.webkit.org/show_bug.cgi?id=181630
1263         <rdar://problem/36498623>
1264
1265         Reviewed by Mark Lam.
1266
1267         Update tests.
1268
1269         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1270         (TestWebKitAPI::TEST):
1271         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1272         (TestWebKitAPI::TEST):
1273
1274 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
1275
1276         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
1277         https://bugs.webkit.org/show_bug.cgi?id=181476
1278
1279         Reviewed by Michael Catanzaro.
1280
1281         Update to xorg-server 1.19.6 which depends on libxfont2, and change
1282         the lists of packages to install libxfont2-devel (or equivalent).
1283
1284         * gtk/install-dependencies:
1285         * gtk/jhbuild.modules:
1286
1287 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1288
1289         [GTK][WPE] Add support for unit test expectations
1290         https://bugs.webkit.org/show_bug.cgi?id=181589
1291
1292         Reviewed by Michael Catanzaro.
1293
1294         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
1295         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
1296         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
1297         script itself is not a good idea either.
1298
1299         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
1300         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
1301         convenient methods to query them.
1302
1303         * Scripts/run-gtk-tests:
1304         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
1305         * Scripts/run-wpe-tests:
1306         (WPETestRunner): Ditto.
1307         * Scripts/webkitpy/common/test_expectations.py: Added.
1308         (TestExpectations):
1309         (TestExpectations.__init__):
1310         (TestExpectations._port_name_for_expected):
1311         (TestExpectations._expected_value):
1312         (TestExpectations.skipped_tests):
1313         (TestExpectations.skipped_subtests):
1314         (TestExpectations._expectation_value):
1315         (TestExpectations.is_slow):
1316         (TestExpectations.get_expectation):
1317         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
1318         (MockTestExpectations):
1319         (MockTestExpectations.__init__):
1320         (MockTestExpectations.is_skip):
1321         (ExpectationsTest):
1322         (assert_exp):
1323         (assert_not_exp):
1324         (assert_bad_exp):
1325         (assert_skip):
1326         (test_basic):
1327         (test_skip):
1328         (test_flaky):
1329         (test_build_type):
1330         * TestWebKitAPI/glib/TestExpectations.json: Added.
1331         * glib/api_test_runner.py:
1332         (TestRunner): Remove SkippedTest implementation.
1333         (TestRunner.__init__): Create a TestExpectations.
1334         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
1335         (TestRunner._should_run_test_program): Ditto.
1336         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
1337         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
1338         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
1339         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
1340         (TestRunner.run_tests.report): Helper to write report to stdout.
1341
1342 2018-01-13  Mark Lam  <mark.lam@apple.com>
1343
1344         Replace all use of ConstExprPoisoned with Poisoned.
1345         https://bugs.webkit.org/show_bug.cgi?id=181542
1346         <rdar://problem/36442138>
1347
1348         Reviewed by JF Bastien.
1349
1350         1. Converted tests to using new uintptr_t& poison type.
1351         2. Added tests for Poisoned comparison operators.
1352
1353         * TestWebKitAPI/CMakeLists.txt:
1354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1355         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
1356         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1357         (TestWebKitAPI::TEST):
1358         (TestWebKitAPI::initializeTestPoison): Deleted.
1359         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1360         (TestWebKitAPI::TEST):
1361         (TestWebKitAPI::passWithRef):
1362         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1363         (TestWebKitAPI::TEST):
1364         (TestWebKitAPI::f1):
1365         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1366         (TestWebKitAPI::TEST):
1367         (TestWebKitAPI::poisonedPtrFoo):
1368         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1369         (TestWebKitAPI::TEST):
1370         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1371         (TestWebKitAPI::TEST):
1372
1373 2018-01-13  David Kilzer  <ddkilzer@apple.com>
1374
1375         check-webkit-style: false positive for [whitespace/braces] with os_log format string
1376         <https://webkit.org/b/181606>
1377
1378         Reviewed by Darin Adler.
1379
1380         * Scripts/webkitpy/style/checkers/cpp.py:
1381         (check_spacing): Modify regular expression to ignore
1382         os_log format strings like '%{public}'.
1383         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1384         (CppStyleTest.test_spacing_before_braces): Add os_log
1385         format string test.
1386
1387 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1388
1389         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
1390         https://bugs.webkit.org/show_bug.cgi?id=181626
1391
1392         Reviewed by Joseph Pecoraro.
1393
1394         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
1395         Additionally, write a new API test covering the change in r226915.
1396
1397         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1398         (webViewForTestingAttachments):
1399         (TestWebKitAPI::TEST):
1400
1401 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1402
1403         History state should be updated during client redirects with asynchronous policy decisions
1404         https://bugs.webkit.org/show_bug.cgi?id=181358
1405         <rdar://problem/35547689>
1406
1407         Reviewed by Andy Estes.
1408
1409         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
1410         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
1411         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1412         (TEST):
1413
1414 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
1415
1416         webkitpy: Refactor simulator code (Part 4)
1417         https://bugs.webkit.org/show_bug.cgi?id=180555
1418         <rdar://problem/36131381>
1419
1420         Reviewed by Aakash Jain.
1421
1422         Move new_simulated_device.py to simulated_device.py.
1423
1424         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
1425         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
1426         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
1427         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
1428         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
1429
1430 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1431
1432         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
1433         https://bugs.webkit.org/show_bug.cgi?id=181595
1434
1435         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
1436         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
1437         I change the < and > to $ to make this test pass and continue to test what it used to.
1438
1439         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
1440         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1441         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1442
1443 2018-01-11  Keith Miller  <keith_miller@apple.com>
1444
1445         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1446         https://bugs.webkit.org/show_bug.cgi?id=181573
1447
1448         Reviewed by Simon Fraser.
1449
1450         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1451
1452 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
1453
1454         [WebAuthN] Import a CBOR coder from Chromium
1455         https://bugs.webkit.org/show_bug.cgi?id=181522
1456         <rdar://problem/36055729>
1457
1458         Reviewed by Brent Fulgham.
1459
1460         This patch also imports all unit tests into our API tests to ensure all
1461         workarounds and modification against the original codebase doesn't change
1462         any original functionalities.
1463
1464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1465         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
1466         (TestWebKitAPI::TEST):
1467         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
1468         (TestWebKitAPI::TEST):
1469         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
1470         (TestWebKitAPI::eq):
1471         Workarounds applied.
1472         (TestWebKitAPI::TEST):
1473
1474 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1475
1476         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
1477         https://bugs.webkit.org/show_bug.cgi?id=181538
1478         <rdar://problem/36440580>
1479
1480         Reviewed by Aakash Jain.
1481
1482         When disambiguating a device type, it is possible that the provided device type is sufficiently
1483         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
1484         will result in a failure to disambiguate the type.
1485
1486         * Scripts/webkitpy/xcode/new_simulated_device.py:
1487         (SimulatedDeviceManager._disambiguate_device_type):
1488
1489 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
1490
1491         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
1492         https://bugs.webkit.org/show_bug.cgi?id=181136
1493         <rdar://problem/36116604>
1494
1495         Reviewed by Chris Dumez.
1496
1497         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
1498         browsing sessions.
1499
1500         * Scripts/run-gtk-tests:
1501         (GtkTestRunner): Unskip test now that it passes.
1502         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1503         (TEST): Add new WebsiteDataStoreEphemeral test.
1504
1505 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1506
1507         Unreviewed, rolling out r226816.
1508
1509         This change broke LayoutTests on the bots.
1510
1511         Reverted changeset:
1512
1513         "run-webkit-tests fails when there is a curly brace in Xcode
1514         build output"
1515         https://bugs.webkit.org/show_bug.cgi?id=181254
1516         https://trac.webkit.org/changeset/226816
1517
1518 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1519
1520         webkitpy: Fix flakey webserver tests
1521         https://bugs.webkit.org/show_bug.cgi?id=181555
1522         <rdar://problem/36448273>
1523
1524         Reviewed by Aakash Jain.
1525
1526         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1527         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
1528         determine if a specific server is running.
1529
1530 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1531
1532         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
1533         https://bugs.webkit.org/show_bug.cgi?id=181561
1534         <rdar://problem/36452652>
1535
1536         Reviewed by Aakash Jain.
1537
1538         BeautifulSoup.find may return None, this case should be gracefully handled.
1539
1540         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1541         (BugzillaQueries._parse_result_count):
1542         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
1543
1544 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
1545
1546         run-webkit-tests fails when there is a curly brace in Xcode build output
1547         https://bugs.webkit.org/show_bug.cgi?id=181254
1548
1549         Reviewed by Daniel Bates.
1550
1551         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1552         (MeteredStream.write):
1553
1554 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1555
1556         webkitpy: Reimplement simulator code (Part 3)
1557         https://bugs.webkit.org/show_bug.cgi?id=180555
1558         <rdar://problem/36131381>
1559
1560         Reviewed by Aakash Jain.
1561
1562         Remove old simulator code.
1563
1564         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
1565         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
1566         * Scripts/webkitpy/xcode/simulator.py: Removed.
1567         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
1568
1569 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1570
1571         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
1572         https://bugs.webkit.org/show_bug.cgi?id=181337
1573         <rdar://problem/36324813>
1574
1575         Reviewed by Tim Horton.
1576
1577         Add 3 new API tests for attachment element dragging.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1580         (-[TestWKWebView expectElementTag:toComeBefore:]):
1581         (-[NSItemProvider expectType:withData:]):
1582         (TestWebKitAPI::TEST):
1583
1584 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1585
1586         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
1587         https://bugs.webkit.org/show_bug.cgi?id=179621
1588         <rdar://problem/35589585>
1589
1590         Unreviewed infrastructure fix.
1591
1592         * Scripts/webkitpy/port/mac.py:
1593         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
1594         list if we are the VERSION_MAX, which usually corresponds with future.
1595
1596 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
1597
1598         CodeBlocks should be in IsoSubspaces
1599         https://bugs.webkit.org/show_bug.cgi?id=180884
1600
1601         Reviewed by Saam Barati.
1602         
1603         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
1604         shouldn't take a long time due to benchmarks we don't optimize for.
1605         
1606         * Scripts/run-jsc-benchmarks:
1607
1608 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
1609
1610         Test gardening for GTK.
1611         https://bugs.webkit.org/show_bug.cgi?id=181477
1612
1613         Unreviewed test gardening.
1614
1615         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
1616         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
1617
1618 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1619
1620         Add the new JSCOnly bot to the scheduler.
1621         https://bugs.webkit.org/show_bug.cgi?id=181487
1622
1623         Unreviewed follow-up patch after r226729
1624
1625         On r226729 I missed to add the new JSCOnly bot the default scheduler.
1626         This is needed to make the bot automatically pick each commit for testing.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/config.json:
1629
1630 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1631
1632         [Attachment Support] Support dragging attachment elements out as files on iOS
1633         https://bugs.webkit.org/show_bug.cgi?id=181199
1634         <rdar://problem/36299316>
1635
1636         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
1637
1638         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
1639         attachment API tests.
1640
1641         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1642         (-[NSItemProvider expectType:withData:]):
1643         (TestWebKitAPI::TEST):
1644
1645         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
1646         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
1647         -expectType:withData: helper to inspect the item providers created from the drag source.
1648
1649         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1650         (TestWebKitAPI::TEST):
1651         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1652         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1653         (-[MockDragSession localContext]):
1654         (-[MockDragSession setLocalContext:]):
1655         (-[DataInteractionSimulator _resetSimulatedState]):
1656         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
1657         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1658         (-[DataInteractionSimulator _advanceProgress]):
1659         (-[DataInteractionSimulator endDataTransfer]):
1660
1661         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
1662         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
1663         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
1664         MockDragSession to hold on to a localContext.
1665
1666 2018-01-11  Ali Juma  <ajuma@chromium.org>
1667
1668         Unreviewed. Add Ali Juma as contributor
1669
1670         * Scripts/webkitpy/common/config/contributors.json:
1671
1672 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1673
1674         Unreviewed. Update Selenium WebDriver imported tests.
1675
1676         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
1677         environment variables.
1678
1679         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1680         (collect): Reorder the arguments to make pytest happy.
1681         (run): Ditto.
1682         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1683         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
1684
1685 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
1686
1687         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
1688         https://bugs.webkit.org/show_bug.cgi?id=181492
1689         <rdar://problem/36359679>
1690
1691         Reviewed by Alexey Proskuryakov. 
1692
1693 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
1694
1695         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
1696         https://bugs.webkit.org/show_bug.cgi?id=181475
1697
1698         Reviewed by Michael Catanzaro.
1699
1700         * gtk/install-dependencies: Update package list for Arch Linux, extend
1701         message shown at end of installation with additional tips.
1702
1703 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1704
1705         REGRESSION(r222507): Composition highlight doesn't render when using IME
1706         https://bugs.webkit.org/show_bug.cgi?id=181485
1707         <rdar://problem/35896516>
1708
1709         Reviewed by Ryosuke Niwa.
1710
1711         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
1712         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
1713         allow rendering composition backgrounds (see InlineTextBox::paint).
1714
1715         * DumpRenderTree/ios/TextInputControllerIOS.m:
1716         (+[TextInputController isSelectorExcludedFromWebScript:]):
1717         (+[TextInputController webScriptNameForSelector:]):
1718         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1719         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1720         * DumpRenderTree/mac/TextInputControllerMac.m:
1721         (+[TextInputController isSelectorExcludedFromWebScript:]):
1722         (+[TextInputController webScriptNameForSelector:]):
1723         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
1724         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
1725         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
1726         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1727         (WTR::TextInputController::setMarkedText):
1728         * WebKitTestRunner/InjectedBundle/TextInputController.h:
1729
1730 2018-01-10  JF Bastien  <jfbastien@apple.com>
1731
1732         Poison small JSObject derivatives which only contain pointers
1733         https://bugs.webkit.org/show_bug.cgi?id=181483
1734         <rdar://problem/36407127>
1735
1736         Reviewed by Mark Lam.
1737
1738         Test the new move-assign and move-copy from unique_ptr, as well as
1739         nullptr_t ctors.
1740
1741         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1742         (TestWebKitAPI::TEST):
1743         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1744         (TestWebKitAPI::TEST):
1745         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1746         (TestWebKitAPI::TEST):
1747
1748 2018-01-10  Chris Dumez  <cdumez@apple.com>
1749
1750         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1751         https://bugs.webkit.org/show_bug.cgi?id=179256
1752         <rdar://problem/35401978>
1753
1754         Reviewed by Alex Christensen.
1755
1756         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1757         instance gets its own folder to avoid conflicts and flakiness.
1758
1759         * WebKitTestRunner/mac/TestControllerMac.mm:
1760         (WTR::TestController::platformConfigureViewForTest):
1761
1762 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1763
1764         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1765         https://bugs.webkit.org/show_bug.cgi?id=181269
1766         <rdar://problem/35110344>
1767
1768         Reviewed by Simon Fraser.
1769
1770         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1771         (WTR::UIScriptController::beginBackSwipe):
1772         (WTR::UIScriptController::completeBackSwipe):
1773         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1774         (WTR::UIScriptController::beginBackSwipe):
1775         (WTR::UIScriptController::completeBackSwipe):
1776         (WTR::UIScriptController::overridePreference):
1777         (WTR::UIScriptController::replaceTextAtRange):
1778         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1779         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1780         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1781         (WTR::UIScriptController::beginBackSwipe):
1782         (WTR::UIScriptController::completeBackSwipe):
1783         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1784         exist on Mac) in terms of the new WKWebView testing SPI.
1785
1786 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1787
1788         REGRESSION (r226715): ignore WARNING output in linter tests
1789         https://bugs.webkit.org/show_bug.cgi?id=181486
1790         <rdar://problem/36408847>
1791
1792         Reviewed by Aakash Jain.
1793
1794         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1795
1796         * Scripts/webkitpy/common/system/outputcapture.py:
1797         (OutputCapture.__init__): Pass logging level to be captured.
1798         * Scripts/webkitpy/style/main_unittest.py:
1799         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1800         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1801         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1802         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1803         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1804         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1805         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1806         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1807
1808 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1809
1810         Add a JSCOnly MIPS buildbot
1811         https://bugs.webkit.org/show_bug.cgi?id=181487
1812
1813         Reviewed by Michael Catanzaro.
1814
1815         Add the new bot configs definitions for the master and update the unit tests.
1816
1817         * BuildSlaveSupport/build.webkit.org-config/config.json:
1818         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1819
1820 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1821
1822         REGRESSION (r226715): don't re-check number of simulators in child processes
1823         https://bugs.webkit.org/show_bug.cgi?id=181484
1824         <rdar://problem/36407151>
1825
1826         Reviewed by Aakash Jain.
1827
1828         * Scripts/webkitpy/port/ios_simulator.py:
1829         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1830         are already initialized.
1831
1832 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1833
1834         Unreviewed, rolling out r226667 and r226673.
1835         https://bugs.webkit.org/show_bug.cgi?id=181488
1836
1837         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1838
1839         Reverted changesets:
1840
1841         "CodeBlocks should be in IsoSubspaces"
1842         https://bugs.webkit.org/show_bug.cgi?id=180884
1843         https://trac.webkit.org/changeset/226667
1844
1845         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1846         https://bugs.webkit.org/show_bug.cgi?id=180884
1847         https://trac.webkit.org/changeset/226673
1848
1849 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1850
1851         Follow-up fix to r226715
1852         https://bugs.webkit.org/show_bug.cgi?id=180555
1853         <rdar://problem/36131381>
1854
1855         Unreviewed infrastructure fix.
1856
1857         * Scripts/webkitpy/xcode/new_simulated_device.py:
1858         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1859         of delete.
1860
1861 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1862
1863         webkitpy: Refactor simulator code (Part 2)
1864         https://bugs.webkit.org/show_bug.cgi?id=180555
1865         <rdar://problem/36131381>
1866
1867         Reviewed by Aakash Jain.
1868
1869         The patch leverages the SimulatedDeviceManager when running layout tests.
1870         This patch is primarily code removal, since much of the IOSSimulatorPort
1871         was dedicated to managing simulators. The removed code is either now owned by the
1872         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1873         boot multiple simulators which was made obsolete in Xcode 9.
1874
1875         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1876         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1877         strip those spaces.
1878         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1879         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1880         * Scripts/webkitpy/port/ios.py:
1881         (IOSPort.__init__): The _current_device idiom is no longer required since the
1882         SimulatedDeviceManager keeps track of any previously booted devices.
1883         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1884         through the array of managed devices.
1885         (IOSPort.using_multiple_devices): Deleted.
1886         * Scripts/webkitpy/port/ios_device.py:
1887         (IOSDevicePort.using_multiple_devices): Deleted.
1888         * Scripts/webkitpy/port/ios_simulator.py:
1889         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1890         class strings so they can be parsed by the DeviceType class.
1891         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1892         the number of simulators currently booted, the number of child processes specified
1893         and the maximum number of simulators supported by this system.
1894         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1895         devices owned by the SimulatedDeviceManager.
1896         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1897         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1898         the maximum number of supported simulators on this system.
1899         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1900         request for each child process and send this list to the SimulatedDeviceManager to
1901         initialize the devices.
1902         (IOSSimulatorPort.clean_up_test_run):
1903         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1904         specified version of iOS.
1905         (IOSSimulatorPort.reset_preferences):
1906         (IOSSimulatorPort.simulator_runtime): Deleted.
1907         (IOSSimulatorPort.simulator_device_type): Deleted.
1908         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1909         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1910         (IOSSimulatorPort._create_simulators): Deleted.
1911         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1912         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1913         (IOSSimulatorPort.using_multiple_devices): Deleted.
1914         (IOSSimulatorPort._create_device): Deleted.
1915         (IOSSimulatorPort.get_simulator_path): Deleted.
1916         (IOSSimulatorPort._createSimulatorApps): Deleted.
1917         (IOSSimulatorPort._createSimulatorApp): Deleted.
1918         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1919         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1920         maximum number of simulators run on this system.
1921         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1922         * Scripts/webkitpy/xcode/new_simulated_device.py:
1923         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1924
1925 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1926
1927         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1928         https://bugs.webkit.org/show_bug.cgi?id=181474
1929
1930         Reviewed by Carlos Alberto Lopez Perez.
1931
1932         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1933         name as the name.
1934
1935         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1936         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1937         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1938
1939 2018-01-09  Andy Estes  <aestes@apple.com>
1940
1941         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1942         https://bugs.webkit.org/show_bug.cgi?id=181459
1943
1944         Reviewed by Dan Bernstein.
1945
1946         * ImageDiff/cg/Configurations/Base.xcconfig:
1947
1948 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1949
1950         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1951         https://bugs.webkit.org/show_bug.cgi?id=181374
1952
1953         Reviewed by Simon Fraser.
1954
1955         The test requires Palatino.
1956
1957         * DumpRenderTree/mac/DumpRenderTree.mm:
1958         (allowedFontFamilySet):
1959         * WebKitTestRunner/mac/TestControllerMac.mm:
1960         (WTR::allowedFontFamilySet):
1961
1962 2018-01-09  Saam Barati  <sbarati@apple.com>
1963
1964         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1965         https://bugs.webkit.org/show_bug.cgi?id=181449
1966
1967         Reviewed by JF Bastien.
1968
1969         This allows me to Cmd+f in my terminal to search for things without
1970         having the results become misaligned.
1971
1972         * Scripts/display-profiler-output:
1973
1974 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1975
1976         [webkitpy] PlatformInfo should have default argument for casual use
1977         https://bugs.webkit.org/show_bug.cgi?id=180827
1978
1979         Reviewed by David Kilzer.
1980
1981         PlatformInfo should be the only way to check platform specific thing instead
1982         of sys.platform or other various checks. If there is something you want to check,
1983         it should be placed in PlatformInfo.
1984
1985         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1986         sys, platform and Executive(). They are straight forward and should be handled
1987         by default arguments. Then we can instantiate PlatformInfo more casual.
1988
1989         * Scripts/webkitpy/common/system/platforminfo.py:
1990         (PlatformInfo): Use relative module path import
1991         (PlatformInfo.__init__):
1992         (PlatformInfo.executive): Lazy instantiation of Executive()
1993         (PlatformInfo.total_bytes_memory): Accessing via above property
1994         (PlatformInfo.xcode_sdk_version): Ditto
1995         (PlatformInfo.xcode_simctl_list): Ditto
1996         (PlatformInfo.xcode_version): Ditto
1997         (PlatformInfo._win_version_str): Ditto
1998         * Scripts/webkitpy/common/system/systemhost.py:
1999         (SystemHost.__init__):
2000         * Scripts/webkitpy/common/system/user.py:
2001         (User.__init__):
2002
2003 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2004
2005         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
2006         https://bugs.webkit.org/show_bug.cgi?id=176443
2007
2008         Reviewed by Darin Adler.
2009
2010         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
2011         (TEST):
2012
2013 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
2014
2015         check-webkit-style: Verify syntax for WK_API_AVAILABLE
2016         https://bugs.webkit.org/show_bug.cgi?id=181394
2017
2018         Reviewed by Darin Adler.
2019
2020         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
2021         as the second parameter instead of ios(WK_IOS_TBA). This generally
2022         builds for iOS on EWS but not when using the public SDK. See r224057,
2023         r223207 and r226211 for example. This patch adds a basic style check
2024         for that macro to prevent this kind of mistake.
2025
2026         * Scripts/webkitpy/style/checkers/cpp.py:
2027         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
2028         (check_style): Run new style check.
2029         (CppChecker): Add build type for the new style check.
2030         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2031         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
2032
2033 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2034
2035         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
2036         https://bugs.webkit.org/show_bug.cgi?id=181420
2037         <rdar://problem/36365827>
2038
2039         Reviewed by Alex Christensen.
2040
2041         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
2042         of corresponding _WKAttachments.
2043
2044         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2045         (TestWebKitAPI::TEST):
2046
2047 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2048
2049         Add WKNavigationDelegate SPI exposing WebProcess crash reason
2050         https://bugs.webkit.org/show_bug.cgi?id=181410
2051         <rdar://problem/36167199>
2052
2053         Reviewed by Wenson Hsieh.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2056         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
2057         (TEST):
2058
2059 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2060
2061         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
2062         https://bugs.webkit.org/show_bug.cgi?id=181408
2063         <rdar://problem/35884960>
2064
2065         Reviewed by Tim Horton.
2066
2067         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2068         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2069
2070 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2071
2072         [Attachment Support] Expose file name and content type of WKAttachment
2073         https://bugs.webkit.org/show_bug.cgi?id=181390
2074         <rdar://problem/36336837>
2075
2076         Reviewed by Tim Horton.
2077
2078         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
2079
2080         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2081         (-[_WKAttachment synchronouslyRequestInfo:]):
2082         (-[_WKAttachment synchronouslyRequestData:]):
2083
2084         Reimplement this in terms of -synchronouslyRequestInfo:.
2085
2086         (-[_WKAttachment expectRequestedDataToBe:]):
2087         (TestWebKitAPI::TEST):
2088
2089 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2090
2091         Copying, pasting, and then deleting an attachment element breaks attachment data requests
2092         https://bugs.webkit.org/show_bug.cgi?id=181365
2093         <rdar://problem/36340647>
2094
2095         Reviewed by Tim Horton.
2096
2097         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
2098         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
2099         detail.
2100
2101         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2102         (TestWebKitAPI::TEST):
2103
2104 2018-01-08  Youenn Fablet  <youenn@apple.com>
2105
2106         navigator.onLine does not work inside service workers
2107         https://bugs.webkit.org/show_bug.cgi?id=181079
2108         <rdar://problem/36178606>
2109
2110         Reviewed by Darin Adler.
2111
2112         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2113         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
2114
2115 2018-01-07  Saam Barati  <sbarati@apple.com>
2116
2117         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
2118         https://bugs.webkit.org/show_bug.cgi?id=181372
2119
2120         Reviewed by Filip Pizlo.
2121
2122         Adding these sorting modes makes it easier to analyze functions
2123         that recompile a lot and exit a lot.
2124
2125         * Scripts/display-profiler-output:
2126
2127 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
2128
2129         Unreviewed, remove my Cisco email from contributors.json
2130
2131         * Scripts/webkitpy/common/config/contributors.json:
2132
2133 2018-01-05  JF Bastien  <jfbastien@apple.com>
2134
2135         WebAssembly: poison JS object's secrets
2136         https://bugs.webkit.org/show_bug.cgi?id=181339
2137         <rdar://problem/36325001>
2138
2139         Reviewed by Mark Lam.
2140
2141         Update tests for swap(Poisoned<k, T>, T*)
2142
2143         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
2144         (TestWebKitAPI::TEST):
2145         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2146         (TestWebKitAPI::TEST):
2147         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2148         (TestWebKitAPI::TEST):
2149
2150 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2151
2152         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
2153         https://bugs.webkit.org/show_bug.cgi?id=181359
2154
2155         Reviewed by Tim Horton.
2156
2157         Ensure that these tests still pass using older SDKs.
2158
2159         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2160         (TestWebKitAPI::TEST):
2161
2162 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2163
2164         Rebase API test after r226469
2165         https://bugs.webkit.org/show_bug.cgi?id=181308
2166
2167         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
2168         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2169         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
2170
2171 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2172
2173         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
2174         https://bugs.webkit.org/show_bug.cgi?id=181217
2175
2176         Reviewed by Tim Horton.
2177
2178         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2179         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2180         (TEST):
2181
2182 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2183
2184         Add WKBundleFrameCreateFrameHandle
2185         https://bugs.webkit.org/show_bug.cgi?id=181232
2186         <rdar://problem/35926696>
2187
2188         Reviewed by Tim Horton.
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
2192         (mouseDidMoveOverElement):
2193         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
2194         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2195         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
2196         (TEST):
2197
2198 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
2199
2200         iOS: Build fix after r226432.
2201         
2202         Unreviewed. Stop duplicating speakAs symbols for iOS.
2203
2204         * DumpRenderTree/AccessibilityUIElement.cpp:
2205         (AccessibilityUIElement::speakAs):
2206
2207 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
2208
2209         Unreviewed, added myself as WebKit reviewer
2210
2211         * Scripts/webkitpy/common/config/contributors.json:
2212
2213 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
2214
2215         WPE: Build fix after r226432.
2216
2217         Unreviewed. Rename ::speak() to ::speakAs().
2218         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2219         (WTR::AccessibilityUIElement::speakAs):
2220         (WTR::AccessibilityUIElement::speak): Deleted.
2221
2222 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
2223
2224         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
2225         https://bugs.webkit.org/show_bug.cgi?id=180361
2226
2227         Reviewed by Zalan Bujtas.
2228
2229         * DumpRenderTree/AccessibilityUIElement.cpp:
2230         (speakAsCallback):
2231         (AccessibilityUIElement::speakAs):
2232         (AccessibilityUIElement::getJSClass):
2233         (speakCallback): Deleted.
2234         (AccessibilityUIElement::speak): Deleted.
2235         * DumpRenderTree/AccessibilityUIElement.h:
2236         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2237         (AccessibilityUIElement::speakAs):
2238         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2239         (AccessibilityUIElement::speakAs):
2240         (AccessibilityUIElement::speak): Deleted.
2241         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2242         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2243         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2244         (WTR::AccessibilityUIElement::speakAs):
2245         (WTR::AccessibilityUIElement::speak): Deleted.
2246         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2247         (WTR::AccessibilityUIElement::speakAs):
2248         (WTR::AccessibilityUIElement::speak): Deleted.
2249
2250 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
2251
2252         REGRESSION (r226395): test-webkitperl test expectations incorrect
2253         https://bugs.webkit.org/show_bug.cgi?id=181307
2254         <rdar://problem/36306558>
2255
2256         Rubber-stamped by Aakash Jain.
2257
2258         r226395 added two lines towards the beginning of
2259         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
2260         numbers in the test expectations need to update.
2261
2262         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2263
2264 2018-01-04  Tim Horton  <timothy_horton@apple.com>
2265
2266         WKWebView loses minimum layout size overrides that happen while the process is terminated
2267         https://bugs.webkit.org/show_bug.cgi?id=181306
2268         <rdar://problem/34398288>
2269
2270         Reviewed by Dan Bernstein.
2271
2272         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2273         (TEST):
2274         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
2275         while the process is terminated results in the page getting the correct
2276         minimum layout size.
2277
2278 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
2279
2280         [MediaStream] Add Mock screen capture source
2281         https://bugs.webkit.org/show_bug.cgi?id=181291
2282         <rdar://problem/36298164>
2283
2284         Reviewed by Dean Jackson.
2285
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
2287         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2288         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2289
2290 2018-01-04  Lucas Forschler  <lforschler@apple.com>
2291
2292         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
2293
2294         Reviewed by Ling Ho.
2295
2296         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2297
2298 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2299
2300         [Attachment Support] Create attachment elements when dropping files on iOS
2301         https://bugs.webkit.org/show_bug.cgi?id=181192
2302         <rdar://problem/36280945>
2303
2304         Reviewed by Tim Horton.
2305
2306         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
2307         switch is enabled. See below for more details.
2308
2309         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2310         (-[NSItemProvider registerData:type:]):
2311         (platformCopyPNG):
2312         (TestWebKitAPI::TEST):
2313         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2314
2315         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
2316         source item provider when dragging rich text *without* attachments, so this should have been a check for just
2317         kUTTypeRTF instead.
2318
2319         (TestWebKitAPI::TEST):
2320
2321         Tests a few cases of inserting attachment elements via drop:
2322         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
2323             Instead of inserting the contents as inline web content, this should generate attachment elements.
2324         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
2325             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
2326             back to inserting the content as an attachment.
2327         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
2328             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
2329             or at the end).
2330
2331         * TestWebKitAPI/cocoa/TestWKWebView.h:
2332         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2333         (-[TestWKWebView objectByEvaluatingJavaScript:]):
2334
2335         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
2336         -stringByEvaluatingJavaScript to just turn around and call this.
2337
2338         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2339
2340 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
2341
2342         Replace hard-coded paths in shebangs with #!/usr/bin/env
2343         https://bugs.webkit.org/show_bug.cgi?id=181040
2344
2345         Reviewed by Alex Christensen.
2346
2347         * BuildSlaveSupport/build-launcher-app:
2348         * BuildSlaveSupport/build-launcher-dmg:
2349         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2350         * BuildSlaveSupport/built-product-archive:
2351         * BuildSlaveSupport/clean-build:
2352         * BuildSlaveSupport/delete-stale-build-files:
2353         * BuildSlaveSupport/download-built-product:
2354         * BuildSlaveSupport/gtk/buildbot/log/run:
2355         * BuildSlaveSupport/gtk/buildbot/run:
2356         * BuildSlaveSupport/gtk/pulseaudio/run:
2357         * BuildSlaveSupport/kill-old-processes:
2358         * BuildSlaveSupport/test-result-archive:
2359         * BuildSlaveSupport/win/kill-old-processes:
2360         * Scripts/SpacingHeuristics.pm:
2361         * Scripts/add-include:
2362         * Scripts/build-api-tests:
2363         * Scripts/build-dumprendertree:
2364         * Scripts/build-imagediff:
2365         * Scripts/build-jsc:
2366         * Scripts/build-webkit:
2367         * Scripts/build-webkittestrunner:
2368         * Scripts/check-Xcode-source-file-types:
2369         * Scripts/check-dom-results:
2370         * Scripts/check-for-exit-time-destructors:
2371         * Scripts/check-for-global-initializers:
2372         * Scripts/check-for-inappropriate-objc-class-names:
2373         * Scripts/check-for-weak-vtables-and-externals:
2374         * Scripts/clean-header-guards:
2375         * Scripts/compare-timing-files:
2376         * Scripts/configure-xcode-for-ios-development:
2377         * Scripts/copy-webkitlibraries-to-product-directory:
2378         * Scripts/create-exports:
2379         * Scripts/debug-minibrowser:
2380         * Scripts/debug-safari:
2381         * Scripts/debug-test-runner:
2382         * Scripts/do-file-rename:
2383         * Scripts/do-webcore-rename:
2384         * Scripts/dump-webkit-tests-run:
2385         * Scripts/ensure-valid-python:
2386         * Scripts/execAppWithEnv:
2387         * Scripts/extract-localizable-js-strings:
2388         * Scripts/filter-build-webkit:
2389         * Scripts/find-extra-includes:
2390         * Scripts/fix-blink-patch:
2391         * Scripts/generate-coverage-data:
2392         * Scripts/git-add-reviewer:
2393         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2394         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
2395         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
2396         * Scripts/make-new-script-test:
2397         * Scripts/make-script-test-wrappers:
2398         * Scripts/package-root:
2399         * Scripts/parse-malloc-history:
2400         * Scripts/report-include-statistics:
2401         * Scripts/resolve-ChangeLogs:
2402         * Scripts/run-api-tests:
2403         * Scripts/run-bindings-tests:
2404         * Scripts/run-content-extension-tester:
2405         * Scripts/run-iexploder-tests:
2406         * Scripts/run-javascriptcore-tests:
2407         * Scripts/run-jsc:
2408         * Scripts/run-leaks:
2409         * Scripts/run-mangleme-tests:
2410         * Scripts/run-minibrowser:
2411         * Scripts/run-pageloadtest:
2412         * Scripts/run-regexp-tests:
2413         * Scripts/run-safari:
2414         * Scripts/run-sunspider:
2415         * Scripts/run-test-runner:
2416         * Scripts/run-webkit-app:
2417         * Scripts/run-webkit-httpd:
2418         * Scripts/run-webkit-websocketserver:
2419         * Scripts/set-webkit-configuration:
2420         * Scripts/show-pretty-diff:
2421         * Scripts/sort-Xcode-project-file:
2422         * Scripts/split-file-by-class:
2423         * Scripts/sunspider-compare-results:
2424         * Scripts/svn-apply:
2425         * Scripts/svn-unapply:
2426         * Scripts/test-webkit-scripts:
2427         * Scripts/test-webkitperl:
2428         * Scripts/update-iexploder-cssproperties:
2429         * Scripts/update-javascriptcore-test-results:
2430         * Scripts/update-webkit:
2431         * Scripts/update-webkit-auxiliary-libs:
2432         * Scripts/update-webkit-dependency:
2433         * Scripts/update-webkit-libs-jhbuild:
2434         * Scripts/update-webkit-localizable-strings:
2435         * Scripts/update-webkit-support-libs:
2436         * Scripts/update-webkitgtk-libs:
2437         * Scripts/update-webkitwpe-libs:
2438         * Scripts/webkit-build-directory:
2439         * Scripts/webkitperl/LoadAsModule.pm:
2440         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
2441         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2442         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
2443         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
2444         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
2445         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2446         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
2447         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2448         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2449         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2450         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
2451         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
2452         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
2453         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2454         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2455         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2456         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2457         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
2458         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
2459         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
2460         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
2461         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
2462         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
2463         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
2464         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2465         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2466         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
2467         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
2468         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
2469         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2470         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2471         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2472         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
2473         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
2474         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
2475         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2476         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2477         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2478         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
2479         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2480         * ccache/ccache-clang:
2481         * ccache/ccache-clang++:
2482         * ccache/ccache-wrapper:
2483         * gtk/install-dependencies:
2484         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
2485         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
2486         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
2487         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
2488         * iExploder/iexploder-1.3.2/tools/showtest.rb:
2489         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
2490         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
2491         * iExploder/iexploder-1.7.2/src/webserver.rb:
2492         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
2493         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
2494         * wpe/install-dependencies:
2495
2496 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
2497
2498         filter-build-webkit filters out useful compiler error lines
2499         https://bugs.webkit.org/show_bug.cgi?id=179864
2500
2501         Reviewed by Tim Horton.
2502
2503         Don't filter out lines that contain information about build errors by always showing lines
2504         after a line that contains "note:" or "error:".
2505
2506         * Scripts/filter-build-webkit:
2507         (shouldShowSubsequentLine):
2508         (shouldIgnoreLine):
2509
2510 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2511
2512         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
2513         https://bugs.webkit.org/show_bug.cgi?id=173915
2514
2515         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
2516         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
2517         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
2518         empty string in this case.
2519
2520         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2521         (emitFormSubmissionEvent):
2522
2523 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2524
2525         [GTK] Add web process API to detect when form is submitted via JavaScript
2526         https://bugs.webkit.org/show_bug.cgi?id=173915
2527
2528         Reviewed by Carlos Garcia Campos.
2529
2530         Test it.
2531
2532         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2533         (FormSubmissionTest::FormSubmissionTest):
2534         (FormSubmissionTest::~FormSubmissionTest):
2535         (FormSubmissionTest::testFormSubmissionResult):
2536         (FormSubmissionTest::willSendDOMEventCallback):
2537         (FormSubmissionTest::willCompleteCallback):
2538         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
2539         (testWebExtensionFormSubmissionSteps):
2540         (beforeAll):
2541         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2542         (DelayedSignal::DelayedSignal):
2543         (emitFormSubmissionEvent):
2544         (handleFormSubmissionCallback):
2545         (willSubmitFormCallback):
2546         (pageCreatedCallback):
2547
2548 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2549
2550         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
2551         https://bugs.webkit.org/show_bug.cgi?id=181251
2552
2553         * Scripts/run-gtk-tests:
2554         (GtkTestRunner):
2555
2556 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2557
2558         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
2559         https://bugs.webkit.org/show_bug.cgi?id=181136
2560
2561         * Scripts/run-gtk-tests:
2562         (GtkTestRunner):
2563
2564 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
2565
2566         [macOS, iOS] Adopt new secure coding APIs in WebKit
2567         https://bugs.webkit.org/show_bug.cgi?id=181085
2568         <rdar://problem/34837397>
2569
2570         Reviewed by Tim Horton.
2571
2572         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
2573         capable of supporting NSSecureCoding, so pass through the current coding routines.
2574
2575         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
2576         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2577         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
2578         routines if necessary.
2579         (TEST): Updated for NSSecureCoding.
2580         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
2581         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
2582
2583 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2584
2585         Remove std::chrono completely
2586         https://bugs.webkit.org/show_bug.cgi?id=181186
2587
2588         Reviewed by Alex Christensen.
2589
2590         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2591         (WTR::TestController::platformRunUntil):
2592
2593 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2594
2595         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
2596         https://bugs.webkit.org/show_bug.cgi?id=181231
2597
2598         Reviewed by Alex Christensen.
2599
2600         Implement TestController APIs needed by ResourceLoadStatistics tests.
2601
2602         * WebKitTestRunner/TestController.cpp:
2603         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2604         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2605
2606 2018-01-02  Tim Horton  <timothy_horton@apple.com>
2607
2608         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
2609         https://bugs.webkit.org/show_bug.cgi?id=181219
2610
2611         Reviewed by Wenson Hsieh.
2612
2613         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2614
2615 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2616
2617         Add a WebAuthentication runtime feature flag
2618         https://bugs.webkit.org/show_bug.cgi?id=181220
2619         <rdar://problem/36055305>
2620
2621         Reviewed by Brent Fulgham.
2622
2623         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2624
2625         * DumpRenderTree/TestOptions.h:
2626         * DumpRenderTree/TestOptions.mm:
2627         (TestOptions::TestOptions):
2628         * DumpRenderTree/mac/DumpRenderTree.mm:
2629         (enableExperimentalFeatures):
2630         (setWebPreferencesForTestOptions):
2631         * WebKitTestRunner/TestController.cpp:
2632         (WTR::TestController::resetPreferencesToConsistentValues):
2633         (WTR::updateTestOptionsFromTestHeader):
2634         * WebKitTestRunner/TestOptions.h:
2635         (WTR::TestOptions::hasSameInitializationOptions const):
2636
2637 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2638
2639         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
2640         https://bugs.webkit.org/show_bug.cgi?id=181143
2641         <rdar://problem/36200381>
2642
2643         Reviewed by Tim Horton.
2644
2645         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
2646         attachment elements are enabled.
2647
2648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2649         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2650         (TestWebKitAPI::TEST):
2651
2652 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2653
2654         Update Credential Management API for WebAuthentication
2655         https://bugs.webkit.org/show_bug.cgi?id=181082
2656         <rdar://problem/36055239>
2657
2658         Reviewed by Brent Fulgham.
2659
2660         Enable Credential Management API for testing.
2661
2662         * DumpRenderTree/TestOptions.h:
2663         * WebKitTestRunner/TestOptions.h:
2664
2665 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2666
2667         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
2668         https://bugs.webkit.org/show_bug.cgi?id=168194
2669
2670         Reviewed by Carlos Garcia Campos.
2671
2672         Fix an assertion and unskip the test. The order that form controls are associated is not
2673         guaranteed.
2674
2675         * Scripts/run-gtk-tests:
2676         (GtkTestRunner):
2677         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2678         (didAssociateFormControlsCallback):
2679
2680 2018-01-02  Alex Christensen  <achristensen@webkit.org>
2681
2682         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
2683         https://bugs.webkit.org/show_bug.cgi?id=180897
2684         <rdar://problem/35535328>
2685
2686         Reviewed by Brent Fulgham.
2687
2688         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
2689
2690         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2691         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2692         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
2693         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2694         (websiteDataStoreTestWebView):
2695         (TEST):
2696
2697 == Rolled over to ChangeLog-2018-01-01 ==