DumpRenderTree should report unknown options
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2
3         DumpRenderTree should report unknown options
4         https://bugs.webkit.org/show_bug.cgi?id=191303
5
6         Reviewed by Frédéric Wang.
7
8         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
9         to report unknown options.
10         Added and assigned test options which are currently used in tests.
11
12         * DumpRenderTree/TestOptions.cpp:
13         (TestOptions::TestOptions):
14
15 2019-02-11  Truitt Savell  <tsavell@apple.com>
16
17         Unreviewed, rolling out r241229.
18
19         Revision broke internal builds for watchOS.
20
21         Reverted changeset:
22
23         "[Cocoa] Ask platform for generic font family mappings"
24         https://bugs.webkit.org/show_bug.cgi?id=187723
25         https://trac.webkit.org/changeset/241229
26
27 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
28
29         [WinCairo][MiniBrowser] Basic authentication always fails.
30         https://bugs.webkit.org/show_bug.cgi?id=194496
31
32         Reviewed by Don Olmstead.
33
34         * MiniBrowser/win/DialogHelper.h:
35         (Dialog::getText):
36
37 2019-02-11  Philippe Normand  <pnormand@igalia.com>
38
39         [GStreamer] GstMappedBuffer testsuite build fails
40         https://bugs.webkit.org/show_bug.cgi?id=194495
41
42         Reviewed by Carlos Garcia Campos.
43
44         Fix the build by explicitely adding the gstreamer1.0-audio include
45         directories to the include path.
46
47         * TestWebKitAPI/PlatformGTK.cmake:
48         * TestWebKitAPI/PlatformWPE.cmake:
49
50 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
51
52         [GTK][WPE] Add enable-javascript-markup setting
53         https://bugs.webkit.org/show_bug.cgi?id=193439
54
55         Reviewed by Michael Catanzaro.
56
57         Add test cases to check the new setting.
58
59         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
60         (testWebKitSettings):
61         (testWebKitSettingsJavaScriptMarkup):
62         (beforeAll):
63
64 2019-02-10  Darin Adler  <darin@apple.com>
65
66         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
67         https://bugs.webkit.org/show_bug.cgi?id=194485
68
69         Reviewed by Daniel Bates.
70
71         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
72
73 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
74
75         Add more tests for clampTo<>()
76         https://bugs.webkit.org/show_bug.cgi?id=194462
77
78         Reviewed by Geoffrey Garen.
79
80         Darin suggested to test the very last floating point number
81         at the boundaries when truncating to integer.
82         I added test for max/min and max-1/min-1.
83
84         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
85         (TestWebKitAPI::TEST):
86
87 2019-02-09  Darin Adler  <darin@apple.com>
88
89         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
90         https://bugs.webkit.org/show_bug.cgi?id=194021
91
92         Reviewed by Geoffrey Garen.
93
94         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
95         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
96         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
97
98 2019-02-09  Zalan Bujtas  <zalan@apple.com>
99
100         [LFC][IFC] Add intrinsic width support for basic inline containers
101         https://bugs.webkit.org/show_bug.cgi?id=194473
102
103         Reviewed by Antti Koivisto.
104
105         Expand tests coverage (11 new tests -> 798)
106
107         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
108
109 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
110
111         Fix MiniBrowser's entitlements
112         https://bugs.webkit.org/show_bug.cgi?id=192431
113
114         Reviewed by Joseph Pecoraro.
115
116         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
117         files, making it impossible to load any extension.
118
119         * MiniBrowser/MiniBrowser.entitlements:
120
121 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
122
123         [Cocoa] Ask platform for generic font family mappings
124         https://bugs.webkit.org/show_bug.cgi?id=187723
125         <rdar://problem/41892438>
126
127         Reviewed by Brent Fulgham.
128
129         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
130
131         * DumpRenderTree/mac/DumpRenderTree.mm:
132         (allowedFontFamilySet):
133         * WebKitTestRunner/mac/TestControllerMac.mm:
134         (WTR::allowedFontFamilySet):
135
136 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
137
138         [GTK] Implement back/forward touchpad gesture
139         https://bugs.webkit.org/show_bug.cgi?id=193919
140
141         Reviewed by Michael Catanzaro.
142
143         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
144         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
145
146 2019-02-08  Alex Christensen  <achristensen@webkit.org>
147
148         Add SPI to use networking daemon instead of XPC service
149         https://bugs.webkit.org/show_bug.cgi?id=194427
150
151         Reviewed by Geoffrey Garen
152
153         * MiniBrowser/MiniBrowser.entitlements:
154
155 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-build] Ensure that every builder in config.json has short name
158         https://bugs.webkit.org/show_bug.cgi?id=194461
159
160         Reviewed by Lucas Forschler.
161
162         * BuildSlaveSupport/ews-build/loadConfig.py:
163         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
164
165 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
166
167         [ews-build] Add short name to config.json
168         https://bugs.webkit.org/show_bug.cgi?id=194456
169
170         Reviewed by Lucas Forschler.
171
172         * BuildSlaveSupport/ews-build/config.json: Added short name.
173         * BuildSlaveSupport/ews-build/loadConfig.py:
174         (loadBuilderConfig): Set the short name as the builder description.
175
176 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
177
178         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
179         https://bugs.webkit.org/show_bug.cgi?id=194418
180
181         Reviewed by Lucas Forschler.
182
183         Do not include errors trying when finding crashlogs at the end of
184         a run-webkit-tests run since we don't process those errors.
185
186         * Scripts/webkitpy/port/darwin.py:
187         (DarwinPort._look_for_all_crash_logs_in_log_dir):
188         * Scripts/webkitpy/port/ios_device.py:
189         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
190         * Scripts/webkitpy/port/watch_device.py:
191         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
192
193 2019-02-08  Beth Dakin  <bdakin@apple.com>
194
195         Add afterScreenUpdates to WKSnapshotConfiguration
196         https://bugs.webkit.org/show_bug.cgi?id=194362
197         -and corresponding-
198         <rdar://problem/40655528> Please add an "after screen updates" property to 
199         WKSnapshotConfiguration (to solve blank snapshots)
200
201         Reviewed by Tim Horton.
202
203         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
204         (TEST):
205
206 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
207
208         clampTo(): do not convert the input to double when dealing with integers
209         https://bugs.webkit.org/show_bug.cgi?id=194263
210         <rdar://problem/47692312>
211
212         Reviewed by Darin Adler.
213
214         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
215         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
216         (TestWebKitAPI::testClampFloatingPointToInteger):
217         (TestWebKitAPI::testClampSameSignIntegers):
218         (TestWebKitAPI::testClampUnsignedToSigned):
219         (TestWebKitAPI::testClampSignedToUnsigned):
220
221 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
222
223         webkitpy: Respect --dedicated-simulators flag
224         https://bugs.webkit.org/show_bug.cgi?id=194416
225         <rdar://problem/47894722>
226
227         Reviewed by Lucas Forschler.
228
229         * Scripts/webkitpy/port/device_port.py:
230         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
231         available devices can be safely ignored.
232
233 2019-02-07  Keith Rollin  <krollin@apple.com>
234
235         Remove extra copy of 100x100-red.tga
236         https://bugs.webkit.org/show_bug.cgi?id=194371
237         <rdar://problem/47873465>
238
239         Reviewed by Said Abou-Hallawa.
240
241         In order to help it pass its tests, Bug 194190 added a second copy of
242         the file 100x100-red.tga. However, it turns out that this additional
243         file wasn't actually needed, and that that sole previous copy was
244         sufficient. At the same time, this second copy -- which was copied to
245         the same location in the build output as the first copy -- now caused
246         XCBuild to complain because there were two production rules for the
247         same output file. Address this by removing the newly-added extra copy.
248
249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
250         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
251
252 2019-02-07  Alex Christensen  <achristensen@webkit.org>
253
254         Deprecate WKBundlePageSetDefersLoading
255         https://bugs.webkit.org/show_bug.cgi?id=191394
256
257         Reviewed by Dean Jackson.
258
259         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
260         (WTR::TestRunner::setDefersLoading):
261
262 2019-02-07  Zalan Bujtas  <zalan@apple.com>
263
264         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
265         https://bugs.webkit.org/show_bug.cgi?id=194391
266
267         Reviewed by Antti Koivisto.
268
269         * LayoutReloaded/misc/LFC-passing-tests.txt:
270
271 2019-02-06  Keith Rollin  <krollin@apple.com>
272
273         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
274         https://bugs.webkit.org/show_bug.cgi?id=193975
275         <rdar://problem/47643306>
276
277         Reviewed by Tim Horton.
278
279         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
280         the Info.plist file into the bundle. This step is not necessary as the
281         implicit "bundle up all the build products into a framework" build
282         phase does this already. Having the Copy Bundle Resources phase do
283         this causes a conflict under XCBuild, which objects to two build
284         phases producing the same file (Info.plist). Address this by removing
285         Info.plist from the Copy Bundle Resources phase.
286
287         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
288
289 2019-02-06  Keith Rollin  <krollin@apple.com>
290
291         Really enable the automatic checking and regenerations of .xcfilelists during builds
292         https://bugs.webkit.org/show_bug.cgi?id=194357
293         <rdar://problem/47861231>
294
295         Reviewed by Chris Dumez.
296
297         Bug 194124 was supposed to enable the automatic checking and
298         regenerating of .xcfilelist files during the build. While related
299         changes were included in that patch, the change to actually enable the
300         operation somehow was omitted. This patch actually enables the
301         operation. The check-xcfilelist.sh scripts now check
302         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
303         from the checking.
304
305         * DumpRenderTree/Scripts/check-xcfilelists.sh:
306         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
307
308 2019-02-06  David Kilzer  <ddkilzer@apple.com>
309
310         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
311         <https://webkit.org/b/194286>
312         <rdar://problem/47815558>
313
314         Reviewed by Alexey Proskuryakov.
315
316         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
317         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
318         WKRetainPtr<> to avoid leaking the WKDataRef.
319
320 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
321
322         Unreviewed, fix a typo
323
324         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
325
326 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
327
328         [GTK][WPE] force libpsl build to use ICU in jhbuild
329         https://bugs.webkit.org/show_bug.cgi?id=194288
330
331         Reviewed by Carlos Garcia Campos.
332
333         * gtk/jhbuild.modules:
334         Require ICU for libpsl build in jhbuild, like done in WPE.
335
336 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
337
338         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
339         https://bugs.webkit.org/show_bug.cgi?id=194209
340
341         Reviewed by Carlos Garcia Campos.
342
343         Enhance TestCookieManager to ensure this doesn't happen again.
344
345         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
346         (testCookieManagerPersistentStorage):
347         (beforeAll):
348
349 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
350
351         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
352         https://bugs.webkit.org/show_bug.cgi?id=194324
353
354         Reviewed by Andy Estes.
355
356         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
357         part of the name is already implicit, since this is in testing code in TestOptions.
358
359         * WebKitTestRunner/TestController.cpp:
360         (WTR::TestController::generateContextConfiguration const):
361         (WTR::updateTestOptionsFromTestHeader):
362         * WebKitTestRunner/TestOptions.h:
363         (WTR::TestOptions::hasSameInitializationOptions const):
364
365 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews-build] Allow * as platform for builders and workers
368         https://bugs.webkit.org/show_bug.cgi?id=188533
369
370         Reviewed by Lucas Forschler.
371
372         * BuildSlaveSupport/ews-build/loadConfig.py:
373         (checkWorkersAndBuildersForConsistency):
374
375 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
376
377         [ews-build] Add few bots to config.json
378         https://bugs.webkit.org/show_bug.cgi?id=194304
379
380         Reviewed by Lucas Forschler.
381
382         * BuildSlaveSupport/ews-build/config.json:
383
384 2019-02-05  Keith Rollin  <krollin@apple.com>
385
386         Enable the automatic checking and regenerations of .xcfilelists during builds
387         https://bugs.webkit.org/show_bug.cgi?id=194124
388         <rdar://problem/47721277>
389
390         Reviewed by Tim Horton.
391
392         Bug 193790 add a facility for checking -- during build time -- that
393         any needed .xcfilelist files are up-to-date and for updating them if
394         they are not. This facility was initially opt-in by setting
395         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
396         the process seemed robust. Its now time to enable this facility and
397         make it opt-out. If there is a need to disable this facility, set and
398         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
399         running `make` or `build-webkit`, or before running Xcode from the
400         command line.
401
402         Additionally, remove the step that generates a list of source files
403         going into the UnifiedSources build step. It's only necessarily to
404         specify Sources.txt and SourcesCocoa.txt as inputs.
405
406         * Scripts/generate-xcfilelists:
407
408 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
409
410         [GTK][WPE] force libpsl build to use ICU in jhbuild
411         https://bugs.webkit.org/show_bug.cgi?id=194288
412
413         Reviewed by Philippe Normand.
414
415         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
416         This can cause build failures if libidn is detected but libunistring is not available.
417
418         Make sure that ICU is used for runtime and builtin PSL data.
419
420         * gtk/jhbuild.modules:
421         * wpe/jhbuild.modules:
422
423 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
424
425         [ews-app] Modified timestamp should be updated on updating data
426         https://bugs.webkit.org/show_bug.cgi?id=194295
427
428         Reviewed by Lucas Forschler.
429
430         * BuildSlaveSupport/ews-app/ews/models/build.py:
431         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
432         * BuildSlaveSupport/ews-app/ews/models/step.py:
433
434 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
435
436         Unreviewed, rolling out r240742.
437
438         Causes crashes on iOS simulator.
439
440         Reverted changeset:
441
442         "[iOS] Keyups for non-modifier keys identified as "Dead" when
443         not focused in a content-editable element"
444         https://bugs.webkit.org/show_bug.cgi?id=192824
445         https://trac.webkit.org/changeset/240742
446
447 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
448
449         run-webkit-tests emits message "...running None" when running tests
450         https://bugs.webkit.org/show_bug.cgi?id=194133
451         <rdar://problem/47724738>
452
453         Reviewed by Lucas Forschler.
454
455         * Scripts/webkitpy/xcode/device_type.py:
456         (DeviceType.__str__): Use both version mapping tables and use just the variant
457         name if no version name is available.
458         * Scripts/webkitpy/xcode/device_type_unittest.py:
459         (DeviceTypeTest):
460         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
461         an associated named.
462
463 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
464
465         [WPE] require python3-setuptools for meson build in jhbuild
466         https://bugs.webkit.org/show_bug.cgi?id=194287
467
468         Reviewed by Philippe Normand.
469
470         python3-setuptools is needed to build meson in jhbuild.
471         It is already required by the GTK port.
472
473         * wpe/install-dependencies:
474
475 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
476
477         [ews-app] Add method to save BuilderMapping to database
478         https://bugs.webkit.org/show_bug.cgi?id=194264
479
480         Reviewed by Lucas Forschler.
481
482         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
483         (BuilderMapping.__str__):
484         (BuilderMapping):
485         (BuilderMapping.save_mapping):
486         (BuilderMapping.update_mapping):
487         (BuilderMapping.get_existing_mapping):
488         (BuilderMapping.is_valid_mapping):
489
490 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
491
492         [ews-app] Add timestamp fields for BuilderMappings
493         https://bugs.webkit.org/show_bug.cgi?id=194266
494
495         Reviewed by Lucas Forschler.
496
497         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
498         (BuilderMapping):
499
500 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
501
502         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
503         https://bugs.webkit.org/show_bug.cgi?id=174816
504
505         Reviewed by Michael Catanzaro.
506
507         Add tests for webkit_uri_for_display().
508
509         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
510         (testURIForDisplayUnaffected):
511         (testURIForDisplayAffected):
512         (beforeAll):
513         (afterAll):
514         * TestWebKitAPI/glib/CMakeLists.txt:
515
516 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
517
518         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
519         https://bugs.webkit.org/show_bug.cgi?id=194158
520         <rdar://problem/47737268>
521
522         Rubber-stamped by Aakash Jain.
523
524         * Scripts/webkitpy/port/device_port.py:
525         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
526
527 2019-02-04  Said Abou-Hallawa  <said@apple.com>
528
529         [CG] Enable setAdditionalSupportedImageTypes for WK1
530         https://bugs.webkit.org/show_bug.cgi?id=194190
531
532         Reviewed by Tim Horton.
533
534         Add a test similar to the one under WebKit Cocoa but make it create a
535         WebView instead of a WKWebView.
536
537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
538         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
539         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
540         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
541         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
542         (TestWebKitAPI::runTest):
543         (TestWebKitAPI::TEST):
544
545 2019-02-04  Zalan Bujtas  <zalan@apple.com>
546
547         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
548         https://bugs.webkit.org/show_bug.cgi?id=194168
549
550         Reviewed by Simon Fraser.
551
552         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
553
554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
555         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
556         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
557         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
558         (TEST):
559         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
560         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
561
562 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
563
564         REGRESSION (r237269): webkit-patch what-broke is broken 
565         https://bugs.webkit.org/show_bug.cgi?id=193025
566
567         Reviewed by Aakash Jain.
568
569         * Scripts/webkitpy/common/host.py:
570         (Host.buildbot):
571         (Host.bugzilla): Renamed to 'buildbot'.
572
573 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
574
575         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
576         https://bugs.webkit.org/show_bug.cgi?id=194207
577
578         Reviewed by Tim Horton.
579
580         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
581         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
582         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
583         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
584         start and delete forwards to remove the original attachment.
585
586         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
587         (TestWebKitAPI::TEST):
588
589 2019-02-04  Youenn Fablet  <youenn@apple.com>
590
591         Capture state should be managed consistently when doing process swapping
592         https://bugs.webkit.org/show_bug.cgi?id=194122
593         <rdar://problem/47609293>
594
595         Reviewed by Eric Carlson.
596
597         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
598         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
599         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
600         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
601         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
602         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
603         (WTR::TestRunner::isDoingMediaCapture const):
604         * WebKitTestRunner/InjectedBundle/TestRunner.h:
605         * WebKitTestRunner/TestController.cpp:
606         (WTR::TestController::isDoingMediaCapture const):
607         * WebKitTestRunner/TestController.h:
608         * WebKitTestRunner/TestInvocation.cpp:
609         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
610         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
611         (WTR::TestController::isDoingMediaCapture const):
612
613 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
614
615         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
616         https://bugs.webkit.org/show_bug.cgi?id=194142
617
618         Reviewed by Ross Kirsling.
619
620         There three 'separator' variables in TestController.cpp. Renamed
621         it 'pathSeparator', and unified them.
622
623         * WebKitTestRunner/TestController.cpp:
624         (WTR::TestController::generateContextConfiguration const):
625         (WTR::createTestURL):
626         (WTR::TestController::platformAdjustContext):
627
628 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
629
630         Make setNeedsLayout on the root more explicitly about triggering its side-effects
631         https://bugs.webkit.org/show_bug.cgi?id=194198
632
633         Reviewed by Antti Koivisto.
634
635         No need to set the banner heights on navigation now, since Page stores them.
636
637         * MiniBrowser/mac/WK2BrowserWindowController.m:
638         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
639
640 2019-02-03  John Wilander  <wilander@apple.com>
641
642         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
643         https://bugs.webkit.org/show_bug.cgi?id=194104
644         <rdar://problem/47649991>
645
646         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
647
648         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
649         (TestWebKitAPI::TEST):
650             Changed numeric types from unsigned short to uint32_t.
651
652 2019-02-02  David Kilzer  <ddkilzer@apple.com>
653
654         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
655         <https://webkit.org/b/194178>
656         <rdar://problem/47753473>
657
658         Reviewed by Alexey Proskuryakov.
659
660         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
661         (WTR::uninstallFakeHelvetica): Pass nullptr into
662         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
663
664 2019-02-02  Zalan Bujtas  <zalan@apple.com>
665
666         [LFC] Initialize ICB's style with fixed width/height.
667         https://bugs.webkit.org/show_bug.cgi?id=194188
668
669         Reviewed by Antti Koivisto.
670
671         * LayoutReloaded/misc/LFC-passing-tests.txt:
672
673 2019-02-02  Zalan Bujtas  <zalan@apple.com>
674
675         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
676         https://bugs.webkit.org/show_bug.cgi?id=194185
677
678         Reviewed by Antti Koivisto.
679
680         * LayoutReloaded/misc/LFC-passing-tests.txt:
681
682 2018-12-16  Darin Adler  <darin@apple.com>
683
684         Convert additional String::format clients to alternative approaches
685         https://bugs.webkit.org/show_bug.cgi?id=192746
686
687         Reviewed by Alexey Proskuryakov.
688
689         * WebKitTestRunner/TestController.cpp:
690         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
691         as an intermediate in code that ultimately constructs a WTF::String.
692         (WTR::userMediaOriginHash): Use makeString.
693         (WTR::TestController::didNavigateWithNavigationData): More of the same.
694         (WTR::TestController::didPerformClientRedirect): Ditto.
695         (WTR::TestController::didPerformServerRedirect): Ditto.
696         (WTR::TestController::didUpdateHistoryTitle): Ditto.
697
698 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
699
700         [ews-build] Add unit test to verify builder keys
701         https://bugs.webkit.org/show_bug.cgi?id=194152
702
703         Reviewed by Lucas Forschler.
704
705         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
706         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
707
708 2019-02-01  Zalan Bujtas  <zalan@apple.com>
709
710         [LFC] Expand tests coverage (12 new tests -> 787)
711
712         Unreviewed test gardening.
713
714         * LayoutReloaded/misc/LFC-passing-tests.txt:
715
716 2019-02-01  Zalan Bujtas  <zalan@apple.com>
717
718         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
719         https://bugs.webkit.org/show_bug.cgi?id=194163
720
721         Reviewed by Simon Fraser.
722
723         775
724
725         * LayoutReloaded/misc/LFC-passing-tests.txt:
726
727 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
728
729         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
730         https://bugs.webkit.org/show_bug.cgi?id=194140
731         <rdar://problem/47728098>
732
733         Reviewed by Tim Horton.
734
735         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
736         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
737         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
738
739         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
740         test to induce an IPC deadlock when presenting a modal alert during touch start.
741
742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
743         * WebKitTestRunner/TestController.cpp:
744         (WTR::runJavaScriptAlert):
745
746         Add a client callback function for running JavaScript alerts.
747
748         (WTR::TestController::createOtherPage):
749         (WTR::TestController::generateContextConfiguration const):
750
751         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
752         the fix in this patch.
753
754         (WTR::TestController::createWebViewWithOptions):
755
756         Plumb TestOptions to generateContextConfiguration.
757
758         (WTR::TestController::resetPreferencesToConsistentValues):
759         (WTR::TestController::resetStateToConsistentValues):
760         (WTR::updateTestOptionsFromTestHeader):
761         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
762         (WTR::TestController::handleJavaScriptAlert):
763         * WebKitTestRunner/TestController.h:
764         * WebKitTestRunner/TestInvocation.cpp:
765         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
766         * WebKitTestRunner/TestOptions.h:
767         (WTR::TestOptions::hasSameInitializationOptions const):
768
769 2019-02-01  Chris Dumez  <cdumez@apple.com>
770
771         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
772         https://bugs.webkit.org/show_bug.cgi?id=193740
773         <rdar://problem/47527267>
774
775         Reviewed by Alex Christensen.
776
777         Add API test coverage.
778
779         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
780
781 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
782
783         [ews-app] Add display name field to BuilderMapping model
784         https://bugs.webkit.org/show_bug.cgi?id=194153
785
786         Reviewed by Lucas Forschler.
787
788         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
789         (BuilderMapping):
790
791 2019-02-01  Youenn Fablet  <youenn@apple.com>
792
793         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
794         https://bugs.webkit.org/show_bug.cgi?id=194155
795
796         Reviewed by Eric Carlson.
797
798         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
799         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
800         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
801
802 2019-02-01  Zalan Bujtas  <zalan@apple.com>
803
804         [LFC] Adjust replaced element's intrinsic ratio
805         https://bugs.webkit.org/show_bug.cgi?id=194154
806
807         Reviewed by Antti Koivisto.
808
809         761
810
811         * LayoutReloaded/misc/LFC-passing-tests.txt:
812
813 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
814
815         [WPE] Show test results in minibrowser
816         https://bugs.webkit.org/show_bug.cgi?id=194150
817
818         Reviewed by Žan Doberšek.
819
820         * Scripts/webkitpy/port/wpe.py:
821         (WPEPort.show_results_html_file):
822
823 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
824
825         [WPE] MiniBrowser: add ky bindings for back/forward navigation
826         https://bugs.webkit.org/show_bug.cgi?id=194151
827
828         Reviewed by Žan Doberšek.
829
830         ALT + <- go back
831         ALT + -> go forward
832
833         * MiniBrowser/wpe/main.cpp:
834         (main):
835
836 2019-02-01  Zalan Bujtas  <zalan@apple.com>
837
838         [LFC] Set intrinsic size on Layout::Replaced
839         https://bugs.webkit.org/show_bug.cgi?id=194139
840
841         Reviewed by Antti Koivisto.
842
843         744
844
845         * LayoutReloaded/misc/LFC-passing-tests.txt:
846
847 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
848
849         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
850         https://bugs.webkit.org/show_bug.cgi?id=194146
851
852         Reviewed by Xabier Rodriguez-Calvar.
853
854         It allows to open relative paths.
855
856         * MiniBrowser/wpe/main.cpp:
857         (main):
858
859 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
860
861         Update flakiness dashboard configuration after recent queue changes
862         https://bugs.webkit.org/show_bug.cgi?id=194127
863
864         Rubber-stamped by Aakash Jain.
865
866         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
867
868         * TestResultServer/static-dashboards/builders.jsonp:
869
870 2019-01-31  Youenn Fablet  <youenn@apple.com>
871
872         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
873         https://bugs.webkit.org/show_bug.cgi?id=194106
874         <rdar://problem/47676333>
875
876         Reviewed by Ryosuke Niwa.
877
878         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
879         (TestWebKitAPI::didFinishNavigation):
880         (TestWebKitAPI::TEST):
881         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
882
883 2019-01-31  Chris Dumez  <cdumez@apple.com>
884
885         Page zoom level is lost after a process swap or a crash
886         https://bugs.webkit.org/show_bug.cgi?id=194105
887         <rdar://problem/47610781>
888
889         Reviewed by Alex Christensen.
890
891         Add API test coverage.
892
893         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
894         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
895
896 2019-01-31  Alex Christensen  <achristensen@webkit.org>
897
898         Revert r238819 which is unneeded and caused a performance regression.
899         https://bugs.webkit.org/show_bug.cgi?id=192272
900         <rdar://problem/46664625>
901
902         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
903         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
904         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
905
906 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
907
908         Formalize WebKitAdditions mechanism of LoadOptimizer
909         https://bugs.webkit.org/show_bug.cgi?id=193886
910         <rdar://problem/47696809>
911
912         Reviewed by Brent Fulgham.
913
914         * MiniBrowser/MiniBrowser.entitlements:
915         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
916
917 2019-01-31  Zalan Bujtas  <zalan@apple.com>
918
919         [LFC] Margin before/after/start/end initial value is 0 and not auto.
920         https://bugs.webkit.org/show_bug.cgi?id=194090
921
922         Reviewed by Antti Koivisto.
923
924         * LayoutReloaded/misc/LFC-passing-tests.txt:
925
926 2019-01-31  Zalan Bujtas  <zalan@apple.com>
927
928         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
929         https://bugs.webkit.org/show_bug.cgi?id=194074
930
931         Reviewed by Antti Koivisto.
932
933         * LayoutReloaded/misc/LFC-passing-tests.txt:
934
935 2019-01-31  Zalan Bujtas  <zalan@apple.com>
936
937         [LFC][BFC] Add support for block level replaced box.
938         https://bugs.webkit.org/show_bug.cgi?id=194071
939
940         Reviewed by Antti Koivisto.
941
942         * LayoutReloaded/misc/LFC-passing-tests.txt:
943
944 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
945
946         Fix WebKitTestRunner's testPath with Windows full paths
947         https://bugs.webkit.org/show_bug.cgi?id=194012
948
949         Reviewed by Alex Christensen.
950
951         updateTestOptionsFromTestHeader failed to open test files because
952         testPath returned wrong file paths. It returned a path "/C:/..."
953         if a URL "file:///C:/..." was given.
954
955         * WebKitTestRunner/TestController.cpp:
956         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
957
958 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
959
960         [WPE] Bump font related dependencies to match the GTK+ port
961         https://bugs.webkit.org/show_bug.cgi?id=194017
962
963         Reviewed by Žan Doberšek.
964
965         * wpe/jhbuild.modules:
966         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
967         * wpe/patches/icudata-stdlibs.patch: Added.
968
969 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
970
971         Enable swipe tests on iOS
972         https://bugs.webkit.org/show_bug.cgi?id=194076
973
974         Reviewed by Geoffrey Garen.
975
976         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
977         it causes a debug assertion failure in runUIScript.
978
979         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
980         (WTR::UIScriptController::beginBackSwipe):
981         (WTR::UIScriptController::completeBackSwipe):
982
983 2019-01-30  Keith Rollin  <krollin@apple.com>
984
985         Use correct printf format specifier
986         https://bugs.webkit.org/show_bug.cgi?id=194062
987         <rdar://problem/47686167>
988
989         Reviewed by Alexey Proskuryakov.
990
991         LayoutTestSpellChecker.mm is trying to format a variable of type
992         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
993         actually an unsigned long long. Fix this by formatting with %llu.
994
995         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
996         (-[LayoutTestTextCheckingResult description]):
997
998 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
999
1000         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1001         https://bugs.webkit.org/show_bug.cgi?id=193979
1002
1003         Reviewed by Wenson Hsieh.
1004
1005         Fix the test for iOS. Make the test work with iOS UA string.
1006
1007         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1008
1009 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1010
1011         Replace High Sierra LLINT CLoop bot due to hardware failure
1012         https://bugs.webkit.org/show_bug.cgi?id=194066
1013
1014         Reviewed by Aakash Jain.
1015
1016         * BuildSlaveSupport/build.webkit.org-config/config.json:
1017
1018 2019-01-30  Keith Rollin  <krollin@apple.com>
1019
1020         [NSDragItem init] is unavailable
1021         https://bugs.webkit.org/show_bug.cgi?id=194059
1022         <rdar://problem/47685715>
1023
1024         Reviewed by Wenson Hsieh.
1025
1026         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1027         DumpRenderTree and TestWebKitAPI, which both try to create an
1028         NSDragItem in a manner that invokes this method. Address this by using
1029         -initWithPasteboardWriter instead.
1030
1031         Note that the parameter passed to initWithPasteboardWriter is likely
1032         incorrect. In both cases, the object passed does not conform to
1033         NSPasteboardWriting. However, with this fix, we're no worse off than
1034         before, and can now perform builds with newer compilers and SDKs until
1035         a real fix can be crafted. That work is tracked in
1036         https://bugs.webkit.org/show_bug.cgi?id=194060
1037
1038         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1039         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1040         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1041         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1042
1043 2019-01-30  Daniel Bates  <dabates@apple.com>
1044
1045         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1046         https://bugs.webkit.org/show_bug.cgi?id=192824
1047         <rdar://problem/47100332>
1048
1049         Reviewed by Wenson Hsieh.
1050
1051         Fix a bug where the wrong usage code was used for F13 thru F24.
1052
1053         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1054         (keyCodeForDOMFunctionKey):
1055
1056 2019-01-30  Chris Dumez  <cdumez@apple.com>
1057
1058         Regression(PSON) Load hang can occur on history navigation
1059         https://bugs.webkit.org/show_bug.cgi?id=194030
1060         <rdar://problem/47656939>
1061
1062         Reviewed by Antti Koivisto.
1063
1064         Add API test coverage.
1065
1066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1067
1068 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1069
1070         [LFC] Expand tests coverage.
1071
1072         Unreviewed test gardening.
1073
1074         * LayoutReloaded/misc/LFC-passing-tests.txt:
1075
1076 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1077
1078         [Flatpak] Add openjpeg support
1079         https://bugs.webkit.org/show_bug.cgi?id=194019
1080
1081         Reviewed by Michael Catanzaro.
1082
1083         * flatpak/org.webkit.CommonModules.yaml:
1084
1085 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1086
1087         Unreviewed, rolling out r240708.
1088         https://bugs.webkit.org/show_bug.cgi?id=194022
1089
1090         It broke WPE build (Requested by KaL on #webkit).
1091
1092         Reverted changeset:
1093
1094         "[WPE] Bump font related dependencies to match the GTK+ port"
1095         https://bugs.webkit.org/show_bug.cgi?id=194017
1096         https://trac.webkit.org/changeset/240708
1097
1098 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1099
1100         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1101         https://bugs.webkit.org/show_bug.cgi?id=194001
1102
1103         Reviewed by Antti Koivisto.
1104
1105         * LayoutReloaded/misc/LFC-passing-tests.txt:
1106
1107 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1108
1109         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1110         https://bugs.webkit.org/show_bug.cgi?id=194020
1111
1112         Reviewed by Antti Koivisto.
1113
1114         * LayoutReloaded/misc/LFC-passing-tests.txt:
1115
1116 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1117
1118         AX: Support color well on iOS
1119         https://bugs.webkit.org/show_bug.cgi?id=194010
1120
1121         Reviewed by Joanmarie Diggs.
1122
1123         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1124         (WTR::AccessibilityUIElement::stringAttributeValue):
1125
1126 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1127
1128         [WPE] Bump font related dependencies to match the GTK+ port
1129         https://bugs.webkit.org/show_bug.cgi?id=194017
1130
1131         Reviewed by Žan Doberšek.
1132
1133         * wpe/jhbuild.modules:
1134         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1135         * wpe/patches/icudata-stdlibs.patch: Added.
1136
1137 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1138
1139         [Mac] Update window scale API usage
1140         https://bugs.webkit.org/show_bug.cgi?id=193991
1141         rdar://problem/47614795
1142
1143         Reviewed by Tim Horton.
1144
1145         * DumpRenderTree/mac/DumpRenderTree.mm:
1146         (changeWindowScaleIfNeeded):
1147         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1148         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1149         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1150
1151 2019-01-29  Chris Dumez  <cdumez@apple.com>
1152
1153         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1154         https://bugs.webkit.org/show_bug.cgi?id=193977
1155         <rdar://problem/47643716>
1156
1157         Reviewed by Geoff Garen.
1158
1159         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1160         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1161         to the previous provisional committing *before* we make the last load. 
1162
1163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1164
1165 2019-01-29  Youenn Fablet  <youenn@apple.com>
1166
1167         Adopt new SPI to evaluate server certificate trust
1168         https://bugs.webkit.org/show_bug.cgi?id=193355
1169
1170         Reviewed by Alex Christensen.
1171
1172         Add infrastructure to handle HTTPS server trust evaluation testing.
1173
1174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1176         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1177         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1178         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1180         * WebKitTestRunner/TestController.cpp:
1181         (WTR::TestController::resetPreferencesToConsistentValues):
1182         (WTR::TestController::didReceiveAuthenticationChallenge):
1183         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1184         * WebKitTestRunner/TestController.h:
1185         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1186         * WebKitTestRunner/TestInvocation.cpp:
1187         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1188         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1189         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1190
1191 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1192
1193         [ews-build] Add build step to print bot Configuration
1194         https://bugs.webkit.org/show_bug.cgi?id=193887
1195
1196         Reviewed by Lucas Forschler.
1197
1198         * BuildSlaveSupport/ews-build/steps.py:
1199         (PrintConfiguration): Build step to print configuration.
1200         * BuildSlaveSupport/ews-build/factories.py:
1201
1202 2019-01-29  Chris Dumez  <cdumez@apple.com>
1203
1204         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1205         https://bugs.webkit.org/show_bug.cgi?id=193967
1206         <rdar://problem/47635348>
1207
1208         Reviewed by Alex Christensen.
1209
1210         Add API test coverage.
1211
1212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1213         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1214
1215 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1216
1217         [ews-app] Handle incoming results data
1218         https://bugs.webkit.org/show_bug.cgi?id=193973
1219
1220         Reviewed by Lucas Forschler.
1221
1222         * BuildSlaveSupport/ews-app/ews/views/results.py:
1223
1224 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1225
1226         [ews-app] Make the results url generic
1227         https://bugs.webkit.org/show_bug.cgi?id=193928
1228
1229         Reviewed by Lucas Forschler.
1230
1231         * BuildSlaveSupport/ews-app/ews/urls.py:
1232
1233 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1234
1235         [ews-build] Configure buildbot to send events to ews-app
1236         https://bugs.webkit.org/show_bug.cgi?id=193968
1237
1238         Reviewed by Lucas Forschler.
1239
1240         * BuildSlaveSupport/ews-build/events.py: Added.
1241         * BuildSlaveSupport/ews-build/master.cfg:
1242
1243 2019-01-29  Keith Rollin  <krollin@apple.com>
1244
1245         Add .xcfilelists to Run Script build phases
1246         https://bugs.webkit.org/show_bug.cgi?id=193792
1247         <rdar://problem/47201785>
1248
1249         Reviewed by Alex Christensen.
1250
1251         As part of supporting XCBuild, update the necessary Run Script build
1252         phases in their Xcode projects to refer to their associated
1253         .xcfilelist files.
1254
1255         Note that the addition of these files bumps the Xcode project version
1256         number to something that's Xcode 10 compatible. This change means that
1257         older versions of the Xcode IDE can't read these projects. Nor can it
1258         fully load workspaces that refer to these projects (the updated
1259         projects are shown as non-expandable placeholders). `xcodebuild` can
1260         still build these projects; it's just that the IDE can't open them.
1261
1262         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1263         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1264
1265 2019-01-29  John Wilander  <wilander@apple.com>
1266
1267         Add data abstraction and validation for Ad Click Attribution
1268         https://bugs.webkit.org/show_bug.cgi?id=193916
1269         <rdar://problem/47603481>
1270
1271         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1272
1273         Ad click attribution has two steps. First, the storage of an ad
1274         campaign ID for a click that takes the user to a destination
1275         site. Second, a conversion on the destination site that can be
1276         attributed to the ad click.
1277
1278         This patch adds a class that represents a request for ad click
1279         attribution. Validation makes sure that the bits of entropy
1280         reported through this mechanism is limited.
1281
1282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1283         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1284         (TestWebKitAPI::TEST):
1285
1286 2019-01-29  Chris Dumez  <cdumez@apple.com>
1287
1288         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1289         https://bugs.webkit.org/show_bug.cgi?id=193932
1290         <rdar://problem/47598947>
1291
1292         Reviewed by Brady Eidson.
1293
1294         Add API test coverage.
1295
1296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1297
1298 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1299
1300         Adding new passing LFC tests.
1301
1302         Unreviewed test gardening.
1303
1304         * LayoutReloaded/misc/LFC-passing-tests.txt:
1305
1306 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1307
1308         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1309         https://bugs.webkit.org/show_bug.cgi?id=193964
1310
1311         Reviewed by Antti Koivisto.
1312
1313         * LayoutReloaded/misc/LFC-passing-tests.txt:
1314
1315 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1316
1317         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1318         https://bugs.webkit.org/show_bug.cgi?id=193954
1319
1320         Reviewed by Antti Koivisto.
1321
1322         * LayoutReloaded/misc/LFC-passing-tests.txt:
1323
1324 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1325
1326         WebDriver: add support for running subtests
1327         https://bugs.webkit.org/show_bug.cgi?id=193904
1328
1329         Reviewed by Michael Catanzaro.
1330
1331         pytest already supports it by passing test.py::subtest, so we can do the same.
1332
1333         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1334         (get_item_name): Made this global.
1335         (CollectRecorder.__init__): Receive the parameter to ignore.
1336         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1337         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1338         (collect): Add parameter to ignore.
1339         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1340         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1341         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1342         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1343         (WebDriverTestRunnerSelenium.run): Ditto.
1344         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1345         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1346         (WebDriverTestRunnerW3C.run): Ditto.
1347
1348 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1349
1350         User agent string override for navigator.userAgent should be site specific quirks
1351         https://bugs.webkit.org/show_bug.cgi?id=193950
1352
1353         Reviewed by Brent Fulgham.
1354
1355         Updated per the _WKWebsitePolicies rename.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1358         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1359
1360 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1361
1362         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1363         https://bugs.webkit.org/show_bug.cgi?id=193941
1364
1365         Reviewed by Alex Christensen.
1366
1367         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1368         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1369         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1370         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1371         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1372         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1373         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1374         * TestWebKitAPI/Tests/WTF/Time.cpp:
1375         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1376         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1377         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1378         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1379
1380 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1381
1382         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1383
1384         * Scripts/webkitpy/common/config/contributors.json:
1385
1386 2019-01-28  Andy Estes  <aestes@apple.com>
1387
1388         [watchOS] Enable Parental Controls content filtering
1389         https://bugs.webkit.org/show_bug.cgi?id=193939
1390         <rdar://problem/46641912>
1391
1392         Reviewed by Ryosuke Niwa.
1393
1394         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1395
1396 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1397
1398         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1399         <https://webkit.org/b/193884>
1400
1401         Reviewed by Jiewen Tan.
1402
1403         * Scripts/webkitpy/style/checkers/cpp.py:
1404         (check_language): Add LocalAuthentication to
1405         `frameworks_with_soft_links`.
1406
1407 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1408
1409         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1410         https://bugs.webkit.org/show_bug.cgi?id=193891
1411
1412         Reviewed by Ross Kirsling.
1413
1414         There were three problems in window sizes of WebView and the host window.
1415         1. The sizes of pixel image output were incorrect.
1416         2. The host window is going to appear after window.resize was invoked.
1417         3. window.resize resized only the host window, not WebView.
1418
1419         This change solves them with a following approach.
1420         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1421         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1422            as well as DumpRenderTree in order to match the client area and the window area.
1423         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1424         d. PlatformWebView::setWindowFrame changes both window sizes.
1425         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1426
1427         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1428         (WTR::PlatformWebView::PlatformWebView): Create the host window
1429         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1430         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1431         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1432
1433 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1434
1435         [ews-app] Add method to save Step data to database
1436         https://bugs.webkit.org/show_bug.cgi?id=193890
1437
1438         Reviewed by Lucas Forschler.
1439
1440         * BuildSlaveSupport/ews-app/ews/models/step.py:
1441         (Step.save_step): Method to save step data.
1442         (Step.update_step): Method to update step data.
1443         (Step.get_existing_step): Method to fetch existing step from database.
1444         (Step.is_valid_result): Method to validate valid step result.
1445
1446 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1447
1448         [ews-app] Add method to save Build data to database
1449         https://bugs.webkit.org/show_bug.cgi?id=193735
1450
1451         Reviewed by Lucas Forschler.
1452
1453         * BuildSlaveSupport/ews-app/ews/models/build.py:
1454         (Build.save_build): Method to save build information to database.
1455         (Build.get_existing_build): Method to fetch existing build from database.
1456         (Build.is_valid_result): Method to validate build result.
1457         * BuildSlaveSupport/ews-app/ews/common/util.py:
1458         (is_valid_int_id): Method to validate valid id.
1459
1460 2019-01-28  Chris Dumez  <cdumez@apple.com>
1461
1462         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1463         https://bugs.webkit.org/show_bug.cgi?id=193915
1464         <rdar://problem/47560907>
1465
1466         Reviewed by Alex Christensen.
1467
1468         Add API test coverage.
1469
1470         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1471
1472 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1473
1474         [ews-app] Rename id variables
1475         https://bugs.webkit.org/show_bug.cgi?id=193883
1476
1477         Reviewed by Lucas Forschler.
1478
1479         * BuildSlaveSupport/ews-app/ews/models/build.py:
1480         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1481         * BuildSlaveSupport/ews-app/ews/models/step.py:
1482         * BuildSlaveSupport/ews-app/ews/urls.py:
1483         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1484         * BuildSlaveSupport/ews-app/ews/views/results.py:
1485         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1486
1487 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1488
1489         [ews-app] Allow certain fields to be empty
1490         https://bugs.webkit.org/show_bug.cgi?id=193892
1491
1492         Reviewed by Lucas Forschler.
1493
1494         * BuildSlaveSupport/ews-app/ews/models/build.py:
1495         * BuildSlaveSupport/ews-app/ews/models/step.py:
1496
1497 2019-01-28  Rob Buis  <rbuis@igalia.com>
1498
1499         Update MIME type parser
1500         https://bugs.webkit.org/show_bug.cgi?id=180526
1501
1502         Reviewed by Frédéric Wang.
1503
1504         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1505         (TestWebKitAPI::TEST):
1506
1507 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1508
1509         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1510         https://bugs.webkit.org/show_bug.cgi?id=193896
1511
1512         Reviewed by Antti Koivisto.
1513
1514         * LayoutReloaded/misc/LFC-passing-tests.txt:
1515
1516 2018-12-15  Darin Adler  <darin@apple.com>
1517
1518         Replace many uses of String::format with more type-safe alternatives
1519         https://bugs.webkit.org/show_bug.cgi?id=192742
1520
1521         Reviewed by Mark Lam.
1522
1523         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1524         (WTR::cacheTestRunnerCallback): Use makeString.
1525         * WebKitTestRunner/TestController.cpp:
1526         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1527         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1528
1529 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1530
1531         Use a load optimizer for some sites
1532         https://bugs.webkit.org/show_bug.cgi?id=193881
1533         <rdar://problem/46325455>
1534
1535         Reviewed by Brent Fulgham.
1536
1537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1538         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1539
1540 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1541
1542         AX: Introduce a static accessibility tree
1543         https://bugs.webkit.org/show_bug.cgi?id=193348
1544         <rdar://problem/47203295>
1545
1546         Reviewed by Ryosuke Niwa.
1547
1548         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1549
1550 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1551
1552         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1553         https://bugs.webkit.org/show_bug.cgi?id=193867
1554
1555         Reviewed by Antti Koivisto.
1556
1557         * LayoutReloaded/misc/LFC-passing-tests.txt:
1558
1559 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1560
1561         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1562         https://bugs.webkit.org/show_bug.cgi?id=193865
1563
1564         Reviewed by Antti Koivisto.
1565
1566         * LayoutReloaded/misc/LFC-passing-tests.txt:
1567
1568 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1569
1570         Need a mechanism to override navigator.userAgent
1571         https://bugs.webkit.org/show_bug.cgi?id=193762
1572         <rdar://problem/47504939>
1573
1574         Reviewed by Brent Fulgham.
1575
1576         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1577
1578         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1579         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1580         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1581
1582 2019-01-25  Dean Jackson  <dino@apple.com>
1583
1584         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1585         https://bugs.webkit.org/show_bug.cgi?id=193831
1586         <rdar://problem/47399263>
1587
1588         Reviewed by Chris Dumez.
1589
1590         Two new tests that exercise cross-origin and same-origin System
1591         Previews.
1592
1593         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1594
1595 2019-01-25  Keith Rollin  <krollin@apple.com>
1596
1597         Update Xcode projects with "Check .xcfilelists" build phase
1598         https://bugs.webkit.org/show_bug.cgi?id=193790
1599         <rdar://problem/47201374>
1600
1601         Reviewed by Alex Christensen.
1602
1603         Support for XCBuild includes specifying inputs and outputs to various
1604         Run Script build phases. These inputs and outputs are specified as
1605         .xcfilelist files. Once created, these .xcfilelist files need to be
1606         kept up-to-date. In order to check that they are up-to-date or not,
1607         add an Xcode build step that invokes an external script that performs
1608         the checking. If the .xcfilelists are found to be out-of-date, update
1609         them, halt the build, and instruct the developer to restart the build
1610         with up-to-date files.
1611
1612         At this time, the checking and regenerating is performed only if the
1613         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1614         who want to use this facility can set this variable and test out the
1615         checking/regenerating. Once it seems like there are no egregious
1616         issues that upset a developer's workflow, we'll unconditionally enable
1617         this facility.
1618
1619         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1620         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1621         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1622         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1623
1624 2019-01-25  Keith Rollin  <krollin@apple.com>
1625
1626         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1627         https://bugs.webkit.org/show_bug.cgi?id=193781
1628         <rdar://problem/47201153>
1629
1630         Reviewed by Alex Christensen.
1631
1632         Part of generating the .xcfilelists used as part of adopting XCBuild
1633         includes running `make DerivedSources.make` from a standalone script.
1634         It’s important for this invocation to have the same environment as
1635         when the actual build invokes `make DerivedSources.make`. If the
1636         environments are different, then the two invocations will provide
1637         different results. In order to get the same environment in the
1638         standalone script, have the script launch xcodebuild targeting the
1639         "Apply Configuration to XCFileLists" build target, which will then
1640         re-invoke our standalone script. The script is now running again, this
1641         time in an environment with all workspace, project, target, xcconfig
1642         and other environment variables established.
1643
1644         The "Apply Configuration to XCFileLists" build target accomplishes
1645         this task via a small embedded shell script that consists only of:
1646
1647             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1648
1649         The process that invokes "Apply Configuration to XCFileLists" first
1650         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1651         evaluated and exports it into the shell environment. When xcodebuild
1652         is invoked, it inherits the value of this variable and can `eval` the
1653         contents of that variable. Our external standalone script can then set
1654         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1655         of command-line parameters needed to restart itself in the appropriate
1656         state.
1657
1658         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1659         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1660
1661 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1662
1663         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1664         https://bugs.webkit.org/show_bug.cgi?id=193802
1665         <rdar://problem/46010580>
1666
1667         Reviewed by Andy Estes.
1668
1669         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1670         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1671         (TEST):
1672
1673 2019-01-25  Daniel Bates  <dabates@apple.com>
1674
1675         [iOS] uiController.keyDown() does not translate Control modified key
1676         https://bugs.webkit.org/show_bug.cgi?id=192898
1677
1678         Reviewed by Wenson Hsieh.
1679
1680         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1681         key translation, as applicable. Among other cases, key translation occurs when performing
1682         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1683         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1684         human pressing down and releasing key(s) using a hardware keyboard.
1685
1686         * WebKitTestRunner/ios/HIDEventGenerator.h:
1687         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1688         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1689
1690         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1691         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1692         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1693         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1694         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1695         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1696         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1697         (-[HIDEventGenerator longPress:completionBlock:]):
1698         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1699         Update code for above renaming.
1700
1701         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1702         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1703
1704         (-[HIDEventGenerator keyDown:]): Added.
1705         (-[HIDEventGenerator keyUp:]): Added.
1706         (-[HIDEventGenerator keyPress:completionBlock:]):
1707         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1708         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1709         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1710         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1711         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1712         (WTR::parseModifier): Deleted.
1713
1714 2019-01-25  Keith Rollin  <krollin@apple.com>
1715
1716         Complete the implementation of generate-xcfilelists
1717         https://bugs.webkit.org/show_bug.cgi?id=193782
1718
1719         Reviewed by Alex Christensen.
1720
1721         A preliminary version of generate-xcfilelists was added in r238008.
1722         This patch updates that script in order to:
1723
1724         - Support checking of .xcfilelists
1725         - Perform better execution of `make DerivedSources.make` by
1726           relaunching generate-xcfilelists under xcodebuild
1727         - Support incremental generation and checking of .xcfilelists
1728         - Support supplementary .xcfilelists files from WebKitAdditions
1729         - Support being wrapped by parallel version of generate-xcfilelists in
1730           Internal that adds support for (re)generating WebKit projects in
1731           that repo.
1732         - Support builds that have been performed in WebKitBuild as well as
1733           ~/Library/Developer/code/DerivedData
1734         - Increase robustness and debugging facilities.
1735
1736         * Scripts/generate-xcfilelists:
1737
1738 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1739
1740         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1741         https://bugs.webkit.org/show_bug.cgi?id=193297
1742         <rdar://problem/47158841>
1743
1744         Unreviewed test case fix.
1745
1746         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1747         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1748
1749         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1750         (TEST):
1751
1752 2019-01-25  Keith Rollin  <krollin@apple.com>
1753
1754         Update existing .xcfilelists
1755         https://bugs.webkit.org/show_bug.cgi?id=193791
1756         <rdar://problem/47201706>
1757
1758         Reviewed by Alex Christensen.
1759
1760         Many .xcfilelist files were added in r238824 in order to support
1761         XCBuild. Update these with recent changes to the set of build files
1762         and with the current generate-xcfilelist script.
1763
1764         * DumpRenderTree/DerivedSources-input.xcfilelist:
1765         * DumpRenderTree/DerivedSources-output.xcfilelist:
1766         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1767         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1768
1769 2019-01-25  Keith Rollin  <krollin@apple.com>
1770
1771         Fix missing dependencies in extract-dependencies-from-makefile
1772         https://bugs.webkit.org/show_bug.cgi?id=193783
1773         <rdar://problem/47201571>
1774
1775         Reviewed by Alex Christensen.
1776
1777         The extract-dependencies-from-makefile script generates .xcfilelists
1778         for XCBuild by invoking a makefile in --debug mode, parsing the
1779         dependency information in the output, and extracting information
1780         regarding targets and dependents. However, the way `make` emits this
1781         dependency information is not rigorous, and so we need to determine
1782         what lines to look for and parse by trial and error. This approach
1783         didn't coriginally atch all the information we needed to collect, so
1784         update the script to look for the additional lines we now know to look
1785         for.
1786
1787         * Scripts/extract-dependencies-from-makefile:
1788         (Parser):
1789         (Parser.addTarget):
1790         (Parser.addPrereq):
1791         (Parser.doParse):
1792
1793 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1794
1795         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1796         https://bugs.webkit.org/show_bug.cgi?id=193297
1797         <rdar://problem/47158841>
1798
1799         Reviewed by Alex Christensen.
1800
1801         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1802             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1803         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1804         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1805         activating the message used to trigger the callback when it is set.
1806
1807 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1808
1809         WKWebView.goBack should reload if there is a safe browsing warning
1810         https://bugs.webkit.org/show_bug.cgi?id=193805
1811         <rdar://problem/46908216>
1812
1813         Reviewed by Geoff Garen.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1816         (+[Simple3LookupContext sharedLookupContext]):
1817         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1818         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1819         (TEST):
1820
1821 2019-01-25  Chris Dumez  <cdumez@apple.com>
1822
1823         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1824         https://bugs.webkit.org/show_bug.cgi?id=193788
1825         <rdar://problem/47531231>
1826
1827         Reviewed by Alex Christensen.
1828
1829         Add API test coverage.
1830
1831         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1832         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1833
1834 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1835
1836         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1837         https://bugs.webkit.org/show_bug.cgi?id=193771
1838
1839         Unreviewed infrastructure fix.
1840
1841         * Scripts/webkitpy/port/darwin.py:
1842         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1843
1844 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1845
1846         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1847
1848 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1849
1850         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1851
1852         * Scripts/webkitpy/common/config/contributors.json:
1853
1854 2019-01-25  Chris Dumez  <cdumez@apple.com>
1855
1856         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1857         https://bugs.webkit.org/show_bug.cgi?id=193779
1858         <rdar://problem/46170903>
1859
1860         Reviewed by Antti Koivisto.
1861
1862         Add API test that quickly navigates forward to a previous process without waiting for it to
1863         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1864         the process' previous page when reconnecting the it for the forward navigation.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1867
1868 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1869
1870         Need a way for JavaScript (or bundle) code to participate in undo
1871         https://bugs.webkit.org/show_bug.cgi?id=190009
1872         <rdar://problem/44807048>
1873
1874         Reviewed by Ryosuke Niwa.
1875
1876         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1877         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1878
1879         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1880         (WTR::UIScriptController::lastUndoLabel const):
1881         (WTR::UIScriptController::firstRedoLabel const):
1882         (WTR::UIScriptController::platformUndoManager const):
1883         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1884         (WTR::UIScriptController::lastUndoLabel const):
1885         (WTR::UIScriptController::firstRedoLabel const):
1886         (WTR::UIScriptController::platformUndoManager const):
1887         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1888         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1889         (WTR::UIScriptController::lastUndoLabel const):
1890         (WTR::UIScriptController::firstRedoLabel const):
1891         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1892         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1893         (WTR::UIScriptController::lastUndoLabel const):
1894         (WTR::UIScriptController::firstRedoLabel const):
1895         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1896         (WTR::UIScriptController::platformUndoManager const):
1897         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1898         (WTR::UIScriptController::platformUndoManager const):
1899
1900 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1901
1902         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1903         https://bugs.webkit.org/show_bug.cgi?id=193824
1904
1905         Reviewed by Antti Koivisto.
1906
1907         * LayoutReloaded/misc/LFC-passing-tests.txt:
1908
1909 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1910
1911         Update macOS JSC bot configurations
1912         https://bugs.webkit.org/show_bug.cgi?id=193739
1913
1914         Reviewed by Alexey Proskuryakov.
1915
1916         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1918         (BubbleQueueServer): Move JSC EWS to Mojave section.
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1920         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1921         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1922
1923 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1924
1925         [Win][WebKitTestRunner] Implement EventSenderProxy
1926         https://bugs.webkit.org/show_bug.cgi?id=193755
1927
1928         Reviewed by Don Olmstead.
1929
1930         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1931         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1932         (WTR::EventSenderProxy::dispatchMessage):
1933         (WTR::EventSenderProxy::EventSenderProxy):
1934         (WTR::EventSenderProxy::mouseDown):
1935         (WTR::EventSenderProxy::mouseUp):
1936         (WTR::EventSenderProxy::mouseMoveTo):
1937         (WTR::EventSenderProxy::mouseScrollBy):
1938         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1939
1940 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1941
1942         Unreviewed fix for API test failure after r240437.
1943
1944         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1945
1946         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1947
1948 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1949
1950         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1951         https://bugs.webkit.org/show_bug.cgi?id=193787
1952         <rdar://problem/47497634>
1953
1954         Reviewed by Alexey Proskuryakov.
1955
1956         * Scripts/webkitdirs.pm:
1957         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1958
1959 2019-01-24  Truitt Savell  <tsavell@apple.com>
1960
1961         Unreviewed, rolling out r240446.
1962
1963         Casued 5 API failures
1964
1965         Reverted changeset:
1966
1967         "Activate the WebResourceLoadStatisticsStore in the
1968         NetworkProcess and deactivate it in the UIProcess."
1969         https://bugs.webkit.org/show_bug.cgi?id=193297
1970         https://trac.webkit.org/changeset/240446
1971
1972 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1973
1974         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1975         https://bugs.webkit.org/show_bug.cgi?id=193741
1976         <rdar://problem/47135030>
1977
1978         Reviewed by Antti Koivisto and Simon Fraser.
1979
1980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1981         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1982         (TestWebKitAPI::TEST):
1983
1984 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1985
1986         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1987         https://bugs.webkit.org/show_bug.cgi?id=193297
1988         <rdar://problem/47158841>
1989
1990         Reviewed by Alex Christensen.
1991
1992         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1993         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1994         activating the message used to trigger the callback when it is set.
1995
1996 2019-01-24  John Wilander  <wilander@apple.com>
1997
1998         Add Ad Click Attribution as an internal/experimental feature
1999         https://bugs.webkit.org/show_bug.cgi?id=193685
2000         <rdar://problem/47450399>
2001
2002         Reviewed by Brent Fulgham.
2003
2004         Added test option adClickAttributionEnabled.
2005
2006         * DumpRenderTree/TestOptions.cpp:
2007         (TestOptions::TestOptions):
2008         * DumpRenderTree/TestOptions.h:
2009         * DumpRenderTree/mac/DumpRenderTree.mm:
2010         (setWebPreferencesForTestOptions):
2011
2012 2019-01-24  Antti Koivisto  <antti@apple.com>
2013
2014         [PSON] Flash on back navigation on Mac
2015         https://bugs.webkit.org/show_bug.cgi?id=193716
2016         <rdar://problem/47148458>
2017
2018         Reviewed by Chris Dumez.
2019
2020         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2021
2022         Closing of the previous page is delayed so waiting for didFinishNavigation is
2023         not sufficient to guarantee we have received all the messages. Wait for them.
2024
2025 2019-01-24  Chris Dumez  <cdumez@apple.com>
2026
2027         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2028         https://bugs.webkit.org/show_bug.cgi?id=193761
2029         <rdar://problem/47456405>
2030
2031         Reviewed by Alex Christensen.
2032
2033         Add API test coverage.
2034
2035         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2036
2037 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2038
2039         webkitpy: Missing PID in crashlog name should not be fatal
2040         https://bugs.webkit.org/show_bug.cgi?id=193771
2041
2042         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2043         of raising an exception.
2044
2045         Reviewed by Lucas Forschler.
2046
2047         * Scripts/webkitpy/port/darwin.py:
2048         (DarwinPort._merge_crash_logs):
2049
2050 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2051
2052         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2053         https://bugs.webkit.org/show_bug.cgi?id=193746
2054
2055         Reviewed by Youenn Fablet.
2056
2057         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2058         so we'd best just not call it.
2059
2060         * Scripts/webkitpy/w3c/test_exporter.py:
2061         (WebPlatformTestExporter.create_branch_with_patch):
2062
2063 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2064
2065         Move FileSystem to WTF
2066         https://bugs.webkit.org/show_bug.cgi?id=193602
2067
2068         Reviewed by Yusuke Suzuki.
2069
2070         * DumpRenderTree/win/DumpRenderTree.cpp:
2071         * TestWebKitAPI/CMakeLists.txt:
2072         * TestWebKitAPI/PlatformGTK.cmake:
2073         * TestWebKitAPI/PlatformJSCOnly.cmake:
2074         * TestWebKitAPI/PlatformPlayStation.cmake:
2075         * TestWebKitAPI/PlatformWPE.cmake:
2076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2077         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2078         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2079         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2080         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2081         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2082         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2083         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2084         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2085         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2086
2087 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2088
2089         [WPE] Remove hard dependency on subprocess32 for the API tests
2090
2091         Rubber-stamped by Carlos Garcia Campos.
2092
2093         * glib/api_test_runner.py:
2094         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2095         its presence only when running WPEQt tests.
2096
2097 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2098
2099         [GLIB] Expose JavaScriptCore options in GLib public API
2100         https://bugs.webkit.org/show_bug.cgi?id=188742
2101
2102         Reviewed by Michael Catanzaro.
2103
2104         Add a test for the new API.
2105
2106         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2107         (testsJSCOptions):
2108         (main):
2109
2110 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2111
2112         [GTK][WPE] Support JPEG 2000 images
2113         https://bugs.webkit.org/show_bug.cgi?id=186272
2114
2115         Reviewed by Žan Doberšek.
2116
2117         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2118
2119         * gtk/jhbuild.modules:
2120         * wpe/jhbuild.modules:
2121
2122 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2123
2124         check-webkit-style should warn when using soft-linking macros in a header
2125         <https://webkit.org/b/193750>
2126
2127         Reviewed by Darin Adler.
2128
2129         * Scripts/webkitpy/style/checkers/cpp.py:
2130         (check_language): Add softlink/header check by refactoring the
2131         softlink/framework check.
2132         (CppChecker): Enable softlink/header check by default.
2133         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2134         (CppStyleTest.test_softlink_framework): Rename from
2135         CppStyleTest.test_softlink() and change test framework name in
2136         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2137         files. Set file_name for macros that only appear in headers.
2138         (CppStyleTest.test_softlink_header): Add tests for using
2139         soft-link macros in headers.
2140
2141 2019-01-23  Chris Dumez  <cdumez@apple.com>
2142
2143         Deprecate API to limit the maximum number of WebProcesses
2144         https://bugs.webkit.org/show_bug.cgi?id=193725
2145         <rdar://problem/47464879>
2146
2147         Reviewed by Geoff Garen.
2148
2149         Update existing API tests to stop using deprecated API.
2150
2151         * MiniBrowser/mac/AppDelegate.m:
2152         (defaultConfiguration):
2153         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2158         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2159         (TEST):
2160         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2161         (TEST):
2162
2163 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2164
2165         [ews-app] Rename ews model buildermappings to buildermapping
2166         https://bugs.webkit.org/show_bug.cgi?id=193729
2167
2168         Reviewed by Lucas Forschler.
2169
2170         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2171         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2172         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2173
2174 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2175
2176         [ews-app] Rename ews model steps to step
2177         https://bugs.webkit.org/show_bug.cgi?id=193697
2178
2179         Reviewed by Lucas Forschler.
2180
2181         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2182         (Step): Renamed Steps to Step.
2183
2184 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2185
2186         Clean up IndexedDB files between tests
2187         https://bugs.webkit.org/show_bug.cgi?id=192796
2188         <rdar://problem/46824999>
2189
2190         Reviewed by Geoffrey Garen.
2191
2192         * DumpRenderTree/mac/DumpRenderTree.mm:
2193         (runTest):
2194         * WebKitTestRunner/TestController.cpp:
2195         (WTR::TestController::resetStateToConsistentValues):
2196         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2197         (WTR::RemoveAllIndexedDatabasesCallback):
2198         (WTR::TestController::ClearIndexedDatabases):
2199         * WebKitTestRunner/TestController.h:
2200         * WebKitTestRunner/TestInvocation.cpp:
2201         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2202
2203 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2204
2205         [ews-app] Rename ews model Builds to Build
2206         https://bugs.webkit.org/show_bug.cgi?id=193695
2207
2208         Reviewed by Lucas Forschler.
2209
2210         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2211         (Build): Renamed Builds to Build.
2212
2213 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2214
2215         webkitpy: Wait longer when launching WebKitTestRunner
2216         https://bugs.webkit.org/show_bug.cgi?id=193734
2217
2218         Reviewed by Aakash Jain.
2219
2220         * Scripts/webkitpy/port/simulator_process.py:
2221         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2222
2223 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2224
2225         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2226         https://bugs.webkit.org/show_bug.cgi?id=193182
2227         <rdar://problem/47452154>
2228
2229         Reviewed by Tim Horton.
2230
2231         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2232         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2233         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2234
2235         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2236         preventing later tests from recognizing gestures.
2237
2238         * WebKitTestRunner/ios/TestControllerIOS.mm:
2239         (WTR::TestController::platformResetStateToConsistentValues):
2240
2241         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2242
2243 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2244
2245         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2246         https://bugs.webkit.org/show_bug.cgi?id=193722
2247         <rdar://problem/47481475>
2248
2249         Reviewed by Lucas Forschler.
2250
2251         iPhone and iPad ports should both use the iOS config.
2252
2253         * Scripts/webkitpy/port/ios_simulator.py:
2254         (IPhoneSimulatorPort.__init__):
2255         (IPadSimulatorPort.__init__):
2256
2257 2019-01-23  Rob Buis  <rbuis@igalia.com>
2258
2259         Update MIME type parser
2260         https://bugs.webkit.org/show_bug.cgi?id=180526
2261
2262         Reviewed by Frédéric Wang.
2263
2264         Add unit tests for both parse modes of ParsedContentType.
2265
2266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2267         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2268         (TestWebKitAPI::TEST):
2269
2270 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2271
2272         [ews-app] fetch loop should not stop on network issues
2273         https://bugs.webkit.org/show_bug.cgi?id=193666
2274
2275         Reviewed by Lucas Forschler.
2276
2277         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2278         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2279
2280 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2281
2282         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2283         https://bugs.webkit.org/show_bug.cgi?id=189165
2284         <rdar://problem/47433765>
2285
2286         Reviewed by Tim Horton.
2287
2288         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2289         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2290         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2291         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2292         would make its way to the UI process by the time the layer tree commit is finished.
2293
2294         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2295         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2296         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2297         will fail because it asks for -_autofillContext too early.
2298
2299         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2300         is handled in the UI process.
2301
2302         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2303
2304         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2305         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2306         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2307         input session.
2308
2309         (-[AutofillTestView textInputHasAutofillContext]):
2310
2311         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2312
2313         * TestWebKitAPI/cocoa/TestWKWebView.h:
2314         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2315         (nextInputSessionChangeCount):
2316
2317         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2318         This includes changing the focused element from one to another.
2319
2320         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2321         (-[TestWKWebView didStartFormControlInteraction]):
2322         (-[TestWKWebView didEndFormControlInteraction]):
2323         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2324
2325         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2326         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2327         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2328         that doesn't require an input session to one that doesn't.
2329
2330 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2331
2332         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2333         <https://webkit.org/b/193676>
2334
2335         Reviewed by Alexey Proskuryakov.
2336
2337         * Scripts/webkitpy/style/checkers/cpp.py:
2338         (check_member_initialization_list):
2339         - Don't report missing whitespace around colon if the colon at
2340           the start of the line is formatted correctly.
2341         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2342         (WebKitStyleTest.test_member_initialization_list):
2343         - Add a test for a missing permutation of existing tests.
2344         - Add a test this false-positive.
2345         - Add blank lines between subtests to make them easier to read.
2346
2347 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2348
2349         [build.webkit.org] Unit-test failure after r237113
2350         https://bugs.webkit.org/show_bug.cgi?id=193669
2351
2352         Reviewed by Michael Catanzaro.
2353
2354         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2355         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2356         multiple or zero flags.
2357
2358 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2359
2360         Cache bytecode to disk
2361         https://bugs.webkit.org/show_bug.cgi?id=192782
2362         <rdar://problem/46084932>
2363
2364         Reviewed by Keith Miller.
2365
2366         Add test helper to execute bytecode-cache tests: it executes each test
2367         twice, the first with JSC_diskCachePath set to a temporary directory
2368         and second with JSC_forceDiskCache=true (in addition to the cache path)
2369         to guarantee that only the disk cache is being used and no new
2370         UnlinkedCodeBlocks are being created.
2371
2372         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2373         * Scripts/run-jsc-stress-tests:
2374
2375 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2376
2377         [css-logical] Implement flow-relative margin, padding and border shorthands
2378         https://bugs.webkit.org/show_bug.cgi?id=188697
2379
2380         Reviewed by Simon Fraser and Antti Koivisto.
2381
2382         * DumpRenderTree/TestOptions.cpp:
2383         (TestOptions::TestOptions):
2384         * DumpRenderTree/TestOptions.h:
2385         * DumpRenderTree/mac/DumpRenderTree.mm:
2386         (setWebPreferencesForTestOptions):
2387         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2388
2389         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2390         (JSONCSSPropertiesChecker.check_codegen_properties):
2391         Allow CSS property definitions to have a 'runtime-flag' parameter which
2392         disables the property when the specified runtime flag is disabled.
2393
2394 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2395
2396         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2397         https://bugs.webkit.org/show_bug.cgi?id=193643
2398
2399         Reviewed by Michael Catanzaro.
2400
2401         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2402         * wpe/jhbuild.modules: Ditto.
2403
2404 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2405
2406         [LFC][Floats] Take float top position into account when computing containing block height.
2407         https://bugs.webkit.org/show_bug.cgi?id=193655
2408
2409         Reviewed by Antti Koivisto.
2410
2411         * LayoutReloaded/misc/LFC-passing-tests.txt:
2412
2413 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2414
2415         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2416         <https://webkit.org/b/193645>
2417         <rdar://problem/47421574>
2418
2419         Reviewed by Alex Christensen.
2420
2421         - Now checks for local soft-linking of all frameworks that have
2422           their own *SoftLinking.{cpp,h,mm} files.
2423         - Changes softlink/uikit warning to softlink/framework.
2424
2425         * Scripts/webkitpy/style/checkers/cpp.py:
2426         (check_language):
2427         (CppChecker):
2428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2429         (CppStyleTest):
2430
2431 2019-01-20  Saam Barati  <sbarati@apple.com>
2432
2433         Rollout r240210: It broke tests on iOS
2434         https://bugs.webkit.org/show_bug.cgi?id=193640
2435
2436         Unreviewed.
2437
2438         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2439         * Scripts/run-jsc-stress-tests:
2440
2441 2019-01-20  chris fleizach  <cfleizach@apple.com>
2442
2443         AX: Support returning relative frames for accessibility
2444         https://bugs.webkit.org/show_bug.cgi?id=193414
2445         <rdar://problem/47268501>
2446
2447         Reviewed by Zalan Bujtas.
2448
2449         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2450         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2451         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2452         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2453         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2454         (WTR::attributesOfElement):
2455         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2456
2457 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2458
2459         Unreviewed, add my new email address
2460
2461         * Scripts/webkitpy/common/config/contributors.json:
2462
2463 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2464
2465         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2466         https://bugs.webkit.org/show_bug.cgi?id=193617
2467
2468         Reviewed by Antti Koivisto.
2469
2470         * LayoutReloaded/misc/LFC-passing-tests.txt:
2471
2472 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2473
2474         Unreviewed, rolling out r240209.
2475
2476         Broke GTK/WPE injected bundle
2477
2478         Reverted changeset:
2479
2480         "AX: Support returning relative frames for accessibility"
2481         https://bugs.webkit.org/show_bug.cgi?id=193414
2482         https://trac.webkit.org/changeset/240209
2483
2484 2019-01-12  Dan Bernstein  <mitz@apple.com>
2485
2486         [Cocoa] Avoid importing directly from subumbrella frameworks
2487         https://bugs.webkit.org/show_bug.cgi?id=186016
2488         <rdar://problem/40591038>
2489
2490         Reviewed by Sam Weinig.
2491
2492         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2493           LaunchServices header.
2494         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2495           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2496         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2497           when using SDKs earlier than 10.13.
2498         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2499           and OTHER_CPLUSPLUSFLAGS.
2500         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2501           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2502         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2503           LaunchServices header.
2504
2505 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2506
2507         Cache bytecode to disk
2508         https://bugs.webkit.org/show_bug.cgi?id=192782
2509         <rdar://problem/46084932>
2510
2511         Reviewed by Keith Miller.
2512
2513         Add test helper to execute bytecode-cache tests: it executes each test
2514         twice, the first with JSC_diskCachePath set to a temporary directory
2515         and second with JSC_forceDiskCache=true (in addition to the cache path)
2516         to guarantee that only the disk cache is being used and no new
2517         UnlinkedCodeBlocks are being created.
2518
2519         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2520         * Scripts/run-jsc-stress-tests:
2521
2522 2019-01-20  chris fleizach  <cfleizach@apple.com>
2523
2524         AX: Support returning relative frames for accessibility
2525         https://bugs.webkit.org/show_bug.cgi?id=193414
2526         <rdar://problem/47268501>
2527
2528         Reviewed by Zalan Bujtas.
2529
2530         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2531         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2532         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2533         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2534         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2535         (WTR::attributesOfElement):
2536         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2537
2538 2019-01-20  Antoine Quint  <graouts@apple.com>
2539
2540         Add a POINTER_EVENTS feature flag
2541         https://bugs.webkit.org/show_bug.cgi?id=193577
2542         <rdar://problem/47408511>
2543
2544         Unreviewed. Also enable Pointer Events for iosmac.
2545
2546         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2547
2548 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2549
2550         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2551         https://bugs.webkit.org/show_bug.cgi?id=193613
2552
2553         Reviewed by Antti Koivisto.
2554
2555         * LayoutReloaded/misc/LFC-passing-tests.txt:
2556
2557 2019-01-19  Antoine Quint  <graouts@apple.com>
2558
2559         Add a POINTER_EVENTS feature flag
2560         https://bugs.webkit.org/show_bug.cgi?id=193577
2561
2562         Reviewed by Dean Jackson.
2563
2564         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2565
2566 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2567
2568         Disable the run-jsc-stress-test remote host key check [second round].
2569         https://bugs.webkit.org/show_bug.cgi?id=192988
2570
2571         Reviewed by Dewei Zhu.
2572
2573         * Scripts/run-jsc-stress-tests:
2574
2575 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2576
2577         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2578         https://bugs.webkit.org/show_bug.cgi?id=193597
2579
2580         Reviewed by Lucas Forschler.
2581
2582         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2583
2584 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2585
2586         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2587         https://bugs.webkit.org/show_bug.cgi?id=193595
2588
2589         Reviewed by Lucas Forschler.
2590
2591         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2592         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2593         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2594
2595 2019-01-18  Chris Dumez  <cdumez@apple.com>
2596
2597         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2598         https://bugs.webkit.org/show_bug.cgi?id=193588
2599         <rdar://problem/47131566>
2600
2601         Reviewed by Alex Christensen.
2602
2603         Add layout test coverage.
2604
2605         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2606
2607 2019-01-18  Jer Noble  <jer.noble@apple.com>
2608
2609         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2610         https://bugs.webkit.org/show_bug.cgi?id=189553
2611
2612         Reviewed by Tim Horton.
2613
2614         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2615
2616         * ContentExtensionTester/Configurations/Base.xcconfig:
2617         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2618         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2619         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2620         * ImageDiff/cg/Configurations/Base.xcconfig:
2621         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2622         * MiniBrowser/Configurations/Base.xcconfig:
2623         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2624         * MobileMiniBrowser/Configurations/Base.xcconfig:
2625         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2626         * Scripts/webkitpy/style/checker.py:
2627         (_all_categories):
2628         (FileType):
2629         (CheckerDispatcher._file_type):
2630         (CheckerDispatcher._create_checker):
2631         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2632         (SDKVariantChecker):
2633         (SDKVariantChecker.__init__):
2634         (SDKVariantChecker.check):
2635         * TestWebKitAPI/Configurations/Base.xcconfig:
2636         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2637         * WebEditingTester/Configurations/Base.xcconfig:
2638         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2639         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2640         * WebKitTestRunner/Configurations/Base.xcconfig:
2641         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2642         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2643         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2644
2645 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2646
2647         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2648         <https://webkit.org/b/193568>
2649         <rdar://problem/47381130>
2650
2651         Reviewed by Alex Christensen.
2652
2653         Make sure no one re-introduces UIKit soft-linking by adding a
2654         style rule.
2655
2656         * Scripts/webkitpy/style/checkers/cpp.py:
2657         (check_language): Add softlink/uikit check.
2658         (CppChecker): Enable softlink/uikit check.
2659         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2660         (CppStyleTest): Add test for softlink/uikit.
2661
2662 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2663
2664         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2665         https://bugs.webkit.org/show_bug.cgi?id=193584
2666
2667         Change "-dev" to "-devel".
2668
2669         Reviewed by Michael Catanzaro.
2670
2671         * gtk/install-dependencies:
2672
2673 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2674
2675         webkitpy: Add iPhone and iPad ports
2676         https://bugs.webkit.org/show_bug.cgi?id=193537
2677         <rdar://problem/47353390>
2678
2679         Reviewed by Lucas Forschler.
2680
2681         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2682         ports. Note that this separation is optional, the --ios-simulator command remains.
2683
2684         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2685         (RunTest.test_device_type_test_division): Drive-by fix.
2686         (RunTest.test_device_type_specific_listing): Ditto.
2687         (RunTest.test_ipad_test_division):
2688         (RunTest):
2689         (RunTest.test_ipad_listing):
2690         * Scripts/webkitpy/port/factory.py:
2691         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2692         (PortFactory):
2693         * Scripts/webkitpy/port/ios_simulator.py:
2694         (IPhoneSimulatorPort):
2695         (IPadSimulatorPort):
2696
2697 2019-01-18  Chris Dumez  <cdumez@apple.com>
2698
2699         Regression(PSON) Scroll position is not always restored properly when navigating back
2700         https://bugs.webkit.org/show_bug.cgi?id=193578
2701         <rdar://problem/47386331>
2702
2703         Reviewed by Tim Horton.
2704
2705         Add API test coverage.
2706
2707         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2708
2709 2019-01-18  Youenn Fablet  <youenn@apple.com>
2710
2711         Add a new SPI to request for cache storage quota increase
2712         https://bugs.webkit.org/show_bug.cgi?id=193323
2713
2714         Reviewed by Alex Christensen.
2715
2716         Implement WebsiteDataStore quota delegate to handle quota requests.
2717         By default, do not update quota.
2718         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2719
2720         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2722         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2723         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2724         * WebKitTestRunner/TestController.cpp:
2725         (WTR::TestController::allowCacheStorageQuotaIncrease):
2726         * WebKitTestRunner/TestController.h:
2727         * WebKitTestRunner/TestInvocation.cpp:
2728         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2729         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2730         (-[CacheStorageQuotaManager init]):
2731         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2732         (WTR::initializeWebViewConfiguration):
2733         (WTR::TestController::cocoaResetStateToConsistentValues):
2734         (WTR::TestController::allowCacheStorageQuotaIncrease):
2735
2736 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2737
2738         [ews-build] Pass owner to the triggered builds
2739         https://bugs.webkit.org/show_bug.cgi?id=193574
2740
2741         Reviewed by Lucas Forschler.
2742
2743         * BuildSlaveSupport/ews-build/factories.py:
2744         (BuildFactory.propertiesToPassToTriggers):
2745
2746 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2747
2748         [ews-app] Send patch author as a build property
2749         https://bugs.webkit.org/show_bug.cgi?id=193560
2750
2751         Reviewed by Lucas Forschler.
2752
2753         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2754         (BugzillaPatchFetcher.fetch):
2755
2756 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2757
2758         webkitpy: Implement device type specific expected results (Follow-up fix)
2759         https://bugs.webkit.org/show_bug.cgi?id=192162
2760         <rdar://problem/46345449>
2761
2762         Unreviewed infrastructure fix.
2763
2764         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2765         (Manager.run): Don't boot a device if no tests are available to run on it.
2766
2767 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2768
2769         webkitpy: Implement device type specific expected results (Follow-up fix)
2770         https://bugs.webkit.org/show_bug.cgi?id=192162
2771         <rdar://problem/46345449>
2772
2773         Unreviewed infrastructure fix.
2774
2775         * Scripts/webkitpy/api_tests/manager.py:
2776         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2777
2778 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2779
2780         webkitpy: Implement device type specific expected results (Part 2)
2781         https://bugs.webkit.org/show_bug.cgi?id=192162
2782         <rdar://problem/46345449>
2783
2784         Rubber-stamped by Aakash Jain.
2785
2786         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2787         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2788         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2789
2790         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2791         (LayoutTestFinder.find_tests): Pass device_type through.
2792         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2793         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2794         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2795         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2796         (Manager._collect_tests): Pass device type to test finder.
2797         (Manager._needs_web_platform_test):
2798         (Manager._prepare_lists): Index _expectations by device type.
2799         (Manager._test_input_for_file):
2800         (Manager._test_is_slow): Ditto.
2801         (Manager._test_should_dump_jsconsolelog_in_stderr):
2802         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2803         (Manager._get_test_inputs):
2804         (Manager._update_worker_count):
2805         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2806         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2807         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2808         the one which runs the test.
2809         (Manager._run_test_subset):
2810         (Manager._run_tests): Index _expectations by current_device_type.
2811         (Manager._print_expectation_line_for_test): Ditto.
2812         (Manager._print_expectations_for_subset): Ditto.
2813         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2814         Unlike run, this function will behave the same regardless of what devices are available.
2815         (Manager._custom_device_for_test): Deleted.
2816         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2817         (ManagerTest.test_uses_custom_device): Deleted.
2818         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2819         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2820         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2821         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2822         all of the expectations.
2823         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2824         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2825         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2826         (TestExpectations.__init__): Allow device_type to be passed through.
2827         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2828         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2829         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2830         (summarize_results):
2831         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2832         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2833         a test ran with, one must check all expectations to find the first non-skip expectation.
2834         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2835         (RunTest.test_device_type_test_division):
2836         (RunTest):
2837         (RunTest.test_device_type_specific_listing):
2838         * Scripts/webkitpy/port/base.py:
2839         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2840         (Port.supported_device_types): The result of this function will change based on what devices are available.
2841         * Scripts/webkitpy/port/device_port.py:
2842         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2843         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2844         can be used.
2845         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2846         any, or the DEFAULT_DEVICE_TYPES of the port.
2847         * Scripts/webkitpy/port/ios.py:
2848         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2849         * Scripts/webkitpy/port/ios_simulator.py:
2850         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2851         * Scripts/webkitpy/port/watch.py:
2852         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2853         * Scripts/webkitpy/port/watch_simulator.py:
2854         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2855         * Scripts/webkitpy/xcode/device_type.py:
2856         (DeviceType):
2857         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2858
2859 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2860
2861         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2862         https://bugs.webkit.org/show_bug.cgi?id=193575
2863
2864         Reviewed by Michael Catanzaro.
2865
2866         Allow the script to run without explicit port argument because
2867         it's specific to the WPE port anyway.
2868
2869         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2870         and simplify the rest of the code accordingly.
2871
2872 2019-01-18  Charlie Turner  <cturner@igalia.com>
2873
2874         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2875         https://bugs.webkit.org/show_bug.cgi?id=192229
2876
2877         Reviewed by Xabier Rodriguez-Calvar.
2878
2879         * MiniBrowser/wpe/main.cpp:
2880         (main): Enable encrypted-media by default.
2881
2882 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2883
2884         [Flatpak] Missing KeyboardInterrupt exception handler
2885         https://bugs.webkit.org/show_bug.cgi?id=193570
2886
2887         Reviewed by Michael Catanzaro.
2888
2889         * flatpak/flatpakutils.py:
2890         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2891
2892 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2893
2894         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2895         https://bugs.webkit.org/show_bug.cgi?id=193564
2896
2897         Reviewed by Antti Koivisto.
2898
2899         * LayoutReloaded/misc/LFC-passing-tests.txt:
2900
2901 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2902
2903         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2904         https://bugs.webkit.org/show_bug.cgi?id=193562
2905
2906         Reviewed by Antti Koivisto.
2907
2908         * LayoutReloaded/misc/LFC-passing-tests.txt:
2909
2910 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2911
2912         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2913         https://bugs.webkit.org/show_bug.cgi?id=193555
2914
2915         Reviewed by Antti Koivisto.
2916
2917         * LayoutReloaded/misc/LFC-passing-tests.txt:
2918
2919 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2920
2921         [WPE] Add Qt extension
2922         https://bugs.webkit.org/show_bug.cgi?id=191464
2923
2924         Reviewed by Carlos Garcia Campos.
2925
2926         MiniBrowser and API tests for the WPE Qt API. To run the
2927         MiniBrowser a new script is introduced. Example invocation:
2928
2929         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2930
2931         Also note-worthy is the introduction of the python2-subprocess32
2932         dependency to run the GLib API tests.
2933
2934         * MiniBrowser/wpe/CMakeLists.txt:
2935         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2936         * MiniBrowser/wpe/qt/main.cpp: Added.
2937         (main):
2938         * MiniBrowser/wpe/qt/main.qml: Added.
2939         * MiniBrowser/wpe/qt/qml.qrc: Added.
2940         * Scripts/run-gtk-tests:
2941         (GtkTestRunner.is_google_test):
2942         (GtkTestRunner):
2943         (GtkTestRunner.is_qt_test):
2944         * Scripts/run-qt-wpe-minibrowser: Added.
2945         * Scripts/run-wpe-tests:
2946         (WPETestRunner):
2947         (WPETestRunner.is_google_test):
2948         (WPETestRunner.is_qt_test):
2949         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2950         (TestLoad::main):
2951         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2952         (TestLoadHtml::main):
2953         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2954         (TestLoadRequest::main):
2955         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2956         (TestRunJavaScript::main):
2957         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2958         (waitForSignal):
2959         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2960         (LoadSpy::LoadSpy):
2961         (LoadSpy::~LoadSpy):
2962         (LoadSpy::onLoadingChanged):
2963         (LoadStartedCatcher::LoadStartedCatcher):
2964         (LoadStartedCatcher::~LoadStartedCatcher):
2965         (LoadStartedCatcher::onLoadingChanged):
2966         (waitForLoadSucceeded):
2967         (waitForLoadFailed):
2968         * TestWebKitAPI/glib/CMakeLists.txt:
2969         * flatpak/flatpakutils.py:
2970         (WebkitFlatpak.load_from_args):
2971         (WebkitFlatpak.__init__):
2972         (WebkitFlatpak.clean_args):
2973         (WebkitFlatpak.run_in_sandbox):
2974         * flatpak/org.webkit.CommonModules.yaml:
2975         * flatpak/org.webkit.WPE.yaml:
2976         * flatpak/org.webkit.WPEModules.yaml:
2977         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2978         * flatpak/org.webkit.WebKit.yaml:
2979         * glib/api_test_runner.py:
2980         (TestRunner._run_test_qt):
2981         (TestRunner.is_qt_test):
2982         (TestRunner._run_test):
2983
2984 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2985
2986         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2987         https://bugs.webkit.org/show_bug.cgi?id=193494
2988         <rdar://problem/46859627>
2989
2990         Reviewed by Simon Fraser and Tim Horton.
2991
2992         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2993         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2994
2995         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2996         (WTR::UIScriptController::contentOffsetX const):
2997         (WTR::UIScriptController::contentOffsetY const):
2998         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2999         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3000         (WTR::UIScriptController::contentOffsetX const):
3001         (WTR::UIScriptController::contentOffsetY const):
3002         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3003
3004         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3005
3006         * WebKitTestRunner/TestController.cpp:
3007         (WTR::updateTestOptionsFromTestHeader):
3008         * WebKitTestRunner/TestOptions.h:
3009         (WTR::TestOptions::hasSameInitializationOptions const):
3010         * WebKitTestRunner/ios/TestControllerIOS.mm:
3011         (WTR::TestController::platformResetStateToConsistentValues):
3012         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3013         (WTR::UIScriptController::contentOffsetX const):
3014         (WTR::UIScriptController::contentOffsetY const):
3015
3016 2019-01-17  Truitt Savell  <tsavell@apple.com>
3017
3018         Unreviewed, rolling out r240124.
3019
3020         This commit broke an internal build.
3021
3022         Reverted changeset:
3023
3024         "SDK_VARIANT build destinations should be separate from non-
3025         SDK_VARIANT builds"
3026         https://bugs.webkit.org/show_bug.cgi?id=189553
3027         https://trac.webkit.org/changeset/240124
3028
3029 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3030
3031         Fix string concatenation API test after r239920
3032         https://bugs.webkit.org/show_bug.cgi?id=193551
3033         <rdar://problem/47359304>
3034
3035         Reviewed by Youenn Fablet.
3036
3037         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3038         (TestWebKitAPI::TEST):
3039         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3040         in WebKit's build configuration like it apparently is on Linux.
3041
3042 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3043
3044         [ews-build] validate-patch should handle the case when bug_id is None
3045         https://bugs.webkit.org/show_bug.cgi?id=193547
3046
3047         Reviewed by Lucas Forschler.
3048
3049         * BuildSlaveSupport/ews-build/steps.py:
3050         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3051         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3052
3053 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3054
3055         [ews-build] Add patch author information in build
3056         https://bugs.webkit.org/show_bug.cgi?id=193465
3057
3058         Reviewed by Lucas Forschler.
3059
3060         * BuildSlaveSupport/ews-build/steps.py:
3061         (ValidatePatch._is_patch_obsolete):
3062
3063 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3064
3065         [ews-build] Pass bug_id to the triggered builds
3066         https://bugs.webkit.org/show_bug.cgi?id=193548
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * BuildSlaveSupport/ews-build/factories.py:
3071         (BuildFactory.propertiesToPassToTriggers):
3072
3073 2019-01-17  Jer Noble  <jer.noble@apple.com>
3074
3075         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3076         https://bugs.webkit.org/show_bug.cgi?id=189553
3077
3078         Reviewed by Tim Horton.
3079
3080         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3081
3082         * ContentExtensionTester/Configurations/Base.xcconfig:
3083         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3084         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3085         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3086         * ImageDiff/cg/Configurations/Base.xcconfig:
3087         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3088         * MiniBrowser/Configurations/Base.xcconfig:
3089         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3090         * MobileMiniBrowser/Configurations/Base.xcconfig:
3091         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3092         * Scripts/webkitpy/style/checker.py:
3093         (_all_categories):
3094         (FileType):
3095         (CheckerDispatcher._file_type):
3096         (CheckerDispatcher._create_checker):
3097         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3098         (SDKVariantChecker):
3099         (SDKVariantChecker.__init__):
3100         (SDKVariantChecker.check):
3101         * TestWebKitAPI/Configurations/Base.xcconfig:
3102         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3103         * WebEditingTester/Configurations/Base.xcconfig:
3104         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3105         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3106         * WebKitTestRunner/Configurations/Base.xcconfig:
3107         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3108         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3109         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3110
3111 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3112
3113         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3114         https://bugs.webkit.org/show_bug.cgi?id=193534
3115
3116         Reviewed by Antti Koivisto.
3117
3118         * LayoutReloaded/misc/LFC-passing-tests.txt:
3119
3120 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3121
3122         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3123         https://bugs.webkit.org/show_bug.cgi?id=193528
3124
3125         Reviewed by Antti Koivisto.
3126
3127         * LayoutReloaded/misc/LFC-passing-tests.txt:
3128
3129 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3130
3131         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3132         https://bugs.webkit.org/show_bug.cgi?id=193520
3133
3134         Reviewed by Antti Koivisto.
3135
3136         * LayoutReloaded/misc/LFC-passing-tests.txt:
3137
3138 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3139
3140         [ews-build] unapply-patch step should not update source
3141         https://bugs.webkit.org/show_bug.cgi?id=193234
3142
3143         Reviewed by Lucas Forschler.
3144
3145         * BuildSlaveSupport/ews-build/steps.py:
3146         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3147         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3148
3149 2019-01-16  Youenn Fablet  <youenn@apple.com>
3150
3151         Add a new SPI for controlling getUserMedia
3152         https://bugs.webkit.org/show_bug.cgi?id=192793
3153
3154         Reviewed by Eric Carlson.
3155
3156         * MiniBrowser/mac/WK2BrowserWindowController.m:
3157         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3158         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3159         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3160         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3161         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3162         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3163         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3164         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3165         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3166         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3167         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3168         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3169         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3170         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3171
3172 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3173
3174         [LFC][BFC] Inflow non-replaced used width should not be negative.
3175         https://bugs.webkit.org/show_bug.cgi?id=193495
3176
3177         Reviewed by Antti Koivisto.
3178
3179         * LayoutReloaded/misc/LFC-passing-tests.txt:
3180
3181 2019-01-16  Chris Dumez  <cdumez@apple.com>
3182
3183         Regression(PSON) View becomes blank after click a cross-site download link
3184         https://bugs.webkit.org/show_bug.cgi?id=193361
3185         <rdar://problem/47099573>
3186
3187         Reviewed by Geoffrey Garen.
3188
3189         Add API test coverage.
3190
3191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3192         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3193
3194 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3195
3196         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3197         https://bugs.webkit.org/show_bug.cgi?id=193470
3198
3199         Reviewed by Antti Koivisto.
3200
3201         * LayoutReloaded/misc/LFC-passing-tests.txt:
3202
3203 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3204
3205         [LFC] Adjust margin box verification.
3206         https://bugs.webkit.org/show_bug.cgi?id=193482
3207
3208         Reviewed by Antti Koivisto.
3209
3210         * LayoutReloaded/misc/LFC-passing-tests.txt:
3211
3212 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3213
3214         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3215         https://bugs.webkit.org/show_bug.cgi?id=193451
3216
3217         Reviewed by Geoffrey Garen.
3218
3219         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3220         (TEST):
3221         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3222         (runWebsiteDataStoreCustomPaths):
3223
3224 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3225
3226         webkitpy: Support boolean simctl isAvailable
3227         https://bugs.webkit.org/show_bug.cgi?id=193472
3228         <rdar://problem/47296150>
3229
3230         Reviewed by Ryosuke Niwa.
3231
3232         * Scripts/webkitpy/xcode/simulated_device.py:
3233         (SimulatedDeviceManager._create_runtimes):
3234         (SimulatedDeviceManager._create_device_with_runtime):
3235
3236 2019-01-15  Chris Dumez  <cdumez@apple.com>
3237
3238         Unreviewed, rolling out r239993, r239995, r239997, and
3239         r239999.
3240
3241         Caused assertions under
3242         ViewGestureController::disconnectFromProcess()
3243
3244         Reverted changesets:
3245
3246         "Regression(PSON) View becomes blank after click a cross-site
3247         download link"
3248         https://bugs.webkit.org/show_bug.cgi?id=193361
3249         https://trac.webkit.org/changeset/239993
3250
3251         "Unreviewed iOS build fix after r239993."
3252         https://trac.webkit.org/changeset/239995
3253
3254         "Fix iOS build after r239993"
3255         https://bugs.webkit.org/show_bug.cgi?id=193361
3256         https://trac.webkit.org/changeset/239997
3257
3258         "Unreviewed, revert part of r239997 as it is not needed to fix
3259         the build."
3260         https://trac.webkit.org/changeset/239999
3261
3262 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3263
3264         Cannot tab out of WKWebView on macOS
3265         https://bugs.webkit.org/show_bug.cgi?id=161448
3266         <rdar://problem/28100085>
3267
3268         Reviewed by Dean Jackson.
3269
3270         Add a test that tabbing into and out of WKWebView works correctly.
3271
3272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3273         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3274         (WebKit2_CommandBackForwardTest::SetUp):
3275         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3276         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3277         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3278         (-[FocusableView canBecomeKeyView]):
3279         (TEST):
3280         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3281         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3282         (-[OffscreenWindow initWithSize:]):
3283         (-[OffscreenWindow isKeyWindow]):
3284         (-[OffscreenWindow isVisible]):
3285         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3286         (TestWebKitAPI::PlatformWebView::initialize):
3287         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3288         (-[ActiveOffscreenWindow isVisible]): Deleted.
3289         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3290
3291 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3292
3293         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3294         https://bugs.webkit.org/show_bug.cgi?id=193459
3295
3296         Reviewed by Mark Lam.
3297
3298         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3299         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3300
3301 2019-01-15  Chris Dumez  <cdumez@apple.com>
3302
3303         Regression(PSON) View becomes blank after click a cross-site download link
3304         https://bugs.webkit.org/show_bug.cgi?id=193361
3305         <rdar://problem/47099573>
3306
3307         Reviewed by Geoff Garen.
3308
3309         Add API test coverage.
3310
3311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3312         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3313
3314 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3315
3316         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3317         https://bugs.webkit.org/show_bug.cgi?id=193448
3318
3319         Reviewed by Antti Koivisto.
3320
3321         * LayoutReloaded/misc/LFC-passing-tests.txt:
3322
3323 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3324
3325         webkitpy: Implement device type specific expected results (Part 1)
3326         https://bugs.webkit.org/show_bug.cgi?id=192162
3327
3328         Reviewed by Lucas Forschler.
3329
3330         Device type specific expected results covers two related ideas. The first (covered by this change)
3331         is where to search for -expected.* files. The second is which tests to run based on the
3332         TestExpectations.txt file.
3333
3334         After this change, the baseline search path will be determined by the type of device running a
3335         test. Device type will be passed into any function which picks a file based on the baseline search
3336         path.
3337
3338         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3339         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3340         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3341         (Manager.run): Print baseline search path for each round of devices.
3342         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3343         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3344         (SingleTestRunner._expected_driver_output): Ditto.
3345         (SingleTestRunner._driver_input): Ditto.
3346         * Scripts/webkitpy/layout_tests/views/printing.py:
3347         (Printer.print_config): Move printing of baseline search path to a separate function.
3348         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3349         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3350         (Testprinter.test_print_config):
3351         (Testprinter.test_print_baseline_search_path):
3352         * Scripts/webkitpy/port/base.py:
3353         (Port.baseline_search_path): Pass device_type through.
3354         (Port._expected_baselines_for_suffixes): Ditto.
3355         (Port.expected_baselines): Ditto.
3356         (Port.expected_filename): Ditto.
3357         (Port.expected_checksum): Ditto.
3358         (Port.expected_image): Ditto.
3359         (Port.expected_audio): Ditto.
3360         (Port.expected_text): Ditto.
3361         (Port.reference_files): Ditto.
3362         (Port.tests): Ditto.
3363         (Port._expanded_paths): Ditto.
3364         (Port.skipped_layout_tests): Ditto.
3365         (Port.expectations_dict): Ditto.
3366         (Port._port_specific_expectations_files): Ditto.
3367         (Port.expectations_files): Ditto.
3368         (Port.test_search_path): Ditto.
3369         (Port._tests_for_other_platforms): Ditto.
3370         * Scripts/webkitpy/port/base_unittest.py:
3371         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3372         (PortTest.test_nonexistant_expectations): Ditto.
3373         (test_ref_tests_platform_directory): Ditto.
3374         * Scripts/webkitpy/port/darwin.py:
3375         (DarwinPort._port_specific_expectations_files): Accept device_type.
3376         * Scripts/webkitpy/port/driver.py:
3377         (DriverProxy):
3378         (DriverProxy.host): Expose _target_host for device_type information.
3379         * Scripts/webkitpy/port/gtk.py:
3380         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3381         * Scripts/webkitpy/port/ios.py:
3382         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3383         * Scripts/webkitpy/port/mac.py:
3384         (MacPort. default_baseline_search_path): Ditto.
3385         * Scripts/webkitpy/port/port_testcase.py:
3386         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3387         * Scripts/webkitpy/port/test.py:
3388         * Scripts/webkitpy/port/watch.py:
3389         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3390         * Scripts/webkitpy/port/win.py:
3391         (WinPort.test_search_path): Accept, but do not use, device_type.
3392         * Scripts/webkitpy/port/wpe.py:
3393         (WPEPort._port_specific_expectations_files): Ditto.
3394         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3395         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3396
3397 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3398
3399         [LFC] Use the containing block's padding box to position out-of-flow elements.
3400         https://bugs.webkit.org/show_bug.cgi?id=193431
3401
3402         Reviewed by Antti Koivisto.
3403
3404         * LayoutReloaded/misc/LFC-passing-tests.txt:
3405
3406 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3407
3408         Move a test implementation file that got misplaced in the Xcode project
3409
3410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3411
3412 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3413
3414         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3415         r239913, and r239914.
3416         https://bugs.webkit.org/show_bug.cgi?id=193407
3417
3418         These revisions caused an internal failure (Requested by
3419         Truitt on #webkit).
3420
3421         Reverted changesets:
3422
3423         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3424         https://bugs.webkit.org/show_bug.cgi?id=186016
3425         https://trac.webkit.org/changeset/239901
3426
3427         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3428         https://trac.webkit.org/changeset/239909
3429
3430         "Tried to fix the build."
3431         https://trac.webkit.org/changeset/239910
3432
3433         "Fixed iOS builds after r239910."
3434         https://trac.webkit.org/changeset/239912
3435
3436         "More build fixing."
3437         https://trac.webkit.org/changeset/239913
3438
3439         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3440         https://trac.webkit.org/changeset/239914
3441
3442 2019-01-14  Mark Lam  <mark.lam@apple.com>
3443
3444         Re-enable ability to build --cloop builds.
3445         https://bugs.webkit.org/show_bug.cgi?id=192955
3446         <rdar://problem/46882363>
3447
3448         Reviewed by Saam barati and Keith Miller.
3449
3450         The --cloop build option was being ignored this whole time since r236381.
3451         This patch makes it possible to build CLoop builds again.
3452
3453         * Scripts/build-jsc:
3454         * Scripts/webkitperl/FeatureList.pm:
3455         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3456
3457 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3458
3459         webkitpy: Expose device_type from host-like objects
3460         https://bugs.webkit.org/show_bug.cgi?id=193406
3461         <rdar://problem/47262305>
3462
3463         Reviewed by Lucas Forschler.
3464
3465         Devices should expose device_type. As a result, all host objects should
3466         provide a device_type property, even if they do not yet define a device_type.
3467
3468         * Scripts/webkitpy/common/system/systemhost.py:
3469         (SystemHost):
3470         (SystemHost.device_type):
3471         * Scripts/webkitpy/common/system/systemhost_mock.py:
3472         (MockSystemHost):
3473         (MockSystemHost.device_type):
3474         * Scripts/webkitpy/port/device.py:
3475         (Device):
3476         (Device.device_type):
3477         * Scripts/webkitpy/xcode/simulated_device.py:
3478         (SimulatedDeviceManager._find_exisiting_device_for_request):
3479         (SimulatedDeviceManager._disambiguate_device_type):
3480         (SimulatedDeviceManager._does_fulfill_request):
3481         (SimulatedDeviceManager.device_count_for_type):
3482         (SimulatedDeviceManager.initialize_devices):
3483         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3484         (test_available_devices):
3485         (test_swapping_devices):
3486
3487 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3488
3489         webkitpy: Support alternate simctl device list output (Follow-up fix)
3490         https://bugs.webkit.org/show_bug.cgi?id=193362
3491         <rdar://problem/47122965>
3492
3493         Rubber-stamped by Lucas Forschler.
3494
3495         * Scripts/webkitpy/xcode/simulated_device.py:
3496         (SimulatedDeviceManager.populate_available_devices):
3497
3498 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3499
3500         [iOS] Expose SPI to access the current sentence boundary and selection state
3501         https://bugs.webkit.org/show_bug.cgi?id=193398
3502         <rdar://problem/45893108>
3503
3504         Reviewed by Dean Jackson.
3505
3506         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3507         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3508         expected.
3509
3510         * TestWebKitAPI/EditingTestHarness.h:
3511         * TestWebKitAPI/EditingTestHarness.mm:
3512         (-[EditingTestHarness moveBackward]):
3513         (-[EditingTestHarness moveForward]):
3514         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3515
3516         Add a couple of new helper methods on EditingTestHarness.
3517
3518         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3519         (-[SelectionChangeObserver initWithWebView:]):
3520         (-[SelectionChangeObserver webView]):
3521         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3522         (-[SelectionChangeObserver currentSelectionAttributes]):
3523
3524 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3525
3526         [LFC][BFC] Add basic box-sizing support.
3527         https://bugs.webkit.org/show_bug.cgi?id=193392
3528
3529         Reviewed by Antti Koivisto.
3530
3531         * LayoutReloaded/misc/LFC-passing-tests.txt:
3532
3533 2019-01-14  Charlie Turner  <cturner@igalia.com>
3534
3535         [WPE] API test gardening
3536         https://bugs.webkit.org/show_bug.cgi?id=193319
3537
3538         Reviewed by Michael Catanzaro.
3539
3540         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3541         passing tests.
3542
3543 2019-01-14  Charlie Turner  <cturner@igalia.com>
3544
3545         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3546         https://bugs.webkit.org/show_bug.cgi?id=192977
3547
3548         Reviewed by Carlos Garcia Campos.
3549
3550         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3551         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3552         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3553         (TestWebKitAPI::GStreamerTest::SetUp):
3554         (TestWebKitAPI::GStreamerTest::TearDown):
3555         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3556         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3557         (TestWebKitAPI::TEST_F):
3558
3559 2019-01-14  Charlie Turner  <cturner@igalia.com>
3560
3561         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3562         https://bugs.webkit.org/show_bug.cgi?id=193332
3563
3564         Reviewed by Michael Catanzaro.
3565
3566         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3567         defined as a char16_t, which changed in ICU 59, the
3568         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3569         unsigned short. This test is relying on the behaviour that
3570         UChar=unsigned short, which doesn't hold across platforms and ICU
3571         library versions. The full fix would be a special syntax for
3572         literal characters so that these ambiguities do not arise. That
3573         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3574         (TestWebKitAPI::TEST):
3575
3576 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3577
3578         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3579
3580         * Scripts/make-dist:
3581         (Distcheck.configure):
3582
3583 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3584
3585         [ews-build] Update macOS queue configurations
3586         https://bugs.webkit.org/show_bug.cgi?id=193365
3587         <rdar://problem/47221073>
3588
3589         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3590
3591         * BuildSlaveSupport/ews-build/config.json:
3592
3593 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3594
3595         [LFC] Adjust assert for statically positioned fixed elements
3596         https://bugs.webkit.org/show_bug.cgi?id=193385
3597
3598         Reviewed by Antti Koivisto.
3599
3600         * LayoutReloaded/misc/LFC-passing-tests.txt:
3601
3602 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3603
3604         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3605         https://bugs.webkit.org/show_bug.cgi?id=193387
3606
3607         Reviewed by Carlos Garcia Campos.
3608
3609         * MiniBrowser/wpe/main.cpp:
3610         (main):
3611
3612 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3613
3614         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3615         https://bugs.webkit.org/show_bug.cgi?id=191655
3616         rdar://problem/46074680
3617
3618         Reviewed by Megan Gardner.
3619
3620         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3621         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3622
3623 2019-01-12  Dan Bernstein  <mitz@apple.com>
3624
3625         [Cocoa] Avoid importing directly from subumbrella frameworks
3626         https://bugs.webkit.org/show_bug.cgi?id=186016
3627         <rdar://problem/40591038>
3628
3629         Reviewed by Sam Weinig.
3630
3631         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3632           LaunchServices header.
3633         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3634           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3635         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3636           when using SDKs earlier than 10.13.
3637         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3638           and OTHER_CPLUSPLUSFLAGS.
3639         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3640           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3641         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3642           LaunchServices header.
3643
3644 2019-01-11  John Wilander  <wilander@apple.com>
3645
3646         Compile out Web API Statistics Collection
3647         https://bugs.webkit.org/show_bug.cgi?id=193370
3648         <rdar://problem/45388584>
3649
3650         Reviewed by Brent Fulgham.
3651
3652         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3653             Defined ENABLE_WEB_API_STATISTICS, off by default.
3654
3655 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3656
3657         [WPE] Add gtk-doc
3658         https://bugs.webkit.org/show_bug.cgi?id=178900
3659
3660         Reviewed by Michael Catanzaro.
3661
3662         Add Tools/gtkdoc to manifest.txt.in files.
3663         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3664
3665         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3666         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3667
3668 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3669
3670         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3671         https://bugs.webkit.org/show_bug.cgi?id=193364
3672         <rdar://problem/47214117>
3673
3674         Reviewed by Tim Horton.
3675
3676         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3677         precise, whereas dragging near the middle of the textarea does.
3678
3679         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3680         (TestWebKitAPI::TEST):
3681
3682 2019-01-11&