watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
2
3         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
4         https://bugs.webkit.org/show_bug.cgi?id=74430
5
6         Reviewed by David Levin.
7
8         * Scripts/webkitpy/common/config/watchlist:
9
10 2011-12-13  Peter Beverloo  <peter@chromium.org>
11
12         [Chromium] Pull in FreeType and decrease check-out complexity for Android
13         https://bugs.webkit.org/show_bug.cgi?id=74401
14
15         Decrease the check-out complexity by removing the need to first run
16         "update-webkit-chromium --chromium" prior to running it with
17         "--chromium-android", which was caused by an unversioned third_party/
18         directory being created. This moves the Android NDK to Source/WebKit/
19         chromium/, coming from third_party/ in that directory.
20
21         Reviewed by Adam Barth.
22
23         * Scripts/update-webkit-chromium:
24         * Scripts/webkitdirs.pm:
25         (buildChromiumMakefile):
26
27 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
28
29         build-jsc passing incorrect args to buildGtkProject
30         https://bugs.webkit.org/show_bug.cgi?id=74308
31
32         Reviewed by Gustavo Noronha Silva.
33
34         * Scripts/build-webkit: Instead of invoking buildGtkProject with
35         another argument about webkit2, unshift a --disable-webkit2
36         argument onto the buildArgs.
37         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
38         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
39         and build-jsc are run one after the other.
40
41 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
42
43         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
44         https://bugs.webkit.org/show_bug.cgi?id=74413
45
46         Unreviewed buildfix.
47
48         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
49
50 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
51
52         [Qt] Unreviewed speculativ debug buildfix after r102679.
53
54         * QtTestBrowser/QtTestBrowser.pro:
55         * QtTestBrowser/main.cpp:
56
57 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
58
59         [Qt] Get rid of layering violations in includes
60
61         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
62         in the webcore.prf, but rather in each target that specificly needs
63         headers in these location. We used to include them directly in webcore
64         since we had layering violations between WebCore and WebKit, but now
65         that they are gone there's no reason to do that.
66
67         Reviewed by Simon Hausmann.
68
69         * DumpRenderTree/qt/DumpRenderTree.pro:
70         * QtTestBrowser/launcherwindow.h:
71         * WebKitTestRunner/InjectedBundle/Target.pri:
72         * qmake/mkspecs/features/webcore.prf:
73         * qmake/mkspecs/features/webkit2.prf:
74
75 2011-12-13  János Badics  <dicska@gmail.com>
76
77         [NRWT] It crashes intermittently when there are WebProcess crashes
78         https://bugs.webkit.org/show_bug.cgi?id=73451
79
80         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
81
82         Reviewed by Kenneth Rohde Christiansen.
83
84         * Scripts/webkitpy/layout_tests/port/server_process.py:
85         (ServerProcess._check_for_crash):
86
87 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
88
89         Unreviewed. Fix GTK+ API docs build.
90
91         * gtk/generate-gtkdoc:
92         (get_webkit2_options): Ignore WebKitUIClient since it's private
93         API.
94
95 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
96
97         Reviewed, removed one of my email addresses to use the apprpriate one.
98
99         * Scripts/webkitpy/common/config/committers.py:
100
101 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
102
103         [Qt] Fix skip list search path and expected file search path in ORWT
104         https://bugs.webkit.org/show_bug.cgi?id=74281
105
106         Expected file search path fixed.
107
108         Print all used skipped list and expected search path in verbose mode similar to NRWT.
109
110         Reviewed by Csaba Osztrogonác.
111
112         * Scripts/old-run-webkit-tests:
113         (buildPlatformResultHierarchy):
114         (buildPlatformTestHierarchy):
115         (readSkippedFiles):
116
117 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
118
119         [Qt] Missing layoutTestController.dumpWillCacheResponse
120         https://bugs.webkit.org/show_bug.cgi?id=74287
121
122         Reviewed by Csaba Osztrogonác.
123
124         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
125         (LayoutTestController::reset):
126         (LayoutTestController::dumpWillCacheResponse):
127         * DumpRenderTree/qt/LayoutTestControllerQt.h:
128
129 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
130
131         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
132         https://bugs.webkit.org/show_bug.cgi?id=73771
133
134         Reviewed by Gustavo Noronha Silva.
135
136         When using a fallback font during testing, always use DejaVu Sans. This prevents
137         falling back to DejaVu Serif on some systems.
138
139         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
140
141 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
142
143         Add myself as a committer
144
145         * Scripts/webkitpy/common/config/committers.py:
146
147 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
148
149         [Qt] [WK2] Support customizing popup menus with QML
150         https://bugs.webkit.org/show_bug.cgi?id=73560
151
152         Reviewed by Tor Arne Vestbø.
153
154         Add an Item Selector to our WebView using the experimental API.
155
156         * MiniBrowser/qt/MiniBrowser.pro:
157         * MiniBrowser/qt/MiniBrowser.qrc:
158         * MiniBrowser/qt/qml/BrowserWindow.qml:
159         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
160
161 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
162
163         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
164         https://bugs.webkit.org/show_bug.cgi?id=74283
165
166         Reviewed by Simon Hausmann.
167
168         * MiniBrowser/qt/MiniBrowserApplication.cpp:
169         (MiniBrowserApplication::sendTouchEvent):
170
171 2011-12-12  Kentaro Hara  <haraken@chromium.org>
172
173         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
174         to show ChangeLogs diff and open ChangeLogs in an editor
175         https://bugs.webkit.org/show_bug.cgi?id=74266
176
177         Reviewed by Ryosuke Niwa.
178
179         We are planning to write unit-tests for prepare-ChangeLog
180         in a run-leaks_unittest manner. This patch is one of the incremental
181         refactorings to remove all top-level code and global variables from
182         prepare-ChangeLog.
183
184         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
185         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
186         Renamed @changed_files to @changedFiles.
187         Renamed %conflict_files to %conflictFiles.
188         (generateFunctionLists):
189         (printDiff):
190         (openChangeLogs):
191
192 2011-12-11  Kentaro Hara  <haraken@chromium.org>
193
194         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
195         https://bugs.webkit.org/show_bug.cgi?id=74257
196
197         Reviewed by Ryosuke Niwa.
198
199         We are planning to write unit-tests for prepare-ChangeLog
200         in a run-leaks_unittest/ manner. This patch is one of the incremental
201         refactorings to remove all top-level code and global variables from
202         prepare-ChangeLog.
203
204         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
205         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
206         into resolveConflictedChangeLogs().
207         (getLatestChangeLogs):
208         (resolveConflictedChangeLogs):
209
210 2011-12-11  Kentaro Hara  <haraken@chromium.org>
211
212         [Refactoring] Move top-level code to generate a new ChangeLog into a method
213         https://bugs.webkit.org/show_bug.cgi?id=74253
214
215         Reviewed by David Kilzer.
216
217         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
218         which requires to remove top-level code and global variables. This patch is one of
219         the incremental refactorings for that.
220
221         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
222         (generateFunctionLists):
223         (findChangeLogs):
224         (generateNewChangeLogs):
225         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
226
227 2011-12-10  Kentaro Hara  <haraken@chromium.org>
228
229         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
230         https://bugs.webkit.org/show_bug.cgi?id=74175
231
232         Reviewed by Ryosuke Niwa.
233
234         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
235         This requires to remove top-level code. This patch is one of the incremental refactorings
236         for that.
237
238         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
239         (findChangeLogs):
240
241 2011-12-10  Andreas Kling  <kling@webkit.org>
242
243         Add my Apple e-mail to committers.py.
244
245         * Scripts/webkitpy/common/config/committers.py:
246
247 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
248
249         chromium win build: revert build_webkit_exes_from_webkit_gyp change
250         https://bugs.webkit.org/show_bug.cgi?id=74225
251
252         This change sets build_webkit_exes_from_webkit_gyp back to 1;
253         the "All.gyp" solution doesn't work on windows.
254
255         * Scripts/webkitdirs.pm:
256         (buildChromium):
257
258 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
259
260         [Qt] Click's count is limited to three continuous clicks.
261         https://bugs.webkit.org/show_bug.cgi?id=45666
262
263         Reviewed by Kenneth Rohde Christiansen.
264
265         Update m_time at every call to leapForward, so double clicks
266         event are correctly sent by EventSender.
267
268         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
269         (WTR::EventSenderProxy::updateClickCountForButton):
270         (WTR::EventSenderProxy::leapForward):
271
272 2011-12-09  Kentaro Hara  <haraken@chromium.org>
273
274         [Refactoring] Reduce top-level code in prepare-ChangeLog
275         https://bugs.webkit.org/show_bug.cgi?id=74172
276
277         Reviewed by Ryosuke Niwa.
278
279         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
280         This requires to remove top-level code. This patch is one of the incremental refactorings
281         for that.
282
283         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
284         (generateFunctionLists):
285
286 2011-12-09  Sam Weinig  <sam@webkit.org>
287
288         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
289         https://bugs.webkit.org/show_bug.cgi?id=74218
290
291         Reviewed by Anders Carlsson.
292
293         Add a test of the WKConnectionRef API.
294
295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
296         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
297         (TestWebKitAPI::didCreateConnection):
298         (TestWebKitAPI::connectionDidReceiveMessage):
299         (TestWebKitAPI::connectionDidClose):
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
302         (TestWebKitAPI::connectionDidReceiveMessage):
303         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
304         (TestWebKitAPI::WKConnectionTest::initialize):
305
306 2011-12-09  David Levin  <levin@chromium.org>
307
308         Hash* iterators should allow comparison between const and const versions.
309         https://bugs.webkit.org/show_bug.cgi?id=73370
310
311         Reviewed by Darin Adler.
312
313         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
315         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
316         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
317         (TestWebKitAPI::TEST): Add a test for the new functionality.
318
319 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
320
321         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
322         https://bugs.webkit.org/show_bug.cgi?id=74212
323
324         Reviewed by Tony Chang.
325
326         The change introduced in r102201 to split the executables out of
327         WebKit.gyp apparently doesn't work right on Windows, since
328         WebKit.gyp and Tools.gyp refer to dependent projects by
329         different relative paths (it appears gyp doesn't normalize the
330         paths). This change moves Tools.gyp to be in the same directory
331         as WebKit.gyp (and All.gyp), which should fix this and
332         conveniently will also solve the problem of how to add Tools.gyp
333         to the chromium DEPS file.
334
335         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
336
337 2011-12-09  Kentaro Hara  <haraken@chromium.org>
338
339         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
340         https://bugs.webkit.org/show_bug.cgi?id=74173
341
342         Reviewed by Ryosuke Niwa.
343
344         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
345         This requires to remove top-level code. This patch is one of the incremental refactorings
346         for that.
347
348         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
349         (fetchBugDescriptionFromURL):
350
351 2011-12-09  Tony Chang  <tony@chromium.org>
352
353         Switch the chromium mac bots to using skia test results
354         https://bugs.webkit.org/show_bug.cgi?id=74201
355
356         Reviewed by Ryosuke Niwa.
357
358         This is reverting http://trac.webkit.org/changeset/97781 and changing
359         the name in master.cfg to no longer have cg in the name.
360
361         * BuildSlaveSupport/build.webkit.org-config/config.json:
362         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
363         (appendCustomBuildFlags):
364         (RunWebKitTests.start):
365
366 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
367
368         [Qt] Remove a wrongly placed ASSERT.
369
370         Reviewed by Tor Arne Vestbø.
371
372         * MiniBrowser/qt/MiniBrowserApplication.cpp:
373         (MiniBrowserApplication::notify):
374
375 2011-12-09  Cary Clark  <caryclark@google.com>
376
377         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
378         https://bugs.webkit.org/show_bug.cgi?id=74118
379
380         Reviewed by Adam Barth.
381
382         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
383         (get):
384         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
385         (ChromiumMacPort.__init__):
386         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
387         (ChromiumMacPortTest.test_versions):
388         (ChromiumMacPortTest.test_graphics_type):
389
390 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
391
392         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
393
394         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
395         this failed when moving files in the source tree, as the .d file would contain
396         stale dependencies on the old source file location. By keeping the object files
397         (and hence the depdendency files) in a proper tree structure inside the objects
398         directory we can prevent this failure.
399
400         A side benefit is that we can also have objects with the same name inside the
401         same project.
402
403         Reviewed by Simon Hausmann.
404
405         * qmake/mkspecs/features/unix/default_pre.prf:
406
407 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
408
409         Unreviewed. Update unit test after r102412.
410
411         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
412         (IRCCommandTest.test_whois):
413
414 2011-12-09  Kentaro Hara  <haraken@chromium.org>
415
416         REGRESSION(r102105): run-bindings-tests should output full diff results
417         https://bugs.webkit.org/show_bug.cgi?id=74166
418
419         Reviewed by Adam Barth.
420
421         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
422         run-bindings-tests should output full diff results.
423
424         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
425         (BindingsTests.generate_from_idl):
426         (BindingsTests.generate_supplemental_dependency):
427         (BindingsTests.detect_changes):
428
429 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
430
431         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
432         https://bugs.webkit.org/show_bug.cgi?id=73990
433
434         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
435
436         Fix QtQuick includes after move from QtDeclarative to QtQuick.
437
438         * MiniBrowser/qt/BrowserWindow.h:
439         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
440
441 2011-12-08  Adam Klein  <adamk@chromium.org>
442
443         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
444         https://bugs.webkit.org/show_bug.cgi?id=73492
445
446         Reviewed by Adam Barth.
447
448         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
449         keypress event without any script on the stack.
450
451         * DumpRenderTree/chromium/EventSender.cpp:
452         (EventSender::EventSender):
453         (EventSender::keyDown):
454         (KeyDownTask::KeyDownTask):
455         (KeyDownTask::runIfValid):
456         (EventSender::scheduleAsynchronousKeyDown):
457         * DumpRenderTree/chromium/EventSender.h:
458
459 2011-12-08  Hayato Ito  <hayato@chromium.org>
460
461         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
462         https://bugs.webkit.org/show_bug.cgi?id=73980
463
464         Reviewed by Tony Chang.
465
466         * gdb/webkit.py:
467         (guess_string_length):
468         (ustring_to_string):
469         (lstring_to_string):
470         (LCharStringPrinter):
471         (LCharStringPrinter.to_string):
472         (WTFStringImplPrinter.get_length):
473         (WTFStringImplPrinter.to_string):
474         (WTFStringImplPrinter.is_8bit):
475         (WTFStringPrinter.stringimpl_ptr):
476         (WTFStringPrinter.get_length):
477         (WTFStringPrinter.to_string):
478         (add_pretty_printers.lookup_function):
479
480 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
481
482         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
483         https://bugs.webkit.org/show_bug.cgi?id=73916
484
485         Reviewed by Kent Tamura.
486
487         * qmake/mkspecs/features/features.prf:
488
489 2011-12-08  Adrienne Walker  <enne@google.com>
490
491         Unreviewed contributor additions to committers.py.
492
493         * Scripts/webkitpy/common/config/committers.py:
494
495 2011-12-08  David Reveman  <reveman@chromium.org>
496
497         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
498         https://bugs.webkit.org/show_bug.cgi?id=74017
499
500         Reviewed by James Robinson.
501         
502         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
503
504         * DumpRenderTree/chromium/DumpRenderTree.cpp:
505         (main):
506         * DumpRenderTree/chromium/TestShell.cpp:
507         (TestShell::TestShell):
508         (TestShell::resetWebSettings):
509         * DumpRenderTree/chromium/TestShell.h:
510         (TestShell::setAcceleratedPaintingEnabled):
511         (TestShell::setPerTilePaintingEnabled):
512         * DumpRenderTree/chromium/WebPreferences.cpp:
513         (WebPreferences::reset):
514         (WebPreferences::applyTo):
515         * DumpRenderTree/chromium/WebPreferences.h:
516         * Scripts/webkitpy/layout_tests/port/chromium.py:
517         (ChromiumDriver._wrapper_options):
518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
519         (parse_args):
520
521 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
522
523         create a "SystemHost" object for webkitpy to slim down the Host object
524         https://bugs.webkit.org/show_bug.cgi?id=72680
525
526         Reviewed by Eric Siedel.
527
528         This creates a SystemHost object that other objects that should
529         only have dependencies on functionality in webkitpy.common.system
530         can use; this will allow them to not require a full Host.
531
532         * Scripts/webkitpy/common/host.py:
533         * Scripts/webkitpy/common/host_mock.py:
534         * Scripts/webkitpy/common/system/systemhost.py: Added.
535         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
536
537 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
538
539         AX: platform/mac/accessibility/search-with-frames.html crashes
540         https://bugs.webkit.org/show_bug.cgi?id=74093
541
542         Reviewed by Darin Adler.
543
544         Take care of the case when an incoming element is null.
545
546         * DumpRenderTree/AccessibilityUIElement.cpp:
547         (uiElementForSearchPredicateCallback):
548         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
549         (AccessibilityUIElement::uiElementForSearchPredicate):
550         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
551         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
552
553 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
554
555         [Qt] Visualize mock point ID's in the MiniBrowser
556         https://bugs.webkit.org/show_bug.cgi?id=74098
557
558         Reviewed by Tor Arne Vestbø.
559
560         * MiniBrowser/qt/BrowserWindow.cpp:
561         (BrowserWindow::updateVisualMockTouchPoints):
562         * MiniBrowser/qt/qml/MockTouchPoint.qml:
563
564 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
565
566         Accessibility: AccessibilityController should support listening to notifications on all elements.
567         https://bugs.webkit.org/show_bug.cgi?id=72866
568
569         Adds addNotificationListener and removeNotificationListener methods
570         to AccessibilityController, to listen to notifications on any element
571         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
572         implementations are all contained in this change.
573
574         On Mac, refactors AccessibilityNotificationHandler into its own
575         source file that can be used by both AccessibilityController and
576         AccessibilityUIElement. (Both DRT and WKTR.)
577
578         Reviewed by Chris Fleizach.
579
580         * DumpRenderTree/AccessibilityController.cpp:
581         (addNotificationListenerCallback):
582         (removeNotificationListenerCallback):
583         (AccessibilityController::getJSClass):
584         * DumpRenderTree/AccessibilityController.h:
585         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
586         * DumpRenderTree/chromium/AccessibilityController.cpp:
587         (AccessibilityController::AccessibilityController):
588         (AccessibilityController::notificationReceived):
589         (AccessibilityController::addNotificationListenerCallback):
590         (AccessibilityController::removeNotificationListenerCallback):
591         * DumpRenderTree/chromium/AccessibilityController.h:
592         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
593         (AccessibilityController::addNotificationListener):
594         (AccessibilityController::removeNotificationListener):
595         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
596         (AccessibilityController::~AccessibilityController):
597         (AccessibilityController::addNotificationListener):
598         (AccessibilityController::removeNotificationListener):
599         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
600         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
601         (-[NSString createJSStringRef]):
602         (-[AccessibilityNotificationHandler init]):
603         (-[AccessibilityNotificationHandler setPlatformElement:]):
604         (-[AccessibilityNotificationHandler dealloc]):
605         (-[AccessibilityNotificationHandler setCallback:]):
606         (-[AccessibilityNotificationHandler startObserving]):
607         (-[AccessibilityNotificationHandler _notificationReceived:]):
608         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
609         (AccessibilityUIElement::addNotificationListener):
610         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
611         (notificationListenerProc):
612         (AccessibilityController::addNotificationListener):
613         (AccessibilityController::removeNotificationListener):
614         (AccessibilityController::winNotificationReceived):
615         (AccessibilityController::winAddNotificationListener):
616         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
617         (AccessibilityUIElement::addNotificationListener):
618         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
619         (WTR::AccessibilityController::addNotificationListener):
620         (WTR::AccessibilityController::removeNotificationListener):
621         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
622         (WTR::AccessibilityController::logAccessibilityEvents):
623         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
624         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
625         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
626         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
627         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
628         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
629         (WTR::AccessibilityController::addNotificationListener):
630         (WTR::AccessibilityController::removeNotificationListener):
631         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
632         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
633         (-[NSString createJSStringRef]):
634         (-[AccessibilityNotificationHandler init]):
635         (-[AccessibilityNotificationHandler setPlatformElement:]):
636         (-[AccessibilityNotificationHandler dealloc]):
637         (-[AccessibilityNotificationHandler setCallback:]):
638         (-[AccessibilityNotificationHandler startObserving]):
639         (-[AccessibilityNotificationHandler _notificationReceived:]):
640         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
641         (WTR::AccessibilityUIElement::AccessibilityUIElement):
642         (WTR::AccessibilityUIElement::verticalScrollbar):
643         (WTR::AccessibilityUIElement::addNotificationListener):
644         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
645
646 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
647
648         [Qt][WK2] Unreviewed buildfix after r102352.
649
650         * qmake/mkspecs/features/webkit2.prf:
651
652 2011-12-08  Adam Roben  <aroben@apple.com>
653
654         Make finding crash logs by PID work on Snow Leopard
655
656         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
657         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
658         read the first line of the crash log and pull the PID out of there.
659
660         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
661         Snow Leopard
662
663         Reviewed by Darin Adler.
664
665         * Scripts/webkitpy/common/system/crashlogs.py:
666         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
667         name and PID for the log, rather than checking the Lion-only app_description extended
668         attribute. We now also reject the log if the process name doesn't match what we expect.
669
670         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
671         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
672         PID.
673         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
674         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
675         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
676         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
677         read, files that actually contain a crash log for some other process, and files that are
678         misformatted.
679
680         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
681         unused.
682
683         * Scripts/webkitpy/common/system/filesystem_mock.py:
684         (MockFileSystem.__init__): Removed xattr support, which is now unused.
685         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
686         ReadableTextFileObject. This function was completely broken before!
687         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
688         bugs like the above.
689         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
690         things like readline() and seek().
691
692         (ReadableTextFileObject.close):
693         (ReadableTextFileObject.read):
694         Added. We override the superclass implementation to account for using a StringIO object.
695
696         (ReadableTextFileObject.readline):
697         (ReadableTextFileObject.seek):
698         Added. These just call through to StringIO.
699
700         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
701         (MainTest.test_crash_log):
702         (MainTest.test_web_process_crash_log):
703         Changed to use make_mock_crash_report_darwin.
704
705 2011-12-06  Jon Lee  <jonlee@apple.com>
706
707         [WK2] Add permissions support (73960)
708         https://bugs.webkit.org/show_bug.cgi?id=73960
709         <rdar://problem/10357008>
710
711         Reviewed by Darin Adler.
712
713         Add null function item to comply with added callback to WKPageUIClient.
714
715         * MiniBrowser/mac/BrowserWindowController.m:
716         (-[BrowserWindowController awakeFromNib]):
717         * WebKitTestRunner/TestController.cpp:
718         (WTR::TestController::createOtherPage):
719         (WTR::TestController::initialize):
720
721 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
722
723         [Qt] Visualize mock points in the Qt MiniBrowser
724         https://bugs.webkit.org/show_bug.cgi?id=74074
725
726         Reviewed by Tor Arne Vestbø.
727
728         * MiniBrowser/qt/BrowserWindow.cpp:
729         (BrowserWindow::updateVisualMockTouchPoints):
730         * MiniBrowser/qt/BrowserWindow.h:
731         * MiniBrowser/qt/MiniBrowser.qrc:
732         * MiniBrowser/qt/MiniBrowserApplication.cpp:
733         (MiniBrowserApplication::notify):
734         (MiniBrowserApplication::sendTouchEvent):
735         * MiniBrowser/qt/MiniBrowserApplication.h:
736         * MiniBrowser/qt/icons/touchpoint.png: Added.
737         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
738
739 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
740
741         [Qt] WebKitTestRunner crashes with debug builds
742         https://bugs.webkit.org/show_bug.cgi?id=74090
743
744         Reviewed by Tor Arne Vestbø.
745
746         * WebKitTestRunner/qt/TestControllerQt.cpp:
747         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
748         to ensure WTF/JSC threading is initialized.
749
750 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
751
752         fix build-webkit --chromium after breakage in r102201
753         https://bugs.webkit.org/show_bug.cgi?id=74031
754
755         Reviewed by Tony Chang.
756
757         * Scripts/webkitdirs.pm:
758         (buildChromium):
759
760 2011-12-08  Kentaro Hara  <haraken@chromium.org>
761
762         Unreviewed, rolling out r102280.
763         http://trac.webkit.org/changeset/102280
764         https://bugs.webkit.org/show_bug.cgi?id=74031
765
766         Chromium/Windows build is broken
767
768         * Scripts/webkitdirs.pm:
769         (buildChromium):
770
771 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
772
773         Adding myself to committers list.
774
775         Unreviewed.
776
777         * Scripts/webkitpy/common/config/committers.py:
778
779 2011-12-07  Michael Saboff  <msaboff@apple.com>
780
781         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
782         https://bugs.webkit.org/show_bug.cgi?id=73995
783
784         Reenabled failing tests that the code part of the patch fixes.
785
786         Reviewed by Geoffrey Garen.
787
788         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
789         (TestWebKitAPI::TEST):
790
791 2011-12-07  MORITA Hajime  <morrita@google.com>
792
793         [filter-build-webkit] should not emit reset color when --no-color is given
794         https://bugs.webkit.org/show_bug.cgi?id=73992
795
796         Reviewed by Daniel Bates.
797
798         Stop printing control sequences when --no-color is given.
799         After this change, the filter runs nicely even on environments
800         like Emacs compilation-mode which cannot understand the control sequence.
801
802         * Scripts/filter-build-webkit:
803         (printLine):
804
805 2011-12-07  Eric Seidel  <eric@webkit.org>
806
807         Use free memory to determine if we have space for DRT instances instead of total memory
808         https://bugs.webkit.org/show_bug.cgi?id=74021
809
810         Reviewed by Adam Barth.
811
812         This will hopefully make the Mac buildbots behave better.
813
814         I also reduced the expected memory needed per DRT now that
815         we're properly accounting for the system memory in our calculations.
816
817         * Scripts/webkitpy/common/system/platforminfo.py:
818         (PlatformInfo.total_bytes_memory):
819         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
820         * Scripts/webkitpy/common/system/platforminfo_mock.py:
821         (MockPlatformInfo.total_bytes_memory):
822         * Scripts/webkitpy/layout_tests/port/base.py:
823         (Port.default_child_processes):
824         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
825         (PortTest.test_default_child_processes):
826
827 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
828
829         fix build-webkit --chromium after breakage in r102201
830         https://bugs.webkit.org/show_bug.cgi?id=74031
831
832         Reviewed by Tony Chang.
833
834         r102201 introduced a change to the chromium build that splits
835         the executables out of WebKit.gyp into other gyp files, and adds
836         a new "All.gyp" that builds everything. However, I forgot to
837         update the build script to use All.gyp.
838
839         * Scripts/webkitdirs.pm:
840         (buildChromium):
841
842 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
843
844         Moved myself to the committers list.
845
846         * Scripts/webkitpy/common/config/committers.py:
847
848 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
849
850         [Qt] Fix debug shlib build with V8.
851
852         Reviewed by Tor Arne Vestbø.
853
854         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
855         v8 builds.
856
857 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
858
859         [Qt] V8 build fixes.
860
861         Reviewed by Tor Arne Vestbø.
862
863         * qmake/mkspecs/features/javascriptcore.prf: Don't add
864         Source/Thirdparty to the include search path here.
865         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
866         used when building WebCore as well as using it, because header files like
867         GraphicsContext3D.h include stuff from ThirdParty.
868
869 2011-12-07  Peter Beverloo  <peter@chromium.org>
870
871         [Chromium] Fix project file generation for the Android bot after r102201
872         https://bugs.webkit.org/show_bug.cgi?id=73996
873
874         The gyp refactoring in r102201 was didn't explicitly exclude
875         the Android operating system in Tools/Tools.gyp, which broke
876         as gcc_version is not defined for that configuration.
877
878         Reviewed by Andreas Kling.
879
880         * Tools.gyp:
881
882 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
883
884         Unreviewed. Disabled failing tests on chromium.
885
886         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
887         (TestWebKitAPI::TEST):
888
889 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
890
891         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
892         https://bugs.webkit.org/show_bug.cgi?id=73382
893
894         Reviewed by Tony Chang.
895
896         XCode (and hence GYP) can't handle circular dependencies between
897         files (and projects). Accordingly, although the binaries in
898         WebKit.gyp depend on webkit_support and webkit_support depends
899         on webkit, we don't mention the latter dependency in the file.
900         To fix this, this change moves the binaries like DRT into a new
901         GYP file, and modifies gyp_webkit to build from that file
902         instead of WebKit.gyp.
903
904         * Tools.gyp: Added.
905
906 2011-12-06  Adam Roben  <aroben@apple.com>
907
908         Add a pid parameter to CrashLogs.find_newest_log
909
910         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
911         considered.
912
913         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
914         process whose crash log you want to find
915
916         Reviewed by Dirk Pranke.
917
918         * Scripts/webkitpy/common/system/crashlogs.py:
919         (CrashLogs.find_newest_log): Added an optional pid parameter.
920         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
921         candidate log's app_description extended attribute to see if that log corresponds to a
922         crashed process with the specified PID.
923
924         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
925         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
926         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
927         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
928
929         * Scripts/webkitpy/common/system/filesystem.py:
930         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
931         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
932         present.
933
934         * Scripts/webkitpy/common/system/filesystem_mock.py:
935         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
936         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
937         dictionary.
938
939         * Scripts/webkitpy/tool/commands/queries.py:
940         (CrashLog): Added help text. Added an optional PID parameter.
941         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
942
943 2011-12-06  Adam Roben  <aroben@apple.com>
944
945         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
946
947         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
948         alive beyond the normal timeout limit. In cases where the crashed process was able to die
949         faster, NRWT would assume that Crash Reporter had finished even though it often was still
950         running, which would lead to an incorrect crash log being picked up.
951
952         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
953
954         Reviewed by Dirk Pranke.
955
956         * Scripts/webkitpy/layout_tests/port/server_process.py:
957         (ServerProcess._reset):
958         (ServerProcess.write):
959         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
960         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
961         set_crashed.
962
963         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
964         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
965         we bail out of handling the failure as a timeout if we find out that the process in fact
966         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
967         so.
968         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
969         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
970         disk.
971
972         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
973         (TrivialMockPort.is_crash_reporter): Added.
974
975         * Scripts/webkitpy/layout_tests/port/webkit.py:
976         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
977         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
978
979 2011-12-06  Adam Barth  <abarth@webkit.org>
980
981         NRWT fails on unreleased versions of Mac OS X
982         https://bugs.webkit.org/show_bug.cgi?id=72748
983
984         Reviewed by Dirk Pranke.
985
986         Hopefully this patch will make NRWT work on future versions on Mac OS X.
987         Most of the infrastructure was already in place, but there were some
988         asserts that failed.  I've tested this patch by haxoring the version
989         detection logic to simulate an unknown version.  We might need to
990         iterate based on feedback from folks with a real future version.
991
992         * Scripts/webkitpy/layout_tests/port/apple.py:
993         (ApplePort.__init__):
994             - mac-future is an allowed port_name that's used internally by
995               webkitpy to represent future versions of Mac OS X.
996         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
997         (test_versions):
998             - Test that we don't throw exceptions when dealing with future
999               versions of Mac OS X.
1000         * Scripts/webkitpy/layout_tests/port/webkit.py:
1001         (WebKitPort._expectations_from_skipped_files):
1002             - Demote this logging message to "debug".  It's expected that
1003               mac-future doesn't have a Skipped file.
1004         * Scripts/webkitpy/layout_tests/port/mac.py:
1005         (MacPort.__init__):
1006         * Scripts/webkitpy/layout_tests/port/win.py:
1007         (WinPort.__init__):
1008             - Re-order some code in these constructors so that
1009               self._operating_system is available to the ApplePort constructor.
1010
1011 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
1012
1013         Added myself as a committer.
1014
1015         * Scripts/webkitpy/common/config/committers.py:
1016
1017 2011-12-06  Peter Beverloo  <peter@chromium.org>
1018
1019         Added myself as a committer.
1020
1021         * Scripts/webkitpy/common/config/committers.py:
1022
1023 2011-12-06  Kentaro Hara  <haraken@chromium.org>
1024
1025         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
1026         https://bugs.webkit.org/show_bug.cgi?id=73637
1027
1028         Reviewed by Adam Barth.
1029
1030         This patch replaces subprocess.Popen() with Executive, similar to other
1031         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
1032         works well for cases where no exception is raised, no exception is raised
1033         but diff is found, and ScriptError is raised.
1034
1035         * Scripts/run-bindings-tests:
1036         (main):
1037         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
1038         (BindingsTests.__init__):
1039         (BindingsTests.generate_from_idl):
1040         (BindingsTests.generate_supplemental_dependency):
1041         (BindingsTests.detect_changes):
1042
1043 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1044
1045         [Qt] MiniBrowser should default to touch behavior
1046         https://bugs.webkit.org/show_bug.cgi?id=73863
1047
1048         Reviewed by Chang Shu.
1049
1050         MiniBrowser currently defaults to the traditional desktop behaviour
1051         instead of touch behaviour which is prefered.
1052
1053         * MiniBrowser/qt/BrowserWindow.cpp:
1054         (BrowserWindow::BrowserWindow):
1055         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1056         (printHelp):
1057         (MiniBrowserApplication::handleUserOptions):
1058         * MiniBrowser/qt/MiniBrowserApplication.h:
1059         (WindowOptions::WindowOptions):
1060         (WindowOptions::setUseTraditionalDesktopBehavior):
1061         (WindowOptions::useTraditionalDesktopBehavior):
1062
1063 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1064
1065         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
1066         https://bugs.webkit.org/show_bug.cgi?id=73878
1067
1068         Reviewed by Tony Chang.
1069
1070         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
1071         r98785 made webkit.py always use m_data16, which does not work when
1072         the string is an 8-bit string (such as KURL::string()).
1073
1074         I was not able to directly call StringImpl::is8Bit() in the Python
1075         code, so I just reproduced the implementation there.
1076
1077         * gdb/webkit.py:
1078         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
1079         (WTFStringPrinter.to_string):
1080         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
1081         (JSCUStringPrinter.to_string):
1082
1083 2011-12-05  Eric Seidel  <eric@webkit.org>
1084
1085         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
1086         in hopes of making the Snow Leopard bot stop timing out.
1087
1088         Unreviewed.
1089
1090         * Scripts/webkitpy/layout_tests/port/base.py:
1091         (Port.default_child_processes):
1092         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1093         (PortTest.test_default_child_processes):
1094
1095 2011-12-05  Eric Seidel  <eric@webkit.org>
1096
1097         NRWT creates too many workers on RAM-limited machines
1098         https://bugs.webkit.org/show_bug.cgi?id=73847
1099
1100         Reviewed by Dirk Pranke.
1101
1102         Make NRWT restrict its number of workers when there isn't enough
1103         RAM to support them.
1104         Also re-enable parallel testing on the Mac bots which were
1105         failing due to not enough ram.
1106
1107         * Scripts/run-webkit-tests:
1108         (platformIsReadyForParallelTesting):
1109         * Scripts/webkitpy/common/host.py:
1110         (Host.__init__):
1111         * Scripts/webkitpy/common/system/executive_mock.py:
1112         (MockExecutive.cpu_count):
1113         * Scripts/webkitpy/common/system/platforminfo.py:
1114         (PlatformInfo.__init__):
1115         (PlatformInfo.display_name):
1116         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1117         (MockPlatformInfo.display_name):
1118         * Scripts/webkitpy/layout_tests/port/base.py:
1119         (Port.default_child_processes):
1120         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1121         (PortTest.test_default_child_processes):
1122         (PortTest.test_pretty_patch_os_error):
1123
1124 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
1125
1126         Last mouse event could be lost if a JS call to eventSender.leapForward is made
1127         https://bugs.webkit.org/show_bug.cgi?id=73366
1128
1129         Reviewed by Kenneth Rohde Christiansen.
1130
1131         Empty the entire event queue when requested besides using
1132         sendEvent instead of postEvent to make sure all events were
1133         delivered.
1134
1135         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1136         (WTR::EventSenderProxy::EventSenderProxy):
1137         (WTR::EventSenderProxy::sendOrQueueEvent):
1138         (WTR::EventSenderProxy::replaySavedEvents):
1139
1140 2011-12-05  Adam Barth  <abarth@webkit.org>
1141
1142         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
1143         https://bugs.webkit.org/show_bug.cgi?id=73845
1144
1145         Reviewed by Darin Fisher.
1146
1147         Update includes to point to the new header locations.
1148
1149         * DumpRenderTree/chromium/AccessibilityController.cpp:
1150         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1151         * DumpRenderTree/chromium/CppBoundClass.cpp:
1152         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1153         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1154         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1155         * DumpRenderTree/chromium/EventSender.cpp:
1156         * DumpRenderTree/chromium/EventSender.h:
1157         * DumpRenderTree/chromium/GamepadController.h:
1158         * DumpRenderTree/chromium/LayoutTestController.cpp:
1159         * DumpRenderTree/chromium/LayoutTestController.h:
1160         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1161         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1162         * DumpRenderTree/chromium/PlainTextController.cpp:
1163         * DumpRenderTree/chromium/Task.cpp:
1164         * DumpRenderTree/chromium/TestNavigationController.h:
1165         * DumpRenderTree/chromium/TestShell.cpp:
1166         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1167         * DumpRenderTree/chromium/TestWebPlugin.h:
1168         * DumpRenderTree/chromium/TextInputController.cpp:
1169         * DumpRenderTree/chromium/WebPermissions.cpp:
1170         * DumpRenderTree/chromium/WebPreferences.h:
1171         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1172         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1173         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1174         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1175         * DumpRenderTree/chromium/WebViewHost.cpp:
1176
1177 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
1178
1179         Add Aharon Lanin to the contributors list.
1180
1181         * Scripts/webkitpy/common/config/committers.py:
1182
1183 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
1184
1185         Moving myself from contributors to committers.
1186
1187         * Scripts/webkitpy/common/config/committers.py:
1188
1189 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1190
1191         Add myself as a committer.
1192
1193         * Scripts/webkitpy/common/config/committers.py:
1194
1195 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
1196
1197         [Qt] Rename QQuickWebView::canStop property to just loading 
1198         https://bugs.webkit.org/show_bug.cgi?id=73813
1199
1200         Reviewed by Kenneth Rohde Christiansen.
1201
1202         Replaced references to WebView.canStop with WebView.loading.
1203
1204         * MiniBrowser/qt/qml/BrowserWindow.qml:
1205
1206 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
1207
1208         run-webkit-tests: limit --child-processes properly on apple mac
1209         https://bugs.webkit.org/show_bug.cgi?id=73856
1210
1211         Reviewed by Adam Roben.
1212
1213         Fix typos in r102013 so that we correctly pass --child-processes=1 on
1214         the apple mac bots temporarily.
1215
1216         * Scripts/run-webkit-tests:
1217         (platformIsReadyForParallelTesting):
1218
1219 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
1220
1221         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
1222         https://bugs.webkit.org/show_bug.cgi?id=73840
1223
1224         Reviewed by Simon Fraser.
1225
1226         Temporarily go back to single process mode on Mac.
1227
1228         * Scripts/run-webkit-tests:
1229         (platformIsReadyForParallelTesting):
1230
1231 2011-12-05  Adam Roben  <aroben@apple.com>
1232
1233         Redeploy apple-macpro-7 and apple-xserve-1
1234
1235         These slaves have been sitting idle since we removed our Leopard builders in r97496.
1236
1237         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
1238         sitting idle
1239
1240         Reviewed by Sam Weinig.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
1243         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
1244         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
1245         (WebKit2 Tests)".
1246
1247 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1248
1249         [Qt] Make the UI of the MiniBrowser slightly nicer
1250
1251         Rubberstamped by Simon Hausmann.
1252
1253         - Add proper padding
1254         - Show feedback when pressing on the toolbar icons
1255         - Make the text entry better looking
1256
1257         * MiniBrowser/qt/qml/BrowserWindow.qml:
1258
1259 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1260
1261         NRWT should handle duplicated expectations
1262         https://bugs.webkit.org/show_bug.cgi?id=69750
1263
1264         Reviewed by Dirk Pranke.
1265
1266         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1267         (TestExpectations.__init__):
1268         (TestExpectations._report_errors):
1269         (TestExpectations._add_expectations):
1270         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1271         (test_add_skipped_tests):
1272         * Scripts/webkitpy/layout_tests/port/base.py:
1273         (Port.skipped_tests):
1274         * Scripts/webkitpy/layout_tests/port/webkit.py:
1275         (WebKitPort.test_expectations):
1276         (WebKitPort.skipped_tests):
1277         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1278         (test_test_expectations):
1279
1280 2011-12-04  Eric Seidel  <eric@webkit.org>
1281
1282         After success with Mac, Win and Gtk, turning on parallel testing
1283         by default for all platforms (except Qt).
1284
1285         We'll add more platforms to the blacklist if we see problems.
1286
1287         Unreviewed.
1288
1289         * Scripts/run-webkit-tests:
1290         (platformIsReadyForParallelTesting):
1291
1292 2011-12-04  Sam Weinig  <sam@webkit.org>
1293
1294         Add tests for RetainPtr::adoptNS/adoptCF
1295         https://bugs.webkit.org/show_bug.cgi?id=73470
1296
1297         Reviewed by Adam Roben and Darin Adler.
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
1301         (TestWebKitAPI::TEST):
1302         Test that adopting using adoptCF creates a RetainPtr with a
1303         value whose retain count is 1.
1304
1305         * TestWebKitAPI/Tests/WTF/ns: Added.
1306         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
1307         (TestWebKitAPI::TEST):
1308         Test that adopting using adoptNS creates a RetainPtr with a
1309         value whose retain count is 1.
1310
1311 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
1312
1313         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
1314         https://bugs.webkit.org/show_bug.cgi?id=73748
1315
1316         Reviewed by Gustavo Noronha Silva.
1317
1318         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
1319
1320 2011-12-04  Philippe Normand  <pnormand@igalia.com>
1321
1322         Another GTK build fix after r101922.
1323
1324         Rubber-stamped by Martin Robinson.
1325
1326         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1327         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
1328
1329 2011-12-04  Xan Lopez  <xlopez@igalia.com>
1330
1331         Fix compiler warning in LayoutTestController
1332
1333         Reviewed by Philippe Normand.
1334
1335         * DumpRenderTree/LayoutTestController.cpp:
1336         (LayoutTestController::LayoutTestController): fix warning.
1337
1338 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
1339
1340         Add missing methods used by fast/notifications tests to LayoutTestController
1341         https://bugs.webkit.org/show_bug.cgi?id=63616
1342
1343         Reviewed by Martin Robinson.
1344
1345         Add missing simulateDesktopNotificationClick method used by
1346         fast/notifications. Provide a default implementation for
1347         areDesktopNotificationPermissionRequestsIgnored and
1348         ignoreDesktopNotificationPermissionRequests.
1349
1350         * DumpRenderTree/LayoutTestController.cpp:
1351         (LayoutTestController::LayoutTestController): call into the port implementation.
1352         (simulateDesktopNotificationClickCallback): ditto.
1353         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
1354         (LayoutTestController::staticFunctions): declare new methods.
1355         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
1356         * DumpRenderTree/LayoutTestController.h:
1357         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
1358         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1359         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
1360         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1361         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1362         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1363         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1364         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1365         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1366         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1367         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1368
1369 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
1370
1371         [GTK] Don't log document events in DRT
1372         https://bugs.webkit.org/show_bug.cgi?id=73746
1373
1374         Reviewed by Martin Robinson.
1375
1376         Stop connecting globally to document-related events.
1377
1378         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1379         (connectAccessibilityCallbacks): Removed connections.
1380         (disconnectAccessibilityCallbacks): Removed disconnections.
1381
1382 2011-12-03  Dan Bernstein  <mitz@apple.com>
1383
1384         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
1385
1386         Reviewed by Darin Adler.
1387
1388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1389         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
1390         (TestWebKitAPI::TEST):
1391
1392 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1393
1394         Another GTK build fix after r101922.
1395
1396         Rubber-stamped by Martin James Robinson.
1397
1398         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1399         (LayoutTestController::pathToLocalResource): return value needs to
1400         be a URI.
1401
1402 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1403
1404         Small fix for my previous patch. Do not try to delete a member
1405         of a dictionary that does not exist.
1406
1407         Reviewed by Gustavo Noronha Silva.
1408
1409         * gtk/run-with-jhbuild:
1410         (install_and_run_jhbuild):
1411
1412 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1413
1414         Fix jhbuild installation for people who have unusual MAKE environment
1415         variables such as 'make -j4' as the jhbuild build does not handle it.
1416
1417         Reviewed by Gustavo Noronha Silva.
1418
1419         * gtk/run-with-jhbuild:
1420         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
1421
1422 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1423
1424         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
1425         when run for the first time.
1426
1427         Reviewed by Gustavo Noronha Silva.
1428
1429         * Scripts/update-webkitgtk-libs: Fix first run.
1430
1431 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1432
1433         Unreviewed, GTK build fix after r101922.
1434
1435         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1436         (LayoutTestController::pathToLocalResource): Added sentinel in
1437         g_build_filename call.
1438
1439 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1440
1441         GTK API tests build fix. Run the tests inside jhbuild.
1442
1443         Rubber-stamped by Gustavo Noronha Silva.
1444
1445         * Scripts/run-gtk-tests:
1446         (TestRunner.__init__):
1447         (TestRunner.run._error_handler):
1448         (TestRunner):
1449         (TestRunner.run):
1450
1451 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1452
1453         Small build fix. Properly specify the path to the locally installed jhbuild.
1454
1455         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
1456
1457 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1458
1459         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1460         https://bugs.webkit.org/show_bug.cgi?id=67256
1461
1462         Reviewed by Philippe Normand.
1463
1464         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
1465         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
1466         which points to the more generic top-level path of the WebKit checkout. This code is
1467         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
1468         share code here.
1469
1470         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
1471         location. This will cause the fallback to fail if you build into a non-typical location
1472         or even fake it with a symlink. In this case it's important to use the environment variable.
1473
1474         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1475         (getTopLevelPath): Added.
1476         (initializeFonts): Use the new helper to get the font path.
1477         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
1478         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1479         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
1480         test paths.
1481         * Scripts/webkitpy/layout_tests/port/gtk.py:
1482         (GtkPort.setup_environ_for_server):Pass the top-level path of the
1483         checkout instead of passing the font path.
1484         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1485         (WTR::getTopLevelPath): Added this helper.
1486         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
1487
1488 2011-12-02  David Levin  <levin@chromium.org>
1489
1490         Rename WTF class from TemporarilyChange to TemporaryChange.
1491         https://bugs.webkit.org/show_bug.cgi?id=73479
1492
1493         Reviewed by Eric Seidel.
1494
1495         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
1496         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
1497         * TestWebKitAPI/TestWebKitAPI.gypi:
1498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1499         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
1500         (TestWebKitAPI::TEST):
1501         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1502
1503 2011-12-02  Tony Chang  <tony@chromium.org>
1504
1505         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
1506         https://bugs.webkit.org/show_bug.cgi?id=73453
1507
1508         Reviewed by Ryosuke Niwa.
1509
1510         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
1511         The verbose output will include the failure reason.
1512
1513         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
1514         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1515         (write_test_result):
1516         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
1517         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
1518         (determine_result_type):
1519         (FailureReftestNoImagesGenerated.__init__):
1520         (FailureReftestNoImagesGenerated):
1521         (FailureReftestNoImagesGenerated.message):
1522         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
1523         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
1524         (MainTest.test_run_singly_actually_runs_tests):
1525         (MainTest.test_unexpected_failures):
1526         (EndToEndTest.test_end_to_end):
1527
1528 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
1529
1530         ChangeLog should be able to parse annotated changelogs
1531         https://bugs.webkit.org/show_bug.cgi?id=72703
1532
1533         Reviewed by Eric Seidel.
1534
1535         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
1536         and extract the revision number for each entry.
1537
1538         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
1539
1540         * Scripts/webkitpy/common/checkout/changelog.py:
1541         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1542         * Scripts/webkitpy/common/checkout/scm/git.py:
1543         * Scripts/webkitpy/common/checkout/scm/scm.py:
1544         * Scripts/webkitpy/common/checkout/scm/svn.py:
1545
1546 2011-12-02  Eric Seidel  <eric@webkit.org>
1547
1548         Enable parallel testing for Win and Gtk bots
1549         after confirming with Lucas and Martin the bots should be OK.
1550
1551         Unreviewed. (I ran the idea by Lucas and Martin.)
1552
1553         * Scripts/run-webkit-tests:
1554         (platformIsReadyForParallelTesting):
1555
1556 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
1557
1558         Try to fix the GTK+ build.
1559
1560         * gtk/jhbuild.modules: Properly specify the glib-networking
1561         dependency for soup.
1562
1563 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
1564
1565         Fix a syntax error in the committers.py file.
1566
1567         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
1568
1569 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
1570
1571         Add Alan Stearns and Peter Linss to the contributors list.
1572
1573         * Scripts/webkitpy/common/config/committers.py:
1574
1575 2011-12-02  Kent Tamura  <tkent@chromium.org>
1576
1577         [Chromium] Fix compilation warnings for ASSERT()
1578         https://bugs.webkit.org/show_bug.cgi?id=73623
1579
1580         Reviewed by Tony Chang.
1581
1582         * DumpRenderTree/chromium/ImageDiff.cpp:
1583          - Fix fprintf format: %s -> %d for __LINE__
1584          - Do nothing for ASSERT() if NDEBUG.
1585
1586 2011-12-02  Eric Seidel  <eric@webkit.org>
1587
1588         Enable parallel testing for all Mac bots.
1589
1590         Unreviewed.
1591
1592         * Scripts/run-webkit-tests:
1593         (platformIsReadyForParallelTesting):
1594
1595 2011-12-02  Eric Seidel  <eric@webkit.org>
1596
1597         Enable parallel testing for run-webkit-tests on Mac Lion.
1598         I plan to move all the machines to parallel testing shortly
1599         but we're starting with Lion.
1600
1601         Unreviewed.
1602
1603         * Scripts/run-webkit-tests:
1604         (platformIsReadyForParallelTesting):
1605
1606 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
1607
1608         Added helper method to identify whether the page has custom page size style.
1609         https://bugs.webkit.org/show_bug.cgi?id=73585
1610
1611         Reviewed by Darin Fisher.
1612
1613         * DumpRenderTree/chromium/LayoutTestController.cpp:
1614         (LayoutTestController::LayoutTestController):
1615         (LayoutTestController::hasCustomPageSizeStyle):
1616         * DumpRenderTree/chromium/LayoutTestController.h:
1617
1618 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
1619
1620         [NRWT] reftest should support having multiple references per test
1621         https://bugs.webkit.org/show_bug.cgi?id=73613
1622
1623         Reviewed by Dirk Pranke.
1624
1625         Add a support for having multiple reference files for a single test.
1626
1627         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
1628         at least one of expected mismatches, we compare expected mismatches first in order to minimize
1629         the number of reference files to open on DRT.
1630
1631         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1632         (interpret_test_failures): Remove checks no longer applicable.
1633         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1634         (ResultSummaryTest.test_interpret_test_failures): Ditto.
1635         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1636         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
1637         (SingleTestRunner._driver_input):
1638         (SingleTestRunner.run):
1639         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
1640         * Scripts/webkitpy/layout_tests/models/test_input.py:
1641         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
1642         * Scripts/webkitpy/layout_tests/port/base.py:
1643         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
1644         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
1645         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1646         (PortTest.test_parse_reftest_list):
1647         * Scripts/webkitpy/layout_tests/port/test.py:
1648         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1649         (MainTest.test_unexpected_failures):
1650         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
1651         (EndToEndTest.test_end_to_end):
1652         (EndToEndTest.test_reftest_with_two_notrefs): Added.
1653
1654 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1655
1656         Build libsoup without gnome dependencies (like keyring).
1657
1658         * gtk/jhbuild.modules:
1659
1660 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1661
1662         Also build gcrypt and p11-kit, and make them dependencies of
1663         gnutls.
1664
1665         * gtk/jhbuild.modules:
1666
1667 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
1668
1669         [wx] Unreviewed build fixes for Windows build.
1670
1671         * waf/build/wxpresets.py:
1672
1673 2011-12-01  Eric Seidel  <eric@webkit.org>
1674
1675         Reviewed by Adam Barth.
1676
1677         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
1678         https://bugs.webkit.org/show_bug.cgi?id=32006
1679
1680         I decided not to make it warn, and just have it re-open the bug.
1681         That's not that different from today's behavior which will
1682         just silently attach the patch.
1683
1684         This patch makes behavior between upload and land-safely consistent
1685         (previously one would assign patches and the other would not)
1686         as well as adds the ability for both to ensure that the bug is open.
1687
1688         To test this I had to add a few more methods to MockBugzilla which
1689         (positively) affected a few other test results.
1690
1691         I also made AbstractStep keep a cached copy of the Bug object
1692         and used the cached copy where appropriate (including for 'bug_title').
1693         This should reduce the number of bug fetches we perform.
1694
1695         * Scripts/webkitpy/tool/commands/download_unittest.py:
1696         * Scripts/webkitpy/tool/commands/upload.py:
1697         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1698         * Scripts/webkitpy/tool/mocktool.py:
1699         * Scripts/webkitpy/tool/steps/__init__.py:
1700         * Scripts/webkitpy/tool/steps/abstractstep.py:
1701         * Scripts/webkitpy/tool/steps/closebug.py:
1702         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
1703         * Scripts/webkitpy/tool/steps/postdiff.py:
1704         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1705         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1706         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1707         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1708
1709 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1710
1711         Also pass --no-interact to jhbuild when updating dependencies.
1712
1713         * Scripts/update-webkitgtk-libs:
1714
1715 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
1716
1717         Make _build_path check more thoroughly that build paths exist.
1718         https://bugs.webkit.org/show_bug.cgi?id=73601
1719
1720         Reviewed by Ojan Vafai.
1721
1722         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1723         (ChromiumMacPort._build_path):
1724
1725 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1726
1727         Add libffi to the jhbuild modules list as a glib dependency.
1728
1729         Rubber-stamped by Martin Robinson.
1730
1731         * gtk/jhbuild.modules:
1732
1733 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1734
1735         Build fix. Use internal pcre on glib, make gnutls a dependency of
1736         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
1737         in non-interactive mode.
1738
1739         * Scripts/update-webkitgtk-libs:
1740         * gtk/jhbuild.modules:
1741         * gtk/run-with-jhbuild:
1742
1743 2011-12-02  Adam Roben  <aroben@apple.com>
1744
1745         Fix for Python 2.6
1746
1747         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1748         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
1749         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
1750         searching for "Tests that timed out:" etc. This makes our check less strict, but it
1751         shouldn't matter given the kinds of content we parse.
1752
1753 2011-12-02  Adam Roben  <aroben@apple.com>
1754
1755         Fix names of failed/timed out tests in run-api-tests output
1756
1757         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
1758         out tests
1759
1760         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
1761
1762         Reviewed by Simon Fraser.
1763
1764         * Scripts/run-api-tests:
1765         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
1766         of this function.
1767
1768 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
1769
1770         [GTK] generate-gtkdoc should respect build type
1771         https://bugs.webkit.org/show_bug.cgi?id=73296
1772
1773         Reviewed by Philippe Normand.
1774
1775         * Scripts/webkitdirs.pm:
1776         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
1777         * gtk/common.py: If --build is passed give preference to the Debug build directory.
1778
1779 2011-12-02  Tony Chang  <tony@chromium.org>
1780
1781         [nrwt] fix wdiff output
1782         https://bugs.webkit.org/show_bug.cgi?id=73604
1783
1784         Reviewed by Adam Barth.
1785
1786         * Scripts/webkitpy/layout_tests/port/base.py:
1787         (Port.wdiff_text):
1788         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1789         (PortTest.test_wdiff_text):
1790
1791 2011-12-02  Adam Roben  <aroben@apple.com>
1792
1793         Teach build.webkit.org to display how many unit tests failed or timed out
1794
1795         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
1796         build.webkit.org
1797
1798         We now display something like "5 unit tests failed or timed out". Eventually we might want
1799         to split out how many failure vs. timeouts there were.
1800
1801         Reviewed by Darin Adler.
1802
1803         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1804         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
1805         classes that may want to subclass it.
1806         (RunUnitTests): Changed to inherit from TestWithFailureCount.
1807         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
1808         timed out:" and "Tests that failed:" lines, if present.
1809
1810         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1811         (StubStdio):
1812         (StubRemoteCommand):
1813         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
1814
1815         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
1816         the test run correctly.
1817
1818         (RunUnitTestsTest.test_no_failures_or_timeouts):
1819         (RunUnitTestsTest.test_one_failure):
1820         (RunUnitTestsTest.test_multiple_failures):
1821         (RunUnitTestsTest.test_one_timeout):
1822         (RunUnitTestsTest.test_multiple_timeouts):
1823         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
1824         Test various cases.
1825
1826 2011-12-02  Adam Roben  <aroben@apple.com>
1827
1828         Teach prepare-ChangeLog to treat master.cfg as a Python file
1829
1830         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
1831         in buildbot's master.cfg
1832
1833         Reviewed by Darin Adler.
1834
1835         * Scripts/prepare-ChangeLog:
1836         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
1837         master.cfg.
1838
1839 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
1840
1841         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
1842         https://bugs.webkit.org/show_bug.cgi?id=73669
1843
1844         Reviewed by Gustavo Noronha Silva.
1845
1846         Add a wrapper script that knows how to install jhbuild and also to wrap commands
1847         in the jhbuild shell.
1848
1849         * Scripts/webkitdirs.pm:
1850         (runAutogenForAutotoolsProject): Use the new wrapper script.
1851         (mustReRunAutogen): Ditto.
1852         (buildAutotoolsProject): Ditto.
1853         * Scripts/webkitpy/layout_tests/port/gtk.py:
1854         (GtkDriver.cmd_line): Ditto.
1855         * gtk/run-with-jhbuild: Added.
1856
1857 2011-12-01  Adam Roben  <aroben@apple.com>
1858
1859         Teach check-webkit-style how to check the syntax of JSON files
1860
1861         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
1862
1863         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
1864         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
1865         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
1866         been removed, since its output differs by platform.
1867
1868         Reviewed by Darin Adler.
1869
1870         * Scripts/webkitpy/style/checker.py:
1871         (_all_categories): Added JSONChecker's categories to the set of all categories.
1872         (FileType): Added a JSON type. Incremented other types.
1873         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
1874         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
1875
1876         * Scripts/webkitpy/style/checker_unittest.py:
1877         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
1878         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
1879
1880         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
1881         which would have matched our other checkers, because I couldn't figure out how to call
1882         "json.loads" without hitting namespace conflicts.)
1883         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
1884         just the modified lines from a patch.
1885         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
1886         exception.
1887         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
1888         try to extract a line number.
1889
1890         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
1891         (MockErrorHandler.__init__):
1892         (MockErrorHandler.turn_off_line_filtering):
1893         (MockErrorHandler.__call__):
1894         Helper class. Copied from xml_unittest.py.
1895
1896         (JSONCheckerTest.test_line_number_from_json_exception): Test the
1897         line_number_from_json_exception helper method.
1898
1899         (JSONCheckerTest.assert_no_error):
1900         (JSONCheckerTest.assert_error):
1901         Helper methods to assert that we did or didn't get an error.
1902
1903         (JSONCheckerTest.mock_handle_style_error): Helper method.
1904
1905         (JSONCheckerTest.test_conflict_marker):
1906         (JSONCheckerTest.test_single_quote):
1907         (JSONCheckerTest.test_init):
1908         (JSONCheckerTest.test_no_error):
1909         Test various cases.
1910
1911 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1912
1913         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
1914         https://bugs.webkit.org/show_bug.cgi?id=73664
1915
1916         Reviewed by Martin Robinson.
1917
1918         This patch adds our HTTP library and its main dependencies; this
1919         should not affect layout or rendering.
1920
1921         * gtk/jhbuild.modules:
1922
1923 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1924
1925         [GTK] Also run DumpRenderTree under jhbuild
1926         https://bugs.webkit.org/show_bug.cgi?id=73646
1927
1928         Reviewed by Martin Robinson.
1929
1930         * Scripts/webkitpy/layout_tests/port/gtk.py:
1931         (GtkDriver.cmd_line):
1932
1933 2011-12-02  Hajime Morrita  <morrita@chromium.org>
1934
1935         Unreviewed, rolling out r101751 and r101775.
1936         http://trac.webkit.org/changeset/101751
1937         http://trac.webkit.org/changeset/101775
1938         https://bugs.webkit.org/show_bug.cgi?id=73191
1939
1940         breaks Windows build
1941
1942         * DumpRenderTree/chromium/config.h:
1943         * DumpRenderTree/config.h:
1944         * TestWebKitAPI/config.h:
1945         * WebKitTestRunner/config.h:
1946
1947 2011-12-02  Kentaro Hara  <haraken@chromium.org>
1948
1949         Move run-bindings-tests implementation to webkitpy/bindings/main.py
1950         https://bugs.webkit.org/show_bug.cgi?id=73619
1951
1952         Reviewed by Adam Barth.
1953
1954         As run-bindings-tests has been growing, this patch just moves its implementation
1955         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
1956
1957         No change in behavior.
1958
1959         * Scripts/run-bindings-tests:
1960         (main):
1961         * Scripts/webkitpy/bindings/__init__.py: Added.
1962         * Scripts/webkitpy/bindings/main.py: Added.
1963         (BindingsTests.__init__):
1964         (BindingsTests.generate_from_idl):
1965         (BindingsTests.generate_supplemental_dependency):
1966         (BindingsTests.detect_changes):
1967         (BindingsTests.run_tests):
1968
1969 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
1970
1971         Tools/Scripts: eliminate find_test_files from Port class.
1972         https://bugs.webkit.org/show_bug.cgi?id=73553
1973
1974         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
1975         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
1976         Also I'll move _is_test_file() and related functions close to Port.tests().
1977
1978         Reviewed by Dirk Pranke.
1979
1980         * Scripts/webkitpy/layout_tests/port/base.py:
1981         (Port.tests):
1982         (Port.is_reference_html_file):
1983         (Port._has_supported_extension):
1984         (Port._is_test_file):
1985         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1986         (PortTest.test_find_no_paths_specified):
1987         (PortTest.test_find_one_test):
1988         (PortTest.test_find_glob):
1989         (PortTest.test_find_with_skipped_directories):
1990         (PortTest.test_find_with_skipped_directories_2):
1991         (PortTest.test_is_test_file):
1992         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1993         (_default_tests_paths):
1994         (ChromiumGpuLinuxPort.tests):
1995         (ChromiumGpuCgMacPort.tests):
1996         (ChromiumGpuMacPort.tests):
1997         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1998         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1999         (ChromiumGpuTest.test_default_tests_paths):
2000         (ChromiumGpuTest.test_test_files.test_paths):
2001         (ChromiumGpuTest):
2002         (ChromiumGpuTest.test_test_files):
2003         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2004         (get_tests_run.RecordingTestDriver.run_test):
2005         * Scripts/webkitpy/tool/commands/rebaseline.py:
2006         (OptimizeBaselines._optimize_baseline):
2007         (OptimizeBaselines.execute):
2008         (AnalyzeBaselines._analyze_baseline):
2009         (AnalyzeBaselines.execute):
2010
2011 2011-12-01  Hajime Morrita  <morrita@chromium.org>
2012
2013         JS_INLINE and WTF_INLINE should be visible from WebCore
2014         https://bugs.webkit.org/show_bug.cgi?id=73191
2015
2016         Reviewed by Kevin Ollivier.
2017
2018         Removed macro definitions which is now provided by Platform.h
2019
2020         * DumpRenderTree/chromium/config.h:
2021         * DumpRenderTree/config.h:
2022         * TestWebKitAPI/config.h:
2023         * WebKitTestRunner/config.h:
2024
2025 2011-12-01  Hayato Ito  <hayato@chromium.org>
2026
2027         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
2028         https://bugs.webkit.org/show_bug.cgi?id=73406
2029
2030         Reviewed by Ryosuke Niwa.
2031
2032         WebKitPort's image_diff uses tolerance='0.1' in default.
2033         When reftests fail, we should use tolerace=0 when diff-ing images.
2034
2035         Since ImageDiff on chromium port doesn't use tolerance value as of now,
2036         this change doesn't affect chromium port's behavior.
2037
2038         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2039         (write_test_result):
2040         * Scripts/webkitpy/layout_tests/port/base.py:
2041         (Port.diff_image):
2042         * Scripts/webkitpy/layout_tests/port/chromium.py:
2043         (ChromiumPort.diff_image):
2044         * Scripts/webkitpy/layout_tests/port/test.py:
2045         (TestPort.diff_image):
2046         * Scripts/webkitpy/layout_tests/port/webkit.py:
2047         (WebKitPort.diff_image):
2048         (WebKitPort._start_image_diff_process):
2049         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2050         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
2051
2052 2011-12-01  Adam Klein  <adamk@chromium.org>
2053
2054         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
2055         https://bugs.webkit.org/show_bug.cgi?id=73599
2056
2057         Reviewed by Ojan Vafai.
2058
2059         * TestResultServer/static-dashboards/builders.js:
2060         * TestResultServer/static-dashboards/dashboard_base.js:
2061         ():
2062         (htmlForTestTypeSwitcher):
2063         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2064         (testHtmlForTestTypeSwitcherGroup):
2065
2066 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
2067
2068         Parse reftest.list and extract types of ref tests
2069         https://bugs.webkit.org/show_bug.cgi?id=66837
2070
2071         Reviewed by Dirk Pranke.
2072
2073         Add support for reftest.list to base port.
2074
2075         * Scripts/webkitpy/common/find_files.py:
2076         (find):
2077         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2078         (SingleTestRunner.__init__):
2079         * Scripts/webkitpy/layout_tests/port/base.py:
2080         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
2081         to a dictionary of {test path: ("==" or "!=", reference file path)}
2082         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
2083         (Port._reference_file_for): Added; obtains the reference file name given a test name.
2084         (Port.is_reftest): Added; Calls _reference_file_for.
2085         (Port.reftest_expected_filename): Calls _reference_file_for.
2086         (Port.reftest_expected_mismatch_filename): Ditto.
2087         (Port.find_test_files):
2088         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
2089         -expected, -expected-mismach, -ref, or -notref as a reference file.
2090         (_is_test_file):
2091         (_parse_reftest_list): Added.
2092         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2093         (PortTest.test_is_test_file):
2094         (PortTest.test_parse_reftest_list):
2095         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2096         (DryrunDriver.run_test):
2097         * Scripts/webkitpy/layout_tests/port/test.py:
2098         (unit_test_filesystem.add_test_file):
2099         (unit_test_filesystem.add_file):
2100         (unit_test_filesystem):
2101         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2102         (get_tests_run.RecordingTestDriver.run_test):
2103         (MainTest.test_unexpected_failures):
2104         (MainTest.test_missing_and_unexpected_results):
2105         (EndToEndTest.test_end_to_end):
2106         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2107         (Rebaseliner._compile_rebaselining_tests):
2108
2109 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2110
2111         Unreviewed, rolling out r101711.
2112         http://trac.webkit.org/changeset/101711
2113         https://bugs.webkit.org/show_bug.cgi?id=73605
2114
2115         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
2116
2117         * Scripts/webkitpy/style/checker.py:
2118         (_all_categories):
2119         (FileType):
2120         (CheckerDispatcher._file_type):
2121         (CheckerDispatcher._create_checker):
2122         * Scripts/webkitpy/style/checker_unittest.py:
2123         (CheckerDispatcherDispatchTest.assert_checker_cpp):
2124         (CheckerDispatcherDispatchTest.test_cpp_paths):
2125         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
2126         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
2127
2128 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
2129
2130         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
2131
2132         * Scripts/webkitpy/common/config/watchlist:
2133
2134 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
2135
2136         [GTK] Read fonts from the jhbuild root
2137         https://bugs.webkit.org/show_bug.cgi?id=73487
2138
2139         Reviewed by Gustavo Noronha Silva.
2140
2141         Read fonts from the jhbuild root instead of from the system. This will ensure
2142         that all testers use the same fonts instead of leaving this up to luck.
2143
2144         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2145         (initializeFonts): Load fonts from jhbuild root.
2146         * Scripts/webkitpy/layout_tests/port/gtk.py:
2147         (GtkPort.setup_environ_for_server): Pass an environment variable containing
2148         the path to the jhbuild root.
2149         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2150         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
2151
2152 2011-12-01  Adam Roben  <aroben@apple.com>
2153
2154         Teach check-webkit-style how to check the syntax of JSON files
2155
2156         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
2157
2158         Reviewed by Darin Adler.
2159
2160         * Scripts/webkitpy/style/checker.py:
2161         (_all_categories): Added JSONChecker's categories to the set of all categories.
2162         (FileType): Added a JSON type. Incremented other types.
2163         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
2164         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
2165
2166         * Scripts/webkitpy/style/checker_unittest.py:
2167         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
2168         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
2169
2170         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
2171         which would have matched our other checkers, because I couldn't figure out how to call
2172         "json.loads" without hitting namespace conflicts.)
2173         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
2174         just the modified lines from a patch.
2175         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
2176         exception.
2177         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
2178         try to extract a line number.
2179
2180         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
2181         (MockErrorHandler.__init__):
2182         (MockErrorHandler.turn_off_line_filtering):
2183         (MockErrorHandler.__call__):
2184         Helper class. Copied from xml_unittest.py.
2185
2186         (JSONCheckerTest.test_line_number_from_json_exception): Test the
2187         line_number_from_json_exception helper method.
2188
2189         (JSONCheckerTest.assert_no_error):
2190         (JSONCheckerTest.assert_error):
2191         Helper methods to assert that we did or didn't get an error.
2192
2193         (JSONCheckerTest.mock_handle_style_error): Helper method.
2194
2195         (JSONCheckerTest.test_conflict_marker):
2196         (JSONCheckerTest.test_single_quote):
2197         (JSONCheckerTest.test_init):
2198         (JSONCheckerTest.test_missing_closing_brace):
2199         (JSONCheckerTest.test_no_error):
2200         Test various cases.
2201
2202 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
2203
2204         [GTK] Add a helper function to find the current executable's path
2205         https://bugs.webkit.org/show_bug.cgi?id=73473
2206
2207         Reviewed by Gustavo Noronha Silva.
2208
2209         Update MiniBrowser to not pass the binary directory as an environment variable.
2210         This means that you can move the binaries around without it breaking.
2211
2212         * MiniBrowser/gtk/main.c:
2213         (main): No longer set the environment variable.
2214         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
2215         * WebKitTestRunner/gtk/main.cpp:  Ditto.
2216
2217 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
2218
2219         Unreviewed. Fix bad file =(.
2220
2221         * gtk/jhbuild.modules:
2222         * Scripts/webkitdirs.pm:
2223         (runAutogenForAutotoolsProject):
2224
2225 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
2226
2227         [GTK] Add freetype to our jhbuild setup
2228         https://bugs.webkit.org/show_bug.cgi?id=73488
2229
2230         Reviewed by Martin Robinson.
2231
2232         This adds the first library to our jhbuild setup, and makes sure
2233         build-webkit calls autogen.sh and make with jhbuild, so that the
2234         environment is properly set.
2235
2236         * Scripts/webkitdirs.pm:
2237         (saveSum):
2238         (hashFile):
2239         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
2240         call autogen under jhbuild run;
2241         (mustRunAutogen): generalized the arguments change checking to also force
2242         running autogen when jhbuild files change;
2243         (buildAutotoolsProject): run make under jhbuild;
2244         * gtk/jhbuild.modules: add freetype.
2245
2246 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
2247
2248         Fix WebKitTestRunner compile warnings with XCode 3.2
2249         https://bugs.webkit.org/show_bug.cgi?id=73378
2250
2251         Reviewed by Chris Fleizach.
2252
2253         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2254         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2255         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2256         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2257         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2258         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2259         (WTR::AccessibilityUIElement::verticalScrollbar):
2260
2261 2011-12-01  Adam Roben  <aroben@apple.com>
2262
2263         Allow committers to use their Trac credentials to force builds on the buildbots
2264
2265         Fixes <http://webkit.org/b/73353>
2266
2267         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
2268         three files to do its job: a config file that contains a list of WebKit committer usernames,
2269         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
2270         those two files.
2271
2272         Reviewed by Darin Adler.
2273
2274         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
2275         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
2276         whether credentials were valid or not.
2277         (CommitterAuth.__init__): Just store the path to auth.json.
2278         (CommitterAuth.auth_json): Load, parse, and return auth.json.
2279         (CommitterAuth.auth_json_filename): Return the path to auth.json.
2280         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
2281         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
2282         checking those conditions.
2283         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
2284         false otherwise or if an exception was thrown.
2285         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
2286         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
2287
2288         (CommitterAuth.open_auth_json_file):
2289         (CommitterAuth.open_trac_credentials_file):
2290         (CommitterAuth.open_webkit_committers_file):
2291         Open the specified file. These are mostly useful for testing purposes.
2292
2293         (CommitterAuth.trac_credentials_filename):
2294         (CommitterAuth.webkit_committers_filename):
2295         Return the path to the specified file by retrieving it from auth.json.
2296
2297         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
2298         of WebKit committers from it.
2299
2300         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
2301         (CMStringIO.__enter__):
2302         (CMStringIO.__exit__):
2303         Helper class that makes it possible to use StringIO with the "with" statement.
2304
2305         (open_override): Helper context manager for overriding the global "open" function
2306         temporarily.
2307
2308         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
2309         tests.
2310         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
2311         "open" to test that the expected path was opened.
2312         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
2313         successfully.
2314         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
2315         somehow have no Trac account can't authenticate.
2316
2317         (CommitterAuthTest.test_fail_to_open_auth_json_file):
2318         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
2319         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
2320         Test what happens when we can't open the three files we depend upon.
2321
2322         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
2323         an authentication class.
2324
2325         (CommitterAuthTest.test_invalid_auth_json_file):
2326         (CommitterAuthTest.test_invalid_committers_file):
2327         (CommitterAuthTest.test_invalid_trac_credentials_file):
2328         (CommitterAuthTest.test_missing_auth_json_keys):
2329         Test what happens when the three files we depend upon are invalid in some way.
2330
2331         (CommitterAuthTest.test_open_auth_json_file):
2332         (CommitterAuthTest.test_open_trac_credentials_file):
2333         (CommitterAuthTest.test_open_webkit_committers_file):
2334         Test that we open the expected paths.
2335
2336         (CommitterAuthTest.test_trac_credentials_filename):
2337         (CommitterAuthTest.test_webkit_committers_filename):
2338         Test that we extract filenames out of auth.json correctly.
2339
2340         (CommitterAuthTest.test_non_committer_fails):
2341         (CommitterAuthTest.test_unknown_user_fails):
2342         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
2343         (CommitterAuthTest.test_wrong_password_fails):
2344         Test various failed authentication attempts.
2345
2346         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
2347         committers out of the committers file correctly.
2348
2349         (CommitterAuthTest.fake_auth_json_file):
2350         (CommitterAuthTest.invalid_auth_json_file):
2351         (CommitterAuthTest.fake_committers_file):
2352         (CommitterAuthTest.invalid_committers_file):
2353         (CommitterAuthTest.fake_htdigest_file):
2354         (CommitterAuthTest.invalid_htdigest_file):
2355         Return various fake files for testing.
2356
2357         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
2358         to be used for authentication in the web interface, and specify that only authenticated
2359         users may force builds.
2360
2361 2011-12-01  Adam Roben  <aroben@apple.com>
2362
2363         Add an HTDigestParser class to webkitpy
2364
2365         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
2366
2367         This class can be used to parse Apache's htdigest files and check whether a given
2368         username/realm/password tuple is present in the file. Eventually this will be used for
2369         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
2370
2371         Reviewed by Eric Seidel.
2372
2373         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
2374         (HTDigestParser.__init__): Stores the parsed representation of the file.
2375         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
2376         password and returns whether the resulting tuple is present in the file.
2377         (HTDigestParser.entries): Just returns the parsed representation of the file.
2378         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
2379         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
2380         whole file as invalid and all authentication attempts will fail.
2381
2382         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
2383         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
2384         optionally appended with some extra data, generates the expected entries.
2385         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
2386         authenticate, and tuples not present cannot.
2387         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
2388         fake_htdigest_file.
2389
2390         (HTDigestParserTest.test_empty_file):
2391         (HTDigestParserTest.test_too_few_colons):
2392         (HTDigestParserTest.test_too_many_colons):
2393         (HTDigestParserTest.test_invalid_hash):
2394         Test various forms of invalid files.
2395
2396         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
2397
2398 2011-12-01  Philippe Normand  <pnormand@igalia.com>
2399
2400         [GTK] Make the new 64-bit Release bot part of the core set
2401         https://bugs.webkit.org/show_bug.cgi?id=73570
2402
2403         Reviewed by Adam Roben.
2404
2405         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
2406         Debug bot which was already part of the core set. The GTK
2407         gardeners are willing to actively maintain it.
2408
2409         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2410         (BuildBot.__init__):
2411         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2412         (test_builder_name_regexps):
2413
2414 2011-12-01  Philippe Normand  <pnormand@igalia.com>
2415
2416         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
2417         https://bugs.webkit.org/show_bug.cgi?id=73547
2418
2419         Reviewed by Adam Roben.
2420
2421         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
2422         the 32-bit Debug configuration to 64-bit Release. The new slave is
2423         a 64-bit machine already. The 32-bit slave will be shut down.
2424
2425 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
2426
2427         [GTK] build-jsc should not trigger gtkdoc generation
2428         https://bugs.webkit.org/show_bug.cgi?id=73552
2429
2430         Reviewed by Philippe Normand.
2431
2432         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
2433         that build-jsc does not try to generate gtkdoc.
2434
2435         * Scripts/webkitdirs.pm:
2436         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
2437
2438 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2439
2440         tests_run0.txt gets clobbered when re-running failing tests
2441         https://bugs.webkit.org/show_bug.cgi?id=63844
2442
2443         Reviewed by Dirk Pranke.
2444
2445         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2446         (Manager.results_directory):
2447         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2448         (AbstractWorker.__init__):
2449         (_ManagerConnection.start_worker):
2450         (_InlineManager.start_worker):
2451         (_MultiProcessManager.start_worker):
2452         (_WorkerConnection.__init__):
2453         (_InlineWorkerConnection.__init__):
2454         (_MultiProcessWorkerConnection.__init__):
2455         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2456         (_TestWorker.__init__):
2457         (_TestsMixin.test_cancel):
2458         (_TestsMixin.test_done):
2459         (_TestsMixin.test_unknown_message):
2460         (InterfaceTest.test_managerconnection_is_abstract):
2461         (InterfaceTest.test_workerconnection_is_abstract):
2462         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2463         (Worker.__init__):
2464         (Worker.safe_init):
2465         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2466         (MainTest.test_retries_directory):
2467
2468 2011-12-01  Adam Roben  <aroben@apple.com>
2469
2470         Buildbot fix
2471
2472         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
2473         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
2474         it possible for build steps to reference things like the buildbotURL property of the config.
2475
2476 2011-11-30  Adam Roben  <aroben@apple.com>
2477
2478         Use curl for downloading builds to test slaves
2479
2480         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
2481         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
2482         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
2483         overhead (courtesy of the Twisted framework).
2484
2485         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
2486         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
2487         This should make the test slaves quite a bit faster, and should ease the CPU load on
2488         build.webkit.org a bit.
2489
2490         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
2491
2492         Reviewed by Mark Rowe.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
2495         to Test slaves. It's run just before DownloadBuiltProduct.
2496         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
2497         download.
2498         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
2499         FileDownload used to do this for us automatically.
2500
2501 2011-11-21  Philippe Normand  <pnormand@igalia.com>
2502
2503         [GTK] enable-webaudio websetting
2504         https://bugs.webkit.org/show_bug.cgi?id=69836
2505
2506         Reviewed by Martin Robinson.
2507
2508         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2509         (LayoutTestController::overridePreference): Update WebKitGTK
2510         enable-webaudio setting when a layout test requests it.
2511
2512 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
2513
2514         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
2515         https://bugs.webkit.org/show_bug.cgi?id=73079
2516
2517         The idea is to have performance tests for WebInspector.
2518         I was suggested to put these tests into PerformanceTests/inspector.
2519         They produce output in a format that is suitable for chromium perf bot drawing scripts.
2520
2521         I'd like to reuse code for scanning folders for test files.
2522         Because of the fact that original test_files.py has common and layout specific parts
2523         I decided to extract the generic part and put it into webkitpy/common
2524         I think the two packages with name test_files look strange but I have no idea about a better name.
2525
2526         Reviewed by Dirk Pranke.
2527
2528         * Scripts/run-inspector-perf-tests.py: Added.
2529         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
2530         (find):
2531         (_normalize):
2532         * Scripts/webkitpy/common/find_files_unittest.py: Added.
2533         (MockWinFileSystem.join):
2534         (MockWinFileSystem):
2535         (MockWinFileSystem.normpath):
2536         (TestWinNormalize.assert_filesystem_normalizes):
2537         (TestWinNormalize.test_mocked_win):
2538         (TestWinNormalize):
2539         (TestWinNormalize.test_win):
2540         * Scripts/webkitpy/layout_tests/port/base.py:
2541         (Port.tests):
2542         (Port.find_test_files):
2543         (Port._driver_class):
2544         (is_reference_html_file):
2545         (_has_supported_extension):
2546         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2547         (PortTest.test_find_no_paths_specified):
2548         (PortTest.test_find_one_test):
2549         (PortTest.test_find_glob):
2550         (PortTest.test_find_with_skipped_directories):
2551         (PortTest.test_find_with_skipped_directories_2):
2552         (PortTest):
2553         (PortTest.test_is_test_file):
2554         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2555         (_tests):
2556         * Scripts/webkitpy/layout_tests/port/test.py:
2557         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
2558         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2559         * Scripts/webkitpy/performance_tests/__init__.py: Added.
2560         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
2561         (PerfTestsRunner.__init__):
2562         (PerfTestsRunner._parse_args):
2563         (PerfTestsRunner._collect_tests._is_test_file):
2564         (PerfTestsRunner._collect_tests):
2565         (PerfTestsRunner.run):
2566         (PerfTestsRunner._run_tests_set):
2567         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
2568         (MainTest.TestPort):
2569         (MainTest.TestPort.create_driver):
2570         (MainTest.TestDriver.run_test):
2571         (MainTest.TestDriver):
2572         (MainTest.TestDriver.stop):
2573         (MainTest.create_runner):
2574         (MainTest.run_test):
2575         (MainTest.test_run_passing_test):
2576         (MainTest.test_run_silent_test):
2577         (MainTest.test_run_failed_test):
2578         (MainTest.test_run_tonguey_test):
2579         (MainTest.test_run_timeout_test):
2580         (MainTest.test_run_crash_test):
2581         (MainTest.test_run_test_set):
2582         (MainTest.test_collect_tests):
2583         (MainTest):
2584         (MainTest.test_parse_args):
2585         * Scripts/webkitpy/tool/commands/rebaseline.py:
2586         (OptimizeBaselines.execute):
2587         (AnalyzeBaselines.execute):
2588
2589 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
2590
2591         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
2592         https://bugs.webkit.org/show_bug.cgi?id=70838
2593
2594         Reviewed by James Robinson.
2595
2596         * DumpRenderTree/chromium/TestShell.cpp:
2597         (TestShell::resetWebSettings):
2598         * DumpRenderTree/chromium/TestShell.h:
2599         (TestShell::threadedCompositingEnabled):
2600         * DumpRenderTree/chromium/WebPreferences.cpp:
2601         (WebPreferences::reset):
2602         (WebPreferences::applyTo):
2603         * DumpRenderTree/chromium/WebPreferences.h:
2604         * DumpRenderTree/chromium/WebViewHost.cpp:
2605         (WebViewHost::WebViewHost):
2606         (WebViewHost::~WebViewHost):
2607
2608 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
2609
2610         AX: Nodes are reporting that focus can be set when they really can't
2611         https://bugs.webkit.org/show_bug.cgi?id=72791
2612
2613         Reviewed by Beth Dakin.
2614
2615         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2616         (AccessibilityUIElement::isFocusable):
2617         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2618         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2619         (WTR::AccessibilityUIElement::isFocusable):
2620
2621 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
2622
2623         Moved myself to the reviewers list.
2624
2625         * Scripts/webkitpy/common/config/committers.py:
2626
2627 2011-11-30  David Levin  <levin@chromium.org>
2628
2629         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
2630         https://bugs.webkit.org/show_bug.cgi?id=73415
2631
2632         Reviewed by Darin Fisher.
2633
2634         * DumpRenderTree/chromium/WebViewHost.cpp:
2635         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
2636         it being moved to a new interface and having the parameter removed.
2637         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
2638
2639 2011-11-30  Adam Roben  <aroben@apple.com>
2640
2641         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
2642
2643         This will make it a lot easier to investigate build failures on the bots.
2644
2645         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
2646
2647         Reviewed by Eric Seidel.
2648
2649         * Scripts/webkitpy/common/system/executive_mock.py:
2650         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
2651         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
2652         seen in practice.
2653
2654         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2655         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
2656         The Printer was modifying the root logger in way that would cause my new tests in
2657         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
2658         seem important to the functioning of this test, and passing False makes Printer not modify
2659         the root logger.
2660
2661         * Scripts/webkitpy/layout_tests/port/webkit.py:
2662         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
2663         up when --verbose is passed but not otherwise.
2664         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
2665         output at the ERROR level so it will always show up.
2666
2667         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2668         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
2669         cases. Test that the build scripts' output is logged when --verbose is passed or the build
2670         fails.
2671
2672 2011-11-30  Adam Roben  <aroben@apple.com>
2673
2674         Add a way to set OutputCapture's log level
2675
2676         This will be used by some unit tests I'm planning to add.
2677
2678         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
2679
2680         Reviewed by Eric Seidel.
2681
2682         * Scripts/webkitpy/common/system/outputcapture.py:
2683         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
2684         level we ever used before this patch.
2685         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
2686         being tested uses. Sets the log level for any current or future logging handlers.
2687         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
2688
2689         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
2690         (OutputCaptureTest.setUp): Create an OutputCapture to test.
2691         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
2692         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
2693         was logged.
2694         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
2695         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
2696         level.
2697
2698 2011-11-29  Beth Dakin  <bdakin@apple.com>
2699
2700         https://bugs.webkit.org/show_bug.cgi?id=72751
2701         WebKit2.MouseMoveAfterCrash API test is failing 
2702
2703         Reviewed by Sam Weinig.
2704
2705         Like DumpRenderTree, the NSWindow should act as an active window.
2706         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2707         (-[ActiveOffscreenWindow isKeyWindow]):
2708         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2709
2710 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
2711
2712         Add step to update gtk dependencies to the buildbot
2713         https://bugs.webkit.org/show_bug.cgi?id=73455
2714
2715         Reviewed by Martin Robinson.
2716
2717         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2718
2719 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2720
2721         [Qt] Add a fullscreen option to MiniBrowser.
2722         https://bugs.webkit.org/show_bug.cgi?id=73445
2723
2724         Reviewed by Noam Rosenthal.
2725
2726         This bypasses the compositor on the N9 to increase performances
2727         and remove the huge useless gray bar part of the window frame
2728         at the bottom.
2729
2730         * MiniBrowser/qt/BrowserWindow.cpp:
2731         (BrowserWindow::BrowserWindow):
2732         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2733         (printHelp):
2734         (MiniBrowserApplication::handleUserOptions):
2735         * MiniBrowser/qt/MiniBrowserApplication.h:
2736         (WindowOptions::setStartFullScreen):
2737         (WindowOptions::startFullScreen):
2738
2739 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
2740
2741         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
2742         https://bugs.webkit.org/show_bug.cgi?id=73425
2743
2744         Reviewed by Gustavo Noronha Silva.
2745
2746         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
2747         ensure that the jhbuild root is up-to-date. Currently the only module is
2748         the font module.
2749
2750         * Scripts/update-webkitgtk-libs: Added.
2751         * gtk/common.py: Added a helper to get the number of CPUs.
2752         * gtk/jhbuild.modules: Added.
2753         * gtk/jhbuildrc: Added.
2754
2755 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2756
2757         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
2758
2759         Reviewed by Csaba Osztrogonác.
2760
2761         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
2762         instead of one that pulls in JavaScriptCore headers.
2763         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
2764         with load(javascriptcore).
2765
2766 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2767
2768         Unreviewed, rolling out r101440 and r101442.
2769         http://trac.webkit.org/changeset/101440
2770         http://trac.webkit.org/changeset/101442
2771         https://bugs.webkit.org/show_bug.cgi?id=73429
2772
2773         multiple crashes on layout tests (Requested by hayato on
2774         #webkit).
2775
2776         * DumpRenderTree/chromium/TestShell.cpp:
2777         (TestShell::resetWebSettings):
2778         * DumpRenderTree/chromium/TestShell.h:
2779         * DumpRenderTree/chromium/WebPreferences.cpp:
2780         (WebPreferences::reset):
2781         (WebPreferences::applyTo):
2782         * DumpRenderTree/chromium/WebPreferences.h:
2783         * DumpRenderTree/chromium/WebViewHost.cpp:
2784         (WebViewHost::WebViewHost):
2785         (WebViewHost::~WebViewHost):
2786
2787 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
2788
2789         [Chromium] Fix broken DRT build for Aura Linux
2790         https://bugs.webkit.org/show_bug.cgi?id=72667
2791
2792         Reviewed by Tony Chang.
2793
2794         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
2795
2796         The following changes have been made:
2797
2798           1. Renamed TestShellAndroid to TestShellLinux.
2799           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
2800           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
2801
2802         * DumpRenderTree/DumpRenderTree.gypi:
2803         * DumpRenderTree/chromium/EventSender.cpp:
2804         (EventSender::keyDown):
2805         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2806         * DumpRenderTree/chromium/TestShellGtk.cpp:
2807         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
2808         (AlarmHandler):
2809         (TestShell::waitTestFinished):
2810         (setupFontconfig):
2811         (platformInit):
2812         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
2813         (checkLayoutTestSystemDependencies):
2814         (openStartupDialog):
2815
2816 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
2817
2818         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
2819         https://bugs.webkit.org/show_bug.cgi?id=73328
2820
2821         Reviewed by Kent Tamura.
2822
2823         * DumpRenderTree/chromium/LayoutTestController.cpp:
2824         (LayoutTestController::enableFixedLayoutMode):
2825         (LayoutTestController::setFixedLayoutSize):
2826
2827 2011-11-29  Hayato Ito  <hayato@chromium.org>
2828
2829         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
2830         https://bugs.webkit.org/show_bug.cgi?id=73381
2831
2832         Reviewed by Ryosuke Niwa.
2833
2834         This is a quick fix for the breakage of tests on non-chromium port.
2835         We should implement diff_image later on non-chromium ports.
2836
2837         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2838         (write_test_result):
2839
2840 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2841
2842         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2843         https://bugs.webkit.org/show_bug.cgi?id=72489
2844
2845         Reviewed by Eric Seidel.
2846
2847         Before the this fix always added "qt" option for the option list
2848         * Scripts/run-webkit-tests:
2849         * Scripts/webkitpy/layout_tests/port/qt.py:
2850
2851 2011-11-29  David Levin  <levin@chromium.org>
2852
2853         Add a way to revert a variable to its previous value after leaving a scope.
2854         https://bugs.webkit.org/show_bug.cgi?id=73371
2855
2856         Reviewed by Adam Barth.
2857
2858         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
2859         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
2860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2861         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2862         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
2863         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
2864
2865 2011-11-28  Kentaro Hara  <haraken@chromium.org>
2866
2867         Implement [Supplemental] IDL and support it in run-bindings-tests
2868         https://bugs.webkit.org/show_bug.cgi?id=73162
2869
2870         Reviewed by Adam Barth.
2871
2872         run-bindings-tests supports the [Supplemental] IDL in the following way.
2873             (1) It creates a file |x| listing all IDL files.
2874             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
2875             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
2876                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
2877                 including all attributes in IDL files that are supplementing the IDL file |z|.
2878
2879         * Scripts/run-bindings-tests:
2880         (generate_from_idl):
2881         (generate_supplemental_dependency):
2882         (detect_changes):
2883         (run_tests):
2884         (main):
2885
2886 2011-11-18  Nat Duca  <nduca@chromium.org>
2887
2888         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
2889         https://bugs.webkit.org/show_bug.cgi?id=70838
2890
2891         Reviewed by James Robinson.
2892
2893         * DumpRenderTree/chromium/TestShell.cpp:
2894         (TestShell::resetWebSettings):
2895         * DumpRenderTree/chromium/TestShell.h:
2896         (TestShell::threadedCompositingEnabled):
2897         * DumpRenderTree/chromium/WebPreferences.cpp:
2898         (WebPreferences::reset):
2899         (WebPreferences::applyTo):
2900         * DumpRenderTree/chromium/WebPreferences.h:
2901         * DumpRenderTree/chromium/WebViewHost.cpp:
2902         (WebViewHost::WebViewHost):
2903         (WebViewHost::~WebViewHost):
2904
2905 2011-11-29  Ojan Vafai  <ojan@chromium.org>
2906
2907         List of builders in the flakiness dashboard is out of date
2908         https://bugs.webkit.org/show_bug.cgi?id=73347
2909
2910         Reviewed by Adam Barth.
2911
2912         The chromium gpu bots no longer run layout tests, so kill that
2913         group entirely.
2914
2915         * TestResultServer/static-dashboards/builders.js:
2916         * TestResultServer/static-dashboards/dashboard_base.js:
2917
2918 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2919
2920         [Qt] Don't hard-code the list of WebKit2 generated sources
2921
2922         The generated sources are... wait for it... generated. So
2923         use the generator itself to figure out which sources we need
2924         to compile.
2925
2926         Reviewed by Simon Hausmann.
2927
2928         * qmake/mkspecs/features/default_post.prf:
2929
2930 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
2931
2932         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
2933         https://bugs.webkit.org/show_bug.cgi?id=73216
2934
2935         Reviewed by Philippe Normand.
2936
2937         Add a script that tries to sniff out 'make dist' problems without running
2938         'make dist.' 'make distcheck' takes a very long time to run and this should
2939         reduce the amount of times it needs to be run consecutively.
2940
2941         * gtk/common.py:
2942         (get_build_path.is_valid_build_directory): Guess the source directory
2943         by the existence of the GNUmakefile instead of the .libs directory. This
2944         allows one to run the script after running autogen.sh but before fully
2945         building.
2946         * gtk/find-make-dist-errors: Added.
2947
2948 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2949
2950         [Qt] Remove use of internal headers in the MiniBrowser
2951
2952         Reviewed by Simon Hausmann.
2953
2954         * MiniBrowser/qt/MiniBrowser.pro:
2955
2956 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
2957
2958         [Qt] Fix debug-shlib build without webkit2
2959
2960         Reviewed by Tor Arne Vestbø.
2961
2962         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
2963
2964 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
2965
2966         [Qt][WK2] Unreviewed buildfix after r101307.
2967
2968         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
2969
2970 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
2971
2972         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
2973         https://bugs.webkit.org/show_bug.cgi?id=72848
2974
2975         Add option to build-webkit.
2976
2977         Reviewed by Dimitri Glazkov.
2978
2979         * Scripts/build-webkit:
2980
2981 2011-11-28  Ojan Vafai  <ojan@chromium.org>
2982
2983         gtest normalization in the test results server is sometimes wrong
2984         https://bugs.webkit.org/show_bug.cgi?id=73262
2985
2986         Reviewed by Tony Chang.
2987
2988         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
2989         entries in the incremental JSON, one of the entries will have the correct data
2990         from the run and the other will have dummy no-data values. Make sure to
2991         always pick the one with real data.
2992
2993         * TestResultServer/model/jsonresults.py:
2994         (JsonResults._remove_gtest_modifiers):
2995         * TestResultServer/model/jsonresults_unittest.py:
2996         (JsonResultsTest.test_remove_gtest_modifiers):
2997
2998 2011-11-28  Ojan Vafai  <ojan@chromium.org>
2999
3000         Some of the results.json files have results/times entries at the directory level
3001         https://bugs.webkit.org/show_bug.cgi?id=73261
3002
3003         Reviewed by Tony Chang.
3004
3005         This is just a bug that got introduced in a temporary push of the results server.
3006         This patch repairs the broken files. After all the bots have cycled, we can simplify
3007         this code to just assert that results/times are not at the directory level.
3008
3009         Also, when catching exceptions, log the full stacktrace.
3010
3011         * TestResultServer/model/jsonresults.py:
3012         (_is_directory):
3013         (JsonResults._load_json):
3014         (JsonResults._merge_tests):
3015         (JsonResults.merge):
3016         * TestResultServer/model/jsonresults_unittest.py:
3017         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
3018
3019 2011-11-28  Tony Chang  <tony@chromium.org>
3020
3021         ews bots should pass --force to update-webkit-chromium
3022         https://bugs.webkit.org/show_bug.cgi?id=73230
3023
3024         Reviewed by Adam Barth.
3025
3026         This makes it less likely for gclient changes to break the bots (e.g.,
3027         if a DEPS repository moves or is switched to a branch).
3028
3029         Also pass --force when using |build-webkit --update-chromium| since this
3030         appears to only be used by the bots.
3031
3032         Take 2: Add Options.non_interactive to update.py's options() method.
3033
3034         * Scripts/update-webkit:
3035         * Scripts/webkitdirs.pm:
3036         (determineIsChromium): Add --force-update to update-webkit --chromium.
3037         (forceChromiumUpdate):
3038         (buildChromium): Pass --force to update-webkit-chromium.
3039         * Scripts/webkitpy/tool/steps/update.py:
3040         (Update.run): Add --force-update if non-interactive (i.e., bots).
3041         * Scripts/webkitpy/tool/steps/update_unittest.py:
3042
3043 2011-11-28  Tony Chang  <tony@chromium.org>
3044
3045         Revert r101279, broke the ews and cq bots.
3046
3047         * Scripts/update-webkit:
3048         * Scripts/webkitdirs.pm:
3049         (determineIsChromium):
3050         (buildChromium):
3051         * Scripts/webkitpy/common/config/ports.py:
3052         (WebKitPort.update_webkit_command):
3053         (ChromiumPort.update_webkit_command):
3054         * Scripts/webkitpy/common/config/ports_mock.py:
3055         (MockPort.update_webkit_command):
3056         * Scripts/webkitpy/tool/steps/update.py:
3057         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
3058
3059 2011-11-28  Ojan Vafai  <ojan@chromium.org>
3060
3061         testlistjson on the test results server doesn't understand hierarchical results format
3062         https://bugs.webkit.org/show_bug.cgi?id=73246
3063
3064         Reviewed by Tony Chang.
3065
3066         * TestResultServer/model/jsonresults.py:
3067         (JsonResults._delete_results_and_times):
3068         Instead of just getting the top-level keys, we now walk the tests tree and
3069         delete the results and times values.
3070
3071         * TestResultServer/model/jsonresults_unittest.py:
3072         Simplify the test harness to take in the same JSON format for the tests
3073         that the actual results.json uses instead of something very similar but
3074         needlessly different. This also allows for testing the broken case of
3075         results and times values being at non-leaf level.
3076
3077 2011-11-28  Tony Chang  <tony@chromium.org>
3078
3079         ews bots should pass --force to update-webkit-chromium
3080         https://bugs.webkit.org/show_bug.cgi?id=73230
3081
3082         Reviewed by Adam Barth.
3083
3084         This makes it less likely for gclient changes to break the bots (e.g.,
3085         if a DEPS repository moves or is switched to a branch).
3086
3087         Also pass --force when using |build-webkit --update-chromium| since this
3088         appears to only be used by the bots.
3089
3090         * Scripts/update-webkit:
3091         * Scripts/webkitdirs.pm:
3092         (determineIsChromium): Add --force-update to update-webkit --chromium.
3093         (forceChromiumUpdate):
3094         (buildChromium): Pass --force to update-webkit-chromium.
3095         * Scripts/webkitpy/tool/steps/update.py:
3096         (Update.run): Add --force-update if non-interactive (i.e., bots).
3097         * Scripts/webkitpy/tool/steps/update_unittest.py:
3098
3099 2011-11-28  Michael Saboff  <msaboff@apple.com>
3100
3101         Fixed help message for --exclude-kraken to say that
3102         it excludes Kraken and not SunSpider.
3103
3104         Rubber-stamped by Filip Pizlo.
3105
3106         * Scripts/bencher:
3107
3108 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3109
3110         Unreviewed, rolling out r101273.
3111         http://trac.webkit.org/changeset/101273
3112         https://bugs.webkit.org/show_bug.cgi?id=73244
3113
3114         multiple test failures and timeouts (Requested by tony^work on
3115         #webkit).
3116
3117         * DumpRenderTree/DumpRenderTree.gypi:
3118         * DumpRenderTree/chromium/EventSender.cpp:
3119         (EventSender::keyDown):
3120         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
3121         (AlarmHandler):
3122         (TestShell::waitTestFinished):
3123         (platformInit):
3124         (openStartupDialog):
3125         (checkLayoutTestSystemDependencies):
3126         * DumpRenderTree/chromium/TestShellGtk.cpp:
3127         (AlarmHandler):
3128         (setupFontconfig):
3129         (TestShell::waitTestFinished):
3130         (platformInit):
3131         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
3132         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
3133
3134 2011-11-28  John Yani  <vanuan@gmail.com>
3135
3136         new-run-webkit-tests is locale dependent
3137         https://bugs.webkit.org/show_bug.cgi?id=68691
3138
3139         Reviewed and modified by Eric Seidel.
3140
3141         This is a simpler version of John's patch which I'm landing.
3142         This just engages the hacks from the Host constructor on a global
3143         basis.
3144
3145         * Scripts/webkitpy/common/host.py:
3146         (Host.__init__):
3147         (Host._engage_awesome_locale_hacks):
3148
3149 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
3150
3151         [Chromium] Fix broken DRT build for Aura Linux
3152         https://bugs.webkit.org/show_bug.cgi?id=72667
3153
3154         Reviewed by Tony Chang.
3155
3156         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
3157
3158         The following changes have been made:
3159
3160           1. Renamed TestShellAndroid to TestShellLinux.
3161           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
3162           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
3163
3164         * DumpRenderTree/DumpRenderTree.gypi:
3165         * DumpRenderTree/chromium/EventSender.cpp:
3166         (EventSender::keyDown):
3167         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
3168         * DumpRenderTree/chromium/TestShellGtk.cpp:
3169         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
3170         (AlarmHandler):
3171         (TestShell::waitTestFinished):
3172         (setupFontconfig):
3173         (platformInit):
3174         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
3175         (checkLayoutTestSystemDependencies):
3176         (openStartupDialog):
3177
3178 2011-11-28  Eric Seidel  <eric@webkit.org>
3179
3180         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
3181         https://bugs.webkit.org/show_bug.cgi?id=71983
3182
3183         Reviewed by Adam Barth.
3184
3185         We'll add more code to Environment overtime,
3186         allowing us to mock out more of our direct interactions with os.environ.
3187
3188         This patch also makes run_command print the passed in environment.
3189
3190         * Scripts/webkitpy/common/host_mock.py:
3191         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3192         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3193         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3194         * Scripts/webkitpy/common/system/executive.py:
3195         * Scripts/webkitpy/common/system/executive_mock.py:
3196         * Scripts/webkitpy/layout_tests/port/webkit.py:
3197         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3198         * Scripts/webkitpy/tool/commands/download_unittest.py:
3199         * Scripts/webkitpy/tool/steps/build.py:
3200
3201 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
3202
3203         [Qt] Build system fixes against V8.
3204
3205         Reviewed by Tor Arne Vestbø.
3206
3207         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
3208         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
3209         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
3210
3211 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3212
3213         Make sure the useFixedLayout feature is consistently handled
3214         https://bugs.webkit.org/show_bug.cgi?id=73212
3215
3216         Reviewed by Simon Hausmann.
3217
3218         The web page parameters are set to our Qt defaults and are now altered
3219         in the WebKitTestRunner.
3220
3221         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3222         (WTR::WrapperWindow::WrapperWindow):
3223
3224 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
3225
3226         [Qt] WTF should be built as separate static library
3227         https://bugs.webkit.org/show_bug.cgi?id=73201
3228
3229         Reviewed by Tor Arne Vestbø.
3230
3231         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
3232         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
3233         thus wtf dependency.
3234         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
3235         * WebKitTestRunner/Target.pri: Ditto.
3236         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
3237         consider wtf, too.
3238         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
3239         moved into wtf.prf.
3240         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
3241         link in libwtf.
3242         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
3243
3244 2011-11-28  Kentaro Hara  <haraken@chromium.org>
3245
3246         run-bindings-tests shows diff error for a newly added binding test
3247         https://bugs.webkit.org/show_bug.cgi?id=73179
3248
3249         Reviewed by Adam Barth.
3250
3251         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
3252         run-bindings-tests just shows diff error because reference files
3253         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
3254
3255             FAIL: (V8) V8TestSupplemental.h
3256             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
3257
3258         Instead, this patch treats a non-existent reference file as an empty file and
3259         shows the result of the newly added binding test, like this:
3260
3261             FAIL: (V8) V8TestSupplemental.h
3262             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
3263             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
3264             @@ -0,0 +1,84 @@
3265             +/*
3266             +    This file is part of the WebKit open source project.
3267             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
3268             +
3269             (omitted)
3270
3271         * Scripts/run-bindings-tests:
3272         (detect_changes): Just added an -N option to the diff command.
3273
3274 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
3275
3276         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
3277         https://bugs.webkit.org/show_bug.cgi?id=73165
3278
3279         Reviewed by Philippe Normand.
3280
3281         Fix some syntax errors in this script and remove an unused variable.
3282
3283         * gtk/generate-gtkdoc:
3284         (get_webkit2_options.src_path): 
3285         (get_webkit2_options):
3286         (get_webkit1_options.src_path):
3287
3288 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
3289
3290         [wx] Unreviewed build fix. Enable the inspector.
3291         
3292         * waf/build/settings.py:
3293
3294 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
3295
3296         Try to fix the build after r101174.
3297
3298         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
3299
3300 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
3301
3302         [GTK] Integrate build-gtkdoc into build-webkit and make
3303         https://bugs.webkit.org/show_bug.cgi?id=72626
3304
3305         Reviewed by Philippe Normand.
3306
3307         * GNUmakefile.am: Added support for new scripts and "make docs".
3308         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
3309         (buildAutotoolsProject):
3310         * gtk/generate-gtkdoc: Added.
3311         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
3312
3313 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
3314
3315         [Qt] Add support for using OWRT with Qt5
3316         https://bugs.webkit.org/show_bug.cgi?id=72947
3317
3318         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
3319
3320         Reviewed by Csaba Osztrogonác.
3321
3322         * Scripts/old-run-webkit-tests:
3323
3324 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
3325
3326         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
3327         https://bugs.webkit.org/show_bug.cgi?id=73126
3328
3329         No need to have a separate client call for this. The front-end can store messages
3330         which arrive before front-end loaded and dispatch them later. This happens in layout
3331         tests only by the way as all other messages should be initiated by the front-end code.
3332
3333         Reviewed by Pavel Feldman.
3334
3335         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3336         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3337         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3338         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3339
3340 2011-11-24  Kentaro Hara  <haraken@chromium.org>
3341
3342         Replace subprocess.call() with subprocess.Popen()
3343         https://bugs.webkit.org/show_bug.cgi?id=73105
3344
3345         Reviewed by Adam Barth.
3346
3347         Currently, the stdout and stderr of the child processes of run-bindings-tests
3348         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
3349         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
3350         between a parent process and a child process. This patch replaces subprocess.call() with
3351         subprocess.Popen() and synchronizes the stdout and stderr between them.
3352         This patch also makes output messages of run-bindings-tests more readable.
3353
3354         With this patch, the output messages of run-bindings-tests look like as follows:
3355
3356             PASS: (CPP) WebDOMTestObj.h
3357             PASS: (CPP) WebDOMTestObj.cpp
3358             FAIL: (CPP) WebDOMTestInterface.h
3359             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
3360             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
3361             @@ -23,7 +23,7 @@
3362              #ifndef WebDOMTestInterface_h
3363              #define WebDOMTestInterface_h
3364
3365             -#if ENABLE(Condition1) || ENABLE(Condition2)
3366             +#if ENABLE(Condition1) || ENABLE(Condition3)
3367
3368              #include <WebDOMObject.h>
3369              #include <WebDOMString.h>
3370              @@ -53,5 +53,5 @@
3371              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
3372
3373              #endif
3374             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
3375             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
3376             PASS: (CPP) WebDOMFloat64Array.cpp
3377             PASS: (CPP) WebDOMFloat64Array.h
3378
3379             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
3380
3381         * Scripts/run-bindings-tests:
3382         (generate_from_idl):
3383         (detect_changes):
3384         (run_tests):
3385         (main):
3386
3387 2011-11-24  Kentaro Hara  <haraken@chromium.org>
3388
3389         Fix the current working directory of run-bindings-tests
3390         https://bugs.webkit.org/show_bug.cgi?id=73106
3391
3392         Reviewed by Adam Barth.
3393
3394         Currently, run-bindings-tests outputs the following error
3395         (although it outputs "all tests passed!" in the end):
3396
3397             Testing the ObjC generator on TestObj.idl
3398             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
3399             gcc: warning: '-x objective-c' after last input file has no effect
3400             gcc: no input files
3401
3402         This is because CodeGeneratorObjC.pm assumes that the current working directory
3403         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
3404         Thus, this patch changes it to WebKit/Source/.
3405
3406         * Scripts/run-bindings-tests:
3407         (generate_from_idl):
3408         (main):
3409
3410 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3411
3412         [Qt] Get rid of the buildDirForSource() function in the build system
3413
3414         At some point the plan was to allow for running qmake on sub-trees
3415         of the sources, into the top level build directory, but this is no
3416         longer possible, so no reason to keep the convenience function around.
3417
3418         Reviewed by Simon Hausmann.
3419
3420         * WebKitTestRunner/DerivedSources.pri:
3421         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3422         * qmake/mkspecs/features/default_post.prf:
3423         * qmake/mkspecs/features/default_pre.prf:
3424         * qmake/mkspecs/features/functions.prf:
3425         * qmake/mkspecs/features/javascriptcore.prf:
3426         * qmake/mkspecs/features/webcore.prf:
3427         * qmake/mkspecs/features/webkit2.prf:
3428
3429 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3430
3431         Unreviewed, rolling out r101107.
3432         http://trac.webkit.org/changeset/101107
3433         https://bugs.webkit.org/show_bug.cgi?id=73062
3434
3435         Breaks the commit-queue (Requested by abarth on #webkit).
3436
3437         * Scripts/webkitpy/common/host.py:
3438         (Host._engage_awesome_windows_hacks):
3439         * Scripts/webkitpy/common/host_mock.py:
3440         (MockHost.__init__):
3441         * Scripts/webkitpy/common/system/environment.py: Removed.
3442         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
3443         * Scripts/webkitpy/common/system/executive.py:
3444         (Executive._run_command_with_teed_output):
3445         (Executive.run_and_throw_if_fail):
3446         * Scripts/webkitpy/common/system/executive_mock.py:
3447         (MockExecutive.run_and_throw_if_fail):
3448         (MockExecutive.run_command):
3449         * Scripts/webkitpy/layout_tests/port/webkit.py:
3450         (WebKitPort._driver_build_script_name):
3451         (WebKitPort._run_script):
3452         (WebKitPort._build_driver):
3453         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3454         (test_build_driver):
3455         * Scripts/webkitpy/tool/commands/download_unittest.py:
3456         * Scripts/webkitpy/tool/steps/build.py:
3457         (Build.build):
3458
3459 2011-11-23  Ojan Vafai  <ojan@chromium.org>
3460
3461         Unreviewed, rolling out r101110.
3462         http://trac.webkit.org/changeset/101110
3463         https://bugs.webkit.org/show_bug.cgi?id=73057
3464
3465         The bots have now cycled and this patch is no longer needed.
3466
3467         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3468         (Manager._upload_json_files):
3469
3470 2011-11-23  Ojan Vafai  <ojan@chromium.org>
3471
3472         Temporarily save the incremental results json in order to identify bug
3473         https://bugs.webkit.org/show_bug.cgi?id=73057
3474
3475         Reviewed by Dean Jackson.
3476
3477         The test results server needed to be rolled back from tip of tree
3478         due to a JSON merging bug. It's hard to identify what the bug is without
3479         the raw data.
3480
3481         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3482         (Manager._upload_json_files):
3483
3484 2011-11-23  Ojan Vafai  <ojan@chromium.org>
3485
3486         Merging two version 4 results hits an error in the test results server
3487         https://bugs.webkit.org/show_bug.cgi?id=73042
3488
3489         Reviewed by Adam Barth.
3490
3491         The old code assumed that if the aggregate results value was not a leaf
3492         value that the incremental results would exist, which is just totally
3493         wrong. Added a test for that case as well.
3494
3495         * TestResultServer/model/jsonresults.py:
3496         (JsonResults._merge_tests):
3497         * TestResultServer/model/jsonresults_unittest.py:
3498         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
3499         (JsonResultsTest.test_merge_build_directory_hierarchy):
3500
3501 2011-11-23  Eric Seidel  <eric@webkit.org>
3502
3503         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
3504         https://bugs.webkit.org/show_bug.cgi?id=71983
3505
3506         Reviewed by Adam Barth.
3507
3508         We'll add more code to Environment overtime,
3509         allowing us to mock out more of our direct interactions with os.environ.
3510
3511         This patch also makes run_command print the passed in environment.
3512
3513         * Scripts/webkitpy/common/host_mock.py:
3514         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3515         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3516         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3517         * Scripts/webkitpy/common/system/executive.py:
3518         * Scripts/webkitpy/common/system/executive_mock.py:
3519         * Scripts/webkitpy/layout_tests/port/webkit.py:
3520         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3521         * Scripts/webkitpy/tool/commands/download_unittest.py:
3522         * Scripts/webkitpy/tool/steps/build.py:
3523
3524 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3525
3526         [Qt] Re-generate QtWebKit API forwarding headers when API changes
3527
3528         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
3529         so we need sync.profile to live in the same directory as the project file
3530         that will be touched when adding/removing API (api.pri in our case).
3531
3532         Since the WebKit2 APIs live in a separate static library, we have to
3533         add the project file for WebKit2 as a dependency of the api.pri file
3534         as well, so that any changes to the WebKit2 API will still trigger a
3535         run of qmake (and then syncqt).
3536
3537         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
3538         that the forwarding headers are still generated in the root build dir,
3539         not in the Source dir along with the internal forwarding headers.
3540
3541         Reviewed by Andreas Kling.
3542
3543         * qmake/mkspecs/features/default_pre.prf:
3544         * qmake/mkspecs/features/functions.prf:
3545
3546 2011-11-23  Johnny Ding  <jnd@chromium.org>
3547
3548         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
3549         https://bugs.webkit.org/show_bug.cgi?id=72950
3550
3551         Reviewed by Tony Chang.
3552
3553         * DumpRenderTree/chromium/LayoutTestController.cpp:
3554         (LayoutTestController::queueLoadHTMLString):
3555
3556 2011-11-23  Adam Barth  <abarth@webkit.org>
3557
3558         garden-o-matic should display a message if it can't find results to display
3559         https://bugs.webkit.org/show_bug.cgi?id=72991
3560
3561         Reviewed by Dimitri Glazkov.
3562
3563         Not all failures (e.g., TIMEOUT) have results that we can display.
3564         This patch adds a short message so that the user can see that we're
3565         done trying to load the results.
3566
3567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3570
3571 2011-11-23  Adam Barth  <abarth@webkit.org>
3572
3573         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
3574         https://bugs.webkit.org/show_bug.cgi?id=72992
3575
3576         Reviewed by Dimitri Glazkov.
3577
3578         This patch also prepares us to list other sorts of failures, like
3579         performance and unit test.
3580
3581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3585
3586 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
3587
3588         Add new Chromium tests to the flakiness dashboard
3589         https://bugs.webkit.org/show_bug.cgi?id=72997
3590
3591         Reviewed by Ojan Vafai.
3592
3593         * TestResultServer/static-dashboards/dashboard_base.js:
3594         ():
3595
3596 2011-11-23  Adam Barth  <abarth@webkit.org>
3597
3598         garden-o-matic should support AUDIO failures
3599         https://bugs.webkit.org/show_bug.cgi?id=69477
3600
3601         Reviewed by Dimitri Glazkov.
3602
3603         This is a first iteration at supporting AUDIO failures in
3604         garden-o-matic.  We'll probably need to iterate a bit when we have a
3605         real audio failure in the tree to play with.  For example, we'll
3606         probably want to add and <audio> element to the "Examine" view to hear
3607         the differences, but that all can be done in a subsequent patch.
3608
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3610
3611 2011-11-23  Scott Graham  <scottmg@chromium.org>
3612
3613         Adding gamepad support
3614         https://bugs.webkit.org/show_bug.cgi?id=69451
3615
3616         Reviewed by Darin Fisher.
3617
3618         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
3619         gamepad data that will be retrieved when JS code pulls via API access.
3620
3621         * DumpRenderTree/DumpRenderTree.gypi:
3622         * DumpRenderTree/chromium/GamepadController.cpp: Added.