2011-06-27 Kent Tamura <tkent@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-27  Kent Tamura  <tkent@chromium.org>
2
3         Reviewed by Hajime Morita.
4
5         [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
6         https://bugs.webkit.org/show_bug.cgi?id=63427
7
8         ~WebViewHost() navigates to about:blank, so it calls some
9         callbacks and LayoutTestController functions.
10
11         * DumpRenderTree/chromium/TestShell.h:
12          Move m_printer upper and move m_webViewHost lower.
13
14 2011-06-27  Adam Barth  <abarth@webkit.org>
15
16         Reviewed by Eric Seidel.
17
18         Move server config files to webkitpy.layout_tests.servers
19         https://bugs.webkit.org/show_bug.cgi?id=63436
20
21         The config files belong with the servers.
22
23         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
24         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
25         * Scripts/webkitpy/layout_tests/servers/http_server.py:
26         * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
27         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
28
29 2011-06-27  Adam Barth  <abarth@webkit.org>
30
31         Reviewed by Eric Seidel.
32
33         Move websocket_server and http_server to webkitpy.layout_package.servers
34         https://bugs.webkit.org/show_bug.cgi?id=63434
35
36         These classes do not represent ports.  They represent servers.
37
38         * Scripts/new-run-webkit-httpd:
39         * Scripts/new-run-webkit-websocketserver:
40         * Scripts/webkitpy/layout_tests/port/base.py:
41         * Scripts/webkitpy/layout_tests/port/chromium.py:
42         * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
43         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
44         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
45         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
46         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
47         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
48         * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
49         * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
50         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
51         * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
52
53 2011-06-27  Eric Seidel  <eric@webkit.org>
54
55         Reviewed by Adam Barth.
56
57         Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
58         https://bugs.webkit.org/show_bug.cgi?id=63428
59
60         * Scripts/webkitpy/layout_tests/port/chromium.py:
61         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
62
63 2011-06-27  Adam Barth  <abarth@webkit.org>
64
65         Reviewed by Eric Seidel.
66
67         Move apache_http_server.py to webkitpy.layout_package.servers
68         https://bugs.webkit.org/show_bug.cgi?id=63433
69
70         The apache_http_server.py is a server, not a port.
71
72         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
73         * Scripts/webkitpy/layout_tests/port/base.py:
74         * Scripts/webkitpy/layout_tests/servers: Added.
75         * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
76         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
77
78 2011-06-27  Adam Barth  <abarth@webkit.org>
79
80         Reviewed by Eric Seidel.
81
82         Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
83         https://bugs.webkit.org/show_bug.cgi?id=63432
84
85         This code isn't in the dependency cone of new-run-webkit-tests. It's
86         unclear what it's final home should be, but this patch moves it out of
87         layout_tests to simply the package.
88
89         * Scripts/rebaseline-chromium-webkit-tests:
90         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
91         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
92         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
93         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
94
95 2011-06-27  Adam Barth  <abarth@webkit.org>
96
97         Reviewed by Eric Seidel.
98
99         Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
100         https://bugs.webkit.org/show_bug.cgi?id=63429
101
102         This package as nothing to do with the layout_tests package.
103
104         * Scripts/update-webgl-conformance-tests:
105         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
106         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
107         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
108         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
109
110 2011-06-27  Adam Barth  <abarth@webkit.org>
111
112         Reviewed by Eric Seidel.
113
114         Move deduplicate_tests.py into webkitpy.to_be_moved
115         https://bugs.webkit.org/show_bug.cgi?id=63426
116
117         deduplicate_tests.py doesn't haven anything to do with layout tests.
118         It's really a separate script.  This patch moves it to the (new)
119         to_be_moved package so that it doesn't distract us when working on NRWT.
120
121         * Scripts/deduplicate-tests:
122         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
123         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
124         * Scripts/webkitpy/test/main.py:
125         * Scripts/webkitpy/to_be_moved: Added.
126         * Scripts/webkitpy/to_be_moved/__init__.py: Added.
127         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
128         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
129
130 2011-06-26  Adam Barth  <abarth@webkit.org>
131
132         Rubber-stamped by Eric Seidel.
133
134         Remove empty directory.
135
136         * Scripts/webkitpy/layout_tests/test_types: Removed.
137
138 2011-06-25  Naoki Takano  <honten@chromium.org>
139
140         Reviewed by Eric Seidel.
141
142         Change my entry from contributors to committers.
143         https://bugs.webkit.org/show_bug.cgi?id=63043
144
145         * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
146
147 2011-06-25  Adam Barth  <abarth@webkit.org>
148
149         Reviewed by Eric Seidel.
150
151         [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
152         https://bugs.webkit.org/show_bug.cgi?id=63394
153
154         * DumpRenderTree/chromium/LayoutTestController.cpp:
155         (LayoutTestController::queueLoad):
156
157 2011-06-25  Brent Fulgham  <bfulgham@webkit.org>
158
159         Unreviewed build correction after r89426.
160
161         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
162           Link with Cairo DLL for new functionality.
163         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
164           code for snprintf.
165
166 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
167
168         Reviewed by Adam Barth.
169
170         run-bindings-tests does not work on Chromium Windows.
171         https://bugs.webkit.org/show_bug.cgi?id=63382
172
173         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
174
175 2011-06-25  Dan Bernstein  <mitz@apple.com>
176
177         Try to fix the Qt and Chromium builds.
178
179         * DumpRenderTree/chromium/LayoutTestController.cpp:
180         (LayoutTestController::setEncodedAudioData):
181         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
182
183 2011-06-24  Dan Bernstein  <mitz@apple.com>
184
185         Reviewed by Anders Carlsson.
186
187         Add an option to enable legacy rounding hacks
188         https://bugs.webkit.org/show_bug.cgi?id=63363
189
190         Added layoutTestController.allowRoundingHacks() and implemented it
191         on OS X.
192
193         * DumpRenderTree/LayoutTestController.cpp:
194         (allowRoundingHacksCallback):
195         (LayoutTestController::staticFunctions):
196         * DumpRenderTree/LayoutTestController.h:
197         * DumpRenderTree/chromium/LayoutTestController.cpp:
198         (LayoutTestController::allowRoundingHacks):
199         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
200         (LayoutTestController::allowRoundingHacks):
201         * DumpRenderTree/mac/DumpRenderTree.mm:
202         (resetWebViewToConsistentStateBeforeTesting):
203         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
204         (LayoutTestController::allowRoundingHacks):
205         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
206         (LayoutTestController::allowRoundingHacks):
207         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
208         (LayoutTestController::allowRoundingHacks):
209         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
210         (LayoutTestController::allowRoundingHacks):
211
212 2011-06-24  Adam Roben  <aroben@apple.com>
213
214         Include the directory containing the failing tests in titles of bugs filed from TestFailures
215         when all the tests won't fit
216
217         Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
218         which tests are failing
219
220         Reviewed by David Kilzer.
221
222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
223         (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
224         that ends in a path separator.
225
226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
227         (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
228         in the title, first try to include the longest common prefix of the test names, then, if
229         that's still too long or there's no common prefix, fall back to not including any
230         information about which tests are failing.
231
232 2011-06-24  Adam Roben  <aroben@apple.com>
233
234         Include links to Trac in bugs filed from TestFailures
235
236         Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
237         Trac for suspect revisions
238
239         Reviewed by David Kilzer.
240
241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
242         (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
243         Trac.
244
245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
246         (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
247         include a link to Trac for it in the first sentence of the description. Otherwise include a
248         link to the suspect range after the list of failing tests.
249
250 2011-06-24  Nat Duca  <nduca@chromium.org>
251
252         Unreviewed, rolling out r89694.
253         http://trac.webkit.org/changeset/89694
254         https://bugs.webkit.org/show_bug.cgi?id=58408
255
256         Test shell still not ready for animate changes.
257
258         * DumpRenderTree/chromium/WebViewHost.cpp:
259         (WebViewHost::paintInvalidatedRegion):
260
261 2011-06-24  Adam Roben  <aroben@apple.com>
262
263         Fix typos introduced in r89696
264
265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
266         (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
267         callback, since that's what it expects.
268
269 2011-06-24  Adam Roben  <aroben@apple.com>
270
271         Make TestFailures correctly remember whether old-run-webkit-tests exited early
272
273         Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
274         completion after reload
275
276         Reviewed by David Kilzer.
277
278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
279         (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
280         in the PeristentCache, store an object that contains both the number of failures and whether
281         old-run-webkit-tests exited early.
282
283 2011-06-24  Adam Roben  <aroben@apple.com>
284
285         Add links to regression ranges in Trac to the TestFailures page
286
287         Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
288         links to regression ranges in Trac
289
290         Reviewed by David Kilzer.
291
292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
293         (Trac): This new class represents a particular instance of Trac for a single project.
294         (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
295         repository path between the two specified revisions
296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
297         (ViewController): Added new trac argument.
298         (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
299         passed/failed builds from here...
300         (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
301         Trac if there are multiple suspect revisions.
302
303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
304         Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
305
306 2011-05-17  Nat Duca  <nduca@chromium.org>
307
308         Reviewed by James Robinson.
309
310         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
311         https://bugs.webkit.org/show_bug.cgi?id=58408
312
313         * DumpRenderTree/chromium/WebViewHost.cpp:
314         (WebViewHost::paintInvalidatedRegion):
315
316 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
317
318         Reviewed by Dimitri Glazkov.
319
320         Convert shadow DOM-related tests to use window.internals
321         https://bugs.webkit.org/show_bug.cgi?id=61671
322
323         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
324         removeShadowRoot from layoutTestController; these have been
325         replaced by equivalents in window.internals instead.
326
327         * DumpRenderTree/LayoutTestController.cpp:
328         (LayoutTestController::staticFunctions):
329         * DumpRenderTree/LayoutTestController.h:
330         * DumpRenderTree/chromium/LayoutTestController.cpp:
331         (LayoutTestController::LayoutTestController):
332         * DumpRenderTree/chromium/LayoutTestController.h:
333         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
334         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
336         * DumpRenderTree/qt/LayoutTestControllerQt.h:
337         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
338         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
339         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
340         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
341         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
342
343 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
344
345         Reviewed by Dirk Schulze.
346
347         Make run-bindings-tests remove its temporary directories.
348         https://bugs.webkit.org/show_bug.cgi?id=63320
349
350         * Scripts/run-bindings-tests:
351
352 2011-06-23  MORITA Hajime  <morrita@google.com>
353
354         Reviewed by Kent Tamura.
355
356         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
357         https://bugs.webkit.org/show_bug.cgi?id=63216
358
359         Deleted m_webViewHost which looks leaked.
360         
361         * DumpRenderTree/chromium/TestShell.h:
362         * DumpRenderTree/chromium/TestShell.cpp:
363         (TestShell::~TestShell):
364
365 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
366
367         Unreviewed. Fix WebKit2 GTK build.
368
369         * WebKitTestRunner/GNUmakefile.am:
370
371 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
372
373         Unreviewed, add myself as committer.
374
375         * Scripts/webkitpy/common/config/committers.py:
376
377 2011-06-23  Nat Duca  <nduca@chromium.org>
378
379         Unreviewed, add myself as committer.
380
381         * Scripts/webkitpy/common/config/committers.py:
382
383 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
384
385         Reviewed by Tony Chang.
386
387         nrwt: move http locking code into manager
388         https://bugs.webkit.org/show_bug.cgi?id=63103
389
390         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
391         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
392
393 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
394
395         Reviewed by James Robinson.
396
397         [chromium] Add support for running layout tests with accelerated rendering
398         https://bugs.webkit.org/show_bug.cgi?id=63274
399
400         * Scripts/webkitpy/layout_tests/port/chromium.py:
401         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
402
403 2011-06-23  Adam Roben  <aroben@apple.com>
404
405         Avoid fetching JSON data when possible on TestFailures page to determine if
406         old-run-webkit-tests exited early
407
408         As of r89610, results.html includes information about whether old-run-webkit-tests exited
409         early, so we don't need to look at JSON data to get this information for builds newer than
410         that.
411
412         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
413         which is slow and limits history to the last build master restart
414
415         Reviewed by David Kilzer.
416
417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
418         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
419         function. If we're dealing with a build that has early-exit information in results.html,
420         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
421         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
422         (as before).
423
424 2011-06-23  Eric Seidel  <eric@webkit.org>
425
426         Reviewed by Adam Barth.
427
428         sheriffbot can no longer restart
429         https://bugs.webkit.org/show_bug.cgi?id=63221
430
431         Fixed and unit tested.
432
433         * Scripts/webkitpy/tool/bot/queueengine.py:
434         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
435         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
436
437 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
438
439         Reviewed by Xan Lopez.
440
441         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
442         https://bugs.webkit.org/show_bug.cgi?id=63287
443
444         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
445         so that the plugin loads properly.
446
447         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
448         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
449         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
450         of the work for getting an environment variable and converting it to UTF-8.
451         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
452         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
453
454 2011-06-23  Adam Roben  <aroben@apple.com>
455
456         Record whether old-run-webkit-tests aborted early in results.html
457
458         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
459         old-run-webkit-tests stopped running tests early
460
461         Reviewed by David Kilzer.
462
463         * Scripts/old-run-webkit-tests:
464         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
465         Added a <style> element with some styles for the new message. If we stopped running early,
466         put the reason why at the top of results.html.
467         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
468         $stoppedRunningEarlyMessage global.
469
470 2011-06-23  Adam Roben  <aroben@apple.com>
471
472         Cache some of the TestFailures page's data in localStorage
473
474         This makes reloading TestFailures much faster. Right now we only store the number of failing
475         tests and the list of failing tests for each build. We may choose to store more later, but
476         it's easy to run up against quota limits.
477
478         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
479         APIs (or similar) to improve loading performance
480
481         Reviewed by David Kilzer.
482
483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
484         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
485         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
486         fetching data to the callback.
487         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
488         store the tests in the cache just before calling the callback. (The previous code in this
489         function relied on being able to modify the tests object after storing it in the cache and
490         having the cached version be updated. This worked while it was a non-serialized cache, but
491         PersistentCache uses serialization.)
492
493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
494         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
495         values, and stores the date that each value was initially stored along with it. This is
496         later used for pruning the cache.
497         (PersistentCache.contains): Checks whether the key exists in localStorage.
498         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
499         value out of it.
500         (PersistentCache.set): Serialize the value, add the date to it, and store it in
501         localStorage. If this fails due to quota limits, empty the whole cache and try again.
502         (PersistentCache.prune): Delete any cached data that is deemed old enough.
503         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
504         (PersistentCache._emptyCache): Delete everything from localStorage.
505         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
506         return them.
507
508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
509         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
510         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
511         where we'd never show the new bug link for tests for which we couldn't determine a passing
512         revision.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
515         PersistentCache.js.
516
517 2011-06-23  Adam Roben  <aroben@apple.com>
518
519         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
520
521         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
522         contain titles that are so long they are rejected by Bugzilla
523
524         Reviewed by David Kilzer.
525
526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
527         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
528         using a query string on the URL. If the search query is very long, using a query string can
529         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
530         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
531
532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
533         (.new-bug-form): Hide the form that we secretly use to file a new bug.
534
535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
536         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
537         query parameters to the URL. Otherwise, send them as the body of the request along with the
538         appropriate headers.
539         (getResource): Now just calls through to fetchResource.
540         (urlEncodedQueryParameters): Added. Moved some code here...
541         (addQueryParametersToURL): ...from here.
542
543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
544         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
545         number of failing tests if mentioning all the tests would make the title too long. Improved
546         the description for large numbers of failures by listing the tests one-per-line instead of
547         just having them be comma-separated, which was hard to read. Use a form to file the new bug
548         instead of a link so that we can POST the form data. (Using a URL with a query string can
549         result in the URL being too long.) The new bug link now just submits the form.
550
551 2011-06-23  Adam Roben  <aroben@apple.com>
552
553         Show closed bugs on the TestFailures page in addition to open ones
554
555         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
556
557         Reviewed by David Kilzer.
558
559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
560         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
561         returned data.
562         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
563         the associated bug is still open.
564
565         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
566         (addQueryParametersToURL): Add a missing semicolon.
567         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
568         object and appends each of the values stored within.
569
570         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
571         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
572         bugs will be included in the results. Split the returned bugs into two sets: those which are
573         open, and those which are closed. Put the open bugs at the top level of the list, and the
574         closed bugs in a second level.
575
576 2011-06-23  Adam Roben  <aroben@apple.com>
577
578         Don't count new tests as failures on the TestFailures page
579
580         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
581         they aren't
582
583         Reviewed by Anders Carlsson.
584
585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
586         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
587         of failures.
588
589 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
590
591         Reviewed by Eric Seidel.
592
593         nrwt: make TestInput objects printable
594         https://bugs.webkit.org/show_bug.cgi?id=63225
595
596         This makes debugging slighlty easier.
597
598         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
599
600 2011-06-22  Daniel Bates  <dbates@webkit.org>
601
602         Reviewed by Adam Barth.
603
604         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
605         https://bugs.webkit.org/show_bug.cgi?id=62943
606
607         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
608         by Scripts/webkitpy/common/checkout/__init__.py.
609
610         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
611
612 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
613
614         Reviewed by Mark Rowe.
615
616         Add window.internals to WebKit2's WebKitTestRunner.
617         https://bugs.webkit.org/show_bug.cgi?id=61073
618
619         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
620         * WebKitTestRunner/Configurations/Base.xcconfig:
621         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
622         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
623         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
624         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
625         (WTR::InjectedBundlePage::didClearWindowForFrame):
626         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
627         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
628
629 2011-06-22  Eric Seidel  <eric@webkit.org>
630
631         Reviewed by Adam Barth.
632
633         Make sheriff-bot rollout messages a little nicer
634         https://bugs.webkit.org/show_bug.cgi?id=63107
635
636         itertools.chain.from_iterable is new in 2.6,
637         use itertools.chain(*list) for 2.5 compat.
638
639         * Scripts/webkitpy/tool/bot/irc_command.py:
640
641 2011-06-22  Eric Seidel  <eric@webkit.org>
642
643         Reviewed by Adam Barth.
644
645         Make sheriff-bot robust against exceptions from commands
646         https://bugs.webkit.org/show_bug.cgi?id=63211
647
648         sheriff-bot was acting strange this afternoon.
649         We don't know if this will fix the cause, but
650         at least it adds some unit tests and catches
651         one possible cause.
652
653         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
654         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
655
656 2011-06-22  Mark Rowe  <mrowe@apple.com>
657
658         Reviewed by David Levin.
659
660         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
661
662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
663         be relative to the built products directory rather than using a hard-coded path. Remove the
664         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
665         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
666         rather than in the .xcodeproj directly.
667
668 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
669
670         Reviewed by Ojan Vafai.
671
672         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
673         https://bugs.webkit.org/show_bug.cgi?id=59993
674
675         * Scripts/webkitpy/layout_tests/port/base.py:
676         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
677         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
678         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
679         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
680         * Scripts/webkitpy/layout_tests/port/gtk.py:
681         * Scripts/webkitpy/layout_tests/port/mac.py:
682         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
683         * Scripts/webkitpy/layout_tests/port/qt.py:
684         * Scripts/webkitpy/layout_tests/port/win.py:
685
686 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
687
688         Reviewed by Andreas Kling.
689
690         Move macpherson from contributor list to committer list.
691         https://bugs.webkit.org/show_bug.cgi?id=63179
692
693         * Scripts/webkitpy/common/config/committers.py:
694         Move macpherson from contributor list to committer list.
695
696 2011-06-22  David Levin  <levin@chromium.org>
697
698         Reviewed by Adam Barth.
699
700         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
701         https://bugs.webkit.org/show_bug.cgi?id=63204
702
703         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
704           with similar code for the parameter checking.
705         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
706           those done for single lines since they don't make sense in that case (variable decls look like function decls).
707           Removed some redundant comments (one of which was slightly wrong).
708           Added checks for the new functionality and minor other test changes.
709
710 2011-06-22  Nate Chapin  <japhet@chromium.org>
711
712         Reviewed by Adam Barth.
713
714         Add libsoup to libWebCoreInternals build.
715         https://bugs.webkit.org/show_bug.cgi?id=62066
716
717         * GNUmakefile.am:
718
719 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
720
721         Reviewed by Tony Chang.
722
723         nrwt: handle missing httpd cleanly
724         https://bugs.webkit.org/show_bug.cgi?id=62027
725
726         We had reverted the change in r89414, so this adds it back in
727         (modifying check_sys_deps() in port/base.py to check for an
728         installed web server).
729
730         This change then fixes the change in r89414 to stub out the
731         check_sys_deps() in the test port so that the unit tests run correctly.
732
733         * Scripts/webkitpy/layout_tests/port/base.py:
734         * Scripts/webkitpy/layout_tests/port/test.py:
735
736 2011-06-22  David Levin  <levin@chromium.org>
737
738         Reviewed by Adam Barth.
739
740         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
741         https://bugs.webkit.org/show_bug.cgi?id=63188
742
743         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
744         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
745
746 2011-06-22  Tony Chang  <tony@chromium.org>
747
748         Reviewed by Ojan Vafai.
749
750         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
751         https://bugs.webkit.org/show_bug.cgi?id=62891
752
753         * BuildSlaveSupport/build.webkit.org-config/config.json:
754
755 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
756
757         Reviewed by Ojan Vafai.
758
759         nrwt: don't look for http lock when running the test port
760         https://bugs.webkit.org/show_bug.cgi?id=63158
761
762         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
763         * Scripts/webkitpy/layout_tests/port/test.py:
764
765 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
766
767         Reviewed by Andreas Kling.
768
769         [Qt][WK2] Set up plugin tests
770         https://bugs.webkit.org/show_bug.cgi?id=63066
771
772         * WebKitTestRunner/qt/TestControllerQt.cpp:
773         (WTR::TestController::initializeTestPluginDirectory):
774         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
775         of the test plugin like DRT does.
776
777 2011-06-22  Eric Seidel  <eric@webkit.org>
778
779         Reviewed by Ojan Vafai.
780
781         Make sheriff-bot rollout messages a little nicer
782         https://bugs.webkit.org/show_bug.cgi?id=63107
783
784         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
785         into urls myself.  So I have now fixed its "preparing" message to include a url.
786
787         I also figured that I should make the messages mention all of the responsible parties
788         so that rollouts are never surprises.  If you're in the channel and were involved
789         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
790
791         As part of doing this I also changed (and tested) _parse_args to fail-fast
792         when given invalid args.
793
794         * Scripts/webkitpy/tool/bot/irc_command.py:
795         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
796         * Scripts/webkitpy/tool/bot/sheriff.py:
797         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
798
799 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
800
801         Reviewed by Tony Chang.
802
803         run-webkit-websocketserver fails to stop websocket server
804         https://bugs.webkit.org/show_bug.cgi?id=63123
805
806         There's a ten-character change in new-run-webkit-websocketserver
807         that fixes the actual bug, and then we update the code in
808         new-run-webkit-httpd to do the actual stop call, and add more tests
809         (refactoring the existing test code so that it is shared).
810
811         * Scripts/new-run-webkit-httpd:
812         * Scripts/new-run-webkit-websocketserver:
813         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
814
815 2011-06-22  Adam Roben  <aroben@apple.com>
816
817         Add links to existing bugs related to failing tests on TestFailures page
818
819         I changed the layout of the page a little to make it easier to read with all the new
820         information. Passing/failing revisions have been moved down below the list of tests to be
821         closer to the existing bugs and the new bug link. And each set of tests and its relevant
822         information is in a light gray box.
823
824         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
825         possible
826
827         Reviewed by Darin Adler.
828
829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
830         (Bugzilla): This new class represents a single Bugzilla instance.
831         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
832         passing the resulting bug titles and URLs to the callback when complete. If called multiple
833         times with the same query before the query returns, caches the callbacks so that only one
834         query is sent over the wire. When the query completes, all pending callbacks are called.
835
836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
837         (#failure-history): Reduce the margin/padding on the top-level list a bit.
838         (#failure-history > li): Put each set of tests in a gray box, and indent most information
839         inside the box.
840         (.test-list): Unindent the list of failing tests so it is visually at the top level.
841         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
842         each box isn't a big empty space.
843         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
844         quite long.
845
846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
847         (addQueryParametersToURL): New function extracted from
848         ViewController.prototype._domForNewAndExistingBugs.
849
850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
851         (ViewController): Take and store an optional Bugzilla instance.
852         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
853         purposes and move the list of failing tests above all other information. Only show bug
854         information once we've determined the most-recent passing revision for a set of tests. It's
855         not that useful to file a new bug before this information has been determined, and searching
856         for existing bugs before we've figured out which tests started failing at the same time
857         would end up giving you information about a bunch of unrelated tests.
858         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
859         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
860         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
861         failing tests, and adds links to the bugs when the search completes.
862
863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
864         Bugzilla instance for bugs.webkit.org to the ViewController.
865
866 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
867
868         Reviewed by Martin Robinson.
869
870         [GTK] Apply current view settings to newly created views in GtkLauncher
871         https://bugs.webkit.org/show_bug.cgi?id=63142
872
873         * GtkLauncher/main.c:
874         (createWebViewCb):
875
876 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
877
878         Reviewed by Martin Robinson.
879
880         [GTK] Use GOption to parse main arguments in GtkLauncher
881         https://bugs.webkit.org/show_bug.cgi?id=63060
882
883         Instead of getting the settings from the view, create a new
884         settings object not associated with any view so that we can parse
885         the command line arguments before creating the view. It will also
886         allows to use the same settings for more than one view if we
887         eventually support passing more than one uri from the command
888         line.
889
890         * GtkLauncher/main.c:
891         (parseOptionEntryCallback): Make this function static. Also use
892         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
893         of atoi/atof to provide better error messages. And always fill the
894         error struct when the function fails.
895         (getOptionEntriesFromWebKitWebSettings): Use an array of
896         GOptionEntry structs instead of a GArray, since that is what
897         g_option_group_add_entries() expects and the array size doesn't
898         change.
899         (addWebSettingsGroupToContext): Helper function to add the
900         websettings group to the option context.
901         (main): Create the option context to parse command line arguments.
902
903 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
904
905         Reviewed by Adam Roben.
906
907         [GTK] Implement pixel dump support for WebKitTestRunner
908         https://bugs.webkit.org/show_bug.cgi?id=58242
909
910         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
911         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
912         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
913         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
914         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
915         file so that we can share it across platforms.
916         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
917         * WebKitTestRunner/TestInvocation.h: Updated method list.
918         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
919         * WebKitTestRunner/cg/TestInvocationCG.cpp:
920         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
921
922 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
923
924         Unreviewed, rolling out r89414.
925         http://trac.webkit.org/changeset/89414
926         https://bugs.webkit.org/show_bug.cgi?id=63130
927
928         It broke webkitpy tests (Requested by Ossy on #webkit).
929
930         * Scripts/webkitpy/layout_tests/port/base.py:
931
932 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
933
934         Reviewed by Dirk Pranke.
935
936         [NRWT] Print error message when there is no httpd present on the system
937         https://bugs.webkit.org/show_bug.cgi?id=62027
938
939         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
940
941 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
942
943         Unreviewed, build fix.
944         Fix crashes in new-run-webkit-tests resulting from the
945         change to the http_server logic in r89400. Python 2.5
946         on Mac 10.5 has some weird error paths.
947
948         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
949         * Scripts/webkitpy/common/system/executive.py:
950
951 2011-06-21  MORITA Hajime  <morrita@google.com>
952
953         Unreviewed, rolling out r89401 and r89403.
954         http://trac.webkit.org/changeset/89401
955         http://trac.webkit.org/changeset/89403
956         https://bugs.webkit.org/show_bug.cgi?id=62970
957
958         Breaks mac build and mistakenly enables the spellcheck API
959
960         * Scripts/build-webkit:
961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
962
963 2011-06-21  Kent Tamura  <tkent@chromium.org>
964
965         [Mac] Sort Xcode project files.
966
967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
968
969 2011-06-20  MORITA Hajime  <morrita@google.com>
970
971         Reviewed by Kent Tamura.
972
973         Spellcheck API should be build-able.
974         https://bugs.webkit.org/show_bug.cgi?id=62970
975
976         * Scripts/build-webkit:
977
978 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
979
980         Reviewed by Tony Chang.
981
982         nrwt: attempt #3 at fixing server startup/shutdown
983         https://bugs.webkit.org/show_bug.cgi?id=62829
984
985         Attempt yet again to make starting and stopping servers
986         reliable. It turns out that apache has races between when the
987         ctl process exists and when it writes/removes the pid file.
988         This change accounts for the races.
989
990         * Scripts/new-run-webkit-httpd:
991         * Scripts/webkitpy/common/system/executive.py:
992         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
993         * Scripts/webkitpy/layout_tests/port/base.py:
994         * Scripts/webkitpy/layout_tests/port/http_server.py:
995         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
996         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
997         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
998         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
999
1000 2011-06-21  Dmitry Lomov  <dslomov@google.com>
1001
1002         Reviewed by Adam Roben.
1003
1004         https://bugs.webkit.org/show_bug.cgi?id=63080
1005         Unit-tests step on test-only bot is broken.
1006         Removing the step until run-api-tests is fixed.
1007
1008         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1009
1010 2011-06-20  Dmitry Lomov  <dslomov@google.com>
1011
1012         Reviewed by David Levin.
1013
1014         https://bugs.webkit.org/show_bug.cgi?id=63017
1015         "Unit tests" step on bots should provide more information in case of failure.
1016
1017         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
1018
1019 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1020
1021         Reviewed by Ojan Vafai.
1022
1023         new-run-webkit-tests: order shards by name, not number of tests
1024         https://bugs.webkit.org/show_bug.cgi?id=62753
1025
1026         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1027
1028 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1029
1030         Reviewed by Ojan Vafai.
1031
1032         we should only log the test names to the tests_run.txt files during layout_tests
1033         https://bugs.webkit.org/show_bug.cgi?id=62751
1034
1035         * Scripts/old-run-webkit-tests:
1036         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1037
1038 2011-06-20  Eric Seidel  <eric@webkit.org>
1039
1040         Reviewed by Adam Barth.
1041
1042         commit-queue/ews-bots should run run-bindings-tests for every patch
1043         https://bugs.webkit.org/show_bug.cgi?id=63010
1044
1045         * Scripts/webkitpy/common/config/ports.py:
1046         * Scripts/webkitpy/tool/commands/download_unittest.py:
1047         * Scripts/webkitpy/tool/steps/runtests.py:
1048         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1049         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1050
1051 2011-06-20  Chang Shu  <cshu@webkit.org>
1052
1053         Reviewed by Adam Barth.
1054
1055         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
1056         https://bugs.webkit.org/show_bug.cgi?id=53676
1057
1058         * WebKitTestRunner/TestController.cpp:
1059         (WTR::TestController::initialize):
1060
1061 2011-06-20  Eric Seidel  <eric@webkit.org>
1062
1063         Reviewed by Adam Barth.
1064
1065         buildbots should run run-bindings-tests
1066         https://bugs.webkit.org/show_bug.cgi?id=63001
1067
1068         run-bindings-tests takes 2.4 seconds on my machine, so
1069         I expect this will not be noticeable on the bots.
1070
1071         I also removed tiger-specific checks since Tiger is no
1072         longer a supported platform for webkit.
1073
1074         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1075
1076 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1077
1078         Unreviewed. Fix WebKit2 GTK build after r89249.
1079
1080         * GtkLauncher/main.c:
1081         (main):
1082
1083 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
1084
1085         Reviewed by Yury Semikhatsky.
1086
1087         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
1088         https://bugs.webkit.org/show_bug.cgi?id=62994
1089
1090         * DumpRenderTree/LayoutTestController.cpp:
1091         (closeWebInspectorCallback):
1092         (LayoutTestController::staticFunctions):
1093         * DumpRenderTree/LayoutTestController.h:
1094         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1095         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1096         * DumpRenderTree/chromium/LayoutTestController.cpp:
1097         (LayoutTestController::LayoutTestController):
1098         * DumpRenderTree/chromium/LayoutTestController.h:
1099         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1100         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1101         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1102         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1103         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1104         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1105         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1106         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1107         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1108
1109 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
1110
1111         Reviewed by Martin Robinson.
1112
1113         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
1114         https://bugs.webkit.org/show_bug.cgi?id=55308
1115
1116         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
1117         (parseOptionEntryCallback): Callback for parsing option entry.
1118         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
1119         list of option entries.
1120         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
1121         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
1122         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
1123         (parseAdditionalOptions): Help function parsing additional commandline options.
1124         (main): Added call to parseAdditionalOptions.
1125
1126 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1127
1128         Reviewed by Andreas Kling.
1129
1130         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
1131         https://bugs.webkit.org/show_bug.cgi?id=62869
1132
1133         Add QFont include to fix "incomlete type QFont" error.
1134
1135         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1136
1137 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1138
1139         Reviewed by Martin Robinson.
1140
1141         [GTK] Enable Media Stream feature and make it default on
1142         https://bugs.webkit.org/show_bug.cgi?id=60394
1143
1144         * Scripts/build-webkit:
1145
1146 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1147
1148         Unreviewed, rolling out r89198.
1149         http://trac.webkit.org/changeset/89198
1150         https://bugs.webkit.org/show_bug.cgi?id=62953
1151
1152         Chromium breakage on "Linux Tests" (Requested by senorblanco
1153         on #webkit).
1154
1155         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1156         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1157         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1158
1159 2011-06-18  Daniel Bates  <dbates@webkit.org>
1160
1161         Reviewed by Eric Seidel.
1162
1163         Git.push_local_commits_to_server() should use passed username and
1164         password when we don't have cached credentials
1165         https://bugs.webkit.org/show_bug.cgi?id=62941
1166
1167         Fixes a issue where Git.push_local_commits_to_server() would always look
1168         for cached credentials regardless of whether a username and password
1169         were passed as arguments. Instead, if given both a username and password
1170         then we shouldn't look for cached credentials (since we were explicitly given
1171         credentials).
1172
1173         * Scripts/webkitpy/common/checkout/scm/git.py:
1174         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
1175
1176 2011-06-18  Daniel Bates  <dbates@rim.com>
1177
1178         Rubber-stamped by Eric Seidel.
1179
1180         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1181         https://bugs.webkit.org/show_bug.cgi?id=62767
1182
1183         Part 3 of 3
1184
1185         Remove the command-line option --skip-build now that the master BuildBot has been restarted
1186         following <http://trac.webkit.org/changeset/89138>.
1187
1188         Instead, specify --no-build to get analogous functionality.
1189
1190         * Scripts/run-javascriptcore-tests:
1191
1192 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
1193
1194         Reviewed by Tony Chang.
1195
1196         new-run-webkit-tests: fix test sorting
1197         https://bugs.webkit.org/show_bug.cgi?id=58691
1198
1199         This changes the sorting to use a "natural" sort order such that
1200         foo2.html sorts before foo13.html, and sorts the tests so
1201         that all the tests in a directory are run before any test in a
1202         subdirectory.
1203
1204         This change also adds a split() method to the filesystem since
1205         that is needed to cluster files into a directory otherwise.
1206
1207         * Scripts/webkitpy/common/system/filesystem.py:
1208         * Scripts/webkitpy/common/system/filesystem_mock.py:
1209         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1210         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
1211
1212 2011-06-18  Evan Martin  <evan@chromium.org>
1213
1214         Reviewed by Darin Adler.
1215
1216         Compiler warning in double->int conversion in TestNetscapePlugIn
1217         https://bugs.webkit.org/show_bug.cgi?id=51554
1218
1219         This code is providing a JS API for removing a property by numeric ID.
1220         We get it from JS as a double, and must convert it to an int before using it.
1221
1222         Test: LayoutTests/plugins/npruntime/remove-property.html
1223
1224         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1225         (NPRuntimeRemoveProperty::TestObject::invoke):
1226
1227 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
1228
1229         Reviewed by Eric Seidel.
1230
1231         Don't exit webkit-patch when running on Win32 python
1232         https://bugs.webkit.org/show_bug.cgi?id=55811
1233
1234         Most of the basic actions work in the meantime,
1235         so let people play with in on Win32 now.
1236
1237         * Scripts/webkit-patch:
1238
1239 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
1240
1241         Reviewed by Ojan Vafai.
1242
1243         Convert json_results_generator.py to output version 4 JSON.
1244         https://bugs.webkit.org/show_bug.cgi?id=60869
1245
1246         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1247         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1248         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1249
1250 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
1251
1252         Reviewed by Eric Seidel.
1253
1254         Some names with spaces are incorrectly reported as not containing spaces
1255         while running prepare-ChangeLog
1256         https://bugs.webkit.org/show_bug.cgi?id=55572
1257
1258         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
1259           non-alphanumeric characters in names.
1260
1261 2011-06-18  Michael Saboff  <msaboff@apple.com>
1262
1263         Reviewed by Eric Seidel.
1264
1265         Enhancement: New Script to Format malloc_history output as tree
1266         https://bugs.webkit.org/show_bug.cgi?id=56378
1267
1268         New script to process malloc_history output to tree format.
1269
1270         * Scripts/malloc-tree: Added.
1271
1272 2011-06-17  Dmitry Lomov  <dslomov@google.com>
1273
1274         Reviewed by Daniel Bates.
1275
1276         https://bugs.webkit.org/show_bug.cgi?id=62918 
1277         Pass configuration to UnitTests step in master.cfg
1278
1279         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1280
1281 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
1282
1283         Reviewed by Eric Seidel.
1284
1285         [EFL] Add Evas-based ImageDiff implementation.
1286         https://bugs.webkit.org/show_bug.cgi?id=61942
1287
1288         Build system changes will be performed as soon as the complete
1289         DumpRenderTree implementation is upstreamed.
1290
1291         * DumpRenderTree/efl/ImageDiff.cpp: Added.
1292         (pixelFromImageData):
1293         (differenceImageFromDifferenceBuffer):
1294         (computeDistanceBetweenPixelComponents):
1295         (calculatePixelDifference):
1296         (calculateDifference):
1297         (getTemporaryFile):
1298         (printImage):
1299         (printImageDifferences):
1300         (resizeEcoreEvasIfNeeded):
1301         (readImageFromStdin):
1302         (parseCommandLineOptions):
1303         (shutdownEfl):
1304         (abortWithErrorMessage):
1305         (initEfl):
1306         (main):
1307
1308 2011-06-17  Tony Chang  <tony@chromium.org>
1309
1310         Reviewed by Dirk Pranke.
1311
1312         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
1313         https://bugs.webkit.org/show_bug.cgi?id=62907
1314
1315         This fixes a bug where the ImageDiff on the user's machine doesn't
1316         match the logic used on the Chromium buildbots.  This has the downside
1317         of requiring that the Chromium ImageDiff is built, but it turns out
1318         that even with --tolerance 0, the CG ImageDiff will allow small pixel
1319         differences through.
1320
1321         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1322
1323 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
1324
1325         [WinCairo] Unreviewed build correction.
1326
1327         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
1328         Update WinCairo property sheet to link against the Cairo DLL,
1329         now that we are using a more recent Cairo build. 
1330
1331 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
1332
1333         Reviewed by Brian Weinstein.
1334
1335         Create a simple example of using the COM-based C++ listeners.
1336         A new onclick event is attached (via C++) to the WebKit logo
1337         in the default test pattern displayed on startup.  Clicking on
1338         the logo causes a message box to be displayed.
1339         https://bugs.webkit.org/show_bug.cgi?id=61885
1340
1341         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
1342           the WebScriptObject and DOMEventListener.
1343         * WinLauncher/WinLauncher.cpp:
1344         (SimpleEventListener::SimpleEventListener): Example implementation
1345           of a simple DOM event listener.
1346         (SimpleEventListener::handleEvent): 
1347         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
1348          to bind a C++ method to the 'onclick' event for the WebKit logo.
1349         (_tWinMain):
1350         * WinLauncher/WinLauncher.h:
1351         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
1352
1353 2011-06-17  Chang Shu  <cshu@webkit.org>
1354
1355         Reviewed by Andreas Kling.
1356
1357         [Qt] [WK2] Support undo/redo in MiniBrowser
1358         https://bugs.webkit.org/show_bug.cgi?id=62809
1359
1360         * MiniBrowser/qt/BrowserWindow.cpp:
1361         (BrowserWindow::BrowserWindow):
1362
1363 2011-06-17  Daniel Bates  <dbates@rim.com>
1364
1365         Rubber-stamped by Eric Seidel.
1366
1367         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1368         https://bugs.webkit.org/show_bug.cgi?id=62767
1369
1370         Part 2 of 3
1371
1372         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
1373         command line option instead of --skip-build.
1374
1375         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
1376         master buildbot picks up the change.
1377
1378         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1379
1380 2011-06-17  Daniel Bates  <dbates@rim.com>
1381
1382         Rubber-stamped by Eric Seidel.
1383
1384         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1385         https://bugs.webkit.org/show_bug.cgi?id=62767
1386
1387         Part 1 of 3
1388
1389         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
1390         run-javascriptcore-tests. Also, add a remark about these options to the usage message
1391         printed by run-javascriptcore-tests.
1392
1393         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
1394
1395         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
1396           of $showHelp.
1397
1398 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
1399
1400         Reviewed by Martin Robinson.
1401
1402         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
1403         https://bugs.webkit.org/show_bug.cgi?id=60687
1404
1405         Replace GdkRectangle by cairo_rectangle_int_t.
1406
1407         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
1408         (createBitmapContextFromWebView):
1409         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
1410         (firstRectForCharacterRangeCallback):
1411
1412 2011-06-16  Dmitry Lomov  <dslomov@google.com>
1413
1414         Reviewed by David Levin.
1415
1416         https://bugs.webkit.org/show_bug.cgi?id=62603
1417         Run run-api-tests on bots in debug mode.
1418         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
1419
1420         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1421
1422 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
1423
1424         Reviewed by Eric Seidel.
1425
1426         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
1427         WorkQueueItem.
1428         They will be plugged into the build system once the EFL's DRT is
1429         fully upstreamed.
1430         https://bugs.webkit.org/show_bug.cgi?id=61958
1431
1432         * DumpRenderTree/efl: Added.
1433         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
1434         (GCController::collect):
1435         (GCController::collectOnAlternateThread):
1436         (GCController::getJSObjectCount):
1437         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
1438         (createBitmapContextFromWebView):
1439         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
1440         (LoadItem::invoke):
1441         (LoadHTMLStringItem::invoke):
1442         (ReloadItem::invoke):
1443         (ScriptItem::invoke):
1444         (BackForwardItem::invoke):
1445         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
1446         (WorkQueueItem::~WorkQueueItem):
1447         (LoadItem::LoadItem):
1448         (LoadHTMLStringItem::LoadHTMLStringItem):
1449         (ScriptItem::ScriptItem):
1450         (LoadingScriptItem::LoadingScriptItem):
1451         (LoadingScriptItem::invoke):
1452         (NonLoadingScriptItem::NonLoadingScriptItem):
1453         (NonLoadingScriptItem::invoke):
1454         (BackForwardItem::BackForwardItem):
1455         (BackItem::BackItem):
1456         (ForwardItem::ForwardItem):
1457
1458 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
1459
1460         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
1461         preference like the perl scripts do.
1462
1463         * waf/build/build_utils.py:
1464         * waf/build/settings.py:
1465
1466 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
1467
1468         Reviewed by Tony Gentilcore.
1469
1470         MediaStream API: Runtime enabled features
1471         https://bugs.webkit.org/show_bug.cgi?id=62798
1472
1473         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
1474
1475         * DumpRenderTree/chromium/TestShell.cpp:
1476         (TestShell::TestShell):
1477
1478 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
1479
1480         Reviewed by Eric Seidel.
1481
1482         Add support for sys.platform == 'linux3' by relaxing
1483         conditional statements and/or extending lookup dicts.
1484         This way, Linux kernels >=3.0-rc1 get supported in the
1485         build process.
1486         https://bugs.webkit.org/show_bug.cgi?id=62730
1487
1488         * Scripts/webkitpy/common/system/executive.py:
1489         * Scripts/webkitpy/common/system/file_lock.py:
1490         * Scripts/webkitpy/common/system/path_unittest.py:
1491         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1492         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1493         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1494         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1495         * Scripts/webkitpy/layout_tests/port/factory.py:
1496         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1497         * Scripts/webkitpy/layout_tests/port/qt.py:
1498         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1499
1500 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1501
1502         Unreviewed, rolling out r88796.
1503         http://trac.webkit.org/changeset/88796
1504         https://bugs.webkit.org/show_bug.cgi?id=62790
1505
1506         It made fast/dom/nodesFromRect-basic.html time out on Qt,
1507         64-bit, debug mode (Requested by Ossy on #webkit).
1508
1509         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1510         (LayoutTestController::nodesFromRect):
1511         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1512         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1513         (PlainTextController::plainText):
1514         * DumpRenderTree/qt/PlainTextControllerQt.h:
1515
1516 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1517
1518         Unreviewed, build fix.
1519
1520         Revert the patches in r88995 and r88999; the http servers don't
1521         seem to be shutting down reliably.
1522
1523         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1524         * Scripts/webkitpy/layout_tests/port/base.py:
1525         * Scripts/webkitpy/layout_tests/port/http_server.py:
1526         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1527         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1528         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1529         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1530
1531 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1532
1533         Unreviewed, build fix.
1534
1535         Add some debugging messages to triage problems introduced in
1536         r88995.
1537
1538         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1539
1540 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1541
1542         Reviewed by Tony Chang.
1543
1544         nrwt: should clean up stale server processes from a previous run
1545         https://bugs.webkit.org/show_bug.cgi?id=62615
1546
1547         This change fixes cases where NRWT might start a server and then
1548         exit, leaving the server still running. Now NRWT should detect
1549         this case and clean up on the next run, without shutting down
1550         any processes it didn't start.
1551
1552         This change also fixes a bug in executive.kill_process on UNIX
1553         where zombies weren't being handled properly.
1554
1555         * Scripts/webkitpy/common/system/executive.py:
1556         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1557         * Scripts/webkitpy/layout_tests/port/base.py:
1558         * Scripts/webkitpy/layout_tests/port/http_server.py:
1559         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1560         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1561         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1562
1563 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1564
1565         Reviewed by Tony Chang.
1566
1567         nrwt: fix http, websocket server startup, shutdown
1568         https://bugs.webkit.org/show_bug.cgi?id=62180
1569
1570         This change refactors all of the server-related code to
1571         have consistent semantics. It pushes the start()/stop()
1572         logic into the base class and adds four much smaller routines
1573         for specialization:
1574         _prepare_config() - for optionally writing config files etc.
1575             to disk prior to starting the server
1576         _remove_stale_log_files()
1577         _spawn_process() - the actual launch of the subprocess
1578         _cleanup_after_stop() - and custom cleanup code
1579
1580         Prior to this change the three server implementations were
1581         fairly inconsistent, leading to lots of weirdness on the bots
1582         with servers being left around, etc.
1583
1584         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1585         * Scripts/webkitpy/layout_tests/port/http_server.py:
1586         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1587         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1588
1589 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1590
1591         Reviewed by Tony Chang.
1592
1593         webkitpy: clean up code prior to functional changes for server startup/shutdown
1594         https://bugs.webkit.org/show_bug.cgi?id=62256
1595
1596         This patch does a bunch of minor cleanup of the code, but there
1597         should be no functional changes except that all of the modules
1598         will now use the same exception type. Other changes include
1599         removing unused code paths and functions, pushing 'name' and
1600         'pid_file' into the base class of the server objects, and using
1601         the Filesystem object instead of the codecs, tempfile, and
1602         shutils modules.
1603
1604         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1605         * Scripts/webkitpy/layout_tests/port/http_server.py:
1606         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1607         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1608
1609 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1610
1611         Reviewed by Tony Chang.
1612
1613         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1614         https://bugs.webkit.org/show_bug.cgi?id=62251
1615
1616         shut_down_http_server() was a total hack that was only used by
1617         new-run-webkit-httpd, so I've moved the code there and switched
1618         to using executive.kill_process() for the common case. The
1619         method itself will be removed in the patch on bug 59993.
1620
1621         * Scripts/new-run-webkit-httpd:
1622         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1623         * Scripts/webkitpy/layout_tests/port/http_server.py:
1624         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1625         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1626
1627 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1628
1629         Unreviewed, build fix.
1630
1631         Fix test-webkitpy failure introduced in r88986.
1632
1633         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1634
1635 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1636
1637         Reviewed by Eric Seidel.
1638
1639         NRWT: doesn't support webarchives, has stale skipping logic.
1640         https://bugs.webkit.org/show_bug.cgi?id=58293
1641
1642         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1643         * Scripts/webkitpy/layout_tests/port/base.py:
1644         * Scripts/webkitpy/layout_tests/port/webkit.py:
1645
1646 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
1647
1648         Change my email to @webkit.org
1649
1650         * Scripts/webkitpy/common/config/committers.py:
1651
1652 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
1653
1654         Reviewed by David Hyatt.
1655
1656         CSS 2.1: Support replaced elements with relative intrinsic sizes
1657         https://bugs.webkit.org/show_bug.cgi?id=15849
1658
1659         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
1660         https://bugs.webkit.org/show_bug.cgi?id=53099
1661
1662         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
1663
1664         * Scripts/old-run-webkit-tests:
1665         * Scripts/webkitpy/layout_tests/port/test_files.py:
1666
1667 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1668
1669         Reviewed by Martin Robinson.
1670
1671         [GTK] Add a statusbar to MiniBrowser
1672         https://bugs.webkit.org/show_bug.cgi?id=62634
1673
1674         It shows the url of the current hovered link.
1675
1676         * MiniBrowser/gtk/BrowserWindow.c:
1677         (browserWindowConstructed): Create the GtkSatusbar.
1678         (mouseDidMoveOverElement): Update statusbar text.
1679         (browserWindowUIClientInit): Add implementation for
1680         mouseDidMoveOverElement().
1681         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
1682         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
1683         (mouseDidMoveOverElement): Pass the url of the current hovered
1684         link to the UI process.
1685         (didCreatePage): Set the UI client adding an implementation for
1686         mouseDidMoveOverElement().
1687         (WKBundleInitialize):
1688         * MiniBrowser/gtk/main.c:
1689         (createWKContextWithInjectedBundle): Create a global context with
1690         the injected bundle.
1691         (loadURI): Use the global context.
1692         (main):
1693
1694 2011-06-14  Lucas Forschler  <lforschler@apple.com>
1695
1696         Reviewed by Stephanie Lewis.
1697
1698         https://bugs.webkit.org/show_bug.cgi?id=62495
1699         Bug 62495 - combine windows and mac kill-old-processes script
1700         Add a platform agnostic script.  Remove the recently added mac flavor.
1701         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
1702         
1703         * BuildSlaveSupport/kill-old-processes: Added.
1704         * BuildSlaveSupport/mac: Removed.
1705         * BuildSlaveSupport/mac/kill-old-processes: Removed.
1706
1707 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
1708
1709         Reviewed by Tony Chang.
1710
1711         nrwt: handle worker exceptions cleanly
1712         https://bugs.webkit.org/show_bug.cgi?id=62614
1713
1714         This change modifiers new-run-webkit-tests to handle exceptions
1715         raised by worker threads better, by:
1716         - capturing the worker's stack and logging it in the manager
1717         - propagating the worker's exception in the caller correctly
1718         - attempting to cancel the workers and clean up even when
1719           we get an unexpected exception
1720
1721         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1722         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1723         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1724         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1725
1726 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1727
1728         Reviewed by Laszlo Gombos.
1729
1730         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
1731         https://bugs.webkit.org/show_bug.cgi?id=62227
1732
1733         QtWebkit does not yet support different CacheModels. This change will 
1734         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
1735
1736         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1737         (LayoutTestController::setCacheModel):
1738         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1739
1740 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1741
1742         Reviewed by Andreas Kling.
1743
1744         [Qt] tst_QWebFrame::overloadedSlots() fails
1745         https://bugs.webkit.org/show_bug.cgi?id=37319
1746
1747         Since we don't implictly convert 'document' object to QWebElement
1748         in metacalls anymore, change the controller to expect QVariantMap instead.
1749
1750         The method plainText() was updated to use QVariantMap as well to let the bridge
1751         do the conversion directly for us.
1752
1753         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1754         (LayoutTestController::nodesFromRect):
1755         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1756         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1757         (PlainTextController::plainText):
1758         * DumpRenderTree/qt/PlainTextControllerQt.h:
1759
1760 2011-06-14  Andras Becsi  <abecsi@webkit.org>
1761
1762         Reviewed by Csaba Osztrogonác.
1763
1764         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
1765         https://bugs.webkit.org/show_bug.cgi?id=62630
1766
1767         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1768         (NPP_New): remove dead variable 'forceCarbon'
1769
1770 2011-06-13  Hayato Ito  <hayato@chromium.org>
1771
1772         Reviewed by Ojan Vafai.
1773
1774         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
1775         https://bugs.webkit.org/show_bug.cgi?id=59188
1776
1777         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
1778         WebKitDriver should always return an actual hash value if DRT returns that.
1779
1780         No tests since I'll add sample reftests to make sure mismatch reftests work later,
1781         which should be in a separate patch.
1782
1783         * Scripts/webkitpy/layout_tests/port/webkit.py:
1784
1785 2011-06-13  Kent Tamura  <tkent@chromium.org>
1786
1787         [Chromium-win] Fix two wrong assertions exposed by r88757.
1788
1789         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1790         (WebThemeEngineDRTWin::paintTrackbar):
1791
1792 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
1793
1794         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
1795         and commit queue happy.
1796
1797         * Scripts/webkitpy/common/config/committers.py:
1798
1799 2011-06-13  Chris Rogers  <crogers@google.com>
1800
1801         Unreviewed build fix.
1802
1803         Build fix to chromium DRT until we can rebaseline some tests
1804         https://bugs.webkit.org/show_bug.cgi?id=62608
1805
1806         * DumpRenderTree/chromium/TestShell.cpp:
1807         (TestShell::TestShell):
1808
1809 2011-06-13  Chris Rogers  <crogers@google.com>
1810
1811         Reviewed by Dirk Pranke.
1812
1813         Add Web Audio support to chromium DRT
1814         https://bugs.webkit.org/show_bug.cgi?id=62306
1815
1816         * DumpRenderTree/chromium/LayoutTestController.cpp:
1817         (LayoutTestController::LayoutTestController):
1818         (LayoutTestController::reset):
1819         (LayoutTestController::setEncodedAudioData):
1820         * DumpRenderTree/chromium/LayoutTestController.h:
1821         (LayoutTestController::encodedAudioData):
1822         (LayoutTestController::shouldDumpAsAudio):
1823         (LayoutTestController::setShouldDumpAsAudio):
1824         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1825         (DRTPrinter::handleAudioHeader):
1826         (TestShellPrinter::handleAudioHeader):
1827         * DumpRenderTree/chromium/TestEventPrinter.h:
1828         * DumpRenderTree/chromium/TestShell.cpp:
1829         (TestShell::TestShell):
1830         (TestShell::dump):
1831
1832 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1833
1834         Reviewed by Eric Seidel.
1835
1836         [EFL] Add load error handler to EWebLauncher
1837         https://bugs.webkit.org/show_bug.cgi?id=62347
1838
1839         Add a handler function of "load,error" to EWebLauncher.
1840         EWebLauncher now displays a simple error page on load errors.
1841
1842         * EWebLauncher/main.c:
1843         (on_load_error):
1844         (browserCreate):
1845
1846 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
1847
1848         Reviewed by Eric Seidel.
1849
1850         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1851         https://bugs.webkit.org/show_bug.cgi?id=62385
1852
1853         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1854         of this code makes keeping it in sync much more difficult. The files are
1855         almost identical and this change ports the X11 changes to main.cpp.
1856
1857         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1858         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
1859         some results on Qt and this seems to be unnecessary for the moment.
1860         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1861         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1862         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1863         it should not be in the results.
1864         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
1865         XP_UNIX block is first by guarding against using a null instance.
1866         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
1867         the XP_UNIX define for Linux.
1868         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1869         * GNUmakefile.am: Update source list.
1870
1871 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1872
1873         Unreviewed, rolling out r88671.
1874         http://trac.webkit.org/changeset/88671
1875         https://bugs.webkit.org/show_bug.cgi?id=62591
1876
1877         "didn't work" (Requested by dpranke on #webkit).
1878
1879         * Scripts/new-run-webkit-httpd:
1880         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1881         * Scripts/webkitpy/layout_tests/port/http_server.py:
1882         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1883         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1884         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1885         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1886
1887 2011-06-13  Nate Chapin  <japhet@chromium.org>
1888
1889         Reviewed by Darin Fisher.
1890
1891         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
1892
1893         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1894
1895 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
1896
1897         Reviewed by Tony Chang.
1898
1899         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1900         https://bugs.webkit.org/show_bug.cgi?id=62251
1901
1902         shut_down_http_server() was a total hack that was only used by
1903         new-run-webkit-httpd, so I've moved the code there and switched
1904         to using executive.kill_process() for the common case. The
1905         method itself will be removed in the patch on bug 59993.
1906
1907         * Scripts/new-run-webkit-httpd:
1908         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1909         * Scripts/webkitpy/layout_tests/port/http_server.py:
1910         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1911         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1912
1913 2011-06-13  Tony Chang  <tony@chromium.org>
1914
1915         Reviewed by Dimitri Glazkov.
1916
1917         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
1918         https://bugs.webkit.org/show_bug.cgi?id=62578
1919
1920         * Scripts/build-webkit:
1921
1922 2011-06-13  Tony Chang  <tony@chromium.org>
1923
1924         Reviewed by Adam Barth.
1925
1926         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
1927         https://bugs.webkit.org/show_bug.cgi?id=62545
1928
1929         * Scripts/build-webkit:
1930
1931 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         Reviewed by Martin Robinson.
1934
1935         [GTK] Export an API similar to WebKit1
1936         https://bugs.webkit.org/show_bug.cgi?id=57820
1937
1938         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
1939         code, but linking to libwebkit2gtk.
1940
1941         * GNUmakefile.am:
1942         * GtkLauncher/main.c:
1943         (createBrowser):
1944         (main):
1945
1946 2011-06-12  MORITA Hajime  <morrita@google.com>
1947
1948         Unreviewed, rolling out r88625.
1949         http://trac.webkit.org/changeset/88625
1950         https://bugs.webkit.org/show_bug.cgi?id=61073
1951
1952         Breaks SL Webkit2 Tests
1953
1954         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1955         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1956         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1958         (WTR::InjectedBundlePage::didClearWindowForFrame):
1959         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1960
1961 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1962
1963         Reviewed by Antonio Gomes.
1964
1965         [Qt] LayoutTestController needs setTextDirection implementation
1966         https://bugs.webkit.org/show_bug.cgi?id=62442
1967
1968         Implements LayoutController.setTextDirection.
1969
1970         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1971         (LayoutTestController::setTextDirection):
1972         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1973
1974 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
1975
1976         Reviewed by Hajime Morita.
1977
1978         Add window.internals to WebKit2's WebKitTestRunner.
1979         https://bugs.webkit.org/show_bug.cgi?id=61073
1980
1981         Test: fast/harness/internals-object.html
1982
1983         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1984         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1985         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1986         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1987         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
1988         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1989
1990 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1991
1992         Unreviewed, rolling out r88616.
1993         http://trac.webkit.org/changeset/88616
1994         https://bugs.webkit.org/show_bug.cgi?id=62517
1995
1996         It broke editing/text-iterator/findString.html (Requested by
1997         tonikitoo on #webkit).
1998
1999         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2000         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2001
2002 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2003
2004         Reviewed by Antonio Gomes.
2005
2006         [Qt] LayoutTestController needs setTextDirection implementation
2007         https://bugs.webkit.org/show_bug.cgi?id=62442
2008
2009         Implements LayoutController.setTextDirection.
2010
2011         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2012         (LayoutTestController::setTextDirection):
2013         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2014
2015 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
2016
2017         Reviewed by Ojan Vafai.
2018
2019         new-run-webkit-tests: 'images' links on results.html don't work
2020         https://bugs.webkit.org/show_bug.cgi?id=62194
2021
2022         Use relative path when generating images-diffs.html
2023
2024         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2025         Added _output_testname.
2026
2027 2011-06-10  Lucas Forschler  <lforschler@apple.com>
2028
2029         Reviewed by Stephanie Lewis.
2030
2031         Script to kill old processes on Mac.
2032         This matches the windows version.
2033         https://bugs.webkit.org/show_bug.cgi?id=62479  
2034         
2035         * BuildSlaveSupport/mac: Added.
2036         * BuildSlaveSupport/mac/kill-old-processes: Added.
2037
2038 2011-06-10  Adam Barth  <abarth@webkit.org>
2039
2040         Reviewed by James Robinson.
2041
2042         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
2043         https://bugs.webkit.org/show_bug.cgi?id=62489
2044
2045         * Scripts/webkitpy/tool/bot/sheriff.py:
2046         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2047
2048 2011-06-10  Tony Chang  <tony@chromium.org>
2049
2050         Reviewed by Ojan Vafai.
2051
2052         add a compile guard ENABLE(FLEXBOX)
2053         https://bugs.webkit.org/show_bug.cgi?id=62049
2054
2055         * Scripts/build-webkit:
2056
2057 2011-06-10  Mark Rowe  <mrowe@apple.com>
2058
2059         Reviewed by Dimitri Glazkov.
2060
2061         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
2062
2063         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
2064         header file.
2065
2066         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2067         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2068
2069 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
2070
2071         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
2072
2073         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2074         (handleEventX11):
2075         (NPP_GetValue):
2076         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2077         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
2078         (webkit_test_plugin_new_instance):
2079         (webkit_test_plugin_destroy_instance):
2080         (webkit_test_plugin_set_window):
2081         (executeScript):
2082         (webkit_test_plugin_new_stream):
2083         (webkit_test_plugin_destroy_stream):
2084         (webkit_test_plugin_stream_as_file):
2085         (webkit_test_plugin_write_ready):
2086         (webkit_test_plugin_write):
2087         (webkit_test_plugin_print):
2088         (keyEventToChar):
2089         (webkit_test_plugin_handle_event):
2090         (webkit_test_plugin_url_notify):
2091         (webkit_test_plugin_get_value):
2092         (webkit_test_plugin_set_value):
2093         (NP_GetMIMEDescription):
2094         (NP_Initialize):
2095         (NP_Shutdown):
2096         (NP_GetValue):
2097         * GNUmakefile.am:
2098
2099 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2100
2101         Reviewed by Eric Seidel.
2102
2103         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
2104         https://bugs.webkit.org/show_bug.cgi?id=55603
2105
2106         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
2107         TextInputController support.
2108
2109         * DumpRenderTree/gtk/TextInputController.cpp:
2110         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
2111         of start and end. This matches the other ports. Do not use GLib style early returns.
2112         (hasMarkedTextCallback): Added.
2113         (markedRangeCallback): Added.
2114         (insertTextCallback): Cleanup as described above.
2115         (unmarkTextCallback): Cleanup as described above.
2116         (firstRectForCharacterRangeCallback): Cleanup as described above.
2117         (selectedRangeCallback): Cleanup as described above.
2118
2119 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
2120
2121         Reviewed by Tony Chang.
2122
2123         nrwt: support webaudio in chromium driver
2124         https://bugs.webkit.org/show_bug.cgi?id=62226
2125
2126         * Scripts/webkitpy/layout_tests/port/chromium.py:
2127
2128 2011-06-09  Dan Bernstein  <mitz@apple.com>
2129
2130         Reviewed by Anders Carlsson.
2131
2132         Added a test for Vector::reverse()
2133         https://bugs.webkit.org/show_bug.cgi?id=62393
2134
2135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2136         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
2137         (TestWebKitAPI::TEST):
2138         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2139
2140 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2141
2142         Reviewed by Andreas Kling.
2143
2144         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
2145         https://bugs.webkit.org/show_bug.cgi?id=62385
2146
2147         Remove duplicate TestNetscapePlugIn implementation. Having two copies
2148         of this code makes keeping it in sync much more difficult. The files are
2149         almost identical and this change ports the X11 changes to main.cpp.
2150
2151         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2152         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
2153         (handleEventX11): Use the handler to properly convert the keycode. Do not print
2154         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
2155         it should not be in the results.
2156         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
2157         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
2158         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
2159         * GNUmakefile.am: Update source list.
2160
2161 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
2162
2163         Reviewed by Tony Chang.
2164
2165         Test plugin should support event logging on the windows port.
2166         https://bugs.webkit.org/show_bug.cgi?id=61721
2167
2168         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
2169         calls to mean the plugin handled the event.
2170
2171         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2172         (handleEventWin): Return 0 for each event on windows.
2173
2174 2011-06-09  Chang Shu  <cshu@webkit.org>
2175
2176         Reviewed by Andreas Kling.
2177
2178         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
2179         https://bugs.webkit.org/show_bug.cgi?id=62381
2180
2181         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
2182         QWKPagePrivate::isViewFocused() will check it later.
2183
2184         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2185         (WTR::PlatformWebView::PlatformWebView):
2186
2187 2011-06-09  Robert Hogan  <robert@webkit.org>
2188
2189         Reviewed by Andreas Kling.
2190
2191         Teach Qt about window.internals
2192         https://bugs.webkit.org/show_bug.cgi?id=61074
2193
2194         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2195         (WebCore::DumpRenderTree::initJSObjects):
2196
2197 2011-06-09  Eric Seidel  <eric@webkit.org>
2198
2199         Reviewed by Adam Barth.
2200
2201         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
2202         https://bugs.webkit.org/show_bug.cgi?id=62362
2203
2204         The mac bots are failing inspector tests.  We don't know why yet.
2205         So for now, turning run-webkit-tests off for the mac-ews.
2206
2207         Also noticed that due to the wrong variable name the cr-linux
2208         bots weren't running tests!
2209
2210         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2211
2212 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
2213
2214         Reviewed by Csaba Osztrogonac.
2215
2216         [Qt][WK2] Canvas tests make css2.1 ones failing
2217         https://bugs.webkit.org/show_bug.cgi?id=53427
2218
2219         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
2220         Since the Qt port should eventually go to QRawFont, this issue will be resolved
2221         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
2222         needed for the workaround.
2223
2224         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2225         (WTR::LayoutTestController::platformInitialize):
2226
2227 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
2228
2229         Reviewed by Chris Fleizach.
2230
2231         [GTK] Provide a way in DRT to check the platform name
2232         https://bugs.webkit.org/show_bug.cgi?id=56855
2233
2234         Patch for adding 'platformName' static property to DRT's
2235         LayoutController and provide platform specific implementations.
2236
2237         In principle, this feature will be only of interest for writing
2238         accessibility tests, so that's why it's only implemented in the
2239         Mac, Gtk and Win platforms.
2240
2241         * DumpRenderTree/LayoutTestController.h: New method platformName().
2242         * DumpRenderTree/LayoutTestController.cpp:
2243         (getPlatformNameCallback): New callback for 'platformName'.
2244         (LayoutTestController::staticValues): New static property.
2245
2246         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2247         (LayoutTestController::platformName): Implemented.
2248
2249         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2250         (LayoutTestController::platformName): Implemented.
2251
2252         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2253         (LayoutTestController::platformName): Implemented.
2254
2255 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
2256
2257         Reviewed by James Robinson.
2258
2259         Add mikelawther to committers.py
2260         https://bugs.webkit.org/show_bug.cgi?id=62354
2261
2262         * Scripts/webkitpy/common/config/committers.py:
2263
2264 2011-06-08  Kent Tamura  <tkent@chromium.org>
2265
2266         [Chromium] Fix a typo.
2267
2268         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2269         (WebThemeControlDRTWin::draw):
2270
2271 2011-06-08  Kent Tamura  <tkent@chromium.org>
2272
2273         Reviewed by Hajime Morita.
2274
2275         [Chromium] Support vertical sliders in Windows DRT
2276         https://bugs.webkit.org/show_bug.cgi?id=62352
2277
2278         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2279         (WebThemeControlDRTWin::draw):
2280           Paint VerticalSliderThumbType and VerticalSliderTrackType.
2281         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2282           Add VerticalSliderTrackType and VerticalSliderThumbType.
2283         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2284         (WebThemeEngineDRTWin::paintTrackbar):
2285           Convert Windows identifiers to the internal identifiers for vertical sliders.
2286
2287 2011-06-08  Ojan Vafai  <ojan@chromium.org>
2288
2289         Reviewed by Tony Chang.
2290
2291         add a short-flag for --experimental-fully-parallel
2292         https://bugs.webkit.org/show_bug.cgi?id=62321
2293
2294         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2295
2296 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2297
2298         Reviewed by Tony Chang.
2299
2300         new-run-webkit-tests: don't turn the tree red when there are new passes
2301         https://bugs.webkit.org/show_bug.cgi?id=62311
2302
2303         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
2304         to match commandComplete.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2307
2308 2011-06-08  Tom Hudson  <tomhudson@google.com>
2309
2310         Reviewed by Mihai Parparita.
2311
2312         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
2313         https://bugs.webkit.org/show_bug.cgi?id=60964
2314
2315         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2316         Add 'Sort tests by metric' link.
2317         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2318         (disableSorting): Activate 'Sort tests by metric' link.
2319         (enableSorting): Deactivate 'Sort tests by metric' link.
2320         (selectDirectory): Call enableSorting()/disableSorting() depending
2321         on currently selected failure type, and sort tests if requested.
2322         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2323         New .disabled-control class for deactivated links.
2324
2325 2011-06-08  Tom Sepez  <tsepez@chromium.org>
2326
2327         Reviewed by Adam Barth.
2328
2329         Add web permissions callbacks for mixed content blocking.
2330         https://bugs.webkit.org/show_bug.cgi?id=61946
2331
2332         * DumpRenderTree/chromium/LayoutTestController.cpp:
2333         (LayoutTestController::setAllowDisplayOfInsecureContent):
2334         (LayoutTestController::setAllowRunningOfInsecureContent):
2335         (LayoutTestController::overridePreference):
2336         * DumpRenderTree/chromium/WebPermissions.cpp:
2337         (WebPermissions::allowDisplayingInsecureContent):
2338         (WebPermissions::allowRunningInsecureContent):
2339         (WebPermissions::setDisplayingInsecureContentAllowed):
2340         (WebPermissions::setRunningInsecureContentAllowed):
2341         (WebPermissions::reset):
2342         * DumpRenderTree/chromium/WebPermissions.h:
2343
2344 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
2345
2346         Reviewed by Tony Chang.
2347
2348         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
2349         https://bugs.webkit.org/show_bug.cgi?id=62259
2350
2351         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2352
2353 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2354
2355         Reviewed by Tony Chang.
2356
2357         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
2358         https://bugs.webkit.org/show_bug.cgi?id=62303
2359
2360         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
2361
2362         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2363
2364 2011-06-08  Greg Simon  <gregsimon@chromium.org>
2365
2366         Reviewed by Dimitri Glazkov.
2367
2368         Control Indexeddb backends from LayoutTestController
2369         https://bugs.webkit.org/show_bug.cgi?id=61000
2370
2371         * DumpRenderTree/chromium/LayoutTestController.cpp:
2372         (LayoutTestController::LayoutTestController):
2373         (LayoutTestController::setOverrideIndexedDBBackingStore):
2374         (LayoutTestController::clearAllDatabases):
2375         * DumpRenderTree/chromium/LayoutTestController.h:
2376
2377 2011-06-08  Andreas Kling  <kling@webkit.org>
2378
2379         Add Pierre Rossi to contributors list for EZ-CC.
2380
2381         * Scripts/webkitpy/common/config/committers.py:
2382
2383 2011-06-08  Ilya Sherman  <isherman@chromium.org>
2384
2385         Reviewed by Andreas Kling.
2386
2387         Add Ilya Sherman to list of committers
2388         https://bugs.webkit.org/show_bug.cgi?id=62270
2389
2390         * Scripts/webkitpy/common/config/committers.py:
2391
2392 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
2393
2394         Reviewed by Tony Chang.
2395
2396         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
2397         https://bugs.webkit.org/show_bug.cgi?id=62178
2398
2399         Added commandComplete and evaluateCommand for NewRunWebKitTests class
2400         to parse new-run-webkit-tests' results.
2401
2402         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2403
2404 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
2405
2406         Reviewed by Eric Seidel.
2407
2408         webkitpy: add a popen() call to executive
2409         https://bugs.webkit.org/show_bug.cgi?id=62179
2410
2411         This change adds a popen() wrapper call to the Executive object.
2412         This will allow other webkitpy scripts that currently call
2413         subprocess directly to use Executive, instead.
2414
2415         No additional tests are necessary (the existing tests cover the code).
2416
2417         * Scripts/webkitpy/common/system/executive.py:
2418
2419 2011-06-07  Sam Weinig  <sam@webkit.org>
2420
2421         Reviewed by Anders Carlsson.
2422
2423         Remove repeated IPC traffic from SetRenderTreeSize message
2424         https://bugs.webkit.org/show_bug.cgi?id=62244
2425
2426         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2427         (WTR::InjectedBundlePage::InjectedBundlePage):
2428         Add stub for didLayoutForFrame.
2429
2430 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
2431
2432         Reviewed by Tony Chang.
2433
2434         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
2435         https://bugs.webkit.org/show_bug.cgi?id=62241
2436
2437         * Scripts/webkitpy/layout_tests/port/chromium.py:
2438
2439 2011-06-07  Adam Barth  <abarth@webkit.org>
2440
2441         Rubber-stamped by Eric Seidel.
2442
2443         Enable tests on the mac-ews
2444
2445         When we bring the mac-ews back up, we're going to try running tests!
2446
2447         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2448
2449 2011-06-07  Dmitry Lomov  <dslomov@google.com>
2450
2451         Reviewed by David Levin.
2452
2453         https://bugs.webkit.org/show_bug.cgi?id=62215
2454         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
2455
2456         * Scripts/webkitpy/style/checkers/cpp.py:
2457         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2458
2459 2011-06-07  Nico Weber  <thakis@chromium.org>
2460
2461         Reviewed by Dimitri Glazkov.
2462
2463         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
2464         https://bugs.webkit.org/show_bug.cgi?id=62210
2465
2466         The change to TestEventPrinter fixes a latent bug, because
2467         objects are deleted through the TestEventPrinter type, but none
2468         of the subclasses have destructors or non-POD members.
2469
2470         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
2471         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
2472         discussed at http://codereview.chromium.org/7094005/, we prefer making
2473         leaf class destructors virtual over making the leaf classes final.
2474
2475         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2476         (NotificationPresenter::~NotificationPresenter):
2477         * DumpRenderTree/chromium/NotificationPresenter.h:
2478         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2479         (TestEventPrinter::~TestEventPrinter):
2480         * DumpRenderTree/chromium/TestEventPrinter.h:
2481         * DumpRenderTree/chromium/WebViewHost.h:
2482
2483 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
2484
2485         Reviewed by Dirk Pranke.
2486
2487         [chromium] Chromium bots on build.webkit.org don't upload results.html
2488         https://bugs.webkit.org/show_bug.cgi?id=61961
2489
2490         Don't fix the path on chromium port erroneously.
2491
2492         * BuildSlaveSupport/test-result-archive:
2493
2494 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
2495
2496         Fix the GTK+ build by ensuring that the autogenerated sources
2497         necessary for libWebCoreInternals are recorded in a predeclared
2498         variable before assigning to BUILT_SOURCES.
2499
2500         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
2501
2502 2011-06-06  Yong Li  <yoli@rim.com>
2503
2504         Reviewed by Eric Seidel.
2505
2506         https://bugs.webkit.org/show_bug.cgi?id=62097
2507         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
2508
2509         * Scripts/webkitpy/style/checkers/cpp.py:
2510         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2511
2512 2011-06-06  Xan Lopez  <xlopez@igalia.com>
2513
2514         Reviewed by Martin Robinson.
2515
2516         [GTK] Enable feature/symbol detection in NWRT/GTK
2517         https://bugs.webkit.org/show_bug.cgi?id=62136
2518
2519         Disable feature detection through DRT, since we don't support it,
2520         and set the libwebcore patch correctly so that symbol detection
2521         through 'nm' works.
2522
2523         * Scripts/webkitpy/layout_tests/port/gtk.py:
2524
2525 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
2526
2527         Reviewed by Tony Gentilcore.
2528
2529         Add a "prerender" state for page visibility.
2530         https://bugs.webkit.org/show_bug.cgi?id=62062
2531
2532         * DumpRenderTree/chromium/LayoutTestController.cpp:
2533         (LayoutTestController::setPageVisibility):
2534
2535 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
2536
2537         [Qt] Implement download feature for QtTestBrowser
2538         https://bugs.webkit.org/show_bug.cgi?id=61865
2539
2540         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
2541
2542         * QtTestBrowser/launcherwindow.cpp:
2543         (LauncherWindow::LauncherWindow):
2544         * QtTestBrowser/launcherwindow.h:
2545
2546 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
2547
2548         Reviewed by Csaba Osztrogonác.
2549
2550         [Qt] Implement download feature for QtTestBrowser
2551         https://bugs.webkit.org/show_bug.cgi?id=61865
2552
2553         * QtTestBrowser/launcherwindow.cpp:
2554         (LauncherWindow::LauncherWindow):
2555         (LauncherWindow::downloadRequest):
2556         (LauncherWindow::fileDownloadFinished):
2557         * QtTestBrowser/launcherwindow.h:
2558
2559 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
2560
2561         Reviewed by Dimitri Glazkov.
2562
2563         Make DumpRenderTree initialize window.internals.
2564         https://bugs.webkit.org/show_bug.cgi?id=61076
2565
2566         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
2567         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2568         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2569
2570 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
2571
2572         Reviewed by Kent Tamura.
2573
2574         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
2575         https://bugs.webkit.org/show_bug.cgi?id=61628
2576
2577         * Scripts/build-webkit:
2578
2579 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
2580
2581         Reviewed by Kent Tamura.
2582
2583         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
2584         https://bugs.webkit.org/show_bug.cgi?id=61631
2585
2586         * Scripts/build-webkit:
2587
2588 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2589
2590         Unreviewed. Fix the GTK+ build.
2591
2592         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
2593
2594 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
2595
2596         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
2597         works properly).
2598
2599         * Scripts/webkitpy/common/config/committers.py:
2600
2601 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2602
2603         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
2604         WebKit scripts expect, so other scripts work properly with wx.
2605
2606         * waf/build/build_utils.py:
2607         * waf/build/settings.py:
2608
2609 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2610
2611         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
2612         to build on Mac.
2613
2614         * waf/build/settings.py:
2615         * wx/install-unix-extras:
2616
2617 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2618
2619         [wx] Unreviewed build fixes for recent trunk changes.
2620
2621         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2622         (LayoutTestController::setTextDirection):
2623         * waf/build/settings.py:
2624
2625 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
2626
2627         Fix the GTK+ build.
2628
2629         * GNUmakefile.am: Add some missing newline escape.
2630
2631 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2632
2633         Try to fix the GTK+ bulid.
2634
2635         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
2636         source list.
2637
2638 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2639
2640         Reviewed by Adam Barth.
2641
2642         nrwt: should skip chromium test expectation overrides on upstream bots
2643         https://bugs.webkit.org/show_bug.cgi?id=61888
2644
2645         * Scripts/webkitpy/layout_tests/port/chromium.py:
2646         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2647
2648 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2649
2650         Reviewed by Ojan Vafai.
2651
2652         new-run-webkit-tests: minor logging, code cleanup
2653         https://bugs.webkit.org/show_bug.cgi?id=62055
2654
2655         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2656         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2657
2658 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2659
2660         Try to fix the build failure on the GTK+ 32-bit Release bot.
2661
2662         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
2663
2664 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
2665
2666         Reviewed by Ryosuke Niwa.
2667
2668         [GTK] Support smart replace for the pasteboard
2669         https://bugs.webkit.org/show_bug.cgi?id=61734
2670
2671         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
2672         This is required to produce consistent test results.
2673
2674         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2675         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
2676         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2677         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
2678         methods which calls into DumpRenderTreeSupportGtk.
2679
2680 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2681
2682         Reviewed by Dimitri Glazkov.
2683
2684         Teach Gtk build about window.internals
2685         https://bugs.webkit.org/show_bug.cgi?id=61071
2686
2687         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2688         (webViewWindowObjectCleared): Inject the new internals object when the
2689         window object clears.
2690         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
2691         Also do a little bit of cleanup.
2692
2693 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2694
2695         Reviewed by Tony Chang.
2696
2697         Worker may not be stopped after LT.
2698         https://bugs.webkit.org/show_bug.cgi?id=61847
2699
2700         Re-submit a variant of the first fix for this bug. It's possible
2701         that actually calling cleanup() in the worker threads was taking
2702         too long and we triggered the assertions in the manager thread.
2703
2704         I've bumped up the timeout in the manager and added better
2705         diagnostics. I also cleaned up the cleanup() code a bit because
2706         there was some unnecessary if-checks.
2707
2708         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2709         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2710
2711 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2712
2713         Reviewed by Tony Chang.
2714
2715         nrwt: fix duplicate logging regression
2716         https://bugs.webkit.org/show_bug.cgi?id=61981
2717
2718         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2719
2720 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
2721
2722         Reviewed by Adam Barth.
2723
2724         Modified addTouchPoint to correctly re-use touchPoint id values starting
2725         from the lowest not-un-use touchPoint id as is done by the embedder
2726         APIs. (Fixes BUGCR36415)
2727
2728         https://bugs.webkit.org/show_bug.cgi?id=62016
2729
2730         * DumpRenderTree/chromium/EventSender.cpp:
2731         (EventSender::addTouchPoint):
2732
2733 2011-06-03  Cary Clark  <caryclark@google.com>
2734
2735         Reviewed by Eric Seidel.
2736
2737         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
2738         https://bugs.webkit.org/show_bug.cgi?id=61534
2739
2740         Skia on Mac uses Skia to render WebKit, and CG
2741         to render UI elements. The CG elements need a
2742         transcribed graphics context that preserves the
2743         canvas matrix, and the canvas clip.
2744
2745         The SkiaBitLocker utility class sets up a CGContext
2746         from the SkCanvas, locks the bitmap's bits, and
2747         releases the lock when the class goes out of scope.
2748
2749         The SkiaBitLocker implementation is described by
2750         this patch:
2751         http://codereview.chromium.org/7031006/
2752
2753         When WebKit uses Skia for rendering, the WebCanvas
2754         is an SkCanvas. Create an equivalent CGContext to
2755         draw the scrollbar thumb.
2756
2757         As the Chrome Mac port does not yet use Skia, this
2758         patch has no effect and requires no tests.
2759
2760         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2761         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2762
2763 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2764
2765         Unreviewed build fix.
2766
2767         Fix typo.
2768
2769         * Scripts/old-run-webkit-tests:
2770
2771 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2772
2773         Reviewed by Csaba Osztrogonác.
2774
2775         Print error message when there is no httpd present on the system
2776         https://bugs.webkit.org/show_bug.cgi?id=61939
2777
2778         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
2779         * Scripts/webkitperl/httpd.pm:
2780
2781 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
2782
2783         Reviewed by Yury Semikhatsky.
2784
2785         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
2786         https://bugs.webkit.org/show_bug.cgi?id=61533
2787
2788         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
2789
2790         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2791         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
2792         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2793         * DumpRenderTree/chromium/LayoutTestController.cpp:
2794         (LayoutTestController::LayoutTestController):
2795         (LayoutTestController::setJavaScriptProfilingEnabled):
2796         * DumpRenderTree/chromium/LayoutTestController.h:
2797         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2798         (LayoutTestController::setJavaScriptProfilingEnabled):
2799         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2800         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
2801         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2802
2803 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
2804
2805         Reviewed by Tony Chang.
2806
2807         NRWT needs a way to log to a file without including backspaces without needing --verbose
2808         https://bugs.webkit.org/show_bug.cgi?id=60328
2809
2810         This change modifies NRWT so that if it can tell if it is
2811         writing to a terminal, it will overwrite any messages printed
2812         in the 'one-line-progress' and 'updates' print options, and if
2813         not (or if --verbose was specified) the messages will be printed
2814         without backspaces.
2815
2816         If the overwriting updates are disabled, one-line-progress will
2817         only print every 10 seconds instead of on every update. This
2818         ensures that we still get updates once in a while while the
2819         tests are running, even if we're not in --verbose mode. Note
2820         that one-line-progress will now still be printed in --verbose,
2821         since it's useful as long as you're not flooded with the
2822         updates.
2823
2824         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2825         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2826         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2827
2828 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
2829
2830         Reviewed by Gustavo Noronha Silva.
2831
2832         [GTK] autogen.sh is run twice for each buld on the bots
2833         https://bugs.webkit.org/show_bug.cgi?id=61951
2834
2835         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
2836         for the WebKit project. This prevents build-jsc runs from forcing subsequent
2837         build-webkit runs to re-rerun autogen.sh.
2838
2839 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2840
2841         Unreviewed, rolling out r87946.
2842         http://trac.webkit.org/changeset/87946
2843         https://bugs.webkit.org/show_bug.cgi?id=61965
2844
2845         Cause NRWT to break (Requested by abarth|gardener on #webkit).
2846
2847         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2848
2849 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2850
2851         Reviewed by Darin Adler.
2852
2853         Add build logistics and plumbing for window.internals object.
2854         https://bugs.webkit.org/show_bug.cgi?id=60313
2855
2856         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2857         * DumpRenderTree/chromium/TestShell.cpp:
2858         (TestShell::bindJSObjectsToWindow): Added injection code.
2859         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2860         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2861
2862 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
2863
2864         Reviewed by Dirk Pranke.
2865
2866         Call cleanup() explicitly at the end of worker.run().
2867         https://bugs.webkit.org/show_bug.cgi?id=61847
2868
2869         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2870
2871 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2872
2873         Unreviewed, rolling out r87926.
2874         http://trac.webkit.org/changeset/87926
2875         https://bugs.webkit.org/show_bug.cgi?id=60313
2876
2877         Fails to find WebCoreTestSupport.dylib on bots.
2878
2879         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2880         * DumpRenderTree/chromium/TestShell.cpp:
2881         (TestShell::bindJSObjectsToWindow):
2882         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2883         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2884
2885 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
2886
2887         Reviewed by Darin Adler.
2888
2889         Add build logistics and plumbing for window.internals object.
2890         https://bugs.webkit.org/show_bug.cgi?id=60313
2891
2892         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2893         * DumpRenderTree/chromium/TestShell.cpp:
2894         (TestShell::bindJSObjectsToWindow): Added injection code.
2895         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2896         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2897
2898 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2899
2900         Reviewed by Eric Seidel.
2901
2902         Adjust efl coding style to more efl directories
2903         https://bugs.webkit.org/show_bug.cgi?id=61903
2904
2905         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
2906
2907 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2908
2909         Reviewed by Tony Chang.
2910
2911         old-run-webkit-tests: add support for audio files
2912         https://bugs.webkit.org/show_bug.cgi?id=57992
2913
2914         * Scripts/old-run-webkit-tests:
2915
2916 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
2917
2918         Reviewed by Adam Barth.
2919
2920         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
2921         https://bugs.webkit.org/show_bug.cgi?id=34314
2922
2923         * DumpRenderTree/DumpRenderTree.gypi:
2924         * DumpRenderTree/chromium/LayoutTestController.cpp:
2925         (LayoutTestController::LayoutTestController):
2926         (LayoutTestController::setImagesAllowed):
2927         (LayoutTestController::setStorageAllowed):
2928         * DumpRenderTree/chromium/LayoutTestController.h:
2929         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
2930         (WebPermissions::WebPermissions):
2931         (WebPermissions::~WebPermissions):
2932         (WebPermissions::allowImages):
2933         (WebPermissions::allowStorage):
2934         (WebPermissions::setImagesAllowed):
2935         (WebPermissions::setStorageAllowed):
2936         (WebPermissions::reset):
2937         * DumpRenderTree/chromium/WebPermissions.h:
2938
2939 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
2940
2941         Reviewed by Tony Chang.
2942
2943         Test plugin should support event logging on the windows port.
2944         https://bugs.webkit.org/show_bug.cgi?id=61721
2945
2946         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2947         (handleEventWin): Well, handle them.
2948
2949 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
2950
2951         Reviewed by Tony Chang.
2952
2953         [chromium] Use correct file name for dragging out images.
2954         https://bugs.webkit.org/show_bug.cgi?id=24887
2955
2956         * DumpRenderTree/chromium/EventSender.cpp:
2957         (EventSender::EventSender):
2958         (EventSender::dumpFilenameBeingDragged):
2959         * DumpRenderTree/chromium/EventSender.h:
2960
2961 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2962
2963         Reviewed by Tony Chang.
2964
2965         nrwt: make webaudio work w/o content-length header
2966         https://bugs.webkit.org/show_bug.cgi?id=61819
2967
2968         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2969         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2970         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2971         * Scripts/webkitpy/layout_tests/port/webkit.py:
2972
2973 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2974
2975         Reviewed by Andreas Kling.
2976
2977         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
2978         https://bugs.webkit.org/show_bug.cgi?id=61802
2979
2980         Add command line parameter and menu item to MiniBrowser application 
2981         enabling use of QGLWidget for browser viewport.
2982
2983         * MiniBrowser/qt/BrowserWindow.cpp:
2984         (BrowserWindow::BrowserWindow):
2985         (BrowserWindow::toggleGLViewport):
2986         * MiniBrowser/qt/BrowserWindow.h:
2987         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2988         (MiniBrowserApplication::handleUserOptions):
2989         * MiniBrowser/qt/MiniBrowserApplication.h:
2990         (WindowOptions::WindowOptions):
2991
2992 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
2993
2994         Reviewed by Xan Lopez.
2995
2996         Print out autogen arguments when they differ from the last set, to help
2997         with debugging build issues.
2998
2999         * Scripts/webkitdirs.pm: Print out previous and current build arguments
3000         when they differ.
3001
3002 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3003
3004         Reviewed by Martin Robinson.
3005
3006         [GTK] run-launcher should run MiniBrowser in WebKit2
3007         https://bugs.webkit.org/show_bug.cgi?id=61858
3008
3009         * Scripts/run-launcher: Check whether -2 command line option has
3010         been passed and run MiniBrowser instead of GtkLauncher.
3011
3012 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
3013
3014         Reviewed by Dirk Pranke.
3015
3016         Fix exception in verbose printing mode.
3017         https://bugs.webkit.org/show_bug.cgi?id=61723
3018
3019         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3020
3021 2011-05-31  Yong Li  <yoli@rim.com>
3022
3023         Reviewed by Eric Seidel.
3024
3025         https://bugs.webkit.org/show_bug.cgi?id=54807
3026         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
3027         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
3028         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
3029         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
3030         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
3031         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
3032         rule we should have in order to make our code independent from compilers and compiler flags.
3033
3034         * Scripts/webkitpy/style/checkers/cpp.py:
3035
3036 2011-05-31  Hironori Bono  <hbono@chromium.org>
3037
3038         Reviewed by Eric Seidel.
3039
3040         Add a JavaScript function layoutTestController.setTextDirection().
3041         https://bugs.webkit.org/show_bug.cgi?id=50952
3042
3043         This change adds a new JavaScript function setTextDirection() to the
3044         LayoutTestController class of Safari and Chrome to write layout tests
3045         that changes the text direction of an editable element.
3046
3047         * DumpRenderTree/LayoutTestController.cpp:
3048         (setTextDirectionCallback):
3049         (LayoutTestController::staticFunctions):
3050         * DumpRenderTree/LayoutTestController.h:
3051         * DumpRenderTree/chromium/LayoutTestController.cpp:
3052         (LayoutTestController::LayoutTestController):
3053         (LayoutTestController::setTextDirection):
3054         * DumpRenderTree/chromium/LayoutTestController.h:
3055         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3056         (LayoutTestController::setTextDirection):
3057         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3058         (LayoutTestController::setTextDirection):
3059         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3060         (LayoutTestController::setTextDirection):
3061
3062 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3063
3064         Reviewed by Simon Hausmann.
3065
3066         [Qt] User-agent list of Qt test browsers is very outdated
3067         https://bugs.webkit.org/show_bug.cgi?id=61531
3068
3069         The user can edit the user-agent manually, so there's no need to have
3070         a super complete and up to date list, but it's nice to have it
3071         minimally updated.
3072
3073         * MiniBrowser/qt/useragentlist.txt:
3074         * QtTestBrowser/useragentlist.txt:
3075
3076 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
3077
3078         Reviewed by Adam Roben.
3079
3080         [GTK] [WebKit2] Implement a basic WebKitTestRunner
3081         https://bugs.webkit.org/show_bug.cgi?id=57068
3082
3083         Add an implementation of WebKitTestRunner for GTK+.
3084
3085         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
3086         * Scripts/old-run-webkit-tests: Ditto.
3087         * Scripts/run-launcher: Ditto.
3088         * Scripts/webkitdirs.pm: Ditto.
3089         * WebKitTestRunner/GNUmakefile.am: Added.
3090         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3091         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
3092         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3093         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3094         * WebKitTestRunner/PlatformWebView.h:
3095         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
3096         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
3097         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3098         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3099         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3100         (main): Added.
3101
3102 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
3103
3104         Reviewed by Tony Chang.
3105
3106         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
3107         https://bugs.webkit.org/show_bug.cgi?id=60241
3108
3109         * Scripts/new-run-webkit-tests:
3110
3111 2011-05-31  Eric Seidel  <eric@webkit.org>
3112
3113         Reviewed by David Kilzer.
3114
3115         webkitpy should create zips with zip -9
3116         https://bugs.webkit.org/show_bug.cgi?id=61789
3117
3118         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
3119
3120         * Scripts/webkitpy/common/system/workspace.py:
3121         * Scripts/webkitpy/common/system/workspace_unittest.py:
3122
3123 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3124
3125         Reviewed by Csaba Osztrogonác.
3126
3127         [Qt] Implement find feature for QtTestBrowser
3128         https://bugs.webkit.org/show_bug.cgi?id=61425
3129
3130         Buildfix for --minimal and CONFIG+=qt_minimal build.
3131
3132         * QtTestBrowser/launcherwindow.cpp:
3133         (LauncherWindow::LauncherWindow):
3134         (LauncherWindow::createChrome):
3135         * QtTestBrowser/launcherwindow.h:
3136
3137 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3138
3139         Reviewed by Csaba Osztrogonác.
3140
3141         [Qt] Implement find feature for QtTestBrowser
3142         https://bugs.webkit.org/show_bug.cgi?id=61425
3143
3144         * QtTestBrowser/launcherwindow.cpp:
3145         (LauncherWindow::LauncherWindow):
3146         (LauncherWindow::createChrome):
3147         (LauncherWindow::showFindBar):
3148         (LauncherWindow::find):
3149         * QtTestBrowser/launcherwindow.h:
3150
3151 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3152
3153         Reviewed by Martin Robinson.
3154
3155         [GTK] Implement JavaScript dialogs in MiniBrowser
3156         https://bugs.webkit.org/show_bug.cgi?id=61725
3157
3158         * MiniBrowser/gtk/BrowserWindow.c:
3159         (WKStringGetCString): Helper function to get a UTF-8 c string from
3160         a WKStringRef.
3161         (WKURLGetCString): Helper function to get a UTF-8 c string from a
3162         WKURLRef.
3163         (browserWindowUpdateURL): Update to use WKURLGetCString.
3164         (didReceiveTitleForFrame): Update to use WKStringGetCString.
3165         (createMessageDialog): Create a GtkMessageDialog.
3166         (runJavaScriptAlert):
3167         (runJavaScriptConfirm):
3168         (runJavaScriptPrompt):
3169         (browserWindowUIClientInit):
3170
3171 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
3172
3173         Reviewed by Kent Tamura.
3174
3175         WebSocket closing handshake
3176         https://bugs.webkit.org/show_bug.cgi?id=35721
3177
3178         * Scripts/webkitpy/thirdparty/__init__.py:
3179         Pull in pywebsocket 0.6b1. We need to update pywebsocket
3180         to get the right behavior of closing handshake.
3181
3182 2011-05-29  Daniel Bates  <dbates@rim.com>
3183
3184         Reviewed by David Kilzer.
3185
3186         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
3187         https://bugs.webkit.org/show_bug.cgi?id=61162
3188
3189         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
3190         that omits a line count. In particular, the chunk range regular expression does
3191         not match a chunk range line that omits a line count. GNU diff(1) will omit the
3192         line count in the chunk range if the line count is exactly 1. For example, appending
3193         a new line to the end of an existing file F that contains exactly one line of text will
3194         be represented in a diff with a chunk range line that omits the line count for F.
3195
3196         * Scripts/VCSUtils.pm:
3197           (parseChunkRange): Added.
3198         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
3199         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3200           - Added unit test "Git: Append new line to the end of an existing file".
3201
3202 2011-05-28  Adam Barth  <abarth@webkit.org>
3203
3204         Reviewed by Eric Seidel.
3205
3206         EWS builds patches that fail to build twice, which seems useless and slows down the bots
3207         https://bugs.webkit.org/show_bug.cgi?id=55585
3208
3209         This patch switches all the early warning system bots over to the new
3210         PatchAnalysisTask-based infrastructure.  This patch makes these bots
3211         more efficient (in the case where patches fail to build) and paves the
3212         way for running tests on these bots!
3213
3214         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3215         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3216         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3217         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3218         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3219         * Scripts/webkitpy/tool/commands/queues.py:
3220
3221 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
3222
3223         Reviewed by Kent Tamura.
3224
3225         Add bashi as a committer.
3226
3227         https://bugs.webkit.org/show_bug.cgi?id=61685
3228
3229         * Scripts/webkitpy/common/config/committers.py:
3230
3231 2011-05-27  Adam Barth  <abarth@webkit.org>
3232
3233         Reviewed by Eric Seidel.
3234
3235         When checking whether the tree is red, the EWS posts a link to the wrong log
3236         https://bugs.webkit.org/show_bug.cgi?id=61072
3237
3238         We need to cache the original script error because that contains the
3239         failure log we want to upload.  If we don't cache that script error,
3240         self._script_error will get overwritten when we sanity check the clean
3241         tree (and it also has test failures).
3242
3243         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3244             - This testing approach is slightly goofy.  We'd like to use
3245               assertRaisesRegexp, but that's not available until Python 2.7.
3246         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3247
3248 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
3249
3250         Reviewed by Adam Barth.
3251
3252         Add layoutTestController.setStorageAllowed() to control whether access
3253         to the localStorage API is enabled via the WebPermissionClient
3254         https://bugs.webkit.org/show_bug.cgi?id=61581
3255
3256         * DumpRenderTree/chromium/LayoutTestController.cpp:
3257         (LayoutTestController::LayoutTestController):
3258         (LayoutTestController::setStorageAllowed):
3259         * DumpRenderTree/chromium/LayoutTestController.h:
3260         * DumpRenderTree/chromium/TestShell.cpp:
3261         (TestShell::TestShell):
3262         (TestShell::createNewWindow):
3263         * DumpRenderTree/chromium/TestShell.h:
3264         * DumpRenderTree/chromium/WebPermissions.h: Added.
3265         (WebPermissions::WebPermissions):
3266         (WebPermissions::allowStorage):
3267         (WebPermissions::setStorageAllowed):
3268         (WebPermissions::reset):
3269
3270 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3271
3272         Reviewed by Eric Seidel.
3273
3274         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
3275         https://bugs.webkit.org/show_bug.cgi?id=60326
3276
3277         This patch removes a lot of the complexity from the
3278         metered_stream implementation that was unnecessary since there
3279         was only one caller and the logic could be coordinated better.
3280
3281         There should be no functional changes in this patch, just code
3282         getting deleted and cleaned up.
3283
3284         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
3285         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
3286         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3287         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3288
3289 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3290
3291         Reviewed by Eric Seidel.
3292
3293         NRWT: minor cleanup in printing module
3294         https://bugs.webkit.org/show_bug.cgi?id=60329
3295
3296         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3297
3298 2011-05-27  Steve Lacey  <sjl@chromium.org>
3299
3300         Reviewed by David Levin.
3301
3302         Add sjl@chromium.org as a committer.
3303
3304         https://bugs.webkit.org/show_bug.cgi?id=61672
3305
3306         * Scripts/webkitpy/common/config/committers.py:
3307
3308 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3309
3310         Reviewed by Adam Barth.
3311
3312         NRWT: remove --print detailed-progress
3313         https://bugs.webkit.org/show_bug.cgi?id=60324
3314
3315         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
3316         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3317         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3319
3320 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3321
3322         Reviewed by Ojan Vafai.
3323
3324         NRWT: debug messages from the workers are being logged twice
3325         https://bugs.webkit.org/show_bug.cgi?id=60428
3326
3327         It looks like when the workers are run in separate processes
3328         we end up getting two copies of every log message they print.
3329         This has to do with the multiprocessing module on UNIX cloning
3330         the log configuration in a way I wasn't expecting, and so two
3331         log handlers end up getting registered.
3332
3333         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
3334         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3335         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3336         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3337
3338 2011-05-27  Adam Roben  <aroben@apple.com>
3339
3340         Always decode tester names from location.hash
3341
3342         When navigating directly to a tester-specific URL (e.g.,
3343         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
3344         with a URL-encoded tester name in the page, and then the encoded name could make its way
3345         into Bugzilla bugs. Bad!
3346
3347         Reviewed by David Kilzer.
3348
3349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3350         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
3351         decodeURIComponent before trying to use it.
3352
3353 2011-05-27  Adam Roben  <aroben@apple.com>
3354
3355         Remove testing code that snuck into r87528
3356
3357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3358         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
3359
3360 2011-05-27  Adam Roben  <aroben@apple.com>
3361
3362         Add links to TestFailures to easily file bugs about failing tests
3363
3364         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
3365         links to file bugs for failing tests
3366
3367         Reviewed by David Kilzer.
3368
3369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3370         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
3371         for a particular build.
3372         (Builder.prototype._getFailingTests): Use resultsPageURL.
3373
3374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3375         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
3376         failures.
3377         (ViewController.prototype._domForBuildName): Use resultsPageURL.
3378         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
3379         new bug link. The bug has a title, description, and URL already filled in for you!
3380
3381 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3382
3383         Unreviewed, rolling out r87464.
3384         http://trac.webkit.org/changeset/87464
3385         https://bugs.webkit.org/show_bug.cgi?id=61643
3386
3387         client-close/server-close tests are flaky on Chromium Mac and
3388         Windows (Requested by aklein on #webkit).
3389
3390         * Scripts/webkitpy/thirdparty/__init__.py:
3391
3392 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
3393
3394         Added Douglas Davidson to contributors list for easier CC'ing.
3395
3396         * Scripts/webkitpy/common/config/committers.py:
3397
3398 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
3399
3400         Reviewed by Adam Barth.
3401
3402         Fix worldID and destinationDomain argument names
3403         https://bugs.webkit.org/show_bug.cgi?id=61571
3404
3405         As part of working on r87423, I noticed a couple of inconsistencies in
3406         argument names:
3407         - We would use worldId in .h files but worldID in .cpp files.
3408           Standardize on the latter
3409         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
3410           destinationDomains argument, even though the actual parameter was for
3411           a single domain (renamed to be singular).
3412
3413         * DumpRenderTree/LayoutTestController.h:
3414         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3415         (LayoutTestController::evaluateScriptInIsolatedWorld):
3416
3417 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
3418
3419         Reviewed by Kent Tamura.
3420
3421         WebSocket closing handshake
3422         https://bugs.webkit.org/show_bug.cgi?id=35721
3423
3424         * Scripts/webkitpy/thirdparty/__init__.py:
3425         Pull in pywebsocket 0.6b1. We need to update pywebsocket
3426         to get the right behavior of closing handshake.
3427
3428 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
3429
3430         Reviewed by Andreas Kling.
3431
3432         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
3433         https://bugs.webkit.org/show_bug.cgi?id=42676
3434
3435         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
3436
3437         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3438         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3439         (WTR::InjectedBundle::beginTesting):
3440         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3441         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
3442         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3443
3444 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3445
3446         Reviewed by Andreas Kling.
3447
3448         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
3449         https://bugs.webkit.org/show_bug.cgi?id=61527
3450
3451         The setMaximumHeight() call is unecessary and breaks the dialog at
3452         least on my setup.
3453
3454         * QtTestBrowser/launcherwindow.cpp:
3455         (LauncherWindow::showUserAgentDialog):
3456
3457 2011-05-02  Robert Hogan  <robert@webkit.org>
3458
3459         Reviewed by Adam Roben.
3460
3461         [Qt] Allow popup windows from plugins when initiated by a user gesture
3462
3463         https://bugs.webkit.org/show_bug.cgi?id=41292
3464
3465         Support parameters introduced in plugin-initiate-popup-window.html
3466
3467         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3468         (webkit_test_plugin_new_instance):
3469         (webkit_test_plugin_handle_event):
3470
3471 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
3472
3473         Reviewed by Adam Barth.
3474
3475         Support cross-origin XMLHttpRequest in isolated worlds
3476         https://bugs.webkit.org/show_bug.cgi?id=59843
3477
3478         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
3479
3480         * DumpRenderTree/chromium/LayoutTestController.cpp:
3481         (LayoutTestController::LayoutTestController):
3482         (LayoutTestController::setIsolatedWorldSecurityOrigin):
3483         * DumpRenderTree/chromium/LayoutTestController.h:
3484
3485 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
3486
3487         Reviewed by Adam Roben.
3488
3489         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
3490         https://bugs.webkit.org/show_bug.cgi?id=61474
3491         <rdar://problem/9468337>
3492
3493         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3494         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
3495
3496 2011-05-26  Andreas Kling  <kling@webkit.org>
3497
3498         Unreviewed, correct address to webkit-committers mailing list.
3499
3500         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3501
3502 2011-05-25  Adam Roben  <aroben@apple.com>
3503
3504         Don't assume that builds finish in the order they were started
3505
3506         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
3507         build when one slave is taking a long time to finish a build
3508
3509         Reviewed by Antti Koivisto.
3510
3511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3512         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
3513         newer than the oldest in-progress build are also themselves in progress. Just check whether
3514         each build is actually in progress (as signified by its presence in the currentBuilds set).
3515
3516 2011-05-25  Adam Roben  <aroben@apple.com>
3517
3518         Correctly detect cases where only a single test failed/crashed/timed out
3519
3520         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
3521         failing test
3522
3523         Reviewed by Darin Adler.
3524
3525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3526         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
3527         will be singular when only a single test fails/crashes/times out.
3528
3529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3530         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
3531         failed/crashed/timed out.
3532
3533 2011-05-26  Tom Hudson  <tomhudson@google.com>
3534
3535         Reviewed by Tony Chang.
3536
3537         Add flags to Chromium ImageDiff to write image comparison metrics on
3538         stdout.
3539         https://bugs.webkit.org/show_bug.cgi?id=60569
3540
3541         * DumpRenderTree/chromium/ImageDiff.cpp:
3542         (Image::createFromStdin): Fix spelling.
3543         (maxOf3): New function to do 3-way maximum.
3544         (getRedComponent): Extract red component from ABGR packed encoding.
3545         (getGreenComponent): Extract green component from ABGR packed encoding.
3546         (getBlueComponent): Extract blue component from ABGR packed encoding.
3547         (weightedPercentageDifferent): Determine % of pixels different in two
3548         images multiplied by intensity difference of each pixel.
3549         (printHelp): Document new arguments.
3550         (compareImages): Parameterize.
3551         (untestedCompareImages): Parameterize.
3552         (diffImages): Parameterize; write results on stdout if requested.
3553         (main): Parse new arguments.
3554
3555 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
3556
3557         Reviewed by Simon Hausmann.
3558
3559         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
3560         https://bugs.webkit.org/show_bug.cgi?id=42697
3561
3562         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
3563
3564         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3565         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3566         (WTR::InjectedBundle::beginTesting):
3567         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3568         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
3569         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3570
3571 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
3572
3573         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
3574         https://bugs.webkit.org/show_bug.cgi?id=61428
3575         <rdar://problem/9457006>
3576
3577         Reviewed by Adam Roben.
3578
3579         The crash occurs when Flash posts a message to a window that it
3580         creates, and in processing the message, it calls NPN_Evaluate to
3581         evaluate JavaScript that removes the plug-in from the page. Flash then
3582         crashes when we return to Flash code.
3583
3584         This test emulates that behavior.
3585
3586         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
3587         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
3588         Initialize member vars.
3589         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
3590         Remove our custom property from the message window, and destroy it.
3591         (CallJSThatDestroysPlugin::NPP_Destroy):
3592         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
3593         layout test controller that we're done.
3594         (wndProc):
3595         Get the PluginTest object, and call its runTest() function.
3596         (CallJSThatDestroysPlugin::NPP_New):
3597         Setup the test: register a class for the message-only window, create
3598         it, and post a message to it to run the test.
3599         (CallJSThatDestroysPlugin::runTest):
3600         Execute JS that removes the plug-in from the page, and if we're not
3601         destroyed, log a success message.
3602
3603         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3604         Add new test to project.
3605
3606 2011-05-25  Tony Chang  <tony@chromium.org>
3607
3608         Reviewed by Adam Barth.
3609
3610         webkitpy's NetworkTransaction shouldn't use mechanize
3611         https://bugs.webkit.org/show_bug.cgi?id=61450
3612
3613         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
3614         use urllib2 directly.  Re-add NetworkTransaction to
3615         test_results_uploader.py (reverting r87124).
3616
3617         * Scripts/webkitpy/common/net/networktransaction.py:
3618         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3619
3620 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
3621
3622         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
3623         until the port begins using those export macros.
3624
3625         * DumpRenderTree/chromium/config.h:
3626
3627 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3628
3629         Unreviewed, rolling out r87257.
3630         http://trac.webkit.org/changeset/87257
3631         https://bugs.webkit.org/show_bug.cgi?id=61457
3632
3633         This broke layout tests, see bug 61431. (Requested by
3634         hwennborg on #webkit).
3635
3636         * DumpRenderTree/chromium/LayoutTestController.cpp:
3637         (LayoutTestController::LayoutTestController):
3638         (LayoutTestController::clearAllDatabases):
3639         * DumpRenderTree/chromium/LayoutTestController.h:
3640
3641 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
3642
3643         Reviewed by Andreas Kling.
3644
3645         [Qt] fast/css/disabled-author-styles.html failed
3646         https://bugs.webkit.org/show_bug.cgi?id=61438
3647
3648         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
3649
3650         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3651         (WebCore::WebPage::resetSettings):
3652         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3653         (LayoutTestController::setAuthorAndUserStylesEnabled):
3654         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3655
3656 2011-05-25  Adam Roben  <aroben@apple.com>
3657
3658         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
3659
3660         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
3661         started exiting early due to too many crashes, timeouts, or failures
3662
3663         Reviewed by David Kilzer.
3664
3665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: