Get rid of forward exit on DoubleAsInt32
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
2
3         Get rid of forward exit on DoubleAsInt32
4         https://bugs.webkit.org/show_bug.cgi?id=125552
5
6         Reviewed by Oliver Hunt.
7         
8         Add some support for testing the generic (non-X86) paths on X86 by disabling
9         architecture-specific optimizations (ASO's).
10
11         * Scripts/run-javascriptcore-tests:
12         * Scripts/run-jsc-stress-tests:
13
14 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
15
16         Unreviewed EFL build fix attempt
17
18         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
19         * WebKitTestRunner/CMakeLists.txt: Ditto.
20
21 2013-12-10  Anders Carlsson  <andersca@apple.com>
22
23         Add a HashMap constructor that takes an initializer list
24         https://bugs.webkit.org/show_bug.cgi?id=125551
25
26         Reviewed by Dan Bernstein.
27
28         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
29         (TestWebKitAPI::TEST):
30
31 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
32
33         Use std::array when computing MD5 checksum
34         https://bugs.webkit.org/show_bug.cgi?id=125509
35
36         Reviewed by Anders Carlsson.
37
38         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
39
40         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
41         (computeMD5HashStringForBitmapContext):
42         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
43         (computeMD5HashStringForBitmapContext):
44         * TestWebKitAPI/Tests/WTF/MD5.cpp:
45         (TestWebKitAPI::expectMD5):
46         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
47         (WTR::computeMD5HashStringForCairoSurface):
48         * WebKitTestRunner/cg/TestInvocationCG.cpp:
49         (WTR::computeMD5HashStringForContext):
50
51 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
52
53         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
54         https://bugs.webkit.org/show_bug.cgi?id=125522
55
56         Reviewed by Chris Fleizach.
57
58         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
59
60         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
61         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
62
63 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
64
65         Add --makeargs option to build-jsc
66         https://bugs.webkit.org/show_bug.cgi?id=125344
67
68         Reviewed by Filip Pizlo.
69
70         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
71
72 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
73
74         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
75         https://bugs.webkit.org/show_bug.cgi?id=125497
76
77         Reviewed by Mario Sanchez Prada.
78
79         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
80         (AccessibilityUIElement::stringForRange): Implemented.
81         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
82         (WTR::AccessibilityUIElement::stringForRange): Implemented.
83
84 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
85
86         Various fixes for the CMake GTK+ build
87
88         Reviewed by Gustavo Noronha.
89
90         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
91         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
92
93 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
94
95         --cloop option does not work in Tools/Scripts/build-jsc.
96         https://bugs.webkit.org/show_bug.cgi?id=125214
97
98         Reviewed by Csaba Osztrogonác.
99
100         * Scripts/build-jsc:
101
102 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
103
104         Merge mark_for_landing and mark_for_commit_queue into one argument
105         https://bugs.webkit.org/show_bug.cgi?id=125448
106
107         Reviewed by Ryosuke Niwa.
108
109         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
110         (CommitQueueFlag):
111         (Bugzilla._commit_queue_flag):
112         (Bugzilla._fill_attachment_form):
113         (Bugzilla.add_patch_to_bug):
114         (Bugzilla.create_bug):
115         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
116         (test_commit_queue_flag.assert_commit_queue_flag):
117         (test_commit_queue_flag):
118
119 2013-12-09  Tim Horton  <timothy_horton@apple.com>
120
121         Remove dead extract_reference_link.py (and the reftests module)
122         https://bugs.webkit.org/show_bug.cgi?id=125116
123
124         Reviewed by Ryosuke Niwa.
125
126         This code doesn't seem to have ever been used.
127
128         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
129         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
130         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
131
132 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
133
134         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
135         https://bugs.webkit.org/show_bug.cgi?id=125456
136
137         Reviewed by Chris Fleizach.
138
139         Return 'AXSection' for section roles instead of 'AXDiv'.
140
141         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
142         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
143
144 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
145
146         check-webkit-style should check for extra newlines at EOF
147         https://bugs.webkit.org/show_bug.cgi?id=125424
148
149         Reviewed by Darin Adler.
150
151         Report a style violation if extraneous newlines are added
152         to the end of a C++ file. There should only be one newline at EOF.
153
154         * Scripts/webkitpy/style/checkers/cpp.py:
155         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
156         (check_for_extra_new_line_at_eof): Added.
157         (_process_lines): Added new check and renamed existing EOF check.
158         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
159         (CppStyleTest.test_extra_newlines_at_eof): Added.
160         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
161
162 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
163
164         check-webkit-style: ternary operator in macro call identified as initialization list
165         https://bugs.webkit.org/show_bug.cgi?id=125443
166
167         Reviewed by Ryosuke Niwa.
168
169         Do not match initialization list when questionmark is placed before :
170
171         * Scripts/webkitpy/style/checkers/cpp.py:
172         (check_member_initialization_list):
173
174 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
175
176         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
177         https://bugs.webkit.org/show_bug.cgi?id=125451
178
179         Reviewed by Mario Sanchez Prada.
180
181         Create the needed callbacks for DRT and WKTR.
182
183         * DumpRenderTree/AccessibilityUIElement.cpp:
184         (characterAtOffsetCallback): added
185         (wordAtOffsetCallback): added
186         (lineAtOffsetCallback): added
187         (sentenceAtOffsetCallback): added
188         (AccessibilityUIElement::getJSClass):
189         * DumpRenderTree/AccessibilityUIElement.h:
190         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
191         (stringAtOffset): added
192         (AccessibilityUIElement::characterAtOffset): added
193         (AccessibilityUIElement::wordAtOffset): added
194         (AccessibilityUIElement::lineAtOffset): added
195         (AccessibilityUIElement::sentenceAtOffset): added
196         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
197         (WTR::AccessibilityUIElement::characterAtOffset): added
198         (WTR::AccessibilityUIElement::wordAtOffset): added
199         (WTR::AccessibilityUIElement::lineAtOffset): added
200         (WTR::AccessibilityUIElement::sentenceAtOffset): added
201         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
202         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
203         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
204         (WTR::stringAtOffset): added
205         (WTR::AccessibilityUIElement::characterAtOffset): added
206         (WTR::AccessibilityUIElement::wordAtOffset): added
207         (WTR::AccessibilityUIElement::lineAtOffset): added
208         (WTR::AccessibilityUIElement::sentenceAtOffset): added
209
210 2013-12-08  Sam Weinig  <sam@webkit.org>
211
212         32-bit MiniBrowser doesn't build
213         https://bugs.webkit.org/show_bug.cgi?id=125420
214
215         Reviewed by Dan Bernstein.
216
217         * MiniBrowser/mac/AppDelegate.h:
218         * MiniBrowser/mac/AppDelegate.m:
219         (-[BrowserAppDelegate init]):
220         (-[BrowserAppDelegate applicationWillTerminate:]):
221
222 2013-12-08  Brian Holt  <brian.holt@samsung.com>
223
224         [WK2] Add ENABLE_NETWORK_PROCESS flag
225         https://bugs.webkit.org/show_bug.cgi?id=125421
226
227         Add support to build with the Network Process enabled.
228
229         Reviewed by Martin Robinson.
230
231         * Scripts/webkitperl/FeatureList.pm:
232
233 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
234
235         Fold typedArray.length if typedArray is constant
236         https://bugs.webkit.org/show_bug.cgi?id=125252
237
238         Reviewed by Sam Weinig.
239         
240         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
241         should put tests that run just like JSRegress but don't run as part of LayoutTests.
242         Currently I'm using it for tests that require some surgical support from jsc.cpp.
243
244         * Scripts/run-javascriptcore-tests:
245
246 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
247
248         [gdb] Update printers for WTF::CString, JSC::JSString
249         https://bugs.webkit.org/show_bug.cgi?id=124600
250
251         Reviewed by Gustavo Noronha Silva.
252
253         Update the two printers after they fell behind the changes in implementation.
254
255         * gdb/webkit.py:
256         (WTFCStringPrinter.to_string):
257         (JSCJSStringPrinter.to_string):
258
259 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
260
261         [webkitpy] Add a WestonDriver unit test
262         https://bugs.webkit.org/show_bug.cgi?id=125408
263
264         Reviewed by Gustavo Noronha Silva.
265
266         Add a webkitpy unit test for the Weston driver.
267
268         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
269         (WestonDriverTest):
270         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
271         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
272         the server environment contains proper WAYLAND and GDK_BACKEND entries.
273         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
274         the driver cleans up the temporary directory.
275         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
276         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
277
278 2013-12-08  Brendan Long  <b.long@cablelabs.com>
279
280         [Gtk] install-dependencies doesn't install libgtk-3-dev
281         https://bugs.webkit.org/show_bug.cgi?id=125320
282
283         Reviewed by Gustavo Noronha Silva.
284
285         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
286
287 2013-12-07  Sam Weinig  <sam@webkit.org>
288
289         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
290         https://bugs.webkit.org/show_bug.cgi?id=125401
291
292         Reviewed by Dan Bernstein.
293
294         * MiniBrowser/mac/WK2BrowserWindowController.m:
295         (-[WK2BrowserWindowController fetch:]):
296         (-[WK2BrowserWindowController reload:]):
297         (-[WK2BrowserWindowController goBack:]):
298         (-[WK2BrowserWindowController goForward:]):
299         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
300         (-[WK2BrowserWindowController currentZoomFactor]):
301         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
302         (-[WK2BrowserWindowController zoomIn:]):
303         (-[WK2BrowserWindowController zoomOut:]):
304         (-[WK2BrowserWindowController canResetZoom]):
305         (-[WK2BrowserWindowController resetZoom:]):
306         (-[WK2BrowserWindowController toggleZoomMode:]):
307         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
308
309 2013-12-07  Sam Weinig  <sam@webkit.org>
310
311         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
312         https://bugs.webkit.org/show_bug.cgi?id=125400
313
314         Reviewed by Dan Bernstein.
315
316         * MiniBrowser/mac/AppDelegate.h:
317         * MiniBrowser/mac/AppDelegate.m:
318         * MiniBrowser/mac/WK2BrowserWindowController.h:
319         * MiniBrowser/mac/WK2BrowserWindowController.m:
320         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
321         (-[WK2BrowserWindowController dealloc]):
322         (createNewPage):
323         (-[WK2BrowserWindowController awakeFromNib]):
324         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
325         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
326         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
327         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
328         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
329         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
330
331 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
332
333         [GTK] Run each gtest subtest separately instead of in one go
334         https://bugs.webkit.org/show_bug.cgi?id=125386
335
336         Reviewed by Martin Robinson.
337
338         This is what other ports are doing (except they build each test as a separate binary)
339         and will help with the timeouts we sometimes hit because it applies to the full test
340         run.
341
342         * Scripts/run-gtk-tests:
343         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
344         (TestRunner._run_google_test): run a single subtest from a gtest binary.
345         (TestRunner._run_google_test_suite): call the binary once per subtest.
346
347 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
348
349         Move PrettyPatch related code to prettypatch.py
350         https://bugs.webkit.org/show_bug.cgi?id=124937
351
352         Reviewed by Ryosuke Niwa.
353
354         This code seems to have a better place here than in Port, since PrettyPatch already knows
355         pretty_patch_path, and this also unifies the usage of PrettyPatch
356
357         * Scripts/webkitpy/common/prettypatch.py:
358         (PrettyPatch.__init__):
359         (PrettyPatch.pretty_diff):
360         (PrettyPatch):
361         (PrettyPatch.pretty_patch_available):
362         (PrettyPatch.check_pretty_patch):
363         (PrettyPatch.pretty_patch_text):
364         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
365         (TestResultWriter.create_text_diff_and_write_result):
366         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
367         (summarize_results):
368         * Scripts/webkitpy/port/base.py:
369         (Port.__init__):
370         (Port.wdiff_available):
371         (Port.check_image_diff):
372         (Port.wdiff_text):
373         * Scripts/webkitpy/port/base_unittest.py:
374         (PortTest.test_pretty_patch_os_error):
375         (PortTest.test_pretty_patch_script_error):
376
377 2013-12-06  Dan Bernstein  <mitz@apple.com>
378
379         [Mac] MiniBrowser Debug builds are compiled with -Os
380         https://bugs.webkit.org/show_bug.cgi?id=125376
381
382         Reviewed by Tim Horton.
383
384         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
385         the Debug configuration at the project level.
386
387 2013-12-06  Jer Noble  <jer.noble@apple.com>
388
389         [MSE] Add a runtime-setting for the MediaSource constructor.
390         https://bugs.webkit.org/show_bug.cgi?id=125336
391
392         Reviewed by Eric Carlson.
393
394         Enable MediaSource in DRT and WKTR.
395
396         * DumpRenderTree/mac/DumpRenderTree.mm:
397         (resetWebPreferencesToConsistentValues):
398         * WebKitTestRunner/TestController.cpp:
399         (WTR::TestController::resetPreferencesToConsistentValues):
400
401 2013-12-06  Jer Noble  <jer.noble@apple.com>
402
403         Strip out extraneous logging from AppleGVA in media tests.
404         https://bugs.webkit.org/show_bug.cgi?id=125357
405
406         Reviewed by Simon Fraser.
407
408         Add a mechanism for stripping out abritrary regular expressions from test input and output.
409
410         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
411         (SingleTestRunner._run_compare_test): Strip out logging
412         * Scripts/webkitpy/port/base.py:
413         (Port.logging_patterns_to_strip): Return an empty list by default.
414         * Scripts/webkitpy/port/driver.py:
415         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
416         * Scripts/webkitpy/port/mac.py:
417         (MacPort.logging_patterns_to_strip): Return a complete list.
418
419 2013-12-06  Dean Jackson  <dino@apple.com>
420
421         Updating ANGLE should point to instructions
422         https://bugs.webkit.org/show_bug.cgi?id=125361
423
424         Reviewed by Eric Carlson.
425
426         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
427         someone wants to patch ANGLE.
428
429         * Scripts/webkitpy/common/config/watchlist:
430
431 2013-12-06  Dan Bernstein  <mitz@apple.com>
432
433         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
434         https://bugs.webkit.org/show_bug.cgi?id=125334
435
436         Reviewed by Darin Adler.
437
438         * MiniBrowser/mac/WK2BrowserWindowController.m:
439         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
440         title property.
441         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
442         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
443         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
444         window title with the title property changes.
445         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
446         set the load delegate instead of the load client.
447         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
448         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
449         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
450         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
451         Implemented this load delegate method.
452         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
453         Ditto.
454         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
455         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
456         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
457         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
458         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
459         Ditto.
460         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
461         Ditto.
462         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
463
464 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
465
466         Remove function from style/checkers/cpp.py.
467         https://bugs.webkit.org/show_bug.cgi?id=125341
468
469         Reviewed by Darin Adler.
470
471         Corrects a FIXME: by removing a function from cpp.py.
472
473         * Scripts/webkitpy/style/checkers/cpp.py:
474         (CppChecker.__init__):
475         (CppChecker.check):
476         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
477         (CppStyleTestBase.process_file_data):
478
479 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
480
481         check-webkit-style: false positive warning for indentation of #ifdef code.
482         https://bugs.webkit.org/show_bug.cgi?id=125254
483
484         Reviewed by Darin Adler.
485
486         * Scripts/webkitpy/style/checkers/cpp.py:
487         (check_member_initialization_list):
488         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
489         (WebKitStyleTest.test_member_initialization_list):
490
491 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
492
493         Fix spelling error in style checker: beggining
494         https://bugs.webkit.org/show_bug.cgi?id=125347
495
496         Reviewed by Anders Carlsson.
497
498         * Scripts/webkitpy/style/checkers/cpp.py:
499         (check_member_initialization_list):
500         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
501         (WebKitStyleTest.test_member_initialization_list):
502
503 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
504
505         [ATK] Missing aria roles mappings
506         https://bugs.webkit.org/show_bug.cgi?id=117729
507
508         Reviewed by Mario Sanchez Prada.
509
510         Added new mappings to AccessibilityUIElementAtk.cpp.
511
512         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
513         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
514
515 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
516
517         Typo fix after r160218.
518
519         * Scripts/webkitpy/test/main.py:
520         (main):
521
522 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
523
524         Unreviewed fix after r160206.
525
526         * Scripts/webkitpy/test/main.py:
527         (main): sys.platform can be win32 or cygwin too on Windows.
528
529 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
530
531         Disable WebKit2 webkitpy unittests on Windows
532         https://bugs.webkit.org/show_bug.cgi?id=125318
533
534         Reviewed by Ryosuke Niwa.
535
536         * Scripts/webkitpy/test/main.py:
537         (main):
538
539 2013-12-05  Anders Carlsson  <andersca@apple.com>
540
541         Tweak WeakObjCPtr
542         https://bugs.webkit.org/show_bug.cgi?id=125311
543
544         Reviewed by Darin Adler.
545
546         Split up tests into more logical groups. Add new tests for new functionality.
547
548         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
549
550 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
551
552         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
553         https://bugs.webkit.org/show_bug.cgi?id=125302
554
555         Reviewed by Philippe Normand.
556
557         * gtk/generate-webkitdom-doc-files:
558         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
559         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
560         and WEBKIT_DEPRECATED_FOR macros.
561
562 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
563
564         Fix cross compilation on x86
565         https://bugs.webkit.org/show_bug.cgi?id=125295
566
567         Reviewed by Zoltan Herczeg.
568
569         Certain compiler flags should not be added when cross compilation is enabled.
570
571         * Scripts/webkitdirs.pm:
572         (runAutogenForAutotoolsProjectIfNecessary):
573         (generateBuildSystemFromCMakeProject):
574
575 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
576
577         Remove duplicated/dead code from cpp style checker unit tests.
578         https://bugs.webkit.org/show_bug.cgi?id=125226
579
580         Reviewed by Ryosuke Niwa.
581
582         Remove the first definition of OrderOfIncludesTest class as it is
583         overwritten by the second. Remove a duplicated assert statement
584         from the second class.
585
586         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
587         (OrderOfIncludesTest.setUp):
588         (OrderOfIncludesTest.test_try_drop_common_suffixes):
589           The last assert was duplicated.
590
591 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
592
593         Remove Scripts/generate-qt-inspector-resource.
594         https://bugs.webkit.org/show_bug.cgi?id=125288
595
596         Reviewed by Andreas Kling.
597
598         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
599         We don't need this file.
600
601 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
602
603         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
604         https://bugs.webkit.org/show_bug.cgi?id=125218
605
606         Reviewed by Ryosuke Niwa.
607
608         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
609         (LayoutTestFinder.skip_tests):
610         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
611         (LayoutTestRunner.run_tests):
612         (LayoutTestRunner._update_summary_with_result):
613         * Scripts/webkitpy/layout_tests/controllers/manager.py:
614         (Manager._test_is_slow):
615         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
616         (JSONLayoutResultsGenerator._insert_failure_summaries):
617         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
618         (TestExpectations.get_rebaselining_failures):
619         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
620         (assert_exp):
621         (MiscTests.test_multiple_results):
622         (MiscTests.test_category_expectations):
623         (MiscTests.test_get_modifiers):
624         (MiscTests.test_get_expectations_string):
625         (MiscTests.test_expectation_to_string):
626         (MiscTests.test_get_test_set):
627         (MiscTests.test_more_specific_override_resets_skip):
628         (SkippedTests.check):
629         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
630         (TestRunResults.__init__):
631         (summarize_results):
632         * Scripts/webkitpy/tool/commands/rebaseline.py:
633         (RebaselineExpectations._tests_to_rebaseline):
634
635 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
636
637         Enable HTMLTemplateElement by default
638         https://bugs.webkit.org/show_bug.cgi?id=123851
639
640         Reviewed by Antti Koivisto.
641
642         * Scripts/webkitperl/FeatureList.pm:
643
644 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
645
646         [EFL] Bumping GStreamer version to 1.2.1
647         https://bugs.webkit.org/show_bug.cgi?id=125155
648
649         Reviewed by Gyuyoung Kim.
650
651         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
652
653
654 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
655
656         Update jhbuild revision.
657         https://bugs.webkit.org/show_bug.cgi?id=124966
658         
659         Reviewed by Gyuyoung Kim.
660
661         Used version of Jhbuild failed to create directories and caused
662         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
663
664         * jhbuild/jhbuild-wrapper:
665
666 2013-12-04  Anders Carlsson  <andersca@apple.com>
667
668         Add a WeakObjCPtr class
669         https://bugs.webkit.org/show_bug.cgi?id=125267
670
671         Reviewed by Geoffrey Garen.
672
673         Add API tests for WeakObjCPtr.
674
675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
676         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
677         (TEST):
678
679 2013-12-04  Anders Carlsson  <andersca@apple.com>
680
681         Make the estimatedProgress property observable using KVO
682         https://bugs.webkit.org/show_bug.cgi?id=125259
683
684         Reviewed by Dan Bernstein.
685
686         Bind the progress indicator value to the "estimatedProgress" property.
687
688         * MiniBrowser/mac/WK2BrowserWindowController.m:
689         (-[WK2BrowserWindowController dealloc]):
690         (-[WK2BrowserWindowController awakeFromNib]):
691
692 2013-12-04  Anders Carlsson  <andersca@apple.com>
693
694         Add a loading property to WKBrowsingContextController
695         https://bugs.webkit.org/show_bug.cgi?id=125256
696
697         Reviewed by Dan Bernstein.
698
699         Bind the progress indicator visibility to the "loading" property.
700
701         * MiniBrowser/mac/WK2BrowserWindowController.m:
702         (-[WK2BrowserWindowController dealloc]):
703         (-[WK2BrowserWindowController awakeFromNib]):
704         (-[WK2BrowserWindowController didStartProgress]):
705         (-[WK2BrowserWindowController didFinishProgress]):
706
707 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
708
709         [EFL][WK2] Buildfix after r160104
710         https://bugs.webkit.org/show_bug.cgi?id=125231
711
712         Reviewed by Anders Carlsson.
713
714         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
715         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
716         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
717         (TestWebKitAPI::setViewClient): Ditto.
718
719 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
720
721         check-webkit-style detected some ternary statements as initialization lists
722         https://bugs.webkit.org/show_bug.cgi?id=125246
723
724         Reviewed by Dean Jackson.
725
726         The regular expression that check-webkit-tests uses to detect initialization
727         lists was too broad, resulting in false positives. This patch makes the
728         regex more specific
729
730         * Scripts/webkitpy/style/checkers/cpp.py:
731         (check_member_initialization_list):
732         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
733         (WebKitStyleTest.test_member_initialization_list):
734
735 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
736
737         run-jsc-stress-tests can only run locally
738         https://bugs.webkit.org/show_bug.cgi?id=124551
739
740         Reviewed by Filip Pizlo.
741
742         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
743         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
744         added a couple more signals to handle gracefully at shutdown. 
745         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
746         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
747         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
748         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
749         toward the end of the script to make it easier to tell which of the various modes do what.
750
751 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
752
753         [EFL][WK2] Buildfix after r160104
754         https://bugs.webkit.org/show_bug.cgi?id=125233
755
756         Reviewed by Anders Carlsson.
757
758         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
759         (TestWebKitAPI::TEST):
760         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
761         (TestWebKitAPI::setPageLoaderClient):
762
763 2013-12-03  Anders Carlsson  <andersca@apple.com>
764
765         Deprecate all unversioned client structs in favor of having explicit versioned structs
766         https://bugs.webkit.org/show_bug.cgi?id=125203
767
768         Reviewed by Dan Bernstein.
769
770         Update for WebKit2 API changes.
771
772         * MiniBrowser/mac/AppDelegate.m:
773         (-[BrowserAppDelegate init]):
774         * MiniBrowser/mac/WK2BrowserWindowController.m:
775         (-[WK2BrowserWindowController awakeFromNib]):
776         * TestWebKitAPI/InjectedBundleController.cpp:
777         (TestWebKitAPI::InjectedBundleController::initialize):
778         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
779         (TestWebKitAPI::TEST):
780         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
781         (TestWebKitAPI::setInjectedBundleClient):
782         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
783         (TestWebKitAPI::TEST):
784         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
785         (TestWebKitAPI::TEST):
786         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
787         (TestWebKitAPI::TEST):
788         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
789         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
790         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
791         (TestWebKitAPI::TEST):
792         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
793         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
794         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
795         (TestWebKitAPI::setInjectedBundleClient):
796         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
797         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
798         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
799         (TestWebKitAPI::TEST):
800         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
801         (TestWebKitAPI::TEST):
802         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
803         (TestWebKitAPI::setContextDownloadClient):
804         (TestWebKitAPI::setPagePolicyClient):
805         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
806         (TestWebKitAPI::TEST):
807         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
808         (TestWebKitAPI::TEST):
809         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
810         (TestWebKitAPI::TEST):
811         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
812         (TestWebKitAPI::TEST):
813         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
814         (TestWebKitAPI::TEST):
815         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
816         (TestWebKitAPI::TEST):
817         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
818         (TestWebKitAPI::setupGeolocationProvider):
819         (TestWebKitAPI::setupView):
820         (TestWebKitAPI::TEST):
821         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
822         (TestWebKitAPI::TEST):
823         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
824         (TestWebKitAPI::setPageLoaderClient):
825         (TestWebKitAPI::setInjectedBundleClient):
826         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
827         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
828         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
829         (TestWebKitAPI::TEST):
830         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
831         (TestWebKitAPI::setInjectedBundleClient):
832         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
833         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
834         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
835         (TestWebKitAPI::TEST):
836         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
837         (TestWebKitAPI::TEST):
838         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
839         (TestWebKitAPI::TEST):
840         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
841         (TestWebKitAPI::TEST):
842         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
843         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
844         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
845         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
846         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
847         (TestWebKitAPI::setPageLoaderClient):
848         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
849         (TestWebKitAPI::setPageLoaderClient):
850         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
851         (TestWebKitAPI::setPageLoaderClient):
852         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
853         (TestWebKitAPI::setPageLoaderClient):
854         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
855         (TestWebKitAPI::setPageLoaderClient):
856         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
857         (TestWebKitAPI::TEST):
858         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
859         (TestWebKitAPI::TEST):
860         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
861         (TestWebKitAPI::setInjectedBundleClient):
862         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
863         (TestWebKitAPI::ParentFrameTest::didCreatePage):
864         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
865         (TestWebKitAPI::setInjectedBundleClient):
866         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
867         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
868         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
869         (TestWebKitAPI::TEST):
870         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
871         (TestWebKitAPI::TEST):
872         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
873         (TestWebKitAPI::TEST):
874         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
875         (TestWebKitAPI::TEST):
876         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
877         (TestWebKitAPI::setInjectedBundleClient):
878         (TestWebKitAPI::setPageLoaderClient):
879         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
880         (TestWebKitAPI::setPageLoaderClient):
881         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
882         (TestWebKitAPI::TEST):
883         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
884         (TestWebKitAPI::setPageLoaderClient):
885         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
886         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
887         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
888         (TestWebKitAPI::TEST):
889         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
890         (TestWebKitAPI::TEST):
891         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
892         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
893         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
894         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
895         (TestWebKitAPI::TEST):
896         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
897         (TestWebKitAPI::WKConnectionTest::initialize):
898         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
899         (TestWebKitAPI::setPageLoaderClient):
900         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
901         (TestWebKitAPI::setInjectedBundleClient):
902         (TestWebKitAPI::TEST):
903         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
904         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
905         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
906         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
907         (TestWebKitAPI::setInjectedBundleClient):
908         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
909         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
910         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
911         (TestWebKitAPI::TEST):
912         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
913         (TestWebKitAPI::setInjectedBundleClient):
914         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
915         (TestWebKitAPI::TEST):
916         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
917         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
918         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
919         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
920         (TestWebKitAPI::didCreateConnection):
921         (TestWebKitAPI::TEST):
922         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
923         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
924         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
925         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
926         (TestWebKitAPI::setPageLoaderClient):
927         * WebKitTestRunner/GeolocationProviderMock.cpp:
928         (WTR::GeolocationProviderMock::GeolocationProviderMock):
929         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
930         (WTR::InjectedBundle::initialize):
931         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
932         (WTR::InjectedBundlePage::InjectedBundlePage):
933         * WebKitTestRunner/TestController.cpp:
934         (WTR::TestController::createOtherPage):
935         (WTR::TestController::initialize):
936         (WTR::TestController::createWebViewWithOptions):
937
938 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
939
940         Style checker for .messages.in files (WTF:: prefix)
941         https://bugs.webkit.org/show_bug.cgi?id=125142
942
943         Reviewed by Anders Carlsson.
944
945         A new style checker for .messages.in files, that checks for the use of WTF::
946         prefix in these files. (Also checks for tabs as these files were previously
947         handled as text files.)
948
949         * Scripts/webkitpy/style/checker.py:
950         (CheckerDispatcher._create_checker):
951           New checker is returned for .messages.in files.
952         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
953           The new style checker class.
954         (MessagesInChecker):
955         (MessagesInChecker.__init__):
956         (MessagesInChecker.check):
957         (MessagesInChecker.check_WTF_prefix):
958         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
959           Unit test for the new style  checker class.
960         (MessagesInCheckerStyleTestCase):
961         (test_checker):
962         (test_checker.error_handler_for_test):
963         (MessagesInCheckerTestCase):
964         (MessagesInCheckerTestCase.test_init):
965         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
966
967 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
968
969         Style checker requires alphabetical ordering in cmake lists even it contains variable.
970         https://bugs.webkit.org/show_bug.cgi?id=124918
971
972         Reviewed by Csaba Osztrogonác.
973
974         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
975         (CMakeCheckerTest.test_check):
976         * Scripts/webkitpy/style/checkers/cmake.py:
977         (CMakeChecker._check_list_order):
978         This will ignore lines with variable substitution.
979
980 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
981
982         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
983         https://bugs.webkit.org/show_bug.cgi?id=124731
984
985         Reviewed by Zoltan Herczeg.
986
987         * Scripts/webkitpy/style/checkers/cpp.py:
988         (check_spacing):
989         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
990         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
991
992 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
993
994         Remove codecs and os dependencies from filereader.py in webkitpy/style.
995         https://bugs.webkit.org/show_bug.cgi?id=124719
996
997         Although TextFileReader requires a FileSystem it circumvents it in two places!
998         We should use the FileSystem only and remove codecs and os imports.
999
1000         Reviewed by Zoltan Herczeg.
1001
1002         * Scripts/webkitpy/common/system/filesystem.py:
1003         (FileSystem.open_stdin): Moved from TextFileReader
1004         * Scripts/webkitpy/style/filereader.py:
1005         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
1006         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
1007
1008 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1009
1010         check-webkit-style should check member initialization indentation.
1011         https://bugs.webkit.org/show_bug.cgi?id=124820
1012
1013         Reviewed by Zoltan Herczeg.
1014
1015         check-webkit-style should check member initialization indentation
1016         belongs to webkit coding style:
1017         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
1018
1019         * Scripts/webkitpy/style/checkers/cpp.py:
1020         (check_member_initialization_list): Add new method to check member
1021         initialization list.
1022         (check_style): Add the call of the new method.
1023         (check_language): Move self initialization checking into the new method.
1024         (CppChecker): Add a new category for initialization list.
1025         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1026         (CppStyleTest.test_runtime_selfinit):
1027         (CppStyleTest.test_deprecated_cast):
1028         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
1029         the new feature.
1030
1031 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
1032
1033         style-bot should reject Committer additions to committers.py
1034         https://bugs.webkit.org/show_bug.cgi?id=107574
1035
1036         Reviewed by Zoltan Herczeg.
1037
1038         The style check when executed in non-interactive mode (probably by a
1039         bot) will raise an additional error if the contributors.json file is
1040         modified. Non-interactive mode information is propagated to the
1041         Dispatcher, which creates a special JSON checker for the
1042         contributors.json file.
1043
1044         * Scripts/webkitpy/style/checker.py:
1045         (check_webkit_style_configuration):
1046         (CheckerDispatcher._create_checker):
1047         (CheckerDispatcher.dispatch):
1048         (StyleProcessorConfiguration.__init__):
1049         (StyleProcessor.process):
1050         * Scripts/webkitpy/style/checker_unittest.py:
1051         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1052         (CheckerDispatcherDispatchTest.dispatch):
1053         (StyleProcessorConfigurationTest._style_checker_configuration):
1054         (StyleProcessor_EndToEndTest.test_init):
1055         (StyleProcessor_EndToEndTest.test_process):
1056         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
1057         (StyleProcessor_CodeCoverageTest.setUp):
1058         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1059         (JSONChecker.line_number_from_json_exception):
1060         (JSONContributorsChecker):
1061         (JSONContributorsChecker.check):
1062         * Scripts/webkitpy/style/error_handlers_unittest.py:
1063         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1064         * Scripts/webkitpy/style/optparser.py:
1065         (CommandOptionValues.__init__):
1066         (ArgumentParser._create_option_parser):
1067         (ArgumentParser.parse):
1068         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1069         (test_post):
1070         (test_upload):
1071         * Scripts/webkitpy/tool/steps/checkstyle.py:
1072         (CheckStyle.run):
1073
1074 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1075
1076         [EFL][WK2] Fix build after API::Client changes
1077         https://bugs.webkit.org/show_bug.cgi?id=125206
1078
1079         Reviewed by Csaba Osztrogonác.
1080
1081         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1082         (TestWebKitAPI::TEST):
1083         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1084         (TestWebKitAPI::setViewClient):
1085
1086 2013-12-03  Dan Bernstein  <mitz@apple.com>
1087
1088         Fixed a test timing out after r160040.
1089
1090         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1091         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
1092         Updated for the delegate method rename.
1093
1094 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
1095
1096         REGRESSION: repro scripts disappear when you rerun tests
1097         https://bugs.webkit.org/show_bug.cgi?id=125184
1098
1099         Reviewed by Mark Hahnenberg.
1100         
1101         This bug made it difficult to quickly see if a test that recently failed is still
1102         failing while also running a new batch of tests.
1103
1104         Repro scripts are supposed to stay around until you delete them explicitly. This
1105         patch accomplishes that.
1106
1107         * Scripts/run-jsc-stress-tests:
1108
1109 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
1110
1111         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
1112         https://bugs.webkit.org/show_bug.cgi?id=125111
1113
1114         Reviewed by Filip Pizlo.
1115
1116         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
1117
1118         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
1119         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
1120
1121 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1122
1123         Add a script to automatically configure a git clone
1124         https://bugs.webkit.org/show_bug.cgi?id=110073
1125
1126         Revert the change to use https for now since git.webkit.org is setup with http.
1127
1128         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1129         (SetupGitClone.execute):
1130
1131 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1132
1133         Add a script to automatically configure a git clone
1134         https://bugs.webkit.org/show_bug.cgi?id=110073
1135
1136         Reviewed by Benjamin Poulain.
1137
1138         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
1139
1140         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
1141
1142         * Scripts/webkitpy/tool/commands/__init__.py:
1143         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
1144         (SetupGitClone):
1145         (SetupGitClone.execute):
1146
1147 2013-12-03  Anders Carlsson  <andersca@apple.com>
1148
1149         Deprecate WKNotificationProvider
1150         https://bugs.webkit.org/show_bug.cgi?id=125178
1151
1152         Reviewed by Sam Weinig.
1153
1154         Update for WebKit2 changes.
1155
1156         * WebKitTestRunner/TestController.cpp:
1157         (WTR::TestController::initialize):
1158         * WebKitTestRunner/WebNotificationProvider.cpp:
1159         (WTR::WebNotificationProvider::provider):
1160         * WebKitTestRunner/WebNotificationProvider.h:
1161
1162 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
1163
1164         [Win] Support 64-bit Application Support Libraries Location 
1165         https://bugs.webkit.org/show_bug.cgi?id=125179
1166
1167         Reviewed by Tim Horton.
1168
1169         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
1170         on Windows until an official distribution is available that properly creates registry settings
1171         to specify these locations.
1172
1173         * Scripts/webkitdirs.pm:
1174         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
1175         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
1176         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
1177         running 64-bit builds.
1178
1179 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
1180
1181         run-jsc-stress-tests only supports host environments that have make installed
1182         https://bugs.webkit.org/show_bug.cgi?id=124550
1183
1184         Reviewed by Darin Adler.
1185
1186         This might not be the case for all hosts, so this patch implements an alternate "backend" 
1187         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
1188         least somewhat competitive with the make-based test runner, the shell backend uses subshells
1189         run in the background to allow tests to run in parallel. Since the concurrency primitives 
1190         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
1191         of the make-based runner.
1192
1193         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
1194         the bundle and controls all of the parallel aspects of the shell-based test runner.
1195         * Scripts/run-jsc-stress-tests:
1196
1197 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1198
1199         Remove function from TextChecker
1200         https://bugs.webkit.org/show_bug.cgi?id=125148
1201
1202         Reviewed by Darin Adler.
1203
1204         The process_file_data is used only from the unit tests, so it is simply moved there.
1205
1206         * Scripts/webkitpy/style/checkers/text.py:
1207         (TextChecker.check):
1208         * Scripts/webkitpy/style/checkers/text_unittest.py:
1209         (TextStyleTestCase.process_file_data):
1210         (TextStyleTestCase.assertNoError):
1211         (TextStyleTestCase.assertError):
1212
1213 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1214
1215         Remove get_test() and reference test names directly instead.
1216         https://bugs.webkit.org/show_bug.cgi?id=124962
1217
1218         Reviewed by Csaba Osztrogonác.
1219
1220         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1221         (Base.__init__):
1222         (Base.get_basic_tests):
1223         (assert_exp):
1224         (MiscTests.test_multiple_results):
1225         (MiscTests.test_category_expectations):
1226         (MiscTests.test_get_modifiers):
1227         (MiscTests.test_get_expectations_string):
1228         (MiscTests.test_get_test_set):
1229         (MiscTests.test_parse_warning):
1230         (MiscTests.test_pixel_tests_flag.match):
1231
1232 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1233
1234         Style Checker false pass.
1235         https://bugs.webkit.org/show_bug.cgi?id=112456
1236
1237         Reviewed by Csaba Osztrogonác.
1238
1239         * Scripts/webkitpy/style/checkers/changelog.py:
1240         (ChangeLogChecker.check_entry):
1241         simple regex fix to check "No new tests (...)."
1242         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1243         (ChangeLogCheckerTest.test_no_new_tests):
1244
1245 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
1246
1247         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
1248         https://bugs.webkit.org/show_bug.cgi?id=125130
1249
1250         Reviewed by Geoffrey Garen.
1251
1252         * Scripts/run-jsc-stress-tests:
1253
1254 2013-12-02  Samuel White  <samuel_white@apple.com>
1255
1256         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
1257         https://bugs.webkit.org/show_bug.cgi?id=124561
1258
1259         Reviewed by Chris Fleizach.
1260
1261         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
1262
1263         * DumpRenderTree/AccessibilityUIElement.cpp:
1264         (uiElementCountForSearchPredicateCallback):
1265         (uiElementForSearchPredicateCallback):
1266         (AccessibilityUIElement::getJSClass):
1267         * DumpRenderTree/AccessibilityUIElement.h:
1268         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1269         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1270         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1271         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1272         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1273         (searchPredicateParameterizedAttributeForSearchCriteria):
1274         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1275         (AccessibilityUIElement::uiElementForSearchPredicate):
1276         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1277         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1278         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1279         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1280         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1281         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1282         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1283         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1284         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1285         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1286         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1287         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1288
1289 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1290
1291         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
1292         https://bugs.webkit.org/show_bug.cgi?id=124714
1293
1294         Reviewed by Ryosuke Niwa.
1295
1296         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1297         (write_test_result):
1298         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1299         (TestFailure.write_failure):
1300         (FailureText):
1301         (FailureText.write_failure):
1302         (FailureAudio):
1303         (FailureAudio.write_failure):
1304         (FailureCrash.write_failure):
1305         (FailureMissingResult):
1306         (FailureTextMismatch):
1307         (FailureMissingImageHash.write_failure):
1308         (FailureMissingImage.write_failure):
1309         (FailureImageHashMismatch.write_failure):
1310         (FailureReftestMismatch.write_failure):
1311         (FailureReftestMismatchDidNotOccur.write_failure):
1312         (FailureMissingAudio):
1313         (FailureAudioMismatch):
1314
1315 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
1316
1317         Remove the stderr_write attribute from StyleProcessorConfiguration
1318         https://bugs.webkit.org/show_bug.cgi?id=124703
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         Remove the stderr_write attribute from this class in checker and
1323         replace its use with calls to a logging module logger. We Should 
1324         use logging module instead of writing to stderr directly.
1325
1326         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
1327         (check_webkit_style_configuration):
1328         (CheckerDispatcher.dispatch): Remove FIXME comment.
1329         (StyleProcessorConfiguration):
1330         (StyleProcessorConfiguration.__init__):
1331         (StyleProcessorConfiguration.write_style_error):
1332         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
1333         There is an "ERROR" prefix in log messiges from now.
1334         (StyleProcessorConfigurationTest):
1335         (StyleProcessorConfigurationTest._style_checker_configuration):
1336         (StyleProcessorConfigurationTest.test_init):
1337         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
1338         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
1339         (StyleProcessor_EndToEndTest.with):
1340         (StyleProcessor_EndToEndTest.test_init):
1341         (StyleProcessor_EndToEndTest.test_process):
1342         (StyleProcessor_CodeCoverageTest.setUp):
1343         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
1344         (DefaultStyleErrorHandler.__call__):
1345         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
1346         There is an "ERROR" prefix in log messiges from now.
1347         (DefaultStyleErrorHandlerTest):
1348         (DefaultStyleErrorHandlerTest.setUp):
1349         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
1350         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1351         (DefaultStyleErrorHandlerTest._check_initialized):
1352         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
1353         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
1354         (DefaultStyleErrorHandlerTest.test_line_numbers):
1355
1356 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
1357
1358         Add JavaScript style checker and teach checker.py about .js files
1359         https://bugs.webkit.org/show_bug.cgi?id=125049
1360
1361         Reviewed by Joseph Pecoraro.
1362
1363         Add a JavaScript file type, extension, and checker (JSChecker).
1364         Use TextChecker for JavaScript tests, libraries, website resources,
1365         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
1366
1367         Amended tests for TextChecker to reflect the rule above.
1368
1369         * Scripts/webkitpy/style/checker.py:
1370         (_all_categories): Add categories defined by JSChecker.
1371         (FileType): Add file type for JS and re-number the enum.
1372         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
1373         (CheckerDispatcher._create_checker):
1374         Create a JSChecker or TextChecker depending on the file's path.
1375
1376         * Scripts/webkitpy/style/checker_unittest.py:
1377         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
1378         (CheckerDispatcherDispatchTest.test_js_paths): Added.
1379         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
1380         that end in .js but should be checked with TextChecker.
1381         * Scripts/webkitpy/style/checkers/js.py: Added.
1382         (JSChecker):
1383         (JSChecker.__init__):
1384         (JSChecker.check):
1385         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
1386         (JSTestCase):
1387         (JSTestCase.assertNoError):
1388         (JSTestCase.assertNoError.error_for_test):
1389         (JSTestCase.assertError):
1390         (JSTestCase.assertError.error_for_test):
1391         (JSTestCase.test_no_error):
1392         (JSTestCase.test_error):
1393
1394 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1395
1396         run-jsc-stress-tests always copies the VM
1397         https://bugs.webkit.org/show_bug.cgi?id=125092
1398
1399         Reviewed by Filip Pizlo.
1400
1401         This can be slow, especially with full debug builds. It should just symlink the VM into the 
1402         bundle by default and do a full copy only when asked.
1403
1404         * Scripts/run-jsc-stress-tests:
1405
1406 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
1407
1408         [Win] Port run-jsc-stress-tests
1409         https://bugs.webkit.org/show_bug.cgi?id=124801
1410
1411         Reviewed by Filip Pizlo.
1412
1413         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
1414         command on Windows so that stress tests can run.
1415
1416 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1417
1418         Build fix after r159955
1419
1420         * Scripts/run-jsc-stress-tests:
1421
1422 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
1423
1424         run-jsc-stress-tests should be able to package its tests and move them places
1425         https://bugs.webkit.org/show_bug.cgi?id=124549
1426
1427         Reviewed by Filip Pizlo.
1428
1429         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
1430         of grep -i -q
1431         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
1432         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
1433         We now also copy whatever VM was specified, along with its associated framework, into this directory.
1434         All of the generated scripts now are completely relative within the results directory. This allows
1435         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
1436         tarball of the generated results directory. Also refactored several portions of the script into
1437         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
1438
1439 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
1440
1441         [ATK] Support active state for listbox elements.
1442         https://bugs.webkit.org/show_bug.cgi?id=125009
1443
1444         Reviewed by Chris Fleizach.
1445
1446         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
1447
1448         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1449         (AccessibilityUIElement::isSelectedOptionActive):
1450         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1451         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1452         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1453         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1454         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1455         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1456         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1457         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1458
1459 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
1460
1461         Unreviewed GTK gardening.
1462
1463         * Scripts/run-gtk-tests:
1464         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
1465
1466 2013-12-01  Dan Bernstein  <mitz@apple.com>
1467
1468         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
1469         https://bugs.webkit.org/show_bug.cgi?id=125046
1470
1471         Reviewed by Sam Weinig.
1472
1473         * MiniBrowser/mac/AppDelegate.m:
1474         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
1475         (-[BrowserAppDelegate openDocument:]): Ditto.
1476         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
1477         interface to the implementation.
1478         * MiniBrowser/mac/WK2BrowserWindowController.m:
1479         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
1480         the policy client.
1481         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1482         Moved policy client implementation into this delegate method.
1483         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
1484         Ditto.
1485         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
1486         Ditto.
1487
1488 2013-12-01  Dan Bernstein  <mitz@apple.com>
1489
1490         [Mac] Remove the MiniBrowser injected bundle
1491         https://bugs.webkit.org/show_bug.cgi?id=125041
1492
1493         Reviewed by Anders Carlsson.
1494
1495         It had no ops!
1496
1497         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
1498         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1499         * MiniBrowser/mac/AppDelegate.m:
1500         (-[BrowserAppDelegate init]):
1501         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
1502         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
1503
1504 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1505
1506         check-webkit-style should check for extraneous newline between config.h and primary header.
1507         https://bugs.webkit.org/show_bug.cgi?id=124821
1508
1509         Reviewed by Csaba Osztrogonác.
1510
1511         * Scripts/webkitpy/style/checkers/cpp.py:
1512         (check_include_line):
1513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1514         (OrderOfIncludesTest.test_check_line_break_after_own_header):
1515         (OrderOfIncludesTest):
1516         (OrderOfIncludesTest.test_check_line_break_before_own_header):
1517
1518 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
1519
1520         test-webkit-scripts should show the failing tests and use an appropriate exit code
1521         https://bugs.webkit.org/show_bug.cgi?id=124840
1522
1523         Reviewed by Ryosuke Niwa.
1524
1525         A fixme in test-webkit-scripts asked that the script should display success or failiure
1526         and exit with a 0 or 1 value accordingly after all of the tests have completed.
1527
1528         * Scripts/test-webkit-scripts:
1529         (ScriptsTester.run_test_script):
1530         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
1531         because at this point we don't need to pass on more information other than success or failiure.
1532         (ScriptsTester.main):
1533         The return values are now stored for each script and when all tests have completed successfully,
1534         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
1535
1536 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
1537
1538         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
1539         https://bugs.webkit.org/show_bug.cgi?id=124923
1540
1541         Reviewed by Mario Sanchez Prada.
1542
1543         Added missing implementation of isAttributeSettable. Using
1544         ATK_STATE_EDITABLE for checking whether attribute is settable.
1545
1546         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1547         (AccessibilityUIElement::isAttributeSettable):
1548         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1549         (WTR::AccessibilityUIElement::isAttributeSettable):
1550
1551 2013-11-28  Commit Queue  <commit-queue@webkit.org>
1552
1553         Unreviewed, rolling out r159839.
1554         http://trac.webkit.org/changeset/159839
1555         https://bugs.webkit.org/show_bug.cgi?id=124974
1556
1557         run-webkit-tests doesn't generate pretty diff (Requested by
1558         Ossy on #webkit).
1559
1560         * Scripts/webkitpy/common/prettypatch.py:
1561         (PrettyPatch.__init__):
1562         (PrettyPatch.pretty_diff):
1563         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1564         (TestResultWriter.create_text_diff_and_write_result):
1565         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1566         (summarize_results):
1567         * Scripts/webkitpy/port/base.py:
1568         (Port.__init__):
1569         (Port.pretty_patch_available):
1570         (Port.check_pretty_patch):
1571         (Port.variable):
1572         (Port.variable.pretty_patch_text):
1573         * Scripts/webkitpy/port/base_unittest.py:
1574         (PortTest.test_pretty_patch_os_error):
1575         (PortTest.test_pretty_patch_script_error):
1576
1577 2013-11-28  Antti Koivisto  <antti@apple.com>
1578
1579         Remove feature: CSS variables
1580         https://bugs.webkit.org/show_bug.cgi?id=114119
1581
1582         Reviewed by Andreas Kling.
1583
1584         * Scripts/webkitperl/FeatureList.pm:
1585
1586 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1587
1588         Move PrettyPatch related code to prettypatch.py
1589         https://bugs.webkit.org/show_bug.cgi?id=124937
1590
1591         Reviewed by Ryosuke Niwa.
1592
1593         This code seems to have a better place here than in Port, since PrettyPatch already knows
1594         pretty_patch_path, and this also unifies the usage of PrettyPatch
1595
1596         * Scripts/webkitpy/common/prettypatch.py:
1597         (PrettyPatch.__init__):
1598         (PrettyPatch.pretty_diff):
1599         (PrettyPatch):
1600         (PrettyPatch.pretty_patch_available):
1601         (PrettyPatch.check_pretty_patch):
1602         (PrettyPatch.pretty_patch_text):
1603         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1604         (TestResultWriter.create_text_diff_and_write_result):
1605         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1606         (summarize_results):
1607         * Scripts/webkitpy/port/base.py:
1608         (Port.__init__):
1609         (Port.wdiff_available):
1610         (Port.check_image_diff):
1611         (Port.wdiff_text):
1612         * Scripts/webkitpy/port/base_unittest.py:
1613         (PortTest.test_pretty_patch_os_error):
1614         (PortTest.test_pretty_patch_script_error):
1615
1616 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1617
1618         Checkout should own the scm object in Host
1619         https://bugs.webkit.org/show_bug.cgi?id=124943
1620
1621         Reviewed by Ryosuke Niwa.
1622
1623         * Scripts/webkitpy/common/host.py:
1624         (Host.__init__):
1625         (Host.initialize_scm):
1626         (Host.scm):
1627
1628 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
1629
1630         Do bytecode validation as part of testing
1631         https://bugs.webkit.org/show_bug.cgi?id=124913
1632
1633         Reviewed by Oliver Hunt.
1634
1635         * Scripts/run-jsc-stress-tests:
1636
1637 2013-11-27  Andres Gomez  <agomez@igalia.com>
1638
1639         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
1640         https://bugs.webkit.org/show_bug.cgi?id=124940
1641
1642         Reviewed by Martin Robinson.
1643
1644         xserver-font-utils is needed for building gtk port dependencies
1645         with jhbuild.
1646
1647         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
1648         dependecies.
1649
1650 2013-11-27  Andres Gomez  <agomez@igalia.com>
1651
1652         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
1653         https://bugs.webkit.org/show_bug.cgi?id=124938
1654
1655         Reviewed by Philippe Normand.
1656
1657         Added needed git dependency for building the gtk port with
1658         jhbuild. Also, the dependencies needed for building the gtk port
1659         are now sorted alphabetically.
1660
1661         * gtk/install-dependencies: Added git as jhbuild dependency and
1662         sorted dependencies alphabetically.
1663
1664 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
1665
1666         run_webkit_tests.py: error: no such option: --wincairo
1667         https://bugs.webkit.org/show_bug.cgi?id=124927
1668
1669         Reviewed by Ryosuke Niwa.
1670
1671         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
1672         the layout testing on wincairo, so it is turned off.
1673
1674 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
1675
1676         Nix upstreaming - Adding build files and supporting scripts
1677         https://bugs.webkit.org/show_bug.cgi?id=118367
1678
1679         Reviewed by Ryosuke Niwa.
1680
1681         * Scripts/build-webkit:
1682         * Scripts/run-nix-tests: Added.
1683         * Scripts/run-webkit-tests:
1684         * Scripts/update-webkit-libs-jhbuild:
1685         * Scripts/update-webkitnix-libs: Added.
1686         * Scripts/webkitdirs.pm:
1687         (determineArchitecture):
1688         (argumentsForConfiguration):
1689         (jscProductDir):
1690         (builtDylibPathForName):
1691         (determineIsNix):
1692         (isNix):
1693         (isAppleWebKit):
1694         (launcherPath):
1695         (launcherName):
1696         (checkRequiredSystemConfig):
1697         (copyInspectorFrontendFiles):
1698         (jhbuildWrapperPrefixIfNeeded):
1699         (buildCMakeProjectOrExit):
1700         (cmakeBasedPortName):
1701         * Scripts/webkitpy/common/config/ports.py:
1702         (DeprecatedPort.port):
1703         (EflWK2Port.build_webkit_command):
1704         (NixPort):
1705         (NixPort.build_webkit_command):
1706         * Scripts/webkitpy/port/factory.py:
1707         (platform_options):
1708         (PortFactory):
1709         * Scripts/webkitpy/port/nix.py: Added.
1710         (NixPort):
1711         (NixPort._wk2_port_name):
1712         (NixPort.determine_full_port_name):
1713         (NixPort.__init__):
1714         (NixPort._port_flag_for_scripts):
1715         (NixPort.setup_test_run):
1716         (NixPort.setup_environ_for_server):
1717         (NixPort.default_timeout_ms):
1718         (NixPort.clean_up_test_run):
1719         (NixPort._generate_all_test_configurations):
1720         (NixPort._path_to_driver):
1721         (NixPort._path_to_image_diff):
1722         (NixPort._image_diff_command):
1723         (NixPort._search_paths):
1724         (NixPort.show_results_html_file):
1725         (NixPort._port_specific_expectations_files):
1726         (NixPort.default_baseline_search_path):
1727         * Scripts/webkitpy/port/nix_unittest.py: Added.
1728         (NixPortTest):
1729         (NixPortTest._assert_search_path):
1730         (NixPortTest._assert_expectations_files):
1731         (NixPortTest.test_baseline_search_path):
1732         (NixPortTest.test_expectations_files):
1733         (NixPortTest.test_default_timeout_ms):
1734         * jhbuild/jhbuild-wrapper:
1735         (determine_platform):
1736         * nix/common.py: Added.
1737         (script_path):
1738         (top_level_path):
1739         * nix/jhbuild.modules: Added.
1740         * nix/jhbuildrc: Added.
1741
1742 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
1743
1744         Record subtest values in Dromaeo tests
1745         https://bugs.webkit.org/show_bug.cgi?id=124498
1746
1747         Reviewed by Andreas Kling.
1748
1749         Supported parsing subtest results.
1750
1751         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
1752         which contains a dictionary with its name and an ordered list of subtest's metrics.
1753         (PerfTest.__init__): Initialize _metrics as a list.
1754         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
1755         (PerfTest._run_with_driver):
1756         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
1757
1758         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1759         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
1760         (TestPerfTest.test_parse_output): Ditto.
1761         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
1762         assertions to ensure subtest results are parsed properly.
1763         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
1764         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
1765
1766         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1767         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
1768         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
1769         adding new results.
1770
1771         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1772         (TestWithSubtestsData): Added.
1773         (TestDriver.run_test):
1774         (MainTest.test_run_test_with_subtests): Added.
1775
1776 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
1777
1778         Enable HTML template element on Windows ports
1779         https://bugs.webkit.org/show_bug.cgi?id=124758
1780
1781         Reviewed by Andreas Kling.
1782
1783         * Scripts/webkitperl/FeatureList.pm:
1784
1785 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
1786
1787         Remove replay performance tests as it's not actively maintained
1788         https://bugs.webkit.org/show_bug.cgi?id=124764
1789
1790         Reviewed by Andreas Kling.
1791
1792         Removed the feature.
1793
1794         * Scripts/webkitpy/performance_tests/perftest.py:
1795         (SingleProcessPerfTest.__init__):
1796         (PerfTestFactory):
1797         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1798         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1799         (PerfTestsRunner._parse_args):
1800         (PerfTestsRunner._collect_tests):
1801         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1802         (MainTest.test_collect_tests_with_ignored_skipped_list):
1803         (MainTest.test_default_args):
1804         * Scripts/webkitpy/thirdparty/__init__.py:
1805         (AutoinstallImportHook.find_module):
1806         (AutoinstallImportHook._install_unittest2):
1807         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1808         (ThirdpartyTest.test_imports):
1809
1810 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
1811
1812         Enable aggressive DFG validation in testing
1813         https://bugs.webkit.org/show_bug.cgi?id=124911
1814
1815         Rubber stamped by Ryosuke Niwa.
1816         
1817         This enables validation testing in non-concurrent-JIT runs.
1818
1819         * Scripts/run-jsc-stress-tests:
1820
1821 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1822
1823         Moved methods which belong to Checkout into checkout.py
1824         https://bugs.webkit.org/show_bug.cgi?id=124889
1825
1826         Reviewed by Ryosuke Niwa.
1827
1828         * Scripts/webkitpy/common/checkout/checkout.py:
1829         (Checkout.scripts_directory):
1830         (Checkout):
1831         (Checkout.script_path):
1832         (Checkout.commit_message_for_this_commit):
1833         (Checkout.apply_patch):
1834         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1835         (test_commit_message_for_this_commit):
1836         (CheckoutTest.test_apply_patch):
1837         * Scripts/webkitpy/common/checkout/scm/scm.py:
1838         (SCM.absolute_path):
1839         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1840         (SCMTest._setup_webkittools_scripts_symlink):
1841         * Scripts/webkitpy/common/checkout/scm/svn.py:
1842         (SVN.create_patch):
1843
1844 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
1845
1846         [EFL] Use Config mode of find_package for EFL 1.8
1847         https://bugs.webkit.org/show_bug.cgi?id=124555
1848
1849         Reviewed by Gyuyoung Kim.
1850
1851         * MiniBrowser/efl/CMakeLists.txt:
1852         Added optional config mode and made version requirement optional.
1853
1854 2013-11-25  Andres Gomez  <agomez@igalia.com>
1855
1856         [GTK] Search functionality in MiniBrowser provides feedback on search fail
1857         https://bugs.webkit.org/show_bug.cgi?id=122681
1858
1859         Reviewed by Mario Sanchez Prada.
1860
1861         When using the search functionality in MiniBrowser, if the search
1862         fails, the entry background color gets red to report the user
1863         about the failing condition. When the entry is cleaned or the
1864         search is again succesful the background turns back to its
1865         original color.
1866
1867         * MiniBrowser/gtk/BrowserSearchBar.c:
1868         (setFailedStyleForEntry): Added.
1869         (doSearch): Sets the entry's background to its original style if
1870         there is no text to search.
1871         (findControllerFailedToFindTextCallback): Added.
1872         (findControllerFoundTextCallback): Added.
1873         (browser_search_bar_init): Creates and adds a new CSS provider to
1874         the text entry so we can change its style based on the success
1875         condition of the search.
1876         (browserSearchBarFinalize): Frees the new CSS provider.
1877         (browser_search_bar_new): Connects the two new handlers to the
1878         "failed-to-find-text" and "found-text" signals emitted by the
1879         WebKitFindController.
1880
1881 2013-11-25  Dan Bernstein  <mitz@apple.com>
1882
1883         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
1884         https://bugs.webkit.org/show_bug.cgi?id=124850
1885
1886         Reviewed by Brady Eidson.
1887
1888         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
1889
1890         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1891         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1892         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1893         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1894         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1895         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1896         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1897
1898 2013-11-25  Commit Queue  <commit-queue@webkit.org>
1899
1900         Unreviewed, rolling out r159752 and r159754.
1901         http://trac.webkit.org/changeset/159752
1902         http://trac.webkit.org/changeset/159754
1903         https://bugs.webkit.org/show_bug.cgi?id=124847
1904
1905         Broke linux test bots. (Requested by mhahnenberg on #webkit).
1906
1907         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1908         * Scripts/run-javascriptcore-tests:
1909         * Scripts/run-jsc-stress-tests:
1910
1911 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
1912
1913         Followup fix after r159752
1914
1915         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
1916
1917 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
1918
1919         run-jsc-stress-tests should be able to package its tests and move them places
1920         https://bugs.webkit.org/show_bug.cgi?id=124549
1921
1922         Reviewed by Filip Pizlo.
1923
1924         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
1925         of grep -i -q
1926         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
1927         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
1928         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
1929         All of the generated scripts now are completely relative within the results directory. This allows 
1930         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
1931         tarball of the generated results directory. Also refactored several portions of the script into 
1932         separate functions to make it easier to run them conditionally depending on which mode we're running in.
1933
1934 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
1935
1936         EWS creates 0 byte sized log files
1937         https://bugs.webkit.org/show_bug.cgi?id=107606
1938
1939         Reviewed by Ryosuke Niwa.
1940
1941         There was a modification in r138264, that tried to make less log,
1942         because some of the messeges were duplicated. After this the EWS
1943         created the log file (with the same name as the bugID) but doesn't
1944         write anything into it, even if there were errors during the build.
1945         From now only creates the log file only if there is some error.
1946
1947         * Scripts/webkitpy/tool/bot/queueengine.py:
1948         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
1949         there is nothing to log. Open the log file only if a ScriptError was raised to
1950         avoid to make empty log files for bugs.
1951         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
1952         because of changes in r138264. Teeing is used for locally testing purposes and
1953         this feature is not used anymore.
1954         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
1955         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
1956         change.
1957         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1958         (LoggingDelegate): The order of the callbacks was changed by this patch.
1959         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
1960         so we have to update this test.
1961         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
1962         this patch.
1963         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1964         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
1965         to be able to handle it in QueueEngine.run. Without this change, the existing
1966         exception handler never run (the process_work_item method never raise ScriptError)
1967         We can get the error message only from the ScriptError at this point.
1968
1969 2013-11-22  Dean Jackson  <dino@apple.com>
1970
1971         Speculative Mountain Lion build fix.
1972
1973         * MiniBrowser/mac/AppDelegate.m:
1974         (-[BrowserAppDelegate openDocument:]):
1975
1976 2013-11-22  Anders Carlsson  <andersca@apple.com>
1977
1978         Fix Mountain Lion bug.
1979
1980         * MiniBrowser/mac/AppDelegate.m:
1981         (-[BrowserAppDelegate openDocument:]):
1982
1983 2013-11-22  Anders Carlsson  <andersca@apple.com>
1984
1985         MiniBrowser should use the blocks-based NSOpenPanel API
1986         https://bugs.webkit.org/show_bug.cgi?id=124786
1987
1988         Reviewed by Simon Fraser.
1989
1990         * MiniBrowser/mac/AppDelegate.m:
1991         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1992         Account for windows that don't have a BrowserWindowController.
1993
1994         (-[BrowserAppDelegate openDocument:]):
1995
1996 2013-11-22  Commit Queue  <commit-queue@webkit.org>
1997
1998         Unreviewed, rolling out r159690.
1999         http://trac.webkit.org/changeset/159690
2000         https://bugs.webkit.org/show_bug.cgi?id=124782
2001
2002         Broke webkitpy tests (Requested by ap on #webkit).
2003
2004         * Scripts/webkitpy/tool/bot/queueengine.py:
2005         (QueueEngine.run):
2006         (QueueEngine._open_work_log):
2007         (QueueEngine._ensure_work_log_closed):
2008         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2009         (AbstractEarlyWarningSystem.review_patch):
2010
2011 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
2012
2013         EWS creates 0 byte sized log files
2014         https://bugs.webkit.org/show_bug.cgi?id=107606
2015
2016         Reviewed by Ryosuke Niwa.
2017
2018         There was a modification in r138264, that tried to make less log, 
2019         because some of the messeges were duplicated. After this the EWS 
2020         created the log file (with the same name as the bugID) but doesn't 
2021         write anything into it, even if there were errors during the build. 
2022         From now only creates the log file only if there is some error.
2023
2024         * Scripts/webkitpy/tool/bot/queueengine.py:
2025         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2026         there is nothing to log. Open the log file only if a ScriptError was raised to
2027         avoid to make empty log files for bugs.
2028         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2029         because of changes in r138264. Teeing is used for locally testing purposes and
2030         this feature is not used anymore.
2031         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
2032         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2033         change.
2034         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2035         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2036         to be able to handle it in QueueEngine.run. Without this change, the existing
2037         exception handler never run (the process_work_item method never raise ScriptError)
2038         We can get the error message only from the ScriptError at this point.
2039
2040 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2041
2042         Remove ENABLE_WORKERS
2043         https://bugs.webkit.org/show_bug.cgi?id=105784
2044
2045         Reviewed by Darin Adler.
2046
2047         * Scripts/webkitperl/FeatureList.pm:
2048
2049 2013-11-21  Darin Adler  <darin@apple.com>
2050
2051         Try to fix buildbot Dashboard for people who have not hidden anything.
2052
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2054         Add a null check for hidden platforms.
2055
2056 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
2057
2058         Remove chrome/chromium related things from webkitpy.
2059         https://bugs.webkit.org/show_bug.cgi?id=124493
2060
2061         Reviewed by Darin Adler.
2062
2063         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2064         (PortTest.assert_mock_port_works):
2065         * Scripts/webkitpy/port/base.py:
2066         (Port.to.setup_environ_for_server):
2067         * Scripts/webkitpy/port/mac_unittest.py:
2068         (test_tests_for_other_platforms):
2069         * Scripts/webkitpy/port/mock_drt.py:
2070         (MockTestShell.output_for_test):
2071         * Scripts/webkitpy/tool/bot/irc_command.py:
2072         (Restart.execute):
2073         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2074         (IRCBotTest.test_help):
2075
2076 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2077
2078         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
2079         https://bugs.webkit.org/show_bug.cgi?id=124717
2080
2081         Reviewed by Ryosuke Niwa.
2082
2083         * Scripts/webkitpy/style/filereader.py:
2084         (TextFileReader.process_file):
2085         * Scripts/webkitpy/style/filereader_unittest.py:
2086         (TextFileReaderTest.test_process_file__does_not_exist):
2087
2088 2013-11-21  Mark Rowe  <mrowe@apple.com>
2089
2090         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
2091
2092         All modern versions of Xcode set it appropriately for our needs.
2093
2094         Reviewed by Alexey Proskuryakov.
2095
2096         * MiniBrowser/Configurations/Base.xcconfig:
2097         * WebKitTestRunner/Configurations/Base.xcconfig:
2098
2099 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
2100
2101         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
2102         https://bugs.webkit.org/show_bug.cgi?id=124676
2103
2104         Reviewed by Daniel Bates.
2105
2106         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
2107         elements when there were more then one occurrence of that argument.
2108         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
2109         {b, a}, when it should be {b, c}.
2110
2111         * Scripts/webkitdirs.pm:
2112         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
2113         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2114         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
2115
2116 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2117
2118         Update build-webkit after r159550.
2119
2120         * Scripts/webkitperl/FeatureList.pm:
2121
2122 2013-11-21  Lucas Forschler  <lforschler@apple.com>
2123
2124         Bring a new bot online, replacing the previous ones.
2125         
2126         Unreviewed.
2127
2128         * BuildSlaveSupport/build.webkit.org-config/config.json:
2129
2130 2013-11-21  Dean Jackson  <dino@apple.com>
2131
2132         Don't fetch hidden platforms on build.webkit.org/dashboard
2133         https://bugs.webkit.org/show_bug.cgi?id=124750
2134
2135         Reviewed by Tim Horton.
2136
2137         If a platform is hidden, don't fetch its data. If it
2138         becomes unhidden, try to fetch immediately (unless
2139         you've recently fetched).
2140
2141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2143
2144 2013-11-21  Commit Queue  <commit-queue@webkit.org>
2145
2146         Unreviewed, rolling out r159633.
2147         http://trac.webkit.org/changeset/159633
2148         https://bugs.webkit.org/show_bug.cgi?id=124726
2149
2150         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
2151
2152         * Scripts/webkitpy/style/checker.py:
2153         (check_webkit_style_configuration):
2154         (CheckerDispatcher.dispatch):
2155         (StyleProcessorConfiguration):
2156         (StyleProcessorConfiguration.__init__):
2157         (StyleProcessorConfiguration.write_style_error):
2158
2159 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
2160
2161         Remove the stderr_write attribute from StyleProcessorConfiguration.
2162         https://bugs.webkit.org/show_bug.cgi?id=124703
2163
2164         Reviewed by Brent Fulgham.
2165
2166         * Scripts/webkitpy/style/checker.py:
2167         (check_webkit_style_configuration):
2168         (CheckerDispatcher.dispatch):
2169         (StyleProcessorConfiguration):
2170         (StyleProcessorConfiguration.__init__):
2171         (StyleProcessorConfiguration.write_style_error):
2172
2173 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2174
2175         PerfTestRunner._generate_results_dict shouldn't depend on test objects
2176         https://bugs.webkit.org/show_bug.cgi?id=124623
2177
2178         Removed the dependency on test objects from results JSON generation.
2179         This allows single test.run to return metrics for multiple tests
2180
2181         Reviewed by Antti Koivisto.
2182
2183         * Scripts/webkitpy/performance_tests/perftest.py:
2184         (PerfTestMetric.__init__): Takes the test path and test name.
2185         (PerfTestMetric.path): Added.
2186         (PerfTestMetric.test_file_name): Added.
2187         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
2188         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
2189         The path is going to have the names of subtests at the end once we support them.
2190
2191         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2192         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
2193         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
2194         (TestPerfTestMetric.test_has_values): Ditto.
2195         (TestPerfTestMetric.test_append): Ditto.
2196
2197         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2198         (_generate_results_dict): Only use metrics.
2199         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
2200
2201 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
2202
2203         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
2204         https://bugs.webkit.org/show_bug.cgi?id=124697
2205
2206         Reviewed by Ryosuke Niwa.
2207
2208         * Scripts/webkitdirs.pm:
2209         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
2210         before trying to access to the first element.
2211
2212 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2213
2214         [GTK] Mark all deprecated symbols in GObject DOM bindings
2215         https://bugs.webkit.org/show_bug.cgi?id=124406
2216
2217         Reviewed by Gustavo Noronha Silva.
2218
2219         * Scripts/webkitpy/style/checker.py: Add special case for
2220         WebKitDOMDeprecated.
2221         * gtk/generate-gtkdoc:
2222         (get_webkit2_options): Use the prefix of the methods as namespace,
2223         since this is what gtkdoc expects to sort the index.
2224         (get_webkit1_options): Ditto.
2225         (get_webkitdom_options): Ditto.
2226         * gtk/generate-webkitdom-doc-files:
2227         (WebKitDOMDocGenerator): Add a global list of deleted objects.
2228         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
2229         the documentation for classes that are deprecated because they
2230         have been removed.
2231         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
2232         for deleted classes too.
2233         (WebKitDOMDocGeneratorSections.__init__): Build a list of
2234         deprecated symbols using the given symbols file.
2235         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
2236         deleted class corresponding to the given function.
2237         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
2238         dictionary of deprecated symbols for every class.
2239         (WebKitDOMDocGeneratorSections.write_section): Add also the
2240         deprecated symbols in every section.
2241         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
2242         sections for deleted classes too.
2243
2244 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
2245
2246         check-webkit-style should support C++11 rvalue references.
2247         https://bugs.webkit.org/show_bug.cgi?id=123406
2248
2249         Reviewed by Brent Fulgham.
2250
2251         * Scripts/webkitpy/style/checkers/cpp.py:
2252         (check_style):
2253         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2254         (Cpp11StyleTest):
2255         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
2256
2257 2013-11-20  Dean Jackson  <dino@apple.com>
2258
2259         Allow settings to be shown/hidden on build.webkit.org/dashboard
2260         https://bugs.webkit.org/show_bug.cgi?id=124694
2261
2262         Reviewed by Tim Horton.
2263
2264         In preparation for more options/buttons, allow the page to
2265         show or hide all the interactive things using a little gear icon
2266         in the top left corner.
2267
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2270         (Settings.prototype.toggleSettingsDisplay):
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2272         (div.cellButton.hide):
2273         (div.cellButton.unhide):
2274         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
2275         (.settings):
2276         (.settings:hover):
2277         (.settings-visible .settings):
2278
2279 2013-11-20  Dean Jackson  <dino@apple.com>
2280
2281         No need to base64 SVG on build.webkit.org/dashboard
2282         https://bugs.webkit.org/show_bug.cgi?id=124687
2283
2284         Reviewed by Tim Horton.
2285
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2287         (.status-line.good .bubble.pictogram):
2288
2289 2013-11-20  Dean Jackson  <dino@apple.com>
2290
2291         Make links look more like links on build.webkit.org/dashboard
2292         https://bugs.webkit.org/show_bug.cgi?id=124686
2293
2294         Reviewed by Tim Horton.
2295
2296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2297         (.queue-view .queueLabel:hover):
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2299         (.status-line.linked .label:hover):
2300
2301 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
2302
2303         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
2304         https://bugs.webkit.org/show_bug.cgi?id=124581
2305
2306         Reviewed by Daniel Bates.
2307
2308         Some subroutines are replicating code from checkForArgument**
2309         functions instead of reusing them as is being done by all other functions.
2310
2311         * Scripts/webkitdirs.pm:
2312         (determineXcodeSDK): Added.
2313         (determinePassedConfiguration): Added.
2314         (determinePassedArchitecture): Added.
2315         (checkForArgumentAndRemoveFromARGV): Added.
2316         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
2317
2318 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
2319
2320         Delete baseline optimizer
2321         https://bugs.webkit.org/show_bug.cgi?id=122333
2322
2323         Reviewed by Ryosuke Niwa.
2324
2325         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
2326         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
2327         * Scripts/webkitpy/tool/commands/rebaseline.py:
2328         (RebaselineTest.execute):
2329         (AbstractParallelRebaselineCommand._files_to_add):
2330         (AbstractParallelRebaselineCommand._rebaseline):
2331         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2332         (TestRebaselineJson.test_rebaseline_all):
2333         (TestRebaselineJson.test_rebaseline_debug):
2334         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
2335
2336 2013-11-20  Anders Carlsson  <andersca@apple.com>
2337
2338         Enable PageLoadTest assertions again
2339         https://bugs.webkit.org/show_bug.cgi?id=124681
2340
2341         Reviewed by Tim Horton.
2342
2343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2344         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
2345
2346 2013-11-20  Mark Rowe  <mrowe@apple.com>
2347
2348         Remove some obsolete logic from WebKit.app.
2349
2350         Reviewed by Alexey Proskuryakov.
2351
2352         * WebKitLauncher/WebKitNightlyEnabler.m:
2353         (poseAsWebKitApp): Remove a pre-10.6 codepath.
2354         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
2355
2356 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2357
2358         Moved stray urls from svn.py and statusserver.py into common.config.urls
2359         https://bugs.webkit.org/show_bug.cgi?id=124650
2360
2361         Reviewed by Ryosuke Niwa.
2362
2363         * Scripts/webkitpy/common/checkout/scm/svn.py:
2364         (SVNRepository):
2365         * Scripts/webkitpy/common/config/urls.py:
2366         * Scripts/webkitpy/common/net/statusserver.py:
2367         (StatusServer.__init__):
2368         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2369         (_generate_results_dict):
2370
2371 2013-11-20  Commit Queue  <commit-queue@webkit.org>
2372
2373         Unreviewed, rolling out r159496.
2374         http://trac.webkit.org/changeset/159496
2375         https://bugs.webkit.org/show_bug.cgi?id=124641
2376
2377         It caused warning and build break with cmake lower than 2.8.8
2378         (Requested by ryuan on #webkit).
2379
2380         * MiniBrowser/efl/CMakeLists.txt:
2381
2382 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
2383
2384         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
2385         https://bugs.webkit.org/show_bug.cgi?id=124412
2386
2387         Reviewed by Gyuyoung Kim.
2388
2389         Update libseccomp to a newer 2.1.0 version.
2390
2391         * efl/jhbuild.modules:
2392
2393 2013-11-19  Mark Rowe  <mrowe@apple.com>
2394
2395         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
2396
2397         Gestalt is deprecated on recent OS X versions so we should switch off it.
2398
2399         Reviewed by Sam Weinig.
2400
2401         * WebKitLauncher/main.m:
2402         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
2403         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
2404         two components, then join them back up.
2405         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
2406         the version we care about.
2407
2408 2013-11-19  Commit Queue  <commit-queue@webkit.org>
2409
2410         Unreviewed, rolling out r159538.
2411         http://trac.webkit.org/changeset/159538
2412         https://bugs.webkit.org/show_bug.cgi?id=124627
2413
2414         it broke run-jsc-stress-tests (Requested by mhahnenberg on
2415         #webkit).
2416
2417         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2418         * Scripts/run-javascriptcore-tests:
2419         * Scripts/run-jsc-stress-tests:
2420
2421 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2422
2423         run-jsc-stress-tests should be able to package its tests and move them places
2424         https://bugs.webkit.org/show_bug.cgi?id=124549
2425
2426         Reviewed by Geoff Garen and Filip Pizlo.
2427
2428         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
2429         of grep -i -q 
2430         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
2431         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
2432         other files that those tests require to run in any environment along with a fixed root directory into which these
2433         files and their expected directory structure are cloned. The default Bundle class is basically 
2434         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
2435         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
2436         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
2437         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
2438         to use MovableBundle instead of just Bundle. 
2439
2440 2013-11-19  Dan Bernstein  <mitz@apple.com>
2441
2442         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
2443
2444         Rubber-stamped by Mark Rowe.
2445
2446         Reverted r156840.
2447
2448         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
2449
2450 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2451
2452         Yet another build fix. Just allow any character.
2453         There are just too many special characters to be listed here.
2454
2455         * Scripts/webkitpy/performance_tests/perftest.py:
2456         (PerfTest._lines_to_ignore_in_parser_result):
2457         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2458         (TestPerfTest.test_parse_output_with_subtests)
2459
2460 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2461
2462         Another build fix. Allow ':' in subtest names.
2463
2464         * Scripts/webkitpy/performance_tests/perftest.py:
2465         (PerfTest._lines_to_ignore_in_parser_result):
2466         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2467         (TestPerfTest.test_parse_output_with_subtests)
2468
2469 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
2470
2471         [EFL] Use Config mode of find_package for EFL 1.8
2472         https://bugs.webkit.org/show_bug.cgi?id=124555
2473
2474         Reviewed by Gyuyoung Kim.
2475
2476         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
2477
2478 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
2479
2480         Build fix. Subtest names need to be more permissive.
2481
2482         * Scripts/webkitpy/performance_tests/perftest.py:
2483         (PerfTest._lines_to_ignore_in_parser_result):
2484         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2485         (TestPerfTest.test_parse_output_with_subtests)
2486
2487 2013-11-18  Mark Rowe  <mrowe@apple.com>
2488
2489         Use hw.activecpu for determining how many processes to spawn.
2490
2491         It's documented as the preferred way to determine the number of threads
2492         or processes to create in a SMP aware application.
2493
2494         Rubber-stamped by Tim Horton.
2495
2496         * Scripts/copy-webkitlibraries-to-product-directory:
2497         * Scripts/run-jsc-stress-tests:
2498         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2499
2500 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2501
2502         build.webkit.org/dashboard builder headers should link to the builder page
2503         https://bugs.webkit.org/show_bug.cgi?id=124553
2504
2505         Reviewed by Timothy Hatcher.
2506
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2508         (BuildbotQueue.prototype.get overviewURL):
2509         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2512         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
2513         (BuildbotBuilderQueueView.prototype.update):
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2515         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2516         (BuildbotTesterQueueView.prototype.update.appendBuild):
2517         (BuildbotTesterQueueView.prototype.update):
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2519         (.queue-view .queueLabel):
2520         (.queue-view .queueLabel:not(:first-child)):
2521         Make the header a link instead of a label, and wire it up to overviewURL.
2522
2523 2013-11-18  Samuel White  <samuel_white@apple.com>
2524
2525         AX: Add ability to fetch only visible table rows.
2526         https://bugs.webkit.org/show_bug.cgi?id=124430
2527
2528         Reviewed by Chris Fleizach.
2529
2530         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
2531         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
2532         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
2533         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
2534         as the test guidelines state, our tests should be more focused and specific about what they test.
2535
2536         * DumpRenderTree/AccessibilityUIElement.cpp:
2537         (uiElementArrayAttributeValueCallback):
2538         (AccessibilityUIElement::uiElementArrayAttributeValue):
2539         (AccessibilityUIElement::getJSClass):
2540         * DumpRenderTree/AccessibilityUIElement.h:
2541         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2542         (AccessibilityUIElement::uiElementArrayAttributeValue):
2543         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2544         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2545         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2546         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2547         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2548         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2549         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2550         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
2551         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2552
2553 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
2554
2555         Simplify and reformat the output of performance tests inside test runners
2556         https://bugs.webkit.org/show_bug.cgi?id=124496
2557
2558         Reviewed by Antti Koivisto.
2559
2560         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
2561         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
2562         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
2563         the first place.
2564
2565         Also modernize the output to adopt "metric" concept better and make it forward compatible
2566         with subtests.
2567
2568         With this patch, performance tests written using runner.js only produces empty lines or
2569         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
2570         <subtest name> -> [<value 1>, <value 2>, ...]
2571         :<metric name> -> [<value 1>, <value 2>, ...]
2572
2573         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
2574
2575         * Scripts/webkitpy/performance_tests/perftest.py:
2576         (PerfTest): Removed a bunch of regular expressions that are no longer used.
2577         (PerfTest._run_with_driver): Just parse the values and description and treat everything
2578         else as errors.
2579
2580         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2581         (TestPerfTest.test_parse_output): Removed the junk.
2582         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
2583         which was removed in favor of the tests below.
2584         (TestPerfTest.test_parse_output_with_running_five_times): Added.
2585         (TestPerfTest.test_parse_output_with_detailed_info): Added.
2586         (TestPerfTest.test_parse_output_with_statistics): Added.
2587         (TestPerfTest.test_parse_output_with_description): Removed the junk.
2588         (TestPerfTest.test_parse_output_with_subtests): Ditto.
2589         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
2590
2591         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2592         (EventTargetWrapperTestData): Ditto.
2593         (SomeParserTestData): Ditto.
2594         (MemoryTestData): Ditto.
2595
2596 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2597
2598         Occasionally, hundreds of tests fail with small text diffs on Mavericks
2599         https://bugs.webkit.org/show_bug.cgi?id=124312
2600
2601         Reviewed by Simon Fraser.
2602
2603         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2604         (Manager._set_up_run):
2605         * Scripts/webkitpy/port/base.py:
2606         (Port.to.reset_preferences):
2607         * Scripts/webkitpy/port/mac.py:
2608         (MacPort.reset_preferences):
2609         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
2610         returning some of the functionality of 158652 after 159364 removed it.
2611
2612 2013-11-18  Tim Horton  <timothy_horton@apple.com>
2613
2614         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
2615         https://bugs.webkit.org/show_bug.cgi?id=122909
2616
2617         Reviewed by Alexey Proskuryakov.
2618
2619         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
2620
2621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2622         (.status-line .bubble):
2623         (.status-line.good .bubble.pictogram):
2624
2625 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
2626
2627         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
2628         https://bugs.webkit.org/show_bug.cgi?id=124499
2629
2630         Reviewed by Csaba Osztrogonác.
2631
2632         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
2633
2634         * Scripts/webkitpy/performance_tests/perftest.py:
2635         (PerfTest._should_ignore_line):
2636         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2637         (TestPerfTest): Removed the unit test.
2638
2639 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
2640
2641         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
2642         quite as easily.
2643         
2644         With help from Andy Trick.
2645
2646         * Scripts/export-llvm-build:
2647
2648 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
2649
2650         FTL should have an explicit notion of bytecode liveness
2651         https://bugs.webkit.org/show_bug.cgi?id=124181
2652
2653         Reviewed by Mark Hahnenberg.
2654
2655         * Scripts/run-jsc-stress-tests:
2656
2657 2013-11-16  Dan Bernstein  <mitz@apple.com>
2658
2659         No way for policy client to determine if a the response’s MIME type can be shown
2660         https://bugs.webkit.org/show_bug.cgi?id=124445
2661
2662         Reviewed by Sam Weinig.
2663
2664         * MiniBrowser/mac/WK2BrowserWindowController.m:
2665         (decidePolicyForResponse): Added canShowMIMEType parameter.
2666         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
2667
2668         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2669         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
2670
2671         * WebKitTestRunner/TestController.cpp:
2672         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
2673         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
2674         * WebKitTestRunner/TestController.h:
2675
2676 2013-11-16  Tim Horton  <timothy_horton@apple.com>
2677
2678         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
2679         https://bugs.webkit.org/show_bug.cgi?id=122909
2680
2681         Reviewed by Timothy Hatcher.
2682
2683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
2684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2685         (StatusLineView.prototype.set repeatCount):
2686         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2687         (.status-line.good .bubble.pictogram):
2688         Use an SVG image instead of an obscure font for the checkboxes so they
2689         render identically on all platforms.
2690
2691 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2692
2693         Occasionally, hundreds of tests fail with small text diffs on Mavericks
2694         https://bugs.webkit.org/show_bug.cgi?id=124312
2695
2696         Reviewed by Alexey Proskuryakov.
2697
2698         Try reverting the part of r158652 that deleted all of the persistent
2699         defaults, in the thought that there might be some sort of race between
2700         processes causing some settings to be left in the wrong state.
2701
2702         * DumpRenderTree/mac/DumpRenderTree.mm:
2703         (setDefaultsToConsistentValuesForTesting):
2704         * WebKitTestRunner/mac/main.mm:
2705         (setDefaultsToConsistentValuesForTesting):
2706
2707 2013-11-15  Dan Bernstein  <mitz@apple.com>
2708
2709         Give the policy client the originating frame of a navigation action
2710         https://bugs.webkit.org/show_bug.cgi?id=124431
2711
2712         Reviewed by Anders Carlsson.
2713
2714         * MiniBrowser/mac/WK2BrowserWindowController.m:
2715         (decidePolicyForNavigationAction): Added originatingFrame parameter.
2716         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
2717         client.
2718
2719         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2720         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
2721         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
2722
2723         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2724         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
2725         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
2726
2727         * WebKitTestRunner/TestController.cpp:
2728         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
2729         client.
2730         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
2731         * WebKitTestRunner/TestController.h:
2732
2733 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2734
2735         build.webkit.org/dashboard should provide a way to focus on a subset of bots
2736         https://bugs.webkit.org/show_bug.cgi?id=122676
2737
2738         Reviewed by Timothy Hatcher.
2739
2740         Add a small 'hide' button next to every platform logo, and a 'show all'
2741         button which only appears when at least one platform is hidden. Hidden
2742         platforms persist using localStorage.
2743
2744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2746         (updateHiddenPlatforms):
2747         (documentReady.unhideButton):
2748         (documentReady.hideButton):
2749         (documentReady):
2750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
2751         (Settings.prototype.setObject):
2752         (Settings.prototype.getObject):
2753         (Settings.prototype.addSettingListener):
2754         (Settings.prototype.fireSettingListener):
2755         (Settings.prototype.toggleHiddenPlatform):
2756         (Settings.prototype.clearHiddenPlatforms):
2757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2758         (div.cellButton):
2759         (div.cellButton.hide):
2760         (.hidden):
2761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2762
2763 2013-11-15  Jer Noble  <jer.noble@apple.com>
2764
2765         MediaTime addition and subtraction operators have errors when the rhs is infinite.
2766         https://bugs.webkit.org/show_bug.cgi?id=124413
2767
2768         Reviewed by Eric Carlson.
2769
2770         Add a test for operator+ and operator- where an infinite value appears
2771         on the right-hand side:
2772         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2773         (TestWebKitAPI::TEST):
2774
2775         Add a LLDB summary provider for MediaTime which displays the rational
2776         time as well as the value in seconds:
2777         * lldb/lldb_webkit.py:
2778         (__lldb_init_module):
2779         (WTFMediaTime_SummaryProvider):
2780         (WTFHashTableProvider.has_children):
2781         (WTFMediaTimeProvider):
2782         (WTFMediaTimeProvider.__init__):
2783         (WTFMediaTimeProvider.timeValue):
2784         (WTFMediaTimeProvider.timeScale):
2785         (WTFMediaTimeProvider.isInvalid):
2786         (WTFMediaTimeProvider.isPositiveInfinity):
2787         (WTFMediaTimeProvider.isNegativeInfinity):
2788         (WTFMediaTimeProvider.isIndefinite):
2789
2790 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2791
2792         Make it possible to select revision numbers on build.webkit.org/dashboard
2793         https://bugs.webkit.org/show_bug.cgi?id=124400
2794
2795         Reviewed by Timothy Hatcher.
2796
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2798         (BuildbotQueueView.prototype.revisionLinksForIteration):
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2800         (.selectable):
2801         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
2802         This way, a Dashboard user can highlight revision numbers for easy copying,
2803         and doesn't even have to be precise about the selection.
2804
2805 2013-11-15  Tim Horton  <timothy_horton@apple.com>
2806
2807         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
2808         https://bugs.webkit.org/show_bug.cgi?id=124399
2809
2810         Reviewed by Gustavo Noronha Silva.
2811
2812         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
2813         with the icons adjusted to have solid backgrounds, to not be squished, and to not
2814         intersect the ring, similar to the Mac icons.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
2817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
2819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
2820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2821         (documentReady.hideButton):
2822         (documentReady):
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2824         (table.queue-grid tr.platform.linux-gtk img.logo):
2825         (table.queue-grid tr.platform.linux-efl img.logo):
2826
2827 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
2828
2829         [GStreamer] Add support for Media Source API
2830         https://bugs.webkit.org/show_bug.cgi?id=99065
2831
2832         Reviewed by Philippe Normand.
2833
2834         * Scripts/webkitperl/FeatureList.pm:
2835
2836 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2837
2838         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
2839         https://bugs.webkit.org/show_bug.cgi?id=124360
2840
2841         Reviewed by Philippe Normand.
2842
2843         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
2844
2845 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
2846
2847         [Win] Improve support for command line builds of 64-bit JSC
2848         https://bugs.webkit.org/show_bug.cgi?id=124380
2849
2850         Reviewed by David Kilzer.
2851
2852         * Scripts/webkitdirs.pm:
2853         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
2854         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
2855         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
2856         what the "$configurationForVisualStudio" value is for.
2857
2858 2013-11-14  Oliver Hunt  <oliver@apple.com>
2859
2860         Make CLoop easier to build, and make it work
2861         https://bugs.webkit.org/show_bug.cgi?id=124359
2862
2863         Reviewed by Geoffrey Garen.
2864
2865         Add --cloop support to forcibly enable to CLoop build
2866
2867         * Scripts/build-jsc:
2868         * Scripts/build-webkit:
2869
2870 2013-11-14  Lucas Forschler  <lforschler@apple.com>
2871
2872         Add webkit slave.
2873
2874         Unreviewed.
2875
2876         * BuildSlaveSupport/build.webkit.org-config/config.json:
2877
2878 2013-11-14  Tim Horton  <timothy_horton@apple.com>
2879
2880         build.webkit.org/dashboard can’t open different results in two new tabs
2881         https://bugs.webkit.org/show_bug.cgi?id=124383
2882
2883         Reviewed by Alexey Proskuryakov.
2884
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2886         (BuildbotQueueView.prototype.revisionLinksForIteration):
2887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2888         (StatusLineView.prototype._clicked):
2889         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
2890         real pseudo-target and instead acts as a named target and will end up causing all link clicks
2891         to open in the same secondary tab).
2892
2893 2013-11-14  Anders Carlsson  <andersca@apple.com>
2894
2895         Remove duplicate entry.
2896
2897         * Scripts/webkitpy/common/config/contributors.json:
2898
2899 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
2900
2901         [ATK] Change WKTR/DRT AX methods to use nullptr 
2902         https://bugs.webkit.org/show_bug.cgi?id=124352
2903
2904         Reviewed by Anders Carlsson.
2905
2906         Change WKTR/DRT accessibility related methods to use nullptr.
2907
2908         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2909         (AccessibilityController::AccessibilityController):
2910         (AccessibilityController::elementAtPoint):
2911         (AccessibilityController::removeNotificationListener):
2912         (AccessibilityController::childElementById):
2913         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
2914         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2915         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2916         (AccessibilityUIElement::elementAtPoint):
2917         (AccessibilityUIElement::linkedUIElementAtIndex):
2918         (AccessibilityUIElement::getChildAtIndex):
2919         (AccessibilityUIElement::titleUIElement):
2920         (AccessibilityUIElement::parentElement):
2921         (AccessibilityUIElement::subrole):
2922         (AccessibilityUIElement::roleDescription):
2923         (AccessibilityUIElement::orientation):
2924         (AccessibilityUIElement::ariaDropEffects):
2925         (AccessibilityUIElement::uiElementForSearchPredicate):
2926         (AccessibilityUIElement::cellForColumnAndRow):
2927         (AccessibilityUIElement::disclosedRowAtIndex):
2928         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2929         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2930         (AccessibilityUIElement::selectedRowAtIndex):
2931         (AccessibilityUIElement::rowAtIndex):
2932         (AccessibilityUIElement::disclosedByRow):
2933         (AccessibilityUIElement::removeNotificationListener):
2934         (AccessibilityUIElement::classList):
2935         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2936         (WTR::AccessibilityController::logAccessibilityEvents):
2937         (WTR::AccessibilityController::resetToConsistentState):
2938         (WTR::childElementById):
2939         (WTR::AccessibilityController::accessibleElementById):
2940         (WTR::AccessibilityController::removeNotificationListener):
2941         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2942         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2943         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2944         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2945         (WTR::AccessibilityUIElement::elementAtPoint):
2946         (WTR::AccessibilityUIElement::childAtIndex):
2947         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2948         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2949         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2950         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2951         (WTR::AccessibilityUIElement::rowAtIndex):
2952         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2953         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2954         (WTR::AccessibilityUIElement::titleUIElement):
2955         (WTR::AccessibilityUIElement::parentElement):
2956         (WTR::AccessibilityUIElement::disclosedByRow):
2957         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2958         (WTR::AccessibilityUIElement::orientation):
2959         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2960         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2961         (WTR::AccessibilityUIElement::horizontalScrollbar):
2962         (WTR::AccessibilityUIElement::verticalScrollbar):
2963         (WTR::AccessibilityUIElement::removeNotificationListener):
2964         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2965         (WTR::AccessibilityUIElement::previousTextMarker):
2966         (WTR::AccessibilityUIElement::nextTextMarker):
2967         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2968         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2969         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2970         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2971         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2972         (WTR::AccessibilityUIElement::textMarkerForPoint):
2973         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2974         (WTR::AccessibilityUIElement::textMarkerForIndex):
2975         (WTR::AccessibilityUIElement::supportedActions):
2976         (WTR::AccessibilityUIElement::pathDescription):
2977         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2978         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2979         (WTR::AccessibilityUIElement::classList):
2980
2981 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2982
2983         run-perf-tests should warn loudly if you're using a Debug build.
2984         https://bugs.webkit.org/show_bug.cgi?id=105236
2985
2986         Reviewed by Csaba Osztrogonác.
2987
2988         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2989         (PerfTestsRunner.run):
2990
2991 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2992
2993         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
2994         https://bugs.webkit.org/show_bug.cgi?id=124143
2995
2996         Reviewed by Csaba Osztrogonác.
2997
2998         * Scripts/webkitpy/port/factory.py:
2999         (configuration_options):
3000
3001 2013-11-13  Anders Carlsson  <andersca@apple.com>
3002
3003         Add a Vector constructor that takes an std::initializer_list
3004         https://bugs.webkit.org/show_bug.cgi?id=124287
3005
3006         Reviewed by Antti Koivisto.
3007
3008         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3009         (TestWebKitAPI::TEST):
3010
3011 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
3012
3013         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
3014
3015         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3016         (TestRebaselineTest.test_baseline_directory): Updated.
3017
3018 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
3019
3020         [ATK] Support compilation of EFL/GTK without accessibility
3021         https://bugs.webkit.org/show_bug.cgi?id=122448
3022
3023         Reviewed by Chris Fleizach.
3024
3025         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
3026         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
3027
3028         * DumpRenderTree/AccessibilityController.h:
3029         * DumpRenderTree/AccessibilityUIElement.h:
3030         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3031         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3032         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
3033         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3034         (WTR::AccessibilityController::rootElement):
3035         (WTR::AccessibilityController::focusedElement):
3036         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3037         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3038         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3039         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3040         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3041         * WebKitTestRunner/PlatformEfl.cmake:
3042
3043 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
3044
3045         [EFL] Added libxss-dev to install-dependencies
3046         https://bugs.webkit.org/show_bug.cgi?id=124254
3047
3048         Reviewed by Gyuyoung Kim.
3049
3050         libxss-dev is required to build EFL packages.
3051         see building part in http://www.enlightenment.org/p.php?p=contribute
3052
3053         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
3054
3055 2013-11-12  Tim Horton  <timothy_horton@apple.com>
3056
3057         After http://trac.webkit.org/changeset/159109, update
3058         rebaseline_unittest to use the new GTK bot names.
3059
3060         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3061         (TestRebaselineTest.test_baseline_directory):
3062
3063 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3064
3065         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
3066         https://bugs.webkit.org/show_bug.cgi?id=124144
3067
3068         Reviewed by Gustavo Noronha Silva.
3069
3070         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
3071         according to http://build.webkit.org/builders.
3072
3073         * Scripts/webkitpy/port/builders.py:
3074
3075 2013-11-11  Samuel White  <samuel_white@apple.com>
3076
3077         AX: support helpText() in DumpRenderTree
3078         https://bugs.webkit.org/show_bug.cgi?id=40194
3079
3080         Reviewed by Chris Fleizach.
3081
3082         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
3083
3084         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3085         (AccessibilityUIElement::helpText):
3086
3087 2013-11-11  Anders Carlsson  <andersca@apple.com>
3088
3089         Remove block based APIs from the WebKit2 C API
3090         https://bugs.webkit.org/show_bug.cgi?id=124157
3091
3092         Reviewed by Sam Weinig.
3093
3094         Update for WK2 changes.
3095
3096         * MiniBrowser/mac/WK2BrowserWindowController.m:
3097         (dumpSource):
3098         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3099
3100 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3101
3102         The feeder queue will not feed patches older than one week.
3103         https://bugs.webkit.org/show_bug.cgi?id=107152
3104
3105         Reviewed by Csaba Osztrogonác.
3106
3107         The feeder queue will not feed patches older than one week.
3108         Unit test added to this scenario.
3109
3110         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3111         (BugzillaQueries._parse_attachment_ids_request_query):
3112           Handle date parameter.
3113         (BugzillaQueries):
3114         (BugzillaQueries._fetch_attachment_ids_request_query):
3115           Propagate date.
3116         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
3117           Propagate date.
3118         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3119         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
3120           Handle date.
3121         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3122         (test_request_page_parsing):
3123           Unit test added.
3124         * Scripts/webkitpy/tool/bot/feeders.py:
3125         (EWSFeeder.feed):
3126           Query patch ids with date parameter (now - 1 week).
3127
3128 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
3129
3130         Do not shut down ImageDiff server after every diff during the tests.
3131         https://bugs.webkit.org/show_bug.cgi?id=124140
3132
3133         Reviewed by Csaba Osztrogonác.
3134
3135         There was a FIXME: There is no need to shut down the ImageDiff
3136         server after every diff. Shutdown is removed from that point.
3137
3138         * Scripts/webkitpy/port/image_diff.py:
3139         (ImageDiffer._read):
3140
3141 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
3142
3143         Unreviewed. Added myself as a contributor.
3144
3145         * Scripts/webkitpy/common/config/contributors.json:
3146
3147 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
3148
3149         [GTK] accessibility/aria-link-supports-press.html is failing
3150         https://bugs.webkit.org/show_bug.cgi?id=98355
3151
3152         Reviewed by Mario Sanchez Prada.
3153
3154         Checking "jump" action for link elements. Action "jump" occurs when a link 
3155         element is pressed/clicked.
3156
3157         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3158         (AccessibilityUIElement::isPressActionSupported):
3159         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3160         (WTR::AccessibilityUIElement::isPressActionSupported):
3161
3162 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
3163
3164         [JHBUILD] Jhbuild Makefile build bug workaround
3165         https://bugs.webkit.org/show_bug.cgi?id=123971
3166
3167         Reviewed by Ryosuke Niwa.
3168
3169         After Jhbuild repository is cloned (for instance when you use
3170         Tools/Scripts/update-webkitefl-libs) it is built from sources.
3171         If you have GREP_OPTIONS grep env variable set (for instance
3172         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
3173         uses shell grep. For specific GREP_OPTIONS grep output will be
3174         different than expected one by Jhbuild and there is an error
3175         with Jhbuild build. Jhbuild will not be built and then WebKit
3176         source also will not be built. This patch is a workaround to this
3177         issue. It disables GREP_OPTIONS for Jhbuild build time.
3178
3179         * jhbuild/jhbuild-wrapper:
3180         (install_jhbuild):
3181
3182 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3183
3184         [GTK] Ignore deprecated macros when generating gtk-doc
3185         https://bugs.webkit.org/show_bug.cgi?id=123988
3186
3187         Reviewed by Philippe Normand.
3188
3189         * gtk/generate-gtkdoc:
3190         (get_common_options): Ignore also WEBKIT_DEPRECATED and
3191         WEBKIT_DEPRECATED_FOR decorators.
3192
3193 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3194
3195         [GTK] Pass the library namespace to gtkdoc-mkdb
3196         https://bugs.webkit.org/show_bug.cgi?id=123900
3197
3198         Reviewed by Martin Robinson.
3199
3200         This fixes the generation of the index of symbols in the API
3201         documentation.
3202
3203         * gtk/generate-gtkdoc:
3204         (get_webkit2_options): Define namespace as WebKit.
3205         (get_webkit1_options): Ditto.
3206         (get_webkitdom_options): Define namespace as WebKitDOM.
3207         * gtk/gtkdoc.py:
3208         (GTKDoc.__init__): Add namespace option.
3209         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
3210
3211 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
3212
3213         Modify email order list for James Craig so his primary email is first.
3214
3215         * Scripts/webkitpy/common/config/contributors.json:
3216
3217 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3218
3219         [Gtk] Disable LTO when building cairo
3220         https://bugs.webkit.org/show_bug.cgi?id=123954
3221
3222         Reviewed by Martin Robinson.
3223
3224         Cairo always uses LTO, when it detects compiler support.
3225         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3226         default. This patch disables LTO when building cairo library.
3227         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3228
3229         With gcc 4.7.3, for example, the build fails with the following message:
3230         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3231
3232         * gtk/jhbuild.modules:
3233
3234 2013-11-07  Samuel White  <samuel_white@apple.com>
3235
3236         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
3237         https://bugs.webkit.org/show_bug.cgi?id=123774
3238
3239         Reviewed by Chris Fleizach.
3240
3241         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
3242
3243         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3244         (AccessibilityUIElement::isFocused):
3245         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3246         (WTR::AccessibilityUIElement::isFocused):
3247
3248 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3249
3250         Removed retrieveQMakespecVar function
3251         https://bugs.webkit.org/show_bug.cgi?id=123996
3252
3253         Reviewed by Csaba Osztrogonác.
3254
3255         * Scripts/webkitdirs.pm:
3256
3257 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3258
3259         Removed QMake related filters
3260         https://bugs.webkit.org/show_bug.cgi?id=123992
3261
3262         Reviewed by Csaba Osztrogonác.
3263
3264         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3265         (TestRebaseline.test_rebaseline):
3266         (TestRebaselineExpectations.test_rebaseline_expectations):
3267
3268 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
3269
3270         [Efl] Disable LTO when building cairo
3271         https://bugs.webkit.org/show_bug.cgi?id=123947
3272
3273         Reviewed by Gyuyoung Kim.
3274
3275         Cairo always uses LTO, when it detects compiler support.
3276         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
3277         default. This patch disables LTO when building cairo library.
3278         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
3279
3280         With gcc 4.7.3, for example, the build fails with the following message:
3281         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
3282
3283         * efl/jhbuild.modules:
3284
3285 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
3286
3287         AX: [ATK] Video and audio elements are not properly exposed
3288         https://bugs.webkit.org/show_bug.cgi?id=123894
3289
3290         Reviewed by Chris Fleizach.
3291
3292         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
3293
3294         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
3295         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
3296
3297 2013-11-07  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3298
3299         Change git_commit_from_svn_revision() to work in a pure git checkout
3300         https://bugs.webkit.org/show_bug.cgi?id=111668
3301
3302         Reviewed by Ryosuke Niwa.
3303
3304         * Scripts/webkitpy/common/checkout/scm/git.py:
3305         (Git.git_commit_from_svn_revision):
3306
3307 2013-11-06  Jer Noble  <jer.noble@apple.com>
3308
3309         Unreviewed webkitpy unit test fix; update baselines after r158765
3310
3311         * Scripts/webkitpy/port/win_unittest.py:
3312         (WinPortTest.test_baseline_search_path):
3313
3314 2013-11-06  Jer Noble  <jer.noble@apple.com>
3315
3316         [Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
3317         https://bugs.webkit.org/show_bug.cgi?id=123905
3318
3319         Reviewed by Brent Fulgham.
3320
3321         Now that the mac-lion results have been removed, the win port should fall back to
3322         the mac-mountainlion results.
3323
3324         * Scripts/webkitpy/port/win.py:
3325         (WinPort.default_baseline_search_path):
3326
3327 2013-11-06  Anders Carlsson  <andersca@apple.com>
3328
3329         Fix a Mountain Lion test failure.
3330
3331         NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
3332
3333         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3334         (TestWebKitAPI::TEST):
3335
3336 2013-11-06  Krzysztof Czech  <k.czech@samsung.com>
3337
3338         [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
3339         https://bugs.webkit.org/show_bug.cgi?id=118969
3340
3341         Reviewed by Mario Sanchez Prada.
3342
3343         Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
3344
3345         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3346         (AccessibilityUIElement::attributesOfChildren):
3347         (AccessibilityUIElement::attributesOfColumnHeaders):
3348         (AccessibilityUIElement::attributesOfRowHeaders):
3349         (AccessibilityUIElement::attributesOfVisibleCells):
3350         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3351         (WTR::AccessibilityUIElement::attributesOfChildren):
3352         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3353         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3354         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3355
3356 2013-11-05  Benjamin Poulain  <benjamin@webkit.org>
3357
3358         [WK2] Add a WebKit2 API for Geolocation's highAccuracy
3359         https://bugs.webkit.org/show_bug.cgi?id=123786
3360
3361         Reviewed by Darin Adler.
3362
3363         Add basic testing for the Geolocation API (start, stop and change accuracy).
3364
3365         * TestWebKitAPI/GNUmakefile.am:
3366         * TestWebKitAPI/PlatformEfl.cmake:
3367         * TestWebKitAPI/PlatformGTK.cmake:
3368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3369         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
3370         (TestWebKitAPI::operator<<):
3371         (TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
3372         (TestWebKitAPI::GeolocationStateTracker::eventsChanged):
3373         (TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
3374         (TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
3375         (TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
3376         (TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
3377         (TestWebKitAPI::setupGeolocationProvider):
3378         (TestWebKitAPI::setupView):
3379         (TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
3380         (TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
3381         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
3382         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
3383         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
3384         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
3385         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
3386         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
3387         (TestWebKitAPI::didFinishLoadForFrame):
3388         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
3389         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
3390         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
3391         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
3392         * WebKitTestRunner/GeolocationProviderMock.cpp:
3393         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3394
3395 2013-11-05  Anders Carlsson  <andersca@apple.com>
3396
3397         Implement more NSCoder methods
3398         https://bugs.webkit.org/show_bug.cgi?id=123815
3399
3400         Reviewed by Dan Bernstein.
3401
3402         Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.
3403
3404         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
3405         (TestWebKitAPI::TEST):
3406         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
3407         (-[BundleObject testMethodWithArray:dictionary:request:]):
3408         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
3409
3410 2013-11-05  Filip Pizlo  <fpizlo@apple.com>
3411
3412         Update ReducedFTL
3413         https://bugs.webkit.org/show_bug.cgi?id=123805
3414
3415         Reviewed by Sam Weinig.
3416         
3417         - Make ReducedFTL build with debug info.
3418         
3419         - Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding
3420           memory leaks and attaching a profiler.
3421         
3422         - Reorder the passes so that they match the FTL.
3423         
3424         - Make it possible to change the backend opt level and enable the fast isel.
3425
3426         * ReducedFTL/ReducedFTL.c:
3427         (usage):
3428         (roundUpSize):
3429         (mmAllocateCodeSection):
3430         (main):
3431         * ReducedFTL/build.sh:
3432
3433 2013-11-05  Chris Fleizach  <cfleizach@apple.com>
3434
3435         AX: switch DRT AX methods to use nullptr
3436         https://bugs.webkit.org/show_bug.cgi?id=123773
3437
3438         Reviewed by Andreas Kling.
3439
3440         Switch AX related code in DRT and WKTR to use nullptr.
3441
3442         * DumpRenderTree/AccessibilityUIElement.cpp:
3443         (AccessibilityUIElement::startTextMarker):
3444         (AccessibilityUIElement::endTextMarker):
3445         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3446         (findAccessibleObjectById):
3447         (AccessibilityController::accessibleElementById):
3448         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3449         (AccessibilityUIElement::getChildAtIndex):
3450         (AccessibilityUIElement::linkedUIElementAtIndex):
3451         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3452         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3453         (AccessibilityUIElement::disclosedRowAtIndex):
3454         (AccessibilityUIElement::selectedChildAtIndex):
3455         (AccessibilityUIElement::selectedRowAtIndex):
3456         (AccessibilityUIElement::rowAtIndex):
3457         (AccessibilityUIElement::titleUIElement):
3458         (AccessibilityUIElement::parentElement):
3459         (AccessibilityUIElement::disclosedByRow):
3460         (AccessibilityUIElement::stringAttributeValue):
3461         (AccessibilityUIElement::uiElementAttributeValue):
3462         (AccessibilityUIElement::role):
3463         (AccessibilityUIElement::subrole):
3464         (AccessibilityUIElement::roleDescription):
3465         (AccessibilityUIElement::title):
3466         (AccessibilityUIElement::description):
3467         (AccessibilityUIElement::orientation):
3468         (AccessibilityUIElement::stringValue):
3469         (AccessibilityUIElement::language):
3470         (AccessibilityUIElement::helpText):
3471         (AccessibilityUIElement::valueDescription):
3472         (AccessibilityUIElement::speak):
3473         (AccessibilityUIElement::classList):
3474         (AccessibilityUIElement::ariaDropEffects):
3475         (AccessibilityUIElement::rangeForLine):
3476         (AccessibilityUIElement::rangeForPosition):
3477         (AccessibilityUIElement::boundsForRange):
3478         (AccessibilityUIElement::stringForRange):
3479         (AccessibilityUIElement::attributedStringForRange):
3480         (AccessibilityUIElement::uiElementForSearchPredicate):
3481         (AccessibilityUIElement::attributesOfColumnHeaders):
3482         (AccessibilityUIElement::attributesOfRowHeaders):
3483         (AccessibilityUIElement::attributesOfColumns):
3484         (AccessibilityUIElement::attributesOfRows):
3485         (AccessibilityUIElement::attributesOfVisibleCells):
3486         (AccessibilityUIElement::attributesOfHeader):
3487         (AccessibilityUIElement::rowIndexRange):
3488         (AccessibilityUIElement::columnIndexRange):
3489         (AccessibilityUIElement::cellForColumnAndRow):
3490         (AccessibilityUIElement::horizontalScrollbar):
3491         (AccessibilityUIElement::verticalScrollbar):
3492         (AccessibilityUIElement::pathDescription):
3493         (AccessibilityUIElement::selectedTextRange):
3494         (AccessibilityUIElement::url):
3495         (AccessibilityUIElement::textMarkerRangeForElement):
3496         (AccessibilityUIElement::textMarkerForIndex):
3497         (AccessibilityUIElement::previousTextMarker):
3498         (AccessibilityUIElement::nextTextMarker):
3499         (AccessibilityUIElement::stringForTextMarkerRange):
3500         (AccessibilityUIElement::textMarkerRangeForMarkers):
3501         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3502         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3503         (AccessibilityUIElement::endTextMarkerForBounds):
3504         (AccessibilityUIElement::startTextMarkerForBounds):
3505         (AccessibilityUIElement::textMarkerForPoint):
3506         (AccessibilityUIElement::accessibilityElementForTextMarker):
3507         (AccessibilityUIElement::startTextMarker):
3508         (AccessibilityUIElement::endTextMarker):
3509         (AccessibilityUIElement::supportedActions):
3510         (AccessibilityUIElement::mathPostscriptsDescription):
3511         (AccessibilityUIElement::mathPrescriptsDescription):
3512         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3513         (WTR::AccessibilityController::accessibleElementById):
3514         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3515         (WTR::AccessibilityUIElement::startTextMarker):
3516         (WTR::AccessibilityUIElement::endTextMarker):
3517         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3518         (WTR::findAccessibleObjectById):
3519         (WTR::AccessibilityController::accessibleElementById):
3520         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3521         (WTR::AccessibilityUIElement::childAtIndex):
3522         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3523         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3524         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3525         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3526         (WTR::AccessibilityUIElement::rowAtIndex):
3527         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3528         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3529         (WTR::AccessibilityUIElement::titleUIElement):
3530         (WTR::AccessibilityUIElement::parentElement):
3531         (WTR::AccessibilityUIElement::disclosedByRow):
3532         (WTR::AccessibilityUIElement::stringAttributeValue):
3533         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3534         (WTR::AccessibilityUIElement::role):
3535         (WTR::AccessibilityUIElement::subrole):
3536         (WTR::AccessibilityUIElement::roleDescription):
3537         (WTR::AccessibilityUIElement::title):
3538         (WTR::AccessibilityUIElement::description):
3539         (WTR::AccessibilityUIElement::orientation):
3540         (WTR::AccessibilityUIElement::stringValue):
3541         (WTR::AccessibilityUIElement::language):
3542         (WTR::AccessibilityUIElement::helpText):
3543         (WTR::AccessibilityUIElement::valueDescription):
3544         (WTR::AccessibilityUIElement::classList):
3545         (WTR::AccessibilityUIElement::speak):
3546         (WTR::AccessibilityUIElement::ariaDropEffects):
3547         (WTR::AccessibilityUIElement::rangeForLine):
3548         (WTR::AccessibilityUIElement::rangeForPosition):
3549         (WTR::AccessibilityUIElement::boundsForRange):
3550         (WTR::AccessibilityUIElement::stringForRange):
3551         (WTR::AccessibilityUIElement::attributedStringForRange):
3552         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3553         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3554         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3555         (WTR::AccessibilityUIElement::attributesOfColumns):
3556         (WTR::AccessibilityUIElement::attributesOfRows):
3557         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3558         (WTR::AccessibilityUIElement::attributesOfHeader):
3559         (WTR::AccessibilityUIElement::rowIndexRange):
3560         (WTR::AccessibilityUIElement::columnIndexRange):
3561         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3562         (WTR::AccessibilityUIElement::horizontalScrollbar):
3563         (WTR::AccessibilityUIElement::verticalScrollbar):
3564         (WTR::AccessibilityUIElement::selectedTextRange):
3565         (WTR::AccessibilityUIElement::url):
3566         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3567         (WTR::AccessibilityUIElement::previousTextMarker):
3568         (WTR::AccessibilityUIElement::nextTextMarker):
3569         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
3570         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3571         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3572         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3573         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3574         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3575         (WTR::AccessibilityUIElement::textMarkerForPoint):
3576         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3577         (WTR::AccessibilityUIElement::textMarkerForIndex):
3578         (WTR::AccessibilityUIElement::startTextMarker):
3579         (WTR::AccessibilityUIElement::endTextMarker):
3580         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3581         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3582         (WTR::AccessibilityUIElement::pathDescription):
3583         (WTR::AccessibilityUIElement::supportedActions):
3584
3585 2013-11-05  László Langó  <laszlo.lango@frontendart.com>
3586
3587         Remove leftover Qt related things from the flakiness_dashboard
3588         https://bugs.webkit.org/show_bug.cgi?id=123800
3589
3590         Reviewed by Anders Carlsson.
3591
3592         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3593         (test):
3594
3595 2013-11-05  Robert Plociennik  <r.plociennik@samsung.com>
3596
3597         [EFL] accessibility/svg-group-element-with-title.html is failing
3598         https://bugs.webkit.org/show_bug.cgi?id=114151
3599
3600         Reviewed by Mario Sanchez Prada.
3601
3602         atk_component_ref_accessible_at_point(), utilized in
3603         AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
3604         accessible child, if one exists, at the coordinate point specified' and not
3605         explicitly return self in case of lack of child elements. This contradicts with
3606         expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
3607         changed to return self regardless of coordinates specified, provided no child
3608         element could be retrieved, effectively mimicing the behaviour of equivalent
3609         Mac implementation in accessibilityHitTest().
3610
3611         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3612         (AccessibilityUIElement::elementAtPoint): Fixed.
3613         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3614         (WTR::AccessibilityUIElement::elementAtPoint): Fixed.
3615
3616 2013-11-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3617
3618         [CSS] Enable css-image-orientation on EFL and GTK ports.
3619         https://bugs.webkit.org/show_bug.cgi?id=123698
3620
3621         Reviewed by Beth Dakin.
3622
3623         r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
3624         when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
3625         and GTK ports by default.
3626