84ee72a6878b770d0d1ac07422bba0bee81882ea
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
2
3         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
4         https://bugs.webkit.org/show_bug.cgi?id=145938
5
6         Reviewed by Alexey Proskuryakov.
7
8         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
9         LWP::UserAgent to get access to more robust HTTPS support.
10
11 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
12
13         [GTK] Fix return type warning in WebViewTest.cpp
14         https://bugs.webkit.org/show_bug.cgi?id=145914
15
16         Reviewed by Darin Adler.
17
18         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
19         (WebViewTest::isEditable):
20
21 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
22
23         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
24         https://bugs.webkit.org/show_bug.cgi?id=145799
25
26         Reviewed by Carlos Garcia Campos.
27
28         Update header inclusions for headers that have been moved
29         to Source/WTF/wtf/glib/.
30
31         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
32         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
33
34         * TestWebKitAPI/PlatformGTK.cmake:
35         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
36         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
37         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
38         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
39         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
40         (TestWebKitAPI::GMainLoopSourceTest::finish):
41         (TestWebKitAPI::GMainLoopSourceTest::source):
42         (TestWebKitAPI::basicRescheduling):
43         (TestWebKitAPI::TEST):
44         (TestWebKitAPI::reentrantRescheduling):
45         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
46         (TestWebKitAPI::basicDestroyCallbacks):
47         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
48         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
49         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
50         (log):
51         (takeLogStr):
52         (TestWebKitAPI::TEST):
53         (TestWebKitAPI::returnOutChar):
54         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
55         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
56         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
57         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
58         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
59         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
60         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
61         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
62         (TestWebKitAPI::basicRescheduling): Deleted.
63         (TestWebKitAPI::TEST): Deleted.
64         (TestWebKitAPI::reentrantRescheduling): Deleted.
65         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
66         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
67         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
68         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
69         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
70         (log): Deleted.
71         (takeLogStr): Deleted.
72         (TestWebKitAPI::TEST): Deleted.
73         (TestWebKitAPI::returnOutChar): Deleted.
74         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
75         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
76         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
77         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
78         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
79         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
80         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
81         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
82         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
83         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
84         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
85         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
86         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
87         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
88         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
89         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
90         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
91         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
92         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
93         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
94         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
95         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
96         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
97         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
98         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
99         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
100         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
101         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
102         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
103         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
104         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
105         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
106         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
107         * WebKitTestRunner/InjectedBundle/TestRunner.h:
108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
109         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
110         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
111         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
112         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
113         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
114         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
115         * WebKitTestRunner/PlatformGTK.cmake:
116         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
117         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
118
119 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
120
121         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
122         https://bugs.webkit.org/show_bug.cgi?id=145913
123
124         Reviewed by Gyuyoung Kim.
125
126         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
127         (TestWebKitAPI::setupGeolocationProvider):
128         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
129         (TestWebKitAPI::setPageLoaderClient):
130         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
131         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
132         * WebKitTestRunner/GeolocationProviderMock.cpp:
133         (WTR::GeolocationProviderMock::GeolocationProviderMock):
134         * WebKitTestRunner/WebNotificationProvider.cpp:
135         (WTR::WebNotificationProvider::provider):
136
137 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
138
139         Fix the libusrsctp build with clang
140         https://bugs.webkit.org/show_bug.cgi?id=145128
141
142         Reviewed by Gyuyoung Kim.
143
144         * efl/jhbuild.modules:
145         * gtk/jhbuild.modules:
146
147 2015-06-11  Mark Lam  <mark.lam@apple.com>
148
149         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
150         https://bugs.webkit.org/show_bug.cgi?id=145872
151
152         Reviewed by Michael Saboff.
153
154         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
155         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
156         - Exercises the JSC ObjC API to call a function which throws an exception.  That
157           exception will be returned as a JSValue instead of an Exception object.  We
158           will use this JSValue to test WebCore::reportException() to confirm that it is
159           able to handle an exception value which is not an Exception object.
160
161 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
162
163         Move cursor to corner and fix safari window size before running benchmark
164         https://bugs.webkit.org/show_bug.cgi?id=145858
165
166         Reviewed by Ryosuke Niwa
167
168         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
169         (OSXBrowserDriver.prepareEnv):
170         (OSXBrowserDriver):
171         (OSXBrowserDriver.moveCursor):
172         (OSXBrowserDriver.getScreenSize):
173         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
174         (OSXChromeDriver.launchUrl):
175         (OSXChromeCanaryDriver.launchUrl):
176         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
177         (OSXFirefoxDriver.launchUrl):
178         (OSXFirefoxNightlyDriver.launchUrl):
179         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
180         (OSXSafariDriver.prepareEnv):
181         (OSXSafariDriver):
182         (OSXSafariDriver.maximizeWindow):
183
184 2015-06-11  Daniel Bates  <dabates@apple.com>
185
186         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
187         https://bugs.webkit.org/show_bug.cgi?id=145319
188
189         Reviewed by David Kilzer.
190
191         Add SPI wrapper header for CoreSimulator and update the source files to reference
192         it instead of directly referencing the CoreSimulator header.
193
194         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
195         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
196         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
197         * LayoutTestRelay/LayoutTestRelay/main.m:
198
199 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
200
201         [EFL] dimmed area for popup does not cover the fullscreen mode.
202         https://bugs.webkit.org/show_bug.cgi?id=145133
203
204         Reviewed by Gyuyoung Kim.
205
206         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
207         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
208
209         * MiniBrowser/efl/main.c:
210         (on_fullscreen_accept):
211         (on_fullscreen_deny):
212         (on_fullscreen_enter):
213
214 2015-06-10  Commit Queue  <commit-queue@webkit.org>
215
216         Unreviewed, rolling out r185442.
217         https://bugs.webkit.org/show_bug.cgi?id=145871
218
219         seems to have broken WTF.StringOperators test (Requested by
220         alexchristensen on #webkit).
221
222         Reverted changeset:
223
224         "[Content Extensions] Limit number of rules."
225         https://bugs.webkit.org/show_bug.cgi?id=145663
226         http://trac.webkit.org/changeset/185442
227
228 2015-06-10  Alex Christensen  <achristensen@webkit.org>
229
230         [Content Extensions] Make max NFA size and max rule count user defaults.
231         https://bugs.webkit.org/show_bug.cgi?id=145663
232         rdar://problem/21242407
233
234         Reviewed by Benjamin Poulain.
235
236         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
237         (TestWebKitAPI::TEST_F):
238
239 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
240
241         [EFL] Execute Javascript method in mini browser address bar.
242         https://bugs.webkit.org/show_bug.cgi?id=145725
243
244         Reviewed by Gyuyoung Kim.
245
246         Support 'javascript:' scheme in WebKit EFL Mini Browser.
247
248         * MiniBrowser/efl/main.c:
249         (url_from_user_input):
250         (url_load_from_user_input):
251         (on_url_bar_activated):
252         (elm_main):
253
254 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
255
256         Implement dumpProgressFinishedCallback() for Win layoutTestController.
257         https://bugs.webkit.org/show_bug.cgi?id=66773
258
259         Reviewed by Darin Adler.
260
261         * DumpRenderTree/win/FrameLoadDelegate.cpp:
262         * DumpRenderTree/win/FrameLoadDelegate.h:
263
264 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
265
266         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
267         https://bugs.webkit.org/show_bug.cgi?id=145764
268
269         Reviewed by Darin Adler.
270
271         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
272         JetStream and SunSpider.
273
274         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
275         (GenericBenchmarkBuilder):
276         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
277         the whole JSON as the input.
278         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
279         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
280         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
281         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
282         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
283         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
284         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
285
286 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
287
288         Remove ewstool scripts used by chromium port
289         https://bugs.webkit.org/show_bug.cgi?id=145789
290
291         Reviewed by Csaba Osztrogonác.
292
293         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
294         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
295         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
296         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
297         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
298
299 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
300
301         Unreviewed, updated my list of email addresses.
302
303         * Scripts/webkitpy/common/config/contributors.json:
304
305 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
306
307         [cmake] Fix the style issues in cmake project files
308         https://bugs.webkit.org/show_bug.cgi?id=145755
309
310         Reviewed by Darin Adler.
311
312         * TestWebKitAPI/CMakeLists.txt:
313         * TestWebKitAPI/PlatformEfl.cmake:
314
315 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
316
317         Fix a typo in r185345.
318
319         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
320         (OSXSafariDriver.closeBrowsers):
321
322 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
323
324         Yet another unreviewed build fix :(
325
326         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
327         (OSXSafariDriver):
328         (OSXSafariDriver.launchUrl):
329         (OSXSafariDriver.closeBrowsers):
330
331 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
332
333         Unreviewed build fix. Initialize result in the case things blow up below.
334
335         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
336         (BenchmarkRunner.execute):
337
338 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
339
340         Partially revert and fix after r185243.
341
342         * Scripts/benchmark_runner/benchmark_runner.py:
343         * Scripts/run-benchmark:
344
345 2015-06-08  Daniel Bates  <dabates@apple.com>
346
347         Many LayoutTests/http tests time out in DumpRenderTree
348         https://bugs.webkit.org/show_bug.cgi?id=145770
349         <rdar://problem/19593910>
350
351         Reviewed by Alexey Proskuryakov.
352
353         * DumpRenderTree/ios/Info.plist: Add ATS key.
354         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
355         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
356         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
357         that make use of testRunner.pathToLocalResource().
358
359 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
360
361         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
362         https://bugs.webkit.org/show_bug.cgi?id=145759
363
364         Reviewed by Carlos Garcia Campos.
365
366         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
367         (testWebViewSave):
368
369 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
370
371         [GTK] Add editor mode to MiniBrowser
372         https://bugs.webkit.org/show_bug.cgi?id=145595
373
374         Reviewed by Sergio Villar Senin.
375
376         It loads an empty editable web view with an edit toolbar. It makes
377         easier to test the editor, editing commands and input methods.
378
379         * MiniBrowser/gtk/BrowserWindow.c:
380         (editingCommandCallback):
381         (browserWindowSetupEditorToolbar):
382         (browserWindowConstructed):
383         * MiniBrowser/gtk/main.c:
384         (createBrowserWindow):
385
386 2015-06-05  Zalan Bujtas  <zalan@apple.com>
387
388         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
389
390         Reviewed by Dan Bernstein.
391
392         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
393         (TestWebKitAPI::TEST):
394
395 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
396
397         [EFL] API test has been broken since r184357
398         https://bugs.webkit.org/show_bug.cgi?id=145635
399
400         Reviewed by Darin Adler.
401
402         r184357 suppress cmake build warning using TARGET_FILE property. However
403         many EFL API test cases have been broken after applying it.
404
405         * TestWebKitAPI/CMakeLists.txt:
406
407 2015-06-05  Anders Carlsson  <andersca@apple.com>
408
409         Make the network cache directory part of WKContextConfigurationRef
410         https://bugs.webkit.org/show_bug.cgi?id=145711
411
412         Reviewed by Antti Koivisto.
413
414         * WebKitTestRunner/TestController.cpp:
415         (WTR::TestController::initialize):
416
417 2015-06-05  Anders Carlsson  <andersca@apple.com>
418
419         Make the application cache directory part of WKContextConfigurationRef
420         https://bugs.webkit.org/show_bug.cgi?id=145704
421
422         Reviewed by Geoffrey Garen.
423
424         * WebKitTestRunner/TestController.cpp:
425         (WTR::TestController::initialize):
426
427 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
428
429         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
430         https://bugs.webkit.org/show_bug.cgi?id=145680
431
432         Reviewed by Brent Fulgham.
433
434         * Scripts/webkitpy/style/checkers/cpp.py:
435         (check_for_null):
436         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
437         (WebKitStyleTest.test_null_false_zero):
438
439 2015-06-05  Stephanie Lewis  <slewis@apple.com>
440
441         Make the web server more robust to timing issues..
442
443         Reviewed by Ryosuke Niwa.
444
445         Cleaned up exception handling.
446         Test server is actually serving pages before returning.
447         Clean up some style issues.
448
449         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
450         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
451         (SimpleHTTPServerDriver.__init__):
452         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
453         (SimpleHTTPServerDriver.baseUrl): 
454         (SimpleHTTPServerDriver.fetchResult):
455         (SimpleHTTPServerDriver.killServer):
456         (SimpleHTTPServerDriver.getReturnCode):
457
458 2015-06-05  Stephanie Lewis  <slewis@apple.com>
459
460
461         Add errors to run-benchmark exception handling.
462
463         Reviewed by Ryosuke Niwa.
464
465         * Scripts/run-benchmark:
466         (main):
467         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
468         (GenericBenchmarkBuilder.prepare):
469         (GenericBenchmarkBuilder._runCreateScript):
470         (GenericBenchmarkBuilder._applyPatch):
471         (GenericBenchmarkBuilder.clean):
472         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
473         (BenchmarkRunner.__init__):
474         (BenchmarkRunner.execute):
475         (BenchmarkRunner):
476         (BenchmarkRunner.cleanup):
477         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
478         (GenericFactory.iterateGetItem):
479         (GenericFactory.create):
480         * Scripts/webkitpy/benchmark_runner/utils.py:
481         (loadModule):
482         (loadJSONFromFile):
483         (forceRemove):
484
485 2015-06-05  Stephanie Lewis  <slewis@apple.com>
486
487         Streamline run-benchmark browser
488
489         Reviewed by Ryosuke Niwa.
490
491         Add Caffeinate so computer won't sleep while running.
492         Remove calls to collect output since we were just dumping to stdout anyway.
493         Add xpc dyld_path.
494         Default to system safari.
495
496         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
497         (OSXBrowserDriver.launchProcess):
498         (OSXBrowserDriver.terminateProcesses):
499         (OSXBrowserDriver):
500         (OSXBrowserDriver.launchCaffeinateForProcess):
501         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
502         (OSXSafariDriver.launchUrl):
503         (OSXSafariDriver.closeBrowsers):
504
505 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
506
507         Combine tiny DFAs into slightly larger ones
508         https://bugs.webkit.org/show_bug.cgi?id=145572
509
510         Reviewed by Alex Christensen.
511
512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
513         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
514         (TestWebKitAPI::DFACombinerTest::SetUp):
515         (TestWebKitAPI::combine):
516         (TestWebKitAPI::TEST_F):
517         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
518         (TestWebKitAPI::countLiveNodes):
519         (TestWebKitAPI::createNFAs):
520         (TestWebKitAPI::buildDFAFromPatterns):
521         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
522         (TestWebKitAPI::countLiveNodes): Deleted.
523         (TestWebKitAPI::createNFAs): Deleted.
524         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
525
526 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
527
528         WebKitTestRunner leaks strings in generateWhitelist()
529         https://bugs.webkit.org/show_bug.cgi?id=145665
530
531         Reviewed by Myles C. Maxfield.
532
533         * WebKitTestRunner/mac/TestControllerMac.mm:
534         (WTR::generateWhitelist):
535
536 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
537
538         Fix options in build-jsc for CMake builds
539         https://bugs.webkit.org/show_bug.cgi?id=145636
540
541         Reviewed by Gyuyoung Kim.
542
543         CMake only accepts -DXXX=YYY style options.
544         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
545
546         * Scripts/build-jsc:
547
548 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
549
550         Added a patch so that the colors displayed on the page could be toggled
551         in case people need accessibility colors displayed in their browser.
552         https://bugs.webkit.org/show_bug.cgi?id=145570
553         <rdar://problem/20994468>
554
555         Added in CSS colors and toggle buttons for checkmarks in the page, so that
556         the page could be rendered in a specific way for accessibility needs if needed.
557
558         Reviewed by Alexey Proskuryakov.
559
560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
561         (updateHiddenPlatforms):
562         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
563         (toggleAccessibilityColors): Toggle colors on and off
564         (documentReady): Needed to make changes to the initialization
565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
566         (a:hover):
567         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
568         (div.cellButton.hide, div.accessibilityButton.hide):
569         (div.cellButton.unhide, div.accessibilityButton.unhide):
570         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
571         (.popover-tracking:hover):
572         (.accessibilityButton):
573         (div.cellButton): Deleted.
574         (div.cellButton.hide): Deleted.
575         (div.cellButton.unhide): Deleted.
576         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
578         (.status-line.neutral .bubble):
579         (.status-line.unauthorized .bubble):
580         (.status-line.danger .bubble.pictogram):
581         (.status-line.bad .bubble.pictogram):
582         (.status-line.no-bubble .message):
583         (.status-line.bad .bubble):
584         (.status-line.good .bubble):
585         (.status-line.good .message):
586         (.status-line.bad .message):
587         (body.accessibility-colors .status-line.good .bubble):
588         (body.accessibility-colors .status-line.bad .bubble):
589         (body.accessibility-colors .status-line.good .message):
590         (body.accessibility-colors .status-line.bad .message):
591         (.status-line.danger .message):
592         (.status-line.unauthorized .message):
593
594 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
595
596         Unreviewed build fix for Dromaeo.
597
598         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
599         (BenchmarkResults._aggregate_results_for_test):
600
601 2015-06-03  Anders Carlsson  <andersca@apple.com>
602
603         Fix build.
604
605         * DumpRenderTree/mac/TestRunnerMac.mm:
606
607 2015-06-03  Daniel Bates  <dabates@apple.com>
608
609         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
610         https://bugs.webkit.org/show_bug.cgi?id=145616
611
612         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
613         of the test. Further investigation is needed.
614
615         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
616         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
617
618 2015-06-03  Brady Eidson  <beidson@apple.com>
619
620         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
621         https://bugs.webkit.org/show_bug.cgi?id=145580
622
623         Reviewed by Mark Lam.
624
625         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
626         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
627
628 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
629
630         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
631
632         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
633         (TestWebKitAPI::TEST): Update the syntax.
634
635 2015-06-02  Mark Lam  <mark.lam@apple.com>
636
637         build-jsc's --cloop option is broken.
638         https://bugs.webkit.org/show_bug.cgi?id=145516
639
640         Reviewed by Darin Adler.
641
642         * Scripts/build-jsc:
643         - Make sure to disable the JIT when --cloop is specified.
644           Did analogous fix for --ftljit.
645
646 2015-06-02  Daniel Bates  <dabates@apple.com>
647
648         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
649
650         Rubber-stamped by Alexey Proskuryakov.
651
652         * MiniBrowser/mac/Info.plist:
653         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
654
655 2015-06-01  Commit Queue  <commit-queue@webkit.org>
656
657         Unreviewed, rolling out r185066.
658         https://bugs.webkit.org/show_bug.cgi?id=145543
659
660         it breaks the FTL JIT builds with a local checkout of llvm
661         (Requested by pizlo on #webkit).
662
663         Reverted changeset:
664
665         "build-jsc's --cloop option is broken."
666         https://bugs.webkit.org/show_bug.cgi?id=145516
667         http://trac.webkit.org/changeset/185066
668
669 2015-06-01  Daniel Bates  <dabates@apple.com>
670
671         Notify client that we began editing when text field is focused
672         https://bugs.webkit.org/show_bug.cgi?id=145439
673         <rdar://problem/21142108>
674
675         Reviewed by Anders Carlsson.
676
677         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
678         a text field is focused and defocused.
679
680         * TestWebKitAPI/CMakeLists.txt:
681         * TestWebKitAPI/PlatformEfl.cmake:
682         * TestWebKitAPI/PlatformGTK.cmake:
683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
684         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
685         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
686         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
687         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
688         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
689         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
690         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
691         (TestWebKitAPI::TEST_F):
692         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
693         (TestWebKitAPI::textFieldDidBeginEditing):
694         (TestWebKitAPI::textFieldDidEndEditing):
695         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
696         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
697         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
698
699 2015-06-01  Alex Christensen  <achristensen@webkit.org>
700
701         [Content Extensions] resource-type and load-type should be independent.
702         https://bugs.webkit.org/show_bug.cgi?id=145528
703         rdar://problem/21190765
704
705         Reviewed by Benjamin Poulain.
706
707         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
708         (TestWebKitAPI::TEST_F):
709
710 2015-06-01  Daniel Bates  <dabates@apple.com>
711
712         Add ATS keys to WebKitTestRunnerApp
713         https://bugs.webkit.org/show_bug.cgi?id=145519
714
715         Reviewed by Alexey Proskuryakov.
716
717         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
718
719         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
720
721 2015-06-01  Brady Eidson  <beidson@apple.com>
722
723         Add WKTR support for "should open external URLs".
724         https://bugs.webkit.org/show_bug.cgi?id=145505
725
726         Reviewed by Darin Adler.
727
728         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
729           "should open external URLs" bit set.
730         
731         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
732           the policy delegate, including whether or not the bit was set.
733         
734         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
735         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
736         (WTR::TestRunner::queueLoad):
737         * WebKitTestRunner/InjectedBundle/TestRunner.h:
738         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
739         (WTR::TestRunner::shouldDumpPolicyCallbacks):
740         
741         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
742         (WTR::InjectedBundle::queueLoad):
743         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
744
745         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
746         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
747
748         * WebKitTestRunner/TestInvocation.cpp:
749         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
750
751         * WebKitTestRunner/WorkQueueManager.cpp:
752         (WTR::WorkQueueManager::queueLoad):
753         * WebKitTestRunner/WorkQueueManager.h:
754
755 2015-06-01  Mark Lam  <mark.lam@apple.com>
756
757         build-jsc's --cloop option is broken.
758         https://bugs.webkit.org/show_bug.cgi?id=145516
759
760         Reviewed by Darin Adler.
761
762         * Scripts/build-jsc:
763         - Make sure to disable the JIT when --cloop is specified.
764           Did analogous fix for --ftljit.
765
766 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
767
768         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
769         https://bugs.webkit.org/show_bug.cgi?id=144959
770
771         Reviewed by Darin Adler.
772
773         * Scripts/webkitpy/style/checkers/cmake.py:
774         (CMakeChecker.check): Use enumerate instead of xrange.
775         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
776         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
777         (CMakeCheckerTest.test_check): Update the expected results.
778
779 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
780
781         Fix the webkitpy scm unittests after r174051
782         https://bugs.webkit.org/show_bug.cgi?id=145511
783
784         Reviewed by Darin Adler.
785
786         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
787         (GitTestWithMock.make_scm):
788
789 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
790
791         EWS provides misleading information for not applyable patches
792         https://bugs.webkit.org/show_bug.cgi?id=145307
793
794         Reviewed by Alexey Proskuryakov.
795
796         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
797
798 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
799
800         Further tweak results of WebKit1.StringTruncator after r184965.
801
802         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
803
804 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
805
806         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
807         https://bugs.webkit.org/show_bug.cgi?id=145264
808
809         Reviewed by Carlos Garcia Campos.
810
811         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
812
813 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
814
815         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
816
817         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
818         (BenchmarkResults._lint_subtest_results):
819         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
820         (test_aggregate_nested_results):
821         (test_lint_results):
822         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
823
824 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
825
826         run-benchmark should print out the results
827         https://bugs.webkit.org/show_bug.cgi?id=145398
828
829         Reviewed by Antti Koivisto.
830
831         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
832         of the output to catch early errors.
833
834         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
835         (BenchmarkResults): Added.
836         (BenchmarkResults.__init__): Added.
837         (BenchmarkResults.format): Added.
838         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
839         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
840         Uses the sample standard deviation to compute the significant figures for the value.
841         (BenchmarkResults._unit_from_metric): Added.
842         (BenchmarkResults._aggregate_results): Added.
843         (BenchmarkResults._aggregate_results_for_test): Added.
844         (BenchmarkResults._flatten_list): Added.
845         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
846         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
847         (BenchmarkResults._aggregate_values): Added.
848         (BenchmarkResults._lint_results): Added.
849         (BenchmarkResults._lint_subtest_results): Added.
850         (BenchmarkResults._lint_aggregator_list): Added.
851         (BenchmarkResults._lint_configuration): Added.
852         (BenchmarkResults._lint_values): Added.
853         (BenchmarkResults._is_numeric): Added.
854         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
855         (BenchmarkResultsTest):
856         (BenchmarkResultsTest.test_init):
857         (BenchmarkResultsTest.test_format):
858         (test_format_values_with_large_error):
859         (test_format_values_with_small_error):
860         (test_format_values_with_time):
861         (test_format_values_with_no_error):
862         (test_format_values_with_small_difference):
863         (test_aggregate_results):
864         (test_aggregate_results_with_gropus):
865         (test_aggregate_nested_results):
866         (test_lint_results):
867         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
868         (BenchmarkRunner.execute): Added a call to show_results
869         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
870         (BenchmarkRunner.show_results): Added.
871
872 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
873
874         run_benchmark should have an option to specify the number of runs
875         https://bugs.webkit.org/show_bug.cgi?id=145091
876
877         Reviewed by Antti Koivisto.
878
879         Added --count option.
880
881         * Scripts/run-benchmark:
882         (main):
883         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
884         (BenchmarkRunner.__init__):
885
886 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
887
888         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
889
890         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
891
892 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
893
894         Update results of WebKit1.StringTruncator after r184965.
895
896         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
897
898 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
899
900         Unreviewed, updated my list of email addresses.
901
902         * Scripts/webkitpy/common/config/contributors.json:
903
904 2015-05-27  Dean Jackson  <dino@apple.com>
905
906         img.currentSrc problem in strict mode with old picturefill
907         https://bugs.webkit.org/show_bug.cgi?id=144095
908         <rdar://problem/21087013>
909
910         Reviewed by Simon Fraser.
911
912         Add a PICTURE_SIZES flag.
913
914         * Scripts/webkitperl/FeatureList.pm:
915
916 2015-05-26  Dana Burkart  <dburkart@apple.com>
917
918         Fixes compatibility issues with recent dashboard cleanup.
919         https://bugs.webkit.org/show_bug.cgi?id=144814
920
921         Reviewed by Alexey Proskuryakov.
922
923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
924         (BuildbotStaticAnalyzerQueueView):
925         (BuildbotStaticAnalyzerQueueView.prototype.update):
926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
927         (documentReady):
928
929 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
930
931         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
932         https://bugs.webkit.org/show_bug.cgi?id=143091
933         rdar://problem/19330328
934
935         Reviewed by Darin Adler and Timothy Hatcher.
936
937         We have many of these, which are hard to fit on the dashboard. Added a view that
938         collapses to a single green bubble when everything is good, and expands when there
939         are failures (or manually).
940
941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
942
943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
944         (Buildbot.prototype.set isAuthenticated):
945         (Buildbot.prototype._normalizeQueueInfo):
946         (Buildbot.prototype._normalizeQueuesInfo):
947         (Buildbot.prototype.updateQueues):
948         Moved queue info normalization here from BuildbitQueue. The latter is a model class
949         that shouldn't have to know about presentation, and this lets us leep the knowledge
950         about combined queues out if it. Later, we can refactor existing code, and move out
951         all knowledge about headings and such.
952
953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
954         Added the new view. It's not quite universal, and doesn't have as helpful popovers
955         as other views, but we can extend it when/if we use it for more than JSC.
956
957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
958         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
959
960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
961         (documentReady): Added support for combined queues. These are currently always ending up
962         in Other column, but it's easy to customize in the future if we need to.
963
964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
965         (WebKitBuildbot): Added JSC queus.
966
967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
968         (.combined-queue-popover):
969         (.combined-queue-popover .revision):
970         Added styles for the combined view.
971
972 2015-05-26  Dan Bernstein  <mitz@apple.com>
973
974         Changed a file to use Unix line endings.
975
976         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
977
978 2015-05-26  Dan Bernstein  <mitz@apple.com>
979
980         <rdar://problem/21104551> Update build settings
981
982         Reviewed by Anders Carlsson.
983
984         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
985         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
986         * MiniBrowser/Configurations/DebugRelease.xcconfig:
987         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
988         * WebEditingTester/Configurations/DebugRelease.xcconfig:
989         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
990         * asan/asan.xcconfig:
991
992 2015-05-26  Anders Carlsson  <andersca@apple.com>
993
994         Fix build.
995
996         * WebKitTestRunner/mac/EventSenderProxy.mm:
997         (WTR::EventSenderProxy::mouseForceDown):
998         (WTR::EventSenderProxy::mouseForceUp):
999         (WTR::EventSenderProxy::mouseForceChanged):
1000
1001 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1002
1003         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
1004         https://bugs.webkit.org/show_bug.cgi?id=145342
1005
1006         Reviewed by Darin Adler.
1007
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1009         (BuildbotIteration.prototype._parseData):
1010
1011 2015-05-26  Milan Crha  <mcrha@redhat.com>
1012
1013         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
1014         https://bugs.webkit.org/show_bug.cgi?id=138134
1015
1016         Reviewed by Žan Doberšek.
1017
1018         * gtk/generate-inspector-gresource-manifest.py:
1019         (get_filenames): Command line with expanded resources exceeds 32KB, which
1020         is a limit on Windows. It's better to expand wildcards inside the python script.
1021
1022 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1023
1024         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
1025         https://bugs.webkit.org/show_bug.cgi?id=140882
1026
1027         Reviewed by Gustavo Noronha Silva.
1028
1029         Make sure unit tests write IndexedDB databases to the temporary
1030         directory, and add a test case to check that the directory is
1031         correctly created at the expected path.
1032
1033         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1034         (testWebContextConfiguration):
1035         (serverCallback):
1036         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1037         (Test::Test):
1038
1039 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1040
1041         [GTK] Enable IndexedDB
1042         https://bugs.webkit.org/show_bug.cgi?id=98932
1043
1044         Reviewed by Žan Doberšek.
1045
1046         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1047
1048 2015-05-24  Sam Weinig  <sam@webkit.org>
1049
1050         Crash when using a removed ScriptMessageHandler
1051         <rdar://problem/20888499>
1052         https://bugs.webkit.org/show_bug.cgi?id=145359
1053
1054         Reviewed by Dan Bernstein.
1055
1056         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1057         Add tests for removing script message handlers.
1058
1059 2015-05-23  Dan Bernstein  <mitz@apple.com>
1060
1061         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
1062         https://bugs.webkit.org/show_bug.cgi?id=145345
1063
1064         Reviewed by Sam Weinig.
1065
1066         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1067         * LayoutTestRelay/Configurations/Base.xcconfig:
1068         * TestWebKitAPI/Configurations/Base.xcconfig:
1069         * WebKitTestRunner/Configurations/Base.xcconfig:
1070
1071 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1072
1073         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
1074         https://bugs.webkit.org/show_bug.cgi?id=144848
1075
1076         Reviewed by Darin Adler.
1077
1078         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
1079
1080         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1081
1082 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1083
1084         Fix one more merge error in static analyzer support.
1085
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1087         (BuildbotStaticAnalyzerQueueView):
1088
1089 2015-05-22  Dana Burkart  <dburkart@apple.com>
1090
1091         Fix internal dashboard breakage from recent commit.
1092         https://bugs.webkit.org/show_bug.cgi?id=144814
1093
1094         Unreviewed build fix.
1095
1096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1097         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
1098         (BuildbotStaticAnalyzerQueueView.prototype.update):
1099
1100 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1101
1102         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
1103         https://bugs.webkit.org/show_bug.cgi?id=130463
1104         rdar://problem/20461342
1105
1106         Reviewed by Tim Horton.
1107
1108         This was more of a timing related flakiness than an actual OS version specific bug,
1109         we weren't getting window visibility notifications.
1110         
1111         I will look into adding this function call to DumpRenderTree separately, layout tests
1112         might actually rely on the broken behavior.
1113
1114         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1115         (TestWebKitAPI::TEST_F):
1116         * TestWebKitAPI/mac/mainMac.mm:
1117         (main):
1118
1119 2015-05-22  Dana Burkart  <dburkart@apple.com>
1120
1121         Add missing file from r184804 (mis-applied diff).
1122         https://bugs.webkit.org/show_bug.cgi?id=144814
1123
1124         Reviewed by Alexey Proskuryakov.
1125
1126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
1127         (BuildbotStaticAnalyzerQueueView):
1128         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
1129         (BuildbotStaticAnalyzerQueueView.prototype.update):
1130
1131 2015-05-22  Dana Burkart  <dburkart@apple.com>
1132
1133         Add support to the botwatchers dashboard for a static analyzer bot.
1134         https://bugs.webkit.org/show_bug.cgi?id=144814
1135
1136         Reviewed by Alexey Proskuryakov.
1137
1138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1139         scan-build should be considered a productive step.
1140
1141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1142         (BuildbotQueue):
1143         Adds support for the staticAnalyzer property
1144
1145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1146         (BuildbotTestResults.prototype._parseResults):
1147         Get bug count from the scan-build step output
1148
1149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1150         (documentReady):
1151         Rename the performance column 'Other', and merge the current 'Other' column with it.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1154         (WebKitBuildbot):
1155         Now that performance bots are part of the 'Other' column, give them better headings.
1156
1157 2015-05-22  Tim Horton  <timothy_horton@apple.com>
1158
1159         Turn on autosaving of toolbar configuration in MiniBrowser
1160
1161         Rubber-stamped by Dan Bernstein.
1162
1163         * MiniBrowser/mac/BrowserWindow.xib:
1164
1165 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1166
1167         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
1168         https://bugs.webkit.org/show_bug.cgi?id=145297
1169
1170         Reviewed by Tim Horton.
1171
1172         This is a refactoring to simplify code, and to make it more logical.
1173
1174         It is up to the view to decide how to present the queues, and whether to split
1175         them into debug and release, or in some different way.
1176
1177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1178         (BuildbotBuilderQueueView.filterQueues):
1179         (BuildbotBuilderQueueView):
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1181         (BuildbotLeaksQueueView):
1182         (BuildbotLeaksQueueView.prototype.update):
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1184         (BuildbotPerformanceQueueView):
1185         (BuildbotPerformanceQueueView.prototype.update):
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1187         (BuildbotQueueView):
1188         (BuildbotQueueView.prototype._updateQueues):
1189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1190         (BuildbotTesterQueueView):
1191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1192         (documentReady):
1193
1194 2015-05-22  Tim Horton  <timothy_horton@apple.com>
1195
1196         Remove action menu support
1197         https://bugs.webkit.org/show_bug.cgi?id=145305
1198         <rdar://problem/21070771>
1199
1200         Reviewed by Anders Carlsson.
1201
1202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1203         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
1204         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
1205         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
1206         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
1207         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
1208         Remove the tests.
1209
1210 2015-05-22  Dan Bernstein  <mitz@apple.com>
1211
1212         Removed the Use Shrink To Fit button from the toolbar’s default set.
1213
1214         Rubber-stamped by Tim Horton.
1215
1216         * MiniBrowser/mac/BrowserWindow.xib:
1217
1218 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
1219
1220         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
1221         https://bugs.webkit.org/show_bug.cgi?id=128420
1222
1223         Reviewed by Chris Fleizach.
1224
1225         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1226         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
1227
1228 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
1229
1230         [EFL] Bump libsoup version to 2.50.0
1231         https://bugs.webkit.org/show_bug.cgi?id=145127
1232
1233         Reviewed by Gyuyoung Kim.
1234
1235         * efl/jhbuild.modules:
1236         * efl/patches/soup-clang-warning-fix1.patch: Removed.
1237         * efl/patches/soup-clang-warning-fix2.patch: Removed.
1238
1239 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
1240
1241         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
1242         https://bugs.webkit.org/show_bug.cgi?id=145117
1243
1244         Reviewed by Csaba Osztrogonác.
1245
1246         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
1247         Tools/TestWebKitAPI/Tests/WTF/glib/.
1248
1249         * TestWebKitAPI/PlatformGTK.cmake:
1250         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
1251         (TestWebKitAPI::TEST):
1252
1253 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
1254
1255         [EFL] fix efreet error
1256         https://bugs.webkit.org/show_bug.cgi?id=143670
1257
1258         Reviewed by Gyuyoung Kim.
1259
1260         Fix efreet error by using external variable efreet_cache_update.
1261         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
1262         efreet error for efreet_cache does not occur.
1263
1264         * MiniBrowser/efl/main.c:
1265         (elm_main):
1266
1267 2015-05-20  Michael Saboff  <msaboff@apple.com>
1268
1269         Add option to run_jsc_stress_tests to disable JIT testing
1270         https://bugs.webkit.org/show_bug.cgi?id=145233
1271
1272         Reviewed by Mark Lam.
1273
1274         Added --no-jit option.
1275
1276         * Scripts/run-jsc-stress-tests:
1277
1278 2015-05-20  Alex Christensen  <achristensen@webkit.org>
1279
1280         Use correct String for StringView in WTF API tests
1281         https://bugs.webkit.org/show_bug.cgi?id=145226
1282         rdar://problem/20361786
1283
1284         Reviewed by Benjamin Poulain.
1285
1286         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1287         (TestWebKitAPI::TEST):
1288         Use patternHolder for pattern.
1289
1290 2015-05-20  Alex Christensen  <achristensen@webkit.org>
1291
1292         [Content Extensions] Relax restrictions on triggers that match everything.
1293         https://bugs.webkit.org/show_bug.cgi?id=145069
1294
1295         Reviewed by Benjamin Poulain.
1296
1297         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1298         (TestWebKitAPI::TEST_F):
1299         Update and add tests for new possibilities with .*
1300
1301 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
1302
1303         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
1304         https://bugs.webkit.org/show_bug.cgi?id=144992
1305
1306         Reviewed by Gyuyoung Kim.
1307
1308         * MiniBrowser/efl/main.c:
1309         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
1310         (on_key_down):
1311         (on_fullscreen_enter):
1312         (on_fullscreen_exit):
1313         (window_create):
1314
1315 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1316
1317         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
1318         https://bugs.webkit.org/show_bug.cgi?id=145109
1319
1320         Reviewed by Darin Adler.
1321
1322         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1323         (TestWebKitAPI::TEST):
1324
1325 2015-05-19  Anders Carlsson  <andersca@apple.com>
1326
1327         Add alternate menu items for performing operations on the default data store
1328         https://bugs.webkit.org/show_bug.cgi?id=145184
1329
1330         Reviewed by Sam Weinig.
1331
1332         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
1333         associated with a data store.
1334
1335         * MiniBrowser/mac/AppDelegate.m:
1336         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
1337         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
1338         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
1339         * MiniBrowser/mac/MainMenu.xib:
1340
1341 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1342
1343         Fix tautological-compare warning in AtomicString.cpp
1344         https://bugs.webkit.org/show_bug.cgi?id=145120
1345
1346         Reviewed by Alexey Proskuryakov.
1347
1348         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1349         (TestWebKitAPI::TEST): Removed always true assert.
1350
1351 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
1352
1353         [EFL] Fix unsequenced warning in MiniBrowser's main.c
1354         https://bugs.webkit.org/show_bug.cgi?id=145123
1355
1356         Reviewed by Gyuyoung Kim.
1357
1358         * MiniBrowser/efl/main.c:
1359         (on_key_down):
1360
1361 2015-05-18  Daniel Bates  <dabates@apple.com>
1362
1363         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
1364         when staged non-empty file for commit
1365         https://bugs.webkit.org/show_bug.cgi?id=145082
1366
1367         Reviewed by Darin Adler.
1368
1369         Fixes two issues when running prepare-ChangeLog:
1370             1. The function above a deleted function is reported as changed.
1371             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
1372             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
1373             included in this patch).
1374
1375         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
1376         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
1377         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
1378         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
1379         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
1380         VCSUtil::parseChunkRange() has existing test coverage.
1381
1382         * Scripts/prepare-ChangeLog:
1383         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
1384         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
1385         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
1386         examine files that only have deletions. Currently this works as a side effect of the behavior of
1387         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
1388         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
1389         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
1390         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
1391         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1392         We return (-1, -1) when the change represents a deletion.
1393         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
1394         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1395         We return (-1, -1) when the change represents an addition.
1396         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
1397         unit tests.
1398
1399 2015-05-18  Anders Carlsson  <andersca@apple.com>
1400
1401         Add ATS keys to MiniBrowser
1402         https://bugs.webkit.org/show_bug.cgi?id=145141
1403
1404         Reviewed by Sam Weinig.
1405
1406         * MiniBrowser/mac/Info.plist:
1407
1408 2015-05-17  David Kilzer  <ddkilzer@apple.com>
1409
1410         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
1411         <http://webkit.org/b/145100>
1412
1413         Reviewed by Darin Adler.
1414
1415         * Scripts/bisect-builds:
1416         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
1417         - Switch to using PROMPT_RESPONSE_* constants when testing the
1418           value of $didReproduceBug.
1419         - Add do { } while loops to implement 'retry' mode.
1420         (promptForTest):
1421         - Switch to returning PROMPT_RESPONSE_* constants.
1422         - Add support for 'retry' response.
1423
1424 2015-05-16  Tanay C  <tanay.c@samsung.com>
1425
1426         [EFL][WK2] Minibrowser : Add search icon to search bar
1427         https://bugs.webkit.org/show_bug.cgi?id=139773
1428
1429         Reviewed by Gyuyoung Kim.
1430
1431         * MiniBrowser/efl/main.c: 
1432         (search_icon_show): Added.
1433         (search_box_show): Modified.
1434
1435 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1436
1437         run_benchmark should have an option to specify the number of runs
1438         https://bugs.webkit.org/show_bug.cgi?id=145091
1439
1440         Reviewed by Stephanie Lewis.
1441
1442         Added --count option.
1443
1444         * Scripts/run-benchmark:
1445         (main):
1446         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1447         (BenchmarkRunner.__init__):
1448
1449 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
1450
1451         Temporarily disable failing API test.
1452
1453         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1454         (TestWebKitAPI::TEST):
1455
1456 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
1457
1458         User interruption while running of run-webkit-tests should also generate results.html
1459         https://bugs.webkit.org/show_bug.cgi?id=122154
1460
1461         Reviewed by Csaba Osztrogonác.
1462
1463         Generation of results.html on execution of run-webkit-tests happens only
1464         on completion of entire layout tests run. It should be created even when
1465         the execution has been interrupted - either by user (by pressing Ctrl+C)
1466         or because of other interruptions (like exit-after-n-failures option).
1467
1468         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1469         (LayoutTestRunner.run_tests):
1470         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1471         (Manager.run):
1472         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1473         (TestRunResults.__init__):
1474         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1475         (main):
1476         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1477         (RunTest.test_keyboard_interrupt):
1478         (MainTest.test_exception_handling):
1479
1480 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
1481
1482         [buildbot] Fix the URL of the performance bots
1483         https://bugs.webkit.org/show_bug.cgi?id=145043
1484
1485         Reviewed by Ryosuke Niwa.
1486
1487         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1488
1489 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
1490
1491         Add a layout mode that scales down the view to try to fit the document
1492         https://bugs.webkit.org/show_bug.cgi?id=145022
1493         <rdar://problem/19790341>
1494
1495         Reviewed by Dean Jackson.
1496
1497         * MiniBrowser/mac/BrowserWindow.xib:
1498         * MiniBrowser/mac/BrowserWindowController.h:
1499         * MiniBrowser/mac/WK2BrowserWindowController.m:
1500         (-[WK2BrowserWindowController toggleShrinkToFit:]):
1501         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
1502         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
1503
1504 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
1505
1506         [CMake] Don't read the LOCATION property of targets
1507         https://bugs.webkit.org/show_bug.cgi?id=145018
1508
1509         Reviewed by Martin Robinson.
1510
1511         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
1512         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
1513         be the same at configure-time as it is at generate-time.
1514
1515         * TestWebKitAPI/CMakeLists.txt:
1516
1517 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
1518
1519         Add String literal overloads to equalIgnoringASCIICase()
1520         https://bugs.webkit.org/show_bug.cgi?id=145008
1521
1522         Reviewed by Benjamin Poulain.
1523
1524         Test changes to WTF.
1525
1526         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1527         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
1528         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1529         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1530         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
1531         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1532
1533 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1534
1535         SharedBuffer::createWithContentsOfFile should use map file routines
1536         https://bugs.webkit.org/show_bug.cgi?id=144192
1537
1538         Reviewed by Darin Adler.
1539
1540         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
1541
1542         * TestWebKitAPI/PlatformGTK.cmake:
1543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1544         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
1545         (TestWebKitAPI::FileSystemTest::tempFilePath):
1546         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
1547         (TestWebKitAPI::TEST_F):
1548         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
1549         (TestWebKitAPI::SharedBufferTest::tempFilePath):
1550         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
1551         (TestWebKitAPI::TEST_F):
1552
1553 2015-05-13  Alex Christensen  <achristensen@webkit.org>
1554
1555         [Content Extensions] Test interactions between multiple extensions and multiple domains.
1556         https://bugs.webkit.org/show_bug.cgi?id=144967
1557
1558         Reviewed by Benjamin Poulain.
1559
1560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1561         Xcode wanted to fix an alphabetization issue.
1562         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1563         (TestWebKitAPI::TEST_F):
1564         Test interactions that worked but were not explicitly tested before.
1565
1566 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1567
1568         Unreviewed build fix.
1569
1570         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
1571
1572         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
1573
1574 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1575
1576         Fix the previous commit, which made both bubbles green.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1579         (.status-line.good .bubble):
1580         (.status-line.bad .bubble):
1581         (.status-line.good .message):
1582
1583 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1584
1585         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
1586         https://bugs.webkit.org/show_bug.cgi?id=144929
1587
1588         Reviewed by Eric Carlson.
1589
1590         Tweaked colors as I see fit.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1593         (.status-line.good .bubble):
1594         (.status-line.bad .bubble):
1595
1596 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
1597
1598         [Mac] Share cookie storage between UI process and secondary processes
1599         https://bugs.webkit.org/show_bug.cgi?id=144820
1600         rdar://problem/20572830
1601
1602         Reviewed by Darin Adler.
1603
1604         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1605         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
1606         for testing.
1607
1608 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
1609
1610         Fix internal build configuration issues
1611         https://bugs.webkit.org/show_bug.cgi?id=144762
1612
1613         Reviewed by David Kilzer.
1614
1615         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
1616
1617         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1618         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1619         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1620         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1621         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1622         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1623         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1624         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1625
1626 2015-05-12  David Kilzer  <ddkilzer@apple.com>
1627
1628         Switch to launching iOS Simulator using bundle ID
1629         <rdar://problem/20916096>
1630
1631         This is required to fix the layout tests on internal bots.
1632
1633         * Scripts/webkitdirs.pm:
1634         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
1635         Simulator.  Add FIXME.
1636         (quitIOSSimulator): Add FIXME.
1637         * Scripts/webkitpy/port/ios.py:
1638         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
1639         launch iOS Simulator.  Add FIXME.
1640         (IOSSimulatorPort.check_sys_deps): Add FIXME.
1641
1642 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
1643
1644         Fix run-javascriptcore-tests step on the WinCairo bot
1645         https://bugs.webkit.org/show_bug.cgi?id=144866
1646
1647         Reviewed by Csaba Osztrogonác.
1648
1649         Catch exception when failing to create soft link, so we can fall back to copy.
1650
1651         * Scripts/run-jsc-stress-tests:
1652
1653 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
1654
1655         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
1656         https://bugs.webkit.org/show_bug.cgi?id=116971
1657
1658         Reviewed by Chris Fleizach.
1659
1660         Implement rowAtIndex for ATK.
1661
1662         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1663         (WTR::AccessibilityUIElement::rowAtIndex):
1664
1665 2015-05-11  Dan Bernstein  <mitz@apple.com>
1666
1667         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
1668
1669         Reviewed by Alexey Proskuryakov.
1670
1671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1672         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
1673         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
1674         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
1675
1676 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
1677
1678         Fix internal build configuration issues
1679         https://bugs.webkit.org/show_bug.cgi?id=144762
1680
1681         Reviewed by Darin Adler.
1682
1683         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
1684
1685         * TestWebKitAPI/Configurations/Base.xcconfig:
1686         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1687         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1688         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1689         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1690         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1691         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1692
1693 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
1694
1695         [Win] Move Windows build target to Windows 7 (or newer)
1696         https://bugs.webkit.org/show_bug.cgi?id=144890
1697         <rdar://problem/20707307>
1698
1699         Reviewed by Anders Carlsson.
1700
1701         Update linked SDK and minimal Windows level to be compatible with
1702         Windows 7 or newer.
1703
1704         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1705         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1706         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1707         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1708         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1709         * DumpRenderTree/config.h:
1710         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1711         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1712         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1713         * WinLauncher/stdafx.h:
1714
1715 2015-05-11  Commit Queue  <commit-queue@webkit.org>
1716
1717         Unreviewed, rolling out r184119.
1718         https://bugs.webkit.org/show_bug.cgi?id=144888
1719
1720         broke JSC tests on Apple Windows bots (Requested by kling on
1721         #webkit).
1722
1723         Reverted changeset:
1724
1725         "Fix run-javascriptcore-tests step on the WinCairo bot"
1726         https://bugs.webkit.org/show_bug.cgi?id=144866
1727         http://trac.webkit.org/changeset/184119
1728
1729 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1730
1731         run-benchmark should support Dromaeo
1732         https://bugs.webkit.org/show_bug.cgi?id=144849
1733
1734         Reviewed by Chris Dumez.
1735
1736         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
1737         they can take as much as 15 minutes to run each.
1738
1739         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
1740         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
1741         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
1742         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
1743
1744 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1745
1746         Build fix. jetstream has a local copy, not remote archive.
1747
1748         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1749
1750 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1751
1752         run-benchmark should support SunSpider, Kraken and Octane
1753         https://bugs.webkit.org/show_bug.cgi?id=144840
1754
1755         Reviewed by Darin Adler.
1756
1757         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
1758         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
1759         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
1760         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
1761
1762         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
1763         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
1764
1765         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
1766         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
1767
1768         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
1769         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
1770         now has the ability to run an arbitrary "create script".
1771
1772         * Scripts/run-benchmark:
1773         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
1774         This also overrides the remote archive URL specified in the plan.
1775
1776         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
1777
1778         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
1779         JetStreamBenchmarkBuilder.
1780
1781         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
1782         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
1783         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
1784         _runCreateScript and _applyPatch to clean after themselves.
1785         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
1786         JetStream, SunSpider, Kraken all use this feature.
1787         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
1788         the leaf directory name since the latter is not available when a remote ZIP file is used.
1789         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
1790         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
1791         the benchmark name in the patches.
1792
1793         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
1794
1795         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1796         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
1797         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
1798         the browser opens by planName as the plan file no longer contains that.
1799
1800         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
1801         the top directory of JetStream instead of its parent.
1802         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
1803         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
1804         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
1805         the top directory of JetStream instead of its parent.
1806         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
1807         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
1808         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
1809         done in JetStream.patch.
1810         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
1811         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
1812         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
1813         path from the top directory of JetStream as done in JetStream.patch.
1814         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
1815
1816 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
1817
1818         Fix run-javascriptcore-tests step on the WinCairo bot
1819         https://bugs.webkit.org/show_bug.cgi?id=144866
1820
1821         Reviewed by Darin Adler.
1822
1823         * Scripts/run-jsc-stress-tests:
1824
1825 2015-05-11  Alex Christensen  <achristensen@webkit.org>
1826
1827         [Content Extensions] Support domain-specific rules and exceptions.
1828         https://bugs.webkit.org/show_bug.cgi?id=144833
1829
1830         Reviewed by Darin Adler.
1831
1832         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1833         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1834         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1835         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1836         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1837         (TestWebKitAPI::mainDocumentRequest):
1838         (TestWebKitAPI::subResourceRequest):
1839         (TestWebKitAPI::TEST_F):
1840         (TestWebKitAPI::checkCompilerError):
1841         Added tests for parsing and functionality of if-domain and unless-domain.
1842
1843 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1844
1845         run-benchmark should support Chrome Canary and Firefox Nightly
1846         https://bugs.webkit.org/show_bug.cgi?id=144850
1847
1848         Reviewed by Darin Adler.
1849
1850         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1851
1852         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1853
1854         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1855         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1856         (OSXBrowserDriver):
1857         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1858         (OSXBrowserDriver.closeBrowsers): Ditto.
1859         (OSXBrowserDriver.launchProcess): Ditto.
1860         (OSXBrowserDriver.terminateProcesses): Ditto.
1861         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1862         (OSXChromeDriver): Removed the unused self.chromePreferences.
1863         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1864         (OSXChromeDriver.closeBrowsers): Ditto.
1865         (OSXChromeDriver.launchUrl):
1866         (OSXChromeCanaryDriver): Added.
1867         (OSXChromeCanaryDriver.launchUrl):
1868         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1869         (OSXFirefoxDriver): Added.
1870         (OSXFirefoxDriver.launchUrl):
1871         (OSXFirefoxNightlyDriver): Added.
1872         (OSXFirefoxNightlyDriver.launchUrl):
1873         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1874         (OSXSafariDriver):
1875         (OSXSafariDriver.closeBrowsers):
1876
1877 2015-05-11  Tim Horton  <timothy_horton@apple.com>
1878
1879         Page overlay action context override should indicate the source of the request
1880         https://bugs.webkit.org/show_bug.cgi?id=144832
1881         <rdar://problem/20562594>
1882
1883         Reviewed by Darin Adler.
1884
1885         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1886         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1887
1888 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
1889
1890         [GTK] fast/events/page-visibility-transition-test.html is timing out
1891         https://bugs.webkit.org/show_bug.cgi?id=114789
1892
1893         Reviewed by Darin Adler.
1894
1895         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1896         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1897         requests visibility changes.
1898
1899 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1900
1901         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1902         https://bugs.webkit.org/show_bug.cgi?id=144798
1903
1904         Reviewed by Darin Adler.
1905
1906         * efl/install-dependencies:
1907
1908 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
1909
1910         Make arguments of run-benchmark more user friendly
1911         https://bugs.webkit.org/show_bug.cgi?id=144835
1912
1913         Reviewed by Darin Adler.
1914
1915         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1916         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1917         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1918         default values from --platform and --browser as they are required arguments.
1919
1920         * Scripts/run-benchmark:
1921         (main): Made --build-directory optional, and removed default values from --platform and --browser.
1922         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1923         are not dynamically obtained via BrowserDriverFactory.
1924         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1925         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1926         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1927         run any benchmark in that case.
1928         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1929         the specified file isn't a valid relative or an absolute path.
1930         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1931         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1932         and browsers.
1933         (BrowserDriverFactory.available_browsers): Ditto.
1934         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1935         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1936         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1937         browserBuildPath was None.
1938         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1939         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1940         so that we can use locally built WebKit to launch Safari.
1941
1942 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
1943
1944         Remove the PICTURE_SIZES build flag
1945         https://bugs.webkit.org/show_bug.cgi?id=144679
1946
1947         Reviewed by Benjamin Poulain.
1948
1949         Removed the PICTURE_SIZES build time flag.
1950
1951         * Scripts/webkitperl/FeatureList.pm:
1952
1953 2015-05-09  David Kilzer  <ddkilzer@apple.com>
1954
1955         Layout tests broke due to unexpected simctl output
1956
1957         * Scripts/webkitpy/xcode/simulator.py:
1958         (Simulator._parse_devices): Handle new Device Pairs header.
1959         * Scripts/webkitpy/xcode/simulator_unittest.py:
1960         (test_device_pairs): Add unit test for Device Pairs header.
1961
1962 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
1963
1964         Remove convenience constructors for TextRun
1965         https://bugs.webkit.org/show_bug.cgi?id=144752
1966
1967         Reviewed by Anders Carlsson.
1968
1969         Test the StringView which takes a StringImpl*.
1970
1971         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1972         (StringView8Bit): Testing is8Bit() on StringView
1973
1974 2015-05-07  Sam Weinig  <sam@webkit.org>
1975
1976         [Content Extensions] Add simple tester that takes an extension and compiles it
1977         https://bugs.webkit.org/show_bug.cgi?id=144781
1978
1979         Reviewed by Dan Bates.
1980
1981         * ContentExtensionTester: Added.
1982         * ContentExtensionTester/Configurations: Added.
1983         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
1984         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
1985         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
1986         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
1987         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
1988         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
1989         * ContentExtensionTester/main.m: Added.
1990         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
1991
1992 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
1993
1994         Build fix.
1995
1996         Reviewed by Dan Bernstein.
1997
1998         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1999         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2000         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
2001         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2002         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2003         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2004         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
2005         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2006
2007 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
2008
2009         [GTK] Some tests fail because they do not assume the popup menu captures click events
2010         https://bugs.webkit.org/show_bug.cgi?id=40601
2011
2012         Reviewed by Carlos Garcia Campos.
2013
2014         Popdown all attached menus when moving between tests and between each new
2015         event sent to the WebView. This prevents context and popup menus from eating
2016         events.
2017
2018         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
2019         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
2020         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2021         (WTR::dispatchEvent): Popdown all menus between dispatching events.
2022         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
2023         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
2024         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2025         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
2026         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2027         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
2028         longer in the platform-independent file.
2029         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
2030
2031 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
2032
2033         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
2034         https://bugs.webkit.org/show_bug.cgi?id=144746
2035
2036         Reviewed by Carlos Garcia Campos.
2037
2038         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
2039
2040         * MiniBrowser/gtk/main.c:
2041         (main):
2042
2043 2015-05-08  Commit Queue  <commit-queue@webkit.org>
2044
2045         Unreviewed, rolling out r183996.
2046         https://bugs.webkit.org/show_bug.cgi?id=144806
2047
2048         ASan detected use-after free (Requested by ap on #webkit).
2049
2050         Reverted changeset:
2051
2052         "Remove convenience constructors for TextRun"
2053         https://bugs.webkit.org/show_bug.cgi?id=144752
2054         http://trac.webkit.org/changeset/183996
2055
2056 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2057
2058         Remove convenience constructors for TextRun
2059         https://bugs.webkit.org/show_bug.cgi?id=144752
2060
2061         Reviewed by Anders Carlsson.
2062
2063         Test the StringView which takes a StringImpl*.
2064
2065         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2066         (StringView8Bit): Testing is8Bit() on StringView
2067
2068 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2069
2070         [GTK] WTR doesn't correctly handle the Escape key
2071         https://bugs.webkit.org/show_bug.cgi?id=144788
2072
2073         Reviewed by Martin Robinson.
2074
2075         Correctly handle 0x001B character code in GTK+ event sender to be
2076         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
2077         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
2078         to dismiss popup menus.
2079
2080         Fixes editing/selection/5354455-1.html.
2081
2082         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2083         (WTR::getGDKKeySymForKeyRef):
2084
2085 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2086
2087         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
2088         https://bugs.webkit.org/show_bug.cgi?id=144748
2089
2090         Reviewed by Sergio Villar Senin.
2091
2092         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2093         (testWebKitSettings): Check the new setting is correctly
2094         initialized and updated.
2095         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2096         (testWebContextSecurityFileXHR): Check XHR to local files is
2097         allowed from file URLs after changing the setting.
2098         (beforeAll): Add new test.
2099
2100 2015-05-08  Commit Queue  <commit-queue@webkit.org>
2101
2102         Unreviewed, rolling out r183945.
2103         https://bugs.webkit.org/show_bug.cgi?id=144789
2104
2105         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
2106
2107         Reverted changeset:
2108
2109         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
2110         https://bugs.webkit.org/show_bug.cgi?id=144746
2111         http://trac.webkit.org/changeset/183945
2112
2113 2015-05-07  Anders Carlsson  <andersca@apple.com>
2114
2115         Build fixes.
2116
2117         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2118         (TestWebKitAPI::TEST):
2119         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2120         (TestWebKitAPI::TEST):
2121         Add casts.
2122
2123 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
2124
2125         GC has trouble with pathologically large array allocations
2126         https://bugs.webkit.org/show_bug.cgi?id=144609
2127
2128         Reviewed by Geoffrey Garen.
2129         
2130         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
2131         and it's a frequently requested feature.
2132         
2133         Also add the ability to run a test pretending that your system has a particular RAM size.
2134         This is useful for GC tests, and the new GC test that I added uses this.
2135
2136         * Scripts/run-javascriptcore-tests:
2137         (runJSCStressTests):
2138         * Scripts/run-jsc-stress-tests:
2139
2140 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
2141
2142         [EFL] Bump EFL version to 1.14.0
2143         https://bugs.webkit.org/show_bug.cgi?id=144743
2144
2145         Reviewed by Darin Adler.
2146
2147         Bump EFL and elementary version to 1.14.0 and removed
2148         md5sum, because it isn't used at all if hash is present.
2149
2150         * efl/jhbuild.modules:
2151
2152 2015-05-07  Saam Barati  <saambarati1@gmail.com>
2153
2154         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
2155         https://bugs.webkit.org/show_bug.cgi?id=144753
2156
2157         Reviewed by Mark Lam.
2158
2159         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2160
2161 2015-05-07  Beth Dakin  <bdakin@apple.com>
2162
2163         New force-related DOM events should fire in WK1 views
2164         https://bugs.webkit.org/show_bug.cgi?id=144663
2165         -and corresponding-
2166         rdar://problem/20281886
2167
2168         Reviewed by Sam Weinig.
2169
2170         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
2171         now. Just send nil. 
2172         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2173         (TestWebKitAPI::buildAndPerformTest):
2174
2175 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2176
2177         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
2178         https://bugs.webkit.org/show_bug.cgi?id=144746
2179
2180         Reviewed by Martin Robinson.
2181
2182         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
2183
2184         * MiniBrowser/gtk/main.c:
2185         (main):
2186
2187 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
2188
2189         Revert "Introducing the Platform Abstraction Layer (PAL)"
2190         https://bugs.webkit.org/show_bug.cgi?id=144751
2191
2192         Unreviewed.
2193
2194         PAL should be a new target inside WebCore, rather than a top-level folder.
2195
2196         * Scripts/build-webkit: Add it to build-webkit.
2197
2198 2015-05-07  Ada Chan  <adachan@apple.com>
2199
2200         Add a test for WKPageCopySessionState() with filtering.
2201         https://bugs.webkit.org/show_bug.cgi?id=144666
2202
2203         Reviewed by Darin Adler.
2204
2205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2206         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
2207         (TestWebKitAPI::didFinishLoadForFrame):
2208         (TestWebKitAPI::setPageLoaderClient):
2209         (TestWebKitAPI::filterFirstItemCallback):
2210         (TestWebKitAPI::filterAllItemsCallback):
2211         (TestWebKitAPI::createSessionStates):
2212         (TestWebKitAPI::TEST):
2213
2214 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2215
2216         iOS build fix attempt
2217
2218         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
2219
2220         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2221
2222 2015-05-06  Matt Baker  <mattbaker@apple.com>
2223
2224         Unreviewed, updated my list of email addresses.
2225
2226         * Scripts/webkitpy/common/config/contributors.json:
2227
2228 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2229
2230         Do not link tools to WebKit2.framework
2231         https://bugs.webkit.org/show_bug.cgi?id=144699
2232
2233         Unreviewed build fix.
2234
2235         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2236         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2237         These linked to WebKit2 in two ways, eliminating the other one.
2238
2239 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
2240
2241         Introducing the Platform Abstraction Layer (PAL)
2242         https://bugs.webkit.org/show_bug.cgi?id=143358
2243
2244         Reviewed by Simon Fraser.
2245
2246         * Scripts/build-webkit: Add it to build-webkit.
2247
2248 2015-05-06  Alex Christensen  <achristensen@webkit.org>
2249
2250         Fix api tests after r183877.
2251
2252         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2253         (TestWebKitAPI::TEST_F):
2254         Generate all DFAs before compiling them.
2255
2256 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2257
2258         Do not link tools to WebKit2.framework
2259         https://bugs.webkit.org/show_bug.cgi?id=144699
2260
2261         Reviewed by Tim Horton.
2262
2263         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2265         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2266
2267 2015-05-06  Alex Christensen  <achristensen@webkit.org>
2268
2269         [Content Extensions] Test splitting NFAs by max NFA size.
2270         https://bugs.webkit.org/show_bug.cgi?id=144659
2271
2272         Reviewed by Darin Adler.
2273
2274         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2275         (TestWebKitAPI::createNFAs):
2276         (TestWebKitAPI::TEST_F):
2277         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2278         (TestWebKitAPI::createNFAs):
2279
2280 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
2281
2282         Remove the remaining vestiges of SVG feature define
2283         https://bugs.webkit.org/show_bug.cgi?id=144655
2284
2285         Reviewed by Alexey Proskuryakov.
2286
2287         * Scripts/webkitperl/FeatureList.pm:
2288
2289 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
2290
2291         Add a layout mode for computing fixed layout size from a minimum size
2292         https://bugs.webkit.org/show_bug.cgi?id=144610
2293         <rdar://problem/19790341>
2294
2295         Reviewed by Simon Fraser.
2296
2297         * MiniBrowser/mac/BrowserWindow.xib:
2298         * MiniBrowser/mac/BrowserWindowController.h:
2299         * MiniBrowser/mac/WK1BrowserWindowController.m:
2300         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
2301         * MiniBrowser/mac/WK2BrowserWindowController.m:
2302         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
2303         Add a optional toolbar item to toggle a minimum view size of 1024x0.
2304
2305 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2306
2307         [Content Extensions] Release input NSString when finished copying it.
2308         https://bugs.webkit.org/show_bug.cgi?id=144642
2309
2310         Reviewed by Brian Weinstein.
2311
2312         * WebKitTestRunner/mac/TestControllerMac.mm:
2313         (WTR::TestController::platformConfigureViewForTest):
2314         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
2315
2316 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
2317
2318         Unreviewed test fix after r183798.
2319
2320         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2321         (convertToDRTLabel): Mimic behavior of Mac accessibility output
2322         so we can share results.
2323
2324 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2325
2326         [Content Extensions] Use less memory to store the json input.
2327         https://bugs.webkit.org/show_bug.cgi?id=144604
2328
2329         Reviewed by Benjamin Poulain.
2330
2331         * MiniBrowser/mac/ExtensionManagerWindowController.m:
2332         (-[ExtensionManagerWindowController add:]):
2333         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2334         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2335         * WebKitTestRunner/mac/TestControllerMac.mm:
2336         (WTR::TestController::platformConfigureViewForTest):
2337
2338 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2339
2340         Unreviewed. Make myself a WebKit reviewer.
2341
2342         * Scripts/webkitpy/common/config/contributors.json:
2343
2344 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
2345
2346         [GTK] r183783 breaks build
2347         https://bugs.webkit.org/show_bug.cgi?id=144632
2348
2349         Reviewed by Martin Robinson.
2350
2351         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
2352
2353         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2354         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2355
2356 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2357
2358         [Content Extensions] Combine NFAs properly and free memory as we compile.
2359         https://bugs.webkit.org/show_bug.cgi?id=144485
2360
2361         Reviewed by Benjamin Poulain.
2362
2363         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2364         (TestWebKitAPI::TEST_F):
2365         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
2366         Added tests for deep NFAs.
2367
2368 2015-05-04  Alex Christensen  <achristensen@webkit.org>
2369
2370         [Content Extensions] Use less memory when writing byte code to file
2371         https://bugs.webkit.org/show_bug.cgi?id=144602
2372
2373         Reviewed by Darin Adler.
2374
2375         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2376
2377 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2378
2379         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
2380         https://bugs.webkit.org/show_bug.cgi?id=144541
2381
2382         Reviewed by Žan Doberšek.
2383
2384         Add a test case to WorkQueue unit test, to check that sources of
2385         asynchronous IO operations running in the WorkQueue thread are
2386         dispatched by the WorkQueue main loop.
2387
2388         * TestWebKitAPI/PlatformGTK.cmake:
2389         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
2390         (TestWebKitAPI::TEST):
2391
2392 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
2393
2394         Correct '--show-webview' option for Tiled Drawing tests
2395         https://bugs.webkit.org/show_bug.cgi?id=144621
2396
2397         Reviewed by Simon Fraser.
2398
2399         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
2400         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
2401
2402         * WebKitTestRunner/mac/TestControllerMac.mm:
2403         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
2404         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
2405
2406 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
2407
2408         Large array shouldn't be slow
2409         https://bugs.webkit.org/show_bug.cgi?id=144617
2410
2411         Reviewed by Geoffrey Garen.
2412         
2413         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
2414         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
2415         long-running. So, hash-map sort of belongs here.
2416
2417         * Scripts/run-jsc-benchmarks:
2418
2419 2015-05-04  Doug Russell  <d_russell@apple.com>
2420
2421         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
2422         https://bugs.webkit.org/show_bug.cgi?id=144489
2423
2424         Reviewed by Chris Fleizach.
2425
2426         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
2427         on the returned control.
2428         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
2429         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
2430         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
2431         Add support for setSelectedVisibleTextRange() in accessibility tests.
2432
2433         * DumpRenderTree/AccessibilityUIElement.cpp:
2434         (setSelectedVisibleTextRangeCallback):
2435         (AccessibilityUIElement::setSelectedVisibleTextRange):
2436         (AccessibilityUIElement::getJSClass):
2437         (AccessibilityUIElement::textMarkerForIndex): Deleted.
2438         * DumpRenderTree/AccessibilityUIElement.h:
2439         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2440         (AccessibilityUIElement::setSelectedVisibleTextRange):
2441         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2442         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2443         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
2444         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2445         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2446         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2447         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2448         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2449         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2450         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2451         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2452
2453 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
2454
2455         [Win] Implement the "--show-webview" option for Windows
2456         https://bugs.webkit.org/show_bug.cgi?id=144589
2457
2458         Reviewed by Alex Christensen.
2459
2460         Add another runtime flag (--show-webview) that causes DumpRenderTree
2461         to draw its view on-screen, rather than the standard offscreen mode.
2462
2463         * DumpRenderTree/win/DumpRenderTree.cpp:
2464         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
2465         (initializeGlobalsFromCommandLineOptions): Recognize the new
2466         command-line argument, and set the global 'showWebView' state if
2467         appropriate.
2468
2469 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
2470
2471         Remove dead code from TestInvocationCairo.cpp
2472         https://bugs.webkit.org/show_bug.cgi?id=144564
2473
2474         Reviewed by Gyuyoung Kim.
2475
2476         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
2477
2478         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2479         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2480
2481 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
2482
2483         [GTK] Add libnotify in gtk install-dependencies
2484         https://bugs.webkit.org/show_bug.cgi?id=144379
2485
2486         Reviewed by Csaba Osztrogonác.
2487
2488         * gtk/install-dependencies:
2489
2490 2015-05-01  Dan Bernstein  <mitz@apple.com>
2491
2492         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
2493         https://bugs.webkit.org/show_bug.cgi?id=144501
2494
2495         Reviewed by Darin Adler.
2496
2497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2498         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
2499         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
2500         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
2501
2502 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
2503
2504         check-webkit-style fails due to system pylint
2505         https://bugs.webkit.org/show_bug.cgi?id=144360
2506
2507         Reviewed by Darin Adler.
2508
2509         Make sure that the directory containing third party autoinstalled modules
2510         is at the beginning of the search path, to avoid conflicts with other
2511         versions of the same modules installed in the system (e.g. pylint).
2512
2513         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
2514         modules directory to sys.path, instead of appending it.
2515
2516 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
2517
2518         Unreviewed, updated my list of email addresses.
2519
2520         * Scripts/webkitpy/common/config/contributors.json: Updated.
2521
2522 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
2523
2524         USE(...) macro should expect unprefixed variables
2525         https://bugs.webkit.org/show_bug.cgi?id=144454
2526
2527         Reviewed by Daniel Bates.
2528
2529         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
2530         * DumpRenderTree/config.h: Ditto.
2531         * TestWebKitAPI/config.h: Ditto.
2532
2533 2015-05-01  Basile Clement  <basile_clement@apple.com>
2534
2535         Unreviewed. Add myself as a commiter in contributors.json.
2536
2537         * Scripts/webkitpy/common/config/contributors.json:
2538
2539 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
2540
2541         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
2542         https://bugs.webkit.org/show_bug.cgi?id=144487
2543
2544         Reviewed by Ryosuke Niwa.
2545
2546         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2547         (BenchmarkRunner.merge): Fix bug.
2548         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
2549
2550 2015-05-01  Brady Eidson  <beidson@apple.com>
2551
2552         Add API to disable meta refreshes.
2553         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
2554
2555         Reviewed by Alexey Proskuryakov.
2556
2557         * DumpRenderTree/mac/DumpRenderTree.mm:
2558         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
2559
2560 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
2561
2562         Provide a runtime flag to run-webkit-tests that shows the test view
2563         https://bugs.webkit.org/show_bug.cgi?id=144079.
2564
2565         Unreviewed correction to r183651.
2566
2567         * WebKitTestRunner/TestController.cpp:
2568         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
2569         flag is included in the options dictionary passed to the PlatformWebView.
2570
2571 2015-05-01  Antti Koivisto  <antti@apple.com>
2572
2573         Remove network process load serialization code
2574         https://bugs.webkit.org/show_bug.cgi?id=144448
2575
2576         Reviewed by Alexey Proskuryakov.
2577
2578         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2579         (WTR::InjectedBundle::beginTesting):
2580         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2581         (WTR::TestRunner::setSerializeHTTPLoads):
2582         (WTR::TestRunner::dispatchPendingLoadRequests):
2583
2584 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2585
2586         [GTK] Add libhyphen-dev to the build dependencies
2587         https://bugs.webkit.org/show_bug.cgi?id=144452
2588
2589         Reviewed by Martin Robinson.
2590
2591         * gtk/install-dependencies: Added hyphen as Fedora and Arch
2592         dependencies.
2593
2594 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
2595
2596         Provide a runtime flag to run-webkit-tests that shows the test view
2597         https://bugs.webkit.org/show_bug.cgi?id=144079.
2598
2599         Reviewed by Dean Jackson.
2600
2601         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
2602         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
2603         option:
2604         
2605         --additional-drt-flag="--show-webview"
2606
2607         * DumpRenderTree/mac/DumpRenderTree.mm:
2608         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
2609         '--show-webview' flag.
2610         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
2611         * WebKitTestRunner/Options.cpp:
2612         (WTR::Options::Options):
2613         (WTR::handleOptionShowWebView):
2614         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
2615         * WebKitTestRunner/Options.h:
2616         * WebKitTestRunner/TestController.cpp:
2617         (WTR::TestController::TestController):
2618         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
2619         * WebKitTestRunner/TestController.h:
2620         (WTR::TestController::shouldShowWebView):
2621         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2622         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
2623         options dictionary. If it is true, display the web view while running the test.
2624
2625 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
2626
2627         r183355 didn't trigger Mac tests
2628         https://bugs.webkit.org/show_bug.cgi?id=144464
2629
2630         Reviewed by Simon Fraser.
2631
2632         Update badly neglected filters and unit tests.
2633
2634         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2635         (_should_file_trigger_build):
2636         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2637         (ShouldBuildTest):
2638         (ShouldBuildTest.test_should_build):
2639
2640 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2641
2642         [GTK] Add libhyphen-dev to the build dependencies
2643         https://bugs.webkit.org/show_bug.cgi?id=144452
2644
2645         Reviewed by Martin Robinson.
2646
2647         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
2648         build dependencies.
2649
2650 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
2651
2652         [GTK] Testing dictionaries are not installed automatically
2653         https://bugs.webkit.org/show_bug.cgi?id=144460
2654
2655         Reviewed by Carlos Garcia Campos.
2656
2657         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
2658
2659 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
2660
2661         Fix return code issue, check return code of safari process and dump results to log
2662         https://bugs.webkit.org/show_bug.cgi?id=144436
2663
2664         Reviewed by Ryosuke Niwa.
2665
2666         * Scripts/run-benchmark:
2667         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2668         (BenchmarkRunner.dump): Correct typo.
2669         (BenchmarkRunner.wrap): Add results to console.
2670         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
2671         (OSXSafariDriver.prepareEnv):
2672         (OSXSafariDriver.launchUrl):
2673         (OSXSafariDriver.closeBrowsers):
2674
2675 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2676
2677         Should no longer need to worry about very old versions of Xcode
2678         https://bugs.webkit.org/show_bug.cgi?id=144437
2679
2680         Reviewed by Dan Bernstein.
2681
2682         * Scripts/check-for-exit-time-destructors:
2683         * Scripts/check-for-global-initializers:
2684         * Scripts/check-for-weak-vtables-and-externals:
2685
2686 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2687
2688         REGRESSION(183583): [Mac] make without SDKROOT has issues
2689         https://bugs.webkit.org/show_bug.cgi?id=144431
2690
2691         Reviewed by Dan Bernstein.
2692
2693         * Makefile:
2694         * WebKitTestRunner/Makefile:
2695         Assume an empty SDKROOT means an macosx variant, so only
2696         enable settings if the SDKROOT is not empty and does not
2697         contain "macosx".
2698
2699 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
2700
2701         Expand test infrastructure to support scrolling tests
2702         https://bugs.webkit.org/show_bug.cgi?id=143684
2703         <rdar://problem/20375516>
2704
2705         Reviewed by Simon Fraser.
2706
2707         * DumpRenderTree/mac/DumpRenderTree.mm:
2708         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
2709         reset before the next test run.
2710         * WebKitTestRunner/TestController.cpp:
2711         (WTR::TestController::resetStateToConsistentValues): Ditto."
2712
2713 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2714
2715         Run javascriptcore tests on Windows without cygwin
2716         https://bugs.webkit.org/show_bug.cgi?id=144419
2717
2718         Reviewed by Brent Fulgham.
2719
2720         * Scripts/run-javascriptcore-tests:
2721         (runJSCStressTests):
2722         Just call ruby, not /usr/bin/env ruby.
2723
2724 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
2725
2726         [GTK] Add --enable-shared option to LLVM to build mesa
2727         https://bugs.webkit.org/show_bug.cgi?id=144393
2728
2729         Reviewed by Martin Robinson.
2730
2731         The updated mesa requires the shared LLVM libraries.
2732         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
2733         to LLVM configure script. It will provide shared libraries in addition to static libraries.
2734
2735         * gtk/jhbuild-optional.modules:
2736
2737 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
2738
2739         [GTK] Add support for automatic hyphenation
2740         https://bugs.webkit.org/show_bug.cgi?id=44478
2741
2742         Reviewed by Carlos Garcia Campos.
2743
2744         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
2745         all systems will use the same dictionaries for testing purposes.
2746
2747 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
2748
2749         Failure when building WebKit for appletvsimulator.
2750         https://bugs.webkit.org/show_bug.cgi?id=144356
2751
2752         Reviewed by Alexey Proskuryakov.
2753
2754         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
2755         make TVOS and WatchOS behave correctly.
2756
2757         * Makefile:
2758         * WebKitTestRunner/Makefile:
2759
2760 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2761
2762         Use-after-free when invalidating WKPageForceRepaint callback
2763         https://bugs.webkit.org/show_bug.cgi?id=144401
2764         rdar://problem/20741111
2765
2766         Reviewed by Tim Horton.
2767
2768         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
2769
2770         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
2771         Don't do anything on error, because the context may be a stale pointer now.
2772
2773 2015-04-29  David Kilzer  <ddkilzer@apple.com>
2774
2775         check-webkit-style: Don't complain about returning value from Objective-C method call in header
2776         <http://webkit.org/b/144395>
2777
2778         Reviewed by Andy Estes.
2779
2780         * Scripts/webkitpy/style/checkers/cpp.py:
2781         (check_spacing): Update regex so 'return' is ignored if it
2782         precedes the whitespace and bracket.  Change category name to
2783         'whitespace/brackets'.  Add period to error message.
2784         (CppChecker): Add 'whitespace/brackets' as a category.
2785         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2786         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
2787         'CppChecker.categories' since that's where the list lives now.
2788         (CppStyleTest.test_spacing_before_brackets): Add tests for
2789         'whitespace/brackets' issues and non-issues.
2790
2791 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2792
2793         Fix WinCairo bot.
2794
2795         * Scripts/webkitdirs.pm:
2796         (determinePassedConfiguration):
2797         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
2798
2799 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
2800
2801         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
2802         https://bugs.webkit.org/show_bug.cgi?id=132159
2803
2804         Reviewed by Darin Adler.
2805
2806         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
2807         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
2808
2809         * DumpRenderTree/mac/DumpRenderTree.mm:
2810         (fontWhitelist):
2811         (adjustFonts):
2812         (createWebViewAndOffscreenWindow):
2813         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2814         (WTR::activateFonts):
2815         * WebKitTestRunner/mac/TestControllerMac.mm:
2816         (WTR::allowedFontFamilySet):
2817         (WTR::systemHiddenFontFamilySet):
2818         (WTR::generateWhitelist):
2819         (WTR::TestController::platformInitializeContext):
2820
2821 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2822
2823         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2824         https://bugs.webkit.org/show_bug.cgi?id=144155
2825
2826         Reviewed by Andreas Kling.
2827
2828         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2829         Make sure that test window is "visible" before each test. While there is no concrete
2830         evidence that this is the problem indeed, the behavior is consistent with what would
2831         happen for an invisible window. Also, WKTR obviously needs to do this to protect
2832         against potential buggy tests that hide the window and don't show it.
2833
2834 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2835
2836         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2837
2838         Latest changes in the inspector UI made this test fail. We were
2839         relying that the sidebar was always visible and the first 'li'
2840         element of the inspector was the one containing the title. This is
2841         no longer true, so better use document title that is not likely
2842         to change.
2843
2844         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2845         (openRemoteDebuggingSession):
2846
2847 2015-04-29  Andres Gomez  <agomez@igalia.com>
2848
2849         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2850
2851         * Scripts/webkitpy/common/config/contributors.json:
2852
2853 2015-04-29  Andres Gomez  <agomez@igalia.com>
2854
2855         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2856
2857         * Scripts/webkitpy/common/config/watchlist:
2858
2859 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
2860
2861         [EFL] Allow to run the tests on the native X display
2862         https://bugs.webkit.org/show_bug.cgi?id=144247
2863
2864         Reviewed by Gyuyoung Kim.
2865
2866         Added the USE_NATIVE_XDISPLAY option for the WTR.
2867         We can select the Xorg driver if environment variable is set up before running the tests.
2868
2869         * Scripts/webkitpy/port/efl.py:
2870         (EflPort._driver_class):
2871
2872 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
2873
2874         [GTK] Add libnotify-dev in gtk install-dependencies
2875         https://bugs.webkit.org/show_bug.cgi?id=144379
2876
2877         Reviewed by Žan Doberšek.
2878
2879         * gtk/install-dependencies:
2880
2881 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
2882
2883         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2884         https://bugs.webkit.org/show_bug.cgi?id=143001
2885
2886         Reviewed by Gyuyoung Kim.
2887
2888         * WebKitTestRunner/TestController.cpp:
2889         (WTR::shouldUseFixedLayout):
2890
2891 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
2892
2893         Increase stablility of run-benchmark script
2894         https://bugs.webkit.org/show_bug.cgi?id=144361
2895
2896         Reviewed by Ryosuke Niwa.
2897
2898         * Scripts/run-benchmark:
2899         (main):
2900         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2901         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2902         (GenericBenchmarkBuilder.clean):
2903         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2904         (BenchmarkRunner.__init__):
2905         (BenchmarkRunner.execute):
2906         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2907         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2908         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2909         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2910         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2911         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
2912         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2913         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2914         (HTTPServerDriver.fetchResult):
2915         (HTTPServerDriver):
2916         (HTTPServerDriver.killServer): Add kill server interface.
2917         (HTTPServerDriver.getReturnCode): Add get return code interface.
2918         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2919         (SimpleHTTPServerDriver.serve):
2920         (SimpleHTTPServerDriver.fetchResult):
2921         (SimpleHTTPServerDriver):
2922         (SimpleHTTPServerDriver.killServer):
2923         (SimpleHTTPServerDriver.getReturnCode):
2924         * Scripts/webkitpy/benchmark_runner/utils.py:
2925         (forceRemove): Provide python version of 'rm -rf'.
2926
2927 2015-04-28  Sam Weinig  <sam@webkit.org>
2928
2929         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2930         https://bugs.webkit.org/show_bug.cgi?id=144363
2931
2932         Reviewed by Alex Christensen.
2933
2934         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2935         (TestWebKitAPI::createNFAs):
2936         (TestWebKitAPI::TEST_F):
2937         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2938         (TestWebKitAPI::countLiveNodes):
2939         (TestWebKitAPI::createNFAs):
2940         (TestWebKitAPI::buildDFAFromPatterns):
2941         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
2942
2943 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2944
2945         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2946         https://bugs.webkit.org/show_bug.cgi?id=144304
2947
2948         Reviewed by Geoffrey Garen.
2949
2950         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
2951         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2952         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2953
2954 2015-04-28  Commit Queue  <commit-queue@webkit.org>
2955
2956         Unreviewed, rolling out r183514.
2957         https://bugs.webkit.org/show_bug.cgi?id=144359
2958
2959         It broke cloop test bots (Requested by mcatanzaro on #webkit).
2960
2961         Reverted changeset:
2962
2963         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
2964         https://bugs.webkit.org/show_bug.cgi?id=144304
2965         http://trac.webkit.org/changeset/183514
2966
2967 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2968
2969         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2970         https://bugs.webkit.org/show_bug.cgi?id=144304
2971
2972         Reviewed by Geoffrey Garen.
2973
2974         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
2975         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
2976         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2977         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2978
2979 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2980
2981         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
2982         https://bugs.webkit.org/show_bug.cgi?id=144319
2983
2984         Reviewed by Csaba Osztrogonác.
2985
2986         * TestWebKitAPI/CMakeLists.txt:
2987         * TestWebKitAPI/PlatformEfl.cmake:
2988
2989 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
2990
2991         Fix common typo "targetting" => "targeting"
2992         https://bugs.webkit.org/show_bug.cgi?id=144349
2993
2994         Reviewed by Daniel Bates.
2995
2996         * Scripts/webkitdirs.pm:
2997         (execMacWebKitAppForDebugging):
2998
2999 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3000
3001         [GTK][jhbuild] Mesa build failure with llvm 3.6
3002         https://bugs.webkit.org/show_bug.cgi?id=144250
3003
3004         Reviewed by Žan Doberšek.
3005
3006         Bump the version of Mesa to 10.5.4
3007
3008         * gtk/jhbuild.modules:
3009
3010 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
3011
3012         Disable App Nap in WebKitTestRunner UI process
3013         https://bugs.webkit.org/show_bug.cgi?id=144308
3014
3015         Reviewed by Daniel Bates.
3016
3017         * WebKitTestRunner/mac/main.mm:
3018         (disableAppNapInUIProcess):
3019         (main):
3020
3021 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3022
3023         [GTK] Update JHBuild Mesa download directory
3024         https://bugs.webkit.org/show_bug.cgi?id=144318
3025
3026         Update the download directory of Mesa module since the previous one
3027         doesn't exist any more.
3028
3029         Reviewed by Žan Doberšek.
3030
3031         * gtk/jhbuild.modules:
3032
3033 2015-04-28  Commit Queue  <commit-queue@webkit.org>
3034
3035         Unreviewed, rolling out r183477.
3036         https://bugs.webkit.org/show_bug.cgi?id=144334
3037
3038         Roll back the Mesa dependency bump in fear of uncaught
3039         regressions while the testing bots are no-op. (Requested by
3040         zdobersek on #webkit).
3041
3042         Reverted changeset:
3043
3044         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
3045         https://bugs.webkit.org/show_bug.cgi?id=144250
3046         http://trac.webkit.org/changeset/183477
3047
3048 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3049
3050         [GTK][jhbuild] Mesa build failure with llvm 3.6
3051         https://bugs.webkit.org/show_bug.cgi?id=144250
3052
3053         Reviewed by Žan Doberšek.
3054
3055         Bump the version of Mesa to 10.5.4
3056
3057         * gtk/jhbuild.modules:
3058
3059 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
3060
3061         Add '__init__.py' and fix known bug in benchmark runner.
3062         https://bugs.webkit.org/show_bug.cgi?id=144296
3063
3064         Reviewed by Ryosuke Niwa
3065
3066         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
3067         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
3068         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3069         (BenchmarkRunner.__init__):
3070         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
3071         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
3072         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
3073
3074 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3075
3076         More build fix.
3077
3078         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3079         (-[AccessibilityNotificationHandler _notificationReceived:]):
3080         Use -objectForKey:, not array subscript.
3081
3082 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3083
3084         Catch unexpected exits in DumpRenderTree
3085         https://bugs.webkit.org/show_bug.cgi?id=144288
3086
3087         Reviewed by Tim Horton.
3088
3089         * DumpRenderTree/mac/DumpRenderTree.mm:
3090         (atexitFunction):
3091         (DumpRenderTreeMain):
3092
3093 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3094
3095         Build fix
3096
3097         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3098         (-[AccessibilityNotificationHandler _notificationReceived:]):
3099         Use -objectForKey:, not array subscript.
3100
3101 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3102
3103         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
3104         https://bugs.webkit.org/show_bug.cgi?id=144155
3105
3106         Reviewed by Tim Horton.
3107
3108         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3109         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
3110         and we clearly don't want App Nap while testing.
3111
3112 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
3113
3114         [CMake] Autogenerate cmakeconfig.h.cmake
3115         https://bugs.webkit.org/show_bug.cgi?id=143997
3116
3117         Reviewed by Csaba Osztrogonác.
3118
3119         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
3120         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
3121
3122 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
3123
3124         REGRESSION(r182879): Images and video can no longer be downloaded
3125         https://bugs.webkit.org/show_bug.cgi?id=144267
3126         <rdar://problem/20702844>
3127
3128         Reviewed by Simon Fraser.
3129
3130         Revise tests to check for proper download menu state.
3131         1. Downloading a loal image should be disabled.
3132         2. Downloading a local media file should be disabled.
3133         3. Downloading non-downloadable media should be disabled.
3134
3135         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3136         (TestWebKitAPI::TEST):
3137
3138 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3139
3140         Merge run-launcher into run-minibrowser
3141         https://bugs.webkit.org/show_bug.cgi?id=141928
3142
3143         Reviewed by Darin Adler.
3144
3145         * Scripts/run-iexploder-tests:
3146         (runSafariWithIExploder):
3147         * Scripts/run-launcher: Removed.
3148         * Scripts/run-minibrowser:
3149         * Scripts/webkitdirs.pm:
3150         (launcherPath):
3151         * Scripts/webkitpy/port/efl.py:
3152         (EflPort.show_results_html_file):
3153         * Scripts/webkitpy/port/efl_unittest.py:
3154         (EflPortTest.test_show_results_html_file):
3155         * Scripts/webkitpy/port/gtk.py:
3156         (GtkPort.print_leaks_summary):
3157         (GtkPort.show_results_html_file):
3158         (GtkPort): Deleted.
3159         * Scripts/webkitpy/port/gtk_unittest.py:
3160         (GtkPortTest.test_show_results_html_file):
3161
3162 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3163
3164         [buildbot] Fix the output of perf-test buildstep on timeout
3165         https://bugs.webkit.org/show_bug.cgi?id=144097
3166
3167         Reviewed by Ryosuke Niwa.
3168
3169         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3170         (RunAndUploadPerfTests.getText2):
3171         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3172         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
3173         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
3174
3175 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3176
3177         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
3178         https://bugs.webkit.org/show_bug.cgi?id=143874
3179
3180         Reviewed by Gyuyoung Kim.
3181
3182         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
3183
3184 2015-04-24  Philippe Normand  <pnormand@igalia.com>
3185
3186         [JHBuild] Move to upstream OpenWebRTC
3187         https://bugs.webkit.org/show_bug.cgi?id=144145
3188
3189         Reviewed by Carlos Garcia Campos.
3190
3191         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
3192         and add a new simple patch to gst-plugins-base, required for
3193         OpenWebRTC build.
3194         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
3195         * gtk/jhbuild.modules: Ditto.
3196         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
3197
3198 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3199
3200         [ES6] Implement ES6 template literals
3201         https://bugs.webkit.org/show_bug.cgi?id=142691
3202
3203         Reviewed by Darin Adler.
3204
3205         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
3206
3207         * Scripts/webkitperl/FeatureList.pm:
3208
3209 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3210
3211         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
3212         https://bugs.webkit.org/show_bug.cgi?id=144217
3213
3214         Reviewed by Darin Adler.
3215
3216         * WebKitTestRunner/PlatformEfl.cmake:
3217
3218 2015-04-26  Doug Russell  <d_russell@apple.com>
3219
3220         AX: richer text change notifications (142719)
3221         https://bugs.webkit.org/show_bug.cgi?id=142719
3222
3223         Reviewed by Darin Adler.
3224
3225         Richer accessibility value change notifications. Introduce AXTextEditType,
3226         postTextStateChangeNotification and postTextReplacementNotification to give assistive
3227         tech apps more reliable context for responding to changes in web content. Also implement
3228         a mechanism to post value changes in password form fields in coalesced ticks to thwart
3229         analyzing the cadence of changes.
3230
3231         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
3232         and an overload of postTextReplacementNotification to give assistive tech apps more
3233         reliable context for responding to changes in web content selection. Also block posting
3234         selection changes on password fields.
3235
3236         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
3237         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3238         (-[AccessibilityNotificationHandler stopObserving]):
3239         (-[AccessibilityNotificationHandler _notificationReceived:]):
3240         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3241         (AccessibilityUIElement::removeNotificationListener):
3242         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3243         (-[AccessibilityNotificationHandler _notificationReceived:]):
3244         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3245         (WTR::AccessibilityUIElement::removeNotificationListener):
3246
3247 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
3248
3249         Add myself to contributors.json
3250         https://bugs.webkit.org/show_bug.cgi?id=144204
3251
3252         Reviewed by Darin Adler.
3253
3254         * Scripts/webkitpy/common/config/contributors.json:
3255
3256 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
3257
3258         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
3259         https://bugs.webkit.org/show_bug.cgi?id=144182
3260
3261         Reviewed by Simon Fraser.
3262
3263         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
3264
3265 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
3266
3267         https://bugs.webkit.org/show_bug.cgi?id=144038
3268
3269         Reviewed by Ryosuke Niwa
3270
3271         Add a script to run Speedometer and JetStream on a browser.
3272
3273         * Scripts/run-benchmark: Wrapper script to run benchmark.
3274         (main):
3275         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
3276         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
3277         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
3278         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
3279         (BenchmarkBuilderFactory):
3280         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
3281         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
3282         (GenericBenchmarkBuilder):
3283         (GenericBenchmarkBuilder.prepare):
3284         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
3285         (GenericBenchmarkBuilder._applyPatch):
3286         (GenericBenchmarkBuilder.clean):
3287         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
3288         (JetStreamBenchmarkBuilder):
3289         (JetStreamBenchmarkBuilder.prepare):
3290         (JetStreamBenchmarkBuilder._runCreateScript):
3291         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
3292         (BenchmarkRunner):
3293         (BenchmarkRunner.__init__):
3294         (BenchmarkRunner.execute):
3295         (BenchmarkRunner.dump):
3296         (BenchmarkRunner.wrap):
3297         (BenchmarkRunner.merge):
3298         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
3299         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
3300         (BrowserDriver):
3301         (BrowserDriver.prepareEnv):
3302         (BrowserDriver.launchUrl):
3303         (BrowserDriver.closeBrowser):
3304         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
3305         (BrowserDriverFactory):
3306         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
3307         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
3308         (OSXChromeDriver):
3309         (OSXChromeDriver.prepareEnv):
3310         (OSXChromeDriver.launchUrl):
3311         (OSXChromeDriver.closeBrowsers):
3312         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
3313         (OSXSafariDriver):
3314         (OSXSafariDriver.prepareEnv):
3315         (OSXSafariDriver.launchUrl):
3316         (OSXSafariDriver.closeBrowsers):
3317         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
3318         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
3319         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
3320         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
3321         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
3322         (GenericFactory):
3323         (GenericFactory.iterateGetItem):
3324         (GenericFactory.create):
3325         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
3326         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
3327         (ServerControl):
3328         (ServerControl.render_GET):
3329         (ServerControl.render_POST):
3330         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
3331         (HTTPServerDriver):
3332         (HTTPServerDriver.serve):
3333         (HTTPServerDriver.fetchResult):
3334         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
3335         (HTTPServerDriverFactory):
3336         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
3337         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
3338         (SimpleHTTPServerDriver):
3339         (SimpleHTTPServerDriver.depends):
3340         (SimpleHTTPServerDriver.__init__):
3341         (SimpleHTTPServerDriver.serve):
3342         (SimpleHTTPServerDriver.baseUrl):
3343         (SimpleHTTPServerDriver.fetchResult):
3344         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
3345         (ModuleNotFoundError):
3346         (loadModule):
3347         (getPathFromProjectRoot):
3348         (loadJSONFromFile):
3349         (TimeoutError):
3350         (timeout):
3351         (timeout.__init__):
3352         (timeout.handle_timeout):
3353         (timeout.__enter__):
3354         (timeout.__exit__):
3355
3356 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3357
3358         Unreviewed, rolling out r183303.
3359         https://bugs.webkit.org/show_bug.cgi?id=144181
3360
3361         Change was incorrect, broke builds (Requested by smfr on
3362         #webkit).
3363
3364         Reverted changeset:
3365
3366         "Fix the build."
3367         http://trac.webkit.org/changeset/183303
3368
3369 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
3370
3371         Fix the build.
3372
3373         * MiniBrowser/mac/WK2BrowserWindowController.m:
3374         (-[WK2BrowserWindowController initWithConfiguration:]):
3375
3376 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3377
3378         Disable ActionMenusPDFTest due to timeout on test bot
3379
3380         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3381         (TestWebKitAPI::TEST):
3382
3383 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3384
3385         Unreviewed, rolling out r183266.
3386         https://bugs.webkit.org/show_bug.cgi?id=144164
3387
3388         Broke 32-bit build and a test. (Requested by ap on #webkit).
3389
3390         Reverted changeset:
3391
3392         "AX: richer text change notifications (142719)"
3393         https://bugs.webkit.org/show_bug.cgi?id=142719
3394         http://trac.webkit.org/changeset/183266
3395
3396 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3397
3398         REGRESSION: WebKit2.ActionMenusTest API test fails
3399         https://bugs.webkit.org/show_bug.cgi?id=144149
3400         <rdar://problem/20677770>
3401
3402         Reviewed by Tim Horton.
3403
3404         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
3405         as the 'ActionMenusPDFTest'.
3406         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3407         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
3408         to match the hit test on the 'action-menu-target.pdf' test file.
3409
3410 2015-04-24  Daniel Bates  <dabates@apple.com>
3411
3412         Cleanup: Use @memoized for property IOSSimulator.testing_device
3413         https://bugs.webkit.org/show_bug.cgi?id=141715
3414
3415         Reviewed by Darin Adler.
3416
3417         Simplify the caching of the result of IOSSimulator.testing_device
3418         and make the code more readable by making use of the @memoized declarator
3419         instead of explicitly managing a private instance variable,
3420         IOSSimulator._testing_device, for the cached result.
3421
3422         * Scripts/webkitpy/port/ios.py:
3423         (IOSPort.determine_full_port_name):
3424         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
3425         (IOSSimulatorPort):
3426         (IOSSimulatorPort.testing_device): No need to cache the created device object in
3427         IOSSimulatorPort._testing_device since we are marking this function @memoized.
3428         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
3429         of caching in local variable since we only make use of this value exactly once in this function.
3430         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
3431         been used since being added in r178622. So, we can remove this constructor since
3432         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
3433
3434 2015-04-24  Anders Carlsson  <andersca@apple.com>
3435
3436         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
3437         https://bugs.webkit.org/show_bug.cgi?id=144158
3438
3439         Reviewed by Beth Dakin.
3440
3441         * MiniBrowser/mac/WK2BrowserWindowController.m:
3442         (-[WK2BrowserWindowController initWithConfiguration:]):
3443
3444 2015-04-24  Doug Russell  <d_russell@apple.com>
3445
3446         AX: richer text change notifications (142719)
3447         https://bugs.webkit.org/show_bug.cgi?id=142719
3448
3449         Reviewed by Darin Adler.
3450
3451         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
3452
3453         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
3454
3455         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
3456         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3457         (-[AccessibilityNotificationHandler stopObserving]):
3458         (-[AccessibilityNotificationHandler _notificationReceived:]):
3459         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3460         (AccessibilityUIElement::removeNotificationListener):
3461         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3462         (-[AccessibilityNotificationHandler _notificationReceived:]):
3463         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3464         (WTR::AccessibilityUIElement::removeNotificationListener):
3465
3466 2015-04-24  Darin Adler  <darin@apple.com>
3467
3468         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
3469         https://bugs.webkit.org/show_bug.cgi?id=128007
3470
3471         Reviewed by Anders Carlsson.
3472
3473         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
3474         * DumpRenderTree/win/UIDelegate.h: Ditto.
3475
3476         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
3477         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
3478
3479         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
3480
3481         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
3482         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
3483         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
3484         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
3485         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3486         (WebKitDOMDOMWindowTest::create): Ditto.
3487         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3488         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
3489         of smart pointers to DelayedSIgnal objects.
3490         (uriChangedCallback): Ditto.
3491
3492 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3493
3494         [Mac] Unreviewed test fix.
3495         https://bugs.webkit.org/show_bug.cgi?id=144149
3496
3497         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3498         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
3499         test.
3500
3501 2015-04-23  Darin Adler  <darin@apple.com>
3502
3503         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
3504         https://bugs.webkit.org/show_bug.cgi?id=144090
3505
3506         Reviewed by Anders Carlsson.
3507
3508         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
3509
3510 2015-04-23  Michael Saboff  <msaboff@apple.com>
3511
3512         lldb macro btjs sometimes can't get a frame description
3513         https://bugs.webkit.org/show_bug.cgi?id=144130
3514
3515         Reviewed by Filip Pizlo.
3516
3517         We look to execute ExecState::describeFrame().  It appears that in some contexts the
3518         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
3519         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
3520
3521         * lldb/lldb_webkit.py:
3522         (btjs):
3523
3524 2015-04-23  Alex Christensen  <achristensen@webkit.org>
3525
3526         Use less memory when compiling content extensions.
3527         https://bugs.webkit.org/show_bug.cgi?id=144051
3528
3529         Reviewed by Darin Adler and Benjamin Poulain.
3530
3531         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3532         (TestWebKitAPI::TEST_F):
3533         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3534         (TestWebKitAPI::countLiveNodes):
3535
3536 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3537
3538         [CMake] Clean up JSC JIT options
3539         https://bugs.webkit.org/show_bug.cgi?id=143998
3540
3541         Reviewed by Filip Pizlo.
3542
3543         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
3544         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
3545
3546 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
3547
3548         [Mac] Extend action menus to support PDF
3549         https://bugs.webkit.org/show_bug.cgi?id=143895
3550         <rdar://problem/19003333>
3551
3552         Reviewed by Tim Horton.
3553
3554         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
3555         of PDF content works.
3556
3557         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
3558         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
3559         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
3560         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3561         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
3562         Update to support PDF tests.
3563         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
3564         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
3565
3566 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3567
3568         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
3569
3570         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3571         (beforeAll):
3572         (testWebViewAudioOnlyUserMediaPermissionRequests):
3573
3574 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3575
3576         Add myself to watchlist
3577         https://bugs.webkit.org/show_bug.cgi?id=144041
3578
3579         Reviewed by Alex Christensen.
3580
3581         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
3582
3583         * Scripts/webkitpy/common/config/watchlist:
3584
3585 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3586
3587         [GTK] MiniBrowser should use NetworkProcess by default
3588         https://bugs.webkit.org/show_bug.cgi?id=143948
3589
3590         Reviewed by Sergio Villar Senin.
3591
3592         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
3593         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
3594
3595         * MiniBrowser/gtk/main.c:
3596         (main):
3597
3598 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
3599
3600         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
3601
3602         Unreviewed build fix.
3603
3604         * Scripts/prepare-ChangeLog:
3605         (get_function_line_ranges_for_cpp):
3606         Use grep instead of any to determine if a string is an element of an array.
3607
3608 2015-04-21  Anders Carlsson  <andersca@apple.com>
3609
3610         Fix block signatures
3611         https://bugs.webkit.org/show_bug.cgi?id=144002
3612
3613         Reviewed by Andreas Kling.
3614
3615         * MiniBrowser/mac/WK2BrowserWindowController.m:
3616         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3617
3618 2015-04-21  Philippe Normand  <pnormand@igalia.com>
3619
3620         [GTK] jhbuild should not use a branch for openwebrtc
3621         https://bugs.webkit.org/show_bug.cgi?id=143981
3622
3623         Reviewed by Carlos Garcia Campos.
3624
3625         * gtk/jhbuild.modules:
3626
3627 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
3628
3629         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
3630
3631         Unreviewed build fix.
3632
3633         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
3634         However, it has been exposed by List::MoreUtils since its inception. This patch uses
3635         the any function exposed by List::MoreUtils for greater compatibility.
3636
3637         * Scripts/prepare-ChangeLog:
3638         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
3639         the any function in all of versions of Perl used by our infrastructure.
3640
3641 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3642
3643         Remove unnecessary logs when resetting tests.
3644
3645         * WebKitTestRunner/mac/TestControllerMac.mm:
3646         (WTR::TestController::platformResetPreferencesToConsistentValues):
3647         In r183020 I added some logs when compiling or removing content extensions fails.
3648         We often try to remove a content extension that does not exist, and that is not a problem.
3649
3650 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3651
3652         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
3653         https://bugs.webkit.org/show_bug.cgi?id=143897
3654
3655         Reviewed by David Kilzer.
3656
3657         This is a speculative fix that addresses two issues:
3658
3659         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
3660         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
3661
3662         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
3663         Before: (723, 729)
3664         After: (721, 720)
3665
3666         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
3667         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
3668
3669         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
3670         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
3671
3672         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
3673
3674         2. Creating git diffs from HEAD and not origin/master by default.
3675
3676         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
3677         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
3678
3679         * Scripts/prepare-ChangeLog:
3680         (originalFile):
3681         Use HEAD instead of origin/master in default Git case.
3682
3683         (generateFunctionLists):
3684         Ensure that the end line is not less than the start line.
3685
3686         (extractLineRangeAfterChange):
3687         Set the end line to the start line if the end line is less than the start line.
3688
3689         (extractLineRangeBeforeChange):
3690         Ditto.
3691
3692 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
3693
3694         Suppress warning in prepare-ChangeLog.
3695         https://bugs.webkit.org/show_bug.cgi?id=143882
3696
3697         Reviewed by David Kilzer.
3698
3699         Prune noisy prepare-ChangeLog output by using the List::Util::any function
3700         instead of the deprecated smartmatch operator.
3701
3702         * Scripts/prepare-ChangeLog:
3703         Import the List::Util::any function.
3704
3705         (get_function_line_ranges_for_cpp):
3706         Use the any function instead of smartmatch.
3707
3708 2015-04-20  Anders Carlsson  <andersca@apple.com>
3709
3710         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
3711         https://bugs.webkit.org/show_bug.cgi?id=143966
3712
3713         Reviewed by Dan Bernstein.
3714
3715         * MiniBrowser/mac/WK2BrowserWindowController.m:
3716         (dataTypes):
3717         (-[WK2BrowserWindowController fetchWebsiteData:]):
3718         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3719         (-[WK2BrowserWindowController clearWebsiteData:]):
3720
3721 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3722
3723         Fix content extension test flakiness.
3724         https://bugs.webkit.org/show_bug.cgi?id=143950
3725
3726         Reviewed by Brady Eidson.
3727
3728         * WebKitTestRunner/mac/TestControllerMac.mm:
3729         (WTR::TestController::platformResetPreferencesToConsistentValues):
3730         Remove the TestContentExtensions if it exists.
3731         (WTR::TestController::platformConfigureViewForTest):
3732         Log errors in case there are any.
3733
3734 2015-04-20  Alex Christensen  <achristensen@webkit.org>
3735
3736         Properly report errors from _WKUserContentExtensionStore.
3737         https://bugs.webkit.org/show_bug.cgi?id=143808
3738
3739         Reviewed by Darin Adler.
3740
3741         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3742         (TEST_F):
3743
3744 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3745
3746         Add a rule for NetworkCache to watchlist file
3747         https://bugs.webkit.org/show_bug.cgi?id=143945
3748
3749         Reviewed by Sergio Villar Senin.
3750
3751         And add myself to the list of watchers.
3752
3753         * Scripts/webkitpy/common/config/watchlist:
3754
3755 2015-04-19  Darin Adler  <darin@apple.com>
3756
3757         Update RefPtr documentation and deprecation
3758         https://bugs.webkit.org/show_bug.cgi?id=143936
3759
3760         Reviewed by Andreas Kling.
3761
3762         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
3763
3764 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3765
3766         Introduce bytecode intrinsics
3767         https://bugs.webkit.org/show_bug.cgi?id=143926
3768
3769         Reviewed by Filip Pizlo.
3770
3771         Change cpplint to accept emit_intrinsic_XXX.
3772
3773         * Scripts/webkitpy/style/checkers/cpp.py:
3774         (check_identifier_name_in_declaration):
3775
3776 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
3777
3778         Fix lldb_webkit.py to show StringImpls correctly
3779         https://bugs.webkit.org/show_bug.cgi?id=143920
3780
3781         Reviewed by Andreas Kling.
3782         
3783         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
3784
3785         * lldb/lldb_webkit.py:
3786         (WTFStringImplProvider.is_8bit):
3787
3788 2015-04-17  Daniel Bates  <dabates@apple.com>
3789
3790         Not able to build WebKit against iOS Simulator 8.3 SDK
3791         https://bugs.webkit.org/show_bug.cgi?id=143883
3792
3793         Reviewed by David Kilzer.
3794
3795         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
3796         so that Xcode uses them.
3797
3798         * Scripts/copy-webkitlibraries-to-product-directory:
3799
3800 2015-04-17  Beth Dakin  <bdakin@apple.com>
3801
3802         Force mouse events should go through normal mouse event handling code paths
3803         https://bugs.webkit.org/show_bug.cgi?id=143749
3804         -and corresponding-
3805         rdar://problem/20472895
3806
3807         Reviewed by Dean Jackson.
3808
3809         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3810         Since there is not a way to create an NSEventTypePressure from scratch, we 
3811         subclass NSEvent and override all of the critical methods.
3812
3813         * WebKitTestRunner/EventSenderProxy.h:
3814         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3815         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3816         (WTR::EventSendingController::mouseForceDown):
3817         (WTR::EventSendingController::mouseForceUp):
3818         (WTR::EventSendingController::mouseForceChanged):
3819         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3820         * WebKitTestRunner/TestController.cpp:
3821         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3822         * WebKitTestRunner/mac/EventSenderProxy.mm:
3823         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3824         (-[EventSenderPressureEvent timestamp]):
3825         (-[EventSenderPressureEvent type]):
3826         (-[EventSenderPressureEvent locationInWindow]):
3827         (-[EventSenderPressureEvent location]):
3828         (-[EventSenderPressureEvent stage]):
3829         (-[EventSenderPressureEvent pressure]):
3830         (-[EventSenderPressureEvent phase]):
3831         (-[EventSenderPressureEvent eventNumber]):
3832         (WTR::EventSenderProxy::mouseForceDown):
3833         (WTR::EventSenderProxy::mouseForceUp):
3834         (WTR::EventSenderProxy::mouseForceChanged):
3835
3836 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
3837
3838         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
3839         https://bugs.webkit.org/show_bug.cgi?id=143885
3840
3841         Reviewed by Tim Horton.
3842
3843         Fixed a case where we have two builds with the same revision(s). An in order build
3844         is one for which the revision is strictly higher.
3845
3846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3847         (BuildbotQueue.prototype._checkForInOrderResult):
3848         (BuildbotQueue.prototype.compareIterationsByRevisions):
3849
3850 2015-04-17  Commit Queue  <commit-queue@webkit.org>
3851
3852         Unreviewed, rolling out r182912 and r182920.
3853         https://bugs.webkit.org/show_bug.cgi?id=143881
3854
3855         Build breakage in some configurations (Requested by ap on
3856         #webkit).
3857
3858         Reverted changesets:
3859
3860         "Force mouse events should go through normal mouse event
3861         handling code paths"
3862         https://bugs.webkit.org/show_bug.cgi?id=143749
3863         http://trac.webkit.org/changeset/182912
3864
3865         http://trac.webkit.org/changeset/182920
3866
3867 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3868
3869         [GTK] One more unreviewed fix after r182882.
3870
3871         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
3872
3873 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
3874
3875         [GTK] Unreviewed speculative clean build fix after r182882.
3876
3877         TestWebKitAPI's forwarding header generator depended on WeKit2's
3878         which generated SOUP related forwarding headers too.
3879
3880         This dependency isn't necessary and was removed by r182882 to make
3881         forwarding header generators parallelizable. But in this case
3882         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
3883         should generate SOUP related forwarding headers too similar to EFL.
3884
3885         * TestWebKitAPI/PlatformGTK.cmake:
3886         * WebKitTestRunner/PlatformGTK.cmake:
3887
3888 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3889
3890         [SOUP] Redirect to non HTTP destination is broken
3891         https://bugs.webkit.org/show_bug.cgi?id=143866
3892
3893         Reviewed by Sergio Villar Senin.
3894
3895         Add a unit test to check that redirect to a data URI works.
3896
3897         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3898         (testRedirectToDataURI):
3899         (serverCallback):
3900         (beforeAll):
3901
3902 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3903
3904         Changes method of quitting iOS Simulator to be more correct.
3905         https://bugs.webkit.org/show_bug.cgi?id=143847
3906         <rdar://problem/20530344>
3907
3908         Reviewed by Darin Adler.
3909
3910         Fixes by addressing the app by ID rather than by name.
3911
3912         * Scripts/webkitdirs.pm:
3913         (quitIOSSimulator):
3914         * Scripts/webkitpy/port/ios.py:
3915         (IOSSimulatorPort.check_sys_deps):
3916
3917 2015-04-16  Anders Carlsson  <andersca@apple.com>
3918
3919         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
3920         https://bugs.webkit.org/show_bug.cgi?id=143844
3921
3922         Reviewed by Dan Bernstein.
3923
3924         * MiniBrowser/mac/AppDelegate.m:
3925         (-[BrowserAppDelegate newPrivateWindow:]):
3926         * MiniBrowser/mac/WK2BrowserWindowController.m:
3927         (-[WK2BrowserWindowController initWithConfiguration:]):
3928         (-[WK2BrowserWindowController fetchWebsiteData:]):
3929         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3930         (-[WK2BrowserWindowController clearWebsiteData:]):
3931
3932 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3933
3934         32-bit build fix.
3935
3936         * WebKitTestRunner/mac/TestControllerMac.mm:
3937         (WTR::TestController::platformResetPreferencesToConsistentValues):
3938         (WTR::TestController::platformConfigureViewForTest):
3939         Added WK_API_ENABLED.
3940
3941 2015-04-16  Alex Christensen  <achristensen@webkit.org>
3942
3943         Removed unused WKUserContentFilterRef.
3944         https://bugs.webkit.org/show_bug.cgi?id=143852
3945
3946         Reviewed by Sam Weinig.
3947
3948         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3949         * WebKitTestRunner/mac/TestControllerMac.mm:
3950         (WTR::TestController::platformResetPreferencesToConsistentValues):
3951         (WTR::TestController::platformConfigureViewForTest):
3952
3953 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
3954
3955         Unreviewed. Adding myself as a commiter in contributers.json.
3956
3957         * Scripts/webkitpy/common/config/contributors.json:
3958
3959 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
3960
3961         It is very hard to attach a debugger to WebProcess to debug tests
3962         https://bugs.webkit.org/show_bug.cgi?id=143837
3963
3964         Reviewed by Chris Dumez.
3965
3966         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
3967         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
3968
3969         Now it disables all timeouts in tools, as is best for debugging tests.
3970
3971         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
3972         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
3973
3974         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
3975         now has the same functionality.
3976
3977 2015-04-16  Beth Dakin  <bdakin@apple.com>
3978
3979         Force mouse events should go through normal mouse event handling code paths
3980         https://bugs.webkit.org/show_bug.cgi?id=143749
3981         -and corresponding-
3982         rdar://problem/20472895
3983
3984         Reviewed by Dean Jackson.
3985
3986         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
3987         Since there is not a way to create an NSEventTypePressure from scratch, we 
3988         subclass NSEvent and override all of the critical methods.
3989
3990         * WebKitTestRunner/EventSenderProxy.h:
3991         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3992         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3993         (WTR::EventSendingController::mouseForceDown):
3994         (WTR::EventSendingController::mouseForceUp):
3995         (WTR::EventSendingController::mouseForceChanged):
3996         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3997         * WebKitTestRunner/TestController.cpp:
3998         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3999         * WebKitTestRunner/mac/EventSenderProxy.mm:
4000         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
4001         (-[EventSenderPressureEvent timestamp]):
4002         (-[EventSenderPressureEvent type]):
4003         (-[EventSenderPressureEvent locationInWindow]):
4004         (-[EventSenderPressureEvent location]):
4005         (-[EventSenderPressureEvent stage]):
4006         (-[EventSenderPressureEvent pressure]):
4007         (-[EventSenderPressureEvent phase]):
4008         (-[EventSenderPressureEvent eventNumber]):
4009         (WTR::EventSenderProxy::mouseForceDown):
4010         (WTR::EventSenderProxy::mouseForceUp):
4011         (WTR::EventSenderProxy::mouseForceChanged):
4012
4013 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
4014
4015         [EFL] Bump LLVM to version 3.6.0 on X86_64
4016         https://bugs.webkit.org/show_bug.cgi?id=143604
4017
4018         Reviewed by Gyuyoung Kim.
4019
4020         * efl/jhbuild.modules:
4021         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
4022         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
4023         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
4024         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
4025
4026 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
4027
4028         [EFL] Remove an unnecessary workaround from jhbuildrc
4029         https://bugs.webkit.org/show_bug.cgi?id=143823
4030
4031         Reviewed by Gyuyoung Kim.
4032
4033         * efl/jhbuildrc:
4034
4035 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
4036
4037         [GTK] Run forwarding headers generator unconditionally
4038         https://bugs.webkit.org/show_bug.cgi?id=143819
4039
4040         Reviewed by Carlos Garcia Campos.
4041
4042         * TestWebKitAPI/PlatformGTK.cmake:
4043         * WebKitTestRunner/PlatformGTK.cmake:
4044
4045 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4046
4047         [EFL] Add gnutls to jhbuild.module
4048         https://bugs.webkit.org/show_bug.cgi?id=143777
4049
4050         Reviewed by Csaba Osztrogonác.
4051
4052         EFL port has required at least 3.0.0 version of gnutls since r176712.
4053         However some old linux distributions don't support 3.0.0 version. Besides
4054         other projects sometimes need to use lower version of gnutls.
4055
4056         This patch supports to download gnutls through jhbuild, and use it.
4057
4058         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
4059         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
4060
4061 2015-04-15  Mark Lam  <mark.lam@apple.com>
4062
4063         Remove obsolete VMInspector debugging tool.
4064         https://bugs.webkit.org/show_bug.cgi?id=143798
4065
4066         Reviewed by Michael Saboff.
4067
4068         * TestWebKitAPI/CMakeLists.txt:
4069         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4070         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
4071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4072         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
4073
4074 2015-04-15  Jer Noble  <jer.noble@apple.com>
4075
4076         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
4077
4078         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
4079
4080 2015-04-15  Jer Noble  <jer.noble@apple.com>
4081
4082         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
4083
4084         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
4085         (TestWebKitAPI::TEST_F):
4086
4087 2015-04-15  Chris Dumez  <cdumez@apple.com>
4088
4089         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
4090         https://bugs.webkit.org/show_bug.cgi?id=143779
4091
4092         Reviewed by Brent Fulgham.
4093
4094         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
4095         similarly to what is done on Mac / WK1. Without this, PageCache could
4096         stay enabled after page cache tests and cause weird behaviors.
4097
4098         * DumpRenderTree/win/DumpRenderTree.cpp:
4099         (resetWebPreferencesToConsistentValues):
4100
4101 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
4102
4103         Re-enable custom dilation for antialiased fonts
4104         https://bugs.webkit.org/show_bug.cgi?id=143738
4105
4106         Reviewed by Tim Horton.
4107         
4108         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
4109         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
4110         a private WebKit pref. This pref defaults to YES, enabling the feature by default
4111         in WK1 as we do for WK2.
4112
4113         * DumpRenderTree/mac/DumpRenderTree.mm:
4114         (resetWebPreferencesToConsistentValues):
4115         * WebKitTestRunner/TestController.cpp:
4116         (WTR::TestController::resetPreferencesToConsistentValues):
4117
4118 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
4119
4120         Correct layering violation in DumpRenderTree Build
4121         https://bugs.webkit.org/show_bug.cgi?id=143732
4122
4123         Reviewed by Simon Fraser.
4124
4125         Correct a layering violation in DumpRenderTree by calling functions on the
4126         WebCoreTestSupport library, rather than attempting to work with WebCore
4127         types directly.
4128
4129         * DumpRenderTree/mac/EventSendingController.mm:
4130         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
4131         than WebCore itself.,
4132         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
4133
4134 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
4135
4136         Add a conservative DFA minimizer for the content extension matcher
4137         https://bugs.webkit.org/show_bug.cgi?id=143501
4138
4139         Reviewed by Alex Christensen.
4140
4141         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4142         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
4143
4144 2015-04-14  Daniel Bates  <dabates@apple.com>
4145
4146         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
4147         https://bugs.webkit.org/show_bug.cgi?id=143693
4148         <rdar://problem/20530316>
4149
4150         Reviewed by Tim Horton.
4151
4152         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
4153         to use the fixed layout code on iOS at this time.
4154
4155         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
4156
4157 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
4158
4159         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
4160         https://bugs.webkit.org/show_bug.cgi?id=143705
4161
4162         Unreviewed change to watchlist file.
4163
4164         * Scripts/webkitpy/common/config/watchlist:
4165
4166 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
4167
4168         [EFL] favicon wasn't updated for google.com sometimes.
4169         https://bugs.webkit.org/show_bug.cgi?id=141940
4170
4171         Reviewed by Gyuyoung Kim.
4172
4173         As elm_entry_utf8_to_markup can include additional characters, parameter for the
4174         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
4175
4176         * MiniBrowser/efl/main.c:
4177         (on_url_changed):
4178
4179 2015-04-13  Tim Horton  <timothy_horton@apple.com>
4180
4181         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
4182         https://bugs.webkit.org/show_bug.cgi?id=143560
4183         <rdar://problem/16302047>
4184
4185         Reviewed by Darin Adler.
4186
4187         * MiniBrowser/mac/BrowserWindowController.h:
4188         * MiniBrowser/mac/MainMenu.xib:
4189         * MiniBrowser/mac/WK1BrowserWindowController.m:
4190         (-[WK1BrowserWindowController setScale:]):
4191         * MiniBrowser/mac/WK2BrowserWindowController.m:
4192         (viewScaleForMenuItemTag):
4193         (-[WK2BrowserWindowController setScale:]):
4194         (-[WK2BrowserWindowController validateMenuItem:]):
4195         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
4196         When in use, we resize the window so that the view fits correctly, and
4197         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
4198         layout size will not change when scaling down (but will update appropriately
4199         when the view is resized).
4200
4201 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
4202
4203         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
4204         https://bugs.webkit.org/show_bug.cgi?id=138630
4205
4206         Reviewed by Tim Horton.
4207
4208         Make sure that we always load at least one in order productive iteration.
4209
4210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4211         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
4212         is done loading at least one iteration that wasn't an out of order build.
4213         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
4214         when that's needed to check for out of order builds.
4215         (BuildbotQueue.prototype.update): Ditto.
4216         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
4217         result, and if it does not, load more iterations.
4218         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
4219         an in order iteration loaded too.
4220         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
4221         corrected to always sort loaded iterations before unloaded ones.
4222
4223 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
4224
4225         Expand test infrastructure to support scrolling tests
4226         https://bugs.webkit.org/show_bug.cgi?id=143286
4227         <rdar://problem/20375516>
4228
4229         Reviewed by Simon Fraser.
4230
4231         Extend the WK1 and WK2 test programs to support two new EventSender commands:
4232         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
4233         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
4234         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
4235         relevant rubberband, scroll, and scroll-snap animations are finished.
4236
4237         * DumpRenderTree/mac/EventSendingController.mm:
4238         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
4239         and 'monitorWheelEvents'.
4240         (+[EventSendingController webScriptNameForSelector:]): Ditto.
4241         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
4242         debugging test failures.
4243         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
4244         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
4245         function, then passes it to WebCore to be called once the test deferrals have been cleared.
4246         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
4247         'callAfterScrollingCompletes' method.
4248         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
4249         and 'monitorWheelEvents'.
4250         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4251         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
4252         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
4253         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
4254         'callAfterScrollingComplates' method.
4255         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4256
4257 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
4258
4259         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
4260         https://bugs.webkit.org/show_bug.cgi?id=143656
4261
4262         Reviewed by Darin Adler.
4263
4264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4265         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4266
4267 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
4268
4269         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
4270         https://bugs.webkit.org/show_bug.cgi?id=142387
4271
4272         Reviewed by Carlos Garcia Campos.
4273
4274         Running mixed content is blocked by default since r181134. Updated
4275         the test case to reflect the new default settings.
4276
4277         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
4278         (testInsecureContent):
4279
4280 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4281
4282         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
4283         https://bugs.webkit.org/show_bug.cgi?id=143667
4284
4285         Reviewed by Csaba Osztrogonác.
4286
4287         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
4288         since r169017. Added $hardwareConcurrencySupport for it.
4289
4290         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
4291
4292         * Scripts/webkitperl/FeatureList.pm:
4293
4294 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
4295
4296         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
4297         https://bugs.webkit.org/show_bug.cgi?id=143664
4298
4299         Reviewed by Gyuyoung Kim.
4300
4301         * Scripts/webkitperl/FeatureList.pm:
4302
4303 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4304
4305         [EFL] Enable Media Source
4306         https://bugs.webkit.org/show_bug.cgi?id=143635
4307
4308         Reviewed by Csaba Osztrogonác.
4309
4310         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
4311
4312 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
4313
4314         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
4315         https://bugs.webkit.org/show_bug.cgi?id=143646
4316
4317         Reviewed by David Kilzer.
4318
4319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4320         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4321
4322 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
4323
4324         Use en_US spell checker for tests on Mac instead of Multilingual
4325         https://bugs.webkit.org/show_bug.cgi?id=143641
4326
4327         Reviewed by Dan Bernstein.
4328
4329         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
4330         While at it, override NSUserDictionaryReplacementItems, so that user replacements
4331         cannot affect tests.
4332
4333         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
4334         Made this more like WebKit1 version.
4335
4336 2015-04-10  Tim Horton  <timothy_horton@apple.com>