[wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
4
5         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
6         (LayoutTestController::shadowRoot):
7
8 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
9
10         Unreviewed, fix exception in rebaseline tool.
11
12         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
13
14 2011-04-02  Beth Dakin  <bdakin@apple.com>
15
16         Rubber-stamped by Geoff Garen.
17
18         For Dan!
19         * DumpRenderTree/mac/DumpRenderTree.mm:
20         (resetWebViewToConsistentStateBeforeTesting):
21
22 2011-04-02  Beth Dakin  <bdakin@apple.com>
23
24         Rubber-stamped by Geoff Garen.
25
26         Need to reset the scale, much like zoom.
27         * DumpRenderTree/mac/DumpRenderTree.mm:
28         (resetWebViewToConsistentStateBeforeTesting):
29
30 2011-04-02  Sam Weinig  <sam@webkit.org>
31
32         Reviewed by Beth Dakin.
33
34         https://bugs.webkit.org/show_bug.cgi?id=57605
35         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
36         getClientRects()
37         -and corresponding-
38         <rdar://problem/9194541>
39
40         Add DRT support for the scaleWebView SPI.
41         * DumpRenderTree/mac/EventSendingController.mm:
42         (+[EventSendingController isSelectorExcludedFromWebScript:]):
43         (+[EventSendingController webScriptNameForSelector:]):
44         (-[EventSendingController scalePageBy:atX:andY:]):
45         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
46         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
47         (WTR::EventSendingController::scalePageBy):
48         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
49         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
50         (WTR::InjectedBundlePage::reset):
51
52 2011-04-02  Dominic Cooney  <dominicc@google.com>
53
54         Reviewed by Martin Robinson.
55
56         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
57         https://bugs.webkit.org/show_bug.cgi?id=57551
58
59         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
60         (LayoutTestController::shadowRoot):
61
62 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
63
64         Reviewed by Eric Seidel.
65
66         Remove AbstractStep._run_script and move script names to ports.py
67         https://bugs.webkit.org/show_bug.cgi?id=57704
68
69         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
70
71         * Scripts/webkitpy/common/config/ports.py:
72         * Scripts/webkitpy/tool/commands/download_unittest.py:
73         * Scripts/webkitpy/tool/commands/roll_unittest.py:
74         * Scripts/webkitpy/tool/commands/upload_unittest.py:
75         * Scripts/webkitpy/tool/steps/abstractstep.py:
76         * Scripts/webkitpy/tool/steps/checkstyle.py:
77         * Scripts/webkitpy/tool/steps/preparechangelog.py:
78         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
79         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
80
81 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
82
83         Reviewed by Eric Seidel.
84
85         Emulate shebang on Win32
86         https://bugs.webkit.org/show_bug.cgi?id=55927
87
88         Scripts on Windows work only if they are called with the explicit interpreter.
89         Read the first line of scripts to detect the correct executable.
90
91         * Scripts/webkitpy/common/config/ports.py:
92         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
93         * Scripts/webkitpy/common/system/executive_unittest.py:
94
95 2011-04-01  Adam Barth  <abarth@webkit.org>
96
97         Reviewed by Eric Seidel.
98
99         apos entities shouldn't show up in ChangeLogs when using webkit-patch
100         https://bugs.webkit.org/show_bug.cgi?id=57692
101
102         Previously, we were using BeautifulSoup to process XML from
103         bugs.webkit.org, but that's incorrect.  We should be using
104         BeautifulStoneSoup to process the XML.  We were getting the &apos;
105         entity wrong because &apos; is an XML entity but not an HTML entity.
106
107         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
108         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
109
110 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
111
112         Unreviewed, rolling out r82721.
113         http://trac.webkit.org/changeset/82721
114         https://bugs.webkit.org/show_bug.cgi?id=57687
115
116         This patch introduced assertion failures on the GTK+ bots.
117         (Requested by mrobinson on #webkit).
118
119         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
120         (LayoutTestController::shadowRoot):
121
122 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
123
124         Unreviewed buildfix.
125
126         [Qt][WK2] Build Webkit2 using "-2" option on Qt
127         https://bugs.webkit.org/show_bug.cgi?id=55074
128
129         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
130         (The isWK2() function removes it from @ARGV, but not from @options.)
131
132 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
133
134         Reviewed by Csaba Osztrogonác.
135
136         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
137         https://bugs.webkit.org/show_bug.cgi?id=57666
138
139         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
140
141 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
142
143         Reviewed by Adam Barth.
144
145         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
146
147         We apparently never implemented the code to skip tests based on
148         what was compiled into DRT. Also, change the logic used to skip
149         platform directories to match what old-run-webkit-tests does: 
150         skip every test not in a directory in the baseline search path.
151
152         https://bugs.webkit.org/show_bug.cgi?id=57662
153
154         * Scripts/webkitpy/layout_tests/port/mac.py:
155         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
156         * Scripts/webkitpy/layout_tests/port/webkit.py:
157
158 2011-03-29  Mark Rowe  <mrowe@apple.com>
159
160         Reviewed by Jon Honeycutt.
161
162         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
163
164         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
165
166         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
167         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
168         * Scripts/webkitpy/layout_tests/port/mac.py:
169         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
170
171 2011-04-01  Chang Shu  <cshu@webkit.org>
172
173         Reviewed by Csaba Osztrogonác.
174
175         [Qt][WK2] Build Webkit2 using "-2" option on Qt
176         https://bugs.webkit.org/show_bug.cgi?id=55074
177
178         * Scripts/build-webkit:
179
180 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
181
182         Reviewed by Tony Chang.
183
184         new-run-webkit-tests: remove spurious port version override in webkit.py
185         base.py provides a default implementation so this is just
186         breaking things.
187
188         https://bugs.webkit.org/show_bug.cgi?id=57667
189
190         * Scripts/webkitpy/layout_tests/port/webkit.py:
191         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
192
193 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
194
195         Reviewed by Adam Roben.
196
197         Make view results on waterfall direct link to results.html
198         https://bugs.webkit.org/show_bug.cgi?id=57671
199
200         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
201         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
202
203 2011-04-01  Sam Weinig  <sam@webkit.org>
204
205         Fix windows build.
206
207         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
208         (TestWebKitAPI::TEST):
209         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
210         (TestWebKitAPI::flushMessages):
211
212 2011-04-01  Sam Weinig  <sam@webkit.org>
213
214         Reviewed by Adam Roben.
215
216         Add adoptWK to WKRetainPtr.h
217         https://bugs.webkit.org/show_bug.cgi?id=57670
218
219         * TestWebKitAPI/PlatformUtilities.h:
220         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
221         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
222         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
223         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
224         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
225         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
226         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
227         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
228         (TestWebKitAPI::createSessionStateContainingFormData):
229         * WebKitTestRunner/StringFunctions.h:
230         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
231
232 2011-04-01  Sam Weinig  <sam@webkit.org>
233
234         Reviewed by Adam Roben.
235
236         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
237
238         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
239         (WTR::LayoutTestController::shadowRoot):
240         Make judicious use of adoptWK().
241
242 2011-04-01  Sam Weinig  <sam@webkit.org>
243
244         Reviewed by Timothy Hatcher.
245
246         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
247
248         * Scripts/extract-localizable-strings:
249
250 2011-04-01  Anders Carlsson  <andersca@apple.com>
251
252         Reviewed by Sam Weinig.
253
254         Shockwave plug-in doesn't accept mouse events
255         https://bugs.webkit.org/show_bug.cgi?id=57653
256         <rdar://problem/8483273>
257
258         Add a plug-in test.
259
260         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
261         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
262         (PluginTest::indicateTestFailure):
263         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
264
265         (PluginTest::NPN_ConvertPoint):
266         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
267         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
268         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
269         Call indicateTestFailure.
270
271         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
272         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
273         (ConvertPoint::ConvertPoint):
274         (ConvertPoint::testConvert):
275         (ConvertPoint::NPP_New):
276
277 2011-04-01  Dominic Cooney  <dominicc@google.com>
278
279         Reviewed by Martin Robinson.
280
281         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
282         https://bugs.webkit.org/show_bug.cgi?id=57551
283
284         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
285         (LayoutTestController::shadowRoot):
286
287 2011-04-01  Sam Weinig  <sam@webkit.org>
288
289         Reviewed by Anders Carlsson.
290
291         WebKitTestRunner needs layoutTestController.shadowRoot
292         https://bugs.webkit.org/show_bug.cgi?id=57661
293
294         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
295         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
296         (WTR::LayoutTestController::shadowRoot):
297         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
298         Implement layoutTestController.shadowRoot for WebKit2.
299
300 2011-04-01  Chang Shu  <cshu@webkit.org>
301
302         Reviewed by Darin Adler.
303
304         WebKitTestRunner needs layoutTestController.setDatabaseQuota
305         https://bugs.webkit.org/show_bug.cgi?id=57568
306
307         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
308         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
309         (WTR::LayoutTestController::setDatabaseQuota):
310         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
311
312 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
313
314         Reviewed by Tony Chang.
315
316         This patch completes the cleanup of
317         rebaseline-chromium-webkit-tests to work with all of the
318         variants of a platform (we can now rebaseline gpu- and non-gpu
319         files at the same time).
320
321         When the rebaselining is complete, any lines declared as
322         REBASELINE in the expectations file that matches a test that was
323         actually rebaselined will be deleted, even if only one of the
324         variants was actually rebaselined. This may cause odd problems,
325         but is better than where we're at today.
326
327         This change removes the -g flag and deprecates -w. The -g flag is gone
328         because GPU baselines are handled just like any other variant.
329         The -w flag is deprecated because this tool now only works
330         against the canaries, since that's the only place we have a full
331         set of bots. It will be trivial to change this to
332         build.webkit.org if we decide that's where we want them to be.
333
334         Also, this patch deletes a lot of cruft that is no longer needed
335         in the test_expectations code and the port-specific code.
336
337         https://bugs.webkit.org/show_bug.cgi?id=55191
338
339         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
340         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
341         * Scripts/webkitpy/layout_tests/port/base.py:
342         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
343         * Scripts/webkitpy/layout_tests/port/chromium.py:
344         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
345         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
346         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
347         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
348         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
349         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
350         * Scripts/webkitpy/layout_tests/port/mac.py:
351         * Scripts/webkitpy/layout_tests/port/test.py:
352         * Scripts/webkitpy/layout_tests/port/webkit.py:
353         * Scripts/webkitpy/layout_tests/port/win.py:
354         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
355         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
356
357 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
358
359         Reviewed by Adam Barth.
360
361         rebaseline-chromium-webkit-tests does not work correctly with
362         version-specific baselines. This patch updates the tool to use
363         all of the version-specific bots on the canaries, and will now
364         attempt to rebaseline all of the versions by default, although
365         it will not update both GPU and CPU versions.
366         
367         Also, it will no longer modify the test_expectations.txt file
368         *at all*. You will have to manually delete the REBASELINE lines
369         after running the tool and determining that it did what you
370         wanted it to do. This should be fixed in a separate bug - see
371         webkit bug #55191.
372
373         https://bugs.webkit.org/show_bug.cgi?id=55608
374
375         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
376         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
377         * Scripts/webkitpy/layout_tests/port/chromium.py:
378         * Scripts/webkitpy/layout_tests/port/test.py:
379         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
380         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
381
382 2011-03-31  Tony Chang  <tony@chromium.org>
383
384         Reviewed by Ojan Vafai.
385
386         [chromium] update the rebaseline tool to know about pngs with checksums
387         https://bugs.webkit.org/show_bug.cgi?id=57481
388
389         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
390         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
391
392 2011-04-01  Adam Roben  <aroben@apple.com>
393
394         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
395
396         Previously, we were getting the revision of the first revision that triggered a build.
397         Choosing the last revision would have been more accurate. But got_revision is what is used
398         everywhere else on build.webkit.org, and should work even when there were no changes that
399         triggered a build (e.g., if someone clicked the Force Build button).
400
401         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
402         recent builds list
403
404         Reviewed by Anders Carlsson.
405
406         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
407         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
408         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
409
410         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
411         (Array.prototype.first): Added this helper function to return the first element in an array
412         that matches the given predicate, or null if no such element exists.
413
414 2011-03-31  Adam Roben  <aroben@apple.com>
415
416         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
417
418         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
419
420         Reviewed by Darin Adler.
421
422         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
423         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
424         URL on its own line.
425
426         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
427         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
428         progression, and added a new test that uses a short bug URL while I was at it.
429
430 2011-04-01  Adam Roben  <aroben@apple.com>
431
432         Mark .vcproj/.vsprops/.sln files as being Windows-only
433
434         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
435
436         Reviewed by Anders Carlsson.
437
438         * Scripts/webkitpy/common/config/build.py:
439         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
440         directories as Windows-only.
441
442         * Scripts/webkitpy/common/config/build_unittest.py:
443         (ShoulBuildTest): Added test cases for the above.
444
445 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
446
447         Reviewed by Laszlo Gombos.
448
449         [Qt] Build MiniBrowser for Symbian
450         https://bugs.webkit.org/show_bug.cgi?id=56319
451
452         Have MiniBrowser reference it's own copy of useragentlist.txt instead
453         of copying QtTestBrowser's.
454         Remove Tools/MiniBrowser/DerivedSources.pro
455         This reduces complexity in the Tools scripts due to Symbian limitations.
456
457         * DerivedSources.pro:
458         * MiniBrowser/DerivedSources.pro: Removed.
459         * MiniBrowser/MiniBrowser.qrc:
460         * MiniBrowser/qt/MiniBrowser.pro:
461         * Scripts/webkitdirs.pm:
462
463 2011-03-31  Chang Shu  <cshu@webkit.org>
464
465         Reviewed by Darin Adler.
466
467         WebKitTestRunner needs layoutTestController.clearAllDatabases
468         https://bugs.webkit.org/show_bug.cgi?id=42540
469
470         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
471         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
472         (WTR::InjectedBundle::beginTesting):
473         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
474         (WTR::LayoutTestController::clearAllDatabases):
475         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
476
477 2011-03-31  Chang Shu  <cshu@webkit.org>
478
479         Reviewed by Darin Adler.
480
481         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
482         https://bugs.webkit.org/show_bug.cgi?id=42692
483
484         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
485
486 2011-03-31  Darin Adler  <darin@apple.com>
487
488         Reviewed by Sam Weinig.
489
490         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
491         https://bugs.webkit.org/show_bug.cgi?id=57573
492
493         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
494         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
495         Removed fake definitions of keyDown and contextClick.
496
497         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
498         (WTR::operator==): Added. So we can compare two WKPoint structs.
499         (WTR::parseModifier): Added.
500         (WTR::parseModifierArray): Added.
501         (WTR::EventSendingController::EventSendingController): Initialize the
502         new data members.
503         (WTR::EventSendingController::mouseDown): Added. Calls
504         WKBundlePageSimulateMouseDown.
505         (WTR::EventSendingController::mouseUp): Added. Calls
506         WKBundlePageSimulateMouseUp.
507         (WTR::EventSendingController::mouseMoveTo): Added. Calls
508         WKBundlePageSimulateMouseMotion.
509         (WTR::EventSendingController::leapForward): Added.
510         (WTR::EventSendingController::updateClickCount): Added. Used by the
511         mouseDown/Up functions to create a click count.
512
513         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
514         for the changes above.
515
516 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
517
518         Reviewed by Martin Robinson.
519
520         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
521         https://bugs.webkit.org/show_bug.cgi?id=57362
522
523         Do not generate DRT output if willSendRequestReturnsNull is set.
524
525         * DumpRenderTree/gtk/DumpRenderTree.cpp:
526         (willSendRequestCallback):
527
528 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
529
530         Reviewed by Martin Robinson.
531
532         Implement MiniBrowser for Gtk port.
533         https://bugs.webkit.org/show_bug.cgi?id=48512
534
535         Initial implementation of the Gtk MiniBrowser.
536
537         * MiniBrowser/gtk/GNUmakefile.am: Added.
538         * MiniBrowser/gtk/main.c: Added.
539         (activateUriEntryCallback):
540         (destroyCallback):
541         (goBackCallback):
542         (goForwardCallback):
543         (createToolbar):
544         (createWebView):
545         (createWindow):
546         (argumentToURL):
547         (main):
548
549 2011-03-30  Dominic Cooney  <dominicc@google.com>
550
551         Reviewed by Dimitri Glazkov.
552
553         Adds layoutTestController.shadowRoot accessor to Mac DRT.
554         https://bugs.webkit.org/show_bug.cgi?id=57415
555
556         * DumpRenderTree/LayoutTestController.cpp:
557         (shadowRootCallback):
558         (LayoutTestController::staticFunctions):
559         * DumpRenderTree/LayoutTestController.h:
560         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
561         (LayoutTestController::shadowRoot):
562         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
563         (LayoutTestController::shadowRoot):
564
565 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
566
567         Reviewed by Chris Marrin.
568
569         Update fast/canvas tests to avoid dumping the render tree when possible
570         https://bugs.webkit.org/show_bug.cgi?id=57493
571
572         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
573           accelerated drawing and accelerated drawing for canvas
574
575 2011-03-30  Adam Roben  <aroben@apple.com>
576
577         Stop ignoring leaks in CGGradientCreateWithColorStops
578
579         Fixes <rdar://problem/7888547>.
580
581         Rubber-stamped by John Sullivan.
582
583         * Scripts/old-run-webkit-tests:
584         (countAndPrintLeaks): Removed some code to ignore those leaks.
585
586 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
587
588         Reviewed by Alexey Proskuryakov.
589
590         Add some dynamic annotations to JavaScriptCore/wtf
591         https://bugs.webkit.org/show_bug.cgi?id=53747
592
593         By using these annotations we can improve the precision of finding
594         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
595         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
596
597         These files don't add new functionality, so don't need extra tests.
598
599         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
600
601 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
602
603         Reviewed by Adam Roben.
604
605         Share most vsprops between Release and Production builds in releaseproduction.vsprops
606         https://bugs.webkit.org/show_bug.cgi?id=57508
607
608         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
609         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
610         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
611         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
612         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
613         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
614         * DumpRenderTree/win/ImageDiffProduction.vsprops:
615         * DumpRenderTree/win/ImageDiffRelease.vsprops:
616         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
617         * FindSafari/FindSafariProduction.vsprops:
618         * FindSafari/FindSafariRelease.vsprops:
619         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
620         * FindSafari/FindSafariReleasePGO.vsprops:
621         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
622         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
623         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
624         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
625         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
626         * WebKitAPITest/WebKitAPITestProduction.vsprops:
627         * WebKitAPITest/WebKitAPITestRelease.vsprops:
628         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
629         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
630         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
631         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
632         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
633         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
634         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
635         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
636         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
637         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
638         * WinLauncher/WinLauncherProduction.vsprops:
639         * WinLauncher/WinLauncherRelease.vsprops:
640         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
641         * record-memory-win/record-memory-winProduction.vsprops:
642         * record-memory-win/record-memory-winRelease.vsprops:
643         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
644
645 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
646
647         Reviewed by Adam Roben.
648
649         Update Windows production build logic for new production configurations
650         https://bugs.webkit.org/show_bug.cgi?id=57494
651
652         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
653         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
654         * DumpRenderTree/win/ImageDiffProduction.vsprops:
655         * FindSafari/FindSafariProduction.vsprops:
656         * FindSafari/FindSafariReleasePGO.vsprops:
657         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
658         * WebKitAPITest/WebKitAPITestProduction.vsprops:
659         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
660         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
661         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
662         * WinLauncher/WinLauncherProduction.vsprops:
663         * record-memory-win/record-memory-winProduction.vsprops:
664
665 2011-03-30  Robert Hogan  <robert@webkit.org>
666
667         Reviewed by Antonio Gomes.
668
669         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
670         Unskip http/tests/navigation/go-back-to-error-page.html
671
672         Also add the location of DumpRenderTreeSupportQt.h
673         to DRT's include paths.
674
675         https://bugs.webkit.org/show_bug.cgi?id=52614
676
677         * DumpRenderTree/qt/DumpRenderTree.pro:
678         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
679         * DumpRenderTree/qt/DumpRenderTreeQt.h:
680         * DumpRenderTree/qt/GCControllerQt.cpp:
681         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
682         (LayoutTestController::queueLoadHTMLString):
683         * DumpRenderTree/qt/LayoutTestControllerQt.h:
684         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
685         * DumpRenderTree/qt/TextInputControllerQt.cpp:
686         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
687         (LoadAlternateHTMLStringItem::invoke):
688         * DumpRenderTree/qt/WorkQueueItemQt.h:
689         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
690         * QtTestBrowser/QtTestBrowser.pro:
691         * QtTestBrowser/launcherwindow.h:
692
693 2011-03-30  Adam Barth  <abarth@webkit.org>
694
695         Reviewed by Adam Roben.
696
697         SheriffBot rollouts take too long
698         https://bugs.webkit.org/show_bug.cgi?id=57498
699
700         We used to build before landing rollouts via the commit-queue to
701         prevent further breakage, but now that our individual commit-queue
702         machines are slower, building takes too long.  I can't remember the
703         last time a rollout broke compile.  It seems like just landing the
704         patch is the better trade-off.
705
706         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
707         * Scripts/webkitpy/tool/commands/queues_unittest.py:
708
709 2011-03-30  Adam Barth  <abarth@webkit.org>
710
711         Remove platform/chromium-mac-snowleopard
712         https://bugs.webkit.org/show_bug.cgi?id=57486
713
714         This directory no longer exists, so we can remove it from the fallback
715         chain.
716
717         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
718
719 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
720
721         Reviewed by Adam Roben.
722
723         Rename Windows configuration Release_LTCG to Production for clarity
724         https://bugs.webkit.org/show_bug.cgi?id=57465
725
726         * DumpRenderTree/DumpRenderTree.sln:
727         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
728         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
729         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
730         * DumpRenderTree/win/DumpRenderTree.vcproj:
731         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
732         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
733         * DumpRenderTree/win/ImageDiff.vcproj:
734         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
735         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
736         * FindSafari/FindSafari.vcproj:
737         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
738         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
739         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
740         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
741         * MiniBrowser/MiniBrowser.vcproj:
742         * Scripts/webkitdirs.pm:
743         * TestWebKitAPI/win/TestWebKitAPI.sln:
744         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
745         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
746         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
747         * WebKitAPITest/WebKitAPITest.vcproj:
748         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
749         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
750         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
751         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
752         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
753         * WebKitTestRunner/WebKitTestRunner.sln:
754         * WebKitTestRunner/win/InjectedBundle.vcproj:
755         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
756         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
757         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
758         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
759         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
760         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
761         * WinLauncher/WinLauncher.vcproj:
762         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
763         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
764         * record-memory-win/record-memory-win.vcproj:
765         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
766         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
767
768 2011-03-30  MORITA Hajime  <morrita@google.com>
769
770         Reviewed by Dimitri Glazkov.
771
772         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
773         https://bugs.webkit.org/show_bug.cgi?id=56573
774
775         Added LayoutTestController.shadowRoot() to Chromium DRT.
776
777         * DumpRenderTree/chromium/LayoutTestController.cpp:
778         (LayoutTestController::LayoutTestController):
779         (LayoutTestController::shadowRoot):
780         * DumpRenderTree/chromium/LayoutTestController.h:
781
782 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
783
784         Reviewed by Kent Tamura.
785
786         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
787         https://bugs.webkit.org/show_bug.cgi?id=57430
788
789         * DumpRenderTree/chromium/LayoutTestController.cpp:
790         (LayoutTestController::LayoutTestController):
791         (LayoutTestController::setPluginsEnabled):
792         * DumpRenderTree/chromium/LayoutTestController.h:
793
794 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
795
796         Reviewed by Adam Barth.
797
798         make webkit-patch upload respect -d
799         https://bugs.webkit.org/show_bug.cgi?id=57425
800
801         * Scripts/webkitpy/common/checkout/scm.py:
802         * Scripts/webkitpy/tool/steps/commit.py:
803
804 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
805
806         Reviewed by Adam Barth.
807
808         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
809         https://bugs.webkit.org/show_bug.cgi?id=57429
810
811         * Scripts/webkitpy/common/checkout/scm.py:
812
813 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
814
815         Unreviewed, rolling out r82383.
816         http://trac.webkit.org/changeset/82383
817         https://bugs.webkit.org/show_bug.cgi?id=57417
818
819         "nrwt isn't shutting down cleanly" (Requested by dpranke on
820         #webkit).
821
822         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
823         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
824         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
825
826 2011-03-29  Kent Tamura  <tkent@chromium.org>
827
828         Reviewed by Dimitri Glazkov.
829
830         Make validation message bubble testable
831         https://bugs.webkit.org/show_bug.cgi?id=57290
832
833         * DumpRenderTree/mac/DumpRenderTree.mm:
834         (createWebViewAndOffscreenWindow): Change a setting so that validation
835           bubbles isn't hidden automatically.
836
837 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
838
839         Reviewed by Ojan Vafai.
840
841         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
842
843         It's a bit unclear whether multiple threads or multiple
844         processes will be a better model on windows. This change will
845         test threads for now while we're still working out the bugs in
846         multiple-processes.
847
848         https://bugs.webkit.org/show_bug.cgi?id=57410
849
850         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
851         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
852         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
853
854 2011-03-29  David Levin  <levin@chromium.org>
855
856         Reviewed by Shinichiro Hamaji.
857
858         check-webkit-style confused by two ChangeLog entries in a row from same user
859         https://bugs.webkit.org/show_bug.cgi?id=57250
860
861         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
862         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
863         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
864           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
865           checking more than that would be very messey.
866         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
867         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
868
869 2011-03-29  Kent Tamura  <tkent@chromium.org>
870
871         Reviewed by Dimitri Glazkov.
872
873         [Mac] Enable interactive-validation tests on Mac DRT
874         https://bugs.webkit.org/show_bug.cgi?id=57308
875
876         * DumpRenderTree/mac/DumpRenderTree.mm:
877         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
878
879 2011-03-29  Chang Shu  <cshu@webkit.org>
880
881         Reviewed by Kenneth Rohde Christiansen.
882
883         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
884         https://bugs.webkit.org/show_bug.cgi?id=42692
885
886         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
887         (WTR::InjectedBundle::beginTesting):
888         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
889         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
890         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
891
892 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
893
894         Reviewed by Xan Lopez.
895
896         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
897         https://bugs.webkit.org/show_bug.cgi?id=57067
898
899         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
900         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
901         update DRT and pixel results as hundreds of results will need to be updated.
902
903         * DumpRenderTree/gtk/DumpRenderTree.cpp:
904         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
905         by overriding the theme RC/CSS files.
906
907 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
908
909         Reviewed by Adam Roben.
910
911         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
912         https://bugs.webkit.org/show_bug.cgi?id=57394
913
914         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
915         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
916         the IDE. To avoid this, add a separate vsprops file for each project configuration that
917         contains the required inherited property sheets.
918
919         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
920         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
921         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
922         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
923         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
924         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
925         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
926         * DumpRenderTree/win/DumpRenderTree.vcproj:
927         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
928         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
929         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
930         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
931         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
932         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
933         * DumpRenderTree/win/ImageDiff.vcproj:
934         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
935         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
936         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
937         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
938         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
939         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
940         * FindSafari/FindSafari.vcproj:
941         * FindSafari/FindSafariDebug.vsprops: Added.
942         * FindSafari/FindSafariDebugAll.vsprops: Added.
943         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
944         * FindSafari/FindSafariRelease.vsprops: Added.
945         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
946         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
947         * FindSafari/FindSafariReleasePGO.vsprops: Added.
948         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
949         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
950         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
951         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
952         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
953         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
954         * MiniBrowser/MiniBrowser.vcproj:
955         * WebKitAPITest/WebKitAPITest.vcproj:
956         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
957         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
958         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
959         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
960         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
961         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
962         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
963         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
964         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
965         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
966         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
967         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
968         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
969         * WebKitTestRunner/win/InjectedBundle.vcproj:
970         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
971         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
972         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
973         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
974         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
975         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
976         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
977         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
978         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
979         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
980         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
981         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
982         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
983         * WinLauncher/WinLauncher.vcproj:
984         * WinLauncher/WinLauncherDebug.vsprops: Added.
985         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
986         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
987         * WinLauncher/WinLauncherRelease.vsprops: Added.
988         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
989         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
990         * record-memory-win/record-memory-win.vcproj:
991         * record-memory-win/record-memory-winDebug.vsprops: Added.
992         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
993         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
994         * record-memory-win/record-memory-winRelease.vsprops: Added.
995         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
996         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
997
998 2011-03-29  Adam Barth  <abarth@webkit.org>
999
1000         Reviewed by Darin Adler.
1001
1002         test_runner2.py can crash due to undefined variable
1003         https://bugs.webkit.org/show_bug.cgi?id=57356
1004
1005         Replace reference to undefined variable with a variable that's actually
1006         defined.  AFAICT, there's no way to test this code.
1007
1008         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1009
1010 2011-03-29  Tony Chang  <tony@chromium.org>
1011
1012         Reviewed by Eric Seidel.
1013
1014         cleanup rebaseline-chromium-webkit-tests
1015         https://bugs.webkit.org/show_bug.cgi?id=57375
1016
1017         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1018             - Split _extract_and_add_new_baselines into 3 functions
1019             - Reduce the amount of line wrapping (the file already has lines
1020               over 80 col, so may as well try to make the file consistent)
1021             - Remove unnecessary ()s
1022
1023 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
1024
1025         Reviewed by Adam Roben.
1026
1027         Make WinCairo a core builder.
1028         https://bugs.webkit.org/show_bug.cgi?id=57373
1029
1030         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
1031         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
1032
1033 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1034
1035         Update update-webkit-localizable-strings to understand that WebKit and
1036         WebKit2 strings go in WebCore.
1037
1038         Also make extract-localizable-strings optionally use an exclude file. No individual
1039         warnings are produced about unlocalized strings when there is no exclude file. This
1040         is needed for WebCore, since there are too many bare strings.
1041
1042         https://webkit.org/b/57354
1043
1044         Reviewed by Sam Weinig.
1045
1046         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
1047         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
1048
1049 2011-03-29  Darin Adler  <darin@apple.com>
1050
1051         Reviewed by Adam Roben.
1052
1053         WebKit2 bundle page needs to offer generated file hooks
1054         https://bugs.webkit.org/show_bug.cgi?id=57279
1055
1056         (Land missing part of the original patch after r82289.)
1057
1058         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1059         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
1060
1061 2011-03-29  Tony Chang  <tony@chromium.org>
1062
1063         Reviewed by Ojan Vafai.
1064
1065         [chromium] NRWT should be able to read checksums from png comments
1066         https://bugs.webkit.org/show_bug.cgi?id=57280
1067
1068         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
1069             from a file.
1070         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
1071         * Scripts/webkitpy/common/system/filesystem_mock.py:
1072         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
1073             if the -checksum.txt file doesn't exist, try looking in the png.
1074         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1075         * Scripts/webkitpy/layout_tests/port/test.py:
1076         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
1077             2k for a png comment with the checksum
1078         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
1079
1080 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1081
1082         Rubber-stamped by Gustavo Noronha Silva.
1083
1084         [GTK] http/tests/uri/username-with-no-hostname.html fails
1085         https://bugs.webkit.org/show_bug.cgi?id=57325
1086
1087         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1088         (willSendRequestCallback): URI host value check done case-insensitively.
1089
1090 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1091
1092         Reviewed by Martin Robinson.
1093
1094         [GTK] http/tests/uri/username-with-no-hostname.html fails
1095         https://bugs.webkit.org/show_bug.cgi?id=57325
1096
1097         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1098         (willSendRequestCallback): Check URI before submitting the request
1099         to WebCore.
1100
1101 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
1102
1103         Reviewed by Ojan Vafai.
1104
1105         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
1106         https://bugs.webkit.org/show_bug.cgi?id=57303
1107
1108         * DumpRenderTree/chromium/EventSender.cpp:
1109         (EventSender::doDragDrop):
1110         (EventSender::beginDragWithFiles):
1111
1112 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
1113
1114         Reviewed by Andreas Kling.
1115
1116         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
1117         https://bugs.webkit.org/show_bug.cgi?id=57314
1118
1119         Provide possibility to print loaded urls to the standard output.
1120
1121         * MiniBrowser/qt/BrowserWindow.cpp:
1122         (BrowserWindow::BrowserWindow):
1123         (BrowserWindow::printURL):
1124         * MiniBrowser/qt/BrowserWindow.h:
1125         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1126         (MiniBrowserApplication::handleUserOptions):
1127         * MiniBrowser/qt/MiniBrowserApplication.h:
1128         (WindowOptions::WindowOptions):
1129         * QtTestBrowser/launcherwindow.cpp:
1130         (LauncherWindow::initializeView):
1131         (LauncherWindow::printURL):
1132         (LauncherWindow::cloneWindow):
1133         * QtTestBrowser/launcherwindow.h:
1134         (WindowOptions::WindowOptions):
1135         * QtTestBrowser/main.cpp:
1136         (LauncherApplication::handleUserOptions):
1137
1138 2011-03-29  Gabor Loki  <loki@webkit.org>
1139
1140         Rubber-stamped by Csaba Osztrogonác.
1141
1142         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1143         https://bugs.webkit.org/show_bug.cgi?id=56918
1144
1145         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
1146
1147 2011-03-28  Gabor Loki  <loki@webkit.org>
1148
1149         Reviewed by Csaba Osztrogonác.
1150
1151         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1152         https://bugs.webkit.org/show_bug.cgi?id=56918
1153
1154         * Scripts/build-jsc:
1155         * Scripts/webkitdirs.pm:
1156
1157 2011-03-28  Andrew Foster  <andrewf@chromium.org>
1158
1159         Reviewed by Ojan Vafai.
1160
1161         webkit-patch should be more intelligent about whether a bug applies to a patch
1162         Create a new function, parse_bug_id_from_changelog() which determines
1163         that a bug is related to a patch by parsing the output generated from
1164         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
1165         the description of a patch.
1166         https://bugs.webkit.org/show_bug.cgi?id=56989
1167
1168         * Scripts/webkitpy/common/checkout/api.py:
1169         * Scripts/webkitpy/common/checkout/changelog.py:
1170         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
1171         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1172         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1173         * Scripts/webkitpy/style/checkers/changelog.py:
1174         * Scripts/webkitpy/tool/commands/upload.py:
1175
1176 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
1177
1178         Revert accidentally commited change.
1179
1180         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1181         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1182
1183 2011-03-28  Tony Chang  <tony@chromium.org>
1184
1185         Reviewed by Adam Barth.
1186
1187         [chromium] have DRT write the png checksum into a png comment
1188         https://bugs.webkit.org/show_bug.cgi?id=57255
1189
1190         * DumpRenderTree/chromium/TestShell.cpp:
1191         (TestShell::dumpImage):
1192
1193 2011-03-28  Adele Peterson  <adele@apple.com>
1194
1195         Removing Qt stub, since it doesn't use the same header as the others.
1196
1197         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1198
1199 2011-03-28  Adele Peterson  <adele@apple.com>
1200
1201         Added a few more stubs.
1202
1203         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1204         (LayoutTestController::hasGrammarMarker):
1205         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1206         (LayoutTestController::hasGrammarMarker):
1207         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1208         (LayoutTestController::hasGrammarMarker):
1209
1210 2011-03-28  Adele Peterson  <adele@apple.com>
1211
1212         Build fix.
1213
1214         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1215         (LayoutTestController::hasGrammarMarker):
1216
1217 2011-03-28  Adele Peterson  <adele@apple.com>
1218
1219         Reviewed by Eric Seidel.
1220
1221         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1222         https://bugs.webkit.org/show_bug.cgi?id=57173
1223
1224         * DumpRenderTree/LayoutTestController.cpp:
1225         (hasGrammarMarkerCallback): Added.
1226         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
1227         * DumpRenderTree/LayoutTestController.h:
1228         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
1229         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
1230
1231 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1232
1233         Reviewed by Benjamin Poulain.
1234
1235         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1236         https://bugs.webkit.org/show_bug.cgi?id=57087
1237
1238         Trivial typo fix after r82082.
1239
1240         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1241         (WTR::activateFonts):
1242
1243 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
1244
1245         Reviewed by Andreas Kling.
1246
1247         Add myself to the committers list.
1248
1249         * Scripts/webkitpy/common/config/committers.py:
1250
1251 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
1252
1253         Reviewed by Sam Weinig.
1254
1255         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
1256         to link against WebKit.framework for now.
1257
1258         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1259
1260 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1261
1262         Reviewed by Andreas Kling.
1263
1264         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1265         https://bugs.webkit.org/show_bug.cgi?id=57087
1266
1267         Disable QT_ASCII_CAST_WARNINGS for applications.
1268
1269         * DumpRenderTree/qt/DumpRenderTree.pro:
1270         * DumpRenderTree/qt/ImageDiff.pro:
1271         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1272         * MiniBrowser/qt/MiniBrowser.pro:
1273         * QtTestBrowser/QtTestBrowser.pro:
1274         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1275
1276 2011-03-28  Andreas Kling  <kling@webkit.org>
1277
1278         Reviewed by Kenneth Rohde Christiansen.
1279
1280         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1281         https://bugs.webkit.org/show_bug.cgi?id=57224
1282
1283         * QtTestBrowser/mainwindow.cpp:
1284         (MainWindow::buildUI):
1285         (MainWindow::onTitleChanged):
1286         * QtTestBrowser/mainwindow.h:
1287
1288 2011-03-27  Jer Noble  <jer.noble@apple.com>
1289
1290         Reviewed by Maciej Stachowiak.
1291
1292         Full Screen: disable keyboard access by default
1293         https://bugs.webkit.org/show_bug.cgi?id=56684
1294
1295         Accept the withKeyboard parameter to supportsFullScreenForElement.
1296
1297         * DumpRenderTree/mac/UIDelegate.mm:
1298         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1299
1300 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1301
1302         Reviewed by David Levin.
1303
1304         check-webkit-style should check ChangeLog for a valid bug number
1305         https://bugs.webkit.org/show_bug.cgi?id=57184
1306
1307         * Scripts/webkitpy/style/checker.py:
1308         * Scripts/webkitpy/style/checker_unittest.py:
1309         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1310         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1311
1312 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1313
1314         Reviewed by Andreas Kling.
1315
1316         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1317         https://bugs.webkit.org/show_bug.cgi?id=57087
1318
1319         Use explicit conversion for string to avoid depending on the default codec
1320         installed by the user code.
1321
1322         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1323         (WTR::activateFonts):
1324
1325 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1326
1327         Revert inadvertantly committed changes.
1328
1329         * Scripts/old-run-webkit-tests:
1330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1331
1332 2011-03-26  Andreas Kling  <kling@webkit.org>
1333
1334         Reviewed by Kenneth Rohde Christiansen.
1335
1336         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1337         https://bugs.webkit.org/show_bug.cgi?id=57162
1338
1339         * QtTestBrowser/QtTestBrowser.qrc:
1340         * QtTestBrowser/favicon.png: Added.
1341         * QtTestBrowser/locationedit.cpp:
1342         (defaultPageIcon):
1343         (LocationEdit::LocationEdit):
1344         (LocationEdit::setPageIcon):
1345         (LocationEdit::resizeEvent):
1346         (LocationEdit::updateInternalGeometry):
1347         * QtTestBrowser/locationedit.h:
1348         * QtTestBrowser/mainwindow.cpp:
1349         (MainWindow::buildUI):
1350         (MainWindow::onIconChanged):
1351         (MainWindow::onLoadStarted):
1352         * QtTestBrowser/mainwindow.h:
1353
1354 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1355
1356         Reviewed by Xan Lopez.
1357
1358         [GTK] Force DumpRenderTree to use 96 DPI
1359         https://bugs.webkit.org/show_bug.cgi?id=56866
1360
1361         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1362         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1363
1364         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1365         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1366         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1367         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1368
1369 2011-03-25  Andy Estes  <aestes@apple.com>
1370
1371         Reviewed by Adele Peterson.
1372
1373         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1374         https://bugs.webkit.org/show_bug.cgi?id=49016
1375
1376         TestNetscapePlugIn needs to register support for an image MIME type so
1377         we can test that the embed tag prefers plug-ins to render image MIME
1378         types.
1379
1380         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1381         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1382         (NP_GetMIMEDescription): Ditto.
1383         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1384
1385 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1386
1387         Reviewed by Sam Weinig.
1388
1389         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1390         https://bugs.webkit.org/show_bug.cgi?id=50780
1391
1392         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1393
1394         The test is named "CookieManager" so that we can eventually exercise more of the
1395         CookieManager functionality in the test.
1396
1397         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1398         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1399         Assert that the policy returned is equal to the policy set in
1400         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1401         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1402         Set the policy to something different than the user's policy and get the policy again.
1403         (TestWebKitAPI::didFinishLoadForFrame):
1404         Get the user's policy so that it can be restored at the end of the test.
1405         (TestWebKitAPI::TEST):
1406         Load about:blank so that the Web Process gets instatiated (needed to get the
1407         CookieManager).
1408
1409         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1410         Add CookieManager.cpp.
1411
1412 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1413
1414         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1415
1416         * wx/build/settings.py:
1417
1418 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1419
1420         Reviewed by Adam Roben.
1421
1422         Implement layoutTestController.setAutoFilled in DRT on Windows
1423         https://bugs.webkit.org/show_bug.cgi?id=56828
1424
1425         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1426         (LayoutTestController::setAutofilled): Implemented.
1427
1428 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1429
1430         Unreviewed build correction.
1431
1432         Correct vsprops file for Debug variant of the CFLite build.
1433         Disable a CFNETWORK-specific test when building for CFLite.
1434
1435         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1436         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1437
1438 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1439
1440         Reviewed by Adam Barth.
1441
1442         fix regressions introduced in 81908 - there were a couple of
1443         code paths that only fired under python 2.5 that I missed.
1444
1445         Also change a couple of 'python' references to sys.executable
1446         in order to handle runing test-webkitpy with a binary other than
1447         something called 'python'.
1448
1449         https://bugs.webkit.org/show_bug.cgi?id=57063
1450
1451         * Scripts/webkitpy/layout_tests/port/mac.py:
1452         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1453         * Scripts/webkitpy/test/cat.py:
1454         * Scripts/webkitpy/test/echo.py:
1455
1456 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1457
1458         Unreviewed build correction.
1459
1460         Add a stub implementation of the TestInvocation dumping logic.
1461         Update project files to reflect new file.
1462
1463         * WebKitTestRunner/cairo: Added.
1464         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1465         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1466         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1467
1468 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1469
1470         Reviewed by Tony Chang.
1471
1472         new-run-webkit-tests: clean up worker model defaults. This
1473         changes the default behavior to 'threads' instead of
1474         'old-threads', and clarifies that chromium-win-* and
1475         chromium-mac-leopard are exceptions.
1476
1477         https://bugs.webkit.org/show_bug.cgi?id=56971
1478
1479         * Scripts/webkitpy/layout_tests/port/base.py:
1480         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1481         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1482         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1483         * Scripts/webkitpy/layout_tests/port/test.py:
1484         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1485
1486 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1487
1488         Reviewed by Darin Adler.
1489
1490         Media Stream API: fix the order of the options in build-webkit.
1491         https://bugs.webkit.org/show_bug.cgi?id=56949
1492
1493         Fix the order of the options in build-webkit.
1494
1495         * Scripts/build-webkit:
1496
1497 2011-03-23  Adam Klein  <adamk@chromium.org>
1498
1499         Reviewed by Mihai Parparita.
1500
1501         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1502         https://bugs.webkit.org/show_bug.cgi?id=56884
1503
1504         This option will be utilized by Chromium's ui_tests to allow
1505         referencing js-test-resources from a layout test over HTTP.
1506
1507         * Scripts/new-run-webkit-httpd:
1508         Added --layout_tests_dir option.
1509         * Scripts/webkitpy/layout_tests/port/http_server.py:
1510         Plumbed through as layout_tests_dir param.
1511
1512 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1513
1514         Reviewed by Mihai Parparita.
1515
1516         new-run-webkit-tests: run tests in ascending alphabetical order per
1517         dir. This is a second attempt at the fix; the first attempt, in 
1518         r81597, broke the behavior on the old-inline and old-threads
1519         worker models.
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=56760
1522
1523         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1524         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1525         * Scripts/webkitpy/layout_tests/port/test.py:
1526         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1527
1528 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1529
1530         Reviewed by Martin Robinson.
1531
1532         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1533         https://bugs.webkit.org/show_bug.cgi?id=56953
1534
1535         Print the string for the detail of 'property-change' signal.
1536
1537         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1538         (axObjectEventListener): Print the detail string.
1539
1540 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1541
1542         Reviewed by Pavel Feldman.
1543
1544         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1545         https://bugs.webkit.org/show_bug.cgi?id=56843
1546
1547         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1548         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1549
1550 2011-03-22  Eric Seidel  <eric@webkit.org>
1551
1552         Reviewed by Adam Barth.
1553
1554         Teach update-webkit about gyp
1555         https://bugs.webkit.org/show_bug.cgi?id=56881
1556
1557         This makes it possible for someone who builds from Xcode
1558         to just run update-webkit --gyp and have the project files
1559         generated after update automatically.
1560
1561         I also added a stand-alone "generate-project-files" script
1562         wrapping Source/gyp/configure.  This makes running gyp simpler
1563         since most people will not have gyp or Source/gyp in their path.
1564
1565         * Scripts/build-webkit:
1566         * Scripts/generate-project-files: Added.
1567         * Scripts/update-webkit:
1568
1569 2011-03-22  Anton D'Auria  <adauria@apple.com>
1570
1571         Reviewed by Alexey Proskuryakov.
1572
1573         Add +[WebApplicationCache getOriginsWithCache]
1574         https://bugs.webkit.org/show_bug.cgi?id=56722
1575
1576         * DumpRenderTree/LayoutTestController.cpp:
1577         (originsWithApplicationCacheCallback):
1578         (LayoutTestController::staticFunctions):
1579         * DumpRenderTree/LayoutTestController.h:
1580         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1581         (LayoutTestController::originsWithApplicationCache):
1582         * DumpRenderTree/chromium/LayoutTestController.h:
1583         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1584         (LayoutTestController::originsWithApplicationCache):
1585         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1586         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1587         (LayoutTestController::originsWithApplicationCache):
1588         (LayoutTestController::originsWithLocalStorage):
1589         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1590         (LayoutTestController::originsWithApplicationCache):
1591         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1592         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1593         (LayoutTestController::originsWithApplicationCache):
1594         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1595         (LayoutTestController::originsWithApplicationCache):
1596
1597 2011-03-22  Eric Seidel  <eric@webkit.org>
1598
1599         Reviewed by Adam Barth.
1600
1601         Add support to build-webkit for building with gyp-generated project files
1602         https://bugs.webkit.org/show_bug.cgi?id=56877
1603
1604         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1605         Eventually we'll want to support gyp-generated projects in a more general manner.
1606
1607         * Scripts/build-webkit:
1608
1609 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1610
1611         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1612
1613         Reviewed by Joseph Pecoraro.
1614
1615         * Scripts/build-webkit: Updated usage statement to include
1616         --dsym.
1617         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1618         (generateDsym): Added. Call determineGenerateDsym() and
1619         return $generateDsym.
1620         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1621         $generateDsym.
1622         (argumentsForXcode): Added.  Returns additional arguments for
1623         xcodebuild based on command-line switches.
1624         (XcodeOptions): Updated to include argumentsForXcode() in the
1625         array returned.
1626
1627 2011-03-22  Adam Roben  <aroben@apple.com>
1628
1629         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1630
1631         These bots are consistently green again.
1632
1633         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1634         core builders
1635
1636         Rubber-stamped by Antti Koivisto.
1637
1638         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1639         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1640
1641         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1642         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1643
1644 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1645
1646         Unreviewed, rolling out r81597.
1647         http://trac.webkit.org/changeset/81597
1648         https://bugs.webkit.org/show_bug.cgi?id=56801
1649
1650         Change results in lots of unexpected flaky on the dashboard.
1651         (Requested by pfeldman on #webkit).
1652
1653         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1654         * Scripts/webkitpy/layout_tests/port/test.py:
1655         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1656
1657 2011-03-21  Sam Weinig  <sam@webkit.org>
1658
1659         Fix failing tests on the WebKit2 bots.
1660
1661         * WebKitTestRunner/TestController.cpp:
1662         (WTR::TestController::resetStateToConsistentValues):
1663
1664 2011-03-21  Daniel Sievers  <sievers@google.com>
1665
1666         Reviewed by Simon Fraser.
1667
1668         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1669         https://bugs.webkit.org/show_bug.cgi?id=56139
1670
1671         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1672         (main):
1673         * DumpRenderTree/chromium/LayoutTestController.cpp:
1674         (LayoutTestController::LayoutTestController):
1675         (LayoutTestController::layerTreeAsText):
1676         * DumpRenderTree/chromium/LayoutTestController.h:
1677         (LayoutTestController::setShowDebugLayerTree):
1678         * DumpRenderTree/chromium/TestShell.cpp:
1679         (TestShell::runFileTest):
1680         (TestShell::dump):
1681         * DumpRenderTree/chromium/TestShell.h:
1682         (TestParams::TestParams):
1683
1684 2011-03-21  Adam Roben  <aroben@apple.com>
1685
1686         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1687
1688         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1689         output as plain text
1690
1691         Reviewed by David Kilzer.
1692
1693         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1694         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1695         to the master.
1696         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1697         since we're running on the build master, not the slave. Instead, turn the raw source of
1698         actual.html which the build slave uploaded into an HTML log.
1699
1700 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1701
1702         Reviewed by Mihai Parparita.
1703
1704         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1705         https://bugs.webkit.org/show_bug.cgi?id=56760
1706
1707         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1708         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1709         * Scripts/webkitpy/layout_tests/port/test.py:
1710
1711 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1712
1713         Reviewed by Steve Block.
1714
1715         Media Stream API patch 0: adding compilation guards.
1716         https://bugs.webkit.org/show_bug.cgi?id=56458
1717
1718         Adding options to enable the media stream API feature in Chromium.
1719
1720         * Scripts/build-webkit:
1721
1722 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1723
1724         Reviewed by Laszlo Gombos.
1725
1726         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1727         https://bugs.webkit.org/show_bug.cgi?id=56323
1728
1729         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1730         "--stdout" or "--stderr" option.
1731
1732         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1733         (WebCore::DumpRenderTree::~DumpRenderTree):
1734         (WebCore::DumpRenderTree::processArgsLine):
1735         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1736         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1737         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1738         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1739         * DumpRenderTree/qt/main.cpp:
1740         (isOption):
1741         (takeOptionValue):
1742         (printUsage):
1743         (main):
1744
1745 2011-03-21  Adam Roben  <aroben@apple.com>
1746
1747         Fix exceptions on the buildbot due to my last change
1748
1749         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1750         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1751
1752 2011-03-21  Adam Roben  <aroben@apple.com>
1753
1754         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1755
1756         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1757         output as plain text
1758
1759         Reviewed by Darin Adler.
1760
1761         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1762         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1763         logs.
1764         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1765         the build master. This will correctly treat it as HTML.
1766
1767 2011-03-20  Bill Budge  <bbudge@chromium.org>
1768
1769         Reviewed by Adam Barth.
1770
1771         Rename ThreadSafeShared to ThreadSafeRefCounted
1772         https://bugs.webkit.org/show_bug.cgi?id=56714
1773
1774         No new tests. Exposes no new functionality.
1775
1776         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1777         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1778         * Scripts/do-webcore-rename:
1779
1780 2011-03-19  Anton D'Auria  <adauria@apple.com>
1781
1782         Reviewed by Dan Bernstein.
1783
1784         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1785         https://bugs.webkit.org/show_bug.cgi?id=56719
1786
1787         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1788         (LayoutTestController::clearApplicationCacheForOrigin):
1789
1790 2011-03-19  Anton D'Auria  <adauria@apple.com>
1791
1792         Reviewed by Alexey Proskuryakov.
1793
1794         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1795         https://bugs.webkit.org/show_bug.cgi?id=56415
1796
1797         * DumpRenderTree/LayoutTestController.cpp:
1798         (clearApplicationCacheForOriginCallback):
1799         (LayoutTestController::staticFunctions):
1800         * DumpRenderTree/LayoutTestController.h:
1801         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1802         (LayoutTestController::LayoutTestController):
1803         (LayoutTestController::clearAllApplicationCaches):
1804         (LayoutTestController::clearApplicationCacheForOrigin): 
1805         * DumpRenderTree/chromium/LayoutTestController.h:
1806         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1807         (LayoutTestController::clearApplicationCacheForOrigin):
1808         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1809         (LayoutTestController::clearApplicationCacheForOrigin):
1810         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1811         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1812         (LayoutTestController::clearApplicationCacheForOrigin):
1813         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1814         (LayoutTestController::clearApplicationCacheForOrigin):
1815
1816 2011-03-18  Dan Bernstein  <mitz@apple.com>
1817
1818         Revised build fix for r81135.
1819
1820         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1821         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1822
1823 2011-03-18  Adam Roben  <aroben@apple.com>
1824
1825         Windows build fix
1826
1827         * WebKitTestRunner/config.h: Add a missing #endif.
1828
1829 2011-03-18  Andreas Kling  <kling@webkit.org>
1830
1831         Unbreak Qt build after r81494.
1832
1833         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1834         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1835
1836 2011-03-18  Sam Weinig  <sam@webkit.org>
1837
1838         Fix windows build. This was really Adam Roben's fault. I swear!
1839
1840         * WebKitTestRunner/config.h:
1841
1842 2011-03-18  Sam Weinig  <sam@webkit.org>
1843
1844         Reviewed by Adam Roben.
1845
1846         Pixel tests don't work in WebKitTestRunner on Windows
1847         https://bugs.webkit.org/show_bug.cgi?id=56630
1848
1849         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1850         built-in snapshotting instead of using the window server on the Mac.
1851
1852         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1853         (WTR::InjectedBundle::InjectedBundle):
1854         (WTR::InjectedBundle::didReceiveMessage):
1855         (WTR::InjectedBundle::beginTesting):
1856         (WTR::InjectedBundle::done):
1857         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1858         (WTR::InjectedBundle::setPixelResult):
1859         (WTR::InjectedBundle::shouldDumpPixels):
1860         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1861         (WTR::InjectedBundlePage::dump):
1862         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1863
1864         * WebKitTestRunner/TestInvocation.cpp:
1865         (WTR::TestInvocation::invoke):
1866         (WTR::TestInvocation::dump):
1867         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1868         * WebKitTestRunner/TestInvocation.h:
1869         * WebKitTestRunner/cg: Added.
1870         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1871         (WTR::createCGContextFromImage):
1872         (WTR::computeMD5HashStringForContext):
1873         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1874         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1875         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1876
1877         * WebKitTestRunner/win/TestInvocationWin.cpp:
1878         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1879         Keep stub for Cairo build.
1880
1881         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1882         Add CG configuration.
1883
1884         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1885         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1886         Add new files.
1887
1888 2011-03-18  Adam Roben  <aroben@apple.com>
1889
1890         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1891
1892         Rubber-stamped by Simon Fraser.
1893
1894         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1895         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1896         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1897
1898 2011-03-18  Adam Roben  <aroben@apple.com>
1899
1900         Don't ellipsize long or indented function names in Leaks Viewer
1901
1902         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1903         scrollbar
1904
1905         Reviewed by Simon Fraser.
1906
1907         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1908         (.data-grid .data-container):
1909         (.data-grid td > div, .data-grid th > div):
1910         Allow the contents to extend to the right.
1911
1912 2011-03-18  Adam Roben  <aroben@apple.com>
1913
1914         Fix some leaks in DRT seen on the leaks bot
1915
1916         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1917         setWillSendRequestClearHeaderCallback in DRT are leaky
1918
1919         Reviewed by Alexey Proskuryakov.
1920
1921         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1922
1923         * DumpRenderTree/LayoutTestController.cpp:
1924         (addURLToRedirectCallback):
1925         (setWillSendRequestClearHeaderCallback):
1926         Use OwnArrayPtr to cause the strings to be deleted.
1927
1928 2011-03-18  Adam Roben  <aroben@apple.com>
1929
1930         Fix a NSURLCredential leak seen on the leaks bot
1931
1932         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1933         connection:didReceiveAuthenticationChallenge:] is leaky
1934
1935         Reviewed by John Sullivan.
1936
1937         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1938         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1939         cause the NSURLCredential to be released.
1940
1941 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1942
1943         Unreviewed.
1944
1945         Remove unnecessary brackets around my email address.
1946
1947         * Scripts/webkitpy/common/config/committers.py:
1948
1949 2011-03-18  Adam Roben  <aroben@apple.com>
1950         
1951         Remove some files I accidentally added in r81454
1952
1953         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1954         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1955
1956 2011-03-18  Adam Roben  <aroben@apple.com>
1957
1958         Ignore an NSNumberFormatter leak on SnowLeopard
1959
1960         * Scripts/old-run-webkit-tests:
1961         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1962         getObjectValue:forString:errorDescription:].
1963
1964 2011-03-18  Adam Roben  <aroben@apple.com>
1965
1966         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1967
1968         Rubber-stamped by Mark Rowe.
1969
1970         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1971         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1972         released.
1973
1974 2011-03-17  Adam Roben  <aroben@apple.com>
1975
1976         Address a review comment I missed in r81445
1977
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1979         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1980         leaked bytes to speed up searching on long lines.
1981
1982 2011-03-17  Adam Roben  <aroben@apple.com>
1983
1984         Mark leaky builds orange, even if all regression tests passed
1985
1986         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1987         build.webkit.org when all tests pass even though there are still leaks
1988
1989         Reviewed by Dan Bernstein.
1990
1991         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1992         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1993         be marked orange if this build step generates warnings.
1994
1995 2011-03-17  Adam Roben  <aroben@apple.com>
1996
1997         Allow values in Leaks Viewer to be shown as percentages
1998
1999         Double-clicking on a column will toggle between showing percentages and showing real values.
2000
2001         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
2002         number of leaked bytes in Leaks Viewer
2003
2004         Reviewed by Joe Pecoraro.
2005
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2007         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
2008         node's totalTime, which is used in calculating percentages.
2009
2010         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2011         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
2012         showing them as percentages.
2013
2014 2011-03-17  Adam Roben  <aroben@apple.com>
2015
2016         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
2017
2018         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
2019         the number of leaked allocations. And the new Average column shows the average number of
2020         leaked bytes per call.
2021
2022         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
2023         just how many allocations
2024
2025         Reviewed by Joe Pecoraro.
2026
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2028         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
2029         line and store it with the leak stack.
2030         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
2031         properties.
2032         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
2033         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
2034         .numberOfCalls now holds the number of leaked allocations.
2035
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2037         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
2038         appear.
2039         (monkeyPatchInspectorObjects): Format the values as bytes.
2040
2041 2011-03-17  Adam Roben  <aroben@apple.com>
2042
2043         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
2044
2045         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
2046         regression tests
2047
2048         Reviewed by James Robinson.
2049
2050         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2051         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
2052         is always populated, even when all regression tests pass.
2053
2054 2011-03-10  Hayato Ito  <hayato@chromium.org>
2055
2056         Reviewed by Tony Chang.
2057
2058         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
2059
2060         https://bugs.webkit.org/show_bug.cgi?id=56076
2061
2062         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2063
2064 2011-03-17  Adam Roben  <aroben@apple.com>
2065
2066         Skip a compositing-sensitive test when accelerated compositing is disabled
2067
2068         Reviewed by Sam Weinig.
2069
2070         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
2071         accelerated compositing is disabled.
2072
2073 2011-03-17  Adam Roben  <aroben@apple.com>
2074
2075         Start using PlatformSpecificScheduler for the Mac builders
2076
2077         The current set of file/directory patterns should work for Mac builders. We may discover
2078         that there are more files and directories we can exclude from the Mac builds, but they can
2079         be added later.
2080
2081         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
2082
2083         Reviewed by Mark Rowe.
2084
2085         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
2086         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
2087
2088         * Scripts/webkitpy/common/config/build.py:
2089         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
2090         cleaned up patterns a little bit.
2091
2092         * Scripts/webkitpy/common/config/build_unittest.py:
2093         (ShouldBuildTest): Fixed some expected results.
2094         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
2095         platforms.
2096
2097 2011-03-17  Jeff Miller  <jeffm@apple.com>
2098
2099         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
2100         
2101         *.mode*
2102         *.pbxuser
2103         *.perspective*
2104         project.xcworkspace
2105         xcuserdata
2106
2107         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2108         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2109         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2110         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2111         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2112
2113 2011-03-17  Adam Roben  <aroben@apple.com>
2114
2115         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
2116
2117         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
2118         mac-wk2
2119
2120         Reviewed by Anders Carlsson.
2121
2122         * Scripts/old-run-webkit-tests:
2123         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
2124         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
2125         we're running in WebKit2 mode.
2126
2127 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
2128
2129         Reviewed by Yury Semikhatsky.
2130
2131         Web Inspector: Clean up Inspector strings.
2132         https://bugs.webkit.org/show_bug.cgi?id=56557
2133
2134         Modify the script to deal correctly with "\xNN" escapes, and to
2135         check strings in Chromium's DevTools.js.
2136
2137         * Scripts/check-inspector-strings:
2138
2139 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
2140
2141         Reviewed by Benjamin Poulain.
2142
2143         Update autoinstall to install mechanize 0.2.4
2144         https://bugs.webkit.org/show_bug.cgi?id=56499
2145
2146         Newer versions of mechanize support HTTPS proxies, which is necessary
2147         for people using webkit-patch behind firewalls.
2148
2149         * Scripts/webkitpy/common/system/autoinstall.py:
2150         * Scripts/webkitpy/thirdparty/__init__.py:
2151
2152 2011-03-16  Sam Weinig  <sam@webkit.org>
2153
2154         Reviewed by Adam Roben.
2155
2156         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
2157         https://bugs.webkit.org/show_bug.cgi?id=56541
2158
2159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2160         (WTR::InjectedBundlePage::willSendRequestForFrame):
2161         Check for an empty host in addition to a null host.  This bug was introduced
2162         when porting off of the KURL code and onto the WKURLRef version.
2163
2164 2011-03-16  Sam Weinig  <sam@webkit.org>
2165
2166         Reviewed by Adam Roben.
2167
2168         Add Lucas Forschler to the list of WebKit committers.
2169
2170         * Scripts/webkitpy/common/config/committers.py:
2171
2172 2011-03-16  Sam Weinig  <sam@webkit.org>
2173
2174         Reviewed upon and dictated through Adam Roben.
2175
2176         Escape crashing function names in results.html. This fixes an issue
2177         when a crash involves a type with templates.
2178
2179         * Scripts/old-run-webkit-tests:
2180
2181 2011-03-16  Daniel Sievers  <sievers@google.com>
2182
2183         Reviewed by James Robinson.
2184
2185         Add setting to always force compositing mode
2186         https://bugs.webkit.org/show_bug.cgi?id=56156
2187
2188         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2189         (main):
2190         * DumpRenderTree/chromium/TestShell.cpp:
2191         (TestShell::TestShell):
2192         (TestShell::resetWebSettings):
2193         * DumpRenderTree/chromium/TestShell.h:
2194         (TestShell::setForceCompositingMode):
2195         * DumpRenderTree/chromium/WebPreferences.cpp:
2196         (WebPreferences::reset):
2197         (WebPreferences::applyTo):
2198         * DumpRenderTree/chromium/WebPreferences.h:
2199
2200 2011-03-15  Hayato Ito  <hayato@chromium.org>
2201
2202         Reviewed by Ojan Vafai.
2203
2204         Ignore files that will be used by reftests in old-run-webkit-tests.
2205
2206         https://bugs.webkit.org/show_bug.cgi?id=55936
2207
2208         * Scripts/old-run-webkit-tests:
2209
2210 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
2211
2212         Reviewed by Adam Roben.
2213
2214         Function relativeScriptsDir doesn't return the correct relative
2215         Scripts directory.
2216
2217         * Scripts/webkitdirs.pm:
2218         (relativeScriptsDir): Ensure we use the directory that contains
2219         webkitdirs.pm, not the one that contains the original script that
2220         was invoked.
2221
2222 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2223
2224         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
2225         fix to link against the Security framework after recent WebKitSystemInterface changes.
2226
2227         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2228         (LayoutTestController::originsWithLocalStorage):
2229         * wx/build/settings.py:
2230         * wx/build/waf_extensions.py:
2231
2232 2011-03-15  Sam Weinig  <sam@webkit.org>
2233
2234         Reviewed by Darin Adler.
2235
2236         Add script to convert a patch to a prettypatch and show in the default browser
2237         https://bugs.webkit.org/show_bug.cgi?id=56416
2238
2239         This can be used either like
2240             $ svn-create-patch | show-pretty-diff
2241         or
2242             $ show-pretty-diff patch.diff
2243
2244         * Scripts/show-pretty-diff: Added.
2245
2246 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
2247
2248         Rubber-stamped by Adam Roben.
2249
2250         Adding myself as a reviewer.
2251
2252         * Scripts/webkitpy/common/config/committers.py:
2253
2254 2011-03-15  Anders Carlsson  <andersca@apple.com>
2255
2256         Try to fix the Windows build.
2257
2258         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2259         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2260
2261 2011-03-15  Anders Carlsson  <andersca@apple.com>
2262
2263         Reviewed by Sam Weinig.
2264
2265         Make sure that NP_Shutdown is always the last NPP function called
2266         https://bugs.webkit.org/show_bug.cgi?id=56391
2267
2268         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
2269
2270         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2271         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2272         (PluginTest::PluginTest):
2273         (PluginTest::NP_Shutdown):
2274         (PluginTest::registerNPShutdownFunction):
2275         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2276         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2277         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2278         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2279         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2280         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2281         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2282         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2283         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2284         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2285         (NP_Shutdown):
2286         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2287         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2288         * GNUmakefile.am:
2289
2290 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2291
2292         Reviewed by Tony Chang.
2293
2294         Autofilled form elements are assigned fixed background color but not text color
2295         https://bugs.webkit.org/show_bug.cgi?id=48382
2296
2297         * DumpRenderTree/LayoutTestController.cpp:
2298         (setAutofilledCallback): Added.
2299         (LayoutTestController::staticFunctions):
2300         * DumpRenderTree/LayoutTestController.h:
2301         * DumpRenderTree/chromium/LayoutTestController.cpp:
2302         (LayoutTestController::LayoutTestController):
2303         (LayoutTestController::setAutofilled): Added.
2304         * DumpRenderTree/chromium/LayoutTestController.h:
2305         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2306         (LayoutTestController::setAutofilled): Added.
2307         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2308         (LayoutTestController::setAutofilled): Added.
2309         (LayoutTestController::setValueForUser): Style tweak.
2310         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2311         (LayoutTestController::setAutofilled): Added (stub).
2312         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2313         (LayoutTestController::setAutofilled): Added (stub).
2314
2315 2011-03-15  Dan Bernstein  <mitz@apple.com>
2316
2317         Build fix after r81135.
2318
2319         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2320
2321 2011-03-15  Dan Bernstein  <mitz@apple.com>
2322
2323         Build fix after r81135.
2324
2325         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2326         * WebKitTestRunner/mac/TestControllerMac.mm:
2327         * WebKitTestRunner/mac/TestInvocationMac.mm:
2328         * WebKitTestRunner/mac/main.mm:
2329
2330 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2331
2332         Reviewed by Adam Barth.
2333
2334         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2335         https://bugs.webkit.org/show_bug.cgi?id=56349
2336
2337         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2338         on platforms where we use it. Copied from DumpRenderTree.pro.
2339
2340 2011-03-15  Dan Bernstein  <mitz@apple.com>
2341
2342         Build fix after r81135.
2343
2344         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2345         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2346
2347 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2348
2349         Reviewed by Darin Adler.
2350
2351         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2352         info into the headers rather than in export symbol definition files, but disable it on 
2353         all platforms initially so we can deal with port build issues one port at a time.
2354         
2355         https://bugs.webkit.org/show_bug.cgi?id=27551
2356
2357         * DumpRenderTree/cg/ImageDiffCG.cpp:
2358         * DumpRenderTree/chromium/config.h:
2359         * DumpRenderTree/config.h:
2360         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2361         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2362         * WebKitAPITest/HostWindow.cpp:
2363         * WebKitAPITest/TestsController.cpp:
2364         * WebKitAPITest/config.h: Added.
2365         * WebKitAPITest/main.cpp:
2366         * WebKitAPITest/tests/WebViewDestruction.cpp:
2367         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2368         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2369         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2370         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2371         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2372         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2373         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2374         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2375         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2376         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2377         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2378         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2379         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2380         * WebKitTestRunner/TestController.cpp:
2381         * WebKitTestRunner/TestInvocation.cpp:
2382         * WebKitTestRunner/config.h: Added.
2383         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2384         * WebKitTestRunner/qt/TestControllerQt.cpp:
2385         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2386         * WebKitTestRunner/qt/main.cpp:
2387         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2388         * WebKitTestRunner/win/TestControllerWin.cpp:
2389         * WebKitTestRunner/win/TestInvocationWin.cpp:
2390         * WebKitTestRunner/win/main.cpp:
2391         * wx/build/settings.py:
2392
2393 2011-03-15  Hayato Ito  <hayato@chromium.org>
2394
2395         Reviewed by Shinichiro Hamaji.
2396
2397         [NRWT] Add support for reftests to new-run-webkit-tests.
2398
2399         https://bugs.webkit.org/show_bug.cgi?id=55457
2400
2401         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2402         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2403         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2404         * Scripts/webkitpy/layout_tests/port/base.py:
2405         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2406         * Scripts/webkitpy/layout_tests/port/test.py:
2407         * Scripts/webkitpy/layout_tests/port/test_files.py:
2408         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2409
2410 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2411
2412         Reviewed by Martin Robinson.
2413
2414         [GTK] Fix compilation warning after r80892
2415         https://bugs.webkit.org/show_bug.cgi?id=56302
2416
2417         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2418         (LayoutTestController::originsWithLocalStorage):
2419
2420 2011-03-15  Robert Hogan  <robert@webkit.org>
2421
2422         Reviewed by Adam Barth.
2423
2424         Document the qmakearg argument, and hint how to build webkit2 on Qt
2425         https://bugs.webkit.org/show_bug.cgi?id=56326
2426
2427         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2428
2429 2011-03-15  Adam Roben  <aroben@apple.com>
2430
2431         Make Windows 7 Release (Tests) a core builder
2432
2433         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2434         give it a few more days of greenness first.
2435
2436         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2437
2438         Reviewed by Sam Weinig.
2439
2440         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2441         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2442
2443         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2444         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2445         Updated the core regexps to match the buildbot module. Updated the expected results to match
2446         the current set of core builders.
2447
2448 2011-03-14  Adam Roben  <aroben@apple.com>
2449
2450         Add forgotten file from r81116
2451
2452         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2453
2454 2011-03-14  Sam Weinig  <sam@webkit.org>
2455
2456         Reviewed by Adam Roben.
2457
2458         about:blank fake responses don't get serialized when sent the UIProcess
2459         <rdar://problem/9108119>
2460         https://bugs.webkit.org/show_bug.cgi?id=56357
2461
2462         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2463         (TestWebKitAPI::decidePolicyForResponse):
2464         (TestWebKitAPI::TEST):
2465         Add test that loads of about:blank have a response with a MIMEType of text/html.
2466
2467         * TestWebKitAPI/PlatformUtilities.h:
2468         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2469         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2470         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2471         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2472         Add helper to get the MIMEType from a WKURLResponse.
2473
2474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2475         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2476         Add new files.
2477
2478 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2479
2480         Reviewed by Kenneth Rohde Christiansen.
2481
2482         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2483         https://bugs.webkit.org/show_bug.cgi?id=56006
2484
2485         * QtTestBrowser/launcherwindow.cpp:
2486         (LauncherWindow::initializeView):
2487         * QtTestBrowser/main.cpp:
2488         (LauncherApplication::handleUserOptions):
2489
2490 2011-03-14  James Kozianski  <koz@chromium.org>
2491
2492         Reviewed by Ojan Vafai.
2493
2494         Add method to make BuildBot return test outputs
2495         https://bugs.webkit.org/show_bug.cgi?id=54374
2496
2497         The Builder.latest_cached_build will be used by the new rebaseline
2498         script to determine the build to use baselines from.
2499
2500         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2501         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2502
2503 2011-03-14  Adam Roben  <aroben@apple.com>
2504
2505         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2506
2507         Reviewed by Sam Weinig.
2508
2509         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2510         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2511         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2512         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2513         ensure the web process is initialized, then ask the bundle to run the test and assert that
2514         it succeeded.
2515
2516         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2517         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2518         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2519         handle a given URL.
2520         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2521         URL type cannot be handled).
2522         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2523         result.
2524
2525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2526         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2527         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2528         Added new files to the project.
2529
2530 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2531
2532         Unreviewed, rolling out r81094.
2533         http://trac.webkit.org/changeset/81094
2534         https://bugs.webkit.org/show_bug.cgi?id=56355
2535
2536         Broke the chromium DRT related build. (Requested by dave_levin
2537         on #webkit).
2538
2539         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2540         (main):
2541         * DumpRenderTree/chromium/LayoutTestController.cpp:
2542         (LayoutTestController::LayoutTestController):
2543         (LayoutTestController::layerTreeAsText):
2544         * DumpRenderTree/chromium/LayoutTestController.h:
2545         * DumpRenderTree/chromium/TestShell.cpp:
2546         (TestShell::runFileTest):
2547         (TestShell::dump):
2548         * DumpRenderTree/chromium/TestShell.h:
2549         (TestParams::TestParams):
2550
2551 2011-03-14  Daniel Sievers  <sievers@google.com>
2552
2553         Reviewed by Simon Fraser.
2554
2555         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2556         https://bugs.webkit.org/show_bug.cgi?id=56139
2557
2558         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2559         (main):
2560         * DumpRenderTree/chromium/LayoutTestController.cpp:
2561         (LayoutTestController::LayoutTestController):
2562         (LayoutTestController::layerTreeAsText):
2563         * DumpRenderTree/chromium/LayoutTestController.h:
2564         (LayoutTestController::setShowDebugLayerTree):
2565         * DumpRenderTree/chromium/TestShell.cpp:
2566         (TestShell::runFileTest):
2567         (TestShell::dump):
2568         * DumpRenderTree/chromium/TestShell.h:
2569         (TestParams::TestParams):
2570
2571 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2572
2573         Reviewed by Adam Roben.
2574
2575         [Qt][WK2]Unbreak InjectedBundle on Qt
2576         https://bugs.webkit.org/show_bug.cgi?id=54109
2577
2578         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2579         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2580         API's instead of KURL to analyze the URL.
2581         * WebKitTestRunner/StringFunctions.h:
2582         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2583         in the WebKitTestRunner project.
2584         (WTR::toWK): Use adoptWK.
2585         (WTR::operator<<): Added helper for printing a WKURL.
2586         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2587         against WebCore.
2588
2589 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2590
2591         Reviewed by Kenneth Rohde Christiansen.
2592
2593         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2594         https://bugs.webkit.org/show_bug.cgi?id=56321
2595
2596         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2597         to the list of exceptions for WebKit2 C API headers.
2598
2599 2011-03-14  Adam Roben  <aroben@apple.com>
2600
2601         Show the list of recent leaky builds in reverse chronological order
2602
2603         Previously they were being shown in a deterministic but surprising order based on
2604         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2605
2606         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2607
2608         Reviewed by Darin Adler.
2609
2610         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2611         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2612         callback.
2613
2614 2011-03-14  Adam Roben  <aroben@apple.com>
2615
2616         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2617
2618         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2619         analyze
2620
2621         Reviewed by David Kilzer and Joe Pecoraro.
2622
2623         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2624         (#url-prompt): Made this a bit taller to make room for the list of builds.
2625
2626         (#recent-builds-loading-indicator):
2627         (#recent-builds-list):
2628         Added styles for the build list and loading indicator.
2629
2630         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2631         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2632         it. This will unescape it.
2633         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2634         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2635         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2636         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2637         prompt UI.
2638         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2639         now also used when a recent build is clicked.
2640
2641         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2642         (RecentBuildsLoader): Store the callback.
2643         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2644         builder. Find the revision number, leak count, and results URL for each one. Pass the
2645         resulting info to our callback.
2646
2647         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2648         (range): Added this helper function to return an array containing the integers [0, n).
2649
2650         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2651         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2652
2653 2011-03-14  Mark Rowe  <mrowe@apple.com>
2654
2655         Reviewed by Adam Roben.
2656
2657         Fix two memory leaks within LayoutTestController's storage support.
2658
2659         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2660         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2661         by JSStringCreateWithCFString.
2662         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2663         allocate.
2664
2665 2011-03-14  Mark Rowe  <mrowe@apple.com>
2666
2667         Reviewed by Oliver Hunt.
2668
2669         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2670
2671         * DumpRenderTree/LayoutTestController.cpp:
2672         (LayoutTestController::staticFunctions): Remove duplicate entries.
2673
2674 2011-03-14  Alice Liu  <alice.liu@apple.com>
2675
2676         Reviewed by Dan Bernstein.
2677
2678         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2679
2680         * DumpRenderTree/mac/PerlSupport/Makefile:
2681         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2682
2683 2011-03-14  Daniel Bates  <dbates@rim.com>
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=55438
2686         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2687         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2688
2689         * Scripts/build-webkit:
2690
2691 2011-03-14  Daniel Bates  <dbates@rim.com>
2692
2693         Reviewed by David Kilzer.
2694
2695         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2696         https://bugs.webkit.org/show_bug.cgi?id=55438
2697
2698         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2699         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2700         CMake arguments for feature defines.
2701
2702         * Scripts/build-webkit:
2703           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2704           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2705           - Sorted forward declarations.
2706           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2707             Modified call sites as needed.
2708         * Scripts/webkitdirs.pm:
2709           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2710           - Added buildCMakeGeneratedProject() to build using generated build system.
2711           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2712           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2713             a CMake project.
2714           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2715
2716 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2717
2718         Reviewed by Steve Block.
2719
2720         Detach Geolocation from Frame when Page destroyed.
2721         https://bugs.webkit.org/show_bug.cgi?id=52877
2722
2723         Extend the layout test controller to expose the number of pending
2724         geolocation requests, so that we can test that the requests have
2725         been cancelled on page close.
2726
2727         * DumpRenderTree/LayoutTestController.cpp:
2728         (numberOfPendingGeolocationPermissionRequestsCallback):
2729         (LayoutTestController::staticFunctions):
2730         * DumpRenderTree/LayoutTestController.h:
2731         * DumpRenderTree/chromium/LayoutTestController.cpp:
2732         (LayoutTestController::LayoutTestController):
2733         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2734         * DumpRenderTree/chromium/LayoutTestController.h:
2735         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2736         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2737         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2738         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2739         * DumpRenderTree/mac/UIDelegate.h:
2740         * DumpRenderTree/mac/UIDelegate.mm:
2741         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2742         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2743         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2744         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2745         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2746         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2747         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2748         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2749
2750
2751 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2752
2753         Unreviewed. Modify my email address in committers.py.
2754
2755         * Scripts/webkitpy/common/config/committers.py:
2756
2757 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2758
2759         Reviewed by Kenneth Rohde Christiansen.
2760
2761         [Qt] QtLauncher does not load the same set of fonts as the DRT
2762         https://bugs.webkit.org/show_bug.cgi?id=34959
2763
2764         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2765         When this option is used the webkit fonts are loaded the same
2766         as they are in DumpRenderTree.  This option can be used on
2767         QtTestBrowser and run-launcher.  It can only be used
2768         on Linux systems with FcInit and is configured as such.
2769
2770         * QtTestBrowser/launcherwindow.h:
2771         (WindowOptions::WindowOptions):
2772         * QtTestBrowser/main.cpp:
2773         (initWebKitTestFonts):
2774         (launcherMain):
2775         (LauncherApplication::handleUserOptions):
2776
2777 2011-03-12  Dan Bernstein  <mitz@apple.com>
2778
2779         Reviewed by Mark Rowe.
2780
2781         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2782         DumpRenderTree is being built for.
2783
2784         * DumpRenderTree/mac/PerlSupport/Makefile:
2785
2786 2011-03-12  Dan Bernstein  <mitz@apple.com>
2787
2788         Suggested by Mark Rowe.
2789
2790         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2791         as they were before r80915.
2792
2793 2011-03-12  Anders Carlsson  <andersca@apple.com>
2794
2795         Reviewed by Sam Weinig.
2796
2797         Should be able to download a PDF to the Downloads folder
2798         https://bugs.webkit.org/show_bug.cgi?id=56256
2799
2800         * MiniBrowser/mac/BrowserWindowController.m:
2801         (-[BrowserWindowController awakeFromNib]):
2802         * WebKitTestRunner/TestController.cpp:
2803         (WTR::TestController::createOtherPage):
2804         (WTR::TestController::initialize):
2805         Update for API changes.
2806
2807 2011-03-11  Anton D'Auria  <adauria@apple.com>
2808
2809         Reviewed and landed by Brady Eidson.
2810
2811         https://bugs.webkit.org/show_bug.cgi?id=51878
2812         Add WebKit1 API to view and delete local storage
2813
2814         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2815
2816         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2817         * DumpRenderTree/LayoutTestController.cpp:
2818         (syncLocalStorageCallback):
2819         (observeStorageTrackerNotificationsCallback):
2820         (deleteAllLocalStorageCallback):
2821         (deleteLocalStorageForOriginCallback):
2822         (originsWithLocalStorageCallback):
2823         (LayoutTestController::staticFunctions):
2824         * DumpRenderTree/LayoutTestController.h:
2825         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2826         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2827         (-[StorageTrackerDelegate init]):
2828         (-[StorageTrackerDelegate logNotifications:controller:]):
2829         (-[StorageTrackerDelegate originModified:]):
2830         (-[StorageTrackerDelegate dealloc]):
2831         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2832         * DumpRenderTree/chromium/LayoutTestController.cpp:
2833         (LayoutTestController::LayoutTestController):
2834         (LayoutTestController::deleteAllLocalStorage):
2835         (LayoutTestController::originsWithLocalStorage):
2836         (LayoutTestController::deleteLocalStorageForOrigin):
2837         (observeStorageTrackerNotifications):
2838         (syncLocalStorage):
2839         * DumpRenderTree/chromium/LayoutTestController.h:
2840         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2841         (LayoutTestController::originsWithLocalStorage):
2842         (LayoutTestController::deleteAllLocalStorage):
2843         (LayoutTestController::deleteLocalStorageForOrigin):
2844         (LayoutTestController::observeStorageTrackerNotifications):
2845         (LayoutTestController::syncLocalStorage):
2846         * DumpRenderTree/mac/DumpRenderTree.mm:
2847         (resetDefaultsToConsistentValues):
2848         (allocateGlobalControllers):
2849         (releaseGlobalControllers):
2850         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2851         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2852         (LayoutTestController::syncLocalStorage):
2853         (LayoutTestController::observeStorageTrackerNotifications):
2854         (LayoutTestController::deleteAllLocalStorage):
2855         (LayoutTestController::originsWithLocalStorage):
2856         (LayoutTestController::deleteLocalStorageForOrigin):
2857         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2858         (LayoutTestController::originsWithLocalStorage):
2859         (LayoutTestController::deleteAllLocalStorage):
2860         (LayoutTestController::deleteLocalStorageForOrigin):
2861         (LayoutTestController::observeStorageTrackerNotifications):
2862         (LayoutTestController::syncLocalStorage):
2863         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2864         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2865         (LayoutTestController::clearAllApplicationCaches):
2866         (LayoutTestController::syncLocalStorage):
2867         (LayoutTestController::observeStorageTrackerNotifications):
2868         (LayoutTestController::clearAllDatabases):
2869         (LayoutTestController::deleteAllLocalStorage):
2870         (LayoutTestController::originsWithLocalStorage):
2871         (LayoutTestController::deleteLocalStorageForOrigin):
2872         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2873         (LayoutTestController::syncLocalStorage):
2874         (LayoutTestController::observeStorageTrackerNotifications):
2875         (LayoutTestController::clearAllDatabases):
2876         (LayoutTestController::deleteAllLocalStorage):
2877         (LayoutTestController::originsWithLocalStorage):
2878         (LayoutTestController::deleteLocalStorageForOrigin):
2879
2880 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2881
2882         Reviewed by Adam Roben.
2883
2884         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2885         Process has finished launching.
2886         https://bugs.webkit.org/show_bug.cgi?id=56208
2887
2888         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2889         (TestWebKitAPI::TEST):
2890         Test that calling WKContextClearResourceCaches works with both options when called before
2891         the Web Process is valid.
2892
2893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2894         Add the new test.
2895         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2896         Ditto.
2897
2898 2011-03-11  Adam Roben  <aroben@apple.com>
2899
2900         Make it possible to view all leaks from a build at once in Leaks Viewer
2901
2902         You can now give Leaks Viewer the URL of a build results page (e.g.,
2903         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2904         will load all the leaks files from that build.
2905
2906         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2907         files from a particular build at once, rather than one at a time
2908
2909         Reviewed by David Kilzer.
2910
2911         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2912         (LeaksLoader): Initialize our properties.
2913         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2914         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2915         from that page.
2916         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2917         so it can provide feedback. Then load each one and pass it to the client.
2918         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2919         it into a DOM, pull out all the links to leaks files, and load each one.
2920
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2922         (LeaksParser): Initialize our worker.
2923         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2924
2925         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2926         This code mostly came from Worker.js.
2927         (LeaksParserWorker): Initialize our profile.
2928         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2929         profile.
2930         (LeaksParserWorker.prototype._parseLeaks):
2931         (LeaksParserWorker.prototype._createNode):
2932         (LeaksParserWorker.prototype._incorporateLeaks):
2933         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2934         version of createProfile which adds to this.profile instead of making a new profile each
2935         time.
2936         (onmessage): Parse the file and send back the new profile.
2937
2938         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2939         (#loading-indicator):
2940         (#spinner):
2941         (#loading-indicator-label):
2942         Tweaked styles to accomodate a longer label.
2943
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2945         (LeaksViewer.loaded): Set up a loader and parser.
2946
2947         (LeaksViewer.get filesLeftToParse):
2948         (LeaksViewer.set filesLeftToParse):
2949         Added these simple accessors.
2950
2951         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2952         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2953         the parser.
2954         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2955         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2956         _loadLeaksFromURL function).
2957         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2958         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2959         loading indicator, including the number of files being loaded.
2960         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2961         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2962         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2963         _loadingIndicatorText.
2964
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2966         (getResource): Moved here from LeaksViewer.js.
2967
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2969         LeaksParserWorker.js.
2970
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2972         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2973
2974 2011-03-11  Adam Roben  <aroben@apple.com>
2975
2976         Don't trigger a build when build.webkit.org's HTML files are modified
2977
2978         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2979
2980         Reviewed by Dan Bernstein.
2981
2982         * Scripts/webkitpy/common/config/build.py:
2983         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2984         directories that shouldn't trigger builds. Re-sorted the list.
2985
2986         * Scripts/webkitpy/common/config/build_unittest.py:
2987         (ShouldBuildTest): Added a test to cover the above change.
2988
2989 2011-03-11  Adam Roben  <aroben@apple.com>
2990
2991         Roll out r80848
2992
2993         It was accidentally committed.
2994
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2996         (LeaksViewer._loadLeaksFromURL):
2997
2998 2011-03-11  Tony Chang  <tony@chromium.org>
2999
3000         Reviewed by Ojan Vafai.
3001
3002         kill hung lighttpd processes on the chromium win bot
3003         https://bugs.webkit.org/show_bug.cgi?id=56152
3004
3005         Sometimes this process doesn't exit and it holds on to
3006         a log file that we can't delete or copy, causing the tests
3007         to go red.
3008
3009         * BuildSlaveSupport/win/kill-old-processes:
3010
3011 2011-03-11  Ilya Sherman  <isherman@chromium.org>
3012
3013         Reviewed by Kent Tamura.
3014
3015         [Chromium] missing HTMLInputElement::setValueForUser() to tests
3016         https://bugs.webkit.org/show_bug.cgi?id=55854
3017
3018         * DumpRenderTree/chromium/LayoutTestController.cpp:
3019         (LayoutTestController::LayoutTestController):
3020         (LayoutTestController::setValueForUser): Added.
3021         * DumpRenderTree/chromium/LayoutTestController.h:
3022
3023 2011-03-10  Peter Kasting  <pkasting@google.com>
3024
3025         Reviewed by Dimitri Glazkov.
3026
3027         Clean up some gross code in TestShellWin.cpp.  No functional change.
3028         https://bugs.webkit.org/show_bug.cgi?id=56048
3029
3030         * DumpRenderTree/chromium/TestShellWin.cpp:
3031         (checkLayoutTestSystemDependencies):
3032
3033 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
3034
3035         Reviewed by Laszlo Gombos.
3036
3037         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
3038
3039         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3040         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
3041
3042 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3043
3044         Reviewed by Kenneth Rohde Christiansen.
3045
3046         [EFL] Make single backing store the default for EWebLauncher
3047         https://bugs.webkit.org/show_bug.cgi?id=55753
3048
3049         Set single backing store the default for EWebLauncher.
3050
3051         * EWebLauncher/main.c:
3052         (main):
3053
3054 2011-03-10  Adam Roben  <aroben@apple.com>
3055
3056         Ignore errors from files being held open when creating a test result archive
3057
3058         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
3059         fails to delete the results directory
3060
3061         Reviewed by Mark Rowe.
3062
3063         * BuildSlaveSupport/test-result-archive:
3064         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
3065         thrown when a process is holding a file open.
3066
3067 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3068
3069         Unreviewed, rolling out r80701.
3070         http://trac.webkit.org/changeset/80701
3071         https://bugs.webkit.org/show_bug.cgi?id=56126
3072
3073         fast/dom/Geolocation/window-close-crash.html fails on Snow
3074         Leopard release builds (Requested by mihaip on #webkit).
3075
3076         * DumpRenderTree/LayoutTestController.cpp:
3077         (LayoutTestController::staticFunctions):
3078         * DumpRenderTree/LayoutTestController.h:
3079         * DumpRenderTree/chromium/LayoutTestController.cpp:
3080         (LayoutTestController::LayoutTestController):
3081         * DumpRenderTree/chromium/LayoutTestController.h:
3082         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3083         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3084         * DumpRenderTree/mac/UIDelegate.h:
3085         * DumpRenderTree/mac/UIDelegate.mm:
3086         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3087         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3088         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3089         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3090
3091 2011-03-10  Philippe Normand  <pnormand@igalia.com>
3092
3093         Reviewed by Gustavo Noronha Silva.
3094
3095         [GTK] run-gtk-tests doesn't fail if a test crashes
3096         https://bugs.webkit.org/show_bug.cgi?id=56089
3097
3098         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
3099         even if a test crashes. So run the tests individually and if a
3100         test fails remember its exit code so run-gtk-test fails too, if
3101         required.
3102
3103 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3104
3105         Reviewed by Dmitry Titov.
3106
3107         Detach Geolocation from Frame when Page destroyed.
3108         https://bugs.webkit.org/show_bug.cgi?id=52877
3109
3110         Extend the layout test controller to expose the number of pending
3111         geolocation requests, so that we can test that the requests have
3112         been cancelled on page close.
3113
3114         * DumpRenderTree/LayoutTestController.cpp:
3115         (numberOfPendingGeolocationPermissionRequestsCallback):
3116         (LayoutTestController::staticFunctions):
3117         * DumpRenderTree/LayoutTestController.h:
3118         * DumpRenderTree/chromium/LayoutTestController.cpp:
3119         (LayoutTestController::LayoutTestController):
3120         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3121         * DumpRenderTree/chromium/LayoutTestController.h:
3122         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3123         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3125         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3126         * DumpRenderTree/mac/UIDelegate.h:
3127         * DumpRenderTree/mac/UIDelegate.mm:
3128         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3129         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3130         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3131         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3132         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3133         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3134         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3135         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3136
3137
3138 2011-03-09  Adam Roben  <aroben@apple.com>
3139
3140         Hide Leaks Viewer's URL prompt by default
3141
3142         We will show it as needed. I think I left it visible by default by accident after doing some
3143         testing.
3144
3145         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
3146         URL is passed as a query parameter, but does
3147
3148         Reviewed by Simon Fraser.
3149
3150         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3151
3152 2011-03-09  Adam Roben  <aroben@apple.com>
3153
3154         Don't use Element.classList or box-shadow in Leaks Viewer
3155
3156         They aren't supported by Safari 5. Luckily we have substitutes for them!
3157
3158         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
3159
3160         Reviewed by Simon Fraser.
3161
3162         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3163         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
3164
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3166         (LeaksViewer.urlPromptButtonClicked):
3167         (LeaksViewer._displayURLPrompt):
3168         (LeaksViewer._setLoadingIndicatorHidden):
3169         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
3170
3171 2011-03-09  Adam Roben  <aroben@apple.com>
3172
3173         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
3174
3175         Rubber-stamped by David Kilzer.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3178
3179 2011-03-09  Adam Roben  <aroben@apple.com>
3180
3181         Add a Leaks Viewer tool to build.webkit.org
3182
3183         This tool parses leaks from the files generated by the leaks bot and displays them in a
3184         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
3185         code).
3186
3187         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
3188         be passed to the tool via the "url" query parameter.
3189
3190         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
3191         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
3192         Inspector's Heavy profile view. But it's still pretty useful as-is.
3193
3194         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
3195
3196         Reviewed by Darin Adler.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
3199         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
3200         (#url-prompt): This is the prompt itself.
3201
3202         (#loading-indicator):
3203         (#loading-indicator > img):
3204         These show a spinner in the bottom-right when we're loading a leaks file.
3205
3206         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
3207         as percentages.
3208
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
3210         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
3211         URL if one wasn't given to us as a query parameter).
3212
3213         (LeaksViewer.get loading):
3214         (LeaksViewer.set loading):
3215         (LeaksViewer.get url):
3216         (LeaksViewer.set url):
3217         Pretty simple accessors.
3218
3219         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
3220         prompt.
3221         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
3222         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
3223         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
3224         the profile to the Web Inspector code once it's been created.
3225         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
3226         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
3227         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
3228         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
3229
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
3231         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
3232         (ProfilerAgent.getProfile): Store the callback.
3233         (ProfilerAgent.profileReady): Call the callback.
3234         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
3235         count and total leak counts as real values, not percentages or milliseconds.
3236
3237         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
3238         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
3239         (parseLeaks): Extract call stacks out of a leaks file.
3240         (createNode): Helper function to create a new empty profile node.
3241         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
3242         WebInspector.ProfileView.
3243
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
3245
3246 2011-03-09  Dan Bernstein  <mitz@apple.com>
3247
3248         Reviewed by Adam Roben.
3249
3250         Combine multiple --ignore-tests values
3251         https://bugs.webkit.org/show_bug.cgi?id=56016
3252
3253         * Scripts/old-run-webkit-tests:
3254
3255 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
3256
3257         Reviewed by David Levin.
3258
3259         Adding myself to the committer file.
3260
3261         * Scripts/webkitpy/common/config/committers.py:
3262
3263 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3264
3265         Rubber-stamped by Adam Roben.
3266
3267         Fix two leaks I introduced into the API tests.
3268
3269         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3270         (TestWebKitAPI::TEST):
3271
3272 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3273
3274         Reviewed by Anders Carlsson.
3275
3276         Crash in CFNetwork visiting google.com
3277         https://bugs.webkit.org/show_bug.cgi?id=55958
3278
3279         Add a test for not trying to copy a null CFURLResponse.
3280
3281         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
3282         (TestWebKitAPI::TEST):
3283         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3284
3285 2011-03-08  Hayato Ito  <hayato@chromium.org>
3286
3287         Reviewed by Ojan Vafai.
3288
3289         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3290
3291         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3292
3293         https://bugs.webkit.org/show_bug.cgi?id=55450
3294
3295         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3296
3297 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3298
3299         Reviewed by Martin Robinson.
3300
3301         [GTK] Add layoutTestController.setValueForUser() after r80412
3302         https://bugs.webkit.org/show_bug.cgi?id=55862
3303
3304         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3305         (LayoutTestController::setValueForUser): Implement setValueForUser()
3306
3307 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3308
3309         Reviewed by Adam Barth.
3310
3311         Add script_shell_command to WebKitPort
3312         https://bugs.webkit.org/show_bug.cgi?id=55925
3313
3314         Add a central place where we generate the shell command from the script name.
3315         This function will be used later to detect the correct script interpreter on Win32.
3316
3317         * Scripts/webkitpy/common/config/ports.py:
3318         * Scripts/webkitpy/layout_tests/port/base.py:
3319         * Scripts/webkitpy/tool/steps/abstractstep.py:
3320         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3321
3322 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3323
3324         Reviewed by Adam Barth.
3325
3326         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3327         https://bugs.webkit.org/show_bug.cgi?id=55749
3328
3329         * Scripts/webkitpy/tool/commands/upload.py:
3330         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3331         * Scripts/webkitpy/tool/steps/__init__.py:
3332         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3333         * Scripts/webkitpy/tool/steps/options.py:
3334
3335 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3336
3337         Reviewed by David Levin.
3338
3339         Add support for DataTransferItems
3340         https://bugs.webkit.org/show_bug.cgi?id=55115
3341
3342         Enable data transfer items in DRT.
3343
3344         * DumpRenderTree/chromium/TestShell.cpp:
3345         (TestShell::TestShell):
3346
3347 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3348
3349         Reviewed by Tony Chang.
3350
3351         [test dashboard] pull treemap files
3352         https://bugs.webkit.org/show_bug.cgi?id=55852
3353
3354         * TestResultServer/handlers/dashboardhandler.py:
3355
3356 2011-03-03  Hayato Ito  <hayato@chromium.org>
3357
3358         Reviewed by Mihai Parparita.
3359
3360         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3361         previous image should not be used in the ChromiumDriver.
3362
3363         Also make sure that output image from the ChromiumDriver should be ''
3364         (empty string) if a test crashes for consistency with the WebKitDriver
3365         implementation.
3366
3367         https://bugs.webkit.org/show_bug.cgi?id=55746
3368
3369         * Scripts/webkitpy/layout_tests/port/chromium.py:
3370
3371 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3372
3373         Reviewed by Martin Robinson.
3374
3375         [Gtk] fast/js/navigator-language.html fails locally
3376         https://bugs.webkit.org/show_bug.cgi?id=55880
3377
3378         Add LANG variable to the clean environment when running
3379         old-run-webkit-tests script.
3380
3381         * Scripts/old-run-webkit-tests:
3382
3383 2011-03-07  Tony Chang  <tony@chromium.org>
3384
3385         Reviewed by Mihai Parparita.
3386
3387         [Chromium] Find .checksum files without .pngs and vice-versa
3388         https://bugs.webkit.org/show_bug.cgi?id=55236
3389
3390         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3391             mismatched results.
3392
3393 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3394
3395         Reviewed by Beth Dakin.
3396
3397         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3398         https://bugs.webkit.org/show_bug.cgi?id=55706
3399
3400         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3401
3402         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3403         (AccessibilityController::focusedElement):
3404            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
3405            because it could change at any time.
3406         (AccessibilityController::rootElement):
3407
3408 2011-03-07  Sam Weinig  <sam@webkit.org>
3409
3410         Reviewed by Anders Carlsson.
3411
3412         Add unableToImplementPolicy callback for WebKit2 policy client
3413         <rdar://problem/9071902>
3414         https://bugs.webkit.org/show_bug.cgi?id=55884
3415
3416         * MiniBrowser/mac/BrowserWindowController.m:
3417         (-[BrowserWindowController awakeFromNib]):
3418         Update policy client initialization struct for new member.
3419
3420 2011-03-07  Sam Weinig  <sam@webkit.org>
3421
3422         Reviewed by Anders Carlsson.
3423
3424         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3425         https://bugs.webkit.org/show_bug.cgi?id=55827
3426
3427         * MiniBrowser/mac/BrowserWindowController.m:
3428         (decidePolicyForResponse):
3429         (-[BrowserWindowController awakeFromNib]):
3430         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3431         (TestWebKitAPI::decidePolicyForResponse):
3432         (TestWebKitAPI::TEST):
3433         Update tools for new name.
3434
3435 2011-03-06  Daniel Bates  <dbates@rim.com>
3436
3437         Reviewed by Eric Seidel and David Kilzer.
3438
3439         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3440         https://bugs.webkit.org/show_bug.cgi?id=55503
3441
3442         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3443         in checkForJavaSDK().
3444
3445         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3446
3447         * Scripts/build-webkit:
3448
3449 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3450
3451         Reviewed by Sam Weinig.
3452
3453         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3454
3455         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3456         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3457             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3458
3459 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3460
3461         Reviewed by Darin Adler.
3462
3463         HTMLInputElement::setValue() should schedule change event when the element is focused
3464         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3465         https://bugs.webkit.org/show_bug.cgi?id=53160
3466
3467         * DumpRenderTree/LayoutTestController.cpp:
3468         (setValueForUserCallback):
3469         (LayoutTestController::staticFunctions):
3470         * DumpRenderTree/LayoutTestController.h:
3471         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3472         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3473         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3474         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3475         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3476         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3477         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3478         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3479         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3480         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3481
3482 2011-03-04  Mark Rowe  <mrowe@apple.com>
3483
3484         Reviewed by Alexey Proskuryakov.
3485
3486         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3487
3488         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3489         
3490         * DumpRenderTree/mac/CheckedMalloc.cpp:
3491         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3492         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3493         and then restore the initial protection flags when we're done.
3494
3495 2011-03-04  Evan Martin  <evan@chromium.org>
3496
3497         Reviewed by Tony Chang.
3498
3499         [gdb] pretty-print KURL in gdb
3500         https://bugs.webkit.org/show_bug.cgi?id=55788
3501
3502         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3503         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3504         pretty-printing.
3505
3506 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3507
3508         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3509
3510         Reviewed by Darin Adler.
3511
3512         * TestWebKitAPI/JavaScriptTest.cpp:
3513         (TestWebKitAPI::javaScriptCallback):
3514         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3515         (TestWebKitAPI::didRunJavaScript):
3516         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3517         (TestWebKitAPI::nullJavaScriptCallback):
3518         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3519         (TestWebKitAPI::didRunJavaScript):
3520
3521 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3522
3523         Make run-api-tests show failed if a test fails.
3524
3525         https://webkit.org/b/55725
3526
3527         Reviewed by Sam Weinig.
3528
3529         * Scripts/run-api-tests:
3530         (runTest): Remove "my" from the nested $result assignment so the
3531         check outside the condition sees the real result.
3532
3533 2011-03-02  MORITA Hajime  <morrita@google.com>
3534
3535         Reviewed by Kent Tamura.
3536
3537         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3538         https://bugs.webkit.org/show_bug.cgi?id=55434
3539
3540         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3541         and passed the object webkit_support::PostDelayedTask directly.
3542
3543         Note that the change keeps postTask() as is because it has a
3544         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3545         the main thread.
3546
3547         * DumpRenderTree/chromium/Task.cpp:
3548         (postDelayedTask):
3549         * DumpRenderTree/chromium/Task.h:
3550         (WebTask::Run):
3551
3552 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3553
3554         Reviewed by Kenneth Rohde Christiansen.
3555
3556         [QT] Implement mock client-based geolocation for layout testing
3557         https://bugs.webkit.org/show_bug.cgi?id=54334
3558
3559         Implement testing for Client-Based geolocation for QtWebkit.
3560
3561         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3562         (WebCore::DumpRenderTree::DumpRenderTree):
3563         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3564         (LayoutTestController::reset):
3565         (LayoutTestController::setGeolocationPermission):
3566         (LayoutTestController::setMockGeolocationError):
3567         (LayoutTestController::setMockGeolocationPosition):
3568
3569 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3570
3571         Unreviewed, rolling out r80237.
3572         http://trac.webkit.org/changeset/80237
3573         https://bugs.webkit.org/show_bug.cgi?id=55714
3574
3575         Windows bots aren't ready to be core (Requested by aroben on
3576         #webkit).
3577
3578         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3579         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3580
3581 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3582
3583         Reviewed by Tony Chang.
3584
3585         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3586         https://bugs.webkit.org/show_bug.cgi?id=55694
3587         
3588         Fixes for interruptions in NRWT:
3589         - Make TestRunInterruptedException be pickleable correctly (the base
3590           Exception class defines a __reduce__ that does not include the reason)
3591         - Fix ordering of returned arguments from TestRunner2._run_tests
3592           (interrupted and keyboard_interrupted were reversed)
3593         - Fix cancel_workers callsites (was using old name).
3594         - In handle_exception re-raise actual exception instance that was thrown
3595
3596         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3597         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3598         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3599         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3600
3601 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3602
3603         Unreviewed.
3604
3605         Adding myself as a committer.
3606
3607         * Scripts/webkitpy/common/config/committers.py:
3608
3609 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3610
3611         Reviewed by Mihai Parparita.
3612
3613         Teach sheriffbot to answer whois commands
3614         https://bugs.webkit.org/show_bug.cgi?id=55687
3615
3616         * Scripts/webkitpy/tool/bot/irc_command.py:
3617         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3618         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3619
3620 2011-03-03  Victoria Kirst  <vrk@google.com>
3621
3622         Reviewed by Eric Carlson.
3623
3624         Enable media tests in chromium-gpu/test_expectations
3625         https://bugs.webkit.org/show_bug.cgi?id=53608
3626
3627         Add media folder to the list of GPU test paths.
3628
3629         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3630
3631 2011-03-03  Adam Roben  <aroben@apple.com>
3632
3633         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3634
3635         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3636         incorrect parsing of absolute Windows-style file: URLs
3637
3638         Reviewed by Tim Hatcher.
3639
3640         * WebKitTestRunner/TestInvocation.cpp:
3641         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3642         <http://webkit.org/b/55683>.
3643
3644 2011-03-03  Tony Chang  <tony@chromium.org>
3645
3646         Reviewed by Dimitri Glazkov.
3647
3648         [chromium] Run kill-old-processes on the chromium-win bot too