[WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
[WebKit-https.git] / Tools / ChangeLog
1 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
4         https://bugs.webkit.org/show_bug.cgi?id=199094
5
6         Reviewed by Carlos Garcia Campos.
7
8         * MiniBrowser/gtk/BrowserTab.c:
9         (runColorChooserCallback):
10         (browserTabConstructed):
11         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
12         (testWebViewSyncRequestOnMaxConns):
13         (beforeAll):
14         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
15         (testWebSocketTLSErrors):
16         (beforeAll):
17         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
18         (WebKitTestServer::~WebKitTestServer):
19         (WebKitTestServer::getWebSocketURIForPath const):
20         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
21         (WTR::AccessibilityUIElement::rowHeaders const):
22         (WTR::AccessibilityUIElement::columnHeaders const):
23         (WTR::AccessibilityUIElement::isAttributeSettable):
24         (WTR::AccessibilityUIElement::x):
25         (WTR::AccessibilityUIElement::y):
26         (WTR::AccessibilityUIElement::width):
27         (WTR::AccessibilityUIElement::height):
28         (WTR::AccessibilityUIElement::clickPointX):
29         (WTR::AccessibilityUIElement::clickPointY):
30         (WTR::AccessibilityUIElement::intValue const):
31         (WTR::AccessibilityUIElement::minValue):
32         (WTR::AccessibilityUIElement::maxValue):
33         (WTR::stringAtOffset):
34
35 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
36
37         test-webkitpy is broken on macOS Catalina
38         https://bugs.webkit.org/show_bug.cgi?id=199078
39
40         Reviewed by Jonathan Bedard.
41
42         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
43         to the runner.
44         (main): 
45         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
46
47 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
48
49         Change status to "committer" in contributors.json
50
51         Unreviewed.
52
53         * Scripts/webkitpy/common/config/contributors.json:
54
55 2019-06-20  Alex Christensen  <achristensen@webkit.org>
56
57         Add unit test for UIContextMenuConfiguration API
58         https://bugs.webkit.org/show_bug.cgi?id=199043
59
60         Reviewed by Wenson Hsieh.
61
62         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
63         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
64         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
65         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
66         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
67         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
68         (TEST):
69         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
70         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
71         (-[TestContextMenuDriver delegate]):
72         (-[TestContextMenuDriver setDelegate:]):
73         (-[TestContextMenuDriver view]):
74         (-[TestContextMenuDriver setView:]):
75         (-[TestContextMenuDriver allowableMovement]):
76         (-[TestContextMenuDriver setAllowableMovement:]):
77         (-[TestContextMenuDriver primaryGestureRecognizer]):
78         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
79         (-[TestContextMenuDriver touchDuration]):
80         (-[TestContextMenuDriver setTouchDuration:]):
81         (-[TestContextMenuDriver locationInCoordinateSpace:]):
82         (-[TestContextMenuDriver cancelInteraction]):
83         (-[TestContextMenuDriver begin:]):
84         (-[TestContextMenuDriver clickDown]):
85         (-[TestContextMenuDriver clickUp]):
86         (-[TestContextMenuDriver end]):
87         * TestWebKitAPI/ios/UIKitSPI.h:
88
89 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
90
91         [ews-app] Status bubble should not turn orange when any build step is skipped
92         https://bugs.webkit.org/show_bug.cgi?id=199079
93
94         Reviewed by Jonathan Bedard.
95
96         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
97
98 2019-06-20  Alex Christensen  <achristensen@webkit.org>
99
100         Fix an internal engineering build after r246605
101        ​https://bugs.webkit.org/show_bug.cgi?id=197800
102
103         * TestWebKitAPI/TCPServer.cpp:
104
105 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
106
107         [ews-build] Triggered builds should use same revision as parent build
108         https://bugs.webkit.org/show_bug.cgi?id=198289
109
110         Reviewed by Jonathan Bedard.
111
112         * BuildSlaveSupport/ews-build/steps.py:
113         (CheckOutSpecificRevision): Build step to checkout specific revision.
114         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
115         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
116         (CheckOutSpecificRevision.start): Run appropriate git command.
117         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
118         builds use same revision as parent build.
119         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
120         * BuildSlaveSupport/ews-build/factories.py:
121         (Factory.__init__): Added CheckOutSpecificRevision step.
122
123 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
124
125         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
126         https://bugs.webkit.org/show_bug.cgi?id=199073
127
128         Reviewed by Jonathan Bedard.
129
130         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
131
132 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
133
134         [GTK] Enable navigation swipe layout tests
135         https://bugs.webkit.org/show_bug.cgi?id=198995
136
137         Reviewed by Michael Catanzaro.
138
139         Add a way for tests to enable and then control swipe gesture on GTK.
140
141         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
142         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
143         * WebKitTestRunner/PlatformGTK.cmake:
144         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
145         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
146         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
147         (WTR::UIScriptController::beginBackSwipe):
148         (WTR::UIScriptController::completeBackSwipe):
149
150 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
151
152         [GTK] HTTP layout tests don't run in flatpak
153         https://bugs.webkit.org/show_bug.cgi?id=199067
154
155         Reviewed by Michael Catanzaro.
156
157         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
158         check that path. Instead, add /app/lib/perl to Apache config directly.
159
160         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
161         /.flatpak-info instead.
162
163         * Scripts/webkitpy/port/base.py:
164         (Port._is_flatpak):
165         (Port._in_flatpak_sandbox):
166         * flatpak/flatpakutils.py:
167         (WebkitFlatpak.run_in_sandbox):
168         (is_sandboxed):
169
170 2019-06-18  Darin Adler  <darin@apple.com>
171
172         Tidy up the remaining bits of the AtomicString to AtomString rename
173         https://bugs.webkit.org/show_bug.cgi?id=198990
174
175         Reviewed by Michael Catanzaro.
176
177         * Scripts/do-webcore-rename: Removed already-done renames.
178         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
179
180 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         [GTK] Remove support for GTK2 plugins
183         https://bugs.webkit.org/show_bug.cgi?id=199065
184
185         Reviewed by Sergio Villar Senin.
186
187         * EWSTools/ubuntu-ews-packages:
188         * TestWebKitAPI/PlatformGTK.cmake:
189         * WebKitTestRunner/PlatformGTK.cmake:
190         * flatpak/org.webkit.GTK.yaml:
191         * gtk/install-dependencies:
192
193 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
194
195         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
196         https://bugs.webkit.org/show_bug.cgi?id=199053
197
198         Reviewed by Saam Barati.
199
200         Added a test stressing IsoHeap with multiple threads.
201
202         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
203         (assertHasObjects):
204         (assertHasOnlyObjects):
205         (assertClean):
206         (TEST):
207
208 2019-06-19  Zalan Bujtas  <zalan@apple.com>
209
210         [LFC] Expand tests coverage (1126 new tests -> 2324).
211
212         * LayoutReloaded/misc/LFC-passing-tests.txt:
213
214 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
215
216         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
217         https://bugs.webkit.org/show_bug.cgi?id=198957
218
219         Reviewed by Alex Christensen.
220
221         * TestWebKitAPI/CMakeLists.txt:
222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
223         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
224
225 2019-06-19  Keith Rollin  <krollin@apple.com>
226
227         Relocate some test tools in non-mac builds
228         https://bugs.webkit.org/show_bug.cgi?id=198984
229         <rdar://problem/51873261>
230
231         Reviewed by Andy Estes.
232
233         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
234         TestNetscapePlugin get created in
235         WebKit.framework/Versions/A/Resources on non-mac builds. This is
236         incorrect, as those bundles are shallow bundles that don't use the
237         Versions hierarchy. Instead, store these files directly in
238         WebKit.framework.
239
240         Note that getting rid of just the "Versions/A" path components and
241         putting the files in WebKit.framework/Resources doesn't work as
242         `codesign` treats the result as an invalid layout.
243
244         The work in this patch involves changing the definition of the custom
245         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
246         variable INSTALL_PATH is defined in terms of this variable. In order
247         to increase visiblity into this relationship, move both of these
248         variables into .xcconfig files if they weren't already. This
249         refactoring was done in a way to be the least disruptive and most
250         compatible with the previous definitions, even at the cost of being
251         repetitive.
252
253         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
254         * DumpRenderTree/mac/Configurations/Base.xcconfig:
255         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
256         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
257         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
258         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
259
260 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
261
262         [ews-build] Patch link should open the pretty patch
263         https://bugs.webkit.org/show_bug.cgi?id=199031
264
265         Reviewed by Jonathan Bedard.
266
267         * BuildSlaveSupport/ews-build/steps.py:
268         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
269
270 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
271
272         [ews-build] Add step to analyze Compile WebKit failures
273         https://bugs.webkit.org/show_bug.cgi?id=199025
274
275         Reviewed by Jonathan Bedard.
276
277         * BuildSlaveSupport/ews-build/steps.py:
278         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
279         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
280         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
281         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
282         this step is run only when compile-webkit failed.
283
284 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
285
286         [ews-build] Send email notifications for failures
287         https://bugs.webkit.org/show_bug.cgi?id=198919
288
289         Reviewed by Jonathan Bedard.
290
291         * BuildSlaveSupport/ews-build/master.cfg:
292
293 2019-06-19  Alex Christensen  <achristensen@webkit.org>
294
295         Add a unit test for client certificate authentication
296         https://bugs.webkit.org/show_bug.cgi?id=197800
297
298         Reviewed by Youenn Fablet.
299
300         Make better abstractions for reading and writing from/to TCPServer.
301         Add a unit test that causes a client certificate authentication challenge to happen.
302
303         * TestWebKitAPI/TCPServer.cpp:
304         (TestWebKitAPI::TCPServer::TCPServer):
305         (TestWebKitAPI::TCPServer::read):
306         (TestWebKitAPI::TCPServer::write):
307         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
308         (TestWebKitAPI::TCPServer::respondWithOK):
309         * TestWebKitAPI/TCPServer.h:
310         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
311         (credentialWithIdentity):
312         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
313         (TEST):
314         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
315         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
316         (-[ClientCertificateDelegate challengeCount]):
317         (TestWebKitAPI::TEST):
318         (respondWithChallengeThenOK): Deleted.
319         (credentialWithIdentityAndKeychainPath): Deleted.
320         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
321         (TEST):
322         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
323         (TestWebKitAPI::TEST):
324         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
325         (TEST):
326         (readRequest): Deleted.
327         (writeResponse): Deleted.
328         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
329         (TestWebKitAPI::TEST):
330         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
331
332 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
333
334         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
335
336         System headers are being included without SYSTEM again here.
337
338         * TestWebKitAPI/PlatformGTK.cmake:
339
340 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
341
342         [JSC] JSLock should be WebThread aware
343         https://bugs.webkit.org/show_bug.cgi?id=198911
344
345         Reviewed by Geoffrey Garen.
346
347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
348         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
349         (TestWebKitAPI::TEST):
350
351 2019-06-18  Keith Miller  <keith_miller@apple.com>
352
353         webkit-patch should allow for a bugzilla url not just bugzilla id
354         https://bugs.webkit.org/show_bug.cgi?id=198972
355
356         Reviewed by Dewei Zhu.
357
358         When prompting for a bugzilla id or a new title we should also
359         allow for a bugzilla url.
360
361         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
362         (PromptForBugOrTitle.run):
363
364 2019-06-18  David Quesada  <david_quesada@apple.com>
365
366         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
367         https://bugs.webkit.org/show_bug.cgi?id=198954
368         rdar://problem/51711556
369
370         Reviewed by Alex Christensen.
371
372         For these tests, kill the web process after the download starts. This makes the deallocation
373         of the download-originating web views, which these tests depend on, more reliable.
374
375         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
376         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
377         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
378
379 2019-06-18  Dan Bernstein  <mitz@apple.com>
380
381         Revert workaround for bug 198904 from run-webkit-archive
382         https://bugs.webkit.org/show_bug.cgi?id=198931
383
384         Reviewed by Alexey Proskuryakov.
385
386         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
387         pick up the built frameworks.
388
389         * WebKitArchiveSupport/run-webkit-archive:
390         (set_dyld_framework_path):
391
392 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
393
394         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
395         https://bugs.webkit.org/show_bug.cgi?id=198854
396         <rdar://problem/51386058>
397
398         Reviewed by Geoffrey Garen.
399
400         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
401         (TestWebKitAPI::TEST):
402
403 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
404
405         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
406         https://bugs.webkit.org/show_bug.cgi?id=198831
407
408         Reviewed by Žan Doberšek.
409
410         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
411         * wpe/jhbuild.modules: Ditto.
412         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
413         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
414
415 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
416
417         Move SOAuthorization from WebKitAdditions to WebKit
418         https://bugs.webkit.org/show_bug.cgi?id=198874
419         <rdar://problem/47573431>
420
421         Reviewed by Brent Fulgham.
422
423         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
424
425         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
427         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
428         (-[TestSOAuthorizationNavigationDelegate init]):
429         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
430         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
431         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
432         (-[TestSOAuthorizationViewController viewDidAppear]):
433         (-[TestSOAuthorizationViewController viewDidDisappear]):
434         (overrideCanPerformAuthorizationWithURL):
435         (overrideSetDelegate):
436         (overrideBeginAuthorizationWithURL):
437         (overrideCancelAuthorization):
438         (overrideAddObserverForName):
439         (overrideIsURLFromAppleOwnedDomain):
440         (resetState):
441         (configureSOAuthorizationWebView):
442         (generateHtml):
443         (checkAuthorizationOptions):
444         (TestWebKitAPI::TEST):
445
446 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
447
448         Ensure ITP state is relayed to Network Process on restart
449         https://bugs.webkit.org/show_bug.cgi?id=198797
450         <rdar://problem/51646944>
451
452         Reviewed by Youenn Fablet.
453
454         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
455         (cleanupITPDatabase): Added.
456         (TEST:EnableDisableITP): Update to use cleanup method.
457         (TEST:NetworkProcessRestart): Added.
458
459 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
460
461         New EWS can't process patches larger than 640kb
462         https://bugs.webkit.org/show_bug.cgi?id=198851
463
464         Reviewed by Jonathan Bedard.
465
466         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
467
468 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
469
470         webkitpy: Add macOS Catalina, iOS 13
471         https://bugs.webkit.org/show_bug.cgi?id=198492
472
473         Reviewed by Alexey Proskuryakov.
474
475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
483         * BuildSlaveSupport/ews-build/steps.py:
484         * Scripts/webkitpy/common/version_name_map.py:
485         * Scripts/webkitpy/common/version_name_map_unittest.py:
486         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
487         * TestResultServer/static-dashboards/flakiness_dashboard.js:
488
489 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
490
491         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
492
493         * gtk/jhbuild.modules:
494         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
495         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
496
497 2019-06-16  Zalan Bujtas  <zalan@apple.com>
498
499         [LFC] Expand tests coverage (325 new tests -> 1198).
500
501         * LayoutReloaded/misc/LFC-passing-tests.txt:
502
503 2019-06-16  Darin Adler  <darin@apple.com>
504
505         Rename AtomicString to AtomString
506         https://bugs.webkit.org/show_bug.cgi?id=195276
507
508         Reviewed by Michael Catanzaro.
509
510         * many files: Let do-webcore-rename do the renaming.
511
512         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
513         that mention "atomic string" and changed them to instead say "atom string".
514
515 2019-06-16  Zalan Bujtas  <zalan@apple.com>
516
517         [LFC] Unreviewed test gardening.
518
519         Unsupported alignments.
520
521         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
522         fast/borders/empty-outline-border-assert.html -vertical-align: super
523         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
524
525         * LayoutReloaded/misc/LFC-passing-tests.txt:
526
527 2019-06-15  Youenn Fablet  <youenn@apple.com>
528
529         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
530         https://bugs.webkit.org/show_bug.cgi?id=198780
531
532         Reviewed by Jonathan Bedard.
533
534         * Scripts/webkitpy/w3c/test_importer.py:
535         (TestImporter._webkit_test_runner_options):
536         In case the test file cannot be read as text, consider that there is no WTR option.
537
538 2019-06-14  Youenn Fablet  <youenn@apple.com>
539
540         WebResourceLoadStatisticsStore should not use its network session if invalidated
541         https://bugs.webkit.org/show_bug.cgi?id=198814
542
543         Reviewed by Geoffrey Garen.
544
545         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
546         (TEST):
547
548 2019-06-14  Youenn Fablet  <youenn@apple.com>
549
550         import-w3c-tests should respect WEBKIT_OUTPUTDIR
551         https://bugs.webkit.org/show_bug.cgi?id=198682
552         <rdar://problem/51536931>
553
554         Reviewed by Jonathan Bedard.
555
556         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
557         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
558
559         * Scripts/webkitpy/common/webkit_finder.py:
560         (WebKitFinder.path_from_webkit_outputdir):
561         * Scripts/webkitpy/w3c/common.py:
562         (WPTPaths):
563         (WPTPaths.checkout_directory):
564         (WPTPaths.wpt_checkout_path):
565         * Scripts/webkitpy/w3c/test_importer.py:
566         (TestImporter.__init__):
567         * Scripts/webkitpy/w3c/test_importer_unittest.py:
568         (test_checkout_directory):
569
570 2019-06-13  Antoine Quint  <graouts@apple.com>
571
572         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
573         https://bugs.webkit.org/show_bug.cgi?id=198800
574         <rdar://problem/51679634>
575
576         Reviewed by Tim Horton.
577
578         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
579         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
580
581         * DumpRenderTree/mac/EventSendingController.mm:
582         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
583         (-[EventSendingController mouseDown:withModifiers:]):
584         (-[EventSendingController mouseUp:withModifiers:]):
585         (-[EventSendingController mouseMoveToX:Y:]):
586
587 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
588
589         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
590         https://bugs.webkit.org/show_bug.cgi?id=198820
591
592         Reviewed by Ross Kirsling.
593
594         WebView window paints nothing because it is moved out of the
595         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
596         as DumpRenderTree does.
597
598         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
599         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
600
601 2019-06-13  Tim Horton  <timothy_horton@apple.com>
602
603         Make it possible for validate-committer-lists to dump a mailmap file
604         https://bugs.webkit.org/show_bug.cgi?id=198517
605
606         Reviewed by Simon Fraser.
607
608         Mailmaps wildly improve the output of various Git tools, including
609         `git shortlog -sne`, mapping committers to our canonical name/email pair.
610
611         * Scripts/validate-committer-lists:
612         (CommitterListFromGit):
613         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
614         Add some missing legacy username mappings.
615
616         (dump_mailmap):
617         (dump_mailmap.format_email):
618         (dump_mailmap.format_email_with_gitsvn_uuid):
619         (dump_mailmap.map_emails_to_legacy_username):
620         (main):
621         Add `validate-committer-lists --dump-mailmap`, which generates
622         one given committers.json and the existing mapping of legacy username
623         to email addresses that exists in validate-committer-lists.
624
625 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
626
627         Replace double-quotes with single quotes in loadConfig.py
628         https://bugs.webkit.org/show_bug.cgi?id=198792
629
630         Reviewed by Jonathan Bedard.
631
632         * BuildSlaveSupport/ews-build/loadConfig.py:
633         * BuildSlaveSupport/ews-build/steps_unittest.py:
634
635 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
636
637         Add mechanism and test case to check if ITP is active
638         https://bugs.webkit.org/show_bug.cgi?id=198694
639         <rdar://problem/51557704>
640
641         Reviewed by Youenn Fablet.
642
643         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
644         (TEST):
645
646 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
647
648         [WPE][GTK] Deprecate WebSQL APIs
649         https://bugs.webkit.org/show_bug.cgi?id=195011
650
651         Reviewed by Carlos Garcia Campos.
652
653         * MiniBrowser/gtk/main.c:
654         (gotWebsiteDataCallback):
655         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
656         (testWebsiteDataConfiguration):
657         (testWebsiteDataEphemeral):
658         (testWebsiteDataDatabases):
659
660 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
661
662         [WPE][GTK] Enable hyperlink auditing
663         https://bugs.webkit.org/show_bug.cgi?id=197845
664
665         Reviewed by Carlos Garcia Campos.
666
667         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
668         (testWebKitSettings):
669
670 2019-06-11  Keith Rollin  <krollin@apple.com>
671
672         Open up xcfilelist processing to more platforms
673         https://bugs.webkit.org/show_bug.cgi?id=198675
674         <rdar://problem/51533238>
675
676         Reviewed by Jonathan Bedard.
677
678         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
679         platforms on which to perform xcfilelist generation/updating.
680
681         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
682         (JavaScriptCoreGenerator):
683         (WebCoreGenerator):
684         (WebKitGenerator):
685
686 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
687
688         webkitpy: Fix device ASan reporting, add testing for report configurations
689         https://bugs.webkit.org/show_bug.cgi?id=198756
690
691         Reviewed by Aakash Jain.
692
693         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
694         configuration thoroughly in webkitpy.
695
696         * Scripts/webkitpy/port/config.py:
697         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
698         * Scripts/webkitpy/port/device_port.py:
699         (DevicePort.configuration_for_upload): Add ASan as style.
700         * Scripts/webkitpy/port/ios_device_unittest.py:
701         (IOSDeviceTest):
702         (IOSDeviceTest.test_default_upload_configuration):
703         * Scripts/webkitpy/port/ios_simulator_unittest.py:
704         (IOSSimulatorTest.test_default_upload_configuration):
705         * Scripts/webkitpy/port/mock_drt_unittest.py:
706         (MockDRTPortTest.test_asan_upload_configuration):
707         * Scripts/webkitpy/port/port_testcase.py:
708         (test_default_upload_configuration):
709         (test_debug_upload_configuration):
710         (test_asan_upload_configuration):
711         (test_guard_malloc_configuration):
712         * Scripts/webkitpy/port/watch_simulator_unittest.py:
713         (WatchSimulatorTest):
714         (WatchSimulatorTest.test_default_upload_configuration):
715
716 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
717
718         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
719         https://bugs.webkit.org/show_bug.cgi?id=198749
720
721         Reviewed by Carlos Garcia Campos.
722
723         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
724         (TestWebKitAPI::TEST):
725
726 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
727
728         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
729         https://bugs.webkit.org/show_bug.cgi?id=198735
730         <rdar://problem/51557159>
731
732         Reviewed by Megan Gardner.
733
734         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
735         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
736
737         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
738         (TestWebKitAPI::TEST):
739
740 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
741
742         Unreviewed, add myself to the JavaScriptCore watchlist.
743
744         * Scripts/webkitpy/common/config/watchlist:
745
746 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
747
748         Unreviewed, change my status to be a WebKit reviewer
749
750         * Scripts/webkitpy/common/config/contributors.json:
751
752 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
753
754         [WPE] Use new exported image API from fdo backend
755         https://bugs.webkit.org/show_bug.cgi?id=198558
756
757         Reviewed by Philippe Normand.
758
759         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
760         WPEToolingBackends that already depends on fdo backend and libxkb
761         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
762         * wpe/backends/HeadlessViewBackend.cpp:
763         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
764         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
765         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
766         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
767         * wpe/backends/HeadlessViewBackend.h:
768         * wpe/backends/ViewBackend.cpp:
769         (WPEToolingBackends::ViewBackend::initialize):
770         * wpe/backends/ViewBackend.h:
771         * wpe/backends/WindowViewBackend.cpp:
772         (WPEToolingBackends::WindowViewBackend::displayBuffer):
773         * wpe/backends/WindowViewBackend.h:
774
775 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
776
777         Extend run-benchmark to allow diagnosing before closing browser on test failure.
778         https://bugs.webkit.org/show_bug.cgi?id=198729
779
780         Reviewed by Ryosuke Niwa.
781
782         Add '--diagnose-directory' option to store diagnose information when test failed.
783
784         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
785         (BenchmarkRunner.__init__):
786         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
787         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
788         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
789         (parse_args):
790         (run_benchmark_plan):
791         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
792         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
793         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
794         (WebServerBenchmarkRunner.__init__):
795         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
796
797 2019-06-10  Sam Weinig  <weinig@apple.com>
798
799         Remove Dashboard support
800         https://bugs.webkit.org/show_bug.cgi?id=198615
801
802         Reviewed by Ryosuke Niwa.
803
804         * DumpRenderTree/TestRunner.cpp:
805         (TestRunner::staticFunctions):
806         (setUseDashboardCompatibilityModeCallback): Deleted.
807         * DumpRenderTree/TestRunner.h:
808         * DumpRenderTree/mac/Configurations/Base.xcconfig:
809         * DumpRenderTree/mac/DumpRenderTree.mm:
810         (resetWebViewToConsistentStateBeforeTesting):
811         * DumpRenderTree/mac/TestRunnerMac.mm:
812         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
813         * ImageDiff/cg/Configurations/Base.xcconfig:
814         * Scripts/webkitperl/FeatureList.pm:
815         * TestWebKitAPI/Configurations/Base.xcconfig:
816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
818         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
819         * WebKitTestRunner/Configurations/Base.xcconfig:
820         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
821         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
822         (WTR::InjectedBundle::beginTesting):
823         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
824         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
825         * WebKitTestRunner/InjectedBundle/TestRunner.h:
826
827 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
828
829         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
830         https://bugs.webkit.org/show_bug.cgi?id=198616
831         rdar://problem/36386573
832
833         Reviewed by David Kilzer.
834
835         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
836
837         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
838         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
839         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
840         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
841         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
842         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
843         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
844         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
845         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
846         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
847
848 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
849
850         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
851         https://bugs.webkit.org/show_bug.cgi?id=198699
852         <rdar://problem/50501718>
853
854         Reviewed by Simon Fraser.
855
856         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
857         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
858         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
859         viewport parameters are used.
860
861         * WebKitTestRunner/ios/TestControllerIOS.mm:
862         (WTR::TestController::platformResetPreferencesToConsistentValues):
863         (WTR::TestController::platformConfigureViewForTest):
864
865 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
866
867         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
868         https://bugs.webkit.org/show_bug.cgi?id=198023
869
870         Reviewed by Saam Barati.
871
872         * Scripts/run-jsc-stress-tests:
873
874 2019-06-10  Timothy Hatcher  <timothy@apple.com>
875
876         Integrate dark mode support for iOS.
877         https://bugs.webkit.org/show_bug.cgi?id=198687
878         rdar://problem/51545643
879
880         Reviewed by Tim Horton.
881
882         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
883
884 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
885
886         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
887         https://bugs.webkit.org/show_bug.cgi?id=198723
888
889         Reviewed by Aakash Jain.
890
891         * Scripts/webkitpy/xcode/simulated_device.py:
892         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
893
894 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
895
896         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
897         https://bugs.webkit.org/show_bug.cgi?id=198635
898         <rdar://problem/46010232>
899
900         Reviewed by Ryosuke Niwa.
901
902         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
903         (areCookiesEqual):
904         (TEST):
905
906 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
907
908         [JHBuild] Bump shared-mime-info to version ≥ 1.6
909         https://bugs.webkit.org/show_bug.cgi?id=198714
910
911         Reviewed by Carlos Garcia Campos.
912
913         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
914         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
915         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
916
917 2019-06-10  Philippe Normand  <pnormand@igalia.com>
918
919         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
920         https://bugs.webkit.org/show_bug.cgi?id=198713
921
922         Reviewed by Carlos Garcia Campos.
923
924         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
925         patches currently used in JHBuild.
926
927 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
928
929         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
930         https://bugs.webkit.org/show_bug.cgi?id=198711
931
932         Reviewed by Philippe Normand.
933
934         * flatpak/org.webkit.GTK.yaml: Also include modules from
935         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
936
937 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
938
939         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
940         avoids double-free condition that's causing bots to exit early.
941
942         * gtk/jhbuild.modules:
943         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
944         * wpe/jhbuild.modules:
945         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
946
947 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
948
949         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
950         https://bugs.webkit.org/show_bug.cgi?id=198655
951
952         Reviewed by Ross Kirsling.
953
954         MediaCapabilities is enabled by default for WK2, but WinCairo
955         doesn't implemented yet. Disable it in MiniBrowser.
956
957         * MiniBrowser/win/WebKitBrowserWindow.cpp:
958         (WebKitBrowserWindow::create):
959
960 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
961
962         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
963         https://bugs.webkit.org/show_bug.cgi?id=198693
964         <rdar://problem/51555371>
965
966         Reviewed by Tim Horton.
967
968         Augment an existing API test to exercise three additional scenarios:
969             -   The web view configuration's application name is never set; the default should not include
970                 "Mobile/15E148" in desktop mode.
971             -   The application name is explicitly set to nil; the default application name should still not include
972                 "Mobile/15E148".
973             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
974                 this when generating the user agent, even in desktop mode.
975
976         * TestWebKitAPI/ios/PreferredContentMode.mm:
977         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
978         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
979         (TestWebKitAPI::TEST):
980
981 2019-06-08  Zalan Bujtas  <zalan@apple.com>
982
983         [LFC] Unreviewed test gardening.
984
985         Remove rtl tests. They were mistakenly marked as pass.
986
987         * LayoutReloaded/misc/LFC-passing-tests.txt:
988
989 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
990
991         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
992         https://bugs.webkit.org/show_bug.cgi?id=198664
993
994         Reviewed by Simon Fraser.
995
996         Delete repeated entries which were submitted by mistake.
997
998         * Tracing/SystemTracePoints.plist:
999
1000 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1001
1002         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
1003         https://bugs.webkit.org/show_bug.cgi?id=198631
1004         <rdar://problem/51505431>
1005
1006         Reviewed by Tim Horton.
1007
1008         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
1009
1010         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1011         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
1012         (-[CustomInputWebView inputView]):
1013         (-[CustomInputWebView inputAccessoryView]):
1014         (TestWebKitAPI::TEST):
1015
1016 2019-06-07  Daniel Bates  <dabates@apple.com>
1017
1018         [lldb-webkit] Pretty-print all kinds of Documents
1019         https://bugs.webkit.org/show_bug.cgi?id=198620
1020
1021         Reviewed by Simon Fraser.
1022
1023         Register formatters for all classes derived from WebCore::Document so we get nice summaries
1024         without having to drill down in Xcode- or casting- to the base class, Document.
1025
1026         Older LLDB versions use to do this automatically, but this functionality was removed in newer
1027         versions:
1028             [[
1029                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
1030                 chains, but also through inheritance chains. This feature has been removed since it
1031                 significantly degrades performance. You need to set up your formatters for every type in
1032                 inheritance chains to which you want the formatter to apply.
1033             ]]
1034             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
1035
1036         * lldb/lldb_webkit.py:
1037         (__lldb_init_module):
1038
1039 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
1040
1041         webkitpy: Support reporting results for uncommon test configurations
1042         https://bugs.webkit.org/show_bug.cgi?id=198662
1043         <rdar://problem/51524128>
1044
1045         Reviewed by Aakash Jain.
1046
1047         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1048         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
1049         * Scripts/webkitpy/port/base.py:
1050         (Port.configuration_for_upload): Set flavor based on options.
1051         * Scripts/webkitpy/results/options.py:
1052         (upload_options): Add result-report-flavor option.
1053         * Scripts/webkitpy/test/main.py:
1054         (Tester._run_tests): Set flavor based on options.
1055
1056 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1057
1058         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
1059         https://bugs.webkit.org/show_bug.cgi?id=198641
1060         <rdar://problem/51266310>
1061
1062         Reviewed by Tim Horton.
1063
1064         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
1065         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
1066         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
1067         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
1068         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
1069         reproduces on iOS simulator.
1070
1071         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
1072         representation is actually ignored by most clients anyways (including WebKit), in favor of using
1073         "com.apple.flat-rtfd".
1074
1075         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1076         (TestWebKitAPI::TEST):
1077         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1078         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1079         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1080
1081 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1082
1083         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
1084         https://bugs.webkit.org/show_bug.cgi?id=198607
1085
1086         Reviewed by Michael Catanzaro.
1087
1088         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
1089         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
1090         determine the type of the tests.
1091
1092         * Scripts/run-gtk-tests:
1093         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1094         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
1095         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1096         (GtkTestRunner.is_google_test): Ditto.
1097         * Scripts/run-wpe-tests:
1098         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1099         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1100         (WPETestRunner.is_google_test): Ditto.
1101         * glib/api_test_runner.py:
1102         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
1103         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
1104
1105 2019-06-06  Keith Rollin  <krollin@apple.com>
1106
1107         Remove SSL-based tests from TestWebKitAPI on some configurations
1108         https://bugs.webkit.org/show_bug.cgi?id=198551
1109         <rdar://problem/51424996>
1110
1111         Reviewed by Jonathan Bedard.
1112
1113         Not all platforms have SSL handy, so don't include SSL-based tests on
1114         those platforms.
1115
1116         * TestWebKitAPI/TCPServer.cpp:
1117         * TestWebKitAPI/TCPServer.h:
1118         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1119         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1120         * TestWebKitAPI/config.h:
1121
1122 2019-06-06  Daniel Bates  <dabates@apple.com>
1123
1124         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
1125         non-default port number
1126         https://bugs.webkit.org/show_bug.cgi?id=198618
1127
1128         Reviewed by Brent Fulgham.
1129
1130         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
1131         a string before we concatenate it with another string when building the string representation
1132         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
1133         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
1134
1135         * lldb/lldb_webkit.py:
1136         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
1137
1138 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1139
1140         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
1141         https://bugs.webkit.org/show_bug.cgi?id=198613
1142
1143         Reviewed by Alexey Proskuryakov.
1144
1145         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
1146
1147 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1148
1149         webkitpluginhost: Support ASan as a style
1150         https://bugs.webkit.org/show_bug.cgi?id=198586
1151         <rdar://problem/51459088>
1152
1153         Reviewed by Alexey Proskuryakov.
1154
1155         * Scripts/webkitpy/port/base.py:
1156         (Port.configuration_for_upload): Add ASan as a style.
1157         * Scripts/webkitpy/port/config.py:
1158         (Config._read_configuration):
1159         (Config):
1160         (Config.asan): Add property to check if the ASan configuration is active.
1161         * Scripts/webkitpy/port/config_unittest.py:
1162         (ConfigTest.test_default_configuration__scripterror):
1163         (ConfigTest):
1164         (ConfigTest.test_asan):
1165         * Scripts/webkitpy/test/main.py:
1166         (Tester._run_tests): Add Asan as a style.
1167
1168 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
1169
1170         block-spammers tool doesn't block e-mail
1171         https://bugs.webkit.org/show_bug.cgi?id=198570
1172
1173         Reviewed by Jonathan Bedard.
1174
1175         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
1176         recognize "false" here. Also, request body is unnecessary.
1177
1178 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1179
1180         [GTK][WPE] Enable PSON
1181         https://bugs.webkit.org/show_bug.cgi?id=194979
1182
1183         Reviewed by Žan Doberšek.
1184
1185         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
1186
1187         * gtk/jhbuild.modules:
1188         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1189         * wpe/jhbuild.modules:
1190         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1191
1192 2019-06-05  Andy Estes  <aestes@apple.com>
1193
1194         [macOS] Stop calling -[NSDraggingItem setItem:]
1195         https://bugs.webkit.org/show_bug.cgi?id=198588
1196         <rdar://problem/48297453>
1197
1198         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
1199
1200         Reviewed by Wenson Hsieh.
1201
1202         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
1203         TestRunnerShared group.
1204
1205         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1206         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1207         Changed to call -[NSDraggingItem _initWithItem:] when available.
1208
1209         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
1210         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
1211         declarations here from DumpRenderTree.
1212
1213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1214         Added TestRunnerShared/spi/AppKitTestSPI.h.
1215
1216         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1217         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1218         Changed to call -[NSDraggingItem _initWithItem:] when available.
1219
1220 2019-06-05  Jer Noble  <jer.noble@apple.com>
1221
1222         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
1223         https://bugs.webkit.org/show_bug.cgi?id=198585
1224
1225         Reviewed by Chris Dumez.
1226
1227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1228         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1229         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
1230         (TEST):
1231         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
1232
1233 2019-06-05  Alex Christensen  <achristensen@webkit.org>
1234
1235         Re-enable safe browsing in WKWebView
1236         https://bugs.webkit.org/show_bug.cgi?id=196161
1237         <rdar://problem/49171413>
1238
1239         Reviewed by Ryosuke Niwa.
1240
1241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1242         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1243         (TEST):
1244         (safeBrowsingView):
1245
1246 == Rolled over to ChangeLog-2019-06-05 ==