8332c09660d5ac4bde099ea093bb984e0657aceb
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [Cocoa] [WebKit2] Add support for replacing find-in-page text matches
4         https://bugs.webkit.org/show_bug.cgi?id=191786
5         <rdar://problem/45813871>
6
7         Reviewed by Ryosuke Niwa.
8
9         * MiniBrowser/mac/WK2BrowserWindowController.m:
10         (-[WK2BrowserWindowController setFindBarView:]):
11
12         Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
13         the "Replace" option.
14
15         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
16
17         Add an API test to exercise find-and-replace API using WKWebView.
18
19         (replaceMatches):
20         (TEST):
21         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
22         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
23         (WTR::findOptionsFromArray):
24         (WTR::TestRunner::findString):
25         (WTR::TestRunner::findStringMatchesInPage):
26         (WTR::TestRunner::replaceFindMatchesAtIndices):
27
28         Add TestRunner hooks to simulate find-in-page and replace.
29
30         * WebKitTestRunner/InjectedBundle/TestRunner.h:
31
32 2018-11-21  Zalan Bujtas  <zalan@apple.com>
33
34         [LFC][IFC] Horizontal margins should be considered as non-breakable space
35         https://bugs.webkit.org/show_bug.cgi?id=191894
36
37         Reviewed by Antti Koivisto.
38
39         * LayoutReloaded/misc/LFC-passing-tests.txt:
40
41 2018-11-21  Zalan Bujtas  <zalan@apple.com>
42
43         [LFC][IFC] Border should be considered as non-breakable space
44         https://bugs.webkit.org/show_bug.cgi?id=191891
45
46         Reviewed by Antti Koivisto.
47
48         * LayoutReloaded/misc/LFC-passing-tests.txt:
49
50 2018-11-21  Zalan Bujtas  <zalan@apple.com>
51
52         [LFC][IFC] Take nonBreakableStart/End into use.
53         https://bugs.webkit.org/show_bug.cgi?id=191873
54
55         Reviewed by Antti Koivisto.
56
57         * LayoutReloaded/misc/LFC-passing-tests.txt:
58
59 2018-11-20  Jeff Miller  <jeffm@apple.com>
60
61         Return nullptr immediately if the key doesn't exist in the HashMap.
62         https://bugs.webkit.org/show_bug.cgi?id=191841
63
64         Reviewed by Chris Dumez.
65         
66         Add a test that would crash prior to the fix for this bug.
67
68         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69         * TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.
70         (TestWebKitAPI::TEST):
71
72 2018-11-19  Alex Christensen  <achristensen@webkit.org>
73
74         Add SPI to disable JIT in a WKWebView
75         https://bugs.webkit.org/show_bug.cgi?id=191822
76         <rdar://problem/28119360>
77
78         Reviewed by Geoffrey Garen.
79
80         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
81         * TestWebKitAPI/Tests/WebKitCocoa/DisableJIT.mm: Added.
82         (TEST):
83
84 2018-11-19  Basuke Suzuki  <basuke.suzuki@sony.com>
85
86         [Curl] Add API for CertificateInfo.
87         https://bugs.webkit.org/show_bug.cgi?id=191647
88
89         Reviewed by Alex Christensen.
90
91         Added test for new WKCertificateInfo API.
92
93         * TestWebKitAPI/PlatformWin.cmake:
94         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Added.
95         (TestWebKitAPI::Curl::makeCertificateInfo):
96         (TestWebKitAPI::Curl::isSamePEM):
97         (TestWebKitAPI::Curl::TEST):
98
99 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
100
101         Unreviewed, fix the internal iOS debug build after r238380
102
103         UICalloutBar should only be declared when the public (non-internal) SDK is used to build WebKit; otherwise, we
104         end up with duplicate declarations of UICalloutBar.
105
106         * TestWebKitAPI/ios/UIKitSPI.h:
107
108 2018-11-19  David Quesada  <david_quesada@apple.com>
109
110         EXC_BAD_ACCESS when invoking a DownloadProxy's destination decision handler after the download has been canceled
111         https://bugs.webkit.org/show_bug.cgi?id=191762
112         rdar://problem/46151509
113
114         Reviewed by Dean Jackson.
115
116         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
117             Enable the Download API test on iOS, since the platform supports downloads. All the
118             tests pass already, except for one which was written using AppKit-specific code:
119         TEST(_WKDownload, RedirectedDownload):
120             Use a more platform-agnostic approach to starting the download in this API test.
121             Instead of manually triggering an NSMenu item to download a file from a link, the
122             test will simulate a user-initiated click on the link, and the navigation delegate
123             will direct the web view to start a download based on the link's navigation action.
124             Additionally, remove the manual creation of a new NSWindow. TestWKWebView makes its
125             own UI/NSWindow.
126         TEST(_WKDownload, DownloadCanceledWhileDecidingDestination):
127             Add an API test _WKDownload.DownloadCanceledWhileDecidingDestination to simulate the
128             conditions that would trigger this crash - handling a download's -decideDestination…
129             delegate call by canceling the download, waiting for the UI process to be notified
130             that the download has been canceled, and calling the decision handler. This should
131             not crash.
132         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidFinish:]):
133         (-[CancelDownloadWhileDecidingDestinationDelegate _download:didFailWithError:]):
134         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidCancel:]):
135         (-[CancelDownloadWhileDecidingDestinationDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
136         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]): Deleted.
137         * TestWebKitAPI/cocoa/TestWKWebView.h:
138         * TestWebKitAPI/cocoa/TestWKWebView.mm:
139         (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
140             Add a user-initated version of -objectByEvaluatingJavaScript:. This is needed in
141             order to maintain the behavior of the RedirectedDownload test, which verifies the
142             state of the _WKDownload.wasUserInitiated property.
143
144 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
145
146         [iOS Debug] Assertion failure in NSComparisonResult UIContentSizeCategoryCompareToCategory()
147         https://bugs.webkit.org/show_bug.cgi?id=190401
148         <rdar://problem/45195285>
149
150         Reviewed by Dean Jackson.
151
152         Work around sporadic UIKit assertions when running API tests that may present a UICalloutBar. Currently, UIKit
153         asks for the `UIApp`’s `-preferredContentSizeCategory` when showing or laying out the callout bar. However,
154         TestWebKitAPI lacks a UIApp altogether, and forcing one to be initialized via `UIApplicationInstantiateSingleton`
155         causes numerous other UIKit and WebKit assertions to be hit.
156
157         In lieu of TestWebKitAPI becoming a real UI application (see https://webkit.org/b/175204), simply don't allow
158         the callout bar to be initialized in TestWKWebView-based API tests. This encompasses all API tests which
159         have some chance of causing the callout bar to be shown by making a ranged text selections during the test.
160
161         * TestWebKitAPI/cocoa/TestWKWebView.mm:
162         (suppressUICalloutBar):
163         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
164         * TestWebKitAPI/ios/UIKitSPI.h:
165
166 2018-11-19  Fujii Hironori  <Hironori.Fujii@sony.com>
167
168         REGRESSION(r238016)[GTK][TestWebKitAPI][Ninja] TestJSC can't compile "Bytecodes.h: No such file or directory"
169         https://bugs.webkit.org/show_bug.cgi?id=191692
170
171         Reviewed by Michael Catanzaro.
172
173         r238016 added a new #include, and requires JSC's derived headers
174         to be copied into the forwarding header directory.
175
176         WEBKIT_MAKE_FORWARDING_HEADERS is using POST_BUILD event to copy
177         derived headers to the forwarding header directory. This is done
178         after linking JSC library.
179
180         GTK port has TestJSC which has a dependency to JSC static library.
181         And, this dependency is a link time dependency which means
182         compiling source files of TestJSC starts before the POST_BUILD
183         event of JSC. Thus, required header can't be found.
184
185         Add an intermediate target between TestJSC and JavaScriptCore to
186         ensure derived headers are copied into the forwarding header
187         directory.
188
189         * TestWebKitAPI/PlatformGTK.cmake: Added a new custom target pre-TestJSC.
190         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
191
192 2018-11-19  Alejandro G. Castro  <alex@igalia.com>
193
194         [GTK][WPE] Solve some issues in the enumerateDevices code
195         https://bugs.webkit.org/show_bug.cgi?id=191832
196
197         Reviewed by Carlos Garcia Campos.
198
199         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
200         (serverCallback): Make all the Strings with HTML code static.
201         (testWebsiteDataDeviceIdHashSalt): Change the webView settings in
202         the test.
203         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
204         (WebViewTest::initializeWebView): Remove the initialization of the
205         webView settings, we now do it in the specific test.
206
207 2018-11-18  Chris Dumez  <cdumez@apple.com>
208
209         [PSON] Received an invalid message "WebPageProxy.DidPerformClientRedirect" from the web process
210         https://bugs.webkit.org/show_bug.cgi?id=191828
211
212         Reviewed by Antti Koivisto.
213
214         Add API test coverage.
215
216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
218         * TestWebKitAPI/Tests/WebKitCocoa/client-side-redirect.html: Added.
219
220 2018-11-17  Wenson Hsieh  <wenson_hsieh@apple.com>
221
222         [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
223         https://bugs.webkit.org/show_bug.cgi?id=191819
224
225         Reviewed by Dan Bernstein.
226
227         Replace UIItemProvider (and related classes) with NSItemProvider.
228
229         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
230         (platformCopyPNG):
231         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
232         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
233
234         Replace usages of this deprecated method with `-registerDataRepresentationForTypeIdentifier:visibility:loadHandler:`.
235
236         (checkEstimatedSize):
237         (checkSuggestedNameAndEstimatedSize):
238         (TestWebKitAPI::TEST):
239         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
240         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
241         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
242         (-[MockDragDropSession canLoadObjectsOfClass:]):
243         (-[MockDragDropSession canLoadObjectsOfClasses:]):
244         (-[MockDropSession initWithProviders:location:window:allowMove:]):
245         (-[MockDropSession canCreateItemsOfClass:]):
246         (-[DragAndDropSimulator _advanceProgress]):
247         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
248         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
249         * TestWebKitAPI/ios/UIKitSPI.h:
250
251 2018-11-17  Chris Dumez  <cdumez@apple.com>
252
253         ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver
254         https://bugs.webkit.org/show_bug.cgi?id=191734
255         <rdar://problem/46151497>
256
257         Reviewed by Ryosuke Niwa.
258
259         Add API test coverage.
260
261         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
262
263 2018-11-17  Zalan Bujtas  <zalan@apple.com>
264
265         [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
266         https://bugs.webkit.org/show_bug.cgi?id=191801
267
268         Reviewed by Antti Koivisto.
269
270         * LayoutReloaded/misc/LFC-passing-tests.txt:
271
272 2018-11-17  Jer Noble  <jer.noble@apple.com>
273
274         Regression(r233865): Causes synchronous IPC in the middle of layout
275         https://bugs.webkit.org/show_bug.cgi?id=188307
276         <rdar://problem/42807306>
277
278         Reviewed by Eric Carlson.
279
280         Follow-up test fix for r238322:
281
282         In ExitFullscreenOnEnterPiP.ElementFullScreen, explicitly make the video
283         element in element fullscreen the "main content" by playing the video during
284         a user gesture; only "main content" videos will cause fullscreen mode to exit
285         when that element is taken into PiP.
286
287         In FullscreenZoomInitialFrame.WebKit, the WebView is not visible, so the Page
288         is considered hidden, and fullscreen is not allowed when the WebView is hidden.
289         Make the WebView visible by ordering the test window on-screen.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html:
292         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
293         (TestWebKitAPI::TEST):
294         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
295         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
296
297 2018-11-16  Alex Christensen  <achristensen@webkit.org>
298
299         Tweak _showSafeBrowsingWarningWithTitle SPI
300         https://bugs.webkit.org/show_bug.cgi?id=191799
301
302         Reviewed by Wenson Hsieh.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
305         (TEST):
306
307 2018-11-16  Ryosuke Niwa  <rniwa@webkit.org>
308
309         REGRESSION (r238294): TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback failing on iOS
310         https://bugs.webkit.org/show_bug.cgi?id=191783
311
312         Reviewed by Chris Dumez.
313
314         Allow either WKErrorWebContentProcessTerminated or WKErrorWebViewInvalidated since the test
315         is closing WebView, thereby invalidating the view, which is racing with the process termination.
316
317         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
318         (TEST):
319
320 2018-11-16  Chris Dumez  <cdumez@apple.com>
321
322         ProcessSwap.DisableForInspector API test is failing
323         https://bugs.webkit.org/show_bug.cgi?id=191798
324
325         Reviewed by Joseph Pecoraro.
326
327         We support process swapping when Web Inspector is shown now so update the
328         API test accordingly.
329
330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
331
332 2018-11-16  Ryan Haddad  <ryanhaddad@apple.com>
333
334         Update buildbot dashboard after Windows 7/10 updates
335         https://bugs.webkit.org/show_bug.cgi?id=191219
336
337         Reviewed by Alexey Proskuryakov.
338
339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
340         (BubbleQueueServer):
341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
343         (WebKitBuildbot):
344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
345         (table.queue-grid tr.platform td.logo::before):
346         (table.queue-grid tr.platform.windows-10 td.logo::before):
347         (table.queue-grid tr.platform.wincairo-windows-10 td.logo::before):
348         (table.queue-grid tr.platform.windows-7 td.logo::before):
349         (table.queue-grid tr.platform.wincairo-windows-10 img.logo):
350
351 2018-11-16  Chris Dumez  <cdumez@apple.com>
352
353         Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
354         https://bugs.webkit.org/show_bug.cgi?id=191789
355
356         Reviewed by Alex Christensen.
357
358         Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
359         SPI no longer works with PSON / Process prewarming.
360
361         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
362         (TestWebKitAPI::TEST):
363
364 2018-11-16  Jonathan Bedard  <jbedard@apple.com>
365
366         webkitpy: Retry app installation on watchOS simulators
367         https://bugs.webkit.org/show_bug.cgi?id=191769
368         <rdar://problem/46139850>
369
370         Reviewed by Aakash Jain.
371
372         * Scripts/webkitpy/xcode/simulated_device.py:
373         (SimulatedDevice.install_app): Retry app installations.
374
375 2018-11-16  Zalan Bujtas  <zalan@apple.com>
376
377         Add DidFirstMeaningfulPaint milestone.
378         https://bugs.webkit.org/show_bug.cgi?id=191754
379
380         Reviewed by Simon Fraser.
381
382         * TestWebKitAPI/CMakeLists.txt:
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp: Added.
385         (TestWebKitAPI::didReachMilestone):
386         (TestWebKitAPI::setPageLoaderClient):
387         (TestWebKitAPI::TEST):
388         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp: Copied from Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h.
389         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::FirstMeaningfulPaintMilestoneTest):
390         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::didCreatePage):
391
392 2018-11-16  Takashi Komori  <Takashi.Komori@sony.com>
393
394         [WinCairo][WebKitTestRunner] Test contents window is displayed while testing.
395         https://bugs.webkit.org/show_bug.cgi?id=191593
396
397         Reviewed by Alex Christensen.
398
399         Hide TestRunner window and taskbar button.
400
401         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
402         (WTR::PlatformWebView::PlatformWebView):
403         (WTR::PlatformWebView::windowSnapshotImage):
404
405 2018-11-16  Alex Christensen  <achristensen@webkit.org>
406
407         Add API to disable safe browsing checks
408         https://bugs.webkit.org/show_bug.cgi?id=191610
409
410         Reviewed by Dean Jackson.
411
412         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
413         (resourceURL):
414         (TEST):
415         (safeBrowsingView):
416         (simpleURL): Deleted.
417
418 2018-11-16  Zalan Bujtas  <zalan@apple.com>
419
420         [LFC][IFC] Add support for out-of-flow positioned boxes
421         https://bugs.webkit.org/show_bug.cgi?id=191726
422
423         Reviewed by Antti Koivisto.
424
425         * LayoutReloaded/misc/LFC-passing-tests.txt:
426
427 2018-11-15  Myles C. Maxfield  <mmaxfield@apple.com>
428
429         WKPreferencesSetFontSmoothingLevel doesn't actually do anything
430         https://bugs.webkit.org/show_bug.cgi?id=191708
431
432         Reviewed by Simon Fraser.
433
434         Delete the symbol because no one calls it and it doesn't do anything
435
436         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
437         (TestWebKitAPI::TEST):
438         * WebKitTestRunner/TestController.cpp:
439         (WTR::TestController::resetPreferencesToConsistentValues):
440
441 2018-11-15  Truitt Savell  <tsavell@apple.com>
442
443         Unreviewed, rolling out r238244.
444
445         Caused High Sierra test runs to fail early with 50 crashes and
446         casued 25 API failures.
447
448         Reverted changeset:
449
450         "[css-logical] Implement flow-relative margin, padding and
451         border shorthands"
452         https://bugs.webkit.org/show_bug.cgi?id=188697
453         https://trac.webkit.org/changeset/238244
454
455 2018-11-15  Aakash Jain  <aakash_jain@apple.com>
456
457         Increase EWS lock timeout to 3 hours
458         https://bugs.webkit.org/show_bug.cgi?id=191705
459
460         Reviewed by Alexey Proskuryakov.
461
462         * QueueStatusServer/config/queues.py: Increased EWS lock timeout to 3 hours.
463
464 2018-11-15  Chris Dumez  <cdumez@apple.com>
465
466         IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled
467         https://bugs.webkit.org/show_bug.cgi?id=191671
468         <rdar://problem/46086062>
469
470         Reviewed by Alex Christensen.
471
472         Add API test coverage.
473
474         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
475         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
476         (TEST):
477
478 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
479
480         [css-logical] Implement flow-relative margin, padding and border shorthands
481         https://bugs.webkit.org/show_bug.cgi?id=188697
482
483         Reviewed by Simon Fraser and Antti Koivisto.
484
485         * DumpRenderTree/TestOptions.cpp:
486         (TestOptions::TestOptions):
487         * DumpRenderTree/TestOptions.h:
488         * DumpRenderTree/mac/DumpRenderTree.mm:
489         (setWebPreferencesForTestOptions):
490         Allow tests to enable the CSSLogicalEnabled flag in WK1.
491
492         * Scripts/webkitpy/style/checkers/jsonchecker.py:
493         (JSONCSSPropertiesChecker.check_codegen_properties):
494         Allow CSS property definitions to have a 'runtime-flag' parameter which
495         disables the property when the specified runtime flag is disabled.
496
497 2018-11-15  Timothy Hatcher  <timothy@apple.com>
498
499         REGRESSION (r238212): WebKit.BackgroundColor* API test failures.
500         https://bugs.webkit.org/show_bug.cgi?id=191697
501         rdar://problem/46098570
502
503         Reviewed by Dean Jackson.
504
505         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
506         (TestWebKitAPI::TEST): Updated for new default background color.
507
508 2018-11-15  Jonathan Bedard  <jbedard@apple.com>
509
510         webkitpy: Check for specific process instead of using data migrator (Follow-up fix)
511         https://bugs.webkit.org/show_bug.cgi?id=191551
512         <rdar://problem/45993156>
513
514         Reviewed by Aakash Jain.
515
516         * Scripts/webkitpy/xcode/simulated_device.py:
517         (SimulatedDevice.is_usable): Use software_variant instead of software_version for watchOS.
518
519 2018-11-15  Daniel Bates  <dabates@apple.com>
520
521         [iOS] Shift + Tab does not focus previous field
522         https://bugs.webkit.org/show_bug.cgi?id=191596
523         <rdar://problem/45892053>
524
525         Reviewed by Wenson Hsieh.
526
527         Add infrastructure to support testing a key down event with modifiers by creating
528         and dispatching a UIEvent. This infrastructure replaces the previous mechanism in
529         Tools/WebKitTestRunner/ios/HIDEventGenerator.mm to generate a IOHIDEvent for a
530         keydown as it did not support creating an event with modifier key state that would
531         be recognized by UIKit.
532
533         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
534         (WTR::UIScriptController::keyDown):
535         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
536         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
537         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
538         Add function uiController.keyDown() that takes a character that represents a keyboard key
539         and an array of modifier keys. The behavior of this function is analogous to eventSender.keyDown().
540         Remove functions uiController.keyDownUsingHardwareKeyboard() and uiController.keyUpUsingHardwareKeyboard()
541         as the former is replaced by uiController.keyDown() and the latter was never used.
542
543         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
544         (WTR::UIScriptController::keyDown): Added.
545         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
546         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
547         * TestRunnerShared/UIScriptContext/UIScriptController.h:
548         * WebKitTestRunner/ios/HIDEventGenerator.h:
549         * WebKitTestRunner/ios/HIDEventGenerator.mm:
550         (createHIDKeyDownEvent): Added.
551         (-[HIDEventGenerator keyDown:completionBlock:]): Deleted.
552         (-[HIDEventGenerator keyUp:completionBlock:]): Deleted.
553         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
554         (WTR::arrayLength): Added.
555         (WTR::parseModifier): Added.
556         (WTR::parseModifierArray): Added.
557         (WTR::UIScriptController::keyDown):
558         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
559         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
560
561 2018-11-15  Keith Rollin  <krollin@apple.com>
562
563         Delete old .xcfilelist files
564         https://bugs.webkit.org/show_bug.cgi?id=191669
565         <rdar://problem/46081994>
566
567         Reviewed by Chris Dumez.
568
569         .xcfilelist files were created and added to the Xcode project files in
570         https://trac.webkit.org/changeset/238008/webkit. However, they caused
571         build issues and they were removed from the Xcode projects in
572         https://trac.webkit.org/changeset/238055/webkit. This check-in removes
573         the files from the repository altogether. They'll ultimately be
574         replaced with new files with names that indicate whether the
575         associated files are inputs to the Run Script phase or are files
576         created by the Run Script phase.
577
578         * DumpRenderTree/DerivedSources.xcfilelist: Removed.
579         * WebKitTestRunner/DerivedSources.xcfilelist: Removed.
580
581 2018-11-14  Zalan Butjas  <zalan@apple.com>
582
583         [LFC][IFC] Add support for in-flow positioned inline boxes.
584         https://bugs.webkit.org/show_bug.cgi?id=191672
585
586         Reviewed by Antti Koivisto.
587
588         * LayoutReloaded/misc/LFC-passing-tests.txt:
589
590 2018-11-14  Keith Rollin  <krollin@apple.com>
591
592         Move scripts for Derived and Unified Sources to external files
593         https://bugs.webkit.org/show_bug.cgi?id=191670
594         <rdar://problem/46082278>
595
596         Reviewed by Keith Miller.
597
598         Move the scripts in the Generate Derived Sources and Generate Unified
599         Sources Run Script phases from the Xcode projects to external shell
600         script files. Then invoke those scripts from the Run Script phases.
601         This refactoring is being performed to support later work that will
602         invoke these scripts in other contexts.
603
604         The scripts were maintained as-is when making the move. I did a little
605         reformatting and added 'set -e' to the top of each file, but that's
606         it.
607
608         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
609         * DumpRenderTree/Scripts/generate-derived-sources.sh: Added.
610         * WebKitTestRunner/Scripts/generate-derived-sources.sh: Added.
611         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
612
613 2018-11-14  Chris Dumez  <cdumez@apple.com>
614
615         WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled
616         https://bugs.webkit.org/show_bug.cgi?id=191640
617
618         Reviewed by Alex Christensen.
619
620         Add API test coverage.
621
622         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
623         (runDecidePolicyForNavigationActionForHyperlinkThatRedirects):
624         (TEST):
625
626 2018-11-14  Chris Dumez  <cdumez@apple.com>
627
628         REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
629         https://bugs.webkit.org/show_bug.cgi?id=191660
630
631         Reviewed by Ryosuke Niwa.
632
633         The test tries to navigate to an invalid URL and makes sure that we do not process swap
634         for such load. The test was inherently racing because it was doing:
635         <body onload="setTimeout(() => alert('DONE'), 0); location.href = 'http://A=a%B=b'">
636
637         Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
638         log an alert, which causes the API test to keep going and check that we did not swap
639         process. The issue is that a 0 timer may not be sufficient to trigger the load, as
640         the policy decision is asynchronous and relies on the UIProcess responding to it.
641
642         To address the issue, the test now waits for the next policy decision, spins the
643         run loop and then makes sure we did not swap process. It no longer relies on a message
644         from the page.
645
646         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
647         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
648
649 2018-11-14  Chris Dumez  <cdumez@apple.com>
650
651         WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
652         https://bugs.webkit.org/show_bug.cgi?id=191638
653
654         Reviewed by Alex Christensen.
655
656         Add API test coverage.
657
658         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
659         (runWebsiteDataStoreCustomPaths):
660         (TEST):
661
662 2018-11-14  Alex Christensen  <achristensen@webkit.org>
663
664         Add SPI to show a safe browsing warning
665         https://bugs.webkit.org/show_bug.cgi?id=191604
666
667         Reviewed by Andy Estes.
668
669         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
670         (TEST):
671
672 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
673
674         [iOS] A few drag and drop tests are crashing after r238146
675         https://bugs.webkit.org/show_bug.cgi?id=191617
676
677         Reviewed by Dean Jackson.
678
679         Augment these crashing tests to verify that selection commands are suppressed during drop over editable elements
680         via more robust means. These tests currently hit an assertion when revealing the callout bar too early, because
681         TestWebKitAPI is not a UI application (see <https://webkit.org/b/190401>).
682
683         Instead of relying on this other bug, directly ask the text input whether it is suppressing selection commands
684         during a drop, and remember the answer via DragAndDropSimulator.
685
686         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
687         (TestWebKitAPI::TEST):
688
689         Add to the existing tests that started failing after r238146.
690
691         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
692         * TestWebKitAPI/cocoa/TestWKWebView.h:
693         * TestWebKitAPI/cocoa/TestWKWebView.mm:
694         (-[TestWKWebView textInputContentView]):
695         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
696         (-[DragAndDropSimulator _resetSimulatedState]):
697         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
698         * TestWebKitAPI/ios/UIKitSPI.h:
699
700 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
701
702         [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
703         https://bugs.webkit.org/show_bug.cgi?id=191605
704         <rdar://problem/45813991>
705
706         Reviewed by Dean Jackson.
707
708         Adds two new API tests to exercise -_pasteAndMatchStyle: and -makeTextWritingDirectionNatural:.
709
710         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
711         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]): Deleted.
712         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
713         (TestWebKitAPI::TEST):
714         * TestWebKitAPI/cocoa/TestWKWebView.h:
715         * TestWebKitAPI/cocoa/TestWKWebView.mm:
716
717         Pull `-_synchronouslyExecuteEditCommand:argument:` out of WKAttachmentTests and into shared code, in a new
718         category on WKWebView declared in TestWKWebView. Also, fix an unrelated typo in a nearby category.
719
720         (-[WKWebView _synchronouslyExecuteEditCommand:argument:]):
721         * TestWebKitAPI/ios/UIKitSPI.h:
722
723 2018-11-14  Chris Dumez  <cdumez@apple.com>
724
725         WebKit.ApplicationManifestBasic API test is failing when enabling PSON
726         https://bugs.webkit.org/show_bug.cgi?id=191602
727
728         Reviewed by Alex Christensen.
729
730         Add API test coverage.
731
732         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
733
734 2018-11-14  Jonathan Bedard  <jbedard@apple.com>
735
736         webkitpy: Refactor port code for devices
737         https://bugs.webkit.org/show_bug.cgi?id=191568
738         <rdar://problem/46005821>
739
740         Reviewed by Alex Christensen.
741
742         watchOS and iOS device ports share many characteristics in testing, mostly due
743         to the fact that both are devices.
744
745         * Scripts/webkitpy/port/device_port.py: Added.
746         (DevicePort): Add base class that all simulated/physical device ports share.
747         (DevicePort.__init__):
748         (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
749         (DevicePort._generate_all_test_configurations): Ditto.
750         (DevicePort.child_processes): Ditto.
751         (DevicePort.driver_name): Ditto.
752         (DevicePort.target_host): Generalize worker access to attached devices and
753         simulated devices based on the device manager.
754         (DevicePort.devices): Return a list of all devices associated with this port.
755         (DevicePort._create_devices):
756         (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
757         (DevicePort._install): Moved from iOS port.
758         (DevicePort.setup_test_run): Ditto.
759         (DevicePort.clean_up_test_run): Ditto.
760         (DevicePort.did_spawn_worker): Ditto.
761         (DevicePort.setup_environ_for_server): Ditto.
762         * Scripts/webkitpy/port/ios.py:
763         (IOSPort):
764         (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
765         (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
766         (IOSPort.driver_name): Ditto.
767         (IOSPort._generate_all_test_configurations): Ditto.
768         (IOSPort.child_processes): Ditto.
769         (IOSPort._testing_device): Ditto.
770         (IOSPort.target_host): Ditto.
771         (IOSPort._create_devices): Ditto.
772         (IOSPort.setup_test_run): Ditto.
773         (IOSPort.clean_up_test_run): Ditto.
774         (IOSPort.did_spawn_worker): Ditto.
775         * Scripts/webkitpy/port/ios_device.py:
776         (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
777         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
778         (IOSDevicePort._get_crash_log): Ditto.
779         (IOSDevicePort.ios_version): Ditto.
780         (IOSDevicePort._create_devices): Ditto.
781         (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
782         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
783         * Scripts/webkitpy/port/ios_device_unittest.py:
784         (IOSDeviceTest.test_get_crash_log):
785         * Scripts/webkitpy/port/ios_simulator.py:
786         (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
787         (IOSSimulatorPort._create_devices): Clean up logging statement.
788         (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
789         across all devices.
790         (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
791         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
792         * Scripts/webkitpy/port/ios_simulator_unittest.py:
793         (IOSSimulatorTest.test_32bit):
794         (IOSSimulatorTest.test_64bit):
795
796 2018-11-14  Chris Dumez  <cdumez@apple.com>
797
798         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
799         https://bugs.webkit.org/show_bug.cgi?id=191624
800
801         Reviewed by Alex Christensen.
802
803         Add API test coverage.
804
805         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
806         (runWKHTTPCookieStoreWithoutProcessPool):
807         (TEST):
808
809 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
810
811         [WebAuthN] Support CTAP HID authenticators on macOS
812         https://bugs.webkit.org/show_bug.cgi?id=188623
813         <rdar://problem/43353777>
814
815         Reviewed by Brent Fulgham and Chris Dumez.
816
817         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
818         to hid devices.
819
820         * MiniBrowser/MiniBrowser.entitlements:
821         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
822         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
823
824 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
825
826         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
827         https://bugs.webkit.org/show_bug.cgi?id=191616
828
829         Reviewed by Chris Dumez.
830
831         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
832         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
833         resulting in the use-after-free.
834
835         Made the tests more robust by clearing geolocation provider before exiting each test
836         since we can't really prevent WKView from entering an autorelease pool.
837
838         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
839         instead of simply the end of the navigation so that the test would continue to work
840         even if a web content process was created for the second web view (lowAccuracyWebView)
841
842         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
843         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
844         (TestWebKitAPI::clearGeolocationProvider): Added.
845         (TestWebKitAPI::runJavaScriptAlert): Added.
846         (TestWebKitAPI::didFinishNavigation): Deleted.
847         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
848
849 2018-11-13  Chris Dumez  <cdumez@apple.com>
850
851         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
852         https://bugs.webkit.org/show_bug.cgi?id=191618
853
854         Reviewed by Ryosuke Niwa.
855
856         Update API test to explicitly disable automatic process prewarning since it is testing
857         manual prewarming.
858
859         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
860         (TEST):
861
862 2018-11-13  Chris Dumez  <cdumez@apple.com>
863
864         Several Service Worker API tests are failing when enabling PSON
865         https://bugs.webkit.org/show_bug.cgi?id=191619
866
867         Reviewed by Youenn Fablet.
868
869         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
870         not impacted by process prewarming.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
873
874 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
875
876         [iOS] Do not show selection UI for editable elements with opacity near zero
877         https://bugs.webkit.org/show_bug.cgi?id=191442
878         <rdar://problem/45958625>
879
880         Reviewed by Simon Fraser.
881
882         Add a couple of new testing helpers to UIScriptController.
883
884         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
885         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
886         (WTR::UIScriptController::textSelectionRangeRects const):
887         (WTR::UIScriptController::selectionCaretViewRect const):
888         (WTR::UIScriptController::selectionRangeViewRects const):
889         * TestRunnerShared/UIScriptContext/UIScriptController.h:
890         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
891         (WTR::UIScriptController::textSelectionRangeRects const):
892
893         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
894         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
895         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
896         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
897         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
898
899         Also, drive-by fix a leaked `NSMutableArray`.
900
901         (WTR::UIScriptController::selectionStartGrabberViewRect const):
902         (WTR::UIScriptController::selectionEndGrabberViewRect const):
903         (WTR::UIScriptController::selectionCaretViewRect const):
904         (WTR::UIScriptController::selectionRangeViewRects const):
905
906         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
907         rects are also clamped to WKContentView bounds.
908
909 2018-11-13  Daniel Bates  <dabates@apple.com>
910
911         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
912         https://bugs.webkit.org/show_bug.cgi?id=173341
913         <rdar://problem/32752890>
914
915         Reviewed by Simon Fraser.
916
917         There is little value to making a distinction between forward declarations
918         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
919         the contents of these two headers can conflict with each other following
920         r218275 as DumpRenderTree includes both headers. Instead we should remove
921         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
922
923         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
924         * DumpRenderTree/mac/DumpRenderTree.mm:
925         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
926         * WebKitTestRunner/Configurations/Base.xcconfig:
927         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
928         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
929         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
930         * WebKitTestRunner/ios/HIDEventGenerator.h:
931         * WebKitTestRunner/ios/HIDEventGenerator.mm:
932         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
933         * WebKitTestRunner/ios/TestControllerIOS.mm:
934         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
935         * WebKitTestRunner/ios/mainIOS.mm:
936
937 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
938
939         Remove WebKitTestRunnerLib's build warnings.
940         https://bugs.webkit.org/show_bug.cgi?id=191580
941
942         Reviewed by Fujii Hironori.
943
944         Include cmakeconfig.h in precompiled header.
945
946         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
947
948 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
949
950         Implement Cache API support for WPE/GTK
951         https://bugs.webkit.org/show_bug.cgi?id=178316
952
953         Reviewed by Michael Catanzaro.
954
955         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
956         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
957
958         * WebKitTestRunner/TestController.cpp:
959         (WTR::TestController::generatePageConfiguration):
960         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
961         (WTR::initializeWebViewConfiguration):
962
963 2018-11-12  Christopher Reid  <chris.reid@sony.com>
964
965         [Curl] Reject entire cookie if the domain fails a tailmatch.
966         https://bugs.webkit.org/show_bug.cgi?id=191406
967
968         Reviewed by Youenn Fablet.
969
970         Added unittests for Curl cookie implementation.
971
972         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
973         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
974
975 2018-11-12  Alex Christensen  <achristensen@webkit.org>
976
977         [iOS] Implement safe browsing in WebKit
978         https://bugs.webkit.org/show_bug.cgi?id=191441
979
980         Reviewed by Tim Horton.
981
982         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
983         (checkTitleAndClick):
984         (TEST):
985
986 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
987
988         [Curl] Add API Test for Curl cookie backend.
989         https://bugs.webkit.org/show_bug.cgi?id=191493
990
991         Reviewed by Youenn Fablet.
992
993         Add unit test to TestWebCore.
994
995         * TestWebKitAPI/PlatformWin.cmake:
996         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
997
998 2018-11-12  Tim Horton  <timothy_horton@apple.com>
999
1000         Make it possible to edit images inline
1001         https://bugs.webkit.org/show_bug.cgi?id=191352
1002         <rdar://problem/30107985>
1003
1004         Reviewed by Dean Jackson.
1005
1006         * WebKitTestRunner/TestController.cpp:
1007         (WTR::updateTestOptionsFromTestHeader):
1008         * WebKitTestRunner/TestOptions.h:
1009         (WTR::TestOptions::hasSameInitializationOptions const):
1010         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1011         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1012         (WTR::TestController::platformCreateWebView):
1013         Add a test option to enable editable images.
1014
1015         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1016         (WTR::UIScriptController::drawSquareInEditableImage):
1017         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1018         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1019         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1020         (WTR::UIScriptController::drawSquareInEditableImage):
1021         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1022         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1023         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
1024         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1025         (WTR::findEditableImageCanvas):
1026         (WTR::UIScriptController::drawSquareInEditableImage):
1027         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1028         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
1029         and also to retrieve the number of strokes currently on the PKCanvasView.
1030         Currently this just takes the first canvas; we might need to make it
1031         take an identifier or something in the future if we need tests with multiple
1032         canvases. The indirect testing mechanism is required because PKCanvasView
1033         can currently not actually paint its strokes in the Simulator.
1034
1035 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
1036
1037         [MediaStream] Screen capture should be an experimental feature on OSX only
1038         https://bugs.webkit.org/show_bug.cgi?id=191552
1039
1040         Unreviewed test gardening.
1041
1042         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
1043
1044 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1045
1046         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1047         https://bugs.webkit.org/show_bug.cgi?id=189230
1048         <rdar://problem/44050379>
1049
1050         Reviewed by Joseph Pecoraro.
1051
1052         Runs all png images through zopflipng. This results in a smaller file
1053         size and takes care of this issue as a byproduct.
1054
1055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
1056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
1057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
1058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
1059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
1060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
1061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
1062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
1063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
1064         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
1066         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
1069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
1070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
1071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
1072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
1073         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
1074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
1075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
1076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
1077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
1078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
1079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
1082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
1083         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
1084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
1087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
1091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1093         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
1094         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
1095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
1096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
1097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
1098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
1099         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
1100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
1101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
1102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
1104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
1105
1106 2018-11-12  Tim Horton  <timothy_horton@apple.com>
1107
1108         Modernize WebKit Tools Xcode projects for localization's sake
1109         https://bugs.webkit.org/show_bug.cgi?id=191495
1110
1111         Reviewed by Alexey Proskuryakov.
1112
1113         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
1114         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1115         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
1116         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1117         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1118         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1119         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1121         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1122         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1123         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1124         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1125         These are less important because they're not localized, but since
1126         I made the style checker complain, it now complains any time anyone
1127         touches any of these projects... so upgrade them.
1128
1129 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
1130
1131         webkitpy: Check for specific process instead of using data migrator
1132         https://bugs.webkit.org/show_bug.cgi?id=191551
1133         <rdar://problem/45993156>
1134
1135         Rubber-stamped by Aakash Jain.
1136
1137         It's possible for the data migrator process to be stuck, but for a simulator to be
1138         usable. Use device-specific processes to detect when a device is usable.
1139
1140         * Scripts/webkitpy/xcode/simulated_device.py:
1141         (SimulatedDeviceManager._wait_until_device_is_usable):
1142         (SimulatedDeviceManager):
1143         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
1144         since this implies that a device is booted.
1145         (SimulatedDeviceManager.swap): Ditto.
1146         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
1147         process indicating the device is usable can be found.
1148         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
1149         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
1150         it triggers the logic in is_usable()
1151
1152 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
1153
1154         Resurrect WebKitTestRunner for Windows port
1155         https://bugs.webkit.org/show_bug.cgi?id=189257
1156
1157         Reviewed by Fujii Hironori.
1158
1159         Implement WebKitTestRunner for WinCairo.
1160
1161         * PlatformWin.cmake:
1162         * Scripts/build-webkittestrunner:
1163         * WebKitTestRunner/CMakeLists.txt:
1164         * WebKitTestRunner/EventSenderProxy.h:
1165         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1166         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1167         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1168         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1169         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1170         (WTR::rangeToStr):
1171         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1172         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1173         (WTR::TestRunner::TestRunner):
1174         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1175         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
1176         (WTR::AccessibilityController::resetToConsistentState):
1177         (WTR::AccessibilityController::accessibleElementById):
1178         (WTR::AccessibilityController::platformName):
1179         (WTR::AccessibilityController::rootElement):
1180         (WTR::AccessibilityController::focusedElement):
1181         (WTR::AccessibilityController::addNotificationListener):
1182         (WTR::AccessibilityController::removeNotificationListener):
1183         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
1184         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1185         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1186         (WTR::AccessibilityUIElement::isEqual):
1187         (WTR::AccessibilityUIElement::getChildren):
1188         (WTR::AccessibilityUIElement::getChildrenWithRange):
1189         (WTR::AccessibilityUIElement::childrenCount):
1190         (WTR::AccessibilityUIElement::elementAtPoint):
1191         (WTR::AccessibilityUIElement::indexOfChild):
1192         (WTR::AccessibilityUIElement::childAtIndex):
1193         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1194         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1195         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1196         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1197         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1198         (WTR::AccessibilityUIElement::rowAtIndex):
1199         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
1200         (WTR::AccessibilityUIElement::selectedChildrenCount const):
1201         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1202         (WTR::AccessibilityUIElement::titleUIElement):
1203         (WTR::AccessibilityUIElement::parentElement):
1204         (WTR::AccessibilityUIElement::disclosedByRow):
1205         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1206         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1207         (WTR::AccessibilityUIElement::attributesOfChildren):
1208         (WTR::AccessibilityUIElement::allAttributes):
1209         (WTR::AccessibilityUIElement::stringAttributeValue):
1210         (WTR::AccessibilityUIElement::numberAttributeValue):
1211         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1212         (WTR::AccessibilityUIElement::rowHeaders const):
1213         (WTR::AccessibilityUIElement::columnHeaders const):
1214         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
1215         (WTR::AccessibilityUIElement::boolAttributeValue):
1216         (WTR::AccessibilityUIElement::isAttributeSettable):
1217         (WTR::AccessibilityUIElement::isAttributeSupported):
1218         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1219         (WTR::AccessibilityUIElement::role):
1220         (WTR::AccessibilityUIElement::subrole):
1221         (WTR::AccessibilityUIElement::roleDescription):
1222         (WTR::AccessibilityUIElement::computedRoleString):
1223         (WTR::AccessibilityUIElement::title):
1224         (WTR::AccessibilityUIElement::description):
1225         (WTR::AccessibilityUIElement::orientation const):
1226         (WTR::AccessibilityUIElement::stringValue):
1227         (WTR::AccessibilityUIElement::language):
1228         (WTR::AccessibilityUIElement::helpText const):
1229         (WTR::AccessibilityUIElement::x):
1230         (WTR::AccessibilityUIElement::y):
1231         (WTR::AccessibilityUIElement::width):
1232         (WTR::AccessibilityUIElement::height):
1233         (WTR::AccessibilityUIElement::clickPointX):
1234         (WTR::AccessibilityUIElement::clickPointY):
1235         (WTR::AccessibilityUIElement::intValue const):
1236         (WTR::AccessibilityUIElement::minValue):
1237         (WTR::AccessibilityUIElement::maxValue):
1238         (WTR::AccessibilityUIElement::valueDescription):
1239         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1240         (WTR::AccessibilityUIElement::isPressActionSupported):
1241         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1242         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1243         (WTR::AccessibilityUIElement::isEnabled):
1244         (WTR::AccessibilityUIElement::isRequired const):
1245         (WTR::AccessibilityUIElement::isFocused const):
1246         (WTR::AccessibilityUIElement::isSelected const):
1247         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
1248         (WTR::AccessibilityUIElement::isExpanded const):
1249         (WTR::AccessibilityUIElement::isChecked const):
1250         (WTR::AccessibilityUIElement::isIndeterminate const):
1251         (WTR::AccessibilityUIElement::hierarchicalLevel const):
1252         (WTR::AccessibilityUIElement::speakAs):
1253         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
1254         (WTR::AccessibilityUIElement::ariaDropEffects const):
1255         (WTR::AccessibilityUIElement::lineForIndex):
1256         (WTR::AccessibilityUIElement::rangeForLine):
1257         (WTR::AccessibilityUIElement::rangeForPosition):
1258         (WTR::AccessibilityUIElement::boundsForRange):
1259         (WTR::AccessibilityUIElement::stringForRange):
1260         (WTR::AccessibilityUIElement::attributedStringForRange):
1261         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1262         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1263         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1264         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1265         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1266         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1267         (WTR::AccessibilityUIElement::attributesOfColumns):
1268         (WTR::AccessibilityUIElement::attributesOfRows):
1269         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1270         (WTR::AccessibilityUIElement::attributesOfHeader):
1271         (WTR::AccessibilityUIElement::rowCount):
1272         (WTR::AccessibilityUIElement::columnCount):
1273         (WTR::AccessibilityUIElement::indexInTable):
1274         (WTR::AccessibilityUIElement::rowIndexRange):
1275         (WTR::AccessibilityUIElement::columnIndexRange):
1276         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1277         (WTR::AccessibilityUIElement::horizontalScrollbar const):
1278         (WTR::AccessibilityUIElement::verticalScrollbar const):
1279         (WTR::AccessibilityUIElement::selectedTextRange):
1280         (WTR::AccessibilityUIElement::setSelectedTextRange):
1281         (WTR::AccessibilityUIElement::increment):
1282         (WTR::AccessibilityUIElement::decrement):
1283         (WTR::AccessibilityUIElement::showMenu):
1284         (WTR::AccessibilityUIElement::press):
1285         (WTR::AccessibilityUIElement::setSelectedChild const):
1286         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
1287         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
1288         (WTR::AccessibilityUIElement::clearSelectedChildren const):
1289         (WTR::AccessibilityUIElement::accessibilityValue const):
1290         (WTR::AccessibilityUIElement::documentEncoding):
1291         (WTR::AccessibilityUIElement::documentURI):
1292         (WTR::AccessibilityUIElement::url):
1293         (WTR::AccessibilityUIElement::addNotificationListener):
1294         (WTR::AccessibilityUIElement::removeNotificationListener):
1295         (WTR::AccessibilityUIElement::isFocusable const):
1296         (WTR::AccessibilityUIElement::isSelectable const):
1297         (WTR::AccessibilityUIElement::isMultiSelectable const):
1298         (WTR::AccessibilityUIElement::isVisible const):
1299         (WTR::AccessibilityUIElement::isOffScreen const):
1300         (WTR::AccessibilityUIElement::isCollapsed const):
1301         (WTR::AccessibilityUIElement::isIgnored const):
1302         (WTR::AccessibilityUIElement::isSingleLine const):
1303         (WTR::AccessibilityUIElement::isMultiLine const):
1304         (WTR::AccessibilityUIElement::hasPopup const):
1305         (WTR::AccessibilityUIElement::takeFocus):
1306         (WTR::AccessibilityUIElement::takeSelection):
1307         (WTR::AccessibilityUIElement::addSelection):
1308         (WTR::AccessibilityUIElement::removeSelection):
1309         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1310         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1311         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1312         (WTR::AccessibilityUIElement::previousTextMarker):
1313         (WTR::AccessibilityUIElement::nextTextMarker):
1314         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1315         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1316         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1317         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1318         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1319         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1320         (WTR::AccessibilityUIElement::textMarkerForPoint):
1321         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1322         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
1323         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
1324         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1325         (WTR::AccessibilityUIElement::indexForTextMarker):
1326         (WTR::AccessibilityUIElement::isTextMarkerValid):
1327         (WTR::AccessibilityUIElement::textMarkerForIndex):
1328         (WTR::AccessibilityUIElement::startTextMarker):
1329         (WTR::AccessibilityUIElement::endTextMarker):
1330         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1331         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1332         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1333         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1334         (WTR::AccessibilityUIElement::supportedActions const):
1335         (WTR::AccessibilityUIElement::pathDescription const):
1336         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
1337         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
1338         (WTR::AccessibilityUIElement::classList const):
1339         (WTR::AccessibilityUIElement::characterAtOffset):
1340         (WTR::AccessibilityUIElement::wordAtOffset):
1341         (WTR::AccessibilityUIElement::lineAtOffset):
1342         (WTR::AccessibilityUIElement::sentenceAtOffset):
1343         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1344         (WTR::activateFonts):
1345         (WTR::installFakeHelvetica):
1346         (WTR::uninstallFakeHelvetica):
1347         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1348         (WTR::InjectedBundle::platformInitialize):
1349         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
1350         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1351         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1352         (WTR::TestRunner::pathToLocalResource):
1353         (WTR::TestRunner::inspectorTestStubURL):
1354         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1355         (WTR::TestRunner::platformInitialize):
1356         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1357         (WTR::TestRunner::installFakeHelvetica):
1358         * WebKitTestRunner/PlatformWebView.h:
1359         * WebKitTestRunner/PlatformWin.cmake: Added.
1360         * WebKitTestRunner/TestController.cpp:
1361         (WTR::TestController::resetStateToConsistentValues):
1362         (WTR::createTestURL):
1363         * WebKitTestRunner/TestInvocation.cpp:
1364         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1365         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
1366         (WTR::EventSenderProxy::EventSenderProxy):
1367         (WTR::EventSenderProxy::~EventSenderProxy):
1368         (WTR::EventSenderProxy::mouseDown):
1369         (WTR::EventSenderProxy::mouseUp):
1370         (WTR::EventSenderProxy::mouseMoveTo):
1371         (WTR::EventSenderProxy::mouseScrollBy):
1372         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1373         (WTR::EventSenderProxy::continuousMouseScrollBy):
1374         (WTR::EventSenderProxy::leapForward):
1375         (WTR::EventSenderProxy::keyDown):
1376         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
1377         (WTR::registerWindowClass):
1378         (WTR::PlatformWebView::PlatformWebView):
1379         (WTR::PlatformWebView::~PlatformWebView):
1380         (WTR::PlatformWebView::resizeTo):
1381         (WTR::PlatformWebView::page):
1382         (WTR::PlatformWebView::focus):
1383         (WTR::PlatformWebView::windowFrame):
1384         (WTR::PlatformWebView::setWindowFrame):
1385         (WTR::PlatformWebView::didInitializeClients):
1386         (WTR::PlatformWebView::addChromeInputField):
1387         (WTR::PlatformWebView::removeChromeInputField):
1388         (WTR::PlatformWebView::addToWindow):
1389         (WTR::PlatformWebView::removeFromWindow):
1390         (WTR::PlatformWebView::setWindowIsKey):
1391         (WTR::PlatformWebView::makeWebViewFirstResponder):
1392         (WTR::generateCairoSurfaceFromBitmap):
1393         (WTR::PlatformWebView::windowSnapshotImage):
1394         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1395         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1396         (WTR::PlatformWebView::forceWindowFramesChanged):
1397         (WTR::PlatformWebView::drawsBackground const):
1398         (WTR::PlatformWebView::setDrawsBackground):
1399         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
1400         (WTR::exceptionFilter):
1401         (WTR::runRunLoopUntil):
1402         (WTR::TestController::notifyDone):
1403         (WTR::TestController::setHidden):
1404         (WTR::TestController::platformInitialize):
1405         (WTR::TestController::platformPreferences):
1406         (WTR::TestController::platformDestroy):
1407         (WTR::toWK):
1408         (WTR::TestController::platformInitializeContext):
1409         (WTR::TestController::platformRunUntil):
1410         (WTR::TestController::platformDidCommitLoadForFrame):
1411         (WTR::TestController::initializeInjectedBundlePath):
1412         (WTR::TestController::initializeTestPluginDirectory):
1413         (WTR::TestController::runModal):
1414         (WTR::TestController::platformContext):
1415         (WTR::TestController::platformLibraryPathForTesting):
1416         (WTR::TestController::platformConfigureViewForTest):
1417         (WTR::TestController::platformResetPreferencesToConsistentValues):
1418         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
1419         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
1420         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1421         (dllLauncherEntryPoint):
1422
1423 2018-11-12  Alicia Boya García  <aboya@igalia.com>
1424
1425         [MSE][GStreamer] Introduce AbortableTaskQueue
1426         https://bugs.webkit.org/show_bug.cgi?id=190902
1427
1428         Reviewed by Xabier Rodriguez-Calvar.
1429
1430         Tests for AbortableTaskQueue are included.
1431
1432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1433         * TestWebKitAPI/PlatformGTK.cmake:
1434         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
1435         (TestWebKitAPI::TEST):
1436         (TestWebKitAPI::FancyResponse::FancyResponse):
1437         (TestWebKitAPI::FancyResponse::operator=):
1438         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
1439         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
1440         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
1441         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
1442
1443 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1444
1445         run-bindings-tests is timing out in some WinCairo bots
1446         https://bugs.webkit.org/show_bug.cgi?id=191348
1447
1448         Reviewed by Alex Christensen.
1449
1450         BuildBot kills run-bindings-tests if it outputs nothing for 20
1451         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
1452         and it takes more than 30 minutes to finish. And, Windows Python
1453         buffers the progress output.
1454
1455         * Scripts/webkitpy/bindings/main.py:
1456         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
1457         test case result is output.
1458
1459 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1460
1461         Implement a new edit command to change the enclosing list type
1462         https://bugs.webkit.org/show_bug.cgi?id=191487
1463         <rdar://problem/45955922>
1464
1465         Reviewed by Ryosuke Niwa.
1466
1467         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
1468         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
1469
1470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1471         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1472         (-[TestWKWebView setPosition:offset:]):
1473         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
1474         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
1475         (TestWebKitAPI::TEST):
1476         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
1477
1478 2018-11-11  Dan Bernstein  <mitz@apple.com>
1479
1480         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
1481         https://bugs.webkit.org/show_bug.cgi?id=191514
1482
1483         Reviewed by Geoffrey Garen.
1484
1485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1486         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
1487         (TEST):
1488
1489 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1490
1491         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1492         https://bugs.webkit.org/show_bug.cgi?id=191492
1493
1494         Reviewed by Alex Christensen.
1495
1496         Update file name.
1497
1498         * DumpRenderTree/mac/DumpRenderTree.mm:
1499         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1500         * WebKitTestRunner/mac/TestControllerMac.mm:
1501
1502 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1503
1504         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1505         https://bugs.webkit.org/show_bug.cgi?id=191492
1506
1507         Reviewed by Alex Christensen.
1508
1509         * DumpRenderTree/mac/DumpRenderTree.mm:
1510         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1511         * WebKitTestRunner/mac/TestControllerMac.mm:
1512
1513 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
1514
1515         Unreviewed, rolling out r238065.
1516
1517         Breaks internal builds.
1518
1519         Reverted changeset:
1520
1521         "Make it possible to edit images inline"
1522         https://bugs.webkit.org/show_bug.cgi?id=191352
1523         https://trac.webkit.org/changeset/238065
1524
1525 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1526
1527         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
1528         https://bugs.webkit.org/show_bug.cgi?id=191221
1529
1530         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
1531         that it is disabled, but we're testing that it is enabled, because I failed to update this
1532         line.
1533
1534         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1535         (testWebKitSettings):
1536
1537 2018-11-10  Tim Horton  <timothy_horton@apple.com>
1538
1539         Make it possible to edit images inline
1540         https://bugs.webkit.org/show_bug.cgi?id=191352
1541         <rdar://problem/30107985>
1542
1543         Reviewed by Dean Jackson.
1544
1545         * WebKitTestRunner/TestController.cpp:
1546         (WTR::updateTestOptionsFromTestHeader):
1547         * WebKitTestRunner/TestOptions.h:
1548         (WTR::TestOptions::hasSameInitializationOptions const):
1549         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1550         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1551         (WTR::TestController::platformCreateWebView):
1552         Add a test option to enable editable images.
1553
1554         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1555         (WTR::UIScriptController::drawSquareInEditableImage):
1556         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1557         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1558         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1559         (WTR::UIScriptController::drawSquareInEditableImage):
1560         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1561         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1562         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
1563         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1564         (WTR::findEditableImageCanvas):
1565         (WTR::UIScriptController::drawSquareInEditableImage):
1566         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1567         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
1568         and also to retrieve the number of strokes currently on the PKCanvasView.
1569         Currently this just takes the first canvas; we might need to make it
1570         take an identifier or something in the future if we need tests with multiple
1571         canvases. The indirect testing mechanism is required because PKCanvasView
1572         can currently not actually paint its strokes in the Simulator.
1573
1574 2018-11-09  Chris Dumez  <cdumez@apple.com>
1575
1576         Suspended page persists even after back/forward list item is gone
1577         https://bugs.webkit.org/show_bug.cgi?id=191488
1578         <rdar://problem/45953006>
1579
1580         Reviewed by Geoffrey Garen.
1581
1582         Add API test coverage.
1583
1584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1585
1586 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1587
1588         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
1589         https://bugs.webkit.org/show_bug.cgi?id=191471
1590         <rdar://problem/45952472>
1591
1592         Reviewed by Tim Horton.
1593
1594         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
1595
1596         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1597         (TestWebKitAPI::webViewForEditActionTesting):
1598         (TestWebKitAPI::TEST):
1599
1600 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
1601
1602         [Curl][WebKit] Implement Proxy configuration API.
1603         https://bugs.webkit.org/show_bug.cgi?id=189053
1604
1605         Reviewed by Youenn Fablet.
1606
1607         Added Proxy Settings dialog to call newly added API.
1608
1609         * MiniBrowser/win/BrowserWindow.h:
1610         * MiniBrowser/win/Common.cpp:
1611         (askProxySettings):
1612         (askCredential):
1613         (authDialogProc): Deleted.
1614         * MiniBrowser/win/Common.h:
1615         * MiniBrowser/win/DialogHelper.h: Added.
1616         (Dialog::run):
1617         (Dialog::doalogProc):
1618         (Dialog::handle):
1619         (Dialog::setup):
1620         (Dialog::update):
1621         (Dialog::validate):
1622         (Dialog::updateOkButton):
1623         (Dialog::command):
1624         (Dialog::ok):
1625         (Dialog::cancel):
1626         (Dialog::close):
1627         (Dialog::hDlg):
1628         (Dialog::item):
1629         (Dialog::setEnabled):
1630         (Dialog::setText):
1631         (Dialog::getText):
1632         (Dialog::getTextLength):
1633         (Dialog::RadioGroup::RadioGroup):
1634         (Dialog::RadioGroup::set):
1635         (Dialog::RadioGroup::get):
1636         (Dialog::radioGroup):
1637         * MiniBrowser/win/MainWindow.cpp:
1638         (MainWindow::WndProc):
1639         * MiniBrowser/win/MiniBrowserLib.rc:
1640         * MiniBrowser/win/MiniBrowserLibResource.h:
1641         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1642         (createWKURL):
1643         (WebKitBrowserWindow::WebKitBrowserWindow):
1644         (WebKitBrowserWindow::updateProxySettings):
1645         (WebKitBrowserWindow::loadURL):
1646         (WebKitBrowserWindow::loadHTMLString):
1647         (WebKitBrowserWindow::openProxySettings):
1648         * MiniBrowser/win/WebKitBrowserWindow.h:
1649         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1650         (WebKitLegacyBrowserWindow::openProxySettings):
1651         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1652
1653 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1654
1655         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
1656         https://bugs.webkit.org/show_bug.cgi?id=191410
1657         <rdar://problem/45898610>
1658
1659         Reviewed by Dean Jackson.
1660
1661         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
1662         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
1663         hooked up to their respective editing commands.
1664
1665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1666         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
1667         (-[TestWKWebView querySelectorExists:]):
1668         (-[TestWKWebView insertString:]):
1669
1670         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
1671         invoking the WKWebView directly on macOS and calling on the content view on iOS.
1672
1673         (TestWebKitAPI::webViewForEditActionTesting):
1674         (TestWebKitAPI::TEST):
1675
1676 2018-11-09  Philippe Normand  <pnormand@igalia.com>
1677
1678         [Flatpak] Refactoring and drive-by fixes
1679         https://bugs.webkit.org/show_bug.cgi?id=191421
1680
1681         Reviewed by Michael Catanzaro.
1682
1683         * Scripts/webkitdirs.pm:
1684         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
1685         the sandbox, so rely on this.
1686         * flatpak/flatpakutils.py:
1687         (expand_manifest): Pass explicit keywords to load_manifest() and
1688         remove unused local variable.
1689         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
1690         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
1691         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
1692         build_type handling a bit.
1693         * flatpak/org.webkit.CommonModules.yaml: Added.
1694         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
1695         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
1696         declaration to CommonModules, so it can be reused later when we
1697         add support for building extra libraries depending on WPE.
1698
1699 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
1700
1701 onal supported image formats
1702         https://bugs.webkit.org/show_bug.cgi?id=190454
1703
1704         Reviewed by Simon Fraser.
1705
1706         Test opening a TGA image in WebView which is not allowed by default. The
1707         TGA format will be allowed through WKWebViewConfiguration.
1708
1709         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1710         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
1711         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
1712         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
1713         (runTest):
1714         (TEST):
1715
1716 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1717
1718         Unreviewed, a proper build fix for r237983
1719
1720         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
1721
1722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1723         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
1724         (TestWebKitAPI::TEST):
1725         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
1726         (TestWebKitAPI::getTestCorruptedSignResponse):
1727         (TestWebKitAPI::getTestCredentialRawIdBytes):
1728         (TestWebKitAPI::convertToVector):
1729         (TestWebKitAPI::TEST):
1730
1731 2018-11-08  Keith Rollin  <krollin@apple.com>
1732
1733         Create .xcfilelist files
1734         https://bugs.webkit.org/show_bug.cgi?id=191324
1735         <rdar://problem/45852819>
1736
1737         Reviewed by Alex Christensen.
1738
1739         As part of preparing for enabling XCBuild, create and use .xcfilelist
1740         files. These files are using during Run Script build phases in an
1741         Xcode project. If a Run Script build phase produces new files that are
1742         used later as inputs to subsequent build phases, XCBuild needs to know
1743         about these files. These files can be either specified in an "output
1744         files" section of the Run Script phase editor, or in .xcfilelist files
1745         that are associated with the Run Script build phase.
1746
1747         This patch takes the second approach. It consists of three sets of changes:
1748
1749         - Modify the DerivedSources.make files to have a
1750           'print_all_generated_files" target that produces a list of the files
1751           they create.
1752
1753         - Create a shell script that produces .xcfilelist files from the
1754           output of the previous step, as well as for the files created in the
1755           Generate Unified Sources build steps.
1756
1757         - Add the new .xcfilelist files to the associated projects.
1758
1759         Note that, with these changes, the Xcode workspace and projects can no
1760         longer be fully loaded into Xcode 9. Xcode will attempt to load the
1761         projects that have .xcfilelist files associated with them, but will
1762         fail and display a placeholder for those projects instead. It's
1763         expected that all developers are using Xcode 10 by now and that not
1764         being able to load into Xcode 9 is not a practical issue. Keep in mind
1765         that this is strictly an IDE issue, and that the projects can still be
1766         built with `xcodebuild`.
1767
1768         Also note that the shell script that creates the .xcfilelist files can
1769         also be used to verify that the set of files that's currently checked
1770         in is up-to-date. This checking can be used as part of a check-in hook
1771         or part of check-webkit-style to sooner catch cases where the
1772         .xcfilelist files need to be regenerated.
1773
1774         * DumpRenderTree/DerivedSources.make:
1775         * DumpRenderTree/DerivedSources.xcfilelist: Added.
1776         * Scripts/generate-xcfilelists: Added.
1777         * WebKitTestRunner/DerivedSources.make:
1778         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
1779
1780 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1781
1782         Unreviewed, a quick build fix for r237983
1783
1784         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
1785
1786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
1787         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
1788         (TestWebKitAPI::TEST):
1789         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
1790         (TestWebKitAPI::getTestCorruptedSignResponse):
1791         (TestWebKitAPI::getTestCredentialRawIdBytes):
1792         (TestWebKitAPI::convertToVector):
1793         (TestWebKitAPI::TEST):
1794
1795 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
1796
1797         Fix steps_unittest.py failures related to recent Win10/Win7 changes
1798         https://bugs.webkit.org/show_bug.cgi?id=191290
1799
1800         Reviewed by Alexey Proskuryakov.
1801
1802         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
1803
1804 2018-11-08  Dean Jackson  <dino@apple.com>
1805
1806         Add a String literal that returns a String
1807         https://bugs.webkit.org/show_bug.cgi?id=191425
1808         <rdar://problem/45914556>
1809
1810         Reviewed by Sam Weinig.
1811
1812         Test _str.
1813
1814         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1815         (TestWebKitAPI::TEST):
1816
1817 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
1818
1819         webkitpy: Generalize trailing SDK specifier (Part 2)
1820         https://bugs.webkit.org/show_bug.cgi?id=191275
1821         <rdar://problem/45703660>
1822
1823         Rubber-stamped by Aakash Jain.
1824
1825         Re-landing this change, configuration issues have been resolved.
1826
1827         * Scripts/webkitpy/port/ios_device.py:
1828         (IOSDevicePort): Use normalized SDK.
1829         * Scripts/webkitpy/port/ios_simulator.py:
1830         (IOSSimulatorPort): Use normalized SDK.
1831         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1832
1833 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1834
1835         [WebAuthN] Import CTAP device request/response converters from Chromium
1836         https://bugs.webkit.org/show_bug.cgi?id=190784
1837         <rdar://problem/45460333>
1838
1839         Reviewed by Brent Fulgham.
1840
1841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1842         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
1843         (TestWebKitAPI::TEST):
1844         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
1845         (TestWebKitAPI::TEST):
1846         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
1847         (TestWebKitAPI::getTestCorruptedSignResponse):
1848         (TestWebKitAPI::getTestCredentialRawIdBytes):
1849         (TestWebKitAPI::convertToVector):
1850         (TestWebKitAPI::TEST):
1851         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
1852
1853 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
1854
1855         [BigInt] Add support to BigInt into ValueAdd
1856         https://bugs.webkit.org/show_bug.cgi?id=186177
1857
1858         Reviewed by Keith Miller.
1859
1860         * Scripts/run-jsc-benchmarks:
1861
1862 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
1863
1864         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
1865         https://bugs.webkit.org/show_bug.cgi?id=191326
1866         <rdar://problem/45769269>
1867
1868         Reviewed by Geoffrey Garen.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
1872         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
1873         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
1874         (TEST):
1875
1876 2018-11-07  Daniel Bates  <dabates@apple.com>
1877
1878         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
1879         https://bugs.webkit.org/show_bug.cgi?id=190141
1880
1881         Reviewed by Darin Adler.
1882
1883         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
1884         runs deterministic regardless of whether a hardware keyboard is attached.
1885
1886         * DumpRenderTree/mac/DumpRenderTree.mm:
1887         (overrideIsInHardwareKeyboardMode): Added.
1888         (prepareConsistentTestingEnvironment):
1889         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
1890         * WebKitTestRunner/ios/TestControllerIOS.mm:
1891         (overrideIsInHardwareKeyboardMode): Added.
1892         (WTR::TestController::platformInitialize):
1893
1894 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
1895
1896         Unreviewed, rolling out r237913.
1897
1898         Breaks running tests on Mac without iOS SDK installed
1899
1900         Reverted changeset:
1901
1902         "webkitpy: Generalize trailing SDK specifier (Part 2)"
1903         https://bugs.webkit.org/show_bug.cgi?id=191275
1904         https://trac.webkit.org/changeset/237913
1905
1906 2018-11-07  Zamiul Haque  <zhaque@apple.com>
1907
1908         Force a gregorian calendar to show for credit card expiration date inputs
1909         (autocomplete='cc-exp'*) regardless of default system settings.
1910         https://bugs.webkit.org/show_bug.cgi?id=191096
1911         rdar://problem/42640256
1912
1913         Reviewed by Tim Horton.
1914
1915         Implemented simulateForeignDefaultCalendar and calendarType to be used
1916         for changing the default calendar returned by the system (ie. [NSCalendar
1917         currentCalendar]) and getting the calendar type identifier of a presented date
1918         picker.
1919
1920         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1921         (WTR::UIScriptController::isShowingDataListSuggestions const):
1922         (WTR::UIScriptController::calendarType const):
1923         (WTR::UIScriptController::setDefaultCalendarType):
1924         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1925         (WTR::UIScriptController::calendarType const):
1926         (WTR::UIScriptController::setDefaultCalendarType):
1927         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1928         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1929         (WTR::UIScriptController::calendarType const): Deleted.
1930         * WebKitTestRunner/TestController.cpp:
1931         * WebKitTestRunner/TestController.h:
1932         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1933         (WTR::UIScriptController::calendarType const):
1934         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1935         (WTR::swizzledCalendar):
1936         (WTR::TestController::getOverriddenCalendarIdentifier const):
1937         (WTR::TestController::setDefaultCalendarType):
1938         (WTR::TestController::cocoaResetStateToConsistentValues):
1939         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1940         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1941         (WTR::UIScriptController::calendarType const): Deleted.
1942
1943 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1944
1945         webkitpy: Boot a single worker for custom devices
1946         https://bugs.webkit.org/show_bug.cgi?id=191312
1947         <rdar://problem/45848717>
1948
1949         Rubber-stamped by Aakash Jain.
1950
1951         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1952         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
1953         simulators is expensive and unneeded for these tests.
1954         * Scripts/webkitpy/port/ios.py:
1955         (IOSPort. child_processes): No reason to memoize this call, and it prevents
1956         overriding the number of child processes when booting custom devices.
1957
1958 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1959
1960         webkitpy: Generalize trailing SDK specifier (Part 2)
1961         https://bugs.webkit.org/show_bug.cgi?id=191275
1962         <rdar://problem/45703660>
1963
1964         Reviewed by Aakash Jain.
1965
1966         * Scripts/webkitpy/port/ios_device.py:
1967         (IOSDevicePort): Use normalized SDK.
1968         * Scripts/webkitpy/port/ios_simulator.py:
1969         (IOSSimulatorPort): Use normalized SDK.
1970         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1971
1972 2018-11-06  Justin Fan  <justin_fan@apple.com>
1973
1974         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1975         https://bugs.webkit.org/show_bug.cgi?id=191291
1976
1977         Reviewed by Myles Maxfield.
1978
1979         Properly disable WEBGPU on all non-Metal platforms for now.
1980
1981         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1982
1983 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1984
1985         [ews-app] Add URL configuration for OpenSource EWS Django app
1986         https://bugs.webkit.org/show_bug.cgi?id=191132
1987
1988         Rubber-stamped by Lucas Forschler.
1989
1990         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
1991         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
1992
1993 2018-11-06  Youenn Fablet  <youenn@apple.com>
1994
1995         Make mDNS ICE Candidate an experimental flag again
1996         https://bugs.webkit.org/show_bug.cgi?id=191262
1997
1998         Reviewed by Dean Jackson.
1999
2000         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2001         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2002         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2003         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
2004         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2005
2006 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2007
2008         [ews-app] Add views for OpenSource EWS Django app
2009         https://bugs.webkit.org/show_bug.cgi?id=191131
2010
2011         Rubber-stamped by Lucas Forschler.
2012
2013         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
2014         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2015         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
2016         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
2017
2018 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2019
2020         [ews-app] Add models for OpenSource EWS Django app
2021         https://bugs.webkit.org/show_bug.cgi?id=191123
2022
2023         Reviewed by Lucas Forschler.
2024
2025         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2026         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
2027         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
2028         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2029         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
2030
2031 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2032
2033         [ews-app] Fix Invalid HTTP_HOST header
2034         https://bugs.webkit.org/show_bug.cgi?id=191325
2035
2036         Reviewed by Lucas Forschler.
2037
2038         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
2039
2040         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2041
2042 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2043
2044         [ews-app] Rename EWS_app to ews-app - part 2
2045         https://bugs.webkit.org/show_bug.cgi?id=191317
2046
2047         Reviewed by Lucas Forschler.
2048
2049         * BuildSlaveSupport/ews-app/EWS_app: Removed.
2050         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
2051         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2052         * BuildSlaveSupport/ews-app/ews-app/urls.py:
2053         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
2054         * BuildSlaveSupport/ews-app/manage.py:
2055
2056 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews-app] Rename EWS_app to ews-app - part 1
2059         https://bugs.webkit.org/show_bug.cgi?id=191317
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * BuildSlaveSupport/EWS_app: Removed.
2064         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
2065
2066 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
2067
2068         Spelling dots are drawn in the wrong place
2069         https://bugs.webkit.org/show_bug.cgi?id=190764
2070
2071         Reviewed by Dean Jackson.
2072
2073         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
2074         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
2075         dots to be drawn.
2076
2077         * WebKitTestRunner/TestController.cpp:
2078         (WTR::TestController::resetStateToConsistentValues):
2079         (WTR::updateTestOptionsFromTestHeader):
2080         (WTR::TestController::platformResetStateToConsistentValues):
2081         * WebKitTestRunner/TestController.h:
2082         * WebKitTestRunner/TestOptions.h:
2083         (WTR::TestOptions::hasSameInitializationOptions const):
2084         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2085         (WTR::TestController::cocoaResetStateToConsistentValues):
2086         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2087         * WebKitTestRunner/ios/TestControllerIOS.mm:
2088         (WTR::TestController::platformResetStateToConsistentValues):
2089         * WebKitTestRunner/mac/TestControllerMac.mm:
2090         (WTR::TestController::platformResetStateToConsistentValues):
2091
2092 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
2093
2094         Feature flags not present for Visual Studio when using build-webkit
2095         https://bugs.webkit.org/show_bug.cgi?id=191288
2096
2097         Reviewed by Fujii Hironori.
2098
2099         Passes feature flags to Visual studio builds within build-webkit.
2100         Removes cmakeBasedPortArguments as it is no longer in use.
2101
2102         * Scripts/build-jsc:
2103         * Scripts/build-webkit:
2104         * Scripts/webkitdirs.pm:
2105         (cmakeBasedPortArguments): Deleted.
2106
2107 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
2108
2109         REGRESSION (r230523): Caps lock indicator not shown in password field
2110         https://bugs.webkit.org/show_bug.cgi?id=190056
2111
2112         Reviewed by Ryosuke Niwa.
2113
2114         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2116         (WTR::TestRunner::toggleCapsLock):
2117         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2118         * WebKitTestRunner/TestController.h:
2119         * WebKitTestRunner/TestInvocation.cpp:
2120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2121         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2122         (WTR::TestController::toggleCapsLock):
2123
2124 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
2125
2126         IndexedDB: WAL file keeps growing
2127         https://bugs.webkit.org/show_bug.cgi?id=191294
2128         <rdar://problem/41333493>
2129
2130         Reviewed by Chris Dumez.
2131
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
2134         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
2135         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
2136         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
2137         (TEST):
2138
2139 2018-11-06  Alex Christensen  <achristensen@webkit.org>
2140
2141         Fix tests after r237863
2142         https://bugs.webkit.org/show_bug.cgi?id=191315
2143
2144         Reviewed by Chris Dumez.
2145
2146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2147         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
2148         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
2149         to verify that main2.html eventually loads, making this test less timing dependent.
2150
2151 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
2152
2153         Unreviewed, rolling out r237834.
2154
2155         Tests for this change crash on iOS Simulator
2156
2157         Reverted changeset:
2158
2159         "Spelling dots are drawn in the wrong place"
2160         https://bugs.webkit.org/show_bug.cgi?id=190764
2161         https://trac.webkit.org/changeset/237834
2162
2163 2018-11-05  Alex Christensen  <achristensen@webkit.org>
2164
2165         [Mac] Implement safe browsing in WebKit
2166         https://bugs.webkit.org/show_bug.cgi?id=188871
2167
2168         Reviewed by Tim Horton.
2169
2170         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2171         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
2172         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
2173         (-[TestLookupContext lookUpURL:completionHandler:]):
2174         (simpleURL):
2175         (safeBrowsingView):
2176         (TEST):
2177         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
2178         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
2179         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
2180         * TestWebKitAPI/Utilities.h:
2181
2182 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
2183
2184         webkitpy: Generalize trailing SDK specifier (Part 1)
2185         https://bugs.webkit.org/show_bug.cgi?id=191275
2186         <rdar://problem/45703660>
2187
2188         Reviewed by Lucas Forschler.
2189
2190         * Scripts/webkitpy/common/system/platforminfo.py:
2191         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
2192         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2193         (TestPlatformInfo):
2194         (TestPlatformInfo.test_available_sdks):
2195
2196 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
2197
2198         Spelling dots are drawn in the wrong place
2199         https://bugs.webkit.org/show_bug.cgi?id=190764
2200
2201         Reviewed by Dean Jackson.
2202
2203         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
2204         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
2205         dots to be drawn.
2206
2207         * WebKitTestRunner/TestController.cpp:
2208         (WTR::TestController::resetStateToConsistentValues):
2209         (WTR::updateTestOptionsFromTestHeader):
2210         (WTR::TestController::platformResetStateToConsistentValues):
2211         * WebKitTestRunner/TestController.h:
2212         * WebKitTestRunner/TestOptions.h:
2213         (WTR::TestOptions::hasSameInitializationOptions const):
2214         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2215         (WTR::TestController::cocoaResetStateToConsistentValues):
2216         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2217         * WebKitTestRunner/ios/TestControllerIOS.mm:
2218         (WTR::TestController::platformResetStateToConsistentValues):
2219         * WebKitTestRunner/mac/TestControllerMac.mm:
2220         (WTR::TestController::platformResetStateToConsistentValues):
2221
2222 2018-11-05  Chris Dumez  <cdumez@apple.com>
2223
2224         Use same limit for page cache and suspended pages
2225         https://bugs.webkit.org/show_bug.cgi?id=191266
2226
2227         Reviewed by Geoffrey Garen.
2228
2229         Update API tests accordingly.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2232
2233 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2234
2235         [style] Exclude style check for auto generated files.
2236         https://bugs.webkit.org/show_bug.cgi?id=191118
2237
2238         Reviewed by Eric Carlson.
2239
2240         Some files checked in to the repository are generated by other tools. In this patch,
2241         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
2242         VisualStudio.
2243
2244         There's no need to check these files because it's not practical to fix the style errors
2245         or it's hard to maintain those fixes.
2246
2247         * Scripts/webkitpy/style/checkers/cpp.py:
2248         (is_generated_file):
2249         (CppChecker.check):
2250
2251 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2252
2253         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
2254         https://bugs.webkit.org/show_bug.cgi?id=190680
2255
2256         Reviewed by Philippe Normand.
2257
2258         * flatpak/org.webkit.WebKit.yaml:
2259
2260 2018-11-05  Daniel Bates  <dabates@apple.com>
2261
2262         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
2263         https://bugs.webkit.org/show_bug.cgi?id=191094
2264
2265         Reviewed by Andy Estes.
2266
2267         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
2268         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
2269         Document summary and add closing brace '}' to both Frame and Document summary strings to make
2270         them look pretty.
2271
2272         * lldb/lldb_webkit.py:
2273         (WebCoreFrame_SummaryProvider):
2274         (WebCoreDocument_SummaryProvider):
2275
2276 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2277
2278         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
2279         https://bugs.webkit.org/show_bug.cgi?id=191240
2280         <rdar://problem/44872806>
2281
2282         Reviewed by Tim Horton.
2283
2284         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
2285         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
2286         overriding `-[WKWebView inputAssistantItem]`.
2287
2288         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2289         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
2290         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
2291         (+[InputAssistantItemTestingWebView barButtonIcon]):
2292         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
2293         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
2294         (-[InputAssistantItemTestingWebView inputAssistantItem]):
2295         (TestWebKitAPI::TEST):
2296
2297 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2298
2299         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
2300         https://bugs.webkit.org/show_bug.cgi?id=191226
2301         <rdar://problem/45781765>
2302
2303         Reviewed by Tim Horton.
2304
2305         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
2306         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
2307
2308         * WebKitTestRunner/TestOptions.h:
2309         (WTR::TestOptions::hasSameInitializationOptions const):
2310
2311 2018-11-05  Commit Queue  <commit-queue@webkit.org>
2312
2313         Unreviewed, rolling out r237784 and r237788.
2314         https://bugs.webkit.org/show_bug.cgi?id=191270
2315
2316         Caused mediastream layout test failures (Requested by
2317         ryanhaddad on #webkit).
2318
2319         Reverted changesets:
2320
2321         "[MediaStream] User should not be prompted again after denying
2322         getDisplayMedia request"
2323         https://bugs.webkit.org/show_bug.cgi?id=191227
2324         https://trac.webkit.org/changeset/237784
2325
2326         "[MediaStream] User should not be prompted again after denying
2327         getDisplayMedia request"
2328         https://bugs.webkit.org/show_bug.cgi?id=191227
2329         https://trac.webkit.org/changeset/237788
2330
2331 2018-11-05  Lucas Forschler  <lforschler@apple.com>
2332
2333         https://bugs.webkit.org/show_bug.cgi?id=191268
2334         Remove unused bots.
2335
2336         rubber-stamped by Alexey Proskuryakov.
2337
2338         * BuildSlaveSupport/build.webkit.org-config/config.json:
2339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2340         (WebKitBuildbot):
2341
2342 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2343
2344         [WPE][GTK] API test runner fails to respect default build type
2345         https://bugs.webkit.org/show_bug.cgi?id=190247
2346
2347         Reviewed by Carlos Garcia Campos.
2348
2349         Problem is it's looking for a release build, even though I've run set-webkit-configuration
2350         --debug. It should look for a debug build unless I explicitly pass --release.
2351
2352         * glib/api_test_runner.py:
2353         (TestRunner.__init__):
2354
2355 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2356
2357         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
2358         https://bugs.webkit.org/show_bug.cgi?id=190674
2359
2360         Reviewed by Philippe Normand.
2361
2362         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
2363         it can use to implement encoding for different formats exposing a trimmed down unified API.
2364
2365         It also adds proper handling of H264 profiles.
2366
2367         The added files follow GStreamer coding style as we aim at upstreaming the element
2368         in the future.
2369
2370         Reviewed by Philippe Normand.
2371
2372         * Scripts/webkitpy/style/checker.py:
2373
2374 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2375
2376         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
2377         https://bugs.webkit.org/show_bug.cgi?id=191221
2378
2379         Reviewed by Carlos Garcia Campos.
2380
2381         This test ensures that MSE is disabled by default, but we now enable it by default, so
2382         reverse the semantics of the test.
2383
2384         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2385         (testWebKitSettings):
2386
2387 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2388
2389         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
2390         https://bugs.webkit.org/show_bug.cgi?id=191225
2391
2392         Reviewed by Alejandro G. Castro.
2393
2394         Fix a memory leak causing this test to fail.
2395
2396         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2397         (WebViewTest::initializeWebView):
2398
2399 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
2400
2401         [webkitpy] Support WPE in the run-web-platform-tests script
2402         https://bugs.webkit.org/show_bug.cgi?id=191183
2403
2404         Reviewed by Alex Christensen.
2405
2406         * Scripts/webkitpy/w3c/wpt_runner.py:
2407         (parse_args): Support `--wpe` as an argument that specifies WPE as the
2408         target port. Additionally, the `--display-server` flag now accepts
2409         `headless` as a valid value, enabling the WPE WebDriver to run in
2410         headless mode.
2411
2412 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2413
2414         [Win] Use C++14, not C++17
2415         https://bugs.webkit.org/show_bug.cgi?id=191101
2416
2417         Reviewed by Alex Christensen.
2418
2419         std::basic_string::data() returns a read-only const buffer in
2420         C++14.
2421
2422         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2423         (createString): Use std::vector instead of std::wstring.
2424         (createUTF8String): Use std::vector instead of std::string.
2425
2426 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2427
2428         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
2429         https://bugs.webkit.org/show_bug.cgi?id=191231
2430
2431         Reviewed by Simon Fraser.
2432
2433         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
2434         it can be shared between iOS-family and macOS platforms. See below for more details.
2435
2436         No change in behavior.
2437
2438         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2439         (WTR::UIScriptController::overridePreference):
2440
2441         Add a method stub for DumpRenderTree.
2442
2443         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2444         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2445         (WTR::UIScriptController::doAsyncTask):
2446         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2447
2448         Unify these method implementations.
2449
2450         (WTR::UIScriptController::removeViewFromWindow):
2451         (WTR::UIScriptController::addViewToWindow):
2452
2453         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
2454         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
2455         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
2456         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
2457
2458         (WTR::UIScriptController::overridePreference):
2459         (WTR::UIScriptController::findString):
2460         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
2461
2462         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
2463
2464         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2465         (WTR::UIScriptController::doAsyncTask): Deleted.
2466         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
2467         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
2468         (WTR::UIScriptController::findString): Deleted.
2469         (WTR::UIScriptController::removeViewFromWindow): Deleted.
2470         (WTR::UIScriptController::addViewToWindow): Deleted.
2471         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2472         (WTR::UIScriptController::doAsyncTask): Deleted.
2473         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
2474         (WTR::UIScriptController::overridePreference): Deleted.
2475         (WTR::UIScriptController::findString): Deleted.
2476         (WTR::UIScriptController::removeViewFromWindow): Deleted.
2477         (WTR::UIScriptController::addViewToWindow): Deleted.
2478         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
2479
2480 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
2481
2482         [MediaStream] User should not be prompted again after denying getDisplayMedia request
2483         https://bugs.webkit.org/show_bug.cgi?id=191227
2484         <rdar://problem/45784512>
2485
2486         Reviewed by Youenn Fablet.
2487
2488         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2489         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2490         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
2491         (TestWebKitAPI::TEST_F):
2492
2493 2018-11-04  Zalan Bujtas  <zalan@apple.com>
2494
2495         [LFC][BFC] Add support for percentage height in quirks mode.
2496         https://bugs.webkit.org/show_bug.cgi?id=191232
2497
2498         Reviewed by Antti Koivisto.
2499
2500         * LayoutReloaded/misc/LFC-passing-tests.txt:
2501
2502 2018-11-04  Zalan Bujtas  <zalan@apple.com>
2503
2504         [LFC][BCF] Add support for block level non-replaced inflow height percentage
2505         https://bugs.webkit.org/show_bug.cgi?id=191229
2506
2507         Reviewed by Antti Koivisto.
2508
2509         * LayoutReloaded/misc/LFC-passing-tests.txt:
2510
2511 2018-11-02  Zalan Bujtas  <zalan@apple.com>
2512
2513         [LFC][BFC] Resolve percentage height values.
2514         https://bugs.webkit.org/show_bug.cgi?id=191224
2515
2516         Reviewed by Antti Koivisto.
2517
2518         * LayoutReloaded/misc/LFC-passing-tests.txt:
2519
2520 2018-11-03  Alex Christensen  <achristensen@webkit.org>
2521
2522         Mac production builds should sign the network process xpc service with entitlements
2523         https://bugs.webkit.org/show_bug.cgi?id=191209
2524         <rdar://problem/45377609>
2525
2526         Reviewed by Geoff Garen.
2527
2528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2529         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
2530         (TEST):
2531
2532 2018-11-02  Alex Christensen  <achristensen@webkit.org>
2533
2534         Unreviewed, rolling out r237761.
2535
2536         Makes most API tests timeout and WK2 tests crash
2537
2538         Reverted changeset:
2539
2540         "Mac production builds should sign the network process xpc
2541         service with entitlements"
2542         https://bugs.webkit.org/show_bug.cgi?id=191209
2543         https://trac.webkit.org/changeset/237761
2544
2545 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2546
2547         Unreviewed API test gardening
2548
2549         * TestWebKitAPI/glib/TestExpectations.json:
2550
2551 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
2552
2553         Add new global object and preliminary Worklets support for CSS painting api
2554         https://bugs.webkit.org/show_bug.cgi?id=190979
2555
2556         Reviewed by Chris Dumez.
2557
2558         * Scripts/webkitpy/bindings/main.py:
2559         (BindingsTests.generate_supplemental_dependency):
2560         (BindingsTests.main):
2561
2562 2018-11-02  Alex Christensen  <achristensen@webkit.org>
2563
2564         Mac production builds should sign the network process xpc service with entitlements
2565         https://bugs.webkit.org/show_bug.cgi?id=191209
2566         <rdar://problem/45377609>
2567
2568         Reviewed by Geoff Garen.
2569
2570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2571         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
2572         (TEST):
2573
2574 2018-11-02  Lucas Forschler  <lforschler@apple.com>
2575
2576         Add Windows 10 archive bots
2577         https://bugs.webkit.org/show_bug.cgi?id=190964
2578         
2579         This Change updates the Apple Windows Buildbot configuration.
2580         - Add Windows 10 specific builders and testers for release and debug.
2581         - Refactor Windows -> Windows 7.
2582         - Remove Windows 7 Debug.
2583
2584         Reviewed by Aakash Jain.
2585
2586         * BuildSlaveSupport/build.webkit.org-config/config.json:
2587
2588 2018-11-02  Philippe Normand  <pnormand@igalia.com>
2589
2590         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
2591
2592         Rubber-stamped by Michael Catanzaro.
2593
2594         This variable is useful to get rid of shell color escapes in tests stderr files.
2595
2596         * Scripts/webkitpy/port/gtk.py:
2597         (GtkPort.setup_environ_for_server):
2598         * Scripts/webkitpy/port/wpe.py:
2599         (WPEPort.setup_environ_for_server):
2600
2601 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
2602
2603         Add Basic Django web app for OpenSource EWS
2604         https://bugs.webkit.org/show_bug.cgi?id=191091
2605
2606         Reviewed by Lucas Forschler.
2607
2608         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
2609         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
2610         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
2611         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
2612         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
2613         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
2614         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
2615         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
2616         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
2617         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
2618         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
2619         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
2620         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
2621         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
2622
2623 2018-11-02  Daniel Bates  <dabates@apple.com>
2624
2625         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2626         https://bugs.webkit.org/show_bug.cgi?id=190487
2627
2628         Reviewed by Tim Horton.
2629
2630         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
2631         match my observations when using the simulator to simulate iOS 12 and add support for testing
2632         right-hand side modifiers.
2633
2634         * DumpRenderTree/mac/EventSendingController.mm:
2635         (modifierFlags):
2636         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2637         (-[EventSendingController setTouchModifier:value:]):
2638         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2639         (hidUsageCodeForCharacter):
2640
2641 2018-11-02  Chris Dumez  <cdumez@apple.com>
2642
2643         [PSON] Reuse SuspendedPages' process when possible, for performance
2644         https://bugs.webkit.org/show_bug.cgi?id=191166
2645
2646         Reviewed by Geoffrey Garen.
2647
2648         Add API test coverage.
2649
2650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2651
2652 2018-11-02  Zalan Bujtas  <zalan@apple.com>
2653
2654         [LFC][IFC] Add support for intrinsic width calculation
2655         https://bugs.webkit.org/show_bug.cgi?id=191144
2656
2657         Reviewed by Antti Koivisto.
2658
2659         * LayoutReloaded/misc/LFC-passing-tests.txt:
2660
2661 2018-11-01  Philippe Normand  <pnormand@igalia.com>
2662
2663         [Apache] Self-signed SSL certificate RSA key is considered too weak
2664         https://bugs.webkit.org/show_bug.cgi?id=191156
2665
2666         Reviewed by Michael Catanzaro.
2667
2668         * Scripts/webkitpy/common/system/pemfile.py:
2669
2670 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
2671
2672         Unreviewed follow-up to r237678.
2673
2674         * wpe/jhbuild.modules: The patch element apparently has to be a child
2675         of the branch in order for Jhbuild to properly detect and apply the
2676         patch file.
2677
2678 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
2679
2680         build-jsc --wincairo should update WinCairo libraries
2681         https://bugs.webkit.org/show_bug.cgi?id=191170
2682
2683         Reviewed by Fujii Hironori.
2684
2685         * Scripts/build-jsc:
2686
2687 2018-11-01  John Wilander  <wilander@apple.com>
2688
2689         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
2690         https://bugs.webkit.org/show_bug.cgi?id=191119
2691         <rdar://problem/44176965>
2692
2693         Reviewed by Chris Dumez.
2694
2695         This is an API test for a WebKitLegacy WebView that is first closed and then
2696         JavaScript is handed a keyboard event.
2697
2698         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2699         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
2700         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
2701         (-[KeyboardEventListener handleEvent:]):
2702         (TestWebKitAPI::TEST):
2703
2704 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2705
2706         Add a storage limit for IndexedDB
2707         https://bugs.webkit.org/show_bug.cgi?id=190598
2708         <rdar://problem/44654715>
2709
2710         Reviewed by Chris Dumez.
2711
2712         Add API for testing.
2713
2714         * DumpRenderTree/TestRunner.cpp:
2715         (setIDBPerOriginQuotaCallback):
2716         (TestRunner::staticFunctions):
2717         * DumpRenderTree/TestRunner.h:
2718         * DumpRenderTree/mac/TestRunnerMac.mm:
2719         (TestRunner::setIDBPerOriginQuota):
2720         * DumpRenderTree/win/TestRunnerWin.cpp:
2721         (TestRunner::setIDBPerOriginQuota):
2722         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2724         (WTR::TestRunner::setIDBPerOriginQuota):
2725         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2726         * WebKitTestRunner/TestController.cpp:
2727         (WTR::TestController::setIDBPerOriginQuota):
2728         * WebKitTestRunner/TestController.h:
2729         * WebKitTestRunner/TestInvocation.cpp:
2730         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2731
2732 2018-11-01  Chris Dumez  <cdumez@apple.com>
2733
2734         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
2735         https://bugs.webkit.org/show_bug.cgi?id=191076
2736
2737         Reviewed by Geoffrey Garen.
2738
2739         Add API test coverage.
2740
2741         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2742         (-[PSONNavigationDelegate init]):
2743         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2744
2745 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
2746
2747         Fix build with VIDEO and WEB_AUDIO disabled
2748         https://bugs.webkit.org/show_bug.cgi?id=191147
2749         <rdar://problem/45726710>
2750
2751         Unreviewed build fix.
2752
2753         This adds the missing compilation guards in the WPE MiniBrowser.
2754
2755         * MiniBrowser/wpe/main.cpp:
2756         (main): Condition GST includes and calls.
2757
2758 2018-10-31  Zalan Bujtas  <zalan@apple.com>
2759
2760         [LFC][IFC] Add support for inline-block elements.
2761         https://bugs.webkit.org/show_bug.cgi?id=191143
2762
2763         Reviewed by Antti Koivisto.
2764
2765         * LayoutReloaded/misc/LFC-passing-tests.txt:
2766
2767 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2768
2769         [WPE] Add missing libsoup patch to jhbuild
2770         https://bugs.webkit.org/show_bug.cgi?id=191149
2771
2772         Reviewed by Žan Doberšek.
2773
2774         * wpe/jhbuild.modules:
2775         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2776
2777 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
2778
2779         Fix build with VIDEO and WEB_AUDIO disabled
2780         https://bugs.webkit.org/show_bug.cgi?id=191147
2781
2782         Reviewed by Philippe Normand.
2783
2784         * MiniBrowser/gtk/main.c:
2785         (main): Condition GST includes and calls
2786
2787 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
2788
2789         Add Justin Michaud to the list of WebKit Committers
2790         https://bugs.webkit.org/show_bug.cgi?id=191142
2791
2792         * Scripts/webkitpy/common/config/contributors.json:
2793
2794 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
2795
2796         Don't run JIT tests on 32-bit platforms
2797         https://bugs.webkit.org/show_bug.cgi?id=191074
2798
2799         Reviewed by Michael Catanzaro.
2800
2801         * Scripts/run-jsc-stress-tests:
2802
2803 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2804
2805         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
2806         https://bugs.webkit.org/show_bug.cgi?id=190530
2807         <rdar://problem/45232149>
2808
2809         Reviewed by Tim Horton.
2810
2811         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
2812         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
2813         is equivalent to the original file wrappers used to insert attachments in the first web view.
2814
2815         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
2816         is still backed by the same NSFileWrapper instance.
2817
2818         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2819         (TestWebKitAPI::TEST):
2820
2821 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2822
2823         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
2824         https://bugs.webkit.org/show_bug.cgi?id=190949
2825
2826         Reviewed by Alex Christensen.
2827
2828         Visual Studio 2017 Community is the alternative.
2829
2830         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
2831         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
2832         (buildVisualStudioProject): Ditto.
2833         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
2834         (usingVisualStudioExpress): Deleted.
2835
2836 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2837
2838         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2839         https://bugs.webkit.org/show_bug.cgi?id=191093
2840         <rdar://problem/45685706>
2841
2842         Unreviewed build fix.
2843
2844         error C2065: 'renderTarget': undeclared identifier
2845
2846         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2847         (createBitmapContextFromWebView): Restored the previous implementation.
2848
2849 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
2850
2851         [PlayStation] Enable JavaScriptCore
2852         https://bugs.webkit.org/show_bug.cgi?id=191072
2853
2854         Reviewed by Brent Fulgham.
2855
2856         Add platform scripts for building the PlayStation port.
2857         perl Tools/Scripts/build-webkit --playstation
2858
2859         * Scripts/build-webkit:
2860         * Scripts/build-webkittestrunner:
2861         * Scripts/webkitdirs.pm:
2862         (argumentsForConfiguration):
2863         (determineConfigurationProductDir):
2864         (isPlayStation): Added.
2865         (getMSBuildPlatformArgument): Added.
2866         (buildVisualStudioProject):
2867         (wrapperPrefixIfNeeded):
2868         (generateBuildSystemFromCMakeProject):
2869         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
2870
2871 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
2872
2873         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2874         https://bugs.webkit.org/show_bug.cgi?id=191093
2875         <rdar://problem/45685706>
2876
2877         Reviewed by Alex Christensen.
2878
2879         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
2880         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
2881         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
2882         (pixelDumpSystemFactory): Added.
2883         (printPNG): Create stub.
2884         (computeMD5HashStringForBitmapContext): Ditto.
2885         (dumpBitmap): Ditto.
2886         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
2887         (BitmapContext::createByAdoptingBitmapAndContext):
2888         (BitmapContext::~BitmapContext):
2889         (BitmapContext::platformContext const):
2890         (BitmapContext::BitmapContext):
2891         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2892         (createBitmapContextFromWebView): Update to support Direct2D.
2893         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
2894         logo is no longer available at this location. Switch to the new logo.
2895
2896 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
2897
2898         webkitpy: Support alternate simctl list outputs
2899         https://bugs.webkit.org/show_bug.cgi?id=191090
2900         <rdar://problem/45684255>
2901
2902         Rubber-stamped by Aakash Jain.
2903
2904         * Scripts/webkitpy/xcode/simulated_device.py:
2905         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
2906         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
2907         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2908         (test_available_devices): Add iOS 12 with alternative availability format.
2909
2910 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2911
2912         Clean up some obsolete MAX_ALLOWED macros
2913         https://bugs.webkit.org/show_bug.cgi?id=190916
2914
2915         Reviewed by Tim Horton.
2916
2917         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2918         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2919         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2920
2921 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
2922
2923         [GTK][WPE] Fixes to the PublicSuffix implementation
2924         https://bugs.webkit.org/show_bug.cgi?id=191031
2925
2926         Reviewed by Michael Catanzaro.
2927
2928         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2929         (TestWebKitAPI::TEST_F): Remove a test for a domain
2930         that is not registrable and shouldn't be tested there.
2931
2932 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2933
2934         Modernize WebKit nibs and lprojs for localization's sake
2935         https://bugs.webkit.org/show_bug.cgi?id=190911
2936         <rdar://problem/45349466>
2937
2938         Reviewed by Dan Bernstein.
2939
2940         * Scripts/check-inspector-strings:
2941         * Scripts/update-webkit-localizable-strings:
2942         * gtk/manifest.txt.in:
2943         * wpe/manifest.txt.in:
2944         English->en
2945
2946 2018-10-29  Daniel Bates  <dabates@apple.com>
2947
2948         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
2949         https://bugs.webkit.org/show_bug.cgi?id=191036
2950
2951         Reviewed by Andy Estes.
2952
2953         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
2954         by an enum that contains two or more enumerators with the same value. For example, suppose
2955         you have the following enum:
2956
2957         enum Flag {
2958             A = 1 << 0,
2959             AAlias = A,
2960         };
2961
2962         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
2963         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
2964         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
2965         tend to be used in bounds checks as opposed to code that adds to a set.
2966
2967         * lldb/lldbWebKitTester/main.cpp:
2968         (testSummaryProviders):
2969         * lldb/lldb_webkit.py:
2970         (WTFOptionSetProvider.update):
2971         * lldb/lldb_webkit_unittest.py:
2972         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
2973         (TestSummaryProviders):
2974         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
2975
2976 2018-10-29  Daniel Bates  <dabates@apple.com>
2977
2978         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
2979         https://bugs.webkit.org/show_bug.cgi?id=191033
2980
2981         Reviewed by Andy Estes.
2982
2983         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
2984         We display the same details in the summary for a Frame because its Document tends to be the most
2985         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
2986         and whether the origin has universal access.
2987
2988         * lldb/lldb_webkit.py:
2989         (__lldb_init_module):
2990         Register new summary providers.
2991
2992         (WebCoreSecurityOrigin_SummaryProvider):
2993         (WebCoreFrame_SummaryProvider):
2994         (WebCoreDocument_SummaryProvider):
2995         Add new summary providers.
2996
2997         (StdOptionalWrapper):
2998         (StdOptionalWrapper.__init__):
2999         (StdOptionalWrapper.has_value):
3000         (StdOptionalWrapper.value):
3001         Convenience data type that provides access to the fields of a std::optional<>.
3002         
3003         (WebCoreSecurityOriginProvider):
3004         (WebCoreSecurityOriginProvider.__init__):
3005         (WebCoreSecurityOriginProvider.is_unique):
3006         (WebCoreSecurityOriginProvider.scheme):
3007         (WebCoreSecurityOriginProvider.host):
3008         (WebCoreSecurityOriginProvider.port):
3009         (WebCoreSecurityOriginProvider.domain):
3010         (WebCoreSecurityOriginProvider.has_universal_access):
3011         (WebCoreSecurityOriginProvider.to_string):
3012         (WebCoreFrameProvider):
3013         (WebCoreFrameProvider.__init__):
3014         (WebCoreFrameProvider.is_main_frame):
3015         (WebCoreFrameProvider.document):
3016         (WebCoreDocumentProvider):
3017         (WebCoreDocumentProvider.__init__):
3018         (WebCoreDocumentProvider.url):
3019         (WebCoreDocumentProvider.origin):
3020         (WebCoreDocumentProvider.page_cache_state):
3021         (WebCoreDocumentProvider.frame):
3022
3023 2018-10-29  Chris Dumez  <cdumez@apple.com>
3024
3025         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
3026         https://bugs.webkit.org/show_bug.cgi?id=190975
3027         <rdar://problem/45059256>
3028
3029         Reviewed by Antti Koivisto.
3030
3031         Add API test coverage.
3032
3033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3034
3035 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3036
3037         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
3038         https://bugs.webkit.org/show_bug.cgi?id=191018
3039
3040         Reviewed by Antti Koivisto.
3041
3042         * LayoutReloaded/misc/LFC-passing-tests.txt:
3043
3044 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3045
3046         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
3047         https://bugs.webkit.org/show_bug.cgi?id=191011
3048
3049         Reviewed by Antti Koivisto.
3050
3051         * LayoutReloaded/misc/LFC-passing-tests.txt:
3052
3053 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3054
3055         Missing from r237549
3056
3057         Reviewed by Antti Koivisto.
3058
3059         * LayoutReloaded/misc/LFC-passing-tests.txt:
3060
3061 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3062
3063         [LFC][IFC] Add support for simple intruding floats.
3064         https://bugs.webkit.org/show_bug.cgi?id=190998
3065
3066         Reviewed by Antti Koivisto.
3067
3068         * LayoutReloaded/misc/LFC-passing-tests.txt:
3069
3070 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3071
3072         [LFC][IFC] Inline layout produces separate runs when float is present.
3073         https://bugs.webkit.org/show_bug.cgi?id=190980
3074
3075         Reviewed by Antti Koivisto.
3076
3077         * LayoutReloaded/misc/LFC-passing-tests.txt:
3078
3079 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
3080
3081         New bytecode format for JSC
3082         https://bugs.webkit.org/show_bug.cgi?id=187373
3083         <rdar://problem/44186758>
3084
3085         Reviewed by Filip Pizlo.
3086
3087         Do not force ENABLE_JIT=true when $forceCLoop is false.
3088
3089         * Scripts/build-jsc:
3090
3091 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
3092
3093         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
3094
3095         Unreviewed build fix
3096
3097         The build fails because of some array-bound check related
3098         to strcmp() macro optimizations. Disabling selective Werrors
3099         when building xserver-xorg might get past this.
3100
3101         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
3102         configuration.
3103
3104 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
3105
3106         [GTK] Update API test expectations after r237383
3107         https://bugs.webkit.org/show_bug.cgi?id=186913
3108
3109         Unreviewed gardening.
3110
3111         * TestWebKitAPI/glib/TestExpectations.json: Remove
3112         passing TestSSL tests.
3113
3114 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
3115
3116         [WPE] Add the WebKitVersion.h header
3117         https://bugs.webkit.org/show_bug.cgi?id=191015
3118
3119         Reviewed by Michael Catanzaro.
3120
3121         * MiniBrowser/wpe/main.cpp:
3122         (automationStartedCallback): Remove the FIXME and finally enable the
3123         webkit_application_info_set_version() call.
3124         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
3125         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
3126
3127 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3128
3129         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
3130         https://bugs.webkit.org/show_bug.cgi?id=190948
3131
3132         Reviewed by Brent Fulgham.
3133
3134         vcxproj files have been removed in Bug 154388.
3135
3136         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
3137         * Scripts/build-jsc:
3138         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
3139         which is not used because Windows ports are using CMake.
3140
3141 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
3142
3143         HashMap should support selecting a random entry
3144         https://bugs.webkit.org/show_bug.cgi?id=190814
3145
3146         Reviewed by Ryosuke Niwa.
3147
3148         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
3149         IsEvenlyDistributed to reflect the fact that we're only testing the
3150         distribution. Added a test case that covers more table densities and
3151         the remove() operation.
3152
3153 2018-10-27  Charlie Turner  <cturner@igalia.com>
3154
3155         [GTK] Add bubblewrap feature option
3156         https://bugs.webkit.org/show_bug.cgi?id=190981
3157
3158         Reviewed by Xabier Rodriguez-Calvar.
3159
3160         Without this, it was not possible to disable the bubblewrap sandbox
3161         from the webkit build scripts.
3162
3163         * Scripts/webkitperl/FeatureList.pm:
3164
3165 2018-10-26  Commit Queue  <commit-queue@webkit.org>
3166
3167         Unreviewed, rolling out r237479 and r237484.
3168         https://bugs.webkit.org/show_bug.cgi?id=190978
3169
3170         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
3171
3172         Reverted changesets:
3173
3174         "New bytecode format for JSC"
3175         https://bugs.webkit.org/show_bug.cgi?id=187373
3176         https://trac.webkit.org/changeset/237479
3177
3178         "Gardening: Build fix after r237479."
3179         https://bugs.webkit.org/show_bug.cgi?id=187373
3180         https://trac.webkit.org/changeset/237484
3181
3182 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
3183
3184         New bytecode format for JSC
3185         https://bugs.webkit.org/show_bug.cgi?id=187373
3186         <rdar://problem/44186758>
3187
3188         Reviewed by Filip Pizlo.
3189
3190         Do not force ENABLE_JIT=true when $forceCLoop is false.
3191
3192         * Scripts/build-jsc:
3193
3194 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
3195
3196         HashMap should support selecting a random entry
3197         https://bugs.webkit.org/show_bug.cgi?id=190814
3198
3199         Reviewed by Antti Koivisto.
3200
3201         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
3202         more thoroughly test for randomness.
3203
3204 2018-10-26  Antti Koivisto  <antti@apple.com>
3205
3206         hashSet.remove(hashSet.random()) doesn't build
3207         https://bugs.webkit.org/show_bug.cgi?id=190953
3208
3209         Reviewed by Chris Dumez.
3210
3211         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3212         (TestWebKitAPI::TEST):
3213
3214 2018-10-26  Zalan Bujtas  <zalan@apple.com>
3215
3216         [LFC][IFC] Layout floats as part of the inline content
3217         https://bugs.webkit.org/show_bug.cgi?id=190942
3218
3219         Reviewed by Antti Koivisto.
3220
3221         * LayoutReloaded/misc/LFC-passing-tests.txt:
3222
3223 2018-10-26  Alicia Boya García  <aboya@igalia.com>
3224
3225         [MSE][WTF][Media] Invalid MediaTime should be falsy
3226         https://bugs.webkit.org/show_bug.cgi?id=190893
3227
3228         Reviewed by Jer Noble.
3229
3230         This patch adds additional API tests for the conversions from
3231         MediaTime to boolean.
3232
3233         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3234         (TestWebKitAPI::TEST):
3235
3236 2018-10-25  Chris Dumez  <cdumez@apple.com>
3237
3238         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
3239         https://bugs.webkit.org/show_bug.cgi?id=190915
3240         <rdar://problem/45059069>
3241
3242         Reviewed by Geoffrey Garen.
3243
3244         Add API test coverage.
3245
3246         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3247
3248 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
3249
3250         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
3251         https://bugs.webkit.org/show_bug.cgi?id=190896
3252
3253         Reviewed by Matt Baker.
3254
3255         * Scripts/webkitpy/common/config/watchlist:
3256
3257 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
3258
3259         HashMap should support selecting a random entry
3260         https://bugs.webkit.org/show_bug.cgi?id=190814
3261
3262         Reviewed by Antti Koivisto.
3263
3264         Unit testing is fun and easy!
3265
3266         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3267         (TestWebKitAPI::ZeroHash::hash):
3268         (TestWebKitAPI::TEST):
3269
3270 2018-10-24  Tim Horton  <timothy_horton@apple.com>
3271
3272         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
3273         https://bugs.webkit.org/show_bug.cgi?id=190897
3274
3275         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3276         (TestWebKitAPI::TEST):
3277         Disable the test for now.
3278
3279 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
3280
3281         Clean up some obsolete macOS version guards
3282         https://bugs.webkit.org/show_bug.cgi?id=190887
3283
3284         Reviewed by Dan Bernstein.
3285
3286         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3287         (__simulated_forceClickAssociatedEventsMask):
3288         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
3289         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3290         (WTR::initializeWebViewConfiguration):
3291         * WebKitTestRunner/mac/EventSenderProxy.mm:
3292         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3293
3294 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
3295
3296         Turn on Conic Gradients
3297         https://bugs.webkit.org/show_bug.cgi?id=190810
3298
3299         Reviewed by Tim Horton.
3300
3301         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3302
3303 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
3304
3305         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
3306         https://bugs.webkit.org/show_bug.cgi?id=190328
3307
3308         Reviewed by Michael Catanzaro.
3309
3310         * TestWebKitAPI/CMakeLists.txt:
3311         * TestWebKitAPI/PlatformWPE.cmake:
3312
3313 2018-10-24  Chris Dumez  <cdumez@apple.com>
3314
3315         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
3316         https://bugs.webkit.org/show_bug.cgi?id=190846
3317         <rdar://problem/45058938>
3318
3319         Reviewed by Antti Koivisto.
3320
3321         Add API test coverage.
3322
3323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3324
3325 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
3326
3327         [GTK] TestSSL failing because of missing libsoup patch
3328         https://bugs.webkit.org/show_bug.cgi?id=190869
3329
3330         Reviewed by Michael Catanzaro.
3331
3332         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
3333         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
3334
3335 2018-10-23  Justin Fan  <justin_fan@apple.com>
3336
3337         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
3338         https://bugs.webkit.org/show_bug.cgi?id=190817
3339
3340         Reviewed by Dean Jackson.
3341
3342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3343         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
3344         (TestWebKitAPI::TEST_F):
3345         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
3346         (TestWebKitAPI::TEST_F):
3347         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
3348         (TestWebKitAPI::TEST_F):
3349         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
3350         (TestWebKitAPI::TEST_F):
3351         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
3352         (TestWebKitAPI::TEST_F):
3353         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
3354
3355 2018-10-23  Chris Dumez  <cdumez@apple.com>
3356
3357         [PSON] Add support for cross-site client-side redirects
3358         https://bugs.webkit.org/show_bug.cgi?id=190806
3359         <rdar://problem/45047344>
3360
3361         Reviewed by Geoffrey Garen.
3362
3363         Add API test coverage.
3364
3365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3366         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
3367         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
3368
3369 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
3370
3371         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
3372         https://bugs.webkit.org/show_bug.cgi?id=190789
3373
3374         Reviewed by Michael Catanzaro.
3375
3376         When the network process serializes certificate data to other
3377         processes through the argument coders, the certificate chain, if
3378         present, is lost. In practice this means that applications using
3379         the public API to process certificate info have no details on the
3380         certificate chain, other than the very basics included in the
3381         certificate. Serialize the entire chain if available in the
3382         certificate.
3383
3384         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3385         (testSSL): Test that the self-signed certificate has no bogus
3386         issuer certificate.
3387
3388 2018-10-22  Tim Horton  <timothy_horton@apple.com>
3389
3390         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
3391         https://bugs.webkit.org/show_bug.cgi?id=190801
3392         <rdar://problem/43674361>
3393
3394         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
3395         (TEST):
3396         Use a parented WKWebView for this test, otherwise none of the assertions
3397         about gesture recognizers work anymore.
3398
3399 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
3400
3401         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
3402         https://bugs.webkit.org/show_bug.cgi?id=187972
3403
3404         Unreviewed test gardening.
3405
3406         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3407         (TestWebKitAPI::TEST): Disable the flaky test.
3408
3409 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3410
3411         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
3412         https://bugs.webkit.org/show_bug.cgi?id=190777
3413
3414         Reviewed by Tim Horton.
3415
3416         Implement isShowingDataListSuggestions on iOS. See below for more details.
3417
3418         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3419         (WTR::UIScriptController::isShowingDataListSuggestions const):
3420
3421         Add a stub implementation for DumpRenderTree.
3422
3423         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3424         (WTR::UIScriptController::isShowingDataListSuggestions const):
3425
3426         Move this stub implementation to !PLATFORM(COCOA).
3427
3428         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3429         (WTR::forEachViewInHierarchy):
3430
3431         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
3432
3433         (WTR::UIScriptController::isShowingDataListSuggestions const):
3434
3435         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
3436
3437 2018-10-19  Dan Bernstein  <mitz@apple.com>
3438
3439         [macOS] MiniBrowser has an unused injected bundle
3440         https://bugs.webkit.org/show_bug.cgi?id=190770
3441
3442         Reviewed by Tim Horton.
3443
3444         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
3445         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
3446           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
3447         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
3448         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
3449         * MiniBrowser/mac/Bundle: Removed.
3450
3451 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3452
3453         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
3454         https://bugs.webkit.org/show_bug.cgi?id=190621
3455         <rdar://problem/45310649>
3456
3457         Reviewed by Tim Horton.
3458
3459         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
3460
3461         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3462         (WTR::UIScriptController::resignFirstResponder):
3463         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3464         (WTR::UIScriptController::resignFirstResponder):
3465         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3466         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3467         (WTR::UIScriptController::resignFirstResponder):
3468         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3469         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3470         (WTR::UIScriptController::resignFirstResponder):
3471         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3472         (WTR::PlatformWebView::makeWebViewFirstResponder):
3473
3474         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
3475         responder on the WKWebView when running iOS layout tests.
3476
3477         * WebKitTestRunner/ios/TestControllerIOS.mm:
3478         (WTR::TestController::platformResetStateToConsistentValues):
3479
3480         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
3481
3482 2018-10-19  Dean Jackson  <dino@apple.com>
3483
3484         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
3485         https://bugs.webkit.org/show_bug.cgi?id=186946
3486         <rdar://problem/41724248>
3487
3488         Reviewed by Antoine Quint.
3489
3490         If the incoming test has different enableWebAnimationsCSSIntegration options,
3491         then we need to create a new WebView.
3492
3493         * DumpRenderTree/TestOptions.cpp:
3494         (TestOptions::webViewIsCompatibleWithOptions const):
3495
3496 2018-10-19  Charlie Turner  <cturner@igalia.com>
3497
3498         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
3499         https://bugs.webkit.org/show_bug.cgi?id=190738
3500
3501         Reviewed by Xabier Rodriguez-Calvar.
3502
3503         Add a GStreamer patch to avoid crashing when the run-time logging
3504         level is TRACE. There was a missing null check which caused many
3505         tests to crash.
3506
3507         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
3508
3509 2018-10-18  Alicia Boya García  <aboya@igalia.com>
3510
3511         [Media] Use nanoseconds as MaximumTimeScale
3512         https://bugs.webkit.org/show_bug.cgi?id=190631
3513
3514         Rebased MediaTime tests covering timescales over the maximum.
3515
3516         Reviewed by Jer Noble.
3517
3518         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3519         (TestWebKitAPI::TEST):
3520
3521 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
3522
3523         clean-webkit pulls in many unnecessary dependencies in webkitpy
3524         https://bugs.webkit.org/show_bug.cgi?id=190732
3525
3526         Reviewed by Alexey Proskuryakov.
3527
3528         * Scripts/webkitpy/common/host.py:
3529         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
3530         (Host):
3531         (Host.bugs):
3532         (Host.bugzilla):
3533         (Host.web):
3534
3535 2018-10-18  Chris Dumez  <cdumez@apple.com>
3536
3537         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
3538         https://bugs.webkit.org/show_bug.cgi?id=190721
3539         <rdar://problem/45059699>
3540
3541         Reviewed by Alex Christensen.
3542
3543         Add API test coverage.
3544
3545         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3546
3547 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
3548
3549         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
3550         https://bugs.webkit.org/show_bug.cgi?id=190729
3551
3552         Reviewed by Tim Horton.
3553
3554         * DumpRenderTree/AccessibilityController.h:
3555         * DumpRenderTree/AccessibilityTextMarker.h:
3556         * DumpRenderTree/AccessibilityUIElement.cpp:
3557         (AccessibilityUIElement::getJSClass):
3558         * DumpRenderTree/AccessibilityUIElement.h:
3559         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
3560         * DumpRenderTree/TestRunner.cpp:
3561         (getSecureEventInputIsEnabledCallback):
3562         (TestRunner::staticFunctions):
3563         (TestRunner::callUIScriptCallback):
3564         * DumpRenderTree/TestRunner.h:
3565         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3566         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
3567         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3568         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
3569         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
3570         * DumpRenderTree/ios/TextInputControllerIOS.m:
3571         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3572         * DumpRenderTree/mac/AppleScriptController.m:
3573         * DumpRenderTree/mac/DumpRenderTree.mm:
3574         (createWebViewAndOffscreenWindow):
3575         (destroyWebViewAndOffscreenWindow):
3576         (resetWebPreferencesToConsistentValues):
3577         (setDefaultsToConsistentValuesForTesting):
3578         (allocateGlobalControllers):
3579         (releaseGlobalControllers):
3580         (addTestPluginsToPluginSearchPath):
3581         (prepareConsistentTestingEnvironment):
3582         (dumpRenderTree):
3583         (DumpRenderTreeMain):
3584         (dumpFrameAsPDF):
3585         (dumpBackForwardListForAllWindows):
3586         (updateDisplay):
3587         (dump):
3588         (resetWebViewToConsistentStateBeforeTesting):
3589         (runTest):
3590         (displayWebView):
3591         (displayAndTrackRepaintsWebView):
3592         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3593         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3594         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3595         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3596         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3597         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3598         (-[DumpRenderTreeWindow close]):
3599         (-[DumpRenderTreeWindow webView]):
3600         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
3601         * DumpRenderTree/mac/EventSendingController.h:
3602         * DumpRenderTree/mac/EventSendingController.mm:
3603         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3604         (+[EventSendingController webScriptNameForSelector:]):
3605         (-[EventSendingController dealloc]):
3606         (-[EventSendingController currentEventTime]):
3607         (-[EventSendingController clearKillRing]):
3608         (modifierFlags):
3609         (-[EventSendingController mouseDown:withModifiers:]):
3610         (-[EventSendingController scalePageBy:atX:andY:]):
3611         (-[EventSendingController mouseUp:withModifiers:]):
3612         (-[EventSendingController mouseMoveToX:Y:]):
3613         (-[EventSendingController mouseScrollByX:andY:continuously:]):
3614         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3615         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3616         (-[FrameLoadDelegate init]):
3617         (-[FrameLoadDelegate dealloc]):
3618         (-[FrameLoadDelegate processWork:]):
3619         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3620         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3621         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3622         * DumpRenderTree/mac/LayoutTestHelper.m:
3623         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3624         (-[MockGeolocationProvider timerFired]):
3625         * DumpRenderTree/mac/TestRunnerMac.mm:
3626         (TestRunner::setMainFrameIsFirstResponder):
3627         (TestRunner::setAutomaticLinkDetectionEnabled):
3628         (TestRunner::setUseDashboardCompatibilityMode):
3629         (TestRunner::isCommandEnabled):
3630         (TestRunner::inspectorTestStubURL):
3631         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3632         (TestRunner::abortModal):
3633         (TestRunner::setTextDirection):
3634         (TestRunner::addChromeInputField):
3635         (TestRunner::removeChromeInputField):
3636         (TestRunner::focusWebView):
3637         (TestRunner::setBackingScaleFactor):
3638         (TestRunner::imageCountInGeneralPasteboard const):
3639         * DumpRenderTree/mac/UIDelegate.h:
3640         * DumpRenderTree/mac/UIDelegate.mm:
3641         (-[UIDelegate modalWindowWillClose:]):
3642         (-[UIDelegate webViewRunModal:]):
3643         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
3644         (-[UIDelegate dealloc]):
3645         * Scripts/check-for-inappropriate-objc-class-names:
3646         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3647         * TestRunnerShared/spi/UIKitTestSPI.h:
3648         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
3649         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
3650         (WebCore::operator<<):
3651         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3652         (TestWebKitAPI::TEST):
3653         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3654         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
3655         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
3656         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
3657         (TestWebKitAPI::TEST):
3658         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
3659         (TestWebKitAPI::TEST):
3660         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
3661         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3662         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
3663         (TEST):
3664         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
3665         (TEST):
3666         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
3667         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
3668         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
3669         (TEST):
3670         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
3671         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
3672         (createWebViewWithCustomPasteboardDataEnabled):
3673         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
3674         (TEST):
3675         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
3676         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
3677         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3678         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3679         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
3680         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
3681         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3682         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
3683         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
3684         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3685         (defaultWebsiteCacheDirectory):
3686         (defaultApplicationCacheDirectory):
3687         (TEST):
3688         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
3689         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
3690         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
3691         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3692         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3693         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3694         (TestWebKitAPI::TEST):
3695         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
3696         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3697         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
3698         (runTestWithWidth):
3699         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
3700         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
3701         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3702         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
3703         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3704         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
3705         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3706         (platformCopyRichTextWithMultipleAttachments):
3707         (platformCopyRichTextWithImage):
3708         (platformCopyPNG):
3709         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3710         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
3711         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3712         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
3713         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3714         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
3715         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3716         (TEST):
3717         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3718         (TEST):
3719         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3720         (TEST):
3721         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
3722         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3723         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
3724         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
3725         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3726         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3727         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3728         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3729         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3730         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
3731         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
3732         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
3733         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
3734         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3735         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3736         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
3737         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3738         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
3739         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
3740         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3741         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
3742         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3743         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3744         (-[WKWebView _test_waitForDidFinishNavigation]):
3745         * TestWebKitAPI/cocoa/TestWKWebView.h:
3746         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3747         * TestWebKitAPI/config.h:
3748         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3749         * TestWebKitAPI/ios/TestWKWebViewController.h:
3750         * TestWebKitAPI/ios/TestWKWebViewController.mm:
3751         * TestWebKitAPI/ios/UIKitSPI.h:
3752         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3753         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3754         (WTR::InjectedBundle::beginTesting):
3755         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3756         (WTR::TestRunner::inspectorTestStubURL):
3757         * WebKitTestRunner/TestController.cpp:
3758         (WTR::TestController::webProcessName):
3759         (WTR::TestController::networkProcessName):
3760         * WebKitTestRunner/TestInvocation.cpp:
3761         (WTR::TestInvocation::invoke):
3762         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3763         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3764         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3765         (WTR::initializeWebViewConfiguration):
3766         (WTR::TestController::platformCreateWebView):
3767         (WTR::TestController::imageCountInGeneralPasteboard const):
3768         (WTR::TestController::addTestKeyToKeychain):
3769         (WTR::TestController::cleanUpKeychain):
3770         (WTR::TestController::keyExistsInKeychain):
3771         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3772         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3773         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3774
3775 2018-10-18  Chris Dumez  <cdumez@apple.com>
3776
3777         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
3778         https://bugs.webkit.org/show_bug.cgi?id=190688
3779         <rdar://problem/45354095>
3780
3781         Reviewed by Antti Koivisto.
3782
3783         Extended API test coverage to confirm that:
3784         - We do not accumulate more than 3 suspended processes.
3785         - We can navigate back 3 times and use the page cache for each of these loads.
3786
3787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3788
3789 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3790
3791         Enable the datalist element by default on iOS and macOS
3792         https://bugs.webkit.org/show_bug.cgi?id=190594
3793         <rdar://problem/45281159>
3794
3795         Reviewed by Ryosuke Niwa and Tim Horton.
3796
3797         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3798
3799 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
3800
3801         AX: Certain tags should identify their context to iOS API
3802         https://bugs.webkit.org/show_bug.cgi?id=190622
3803         <rdar://problem/45308194>
3804
3805         Reviewed by Zalan Bujtas.
3806
3807         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3808         (AccessibilityUIElement::stringAttributeValue):
3809         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3810         (WTR::AccessibilityUIElement::stringAttributeValue):
3811
3812 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
3813
3814         Add a switch for Web SQL
3815         https://bugs.webkit.org/show_bug.cgi?id=190271
3816
3817         Reviewed by Ryosuke Niwa.
3818
3819         * WebKitTestRunner/TestController.cpp:
3820         (WTR::TestController::resetPreferencesToConsistentValues):
3821
3822 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3823
3824         Remove InjectedBundleBackForwardList
3825         https://bugs.webkit.org/show_bug.cgi?id=190640
3826
3827         Reviewed by Chris Dumez.
3828
3829         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3830         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
3831         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3832         (WTR::InjectedBundlePage::prepare):
3833         (WTR::InjectedBundlePage::dumpHistory):
3834         (WTR::hasPrefix): Deleted.
3835         (WTR::compareByTargetName): Deleted.
3836         (WTR::dumpBackForwardListItem): Deleted.
3837         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
3838         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3840         (WTR::TestRunner::clearBackForwardList):
3841
3842 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
3843
3844         Unreviewed, added myself to contributors.json.
3845
3846         * Scripts/webkitpy/common/config/contributors.json:
3847
3848 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3849
3850         Implement feature flag and bindings for CSS Painting API
3851         https://bugs.webkit.org/show_bug.cgi?id=190237
3852
3853         Reviewed by Ryosuke Niwa.
3854
3855         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3856
3857 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3858
3859         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
3860
3861         * gstreamer/jhbuild.modules:
3862
3863 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3864
3865         [GTK][JHBuild] Disable libmount support in glib
3866
3867         Rubber-stamped by Alejandro G. Castro.
3868
3869         This feature doesn't seem required for our setup.
3870
3871         * gtk/jhbuild.modules:
3872
3873 2018-10-15  Justin Fan  <justin_fan@apple.com>
3874
3875         Add WebGPU 2018 feature flag and experimental feature flag
3876         https://bugs.webkit.org/show_bug.cgi?id=190509
3877
3878         Reviewed by Dean Jackson.
3879
3880         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3881         for the 2018 WebGPU prototype.
3882
3883         * DumpRenderTree/TestOptions.cpp:
3884         (TestOptions::TestOptions):
3885         * DumpRenderTree/TestOptions.h:
3886         * DumpRenderTree/mac/DumpRenderTree.mm:
3887         (setWebPreferencesForTestOptions):
3888         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3889
3890 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3891
3892         Update bot configuration for Sierra archive queues
3893         https://bugs.webkit.org/show_bug.cgi?id=190605
3894
3895         Reviewed by Aakash Jain.
3896
3897         * BuildSlaveSupport/build.webkit.org-config/config.json:
3898
3899 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3900
3901         Add support for prefers-color-scheme media query
3902         https://bugs.webkit.org/show_bug.cgi?id=190499
3903         rdar://problem/45212025
3904
3905         Reviewed by Dean Jackson.
3906
3907         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
3908         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3909
3910 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3911
3912         [JHBuild] Add xdg-dbus-proxy module
3913         https://bugs.webkit.org/show_bug.cgi?id=190589
3914
3915         Reviewed by Michael Catanzaro.
3916
3917         * gtk/jhbuild.modules:
3918
3919 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3920
3921         [GTK] Add new sandboxing dependencies to install-dependencies
3922         https://bugs.webkit.org/show_bug.cgi?id=190588
3923
3924         Reviewed by Michael Catanzaro.
3925
3926         * gtk/install-dependencies:
3927
3928 2018-10-15  Chris Dumez  <cdumez@apple.com>
3929
3930         Experiment: target=_blank on anchors should imply rel=noopener
3931         https://bugs.webkit.org/show_bug.cgi?id=190481
3932
3933         Reviewed by Alex Christensen.
3934
3935         Add API test coverage to make sure we can now swap process when target=_blank
3936         is specified on an anchor but rel=noopener is not.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3939
3940 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3941
3942         [iOS] Can't select text after dismissing the keyboard when changing focus
3943         https://bugs.webkit.org/show_bug.cgi?id=190563
3944         <rdar://problem/44613559>
3945
3946         Reviewed by Tim Horton.
3947
3948         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3949         (WTR::UIScriptController::isShowingKeyboard const):
3950
3951         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
3952         details.
3953
3954         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3955         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3956         (WTR::UIScriptController::isShowingKeyboard const):
3957         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3958         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3959         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3960
3961         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
3962         `isShowingKeyboard` as the getter method.
3963
3964         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
3965         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
3966         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3967         (WTR::UIScriptController::isShowingKeyboard const):
3968
3969 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3970
3971         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
3972
3973         * Scripts/run-javascriptcore-tests:
3974         (runJSCStressTests): Remove wsl-tests.yaml.
3975
3976 2018-10-15  Christopher Reid  <chris.reid@sony.com>
3977
3978         [Curl][WinCairo] Add Public Suffix support to WinCairo
3979         https://bugs.webkit.org/show_bug.cgi?id=183060
3980
3981         Reviewed by Alex Christensen.
3982
3983         Share mac's PublicSuffix tests with all ports.
3984
3985         * TestWebKitAPI/PlatformWin.cmake:
3986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3987         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3988         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
3989
3990 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
3991
3992         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
3993         https://bugs.webkit.org/show_bug.cgi?id=190555
3994
3995         Unreviewed.
3996
3997         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
3998
3999         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
4000         * WebGPUShadingLanguageRI/All.js: Removed.
4001         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
4002         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
4003         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
4004         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
4005         * WebGPUShadingLanguageRI/Assignment.js: Removed.
4006         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
4007         * WebGPUShadingLanguageRI/Block.js: Removed.
4008         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
4009         * WebGPUShadingLanguageRI/Break.js: Removed.
4010         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
4011         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
4012         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
4013         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
4014         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
4015         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
4016         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
4017         * WebGPUShadingLanguageRI/Casts.js: Removed.
4018         * WebGPUShadingLanguageRI/Check.js: Removed.
4019         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
4020         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
4021         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
4022         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
4023         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
4024         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
4025         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
4026         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
4027         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
4028         * WebGPUShadingLanguageRI/Checker.js: Removed.
4029         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
4030         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
4031         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
4032         * WebGPUShadingLanguageRI/Continue.js: Removed.
4033         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
4034         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
4035         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
4036         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
4037         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
4038         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
4039         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
4040         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
4041         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
4042         * WebGPUShadingLanguageRI/EPtr.js: Removed.
4043         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
4044         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
4045         * WebGPUShadingLanguageRI/EnumType.js: Removed.
4046         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
4047         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
4048         * WebGPUShadingLanguageRI/Expression.js: Removed.
4049         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
4050         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
4051         * WebGPUShadingLanguageRI/Field.js: Removed.
4052         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
4053         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
4054         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
4055         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
4056         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
4057         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
4058         * WebGPUShadingLanguageRI/Func.js: Removed.
4059         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
4060         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
4061         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
4062         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
4063         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
4064         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
4065         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
4066         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
4067         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
4068         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
4069         * WebGPUShadingLanguageRI/Inline.js: Removed.
4070         * WebGPUShadingLanguageRI/Inliner.js: Removed.
4071         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
4072         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
4073         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
4074         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
4075         * WebGPUShadingLanguageRI/Lexer.js: Removed.
4076         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
4077         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
4078         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
4079         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
4080         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
4081         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
4082         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
4083         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
4084         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
4085         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
4086         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
4087         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
4088         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
4089         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
4090         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
4091         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
4092         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
4093         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
4094         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
4095         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
4096         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
4097         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
4098         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
4099         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
4100         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
4101         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
4102         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
4103         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
4104         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
4105         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
4106         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
4107         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
4108         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
4109         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
4110         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
4111         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
4112         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
4113         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
4114         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
4115         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
4116         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
4117         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
4118         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
4119         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
4120         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
4121         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
4122         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
4123         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
4124         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
4125         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
4126         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
4127         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
4128         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
4129         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
4130         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
4131         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
4132         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
4133         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
4134         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
4135         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
4136         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
4137         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
4138         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
4139         * WebGPUShadingLanguageRI/NameContext.js: Removed.
4140         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
4141         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
4142         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
4143         * WebGPUShadingLanguageRI/NativeType.js: Removed.
4144         * WebGPUShadingLanguageRI/Node.js: Removed.
4145         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
4146         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
4147         * WebGPUShadingLanguageRI/NullType.js: Removed.
4148         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
4149         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
4150         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
4151         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
4152         * WebGPUShadingLanguageRI/Parse.js: Removed.
4153         * WebGPUShadingLanguageRI/Prepare.js: Removed.
4154         * WebGPUShadingLanguageRI/Program.js: Removed.
4155         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
4156         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
4157         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
4158         * WebGPUShadingLanguageRI/PtrType.js: Removed.
4159         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
4160         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
4161         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
4162         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
4163         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
4164         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
4165         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
4166         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
4167         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
4168         * WebGPUShadingLanguageRI/Return.js: Removed.
4169         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
4170         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
4171         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
4172         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
4173         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
4174         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
4175         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
4176         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
4177         * WebGPUShadingLanguageRI/Sampler.js: Removed.
4178         * WebGPUShadingLanguageRI/Semantic.js: Removed.
4179         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
4180         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
4181         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
4182         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
4183         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
4184         * WebGPUShadingLanguageRI/StructType.js: Removed.
4185         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
4186         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
4187         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
4188         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
4189         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
4190         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
4191         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
4192         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
4193         * WebGPUShadingLanguageRI/Test.html: Removed.
4194         * WebGPUShadingLanguageRI/Test.js: Removed.
4195         * WebGPUShadingLanguageRI/Texture.js: Removed.
4196         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
4197         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
4198         * WebGPUShadingLanguageRI/Type.js: Removed.
4199         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
4200         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
4201         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
4202         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
4203         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
4204         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
4205         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
4206         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
4207         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
4208         * WebGPUShadingLanguageRI/Value.js: Removed.
4209         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
4210         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
4211         * WebGPUShadingLanguageRI/VectorType.js: Removed.
4212         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
4213         * WebGPUShadingLanguageRI/Visitor.js: Removed.
4214         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
4215         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
4216         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
4217         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
4218         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
4219         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
4220         * WebGPUShadingLanguageRI/index.html: Removed.
4221         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
4222         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
4223
4224 2018-10-15  Philippe Normand  <pnormand@igalia.com>
4225
4226         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
4227         https://bugs.webkit.org/show_bug.cgi?id=190581
4228
4229         Reviewed by Michael Catanzaro.
4230
4231         These bots don't use JHBuild and their host GStreamer version is
4232         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
4233
4234         * BuildSlaveSupport/build.webkit.org-config/config.json:
4235
4236 2018-10-15  Alex Christensen  <achristensen@webkit.org>
4237
4238         Use pragma once in WTF
4239         https://bugs.webkit.org/show_bug.cgi?id=190527
4240
4241         Reviewed by Chris Dumez.
4242
4243         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
4244
4245         * DumpRenderTree/TestRunner.cpp:
4246         (TestRunner::queueLoadHTMLString):
4247         (TestRunner::queueLoadAlternateHTMLString):
4248         (TestRunner::queueBackNavigation):
4249         (TestRunner::queueForwardNavigation):
4250         (TestRunner::queueLoadingScript):
4251         (TestRunner::queueNonLoadingScript):
4252         (TestRunner::queueReload):
4253         * DumpRenderTree/WorkQueue.cpp:
4254         (WorkQueue::singleton): Deleted.
4255         (WorkQueue::WorkQueue): Deleted.
4256         (WorkQueue::queue): Deleted.
4257         (WorkQueue::dequeue): Deleted.
4258         (WorkQueue::count): Deleted.
4259         (WorkQueue::clear): Deleted.
4260         (WorkQueue::processWork): Deleted.
4261         * DumpRenderTree/WorkQueue.h:
4262         (WorkQueue::setFrozen): Deleted.