REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnima...
[WebKit-https.git] / Tools / ChangeLog
1 2018-06-07  Tim Horton  <timothy_horton@apple.com>
2
3         REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
4         https://bugs.webkit.org/show_bug.cgi?id=186395
5         <rdar://problem/40902427>
6
7         Reviewed by Wenson Hsieh.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
10         (TEST):
11         endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.
12
13 2018-06-07  Thibault Saunier  <tsaunier@igalia.com>
14
15         [GTK][WPE] Start implementing MediaStream API
16         https://bugs.webkit.org/show_bug.cgi?id=185787
17
18         Reviewed by Philippe Normand.
19
20         * Scripts/webkitpy/style/checker.py: Apply special formatting rules for new GObject subclasses.
21         * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base.
22         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch:
23         Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d0e9cc92a86aa0227ee87406737b6d31670aea
24
25 2018-06-07  Brendan McLoughlin  <brendan@bocoup.com>
26
27         Update web-platform-tests github location in webkitpy.w3c.test_importer
28         https://bugs.webkit.org/show_bug.cgi?id=186392
29
30         Reviewed by Youenn Fablet.
31
32         * Scripts/webkitpy/w3c/test_importer.py:
33         (TestImporter.write_import_log):
34
35 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
36
37         webkitperl: Generalize .internal SDK suffix
38         https://bugs.webkit.org/show_bug.cgi?id=186352
39         <rdar://problem/40853947>
40
41         Reviewed by Alexey Proskuryakov.
42
43         * Scripts/build-webkit:
44         * Scripts/package-root:
45         (usage):
46         * Scripts/webkitdirs.pm:
47         (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output.
48         (availableXcodeSDKS): Generate a list of all available Xcode SDKs on this machine.
49         (determineXcodeSDK): Always prefer .internal SDKs if available.
50         * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl:
51         
52 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
53
54         [Win][MiniBrowser] Support multiple windows properly
55         https://bugs.webkit.org/show_bug.cgi?id=186263
56
57         Reviewed by Ryosuke Niwa.
58
59         The current implementation of
60         PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using
61         CreateProcess to open a new window, and doesn't return the new
62         instance of IWebView. As the result, for example, window.close
63         doesn't work as expected.
64
65         In this change, a new MainWindow is created and return the
66         IWebView in PrintWebUIDelegate::createWebViewWithRequest.
67
68         In addition to it, this change unifies the lifetime of MiniBrowser
69         and its delegates AccessibilityDelegate, PrintWebUIDelegate,
70         ResourceLoadDelegate and WebDownloadDelegate in order to keep
71         MiniBrowser alive as long as the delegates live. Because the
72         window of webview keeps references of such delegates and accesses
73         those after MiniBrowser destruction.
74
75         * MiniBrowser/win/MainWindow.h: Added s_numInstances class member
76         to count the number of instance to close the application. Do not
77         use unique_ptr for m_browserWindow because it has ref count now.
78         * MiniBrowser/win/MainWindow.cpp:
79         (MainWindow::MainWindow): Increment s_numInstances.
80         (MainWindow::~MainWindow): Decrement s_numInstances.
81         (MainWindow::create):
82         (MainWindow::init):
83         (MainWindow::WndProc): Rename thiz to thisWindow. Keep this
84         instance alive during this function by using RefPtr<MainWindow>.
85         Deref the MainWindow instance on WM_DESTROY. Quit the application
86         when the last MainWindow is closed.
87         (MainWindow::cachesDialogProc): Rename thiz to thisWindow.
88         (MainWindow::customUserAgentDialogProc): Ditto.
89         * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release.
90         * MiniBrowser/win/MiniBrowser.cpp:
91         (MiniBrowser::create):
92         (MiniBrowser::AddRef):
93         (MiniBrowser::Release):
94         (MiniBrowser::init): Passes this to the constructors of delegates.
95         * MiniBrowser/win/AccessibilityDelegate.cpp:
96         (AccessibilityDelegate::AddRef): Delegate to MiniBrowser.
97         (AccessibilityDelegate::Release): Ditto.
98         * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount.
99         (AccessibilityDelegate::AccessibilityDelegate):
100         * MiniBrowser/win/MiniBrowserWebHost.cpp:
101         (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser.
102         (MiniBrowserWebHost::Release): Ditto.
103         * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount.
104         * MiniBrowser/win/PrintWebUIDelegate.cpp:
105         (PrintWebUIDelegate::createWebViewWithRequest): Create a new
106         MainWindow and return the IWebView.
107         (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser.
108         (PrintWebUIDelegate::Release): Ditto.
109         * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount.
110         (PrintWebUIDelegate::PrintWebUIDelegate):
111         * MiniBrowser/win/ResourceLoadDelegate.cpp:
112         (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser.
113         (ResourceLoadDelegate::Release): Ditto.
114         * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount.
115         * MiniBrowser/win/WebDownloadDelegate.cpp:
116         (WebDownloadDelegate::WebDownloadDelegate):
117         (WebDownloadDelegate::AddRef): Delegate to MiniBrowser.
118         (WebDownloadDelegate::Release): Ditto.
119         * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount.
120
121 2018-06-06  Fujii Hironori  <Hironori.Fujii@sony.com>
122
123         [Win][MiniBrowser] Remove gMainWindow global variable
124         https://bugs.webkit.org/show_bug.cgi?id=186378
125
126         Reviewed by Ryosuke Niwa.
127
128         I'm going to support multiple MainWindow in Bug 186263. It should
129         not be assumed that MainWindow has only one instance. gMainWindow
130         is used only in DisplayAuthDialog.
131
132         * MiniBrowser/win/Common.cpp:
133         (authDialogProc): Use DWLP_USER to store the dialog data.
134         (displayAuthDialog): Moved and renamed from
135         MainWindow::displayAuthDialog. Use DialogBoxParam instead of
136         DialogBox to pass a data pointer. Do not return S_OK if
137         DialogBoxParam returns -1. Take a HWND argument as the parent
138         window.
139         (DisplayAuthDialog): Deleted.
140         * MiniBrowser/win/Common.h:
141         * MiniBrowser/win/MainWindow.cpp:
142         (authDialogProc): Moved to Common.cpp.
143         (MainWindow::displayAuthDialog): Ditto.
144         * MiniBrowser/win/MainWindow.h:
145         * MiniBrowser/win/ResourceLoadDelegate.cpp:
146         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
147         * MiniBrowser/win/WinMain.cpp:
148         (wWinMain): Added a local variable mainWindow instead of using
149         gMainWindow.
150
151 2018-06-06  Dan Bernstein  <mitz@apple.com>
152
153         [Xcode] Opt out of the New Build System
154         https://bugs.webkit.org/show_bug.cgi?id=186380
155
156         Reviewed by Alexey Proskuryakov.
157
158         * Scripts/webkitdirs.pm:
159         (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild.
160
161 2018-06-06  Antoine Quint  <graouts@apple.com>
162
163         Rename color-filter to -apple-color-filter and do not expose it to Web content
164         https://bugs.webkit.org/show_bug.cgi?id=186306
165         <rdar://problem/39874167>
166
167         Reviewed by Simon Fraser.
168
169         Adding an option to turn support for the -apple-color-filter property on via an HTML comment.
170
171         * DumpRenderTree/TestOptions.cpp:
172         (TestOptions::TestOptions):
173         * DumpRenderTree/TestOptions.h:
174         * DumpRenderTree/mac/DumpRenderTree.mm:
175         (setWebPreferencesForTestOptions):
176         * WebKitTestRunner/TestController.cpp:
177         (WTR::TestController::resetPreferencesToConsistentValues):
178         (WTR::updateTestOptionsFromTestHeader):
179         * WebKitTestRunner/TestOptions.h:
180         (WTR::TestOptions::hasSameInitializationOptions const):
181         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
182         (WTR::TestController::platformCreateWebView):
183
184 2018-06-06  Brent Fulgham  <bfulgham@apple.com>
185
186         Adjust compile and runtime flags to match shippable state of features (Part 2)
187         https://bugs.webkit.org/show_bug.cgi?id=186319
188         <rdar://problem/40352045>
189
190         Unreviewed test fix.
191
192         TestWebKitAPI was timing out because 'color' input types are no longer support. I also discovered that the
193         ASSERT_STREQ macro returns on error, which causes tests to time out whenever a 'done = true' call (needed to
194         end the test) is done after ASSERT_STREQ, which might fail and return early, preventing the flag from being
195         set.
196
197         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
198         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]): Make testing of
199         the 'color' input type conditional on the feature being part of the build.
200         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
201         (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set the 'done=true' state before performing
202         string equality assertions, since they do an early return and bypass the end state of the test.
203         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto.
204         (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
205         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
206
207 2018-06-05  Chris Dumez  <cdumez@apple.com>
208
209         Regression(r232082): Websites get loaded inside of Messages App chat transcript
210         https://bugs.webkit.org/show_bug.cgi?id=186331
211         <rdar://problem/40735446>
212
213         Reviewed by Darin Adler.
214
215         Add API test coverage.
216
217         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm:
218         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
219         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartProvisionalLoadForFrame:]):
220         (TestWebKitAPI::TEST):
221         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Deleted.
222         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): Deleted.
223         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): Deleted.
224
225 2018-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
226
227         DataInteractionTests ContentEditableToTextarea and ContentEditableToContentEditable are failing on recent iOS 12
228         https://bugs.webkit.org/show_bug.cgi?id=186325
229         <rdar://problem/40527850>
230
231         Reviewed by Tim Horton.
232
233         Tweak these API tests so that they're robust against changes to how NSAttributedStrings are serialized in item
234         providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions of iOS, just verify that either rich
235         text type is present in the list of dragged type identifiers, and that the rich text type is placed at a higher
236         fidelity than plain text.
237
238         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
239         (checkRichTextTypePrecedesPlainTextType):
240         (TestWebKitAPI::TEST):
241         (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted.
242
243 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
244
245         Adjust compile and runtime flags to match shippable state of features
246         https://bugs.webkit.org/show_bug.cgi?id=186319
247         <rdar://problem/40352045>
248
249         Reviewed by Maciej Stachowiak, Jon Lee, and others.
250
251         This patch revises the compile time and runtime state for various features to match their
252         suitability for end-user releases.
253
254         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
255         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
256         Cocoa builds.
257         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
258         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
259
260 2018-06-05  Saam Barati  <sbarati@apple.com>
261
262         run-testmem should have a dry run option and an option to parse the stdout of executing the dry run
263         https://bugs.webkit.org/show_bug.cgi?id=186293
264
265         Reviewed by Mark Lam.
266
267         This makes it easier to execute run-testmem on a device that doesn't have ruby
268         on it. run-testmem now has a --dry option that will output commands to execute
269         in bash. To run on a device that doesn't have ruby, just put its output into
270         a bash script, and copy the PerformanceTests/testmem directory onto that device,
271         and execute the bash script. Running that bash script will give you raw output.
272         Make a file with that output and pass it into run-testmem using the --parse option.
273         run-testmem will parse the raw output and compute the benchmark score.
274
275         * Scripts/run-testmem:
276
277 2018-06-05  Youenn Fablet  <youenn@apple.com>
278
279         ServiceWorker registration should store any script fetched through importScripts
280         https://bugs.webkit.org/show_bug.cgi?id=182444
281         <rdar://problem/37164835>
282
283         Reviewed by Chris Dumez.
284
285         Add support to crash the storage process from Internals.
286
287         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
288         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
289         (WTR::TestRunner::terminateStorageProcess):
290         * WebKitTestRunner/InjectedBundle/TestRunner.h:
291         * WebKitTestRunner/TestController.cpp:
292         (WTR::TestController::terminateStorageProcess):
293         * WebKitTestRunner/TestController.h:
294         * WebKitTestRunner/TestInvocation.cpp:
295         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
296
297 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
298
299         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
300         https://bugs.webkit.org/show_bug.cgi?id=186286
301         <rdar://problem/40782992>
302
303         Reviewed by Dan Bernstein.
304
305         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
306         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
307         change this flag when preparing for a production release.
308
309         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to
310         determine whether experimental features should be enabled, and use it to properly define
311         the feature flag.
312
313 2018-06-05  Robin Morisset  <rmorisset@apple.com>
314
315         Add a grammar (in antlr4 format) to the WSL spec.
316         https://bugs.webkit.org/show_bug.cgi?id=186310
317
318         Rubberstamped by Filip Pizlo
319
320         It is just the raw rules, without much comments and no typesetting.
321         Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK)
322
323         It does not exactly match the parser of the current js implementation of WSL, it:
324         - Accepts negative literals
325         - Reserves keywords fallthrough/auto
326         - Refuses '_' as a valid identifier
327         - Accepts several capitalizations for Null/True/False
328         - Accepts variable declarations at the top-level
329         - Correctly parses ternary expressions
330         - Forbids empty extension list for protocols
331         - Does not allow a space between '[' and ']' in type suffixes
332         - Correctly parses nested generics
333         - Accepts a 'fallthrough;' statement (for switches)
334         - Refuses chained relational operator (e.g. x < y < z)
335         - Generally a completely different structure for parsing effectful expressions, although it probably accepts about the same language
336         - Currently only accepts literals and identifiers as constexpr (while the js parser accepts way too much, including '(x += 42)')
337         There are probably more differences that I missed. The js parser will probably have to be mostly rewritten to follow the spec more closely (and fix all the bugs).
338         I will try to see if it can be automatically derived from the antlr4 grammar.
339
340         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added.
341
342 2018-06-04  Frederic Wang  <fwang@igalia.com>
343
344         import-w3c-tests should rely on <meta name="flags"> to detect CSS manual tests
345         https://bugs.webkit.org/show_bug.cgi?id=186261
346
347         Reviewed by Youenn Fablet.
348
349         * Scripts/webkitpy/w3c/test_parser.py:
350         (TestParser.is_wpt_manualtest): Add code to detect whether a file is a manual test
351         from its <meta name="flags"> tags. This is based on SourceFile::content_is_css_manual from
352         the WPT repository.
353         * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whether files with
354         <meta name="flags"> are manual or non-manual according to CSS WG rules.
355
356 2018-06-04  Dan Bernstein  <mitz@apple.com>
357
358         Fixed building ImageDiff with the default build system in the Xcode 10 developer beta.
359
360         * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include
361           HaveInternalSDK.xcconfig, since it may not be preent.
362
363 2018-06-04  Dan Bernstein  <mitz@apple.com>
364
365         Fixed building TestWebKitAPI with a shared build directory with XCBuild, which is the
366         default build system in the Xcode 10 developer beta.
367
368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the reference to the
369           built libWTF.a to be relative to the built products directory.
370
371 2018-06-04  Chris Dumez  <cdumez@apple.com>
372
373         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
374         https://bugs.webkit.org/show_bug.cgi?id=186287
375         <rdar://problem/40783352>
376
377         Reviewed by Youenn Fablet.
378
379         * DumpRenderTree/mac/DumpRenderTree.mm:
380         (enableExperimentalFeatures):
381         * DumpRenderTree/win/DumpRenderTree.cpp:
382         (enableExperimentalFeatures):
383
384 2018-06-04  Daniel Bates  <dabates@apple.com>
385
386         Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
387         https://bugs.webkit.org/show_bug.cgi?id=186290
388
389         Reviewed by Aakash Jain.
390
391         Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
392         questionable we should fix a typo when calling this mocked function with argument since.
393
394         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
395         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
396
397 2018-06-04  Dan Bernstein  <mitz@apple.com>
398
399         Fixed building with the macOS Mojave seed SDK.
400
401         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
402
403 2018-06-04  Alexey Proskuryakov  <ap@apple.com>
404
405         Add Mojave support to WebKit tools
406         https://bugs.webkit.org/show_bug.cgi?id=186282
407
408         Reviewed by Daniel Bates.
409
410         Nightly build support will be added separately.
411
412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png: Added.
413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png: Added.
414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
416         Added dashboard support.
417
418         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
419         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
420         Trigger the right build queues on check-in.
421
422         * Scripts/webkitpy/common/version_name_map.py:
423         * Scripts/webkitpy/common/version_name_map_unittest.py:
424         The main version mapping class updated.
425
426         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
427         * Scripts/webkitpy/port/mac_unittest.py:
428         Updated for more platforms in unit tests.
429
430         * TestResultServer/static-dashboards/flakiness_dashboard.js:
431         Added the new platform to flakiness dashboard.
432
433 2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>
434
435         [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
436         https://bugs.webkit.org/show_bug.cgi?id=186279
437
438         Reviewed by Tim Horton.
439
440         Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).
441
442         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
443
444 2018-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
445
446         [Win][MiniBrowser] Remove gMiniBrowser global variable
447         https://bugs.webkit.org/show_bug.cgi?id=186134
448
449         Reviewed by Brent Fulgham.
450
451         It should not be assumed there is only one main window and one browser
452         window to support multiple windows properly. gMainWindow and
453         gMiniBrowser global variables should be removed. This change
454         removes gMiniBrowser.
455
456         * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable.
457         * MiniBrowser/win/Common.h: Ditto.
458         * MiniBrowser/win/MainWindow.cpp:
459         (MainWindow::init):
460         (MainWindow::WndProc):
461         (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar.
462         (MainWindow::cachesDialogProc): Renamed from Caches.
463         (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent.
464         (MainWindow::onURLBarEnter): Extracted from EditProc.
465         (BackButtonProc): Deleted.
466         (ForwardButtonProc): Deleted.
467         (Caches): Renamed to MainWindow::cachesDialogProc.
468         (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc.
469         * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a member variable of MainWindow.
470         * MiniBrowser/win/MiniBrowserLibResource.h:
471         * MiniBrowser/win/WinMain.cpp:
472         (wWinMain):
473
474 2018-06-02  Darin Adler  <darin@apple.com>
475
476         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
477         https://bugs.webkit.org/show_bug.cgi?id=186227
478
479         Reviewed by Dan Bernstein.
480
481         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
482         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
483         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
484
485         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing include.
486
487         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
488         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
489         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
490         (AccessibilityTextMarker::isEqual): Ditto.
491         (AccessibilityTextMarkerRange::isEqual): Ditto.
492
493         * DumpRenderTree/mac/DumpRenderTree.mm:
494         (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of NSAutoreleasePool.
495         (DumpRenderTreeMain): Ditto.
496         (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto.
497         (runTest): Ditto.
498
499         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
500         (copyFile): Use a std::pair to return both a URL and an error rather than using an
501         out argument for the NSError.
502         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
503         Updated for the above change.
504
505         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
506         (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging typecast.
507         (-[DumpRenderTreeWindow close]): Ditto.
508         * DumpRenderTree/mac/LayoutTestHelper.m:
509         (setDisplayColorProfile): Ditto.
510
511         * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include.
512
513         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
514         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
515         Add __bridge to a bridging typecast.
516         * DumpRenderTree/mac/TestRunnerMac.mm:
517         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto.
518         (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool instead of NSAutoreleasePool.
519
520         * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment.
521
522         * DumpRenderTree/mac/UIScriptControllerMac.mm:
523         (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridging typecast.
524         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto.
525         (WTR::UIScriptController::overridePreference): Ditto.
526         * DumpRenderTree/mac/WorkQueueItemMac.mm:
527         (LoadItem::invoke const): Ditto.
528         (LoadHTMLStringItem::invoke const): Ditto.
529         (ScriptItem::invoke const): Ditto.
530
531         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
532         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
533         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
534
535         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
536         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
537         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
538
539         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
540         (WTR::AccessibilityController::accessibleElementById): Add __bridge to a bridging typecast.
541         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
542         (-[NSString createJSStringRef]): Ditto.
543         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm:
544         (WTR::AccessibilityTextMarker::isEqual): Ditto.
545         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm:
546         (WTR::AccessibilityTextMarkerRange::isEqual): Ditto.
547         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
548         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
549         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto.
550         (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
551         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
552         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
553         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
554         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
555         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
556         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
557         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
558         (WTR::createJSStringRef): Ditto.
559         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
560         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
561         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
562         (WTR::AccessibilityUIElement::indexForTextMarker): Ditto.
563         (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto.
564         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
565         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
566         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
567         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
568         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
569         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
570         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
571         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
572         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
573         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
574         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
575         (WTR::initializeWebViewConfiguration): Ditto.
576         (WTR::TestController::platformContext): Ditto.
577         (WTR::TestController::platformPreferences): Ditto.
578         (WTR::TestController::platformAdjustContext): Ditto.
579         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
580         (WTR::PlatformWebView::PlatformWebView): Ditto.
581         * WebKitTestRunner/mac/TestControllerMac.mm:
582         (WTR::TestController::initializeInjectedBundlePath): Ditto.
583         (WTR::TestController::initializeTestPluginDirectory): Ditto.
584         (WTR::TestController::platformConfigureViewForTest): Ditto.
585
586         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
587         (WTR::nsString): Use CFBridgingRelease instead of autorelease.
588         (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to a bridging
589         typecast.
590
591         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing include.
592
593         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
594         (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging typecast.
595         (-[LocalPasteboard setString:forType:]): Ditto.
596
597         * WebKitTestRunner/mac/main.mm:
598         (main): Use @autoreleasepool instead of NSAutoreleasePool.
599
600 2018-06-02  Keith Miller  <keith_miller@apple.com>
601
602         run-jsc should pass the option to use dollar vm by default
603         https://bugs.webkit.org/show_bug.cgi?id=186170
604
605         Reviewed by Yusuke Suzuki.
606
607         * Scripts/run-jsc:
608
609 2018-06-02  Commit Queue  <commit-queue@webkit.org>
610
611         Unreviewed, rolling out r232421.
612         https://bugs.webkit.org/show_bug.cgi?id=186240
613
614         Breaks webkitpy tests (Requested by aakashjain on #webkit).
615
616         Reverted changeset:
617
618         "Add some tests for lldb_webkit.py"
619         https://bugs.webkit.org/show_bug.cgi?id=183744
620         https://trac.webkit.org/changeset/232421
621
622 2018-06-01  Daniel Bates  <dabates@apple.com>
623
624         Add some tests for lldb_webkit.py
625         https://bugs.webkit.org/show_bug.cgi?id=183744
626
627         Reviewed by Alexey Proskuryakov.
628
629         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
630         and WTF::String objects.
631
632         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
633         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
634         on Mac.
635
636         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
637         * Scripts/build-lldbwebkittester: Added.
638         (buildProjectOrDie):
639         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
640         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
641         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
642         the file and take advantage of Python's default error semantics to throw an exception
643         if the import fails instead of handling it ourself. This has the side effect that we
644         now always import the LLDB Python module even if this script is invoked with --help.
645         If this turns out to be a significant annoyance then we can look to dynamically import
646         the module as we did before this change.
647         (webkit_build_dir):
648         (main):
649         (developer_dir): Deleted.
650         (import_lldb): Deleted.
651         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
652         that fact that test-webkitpy does not support class and module fixtures. This is because
653         test-webkitpy currently implements parallelism by breaking down existing test classes
654         into individual test methods itself and having each worker run exactly one test method (via
655         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
656         setUpModule()/setUpClass() are called for each test method as opposed to once per test
657         class/test module.
658         (remove_dir): Ditto.
659         * Scripts/webkitpy/common/system/systemhost.py:
660         (SystemHost):
661         (SystemHost.path_to_lldb_python_directory): Added.
662         * Scripts/webkitpy/test/main.py:
663         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
664         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
665         lldbWebKitTester on Mac.
666         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
667         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
668         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
669         If we will run these tests then build lldbWebKitTester if it has not already been built as the
670         unit tests depend on this program.
671         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
672         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
673         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
674         * lldb/lldbWebKitTester/Makefile: Added.
675         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
676         * lldb/lldbWebKitTester/main.cpp: Added.
677         (breakForTestingSummaryProviders):
678         (utf16String):
679         (testSummaryProviders):
680         (main):
681         * lldb/lldb_webkit_unittest.py: Added.
682         (destroy_cached_debug_session):
683         (LLDBDebugSession):
684         (LLDBDebugSession.setup):
685         (LLDBDebugSession.tearDown):
686         (TestSummaryProviders):
687         (TestSummaryProviders.setUpClass):
688         (TestSummaryProviders._sbFrame):
689         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
690         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
691         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
692         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
693         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
694         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
695         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
696         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
697
698 2018-06-01  Frederic Wang  <fwang@igalia.com>
699
700         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
701         https://bugs.webkit.org/show_bug.cgi?id=186133
702
703         Reviewed by Youenn Fablet.
704
705         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
706         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
707
708 2018-05-31  Frederic Wang  <fwang@igalia.com>
709
710         export-w3c-test-changes should use the new location & name of the WPT repo
711         https://bugs.webkit.org/show_bug.cgi?id=186135
712
713         Reviewed by Youenn Fablet.
714
715         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
716         corresponding variables to use the new organization and repository name. It also refactors a
717         bit the code to reduce the amount of hardcoded strings.
718
719         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
720         final slash to WPT_GH_URL, so it can be used for repo URL too.
721         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
722         WPT_GH_URL.
723         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
724         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
725         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
726         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
727         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
728         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
729         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
730         (TestExporterTest.test_export): Update organization and repository names for the remote
731         branch and pull request.
732         (TestExporterTest.test_export_with_specific_branch): Update repository name.
733
734 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
735
736         Update expected results for BuildStepsConstructorTest
737         https://bugs.webkit.org/show_bug.cgi?id=186119
738
739         Reviewed by Alex Christensen.
740
741         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
742
743 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
744
745         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
746         https://bugs.webkit.org/show_bug.cgi?id=185831
747         <rdar://problem/40468716>
748
749         Reviewed by David Kilzer.
750
751         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
752         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
753         (TEST):
754
755 2018-05-31  Chris Dumez  <cdumez@apple.com>
756
757         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
758         https://bugs.webkit.org/show_bug.cgi?id=184893
759         <rdar://problem/39747271>
760
761         Reviewed by Wenson Hsieh.
762
763         Update test to wait until the view is the expected height instead of
764         calling waitForNextPresentationUpdate once and expect the view to
765         have the right height. This fixes the flakiness.
766
767         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
768         (TestWebKitAPI::waitUntilInnerHeightIs):
769         (TestWebKitAPI::TEST):
770
771 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
772
773         test262-runner should run in verbose mode in automation
774         https://bugs.webkit.org/show_bug.cgi?id=186115
775
776         Reviewed by Yusuke Suzuki.
777
778         This patch toggles the verbose mode in the build bot and reports every test file
779         in order to avoid the '1200 seconds without output' issue.
780         * BuildSlaveSupport/build.webkit.org-config/steps.py:
781         (RunTest262Tests):
782         * Scripts/test262/Runner.pm:
783         (processResult):
784
785 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
786
787         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
788         https://bugs.webkit.org/show_bug.cgi?id=186079
789
790         Reviewed by Alex Christensen.
791
792         This is a sub task of Bug 184770.
793
794         This change is partial. I'm going to remove global variables
795         gMainWindow and gMiniBrowser and convert more functions to
796         MainWindow's methods in follow-up patches.
797
798         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
799         * MiniBrowser/win/Common.cpp:
800         (menuItemIsChecked): Moved to MainWindow.cpp.
801         (turnOffOtherUserAgents): Ditto.
802         (EditProc): Ditto.
803         (BackButtonProc): Ditto.
804         (ForwardButtonProc): Ditto.
805         (About): Ditto.
806         (Caches): Ditto.
807         (CustomUserAgent): Ditto.
808         (AuthDialogProc): Ditto.
809         (DisplayAuthDialog): Converted to MainWindow's method.
810         (ToggleMenuItem): Ditto.
811         (loadURL): Ditto.
812         * MiniBrowser/win/Common.h:
813         * MiniBrowser/win/MainWindow.cpp:
814         (MainWindow::init): Call SetFocus at the end of the construction.
815         (MainWindow::WndProc):
816         (menuItemIsChecked): Moved from Common.cpp.
817         (turnOffOtherUserAgents): Ditto.
818         (EditProc): Ditto.
819         (BackButtonProc): Ditto.
820         (ForwardButtonProc): Ditto.
821         (About): Ditto.
822         (Caches): Ditto.
823         (CustomUserAgent): Ditto.
824         (authDialogProc): Ditto.
825         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
826         (MainWindow::toggleMenuItem): Ditto.
827         (MainWindow::loadURL): Ditto.
828         * MiniBrowser/win/MainWindow.h: Added method declarations.
829         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
830         * MiniBrowser/win/WinMain.cpp:
831         (wWinMain): Include Common.h instead of Common.cpp.
832
833 2018-05-30  Brady Eidson  <beidson@apple.com>
834
835         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
836         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
837
838         Reviewed by Andy Estes.
839
840         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
841         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
842         (WTR::TestRunner::setCustomUserAgent):
843         * WebKitTestRunner/InjectedBundle/TestRunner.h:
844         * WebKitTestRunner/TestController.cpp:
845         (WTR::TestController::resetStateToConsistentValues):
846         * WebKitTestRunner/TestInvocation.cpp:
847         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
848
849 2018-05-30  Youenn Fablet  <youenn@apple.com>
850
851         Rename CrossOriginResourcePolicy same to same-origin
852         https://bugs.webkit.org/show_bug.cgi?id=186080
853
854         Reviewed by Chris Dumez.
855
856         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
857         (TestWebKitAPI::TEST):
858
859 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
860
861         [GTK] Unreviewed test gardening
862         https://bugs.webkit.org/show_bug.cgi?id=186098
863
864         Unreviewed gardening.
865
866         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
867
868 2018-05-29  Youenn Fablet  <youenn@apple.com>
869
870         Add a consistency check between URL and CFURL
871         https://bugs.webkit.org/show_bug.cgi?id=182444
872         <rdar://problem/37164835>
873
874         Reviewed by Geoff Garen.
875
876         DRT code expected a non null URL which is no longer the case now.
877         Updated DRT to remove that assumption.
878
879         * DumpRenderTree/TestRunner.cpp:
880         (TestRunner::redirectionDestinationForURL):
881         * DumpRenderTree/TestRunner.h:
882         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
883         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
884
885 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
886
887         Export changes to web-platform-test as part of the webkit-patch upload workflow
888         https://bugs.webkit.org/show_bug.cgi?id=184914
889
890         Reviewed by Youenn Fablet.
891
892         * Scripts/webkitpy/tool/commands/upload.py:
893         (Upload):
894         (CreateBug.execute):
895         (WPTChangeExport):
896         * Scripts/webkitpy/tool/steps/__init__.py:
897         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
898         (WPTChangeExport):
899         (WPTChangeExport.options):
900         (WPTChangeExport.run):
901         * Scripts/webkitpy/w3c/common.py:
902         * Scripts/webkitpy/w3c/test_exporter.py:
903         (WebPlatformTestExporter):
904         (WebPlatformTestExporter.__init__):
905         (WebPlatformTestExporter.username):
906         (WebPlatformTestExporter.token):
907         (WebPlatformTestExporter._github):
908         (WebPlatformTestExporter._wpt_fork_branch_github_url):
909         (WebPlatformTestExporter._wpt_fork_remote):
910         (WebPlatformTestExporter._wpt_fork_push_url):
911         (WebPlatformTestExporter._git):
912         (WebPlatformTestExporter._branch_name):
913         (WebPlatformTestExporter._public_branch_name):
914         (WebPlatformTestExporter._wpt_patch):
915         (WebPlatformTestExporter.has_wpt_changes):
916         (WebPlatformTestExporter._find_filename):
917         (WebPlatformTestExporter._is_ignored_file):
918         (WebPlatformTestExporter._strip_ignored_files_from_diff):
919         (WebPlatformTestExporter.write_git_patch_file):
920         (WebPlatformTestExporter._prompt_for_token):
921         (WebPlatformTestExporter._prompt_for_username):
922         (WebPlatformTestExporter._ensure_username_and_token):
923         (WebPlatformTestExporter._validate_and_save_token):
924         (WebPlatformTestExporter.create_branch_with_patch):
925         (WebPlatformTestExporter.push_to_wpt_fork):
926         (WebPlatformTestExporter.make_pull_request):
927         (WebPlatformTestExporter.delete_local_branch):
928         (WebPlatformTestExporter.create_upload_remote_if_needed):
929         (WebPlatformTestExporter.do_export):
930         (parse_args):
931         (TestExporter): Deleted.
932         (TestExporter.__init__): Deleted.
933         (TestExporter._ensure_wpt_repository): Deleted.
934         (TestExporter._fetch_wpt_repository): Deleted.
935         (TestExporter._ensure_new_branch_name): Deleted.
936         (TestExporter.download_and_commit_patch): Deleted.
937         (TestExporter.clean): Deleted.
938         (TestExporter.create_branch_with_patch): Deleted.
939         (TestExporter.push_to_wpt_fork): Deleted.
940         (TestExporter.make_pull_request): Deleted.
941         (TestExporter.create_wpt_pull_request): Deleted.
942         (TestExporter.delete_local_branch): Deleted.
943         (TestExporter.create_git_patch): Deleted.
944         (TestExporter.create_upload_remote): Deleted.
945         (TestExporter.do_export): Deleted.
946         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
947         (TestExporterTest.MockGit):
948         (TestExporterTest.MockGit.create_patch):
949         (TestExporterTest.test_export):
950         (TestExporterTest.test_export_with_specific_branch):
951         (TestExporterTest):
952         (TestExporterTest.test_export_interactive_mode):
953         (TestExporterTest.test_export_invalid_token):
954         (TestExporterTest.test_export_wrong_token):
955         (TestExporterTest.test_has_wpt_changes):
956         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
957         (TestExporterTest.test_ignore_changes_to_expected_file):
958
959 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
960
961         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
962         https://bugs.webkit.org/show_bug.cgi?id=186029
963
964         Reviewed by Alex Christensen.
965
966         This is a sub task of Bug 184770.
967
968         * MiniBrowser/win/Common.cpp:
969         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
970         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
971         (AbortProc): Moved to MiniBrowser.cpp.
972         (getPrinterDC): Ditto.
973         (initDocStruct): Ditto.
974         (PrintView): Ditto.
975         (ToggleMenuFlag): Ditto.
976         (setWindowText): Ditto.
977         (updateStatistics): Ditto.
978         * MiniBrowser/win/MainWindow.cpp:
979         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
980         * MiniBrowser/win/MiniBrowser.cpp:
981         (AbortProc): Moved from Common.cpp.
982         (getPrinterDC): Moved from Common.cpp.
983         (initDocStruct): Moved from Common.cpp.
984         (setWindowText): Moved from Common.cpp.
985         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
986         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
987         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
988         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
989         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
990
991 2018-05-29  Saam Barati  <sbarati@apple.com>
992
993         JSC should put bmalloc's scavenger into mini mode
994         https://bugs.webkit.org/show_bug.cgi?id=185988
995
996         Reviewed by Michael Saboff.
997
998         This patch makes it so that we turn off the JIT when running run-testmem
999         that way we make JSC use its mini mode.
1000
1001         * Scripts/run-testmem:
1002
1003 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
1004
1005         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
1006         https://bugs.webkit.org/show_bug.cgi?id=185835
1007         <rdar://problem/39142257>
1008
1009         Reviewed by Chris Dumez.
1010
1011         Add API test coverage.
1012
1013         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1014         (TEST):
1015
1016 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1017
1018         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
1019         https://bugs.webkit.org/show_bug.cgi?id=186042
1020         <rdar://problem/40604182>
1021
1022         Reviewed by Tim Horton.
1023
1024         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
1025         significant portion of the page has been painted before document load is finished.
1026
1027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1028         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
1029         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
1030         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
1031         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
1032         (-[RenderingProgressHandler initWithHandler:]):
1033         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
1034         (TEST):
1035
1036 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
1037
1038         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
1039         https://bugs.webkit.org/show_bug.cgi?id=186040
1040
1041         The patch we merge contained a type and was merged in upstream GStreamer fixing that
1042         (s/avalaible/available/).
1043
1044         Reviewed by Xabier Rodriguez-Calvar.
1045
1046         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
1047
1048 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
1049
1050         Add an API test to check process privilege when using Cookie API
1051         https://bugs.webkit.org/show_bug.cgi?id=185406
1052
1053         Reviewed by Geoffrey Garen.
1054
1055         Add API test coverage.
1056
1057         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1058         (TEST):
1059
1060 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
1061
1062         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
1063         https://bugs.webkit.org/show_bug.cgi?id=185948
1064
1065         Reviewed by Xabier Rodriguez-Calvar.
1066
1067         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
1068         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
1069         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
1070         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
1071
1072         * gstreamer/jhbuild.modules:
1073         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
1074         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
1075         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
1076
1077 2018-05-27  Dan Bernstein  <mitz@apple.com>
1078
1079         Reverted the changes made for https://webkit.org/b/186016
1080
1081         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
1082
1083 2018-05-27  Dan Bernstein  <mitz@apple.com>
1084
1085         [Cocoa] Avoid importing directly from subumbrella frameworks
1086         https://bugs.webkit.org/show_bug.cgi?id=186016
1087
1088         Reviewed by Sam Weinig.
1089
1090         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1091           LaunchServices header.
1092         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1093           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1094         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1095           when using SDKs earlier than 10.13.
1096         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1097           and OTHER_CPLUSPLUSFLAGS.
1098         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
1099           HIToolbox header.
1100         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1101           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1102         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1103           LaunchServices header.
1104
1105 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1106
1107         [Win][MiniBrowser] Add MainWindow class
1108         https://bugs.webkit.org/show_bug.cgi?id=185814
1109
1110         Reviewed by Per Arne Vollan.
1111
1112         This is a sub task of Bug 184770. Added a new class MainWindow to
1113         represent the main window which will be shared among WK1 and WK2.
1114
1115         This change is partial so that it's easy to review this patch.
1116         I'll move more functions into MainWindow.cpp, and remove more
1117         global variables in forthcoming patches.
1118
1119         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
1120         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
1121         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
1122         hForwardButtonWnd. Added a new global variable gMainWindow.
1123         (WndProc): Moved to MainWindow.cpp.
1124         (resizeSubViews): Ditto.
1125         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
1126         (ToggleMenuItem): Ditto.
1127         (CustomUserAgent): Follow the global variables removal.
1128         (DisplayAuthDialog): Ditto.
1129         (loadURL): Ditto.
1130         (WndProc): Renamed to MainWindow::WndProc.
1131         * MiniBrowser/win/MainWindow.cpp: Added.
1132         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
1133         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
1134         (MainWindow::resizeSubViews): Moved from Common.cpp.
1135         (MainWindow::WndProc): Ditto.
1136         * MiniBrowser/win/MainWindow.h: Added.
1137         (MainWindow::hwnd):
1138         (MainWindow::browserWindow):
1139         * MiniBrowser/win/MiniBrowser.cpp:
1140         (MiniBrowser::init):
1141         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
1142         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
1143         * MiniBrowser/win/MiniBrowser.h:
1144         * MiniBrowser/win/WinMain.cpp:
1145         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
1146         (MyRegisterClass): Moved to MainWindow.cpp.
1147
1148 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1149
1150         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
1151         https://bugs.webkit.org/show_bug.cgi?id=185969
1152
1153         Reviewed by Alex Christensen.
1154
1155         MiniBrowser::init takes URL argument, but it's used only for
1156         loading default HTML if URL is not given.
1157
1158         - Add a new method MiniBrowser::loadHTMLString
1159         - Remove loadHTMLString process from MiniBrowser::prepareViews
1160
1161         * MiniBrowser/win/MiniBrowser.cpp:
1162         (MiniBrowser::init): Removed `requestedURL` argument.
1163         (MiniBrowser::prepareViews): Ditto.
1164         (MiniBrowser::loadHTMLString): New.
1165         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
1166         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
1167         * MiniBrowser/win/WinMain.cpp:
1168         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
1169
1170 2018-05-27  David Kilzer  <ddkilzer@apple.com>
1171
1172         svn-apply fails when a patch has an empty file
1173         <https://webkit.org/b/29684>
1174
1175         Reviewed by Daniel Bates.
1176
1177         Prior to this change, applying the following patches resulted in:
1178         - svn: add empty file     (failure)
1179         - svn: delete empty file  (failure)
1180         - svn: rename empty file  (failure)
1181         - git: add empty file     (false-positive success)
1182         - git: delete empty file  (success)
1183         - git: rename empty file  (failure)
1184
1185         * Scripts/VCSUtils.pm:
1186         (parseSvnDiffHeader): Handle the case when there is no patch
1187         following the header.  If the file exists and is empty, that
1188         means it's a deletion.  If the file does not exist, that means
1189         it's an addition. Everything else is a fatal error.
1190         * Scripts/svn-apply:
1191         (patch):
1192         - Only apply a patch for deletion if it has one or more text
1193           chunks.
1194         - Add a case to handle adding an empty file (an addition with no
1195           text chunks), and verify the file doesn't exist yet.
1196         - Any unhandled patch is a fatal error.
1197         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1198         Add tests for adding an empty file and deleting an empty file.
1199         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
1200         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
1201         test case.
1202
1203 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
1204
1205         Display detailed error logs when a script fails in EWS
1206         https://bugs.webkit.org/show_bug.cgi?id=175696
1207         <rdar://problem/34841885>
1208
1209         Reviewed by Darin Adler.
1210
1211         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
1212         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
1213         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1214         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
1215         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1216         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
1217
1218 2018-05-25  Daniel Bates  <dabates@apple.com>
1219
1220         test-webkitpy messages logged using __main__ logger are not displayed
1221         https://bugs.webkit.org/show_bug.cgi?id=185823
1222
1223         Rubber-stamped by Aakash Jain.
1224
1225         Configure the logger for __main__ so that messages that are logged before it parses its
1226         command line arguments are printed to standard error.
1227
1228         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
1229         not configure a stream to use for printing until after it parses its command line arguments
1230         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
1231         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
1232         earlier because the latter both configures a stream and filters logged messages based on
1233         the specified verbosity. Logged messaged from code in __main__ should not be subject to
1234         such filtering. So, we explicitly configure the __main__ logger.
1235
1236         * Scripts/webkitpy/test/main.py:
1237         (main):
1238
1239 2018-05-25  Saam Barati  <sbarati@apple.com>
1240
1241         Make JSC have a mini mode that kicks in when the JIT is disabled
1242         https://bugs.webkit.org/show_bug.cgi?id=185931
1243
1244         Reviewed by Mark Lam.
1245
1246         This renames a variable for clarity.
1247
1248         * Scripts/run-testmem:
1249
1250 2018-05-25  Alex Christensen  <achristensen@webkit.org>
1251
1252         URL::host should return a StringView to reduce allocations
1253         https://bugs.webkit.org/show_bug.cgi?id=185986
1254
1255         Reviewed by Geoff Garen.
1256
1257         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1258         (TestWebKitAPI::TEST_F):
1259         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1260         (TestWebKitAPI::eq):
1261         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
1262         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1263
1264 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
1265
1266         Minor improvements to wpt exporter.
1267         https://bugs.webkit.org/show_bug.cgi?id=185978
1268
1269         Reviewed by Youenn Fablet.
1270
1271         * Scripts/webkitpy/w3c/test_exporter.py:
1272         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
1273         (TestExporter.make_pull_request): Improve the description of the created PR.
1274         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
1275
1276 2018-05-25  Saam Barati  <sbarati@apple.com>
1277
1278         Have a memory test where we can validate JSCs mini memory mode
1279         https://bugs.webkit.org/show_bug.cgi?id=185932
1280
1281         Reviewed by Mark Lam.
1282
1283         This patch adds the run-testmem script. This runs the new testmem
1284         CLI against the contents in the testmem benchmark. The contents of testmem
1285         contain tests from ARES-6, Sunspider, Octane, and JetStream.
1286         
1287         One iteration of the benchmark comprises of running each testmem test for
1288         a certain number of iterations. We collect the peak memory usage, the memory
1289         usage after running all the iterations, and the time it takes to run all the
1290         iterations. We then run the entire benchmark 3 times over. For each test, we
1291         compute the arithmetic mean over each iteration for time, peak memory, and
1292         end memory. The benchmark then computes a time score and memory score.
1293         
1294         peak memory score = geomean({peak memory of each individual test})
1295         end memory score = geomean({end memory of each individual test})
1296         memory score = geomean({peak memory score, end memory score})
1297         time score = geomean({time score of each individual test})
1298         
1299         We want the memory score to weigh improvements to peak memory usage and
1300         memory usage at the end equally.
1301         
1302         We plan to tune this benchmark in JSC's mini mode by improving the memory
1303         score while ensuring the time score is not more than 10-15% regressed.
1304
1305         * Scripts/run-testmem: Added.
1306
1307 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
1308
1309         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1310         https://bugs.webkit.org/show_bug.cgi?id=185041
1311         <rdar://problem/34684214>
1312
1313         Reviewed by Geoffrey Garen.
1314
1315         Add API test coverage.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1318         (TEST):
1319
1320 2018-05-24  Chris Dumez  <cdumez@apple.com>
1321
1322         Reduce copying of FontCascadeDescription objects by moving them around
1323         https://bugs.webkit.org/show_bug.cgi?id=185963
1324
1325         Reviewed by Simon Fraser.
1326
1327         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1328
1329         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1330         (TestWebKitAPI::TEST_F):
1331
1332 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1333
1334         WebDriver: implement maximize, minimize and fullscreen window commands
1335         https://bugs.webkit.org/show_bug.cgi?id=180398
1336
1337         Reviewed by Brian Burg.
1338
1339         * Scripts/webkitpy/port/xvfbdriver.py:
1340         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
1341
1342 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1343
1344         [GStreamer] Save some time disabling some compile options in the dependencies
1345         https://bugs.webkit.org/show_bug.cgi?id=185909
1346
1347         Reviewed by Philippe Normand.
1348
1349         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
1350         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
1351
1352 2018-05-23  Roy Reapor  <rreapor@apple.com>
1353
1354         Use Helvetica on build.webkit.org webpages
1355         https://bugs.webkit.org/show_bug.cgi?id=185894
1356
1357         Reviewed by Aakash Jain.
1358
1359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1362
1363 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
1364
1365         Add Buildbot configuration for Opensource EWS
1366         https://bugs.webkit.org/show_bug.cgi?id=185484
1367
1368         Rubber-stamped by Alexey Proskuryakov.
1369
1370         * BuildSlaveSupport/ews-build/config.json: Added, config file.
1371         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
1372         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
1373         (loadBuilderConfig): Loads the configuration.
1374         (checkValidWorker): Checks if the worker is valid.
1375         (checkValidBuilder): Checks if the builder is valid.
1376         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
1377         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
1378         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
1379         (getValidTags): Returns a list of valid tags.
1380         (getTagsForBuilder): Return a list of tags for given builder.
1381         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
1382         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
1383
1384 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
1385
1386         [GTK] Silence GCC 8 warnings
1387         https://bugs.webkit.org/show_bug.cgi?id=185556
1388
1389         Reviewed by Žan Doberšek.
1390
1391         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
1392         source and destination are always identical. But switching to snprintf avoids the warning.
1393
1394         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
1395         (FormValue::NPP_GetValue):
1396
1397 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
1398
1399         Unreviewed, rolling out r232112.
1400
1401         The tests added with this change  are failing on the bots.
1402
1403         Reverted changeset:
1404
1405         "test262/Runner.pm: add unit tests"
1406         https://bugs.webkit.org/show_bug.cgi?id=185783
1407         https://trac.webkit.org/changeset/232112
1408
1409 2018-05-23  Valerie R Young  <valerie@bocoup.com>
1410
1411         test262/Runner.pm: add unit tests
1412         https://bugs.webkit.org/show_bug.cgi?id=185783
1413
1414         Reviewed by Aakash Jain.
1415
1416         Add unit tests to be run by test-webkitperl
1417
1418         * Scripts/test262/Runner.pm:
1419         (main):
1420          - If harness files cannot be found in a custom, supplies test262 path,
1421            then sure the webkit test262 harness files.
1422          - Lazily create the test262-results directory.
1423          - If an expectation file is supplied via command line, save to the
1424            supplied location instead of the detault webkit location.
1425         (compileTest):
1426         (processResult):
1427         (getHarness):
1428         * Scripts/webkitperl/test262_unittest/README: Added.
1429         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
1430         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
1431         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
1432         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
1433         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
1434         (f):
1435         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
1436         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
1437         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
1438         (f):
1439         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
1440
1441 2018-05-22  Roy Reapor  <rreapor@apple.com>
1442
1443         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
1444         https://bugs.webkit.org/show_bug.cgi?id=185788
1445
1446         Reviewed by Aakash Jain.
1447
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
1451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1453         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1454         * TestResultServer/static-dashboards/run-unittests.html:
1455
1456 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1457
1458         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
1459         https://bugs.webkit.org/show_bug.cgi?id=185831
1460
1461         Reviewed by Chris Dumez.
1462
1463         Updated the test to prevent crash after assertion fails.
1464
1465         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1466         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1467
1468 2018-05-22  Chris Dumez  <cdumez@apple.com>
1469
1470         Regression(AsyncPolicyDelegates): Box.app login Window is blank
1471         https://bugs.webkit.org/show_bug.cgi?id=185832
1472         <rdar://problem/40307871>
1473
1474         Reviewed by Geoffrey Garen.
1475
1476         Add API test coverage.
1477
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
1480         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
1481         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1482         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
1483         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
1484         (TestWebKitAPI::TEST):
1485         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1486         (-[WKWebView _isBackground]):
1487
1488 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1489
1490         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
1491         https://bugs.webkit.org/show_bug.cgi?id=185715
1492
1493         Reviewed by Geoffrey Garen.
1494
1495         Add API test coverage.
1496
1497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1498         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
1499         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1500         (TEST):
1501
1502 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
1503
1504         Unreviewed, added myself as a WebKit committer.
1505
1506         * Scripts/webkitpy/common/config/contributors.json:
1507
1508 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
1509
1510         Unreviewed, rolling out r232052.
1511
1512         Breaks internal builds.
1513
1514         Reverted changeset:
1515
1516         "Use more C++17"
1517         https://bugs.webkit.org/show_bug.cgi?id=185176
1518         https://trac.webkit.org/changeset/232052
1519
1520 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
1521
1522         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
1523         https://bugs.webkit.org/show_bug.cgi?id=185689
1524
1525         Reviewed by Philippe Normand.
1526
1527         And update the patches, removing the ones that have been merged upstream.
1528
1529         * gstreamer/jhbuild.modules:
1530         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
1531         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
1532         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
1533         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
1534         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
1535         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
1536         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
1537         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
1538
1539 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1540
1541         Use more C++17
1542         https://bugs.webkit.org/show_bug.cgi?id=185176
1543
1544         Reviewed by JF Bastien.
1545
1546         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1547         * ImageDiff/cg/Configurations/Base.xcconfig:
1548         * MiniBrowser/Configurations/Base.xcconfig:
1549         * MobileMiniBrowser/Configurations/Base.xcconfig:
1550         * TestWebKitAPI/Configurations/Base.xcconfig:
1551         * WebKitTestRunner/Configurations/Base.xcconfig:
1552
1553 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1554
1555         [WinCairo] Enable WebKit build by default
1556         https://bugs.webkit.org/show_bug.cgi?id=185141
1557
1558         Reviewed by Per Arne Vollan.
1559
1560         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
1561         WebKitForwardingHeaders because config.h includes a header of WK2.
1562
1563         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
1564         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
1565
1566 2018-05-21  Jer Noble  <jer.noble@apple.com>
1567
1568         Complete fix for enabling modern EME by default
1569         https://bugs.webkit.org/show_bug.cgi?id=185770
1570         <rdar://problem/40368220>
1571
1572         Reviewed by Eric Carlson.
1573
1574         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1575
1576 2018-05-18  Christopher Reid  <chris.reid@sony.com>
1577
1578         Unreviewed, add myself as a WebKit committer.
1579
1580         * Scripts/webkitpy/common/config/contributors.json:
1581
1582 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1583
1584         Unreviewed, rolling out r222967.
1585
1586         It's not ready yet
1587
1588         Reverted changeset:
1589
1590         "[GTK][WPE] Add API to configure and enable resource load
1591         statistics"
1592         https://bugs.webkit.org/show_bug.cgi?id=177943
1593         https://trac.webkit.org/changeset/222967
1594
1595 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1596
1597         [GTK] MiniBrowser crashes when loading twice quickly
1598         https://bugs.webkit.org/show_bug.cgi?id=185763
1599
1600         Reviewed by Michael Catanzaro.
1601
1602         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
1603         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
1604         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
1605         leaked, it will crash when scheduled if the window has already been destroyed.
1606
1607         * MiniBrowser/gtk/BrowserWindow.c:
1608         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
1609
1610 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
1611
1612         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
1613         https://bugs.webkit.org/show_bug.cgi?id=185624
1614         <rdar://problem/39111626>
1615
1616         Reviewed by Chris Dumez.
1617
1618         Modified expectation to make test more robust as cookies can be returned in different orders.
1619
1620         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1621         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1622         (TEST):
1623
1624 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1625
1626         Unreviewed, rolling out r231982.
1627         https://bugs.webkit.org/show_bug.cgi?id=185793
1628
1629         Caused layout test failures (Requested by realdawei on
1630         #webkit).
1631
1632         Reverted changeset:
1633
1634         "Complete fix for enabling modern EME by default"
1635         https://bugs.webkit.org/show_bug.cgi?id=185770
1636         https://trac.webkit.org/changeset/231982
1637
1638 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1639
1640         Handle failure to extend sandbox gracefully
1641         https://bugs.webkit.org/show_bug.cgi?id=185779
1642         <rdar://problem/40316349>
1643
1644         Unreviewed, fix test results.
1645
1646         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1647         (TEST_F):
1648
1649 2018-05-18  Jer Noble  <jer.noble@apple.com>
1650
1651         Complete fix for enabling modern EME by default
1652         https://bugs.webkit.org/show_bug.cgi?id=185770
1653         <rdar://problem/40368220>
1654
1655         Reviewed by Eric Carlson.
1656
1657         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1658
1659 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1660
1661         Handle failure to extend sandbox gracefully
1662         https://bugs.webkit.org/show_bug.cgi?id=185779
1663         <rdar://problem/40316349>
1664
1665         Reviewed by Brent Fulgham.
1666
1667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1668         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
1669         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
1670         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1671         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1672         (MediaCaptureSimulateFailedSandbox::SetUp):
1673         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
1674         (TEST_F):
1675         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
1676
1677 2018-05-18  Daniel Bates  <dabates@apple.com>
1678
1679         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
1680         https://bugs.webkit.org/show_bug.cgi?id=185774
1681
1682         Reviewed by Andy Estes.
1683
1684         For now, the script debug-safari is not supported for WebKit for iOS. To
1685         fix this we differentiate between the Apple Mac port and Apple embedded
1686         ports.
1687
1688         * Scripts/webkitdirs.pm:
1689         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1690         (isAppleMacWebKit): Added.
1691         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
1692         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1693         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
1694         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1695         (runSafari): Ditto.
1696         (runMiniBrowser): Ditto.
1697         (debugMiniBrowser): Ditto.
1698         (runWebKitTestRunner): Ditto.
1699         (debugWebKitTestRunner): Ditto.
1700
1701 2018-05-18  Antoine Quint  <graouts@apple.com>
1702
1703         [Web Animations] Turn Web Animations with CSS integration on for test runners
1704         https://bugs.webkit.org/show_bug.cgi?id=184819
1705         <rdar://problem/39597337>
1706
1707         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
1708
1709         * DumpRenderTree/TestOptions.cpp:
1710         (TestOptions::TestOptions):
1711         * DumpRenderTree/TestOptions.h:
1712         * DumpRenderTree/mac/DumpRenderTree.mm:
1713         (runTest):
1714         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
1715         * WebKitTestRunner/TestController.cpp:
1716         (WTR::TestController::resetPreferencesToConsistentValues):
1717         (WTR::updateTestOptionsFromTestHeader):
1718         * WebKitTestRunner/TestOptions.cpp:
1719         (WTR::TestOptions::TestOptions):
1720         (WTR::isLegacyAnimationEngineTestPath): Deleted.
1721         * WebKitTestRunner/TestOptions.h:
1722
1723 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1724
1725         [Win][MiniBrowser] Create MainWindow even in transparent mode
1726         https://bugs.webkit.org/show_bug.cgi?id=185597
1727
1728         Reviewed by Per Arne Vollan.
1729
1730         The current implementations doesn't create the MainWindow in
1731         transparent mode. The screenshot is in Bug 58300.
1732
1733         There were three problems:
1734         - Can't control the WebView. ie. going backward and forward.
1735         - Can't quit the program.
1736         - It makes implementation complicated.
1737
1738         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
1739         even in the transparent mode.
1740         * MiniBrowser/win/WinMain.cpp:
1741         (wWinMain): Create the main window even in the transparent mode.
1742
1743 2018-05-18  Antoine Quint  <graouts@apple.com>
1744
1745         [Web Animations] Turn Web Animations with CSS integration on for test runners
1746         https://bugs.webkit.org/show_bug.cgi?id=184819
1747         <rdar://problem/39597337>
1748
1749         Reviewed by Jon Lee.
1750
1751         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
1752         integration flag on.
1753
1754         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
1755         comment directly at the top of the file since test runners now set the flag on by default
1756         and a dedicated directory exists for tests that need to run with this flag off.
1757
1758         * DumpRenderTree/TestOptions.cpp:
1759         (TestOptions::TestOptions):
1760         * DumpRenderTree/TestOptions.h:
1761         * DumpRenderTree/mac/DumpRenderTree.mm:
1762         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
1763         (runTest):
1764         * WebKitTestRunner/TestController.cpp:
1765         (WTR::TestController::resetPreferencesToConsistentValues):
1766         (WTR::updateTestOptionsFromTestHeader):
1767         * WebKitTestRunner/TestOptions.cpp:
1768         (WTR::isLegacyAnimationEngineTestPath):
1769         (WTR::TestOptions::TestOptions):
1770         * WebKitTestRunner/TestOptions.h:
1771
1772 2018-05-17  Nan Wang  <n_wang@apple.com>
1773
1774         AX: [macOS] Expose the primary screen height through AX API
1775         https://bugs.webkit.org/show_bug.cgi?id=185742
1776
1777         Reviewed by Chris Fleizach.
1778
1779         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1780         (attributesOfElement):
1781         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1782         (WTR::attributesOfElement):
1783
1784 2018-05-17  Commit Queue  <commit-queue@webkit.org>
1785
1786         Unreviewed, rolling out r231912.
1787         https://bugs.webkit.org/show_bug.cgi?id=185750
1788
1789         It is prompting the user when there is no WPT changes
1790         (Requested by bmac on #webkit).
1791
1792         Reverted changeset:
1793
1794         "Export changes to web-platform-test as part of the webkit-
1795         patch upload workflow"
1796         https://bugs.webkit.org/show_bug.cgi?id=184914
1797         https://trac.webkit.org/changeset/231912
1798
1799 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1800
1801         test262/Runner.pm: expand $INC to find webkitdirs.pm
1802         https://bugs.webkit.org/show_bug.cgi?id=185739
1803
1804         Reviewed by Michael Saboff.
1805
1806         * Scripts/test262/Runner.pm:
1807         (getBuildPath):
1808
1809 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1810
1811         [WPE] Implement and enable FULLSCREEN_API
1812         https://bugs.webkit.org/show_bug.cgi?id=185676
1813
1814         Reviewed by Žan Doberšek.
1815
1816         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1817         (testWebViewFullScreen):
1818
1819 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
1820
1821         Export changes to web-platform-test as part of the webkit-patch upload workflow
1822         https://bugs.webkit.org/show_bug.cgi?id=184914
1823
1824         Reviewed by Youenn Fablet.
1825
1826         * Scripts/webkitpy/tool/commands/upload.py:
1827         (Upload):
1828         (CreateBug.execute):
1829         (WPTChangeExport):
1830         * Scripts/webkitpy/tool/steps/__init__.py:
1831         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1832         (WPTChangeExport):
1833         (WPTChangeExport.options):
1834         (WPTChangeExport.run):
1835         * Scripts/webkitpy/w3c/common.py:
1836         * Scripts/webkitpy/w3c/test_exporter.py:
1837         (WebPlatformTestExporter):
1838         (WebPlatformTestExporter.__init__):
1839         (WebPlatformTestExporter.username):
1840         (WebPlatformTestExporter.token):
1841         (WebPlatformTestExporter._github):
1842         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1843         (WebPlatformTestExporter._wpt_fork_remote):
1844         (WebPlatformTestExporter._wpt_fork_push_url):
1845         (WebPlatformTestExporter._git):
1846         (WebPlatformTestExporter._branch_name):
1847         (WebPlatformTestExporter._public_branch_name):
1848         (WebPlatformTestExporter.has_wpt_changes):
1849         (WebPlatformTestExporter._create_patch):
1850         (WebPlatformTestExporter.create_git_patch):
1851         (WebPlatformTestExporter._prompt_for_token):
1852         (WebPlatformTestExporter._prompt_for_username):
1853         (WebPlatformTestExporter._ensure_username_and_token):
1854         (WebPlatformTestExporter._validate_and_save_token):
1855         (WebPlatformTestExporter.push_to_wpt_fork):
1856         (WebPlatformTestExporter.make_pull_request):
1857         (WebPlatformTestExporter.delete_local_branch):
1858         (parse_args):
1859         (TestExporter): Deleted.
1860         (TestExporter.__init__): Deleted.
1861         (TestExporter._ensure_wpt_repository): Deleted.
1862         (TestExporter._fetch_wpt_repository): Deleted.
1863         (TestExporter._ensure_new_branch_name): Deleted.
1864         (TestExporter.download_and_commit_patch): Deleted.
1865         (TestExporter.clean): Deleted.
1866         (TestExporter.create_branch_with_patch): Deleted.
1867         (TestExporter.push_to_wpt_fork): Deleted.
1868         (TestExporter.make_pull_request): Deleted.
1869         (TestExporter.create_wpt_pull_request): Deleted.
1870         (TestExporter.delete_local_branch): Deleted.
1871         (TestExporter.create_git_patch): Deleted.
1872         (TestExporter.create_upload_remote_if_needed): Deleted.
1873         (TestExporter.do_export): Deleted.
1874         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1875         (TestExporterTest.test_export):
1876         (TestExporterTest.test_export_with_specific_branch):
1877         (TestExporterTest):
1878         (TestExporterTest.test_export_interactive_mode):
1879         (TestExporterTest.test_export_invalid_token):
1880         (TestExporterTest.test_export_wrong_token):
1881
1882 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1883
1884         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
1885         https://bugs.webkit.org/show_bug.cgi?id=185650
1886
1887         Reviewed by Michael Saboff.
1888
1889         First, use jsc from CLI arg, then try to use webkit-build-directory,
1890         if that doesn't work, look for jsc in the $PATH
1891
1892         * Scripts/test262/Runner.pm:
1893         (processCLI):
1894         (getBuildPath):
1895         (runTest):
1896
1897 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1898
1899         Test262-Runner: Adds a --timeout option
1900         https://bugs.webkit.org/show_bug.cgi?id=185696
1901
1902         Reviewed by Michael Saboff.
1903
1904         The timeout option is used to set a timeout execution in ms for each test run in JSC.
1905         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
1906         * Scripts/test262/Runner.pm:
1907         (processCLI):
1908         (runTest):
1909
1910 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1911
1912         Test262-Runner: Set timer for each test run
1913         https://bugs.webkit.org/show_bug.cgi?id=185692
1914
1915         Reviewed by Michael Saboff.
1916
1917         Sets a high resolution timer for each execution call of JSC, reporting
1918         the time in the results report to allow identifying slow tests.
1919         * Scripts/test262/Runner.pm:
1920         (main):
1921         (processFile):
1922         (runTest):
1923         (processResult):
1924
1925 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
1926
1927         Add support for Intl NumberFormat formatToParts
1928         https://bugs.webkit.org/show_bug.cgi?id=185375
1929
1930         Reviewed by Yusuke Suzuki.
1931
1932         Add flag for NumberFormat formatToParts.
1933
1934         * Scripts/webkitperl/FeatureList.pm:
1935         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1936
1937 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1938
1939         [Win] Use C++17 in MSVC
1940         https://bugs.webkit.org/show_bug.cgi?id=185232
1941
1942         Reviewed by Alex Christensen.
1943
1944         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
1945         conflicts with ::byte defined in Windows' header.
1946
1947         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1948         (WindowedPluginTest::WindowedPluginTest):
1949         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1950         (logEventProc):
1951         (stringEvent):
1952         (AccessibilityController::winNotificationReceived):
1953         * DumpRenderTree/win/TextInputController.cpp:
1954         (markedRangeCallback):
1955         (firstRectForCharacterRangeCallback):
1956         (selectedRangeCallback):
1957         * DumpRenderTree/win/TextInputController.h:
1958         * DumpRenderTree/win/TextInputControllerWin.cpp:
1959         (TextInputController::markedRange):
1960         (TextInputController::firstRectForCharacterRange):
1961         (TextInputController::selectedRange):
1962
1963 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
1964
1965         Session cookies aren't reliably set when using default WKWebSiteDataStore
1966         https://bugs.webkit.org/show_bug.cgi?id=185624
1967         <rdar://problem/39111626>
1968
1969         Reviewed by Geoffrey Garen.
1970
1971         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
1972
1973         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1974         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1975         (TEST):
1976
1977 2018-05-16  Valerie R Young  <valerie@bocoup.com>
1978
1979         test262/Runner.pm: save to supplied expectation file if supplied
1980         https://bugs.webkit.org/show_bug.cgi?id=185660
1981
1982         Reviewed by Michael Saboff.
1983
1984         * Scripts/test262/Runner.pm:
1985         (processCLI):
1986         (main):
1987
1988 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
1989
1990         Unreviewed, rolling out r231763.
1991
1992         The test added with this change is failing an assertion.
1993
1994         Reverted changeset:
1995
1996         "NSEvent event trackers don't work from WebKitTestRunner"
1997         https://bugs.webkit.org/show_bug.cgi?id=185383
1998         https://trac.webkit.org/changeset/231763
1999
2000 2018-05-15  David Kilzer  <ddkilzer@apple.com>
2001
2002         TestWebKitAPI: Fix warnings found by new clang compiler
2003         <https://webkit.org/b/185631>
2004
2005         Reviewed by Michael Catanzaro.
2006
2007         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2008         (TestWebKitAPI::TEST):
2009         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2010         (TestWebKitAPI::TEST):
2011         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2012         (TestWebKitAPI::TEST):
2013         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2014         (TestWebKitAPI::TEST):
2015         - Add #pragma statements to ignore the new
2016           -Wself-assign-overloaded warning and to ignore
2017           this as an unknown warning on older clang versions.  We want
2018           to keep these self assigments as this code is designed to test
2019           that use case.
2020
2021         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2022         (TestWebKitAPI::didFindStringMatches):
2023         - Replace the "rect = rect;" statement that was used to avoid an
2024           unused variable warning with two expectations.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2027         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
2028         - Switch from -integerValue to -unsignedIntegerValue when
2029           comparing against _WKRectEdgeAll since it's an enum declared
2030           as an NSUInteger.
2031
2032 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2033
2034         Unreviewed, rolling out r230749
2035
2036         This did not work as desired.
2037
2038         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2039         (TestWebKitAPI::TEST):
2040
2041 2018-05-15  Antoine Quint  <graouts@apple.com>
2042
2043         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2044         https://bugs.webkit.org/show_bug.cgi?id=185647
2045
2046         Reviewed by Dean Jackson.
2047
2048         Rename the Web Animations CSS integration flag.
2049
2050         * DumpRenderTree/TestOptions.cpp:
2051         (TestOptions::TestOptions):
2052         * DumpRenderTree/TestOptions.h:
2053         * DumpRenderTree/mac/DumpRenderTree.mm:
2054         (setWebPreferencesForTestOptions):
2055         * WebKitTestRunner/TestController.cpp:
2056         (WTR::TestController::resetPreferencesToConsistentValues):
2057         (WTR::updateTestOptionsFromTestHeader):
2058         * WebKitTestRunner/TestOptions.h:
2059         (WTR::TestOptions::hasSameInitializationOptions const):
2060
2061 2018-05-14  Brady Eidson  <beidson@apple.com>
2062
2063         Add an API test to guard against regressions while re-entering setDefersLoading:.
2064         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
2065
2066         Reviewed by Chris Dumez.
2067
2068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2069         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
2070         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
2071         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
2072         (-[DefersScheme initWithBytes:]):
2073         (-[DefersScheme webView:startURLSchemeTask:]):
2074         (-[DefersScheme webView:stopURLSchemeTask:]):
2075         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
2076         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2077         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
2078         (-[DoubleDefersLoadingPlugIn dealloc]):
2079
2080 2018-05-14  Daniel Bates  <dabates@apple.com>
2081
2082         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
2083         https://bugs.webkit.org/show_bug.cgi?id=185599
2084         <rdar://problem/22493890>
2085
2086         Reviewed by Simon Fraser.
2087
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2089         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
2090         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
2091         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
2092         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2093         (TestWebKitAPI::TEST):
2094         * TestWebKitAPI/ios/set-timeout-function.html: Added.
2095
2096 2018-05-14  Valerie R Young  <valerie@bocoup.com>
2097
2098         test262/Runner.pm: small bugs in CLI and error codes
2099         https://bugs.webkit.org/show_bug.cgi?id=185629
2100
2101         Reviewed by Michael Saboff.
2102
2103         Fix two commandline args with use '-f', correct
2104         error code of failures.
2105
2106         * Scripts/test262/Runner.pm:
2107         (processCLI):
2108         (main):
2109
2110 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
2111
2112         Disable API tests that time out after pointer poisioning was disabled.
2113         https://bugs.webkit.org/show_bug.cgi?id=185586
2114
2115         Unreviewed test gardening.
2116
2117         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2118         (TestWebKitAPI::TEST):
2119         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2120         (TestWebKitAPI::TEST):
2121         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2124         (TestWebKitAPI::TEST):
2125
2126 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
2127
2128         Test262-Runner: Fix RegExp for capturing tests metadata"
2129         https://bugs.webkit.org/show_bug.cgi?id=185622
2130
2131         Reviewed by Michael Saboff.
2132
2133         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
2134         both LF and CRLF forms.
2135
2136         The fix also allows the runner to capture the proper results from two specific files using CR and
2137         CRLF line terminators. They are updated in the expectations file.
2138         * Scripts/test262/Runner.pm:
2139         (parseData):
2140
2141 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
2142
2143         NSEvent event trackers don't work from WebKitTestRunner
2144         https://bugs.webkit.org/show_bug.cgi?id=185383
2145         rdar://problem/40025045
2146
2147         Reviewed by Simon Fraser.
2148
2149         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
2150         NSEvent swipe tracking is used for webkit swipe navigation.
2151
2152         * WebKitTestRunner/mac/EventSenderProxy.mm:
2153         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2154
2155 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
2156
2157         Test262 Runner should search for the Debug JSC by default
2158         https://bugs.webkit.org/show_bug.cgi?id=185562
2159
2160         Reviewed by Michael Saboff.
2161
2162         The Test262 Runner is now searching for the Debug build of JSC by
2163         default, not the Release build.
2164
2165         This fix allows a similar call from the previous runner, making
2166         it compatible with the current build bot configuration parameters.
2167
2168         This patch also adds some minor improvements the verbose mode output.
2169
2170         * Scripts/test262/Runner.pm:
2171         (processCLI):
2172         (main):
2173         (getBuildPath):
2174         (processResult):
2175
2176 2018-05-11  Charles Vazac  <cvazac@gmail.com>
2177
2178         Runtime feature flag for Server-Timing
2179         https://bugs.webkit.org/show_bug.cgi?id=184758
2180
2181         Reviewed by Youenn Fablet.
2182
2183         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
2184         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
2185
2186 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2187
2188         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
2189         https://bugs.webkit.org/show_bug.cgi?id=185418
2190
2191         Reviewed by Alex Christensen.
2192
2193         All WK1 related code should be moved into MiniBrowser for the preparation
2194         of Bug 184770.
2195
2196         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
2197
2198         * MiniBrowser/win/Common.cpp:
2199         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
2200         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
2201         * MiniBrowser/win/Common.h: Added.
2202         * MiniBrowser/win/MiniBrowser.cpp:
2203         (MiniBrowser::init): Moved the initilization code from wWinMain.
2204         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
2205         * MiniBrowser/win/MiniBrowser.h:
2206         (MiniBrowser::setCacheFolder): Changed to a private method.
2207         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
2208         * MiniBrowser/win/WinMain.cpp:
2209         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
2210
2211 2018-05-11  Brady Eidson  <beidson@apple.com>
2212
2213         Make sure history navigations reuse the existing process when necessary.
2214         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
2215
2216         Reviewed by Ryosuke Niwa.
2217
2218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2219
2220 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2221
2222         [JSC][GLIB] Add introspectable alternatives to functions using vargars
2223         https://bugs.webkit.org/show_bug.cgi?id=185508
2224
2225         Reviewed by Michael Catanzaro.
2226
2227         Add test cases for the new API.
2228
2229         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2230         (testJSCFunction):
2231         (testJSCObject):
2232
2233 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
2234
2235         [Build Bot] Restore configuration options to the Test262 Runner
2236
2237         During the switch from the previous Test262 runner to the new one,
2238         a call for an extra configurations options got removed.
2239
2240         This call is important to inform the script to find the debug or
2241         release build of JSC. It's being restored in this patch.
2242
2243         https://bugs.webkit.org/show_bug.cgi?id=185513
2244
2245         Reviewed by Yusuke Suzuki.
2246
2247         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2248         (RunTest262Tests):
2249
2250 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
2251
2252         REGRESSION (r230998): Cannot stream API test output
2253         https://bugs.webkit.org/show_bug.cgi?id=185090
2254
2255         Reviewed by Ryosuke Niwa.
2256
2257         Change run-api-tests so that the stdout and stderr of a test will be printed
2258         before it's result. If -v is passed, the output of single test runs will be
2259         streamed. 
2260
2261         * Scripts/webkitpy/api_tests/run_api_tests.py:
2262         (run): Use print_timestamps flag.
2263         (parse_args): Add timestamps option to print timestamps in the log.
2264         * Scripts/webkitpy/api_tests/runner.py:
2265         (Runner): Add running status.
2266         (Runner.__init__): Add number of workers and a flag to detect if a newline
2267         is needed at the beginning of a log line.
2268         (Runner.run): Turn off most logging coming from server process since it is
2269         not constructive for API tests.
2270         (Runner.handle): Add new log message to stream stdout and stderr instead of
2271         caching values until the test run finished.
2272         (_Worker._run_single_test): Log stdout and stderr in real time.
2273         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
2274         the test.
2275         (_Worker.post): Provide a post with explicitly enumerated argument names.
2276         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2277         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
2278         (MeteredStream.write): Allow for verbose logging without timestamps.
2279         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2280         (RegularTest): Add print_timestamps flag.
2281         (RegularTest.setUp):
2282         (RegularTest.test_logging_not_included):
2283         (VerboseTest.test_log_args):
2284         (VerboseWithOutTimestamp):
2285         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
2286
2287 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
2288
2289         build-webkit can erroneously warn about Xcode being too old
2290         https://bugs.webkit.org/show_bug.cgi?id=185533
2291
2292         Reviewed by Dan Bernstein.
2293
2294         Don't assume the version number is always a single digit.
2295
2296         * Scripts/webkitdirs.pm:
2297         (determineXcodeVersion):
2298
2299 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
2300
2301         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
2302         https://bugs.webkit.org/show_bug.cgi?id=185528
2303
2304         Reviewed by Lucas Forschler.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2307         (TestFactory.__init__):
2308         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2309         (InstallWinCairoDependencies):
2310
2311 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2312
2313         Fix some -Wstring-op-truncation warnings
2314         https://bugs.webkit.org/show_bug.cgi?id=185496
2315
2316         Reviewed by Alex Christensen.
2317
2318         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
2319         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
2320         set the last bucket to NUL.
2321
2322         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2323         (TestWebKitAPI::testAtomicStringNumber):
2324         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2325         (TestWebKitAPI::testStringNumberFixedPrecision):
2326         (TestWebKitAPI::testStringNumberFixedWidth):
2327         (TestWebKitAPI::testStringNumber):
2328
2329 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2330
2331         [Win][MiniBrowser] Add a separate WndProc for the layered window
2332         https://bugs.webkit.org/show_bug.cgi?id=185460
2333
2334         Reviewed by Brent Fulgham.
2335
2336         All WK1 related code should be moved into MiniBrowser for the
2337         preparation of Bug 184770.
2338
2339         The layered window was using WndProc of the main window. The
2340         layered window is specific only for WK1. the main window will be
2341         shared among WK1 and WK2.
2342
2343         This change add a new WndProc for the layer window.
2344
2345         * MiniBrowser/win/Common.cpp:
2346         (WndProc): Removed code for the layered windows.
2347         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
2348         * MiniBrowser/win/MiniBrowser.cpp:
2349         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
2350         (viewWndProc): New WndProc for the layered windows.
2351         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
2352         * MiniBrowser/win/MiniBrowser.h:
2353         (MiniBrowser::hwnd):
2354         * MiniBrowser/win/WinMain.cpp:
2355         (wWinMain): Added m_viewWnd.
2356
2357 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
2358
2359         Support --verbose in run-javascriptcore-tests
2360         https://bugs.webkit.org/show_bug.cgi?id=185492
2361
2362         Reviewed by Daniel Bates.
2363
2364         * Scripts/run-javascriptcore-tests:
2365         (runJSCStressTests):
2366
2367 2018-05-10  Valerie R Young  <valerie@bocoup.com>
2368
2369         test262/Runner.pm: --failing-files uses results file not expectations
2370         https://bugs.webkit.org/show_bug.cgi?id=185395
2371
2372         Reviewed by Michael Saboff.
2373
2374         --failing-files arg now uses results file to find failing tests
2375         to rerun. It will look in the test262-results directory from whereever
2376         the script is run, or a results.yaml file can be supplied via command
2377         line argument.
2378         --expectations arg added for suppling expectation file.
2379
2380         * Scripts/test262/Runner.pm:
2381         (processCLI):
2382         (main):
2383         (loadImportFile):
2384         (findAllFailing):
2385
2386 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2387
2388         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
2389         https://bugs.webkit.org/show_bug.cgi?id=185506
2390
2391         Reviewed by Philippe Normand.
2392
2393         Useful for testing and debugging.
2394
2395         * MiniBrowser/gtk/main.c:
2396         (main):
2397
2398 2018-05-09  Chris Dumez  <cdumez@apple.com>
2399
2400         Unreviewed Windows build fix after r231622.
2401
2402         * DumpRenderTree/win/DumpRenderTree.cpp:
2403         (enableExperimentalFeatures):
2404
2405 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
2406
2407         Update WebKit.WebsiteDataStoreCustomPaths after r231536
2408         https://bugs.webkit.org/show_bug.cgi?id=185486
2409         <rdar://problem/37214391>
2410
2411         Reviewed by Chris Dumez.
2412
2413         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
2414
2415         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2416         (TEST):
2417
2418 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2419
2420         Test262-Runner: Improve the verbose output
2421         https://bugs.webkit.org/show_bug.cgi?id=185491
2422
2423         Reviewed by Michael Saboff.
2424
2425         * Scripts/test262/Import.pm:
2426         (transferFiles):
2427         * Scripts/test262/Runner.pm:
2428         (processResult):
2429
2430 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2431
2432         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
2433         https://bugs.webkit.org/show_bug.cgi?id=185488
2434
2435         Reviewed by Michael Saboff.
2436
2437         * Scripts/test262/Runner.pm:
2438         (processCLI):
2439         (getBuildPath):
2440         (runTest):
2441
2442 2018-05-09  Richard Houle  <rhoule@apple.com>
2443
2444         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
2445         https://bugs.webkit.org/show_bug.cgi?id=185260
2446         <rdar://problem/39290394>
2447
2448         Reviewed by Tim Horton.
2449
2450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2451         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
2452         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
2453         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
2454         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2455         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2456
2457 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
2458
2459         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2460         https://bugs.webkit.org/show_bug.cgi?id=185481
2461
2462         Reviewed by Philippe Normand.
2463
2464         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
2465
2466         * Scripts/webkitpy/port/gtk.py:
2467         (GtkPort.setup_environ_for_server):
2468
2469 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
2470
2471         Set build.webkit.org to use the new Test262-runner
2472         https://bugs.webkit.org/show_bug.cgi?id=184933
2473
2474         Reviewed by Aakash Jain.
2475
2476         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2477         (RunTest262Tests):
2478         (RunTest262Tests.countFailures):
2479         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2480
2481 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2482
2483         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
2484         https://bugs.webkit.org/show_bug.cgi?id=185461
2485
2486         Reviewed by Michael Catanzaro.
2487
2488         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
2489
2490         * gtk/jhbuild.modules:
2491
2492 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2493
2494         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
2495
2496         * wpe/manifest.txt.in: Distribute the NEWS.
2497
2498 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2499
2500         [WPE] Build cleanly with GCC 8 and ICU 60
2501         https://bugs.webkit.org/show_bug.cgi?id=185462
2502
2503         Reviewed by Carlos Alberto Lopez Perez.
2504
2505         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
2506         sure why this was never noticed until now or why the bots are OK.
2507         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2508         * gtk/patches/glib-cast-function-type.patch: Added.
2509         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
2510         * wpe/patches/glib-cast-function-type.patch: Added.
2511
2512 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2513
2514         [JSC][GTK][JSCONLY] Use capstone disassembler
2515         https://bugs.webkit.org/show_bug.cgi?id=185283
2516
2517         Reviewed by Michael Catanzaro.
2518
2519         * gtk/manifest.txt.in:
2520         * wpe/manifest.txt.in:
2521
2522 2018-05-09  Antti Koivisto  <antti@apple.com>
2523
2524         Add OptionSet::operator& and operator bool
2525         https://bugs.webkit.org/show_bug.cgi?id=185306
2526
2527         Reviewed by Anders Carlsson.
2528
2529         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2530         (TestWebKitAPI::TEST):
2531
2532 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2533
2534         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
2535         https://bugs.webkit.org/show_bug.cgi?id=185340
2536
2537         Reviewed by Tim Horton.
2538
2539         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
2540         non-empty text in a contenteditable.
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2543         (TestWebKitAPI::TEST):
2544
2545 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2546
2547         test262/Runner.pm: create results dir for results of test262 run
2548         https://bugs.webkit.org/show_bug.cgi?id=185392
2549
2550         Reviewed by Michael Saboff.
2551
2552         New directory test262-results created from where ever script is
2553         called.
2554
2555         * Scripts/test262/Runner.pm:
2556         (processCLI):
2557
2558 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2559
2560         test262/Runner.pm: lower number of processes per core
2561         https://bugs.webkit.org/show_bug.cgi?id=185426
2562
2563         Reviewed by Michael Saboff.
2564
2565         * Scripts/test262/Runner.pm:
2566         (getProcesses):
2567
2568 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
2569
2570         Test262-Runner: Add base Perl UnicodeData
2571         https://bugs.webkit.org/show_bug.cgi?id=185444
2572
2573         Reviewed by Michael Saboff.
2574
2575         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
2576         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
2577
2578 2018-05-08  Daniel Bates  <dabates@apple.com>
2579
2580         Add tests to ensure that the Strong Password appearance is removed on form reset
2581         https://bugs.webkit.org/show_bug.cgi?id=185440
2582
2583         Reviewed by Ryosuke Niwa.
2584
2585         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
2586         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2587         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2588         (TEST):
2589
2590 2018-05-08  Daniel Bates  <dabates@apple.com>
2591
2592         Resign Strong Password appearance when text field value changes
2593         https://bugs.webkit.org/show_bug.cgi?id=185433
2594         <rdar://problem/39958508>
2595
2596         Reviewed by Ryosuke Niwa.
2597
2598         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2599         when the field has the Strong Password button and its value changes.
2600
2601         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2602         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2603         (TEST):
2604
2605 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2606
2607         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2608         https://bugs.webkit.org/show_bug.cgi?id=185365
2609
2610         Reviewed by Saam Barati.
2611         
2612         Make it possible to measure compile times.
2613         
2614         Rolling back in after fixing cloop builds.
2615
2616         * Scripts/run-jsc-benchmarks:
2617
2618 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2619
2620         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
2621         https://bugs.webkit.org/show_bug.cgi?id=185414
2622
2623         Reviewed by Tim Horton.
2624
2625         Adjust a test expectation to check that the resulting DOM contains an attachment element,
2626         anchor element, and another attachment element in that order. This ensures that the test
2627         still passes, even after the anchor element is followed by a line break.
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2630         (TestWebKitAPI::TEST):
2631
2632 2018-05-08  Commit Queue  <commit-queue@webkit.org>
2633
2634         Unreviewed, rolling out r231491.
2635         https://bugs.webkit.org/show_bug.cgi?id=185434
2636
2637         Setting the Created key on a cookie does not work yet, due a
2638         bug in CFNetwork (Requested by ggaren on #webkit).
2639
2640         Reverted changeset:
2641
2642         "[WKHTTPCookieStore getAllCookies] returns inconsistent
2643         creation time"
2644         https://bugs.webkit.org/show_bug.cgi?id=185041
2645         https://trac.webkit.org/changeset/231491
2646
2647 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2648
2649         test262/Runner.pm: move input files to JSTests/test262
2650         https://bugs.webkit.org/show_bug.cgi?id=185389
2651
2652         Reviewed by Michael Saboff.
2653
2654         * Scripts/test262/Runner.pm:
2655         (processCLI):
2656
2657 2018-05-08  Chris Dumez  <cdumez@apple.com>
2658
2659         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
2660
2661         * Scripts/webkitpy/performance_tests/perftest.py:
2662         (PerfTest):
2663
2664 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
2665
2666         Unreviewed, rolling out r231468.
2667
2668         Broke the CLoop build
2669
2670         Reverted changeset:
2671
2672         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
2673         any abstract values"
2674         https://bugs.webkit.org/show_bug.cgi?id=185365
2675         https://trac.webkit.org/changeset/231468
2676
2677 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
2678
2679         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
2680         https://bugs.webkit.org/show_bug.cgi?id=185041
2681         <rdar://problem/34684214>
2682
2683         Reviewed by Geoffrey Garen.
2684
2685         Add API test Coverage.
2686
2687         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2688         (TEST):
2689
2690 2018-05-08  Chris Dumez  <cdumez@apple.com>
2691
2692         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2693
2694         * Scripts/webkitpy/performance_tests/perftest.py:
2695         (PerfTest):
2696
2697 2018-05-08  Chris Dumez  <cdumez@apple.com>
2698
2699         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2700
2701         * Scripts/webkitpy/performance_tests/perftest.py:
2702         (PerfTest):
2703
2704 2018-05-07  Chris Dumez  <cdumez@apple.com>
2705
2706         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2707
2708         * Scripts/webkitpy/performance_tests/perftest.py:
2709         (PerfTest):
2710
2711 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2712
2713         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2714         https://bugs.webkit.org/show_bug.cgi?id=185365
2715
2716         Reviewed by Saam Barati.
2717         
2718         Make it possible to measure compile times.
2719
2720         * Scripts/run-jsc-benchmarks:
2721
2722 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
2723
2724         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
2725         https://bugs.webkit.org/show_bug.cgi?id=185390
2726
2727         Reviewed by Michael Saboff.
2728
2729         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
2730
2731 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
2732
2733         Check for com.apple.datamigrator before declaring simulators booted
2734         https://bugs.webkit.org/show_bug.cgi?id=185315
2735         <rdar://problem/39986261>
2736
2737         Reviewed by David Kilzer.
2738
2739         * Scripts/webkitdirs.pm:
2740         (waitUntilProcessNotRunning): Wait until a process is not found.
2741         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
2742         a simulator booted.
2743         * Scripts/webkitpy/common/system/executive_mock.py:
2744         (MockExecutive2.__init__): Define _running_pids.
2745         * Scripts/webkitpy/xcode/simulated_device.py:
2746         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
2747         declaring that devices have been booted, increase the timeout since data migration will frequently
2748         take longer than 60 seconds, especially with multiple simulators booting.
2749         (SimulatedDeviceManager.swap): Ditto.
2750         (SimulatedDeviceManager):
2751         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
2752         processes running.
2753
2754 2018-05-07  Daniel Bates  <dabates@apple.com>
2755
2756         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
2757         https://bugs.webkit.org/show_bug.cgi?id=185054
2758         <rdar://problem/39773209>
2759
2760         Reviewed by Ryosuke Niwa.
2761
2762         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
2763
2764         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
2765         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
2766         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
2767         tests for the port.
2768
2769         * Scripts/webkitpy/port/mac.py:
2770         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
2771         have Apple Additions.
2772         * Scripts/webkitpy/port/mac_unittest.py:
2773         (MacTest.test_factory_with_future_version): Added.
2774         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
2775         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
2776         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
2777         is absent.
2778
2779 2018-05-07  Brian Burg  <bburg@apple.com>
2780
2781         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2782         https://bugs.webkit.org/show_bug.cgi?id=184861
2783         <rdar://problem/39153768>
2784
2785         Reviewed by Timothy Hatcher.
2786
2787         Add a new test that checks whether a new process is used for navigation when
2788         an Inspector is shown. Also check that the behavior reverts to normal after
2789         the Inspector has been closed.
2790
2791         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2792
2793 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2794
2795         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
2796         https://bugs.webkit.org/show_bug.cgi?id=185289
2797         <rdar://problem/35756912>
2798
2799         Reviewed by Tim Horton and Darin Adler.
2800
2801         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
2802         sessions.
2803
2804         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2805         (TestWebKitAPI::TEST):
2806
2807 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2808
2809         Deprecate legacy WebView and friends
2810         https://bugs.webkit.org/show_bug.cgi?id=185279
2811         rdar://problem/33268700
2812
2813         Reviewed by Tim Horton.
2814
2815         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
2816         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
2817
2818 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2819
2820         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
2821         https://bugs.webkit.org/show_bug.cgi?id=185314
2822
2823         Reviewed by Michael Saboff.
2824
2825         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
2826
2827 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
2828
2829         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
2830         https://bugs.webkit.org/show_bug.cgi?id=184196
2831         <rdar://problem/39054481>
2832
2833         Reviewed by Tim Horton.
2834
2835         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
2836         earlier than 11.3. Also re-enables these tests.
2837
2838         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2839         (TestWebKitAPI::TEST):
2840         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
2841         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
2842
2843 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
2844
2845         Text shaping in the simple path is flipped in the y direction
2846         https://bugs.webkit.org/show_bug.cgi?id=185062
2847         <rdar://problem/39778678>
2848
2849         Reviewed by Simon Fraser.
2850
2851         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
2852
2853         * Scripts/webkitpy/common/config/contributors.json:
2854
2855 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2856
2857         Test262-Runner: place the processCLI inside the main call
2858         https://bugs.webkit.org/show_bug.cgi?id=185304
2859
2860         Reviewed by Michael Saboff.
2861
2862         * Scripts/test262/Runner.pm:
2863         (main):
2864
2865 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2866
2867         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
2868         https://bugs.webkit.org/show_bug.cgi?id=174730
2869
2870         Reviewed by Michael Catanzaro.
2871
2872         Update unit tests to check that User-Agent header is included in HTTP download requests.
2873
2874         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2875         (testDownloadRemoteFile):
2876         (testWebViewDownloadURI):
2877         (testPolicyResponseDownload):
2878         (testPolicyResponseDownloadCancel):
2879         (testDownloadMIMEType):
2880         (testContextMenuDownloadActions):
2881
2882 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
2883
2884         [WinCairo] Test archive must use Python zipfile, just like build product.
2885         https://bugs.webkit.org/show_bug.cgi?id=185265
2886
2887         Reviewed by Per Arne Vollan.
2888
2889         * BuildSlaveSupport/test-result-archive:
2890         (archive_test_results):
2891         Copy over Win32-oriented archiving logic from built-product-archive.
2892
2893 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
2894
2895         cleanup modules usage for the Test262-Runner
2896         https://bugs.webkit.org/show_bug.cgi?id=185263
2897
2898         Reviewed by Michael Saboff.
2899
2900         * Scripts/test262-runner:
2901         * Scripts/test262/Runner.pm:
2902         (processCLI):
2903
2904 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2905
2906         test262/Runner.pm: minor fixes
2907         https://bugs.webkit.org/show_bug.cgi?id=185250
2908
2909         Reviewed by Michael Saboff.
2910
2911         Add comments, change output and fix bug: unintended interpolation
2912         of filename when running jsc.
2913
2914         * Scripts/test262/Runner.pm:
2915         (processCLI):
2916         (main):
2917         (runTest):
2918
2919 2018-05-03  Chris Dumez  <cdumez@apple.com>
2920
2921         Load hangs if the WebProcess fails to launch
2922         https://bugs.webkit.org/show_bug.cgi?id=185225
2923         <rdar://problem/38249058>
2924
2925         Reviewed by Geoff Garen.
2926
2927         Add API test coverage.
2928
2929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2930         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
2931         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
2932         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
2933         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2934         (TEST):
2935
2936 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
2937
2938         [WinCairo] Add JSC test bots
2939         https://bugs.webkit.org/show_bug.cgi?id=185234
2940
2941         Reviewed by Per Arne Vollan.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/config.json:
2944         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2945         (RunJavaScriptCoreTests.start):
2946
2947 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2948
2949         WebKit should send fake macOS user agent to docs.google.com
2950         https://bugs.webkit.org/show_bug.cgi?id=185165
2951
2952         Reviewed by Carlos Garcia Campos.
2953
2954         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2955         (TestWebKitAPI::TEST):
2956
2957 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2958
2959         test262/Runner.pm: performance improvements
2960         https://bugs.webkit.org/show_bug.cgi?id=185202
2961
2962         Reviewed by Michael Saboff.
2963
2964         Batch the tests by the number of processes, and give each process
2965         a file to save results to to avoid threading. Do not parallelize
2966         when running small sets of tests.
2967
2968         * Scripts/test262/Runner.pm:
2969         (processCLI):
2970         (main):
2971         (processFile):
2972         (processResult):
2973
2974 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
2975
2976         Unreviewed, rolling out r231253.
2977
2978         The API test added with this change is crashing on the bots.
2979
2980         Reverted changeset:
2981
2982         "Web Inspector: opt out of process swap on navigation if a Web
2983         Inspector frontend is connected"
2984         https://bugs.webkit.org/show_bug.cgi?id=184861
2985         https://trac.webkit.org/changeset/231253
2986
2987 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2988
2989         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
2990         https://bugs.webkit.org/show_bug.cgi?id=183348
2991
2992         Reviewed by Michael Catanzaro.
2993
2994         Add a test case to reproduce the crash.
2995
2996         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2997         (testWebViewCloseQuickly):
2998         (beforeAll):
2999
3000 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
3001
3002         Can't copy and paste URLs that have no title into Mail (macOS)
3003         https://bugs.webkit.org/show_bug.cgi?id=185205
3004         <rdar://problem/36352406>
3005
3006         Reviewed by Tim Horton.
3007
3008         Added test to verify behavior when copying and pasting a URL without a title.
3009
3010         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
3011         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3012         (TestWebKitAPI::TEST):
3013
3014 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3015
3016         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
3017         https://bugs.webkit.org/show_bug.cgi?id=184699
3018
3019         Unreviewed follow-up fix after r231230.
3020
3021         * Scripts/generate-jsc-bundle:
3022         (generate_wrapper_script): Quote the arguments passed to jsc.
3023
3024 2018-05-02  Brian Burg  <bburg@apple.com>
3025
3026         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
3027         https://bugs.webkit.org/show_bug.cgi?id=184861
3028         <rdar://problem/39153768>
3029
3030         Reviewed by Ryosuke Niwa.
3031
3032         Add a new test that checks whether a new process is used for navigation when
3033         an Inspector is shown. Also check that the behavior reverts to normal after
3034         the Inspector has been closed.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3037
3038 2018-05-02  Valerie R Young  <valerie@bocoup.com>
3039
3040         test262/Runner.pm: save summary to file
3041         https://bugs.webkit.org/show_bug.cgi?id=185200
3042
3043         Reviewed by Michael Saboff.
3044
3045         * Scripts/test262/Runner.pm:
3046         (processCLI):
3047         (main):
3048         (summarizeResults):
3049
3050 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3051
3052         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
3053         https://bugs.webkit.org/show_bug.cgi?id=184699
3054
3055         Reviewed by Gustavo Noronha Silva.
3056
3057         This adds a new step for the GTK 64-bit release build bot and the
3058         GTK 32-bit release build&test bot.
3059
3060         This step will be run as one of the lasts ones (after the product
3061         is built) and will execute the script generate-jsc-bundle.
3062         This script will take care of creating a JSC bundle and uploading
3063         it to a server defined on a configuration file that has to be
3064         deployed on the bots with the required server data and credentials
3065         for this upload.
3066
3067         In this case, the built products should then be accessible at
3068         <https://webkitgtk.org/jsc-built-products>. But the implementation
3069         is not tied to any specific server. All the details about where
3070         to upload the file is done in configuration file that is kept
3071         private on each bot outside of the WebKit source tree.
3072
3073         The script also supports generating a JSC bundle locally and not
3074         uploading it anywhere. This is the default mode of running.
3075         The remote upload will only be activated if a --remote-config-file
3076         parameter is passed (which is done from the buildbot config)
3077
3078         * BuildSlaveSupport/build.webkit.org-config/config.json:
3079         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3080         (BuildFactory):
3081         (BuildFactory.__init__):
3082         (TestFactory):
3083         (TestFactory.__init__):
3084         (BuildAndGenerateJSCBundleFactory):
3085         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
3086         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3087         (GenerateJSCBundle):
3088         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3089         * Scripts/generate-jsc-bundle: Added.
3090         (ldd_get_libs_and_interpreter):
3091         (generate_readme):
3092         (generate_wrapper_script):
3093         (copy_and_remove_rpath):
3094         (createJSCBundle):
3095         (sha256sum):
3096         (uploadJSCBundle):
3097         (main):
3098
3099 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
3100
3101         PSON: Make WebKitTestRunner work with process swap on navigation turned on
3102         https://bugs.webkit.org/show_bug.cgi?id=185111
3103
3104         Reviewed by Chris Dumez.
3105
3106         Add the basic support for running layout tests with process-swap-on-navigation turned on.
3107
3108         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
3109         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
3110
3111         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
3112         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
3113         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
3114         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
3115
3116         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3117         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
3118         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
3119         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
3120         beginTesting with BegingTestingMode::Resume when this boolean is set.
3121         (WTR::InjectedBundle::didReceiveMessageToPage):
3122         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
3123         bundle after a process swap on navigation.
3124         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3125         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3126         (WTR::InjectedBundlePage::dump):
3127         (WTR::InjectedBundlePage::frameDidChangeLocation):
3128         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3129         (WTR::TestRunner::TestRunner):
3130         (WTR::TestRunner::shouldDumpPixels const): Added.
3131         (WTR::TestRunner::setDumpPixels): Added.
3132         (WTR::TestRunner::dumpAsText):
3133         (WTR::TestRunner::whatToDump const): Added.
3134         (WTR::TestRunner::setWhatToDump): Added.
3135         (WTR::TestRunner::waitUntilDone):
3136         (WTR::TestRunner::setWaitUntilDone): Added.
3137         (WTR::TestRunner::shouldWaitUntilDone): Added.
3138         (WTR::TestRunner::notifyDone):
3139         (WTR::TestRunner::forceImmediateCompletion):
3140         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
3141         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
3142         (WTR::TestRunner::setAudioResult):
3143         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3144         (WTR::TestRunner::dumpChildFramesAsText):
3145         (WTR::TestRunner::dumpDOMAsWebArchive):
3146         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
3147         (WTR::TestRunner::whatToDump const): Moved to cpp.
3148         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
3149         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
3150         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
3151         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
3152         * WebKitTestRunner/TestInvocation.cpp:
3153         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
3154         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
3155         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
3156         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
3157         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
3158         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
3159         started as a result of a process swap on navigation (m_startedTesting is true).
3160         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
3161         support initializing the injected bundle in a process swapped after navigation and set/get messages for
3162         the states which must persist across process swaps within a test.
3163         * WebKitTestRunner/TestInvocation.h:
3164         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3165         * Tools/WebKitTestRunner/WhatToDump.h:
3166         (WTR::WhatToDump): Added.
3167
3168 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
3169
3170         Auto save the results for Test262
3171         https://bugs.webkit.org/show_bug.cgi?id=184926
3172
3173         Reviewed by Michael Saboff.
3174
3175         * Scripts/test262/Runner.pm:
3176         (processCLI):
3177         (main):
3178         (parseError):
3179         (processResult):
3180         (summarizeResults):
3181         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
3182
3183 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
3184
3185         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
3186         https://bugs.webkit.org/show_bug.cgi?id=185164
3187
3188         Reviewed by David Kilzer.
3189
3190         * Scripts/webkitpy/common/system/executive.py:
3191         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
3192         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
3193
3194 2018-05-01  Chris Dumez  <cdumez@apple.com>
3195
3196         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
3197         https://bugs.webkit.org/show_bug.cgi?id=184918
3198         <rdar://problem/39705516>
3199
3200         Reviewed by Wenson Hsieh.
3201
3202         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
3203         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
3204         asynchronously because we ask the client if it is OK to do the load and the policy
3205         delegates are asynchronous nowadays.
3206
3207         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3208         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
3209         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3210         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3211         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
3212         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
3213         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
3214
3215 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
3216
3217         [WinCairo] Align buildbot test stages with AppleWin.
3218         https://bugs.webkit.org/show_bug.cgi?id=185094
3219
3220         Reviewed by Brent Fulgham.
3221
3222         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3223         (TestFactory.__init__):
3224         Do run API tests, don't run dashboard tests.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3227         (RunUnitTests):
3228         Call run-api-tests with Python, not Perl (bugfix for r230998).
3229
3230         * Scripts/webkitpy/port/win.py:
3231         (WinPort.environment_for_api_tests):
3232         Retrieve necessary Windows environment variables.
3233
3234 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3235
3236         [MediaStream] remove WK1 support
3237         https://bugs.webkit.org/show_bug.cgi?id=185136
3238
3239         Reviewed by Youenn Fablet.
3240
3241         * DumpRenderTree/mac/UIDelegate.mm:
3242         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
3243
3244 2018-05-01  Chris Dumez  <cdumez@apple.com>
3245
3246         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
3247         https://bugs.webkit.org/show_bug.cgi?id=185157
3248
3249         Reviewed by Geoffrey Garen.
3250
3251         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
3252         common configuration and should therefore be the configuration we test by default.
3253
3254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3255         (WTR::InjectedBundlePage::decidePolicyForResponse):
3256
3257 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3258
3259         WebAssembly: add support for stream APIs - JavaScript API
3260         https://bugs.webkit.org/show_bug.cgi?id=183442
3261
3262         Reviewed by Yusuke Suzuki and JF Bastien.
3263
3264         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3265
3266 2018-04-30  Mark Lam  <mark.lam@apple.com>
3267
3268         Apply PtrTags to the MetaAllocator and friends.
3269         https://bugs.webkit.org/show_bug.cgi?id=185110
3270         <rdar://problem/39533895>
3271
3272         Reviewed by Saam Barati.
3273
3274         Update the test to match MetaAllocator changes in WTF.
3275
3276         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3277         (TestWebKitAPI::TEST_F):
3278         (WTF::tagForPtr):
3279         (WTF::ptrTagName):
3280
3281 2018-04-30  Alex Christensen  <achristensen@webkit.org>
3282
3283         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
3284         https://bugs.webkit.org/show_bug.cgi?id=180955
3285
3286         Reviewed by Andy Estes.
3287
3288         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
3289         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
3290         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
3291
3292 2018-04-30  JF Bastien  <jfbastien@apple.com>
3293
3294         Use some C++17 features
3295         https://bugs.webkit.org/show_bug.cgi?id=185135
3296
3297         Reviewed by Alex Christensen.
3298
3299         * DumpRenderTree/PlatformMac.cmake:
3300         * gtk/ycm_extra_conf.py:
3301         (FlagsForFile):
3302
3303 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3304
3305         Use WordLock instead of std::mutex for Threading
3306         https://bugs.webkit.org/show_bug.cgi?id=185121
3307
3308         Reviewed by Geoffrey Garen.
3309
3310         * TestWebKitAPI/Tests/WTF/Signals.cpp:
3311         (TEST):
3312
3313 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3314
3315         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
3316         https://bugs.webkit.org/show_bug.cgi?id=185103
3317
3318         Reviewed by Carlos Garcia Campos.
3319
3320         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3321         (TestWebKitAPI::TEST):
3322
3323 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
3324
3325         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
3326         https://bugs.webkit.org/show_bug.cgi?id=185052
3327
3328         Reviewed by Geoffrey Garen.
3329
3330         Modified API test to provide correct test cases for HTTPOnly flag.
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3333         (TEST):
3334
3335 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
3336
3337         Token misspelled "tocken" in error message string
3338         https://bugs.webkit.org/show_bug.cgi?id=185030
3339
3340         Reviewed by Saam Barati.
3341
3342         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
3343
3344 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
3345
3346         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
3347         https://bugs.webkit.org/show_bug.cgi?id=185049
3348
3349         Reviewed by Keith Miller.
3350
3351         * Scripts/run-javascriptcore-tests:
3352         (runJSCStressTests):
3353         * Scripts/run-jsc-stress-tests:
3354
3355 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3356
3357         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
3358         https://bugs.webkit.org/show_bug.cgi?id=185066
3359
3360         Reviewed by Youenn Fablet.
3361
3362         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
3363         WebKit should not swap WebContent process in this case.
3364
3365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3366         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3367         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3368
3369 2018-04-27  Nan Wang  <n_wang@apple.com>
3370
3371         AX: Accessibility needs to know which part of the content view is visible on iOS
3372         https://bugs.webkit.org/show_bug.cgi?id=185085
3373         <rdar://problem/39801363>
3374
3375         Reviewed by Chris Fleizach.
3376
3377         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3378         (WTR::AccessibilityUIElement::stringAttributeValue):
3379
3380 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3381
3382         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
3383         https://bugs.webkit.org/show_bug.cgi?id=185050
3384         <rdar://problem/39624038>
3385
3386         Reviewed by Tim Horton.
3387
3388         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
3389         tested by the layout test added in this patch.
3390
3391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3392         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
3393
3394 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
3395
3396         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
3397         https://bugs.webkit.org/show_bug.cgi?id=185061
3398
3399         Reviewed by Aakash Jain.
3400
3401         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3402         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
3403         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
3404
3405 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3406
3407         Add release bots for WinCairo.
3408         https://bugs.webkit.org/show_bug.cgi?id=185042
3409
3410         Reviewed by Lucas Forschler.
3411
3412         * BuildSlaveSupport/build.webkit.org-config/config.json:
3413         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
3414
3415 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
3416
3417         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
3418         https://bugs.webkit.org/show_bug.cgi?id=184938
3419         <rdar://problem/34737395>
3420
3421         Reviewed by Geoffrey Garen.
3422
3423         Add API test coverage.
3424
3425         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3426         (TEST):
3427
3428 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3429
3430         WinCairo test bots should run JSC tests with options for Windows command prompt.
3431         https://bugs.webkit.org/show_bug.cgi?id=185019
3432
3433         Reviewed by Per Arne Vollan.
3434
3435         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3436         (RunJavaScriptCoreTests.start):
3437
3438 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
3439
3440         WinCairo WKL Debug Test bot is not using DRT.
3441         https://bugs.webkit.org/show_bug.cgi?id=185009
3442
3443         Reviewed by Per Arne Vollan.
3444
3445         * BuildSlaveSupport/build.webkit.org-config/config.json:
3446
3447 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3448
3449         Disable content filtering in minimal simulator mode
3450         https://bugs.webkit.org/show_bug.cgi?id=185027
3451         <rdar://problem/39736091>
3452
3453         Reviewed by Jer Noble.
3454
3455         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3456
3457 2018-04-26  Brady Eidson  <beidson@apple.com>
3458
3459         Add a setting for keeping around all processes and always reusing them per-origin.
3460         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
3461
3462         Reviewed by Andy Estes.
3463
3464         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3465
3466 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3467
3468         [INTL] Implement Intl.PluralRules
3469         https://bugs.webkit.org/show_bug.cgi?id=184312
3470
3471         Reviewed by JF Bastien.
3472
3473         Added Intl.PluralRules feature flag.
3474
3475         * Scripts/webkitperl/FeatureList.pm:
3476         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3477
3478 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3479
3480         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
3481         https://bugs.webkit.org/show_bug.cgi?id=184643
3482
3483         Reviewed by Žan Doberšek.
3484
3485         Add missing INCLUDE_DIRS in many places.
3486
3487         Adapt to single-header WPE includes.
3488
3489         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
3490
3491         * TestWebKitAPI/PlatformWPE.cmake:
3492         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3493         (testWebViewWebBackend):
3494         * TestWebKitAPI/glib/PlatformWPE.cmake:
3495         * WebKitTestRunner/EventSenderProxy.h:
3496         * WebKitTestRunner/PlatformWPE.cmake:
3497         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3498         * wpe/HeadlessViewBackend/CMakeLists.txt:
3499         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3500         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3501         * wpe/jhbuild.modules:
3502
3503 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
3504
3505         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
3506         https://bugs.webkit.org/show_bug.cgi?id=184982
3507
3508         Rubber-stamped by Aakash Jain.
3509
3510         Correctly count the number of API test failures.
3511
3512         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3513         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
3514         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3515         * Scripts/webkitpy/api_tests/manager.py:
3516         (Manager.run): Disabled tests are not run.
3517
3518 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3519
3520         Remove access to keychain from the WebContent process
3521         https://bugs.webkit.org/show_bug.cgi?id=184428
3522         <rdar://problem/13150903>
3523
3524         Reviewed by Brent Fulgham.
3525
3526         This patch does the followings:
3527         1. Added an API test for this patch.
3528         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
3529
3530         * DumpRenderTree/mac/UIDelegate.mm:
3531         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
3532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3533         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
3534         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
3535         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
3536         (TestWebKitAPI::TEST_F):
3537         * WebKitTestRunner/TestController.cpp:
3538         (WTR::copySignedPublicKeyAndChallengeString):
3539         (WTR::TestController::createOtherPage):
3540         (WTR::TestController::createWebViewWithOptions):
3541
3542 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3543
3544         [Extra zoom mode] The search field on www.bing.com is missing label text
3545         https://bugs.webkit.org/show_bug.cgi?id=184975
3546         <rdar://problem/39723081>
3547
3548         Reviewed by Tim Horton.
3549
3550         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
3551         focused element in extra zoom mode.
3552
3553         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3554         (WTR::UIScriptController::formInputLabel const):
3555         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3556         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3557         (WTR::UIScriptController::formInputLabel const):
3558         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3559         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3560         (WTR::UIScriptController::formInputLabel const):
3561
3562 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3563
3564         [WPE] Should load injected bundle from builddir in developer builds
3565         https://bugs.webkit.org/show_bug.cgi?id=184983
3566
3567         Reviewed by Carlos Alberto Lopez Perez.
3568
3569         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
3570
3571         * Scripts/run-minibrowser:
3572
3573 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3574
3575         [WPE] libgstggtk.so broken in jhbuild environment
3576         https://bugs.webkit.org/show_bug.cgi?id=184984
3577
3578         Reviewed by Carlos Alberto Lopez Perez.
3579
3580         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
3581         gst-plugins-good.
3582
3583         * wpe/jhbuild.modules:
3584
3585 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3586
3587         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
3588         https://bugs.webkit.org/show_bug.cgi?id=184962
3589
3590         Reviewed by Youenn Fablet.
3591
3592         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
3593
3594         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3595         (ProcessSwap.SameOriginBlobNavigation): Added.
3596         (ProcessSwap.CrossOriginBlobNavigation): Added.
3597         (ProcessSwap.NavigateToAboutBlank): Added.
3598         (ProcessSwap.NavigateToDataURL): Added.
3599
3600 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3601
3602         [WPE] Remove deprecated functions and properties from the API
3603         https://bugs.webkit.org/show_bug.cgi?id=179295
3604
3605         Reviewed by Žan Doberšek.
3606
3607         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3608         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
3609         to rewrite LoadTrackingTest to not require the web view at construction time.
3610         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3611         (testWebKitSettings): Don't test private browsing setting, which is gone.
3612         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
3613
3614 2018-04-25  Andy Estes  <aestes@apple.com>
3615
3616         [Mac] Number of drop items is always 0 when performing a DHTML drag
3617         https://bugs.webkit.org/show_bug.cgi?id=184943
3618
3619         Reviewed by Ryosuke Niwa.
3620
3621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3622         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3623         (-[DragInfo numberOfValidItemsForDrop]):