1 2014-11-28 Andrzej Badowski <a.badowski@samsung.com>
3 [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
4 https://bugs.webkit.org/show_bug.cgi?id=139044
6 Reviewed by Chris Fleizach.
8 ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
9 The proposed solution will enable the use of this method for the object table.
10 Existing test shows the result.
12 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
13 (WTR::AccessibilityUIElement::columnHeaders):
15 2014-11-27 Ryuan Choi <ryuan.choi@navercorp.com>
17 [EFL] Remove E_Dbus dependency
18 https://bugs.webkit.org/show_bug.cgi?id=136355
20 Reviewed by Gyuyoung Kim.
22 * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
24 2014-11-26 Akos Kiss <akiss@inf.u-szeged.hu>
26 [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
27 https://bugs.webkit.org/show_bug.cgi?id=139047
29 Reviewed by Carlos Garcia Campos.
31 * efl/jhbuild.modules:
32 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
33 * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
34 * gtk/jhbuild-optional.modules:
35 * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
36 * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
38 2014-11-25 Tanay C <tanay.c@samsung.com>
40 [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
41 https://bugs.webkit.org/show_bug.cgi?id=138090
43 Reviewed by Carlos Garcia Campos.
45 * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
46 (browserWindowZoomIn): Added.
47 (browserWindowZoomOut): Added.
48 (scrollEventCallback): Added.
49 (zoomInCallback): Modified.
50 (zoomOutCallback): Modified.
51 (browserWindowConstructed): Modified.
53 2014-11-25 Csaba Osztrogonác <ossy@webkit.org>
55 [EFL] REGRESSION(r176514): It made performance tests fail
56 https://bugs.webkit.org/show_bug.cgi?id=139037
58 Reviewed by Gyuyoung Kim.
60 * Scripts/webkitpy/port/efl.py:
61 (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
62 * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
63 only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
65 2014-11-24 Michael Catanzaro <mcatanzaro@igalia.com>
67 [GTK] update-webkitgtk-libs fails to build fontconfig
68 https://bugs.webkit.org/show_bug.cgi?id=139032
70 Reviewed by Martin Robinson.
72 On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
73 fontconfig will try to generate documentation and fail.
75 * gtk/install-dependencies:
77 2014-11-24 Carlos Garcia Campos <cgarcia@igalia.com>
79 Unreviewed. Fix GTK+ make distcheck.
81 * gtk/manifest.txt: Remove deleted files.
83 2014-11-24 Krzysztof Czech <k.czech@samsung.com>
85 [EFL] Utilize Eail library to support accessibility in EFL
86 https://bugs.webkit.org/show_bug.cgi?id=137742
88 Reviewed by Gyuyoung Kim.
90 Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
92 * efl/jhbuild-optional.modules: Added.
93 * efl/jhbuild.modules:
95 2014-11-24 Carlos Garcia Campos <cgarcia@igalia.com>
97 [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
98 https://bugs.webkit.org/show_bug.cgi?id=139023
100 Reviewed by Sergio Villar Senin.
102 Rename WebKitWebView/default-context as WebKitWebView/web-context
103 and check we are always using the right context for new web views.
105 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
106 (testWebViewWebContext):
108 (testWebViewDefaultContext): Deleted.
110 2014-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
112 [GTK] Add API to override the default local storage directory
113 https://bugs.webkit.org/show_bug.cgi?id=138828
115 Reviewed by Gustavo Noronha Silva.
117 Add test to check that the local storage directory is created at
118 the path given on construction.
120 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
121 (testWebContextConfiguration):
123 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
125 (Test::~Test): Deleted.
127 2014-11-21 Zalan Bujtas <zalan@apple.com>
129 Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
130 https://bugs.webkit.org/show_bug.cgi?id=138981
132 Reviewed by Simon Fraser.
134 * MiniBrowser/mac/SettingsController.h:
135 * MiniBrowser/mac/SettingsController.m:
136 (-[SettingsController _populateMenu]):
137 (-[SettingsController validateMenuItem:]):
138 (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
139 (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
140 * MiniBrowser/mac/WK1BrowserWindowController.m:
141 (-[WK1BrowserWindowController didChangeSettings]):
142 * MiniBrowser/mac/WK2BrowserWindowController.m:
143 (-[WK2BrowserWindowController didChangeSettings]):
145 2014-11-21 Csaba Osztrogonác <ossy@webkit.org>
147 Remove http lock code from webkitperl
148 https://bugs.webkit.org/show_bug.cgi?id=138959
150 Reviewed by Alexey Proskuryakov.
152 * Scripts/webkitperl/httpd.pm:
154 (extractLockNumber): Deleted.
155 (getLockFiles): Deleted.
156 (getNextAvailableLockNumber): Deleted.
157 (getLockNumberForCurrentRunning): Deleted.
158 (waitForHTTPDLock): Deleted.
159 (scheduleHttpTesting): Deleted.
160 (getWaitTime): Deleted.
162 2014-11-20 Hunseop Jeong <hs85.jeong@samsung.com>
164 [EFL] The option value of fixed layout is false in MiniBrowser
165 https://bugs.webkit.org/show_bug.cgi?id=138830
167 Reviewed by Gyuyoung Kim.
169 Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
171 * MiniBrowser/efl/main.c:
173 2014-11-20 Adrian Perez de Castro <aperez@igalia.com>
175 [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
176 https://bugs.webkit.org/show_bug.cgi?id=138871
178 Reviewed by Carlos Garcia Campos.
180 Add a test case for the convenience API for posting user messages
181 added to the DOM bindings.
183 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
184 (testUserContentManagerMessageFromConvenienceDOMBindings):
186 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
187 (documentLoadedCallback):
189 2014-11-19 Dana Burkart <dburkart@apple.com>
191 Work around the fact that different masters may have different names for their codebases.
192 https://bugs.webkit.org/show_bug.cgi?id=138878
194 Reviewed by Mark Rowe.
196 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
197 (parseRevisionProperty): Changed.
198 Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
199 opensource / internal codebase naming convention.
201 2014-11-19 Chris Fleizach <cfleizach@apple.com>
203 AX: Screen braille input doesn't work on forms.
204 https://bugs.webkit.org/show_bug.cgi?id=138804
206 Unreviewed build fix.
208 * DumpRenderTree/AccessibilityUIElement.cpp:
209 (AccessibilityUIElement::setValue):
211 2014-11-19 Chris Fleizach <cfleizach@apple.com>
213 AX: Screen braille input doesn't work on forms.
214 https://bugs.webkit.org/show_bug.cgi?id=138804
216 Reviewed by Mario Sanchez Prada.
218 Add a method to setValue through the AX API in DRT.
220 * DumpRenderTree/AccessibilityUIElement.cpp:
222 (AccessibilityUIElement::getJSClass):
223 * DumpRenderTree/AccessibilityUIElement.h:
224 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
225 (AccessibilityUIElement::setValue):
226 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
227 (AccessibilityUIElement::setValue):
229 2014-11-18 Csaba Osztrogonác <ossy@webkit.org>
231 Remove the WinCairo buildbot
232 https://bugs.webkit.org/show_bug.cgi?id=138805
234 Reviewed by Alex Christensen.
236 * BuildSlaveSupport/build.webkit.org-config/config.json:
237 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
238 (appendCustomBuildFlags):
239 * BuildSlaveSupport/test-result-archive:
240 (archiveTestResults):
242 2014-11-18 Daniel Bates <dabates@apple.com>
244 [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
245 SPI are not available in public SDK
246 https://bugs.webkit.org/show_bug.cgi?id=138802
248 Reviewed by David Kilzer.
250 Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
252 * DumpRenderTree/mac/CheckedMalloc.cpp:
254 2014-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
256 Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
258 Forgot to fix this test before landing.
260 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
261 (testWebViewDefaultContext):
263 2014-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
265 [GTK] Add API to create a WebKitWebContext
266 https://bugs.webkit.org/show_bug.cgi?id=138826
268 Reviewed by Gustavo Noronha Silva.
270 Use a different WebKitWebContext for every test to ensure test
271 cases are independent to each other. Tests using DBus to
272 communicate with the injected bundle extension now use a unique
273 name for the well known DBus name.
275 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
276 (beforeAll): Remove comment about the order of the tests and
277 move the success test before the failed one now that tests don't
278 depend on each others.
279 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
280 (beforeAll): Remove call to set the web extensions directory,
281 since this is now done for all test in the Test constructor.
282 * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
283 (beforeAll): Do not create a temporary directory, a temporary data
284 directory is now created for all tests.
286 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
287 (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
288 to the web process test runner.
289 (testWebKitDOMNodeInsertion): Ditto.
290 (testWebKitDOMNodeTagNames): Ditto.
291 (beforeAll): Remove call to set the web extensions directory.
292 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
293 (runTest): Pass the web extension ID to the web process test runner.
294 (beforeAll): Remove call to set the web extensions directory.
295 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
296 (runTest): Pass the web extension ID to the web process test runner.
297 (beforeAll): Remove call to set the web extensions directory.
298 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
299 (createFileAtDestination): Use Test::dataDirectory() as base dir
301 (beforeAll): Do not create a temporary directory.
303 * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
304 (webkitFrameTestRun): Pass the web extension ID to the web process
306 (beforeAll): Remove call to set the web extensions directory.
307 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
308 (beforeAll): Remove call to set the web extensions directory.
309 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
310 (testProcessPerWebView): Use local member instead of global variable.
311 (testMultiprocessWebViewCreateReadyClose): Ditto.
312 (beforeAll): Do not connect to initialize-web-extensions, Test now
313 connects to the signal for all tests and calls a virtual method
314 that test can override.
316 (initializeWebExtensions): Deleted.
317 * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
318 (testPrintOperationPrint): Use Test::dataDirectory() as base dir
320 (beforeAll): Do not create a temporary directory.
322 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
323 (beforeAll): Remove call to set the web extensions directory.
324 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
325 (beforeAll): Remove comment about the tests order.
326 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
327 (testWebExtensionGetTitle): Build the DBus service name using the
329 (testDocumentLoadedSignal): Ditto.
330 (testWebKitWebViewProcessCrashed): Ditto.
331 (testWebExtensionIsolatedWorld): Ditto.
332 (beforeAll): Remove initialization-user-data test, since now all
333 tests are passing user data to the web extension.
334 (testWebExtensionInitializationUserData): Deleted.
335 (initializeWebExtensions): Deleted.
336 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
337 (testSetDirectory): Use the web context member inherited from Test.
338 (testClearDatabase): Ditto.
339 (testGetFaviconURI): Ditto.
340 (beforeAll): Do not create a temporary directory.
342 (webkitFaviconDatabaseFinalizedCallback): Deleted.
343 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
344 (UserContentManagerTest::UserContentManagerTest):
345 (beforeAll): Remove call to set the web extensions directory.
346 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
347 (testWebContextDefault): Check also that a newly create web
348 context is not the default web context.
349 (testWebContextSpellChecker): Use the web context member inherited
351 (testWebContextLanguages): Ditto.
352 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
353 (methodCallCallback): Remove GetInitializationUserData method.
354 (webkit_web_extension_initialize_with_user_data): Always create
355 the DBus name using the user data provided.
356 (makeBusName): Deleted.
357 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
358 (webkit_web_extension_initialize_with_user_data): Create the DBus
359 name using the user data provided.
360 (webkit_web_extension_initialize): Deleted.
361 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
362 (Test::dataDirectory): Return the temporary data directory.
363 (removeNonEmptyDirectory): Also remove directories recursively.
364 (main): Remove the disk cache directory initialization, since this
365 is now done in the Test constructor.
366 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
367 (Test::initializeWebExtensionsCallback): Call the virtual method
368 initializeWebExtensions()
369 (Test::Test): Create a new WebKitWebContext and initialize it.
370 (Test::~Test): Disconnect initialize-web-extensions signal.
371 (Test::initializeWebExtensions): Set the web extensions directory
373 * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
374 (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
375 (WebProcessTestRunner::runTest): Build the DBus proxy using a
376 unique name created with the Test web extension ID.
377 (WebProcessTestRunner::proxy): Deleted.
378 * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
379 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
380 (WebViewTest::WebViewTest): Create the web view with the Test web
382 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
383 content manager parameter to the constructor.
385 2014-11-18 ChangSeok Oh <changseok.oh@collabora.com>
387 [GTK] Mesa build fails over llvm-3.5
388 https://bugs.webkit.org/show_bug.cgi?id=138825
390 Reviewed by Gustavo Noronha Silva.
392 OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
394 * gtk/jhbuild.modules:
395 * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
397 2014-11-17 Daniel Bates <dabates@apple.com>
399 Unreviewed, rolling out r176232.
401 Broke the Mac build. Will investigate offline.
405 "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
407 https://bugs.webkit.org/show_bug.cgi?id=138802
408 http://trac.webkit.org/changeset/176232
410 2014-11-17 Daniel Bates <dabates@apple.com>
412 [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
413 SPI are not available in public SDK
414 https://bugs.webkit.org/show_bug.cgi?id=138802
416 Reviewed by David Kilzer.
418 Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
420 * DumpRenderTree/mac/CheckedMalloc.cpp:
422 2014-11-17 Jake Nielsen <jacob_nielsen@apple.com>
424 Having 30+ flaky failures breaks EWS
425 https://bugs.webkit.org/show_bug.cgi?id=138743
427 Reviewed by Alexey Proskuryakov.
429 Adds tests to ensure that the problem has been solved.
430 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
431 (test_first_failure_limit):
432 (test_first_failure_limit_with_some_tree_redness):
433 (test_second_failure_limit):
434 (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
435 (test_first_and_second_failure_limit):
436 (test_first_and_clean_failure_limit):
437 (test_first_second_and_clean_failure_limit):
438 (test_very_red_tree_retry): Deleted.
439 Really this was renamed to test_first_second_and_clean_failure_limit.
440 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
441 Makes the appropriate changes to PatchAnalysisTask to make sure that
442 even when the first test run hits the failure limit, it will still try
444 (PatchAnalysisTask._results_failed_different_tests):
445 (PatchAnalysisTask._test_patch):
446 (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
448 2014-11-17 Ting-Wei Lan <lantw44@gmail.com>
450 [GTK] Add library search paths from LDFLAGS before pkg-config --libs
451 https://bugs.webkit.org/show_bug.cgi?id=136018
453 Reviewed by Carlos Garcia Campos.
455 It is possible that the order of -L arguments in the output of
456 pkg-config is wrong, which causes the linker to find the wrong
457 version (usually older version) of libraries when running
461 (GTKDoc._run_gtkdoc_scangobj):
463 2014-11-17 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
465 Bump EFL version to 1.12.0
466 https://bugs.webkit.org/show_bug.cgi?id=138733
468 Reviewed by Gyuyoung Kim.
470 * efl/jhbuild.modules:
472 2014-11-16 Joanmarie Diggs <jdiggs@igalia.com>
474 AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
475 https://bugs.webkit.org/show_bug.cgi?id=138771
477 Reviewed by Chris Fleizach.
479 Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
481 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
483 2014-11-15 Joanmarie Diggs <jdiggs@igalia.com>
485 AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
486 https://bugs.webkit.org/show_bug.cgi?id=138767
488 Reviewed by Chris Fleizach.
490 Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
492 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
494 2014-11-14 Alexey Proskuryakov <ap@apple.com>
496 Add shortcut macros to Mac TestExpectations
497 https://bugs.webkit.org/show_bug.cgi?id=138729
499 Reviewed by Simon Fraser.
501 * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
502 Add version macros for current OS versions.
504 2014-11-13 Alexey Proskuryakov <ap@apple.com>
506 https://bugs.webkit.org/show_bug.cgi?id=138628
507 A patch that doesn't apply is stuck in commit queue
509 Rubber-stamped by David Kilzer.
511 This also hopefully fixes other issues:
512 - a patch that has cq+ flag set by a non-committer kills commit queue;
513 - EWS never reports failing tests, and keeps spinning instead.
515 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
516 (Bugzilla.set_flag_on_attachment):
517 (Bugzilla.obsolete_attachment):
518 Apply the fix from r174797 to more places.
520 2014-11-13 Dan Bernstein <mitz@apple.com>
522 Policy client not called for navigations through the page cache
523 https://bugs.webkit.org/show_bug.cgi?id=138703
525 Reviewed by Alexey Proskuryakov.
527 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
528 (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
529 (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
531 2014-11-13 Joanmarie Diggs <jdiggs@igalia.com>
533 AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
534 https://bugs.webkit.org/show_bug.cgi?id=137867
536 Reviewed by Chris Fleizach.
538 Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
539 AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
540 able to test for the presence of ATK_ROLE_INVALID.
542 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
543 (WTR::AccessibilityUIElement::role):
545 2014-11-13 Juergen Ributzka <juergen@apple.com>
547 Update the "combineModules" script to handel more LLVM metadata.
548 https://bugs.webkit.org/show_bug.cgi?id=138514
550 Reviewed by Filip Pizlo.
552 * ReducedFTL/combineModules.rb:
554 2014-11-13 Myles C. Maxfield <mmaxfield@apple.com>
556 Allow constructing a base PassRef with a derived Ref
557 https://bugs.webkit.org/show_bug.cgi?id=138701
559 Reviewed by Andreas Kling
561 * TestWebKitAPI/Tests/WTF/Ref.cpp:
562 (TestWebKitAPI::passWithPassRef):
563 (TestWebKitAPI::passWithPassRefPtr):
564 (TestWebKitAPI::TEST):
566 2014-11-05 Ada Chan <adachan@apple.com>
568 Implement new plug-in API for muting plug-ins
569 https://bugs.webkit.org/show_bug.cgi?id=138105
571 Reviewed by Anders Carlsson.
573 Add a new plug-in test for the mute API.
575 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
576 * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
577 (SetMuted::SetMuted):
579 (SetMuted::cachedIsMuted):
580 (SetMuted::ScriptableObject::hasProperty):
581 (SetMuted::ScriptableObject::getProperty):
582 (SetMuted::ScriptableObject::pluginTest):
584 (SetMuted::NPP_GetValue):
585 (SetMuted::NPP_SetValue):
587 2014-11-12 Philippe Normand <pnormand@igalia.com>
589 Unreviewed, GTK gardening.
591 * Scripts/run-gtk-tests:
592 (TestRunner): Skip the UserMediaBasic test because it depends on
593 constraints validation which is going to be fixed in bug #136449.
595 2014-11-12 Carlos Garcia Campos <cgarcia@igalia.com>
597 [GTK] Expose user script messages to GObject DOM bindings
598 https://bugs.webkit.org/show_bug.cgi?id=138411
600 Reviewed by Philippe Normand.
602 Add a test case to check that user script messages sent using the
603 DOM bindings API are also received in the UI process.
605 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
606 (UserScriptMessageTest::waitUntilMessageReceived):
607 (UserScriptMessageTest::postMessageAndWaitUntilReceived):
608 (testUserContentManagerScriptMessageFromDOMBindings):
610 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
611 (documentLoadedCallback):
613 2014-11-12 Carlos Garcia Campos <cgarcia@igalia.com>
615 Unreviewed. Fix GTK+ clean build after r175930.
617 Partial rollout of r175930 to not build the new unit test that
618 broke clean builds in GTK+ port.
620 * TestWebKitAPI/PlatformGTK.cmake:
622 2014-09-01 Philippe Normand <pnormand@igalia.com>
624 [WK2] UserMediaClient support
625 https://bugs.webkit.org/show_bug.cgi?id=123158
627 Reviewed by Benjamin Poulain.
629 Simple API test for the UserMedia permission request API. The
630 required test infrastructure is also added, inspired by the
631 Geolocation infrastructure.
633 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
635 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
636 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
637 (TestWebKitAPI::TEST):
638 * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
639 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
640 helper method to set the permission request result without user interaction.
641 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
642 (WTR::InjectedBundle::setUserMediaPermission):
643 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
644 * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
645 (WTR::TestRunner::setUserMediaPermission):
646 * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
647 * WebKitTestRunner/TestController.cpp:
648 (WTR::decidePolicyForUserMediaPermissionRequest): Permission
650 (WTR::TestController::createOtherPage): Enable the new UserMedia
651 permission request handler.
652 (WTR::TestController::createWebViewWithOptions): Ditto.
653 (WTR::TestController::resetPreferencesToConsistentValues): Enable
654 MediaStream support, this is needed for getUserMedia.
655 (WTR::TestController::resetStateToConsistentValues): clear
656 UserMedia permissions list and flags.
657 (WTR::TestController::setUserMediaPermission): Set permission
658 request result and distpatch it.
659 (WTR::TestController::handleUserMediaPermissionRequest): Save
660 request and dispatch it.
661 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
662 Dispatch cached permission requests.
663 * WebKitTestRunner/TestController.h:
664 * WebKitTestRunner/TestInvocation.cpp:
665 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
667 2014-11-11 David Kilzer <ddkilzer@apple.com>
669 webkit-patch --suggest-reviewers is broken with newer versions of git
670 <http://webkit.org/b/138627>
672 Reviewed by Michael Saboff with feedback from Daniel Bates.
674 * Scripts/webkitpy/common/checkout/scm/git.py:
675 (Git._changes_files_for_commit): Strip blank lines instead of
676 assuming there is always a blank line at the beginning of the
679 2014-11-11 Alexey Proskuryakov <ap@apple.com>
681 DRT and WKTR touch disk cache
682 https://bugs.webkit.org/show_bug.cgi?id=138622
684 Reviewed by Geoffrey Garen.
686 * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
687 Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
688 because this function uses the shared cache.
690 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
691 Create an empty shared cache to prevent a default one from being created on disk.
693 2014-10-07 Sergio Villar Senin <svillar@igalia.com>
695 [CSS Grid Layout] Limit the size of explicit/implicit grid
696 https://bugs.webkit.org/show_bug.cgi?id=136217
698 Reviewed by Andreas Kling.
700 Added a new unit test for the CSS parser. Right now it only checks
701 that we properly clamp the maximum number of tracks on a grid to a
702 maximum of 1 million.
704 * TestWebKitAPI/CMakeLists.txt:
705 * TestWebKitAPI/PlatformEfl.cmake:
706 * TestWebKitAPI/PlatformGTK.cmake:
707 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708 * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
709 (TestWebKitAPI::computeNumberOfTracks): Helper function.
710 (TestWebKitAPI::TEST): Added a
711 CSSPropertyParserTest.GridTrackLimits test case.
713 2014-11-11 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
715 webkitpy test fix after r175867
716 https://bugs.webkit.org/show_bug.cgi?id=138607
718 Reviewed by Philippe Normand.
720 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
721 (GDBCrashLogGeneratorTest.test_generate_crash_log):
723 2014-11-10 Philippe Normand <pnormand@igalia.com>
725 webkitpy: demangle C++ symbols from crash log stderr
726 https://bugs.webkit.org/show_bug.cgi?id=138565
728 Reviewed by Alexey Proskuryakov.
730 * Scripts/webkitpy/port/linux_get_crash_log.py:
731 (GDBCrashLogGenerator.generate_crash_log): Process stderr output
734 2014-11-10 Philippe Normand <pnormand@igalia.com>
736 [GTK] fix up the GDB backtrace report tool
737 https://bugs.webkit.org/show_bug.cgi?id=138564
739 Reviewed by Carlos Garcia Campos.
741 * Scripts/webkitpy/port/gtk.py:
742 (GtkPort._get_crash_log): Match the process name reported by the
743 driver with the GTK port WebProcess executable filename.
744 * Scripts/webkitpy/port/linux_get_crash_log.py:
745 (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
747 (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
748 pattern to workaround the 16 characters size limit of %e.
750 2014-11-10 Conrad Shultz <conrad_shultz@apple.com>
752 Unreviewed, moved myself to the list of committers.
754 * Scripts/webkitpy/common/config/contributors.json:
756 2014-11-10 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
758 [EFL] Fix the test font path after r175555.
760 Reviewed by Csaba Osztrogonác.
762 * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
764 2014-11-10 Akos Kiss <akiss@inf.u-szeged.hu>
766 Fix the exception fuzz helper to generate targets in the correct range
767 https://bugs.webkit.org/show_bug.cgi?id=138544
769 Reviewed by Filip Pizlo.
771 Currently, the script generates exception fuzz targets in the range of
772 0..($checkCount-1). However, target 0 is never hit, while target 1 is
773 always outside of the outermost try block of the tests, which therefore
774 prints unexpected output and results in false failures when fired at.
775 Additionally, target $checkCount is never generated.
777 This patch fixes the script to generate targets in the range of
780 * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
782 2014-11-09 Csaba Osztrogonác <ossy@webkit.org>
784 make-passwords-json.py should generarate everything needed for testing
785 https://bugs.webkit.org/show_bug.cgi?id=138503
787 Reviewed by Ryosuke Niwa.
789 * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
790 Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
791 Additionally generate auth.json, credentials.cfg and committers.cfg too.
792 (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
793 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
794 (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
795 (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
797 2014-11-09 Carlos Garcia Campos <cgarcia@igalia.com>
799 [GTK] generate-gtkdoc should ignore invalid files
800 https://bugs.webkit.org/show_bug.cgi?id=138542
802 Reviewed by Darin Adler.
804 * gtk/generate-gtkdoc:
805 (files_to_ignore.file_should_be_ignored): Return True to ignore
808 2014-11-08 Alexey Proskuryakov <ap@apple.com>
810 Delete cookies between tests
811 https://bugs.webkit.org/show_bug.cgi?id=138528
813 Reviewed by Sam Weinig.
815 * DumpRenderTree/mac/DumpRenderTree.mm:
816 (resetWebPreferencesToConsistentValues):
817 * WebKitTestRunner/TestController.cpp:
818 (WTR::TestController::resetPreferencesToConsistentValues):
821 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
822 (WTR::InjectedBundle::beginTesting):
825 2014-11-08 Carlos Garcia Campos <cgarcia@igalia.com>
827 [GTK] Run layout tests using the network process
828 https://bugs.webkit.org/show_bug.cgi?id=138428
830 Reviewed by Martin Robinson.
832 Shared secondary process is the default in the GTK+ port, but we
833 should run the tests using the network process to ensure
834 everything works with the network process. In the future, the
835 shared secondary process model might be a special case of multiple
836 processes with 1 as maximum number of processes, but always using
839 * WebKitTestRunner/TestController.cpp:
840 (WTR::TestController::initialize):
842 2014-11-08 Carlos Garcia Campos <cgarcia@igalia.com>
844 [GTK] Allow to create a view with a related page in WTR
845 https://bugs.webkit.org/show_bug.cgi?id=138501
847 Reviewed by Martin Robinson.
849 * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
850 (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
851 related page to WKViewCreate.
852 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
853 (WTR::PlatformWebView::PlatformWebView): Pass the given related
854 page to WKViewCreate.
856 2014-11-08 Carlos Garcia Campos <cgarcia@igalia.com>
858 WTR crashes after running a test when NetworkProcess enabled
859 https://bugs.webkit.org/show_bug.cgi?id=138500
861 Reviewed by Alexey Proskuryakov.
863 WebNotificationProvider destructor is calling
864 WKNotificationManagerSetProvider, but m_notificationManager is
865 null because removeNotificationManager was already called.
867 * WebKitTestRunner/WebNotificationProvider.cpp:
868 (WTR::WebNotificationProvider::~WebNotificationProvider): Check
869 m_notificationManager is not null before calling WKNotificationManagerSetProvider.
871 2014-11-06 Jake Nielsen <jacob_nielsen@apple.com>
873 Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
874 regarding incorrect call to PatchAnalysisTask.report_failure
875 https://bugs.webkit.org/show_bug.cgi?id=138229
877 Reviewed by Daniel Bates.
879 * Scripts/webkitpy/common/net/layouttestresults.py:
880 Makes sure test_results returns a list.
881 (LayoutTestResults.test_results):
882 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
883 Makes unit tests also check to make sure
884 task.results_from_patch_test_run() and
885 task.results_from_test_run_without_patch return instances of
887 (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
888 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
889 Condenses duplicate code into _should_defer_patch_or_throw, and
890 removes the now-unused _clean_tree_results member.
891 (PatchAnalysisTask.__init__):
892 (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
893 (PatchAnalysisTask._should_defer_patch_or_throw):
894 (PatchAnalysisTask._test_patch):
895 (PatchAnalysisTask.results_from_patch_test_run):
896 (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
897 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
898 Removes needless call to results_from_test_run_without_patch
899 (AbstractEarlyWarningSystem._failing_tests_message):
900 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
901 Changes order of test failure messages to be in the order that they
903 (AbstractEarlyWarningSystemTest.test_failing_tests_message):
904 * Scripts/webkitpy/tool/commands/queues.py:
905 Removes needless call to results_from_test_run_without_patch.
906 (CommitQueue._failing_tests_message):
907 * Scripts/webkitpy/tool/commands/queues_unittest.py:
908 (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
910 2014-11-06 Ryuan Choi <ryuan.choi@navercorp.com>
912 Unreviewed. Reorder my e-mail addresses in contributors.json
914 * Scripts/webkitpy/common/config/contributors.json:
916 2014-11-06 Matthew Hanson <matthew_hanson@apple.com>
918 Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
919 https://bugs.webkit.org/show_bug.cgi?id=138475
921 Reviewed by Ryosuke Niwa.
923 The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
924 This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
925 explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
926 renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
928 * Scripts/webkitpy/common/checkout/scm/git.py:
929 (Git._run_git_svn_find_rev):
930 Add comment mentioning that svn_revisions need to begin with 'r'.
931 Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
932 Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
933 Remove code that coerced the revision/treeish into a string and prepended an 'r'.
935 2014-11-06 Carlos Garcia Campos <cgarcia@igalia.com>
937 [GTK] Add context menu API to Web Process Extensions
938 https://bugs.webkit.org/show_bug.cgi?id=138311
940 Reviewed by Gustavo Noronha Silva.
942 Add tests cases for WebKitWebPage::context-menu signal.
944 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
945 (testContextMenuWebExtensionMenu):
946 (testContextMenuWebExtensionNode):
948 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
949 (serializeContextMenu):
951 (contextMenuCallback):
952 (pageCreatedCallback):
954 2014-11-06 Commit Queue <commit-queue@webkit.org>
956 Unreviewed, rolling out r175690.
957 https://bugs.webkit.org/show_bug.cgi?id=138460
959 We are not ready to run layout tests using the network process
960 yet (Requested by KaL on #webkit).
964 "[GTK] Run layout tests using the network process"
965 https://bugs.webkit.org/show_bug.cgi?id=138428
966 http://trac.webkit.org/changeset/175690
968 2014-11-06 Carlos Garcia Campos <cgarcia@igalia.com>
970 [GTK] Run layout tests using the network process
971 https://bugs.webkit.org/show_bug.cgi?id=138428
973 Reviewed by Martin Robinson.
975 Shared secondary process is the default in the GTK+ port, but we
976 should run the tests using the network process to ensure
977 everything works with the network process. In the future, the
978 shared secondary process model might be a special case of multiple
979 processes with 1 as maximum number of processes, but always using
982 * WebKitTestRunner/TestController.cpp:
983 (WTR::TestController::initialize):
985 2014-11-05 Dan Bernstein <mitz@apple.com>
987 Remove the unused deletion UI feature
988 https://bugs.webkit.org/show_bug.cgi?id=138442
990 Rubber-stamped by Alexey Proskuryakov.
992 * DumpRenderTree/mac/EditingDelegate.mm:
993 (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
994 delegate method that’s been removed.
996 2014-11-05 Alexey Proskuryakov <ap@apple.com>
998 fast/dom/remove-body-during-body-replacement2.html fails on WK2
999 https://bugs.webkit.org/show_bug.cgi?id=138334
1001 Reviewed by Anders Carlsson.
1003 Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1004 calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1005 -makeFirstResponder calls, which may or may not be needed for other reasons, but
1006 it also needs to reset internal focus explicitly.
1008 It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1009 WebKit behavior appears wrong, but it matches Firefox.
1011 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1012 (WTR::InjectedBundlePage::resetAfterTest):
1014 2014-11-05 Carlos Garcia Campos <cgarcia@igalia.com>
1016 [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1017 https://bugs.webkit.org/show_bug.cgi?id=137862
1019 Reviewed by Gustavo Noronha Silva.
1021 Add a test case to check that WebKitWebResource::failed-with-tls-errors
1022 is emitted when a subresource load fails due to TLS errors.
1024 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1025 (TLSSubresourceTest::resourceLoadStartedCallback):
1026 (TLSSubresourceTest::TLSSubresourceTest):
1027 (TLSSubresourceTest::subresourceFailedCallback):
1028 (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1029 (TLSSubresourceTest::subresourceLoadStarted):
1030 (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1031 (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1032 (testSubresourceLoadFailedWithTLSErrors):
1033 (httpsServerCallback):
1034 (httpServerCallback):
1037 2014-11-05 Alexey Proskuryakov <ap@apple.com>
1039 Build fix for some compiler versions.
1041 * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1042 unhappy because this is a getter, and these shouldn't have side effects.
1044 2014-11-04 Matthew Hanson <matthew_hanson@apple.com>
1046 Add a method for performing cherrypick-merges.
1047 https://bugs.webkit.org/show_bug.cgi?id=138375
1049 Reviewed by Ryosuke Niwa.
1051 Adds support for cherrypick-merges.
1053 * Scripts/webkitpy/common/checkout/scm/git.py:
1054 (Git.cherrypick_merge): Added.
1056 2014-11-04 Matthew Hanson <matthew_hanson@apple.com>
1058 Add a way to ascertain the SVN URL associated with a Git branch.
1059 https://bugs.webkit.org/show_bug.cgi?id=138374
1061 Reviewed by Ryosuke Niwa.
1063 The svn_url method returns the SVN URL associated with the current Git branch.
1065 * Scripts/webkitpy/common/checkout/scm/git.py:
1066 (Git.svn_url): Added.
1068 2014-11-04 Matthew Hanson <matthew_hanson@apple.com>
1070 Add the ability to search for modifications that are staged for commit.
1071 https://bugs.webkit.org/show_bug.cgi?id=138373
1073 Reviewed by Ryosuke Niwa and Daniel Bates.
1075 This makes is easy to do identify files that require merge post-processing,
1076 in addition to stand-alone utility.
1078 * Scripts/webkitpy/common/checkout/scm/git.py:
1079 (Git.modifications_staged_for_commit): Added.
1081 2014-11-04 Matthew Hanson <matthew_hanson@apple.com>
1083 Add a branch keyword argument to _run_git_svn_find_rev.
1084 https://bugs.webkit.org/show_bug.cgi?id=138372
1086 Reviewed by Ryosuke Niwa.
1088 The addition of this keyword argument allows clients to determine the Git hash
1089 of commits made on an SVN branch, provided that branch has been fetched locally.
1091 * Scripts/webkitpy/common/checkout/scm/git.py:
1092 (Git._run_git_svn_find_rev):
1093 Add a branch keyword argument that is added to the end of the command, if present.
1095 2014-11-04 Chris Dumez <cdumez@apple.com>
1097 Add ptr() method to Ref class
1098 https://bugs.webkit.org/show_bug.cgi?id=138361
1100 Reviewed by Darin Adler.
1102 Use the new Ref::ptr() method.
1104 * TestWebKitAPI/Tests/WTF/Ref.cpp:
1105 (TestWebKitAPI::TEST):
1107 2014-11-04 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1109 [jhbuild] Make it possible to build GTK/EFL in same repository
1110 https://bugs.webkit.org/show_bug.cgi?id=137448
1112 Reviewed by Martin Robinson.
1114 * Scripts/webkitdirs.pm:
1116 * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1117 (getPlatformFontsPath):
1118 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1119 (WTR::getFontsPath):
1120 * jhbuild/jhbuild-wrapper:
1121 (determine_platform):
1123 * jhbuild/jhbuildrc_common.py:
1126 2014-11-04 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com>
1128 [EFL] Bump LLVM to version 3.5.0
1129 https://bugs.webkit.org/show_bug.cgi?id=138312
1131 Reviewed by Csaba Osztrogonác.
1133 * efl/jhbuild.modules:
1134 * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1135 * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1137 2014-11-03 Simon Fraser <simon.fraser@apple.com>
1139 Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1140 https://bugs.webkit.org/show_bug.cgi?id=138257
1142 Reviewed by Tim Horton.
1144 Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1145 the user to toggle region page overlays on and off. Two overlays are available,
1146 for the non-fast scrollable region, and the region of element with wheel
1149 * MiniBrowser/mac/SettingsController.h:
1150 * MiniBrowser/mac/SettingsController.m:
1151 (-[SettingsController _populateMenu]):
1152 (-[SettingsController validateMenuItem:]):
1153 (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1154 (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1155 (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1156 (-[SettingsController toggleDebugOverlay:]):
1157 (-[SettingsController debugOverlayVisible:]):
1158 * MiniBrowser/mac/WK2BrowserWindowController.m:
1159 (-[WK2BrowserWindowController didChangeSettings]):
1161 2014-11-03 Alexey Proskuryakov <ap@apple.com>
1163 REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1164 https://bugs.webkit.org/show_bug.cgi?id=138323
1166 Reviewed by Zalan Bujtas.
1168 * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1170 2014-11-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1172 [ninja] Don't remove response files for verbose builds
1173 https://bugs.webkit.org/show_bug.cgi?id=137816
1175 Reviewed by Csaba Osztrogonác.
1177 * Scripts/webkitdirs.pm:
1178 (determineNinjaVersion):
1179 (buildCMakeGeneratedProject):
1181 2014-11-02 Akos Kiss <akiss@inf.u-szeged.hu>
1183 [GTK] Fix the build of FTL JIT
1184 https://bugs.webkit.org/show_bug.cgi?id=138298
1186 Reviewed by Carlos Garcia Campos.
1188 * gtk/jhbuild-optional.modules:
1189 Bump up LLVM version to 3.5.0 release and apply patches.
1190 * gtk/patches/llvm-elf-add-stackmaps.patch:
1191 Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1193 * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1194 Added. Ensures that PC-relative relocations in EH frames are not
1195 truncated to 32 bits on x86_64.
1197 2014-10-31 Michael Saboff <msaboff@apple.com>
1199 No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1200 https://bugs.webkit.org/show_bug.cgi?id=138268
1202 Reviewed by Andreas Kling.
1204 Added a --arch and --os option to set or override the values that are
1205 normally computed based on examining the JavaScriptCore we want to test.
1207 * Scripts/run-jsc-stress-tests:
1209 2014-10-31 Dan Bernstein <mitz@apple.com>
1211 llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1212 https://bugs.webkit.org/show_bug.cgi?id=138259
1214 Reviewed by Geoff Garen.
1216 * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1217 going to be empty to silence the warning.
1219 2014-10-31 Adrian Perez de Castro <aperez@igalia.com>
1221 [GTK] Support script message handlers WebKitUserContentManager
1222 https://bugs.webkit.org/show_bug.cgi?id=133730
1224 Reviewed by Carlos Garcia Campos.
1226 Support user script message handlers in WebKitUserContentManager.
1227 This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1228 an option is added to the CMake build files. The option is disabled
1229 globally by default, and the WebKitGTK port enables it. On the API
1230 level, two new methods to register and unregister names are provided
1231 in the "window.webkit" namespace, and on message reception the
1232 "WebKitUserContentManager::script-message-received" signal is
1233 emitted, using the registered names as signal detail.
1235 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1236 Add test case for user script message handlers.
1237 (scriptMessageReceived):
1238 (testUserContentManagerScriptMessageReceived):
1241 2014-10-30 Matthew Hanson <matthew_hanson@apple.com>
1243 bisect-builds should support WebKit clients other than Safari
1244 https://bugs.webkit.org/show_bug.cgi?id=138225
1246 This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1248 The -a / --application optional argument allows the user to specify which application (or application bundle)
1249 should be run against the WebKit nightly builds.
1251 Reviewed by David Kilzer.
1253 * Scripts/bisect-builds:
1254 Swap out $safariPath for the more general $applicationPath
1255 Leave --safari-path as a commandline option for backwards compatibility
1256 (mountAndRunNightly):
1257 Use File::Spec->cat correctly (one directory per argument)
1258 Use open --wait-apps instead of running the target application directly
1260 2014-10-30 Dana Burkart <dburkart@apple.com>
1262 <rdar://problem/18821260> Perpare for the mysterious future
1264 Reviewed by Lucas Forschler.
1266 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1267 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1268 * LayoutTestRelay/Configurations/Base.xcconfig:
1269 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1270 * MiniBrowser/Configurations/Base.xcconfig:
1271 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1272 * TestWebKitAPI/Configurations/Base.xcconfig:
1273 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1274 * WebKitLauncher/Configurations/Base.xcconfig:
1275 * WebKitTestRunner/Configurations/Base.xcconfig:
1276 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1278 2014-10-30 Matthew Hanson <matthew_hanson@apple.com>
1280 Update safariVersion to safariVersionString
1281 https://bugs.webkit.org/show_bug.cgi?id=138193
1283 The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1284 but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1286 Rubber-stamped by David Kilzer.
1288 * Scripts/bisect-builds:
1290 Compare safariVersionString to a string literal, instead of safariVersion.
1292 2014-10-30 Rohit Kumar <kumar.rohit@samsung.com>
1294 [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1295 https://bugs.webkit.org/show_bug.cgi?id=137775
1297 Reviewed by Carlos Garcia Campos.
1299 * MiniBrowser/gtk/BrowserWindow.c:
1300 (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1301 (browser_window_init):
1303 2014-10-29 Jake Nielsen <jacob_nielsen@apple.com>
1305 CommitQueue and EWS should reject any patches that result in consistent test
1306 failures that aren't present on the tree.
1307 https://bugs.webkit.org/show_bug.cgi?id=138184
1309 Reviewed by Alexey Proskuryakov.
1311 * Scripts/webkitpy/layout_tests/models/test_results.py:
1312 Adds a simple hashing function to allow for set operations to handle
1313 TestResult objects properly.
1314 (TestResult.__hash__):
1315 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1316 Adds one unit test, and modifies others to agree with the notion that
1317 patches that introduce new test failures (but also have flakyness)
1318 should be rejected rather than spin.
1319 (MockCommitQueue.report_flaky_tests):
1320 (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1321 (test_double_flaky_test_failure):
1322 (test_two_flaky_tests):
1323 (test_very_flaky_patch):
1324 (test_very_flaky_patch_with_some_tree_redness):
1325 (test_different_test_failures):
1326 (test_different_test_failures_with_some_tree_redness):
1327 (test_different_test_failures_with_some_tree_redness_and_some_fixes):
1328 (test_mildly_flaky_patch):
1329 (test_mildly_flaky_patch_with_some_tree_redness):
1330 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1331 Makes PatchAnalysisTask reject said patches.
1332 (PatchAnalysisTask._test_patch):
1334 2014-10-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
1336 WinCairoRequirements.zip cannot be downloaded from dropbox
1337 https://bugs.webkit.org/show_bug.cgi?id=138113
1339 Reviewed by Alexey Proskuryakov.
1341 * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
1343 2014-10-29 Matthew Hanson <matthew_hanson@apple.com>
1345 bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
1346 https://bugs.webkit.org/show_bug.cgi?id=138193
1348 This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
1349 for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
1351 It also does a bit of refactoring, including distinguishing between versions and version strings and
1352 saving versions to local variables instead of using eval in each conditional.
1354 Reviewed by David Kilzer.
1356 * Scripts/bisect-builds:
1358 Restrict the set of nightlies to r174650 and above when running Yosemite.
1359 Restrict the set of nightlies to r157846 and above when running Mavericks.
1360 Restrict the set of nightlies to r122421 and above when running Mountain Lion.
1362 2014-10-29 Csaba Osztrogonác <ossy@webkit.org>
1364 [EFL] build-webkit should try harder to avoid re-running cmake
1365 https://bugs.webkit.org/show_bug.cgi?id=137949
1367 Reviewed by Martin Robinson.
1369 * Scripts/webkitdirs.pm:
1370 (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
1371 (generateBuildSystemFromCMakeProject): Comment fix after r174681.
1373 2014-10-28 Daniel Bates <dabates@apple.com>
1375 Unify logic in RunTests.run() to run the Python unit tests
1376 https://bugs.webkit.org/show_bug.cgi?id=138160
1378 Reviewed by Martin Robinson.
1380 Unify the interactive and non-interactive code path for running the Python unit tests
1381 in step RunTests so as to remove duplicate code to compute the the path to the script
1382 test-webkitpy and log an informative message ("Running Python unit tests") to the console.
1384 No new tests since no functionality was changed.
1386 * Scripts/webkitpy/port/base.py:
1387 (Port.python_unittest_results_directory):
1388 * Scripts/webkitpy/tool/steps/runtests.py:
1391 2014-10-28 Jake Nielsen <jacob_nielsen@apple.com>
1393 Make runtest.py call test-webkitpy with the --json flag when in
1394 non-interactive mode.
1395 https://bugs.webkit.org/show_bug.cgi?id=137667
1397 Reviewed by Daniel Bates.
1399 * Scripts/webkitpy/port/base.py:
1400 Adds the python_unittest_results_directory method.
1401 (Port.python_unittest_results_directory):
1402 * Scripts/webkitpy/tool/steps/runtests.py:
1403 Changes RunTests to call test-webkitpy with the --json flag if the
1404 --non-interactive flag is set.
1408 2014-10-28 Rebecca Hauck <rhauck@adobe.com>
1410 import-w3c-tests should use re.escape() wherever it's handling file paths
1411 https://bugs.webkit.org/show_bug.cgi?id=137934
1413 This patch adds re.escape() to a few places where we're doing string
1414 conversions. This prevents errors when attribute values coincidentally
1415 have character sequences that can be interpreted as regular expressions.
1417 Reviewed by Bem Jones-Bey.
1419 * Scripts/webkitpy/w3c/test_converter.py:
1420 (_W3CTestConverter.convert_attributes_if_needed):
1422 2014-10-28 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1424 [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
1425 https://bugs.webkit.org/show_bug.cgi?id=138130
1427 Reviewed by Csaba Osztrogonác.
1429 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1431 2014-10-25 Raniere Silva <raniere@ime.unicamp.br>
1433 Fix link to Arch Linux Wiki
1434 https://bugs.webkit.org/show_bug.cgi?id=138010
1436 Reviewed by Benjamin Poulain.
1438 * gtk/install-dependencies:
1440 2014-10-25 Alexey Proskuryakov <ap@apple.com>
1442 Test regressions are not detected when image result is missing
1443 https://bugs.webkit.org/show_bug.cgi?id=138070
1445 Reviewed by Simon Fraser.
1447 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1448 * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1449 Count these as regressions, not as flaky tests.
1451 * Scripts/webkitpy/port/test.py:
1452 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1455 2014-10-24 Timothy Horton <timothy_horton@apple.com>
1457 Add Conrad Shultz to the contributors list.
1459 * Scripts/webkitpy/common/config/contributors.json:
1461 2014-10-24 Dan Bernstein <mitz@apple.com>
1463 build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
1464 https://bugs.webkit.org/show_bug.cgi?id=138046
1466 Reviewed by Alexey Proskuryakov.
1468 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1469 (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
1470 401. Otherwise, we’ll retry normally in 45 seconds.
1472 2014-10-24 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
1474 [GTK] Implement is_selected method on WebKitHitTestResult
1475 https://bugs.webkit.org/show_bug.cgi?id=137110
1477 Reviewed by Tim Horton.
1479 Add tests for new context SELECTION on WebKitHitTestResult.
1481 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1482 (testContextMenuDefaultMenu):
1483 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1484 (testWebViewMouseTarget):
1486 2014-10-23 Roger Fong <roger_fong@apple.com>
1488 [Win] Skip failing JSC tests following r175078
1489 https://bugs.webkit.org/show_bug.cgi?id=130967.
1491 * Scripts/run-javascriptcore-tests:
1493 2014-10-22 Jake Nielsen <jacob_nielsen@apple.com>
1495 commitqueuetask_unittest.py should be made more concise.
1496 https://bugs.webkit.org/show_bug.cgi?id=137985
1498 Reviewed by Alexey Proskuryakov.
1500 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1501 Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
1502 (MockCommitQueue.__init__):
1503 (MockCommitQueue.report_flaky_tests):
1505 (MockCommitQueue.get_reported_flaky_tests):
1506 (MockSimpleTestPlanCommitQueue.__init__):
1507 (MockSimpleTestPlanCommitQueue.run_command):
1508 (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
1509 (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1510 (test_land_failure):
1511 (test_failed_archive):
1512 (test_double_flaky_test_failure):
1513 (test_test_failure):
1514 (test_red_test_failure):
1515 (test_very_red_tree_retry):
1516 (test_red_tree_patch_rejection):
1517 (test_one_flaky_test):
1518 (test_tree_more_red_than_patch):
1519 (MockCommitQueue.test_results): Deleted.
1520 (test_simple_flaky_test_failure): Deleted.
1521 (_expect_validate): Deleted.
1522 (_expect_validate.MockDelegate): Deleted.
1523 (_expect_validate.MockDelegate.refetch_patch): Deleted.
1524 (_expect_validate.MockDelegate.expected_failures): Deleted.
1525 (_mock_patch): Deleted.
1526 (test_validate): Deleted.
1527 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1528 Fixes a bug that slipped through the cracks prior to this change.
1529 (PatchAnalysisTask._test_patch):
1531 2014-10-22 Alexey Proskuryakov <ap@apple.com>
1533 Flakiness dashboard should support OS X Yosemite
1534 https://bugs.webkit.org/show_bug.cgi?id=137986
1536 Reviewed by Ryosuke Niwa.
1538 * TestResultServer/app.yaml:
1539 * TestResultServer/static-dashboards/builders.jsonp:
1540 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1542 2014-10-22 Jake Nielsen <jacob_nielsen@apple.com>
1544 commitqueuetask should include more tests to ensure that the behavior
1545 of PatchAnalysisTask._test_patch() is well defined
1546 https://bugs.webkit.org/show_bug.cgi?id=137977
1548 Reviewed by Alexey Proskuryakov.
1550 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1551 Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
1552 and more readable to define tests that are meant to test the behaviour
1553 of PatchAnalysisTask._test_patch(), and adds several unit tests.
1554 (FailingTestCommitQueue.test_results):
1555 (PatchAnalysisResult):
1556 (MockSimpleTestPlanCommitQueue):
1557 (MockSimpleTestPlanCommitQueue.__init__):
1558 (MockSimpleTestPlanCommitQueue.run_command):
1559 (MockSimpleTestPlanCommitQueue._mock_test_result):
1560 (MockSimpleTestPlanCommitQueue.test_results):
1561 (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1562 (test_flaky_test_failure):
1563 (test_failed_archive):
1564 (test_two_flaky_tests):
1565 (test_one_flaky_test):
1566 (test_very_flaky_patch):
1567 (test_very_flaky_patch_with_some_tree_redness):
1568 (test_different_test_failures):
1569 (test_different_test_failures_with_some_tree_redness):
1570 (test_mildly_flaky_patch):
1571 (test_mildly_flaky_patch_with_some_tree_redness):
1572 (test_tree_more_red_than_patch):
1574 2014-10-22 Jake Nielsen <jacob_nielsen@apple.com>
1576 PatchAnalysisTask._test_patch() needs refactoring
1577 https://bugs.webkit.org/show_bug.cgi?id=137904
1579 Reviewed by Alexey Proskuryakov.
1581 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1582 Fixes several small bugs, and makes minor changes to accomodate the
1583 changes in PatchAnalysisTask.
1584 (MockCommitQueue.refetch_patch):
1585 (MockCommitQueue.test_results):
1586 (test_flaky_test_failure):
1587 (test_failed_archive):
1588 (test_very_red_tree_retry):
1589 (_expect_validate.MockDelegate.refetch_patch):
1590 (MockCommitQueue.expected_failures): Deleted.
1591 (_expect_validate.MockDelegate.expected_failures): Deleted.
1592 * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1593 * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1594 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1595 Removes the unexpected_failures member, adds the _clean_tree_results
1596 member, adds a helper function for _test_patch, and refactors
1597 _test_patch to be more readable.
1598 (PatchAnalysisTask.__init__):
1599 (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1600 (PatchAnalysisTask._test_patch):
1601 (PatchAnalysisTask.results_from_test_run_without_patch):
1602 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1603 Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures.
1604 (AbstractEarlyWarningSystem.begin_work_queue):
1605 (AbstractEarlyWarningSystem._failing_tests_message):
1606 (AbstractEarlyWarningSystem.command_failed):
1607 (AbstractEarlyWarningSystem.expected_failures): Deleted.
1608 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1609 Makes changes to accomodate the changes made to PatchAnalysisTask.
1610 (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1611 * Scripts/webkitpy/tool/commands/perfalizer.py:
1612 Removes Perfalizer's dependancy on ExpectedFailures.
1613 (PerfalizerTask.refetch_patch):
1614 (PerfalizerTask.expected_failures): Deleted.
1615 * Scripts/webkitpy/tool/commands/queues.py:
1616 Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1617 initializer to allow for mock injection.
1618 (CommitQueue.__init__):
1619 (CommitQueue.begin_work_queue):
1620 (CommitQueue.process_work_item):
1621 (CommitQueue._failing_tests_message):
1622 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1623 Removes dependancy on ExpectedFailures, and instead uses mock
1625 (MockCommitQueueTask):
1626 (MockCommitQueueTask.results_from_patch_test_run):
1627 (MockCommitQueueTask.results_from_test_run_without_patch):
1628 (mock_run_webkit_patch):
1630 2014-10-22 Rohit Kumar <kumar.rohit@samsung.com>
1632 [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
1633 https://bugs.webkit.org/show_bug.cgi?id=136736
1635 Reviewed by Gyuyoung Kim.
1637 * MiniBrowser/efl/main.c:
1638 (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
1641 2014-10-22 Carlos Garcia Campos <cgarcia@igalia.com>
1643 [GTK] Move GtkInputMethodFilter from Platform to WebKit2
1644 https://bugs.webkit.org/show_bug.cgi?id=137884
1646 Reviewed by Gustavo Noronha Silva.
1648 Move InputMethodFilter test from WebCore tests to WebKit2 tests
1649 and adapt it to use the new InputMethodFilter WebKit class. Instead
1650 of having virtual methods just for testing, it has a testing mode
1651 that logs the events.
1653 * TestWebKitAPI/PlatformGTK.cmake:
1654 * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
1655 (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1656 (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
1657 (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
1658 (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
1659 (TestWebKitAPI::TEST):
1660 (TestWebKitAPI::temporaryGetPreeditStringOverride):
1661 (TestWebKitAPI::temporaryResetOverride):
1662 (TestWebKitAPI::verifyCanceledComposition):
1664 2014-10-21 Alexey Proskuryakov <ap@apple.com>
1666 build.webkit.org/dashboard: Cannot click on green tester bubbles
1667 https://bugs.webkit.org/show_bug.cgi?id=137909
1669 Reviewed by Darin Adler.
1671 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1672 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1674 2014-10-21 Brent Fulgham <bfulgham@apple.com>
1676 [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
1677 https://bugs.webkit.org/show_bug.cgi?id=137932
1679 Reviewed by Simon Fraser.
1681 This is the first step in moving over to native Windows rendering for our layout tests.
1682 Once this change lands, approximately 300 tests will start failing on Windows. I will
1683 rebaseline these changes against our test hardware and update this bug with the
1684 commits related to that work.
1686 * DumpRenderTree/win/DumpRenderTree.cpp:
1687 (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
1688 we use native Windows drawing style.
1690 2014-10-21 Dániel Bátyai <dbatyai.u-szeged@partner.samsung.com>
1692 Fix FTL Native Inlining for EFL
1693 https://bugs.webkit.org/show_bug.cgi?id=137774
1695 Reviewed by Michael Saboff.
1697 Added Clang as an optional module to jhbuild.
1699 * efl/jhbuild.modules:
1701 2014-10-20 Michael Catanzaro <mcatanzaro@igalia.com>
1703 Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
1704 https://bugs.webkit.org/show_bug.cgi?id=137832
1706 Reviewed by Carlos Garcia Campos.
1708 Ensure each test sets the TLS errors policy that it really needs.
1709 Have each test except testTLSErrorsPolicy stash and restore the original
1710 TLS errors policy. Update testTLSErrorsPolicy to account for the new
1713 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1715 (testInsecureContent):
1716 (testTLSErrorsPolicy):
1717 (testTLSErrorsRedirect):
1718 (testTLSErrorsHTTPAuth):
1719 (testLoadFailedWithTLSErrors):
1722 2014-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
1724 Unreviewed. Unskip inspector server unit tests.
1726 They should pass now.
1728 * Scripts/run-gtk-tests:
1731 2014-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
1733 [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
1734 https://bugs.webkit.org/show_bug.cgi?id=132044
1736 Reviewed by Brian Burg.
1738 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1739 (openRemoteDebuggingSession): Remove trailing slash when
1740 concatenating base inspector URL with the page, because the
1741 inspector returns the relative paths with a leading slash.
1743 2014-10-20 Tanay C <tanay.c@samsung.com>
1745 [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
1746 https://bugs.webkit.org/show_bug.cgi?id=137023
1748 Reviewed by Gyuyoung Kim.
1750 * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
1751 (search_box_show): Modified.
1752 (search_box_hide): Modified.
1753 (on_search_field_activated): Modified.
1754 (on_search_backward_button_clicked): Modified.
1755 (on_search_forward_button_clicked): Modified.
1756 (on_search_case_option_changed): Added.
1757 (on_search_word_start_option_changed): Added.
1758 (window_create): Modified.
1760 2014-10-20 Tanay C <tanay.c@samsung.com>
1762 [GTK][Minibrowser] Escape key does not hide the search box
1763 https://bugs.webkit.org/show_bug.cgi?id=137734
1765 Reviewed by Philippe Normand.
1767 * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
1768 (stopPageLoad): Modified.
1770 2014-10-18 Antti Koivisto <antti@apple.com>
1772 REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
1773 https://bugs.webkit.org/show_bug.cgi?id=137855
1775 Reviewed by Dan Bernstein.
1777 Test and warn if the dumped response mime type differs from the platform response mime type.
1779 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1780 (WTR::InjectedBundlePage::didReceiveResponseForResource):
1781 (WTR::InjectedBundlePage::platformResponseMimeType):
1782 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1783 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1784 (WTR::InjectedBundlePage::platformResponseMimeType):
1786 2014-10-17 Joseph Pecoraro <pecoraro@apple.com>
1788 Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
1789 https://bugs.webkit.org/show_bug.cgi?id=137835
1791 Reviewed by Andreas Kling.
1793 * Scripts/run-inspector-perf-tests.py: Removed.
1794 This script is stale, as PerformanceTests/inspector no longer exists.
1796 2014-10-17 Simon Fraser <simon.fraser@apple.com>
1798 Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
1800 * Scripts/webkitpy/port/ios.py:
1801 (IOSSimulatorPort.default_baseline_search_path):
1803 2014-10-17 Simon Fraser <simon.fraser@apple.com>
1805 [iOS] Simplify test fallback paths for iOS Simulator testing
1806 https://bugs.webkit.org/show_bug.cgi?id=137830
1808 Reviewed by Zalan Bujtas.
1810 Make the fallback paths be:
1811 ios-simulator -> generic
1812 ios-simulator-wk2->ios-simulator -> generic
1814 so don't include mac in the fallback path. Also remove the
1815 version handling for simplicity.
1817 * Scripts/webkitpy/port/ios.py:
1819 (IOSSimulatorPort.default_baseline_search_path):
1821 2014-10-17 Dana Burkart <dburkart@apple.com>
1823 Fix typos in the dashboard config file.
1827 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1830 2014-10-17 Brent Fulgham <bfulgham@apple.com>
1832 [Win] Allow WinLauncher to specify Custom User Agent strings
1833 https://bugs.webkit.org/show_bug.cgi?id=137828
1835 Reviewed by Dean Jackson.
1837 * WinLauncher/Common.cpp: Add support for custom user agent strings.
1838 * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
1839 and set the user agent strings.
1840 * WinLauncher/WinLauncher.h:
1841 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
1842 resources and dialog for setting custom User Agent strings.
1843 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1845 2014-10-16 Simon Fraser <simon.fraser@apple.com>
1847 [iOS] Turn off font autosizing for iOS WebKitTestRunner
1848 https://bugs.webkit.org/show_bug.cgi?id=137806
1850 Reviewed by Sam Weinig.
1852 Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
1853 Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
1854 to disable font autosizing.
1856 Add platformResetPreferencesToConsistentValues() and implement it in the iOS
1857 test controller to set platform-specific prefs.
1859 * WebKitTestRunner/TestController.cpp:
1860 (WTR::TestController::resetPreferencesToConsistentValues):
1861 (WTR::TestController::platformResetPreferencesToConsistentValues):
1862 * WebKitTestRunner/TestController.h:
1863 * WebKitTestRunner/ios/TestControllerIOS.mm:
1864 (WTR::TestController::platformResetPreferencesToConsistentValues):
1865 * WebKitTestRunner/mac/TestControllerMac.mm:
1866 (WTR::TestController::platformResetPreferencesToConsistentValues):
1868 2014-10-16 Dan Bernstein <mitz@apple.com>
1870 OSObjectPtr is missing leakRef()
1871 https://bugs.webkit.org/show_bug.cgi?id=137798
1873 Reviewed by Sam Weinig.
1875 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1876 (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
1878 2014-10-16 Lucas Forschler <lforschler@apple.com>
1880 Update target platform to remove Leopard, Snow Leopard, Lion.
1885 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1886 (_should_file_trigger_build):
1888 2014-10-16 David Kilzer <ddkilzer@apple.com>
1890 commit-queue: fails to replace OO-PS! with reviewer name
1891 <http://webkit.org/b/137795>
1893 Reviewed by Alexey Proskuryakov.
1895 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1896 (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
1897 email addresses to unauthenticated page loads, so we must always
1898 authenticate before getting bug data so we get full email
1901 2014-10-16 David Kilzer <ddkilzer@apple.com>
1903 commit-queue: fails to close bugs after successfully landing patches
1904 <http://webkit.org/b/137794>
1906 Reviewed by Alexey Proskuryakov.
1908 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1909 (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
1910 tell Mechanize to use the second <textarea> on the page with
1913 2014-10-16 Brent Fulgham <bfulgham@apple.com>
1915 [Win] Update DRT to match Mac Logic
1916 https://bugs.webkit.org/show_bug.cgi?id=137787
1918 Reviewed by Dean Jackson.
1920 * DumpRenderTree/win/DumpRenderTree.cpp:
1921 (initialize): 0 -> nullptr
1922 (runTest): Initialize MSG structure before using.
1923 (main): Add CRT debug flags if building DRT with debug malloc on Windows.
1924 Also, cleanly shut down COM when exiting.
1925 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1926 (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
1927 header and add printf to match Mac.
1928 (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
1929 * DumpRenderTree/win/FrameLoadDelegate.h:
1930 (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
1931 (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
1932 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1933 (isLocalhost): Added.
1934 (hostIsUsedBySomeTestsToGenerateError): Added.
1935 (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
1936 of certain error and redirect host names.
1937 * DumpRenderTree/win/UIDelegate.cpp:
1938 (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
1939 anything should be output to the console. This modifies behavior to match the Mac.
1940 (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1941 (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1942 (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1943 (UIDelegate::webViewAddMessageToConsole): Ditto.
1944 * WinLauncher/PageLoadTestClient.cpp:
1945 (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
1948 2014-10-16 Commit Queue <commit-queue@webkit.org>
1950 Unreviewed, rolling out r174754.
1951 https://bugs.webkit.org/show_bug.cgi?id=137789
1953 Speculative fix for Windows test was ineffective. (Requested
1954 by rfong on #webkit).
1958 "[Windows] Add some more logging to debug Windows test
1960 http://trac.webkit.org/changeset/174754
1962 2014-10-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1964 Unreviewed, add myself to CoordinatedGraphics watchers.
1966 * Scripts/webkitpy/common/config/watchlist:
1968 2014-10-15 Roger Fong <roger_fong@apple.com>
1970 [Windows] Speculative Windows test fix.
1972 * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
1974 2014-10-15 Rebecca Hauck <rhauck@adobe.com>
1976 import-w3c-test rewrites relative src paths in ref files incorrectly
1977 https://bugs.webkit.org/show_bug.cgi?id=137586
1979 This patch fixes a bug in test_converter.py where src paths were getting
1980 rewritten as ../../some-path instead of <script src="../../some-path>".
1981 It also adds support for rewriting src paths in style elements, which was
1982 missing before and it adds tests for this case.
1984 Reviewed by Bem Jones-Bey.
1986 * Scripts/webkitpy/w3c/test_converter.py:
1987 (_W3CTestConverter.convert_attributes_if_needed):
1988 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1989 (test_convert_attributes_if_needed):
1990 (verify_reference_relative_paths):
1992 2014-10-15 Jake Nielsen <jacob_nielsen@apple.com>
1994 Add --json flag to test-webkitpy to emit JSON formatted test results
1996 https://bugs.webkit.org/show_bug.cgi?id=137353
1998 Reviewed by Daniel Bates.
2000 * Scripts/webkitpy/port/server_process_unittest.py:
2001 Adds the read method to MockFile to allow the stdout of test_webkitpy
2002 to be redirected without causing erroneous test failures.
2004 webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2006 webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2007 because when redirecting to a file, the
2008 _wait_for_data_and_update_buffers_using_select method in
2009 server_process.py will find that there is a read file descriptor in
2010 its call to select.select, which eventually leads to it calling read()
2011 on the MockFile object.
2013 * Scripts/webkitpy/test/main.py:
2014 Adds the _print_results_as_json method and the --json flag which
2015 determines whether _print_results_as_json will get called.
2016 (Tester._parse_args):
2017 (Tester._print_results_as_json):
2018 (Tester._print_results_as_json.result_dict_from_tuple):
2019 (Tester._run_tests):
2021 2014-10-13 David Farler <dfarler@apple.com>
2023 [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2024 https://bugs.webkit.org/show_bug.cgi?id=137662
2026 Reviewed by Darin Adler.
2028 The layout test harness can close LayoutTestRelay's subprocess
2029 stdout and stderr in the case of a timeout or if a run is
2030 cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2031 finds that no one is listening to its stdout/stderr (broken
2032 pipe), then just exit(1), there is nothing to report.
2034 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2035 (-[LTRelayController didReceiveStdoutData:]):
2036 Add @try/@catch for NSFileHandleOperationException.
2037 (-[LTRelayController didReceiveStderrData:]):
2038 Add @try/@catch for NSFileHandleOperationException.
2040 2014-10-15 Rohit Kumar <kumar.rohit@samsung.com>
2042 [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2043 https://bugs.webkit.org/show_bug.cgi?id=137060
2045 Reviewed by Philippe Normand.
2047 Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2049 * MiniBrowser/gtk/BrowserWindow.c:
2052 (defaultZoomCallback): Callback for default zoom keyboard support.
2053 (browser_window_init):
2055 2014-10-14 Simon Fraser <simon.fraser@apple.com>
2057 [Mac] DRT stderr logging after the test completes gets attributed to the next test
2059 Reviewed by Alexey Proskuryakov.
2061 DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2062 logging to stderr to get associated with the next test.
2064 Fix by logging #EOF to stderr later, after we've completely finished with this test.
2066 * DumpRenderTree/mac/DumpRenderTree.mm:
2070 2014-10-14 Brent Fulgham <bfulgham@apple.com>
2072 [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2074 * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2076 2014-10-14 Csaba Osztrogonác <ossy@webkit.org>
2078 [cmake] Fix the make build after r174683
2079 https://bugs.webkit.org/show_bug.cgi?id=137703
2081 Reviewed by Martin Robinson.
2083 * Scripts/webkitdirs.pm:
2084 (buildCMakeGeneratedProject):
2086 2014-10-14 Myles C. Maxfield <mmaxfield@apple.com>
2088 Adding myself to the watchlist to CachedFont
2092 * Scripts/webkitpy/common/config/watchlist:
2094 2014-10-14 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2096 [EFL][GTK] Make it possible to get verbose output with ninja
2097 https://bugs.webkit.org/show_bug.cgi?id=137606
2099 Reviewed by Csaba Osztrogonác.
2101 * Scripts/webkitdirs.pm:
2102 (buildCMakeGeneratedProject):
2104 2014-10-14 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2106 [EFL] Make it possible to use ninja for EFL build too
2107 https://bugs.webkit.org/show_bug.cgi?id=137605
2109 Reviewed by Csaba Osztrogonác.
2111 * Scripts/webkitdirs.pm:
2112 (generateBuildSystemFromCMakeProject):
2113 * efl/install-dependencies:
2115 2014-10-14 Rohit Kumar <kumar.rohit@samsung.com>
2117 [GTK] Minibrowser : Add home buton and keyboard support for home page load
2118 https://bugs.webkit.org/show_bug.cgi?id=137486
2120 Reviewed by Philippe Normand.
2122 * MiniBrowser/gtk/BrowserWindow.c:
2123 (loadHomePage): Callback for home page load.
2124 (browser_window_init):
2125 * MiniBrowser/gtk/BrowserWindow.h:
2126 * MiniBrowser/gtk/main.c:
2129 2014-10-14 Manuel Rego Casasnovas <rego@igalia.com>
2131 import-w3c-tests doesn't prefix property values
2132 https://bugs.webkit.org/show_bug.cgi?id=137600
2134 Reviewed by Bem Jones-Bey.
2136 Some property values are prefixed in WebKit. Modified the W3C import
2137 script in order to prefix property values and not only properties.
2138 The patch re-uses most of the already existent logic to prefix
2141 * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2142 from CSSValueKeywords.in and adapt converter to modify both properties
2143 and property values.
2144 (convert_for_webkit):
2145 (_W3CTestConverter.__init__):
2146 (_W3CTestConverter.output):
2147 (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2148 (_W3CTestConverter):
2149 (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2150 (_W3CTestConverter.add_webkit_prefix_following_regex):
2151 (_W3CTestConverter.convert_reference_relpaths):
2152 (_W3CTestConverter.convert_style_data):
2153 (_W3CTestConverter.convert_attributes_if_needed):
2154 (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2155 * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2156 include checks for property values too.
2157 (W3CTestConverterTest.test_read_prefixed_property_list):
2158 (verify_no_conversion_happened):
2159 (verify_prefixed_properties):
2160 (verify_prefixed_property_values):
2161 (generate_test_content_properties_and_values):
2162 (generate_test_content):
2163 * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2164 prefixed property values and inform about them.
2165 (TestImporter.import_tests):
2166 (TestImporter.write_import_log):
2168 2014-10-13 Jer Noble <jer.noble@apple.com>
2170 MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2171 https://bugs.webkit.org/show_bug.cgi?id=137533
2173 Reviewed by Andy Estes.
2175 Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2177 * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2178 (TestWebKitAPI::isMSEEnabledCallback):
2179 (TestWebKitAPI::TEST):
2181 2014-10-13 Brent Fulgham <bfulgham@apple.com>
2183 [Win] Implement a page load profiling tool
2184 https://bugs.webkit.org/show_bug.cgi?id=137673
2186 Reviewed by Dean Jackson.
2188 Add a tool to capture and summarize page load statistics.
2190 * WinLauncher/Common.cpp:
2191 (parseCommandLine): Move from WinMain.cpp so that it can
2192 be shared with internal tools.
2193 * WinLauncher/PageLoadTestClient.cpp: Added.
2194 (PageLoadTestClient::PageLoadTestClient):
2195 (PageLoadTestClient::pageLoadStartedAtTime):
2196 (PageLoadTestClient::didStartProvisionalLoad):
2197 (PageLoadTestClient::didCommitLoad):
2198 (PageLoadTestClient::didFirstLayoutForMainFrame):
2199 (PageLoadTestClient::didHandleOnLoadEvents):
2200 (PageLoadTestClient::didFinishLoad):
2201 (PageLoadTestClient::didFailLoad):
2202 (PageLoadTestClient::didInitiateResourceLoad):
2203 (PageLoadTestClient::didEndResourceLoad):
2204 (PageLoadTestClient::pageLoadEndedAtTime):
2205 (PageLoadTestClient::endPageLoad):
2206 (PageLoadTestClient::clearPageLoadState):
2207 (PageLoadTestClient::shouldConsiderPageLoadEnded):
2208 (PageLoadTestClient::maybeEndPageLoadSoon):
2209 (PageLoadTestClient::setPageURL):
2210 (PageLoadTestClient::dumpRunStatistics):
2211 * WinLauncher/PrintWebUIDelegate.cpp:
2212 (PrintWebUIDelegate::createWebViewWithRequest): Handle
2213 nullptr URL properly.
2214 * WinLauncher/ResourceLoadDelegate.cpp: Added.
2215 (ResourceLoadDelegate::QueryInterface):
2216 (ResourceLoadDelegate::AddRef):
2217 (ResourceLoadDelegate::Release):
2218 (ResourceLoadDelegate::identifierForInitialRequest):
2219 (ResourceLoadDelegate::willSendRequest):
2220 (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2221 (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2222 (ResourceLoadDelegate::didReceiveResponse):
2223 (ResourceLoadDelegate::didReceiveContentLength):
2224 (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2225 (ResourceLoadDelegate::didFailLoadingWithError):
2226 (ResourceLoadDelegate::plugInFailedWithError):
2227 * WinLauncher/ResourceLoadDelegate.h: Added.
2228 (ResourceLoadDelegate::ResourceLoadDelegate):
2229 * WinLauncher/WinLauncher.cpp:
2230 (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2231 page loading statistics.
2232 (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2233 and set private load delegate state.
2234 (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2235 that sets the view's resource load delegate.
2236 (WinLauncher::loadURL): If no URL is passed, load the test document.
2237 * WinLauncher/WinLauncher.h:
2238 (WinLauncher::pageLoadTestClient):
2239 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2240 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2241 * WinLauncher/WinLauncherWebHost.cpp:
2242 (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2243 (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2244 it could be used from other source files.
2245 (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2246 (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2247 (WinLauncherWebHost::didFailLoadWithError): Ditto.
2248 (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2249 (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2250 (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2251 (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2252 (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2253 * WinLauncher/WinLauncherWebHost.h:
2254 * WinLauncher/WinMain.cpp:
2255 (wWinMain): Create and use new delegates for gathering page load data.
2256 * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2258 2014-10-13 Simon Fraser <simon.fraser@apple.com>
2260 Improve the test image diffs page
2261 https://bugs.webkit.org/show_bug.cgi?id=137674
2263 Reviewed by Alexey Proskuryakov.
2265 Don't treat the input file as a format string, otherwise we have to escape special
2266 characters. Just do a couple of replaces.
2268 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2269 (TestResultWriter.write_image_diff_files):
2271 2014-10-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
2273 [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2274 https://bugs.webkit.org/show_bug.cgi?id=137659
2276 Reviewed by Martin Robinson.
2278 * Scripts/webkitpy/port/xvfbdriver.py:
2279 (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2281 2014-10-13 Alexey Proskuryakov <ap@apple.com>
2283 Add more detailed wait time information to EWS metrics
2284 https://bugs.webkit.org/show_bug.cgi?id=137649
2286 Reviewed by Daniel Bates.
2288 Added average and worst time (we used to only have median), and also a percentage
2289 of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2291 There is always some wait due to the polling nature of the queues, which is well understood
2292 and doesn't need to be measured. What needs to be measured is whether there is enough
2293 bot machines to process patches as soon as they are submitted.
2295 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2296 (Analyzer.prototype._analyzeBubblePerformance):
2297 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2298 (MetricsBubbleView.prototype._update):
2300 2014-10-11 Jer Noble <jer.noble@apple.com>
2302 MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2303 https://bugs.webkit.org/show_bug.cgi?id=137533
2305 Reviewed by Darin Adler.
2307 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2308 * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2309 (TestWebKitAPI::TEST):
2310 * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
2311 * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
2313 2014-10-13 Simon Fraser <simon.fraser@apple.com>
2315 iOS DRT snapshots are limited to the page visible area
2316 https://bugs.webkit.org/show_bug.cgi?id=137650
2318 Reviewed by Daniel Bates.
2320 LegacyTileCache drawing was limited to the window's visible area, found by
2321 crawling up the layer hierarchy to the root layer. This caused test snapshots to
2322 be missing non-composited content outside the iPhone visible area, which hinders
2325 Fix by adding a test-only mode where the window visible area is the entire window.
2327 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2328 (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
2329 * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2330 (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
2334 2014-10-12 Simon Fraser <simon.fraser@apple.com>
2336 Page not fully rendered in iOS DRT snapshots
2337 https://bugs.webkit.org/show_bug.cgi?id=137638
2339 Reviewed by Tim Horton.
2341 In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
2342 to ensure that the page has laid out and is rendered by the time we take
2345 * DumpRenderTree/mac/DumpRenderTree.mm:
2346 (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
2347 (-[DumpRenderTree _webThreadInvoked]): Moved.
2348 (-[DumpRenderTree _waitForWebThreadThenDump]):
2349 (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
2350 for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
2351 that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
2352 relies on dispatch_async too, and the inner block won't complete until the outer block
2354 (dumpTestResults): Move the guts of dump() here.
2355 (runTest): Whitespace.
2357 2014-10-12 Alexey Proskuryakov <ap@apple.com>
2359 Adding svn:ignore so that .pyc files don't show up as new.
2361 * Scripts/webkitpy/xcode: Added property svn:ignore.
2363 2014-10-12 Ryuan Choi <ryuan.choi@gmail.com>
2365 [EFL] Introduce EWebKit_Extension
2366 https://bugs.webkit.org/show_bug.cgi?id=134921
2368 Reviewed by Gyuyoung Kim.
2370 * MiniBrowser/efl/main.c: Added x option to test extension path.
2373 * Scripts/webkitpy/common/config/watchlist:
2374 Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2375 * Scripts/webkitpy/style/checker.py:
2376 Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2378 2014-10-11 Simon Fraser <simon.fraser@apple.com>
2380 After r174628 we send the test process a SIGTERM before the SIGKILL.
2382 * Scripts/webkitpy/common/system/executive_unittest.py:
2383 (ExecutiveTest.serial_test_kill_process):
2385 2014-10-11 KwangHyuk Kim <hyuki.kim@samsung.com>
2387 [EFL] Enable WebP support.
2388 https://bugs.webkit.org/show_bug.cgi?id=136156
2390 Reviewed by Gyuyoung Kim.
2392 Include libwebp-dev package to support WebP for WK2 Efl.
2394 * efl/install-dependencies:
2396 2014-10-11 Carlos Garcia Campos <cgarcia@igalia.com>
2398 [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
2399 https://bugs.webkit.org/show_bug.cgi?id=137485
2401 Reviewed by Sergio Villar Senin.
2403 Update GMainLoopSource tests. Most of the tests are now run twice,
2404 first with a GMainLoopSource and then with a
2405 GThreadSafeMainLoopSource, since both should have the same
2406 behaviour. The threading test uses GThreadSafeMainLoopSource and
2407 the delete on destroy test uses GMainLoopSource. The tests
2408 themselves haven't changed, since there's no change in behaviour.
2410 * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2411 (TestWebKitAPI::GMainLoopSourceTest::source):
2412 (TestWebKitAPI::basicRescheduling):
2413 (TestWebKitAPI::TEST):
2414 (TestWebKitAPI::reentrantRescheduling):
2415 (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2416 (TestWebKitAPI::basicDestroyCallbacks):
2417 (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2418 (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2420 2014-10-10 Dana Burkart <dburkart@apple.com>
2422 Fix fat-fingered function name in git-add-reviewer.
2426 * Scripts/git-add-reviewer:
2429 2014-10-10 David Farler <dfarler@apple.com>
2431 [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
2432 https://bugs.webkit.org/show_bug.cgi?id=137528
2434 Reviewed by Simon Fraser.
2436 Catch SIGINT and SIGTERM signals in the LayoutTestRelay
2437 and SIGKILL the paired simulator app before exiting cleanly.
2439 webkitpy only uses SIGKILL to kill processes which you cannot
2440 catch. Send SIGTERM to the process and give it chance to do
2441 its thing before sending SIGKILL. Sending a SIGKILL to an already
2444 * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2445 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2446 (-[LTRelayController finish]):
2447 * LayoutTestRelay/LayoutTestRelay/main.m:
2451 2014-10-10 David Farler <dfarler@apple.com>
2453 [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
2454 https://bugs.webkit.org/show_bug.cgi?id=137527
2456 Reviewed by Simon Fraser.
2458 NSFileHandle doesn't notify of EOF in its readability handler.
2459 Use a dispatch_source_t and an event handler that is called when reading is possible.
2460 In the handler block, do a run-of-the-mill read(2) from standard input and
2461 detect EOF in the usual way by checking that zero bytes were read.
2463 Once an EOF is received, the FIFOs are disconnected, the simulator app
2464 is killed, and the relay exits with status 0.
2466 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2467 (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2468 (-[LTRelayController didDisconnect]):
2469 (-[LTRelayController didConnect]):
2470 (-[LTRelayController launchApp]):
2471 Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
2472 confusion with this new dispatch source, called "standardInputDispatchSource".
2473 (-[LTRelayController finish]): Added.
2474 (-[LTRelayController readFileHandle:]): Deleted.
2476 2014-10-10 KwangHyuk Kim <hyuki.kim@samsung.com>
2478 [EFL] Crash on facebook.com
2479 https://bugs.webkit.org/show_bug.cgi?id=137562
2481 Reviewed by Chris Dumez.
2483 Crash occurs on the facebook.com when the webview is resized
2484 after the <select> item is clicked but no item is chosen.
2485 This crash is just caused by the reference of invalidated variable.
2486 From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
2487 Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
2488 on MiniBrowser is called.
2489 As a result, just set ewk_menu to NULL in order to prevent crash condition.
2491 * MiniBrowser/efl/main.c:
2492 (on_popup_menu_hide):
2494 2014-10-10 Alexey Proskuryakov <ap@apple.com>
2496 A small wording change for clarity.
2498 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2499 (MetricsBubbleView.prototype._update):
2501 2014-10-10 Alexey Proskuryakov <ap@apple.com>
2503 Dashboard metrics page should have EWS statistics
2504 https://bugs.webkit.org/show_bug.cgi?id=137626
2506 Reviewed by Ryosuke Niwa.
2508 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2509 (BubbleQueue): Put shortName in the object, so that it's actually useful.
2511 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2512 (BubbleQueueServer): Re-ordered queues to match bubble order.
2513 (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
2514 (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
2516 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2517 Added analysis for bubble queues.
2519 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
2521 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2522 (buildBubbleQueuesTable): Build the UI.
2524 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2525 Added JS sources to load.
2527 * QueueStatusServer/app.yaml: To update app version.
2529 * QueueStatusServer/handlers/processingtimesjson.py: Added.
2531 * QueueStatusServer/main.py: Added a handler for processing-times-json.
2533 2014-10-10 Alexey Proskuryakov <ap@apple.com>
2535 REGRESSION: Commit queue doesn't process rollouts
2536 https://bugs.webkit.org/show_bug.cgi?id=137623
2538 Reviewed by Tim Horton.
2540 * QueueStatusServer/app.yaml:
2541 * QueueStatusServer/handlers/updateworkitems.py:
2542 (UpdateWorkItems._work_items_from_request):
2544 2014-10-10 Simon Fraser <simon.fraser@apple.com>
2546 Fix syntax error after r174601.
2548 * Scripts/run-javascriptcore-tests:
2550 2014-10-10 Michael Saboff <msaboff@apple.com>
2552 Add ability to select tarfile name in run-jsc-stress-tests
2553 https://bugs.webkit.org/show_bug.cgi?id=137614
2555 Reviewed by Mark Hahnenberg.
2557 Added optional file name argument to the --tarball option.
2559 * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2560 extra test given after the options wont be used for the optional tarball file name.
2561 * Scripts/run-jsc-stress-tests:
2563 2014-10-10 Chris Dumez <cdumez@apple.com>
2565 Unreviewed, update my information in contributors.json
2567 Use my preferred first name and update my expertise areas.
2569 * Scripts/webkitpy/common/config/contributors.json:
2571 2014-10-10 Adrien Destugues <pulkomandy@gmail.com>
2573 Fix perl scripts to run with env on Linux
2574 https://bugs.webkit.org/show_bug.cgi?id=137601
2576 Reviewed by Csaba Osztrogonác.
2578 Use of arguments in #! is nonstandard and does not behave the same on
2579 different systems. Linux would look for an executable named "perl -w"
2580 "use warnings;" does the same things in a more portable way.
2582 * Scripts/commit-log-editor:
2584 * Scripts/prepare-ChangeLog:
2585 * Scripts/run-launcher:
2586 * Scripts/svn-create-patch:
2588 2014-10-10 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
2590 [jhbuild] We should be able to disable wiping on configuration change
2591 https://bugs.webkit.org/show_bug.cgi?id=137446
2593 Reviewed by Csaba Osztrogonác.
2595 The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2596 setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2597 or passing --no-wipe-on-change command line option.
2599 * Scripts/update-webkit-libs-jhbuild:
2601 2014-10-09 Andy Estes <aestes@apple.com>
2603 Teach webkitpy about OS X Yosemite
2604 https://bugs.webkit.org/show_bug.cgi?id=137585
2606 Reviewed by Simon Fraser.
2608 * Scripts/webkitpy/common/system/platforminfo.py:
2609 (PlatformInfo._determine_mac_version):
2610 * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2611 (TestPlatformInfo.test_os_version):
2612 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2613 (TestExpectationParser):
2614 * Scripts/webkitpy/port/builders.py:
2615 * Scripts/webkitpy/port/mac.py:
2617 * Scripts/webkitpy/port/mac_unittest.py:
2619 (test_baseline_search_path):
2620 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2621 (TestRebaselineTest.test_baseline_directory):
2622 (TestRebaselineExpectations.test_rebaseline_expectations):
2624 2014-10-09 Dana Burkart <dburkart@apple.com>
2626 Add Mac OS Yosemite dashboard support.
2628 Rubber-stamped by Lucas Forschler.
2630 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
2631 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
2632 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2633 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2634 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2636 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2638 Add Babak to contributors.json and add historical email addresses for some contributors
2639 https://bugs.webkit.org/show_bug.cgi?id=137546
2641 Reviewed by Christophe Dumez.
2643 contributors.json is used to analyze historical commit data and change logs.
2645 Add back historical email addresses for some contributors and also add Babak (Shafiei).
2647 * Scripts/webkitpy/common/config/contributors.json:
2649 2014-10-09 Lucas Forschler <lforschler@apple.com>
2651 Add Mac OS Yosemite webkit build infrastructure.
2653 This patch adds 15 bots to our build.webkit.org configuration.
2654 We are matching the current Mavericks machines 1:1.
2656 This patch includes some minor spacing changes to the buildslaves section to make everything similar.
2658 Reviewed by Matt Hanson.
2660 * BuildSlaveSupport/build.webkit.org-config/config.json:
2662 2014-10-09 Dana Burkart <dburkart@apple.com>
2664 Don't use backticks when running commands, as we run into sh-related
2665 interpolation issues. Also, fix our usage of system() to properly
2666 retrieve the status code.
2667 https://bugs.webkit.org/show_bug.cgi?id=137541
2669 Reviewed by Darin Adler.
2671 * Scripts/git-add-reviewer:
2674 (requireCleanWorkTree):
2677 (addReviewerToFile):
2681 (changeLogsForCommit):
2684 (runCommandWithOutput):
2686 2014-10-09 Tim Horton <timothy_horton@apple.com>
2688 Add a WebKit1 preference for selection services
2689 https://bugs.webkit.org/show_bug.cgi?id=137498
2690 <rdar://problem/18572699>
2692 Reviewed by Simon Fraser.
2694 * MiniBrowser/mac/WK1BrowserWindowController.m:
2695 (-[WK1BrowserWindowController awakeFromNib]):
2696 Turn on image and selection services in the Legacy WebKit MiniBrowser.
2698 2014-10-09 Adrien Destugues <pulkomandy@gmail.com>
2700 Get the patch scripts running on Haiku
2701 https://bugs.webkit.org/show_bug.cgi?id=137559
2703 Reviewed by Benjamin Poulain.
2705 Use /usr/bin/env instead of hardcoding path to perl.
2706 Declare haiku platform in platforminfo.py to avoid check-webkit-style
2709 * Scripts/commit-log-editor:
2711 * Scripts/prepare-ChangeLog:
2712 * Scripts/run-launcher:
2713 * Scripts/svn-create-patch:
2714 * Scripts/webkitpy/common/system/platforminfo.py:
2715 (PlatformInfo._determine_os_name):
2717 2014-10-08 Jake Nielsen <jacob_nielsen@apple.com>
2719 StyleQueue should throw a PatchIsNotValid exception to achieve
2720 consistency with CommitQueue and EWS
2721 https://bugs.webkit.org/show_bug.cgi?id=137500
2723 Reviewed by Alexey Proskuryakov.
2725 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2726 Adds a call to validate() in run().
2727 (StyleQueueTask.run):
2728 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2729 Adds a return False in the patch is not valid exception statement.
2730 (AbstractEarlyWarningSystem.review_patch):
2731 * Scripts/webkitpy/tool/commands/queues.py:
2732 Adds a return False in the patch is not valid exception statement in
2733 commit queue, and adds an except statement to catch PatchIsNotValid
2734 exceptions in style queue.
2735 (CommitQueue.process_work_item):
2736 (StyleQueue.review_patch):
2738 2014-10-08 Carlos Garcia Campos <cgarcia@igalia.com>
2740 Race condition with WebKitWebView:is-loading after starting page load
2741 https://bugs.webkit.org/show_bug.cgi?id=136692
2743 Reviewed by Gustavo Noronha Silva.
2745 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2746 (loadChangedCallback): Only check is-loading is false when load
2747 has finished if the load didn't fail due to a cancellation.
2748 (loadFailedCallback): Only check is-loading is false if the load
2749 didn't fail due to a cancellation.
2750 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2751 (WebViewTest::loadURI): Check is-loading is true and active URI is
2752 the requested one rigth after requesting the load.
2753 (WebViewTest::loadHtml): Ditto.
2754 (WebViewTest::loadPlainText): Ditto.
2755 (WebViewTest::loadBytes): Ditto.
2756 (WebViewTest::loadRequest): Ditto.
2757 (WebViewTest::loadAlternateHTML): Ditto.
2758 (WebViewTest::goBack): Ditto.
2759 (WebViewTest::goForward): Ditto.
2760 (WebViewTest::goToBackForwardListItem): Ditto.
2762 2014-10-08 Brent Fulgham <bfulgham@apple.com>
2764 [Win] Resolve various static analyzer warnings in Tools.
2765 https://bugs.webkit.org/show_bug.cgi?id=137534
2767 Reviewed by Dean Jackson.
2769 * DumpRenderTree/cg/ImageDiffCG.cpp:
2770 (main): User proper printf specifiers.
2771 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2772 (AccessibilityUIElement::childrenCount): Handle possibility that
2773 gcc_accChildCount returns with an error.
2774 (accessibilityState): Ditto for gcc_accState.
2775 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2776 (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
2777 check for return value from 'isHTML'. HRESULT is not a boolean and cannot
2779 * DumpRenderTree/win/DumpRenderTree.cpp:
2780 (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
2781 by comparing an unsigned value as being greater-than zero.
2782 * DumpRenderTree/win/EditingDelegate.cpp:
2783 (dump): Pass proper character pointer type to printf.
2784 (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
2785 (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2786 (EditingDelegate::shouldInsertNode): Ditto.
2787 (EditingDelegate::shouldInsertText): Ditto.
2788 (EditingDelegate::shouldDeleteDOMRange): Ditto.
2789 (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2790 (EditingDelegate::shouldApplyStyle): Ditto.
2791 * DumpRenderTree/win/EventSender.cpp:
2792 (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
2793 * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
2795 * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
2796 from CreateDIBSection.
2797 * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
2798 * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
2799 older versions of MSVC we no longer support.
2800 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
2802 * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
2803 * TestWebKitAPI/TestsController.h: Ditto.
2804 * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
2805 * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
2806 performing bitwise | before the comparison is done.
2808 2014-10-08 Ada Chan <adachan@apple.com>
2810 Add a test for WKPageIsPlayingAudio().
2811 https://bugs.webkit.org/show_bug.cgi?id=137048
2813 Reviewed by Darin Adler.
2815 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2816 Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
2817 * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
2818 (TestWebKitAPI::nullJavaScriptCallback):
2819 (TestWebKitAPI::didFinishLoadForFrame):
2820 (TestWebKitAPI::isPlayingAudioDidChangeCallback):
2821 (TestWebKitAPI::setUpClients):
2822 (TestWebKitAPI::TEST):
2823 This test loads a page with a video in it. When the page is loaded, we first check that
2824 WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
2825 When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
2826 now returns true for the page.
2827 * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
2828 * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
2829 This is a video copied from LayoutTests/media/content.
2831 2014-10-08 Csaba Osztrogonác <ossy@webkit.org>
2833 [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
2834 https://bugs.webkit.org/show_bug.cgi?id=137516
2836 Reviewed by Alexey Proskuryakov.
2838 * Scripts/webkitpy/thirdparty/__init__.py:
2839 (AutoinstallImportHook._install_irc):
2841 2014-10-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
2843 [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
2844 https://bugs.webkit.org/show_bug.cgi?id=137520
2846 Reviewed by Philippe Normand.
2848 Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
2849 For other distributions, we are already installing libjpeg-turbo.
2850 So, do the same for Debian and derivatives.
2852 * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
2854 2014-10-08 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2856 [webkitpy] Add back the workaround to replace ZipFile.extractall()
2857 https://bugs.webkit.org/show_bug.cgi?id=137519
2859 Reviewed by Csaba Osztrogonác.
2861 It was removed by <http://trac.webkit.org/changeset/174266>,
2862 because the comment stated it is a workaround for buggy python
2863 2.6.1 which shipped on Snow Leopard. But it turned out the bug
2864 is still valid with python 2.7 shipped on the latest Ubuntu
2865 (12.04 and 14.04) and OS X 10.9.
2867 * Scripts/webkitpy/common/system/autoinstall.py:
2869 (AutoInstaller._extract_all):
2870 (AutoInstaller._unzip):
2872 2014-10-08 Commit Queue <commit-queue@webkit.org>
2874 Unreviewed, rolling out r174335.
2875 https://bugs.webkit.org/show_bug.cgi?id=137515
2877 It broke EFL layout test totally (Requested by gyuyoung on
2882 "[EFL] Introduce EWebKit_Extension"
2883 https://bugs.webkit.org/show_bug.cgi?id=134921
2884 http://trac.webkit.org/changeset/174335
2886 2014-10-08 Carlos Garcia Campos <cgarcia@igalia.com>
2888 [GTK] Make forwarding headers generation depend on source code
2889 https://bugs.webkit.org/show_bug.cgi?id=137394
2891 Reviewed by Philippe Normand.
2893 * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
2894 * TestWebKitAPI/PlatformGTK.cmake: Only run
2895 generate-forwarding-headers.pl when source code changes.
2896 * WebKitTestRunner/PlatformGTK.cmake: Ditto.
2898 2014-10-07 Tanay C <tanay.c@samsung.com>
2900 Remove build warnings in Hashmap API tests
2901 https://bugs.webkit.org/show_bug.cgi?id=137484
2903 Reviewed by Darin Adler.
2905 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2906 (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry)
2908 2014-10-07 Jake Nielsen <jacob_nielsen@apple.com>
2910 Commit queue doesn't drop obsolete patches sometimes
2911 https://bugs.webkit.org/show_bug.cgi?id=137460
2913 Reviewed by Alexey Proskuryakov.
2915 * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2916 Adds another test patch for use in queues_unittest.py.
2917 courtesy of Csaba Osztrogonác <ossy@webkit.org>
2919 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2920 Raises a PatchIsNotValid exception in the case of validate() returning
2922 (CommitQueueTask.run):
2923 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2924 Raises a PatchIsNotValid exception in the case of validate() returning
2926 (EarlyWarningSystemTask.run):
2927 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2928 Defines PatchIsNotValid exception.
2930 (PatchIsNotValid.__init__):
2931 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2932 Remove call to validate() and instead catches the PatchIsNotValid
2934 (AbstractEarlyWarningSystem.review_patch):
2935 * Scripts/webkitpy/tool/commands/queues.py:
2936 Adds logic to catch the PatchIsNotValid exception.
2937 (CommitQueue.process_work_item):
2938 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2939 Adds the test_non_valid_patch test to ensure that invalid patches are
2940 handled properly, and don't just result in indefinite spinning.
2941 courtesy of Csaba Osztrogonác <ossy@webkit.org>
2942 (test_non_valid_patch):
2944 2014-10-07 Daniel Bates <dabates@apple.com>
2946 [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
2947 https://bugs.webkit.org/show_bug.cgi?id=137499
2949 Reviewed by Simon Fraser.
2951 Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
2952 honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
2953 should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
2954 bit simulator builds of iOS WebKit.
2956 * Scripts/webkitpy/port/ios.py:
2957 (IOSSimulatorPort._generate_all_test_configurations):
2959 2014-10-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
2961 [GTK] jhbuild modules should build xserver with the --without-dtrace option.
2962 https://bugs.webkit.org/show_bug.cgi?id=137482
2964 Reviewed by Martin Robinson.
2966 * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
2968 2014-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
2970 [SOUP] TLS errors should take precedence over HTTP authentication
2971 https://bugs.webkit.org/show_bug.cgi?id=137300
2973 Reviewed by Sergio Villar Senin.
2975 Add a test case to check that authenticate signal is not emitted
2976 in case of TLS errors, and the load fails instead.
2978 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2979 (webViewAuthenticationCallback):
2980 (testTLSErrorsHTTPAuth):
2981 (httpsServerCallback):
2984 2014-10-06 Ryosuke Niwa <rniwa@webkit.org>
2986 Make webkit-patch find-users useful
2987 https://bugs.webkit.org/show_bug.cgi?id=137475
2989 Reviewed by Alexey Proskuryakov.
2991 Make find-users use the CommitterList instead of accessing Bugzilla.
2993 This essentially exposes the same functionality as webkitbot's whois command.
2995 * Scripts/webkitpy/tool/commands/findusers.py:
2996 (FindUsers.execute):
2998 2014-10-06 Chris Fleizach <cfleizach@apple.com>
3000 AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3001 https://bugs.webkit.org/show_bug.cgi?id=137289
3003 Unreviewed build fix.
3005 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3006 (AccessibilityUIElement::getChildrenWithRange):
3008 2014-10-06 Alexey Proskuryakov <ap@apple.com>
3010 build.webkit.org/dashboard: Add commit queue
3011 https://bugs.webkit.org/show_bug.cgi?id=137462
3013 Reviewed by Tim Horton.
3015 Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3016 Style queue is still invisible, as it doesn't have an associated platform, and also
3017 we never have problems with it anyway, so it's not worth watching.
3019 The UI now allows for adding more bots to the Other column (such as leaks bot).
3020 To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3021 sources of data in a cell.
3023 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3025 (BubbleQueue.prototype.get statusPageURL):
3026 (BubbleQueue.prototype.update):
3027 (BubbleQueue.prototype.loadDetailedStatus):
3028 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3029 (BubbleQueueServer):
3030 (BubbleQueueServer.prototype.jsonQueueLengthURL):
3031 (BubbleQueueServer.prototype.jsonQueueStatusURL):
3032 (BubbleQueueServer.prototype.queueStatusURL):
3033 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3035 (BubbleQueueView.prototype.update.appendQueue):
3036 (BubbleQueueView.prototype.update):
3037 (BubbleQueueView.prototype._addQueueHeadingToPopover):
3038 (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3039 (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3040 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3041 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3042 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3043 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3044 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3045 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3046 (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3047 (.bubble-server-popover .latest-status-no-link):
3048 (.bubble-server-popover .bot-status-description):
3049 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3051 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3052 (buildAggregateTable):
3054 Removed dysfunctional support for EWS for now. It will be different.
3056 2014-10-06 Alexey Proskuryakov <ap@apple.com>
3058 One more case of incorrect comparison in recordpatchevent.py
3059 https://bugs.webkit.org/show_bug.cgi?id=137459
3061 Reviewed by Tim Horton.
3063 * QueueStatusServer/app.yaml:
3064 * QueueStatusServer/loggers/recordpatchevent.py:
3065 (RecordPatchEvent.started):
3067 2014-10-06 Alexey Proskuryakov <ap@apple.com>
3069 webkit-queues PatchLog is incorrect for patches that took less than a second
3070 https://bugs.webkit.org/show_bug.cgi?id=137453
3072 Reviewed by Tim Horton.
3074 * QueueStatusServer/app.yaml: Updated app version.
3076 * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3077 Don't bail out for patches that took 0 seconds to process (as frequently happens
3078 when a patch is obsolete).
3080 2014-10-06 Csaba Osztrogonác <ossy@webkit.org>
3082 EWS bubble hover shows wrong timestamps
3083 https://bugs.webkit.org/show_bug.cgi?id=137252
3085 Reviewed by Alexey Proskuryakov.
3087 Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
3089 * QueueStatusServer/handlers/queuestatusjson.py:
3090 (QueueStatusJSON.get):
3091 * QueueStatusServer/handlers/statusbubble.py:
3092 (StatusBubble._iso_time):
3094 2014-10-06 Mario Sanchez Prada <mario@webkit.org>
3096 Unreviewed, updated list of email addresses in contributors.json
3098 * Scripts/webkitpy/common/config/contributors.json: Added my former
3099 email address in Igalia, for the sake of completeness.
3101 2014-10-06 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
3103 Unreviewed, moved myself to the list of committers.
3105 * Scripts/webkitpy/common/config/contributors.json:
3107 2014-10-05 Ryuan Choi <ryuan.choi@gmail.com>
3109 [EFL] Introduce EWebKit_Extension
3110 https://bugs.webkit.org/show_bug.cgi?id=134921
3112 Reviewed by Gyuyoung Kim.
3114 * MiniBrowser/efl/main.c: Added x option to test extension path.
3117 * Scripts/webkitpy/common/config/watchlist:
3118 Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3119 * Scripts/webkitpy/style/checker.py:
3120 Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3122 2014-10-04 Csaba Osztrogonác <ossy@webkit.org>
3124 [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
3125 https://bugs.webkit.org/show_bug.cgi?id=137390
3127 Reviewed by Carlos Garcia Campos.
3129 * Scripts/update-webkit-libs-jhbuild:
3131 2014-10-04 Carlos Garcia Campos <cgarcia@igalia.com>
3133 [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
3134 https://bugs.webkit.org/show_bug.cgi?id=137391
3136 Reviewed by Martin Robinson.
3138 Add a custom command to only re-generate
3139 webkit2gtk-tests-resources.gresource when any of its dependencies changes.
3141 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3143 2014-10-04 Carlos Garcia Campos <cgarcia@igalia.com>
3145 [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
3146 https://bugs.webkit.org/show_bug.cgi?id=135502
3148 Reviewed by Martin Robinson.
3150 When writing to stdout/stderr fails due to a UnicodeDecodeError
3151 exception, try again without encoding the output.
3154 (GTKDoc._run_command):
3156 2014-10-03 Alexey Proskuryakov <ap@apple.com>
3158 Bugzilla status bubble displays an exception showing attachment 175738
3159 https://bugs.webkit.org/show_bug.cgi?id=137410
3161 Reviewed by Tim Horton.
3163 * QueueStatusServer/app.yaml: Update version.
3165 * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
3166 Don't fail even if expected status message is missing.
3168 * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
3169 the field in the same way it's defined in QueueStatus table.
3171 2014-10-03 Alexey Proskuryakov <ap@apple.com>
3173 Record latest message in PatchLog for quick access
3174 https://bugs.webkit.org/show_bug.cgi?id=137405
3178 * QueueStatusServer/app.yaml:
3179 * QueueStatusServer/handlers/releasepatch.py:
3181 2014-10-03 Alexey Proskuryakov <ap@apple.com>
3183 Record latest message in PatchLog for quick access
3184 https://bugs.webkit.org/show_bug.cgi?id=137405
3186 Reviewed by Ryosuke Niwa.
3190 * QueueStatusServer/handlers/releasepatch.py:
3191 * QueueStatusServer/handlers/updatestatus.py:
3192 * QueueStatusServer/loggers/recordpatchevent.py:
3193 * QueueStatusServer/model/patchlog.py:
3195 2014-10-02 David Farler <dfarler@apple.com>
3197 -asan-blacklist option also renamed to generic -fsanitize-blacklist
3198 https://bugs.webkit.org/show_bug.cgi?id=137377
3200 Reviewed by Daniel Bates.
3202 * asan/asan.xcconfig:
3203 -asan-blacklist -> -fsanitize-blacklist
3205 http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3207 2014-10-03 Roger Fong <roger_fong@apple.com>
3209 [Windows] Include batch size argument to layout tests on Windows.
3211 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3212 (RunWebKitTests.start):
3213 This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
3214 These crashes seem to happen on random tests though generally in a spread out fashion.
3215 It seems possible that the DRT instance is being clobbered somehow after running too many
3216 tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
3218 2014-10-03 Roger Fong <roger_fong@apple.com>
3220 [Windows] Settle for 2 chid processes running NRWT on Windows.
3222 * Scripts/webkitpy/port/win.py:
3223 (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
3225 2014-10-03 Akos Kiss <akiss@inf.u-szeged.hu>
3227 [GTK] Bump up and patch dependencies to allow building for aarch64
3228 https://bugs.webkit.org/show_bug.cgi?id=137147
3230 Reviewed by Martin Robinson.
3232 The currently used versions of pixman, libffi, librsvg, glib,
3233 glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
3234 and/or build for aarch64, so they are bumped up and patched where
3235 necessary. Wherever possible, the same versions and patches were used as
3236 for the EFL port bump-up
3237 (https://bugs.webkit.org/show_bug.cgi?id=135885).
3239 After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
3240 regression by crashing http/tests/media/video-redirect.html . A patch
3241 already in upstream fixes that bug.
3243 This change does not touch xserver, which also needs bumping up, but
3244 will be dealt with later.
3246 * gtk/jhbuild.modules:
3247 Specified versions and patches necessary to correctly build for aarch64.
3248 * gtk/patches/gst-events-arent-gstobjects.patch:
3249 Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
3250 * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
3251 Added. Patches gst-plugins-base to configure correctly for aarch64.
3252 * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
3253 Added. Bumps up config.guess and config.sub in librsvg to recognize
3255 * gtk/patches/libxml2-2.9.0-dtd.patch:
3256 Removed. Not necessary for libxml2 v2.9.1 anymore.
3258 2014-09-28 Sam Weinig <sam@webkit.org>
3260 Remove RefPtrHashMap
3261 https://bugs.webkit.org/show_bug.cgi?id=137200
3263 Reviewed by Darin Adler.
3265 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3266 (TestWebKitAPI::TEST):
3267 Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
3268 a minimum of refcount churn occurs.
3270 2014-10-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3272 Remove workarounds for versions of Python before 2.7
3273 https://bugs.webkit.org/show_bug.cgi?id=137338
3275 Reviewed by Csaba Osztrogonác.
3277 * Scripts/webkitpy/common/system/autoinstall.py:
3278 (AutoInstaller._extract_targz):
3279 (AutoInstaller._unzip):
3280 (AutoInstaller): Deleted.
3281 (AutoInstaller._extract_all): Deleted.
3282 * Scripts/webkitpy/common/webkitunittest.py:
3283 (TestCase.setUp): Deleted.
3284 * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3285 (TestConfigurationConverter.collapse_macros):
3286 (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3287 (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3288 (TestConfigurationConverter):
3289 (TestConfigurationConverter.combinations): Deleted.
3290 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3291 * Scripts/webkitpy/port/base.py:
3293 2014-10-03 Commit Queue <commit-queue@webkit.org>
3295 Unreviewed, rolling out r174264.
3296 https://bugs.webkit.org/show_bug.cgi?id=137392
3298 It broke run-webkit-tests (Requested by ebalazsfalvi on
3303 "Remove workarounds for versions of Python before 2.7"
3304 https://bugs.webkit.org/show_bug.cgi?id=137338
3305 http://trac.webkit.org/changeset/174264
3307 2014-10-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3309 Remove workarounds for versions of Python before 2.7
3310 https://bugs.webkit.org/show_bug.cgi?id=137338
3312 Reviewed by Csaba Osztrogonác.
3314 * Scripts/webkitpy/common/system/autoinstall.py:
3315 (AutoInstaller._extract_targz):
3316 (AutoInstaller._unzip):
3317 (AutoInstaller): Deleted.
3318 (AutoInstaller._extract_all): Deleted.
3319 * Scripts/webkitpy/common/webkitunittest.py:
3320 (TestCase.setUp): Deleted.
3321 * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3322 (TestConfigurationConverter.collapse_macros):
3323 (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3324 (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3325 (TestConfigurationConverter):
3326 (TestConfigurationConverter.combinations): Deleted.
3327 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3328 * Scripts/webkitpy/port/base.py:
3329 * Scripts/webkitpy/port/driver.py:
3330 (ContentBlock.__init__):
3331 * Scripts/webkitpy/port/server_process.py:
3332 (ServerProcess._reset):
3334 2014-10-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3336 Remove autoinstaller workaround for python 2.6
3337 https://bugs.webkit.org/show_bug.cgi?id=137343
3339 Reviewed by Daniel Bates.
3341 Reverting <http://trac.webkit.org/changeset/124928>, neither Python
3342 2.6, nor Snow Leopard is supported anymore, so the workaround is not
3345 * Scripts/webkitpy/common/system/autoinstall.py:
3346 (AutoInstaller.install):
3347 * Scripts/webkitpy/test/main.py:
3348 (Tester._run_tests):
3349 * Scripts/webkitpy/thirdparty/__init__.py:
3350 (AutoinstallImportHook._install_mechanize):
3351 (AutoinstallImportHook._install_pep8):
3352 (AutoinstallImportHook._install_pylint):
3353 (AutoinstallImportHook._install_buildbot):
3354 (AutoinstallImportHook._install_coverage):
3355 (AutoinstallImportHook._install_eliza):
3356 (AutoinstallImportHook._install_irc):
3357 (AutoinstallImportHook._install):
3358 (autoinstall_everything):
3360 2014-10-02 Daniel Bates <dabates@apple.com>
3362 Use version number 101000 instead of 10100 for OS X Yosemite
3363 https://bugs.webkit.org/show_bug.cgi?id=137372
3365 Reviewed by Mark Rowe.
3367 The version number for OS X Yosemite is 101000.
3369 * DumpRenderTree/mac/TextInputController.m:
3371 2014-10-02 Alexey Proskuryakov <ap@apple.com>
3373 update-work-items should never delete items
3374 https://bugs.webkit.org/show_bug.cgi?id=137366
3376 Reviewed by Ryosuke Niwa.
3378 As we don't just replace the whole list any more, indicate which items are high
3379 priority, and which are not. Hight priority ones will be prepended to the queue,
3380 others will be appended.
3382 This creates a bit of unfairness in that high priority item queue becomes a LIFO.
3383 But hopefully we will never have many rollouts competing like that.
3385 * QueueStatusServer/app.yaml: Update version.
3387 * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
3388 priority and regular items separately. Removed some error handling that used to
3389 end up in returning status 500 - an uncaught exception does that automatically.
3391 * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
3393 * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
3395 * QueueStatusServer/templates/updateworkitems.html: Added a field for high
3398 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3399 (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
3400 line that complicated testing.
3402 * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
3404 * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
3405 priority items into separate lists.
3407 * Scripts/webkitpy/common/net/statusserver_mock.py:
3408 * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3409 * Scripts/webkitpy/tool/commands/queues_unittest.py:
3412 2014-10-02 Brendan Long <b.long@cablelabs.com>
3414 Annoying build warnings in WTFString API tests
3415 https://bugs.webkit.org/show_bug.cgi?id=137360
3417 Reviewed by Darin Adler.
3419 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3420 (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
3422 2014-10-02 Roger Fong <roger_fong@apple.com>
3424 [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
3426 * Scripts/webkitpy/port/win.py:
3427 (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
3429 2014-10-02 David Farler <dfarler@apple.com>
3431 Move ASan arguments from LLVM (-mllvm) to the frontend
3432 https://bugs.webkit.org/show_bug.cgi?id=137365
3434 Reviewed by David Kilzer.
3436 * asan/asan.xcconfig:
3437 Remove the -mllvm prefix to the asan-blacklist argument, moving it
3438 to the clang frontend.
3440 http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3442 2014-10-02 Commit Queue <commit-queue@webkit.org>
3444 Unreviewed, rolling out r174120.
3445 https://bugs.webkit.org/show_bug.cgi?id=137350
3447 While number of failures is reasonable with 2 processes, test
3448 results seem to be inconsistent between runs (Requested by
3453 "[Windows] Back to 2 child processes for NRWT on Windows."
3454 http://trac.webkit.org/changeset/174120
3456 2014-10-02 Jeff Miller <jeffm@apple.com>
3458 DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
3459 https://bugs.webkit.org/show_bug.cgi?id=137347
3461 Reviewed by Dan Bernstein.
3463 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3464 Use WebKitSystemInterfaceYosemite on OS X 10.10.
3466 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3469 2014-10-02 Carlos Alberto Lopez Perez <clopez@igalia.com>
3471 [GTK] [JHBuild] Switch sourceware.org mirror to http.
3475 The ftp access is recently failing to work as expected, and the
3476 bots fail to download the file.
3477 The same mirror is available via http and seems to work better.
3479 * gtk/jhbuild.modules:
3481 2014-10-01 Commit Queue <commit-queue@webkit.org>
3483 Unreviewed, rolling out r174185.
3484 https://bugs.webkit.org/show_bug.cgi?id=137334
3486 Patch that adds logging causes webkitpy failures (Requested by
3491 "commitqueuetasks_unittest references a non-existent member
3493 https://bugs.webkit.org/show_bug.cgi?id=137303
3494 http://trac.webkit.org/changeset/174185
3496 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com>
3498 EWS and Commit Queue should know better than to spew 500 failed
3499 results in the case of extremely red patches.
3500 https://bugs.webkit.org/show_bug.cgi?id=137324
3502 Reviewed by Alexey Proskuryakov.
3504 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3505 Adds a check for did_exceed_test_failure_limit.
3506 (AbstractEarlyWarningSystem._failing_tests_message):
3507 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3508 Alters the task mock to respond properly to
3509 results_from_patch_test_run(patch)
3510 (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3511 * Scripts/webkitpy/tool/commands/queues.py:
3512 Adds a check for did_exceed_test_failure_limit.
3513 (CommitQueue._failing_tests_message):
3515 2014-10-01 Daniel Bates <dabates@apple.com>
3517 Unreviewed, rolling out r174192.
3519 Revert the unit test fix in r174192 since we reverted r174187
3520 in r174194 due to correctness issues. See
3521 <http://webkit.org/b/137329> for more details.
3525 "Test fix after r174187"
3526 http://trac.webkit.org/changeset/174192
3528 2014-10-01 Mark Rowe <mrowe@apple.com>
3530 <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3532 Reviewed by Dan Bernstein.
3534 * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
3535 into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
3536 for the LLVM components when on Yosemite.
3538 2014-10-01 Commit Queue <commit-queue@webkit.org>
3540 Unreviewed, rolling out r174187.
3541 https://bugs.webkit.org/show_bug.cgi?id=137329
3543 webkitpy failures, and thorton says the patch is wrong
3544 (Requested by dethbakin on #webkit).
3548 "[Windows] Increase layout test timeout for Windows following
3550 http://trac.webkit.org/changeset/174187
3552 2014-10-01 Brent Fulgham <bfulgham@apple.com>
3554 Test fix after r174187
3556 * Scripts/webkitpy/port/win_unittest.py:
3557 (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
3559 2014-10-01 Roger Fong <roger_fong@apple.com>
3561 [Windows] Increase layout test timeout for Windows following r174162.
3563 * Scripts/webkitpy/port/win.py:
3564 (WinPort.default_timeout_ms):
3566 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com>
3568 commitqueuetasks_unittest references a non-existent member variable
3569 when mock-reporting flaky tests.
3570 https://bugs.webkit.org/show_bug.cgi?id=137303
3572 Reviewed by Daniel Bates.
3574 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3575 (MockCommitQueue.report_flaky_tests):
3576 Makes the appropriate name change.
3577 (test_simple_flaky_test_failure):
3578 Adds a unit test to make sure that the code is excercised.
3580 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com>
3582 EWS is inconclusively spinning forever on a patch that breaks 500+
3584 https://bugs.webkit.org/show_bug.cgi?id=137223
3586 Reviewed by Tim Horton.
3588 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3589 Checks to see whether the tests have exceeded the failure limit, and
3590 only spins off another test if they have not exceeded the limit.
3591 (PatchAnalysisTask._test_patch):
3593 2014-10-01 Brian J. Burg <burg@cs.washington.edu>
3595 Unreviewed, add Katie Madonna as a contributor.
3597 * Scripts/webkitpy/common/config/contributors.json:
3599 2014-10-01 Jake Nielsen <jacob_nielsen@apple.com>
3601 commitqueuetasks_unittest does not construct FailingTestCommitQueue
3602 objects properly in its test cases.
3603 https://bugs.webkit.org/show_bug.cgi?id=137281
3605 Reviewed by Daniel Bates.
3607 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3608 (FailingTestCommitQueue.test_results):
3609 Adds an assert to make FailingTestCommitQueue harder to mis-use.
3610 (test_double_flaky_test_failure):
3611 Nests the intended test failure strings into one-length lists.
3612 (test_red_test_failure):
3613 Nests the intended test failure strings into one-length lists.
3615 2014-10-01 Alexey Proskuryakov <ap@apple.com>
3617 REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
3618 https://bugs.webkit.org/show_bug.cgi?id=136987
3620 Reviewed by Daniel Bates.
3622 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3623 Specify the default encoding for all WebKit developers to get consistent results.
3625 2014-10-01 Alexey Proskuryakov <ap@apple.com>
3627 EWS is too eager to say that a patch does not apply to trunk of repository
3628 https://bugs.webkit.org/show_bug.cgi?id=137290
3630 Reviewed by Ryosuke Niwa.
3632 * QueueStatusServer/app.yaml: Updated app version.
3634 * QueueStatusServer/handlers/statusbubble.py:
3635 (StatusBubble._build_bubble):
3636 (StatusBubble._build_bubbles_for_attachment):
3637 Rewrote to make more sense.
3639 2014-09-30 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
3641 Remove thirdparty/unittest2 from webkitpy
3642 https://bugs.webkit.org/show_bug.cgi?id=137251