EWS bubble hover shows wrong timestamps
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
2
3         EWS bubble hover shows wrong timestamps
4         https://bugs.webkit.org/show_bug.cgi?id=137252
5
6         Reviewed by Alexey Proskuryakov.
7
8         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
9
10         * QueueStatusServer/handlers/queuestatusjson.py:
11         (QueueStatusJSON.get):
12         * QueueStatusServer/handlers/statusbubble.py:
13         (StatusBubble._iso_time):
14
15 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
16
17         Unreviewed, updated list of email addresses in contributors.json
18
19         * Scripts/webkitpy/common/config/contributors.json: Added my former
20         email address in Igalia, for the sake of completeness.
21
22 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
23
24         Unreviewed, moved myself to the list of committers.
25
26         * Scripts/webkitpy/common/config/contributors.json:
27
28 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
29
30         [EFL] Introduce EWebKit_Extension
31         https://bugs.webkit.org/show_bug.cgi?id=134921
32
33         Reviewed by Gyuyoung Kim.
34
35         * MiniBrowser/efl/main.c: Added x option to test extension path.
36         (window_create):
37         (elm_main):
38         * Scripts/webkitpy/common/config/watchlist:
39         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
40         * Scripts/webkitpy/style/checker.py:
41         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
42
43 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
44
45         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
46         https://bugs.webkit.org/show_bug.cgi?id=137390
47
48         Reviewed by Carlos Garcia Campos.
49
50         * Scripts/update-webkit-libs-jhbuild:
51
52 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
53
54         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
55         https://bugs.webkit.org/show_bug.cgi?id=137391
56
57         Reviewed by Martin Robinson.
58
59         Add a custom command to only re-generate
60         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
61
62         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
63
64 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
65
66         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
67         https://bugs.webkit.org/show_bug.cgi?id=135502
68
69         Reviewed by Martin Robinson.
70
71         When writing to stdout/stderr fails due to a UnicodeDecodeError
72         exception, try again without encoding the output.
73
74         * gtk/gtkdoc.py:
75         (GTKDoc._run_command):
76
77 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
78
79         Bugzilla status bubble displays an exception showing attachment 175738
80         https://bugs.webkit.org/show_bug.cgi?id=137410
81
82         Reviewed by Tim Horton.
83
84         * QueueStatusServer/app.yaml: Update version.
85
86         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
87         Don't fail even if expected status message is missing.
88
89         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
90         the field in the same way it's defined in QueueStatus table.
91
92 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
93
94         Record latest message in PatchLog for quick access
95         https://bugs.webkit.org/show_bug.cgi?id=137405
96
97         Fixing a typo.
98
99         * QueueStatusServer/app.yaml:
100         * QueueStatusServer/handlers/releasepatch.py:
101
102 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
103
104         Record latest message in PatchLog for quick access
105         https://bugs.webkit.org/show_bug.cgi?id=137405
106
107         Reviewed by Ryosuke Niwa.
108
109         It's no SQL...
110
111         * QueueStatusServer/handlers/releasepatch.py:
112         * QueueStatusServer/handlers/updatestatus.py:
113         * QueueStatusServer/loggers/recordpatchevent.py:
114         * QueueStatusServer/model/patchlog.py:
115
116 2014-10-02  David Farler  <dfarler@apple.com>
117
118         -asan-blacklist option also renamed to generic -fsanitize-blacklist
119         https://bugs.webkit.org/show_bug.cgi?id=137377
120
121         Reviewed by Daniel Bates.
122
123         * asan/asan.xcconfig:
124         -asan-blacklist -> -fsanitize-blacklist
125
126         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
127
128 2014-10-03  Roger Fong  <roger_fong@apple.com>
129
130         [Windows] Include batch size argument to layout tests on Windows.
131
132         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
133         (RunWebKitTests.start): 
134         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
135         These crashes seem to happen on random tests though generally in a spread out fashion.
136         It seems possible that the DRT instance is being clobbered somehow after running too many
137         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
138
139 2014-10-03  Roger Fong  <roger_fong@apple.com>
140
141         [Windows] Settle for 2 chid processes running NRWT on Windows.
142
143         * Scripts/webkitpy/port/win.py:
144         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
145
146 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
147
148         [GTK] Bump up and patch dependencies to allow building for aarch64
149         https://bugs.webkit.org/show_bug.cgi?id=137147
150
151         Reviewed by Martin Robinson.
152
153         The currently used versions of pixman, libffi, librsvg, glib,
154         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
155         and/or build for aarch64, so they are bumped up and patched where
156         necessary. Wherever possible, the same versions and patches were used as
157         for the EFL port bump-up
158         (https://bugs.webkit.org/show_bug.cgi?id=135885).
159
160         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
161         regression by crashing http/tests/media/video-redirect.html . A patch
162         already in upstream fixes that bug.
163
164         This change does not touch xserver, which also needs bumping up, but 
165         will be dealt with later.
166
167         * gtk/jhbuild.modules:
168         Specified versions and patches necessary to correctly build for aarch64.
169         * gtk/patches/gst-events-arent-gstobjects.patch:
170         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
171         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
172         Added. Patches gst-plugins-base to configure correctly for aarch64.
173         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
174         Added. Bumps up config.guess and config.sub in librsvg to recognize
175         aarch64.
176         * gtk/patches/libxml2-2.9.0-dtd.patch:
177         Removed. Not necessary for libxml2 v2.9.1 anymore.
178
179 2014-09-28  Sam Weinig  <sam@webkit.org>
180
181         Remove RefPtrHashMap
182         https://bugs.webkit.org/show_bug.cgi?id=137200
183
184         Reviewed by Darin Adler.
185
186         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
187         (TestWebKitAPI::TEST):
188         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
189         a minimum of refcount churn occurs.
190
191 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
192
193         Remove workarounds for versions of Python before 2.7
194         https://bugs.webkit.org/show_bug.cgi?id=137338
195
196         Reviewed by Csaba Osztrogonác.
197
198         * Scripts/webkitpy/common/system/autoinstall.py:
199         (AutoInstaller._extract_targz):
200         (AutoInstaller._unzip):
201         (AutoInstaller): Deleted.
202         (AutoInstaller._extract_all): Deleted.
203         * Scripts/webkitpy/common/webkitunittest.py:
204         (TestCase.setUp): Deleted.
205         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
206         (TestConfigurationConverter.collapse_macros):
207         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
208         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
209         (TestConfigurationConverter):
210         (TestConfigurationConverter.combinations): Deleted.
211         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
212         * Scripts/webkitpy/port/base.py:
213
214 2014-10-03  Commit Queue  <commit-queue@webkit.org>
215
216         Unreviewed, rolling out r174264.
217         https://bugs.webkit.org/show_bug.cgi?id=137392
218
219         It broke run-webkit-tests (Requested by ebalazsfalvi on
220         #webkit).
221
222         Reverted changeset:
223
224         "Remove workarounds for versions of Python before 2.7"
225         https://bugs.webkit.org/show_bug.cgi?id=137338
226         http://trac.webkit.org/changeset/174264
227
228 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
229
230         Remove workarounds for versions of Python before 2.7
231         https://bugs.webkit.org/show_bug.cgi?id=137338
232
233         Reviewed by Csaba Osztrogonác.
234
235         * Scripts/webkitpy/common/system/autoinstall.py:
236         (AutoInstaller._extract_targz):
237         (AutoInstaller._unzip):
238         (AutoInstaller): Deleted.
239         (AutoInstaller._extract_all): Deleted.
240         * Scripts/webkitpy/common/webkitunittest.py:
241         (TestCase.setUp): Deleted.
242         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
243         (TestConfigurationConverter.collapse_macros):
244         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
245         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
246         (TestConfigurationConverter):
247         (TestConfigurationConverter.combinations): Deleted.
248         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
249         * Scripts/webkitpy/port/base.py:
250         * Scripts/webkitpy/port/driver.py:
251         (ContentBlock.__init__):
252         * Scripts/webkitpy/port/server_process.py:
253         (ServerProcess._reset):
254
255 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
256
257         Remove autoinstaller workaround for python 2.6
258         https://bugs.webkit.org/show_bug.cgi?id=137343
259
260         Reviewed by Daniel Bates.
261
262         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
263         2.6, nor Snow Leopard is supported anymore, so the workaround is not
264         needed anymore.
265
266         * Scripts/webkitpy/common/system/autoinstall.py:
267         (AutoInstaller.install):
268         * Scripts/webkitpy/test/main.py:
269         (Tester._run_tests):
270         * Scripts/webkitpy/thirdparty/__init__.py:
271         (AutoinstallImportHook._install_mechanize):
272         (AutoinstallImportHook._install_pep8):
273         (AutoinstallImportHook._install_pylint):
274         (AutoinstallImportHook._install_buildbot):
275         (AutoinstallImportHook._install_coverage):
276         (AutoinstallImportHook._install_eliza):
277         (AutoinstallImportHook._install_irc):
278         (AutoinstallImportHook._install):
279         (autoinstall_everything):
280
281 2014-10-02  Daniel Bates  <dabates@apple.com>
282
283         Use version number 101000 instead of 10100 for OS X Yosemite
284         https://bugs.webkit.org/show_bug.cgi?id=137372
285
286         Reviewed by Mark Rowe.
287
288         The version number for OS X Yosemite is 101000.
289
290         * DumpRenderTree/mac/TextInputController.m:
291
292 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
293
294         update-work-items should never delete items
295         https://bugs.webkit.org/show_bug.cgi?id=137366
296
297         Reviewed by Ryosuke Niwa.
298
299         As we don't just replace the whole list any more, indicate which items are high
300         priority, and which are not. Hight priority ones will be prepended to the queue,
301         others will be appended.
302
303         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
304         But hopefully we will never have many rollouts competing like that.
305
306         * QueueStatusServer/app.yaml: Update version.
307
308         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
309         priority and regular items separately. Removed some error handling that used to
310         end up in returning status 500 - an uncaught exception does that automatically.
311
312         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
313
314         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
315
316         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
317         priority items.
318
319         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
320         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
321         line that complicated testing.
322
323         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
324
325         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
326         priority items into separate lists.
327
328         * Scripts/webkitpy/common/net/statusserver_mock.py:
329         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
330         * Scripts/webkitpy/tool/commands/queues_unittest.py:
331         Updated tests.
332
333 2014-10-02  Brendan Long  <b.long@cablelabs.com>
334
335         Annoying build warnings in WTFString API tests
336         https://bugs.webkit.org/show_bug.cgi?id=137360
337
338         Reviewed by Darin Adler.
339
340         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
341         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
342
343 2014-10-02  Roger Fong  <roger_fong@apple.com>
344
345         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
346
347         * Scripts/webkitpy/port/win.py:
348         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
349
350 2014-10-02  David Farler  <dfarler@apple.com>
351
352         Move ASan arguments from LLVM (-mllvm) to the frontend
353         https://bugs.webkit.org/show_bug.cgi?id=137365
354
355         Reviewed by David Kilzer.
356
357         * asan/asan.xcconfig:
358         Remove the -mllvm prefix to the asan-blacklist argument, moving it
359         to the clang frontend.
360
361         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
362
363 2014-10-02  Commit Queue  <commit-queue@webkit.org>
364
365         Unreviewed, rolling out r174120.
366         https://bugs.webkit.org/show_bug.cgi?id=137350
367
368         While number of failures is reasonable with 2 processes, test
369         results seem to be inconsistent between runs (Requested by
370         rfong on #webkit).
371
372         Reverted changeset:
373
374         "[Windows] Back to 2 child processes for NRWT on Windows."
375         http://trac.webkit.org/changeset/174120
376
377 2014-10-02  Jeff Miller  <jeffm@apple.com>
378
379         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
380         https://bugs.webkit.org/show_bug.cgi?id=137347
381
382         Reviewed by Dan Bernstein.
383
384         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
385         Use WebKitSystemInterfaceYosemite on OS X 10.10.
386
387         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
388         Ditto.
389
390 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
391
392         [GTK] [JHBuild] Switch sourceware.org mirror to http.
393
394         Unreviewed.
395
396         The ftp access is recently failing to work as expected, and the
397         bots fail to download the file.
398         The same mirror is available via http and seems to work better.
399
400         * gtk/jhbuild.modules:
401
402 2014-10-01  Commit Queue  <commit-queue@webkit.org>
403
404         Unreviewed, rolling out r174185.
405         https://bugs.webkit.org/show_bug.cgi?id=137334
406
407         Patch that adds logging causes webkitpy failures (Requested by
408         rfong on #webkit).
409
410         Reverted changeset:
411
412         "commitqueuetasks_unittest references a non-existent member
413         variable"
414         https://bugs.webkit.org/show_bug.cgi?id=137303
415         http://trac.webkit.org/changeset/174185
416
417 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
418
419         EWS and Commit Queue should know better than to spew 500 failed
420         results in the case of extremely red patches.
421         https://bugs.webkit.org/show_bug.cgi?id=137324
422
423         Reviewed by Alexey Proskuryakov.
424
425         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
426         Adds a check for did_exceed_test_failure_limit.
427         (AbstractEarlyWarningSystem._failing_tests_message):
428         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
429         Alters the task mock to respond properly to
430         results_from_patch_test_run(patch)
431         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
432         * Scripts/webkitpy/tool/commands/queues.py:
433         Adds a check for did_exceed_test_failure_limit.
434         (CommitQueue._failing_tests_message):
435
436 2014-10-01  Daniel Bates  <dabates@apple.com>
437
438         Unreviewed, rolling out r174192.
439
440         Revert the unit test fix in r174192 since we reverted r174187
441         in r174194 due to correctness issues. See
442         <http://webkit.org/b/137329> for more details.
443
444         Reverted changeset:
445
446         "Test fix after r174187"
447         http://trac.webkit.org/changeset/174192
448
449 2014-10-01  Mark Rowe  <mrowe@apple.com>
450
451         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
452
453         Reviewed by Dan Bernstein.
454
455         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
456         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
457         for the LLVM components when on Yosemite.
458
459 2014-10-01  Commit Queue  <commit-queue@webkit.org>
460
461         Unreviewed, rolling out r174187.
462         https://bugs.webkit.org/show_bug.cgi?id=137329
463
464         webkitpy failures, and thorton says the patch is wrong
465         (Requested by dethbakin on #webkit).
466
467         Reverted changeset:
468
469         "[Windows] Increase layout test timeout for Windows following
470         r174162."
471         http://trac.webkit.org/changeset/174187
472
473 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
474
475         Test fix after r174187
476
477         * Scripts/webkitpy/port/win_unittest.py:
478         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
479
480 2014-10-01  Roger Fong  <roger_fong@apple.com>
481
482         [Windows] Increase layout test timeout for Windows following r174162.
483
484         * Scripts/webkitpy/port/win.py:
485         (WinPort.default_timeout_ms):
486
487 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
488
489         commitqueuetasks_unittest references a non-existent member variable
490         when mock-reporting flaky tests.
491         https://bugs.webkit.org/show_bug.cgi?id=137303
492
493         Reviewed by Daniel Bates.
494
495         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
496         (MockCommitQueue.report_flaky_tests):
497         Makes the appropriate name change.
498         (test_simple_flaky_test_failure):
499         Adds a unit test to make sure that the code is excercised.
500
501 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
502
503         EWS is inconclusively spinning forever on a patch that breaks 500+
504         tests
505         https://bugs.webkit.org/show_bug.cgi?id=137223
506
507         Reviewed by Tim Horton.
508
509         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
510         Checks to see whether the tests have exceeded the failure limit, and
511         only spins off another test if they have not exceeded the limit.
512         (PatchAnalysisTask._test_patch):
513
514 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
515
516         Unreviewed, add Katie Madonna as a contributor.
517
518         * Scripts/webkitpy/common/config/contributors.json:
519
520 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
521
522         commitqueuetasks_unittest does not construct FailingTestCommitQueue
523         objects properly in its test cases.
524         https://bugs.webkit.org/show_bug.cgi?id=137281
525
526         Reviewed by Daniel Bates.
527
528         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
529         (FailingTestCommitQueue.test_results):
530         Adds an assert to make FailingTestCommitQueue harder to mis-use.
531         (test_double_flaky_test_failure):
532         Nests the intended test failure strings into one-length lists.
533         (test_red_test_failure):
534         Nests the intended test failure strings into one-length lists.
535
536 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
537
538         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
539         https://bugs.webkit.org/show_bug.cgi?id=136987
540
541         Reviewed by Daniel Bates.
542
543         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
544         Specify the default encoding for all WebKit developers to get consistent results.
545
546 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
547
548         EWS is too eager to say that a patch does not apply to trunk of repository
549         https://bugs.webkit.org/show_bug.cgi?id=137290
550
551         Reviewed by Ryosuke Niwa.
552
553         * QueueStatusServer/app.yaml: Updated app version.
554
555         * QueueStatusServer/handlers/statusbubble.py:
556         (StatusBubble._build_bubble):
557         (StatusBubble._build_bubbles_for_attachment):
558         Rewrote to make more sense.
559
560 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
561
562         Remove thirdparty/unittest2 from webkitpy
563         https://bugs.webkit.org/show_bug.cgi?id=137251
564
565         Reviewed by Brent Fulgham.
566
567         Additionally ordered imports in related webkitpy files and
568         removed unnecessary shebangs from unittest files.
569
570         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
571         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
572         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
573         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
574         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
575         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
576         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
577         * Scripts/webkitpy/common/config/committers_unittest.py:
578         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
579         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
580         * Scripts/webkitpy/common/config/ports_unittest.py:
581         * Scripts/webkitpy/common/config/urls_unittest.py:
582         * Scripts/webkitpy/common/editdistance_unittest.py:
583         * Scripts/webkitpy/common/find_files_unittest.py:
584         * Scripts/webkitpy/common/lru_cache_unittest.py:
585         * Scripts/webkitpy/common/memoized_unittest.py:
586         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
587         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
588         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
589         * Scripts/webkitpy/common/net/credentials_unittest.py:
590         * Scripts/webkitpy/common/net/failuremap_unittest.py:
591         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
592         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
593         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
594         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
595         * Scripts/webkitpy/common/net/statusserver_unittest.py:
596         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
597         * Scripts/webkitpy/common/newstringio_unittest.py:
598         * Scripts/webkitpy/common/prettypatch_unittest.py:
599         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
600         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
601         * Scripts/webkitpy/common/system/environment_unittest.py:
602         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
603         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
604         * Scripts/webkitpy/common/system/executive_unittest.py:
605         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
606         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
607         * Scripts/webkitpy/common/system/filesystem_unittest.py:
608         * Scripts/webkitpy/common/system/logtesting.py:
609         * Scripts/webkitpy/common/system/logutils_unittest.py:
610         * Scripts/webkitpy/common/system/outputcapture.py:
611         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
612         * Scripts/webkitpy/common/system/outputtee_unittest.py:
613         * Scripts/webkitpy/common/system/path_unittest.py:
614         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
615         * Scripts/webkitpy/common/system/profiler_unittest.py:
616         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
617         * Scripts/webkitpy/common/system/user_unittest.py:
618         * Scripts/webkitpy/common/system/workspace_unittest.py:
619         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
620         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
621         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
622         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
623         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
624         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
625         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
626         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
627         * Scripts/webkitpy/common/webkitunittest.py:
628         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
629         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
630         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
631         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
632         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
633         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
634         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
635         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
636         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
637         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
638         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
639         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
640         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
641         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
642         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
643         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
644         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
645         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
646         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
647         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
648         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
649         * Scripts/webkitpy/port/base_unittest.py:
650         * Scripts/webkitpy/port/builders_unittest.py:
651         * Scripts/webkitpy/port/config_unittest.py:
652         * Scripts/webkitpy/port/driver_unittest.py:
653         * Scripts/webkitpy/port/efl_unittest.py:
654         * Scripts/webkitpy/port/factory_unittest.py:
655         * Scripts/webkitpy/port/gtk_unittest.py:
656         * Scripts/webkitpy/port/http_lock_unittest.py:
657         * Scripts/webkitpy/port/image_diff_unittest.py:
658         * Scripts/webkitpy/port/leakdetector_unittest.py:
659         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
660         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
661         * Scripts/webkitpy/port/mock_drt_unittest.py:
662         * Scripts/webkitpy/port/port_testcase.py:
663         * Scripts/webkitpy/port/server_process_unittest.py:
664         * Scripts/webkitpy/port/westondriver_unittest.py:
665         * Scripts/webkitpy/port/win_unittest.py:
666         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
667         * Scripts/webkitpy/style/checker_unittest.py:
668         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
669         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
670         * Scripts/webkitpy/style/checkers/common_unittest.py:
671         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
672         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
673         * Scripts/webkitpy/style/checkers/js_unittest.py:
674         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
675         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
676         * Scripts/webkitpy/style/checkers/png_unittest.py:
677         * Scripts/webkitpy/style/checkers/python_unittest.py:
678         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
679         * Scripts/webkitpy/style/checkers/text_unittest.py:
680         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
681         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
682         * Scripts/webkitpy/style/checkers/xml_unittest.py:
683         * Scripts/webkitpy/style/error_handlers_unittest.py:
684         * Scripts/webkitpy/style/filereader_unittest.py:
685         * Scripts/webkitpy/style/filter_unittest.py:
686         * Scripts/webkitpy/style/main_unittest.py:
687         * Scripts/webkitpy/style/optparser_unittest.py:
688         * Scripts/webkitpy/style/patchreader_unittest.py:
689         * Scripts/webkitpy/test/finder_unittest.py:
690         * Scripts/webkitpy/test/main.py: Ordered imports.
691         * Scripts/webkitpy/test/main_unittest.py:
692         * Scripts/webkitpy/test/printer.py: Ordered imports.
693         (Printer.configure):
694         * Scripts/webkitpy/test/runner_unittest.py:
695         * Scripts/webkitpy/test/skip_unittest.py:
696         * Scripts/webkitpy/thirdparty/__init__.py:
697         (AutoinstallImportHook._install_irc):
698         (AutoinstallImportHook._install_unittest2): Deleted.
699         * Scripts/webkitpy/thirdparty/__init___unittest.py:
700         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
701         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
702         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
703         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
704         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
705         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
706         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
707         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
708         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
709         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
710         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
711         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
712         * Scripts/webkitpy/tool/commands/download_unittest.py:
713         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
714         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
715         * Scripts/webkitpy/tool/commands/queries_unittest.py:
716         * Scripts/webkitpy/tool/commands/queuestest.py:
717         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
718         * Scripts/webkitpy/tool/grammar_unittest.py:
719         * Scripts/webkitpy/tool/mocktool_unittest.py:
720         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
721         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
722         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
723         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
724         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
725         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
726         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
727         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
728         * Scripts/webkitpy/tool/steps/commit_unittest.py:
729         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
730         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
731         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
732         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
733         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
734         * Scripts/webkitpy/tool/steps/steps_unittest.py:
735         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
736         * Scripts/webkitpy/tool/steps/update_unittest.py:
737         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
738         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
739         * Scripts/webkitpy/w3c/test_converter_unittest.py:
740         * Scripts/webkitpy/w3c/test_importer_unittest.py:
741         * Scripts/webkitpy/w3c/test_parser_unittest.py:
742
743 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
744
745         LayoutTestResults and ExpectedFailures should know about the
746         interrupted flag from the json results file
747         https://bugs.webkit.org/show_bug.cgi?id=137229
748
749         Reviewed by Daniel Bates.
750
751         Changes LayoutTestResults to use the interrupted flag instead of
752         counting failures.
753
754         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
755         (BuilderTest._install_fetch_build._mock_fetch_build):
756         (BuilderTest.test_latest_layout_test_results):
757         * Scripts/webkitpy/common/net/layouttestresults.py:
758         Removes notion of failure_limit_count, and adds
759         did_exceed_test_failure_limit.
760
761         (LayoutTestResults.results_from_string):
762         (LayoutTestResults.__init__):
763         (LayoutTestResults.did_exceed_test_failure_limit):
764         (LayoutTestResults): Deleted.
765         (LayoutTestResults.set_failure_limit_count): Deleted.
766         (LayoutTestResults.failure_limit_count): Deleted.
767         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
768         Removes unit test for failure_limit_count logic.
769
770         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
771         * Scripts/webkitpy/common/net/resultsjsonparser.py:
772         Instead of providing a class method that returns a list of
773         TestResults objects, resultsjsonparser now provides a class
774         ParsedJSONResults that serves as an interface between the results.json
775         file and the rest of webkitpy.
776
777         (ParsedJSONResults):
778         (ParsedJSONResults.__init__):
779         (ParsedJSONResults.did_exceed_test_failure_limit):
780         (ParsedJSONResults.test_results):
781         (ResultsJSONParser): Deleted.
782         (ResultsJSONParser.parse_results_json): Deleted.
783         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
784         Updates the unit test so that it can test the new ResultsJSONParser
785         class.
786
787         (ParsedJSONResultsTest):
788         (test_basic):
789         (ResultsJSONParserTest): Deleted.
790         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
791         Updates the unit test to instantiate ResultsJSONParser objects rather
792         than simple lists of TestResult objects.
793
794         (MockCommitQueue.test_results):
795         (FailingTestCommitQueue.test_results):
796         (test_flaky_test_failure):
797         (test_failed_archive):
798         * Scripts/webkitpy/tool/bot/expectedfailures.py:
799         Updates ExpectedFailures to use the did_exceed_test_failure_limit
800         method rather than counting the number of failed tests.
801
802         (ExpectedFailures._should_trust):
803         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
804         Updates MockResults to more closely resemble the updated
805         LayoutTestResults class.
806
807         (MockResults.__init__):
808         (MockResults.did_exceed_test_failure_limit):
809         (ExpectedFailuresTest.test_can_trust_results):
810         (ExpectedFailuresTest.test_unexpected_failures_observed):
811         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
812         (MockResults.failure_limit_count): Deleted.
813         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
814         Removes a FIXME regarding the use of the
815         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
816
817         (LayoutTestResultsReader.results):
818         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
819         Updates test to not check the now-nonexistant failure_count_limit
820         method.
821
822         (test_missing_unit_test_results_path):
823         (test_layout_test_results):
824         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
825         Accounts for name change: ResultsJSONParserTest ->
826         ParsedJSONParserTest.
827
828         (RebaselineTestTest.test_gather_baselines):
829
830 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
831
832         [EFL] Rename TEST_THEME_DIR macro
833         https://bugs.webkit.org/show_bug.cgi?id=137244
834
835         Reviewed by Csaba Osztrogonác.
836
837         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
838         DEFAULT_THEME_DIR is better than it.
839
840         * MiniBrowser/efl/main.c:
841         (window_create):
842         * TestWebKitAPI/efl/PlatformWebView.cpp:
843         (TestWebKitAPI::PlatformWebView::PlatformWebView):
844         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
845         (WTR::PlatformWebView::PlatformWebView):
846
847 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
848
849         Windows EWS went purple when it failed to build
850         https://bugs.webkit.org/show_bug.cgi?id=137267
851
852         Reviewed by Ryosuke Niwa.
853
854         * QueueStatusServer/app.yaml: Update the version.
855
856         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
857         Make it work for style and win-ews queues.
858
859 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
860
861         It should be fun and easy to run every possible JavaScript benchmark from the command line
862         https://bugs.webkit.org/show_bug.cgi?id=137245
863
864         Reviewed by Oliver Hunt.
865         
866         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
867         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
868         having their own private scripts for doing benchmark runs, and didn't share them in the open
869         source community, because of fears about the shady licensing of the benchmarks suites that
870         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
871         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
872         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
873         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
874         but some of them are. The non-public tests are exclusively those that were not made by any
875         WebKit contributor, but which JSC/WebKit devs found useful for testing.
876
877         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
878         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
879         checked into WebKit svn at all) can be run by passing the path to them via a configuration
880         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
881         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
882         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
883         probably never be checked in because there is no license text anywhere in that benchmark.
884         A valid ~/.run-jsc-benchmarks file will just be something like:
885         
886             {
887                 "OctanePath": "/path/to/Octane2",
888                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
889             }
890         
891         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
892         run-jsc-benchmarks will just gracefully avoid running that test suite.
893         
894         Finally, a word about policy: it is understood that different organizations that do
895         development on JSC may find themselves having internal benchmarks that they cannot share
896         because of weird licensing. It happens - usually because the organization doing JSC
897         development found some test in the wild that is owned by someone else and therefore cannot
898         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
899         that add support for some new kind of benchmark suite even if the suite is not made public
900         as part of the same patch - so long as the patch isn't too invasive. An example of
901         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
902         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
903         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
904         completely open-sourced and committed to the WebKit repo - but the reality is that this
905         can't always be done safely.
906
907         * Scripts/bencher: Removed.
908         * Scripts/run-jsc-benchmarks: Added.
909
910 2014-09-30  Roger Fong  <roger_fong@apple.com>
911
912         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
913
914         * Scripts/webkitpy/port/drdiver.py:
915         (Driver.stop):
916         * Scripts/webkitpy/port/server_process.py:
917         (ServerProcess.stop):
918
919 2014-09-30  Roger Fong  <roger_fong@apple.com>
920
921         [Windows] Back to 2 child processes for NRWT on Windows.
922
923         * Scripts/webkitpy/port/win.py:
924         (WinPort.default_child_processes):
925         Changing the number of processes to 1 did not have an effect on the layout test results. 
926         It does introduce an issue with one of the workers hanging indefinitely and causing the 
927         layout tests to timeout as a whole occasionally, but we should just fix that.
928
929 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
930
931         Remove an accidentally committed line..
932
933         * QueueStatusServer/handlers/statusbubble.py:
934         (StatusBubble._build_bubble):
935
936 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
937
938         build.webkit.org/dashboard: Switch EWS view to using actual retry count
939         https://bugs.webkit.org/show_bug.cgi?id=137240
940
941         Reviewed by Ryosuke Niwa.
942
943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
944         (EWSQueue.prototype.loadDetailedStatus):
945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
946         (EWSQueueView.prototype._popoverContentForEWSQueue):
947         Use the new retry_count data member from JSON.
948
949         * QueueStatusServer/app.yaml: Updating the version.
950
951         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
952         Instead of message_count, produce retry_count.
953
954 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
955
956         EWS doesn't need to show all the bubbles when a patch fails to apply
957         https://bugs.webkit.org/show_bug.cgi?id=137256
958
959         Reviewed by Ryosuke Niwa.
960
961         * QueueStatusServer/app.yaml: Updated app version.
962
963         * QueueStatusServer/handlers/statusbubble.py:
964         (StatusBubble._build_bubble):
965         (StatusBubble._build_bubbles_for_attachment):
966         (StatusBubble.get):
967         * QueueStatusServer/templates/statusbubble.html:
968         When some queues fail to apply, and no queues had meaningful output (meaning that
969         they will almost certainly fail to apply later), we can show a single bubble
970         telling the user just that.
971
972 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
973
974         [EFL] Bump EFL version to 1.11.2
975         https://bugs.webkit.org/show_bug.cgi?id=137118
976
977         Reviewed by Gyuyoung Kim.
978
979         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
980         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
981
982         * efl/jhbuild.modules:
983         * efl/patches/ecore.patch: Removed.
984
985 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
986
987         REGRESSION(r173929): [GTK] TestInspector fails after r173929
988         https://bugs.webkit.org/show_bug.cgi?id=137247
989
990         Reviewed by Philippe Normand.
991
992         Wait until can-attach property changes before trying to attach the
993         inspector after resizing the view.
994
995         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
996         (testInspectorDefault):
997
998 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
999
1000         Require Python 2.7 version
1001         https://bugs.webkit.org/show_bug.cgi?id=137112
1002
1003         Reviewed by Csaba Osztrogonác.
1004
1005         * Scripts/ensure-valid-python:
1006         (checkPythonVersion):
1007         * Scripts/webkitpy/common/version_check.py:
1008
1009 2014-09-30  Martin Hock  <mhock@apple.com>
1010
1011         Skip a JSC test after r174036.
1012         https://bugs.webkit.org/show_bug.cgi?id=137236
1013
1014         Reviewed by Csaba Osztrogonác.
1015
1016         * Scripts/run-javascriptcore-tests:
1017
1018 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1019
1020         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
1021         https://bugs.webkit.org/show_bug.cgi?id=137212
1022
1023         This moves TestNetscapePlugin to a new folder (lib/plugins).
1024         We should not use the same directory for TestNetscapePlugin and
1025         the other libraries, because we end up scanning all the .so in the
1026         lib dir for every test.
1027
1028         Reviewed by Carlos Garcia Campos.
1029
1030         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
1031         * Scripts/webkitpy/port/efl.py:
1032         (EflPort.setup_environ_for_server): Update plugin path.
1033         * Scripts/webkitpy/port/gtk.py:
1034         (GtkPort.setup_environ_for_server): Update plugin path.
1035         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
1036
1037 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1038
1039         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
1040
1041         Rubber-stamped by Tim Horton.
1042
1043         * QueueStatusServer/app.yaml:
1044         * QueueStatusServer/handlers/statusbubble.py:
1045         (StatusBubble._build_bubble):
1046
1047 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1048
1049         Typo fix, suggested by Tim Horton.
1050
1051         * QueueStatusServer/handlers/statusbubble.py:
1052         (StatusBubble._build_message_for_provisional_failure):
1053
1054 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1055
1056         Improve Bugzilla status bubbles
1057         https://bugs.webkit.org/show_bug.cgi?id=137232
1058
1059         Reviewed by Ryosuke Niwa.
1060
1061         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
1062
1063         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
1064         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
1065         that are stuck, as it was only confusing that they disappeared after 99.
1066
1067         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
1068         by old bubbles. We need a lot more information to determine color, so the implementation
1069         can not be here.
1070
1071         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
1072         always have a link for consistency. Added code to convert timestamps in tooltips
1073         to local time zone.
1074
1075 2014-09-29  Commit Queue  <commit-queue@webkit.org>
1076
1077         Unreviewed, rolling out r174045.
1078         https://bugs.webkit.org/show_bug.cgi?id=137231
1079
1080         Introduced a crash during page loading tests on Mac (Requested
1081         by rniwa on #webkit).
1082
1083         Reverted changeset:
1084
1085         "Replace OSObjectPtr with RetainPtr/adoptOS"
1086         https://bugs.webkit.org/show_bug.cgi?id=137158
1087         http://trac.webkit.org/changeset/174045
1088
1089 2014-09-29  Tim Horton  <timothy_horton@apple.com>
1090
1091         Add Jake as a contributor.
1092
1093         * Scripts/webkitpy/common/config/contributors.json:
1094
1095 2014-09-29  Roger Fong  <roger_fong@apple.com>
1096
1097         [Windows] Skip a javascriptcore test following r174036.
1098
1099         * Scripts/run-javascriptcore-tests:
1100
1101 2014-09-29  Roger Fong  <roger_fong@apple.com>
1102
1103         [Windows] Reduce number of processes used by NRWT on Windows to 1.
1104
1105         * Scripts/webkitpy/port/win.py:
1106         (WinPort.default_child_processes):
1107         Reduce number of processes to 1 so we can get a good baseline for what failures
1108         we should be expecting to see from the Windows bots.
1109
1110 2014-09-29  Darin Adler  <darin@apple.com>
1111
1112         Tweak and tighten SVG font converter
1113         https://bugs.webkit.org/show_bug.cgi?id=136956
1114
1115         Reviewed by Myles Maxfield.
1116
1117         I was investigating behavior of String::toInt, String::toDouble, and
1118         String::toFloat for various failure cases, and decided to start some
1119         unit tests for those functions here.
1120
1121         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1122         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
1123         StringToDouble testing.
1124
1125 2014-09-29  Philippe Normand  <pnormand@igalia.com>
1126
1127         [GTK][CMake] TestWebCore target build sometimes fail
1128         https://bugs.webkit.org/show_bug.cgi?id=137207
1129
1130         Reviewed by Csaba Osztrogon.
1131
1132         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
1133         headers are generated before the TestWebCore target is built.
1134
1135 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1136
1137         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
1138         https://bugs.webkit.org/show_bug.cgi?id=137209
1139
1140         Reviewed by Philippe Normand.
1141
1142         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
1143         from the WebCore test sources.
1144
1145 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1146
1147         Allow webkit-patch upload to respect the --directory argument with git checkouts
1148         https://bugs.webkit.org/show_bug.cgi?id=137166
1149
1150         Reviewed by Darin Adler.
1151
1152         We simply hadn't plumbed it through.
1153
1154         * Scripts/webkitpy/common/checkout/scm/detection.py:
1155         (SCMDetector.detect_scm_system):
1156         * Scripts/webkitpy/common/checkout/scm/git.py:
1157         (Git.__init__):
1158         (Git.changed_files):
1159
1160 2014-09-26  Sam Weinig  <sam@webkit.org>
1161
1162         Replace OSObjectPtr with RetainPtr/adoptOS
1163         https://bugs.webkit.org/show_bug.cgi?id=137158
1164
1165         Reviewed by Dan Bernstein.
1166
1167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1168         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
1169         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
1170         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
1171
1172 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
1173
1174         Disable function.arguments
1175         https://bugs.webkit.org/show_bug.cgi?id=137167
1176
1177         Rubber stamped by Geoffrey Garen
1178         
1179         Enable the feature by default during tests.
1180
1181         * Scripts/run-jsc-stress-tests:
1182
1183 2014-09-26  Beth Dakin  <bdakin@apple.com>
1184
1185         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
1186         https://bugs.webkit.org/show_bug.cgi?id=137089
1187
1188         Reviewed by Tim Horton.
1189
1190         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
1191         tests run at 1x, but that code does not seem to execute at the right time for 
1192         these tests, so if we just ensure we start out at 1x, that appears to fix these 
1193         tests and does not break the HiDPI tests either.
1194         * WebKitTestRunner/TestController.cpp:
1195         (WTR::TestController::createWebViewWithOptions):
1196
1197 2014-09-26  Roger Fong  <roger_fong@apple.com>
1198
1199         [Windows] Decrease default number of child processes used by Windows.
1200
1201         * Scripts/webkitpy/port/win.py:
1202         (WinPort.default_child_processes):
1203         Having too many seems to cause many tests to crash or timeout. 
1204         We may even need to make it have only 1 child process if we’re still seeing problems after this.
1205
1206 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1207
1208         Mac EWS bots do not keep logs as promised
1209         https://bugs.webkit.org/show_bug.cgi?id=137151
1210
1211         Reviewed by Ryosuke Niwa.
1212
1213         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
1214
1215 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1216
1217         Get rid of webkit-queues dashboard
1218         https://bugs.webkit.org/show_bug.cgi?id=137141
1219
1220         Reviewed by Ryosuke Niwa.
1221
1222         * QueueStatusServer/app.yaml: Updated version.
1223
1224         * QueueStatusServer/templates/dashboard.html: Removed.
1225         * QueueStatusServer/handlers/dashboard.py: Removed.
1226         * QueueStatusServer/main.py:
1227         Kill it!
1228
1229         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
1230         (.status-cell): Deleted.
1231         (.status-cell:hover): Deleted.
1232         (.status-cell.pass): Deleted.
1233         (.status-cell.fail): Deleted.
1234         (.status-cell.pending): Deleted.
1235         (.status-cell.error): Deleted.
1236         * QueueStatusServer/stylesheets/dashboard.css: Removed.
1237         * QueueStatusServer/templates/activebots.html:
1238         * QueueStatusServer/templates/patch.html:
1239         * QueueStatusServer/templates/queuestatus.html:
1240         * QueueStatusServer/templates/recentstatus.html:
1241         Renamed dashboard.css to common.css, and removed dashboard-only rules.
1242
1243 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1244
1245         Get rid of Retry status in webkit-queues
1246         https://bugs.webkit.org/show_bug.cgi?id=137135
1247
1248         Reviewed by Ryosuke Niwa.
1249
1250         * QueueStatusServer/config/messages.py: Removed Retry.
1251
1252         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
1253         no longer needs to check the latest status. It just always both unlocks the patch
1254         and removes it from WorkItems.
1255
1256         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
1257         I don't understand why we even needed to check for retries here, but now that there
1258         are no retries, that code can go to /dev/null.
1259
1260         * QueueStatusServer/loggers/recordpatchevent.py:
1261         (RecordPatchEvent.started):
1262         (RecordPatchEvent.retrying): Deleted.
1263         Fixed retry counting, it should work for all queues now.
1264
1265         * QueueStatusServer/model/queuestatus.py:
1266         (QueueStatus.is_retry_request): Deleted. These are no more.
1267
1268         * Scripts/webkitpy/common/net/statusserver_mock.py:
1269         (MockStatusServer.release_lock):
1270         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1271         Did whatever it took to keep passing the tests. The particular test doesn't seem
1272         quite right, but whatever.
1273
1274         * Scripts/webkitpy/tool/commands/queues.py:
1275         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
1276         and let others pick up. Also, added explicit returns for clarity.
1277         (AbstractPatchQueue._did_retry): Deleted.
1278
1279 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1280
1281         [EFL] Fix the gst-libav build on ARM Thumb2
1282         https://bugs.webkit.org/show_bug.cgi?id=137022
1283
1284         Reviewed by Zoltan Herczeg.
1285
1286         * efl/jhbuild.modules:
1287         * efl/patches/gst-libav.patch: Added.
1288
1289 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1290
1291         [EFL] Bump up dependencies not to conflict with the GTK port.
1292         https://bugs.webkit.org/show_bug.cgi?id=137143
1293
1294         Reviewed by Gyuyoung Kim.
1295
1296         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
1297         installing and removing different versions of libgnutls-dev, thus
1298         hindering the development for both ports on the same machine. GTK is
1299         using the newer version of the package, now bumping up EFL to use the 
1300         same.
1301
1302         * efl/install-dependencies:
1303
1304 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
1305
1306         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
1307         https://bugs.webkit.org/show_bug.cgi?id=136854
1308
1309         Reviewed by Gyuyoung Kim.
1310
1311         'Escape' key should exit fullscreen first and then should be used to stop page load.
1312
1313         * MiniBrowser/efl/main.c:
1314         (on_key_down):
1315
1316 2014-09-25  Dean Jackson  <dino@apple.com>
1317
1318         Add Said to the contributors list so his name completes in bugzilla.
1319
1320         * Scripts/webkitpy/common/config/contributors.json:
1321
1322 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
1323
1324         EWS only repeats its cycle every two hours
1325         https://bugs.webkit.org/show_bug.cgi?id=137129
1326
1327         Reviewed by Ryosuke Niwa.
1328
1329         * QueueStatusServer/app.yaml: Updated version.
1330
1331         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
1332
1333         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
1334         the patch from work items.
1335
1336         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
1337
1338         * QueueStatusServer/main.py: Added release-lock.
1339
1340         * QueueStatusServer/model/activeworkitems.py:
1341         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
1342
1343         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
1344         we don't want it to be immediately picked up again, it's better to give other patches
1345         a chance.
1346
1347         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
1348         these interactive versions, but OK.
1349
1350         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
1351         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
1352         or svn is down).
1353
1354         * Scripts/webkitpy/tool/commands/queues.py:
1355         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
1356         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
1357         meaning that these handlers could never do the right thing. We'd either get a duplicate
1358         _did_fail, or try to unlock an already unlocked patch.
1359         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
1360         making it eligible for retry immediately.
1361
1362         * Scripts/webkitpy/common/net/statusserver.py:
1363         (StatusServer._post_release_lock):
1364         (StatusServer.release_lock):
1365         Added a call to release-lock.
1366
1367 2014-09-25  Roger Fong  <roger_fong@apple.com>
1368
1369         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
1370
1371         * Scripts/webkitpy/common/system/path.py:
1372         (_CygPath.convert):
1373
1374 2014-09-25  Roger Fong  <roger_fong@apple.com>
1375
1376         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
1377
1378         * Scripts/webkitpy/common/system/path.py:
1379         (_CygPath.convert):
1380
1381 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1382
1383         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
1384         https://bugs.webkit.org/show_bug.cgi?id=136377
1385
1386         Reviewed by Philippe Normand.
1387
1388         * Scripts/webkitdirs.pm:
1389         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
1390
1391 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
1392
1393         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
1394         https://bugs.webkit.org/show_bug.cgi?id=137117
1395
1396         Tools/efl/install-dependencies relies on apt-get to install packages.
1397         Unfortunately, if a package does not exist (e.g., for a given
1398         architecture) then apt-get install is not able to ignore the missing
1399         package and install the rest but fails to run entirely (and there
1400         seems to be no intent to change this behaviour).
1401
1402         On ARM64, the luajit package is missing and currently it needs manual
1403         editing of install-dependencies to get the script install as much as it
1404         can.
1405
1406         This patch separates the installation of the universally available
1407         packages from those which might not be available for all architectures.
1408
1409         Reviewed by Gyuyoung Kim.
1410
1411         * efl/install-dependencies:
1412
1413 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
1414
1415         Remove WinCE port from trunk
1416         https://bugs.webkit.org/show_bug.cgi?id=136951
1417
1418         Reviewed by Alex Christensen.
1419
1420         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1421         (_should_file_trigger_build):
1422         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1423         (ShouldBuildTest):
1424         * CMakeLists.txt:
1425         * DumpRenderTree/win/DRTDataObject.cpp:
1426         (DRTDataObject::CopyMedium):
1427         * Scripts/build-webkit:
1428         * Scripts/webkit-build-directory:
1429         * Scripts/webkitdirs.pm:
1430         (argumentsForConfiguration):
1431         (builtDylibPathForName):
1432         (isAppleWinWebKit):
1433         (launcherPath):
1434         (launcherName):
1435         (shouldRemoveCMakeCache):
1436         (cmakeBasedPortArguments):
1437         (cmakeBasedPortName):
1438         (isCMakeBuild):
1439         (isWinCE): Deleted.
1440         (determineIsWinCE): Deleted.
1441         * Scripts/webkitperl/FeatureList.pm:
1442         * Scripts/webkitpy/port/port_testcase.py:
1443         (test_apache_config_file_name_for_platform):
1444         * TestWebKitAPI/config.h:
1445         * WinCELauncher/CMakeLists.txt: Removed.
1446         * WinCELauncher/main.cpp: Removed.
1447         * gtk/manifest.txt:
1448
1449 2014-09-23  David Farler  <dfarler@apple.com>
1450
1451         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
1452         https://bugs.webkit.org/show_bug.cgi?id=136895
1453
1454         Reviewed by David Kilzer.
1455
1456         Create Device, DeviceType, and Runtime data classes.
1457         Create Simulator class represent simctl output.
1458
1459         Wherever possible, use structured data classes anywhere a raw
1460         identifier or UDID string was used for a cleaner implementation
1461         and to encapsulate the inherent fragility of scraping simctl output.
1462
1463         Create a suitably named testing device if one doesn't exist.
1464
1465         Finally, accurately handle having multiple simulator runtimes (SDKs)
1466         installed in the active Xcode.app bundle.
1467
1468         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1469         (_set_up_derived_options):
1470         * Scripts/webkitpy/port/driver.py:
1471         (IOSSimulatorDriver.cmd_line):
1472         Construct DeviceType and Runtime objects from identifiers passed at the
1473         command line, still providing sensible defaults for 32- and 64-bit testing.
1474         * Scripts/webkitpy/port/ios.py:
1475         (IOSSimulatorPort.__init__):
1476         (IOSSimulatorPort.setup_test_run):
1477         (IOSSimulatorPort):
1478         (IOSSimulatorPort.testing_device):
1479         Cache the testing device once it is created or found.
1480         (IOSSimulatorPort.reset_preferences):
1481         Get the device path from the Device object instead of consructing it
1482         in the port class.
1483         (IOSSimulatorPort.simulator_udid): Deleted.
1484         Get the UDID from the testing_device :: Device object itself.
1485         * Scripts/webkitpy/xcode/simulator.py:
1486         Created Device, DeviceType, Runtime, and Simulator classes.
1487         (get_runtimes): Deleted.
1488         (get_devices): Deleted.
1489         (get_device_types): Deleted.
1490         (get_latest_runtime): Deleted.
1491
1492 2014-09-24  Roger Fong  <roger_fong@apple.com>
1493
1494         [Windows] Tentative fix for Windows test bots.
1495
1496         * Scripts/webkitpy/common/system/path.py:
1497         (_CygPath.convert):
1498
1499 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
1500
1501         Change more build.webkit.org links to https
1502         https://bugs.webkit.org/show_bug.cgi?id=137049
1503
1504         Reviewed by Csaba Osztrogonác.
1505
1506         Fix appspot, svn.webkit.org and Trac links.
1507
1508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1509         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1512         (ViewController.prototype._domForBuildName):
1513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1517         (.):
1518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1519         (EWS):
1520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1522         (TestHistory):
1523         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1524
1525 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
1526
1527         Update the list of u-szeged contributors.
1528
1529         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
1530
1531         * Scripts/webkitpy/common/config/contributors.json:
1532
1533 2014-09-23  Roger Fong  <roger_fong@apple.com>
1534
1535         [Windows] More debugging for the Windows bots.
1536
1537         * Scripts/webkitpy/common/system/path.py:
1538         (_CygPath):
1539
1540 2014-09-23  Roger Fong  <roger_fong@apple.com>
1541
1542         Unreviewed. Fix for r173899, those tabs should be spaces.
1543
1544         * Scripts/webkitpy/port/driver.py:
1545         (Driver._command_from_driver_input):
1546         (Driver): Deleted.
1547
1548 2014-09-23  Roger Fong  <roger_fong@apple.com>
1549
1550         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
1551
1552         * Scripts/webkitpy/port/driver.py:
1553         (Driver):
1554
1555 2014-09-23  Jer Noble  <jer.noble@apple.com>
1556
1557         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
1558         https://bugs.webkit.org/show_bug.cgi?id=137031
1559
1560         Reviewed by Joseph Pecoraro.
1561
1562         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
1563         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
1564         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
1565         ChangeLog locations before passing them to createCommitMessage().
1566
1567         * Scripts/commit-log-editor:
1568
1569 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1570
1571         W3C test importer should detect manual and reference tests according their filenames
1572         https://bugs.webkit.org/show_bug.cgi?id=133852
1573
1574         Reviewed by Bem Jones-Bey.
1575
1576         * Scripts/webkitpy/w3c/test_parser.py:
1577         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1578         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1579         (TestParser):
1580         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1581         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1582         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1583         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1584
1585 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1586
1587         Unreviewed, add Rebecca Hauck as a contributor.
1588
1589         * Scripts/webkitpy/common/config/contributors.json:
1590
1591 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1592
1593         Switch build.webkit.org URLs to https
1594
1595         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1596
1597         * TestResultServer/app.yaml: Update version to this commit
1598         revision.
1599
1600         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1601         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1604         (WebKitBuildbot):
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1608         (.):
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1610         (WebKitBuildbot):
1611         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1612         * Scripts/webkitpy/common/config/urls.py:
1613         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1614         (test_builder_with_name):
1615         * Scripts/webkitpy/tool/commands/queries.py:
1616         (TreeStatus):
1617         * TestResultServer/generate_builders_json.py:
1618         (main):
1619         * TestResultServer/generate_builders_json_unittest.py:
1620         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1621         (GenerateBuildersJsonTest):
1622         (GenerateBuildersJsonTest.test_generate_json_data):
1623         * TestResultServer/static-dashboards/builders.jsonp:
1624         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1625         (loadExpectationsLayoutTests):
1626         * TestResultServer/static-dashboards/timeline_explorer.js:
1627
1628 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1629
1630         W3C test importer should copy .htaccess files
1631         https://bugs.webkit.org/show_bug.cgi?id=136850
1632
1633         Reviewed by Bem Jones-Bey.
1634
1635         * Scripts/webkitpy/w3c/test_importer.py:
1636         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
1637         (TestImporter):
1638         (TestImporter.find_importable_tests): Making use of new helper function.
1639
1640 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
1641
1642         Trying to revive bot watcher's dashboard after HSTS.
1643
1644         Unreviewed.
1645
1646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1647         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
1648
1649 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1650
1651         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
1652         https://bugs.webkit.org/show_bug.cgi?id=137026
1653
1654         Reviewed by Csaba Osztrogonác.
1655
1656         * BuildSlaveSupport/wait-for-SVN-server.py:
1657         (getLatestSVNRevision):
1658         (waitForSVNRevision):
1659
1660 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1661
1662         Remove unlinkZeroFiles from build-webkit
1663         https://bugs.webkit.org/show_bug.cgi?id=137018
1664
1665         Reviewed by Csaba Osztrogonác.
1666
1667         * Scripts/build-webkit:
1668         (unlinkZeroFiles): Deleted.
1669
1670 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
1671
1672         [GTK] Minibrowser : Add keyboard support for stop page load
1673         https://bugs.webkit.org/show_bug.cgi?id=136857
1674
1675         Reviewed by Philippe Normand.
1676
1677         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
1678
1679         * MiniBrowser/gtk/BrowserWindow.c:
1680         (stopPageLoad): Callback to stop page load.
1681         (browser_window_init):
1682
1683 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
1684
1685         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
1686         https://bugs.webkit.org/show_bug.cgi?id=136813
1687
1688         Reviewed by Gyuyoung Kim.
1689
1690         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
1691
1692         * MiniBrowser/efl/main.c:
1693         (on_key_down):
1694
1695 2014-09-22  Daniel Bates  <dabates@apple.com>
1696
1697         [Cocoa] Add UI delegate callback when window.close() is called
1698         https://bugs.webkit.org/show_bug.cgi?id=137008
1699         <rdar://problem/17801001>
1700
1701         Reviewed by Anders Carlsson.
1702
1703         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
1704         for window opened via JavaScript (i.e. window.open()).
1705
1706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1707         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
1708         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
1709
1710 2014-09-22  Youenn Fablet  <youennf@gmail.com>
1711
1712         W3C importer should import html files within resources folders
1713         https://bugs.webkit.org/show_bug.cgi?id=127548
1714
1715         Reviewed by Ryosuke Niwa.
1716         
1717         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
1718
1719         * Scripts/webkitpy/w3c/test_importer.py:
1720         (TestImporter.find_importable_tests):
1721
1722 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1723
1724         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
1725         https://bugs.webkit.org/show_bug.cgi?id=136998
1726
1727         Reviewed by Philippe Normand.
1728
1729         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1730         (testWebViewCanShowMIMEType): Remove the check of PDF as
1731         unsupported MIME type.
1732
1733 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1734
1735         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
1736
1737         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
1738         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
1739
1740         * Scripts/webkitpy/common/config/watchlist: Use
1741         Source/WebCore/platform/gtk/po/ as directory to watch for
1742         WebKitGTKTranslations rule and add berto and myself to the list of
1743         watchers.
1744
1745 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
1746
1747         Fix syntaxError in watchlist since r173594
1748         https://bugs.webkit.org/show_bug.cgi?id=136996
1749
1750         Reviewed by Philippe Normand.
1751
1752         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1753
1754 2014-09-20  Sam Weinig  <sam@webkit.org>
1755
1756         Make possible HashSet<std::unique_ptr<>>
1757         https://bugs.webkit.org/show_bug.cgi?id=136166
1758
1759         Reviewed by Darin Adler.
1760
1761         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
1762         * TestWebKitAPI/Counters.cpp: Added.
1763         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
1764         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
1765         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
1766         translation unit.
1767     
1768         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1769         Add new files.
1770
1771         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1772         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
1773
1774         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1775         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
1776
1777 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1778
1779         run-webkit-tests should count tests submitted as absolute paths once
1780         https://bugs.webkit.org/show_bug.cgi?id=136848
1781
1782         Reviewed by Darin Adler.
1783
1784         * Scripts/webkitpy/port/base.py:
1785         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
1786
1787 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1788
1789         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
1790         https://bugs.webkit.org/show_bug.cgi?id=136974
1791
1792         Reviewed by Chris Fleizach.
1793
1794         * DumpRenderTree/AccessibilityUIElement.cpp:
1795         (selectTextWithCriteriaCallback):
1796         Be sure to release the string if it was allocated.
1797
1798 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
1799
1800         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
1801         https://bugs.webkit.org/show_bug.cgi?id=136966
1802
1803         Reviewed by Daniel Bates.
1804
1805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1806         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
1807
1808 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1809
1810         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
1811         https://bugs.webkit.org/show_bug.cgi?id=136917
1812
1813         Reviewed by Darin Adler.
1814
1815         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
1816
1817         * TestWebKitAPI/PlatformEfl.cmake:
1818         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
1819         (TestWebKitAPI::didFinishLoadForFrame):
1820         (TestWebKitAPI::TEST):
1821         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
1822
1823 2014-09-19  Daniel Bates  <dabates@apple.com>
1824
1825         Always assume internal SDK when building configuration Production
1826         https://bugs.webkit.org/show_bug.cgi?id=136925
1827         <rdar://problem/18362399>
1828
1829         Reviewed by Dan Bernstein.
1830
1831         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1832         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1833         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1834         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1835
1836 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1837
1838         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
1839         https://bugs.webkit.org/show_bug.cgi?id=136847
1840
1841         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
1842
1843         Reviewed by Alexey Proskuryakov.
1844
1845         * WebKitTestRunner/TestController.cpp:
1846         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
1847
1848 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1849
1850         [GTK] Missing inspector files in the tarball
1851         https://bugs.webkit.org/show_bug.cgi?id=136952
1852
1853         Reviewed by Gustavo Noronha Silva.
1854
1855         * gtk/manifest.txt: Add
1856         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
1857         to the tarball.
1858
1859 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1860
1861         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1862         https://bugs.webkit.org/show_bug.cgi?id=136632
1863
1864         Reviewed by Gustavo Noronha Silva.
1865
1866         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
1867         the gtk icons.
1868         * gtk/manifest.txt: Only include the free icons in the tarball.
1869
1870 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1871
1872         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
1873         https://bugs.webkit.org/show_bug.cgi?id=136943
1874
1875         Reviewed by Philippe Normand.
1876
1877         Update the script to receive the list of files from the command
1878         line instead of scanning the given directories.
1879
1880         * gtk/generate-inspector-gresource-manifest.py:
1881         (get_filenames): Convert filenames to use relative paths.
1882         (find_all_files_in_directory): Deleted.
1883         (find_all_files_in_directory.select_file): Deleted.
1884
1885 2014-09-18  Tanay C  <tanay.c@samsung.com>
1886
1887         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
1888         https://bugs.webkit.org/show_bug.cgi?id=136739
1889
1890         Reviewed by Gyuyoung Kim.
1891
1892         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
1893         (on_mouse_wheel): Modified.
1894
1895 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1896
1897         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
1898         https://bugs.webkit.org/show_bug.cgi?id=136923
1899
1900         Reviewed by Gustavo Noronha Silva.
1901
1902         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1903         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
1904         the source.
1905
1906 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
1907
1908         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
1909         https://bugs.webkit.org/show_bug.cgi?id=136856
1910
1911         Reviewed by Darin Adler.
1912
1913         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1914         (RunLLINTCLoopTests.countFailures):
1915         (Run32bitJSCTests.countFailures):
1916         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1917         (RunLLINTCLoopTestsTest.test_failures):
1918         (RunLLINTCLoopTestsTest.test_failure):
1919         (RunLLINTCLoopTestsTest.test_no_failure):
1920         (Run32bitJSCTestsTest.test_failures):
1921         (Run32bitJSCTestsTest.test_failure):
1922         (Run32bitJSCTestsTest.test_no_failure):
1923
1924 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
1925
1926         GMainLoopSource is exposed to race conditions
1927         https://bugs.webkit.org/show_bug.cgi?id=135800
1928
1929         Reviewed by Carlos Garcia Campos.
1930
1931         Add unit tests for GMainLoopSource.
1932
1933         The tests check correct behavior of GMainLoopSource in various conditions --
1934         from the most simple rescheduling to rescheduling during dispatch, cancelling
1935         or destroying the GMainLoopSource during dispatch, proper destroy callback
1936         dispatching etc.
1937
1938         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
1939         State of the GMainLoopSource object (either ready, sheduled or active) is
1940         thoroughly tested throughout the lifetime of that object.
1941
1942         Still missing are tests for socket callbacks, which are a bit trickier because
1943         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
1944         are also not tested thoroughly, simply because it is at the moment impossible
1945         to test that the objects are actually destroyed when the corresponding source
1946         is finally deleted.
1947
1948         * TestWebKitAPI/PlatformGTK.cmake:
1949         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1950         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1951         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1952         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1953         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1954         (TestWebKitAPI::GMainLoopSourceTest::finish):
1955         (TestWebKitAPI::GMainLoopSourceTest::source):
1956         (TestWebKitAPI::TEST):
1957
1958 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
1959
1960         Unreviewed, Update my email in contributors.json
1961
1962         * Scripts/webkitpy/common/config/contributors.json:
1963
1964 2014-09-17  Daniel Bates  <dabates@apple.com>
1965
1966         Unreviewed, rolling out r173695.
1967
1968         Broke building third-party Legacy WebKit apps; will
1969         investigate offline
1970
1971         Reverted changeset:
1972
1973         "[iOS] Make WebCore build with public iOS SDK"
1974         https://bugs.webkit.org/show_bug.cgi?id=136487
1975         http://trac.webkit.org/changeset/173695
1976
1977 2014-09-17  Daniel Bates  <dabates@apple.com>
1978
1979         [iOS] Make WebCore build with public iOS SDK
1980         https://bugs.webkit.org/show_bug.cgi?id=136487
1981
1982         Reviewed by David Kilzer.
1983
1984         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
1985
1986         * DumpRenderTree/mac/CheckedMalloc.cpp:
1987
1988 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1989
1990         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
1991         https://bugs.webkit.org/show_bug.cgi?id=136889
1992
1993         Reviewed by Gustavo Noronha Silva.
1994
1995         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1996         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
1997         event was added to the events vector.
1998         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1999         (loadFailedCallback): Do not assume the web view URI is the
2000         failing URI when the load fails before the committed state.
2001         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
2002         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
2003         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
2004         (LoadTrackingTest::loadFailedWithTLSErrors): Add
2005         LoadFailedWithTLSErrors event to the events vector.
2006         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2007
2008 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
2009
2010         [EFL][GTK] Remove WebKit1 related codes
2011         https://bugs.webkit.org/show_bug.cgi?id=136853
2012
2013         Reviewed by Csaba Osztrogonác.
2014
2015         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
2016         from scripts.
2017
2018         * BuildSlaveSupport/build.webkit.org-config/config.json:
2019         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2020         (Compile32bitJSC):
2021         (BuildAndTestWebKit2Factory):
2022         (CompileWebKit1Only): Deleted.
2023         (CompileWebKit2Only): Deleted.
2024         (BuildAndTestWebKit1OnlyFactory): Deleted.
2025         (BuildAndTestWebKit2OnlyFactory): Deleted.
2026         * Scripts/build-webkit:
2027         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2028         * Scripts/webkitpy/common/config/ports.py:
2029         (GtkWK2Port.build_webkit_command):
2030         (EflWK2Port.build_webkit_command):
2031         * Scripts/webkitpy/common/config/ports_unittest.py:
2032         (DeprecatedPortTest.test_gtk_wk2_port):
2033         * Scripts/webkitpy/port/efl.py:
2034         (EflPort.build_webkit_command):
2035         * Scripts/webkitpy/port/gtk.py:
2036         (GtkPort._built_libraries_path):
2037         (GtkPort._search_paths):
2038         (GtkPort.test_expectations_file_position):
2039         (GtkPort.build_webkit_command):
2040         (GtkPort.run_webkit_tests_command):
2041         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
2042
2043 2014-09-16  Daniel Bates  <dabates@apple.com>
2044
2045         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2046         https://bugs.webkit.org/show_bug.cgi?id=136862
2047
2048         Reviewed by David Kilzer.
2049
2050         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2051         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2052         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
2053         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
2054
2055 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2056
2057         Mac queue slaves should reboot every so often
2058         https://bugs.webkit.org/show_bug.cgi?id=136791
2059
2060         Reviewed by Alexey Proskuryakov.
2061
2062         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
2063
2064         * EWSTools/start-queue-mac.sh:
2065
2066 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2067
2068         Unreviewed gardening, skip one more tests on Windows.
2069
2070         * Scripts/run-javascriptcore-tests:
2071
2072 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2073
2074         JSC test gardening
2075         https://bugs.webkit.org/show_bug.cgi?id=136823
2076
2077         Reviewed by Geoffrey Garen.
2078
2079         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
2080
2081 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2082
2083         Remove shouldAbortEarly cruft from master.cfg
2084         https://bugs.webkit.org/show_bug.cgi?id=136779
2085
2086         Reviewed by Csaba Osztrogonác.
2087
2088         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2089         (ConfigureBuild.start):
2090         (RunWebKitTests.start):
2091         (RunWebKit2Tests.start): Deleted.
2092
2093 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2094
2095         Remove ORWT related crufts from webkitdirs.pm
2096         https://bugs.webkit.org/show_bug.cgi?id=136821
2097
2098         Reviewed by Alexey Proskuryakov.
2099
2100         * Scripts/webkitdirs.pm:
2101         (isPerianInstalled): Deleted.
2102         (determineIPhoneSimulatorVersion): Deleted.
2103         (iPhoneSimulatorVersion): Deleted.
2104         (isSnowLeopard): Deleted.
2105         (isLion): Deleted.
2106         (quitIOSSimulator): Deleted.
2107
2108 2014-09-15  Roger Fong  <roger_fong@apple.com>
2109
2110         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
2111         https://bugs.webkit.org/show_bug.cgi?id=25160
2112
2113         * Scripts/run-javascriptcore-tests:
2114
2115 2014-09-15  Lucas Forschler  <lforschler@apple.com>
2116
2117         Add another Apple build slave to the Mountain Lion Debug WK1 queue
2118         
2119         Rubber stamped by Matt Hanson.
2120         
2121         * BuildSlaveSupport/build.webkit.org-config/config.json:
2122
2123 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2124
2125         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
2126         https://bugs.webkit.org/show_bug.cgi?id=136822
2127
2128         Reviewed by Gyuyoung Kim.
2129
2130         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
2131         initialized as we already does it in PlatformWebView::PlatformWebView
2132         calling ewk_init(). The reason for that was to ensure testing for example,
2133         WTF where creating the view is not mandatory.
2134
2135         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
2136         in order to properly initalize and release EWebKit.
2137
2138         * TestWebKitAPI/PlatformEfl.cmake:
2139         * TestWebKitAPI/efl/PlatformWebView.cpp:
2140         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2141         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2142         * TestWebKitAPI/efl/main.cpp:
2143         (main):
2144
2145 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
2146
2147         [WinCairo] Make it easier to enable/disable GStreamer.
2148         https://bugs.webkit.org/show_bug.cgi?id=135766
2149
2150         Reviewed by Brent Fulgham.
2151
2152         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
2153
2154         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
2155
2156 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
2157
2158         Web Inspector: remind about rebaselining generator test results
2159         https://bugs.webkit.org/show_bug.cgi?id=136759
2160
2161         Reviewed by Joseph Pecoraro.
2162
2163         For now, we can implement this as a watchlist message. Add watchlist
2164         groups and messages for the inspector and web replay generators.
2165
2166         * Scripts/webkitpy/common/config/watchlist:
2167
2168 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2169
2170         build.webkit.org/dashboard: Overlapping text when status is long
2171         https://bugs.webkit.org/show_bug.cgi?id=136794
2172
2173         Reviewed by Timothy Hatcher.
2174
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2176         (.status-line): Replaces height with min-height.
2177
2178 2014-09-12  Timothy Hatcher  <timothy@apple.com>
2179
2180         Make Brian Burg a WebKit reviewer.
2181
2182         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
2183
2184 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2185
2186         Multiple EWS or commit bots can pick up processing of the same patch
2187         https://bugs.webkit.org/show_bug.cgi?id=136793
2188
2189         Reviewed by Ryosuke Niwa.
2190
2191         Change timeout from one hour to two hours. This will let bots finish, and in the
2192         unlikely event of a bot being frozen, will only delay patch processing restart by
2193         one hour.
2194
2195         * QueueStatusServer/app.yaml:
2196         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
2197
2198 2014-09-11  Andy Estes  <aestes@apple.com>
2199
2200         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
2201         https://bugs.webkit.org/show_bug.cgi?id=136768
2202
2203         Reviewed by Tim Horton.
2204
2205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2206         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
2207         (TestWebKitAPI::TEST):
2208
2209 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2210
2211         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
2212         https://bugs.webkit.org/show_bug.cgi?id=136669
2213
2214         Reviewed by Antti Koivisto.
2215
2216         * Scripts/run-gtk-tests:
2217         (TestRunner): Unskip SSL test.
2218
2219 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
2220
2221         Strip extraneous AVFoundation and CoreMedia logging
2222         https://bugs.webkit.org/show_bug.cgi?id=136747
2223
2224         Reviewed by Jer Noble.
2225
2226         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2227         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
2228
2229         * Scripts/webkitpy/port/base.py:
2230         (Port.stderr_patterns_to_strip): Base class, empty list
2231
2232         * Scripts/webkitpy/port/driver.py:
2233         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
2234
2235         * Scripts/webkitpy/port/ios.py:
2236         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
2237
2238         * Scripts/webkitpy/port/mac.py:
2239         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
2240
2241
2242 2014-09-11  Michael Saboff  <msaboff@apple.com>
2243
2244         lldb_webkit.py:btjs doesn't work with release builds
2245         https://bugs.webkit.org/show_bug.cgi?id=136760
2246
2247         Reviewed by Jer Noble.
2248
2249         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
2250         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
2251         we can't get a valid result from trying either call.  In that case, we fallback to
2252         just showing the PC.  Also added check for both entry points.  If neither is found,
2253         we issue a warning and output the stack trace without JavaScript annotations.
2254
2255         * lldb/lldb_webkit.py:
2256         (btjs):
2257
2258 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
2259
2260         webkitpy test failures from import-w3c-tests
2261         https://bugs.webkit.org/show_bug.cgi?id=136752
2262
2263         Reviewed by Bem Jones-Bey.
2264
2265         This patch fixes a bug in import-w3c-tests where we were appending
2266         the wrong set of files to the copy_list. This also updates the tests
2267         to clear the failures introduced in the patch for bug 135929.
2268
2269         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2270         (W3CTestConverterTest.test_read_prefixed_property_list):
2271         * Scripts/webkitpy/w3c/test_parser.py:
2272         (TestParser.analyze_test):
2273         (TestParser.support_files):
2274         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2275
2276 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
2277
2278         Blink merge: Speculative fix for windows run-webkit-tests hangs
2279         https://bugs.webkit.org/show_bug.cgi?id=136727
2280
2281         Reviewed by Csaba Osztrogonác.
2282
2283         Merged from Blink (patch by Dirk Pranke):
2284         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
2285
2286         * Scripts/webkitpy/common/system/executive.py:
2287         (Executive.kill_process):
2288
2289 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2290
2291         Added myself as a committer.
2292
2293         Unreviewed.
2294
2295         * Scripts/webkitpy/common/config/contributors.json:
2296
2297 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
2298
2299         [JavaScriptCore] Fix FTL on platform EFL.
2300         https://bugs.webkit.org/show_bug.cgi?id=133571
2301
2302         Reviewed by Filip Pizlo.
2303
2304         * efl/install-dependencies: Revert r169181.
2305         * efl/jhbuild.modules: Clone and build a custom branch.
2306         This branch contains some fix for FTL of platform EFL.
2307         The branch is a fork of llvm r206311.
2308
2309 2014-09-10  Tanay C  <tanay.c@samsung.com>
2310
2311         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
2312         https://bugs.webkit.org/show_bug.cgi?id=136698
2313
2314         Reviewed by Gyuyoung Kim.
2315
2316         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
2317         (on_mouse_wheel): Added.
2318         (window_free):
2319         (window_create):
2320
2321 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
2322
2323         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
2324         https://bugs.webkit.org/show_bug.cgi?id=136284
2325
2326         Reviewed by Gyuyoung Kim.
2327
2328         * MiniBrowser/efl/main.c:
2329         (window_create):
2330
2331 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
2332
2333         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
2334         https://bugs.webkit.org/show_bug.cgi?id=135929
2335
2336         Reviewed by Bem Jones-Bey.
2337
2338         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
2339         were made when this script was originally written with respect to relative paths
2340         in ref files. This patch updates import-w3c-tests to update paths in ref files if
2341         they move relative to the test file.
2342
2343
2344         * Scripts/webkitpy/w3c/test_converter.py:
2345         (convert_for_webkit):
2346         (_W3CTestConverter.__init__):
2347         (_W3CTestConverter.convert_reference_relpaths):
2348         (_W3CTestConverter.convert_style_data):
2349         (_W3CTestConverter.convert_attributes_if_needed):
2350         * Scripts/webkitpy/w3c/test_importer.py:
2351         (TestImporter.find_importable_tests):
2352         (TestImporter.import_tests):
2353         * Scripts/webkitpy/w3c/test_parser.py:
2354         (TestParser.load_file):
2355         (TestParser.analyze_test):
2356         (TestParser.support_files):
2357
2358 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2359
2360         [GTK] allow overwriting destination of download
2361         https://bugs.webkit.org/show_bug.cgi?id=136372
2362
2363         Reviewed by Carlos Garcia Campos.
2364
2365         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2366         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
2367         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
2368         (createFileAtDestination): Added
2369         (testDownloadOverwriteDestinationAllowed): Added
2370         (testDownloadOverwriteDestinationDisallowed): Added
2371         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
2372         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
2373         (beforeAll): New tests
2374
2375 2014-08-05  David Farler  <dfarler@apple.com>
2376
2377         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
2378         https://bugs.webkit.org/show_bug.cgi?id=135551
2379
2380         Reviewed by Daniel Bates.
2381
2382         Prevent printing invalid Unicode strings going to stderr.
2383         Also, make filesystem.py more tolerant about receiving
2384         Unicode (encoded as UTF-8) when writing to files, in the
2385         rare case that an NSError description will make it to
2386         stderr, such as -[LTRelayController createUniqueApp].
2387
2388         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2389         (-[LTRelayController launchSimulator]): Removed.
2390         (-[LTRelayController createUniqueApp]):
2391         Don't explicitly try to uninstall the app. It is automatically handled
2392         when installing an app with the same bundle identifier.
2393         (-[LTRelayController start]):
2394         (-[LTRelayController bootDevice]): Removed.
2395         The device already boots as a part of starting the simulator. Attempting
2396         to boot a second time may cause spurious stderr output.
2397         * Scripts/webkitpy/port/driver.py:
2398         (IOSSimulatorDriver._setup_environ_for_driver):
2399         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
2400         Open the iOS Simulator once instead of the LayoutTestRelay trying
2401         to do it.
2402         * Scripts/webkitpy/port/ios.py:
2403         (IOSSimulatorPort._get_crash_log):
2404         Make sure stderr is at least an empty string.
2405         (IOSSimulatorPort):
2406         (IOSSimulatorPort.developer_dir):
2407         New property for setting up DEVELOPER_DIR in the driver environment.
2408
2409 2014-09-09  Dan Bernstein  <mitz@apple.com>
2410
2411         Clean up the MiniBrowser Xcode project
2412         https://bugs.webkit.org/show_bug.cgi?id=136684
2413
2414         Reviewed by Tim Horton.
2415
2416         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
2417         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
2418         WebKit2.framework. Upgraded project file version.
2419
2420 2014-09-09  Daniel Bates  <dbates@webkit.org>
2421
2422         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
2423         https://bugs.webkit.org/show_bug.cgi?id=136379
2424
2425         Reviewed by David Kilzer.
2426
2427         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
2428         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
2429         and sets a property on F (say, the executable bit).
2430
2431         * Scripts/svn-apply:
2432         (patch): Only add file if the diff has text chunks.
2433         * Scripts/svn-unapply:
2434         (patch): Only delete added file if the diff has text chunks.
2435
2436 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2437
2438         [GTK] Unreviewed GTK gardening.
2439
2440         * Scripts/run-gtk-tests:
2441         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
2442
2443 2014-09-09  Christophe Dumez  <cdumez@apple.com>
2444
2445         Update my email in contributors.json
2446         https://bugs.webkit.org/show_bug.cgi?id=136671
2447
2448         Reviewed by Andreas Kling.
2449
2450         * Scripts/webkitpy/common/config/contributors.json:
2451
2452 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2453
2454         [EFL] Enable fixed layout by default
2455         https://bugs.webkit.org/show_bug.cgi?id=136607
2456
2457         Reviewed by Csaba Osztrogonác.
2458
2459         Fixed layout is being used by Tizen platform by default. However, the feature
2460         has still many defects now. So, we need to enable it by default, then should fix
2461         those bugs. 
2462
2463         * MiniBrowser/efl/main.c:
2464
2465 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2466
2467         Remove FILTERS flag
2468         https://bugs.webkit.org/show_bug.cgi?id=136571
2469
2470         Reviewed by Darin Adler.
2471
2472         * Scripts/webkitperl/FeatureList.pm:
2473
2474 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
2475
2476         Dashboard metrics should ignore commits that didn't trigger builds
2477         https://bugs.webkit.org/show_bug.cgi?id=136618
2478
2479         Reviewed by Darin Adler.
2480
2481         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
2482         other platforms etc. It does not make sense to count wait time for these, as it
2483         can be arbitrarily long.
2484
2485         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
2486
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2488         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
2489
2490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2491         We used to walk the timeline to see which revisions are fully tested, but that's not
2492         correct. A revision that's only tested by a subset of queues finishes independently
2493         of another that's tested by another subset. Now, we just search for the answer for
2494         each revision individually.
2495
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2497         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
2498         the analyzer now reports. Removed best time, which is more confusing than meaningful.
2499
2500 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2501
2502         Remove EWebLauncher from webkitdirs.pm
2503         https://bugs.webkit.org/show_bug.cgi?id=136622
2504
2505         Reviewed by Gyuyoung Kim.
2506
2507         * Scripts/webkitdirs.pm:
2508         (launcherName):
2509
2510 2014-09-06  Sam Weinig  <sam@webkit.org>
2511
2512         XPCPtr should be converted into an all purpose smart pointer for os_objects
2513         https://bugs.webkit.org/show_bug.cgi?id=136602
2514
2515         Reviewed by Darin Adler.
2516
2517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2518         * TestWebKitAPI/Tests/WTF/darwin: Added.
2519         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
2520         Add basic unit tests for OSObjectPtr.
2521
2522 2014-09-06  Saam Barati  <saambarati1@gmail.com>
2523
2524         Unreviewed. Add myself as a committer.
2525
2526         * Scripts/webkitpy/common/config/contributors.json:
2527
2528 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2529
2530         Unreviewed, EFL build fix when SHARED_CORE is on.
2531
2532         * TestWebKitAPI/PlatformEfl.cmake:
2533
2534 2014-09-05  Lucas Forschler  <lforschler@apple.com>
2535
2536         <https://webkit.org/b/136586> Add bots to Apple build/test queues
2537         
2538         Reviewed by Daniel Bates.
2539
2540         * BuildSlaveSupport/build.webkit.org-config/config.json:
2541
2542 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
2543
2544         Buildbot metrics page gives wrong results after a new bot gets added
2545         https://bugs.webkit.org/show_bug.cgi?id=136516
2546
2547         Reviewed by Tim Horton.
2548
2549         Part 2: Fix elapsed times.
2550
2551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2552         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
2553         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
2554
2555 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2556
2557         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
2558         https://bugs.webkit.org/show_bug.cgi?id=136562
2559
2560         Reviewed by Martin Robinson.
2561
2562         * Scripts/run-gtk-tests:
2563         (TestRunner): Remove failure expectations for tests that now pass.
2564
2565 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2566
2567         Dashboard metrics page wastes a lot of time sorting iterations
2568         https://bugs.webkit.org/show_bug.cgi?id=136559
2569
2570         Reviewed by Tim Horton.
2571
2572         Also fixes comments here and there, and adds a missing "var".
2573
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2575         (BuildbotIteration.prototype._parseData):
2576         (BuildbotIteration.prototype._updateWithData):
2577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2578         (BuildbotQueue.prototype.loadAll):
2579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2580         (Analyzer.prototype._countTimes):
2581
2582 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2583
2584         [GTK] Unreviewed GTK gardening.
2585
2586         * Scripts/run-gtk-tests:
2587         (TestRunner): Skip tests failing since r173272.
2588
2589 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2590
2591         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2592         https://bugs.webkit.org/show_bug.cgi?id=136561
2593
2594         Reviewed by Tim Horton.
2595         
2596         Log for calloc() and CGBitmapContextCreate() failures.
2597
2598         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2599         (createBitmapContext):
2600         (createBitmapContextFromWebView):
2601
2602 2014-09-04  Andy Estes  <aestes@apple.com>
2603
2604         Fix the Mac Production build after r173283.
2605
2606         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
2607
2608 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2609
2610         [Win] webkitpy test suite frequently fails to complete
2611         https://bugs.webkit.org/show_bug.cgi?id=136546
2612
2613         Reviewed by Daniel Bates.
2614
2615         Properly convert the ASCII crash log produced by ntsd into
2616         a unicode string as early as possible so that we handle it
2617         properly when generating our logs and other test support output.
2618
2619         We were mixing ASCII/unicode strings under Windows, which was
2620         causing test system failures when we processed some crash logs.
2621
2622         Also do a better job of handling garbage pid entries in the
2623         Cygwin lock files.
2624
2625         * Scripts/webkitpy/common/system/crashlogs.py:
2626         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
2627         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
2628         handle the strings as unicode from that point on.
2629         * Scripts/webkitpy/port/http_lock.py:
2630         (HttpLock._current_lock_pid): Add logging and handle case of
2631         the current_pid failing to cleanly convert to 'int'.
2632         * Scripts/webkitpy/port/win.py:
2633         (WinPort): Add 64-bit architecture as a known target for the
2634         Windows build.
2635
2636 2014-09-04  Andy Estes  <aestes@apple.com>
2637
2638         Address additional review feedback after landing r173283.
2639
2640         Reviewed by Daniel Bates.
2641
2642         * DumpRenderTree/config.h: Removed redundant includes.
2643         * TestWebKitAPI/config.h: Ditto.
2644         * WebKitTestRunner/config.h: Ditto.
2645
2646 2014-09-03  Andy Estes  <aestes@apple.com>
2647
2648         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2649         https://bugs.webkit.org/show_bug.cgi?id=136521
2650
2651         Reviewed by Anders Carlsson.
2652
2653         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
2654         * TestWebKitAPI/config.h: Ditto.
2655         * WebKitTestRunner/config.h: Ditto.
2656
2657 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2658
2659         REGRESSION: Dashboard metrics page aggregation counts performance bots
2660         https://bugs.webkit.org/show_bug.cgi?id=136539
2661
2662         Reviewed by Tim Horton.
2663
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2665
2666 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2667
2668         [Win] Perl test fix.
2669
2670         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
2671         VersionStamp.exe tool, not just the driver script.
2672
2673 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2674
2675         Remove CSS_FILTERS flag
2676         https://bugs.webkit.org/show_bug.cgi?id=136529
2677
2678         Reviewed by Dirk Schulze.
2679
2680         * Scripts/webkitperl/FeatureList.pm:
2681
2682 2014-09-04  Commit Queue  <commit-queue@webkit.org>
2683
2684         Unreviewed, rolling out r173201.
2685         https://bugs.webkit.org/show_bug.cgi?id=136538
2686
2687         Improves the situation but also introduces additional crashes.
2688         (Requested by zdobersek on #webkit).
2689
2690         Reverted changeset:
2691
2692         "GMainLoopSource is exposed to race conditions"
2693         https://bugs.webkit.org/show_bug.cgi?id=135800
2694         http://trac.webkit.org/changeset/173201
2695
2696 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2697
2698         Buildbot metrics page gives wrong results after a new bot gets added
2699         https://bugs.webkit.org/show_bug.cgi?id=136516
2700
2701         Part 1: Fix red/green counters. Dashboard is considered green at a given time
2702         if all the bots that ever had results before this time are green.
2703
2704         This doesn't (and cannot) address situations where the bot gets removed and then
2705         re-added. It also gives wrong results after a bot gets removed, because it doesn't
2706         know that it was ever displayed on the dashboard.
2707
2708         Reviewed by Darin Adler.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2711         (Analyzer.prototype._dashboardIsAllGreen):
2712         (Analyzer.prototype._updateStretchOfRedCounters):
2713         (Analyzer.prototype._countPercentageOfGreen):
2714         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
2715
2716 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2717
2718         [Win] Unreviewed test fix.
2719
2720         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
2721         test if user doesn't have the VersionStamp.exe program.
2722
2723 2014-09-03  Dana Burkart  <dburkart@apple.com>
2724
2725         Unreviewed. Add myself as a committer.
2726
2727         * Scripts/webkitpy/common/config/contributors.json:
2728
2729 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2730
2731         build.webkit.org/dashboard performance popover is unstyled
2732         https://bugs.webkit.org/show_bug.cgi?id=136499
2733
2734         Reviewed by Tim Horton.
2735
2736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2737         (.performance-popover):
2738         (.performance-popover .dashboard-link):
2739
2740 2014-09-03  Saam Barati  <saambarati1@gmail.com>
2741
2742         Create tests for type profiling
2743         https://bugs.webkit.org/show_bug.cgi?id=136161
2744
2745         Reviewed by Geoffrey Garen.
2746
2747         Have run-javascriptcore-tests run the newly created
2748         tests for the type profiler.
2749
2750         * Scripts/run-javascriptcore-tests:
2751         * Scripts/run-jsc-stress-tests:
2752
2753 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2754
2755         [Win] Revise test environment for Windows build.
2756         https://bugs.webkit.org/show_bug.cgi?id=136486
2757
2758         Reviewed by David Kilzer.
2759
2760         The various calls to get the Safari path really only have
2761         meaning on the Mac. Other ports get access to the build
2762         and test environment separately, so remove the various
2763         checks in the Safari-specific code to simplify things.
2764
2765         Remove some 64-bit hacks used on Windows now that the
2766         various tools know how to find the 64-bit runtime environment.
2767
2768         * Scripts/run-javascriptcore-tests: 
2769         * Scripts/webkitdirs.pm:
2770         (safariPathFromSafariBundle): Revise to expect Mac.
2771         (installedSafariPath): Ditto.
2772         (safariPath): Ditto.
2773         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
2774         (setPathForRunningWebKitApp): Get rid of unused SafariPath
2775         argument for Windows runs.
2776
2777 2014-09-03  Dana Burkart  <dburkart@apple.com>
2778
2779         Dashboard should show performance bots.
2780         https://bugs.webkit.org/show_bug.cgi?id=136386
2781
2782         Reviewed by Alexey Proskuryakov.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2785         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
2786         (BuildbotIteration.prototype._parseData):
2787         Support possible performance failures.
2788
2789         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2790         New QueueView to manage the way we present performance data.
2791
2792         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2793         (BuildbotQueue):
2794         Support new 'performance' and 'performanceTestName' keys.
2795
2796
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2798         Add performance column to the main page.
2799
2800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2801         (WebKitBuildbot):
2802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2803         (body):
2804         Make sure everything fits on 13 inch screens.
2805
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2807
2808 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
2809
2810         GMainLoopSource is exposed to race conditions
2811         https://bugs.webkit.org/show_bug.cgi?id=135800
2812
2813         Reviewed by Carlos Garcia Campos.
2814
2815         Add a unit test for GMainLoopSource that tests different
2816         types of rescheduling tasks on already-active sources.
2817
2818         * TestWebKitAPI/PlatformGTK.cmake:
2819         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2820         (GMainLoopSourceTest::GMainLoopSourceTest):
2821         (GMainLoopSourceTest::~GMainLoopSourceTest):
2822         (GMainLoopSourceTest::runLoop):
2823         (GMainLoopSourceTest::finish):
2824         (GMainLoopSourceTest::source):
2825         (testGMainLoopSourceBasicRescheduling):
2826         (testGMainLoopSourceReentrantRescheduling):
2827         (testGMainLoopSourceDifferentThreadRescheduling):
2828         (beforeAll):
2829         (afterAll):
2830         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2831         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2832         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2833         (TestWebKitAPI::GMainLoopSourceTest::finish):
2834         (TestWebKitAPI::GMainLoopSourceTest::source):
2835         (TestWebKitAPI::TEST):
2836
2837 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
2838
2839         Make sure WK1 prefs are initialized in MiniBrowser
2840         https://bugs.webkit.org/show_bug.cgi?id=136465
2841
2842         Reviewed by Tim Horton.
2843         
2844         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
2845         for WK2 windows, to make sure that WebPreferences are updated (to get
2846         layer borders to work consistently).
2847
2848         * MiniBrowser/mac/WK1BrowserWindowController.m:
2849         (-[WK1BrowserWindowController awakeFromNib]):
2850
2851 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
2852
2853         check-webkit-style should complain about C++ comments in Platform.h
2854         https://bugs.webkit.org/show_bug.cgi?id=133802
2855
2856         Reviewed by Csaba Osztrogonác.
2857
2858         * Scripts/webkitpy/style/checkers/cpp.py:
2859         (check_platformh_comments):
2860         (_process_lines):
2861         (CppChecker):
2862         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2863         (CppStyleTest.test_platformh_comment):
2864
2865 2014-09-02  Brendan Long  <self@brendanlong.com>
2866
2867         [Gtk] Make install-dependencies work on Arch Linux
2868         https://bugs.webkit.org/show_bug.cgi?id=136374
2869
2870         Reviewed by Philippe Normand.
2871
2872         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
2873
2874 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
2875
2876         Provide column numbers to DTrace willExecute/didExecute probes
2877         https://bugs.webkit.org/show_bug.cgi?id=136434
2878
2879         Reviewed by Antti Koivisto.
2880
2881         Create a directory for DTrace scripts. Add an example script that
2882         shows how to use static probes provided by JavaScriptCore's profiler.
2883
2884         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
2885
2886 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2887
2888         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
2889         https://bugs.webkit.org/show_bug.cgi?id=136431
2890
2891         Reviewed by Martin Robinson.
2892
2893         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
2894         Add missing dependencies for librsvg (glib and cairo).
2895
2896 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2897
2898         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
2899         https://bugs.webkit.org/show_bug.cgi?id=136425
2900
2901         Reviewed by Martin Robinson.
2902
2903         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
2904
2905 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
2906
2907         Update my list of email addresses in contributors.json
2908         https://bugs.webkit.org/show_bug.cgi?id=136424
2909
2910         Reviewed by Gyuyoung Kim.
2911
2912         * Scripts/webkitpy/common/config/contributors.json:
2913
2914 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
2915
2916         [RJST] eager-no-cjit should really mean eager
2917         https://bugs.webkit.org/show_bug.cgi?id=136407
2918
2919         Reviewed by Mark Hahnenberg.
2920         
2921         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
2922         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
2923         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
2924         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
2925         threshold setting that NO_CJIT_OPTIONS was currently setting
2926         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
2927         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
2928         
2929         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
2930
2931         * Scripts/run-jsc-stress-tests:
2932
2933 2014-08-29  Daniel Bates  <dabates@apple.com>
2934
2935         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
2936         https://bugs.webkit.org/show_bug.cgi?id=136388
2937
2938         Reviewed by David Kilzer.
2939
2940         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
2941         support building a command line tool for the iOS Simulator. You must run this
2942         script as root.
2943
2944         The script uses the xcspec files in the OS X SDK to create xcspec files in the
2945         iOS Simulator SDK with the product- and package- type definitions to build a
2946         command line tool, if applicable.
2947
2948         * Scripts/configure-xcode-for-ios-development: Added.
2949
2950 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2951
2952         Remove Windows WebKit2 code from TestWebKitAPI
2953         https://bugs.webkit.org/show_bug.cgi?id=136385
2954
2955         Reviewed by Alexey Proskuryakov.
2956
2957         * TestWebKitAPI/PlatformUtilities.h:
2958         * TestWebKitAPI/PlatformWebView.h:
2959         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
2960         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2961         (TestWebKitAPI::TEST): Deleted.
2962         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2963         (TestWebKitAPI::TEST):
2964         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2965         (TestWebKitAPI::TEST):
2966         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
2967         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
2968         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
2969         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
2970         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
2971         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
2972         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
2973
2974 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2975
2976         [JSC] Some JSC tests are dependent on the machine time zone.
2977         https://bugs.webkit.org/show_bug.cgi?id=136363
2978
2979         Reviewed by Filip Pizlo.
2980
2981         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
2982         Unskip the tests that were skipped on r99580.
2983
2984 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2985
2986         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
2987         https://bugs.webkit.org/show_bug.cgi?id=135560
2988
2989         Reviewed by Gyuyoung Kim.
2990
2991         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
2992
2993 2014-08-28  Daniel Bates  <dabates@apple.com>
2994
2995         [Win] update-webkit should update auxiliary libs by default
2996
2997         Reviewed by Dan Bernstein.
2998
2999         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
3000         from updating the Windows auxiliary libs by default. We should make update-webkit update the
3001         Windows auxiliary libs by default. This will make its behavior match its usage text.
3002
3003         * Scripts/update-webkit:
3004
3005 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
3006
3007         build-webkit --inspector-frontend tries to copy files from old inspector path
3008         https://bugs.webkit.org/show_bug.cgi?id=136346
3009
3010         Reviewed by Timothy Hatcher.
3011
3012         Remove the old code path for copying inspector resources. It doesn't work.
3013         Complain if this option is passed to CMake-based builds.
3014
3015         * Scripts/build-webkit:
3016         * Scripts/webkitdirs.pm:
3017         (copyInspectorFrontendFiles): Deleted.
3018
3019 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
3020
3021         Dashboard metrics page could show longest stretch of red
3022         https://bugs.webkit.org/show_bug.cgi?id=136334
3023
3024         Reviewed by Sam Weinig.
3025
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3027         (Analyzer.prototype._updateStretchOfRedCounters):
3028         (Analyzer.prototype._countPercentageOfGreen):
3029         When counting percentage of green, also keep track of how long the page was red.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
3032         (MetricsView.prototype._update.addDivider):
3033         (MetricsView.prototype._update.appendQueueResults):
3034         Show it in aggregate queues (can't think of a reason to have it in individual ones).
3035
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3037         Changed to use an explicit divider element between green time and performance groups,
3038         as there are too many combinations to easily express in CSS.
3039
3040 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3041
3042         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
3043         https://bugs.webkit.org/show_bug.cgi?id=136248
3044
3045         Reviewed by Gustavo Noronha Silva.
3046
3047         Add new test case for webkit_uri_response_get_http_headers().
3048
3049         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3050         (testURIResponseHTTPHeaders):
3051         (serverCallback):
3052         (beforeAll):
3053
3054 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3055
3056         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3057         https://bugs.webkit.org/show_bug.cgi?id=131668
3058
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3060         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
3061
3062 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3063
3064         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
3065         https://bugs.webkit.org/show_bug.cgi?id=136264
3066
3067         Reviewed by Simon Fraser.
3068         
3069         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
3070         functions. ->snappedIntSize()/snapSizeToDevicePixel().
3071         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
3072
3073         Covered by existing tests.
3074
3075         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3076         (TestWebKitAPI::TEST): Deleted.
3077
3078 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3079
3080         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3081         https://bugs.webkit.org/show_bug.cgi?id=131668
3082
3083         Reviewed by Daniel Bates.
3084
3085         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
3086         to not just hardcode.
3087
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3089         (EWS.prototype.queueStatusURL): Added.
3090
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3092         (EWSQueue.prototype.get statusPageURL): Use the above function.
3093         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
3094
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
3096         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
3097         are no patches in the queue. The popover has other useful information, such as charts
3098         link and bot status.
3099
3100 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3101
3102         https://bugs.webkit.org/show_bug.cgi?id=136317
3103         Dashboard metrics page sometimes shows 0 for best time
3104
3105         Reviewed by Tim Horton.
3106
3107         This also affects regular dashboard display in a good way - iterations that failed
3108         due to infrastructure misbehavior will more reliably show up as yellow and not red.
3109
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3111         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
3112         updated if we rename steps.
3113         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
3114         do it once.
3115         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
3116         that failed e.g. at downloading built archive step are not productive.
3117
3118 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
3119
3120         [Win] Unreviewed gardening.
3121
3122         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
3123         of logs assembled into the final build output.
3124
3125 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3126
3127         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
3128         https://bugs.webkit.org/show_bug.cgi?id=136196
3129
3130         Reviewed by Timothy Hatcher.
3131
3132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
3134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
3135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
3136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
3137         A date range picker control with dependencies.
3138         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
3139         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
3140         (it didn't happen again upon re-opening the picker).
3141         - Made made style tweaks to match Dashboard UI.
3142
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3144         Don't create objects that are not needed by the given app, and thus are not loaded at all.
3145
3146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
3147         Math to count all the things. Only supports open source tree and trunk at the moment,
3148         but written with internal tree and branches in mind.
3149
3150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
3151         Like dashboard Main.js, draws the UI and creates all necessary objects.
3152
3153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
3154         A view for table cells.
3155
3156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3157         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
3158         Metrics page has individual platforms initially scrolled away form the view, so 
3159         it needs to scroll down to reveal what's being configured.
3160
3161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3162         Added Array.prototype.average and Array.prototype.median.
3163
3164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3165         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
3166         in settings mode.
3167
3168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3169         Additional style rules.
3170
3171         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3172         The metrics page.
3173
3174 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3175
3176         Remove networkinfo watch category in watchlist
3177         https://bugs.webkit.org/show_bug.cgi?id=136279
3178
3179         Reviewed by Alexey Proskuryakov.
3180
3181         Network info was removed. So, it is not needed anymore.
3182
3183         * Scripts/webkitpy/common/config/watchlist:
3184
3185 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3186
3187         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
3188         https://bugs.webkit.org/show_bug.cgi?id=136281
3189
3190         Reviewed by Tim Horton.
3191
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3193         Track and expose whether the itertion is being loaded. Made update() a no-op if
3194         the iteration is already being loaded.
3195
3196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3197         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
3198         loading everything at once, ask the queue to load a little more. We can always repeat
3199         if we still don't have enough data.
3200
3201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3202         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
3203         10 more iterations intelligently.
3204
3205 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3206
3207         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
3208         https://bugs.webkit.org/show_bug.cgi?id=136283
3209
3210         Reviewed by Tim Horton.
3211
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3213         Don't.
3214
3215 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3216
3217         build.webkit.org/dashboard raises an exception after a hidden platform is removed
3218         https://bugs.webkit.org/show_bug.cgi?id=136282
3219
3220         Reviewed by Tim Horton.
3221
3222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3223         (updateHiddenPlatforms): Check that the platform is still valid.
3224
3225 2014-08-26  Matt Lilek  <mrl@apple.com>
3226
3227         Add WebKit SPI to control the navigator.standalone property
3228         https://bugs.webkit.org/show_bug.cgi?id=136189
3229
3230         Reviewed by Andy Estes.
3231
3232         Add API test for WKPreferences
3233
3234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3235         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3236         (TEST):
3237
3238 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3239
3240         Remove ENABLE_DRT environment variable to enable SHARED_CORE
3241         https://bugs.webkit.org/show_bug.cgi?id=136205
3242
3243         Reviewed by Andrei Bucur.
3244
3245         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
3246         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
3247
3248         * Scripts/webkitdirs.pm:
3249         (generateBuildSystemFromCMakeProject):
3250
3251 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3252
3253         [Win] Version stamp should include package-level version
3254         https://bugs.webkit.org/show_bug.cgi?id=136266
3255         <rdar://problem/18134138>
3256
3257         Reviewed by David Kilzer.
3258
3259         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
3260         tests for the full 3+ digit version.
3261         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3262         Confirm that the final output DLL uses the 3+ digit version.
3263
3264 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3265
3266         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
3267         https://bugs.webkit.org/show_bug.cgi?id=136258
3268         <rdar://problem/18134138>
3269
3270         Reviewed by Tim Horton.
3271
3272         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
3273         values from passing through the 32-bit OLE_HANDLE data type.
3274
3275         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3276         (AccessibilityController::rootElement):
3277         * DumpRenderTree/win/DumpRenderTree.cpp:
3278         (resetWebViewToConsistentStateBeforeTesting):
3279         (runTest):
3280         (createWebViewAndOffscreenWindow):
3281         * DumpRenderTree/win/FrameLoadDelegate.h:
3282         (FrameLoadDelegate::didReceiveIcon):
3283         * DumpRenderTree/win/TestRunnerWin.cpp:
3284         (TestRunner::setWindowIsKey):
3285         * DumpRenderTree/win/UIDelegate.cpp:
3286         (UIDelegate::trackCustomPopupMenu):
3287         (UIDelegate::drawHeaderInRect):
3288         (UIDelegate::drawFooterInRect):
3289         (UIDelegate::webViewClose):
3290         (UIDelegate::webViewFocus):
3291         (UIDelegate::webViewSetCursor):
3292         (UIDelegate::drawBackground):
3293         * DumpRenderTree/win/UIDelegate.h:
3294         (UIDelegate::webViewFirstResponder):
3295         (UIDelegate::makeFirstResponder):
3296         (UIDelegate::contextMenuItemsForElement):
3297         (UIDelegate::addCustomMenuDrawingData):
3298         (UIDelegate::cleanUpCustomMenuDrawingData):
3299         (UIDelegate::webViewLostFocus):
3300         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3301         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3302         * WinLauncher/PrintWebUIDelegate.cpp:
3303         (PrintWebUIDelegate::drawHeaderInRect):
3304         (PrintWebUIDelegate::drawFooterInRect):
3305         * WinLauncher/PrintWebUIDelegate.h:
3306         (PrintWebUIDelegate::webViewFirstResponder):
3307         (PrintWebUIDelegate::makeFirstResponder):
3308         (PrintWebUIDelegate::contextMenuItemsForElement):
3309         (PrintWebUIDelegate::trackCustomPopupMenu):
3310         (PrintWebUIDelegate::addCustomMenuDrawingData):
3311         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
3312         * WinLauncher/WinLauncher.cpp:
3313         (WinLauncher::prepareViews):
3314         * WinLauncher/WinLauncherWebHost.h:
3315         (WinLauncherWebHost::didReceiveIcon):
3316
3317 2014-08-26  Daniel Bates  <dabates@apple.com>
3318
3319         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
3320
3321         Rubber-stamped by Tim Horton.
3322
3323         The Windows and iOS ports are the only ports that make use of WebCore headers
3324         in DumpRenderTree.
3325
3326         * DumpRenderTree/config.h:
3327
3328 2014-08-26  Dan Bernstein  <mitz@apple.com>
3329
3330         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
3331         https://bugs.webkit.org/show_bug.cgi?id=136254
3332
3333         Reviewed by Tim Horton.
3334
3335         * Scripts/webkitdirs.pm:
3336         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
3337         not the invoking script.
3338
3339 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
3340
3341         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
3342         https://bugs.webkit.org/show_bug.cgi?id=136127
3343
3344         Reviewed by Gyuyoung Kim.
3345
3346         Add espeak dependency.
3347
3348         * efl/install-dependencies:
3349
3350 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3351
3352         Remove a little more accidentally landed code from r172891.
3353
3354         iteration.branch also wasn't meant to be landed.
3355
3356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3357         (BuildbotIteration.prototype._parseData):
3358
3359 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3360
3361         REGRESSION (r172891): Internal dashboard is broken.
3362
3363         Removing some accidentally landed code - I needed "changes" for another patch, but
3364         not here, and then I decided to not use it anyway.
3365
3366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3367         (BuildbotIteration.prototype._parseData):
3368
3369 2014-08-25  Daniel Bates  <dabates@apple.com>
3370
3371         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
3372         (https://bugs.webkit.org/show_bug.cgi?id=136108)
3373
3374         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
3375         so that we can compile DumpRenderTree for iOS.
3376
3377         * DumpRenderTree/config.h:
3378
3379 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3380
3381         Make build.webkit.org/dashboard work with changeset_show_files=location
3382         https://bugs.webkit.org/show_bug.cgi?id=136237
3383
3384         Reviewed by Tim Horton.
3385
3386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3387         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
3388         from description before getting title, and also actually parse the location into
3389         result object when available.
3390
3391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3392         (String.prototype.startsWith): Added.
3393
3394 2014-08-25  Tanay C  <tanay.c@samsung.com>
3395
3396         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
3397         https://bugs.webkit.org/show_bug.cgi?id=135795
3398
3399         Reviewed by Gyuyoung Kim.
3400
3401         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
3402         (history_list_hide): Hiding and dereferencing the history list and items
3403         (on_key_down):
3404         (on_mouse_down):
3405         (on_back_button_clicked): Early return for longpress 
3406         (on_forward_button_clicked): Early return for longpress 
3407         (list_item_label_get): Populate item labels
3408         (on_list_item_select): Navigates on selection from history list
3409         (navigation_button_longpress_process): Populates the history list and displays it
3410         (on_forward_button_longpress):
3411         (on_back_button_longpress):
3412         (window_create): Add the widget for history list
3413
3414 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3415
3416         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
3417         https://bugs.webkit.org/show_bug.cgi?id=136152
3418
3419         Reviewed by Philippe Normand.
3420
3421         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
3422         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
3423         Cherry pick upstream patches daa194 and 4e3d101.
3424
3425 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
3426
3427         GenericHashTraits::peek() is producing copies of passed-in temporary values
3428         https://bugs.webkit.org/show_bug.cgi?id=131461
3429
3430         Reviewed by Darin Adler.
3431
3432         Add a test case that checks the number of copies and moves of the mapped objects
3433         when calling HashMap::get(). Exactly one copy of the mapped value should be
3434         performed when there exists a value that is mapped to the specified key, and
3435         exactly one move and no copies of the empty value should be performed when there
3436         isn't any mapped value for the specified key.
3437
3438         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
3439         (CopyMoveCounter::TestingScope::TestingScope):
3440         (CopyMoveCounter::CopyMoveCounter):
3441         (CopyMoveCounter::operator=):
3442         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3443         (TestWebKitAPI::TEST):
3444
3445 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
3446
3447         [EFL] Introduce DEVELOPER_MODE
3448         https://bugs.webkit.org/show_bug.cgi?id=135884
3449
3450         Reviewed by Gyuyoung Kim.
3451
3452         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
3453         (generateBuildSystemFromCMakeProject):
3454
3455 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
3456
3457         build.webkit.org/dashboard unnecessarily loads results of hidden queues
3458         https://bugs.webkit.org/show_bug.cgi?id=136195
3459
3460         Reviewed by Tim Horton.
3461
3462         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3466         Don't start an update just because a queue object was created. Periodic updates
3467         are triggered by views, so it only makes sense to do the same for the initial update.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3470         Now that Trac object doesn't auto-load, start loading here.
3471
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3473         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
3474         a data member added by subclasses later. With this.platform being undefined, it
3475         always looked like this queue was not hidden.
3476         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
3477
3478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3479         (Trac): Don't load anything here, the client may choose to load a custom date range.
3480         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
3481
3482 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3483
3484         build.webkit.org/dashboard: Further improve Trac loading
3485         https://bugs.webkit.org/show_bug.cgi?id=136174
3486
3487         Reviewed by Timothy Hatcher.
3488
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3490         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
3491         error, the oldest commit within the range wasn't returned. The correct argument for
3492         "no limit" is 0.
3493         (Trac.prototype.load): Added a function to load a specific time range.
3494         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
3495         positioned with regards to ones that were already known.
3496
3497 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3498
3499         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
3500         https://bugs.webkit.org/show_bug.cgi?id=136182
3501
3502         Reviewed by Timothy Hatcher.
3503
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3505         Make it possible to create a complete BuildbotIteration object with JSON, not only by
3506         loading data from the network.
3507
3508         An iteration has three states:
3509         1. Just created, it only knows the revision, and whether it's already finished.
3510         BuildbotIteration constructor used to create these.
3511         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
3512         3. Data about tests is fetched.
3513
3514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3515         Make it possible to pull all data from a buildbot queue. This needs to be better
3516         optimized eventually, as it's somewhat slow.
3517
3518 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3519
3520         Remove LevelDB.
3521         https://bugs.webkit.org/show_bug.cgi?id=136170
3522
3523         Reviewed by Gyuyoung Kim.
3524
3525         * Scripts/webkitpy/common/config/watchlist:
3526         * Scripts/webkitpy/style/checker.py:
3527
3528 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3529
3530         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
3531         https://bugs.webkit.org/show_bug.cgi?id=136153
3532
3533         Reviewed by Martin Robinson.
3534
3535         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
3536
3537 2014-08-21  Alex Christensen  <achristensen@webkit.org>
3538
3539         [Win] Another unreviewed build fix.
3540
3541         * DumpRenderTree/config.h:
3542         Defined WEBCORE_EXPORT on Windows.
3543
3544 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
3545
3546         [EFL][WK2] Minibrowser : Add stop button to abort page load
3547         https://bugs.webkit.org/show_bug.cgi?id=136122
3548
3549         Reviewed by Gyuyoung Kim.
3550
3551         * MiniBrowser/efl/main.c:
3552         (on_key_down):
3553         (on_stop_button_clicked): Callback for stop button press.
3554         (window_create):
3555
3556 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3557
3558         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
3559         https://bugs.webkit.org/show_bug.cgi?id=134070
3560
3561         Reviewed by Martin Robinson.
3562
3563         * Scripts/webkitpy/port/base.py:
3564         (Port.__init__): Set default _jhbuild_wrapper variable.
3565         (Port._should_use_jhbuild): Implement generic check.
3566         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
3567         to make it consistent with the other ports.
3568         * Scripts/webkitpy/port/gtk.py:
3569         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
3570         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
3571         querying the jhbuild with printenv. Also check that the path contains
3572         the libraries we expect. Preload this path only for XvfbDriver.
3573         * Scripts/webkitpy/port/xvfbdriver.py:
3574         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
3575         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
3576         configured at setup_environ_for_server()
3577         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3578         (XvfbDriverTest.make_driver): Get the port default environment.
3579         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
3580         should include the environment that is passed when running Xvfb.
3581         (XvfbDriverTest.test_start_pixel_tests): Ditto.
3582         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
3583         (XvfbDriverTest.test_start_next_worker): Ditto.
3584         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
3585         prevent future problems when the version is raised. Add also a
3586         comment with a warning.
3587         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
3588         that has the llvm optimized Gallium libGL libraries.
3589
3590 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3591
3592         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
3593         https://bugs.webkit.org/show_bug.cgi?id=136125
3594
3595         Reviewed by Csaba Osztrogonác.
3596
3597         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3598         (RunLLINTCLoopTests.countFailures):
3599         (Run32bitJSCTests.countFailures):
3600         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3601         (RunLLINTCLoopTestsTest):
3602         (RunLLINTCLoopTestsTest.assertResults):
3603         (RunLLINTCLoopTestsTest.test_failures):
3604         (RunLLINTCLoopTestsTest.test_failure):
3605         (RunLLINTCLoopTestsTest.test_no_failure):
3606         (Run32bitJSCTestsTest):
3607         (Run32bitJSCTestsTest.assertResults):
3608         (Run32bitJSCTestsTest.test_failures):
3609         (Run32bitJSCTestsTest.test_failure):
3610         (Run32bitJSCTestsTest.test_no_failure):
3611
3612 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3613
3614         Unreviewed, EFL build fix since r172814.
3615
3616         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
3617
3618 2014-08-20  Alex Christensen  <achristensen@webkit.org>
3619
3620         Introducing WEBCORE_EXPORT macro.
3621         https://bugs.webkit.org/show_bug.cgi?id=136108
3622
3623         Reviewed by Antti Koivisto.
3624
3625         * TestWebKitAPI/config.h:
3626         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
3627
3628 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
3629
3630         import-w3c-tests doesn't import .svg support files
3631         https://bugs.webkit.org/show_bug.cgi?id=135928
3632
3633         Reviewed by Bem Jones-Bey.
3634
3635         This patch fixes the W3C import script to not treat all
3636         files with an xml mimetype as convertible tests, which
3637         was causing SVG support files to not be imported.
3638
3639         * Scripts/webkitpy/w3c/test_importer.py:
3640         (TestImporter.find_importable_tests):
3641
3642 2014-08-19  Dan Bernstein  <mitz@apple.com>
3643
3644      &nb