2011-06-29 Yuta Kitamura <yutak@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-29  Yuta Kitamura  <yutak@chromium.org>
2
3         Reviewed by Kent Tamura.
4
5         DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController
6         https://bugs.webkit.org/show_bug.cgi?id=63532
7
8         LayoutTestController::overridePreference() will be used to change the value of
9         the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way,
10         we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but
11         at least we need to reset preference values in DumpRenderTree every time we start
12         a new test because preference values changed in some test should not be leaked
13         to the next test.
14
15         * DumpRenderTree/chromium/LayoutTestController.cpp:
16         (LayoutTestController::overridePreference):
17         The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h.
18         * DumpRenderTree/chromium/WebPreferences.cpp:
19         (WebPreferences::reset):
20         Set the default value. This will be called from TestShell::resetTestController().
21         (WebPreferences::applyTo):
22         * DumpRenderTree/chromium/WebPreferences.h:
23         * DumpRenderTree/mac/DumpRenderTree.mm:
24         (resetDefaultsToConsistentValues): Set the default value.
25         * DumpRenderTree/win/DumpRenderTree.cpp:
26         (resetDefaultsToConsistentValues): Ditto.
27
28 2011-06-29  Kenichi Ishibashi  <bashi@chromium.org>
29
30         Reviewed by Adam Barth.
31
32         check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
33         https://webkit.org/b/57360
34
35         Modify the regular expression to match https scheme.
36
37         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
38         * Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
39
40 2011-06-29  Adam Barth  <abarth@webkit.org>
41
42         Reviewed by Eric Seidel.
43
44         new-run-webkit-tests: images page switch actual and expected images before they're loaded
45         https://bugs.webkit.org/show_bug.cgi?id=63199
46
47         We now preload the images and keep the DOM nodes in memory instead of
48         going back to the MemoryCache all the time.  (Also, remove some nutty
49         </img> HTML.)
50
51         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
52
53 2011-06-29  Adam Barth  <abarth@webkit.org>
54
55         Reviewed by Eric Seidel.
56
57         new-run-webkit-tests should tell you when it creates new expectations
58         https://bugs.webkit.org/show_bug.cgi?id=63675
59
60         Unforunately, this patch creates a bunch of test-webkitpy spam because
61         we don't understand how Python logging works well enough to stop the
62         spam.  :(
63
64         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
65
66 2011-06-29  Eric Seidel  <eric@webkit.org>
67
68         Reviewed by Adam Barth.
69
70         Refactor WebKitDriver.run_test into smaller pieces
71         https://bugs.webkit.org/show_bug.cgi?id=63673
72
73         There is no functional change here.  Just moving code around.
74         This is in preparation for adding support for #CRASHED and #CRASHED - WebProcess
75
76         * Scripts/webkitpy/layout_tests/port/webkit.py:
77
78 2011-06-29  Eric Seidel  <eric@webkit.org>
79
80         Reviewed by Adam Barth.
81
82         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
83         https://bugs.webkit.org/show_bug.cgi?id=63501
84
85         Re-landing after fixing a bug in WebKitPort.baseline_search_path which broke
86         the rebaselineserver unit tests.  Also fixed nits brought up by Dirk after previous landing.
87
88         The goal was to add support for wk2 skipped lists.
89         However, I found that our skipped list computation was a
90         manual hack (which only worked for the mac port).
91
92         So I fixed a FIXME to move the skipped list finding
93         into WebKitPort instead of MacPort.
94         Doing so required the concept of a "port_name", since previously
95         the only name accessible from a port object was name()
96         which includes many things beyond "mac" or "chromium", etc.
97
98         Eventually I believe we'll want to re-think the way that we pass
99         in a port_name argument to Port subclasses and expect them to parse
100         it.  But for now I just added a cls.port_name variable which contains
101         the static information needed to compute wk2 names as well as
102         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
103
104         In order to test my new _skipped_file_search_paths method, I
105         fixed another FIXME by making it return relative paths.
106
107         I also fixed the test_expectations_path code in WebKitPort to use port_name.
108         It was using name() which would return PORT-VERSION so MacPort was overriding
109         it to use just PORT.  After fixing test_expectations_path to use port_name
110         (and making it aware of webkit2) I was able to remove the MacPort implementation.
111
112         * Scripts/webkitpy/layout_tests/port/base.py:
113          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
114          - Document that real_name() seems to have no purpose.
115         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
116          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
117         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
118          - Add _parse_port_name.
119         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
120          - Add _parse_port_name.
121         * Scripts/webkitpy/layout_tests/port/gtk.py:
122         * Scripts/webkitpy/layout_tests/port/mac.py:
123          - Move Skipped-file finding code down to WebKitPort
124         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
125         * Scripts/webkitpy/layout_tests/port/qt.py:
126         * Scripts/webkitpy/layout_tests/port/webkit.py:
127         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
128
129 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
130
131         Unreviewed, rolling out r90070.
132         http://trac.webkit.org/changeset/90070
133         https://bugs.webkit.org/show_bug.cgi?id=63676
134
135         Broke test-webkitpy rebaseline tests (Requested by eseidel2 on
136         #webkit).
137
138         * Scripts/webkitpy/layout_tests/port/base.py:
139         * Scripts/webkitpy/layout_tests/port/chromium.py:
140         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
141         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
142         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
143         * Scripts/webkitpy/layout_tests/port/gtk.py:
144         * Scripts/webkitpy/layout_tests/port/mac.py:
145         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
146         * Scripts/webkitpy/layout_tests/port/qt.py:
147         * Scripts/webkitpy/layout_tests/port/webkit.py:
148         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
149         * Scripts/webkitpy/layout_tests/port/win.py:
150         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
151
152 2011-06-29  Adam Barth  <abarth@webkit.org>
153
154         Reviewed by Eric Seidel.
155
156         new-run-webkit-tests doesn't support sample-on-timeout
157         https://bugs.webkit.org/show_bug.cgi?id=56731
158
159         * Scripts/webkitpy/layout_tests/port/server_process.py:
160         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
161         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
162
163 2011-06-29  Eric Seidel  <eric@webkit.org>
164
165         Reviewed by Adam Barth.
166
167         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
168         https://bugs.webkit.org/show_bug.cgi?id=63501
169
170         The goal was to add support for wk2 skipped lists.
171         However, I found that our skipped list computation was a
172         manual hack (which only worked for the mac port).
173
174         So I fixed a FIXME to move the skipped list finding
175         into WebKitPort instead of MacPort.
176         Doing so required the concept of a "port_name", since previously
177         the only name accessible from a port object was name()
178         which includes many things beyond "mac" or "chromium", etc.
179
180         Eventually I believe we'll want to re-think the way that we pass
181         in a port_name argument to Port subclasses and expect them to parse
182         it.  But for now I just added a cls.port_name variable which contains
183         the static information needed to compute wk2 names as well as
184         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
185
186         In order to test my new _skipped_file_search_paths method, I
187         fixed another FIXME by making it return relative paths.
188
189         I also fixed the test_expectations_path code in WebKitPort to use port_name.
190         It was using name() which would return PORT-VERSION so MacPort was overriding
191         it to use just PORT.  After fixing test_expectations_path to use port_name
192         (and making it aware of webkit2) I was able to remove the MacPort implementation.
193
194         * Scripts/webkitpy/layout_tests/port/base.py:
195          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
196          - Document that real_name() seems to have no purpose.
197         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
198          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
199         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
200          - Add _parse_port_name.
201         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
202          - Add _parse_port_name.
203         * Scripts/webkitpy/layout_tests/port/gtk.py:
204         * Scripts/webkitpy/layout_tests/port/mac.py:
205          - Move Skipped-file finding code down to WebKitPort
206         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
207         * Scripts/webkitpy/layout_tests/port/qt.py:
208         * Scripts/webkitpy/layout_tests/port/webkit.py:
209         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
210
211 2011-06-29  Adam Barth  <abarth@webkit.org>
212
213         Reviewed by Dirk Pranke.
214
215         new-run-webkit-tests complains about missing pixel results instead of plopping down new expectations
216         https://bugs.webkit.org/show_bug.cgi?id=38063
217
218         This patch changes new-run-webkit-tests to match old-run-webkit-tests
219         in generating new expected results when the expected results are
220         missing.
221
222         There are still a couple details that are different:
223
224         1) Image baselines aren't generated unless you run with -p.
225         2) Render tree dumps are places in the cross-platform directory instead
226         of the platform-specific directory.
227
228         I'm inclined to deal with both of these issues in follow-up patches.
229
230         * Scripts/webkitpy/common/net/layouttestresults.py:
231         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
232         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
233         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
234         * Scripts/webkitpy/layout_tests/port/test.py:
235         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
236         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
237
238 2011-06-29  Adam Roben  <aroben@apple.com>
239
240         Teach TestFailures to detect possibly flaky tests and list them separately
241
242         Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
243         arbitrary revisions for breaking flaky tests
244
245         Reviewed by Dan Bates.
246
247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.
248         (FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
249         from various builds (in reverse-chronological order).
250         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
251         monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
252         (FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
253         given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
254         and puts them in an array in reverse-chronological order.
255         (FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
256         to be possibly flaky.
257
258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
259         (LayoutTestHistoryAnalyzer): Initialize new members.
260         (LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
261         properties: history and possiblyFlaky. history holds the data this function used to pass to
262         the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
263         flakiness. Updated documentation comment to match.
264         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
265         FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
266         removed from the failure history, since when they started failing is no longer meaningful.
267         We tell our caller to keep calling until all current failures have been explained and we've
268         gone through 5 builds without any new flaky tests being identified.
269
270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
271         (sorted): New helper function to return a sorted copy of an array.
272         (Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
273         that matches the predicate.
274
275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
276         (ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
277         the analyzer. Now puts the list of possibly flaky tests after the failure history.
278         (ViewController.prototype._domForFailedTest): Moved some code from here...
279         (ViewController.prototype._domForFailureDiagnosis): ...to here.
280         (ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
281         possibly flaky tests and examples of their flakiness and returns it.
282
283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
284         FlakyLayoutTestDetector.js.
285
286 2011-06-29  Eric Seidel  <eric@webkit.org>
287
288         Adam says cowboys don't review (or unit test).
289
290         * Scripts/webkitpy/tool/commands/download.py:
291
292 2011-06-29  Eric Seidel  <eric@webkit.org>
293
294         Reviewed by Adam Barth.
295
296         Make port/config.py mockable for easier unit testing
297         https://bugs.webkit.org/show_bug.cgi?id=63661
298
299         Fix an exception from the unit tests.
300
301         * Scripts/webkitpy/layout_tests/port/config.py:
302
303 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
304
305         Unreviewed build correction.
306
307         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
308         Link against zlib1.dll, not the static zlib.lib.
309
310 2011-06-29  Eric Seidel  <eric@webkit.org>
311
312         Reviewed by Adam Barth.
313
314         Make port/config.py mockable for easier unit testing
315         https://bugs.webkit.org/show_bug.cgi?id=63661
316
317         Right now config.py leaks real system paths for
318         webkit_base_dir due to using __file__.  This patch
319         adds a filsystem.py wrapper around __file__ so that
320         we don't have to jump through hoops in webkit_unittest.py
321         to avoid leaking local paths to the unit test results.
322
323         There are probably many more places where we should now
324         use filesystem.path_for_module, but starting with just this one.
325
326         * Scripts/webkitpy/common/system/filesystem.py:
327         * Scripts/webkitpy/common/system/filesystem_mock.py:
328         * Scripts/webkitpy/layout_tests/port/config.py:
329         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
330         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
331
332 2011-06-29  Eric Seidel  <eric@webkit.org>
333
334         Reviewed by Adam Barth.
335
336         Remove duplicate methods in filesystem.py
337         https://bugs.webkit.org/show_bug.cgi?id=63658
338
339         Looks like there was a bad merge at some point.
340
341         I also removed a bunch of redundant docstrings.
342
343         * Scripts/webkitpy/common/system/filesystem.py:
344
345 2011-06-29  Adam Barth  <abarth@webkit.org>
346
347         Reviewed by Eric Seidel.
348
349         Pass --no-new-test-results to NRWT on build.webkit.org
350         https://bugs.webkit.org/show_bug.cgi?id=63653
351
352         This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.
353
354         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
355
356 2011-06-29  Xan Lopez  <xlopez@igalia.com>
357
358         Reviewed by Adam Barth.
359
360         [GTK] overlapping drag&drop tests fail on NRWT
361         https://bugs.webkit.org/show_bug.cgi?id=57640
362
363         Make a GTK test driver that spawns one Xvfb instance per
364         thread. This avoids bad interactions in DnD tests between threads.
365
366         * Scripts/webkitpy/layout_tests/port/gtk.py:
367
368 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
369
370         Unreviewed, rolling out r89888.
371         http://trac.webkit.org/changeset/89888
372         https://bugs.webkit.org/show_bug.cgi?id=63609
373
374          "Seems to be causing merging issues on the dashboard, e.g.
375         http://test-
376         results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
377         (Requested by aboxhall on #webkit).
378
379         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
380         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
381         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
382
383 2011-06-29  Philippe Normand  <pnormand@igalia.com>
384
385         Reviewed by Martin Robinson.
386
387         [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
388         https://bugs.webkit.org/show_bug.cgi?id=63624
389
390         * Scripts/webkitpy/common/system/executive.py: In some cases the
391         ps output lines can contain one or more leading white-spaces, so
392         strip it before splitting the pid and command name.
393
394 2011-06-29  Noel Gordon  <noel.gordon@gmail.com>
395
396         Reviewed by Kent Tamura.
397
398         [Chromium] [DRT] ImageDiff should compile in VS2010
399         https://bugs.webkit.org/show_bug.cgi?id=63614
400
401         * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
402
403 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
404
405         Reviewed by Kenneth Rohde Christiansen.
406
407         [Qt] DRT support for setInteractiveFormValidationEnabled
408         https://bugs.webkit.org/show_bug.cgi?id=63496
409
410         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
411         (WebCore::DumpRenderTree::DumpRenderTree):
412
413 2011-06-28  Eric Seidel  <eric@webkit.org>
414
415         Reviewed by Adam Barth.
416
417         Make new-run-webkit-tests -2 actually use WebKitTestRunner
418         https://bugs.webkit.org/show_bug.cgi?id=63572
419
420         new-run-webkit-tests -2 works with this change.  However a zillion
421         tests fail since it can't find the right skipped lists for wk2.
422         The Skipped-list fixing is covered in bug 63501.
423
424         * Scripts/webkitpy/layout_tests/port/gtk.py:
425         * Scripts/webkitpy/layout_tests/port/qt.py:
426         * Scripts/webkitpy/layout_tests/port/webkit.py:
427
428 2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>
429
430         Reviewed by Adam Roben.
431
432         Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
433         https://bugs.webkit.org/show_bug.cgi?id=63500
434
435         Added google-mac-3 and google-mac-4.
436
437         * BuildSlaveSupport/build.webkit.org-config/config.json:
438
439 2011-06-28  Eric Seidel  <eric@webkit.org>
440
441         Reviewed by Dirk Pranke.
442
443         Remove webkitpy's tiger support now that WebKit no longer supports tiger
444         https://bugs.webkit.org/show_bug.cgi?id=63568
445
446         I don't think our support actually fully worked anyway.  Regardless
447         tiger is dead now (thankfully)!
448
449         I also unwrapped some short lines and added a couple FIXMEs while
450         touring the code.
451
452         No new tests, only removing old ones which tested our Tiger support.
453
454         * Scripts/webkitpy/layout_tests/port/base.py:
455         * Scripts/webkitpy/layout_tests/port/builders.py:
456         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
457         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
458         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
459         * Scripts/webkitpy/layout_tests/port/mac.py:
460         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
461         * Scripts/webkitpy/tool/commands/rebaseline.py:
462         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
463
464 2011-06-28  Eric Seidel  <eric@webkit.org>
465
466         Unreviewed, just fixing a typo.
467
468         Fix misspellings of "thead" to "thread".
469
470         * Scripts/webkitpy/common/checkout/scm/git.py:
471         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
472
473 2011-06-28  Eric Seidel  <eric@webkit.org>
474
475         Reviewed by Tony Chang.
476
477         new-run-webkit-tests needs a --webkit-test-runner option
478         https://bugs.webkit.org/show_bug.cgi?id=63439
479
480         This was accidentally fixed in bug 63501 as well.
481         The root problem here was that the webkit unit tests were not using
482         enough mocks.  I've fixed them here to use more mocks
483         which should unbreak windows.
484
485         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
486
487 2011-06-28  Eric Seidel  <eric@webkit.org>
488
489         Reviewed by Tony Chang.
490
491         new-run-webkit-tests should not run mthml tests when MHTML support is disabled
492         https://bugs.webkit.org/show_bug.cgi?id=63549
493
494         This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
495         I happen to go looking for what code was deciding that .mht was a supported
496         extension, found test_files.py and then removed some redundant doc-strings and
497         if branching.
498
499         * Scripts/webkitpy/layout_tests/port/test_files.py:
500         * Scripts/webkitpy/layout_tests/port/webkit.py:
501         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
502
503 2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>
504
505         Reviewed by Tony Chang.
506
507         Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
508         https://bugs.webkit.org/show_bug.cgi?id=63514
509
510         - change write_text_file to write_binary_file
511         - check that text_path and binary_path are actually existant files
512         - change cleanup block from 'except' to 'finally'
513
514         * Scripts/webkitpy/common/system/filesystem_unittest.py:
515
516 2011-06-28  Adam Roben  <aroben@apple.com>
517
518         Roll out r89924 and r89925
519
520         I didn't mean to commit them!
521
522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
525
526 2011-06-27  Adam Barth  <abarth@webkit.org>
527
528         Reviewed by Eric Seidel.
529
530         NRWT should wait for ReportCrash
531         https://bugs.webkit.org/show_bug.cgi?id=63495
532
533         When a test crashes on Mac, ReportCrash confuses us into thinking the
534         test times out.
535
536         I'm not sure how to test this in a meaningful way in our current test
537         harness...
538
539         * Scripts/webkitpy/common/system/crashlogs.py:
540         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
541         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
542         * Scripts/webkitpy/layout_tests/port/base.py:
543         * Scripts/webkitpy/layout_tests/port/mac.py:
544         * Scripts/webkitpy/layout_tests/port/server_process.py:
545         * Scripts/webkitpy/tool/commands/queries.py:
546
547 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
548
549         Unreviewed, rolling out r89881.
550         http://trac.webkit.org/changeset/89881
551         https://bugs.webkit.org/show_bug.cgi?id=63513
552
553         Makes Qt massively slow (Requested by abarth on #webkit).
554
555         * Scripts/webkitpy/common/system/crashlogs.py:
556         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
557         * Scripts/webkitpy/common/system/executive.py:
558         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
559         * Scripts/webkitpy/layout_tests/port/base.py:
560         * Scripts/webkitpy/layout_tests/port/mac.py:
561         * Scripts/webkitpy/layout_tests/port/server_process.py:
562         * Scripts/webkitpy/tool/commands/queries.py:
563
564 2011-06-27  Alice Boxhall  <aboxhall@chromium.org>
565
566         Reviewed by Ojan Vafai.
567
568         Convert json_results_generator.py to output version 4 JSON.
569         https://bugs.webkit.org/show_bug.cgi?id=60869
570
571         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
572         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
573         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
574
575 2011-06-27  Adam Barth  <abarth@webkit.org>
576
577         Reviewed by Eric Seidel.
578
579         NRWT should wait for ReportCrash
580         https://bugs.webkit.org/show_bug.cgi?id=63495
581
582         When a test crashes on Mac, ReportCrash confuses us into thinking the
583         test times out.
584
585         I'm not sure how to test this in a meaningful way in our current test
586         harness...
587
588         * Scripts/webkitpy/common/system/crashlogs.py:
589         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
590         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
591         * Scripts/webkitpy/layout_tests/port/base.py:
592         * Scripts/webkitpy/layout_tests/port/mac.py:
593         * Scripts/webkitpy/layout_tests/port/server_process.py:
594         * Scripts/webkitpy/tool/commands/queries.py:
595
596 2011-06-27  Adam Barth  <abarth@webkit.org>
597
598         Reviewed by Eric Seidel.
599
600         new-run-webkit-tests should upload crash logs
601         https://bugs.webkit.org/show_bug.cgi?id=55907
602
603         NRWT used to have a different name for crash logs.  I've changed the
604         name to patch ORWT.
605
606         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
607         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
608
609 2011-06-27  Eric Seidel  <eric@webkit.org>
610
611         Reviewed by Adam Barth.
612
613         new-run-webkit-tests needs a --webkit-test-runner option
614         https://bugs.webkit.org/show_bug.cgi?id=63439
615
616         NRWT doesn't actually know how to run with the WebKitTestRunner yet
617         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
618
619         There is a bunch of other little cleanup in this patch which I added as I
620         took a tour through all of our hard-coded DumpRenderTree strings.
621
622         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
623         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
624         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
625         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
626         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
627         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
628         * Scripts/webkitpy/layout_tests/port/config.py:
629          - build_dumprendertree had no business in this class, removed it.
630          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
631          - Exposed _script_path as script_path() (this probably belongs elsewhere).
632         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
633          - Moved these tests to webkit_unittests.
634         * Scripts/webkitpy/layout_tests/port/webkit.py:
635          - Now respects the --webkit-test-runner option.
636          - setup_test_run is empty in base.py too, no need to override it.
637         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
638          - Test the new hotness.
639          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
640            I think this code is still hitting disk during the unit tests. :(
641         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
642          - Add the option.
643         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
644          - Remove optional args option.
645         * Scripts/webkitpy/tool/commands/commandtest.py:
646          - Remove optional args option.
647         * Scripts/webkitpy/tool/commands/queues_unittest.py:
648          - Remove optional args option.
649
650 2011-06-27  Adam Barth  <abarth@webkit.org>
651
652         Reviewed by Dirk Pranke.
653
654         new-run-webkit-tests does not report stderr output
655         https://bugs.webkit.org/show_bug.cgi?id=37739
656
657         Almost all the infrastructure appears to be in place to report stderr
658         in results.html.  We just need to wire up a bool to tell results.html
659         to create the hyperlink.
660
661         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
662         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
663         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
664         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
665         * Scripts/webkitpy/layout_tests/port/base.py:
666
667 2011-06-27  Adam Barth  <abarth@webkit.org>
668
669         Reviewed by Dirk Pranke.
670
671         webkitpy unit tests should have more descriptive names than just "Test"
672         https://bugs.webkit.org/show_bug.cgi?id=63479
673
674         Luckily we kept these classes in separate namespaces in the harness so
675         we were actually running them all even though they had the same name.
676
677         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
678         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
679         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
680
681 2011-06-27  Greg Simon  <gregsimon@chromium.org>
682
683         No review necessary.
684
685         Add email addr to contributor list
686         https://bugs.webkit.org/show_bug.cgi?id=63478
687
688         * Scripts/webkitpy/common/config/committers.py:
689
690 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
691
692         Unreviewed, rolling out r89834.
693         http://trac.webkit.org/changeset/89834
694         https://bugs.webkit.org/show_bug.cgi?id=63476
695
696         Broke test-webkitpy (Requested by abarth on #webkit).
697
698         * Scripts/webkitpy/common/net/layouttestresults.py:
699         * Scripts/webkitpy/common/system/outputcapture.py:
700         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
701         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
702         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
703         * Scripts/webkitpy/layout_tests/port/base.py:
704         * Scripts/webkitpy/layout_tests/port/config.py:
705         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
706         * Scripts/webkitpy/layout_tests/port/webkit.py:
707         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
708         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
709         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
710         * Scripts/webkitpy/tool/commands/commandtest.py:
711         * Scripts/webkitpy/tool/commands/queues_unittest.py:
712
713 2011-06-27  Jeff Miller  <jeffm@apple.com>
714
715         Reviewed by Adam Roben.
716
717         Stop copying obsolete WebKit libraries on Windows
718         https://bugs.webkit.org/show_bug.cgi?id=63474
719         
720         Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
721
722         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
723         * MiniBrowser/MiniBrowserPostBuild.cmd:
724         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
725
726 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
727
728         Add Wyatt Carss to the list of non-committer contributors.
729
730         * Scripts/webkitpy/common/config/committers.py:
731
732 2011-06-27  Adam Barth  <abarth@webkit.org>
733
734         Reviewed by Eric Seidel.
735
736         webkitpy should understand crash logs
737         https://bugs.webkit.org/show_bug.cgi?id=63468
738
739         We're planning to use this functionality to upload crash logs along
740         with test results for new-run-webkit-tests.
741
742         * Scripts/webkitpy/common/system/crashlog.py: Added.
743         * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
744         * Scripts/webkitpy/common/system/executive.py:
745         * Scripts/webkitpy/common/system/executive_unittest.py:
746         * Scripts/webkitpy/common/system/filesystem.py:
747         * Scripts/webkitpy/common/system/filesystem_mock.py:
748         * Scripts/webkitpy/tool/commands/queries.py:
749
750 2011-06-27  Adam Roben  <aroben@apple.com>
751
752         Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many
753         failures
754
755         Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
756         old-run-webkit-tests exited early after reload
757
758         Reviewed by Anders Carlsson.
759
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
761         (LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
762         old-run-webkit-tests exited early due to too many failures in PersistentCache.
763
764 2011-06-27  Adam Roben  <aroben@apple.com>
765
766         Make TestFailures load build names from build.webkit.org/old-results too
767
768         Build results are periodically moved from results to old-results. This change makes those
769         builds still visible to TestFailures.
770
771         Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
772         have been moved to build.webkit.org/old-results
773
774         Reviewed by Anders Carlsson.
775
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
777         (Builder.prototype.getBuildNames): Extracted code to parse build names from a
778         build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
779         we now only include directory entries whose names are parseable as build names (since
780         old-results sometimes contains other random files/directories from who knows what). We now
781         fetch both results and old-results (with a FIXME about loading old-results on demand),
782         extract build names from each, and concatenate the two sets of names.
783
784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:
785         (WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
786         parseable, rather than throwing an exception.
787
788 2011-06-26  Adam Roben  <aroben@apple.com>
789
790         Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache
791
792         It seems silly to have a whole generic cache just to store a single object.
793
794         Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
795         need one
796
797         Reviewed by Anders Carlsson.
798
799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
800         (LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
801         (LayoutTestHistoryAnalyzer.prototype.start): Ditto.
802         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
803         no-longer-needed history argument.
804
805 2011-06-26  Adam Roben  <aroben@apple.com>
806
807         Move some inappropriate code out of Builder
808
809         Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
810         isn't really about a builder
811
812         Reviewed by Anders Carlsson.
813
814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
815         (Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
816         called by other objects.
817
818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
819         Added. Code came from Builder.
820         (LayoutTestHistoryAnalyzer):
821         (LayoutTestHistoryAnalyzer.prototype.start):
822         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):
823
824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
825         Added. Code came from Builder.
826         (LayoutTestResultsLoader):
827         (LayoutTestResultsLoader.prototype.start):
828
829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
830         (ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.
831
832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new
833         scripts.
834
835 2011-05-17  Nat Duca  <nduca@chromium.org>
836
837         Reviewed by James Robinson.
838
839         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
840         https://bugs.webkit.org/show_bug.cgi?id=58408
841
842         * DumpRenderTree/chromium/WebViewHost.cpp:
843         (WebViewHost::paintInvalidatedRegion):
844
845 2011-06-27  Eric Seidel  <eric@webkit.org>
846
847         Reviewed by Adam Barth.
848
849         new-run-webkit-tests needs a --webkit-test-runner option
850         https://bugs.webkit.org/show_bug.cgi?id=63439
851
852         NRWT doesn't actually know how to run with the WebKitTestRunner yet
853         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
854
855         There is a bunch of other little cleanup in this patch which I added as I
856         took a tour through all of our hard-coded DumpRenderTree strings.
857
858         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
859         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
860         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
861         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
862         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
863         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
864         * Scripts/webkitpy/layout_tests/port/config.py:
865          - build_dumprendertree had no business in this class, removed it.
866          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
867          - Exposed _script_path as script_path() (this probably belongs elsewhere).
868         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
869          - Moved these tests to webkit_unittests.
870         * Scripts/webkitpy/layout_tests/port/webkit.py:
871          - Now respects the --webkit-test-runner option.
872          - setup_test_run is empty in base.py too, no need to override it.
873         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
874          - Test the new hotness.
875          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
876            I think this code is still hitting disk during the unit tests. :(
877         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
878          - Add the option.
879         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
880          - Remove optional args option.
881         * Scripts/webkitpy/tool/commands/commandtest.py:
882          - Remove optional args option.
883         * Scripts/webkitpy/tool/commands/queues_unittest.py:
884          - Remove optional args option.
885
886 2011-06-27  Chang Shu  <cshu@webkit.org>
887
888         Reviewed by Darin Adler.
889
890         [WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
891         https://bugs.webkit.org/show_bug.cgi?id=63457
892
893         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
894         (WTR::InjectedBundle::beginTesting):
895
896 2011-06-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
897
898         Reviewed by Kent Tamura.
899
900         [EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
901         It will be plugged into the build system as soon as the rest of the
902         DRT code is fully upstreamed.
903         https://bugs.webkit.org/show_bug.cgi?id=63086
904
905         * DumpRenderTree/efl/DumpRenderTreeView.cpp: Added.
906         (onConsoleMessage):
907         (onJavaScriptAlert):
908         (onJavaScriptConfirm):
909         (onJavaScriptPrompt):
910         (drtViewTiledAdd):
911         * DumpRenderTree/efl/DumpRenderTreeView.h: Added.
912
913 2011-06-27  Leandro Pereira  <leandro@profusion.mobi>
914
915         Reviewed by Kent Tamura.
916
917         [EFL] Add an EventSender implementation to EFL's DumpRenderTree along
918         with support files.
919         Build system changes will be made as soon as the whole DumpRenderTree
920         is upstreamed.
921         https://bugs.webkit.org/show_bug.cgi?id=61962
922
923         * DumpRenderTree/efl/EventSender.cpp: Added.
924         (setEvasModifiers):
925         (translateMouseButtonNumber):
926         (sendMouseEvent):
927         (sendClick):
928         (scheduleAsynchronousClickCallback):
929         (updateClickCount):
930         (modifierFromJSValue):
931         (modifiersFromJSValue):
932         (mouseDownCallback):
933         (mouseUpCallback):
934         (mouseMoveToCallback):
935         (evasMouseEventFromHorizontalAndVerticalOffsets):
936         (mouseScrollByCallback):
937         (continuousMouseScrollByCallback):
938         (keyPadNameFromJSValue):
939         (keyNameFromJSValue):
940         (keyDownCallback):
941         (scalePageByCallback):
942         (getClass):
943         (makeEventSender):
944         * DumpRenderTree/efl/EventSender.h: Added.
945
946 2011-06-27  Eric Seidel  <eric@webkit.org>
947
948         Reviewed by Adam Barth.
949
950         Remove evil uses of hasattr
951         https://bugs.webkit.org/show_bug.cgi?id=63430
952
953         For some reason these classes believe that they may be called with
954         various flavors of "option" elements and so carefully check to make
955         sure that the options element has their option before checking it.
956
957         We had a set_option_default method which was never called, so I made it
958         do what callsites seemed to want it to do and replaced 3 callers
959         who previously used hasattr manually to use set_option_default instead.
960
961         * Scripts/webkitpy/layout_tests/port/base.py:
962         * Scripts/webkitpy/layout_tests/port/webkit.py:
963
964 2011-06-27  Kent Tamura  <tkent@chromium.org>
965
966         Reviewed by Hajime Morita.
967
968         [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
969         https://bugs.webkit.org/show_bug.cgi?id=63427
970
971         ~WebViewHost() navigates to about:blank, so it calls some
972         callbacks and LayoutTestController functions.
973
974         * DumpRenderTree/chromium/TestShell.h:
975          Move m_printer upper and move m_webViewHost lower.
976
977 2011-06-27  Adam Barth  <abarth@webkit.org>
978
979         Reviewed by Eric Seidel.
980
981         Move server config files to webkitpy.layout_tests.servers
982         https://bugs.webkit.org/show_bug.cgi?id=63436
983
984         The config files belong with the servers.
985
986         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
987         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
988         * Scripts/webkitpy/layout_tests/servers/http_server.py:
989         * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
990         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
991
992 2011-06-27  Adam Barth  <abarth@webkit.org>
993
994         Reviewed by Eric Seidel.
995
996         Move websocket_server and http_server to webkitpy.layout_package.servers
997         https://bugs.webkit.org/show_bug.cgi?id=63434
998
999         These classes do not represent ports.  They represent servers.
1000
1001         * Scripts/new-run-webkit-httpd:
1002         * Scripts/new-run-webkit-websocketserver:
1003         * Scripts/webkitpy/layout_tests/port/base.py:
1004         * Scripts/webkitpy/layout_tests/port/chromium.py:
1005         * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
1006         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
1007         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1008         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1009         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
1010         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1011         * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
1012         * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
1013         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
1014         * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
1015
1016 2011-06-27  Eric Seidel  <eric@webkit.org>
1017
1018         Reviewed by Adam Barth.
1019
1020         Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
1021         https://bugs.webkit.org/show_bug.cgi?id=63428
1022
1023         * Scripts/webkitpy/layout_tests/port/chromium.py:
1024         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1025
1026 2011-06-27  Adam Barth  <abarth@webkit.org>
1027
1028         Reviewed by Eric Seidel.
1029
1030         Move apache_http_server.py to webkitpy.layout_package.servers
1031         https://bugs.webkit.org/show_bug.cgi?id=63433
1032
1033         The apache_http_server.py is a server, not a port.
1034
1035         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
1036         * Scripts/webkitpy/layout_tests/port/base.py:
1037         * Scripts/webkitpy/layout_tests/servers: Added.
1038         * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
1039         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
1040
1041 2011-06-27  Adam Barth  <abarth@webkit.org>
1042
1043         Reviewed by Eric Seidel.
1044
1045         Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
1046         https://bugs.webkit.org/show_bug.cgi?id=63432
1047
1048         This code isn't in the dependency cone of new-run-webkit-tests. It's
1049         unclear what it's final home should be, but this patch moves it out of
1050         layout_tests to simply the package.
1051
1052         * Scripts/rebaseline-chromium-webkit-tests:
1053         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
1054         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
1055         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
1056         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
1057
1058 2011-06-27  Adam Barth  <abarth@webkit.org>
1059
1060         Reviewed by Eric Seidel.
1061
1062         Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
1063         https://bugs.webkit.org/show_bug.cgi?id=63429
1064
1065         This package as nothing to do with the layout_tests package.
1066
1067         * Scripts/update-webgl-conformance-tests:
1068         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
1069         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
1070         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
1071         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
1072
1073 2011-06-27  Adam Barth  <abarth@webkit.org>
1074
1075         Reviewed by Eric Seidel.
1076
1077         Move deduplicate_tests.py into webkitpy.to_be_moved
1078         https://bugs.webkit.org/show_bug.cgi?id=63426
1079
1080         deduplicate_tests.py doesn't haven anything to do with layout tests.
1081         It's really a separate script.  This patch moves it to the (new)
1082         to_be_moved package so that it doesn't distract us when working on NRWT.
1083
1084         * Scripts/deduplicate-tests:
1085         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
1086         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
1087         * Scripts/webkitpy/test/main.py:
1088         * Scripts/webkitpy/to_be_moved: Added.
1089         * Scripts/webkitpy/to_be_moved/__init__.py: Added.
1090         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
1091         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
1092
1093 2011-06-26  Adam Barth  <abarth@webkit.org>
1094
1095         Rubber-stamped by Eric Seidel.
1096
1097         Remove empty directory.
1098
1099         * Scripts/webkitpy/layout_tests/test_types: Removed.
1100
1101 2011-06-25  Naoki Takano  <honten@chromium.org>
1102
1103         Reviewed by Eric Seidel.
1104
1105         Change my entry from contributors to committers.
1106         https://bugs.webkit.org/show_bug.cgi?id=63043
1107
1108         * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
1109
1110 2011-06-25  Adam Barth  <abarth@webkit.org>
1111
1112         Reviewed by Eric Seidel.
1113
1114         [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
1115         https://bugs.webkit.org/show_bug.cgi?id=63394
1116
1117         * DumpRenderTree/chromium/LayoutTestController.cpp:
1118         (LayoutTestController::queueLoad):
1119
1120 2011-06-25  Brent Fulgham  <bfulgham@webkit.org>
1121
1122         Unreviewed build correction after r89426.
1123
1124         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
1125           Link with Cairo DLL for new functionality.
1126         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
1127           code for snprintf.
1128
1129 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
1130
1131         Reviewed by Adam Barth.
1132
1133         run-bindings-tests does not work on Chromium Windows.
1134         https://bugs.webkit.org/show_bug.cgi?id=63382
1135
1136         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
1137
1138 2011-06-25  Dan Bernstein  <mitz@apple.com>
1139
1140         Try to fix the Qt and Chromium builds.
1141
1142         * DumpRenderTree/chromium/LayoutTestController.cpp:
1143         (LayoutTestController::setEncodedAudioData):
1144         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1145
1146 2011-06-24  Dan Bernstein  <mitz@apple.com>
1147
1148         Reviewed by Anders Carlsson.
1149
1150         Add an option to enable legacy rounding hacks
1151         https://bugs.webkit.org/show_bug.cgi?id=63363
1152
1153         Added layoutTestController.allowRoundingHacks() and implemented it
1154         on OS X.
1155
1156         * DumpRenderTree/LayoutTestController.cpp:
1157         (allowRoundingHacksCallback):
1158         (LayoutTestController::staticFunctions):
1159         * DumpRenderTree/LayoutTestController.h:
1160         * DumpRenderTree/chromium/LayoutTestController.cpp:
1161         (LayoutTestController::allowRoundingHacks):
1162         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1163         (LayoutTestController::allowRoundingHacks):
1164         * DumpRenderTree/mac/DumpRenderTree.mm:
1165         (resetWebViewToConsistentStateBeforeTesting):
1166         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1167         (LayoutTestController::allowRoundingHacks):
1168         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1169         (LayoutTestController::allowRoundingHacks):
1170         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1171         (LayoutTestController::allowRoundingHacks):
1172         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1173         (LayoutTestController::allowRoundingHacks):
1174
1175 2011-06-24  Adam Roben  <aroben@apple.com>
1176
1177         Include the directory containing the failing tests in titles of bugs filed from TestFailures
1178         when all the tests won't fit
1179
1180         Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
1181         which tests are failing
1182
1183         Reviewed by David Kilzer.
1184
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1186         (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
1187         that ends in a path separator.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1190         (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
1191         in the title, first try to include the longest common prefix of the test names, then, if
1192         that's still too long or there's no common prefix, fall back to not including any
1193         information about which tests are failing.
1194
1195 2011-06-24  Adam Roben  <aroben@apple.com>
1196
1197         Include links to Trac in bugs filed from TestFailures
1198
1199         Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
1200         Trac for suspect revisions
1201
1202         Reviewed by David Kilzer.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1205         (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
1206         Trac.
1207
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1209         (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
1210         include a link to Trac for it in the first sentence of the description. Otherwise include a
1211         link to the suspect range after the list of failing tests.
1212
1213 2011-06-24  Nat Duca  <nduca@chromium.org>
1214
1215         Unreviewed, rolling out r89694.
1216         http://trac.webkit.org/changeset/89694
1217         https://bugs.webkit.org/show_bug.cgi?id=58408
1218
1219         Test shell still not ready for animate changes.
1220
1221         * DumpRenderTree/chromium/WebViewHost.cpp:
1222         (WebViewHost::paintInvalidatedRegion):
1223
1224 2011-06-24  Adam Roben  <aroben@apple.com>
1225
1226         Fix typos introduced in r89696
1227
1228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1229         (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
1230         callback, since that's what it expects.
1231
1232 2011-06-24  Adam Roben  <aroben@apple.com>
1233
1234         Make TestFailures correctly remember whether old-run-webkit-tests exited early
1235
1236         Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
1237         completion after reload
1238
1239         Reviewed by David Kilzer.
1240
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1242         (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
1243         in the PeristentCache, store an object that contains both the number of failures and whether
1244         old-run-webkit-tests exited early.
1245
1246 2011-06-24  Adam Roben  <aroben@apple.com>
1247
1248         Add links to regression ranges in Trac to the TestFailures page
1249
1250         Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
1251         links to regression ranges in Trac
1252
1253         Reviewed by David Kilzer.
1254
1255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
1256         (Trac): This new class represents a particular instance of Trac for a single project.
1257         (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
1258         repository path between the two specified revisions
1259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1260         (ViewController): Added new trac argument.
1261         (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
1262         passed/failed builds from here...
1263         (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
1264         Trac if there are multiple suspect revisions.
1265
1266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1267         Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
1268
1269 2011-05-17  Nat Duca  <nduca@chromium.org>
1270
1271         Reviewed by James Robinson.
1272
1273         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
1274         https://bugs.webkit.org/show_bug.cgi?id=58408
1275
1276         * DumpRenderTree/chromium/WebViewHost.cpp:
1277         (WebViewHost::paintInvalidatedRegion):
1278
1279 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
1280
1281         Reviewed by Dimitri Glazkov.
1282
1283         Convert shadow DOM-related tests to use window.internals
1284         https://bugs.webkit.org/show_bug.cgi?id=61671
1285
1286         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
1287         removeShadowRoot from layoutTestController; these have been
1288         replaced by equivalents in window.internals instead.
1289
1290         * DumpRenderTree/LayoutTestController.cpp:
1291         (LayoutTestController::staticFunctions):
1292         * DumpRenderTree/LayoutTestController.h:
1293         * DumpRenderTree/chromium/LayoutTestController.cpp:
1294         (LayoutTestController::LayoutTestController):
1295         * DumpRenderTree/chromium/LayoutTestController.h:
1296         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1297         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1298         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1299         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1300         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1301         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1302         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1303         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1304         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1305
1306 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
1307
1308         Reviewed by Dirk Schulze.
1309
1310         Make run-bindings-tests remove its temporary directories.
1311         https://bugs.webkit.org/show_bug.cgi?id=63320
1312
1313         * Scripts/run-bindings-tests:
1314
1315 2011-06-23  MORITA Hajime  <morrita@google.com>
1316
1317         Reviewed by Kent Tamura.
1318
1319         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
1320         https://bugs.webkit.org/show_bug.cgi?id=63216
1321
1322         Deleted m_webViewHost which looks leaked.
1323         
1324         * DumpRenderTree/chromium/TestShell.h:
1325         * DumpRenderTree/chromium/TestShell.cpp:
1326         (TestShell::~TestShell):
1327
1328 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1329
1330         Unreviewed. Fix WebKit2 GTK build.
1331
1332         * WebKitTestRunner/GNUmakefile.am:
1333
1334 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
1335
1336         Unreviewed, add myself as committer.
1337
1338         * Scripts/webkitpy/common/config/committers.py:
1339
1340 2011-06-23  Nat Duca  <nduca@chromium.org>
1341
1342         Unreviewed, add myself as committer.
1343
1344         * Scripts/webkitpy/common/config/committers.py:
1345
1346 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1347
1348         Reviewed by Tony Chang.
1349
1350         nrwt: move http locking code into manager
1351         https://bugs.webkit.org/show_bug.cgi?id=63103
1352
1353         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1354         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1355
1356 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
1357
1358         Reviewed by James Robinson.
1359
1360         [chromium] Add support for running layout tests with accelerated rendering
1361         https://bugs.webkit.org/show_bug.cgi?id=63274
1362
1363         * Scripts/webkitpy/layout_tests/port/chromium.py:
1364         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1365
1366 2011-06-23  Adam Roben  <aroben@apple.com>
1367
1368         Avoid fetching JSON data when possible on TestFailures page to determine if
1369         old-run-webkit-tests exited early
1370
1371         As of r89610, results.html includes information about whether old-run-webkit-tests exited
1372         early, so we don't need to look at JSON data to get this information for builds newer than
1373         that.
1374
1375         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
1376         which is slow and limits history to the last build master restart
1377
1378         Reviewed by David Kilzer.
1379
1380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1381         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
1382         function. If we're dealing with a build that has early-exit information in results.html,
1383         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
1384         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
1385         (as before).
1386
1387 2011-06-23  Eric Seidel  <eric@webkit.org>
1388
1389         Reviewed by Adam Barth.
1390
1391         sheriffbot can no longer restart
1392         https://bugs.webkit.org/show_bug.cgi?id=63221
1393
1394         Fixed and unit tested.
1395
1396         * Scripts/webkitpy/tool/bot/queueengine.py:
1397         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1398         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1399
1400 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
1401
1402         Reviewed by Xan Lopez.
1403
1404         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
1405         https://bugs.webkit.org/show_bug.cgi?id=63287
1406
1407         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
1408         so that the plugin loads properly.
1409
1410         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
1411         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1412         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
1413         of the work for getting an environment variable and converting it to UTF-8.
1414         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
1415         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
1416
1417 2011-06-23  Adam Roben  <aroben@apple.com>
1418
1419         Record whether old-run-webkit-tests aborted early in results.html
1420
1421         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
1422         old-run-webkit-tests stopped running tests early
1423
1424         Reviewed by David Kilzer.
1425
1426         * Scripts/old-run-webkit-tests:
1427         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
1428         Added a <style> element with some styles for the new message. If we stopped running early,
1429         put the reason why at the top of results.html.
1430         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
1431         $stoppedRunningEarlyMessage global.
1432
1433 2011-06-23  Adam Roben  <aroben@apple.com>
1434
1435         Cache some of the TestFailures page's data in localStorage
1436
1437         This makes reloading TestFailures much faster. Right now we only store the number of failing
1438         tests and the list of failing tests for each build. We may choose to store more later, but
1439         it's easy to run up against quota limits.
1440
1441         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
1442         APIs (or similar) to improve loading performance
1443
1444         Reviewed by David Kilzer.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1447         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
1448         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
1449         fetching data to the callback.
1450         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
1451         store the tests in the cache just before calling the callback. (The previous code in this
1452         function relied on being able to modify the tests object after storing it in the cache and
1453         having the cached version be updated. This worked while it was a non-serialized cache, but
1454         PersistentCache uses serialization.)
1455
1456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
1457         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
1458         values, and stores the date that each value was initially stored along with it. This is
1459         later used for pruning the cache.
1460         (PersistentCache.contains): Checks whether the key exists in localStorage.
1461         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
1462         value out of it.
1463         (PersistentCache.set): Serialize the value, add the date to it, and store it in
1464         localStorage. If this fails due to quota limits, empty the whole cache and try again.
1465         (PersistentCache.prune): Delete any cached data that is deemed old enough.
1466         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
1467         (PersistentCache._emptyCache): Delete everything from localStorage.
1468         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
1469         return them.
1470
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1472         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
1473         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
1474         where we'd never show the new bug link for tests for which we couldn't determine a passing
1475         revision.
1476
1477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1478         PersistentCache.js.
1479
1480 2011-06-23  Adam Roben  <aroben@apple.com>
1481
1482         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
1483
1484         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
1485         contain titles that are so long they are rejected by Bugzilla
1486
1487         Reviewed by David Kilzer.
1488
1489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1490         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
1491         using a query string on the URL. If the search query is very long, using a query string can
1492         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
1493         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
1494
1495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1496         (.new-bug-form): Hide the form that we secretly use to file a new bug.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1499         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
1500         query parameters to the URL. Otherwise, send them as the body of the request along with the
1501         appropriate headers.
1502         (getResource): Now just calls through to fetchResource.
1503         (urlEncodedQueryParameters): Added. Moved some code here...
1504         (addQueryParametersToURL): ...from here.
1505
1506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1507         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
1508         number of failing tests if mentioning all the tests would make the title too long. Improved
1509         the description for large numbers of failures by listing the tests one-per-line instead of
1510         just having them be comma-separated, which was hard to read. Use a form to file the new bug
1511         instead of a link so that we can POST the form data. (Using a URL with a query string can
1512         result in the URL being too long.) The new bug link now just submits the form.
1513
1514 2011-06-23  Adam Roben  <aroben@apple.com>
1515
1516         Show closed bugs on the TestFailures page in addition to open ones
1517
1518         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
1519
1520         Reviewed by David Kilzer.
1521
1522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1523         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
1524         returned data.
1525         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
1526         the associated bug is still open.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1529         (addQueryParametersToURL): Add a missing semicolon.
1530         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
1531         object and appends each of the values stored within.
1532
1533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1534         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
1535         bugs will be included in the results. Split the returned bugs into two sets: those which are
1536         open, and those which are closed. Put the open bugs at the top level of the list, and the
1537         closed bugs in a second level.
1538
1539 2011-06-23  Adam Roben  <aroben@apple.com>
1540
1541         Don't count new tests as failures on the TestFailures page
1542
1543         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
1544         they aren't
1545
1546         Reviewed by Anders Carlsson.
1547
1548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1549         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
1550         of failures.
1551
1552 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1553
1554         Reviewed by Eric Seidel.
1555
1556         nrwt: make TestInput objects printable
1557         https://bugs.webkit.org/show_bug.cgi?id=63225
1558
1559         This makes debugging slighlty easier.
1560
1561         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1562
1563 2011-06-22  Daniel Bates  <dbates@webkit.org>
1564
1565         Reviewed by Adam Barth.
1566
1567         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
1568         https://bugs.webkit.org/show_bug.cgi?id=62943
1569
1570         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
1571         by Scripts/webkitpy/common/checkout/__init__.py.
1572
1573         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1574
1575 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
1576
1577         Reviewed by Mark Rowe.
1578
1579         Add window.internals to WebKit2's WebKitTestRunner.
1580         https://bugs.webkit.org/show_bug.cgi?id=61073
1581
1582         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
1583         * WebKitTestRunner/Configurations/Base.xcconfig:
1584         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1585         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1586         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1587         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1588         (WTR::InjectedBundlePage::didClearWindowForFrame):
1589         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1590         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1591
1592 2011-06-22  Eric Seidel  <eric@webkit.org>
1593
1594         Reviewed by Adam Barth.
1595
1596         Make sheriff-bot rollout messages a little nicer
1597         https://bugs.webkit.org/show_bug.cgi?id=63107
1598
1599         itertools.chain.from_iterable is new in 2.6,
1600         use itertools.chain(*list) for 2.5 compat.
1601
1602         * Scripts/webkitpy/tool/bot/irc_command.py:
1603
1604 2011-06-22  Eric Seidel  <eric@webkit.org>
1605
1606         Reviewed by Adam Barth.
1607
1608         Make sheriff-bot robust against exceptions from commands
1609         https://bugs.webkit.org/show_bug.cgi?id=63211
1610
1611         sheriff-bot was acting strange this afternoon.
1612         We don't know if this will fix the cause, but
1613         at least it adds some unit tests and catches
1614         one possible cause.
1615
1616         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1617         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1618
1619 2011-06-22  Mark Rowe  <mrowe@apple.com>
1620
1621         Reviewed by David Levin.
1622
1623         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
1624
1625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
1626         be relative to the built products directory rather than using a hard-coded path. Remove the
1627         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
1628         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
1629         rather than in the .xcodeproj directly.
1630
1631 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1632
1633         Reviewed by Ojan Vafai.
1634
1635         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
1636         https://bugs.webkit.org/show_bug.cgi?id=59993
1637
1638         * Scripts/webkitpy/layout_tests/port/base.py:
1639         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1640         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1641         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1642         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1643         * Scripts/webkitpy/layout_tests/port/gtk.py:
1644         * Scripts/webkitpy/layout_tests/port/mac.py:
1645         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1646         * Scripts/webkitpy/layout_tests/port/qt.py:
1647         * Scripts/webkitpy/layout_tests/port/win.py:
1648
1649 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
1650
1651         Reviewed by Andreas Kling.
1652
1653         Move macpherson from contributor list to committer list.
1654         https://bugs.webkit.org/show_bug.cgi?id=63179
1655
1656         * Scripts/webkitpy/common/config/committers.py:
1657         Move macpherson from contributor list to committer list.
1658
1659 2011-06-22  David Levin  <levin@chromium.org>
1660
1661         Reviewed by Adam Barth.
1662
1663         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
1664         https://bugs.webkit.org/show_bug.cgi?id=63204
1665
1666         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
1667           with similar code for the parameter checking.
1668         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
1669           those done for single lines since they don't make sense in that case (variable decls look like function decls).
1670           Removed some redundant comments (one of which was slightly wrong).
1671           Added checks for the new functionality and minor other test changes.
1672
1673 2011-06-22  Nate Chapin  <japhet@chromium.org>
1674
1675         Reviewed by Adam Barth.
1676
1677         Add libsoup to libWebCoreInternals build.
1678         https://bugs.webkit.org/show_bug.cgi?id=62066
1679
1680         * GNUmakefile.am:
1681
1682 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1683
1684         Reviewed by Tony Chang.
1685
1686         nrwt: handle missing httpd cleanly
1687         https://bugs.webkit.org/show_bug.cgi?id=62027
1688
1689         We had reverted the change in r89414, so this adds it back in
1690         (modifying check_sys_deps() in port/base.py to check for an
1691         installed web server).
1692
1693         This change then fixes the change in r89414 to stub out the
1694         check_sys_deps() in the test port so that the unit tests run correctly.
1695
1696         * Scripts/webkitpy/layout_tests/port/base.py:
1697         * Scripts/webkitpy/layout_tests/port/test.py:
1698
1699 2011-06-22  David Levin  <levin@chromium.org>
1700
1701         Reviewed by Adam Barth.
1702
1703         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
1704         https://bugs.webkit.org/show_bug.cgi?id=63188
1705
1706         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
1707         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1708
1709 2011-06-22  Tony Chang  <tony@chromium.org>
1710
1711         Reviewed by Ojan Vafai.
1712
1713         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
1714         https://bugs.webkit.org/show_bug.cgi?id=62891
1715
1716         * BuildSlaveSupport/build.webkit.org-config/config.json:
1717
1718 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1719
1720         Reviewed by Ojan Vafai.
1721
1722         nrwt: don't look for http lock when running the test port
1723         https://bugs.webkit.org/show_bug.cgi?id=63158
1724
1725         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1726         * Scripts/webkitpy/layout_tests/port/test.py:
1727
1728 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
1729
1730         Reviewed by Andreas Kling.
1731
1732         [Qt][WK2] Set up plugin tests
1733         https://bugs.webkit.org/show_bug.cgi?id=63066
1734
1735         * WebKitTestRunner/qt/TestControllerQt.cpp:
1736         (WTR::TestController::initializeTestPluginDirectory):
1737         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
1738         of the test plugin like DRT does.
1739
1740 2011-06-22  Eric Seidel  <eric@webkit.org>
1741
1742         Reviewed by Ojan Vafai.
1743
1744         Make sheriff-bot rollout messages a little nicer
1745         https://bugs.webkit.org/show_bug.cgi?id=63107
1746
1747         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
1748         into urls myself.  So I have now fixed its "preparing" message to include a url.
1749
1750         I also figured that I should make the messages mention all of the responsible parties
1751         so that rollouts are never surprises.  If you're in the channel and were involved
1752         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
1753
1754         As part of doing this I also changed (and tested) _parse_args to fail-fast
1755         when given invalid args.
1756
1757         * Scripts/webkitpy/tool/bot/irc_command.py:
1758         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1759         * Scripts/webkitpy/tool/bot/sheriff.py:
1760         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1761
1762 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1763
1764         Reviewed by Tony Chang.
1765
1766         run-webkit-websocketserver fails to stop websocket server
1767         https://bugs.webkit.org/show_bug.cgi?id=63123
1768
1769         There's a ten-character change in new-run-webkit-websocketserver
1770         that fixes the actual bug, and then we update the code in
1771         new-run-webkit-httpd to do the actual stop call, and add more tests
1772         (refactoring the existing test code so that it is shared).
1773
1774         * Scripts/new-run-webkit-httpd:
1775         * Scripts/new-run-webkit-websocketserver:
1776         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
1777
1778 2011-06-22  Adam Roben  <aroben@apple.com>
1779
1780         Add links to existing bugs related to failing tests on TestFailures page
1781
1782         I changed the layout of the page a little to make it easier to read with all the new
1783         information. Passing/failing revisions have been moved down below the list of tests to be
1784         closer to the existing bugs and the new bug link. And each set of tests and its relevant
1785         information is in a light gray box.
1786
1787         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
1788         possible
1789
1790         Reviewed by Darin Adler.
1791
1792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
1793         (Bugzilla): This new class represents a single Bugzilla instance.
1794         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
1795         passing the resulting bug titles and URLs to the callback when complete. If called multiple
1796         times with the same query before the query returns, caches the callbacks so that only one
1797         query is sent over the wire. When the query completes, all pending callbacks are called.
1798
1799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1800         (#failure-history): Reduce the margin/padding on the top-level list a bit.
1801         (#failure-history > li): Put each set of tests in a gray box, and indent most information
1802         inside the box.
1803         (.test-list): Unindent the list of failing tests so it is visually at the top level.
1804         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
1805         each box isn't a big empty space.
1806         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
1807         quite long.
1808
1809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1810         (addQueryParametersToURL): New function extracted from
1811         ViewController.prototype._domForNewAndExistingBugs.
1812
1813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1814         (ViewController): Take and store an optional Bugzilla instance.
1815         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
1816         purposes and move the list of failing tests above all other information. Only show bug
1817         information once we've determined the most-recent passing revision for a set of tests. It's
1818         not that useful to file a new bug before this information has been determined, and searching
1819         for existing bugs before we've figured out which tests started failing at the same time
1820         would end up giving you information about a bunch of unrelated tests.
1821         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
1822         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
1823         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
1824         failing tests, and adds links to the bugs when the search completes.
1825
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
1827         Bugzilla instance for bugs.webkit.org to the ViewController.
1828
1829 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         Reviewed by Martin Robinson.
1832
1833         [GTK] Apply current view settings to newly created views in GtkLauncher
1834         https://bugs.webkit.org/show_bug.cgi?id=63142
1835
1836         * GtkLauncher/main.c:
1837         (createWebViewCb):
1838
1839 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1840
1841         Reviewed by Martin Robinson.
1842
1843         [GTK] Use GOption to parse main arguments in GtkLauncher
1844         https://bugs.webkit.org/show_bug.cgi?id=63060
1845
1846         Instead of getting the settings from the view, create a new
1847         settings object not associated with any view so that we can parse
1848         the command line arguments before creating the view. It will also
1849         allows to use the same settings for more than one view if we
1850         eventually support passing more than one uri from the command
1851         line.
1852
1853         * GtkLauncher/main.c:
1854         (parseOptionEntryCallback): Make this function static. Also use
1855         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
1856         of atoi/atof to provide better error messages. And always fill the
1857         error struct when the function fails.
1858         (getOptionEntriesFromWebKitWebSettings): Use an array of
1859         GOptionEntry structs instead of a GArray, since that is what
1860         g_option_group_add_entries() expects and the array size doesn't
1861         change.
1862         (addWebSettingsGroupToContext): Helper function to add the
1863         websettings group to the option context.
1864         (main): Create the option context to parse command line arguments.
1865
1866 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
1867
1868         Reviewed by Adam Roben.
1869
1870         [GTK] Implement pixel dump support for WebKitTestRunner
1871         https://bugs.webkit.org/show_bug.cgi?id=58242
1872
1873         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
1874         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
1875         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
1876         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
1877         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
1878         file so that we can share it across platforms.
1879         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
1880         * WebKitTestRunner/TestInvocation.h: Updated method list.
1881         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
1882         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1883         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
1884
1885 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
1886
1887         Unreviewed, rolling out r89414.
1888         http://trac.webkit.org/changeset/89414
1889         https://bugs.webkit.org/show_bug.cgi?id=63130
1890
1891         It broke webkitpy tests (Requested by Ossy on #webkit).
1892
1893         * Scripts/webkitpy/layout_tests/port/base.py:
1894
1895 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1896
1897         Reviewed by Dirk Pranke.
1898
1899         [NRWT] Print error message when there is no httpd present on the system
1900         https://bugs.webkit.org/show_bug.cgi?id=62027
1901
1902         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1903
1904 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
1905
1906         Unreviewed, build fix.
1907         Fix crashes in new-run-webkit-tests resulting from the
1908         change to the http_server logic in r89400. Python 2.5
1909         on Mac 10.5 has some weird error paths.
1910
1911         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1912         * Scripts/webkitpy/common/system/executive.py:
1913
1914 2011-06-21  MORITA Hajime  <morrita@google.com>
1915
1916         Unreviewed, rolling out r89401 and r89403.
1917         http://trac.webkit.org/changeset/89401
1918         http://trac.webkit.org/changeset/89403
1919         https://bugs.webkit.org/show_bug.cgi?id=62970
1920
1921         Breaks mac build and mistakenly enables the spellcheck API
1922
1923         * Scripts/build-webkit:
1924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1925
1926 2011-06-21  Kent Tamura  <tkent@chromium.org>
1927
1928         [Mac] Sort Xcode project files.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1931
1932 2011-06-20  MORITA Hajime  <morrita@google.com>
1933
1934         Reviewed by Kent Tamura.
1935
1936         Spellcheck API should be build-able.
1937         https://bugs.webkit.org/show_bug.cgi?id=62970
1938
1939         * Scripts/build-webkit:
1940
1941 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
1942
1943         Reviewed by Tony Chang.
1944
1945         nrwt: attempt #3 at fixing server startup/shutdown
1946         https://bugs.webkit.org/show_bug.cgi?id=62829
1947
1948         Attempt yet again to make starting and stopping servers
1949         reliable. It turns out that apache has races between when the
1950         ctl process exists and when it writes/removes the pid file.
1951         This change accounts for the races.
1952
1953         * Scripts/new-run-webkit-httpd:
1954         * Scripts/webkitpy/common/system/executive.py:
1955         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1956         * Scripts/webkitpy/layout_tests/port/base.py:
1957         * Scripts/webkitpy/layout_tests/port/http_server.py:
1958         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1959         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1960         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1961         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1962
1963 2011-06-21  Dmitry Lomov  <dslomov@google.com>
1964
1965         Reviewed by Adam Roben.
1966
1967         https://bugs.webkit.org/show_bug.cgi?id=63080
1968         Unit-tests step on test-only bot is broken.
1969         Removing the step until run-api-tests is fixed.
1970
1971         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1972
1973 2011-06-20  Dmitry Lomov  <dslomov@google.com>
1974
1975         Reviewed by David Levin.
1976
1977         https://bugs.webkit.org/show_bug.cgi?id=63017
1978         "Unit tests" step on bots should provide more information in case of failure.
1979
1980         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
1981
1982 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1983
1984         Reviewed by Ojan Vafai.
1985
1986         new-run-webkit-tests: order shards by name, not number of tests
1987         https://bugs.webkit.org/show_bug.cgi?id=62753
1988
1989         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1990
1991 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1992
1993         Reviewed by Ojan Vafai.
1994
1995         we should only log the test names to the tests_run.txt files during layout_tests
1996         https://bugs.webkit.org/show_bug.cgi?id=62751
1997
1998         * Scripts/old-run-webkit-tests:
1999         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2000
2001 2011-06-20  Eric Seidel  <eric@webkit.org>
2002
2003         Reviewed by Adam Barth.
2004
2005         commit-queue/ews-bots should run run-bindings-tests for every patch
2006         https://bugs.webkit.org/show_bug.cgi?id=63010
2007
2008         * Scripts/webkitpy/common/config/ports.py:
2009         * Scripts/webkitpy/tool/commands/download_unittest.py:
2010         * Scripts/webkitpy/tool/steps/runtests.py:
2011         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2012         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2013
2014 2011-06-20  Chang Shu  <cshu@webkit.org>
2015
2016         Reviewed by Adam Barth.
2017
2018         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
2019         https://bugs.webkit.org/show_bug.cgi?id=53676
2020
2021         * WebKitTestRunner/TestController.cpp:
2022         (WTR::TestController::initialize):
2023
2024 2011-06-20  Eric Seidel  <eric@webkit.org>
2025
2026         Reviewed by Adam Barth.
2027
2028         buildbots should run run-bindings-tests
2029         https://bugs.webkit.org/show_bug.cgi?id=63001
2030
2031         run-bindings-tests takes 2.4 seconds on my machine, so
2032         I expect this will not be noticeable on the bots.
2033
2034         I also removed tiger-specific checks since Tiger is no
2035         longer a supported platform for webkit.
2036
2037         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2038
2039 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2040
2041         Unreviewed. Fix WebKit2 GTK build after r89249.
2042
2043         * GtkLauncher/main.c:
2044         (main):
2045
2046 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
2047
2048         Reviewed by Yury Semikhatsky.
2049
2050         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
2051         https://bugs.webkit.org/show_bug.cgi?id=62994
2052
2053         * DumpRenderTree/LayoutTestController.cpp:
2054         (closeWebInspectorCallback):
2055         (LayoutTestController::staticFunctions):
2056         * DumpRenderTree/LayoutTestController.h:
2057         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2058         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2059         * DumpRenderTree/chromium/LayoutTestController.cpp:
2060         (LayoutTestController::LayoutTestController):
2061         * DumpRenderTree/chromium/LayoutTestController.h:
2062         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2063         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2064         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2065         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2066         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2067         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2068         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2069         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2070         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2071
2072 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
2073
2074         Reviewed by Martin Robinson.
2075
2076         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
2077         https://bugs.webkit.org/show_bug.cgi?id=55308
2078
2079         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
2080         (parseOptionEntryCallback): Callback for parsing option entry.
2081         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
2082         list of option entries.
2083         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
2084         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
2085         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
2086         (parseAdditionalOptions): Help function parsing additional commandline options.
2087         (main): Added call to parseAdditionalOptions.
2088
2089 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2090
2091         Reviewed by Andreas Kling.
2092
2093         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
2094         https://bugs.webkit.org/show_bug.cgi?id=62869
2095
2096         Add QFont include to fix "incomlete type QFont" error.
2097
2098         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2099
2100 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
2101
2102         Reviewed by Martin Robinson.
2103
2104         [GTK] Enable Media Stream feature and make it default on
2105         https://bugs.webkit.org/show_bug.cgi?id=60394
2106
2107         * Scripts/build-webkit:
2108
2109 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2110
2111         Unreviewed, rolling out r89198.
2112         http://trac.webkit.org/changeset/89198
2113         https://bugs.webkit.org/show_bug.cgi?id=62953
2114
2115         Chromium breakage on "Linux Tests" (Requested by senorblanco
2116         on #webkit).
2117
2118         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2119         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2120         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2121
2122 2011-06-18  Daniel Bates  <dbates@webkit.org>
2123
2124         Reviewed by Eric Seidel.
2125
2126         Git.push_local_commits_to_server() should use passed username and
2127         password when we don't have cached credentials
2128         https://bugs.webkit.org/show_bug.cgi?id=62941
2129
2130         Fixes a issue where Git.push_local_commits_to_server() would always look
2131         for cached credentials regardless of whether a username and password
2132         were passed as arguments. Instead, if given both a username and password
2133         then we shouldn't look for cached credentials (since we were explicitly given
2134         credentials).
2135
2136         * Scripts/webkitpy/common/checkout/scm/git.py:
2137         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
2138
2139 2011-06-18  Daniel Bates  <dbates@rim.com>
2140
2141         Rubber-stamped by Eric Seidel.
2142
2143         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2144         https://bugs.webkit.org/show_bug.cgi?id=62767
2145
2146         Part 3 of 3
2147
2148         Remove the command-line option --skip-build now that the master BuildBot has been restarted
2149         following <http://trac.webkit.org/changeset/89138>.
2150
2151         Instead, specify --no-build to get analogous functionality.
2152
2153         * Scripts/run-javascriptcore-tests:
2154
2155 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
2156
2157         Reviewed by Tony Chang.
2158
2159         new-run-webkit-tests: fix test sorting
2160         https://bugs.webkit.org/show_bug.cgi?id=58691
2161
2162         This changes the sorting to use a "natural" sort order such that
2163         foo2.html sorts before foo13.html, and sorts the tests so
2164         that all the tests in a directory are run before any test in a
2165         subdirectory.
2166
2167         This change also adds a split() method to the filesystem since
2168         that is needed to cluster files into a directory otherwise.
2169
2170         * Scripts/webkitpy/common/system/filesystem.py:
2171         * Scripts/webkitpy/common/system/filesystem_mock.py:
2172         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2173         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
2174
2175 2011-06-18  Evan Martin  <evan@chromium.org>
2176
2177         Reviewed by Darin Adler.
2178
2179         Compiler warning in double->int conversion in TestNetscapePlugIn
2180         https://bugs.webkit.org/show_bug.cgi?id=51554
2181
2182         This code is providing a JS API for removing a property by numeric ID.
2183         We get it from JS as a double, and must convert it to an int before using it.
2184
2185         Test: LayoutTests/plugins/npruntime/remove-property.html
2186
2187         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
2188         (NPRuntimeRemoveProperty::TestObject::invoke):
2189
2190 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
2191
2192         Reviewed by Eric Seidel.
2193
2194         Don't exit webkit-patch when running on Win32 python
2195         https://bugs.webkit.org/show_bug.cgi?id=55811
2196
2197         Most of the basic actions work in the meantime,
2198         so let people play with in on Win32 now.
2199
2200         * Scripts/webkit-patch:
2201
2202 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
2203
2204         Reviewed by Ojan Vafai.
2205
2206         Convert json_results_generator.py to output version 4 JSON.
2207         https://bugs.webkit.org/show_bug.cgi?id=60869
2208
2209         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2210         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2211         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2212
2213 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
2214
2215         Reviewed by Eric Seidel.
2216
2217         Some names with spaces are incorrectly reported as not containing spaces
2218         while running prepare-ChangeLog
2219         https://bugs.webkit.org/show_bug.cgi?id=55572
2220
2221         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
2222           non-alphanumeric characters in names.
2223
2224 2011-06-18  Michael Saboff  <msaboff@apple.com>
2225
2226         Reviewed by Eric Seidel.
2227
2228         Enhancement: New Script to Format malloc_history output as tree
2229         https://bugs.webkit.org/show_bug.cgi?id=56378
2230
2231         New script to process malloc_history output to tree format.
2232
2233         * Scripts/malloc-tree: Added.
2234
2235 2011-06-17  Dmitry Lomov  <dslomov@google.com>
2236
2237         Reviewed by Daniel Bates.
2238
2239         https://bugs.webkit.org/show_bug.cgi?id=62918 
2240         Pass configuration to UnitTests step in master.cfg
2241
2242         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2243
2244 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
2245
2246         Reviewed by Eric Seidel.
2247
2248         [EFL] Add Evas-based ImageDiff implementation.
2249         https://bugs.webkit.org/show_bug.cgi?id=61942
2250
2251         Build system changes will be performed as soon as the complete
2252         DumpRenderTree implementation is upstreamed.
2253
2254         * DumpRenderTree/efl/ImageDiff.cpp: Added.
2255         (pixelFromImageData):
2256         (differenceImageFromDifferenceBuffer):
2257         (computeDistanceBetweenPixelComponents):
2258         (calculatePixelDifference):
2259         (calculateDifference):
2260         (getTemporaryFile):
2261         (printImage):
2262         (printImageDifferences):
2263         (resizeEcoreEvasIfNeeded):
2264         (readImageFromStdin):
2265         (parseCommandLineOptions):
2266         (shutdownEfl):
2267         (abortWithErrorMessage):
2268         (initEfl):
2269         (main):
2270
2271 2011-06-17  Tony Chang  <tony@chromium.org>
2272
2273         Reviewed by Dirk Pranke.
2274
2275         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
2276         https://bugs.webkit.org/show_bug.cgi?id=62907
2277
2278         This fixes a bug where the ImageDiff on the user's machine doesn't
2279         match the logic used on the Chromium buildbots.  This has the downside
2280         of requiring that the Chromium ImageDiff is built, but it turns out
2281         that even with --tolerance 0, the CG ImageDiff will allow small pixel
2282         differences through.
2283
2284         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2285
2286 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2287
2288         [WinCairo] Unreviewed build correction.
2289
2290         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
2291         Update WinCairo property sheet to link against the Cairo DLL,
2292         now that we are using a more recent Cairo build. 
2293
2294 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2295
2296         Reviewed by Brian Weinstein.
2297
2298         Create a simple example of using the COM-based C++ listeners.
2299         A new onclick event is attached (via C++) to the WebKit logo
2300         in the default test pattern displayed on startup.  Clicking on
2301         the logo causes a message box to be displayed.
2302         https://bugs.webkit.org/show_bug.cgi?id=61885
2303
2304         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
2305           the WebScriptObject and DOMEventListener.
2306         * WinLauncher/WinLauncher.cpp:
2307         (SimpleEventListener::SimpleEventListener): Example implementation
2308           of a simple DOM event listener.
2309         (SimpleEventListener::handleEvent): 
2310         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
2311          to bind a C++ method to the 'onclick' event for the WebKit logo.
2312         (_tWinMain):
2313         * WinLauncher/WinLauncher.h:
2314         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
2315
2316 2011-06-17  Chang Shu  <cshu@webkit.org>
2317
2318         Reviewed by Andreas Kling.
2319
2320         [Qt] [WK2] Support undo/redo in MiniBrowser
2321         https://bugs.webkit.org/show_bug.cgi?id=62809
2322
2323         * MiniBrowser/qt/BrowserWindow.cpp:
2324         (BrowserWindow::BrowserWindow):
2325
2326 2011-06-17  Daniel Bates  <dbates@rim.com>
2327
2328         Rubber-stamped by Eric Seidel.
2329
2330         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2331         https://bugs.webkit.org/show_bug.cgi?id=62767
2332
2333         Part 2 of 3
2334
2335         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
2336         command line option instead of --skip-build.
2337
2338         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
2339         master buildbot picks up the change.
2340
2341         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2342
2343 2011-06-17  Daniel Bates  <dbates@rim.com>
2344
2345         Rubber-stamped by Eric Seidel.
2346
2347         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2348         https://bugs.webkit.org/show_bug.cgi?id=62767
2349
2350         Part 1 of 3
2351
2352         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
2353         run-javascriptcore-tests. Also, add a remark about these options to the usage message
2354         printed by run-javascriptcore-tests.
2355
2356         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
2357
2358         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
2359           of $showHelp.
2360
2361 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
2362
2363         Reviewed by Martin Robinson.
2364
2365         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
2366         https://bugs.webkit.org/show_bug.cgi?id=60687
2367
2368         Replace GdkRectangle by cairo_rectangle_int_t.
2369
2370         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
2371         (createBitmapContextFromWebView):
2372         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
2373         (firstRectForCharacterRangeCallback):
2374
2375 2011-06-16  Dmitry Lomov  <dslomov@google.com>
2376
2377         Reviewed by David Levin.
2378
2379         https://bugs.webkit.org/show_bug.cgi?id=62603
2380         Run run-api-tests on bots in debug mode.
2381         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
2382
2383         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2384
2385 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
2386
2387         Reviewed by Eric Seidel.
2388
2389         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
2390         WorkQueueItem.
2391         They will be plugged into the build system once the EFL's DRT is
2392         fully upstreamed.
2393         https://bugs.webkit.org/show_bug.cgi?id=61958
2394
2395         * DumpRenderTree/efl: Added.
2396         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
2397         (GCController::collect):
2398         (GCController::collectOnAlternateThread):
2399         (GCController::getJSObjectCount):
2400         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
2401         (createBitmapContextFromWebView):
2402         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
2403         (LoadItem::invoke):
2404         (LoadHTMLStringItem::invoke):
2405         (ReloadItem::invoke):
2406         (ScriptItem::invoke):
2407         (BackForwardItem::invoke):
2408         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
2409         (WorkQueueItem::~WorkQueueItem):
2410         (LoadItem::LoadItem):
2411         (LoadHTMLStringItem::LoadHTMLStringItem):
2412         (ScriptItem::ScriptItem):
2413         (LoadingScriptItem::LoadingScriptItem):
2414         (LoadingScriptItem::invoke):
2415         (NonLoadingScriptItem::NonLoadingScriptItem):
2416         (NonLoadingScriptItem::invoke):
2417         (BackForwardItem::BackForwardItem):
2418         (BackItem::BackItem):
2419         (ForwardItem::ForwardItem):
2420
2421 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2422
2423         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
2424         preference like the perl scripts do.
2425
2426         * waf/build/build_utils.py:
2427         * waf/build/settings.py:
2428
2429 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
2430
2431         Reviewed by Tony Gentilcore.
2432
2433         MediaStream API: Runtime enabled features
2434         https://bugs.webkit.org/show_bug.cgi?id=62798
2435
2436         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
2437
2438         * DumpRenderTree/chromium/TestShell.cpp:
2439         (TestShell::TestShell):
2440
2441 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
2442
2443         Reviewed by Eric Seidel.
2444
2445         Add support for sys.platform == 'linux3' by relaxing
2446         conditional statements and/or extending lookup dicts.
2447         This way, Linux kernels >=3.0-rc1 get supported in the
2448         build process.
2449         https://bugs.webkit.org/show_bug.cgi?id=62730
2450
2451         * Scripts/webkitpy/common/system/executive.py:
2452         * Scripts/webkitpy/common/system/file_lock.py:
2453         * Scripts/webkitpy/common/system/path_unittest.py:
2454         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2455         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2456         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2457         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2458         * Scripts/webkitpy/layout_tests/port/factory.py:
2459         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2460         * Scripts/webkitpy/layout_tests/port/qt.py:
2461         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2462
2463 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2464
2465         Unreviewed, rolling out r88796.
2466         http://trac.webkit.org/changeset/88796
2467         https://bugs.webkit.org/show_bug.cgi?id=62790
2468
2469         It made fast/dom/nodesFromRect-basic.html time out on Qt,
2470         64-bit, debug mode (Requested by Ossy on #webkit).
2471
2472         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2473         (LayoutTestController::nodesFromRect):
2474         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2475         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2476         (PlainTextController::plainText):
2477         * DumpRenderTree/qt/PlainTextControllerQt.h:
2478
2479 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2480
2481         Unreviewed, build fix.
2482
2483         Revert the patches in r88995 and r88999; the http servers don't
2484         seem to be shutting down reliably.
2485
2486         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2487         * Scripts/webkitpy/layout_tests/port/base.py:
2488         * Scripts/webkitpy/layout_tests/port/http_server.py:
2489         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2490         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
2491         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2492         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2493
2494 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2495
2496         Unreviewed, build fix.
2497
2498         Add some debugging messages to triage problems introduced in
2499         r88995.
2500
2501         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2502
2503 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2504
2505         Reviewed by Tony Chang.
2506
2507         nrwt: should clean up stale server processes from a previous run
2508         https://bugs.webkit.org/show_bug.cgi?id=62615
2509
2510         This change fixes cases where NRWT might start a server and then
2511         exit, leaving the server still running. Now NRWT should detect
2512         this case and clean up on the next run, without shutting down
2513         any processes it didn't start.
2514
2515         This change also fixes a bug in executive.kill_process on UNIX
2516         where zombies weren't being handled properly.
2517
2518         * Scripts/webkitpy/common/system/executive.py:
2519         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2520         * Scripts/webkitpy/layout_tests/port/base.py:
2521         * Scripts/webkitpy/layout_tests/port/http_server.py:
2522         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2523         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2524         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2525
2526 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2527
2528         Reviewed by Tony Chang.
2529
2530         nrwt: fix http, websocket server startup, shutdown
2531         https://bugs.webkit.org/show_bug.cgi?id=62180
2532
2533         This change refactors all of the server-related code to
2534         have consistent semantics. It pushes the start()/stop()
2535         logic into the base class and adds four much smaller routines
2536         for specialization:
2537         _prepare_config() - for optionally writing config files etc.
2538             to disk prior to starting the server
2539         _remove_stale_log_files()
2540         _spawn_process() - the actual launch of the subprocess
2541         _cleanup_after_stop() - and custom cleanup code
2542
2543         Prior to this change the three server implementations were
2544         fairly inconsistent, leading to lots of weirdness on the bots
2545         with servers being left around, etc.
2546
2547         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2548         * Scripts/webkitpy/layout_tests/port/http_server.py:
2549         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2550         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2551
2552 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2553
2554         Reviewed by Tony Chang.
2555
2556         webkitpy: clean up code prior to functional changes for server startup/shutdown
2557         https://bugs.webkit.org/show_bug.cgi?id=62256
2558
2559         This patch does a bunch of minor cleanup of the code, but there
2560         should be no functional changes except that all of the modules
2561         will now use the same exception type. Other changes include
2562         removing unused code paths and functions, pushing 'name' and
2563         'pid_file' into the base class of the server objects, and using
2564         the Filesystem object instead of the codecs, tempfile, and
2565         shutils modules.
2566
2567         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2568         * Scripts/webkitpy/layout_tests/port/http_server.py:
2569         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2570         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2571
2572 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2573
2574         Reviewed by Tony Chang.
2575
2576         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
2577         https://bugs.webkit.org/show_bug.cgi?id=62251
2578
2579         shut_down_http_server() was a total hack that was only used by
2580         new-run-webkit-httpd, so I've moved the code there and switched
2581         to using executive.kill_process() for the common case. The
2582         method itself will be removed in the patch on bug 59993.
2583
2584         * Scripts/new-run-webkit-httpd:
2585         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2586         * Scripts/webkitpy/layout_tests/port/http_server.py:
2587         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2588         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2589
2590 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2591
2592         Unreviewed, build fix.
2593
2594         Fix test-webkitpy failure introduced in r88986.
2595
2596         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2597
2598 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2599
2600         Reviewed by Eric Seidel.
2601
2602         NRWT: doesn't support webarchives, has stale skipping logic.
2603         https://bugs.webkit.org/show_bug.cgi?id=58293
2604
2605         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2606         * Scripts/webkitpy/layout_tests/port/base.py:
2607         * Scripts/webkitpy/layout_tests/port/webkit.py:
2608
2609 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
2610
2611         Change my email to @webkit.org
2612
2613         * Scripts/webkitpy/common/config/committers.py:
2614
2615 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
2616
2617         Reviewed by David Hyatt.
2618
2619         CSS 2.1: Support replaced elements with relative intrinsic sizes
2620         https://bugs.webkit.org/show_bug.cgi?id=15849
2621
2622         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
2623         https://bugs.webkit.org/show_bug.cgi?id=53099
2624
2625         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
2626
2627         * Scripts/old-run-webkit-tests:
2628         * Scripts/webkitpy/layout_tests/port/test_files.py:
2629
2630 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2631
2632         Reviewed by Martin Robinson.
2633
2634         [GTK] Add a statusbar to MiniBrowser
2635         https://bugs.webkit.org/show_bug.cgi?id=62634
2636
2637         It shows the url of the current hovered link.
2638
2639         * MiniBrowser/gtk/BrowserWindow.c:
2640         (browserWindowConstructed): Create the GtkSatusbar.
2641         (mouseDidMoveOverElement): Update statusbar text.
2642         (browserWindowUIClientInit): Add implementation for
2643         mouseDidMoveOverElement().
2644         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
2645         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
2646         (mouseDidMoveOverElement): Pass the url of the current hovered
2647         link to the UI process.
2648         (didCreatePage): Set the UI client adding an implementation for
2649         mouseDidMoveOverElement().
2650         (WKBundleInitialize):
2651         * MiniBrowser/gtk/main.c:
2652         (createWKContextWithInjectedBundle): Create a global context with
2653         the injected bundle.
2654         (loadURI): Use the global context.
2655         (main):
2656
2657 2011-06-14  Lucas Forschler  <lforschler@apple.com>
2658
2659         Reviewed by Stephanie Lewis.
2660
2661         https://bugs.webkit.org/show_bug.cgi?id=62495
2662         Bug 62495 - combine windows and mac kill-old-processes script
2663         Add a platform agnostic script.  Remove the recently added mac flavor.
2664         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
2665         
2666         * BuildSlaveSupport/kill-old-processes: Added.
2667         * BuildSlaveSupport/mac: Removed.
2668         * BuildSlaveSupport/mac/kill-old-processes: Removed.
2669
2670 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
2671
2672         Reviewed by Tony Chang.
2673
2674         nrwt: handle worker exceptions cleanly
2675         https://bugs.webkit.org/show_bug.cgi?id=62614
2676
2677         This change modifiers new-run-webkit-tests to handle exceptions
2678         raised by worker threads better, by:
2679         - capturing the worker's stack and logging it in the manager
2680         - propagating the worker's exception in the caller correctly
2681         - attempting to cancel the workers and clean up even when
2682           we get an unexpected exception
2683
2684         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2685         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2686         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2687         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2688
2689 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2690
2691         Reviewed by Laszlo Gombos.
2692
2693         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
2694         https://bugs.webkit.org/show_bug.cgi?id=62227
2695
2696         QtWebkit does not yet support different CacheModels. This change will 
2697         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
2698
2699         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2700         (LayoutTestController::setCacheModel):
2701         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2702
2703 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2704
2705         Reviewed by Andreas Kling.
2706
2707         [Qt] tst_QWebFrame::overloadedSlots() fails
2708         https://bugs.webkit.org/show_bug.cgi?id=37319
2709
2710         Since we don't implictly convert 'document' object to QWebElement
2711         in metacalls anymore, change the controller to expect QVariantMap instead.
2712
2713         The method plainText() was updated to use QVariantMap as well to let the bridge
2714         do the conversion directly for us.
2715
2716         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2717         (LayoutTestController::nodesFromRect):
2718         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2719         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2720         (PlainTextController::plainText):
2721         * DumpRenderTree/qt/PlainTextControllerQt.h:
2722
2723 2011-06-14  Andras Becsi  <abecsi@webkit.org>
2724
2725         Reviewed by Csaba Osztrogonác.
2726
2727         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
2728         https://bugs.webkit.org/show_bug.cgi?id=62630
2729
2730         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2731         (NPP_New): remove dead variable 'forceCarbon'
2732
2733 2011-06-13  Hayato Ito  <hayato@chromium.org>
2734
2735         Reviewed by Ojan Vafai.
2736
2737         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
2738         https://bugs.webkit.org/show_bug.cgi?id=59188
2739
2740         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
2741         WebKitDriver should always return an actual hash value if DRT returns that.
2742
2743         No tests since I'll add sample reftests to make sure mismatch reftests work later,
2744         which should be in a separate patch.
2745
2746         * Scripts/webkitpy/layout_tests/port/webkit.py:
2747
2748 2011-06-13  Kent Tamura  <tkent@chromium.org>
2749
2750         [Chromium-win] Fix two wrong assertions exposed by r88757.
2751
2752         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2753         (WebThemeEngineDRTWin::paintTrackbar):
2754
2755 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
2756
2757         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
2758         and commit queue happy.
2759
2760         * Scripts/webkitpy/common/config/committers.py:
2761
2762 2011-06-13  Chris Rogers  <crogers@google.com>
2763
2764         Unreviewed build fix.
2765
2766         Build fix to chromium DRT until we can rebaseline some tests
2767         https://bugs.webkit.org/show_bug.cgi?id=62608
2768
2769         * DumpRenderTree/chromium/TestShell.cpp:
2770         (TestShell::TestShell):
2771
2772 2011-06-13  Chris Rogers  <crogers@google.com>
2773
2774         Reviewed by Dirk Pranke.
2775
2776         Add Web Audio support to chromium DRT
2777         https://bugs.webkit.org/show_bug.cgi?id=62306
2778
2779         * DumpRenderTree/chromium/LayoutTestController.cpp:
2780         (LayoutTestController::LayoutTestController):
2781         (LayoutTestController::reset):
2782         (LayoutTestController::setEncodedAudioData):
2783         * DumpRenderTree/chromium/LayoutTestController.h:
2784         (LayoutTestController::encodedAudioData):
2785         (LayoutTestController::shouldDumpAsAudio):
2786         (LayoutTestController::setShouldDumpAsAudio):
2787         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2788         (DRTPrinter::handleAudioHeader):
2789         (TestShellPrinter::handleAudioHeader):
2790         * DumpRenderTree/chromium/TestEventPrinter.h:
2791         * DumpRenderTree/chromium/TestShell.cpp:
2792         (TestShell::TestShell):
2793         (TestShell::dump):
2794
2795 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2796
2797         Reviewed by Eric Seidel.
2798
2799         [EFL] Add load error handler to EWebLauncher
2800         https://bugs.webkit.org/show_bug.cgi?id=62347
2801
2802         Add a handler function of "load,error" to EWebLauncher.
2803         EWebLauncher now displays a simple error page on load errors.
2804
2805         * EWebLauncher/main.c:
2806         (on_load_error):
2807         (browserCreate):
2808
2809 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
2810
2811         Reviewed by Eric Seidel.
2812
2813         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
2814         https://bugs.webkit.org/show_bug.cgi?id=62385
2815
2816         Remove duplicate TestNetscapePlugIn implementation. Having two copies
2817         of this code makes keeping it in sync much more difficult. The files are
2818         almost identical and this change ports the X11 changes to main.cpp.
2819
2820         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2821         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
2822         some results on Qt and this seems to be unnecessary for the moment.
2823         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
2824         (handleEventX11): Use the handler to properly convert the keycode. Do not print
2825         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
2826         it should not be in the results.
2827         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
2828         XP_UNIX block is first by guarding against using a null instance.
2829         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
2830         the XP_UNIX define for Linux.
2831         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
2832         * GNUmakefile.am: Update source list.
2833
2834 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2835
2836         Unreviewed, rolling out r88671.
2837         http://trac.webkit.org/changeset/88671
2838         https://bugs.webkit.org/show_bug.cgi?id=62591
2839
2840         "didn't work" (Requested by dpranke on #webkit).
2841
2842         * Scripts/new-run-webkit-httpd:
2843         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2844         * Scripts/webkitpy/layout_tests/port/http_server.py:
2845         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2846         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
2847         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2848         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2849
2850 2011-06-13  Nate Chapin  <japhet@chromium.org>
2851
2852         Reviewed by Darin Fisher.
2853
2854         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
2855
2856         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2857
2858 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
2859
2860         Reviewed by Tony Chang.
2861
2862         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
2863         https://bugs.webkit.org/show_bug.cgi?id=62251
2864
2865         shut_down_http_server() was a total hack that was only used by
2866         new-run-webkit-httpd, so I've moved the code there and switched
2867         to using executive.kill_process() for the common case. The
2868         method itself will be removed in the patch on bug 59993.
2869
2870         * Scripts/new-run-webkit-httpd:
2871         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2872         * Scripts/webkitpy/layout_tests/port/http_server.py:
2873         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2874         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2875
2876 2011-06-13  Tony Chang  <tony@chromium.org>
2877
2878         Reviewed by Dimitri Glazkov.
2879
2880         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
2881         https://bugs.webkit.org/show_bug.cgi?id=62578
2882
2883         * Scripts/build-webkit:
2884
2885 2011-06-13  Tony Chang  <tony@chromium.org>
2886
2887         Reviewed by Adam Barth.
2888
2889         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
2890         https://bugs.webkit.org/show_bug.cgi?id=62545
2891
2892         * Scripts/build-webkit:
2893
2894 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2895
2896         Reviewed by Martin Robinson.
2897
2898         [GTK] Export an API similar to WebKit1
2899         https://bugs.webkit.org/show_bug.cgi?id=57820
2900
2901         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
2902         code, but linking to libwebkit2gtk.
2903
2904         * GNUmakefile.am:
2905         * GtkLauncher/main.c:
2906         (createBrowser):
2907         (main):
2908
2909 2011-06-12  MORITA Hajime  <morrita@google.com>
2910
2911         Unreviewed, rolling out r88625.
2912         http://trac.webkit.org/changeset/88625
2913         https://bugs.webkit.org/show_bug.cgi?id=61073
2914
2915         Breaks SL Webkit2 Tests
2916
2917         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
2918         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2919         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
2920         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2921         (WTR::InjectedBundlePage::didClearWindowForFrame):
2922         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2923
2924 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2925
2926         Reviewed by Antonio Gomes.
2927
2928         [Qt] LayoutTestController needs setTextDirection implementation
2929         https://bugs.webkit.org/show_bug.cgi?id=62442
2930
2931         Implements LayoutController.setTextDirection.
2932
2933         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2934         (LayoutTestController::setTextDirection):
2935         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2936
2937 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
2938
2939         Reviewed by Hajime Morita.
2940
2941         Add window.internals to WebKit2's WebKitTestRunner.
2942         https://bugs.webkit.org/show_bug.cgi?id=61073
2943
2944         Test: fast/harness/internals-object.html
2945
2946         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
2947         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2948         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
2949         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2950         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
2951         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2952
2953 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2954
2955         Unreviewed, rolling out r88616.
2956         http://trac.webkit.org/changeset/88616
2957         https://bugs.webkit.org/show_bug.cgi?id=62517
2958
2959         It broke editing/text-iterator/findString.html (Requested by
2960         tonikitoo on #webkit).
2961
2962         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2963         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2964
2965 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2966
2967         Reviewed by Antonio Gomes.
2968
2969         [Qt] LayoutTestController needs setTextDirection implementation
2970         https://bugs.webkit.org/show_bug.cgi?id=62442
2971
2972         Implements LayoutController.setTextDirection.
2973
2974         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2975         (LayoutTestController::setTextDirection):
2976         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2977
2978 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
2979
2980         Reviewed by Ojan Vafai.
2981
2982         new-run-webkit-tests: 'images' links on results.html don't work
2983         https://bugs.webkit.org/show_bug.cgi?id=62194
2984
2985         Use relative path when generating images-diffs.html
2986
2987         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2988         Added _output_testname.
2989
2990 2011-06-10  Lucas Forschler  <lforschler@apple.com>
2991
2992         Reviewed by Stephanie Lewis.
2993
2994         Script to kill old processes on Mac.
2995         This matches the windows version.
2996         https://bugs.webkit.org/show_bug.cgi?id=62479  
2997         
2998         * BuildSlaveSupport/mac: Added.
2999         * BuildSlaveSupport/mac/kill-old-processes: Added.
3000
3001 2011-06-10  Adam Barth  <abarth@webkit.org>
3002
3003         Reviewed by James Robinson.
3004
3005         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
3006         https://bugs.webkit.org/show_bug.cgi?id=62489
3007
3008         * Scripts/webkitpy/tool/bot/sheriff.py:
3009         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3010
3011 2011-06-10  Tony Chang  <tony@chromium.org>
3012
3013         Reviewed by Ojan Vafai.
3014
3015         add a compile guard ENABLE(FLEXBOX)
3016         https://bugs.webkit.org/show_bug.cgi?id=62049
3017
3018         * Scripts/build-webkit:
3019
3020 2011-06-10  Mark Rowe  <mrowe@apple.com>
3021
3022         Reviewed by Dimitri Glazkov.
3023
3024         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
3025
3026         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
3027         header file.
3028
3029         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3030         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3031
3032 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
3033
3034         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
3035
3036         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3037         (handleEventX11):
3038         (NPP_GetValue):
3039         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3040         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
3041         (webkit_test_plugin_new_instance):
3042         (webkit_test_plugin_destroy_instance):
3043         (webkit_test_plugin_set_window):
3044         (executeScript):
3045         (webkit_test_plugin_new_stream):
3046         (webkit_test_plugin_destroy_stream):
3047         (webkit_test_plugin_stream_as_file):
3048         (webkit_test_plugin_write_ready):
3049         (webkit_test_plugin_write):
3050         (webkit_test_plugin_print):
3051         (keyEventToChar):
3052         (webkit_test_plugin_handle_event):
3053         (webkit_test_plugin_url_notify):
3054         (webkit_test_plugin_get_value):
3055         (webkit_test_plugin_set_value):
3056         (NP_GetMIMEDescription):
3057         (NP_Initialize):
3058         (NP_Shutdown):
3059         (NP_GetValue):
3060         * GNUmakefile.am:
3061
3062 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
3063
3064         Reviewed by Eric Seidel.
3065
3066         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
3067         https://bugs.webkit.org/show_bug.cgi?id=55603
3068
3069         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
3070         TextInputController support.
3071
3072         * DumpRenderTree/gtk/TextInputController.cpp:
3073         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
3074         of start and end. This matches the other ports. Do not use GLib style early returns.
3075         (hasMarkedTextCallback): Added.
3076         (markedRangeCallback): Added.
3077         (insertTextCallback): Cleanup as described above.
3078         (unmarkTextCallback): Cleanup as described above.
3079         (firstRectForCharacterRangeCallback): Cleanup as described above.
3080         (selectedRangeCallback): Cleanup as described above.
3081
3082 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
3083
3084         Reviewed by Tony Chang.
3085
3086         nrwt: support webaudio in chromium driver
3087         https://bugs.webkit.org/show_bug.cgi?id=62226
3088
3089         * Scripts/webkitpy/layout_tests/port/chromium.py:
3090
3091 2011-06-09  Dan Bernstein  <mitz@apple.com>
3092
3093         Reviewed by Anders Carlsson.
3094
3095         Added a test for Vector::reverse()
3096         https://bugs.webkit.org/show_bug.cgi?id=62393
3097
3098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3099         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
3100         (TestWebKitAPI::TEST):
3101         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3102
3103 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
3104
3105         Reviewed by Andreas Kling.
3106
3107         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
3108         https://bugs.webkit.org/show_bug.cgi?id=62385
3109
3110         Remove duplicate TestNetscapePlugIn implementation. Having two copies
3111         of this code makes keeping it in sync much more difficult. The files are
3112         almost identical and this change ports the X11 changes to main.cpp.
3113
3114         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3115         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
3116         (handleEventX11): Use the handler to properly convert the keycode. Do not print
3117         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
3118         it should not be in the results.
3119         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
3120         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
3121         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
3122         * GNUmakefile.am: Update source list.
3123
3124 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
3125
3126         Reviewed by Tony Chang.
3127
3128         Test plugin should support event logging on the windows port.
3129         https://bugs.webkit.org/show_bug.cgi?id=61721
3130
3131         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
3132         calls to mean the plugin handled the event.
3133
3134         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3135         (handleEventWin): Return 0 for each event on windows.
3136
3137 2011-06-09  Chang Shu  <cshu@webkit.org>
3138
3139         Reviewed by Andreas Kling.
3140
3141         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
3142         https://bugs.webkit.org/show_bug.cgi?id=62381
3143
3144         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
3145         QWKPagePrivate::isViewFocused() will check it later.
3146
3147         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3148         (WTR::PlatformWebView::PlatformWebView):
3149
3150 2011-06-09  Robert Hogan  <robert@webkit.org>
3151
3152         Reviewed by Andreas Kling.
3153
3154         Teach Qt about window.internals
3155         https://bugs.webkit.org/show_bug.cgi?id=61074
3156
3157         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3158         (WebCore::DumpRenderTree::initJSObjects):
3159
3160 2011-06-09  Eric Seidel  <eric@webkit.org>
3161
3162         Reviewed by Adam Barth.
3163
3164         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
3165         https://bugs.webkit.org/show_bug.cgi?id=62362
3166
3167         The mac bots are failing inspector tests.  We don't know why yet.
3168         So for now, turning run-webkit-tests off for the mac-ews.
3169
3170         Also noticed that due to the wrong variable name the cr-linux
3171         bots weren't running tests!
3172
3173         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3174
3175 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
3176
3177         Reviewed by Csaba Osztrogonac.
3178
3179         [Qt][WK2] Canvas tests make css2.1 ones failing
3180         https://bugs.webkit.org/show_bug.cgi?id=53427
3181
3182         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
3183         Since the Qt port should eventually go to QRawFont, this issue will be resolved
3184         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
3185         needed for the workaround.
3186
3187         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3188         (WTR::LayoutTestController::platformInitialize):
3189
3190 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
3191
3192         Reviewed by Chris Fleizach.
3193
3194         [GTK] Provide a way in DRT to check the platform name
3195         https://bugs.webkit.org/show_bug.cgi?id=56855
3196
3197         Patch for adding 'platformName' static property to DRT's
3198         LayoutController and provide platform specific implementations.
3199
3200         In principle, this feature will be only of interest for writing
3201         accessibility tests, so that's why it's only implemented in the
3202         Mac, Gtk and Win platforms.
3203
3204         * DumpRenderTree/LayoutTestController.h: New method platformName().
3205         * DumpRenderTree/LayoutTestController.cpp:
3206         (getPlatformNameCallback): New callback for 'platformName'.
3207         (LayoutTestController::staticValues): New static property.
3208
3209         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3210         (LayoutTestController::platformName): Implemented.
3211
3212         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3213         (LayoutTestController::platformName): Implemented.
3214
3215         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3216         (LayoutTestController::platformName): Implemented.
3217
3218 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
3219
3220         Reviewed by James Robinson.
3221
3222         Add mikelawther to committers.py
3223         https://bugs.webkit.org/show_bug.cgi?id=62354
3224
3225         * Scripts/webkitpy/common/config/committers.py:
3226
3227 2011-06-08  Kent Tamura  <tkent@chromium.org>
3228
3229         [Chromium] Fix a typo.
3230
3231         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3232         (WebThemeControlDRTWin::draw):
3233
3234 2011-06-08  Kent Tamura  <tkent@chromium.org>
3235
3236         Reviewed by Hajime Morita.
3237
3238         [Chromium] Support vertical sliders in Windows DRT
3239         https://bugs.webkit.org/show_bug.cgi?id=62352
3240
3241         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3242         (WebThemeControlDRTWin::draw):
3243           Paint VerticalSliderThumbType and VerticalSliderTrackType.
3244         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3245           Add VerticalSliderTrackType and VerticalSliderThumbType.
3246         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3247         (WebThemeEngineDRTWin::paintTrackbar):
3248           Convert Windows identifiers to the internal identifiers for vertical sliders.
3249
3250 2011-06-08  Ojan Vafai  <ojan@chromium.org>
3251
3252         Reviewed by Tony Chang.
3253
3254         add a short-flag for --experimental-fully-parallel
3255         https://bugs.webkit.org/show_bug.cgi?id=62321
3256
3257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3258
3259 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3260
3261         Reviewed by Tony Chang.
3262
3263         new-run-webkit-tests: don't turn the tree red when there are new passes
3264         https://bugs.webkit.org/show_bug.cgi?id=62311
3265
3266         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
3267         to match commandComplete.
3268
3269         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3270
3271 2011-06-08  Tom Hudson  <tomhudson@google.com>
3272
3273         Reviewed by Mihai Parparita.
3274
3275         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
3276         https://bugs.webkit.org/show_bug.cgi?id=60964
3277
3278         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3279         Add 'Sort tests by metric' link.
3280         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3281         (disableSorting): Activate 'Sort tests by metric' link.
3282         (enableSorting): Deactivate 'Sort tests by metric' link.
3283         (selectDirectory): Call enableSorting()/disableSorting() depending
3284         on currently selected failure type, and sort tests if requested.
3285         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3286         New .disabled-control class for deactivated links.
3287
3288 2011-06-08  Tom Sepez  <tsepez@chromium.org>
3289
3290         Reviewed by Adam Barth.
3291
3292         Add web permissions callbacks for mixed content blocking.
3293         https://bugs.webkit.org/show_bug.cgi?id=61946
3294
3295         * DumpRenderTree/chromium/LayoutTestController.cpp:
3296         (LayoutTestController::setAllowDisplayOfInsecureContent):
3297         (LayoutTestController::setAllowRunningOfInsecureContent):
3298         (LayoutTestController::overridePreference):
3299         * DumpRenderTree/chromium/WebPermissions.cpp:
3300         (WebPermissions::allowDisplayingInsecureContent):
3301         (WebPermissions::allowRunningInsecureContent):
3302         (WebPermissions::setDisplayingInsecureContentAllowed):
3303         (WebPermissions::setRunningInsecureContentAllowed):
3304         (WebPermissions::reset):
3305         * DumpRenderTree/chromium/WebPermissions.h:
3306
3307 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
3308
3309         Reviewed by Tony Chang.
3310
3311         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
3312         https://bugs.webkit.org/show_bug.cgi?id=62259
3313
3314         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3315
3316 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3317
3318         Reviewed by Tony Chang.
3319
3320         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
3321         https://bugs.webkit.org/show_bug.cgi?id=62303
3322
3323         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
3324
3325         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3326
3327 2011-06-08  Greg Simon  <gregsimon@chromium.org>
3328
3329         Reviewed by Dimitri Glazkov.
3330
3331         Control Indexeddb backends from LayoutTestController
3332         https://bugs.webkit.org/show_bug.cgi?id=61000
3333
3334         * DumpRenderTree/chromium/LayoutTestController.cpp:
3335         (LayoutTestController::LayoutTestController):
3336         (LayoutTestController::setOverrideIndexedDBBackingStore):
3337         (LayoutTestController::clearAllDatabases):
3338         * DumpRenderTree/chromium/LayoutTestController.h:
3339
3340 2011-06-08  Andreas Kling  <kling@webkit.org>
3341
3342         Add Pierre Rossi to contributors list for EZ-CC.
3343
3344         * Scripts/webkitpy/common/config/committers.py:
3345
3346 2011-06-08  Ilya Sherman  <isherman@chromium.org>
3347
3348         Reviewed by Andreas Kling.
3349
3350         Add Ilya Sherman to list of committers
3351         https://bugs.webkit.org/show_bug.cgi?id=62270
3352
3353         * Scripts/webkitpy/common/config/committers.py:
3354
3355 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
3356
3357         Reviewed by Tony Chang.
3358
3359         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
3360         https://bugs.webkit.org/show_bug.cgi?id=62178
3361
3362         Added commandComplete and evaluateCommand for NewRunWebKitTests class
3363         to parse new-run-webkit-tests' results.
3364
3365         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3366
3367 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
3368
3369         Reviewed by Eric Seidel.
3370
3371         webkitpy: add a popen() call to executive
3372         https://bugs.webkit.org/show_bug.cgi?id=62179
3373
3374         This change adds a popen() wrapper call to the Executive object.
3375         This will allow other webkitpy scripts that currently call
3376         subprocess directly to use Executive, instead.
3377
3378         No additional tests are necessary (the existing tests cover the code).
3379
3380         * Scripts/webkitpy/common/system/executive.py:
3381
3382 2011-06-07  Sam Weinig  <sam@webkit.org>
3383
3384         Reviewed by Anders Carlsson.
3385
3386         Remove repeated IPC traffic from SetRenderTreeSize message
3387         https://bugs.webkit.org/show_bug.cgi?id=62244
3388
3389         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3390         (WTR::InjectedBundlePage::InjectedBundlePage):
3391         Add stub for didLayoutForFrame.
3392
3393 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
3394
3395         Reviewed by Tony Chang.
3396
3397         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
3398         https://bugs.webkit.org/show_bug.cgi?id=62241
3399
3400         * Scripts/webkitpy/layout_tests/port/chromium.py:
3401
3402 2011-06-07  Adam Barth  <abarth@webkit.org>
3403
3404         Rubber-stamped by Eric Seidel.
3405
3406         Enable tests on the mac-ews
3407
3408         When we bring the mac-ews back up, we're going to try running tests!
3409
3410         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3411
3412 2011-06-07  Dmitry Lomov  <dslomov@google.com>
3413
3414         Reviewed by David Levin.
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=62215
3417         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
3418
3419         * Scripts/webkitpy/style/checkers/cpp.py:
3420         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3421
3422 2011-06-07  Nico Weber  <thakis@chromium.org>
3423
3424         Reviewed by Dimitri Glazkov.
3425
3426         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
3427         https://bugs.webkit.org/show_bug.cgi?id=62210
3428
3429         The change to TestEventPrinter fixes a latent bug, because
3430         objects are deleted through the TestEventPrinter type, but none
3431         of the subclasses have destructors or non-POD members.
3432
3433         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
3434         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
3435         discussed at http://codereview.chromium.org/7094005/, we prefer making
3436         leaf class destructors virtual over making the leaf classes final.
3437
3438         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3439         (NotificationPresenter::~NotificationPresenter):
3440         * DumpRenderTree/chromium/NotificationPresenter.h:
3441         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3442         (TestEventPrinter::~TestEventPrinter):
3443         * DumpRenderTree/chromium/TestEventPrinter.h:
3444         * DumpRenderTree/chromium/WebViewHost.h:
3445
3446 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3447
3448         Reviewed by Dirk Pranke.
3449
3450         [chromium] Chromium bots on build.webkit.org don't upload results.html
3451         https://bugs.webkit.org/show_bug.cgi?id=61961
3452
3453         Don't fix the path on chromium port erroneously.
3454
3455         * BuildSlaveSupport/test-result-archive:
3456
3457 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
3458
3459         Fix the GTK+ build by ensuring that the autogenerated sources
3460         necessary for libWebCoreInternals are recorded in a predeclared
3461         variable before assigning to BUILT_SOURCES.
3462
3463         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
3464
3465 2011-06-06  Yong Li  <yoli@rim.com>
3466
3467         Reviewed by Eric Seidel.
3468
3469         https://bugs.webkit.org/show_bug.cgi?id=62097
3470         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
3471
3472         * Scripts/webkitpy/style/checkers/cpp.py:
3473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3474
3475 2011-06-06  Xan Lopez  <xlopez@igalia.com>
3476
3477         Reviewed by Martin Robinson.
3478
3479         [GTK] Enable feature/symbol detection in NWRT/GTK
3480         https://bugs.webkit.org/show_bug.cgi?id=62136
3481
3482         Disable feature detection through DRT, since we don't support it,
3483         and set the libwebcore patch correctly so that symbol detection
3484         through 'nm' works.
3485
3486         * Scripts/webkitpy/layout_tests/port/gtk.py:
3487
3488 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
3489
3490         Reviewed by Tony Gentilcore.
3491
3492         Add a "prerender" state for page visibility.
3493         https://bugs.webkit.org/show_bug.cgi?id=62062
3494
3495         * DumpRenderTree/chromium/LayoutTestController.cpp:
3496         (LayoutTestController::setPageVisibility):
3497
3498 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
3499
3500         [Qt] Implement download feature for QtTestBrowser
3501         https://bugs.webkit.org/show_bug.cgi?id=61865
3502
3503         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
3504
3505         * QtTestBrowser/launcherwindow.cpp:
3506         (LauncherWindow::LauncherWindow):
3507         * QtTestBrowser/launcherwindow.h:
3508
3509 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
3510
3511         Reviewed by Csaba Osztrogonác.
3512
3513         [Qt] Implement download feature for QtTestBrowser
3514         https://bugs.webkit.org/show_bug.cgi?id=61865
3515
3516         * QtTestBrowser/launcherwindow.cpp:
3517         (LauncherWindow::LauncherWindow):
3518         (LauncherWindow::downloadRequest):
3519         (LauncherWindow::fileDownloadFinished):
3520         * QtTestBrowser/launcherwindow.h:
3521
3522 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
3523
3524         Reviewed by Dimitri Glazkov.
3525
3526         Make DumpRenderTree initialize window.internals.
3527         https://bugs.webkit.org/show_bug.cgi?id=61076
3528
3529         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
3530         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3531         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3532
3533 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
3534
3535         Reviewed by Kent Tamura.
3536
3537         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
3538         https://bugs.webkit.org/show_bug.cgi?id=61628
3539
3540         * Scripts/build-webkit:
3541
3542 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
3543
3544         Reviewed by Kent Tamura.
3545
3546         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
3547         https://bugs.webkit.org/show_bug.cgi?id=61631
3548
3549         * Scripts/build-webkit:
3550
3551 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3552
3553         Unreviewed. Fix the GTK+ build.
3554
3555         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
3556
3557 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
3558
3559         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
3560         works properly).
3561
3562         * Scripts/webkitpy/common/config/committers.py:
3563
3564 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3565
3566         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
3567         WebKit scripts expect, so other scripts work properly with wx.
3568
3569         * waf/build/build_utils.py:
3570         * waf/build/settings.py:
3571
3572 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3573
3574         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
3575         to build on Mac.
3576
3577         * waf/build/settings.py:
3578         * wx/install-unix-extras:
3579
3580 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3581
3582         [wx] Unreviewed build fixes for recent trunk changes.
3583
3584         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3585         (LayoutTestController::setTextDirection):
3586         * waf/build/settings.py:
3587
3588 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
3589
3590         Fix the GTK+ build.
3591
3592         * GNUmakefile.am: Add some missing newline escape.
3593
3594 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3595
3596         Try to fix the GTK+ bulid.
3597
3598         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
3599         source list.
3600
3601 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3602
3603         Reviewed by Adam Barth.
3604
3605         nrwt: should skip chromium test expectation overrides on upstream bots
3606         https://bugs.webkit.org/show_bug.cgi?id=61888
3607
3608         * Scripts/webkitpy/layout_tests/port/chromium.py:
3609         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3610
3611 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3612
3613         Reviewed by Ojan Vafai.
3614
3615         new-run-webkit-tests: minor logging, code cleanup
3616         https://bugs.webkit.org/show_bug.cgi?id=62055
3617
3618         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3619         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3620
3621 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3622
3623         Try to fix the build failure on the GTK+ 32-bit Release bot.
3624
3625         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
3626
3627 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
3628
3629         Reviewed by Ryosuke Niwa.
3630
3631         [GTK] Support smart replace for the pasteboard
3632         https://bugs.webkit.org/show_bug.cgi?id=61734
3633
3634         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
3635         This is required to produce consistent test results.
3636
3637         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3638         (resetDefaultsT