8158db00c9e4579e2a401137346d1d8fcc9c65f3
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-07  Jessie Berlin  <jberlin@apple.com>
2
3         Clean Windows build fails after r110033
4         https://bugs.webkit.org/show_bug.cgi?id=80553
5
6         Rubber-stamped by Jon Honeycutt and Eric Seidel.
7
8         Add the new JavaScriptCore include directory to some more vsprops files.
9
10         * DumpRenderTree/win/ImageDiffCommon.vsprops:
11         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
12         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
13
14 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
15
16         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
17         https://bugs.webkit.org/show_bug.cgi?id=72489
18
19         Reviewed by Dirk Pranke.
20
21         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
22         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
23         --platform will override the platform name and then we'll use it.
24
25         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
26         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
27         override it in the end.
28
29         * Scripts/old-run-webkit-tests:
30         * Scripts/webkitpy/layout_tests/port/qt.py:
31         (QtPort):
32         (QtPort.determine_full_port_name):
33         (QtPort.baseline_search_path):
34
35 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
36
37         [Qt][WK2] MiniBrowser on desktop does not react to click events
38         https://bugs.webkit.org/show_bug.cgi?id=80314
39
40         Reviewed by Kenneth Rohde Christiansen.
41
42         Do not enable touch mocking on desktop mode.
43
44         * MiniBrowser/qt/MiniBrowserApplication.cpp:
45         (MiniBrowserApplication::handleUserOptions):
46
47 2012-03-07  Ojan Vafai  <ojan@chromium.org>
48
49         Automatically move to the next test after rebaseline in the results view
50         https://bugs.webkit.org/show_bug.cgi?id=80527
51
52         Reviewed by Dimitri Glazkov.
53
54         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
55         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
56
57 2012-03-07  Ojan Vafai  <ojan@chromium.org>
58
59         garden-o-matic rebaseline is broken for ports that don't have a fallback port
60         https://bugs.webkit.org/show_bug.cgi?id=80526
61
62         Reviewed by Adam Barth.
63
64         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
65         since there is no "None" port.
66
67         * Scripts/webkitpy/tool/servers/gardeningserver.py:
68         (GardeningHTTPRequestHandler.rebaseline):
69         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
70         (GardeningServerTest.test_rebaseline):
71
72 2012-03-07  James Robinson  <jamesr@chromium.org>
73
74         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
75         https://bugs.webkit.org/show_bug.cgi?id=80521
76
77         Reviewed by Kenneth Russell.
78
79         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
80         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
81         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
82
83         Covered by platform/chromium/compositing/plugins/*
84
85         * DumpRenderTree/chromium/TestWebPlugin.cpp:
86         (TestWebPlugin::TestWebPlugin):
87         (TestWebPlugin::initialize):
88         (TestWebPlugin::updateGeometry):
89         (TestWebPlugin::initScene):
90         (TestWebPlugin::destroyScene):
91         * DumpRenderTree/chromium/TestWebPlugin.h:
92         (TestWebPlugin):
93         * DumpRenderTree/chromium/WebViewHost.cpp:
94         (WebViewHost::createPlugin):
95
96 2012-03-07  Philippe Normand  <pnormand@igalia.com>
97
98         [GTK] remove webkitpy dependency in run-gtk-tests
99         https://bugs.webkit.org/show_bug.cgi?id=80500
100
101         Reviewed by Martin Robinson.
102
103         Replace Executive calls with bare subprocess calls.
104
105         * Scripts/run-gtk-tests:
106         (TestRunner):
107         (TestRunner._lookup_atspi2_binary):
108         (TestRunner.run):
109         (TestRunner.run.run_for_real):
110
111 2012-03-07  Philippe Normand  <pnormand@igalia.com>
112
113         Unreviewed, GTK build fix after r110059.
114
115         * Scripts/run-gtk-tests:
116         (TestRunner._check_if_tests_have_timed_out):
117         (TestRunner.run.run_tests):
118         (TestRunner):
119
120 2012-03-07  Philippe Normand  <pnormand@igalia.com>
121
122         [GTK] race condition in run-gtk-tests
123         https://bugs.webkit.org/show_bug.cgi?id=80495
124
125         Reviewed by Martin Robinson.
126
127         Refactored the script to wait the a11y dbus service becomes
128         available before starting the tests.
129
130         * Scripts/run-gtk-tests:
131         (TestRunner._lookup_atspi2_binary):
132         (TestRunner):
133         (TestRunner._wait_dbus_service_and_run):
134         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
135         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
136         (TestRunner.run):
137         (TestRunner.run.bailout):
138         (TestRunner.run.run_for_real):
139
140 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
141
142         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
143         https://bugs.webkit.org/show_bug.cgi?id=80425
144
145         Reviewed by Simon Hausmann.
146
147         Set startScreenPos in mock touch point
148
149         * MiniBrowser/qt/MiniBrowserApplication.cpp:
150         (MiniBrowserApplication::notify):
151         * MiniBrowser/qt/MiniBrowserApplication.h:
152         (MiniBrowserApplication):
153
154 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
155
156         [Qt] Windows build fix.
157
158         Reviewed by Tor Arne Vestbø.
159
160         Pass the -j parameter only to "make", not "nmake".
161
162         * Scripts/webkitdirs.pm:
163         (buildQMakeProjects):
164
165 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
166
167         [Qt] Fix compilation without QtQuick1
168         https://bugs.webkit.org/show_bug.cgi?id=80503
169
170         Reviewed by Tor Arne Vestbø.
171
172         Introduce HAVE_QQUICK1 as feature and added haveQtModule
173         as convenience function.
174
175         * qmake/mkspecs/features/features.prf:
176         * qmake/mkspecs/features/functions.prf:
177
178 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
179
180         [Qt] Add qmake config tests for JPEG and PNG library
181         https://bugs.webkit.org/show_bug.cgi?id=80398
182
183         Add JPEG and PNG library tests to config.tests and
184         add error() abort to WebCore.pri if tests don't work.
185
186         Reviewed by Tor Arne Vestbø.
187
188         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
189         (main):
190         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
191         * qmake/config.tests/libpng/libpng.cpp: Added.
192         (main):
193         * qmake/config.tests/libpng/libpng.pro: Added.
194         * qmake/sync.profile:
195
196 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
197
198         [EFL] Build warning: Fix warn_unused_result warnings.
199         https://bugs.webkit.org/show_bug.cgi?id=79194
200
201         Reviewed by Filip Pizlo.
202
203         Fixed build warning which is getting generated when not using return
204         value of a fuction, especially declared with warn_unused_result
205         attribute.
206
207         * DumpRenderTree/efl/ImageDiff.cpp:
208         (printImage):
209
210 2012-03-07  Kangil Han  <kangil.han@samsung.com>
211
212         [DRT] Remove PlainTextController implementations.
213         https://bugs.webkit.org/show_bug.cgi?id=79959
214
215         Reviewed by Hajime Morita.
216
217         PlainTextController usages in existing tests have been
218         replaced by internals API by bug 78570.
219         So this patch will remove PlainTextController implementations
220         to avoid further usage in new tests.
221
222         * DumpRenderTree/DumpRenderTree.gypi:
223         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
224         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
225         * DumpRenderTree/chromium/PlainTextController.h: Removed.
226         * DumpRenderTree/chromium/TestShell.cpp:
227         (TestShell::TestShell):
228         (TestShell::bindJSObjectsToWindow):
229         * DumpRenderTree/chromium/TestShell.h:
230         (TestShell):
231         * DumpRenderTree/gtk/DumpRenderTree.cpp:
232         (webViewWindowObjectCleared):
233         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
234         * DumpRenderTree/gtk/PlainTextController.h: Removed.
235         * DumpRenderTree/mac/FrameLoadDelegate.mm:
236         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
237         * DumpRenderTree/mac/PlainTextController.h: Removed.
238         * DumpRenderTree/mac/PlainTextController.mm: Removed.
239         * DumpRenderTree/qt/DumpRenderTree.pro:
240         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
241         (WebCore::DumpRenderTree::DumpRenderTree):
242         (WebCore::DumpRenderTree::initJSObjects):
243         * DumpRenderTree/qt/DumpRenderTreeQt.h:
244         (DumpRenderTree):
245         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
246         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
247         * GNUmakefile.am:
248
249 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
250
251         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
252         https://bugs.webkit.org/show_bug.cgi?id=80137
253
254         Reviewed by Eric Seidel.
255
256         Adds implementation LayoutTestController's setPopupBlockingEnabled.
257         To pass popup-blocking-click-in-iframe.html EventSender should not
258         repeat click events in idler's function. EventSender allows to
259         asynchronously send click event through ecore_idler_add.
260         This event will be called repeatedly as long as it return true.
261         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
262
263         * DumpRenderTree/efl/EventSender.cpp:
264         (sendMouseEvent): Changed return value from bool to void because it always returns true.
265         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
266         (mouseDownCallback): Remove unnecessary checking of return value.
267         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
268         (LayoutTestController::setPopupBlockingEnabled):
269
270 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
271
272         rebaseline_chromium_webkit_tests is obsolete and should be removed
273         https://bugs.webkit.org/show_bug.cgi?id=80347
274
275         Reviewed by Tony Chang.
276
277         * Scripts/rebaseline-chromium-webkit-tests: Removed.
278         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
279         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
280
281 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
282
283         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
284         https://bugs.webkit.org/show_bug.cgi?id=80468
285
286         Unreviewed, build fix.
287
288         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
289
290         * Scripts/webkitpy/layout_tests/servers/http_server.py:
291         (Lighttpd._prepare_config):
292
293 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
294
295         remove chromium_gpu ports
296         https://bugs.webkit.org/show_bug.cgi?id=80345
297
298         Reviewed by Ojan Vafai.
299
300         This change leaves in the 'graphics_type' distinction in the
301         test_expectations; removing that will require more updates and a
302         pass over test_expectations.txt, so I'm separating that out.
303
304         * Scripts/webkitpy/layout_tests/port/builders.py:
305         * Scripts/webkitpy/layout_tests/port/chromium.py:
306         (ChromiumPort):
307         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
308         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
309         * Scripts/webkitpy/layout_tests/port/factory.py:
310         (PortFactory):
311         (PortFactory.get):
312         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
313         (FactoryTest.test_qt):
314         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
315         (TestRebaseline.test_rebaseline_expectations):
316
317 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
318
319         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
320         https://bugs.webkit.org/show_bug.cgi?id=80282
321
322         Reviewed by Antonio Gomes.
323
324         Remove transitive library dependencies; they are especially
325         dangerous when one ends up linking against WTF, JSC and then WTF
326         again, since some symbols will not be defined.
327
328         Passing --no-copy-dt-needed-entries and --as-needed to the linker
329         (which some recent Linux distros do by default) makes the issue
330         even more evident.
331
332         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
333         as the other libraries have the needed symbols. Explicitly link
334         against fontconfig.
335
336 2012-03-06  Dean Jackson  <dino@apple.com>
337
338         filter-build-webkit needs more filters
339         https://bugs.webkit.org/show_bug.cgi?id=80440
340
341         Reviewed by Joseph Pecoraro.
342
343         Added as many missing filters as I could find for Apple
344         builds. Plus a few minor style updates.
345
346         * Scripts/filter-build-webkit:
347         (printLine):
348
349 2012-03-06  Ojan Vafai  <ojan@chromium.org>
350
351         Copying old baselines throws an error if the new directory doesn't exist
352         https://bugs.webkit.org/show_bug.cgi?id=80443
353
354         Reviewed by Adam Barth.
355
356         Existing tests cover the new code with the fix to filesystem_mock.
357
358         * Scripts/webkitpy/common/system/filesystem_mock.py:
359         (MockFileSystem.copyfile):
360         Fix the mock to better match python's copyfile semantics.
361
362         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
363         (Rebaseliner._create_html_baseline_files):
364         * Scripts/webkitpy/tool/commands/rebaseline.py:
365         (RebaselineTest._copy_existing_baseline):
366
367 2012-03-05  Ojan Vafai  <ojan@chromium.org>
368
369         Add a mechanism to rebaseline new ports
370         https://bugs.webkit.org/show_bug.cgi?id=80355
371
372         Reviewed by Adam Barth.
373
374         For a test that's only failing on a new port, we want
375         to first copy the existing result into the location for the
376         port it's replacing in order to not break that port.
377
378         For example, bringing up the chromium-lion port, if we just
379         stick the results in the chromium-mac directory, the snow leopard
380         will start failing. Instead, we first copy the existing result
381         to the chromium-mac-snowleopard directory.
382
383         * Scripts/webkitpy/layout_tests/port/builders.py:
384         (builder_path_for_port_name):
385         (fallback_port_name_for_new_port):
386         * Scripts/webkitpy/tool/commands/rebaseline.py:
387         (RebaselineTest):
388         (RebaselineTest._copy_existing_baseline):
389         (RebaselineTest._rebaseline_test):
390         (RebaselineTest.execute):
391         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
392         (TestRebaseline.test_rebaseline_test):
393         (TestRebaseline):
394         (TestRebaseline.test_rebaseline_and_copy_test):
395         (test_rebaseline_and_copy_test_no_existing_result):
396         (test_rebaseline_and_copy_test_with_lion_result):
397         (test_rebaseline_and_copy_no_overwrite_test):
398         * Scripts/webkitpy/tool/servers/gardeningserver.py:
399         (GardeningHTTPRequestHandler.rebaseline):
400         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
401         (GardeningServerTest.test_rebaseline):
402         (GardeningServerTest):
403         (GardeningServerTest.test_rebaseline_new_port):
404
405 2012-03-06  Beth Dakin  <bdakin@apple.com>
406
407         https://bugs.webkit.org/show_bug.cgi?id=80351
408         InlineTextBox is using the wrong origin when calling 
409         addRelevantRepaintedObject
410         -and corresponding-
411         <rdar://problem/10970221>
412
413         Reviewed by Sam Weinig.
414
415         This test has actually been broken since revision 109273. This change makes 
416         the test pass again, and it makes it specifically exercise the fix for this 
417         bug.
418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
419         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
420         (TestWebKitAPI::TEST):
421
422         Adjust comments in the other tests to reflect the API changes from 109273.
423         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
426         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
427         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
428         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
429         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
430         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
431         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
432
433 2012-03-06  Hans Wennborg  <hans@chromium.org>
434
435         Speech JavaScript API: add SpeechRecognitionError
436         https://bugs.webkit.org/show_bug.cgi?id=80410
437
438         Chromium: enable the runtime flag for scripted speech so we can run
439         the layout tests for it.
440
441         Reviewed by Adam Barth.
442
443         * DumpRenderTree/chromium/TestShell.cpp:
444         (TestShell::TestShell):
445
446 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
447
448         Enable universal newlines in chromium android layout test runner
449         https://bugs.webkit.org/show_bug.cgi?id=80418
450
451         Reviewed by Adam Barth.
452
453         The Chromium Android layout test runner uses the 'adb' program to
454         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
455         output lines from the test runner, while the test expectation files are
456         written with LF ('\n') delimiters. This causes the results to have
457         spurious whitespace differences, making them more difficult to
458         interpret.
459
460         The fix is to enable universal newlines for the DumpRenderTree pipe,
461         causing the output to only contain LF newlines like on other platforms.
462
463         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
464         (ChromiumAndroidDriver._start):
465
466 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
467
468         [Qt] Revert r109900, it was completly busted
469
470         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
471
472         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
473         of manual define checks.
474
475         Reviewed by Ossy.
476
477         * DumpRenderTree/qt/DumpRenderTree.pro:
478         * QtTestBrowser/QtTestBrowser.pro:
479         * WebKitTestRunner/InjectedBundle/Target.pri:
480         * qmake/mkspecs/features/features.prf:
481
482 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
483
484         [Qt] Use config test to determine if the compiler supports -MD
485
486         We used to assume that unix systems building against Qt5 would have
487         a compiler that supported -MD. Although this was usually the case,
488         we failed to take into account broken tools for distributed builds
489         (e.g. teambuilder or icecream) which would end up producing .d files
490         in the root of the build dir instead of along-side the object file.
491
492         Now that we use a config-test to determine the support, we'll capture
493         those cases, unless distributed builds are enabled after the initial
494         build-webkit run.
495
496         Reviewed by Csaba Osztrogonác.
497
498         * Tools.pro:
499         * qmake/config.tests/gccdepends/empty.cpp: Added.
500         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
501         * qmake/mkspecs/features/default_pre.prf:
502         * qmake/mkspecs/features/features.prf:
503         * qmake/mkspecs/features/unix/default_pre.prf:
504         * qmake/sync.profile:
505
506 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
507
508         REGRESSION(r109294): It broke the unittest of master.cfg
509         https://bugs.webkit.org/show_bug.cgi?id=80253
510
511         Reviewed by Tor Arne Vestbø.
512
513         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
514         (BuildBotConfigLoader._create_mock_passwords_dict):
515         (BuildBotConfigLoader._mock_open):
516         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
517         (BuildBotConfigLoader.load_config):
518
519 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
520
521         Qt API test buildstep throws exception after buildmaster update
522         https://bugs.webkit.org/show_bug.cgi?id=80249
523
524         This patch based on Peter Gal's work.
525
526         Reviewed by Csaba Osztrogonác.
527
528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
529         (RunQtAPITests):
530         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
531
532 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
533
534         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
535
536         Reviewed by Simon Hausmann.
537         Reviewed by Ossy.
538
539         * DumpRenderTree/qt/DumpRenderTree.pro:
540         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
541         (WebKit::initializeTestFonts):
542         * QtTestBrowser/QtTestBrowser.pro:
543         * WebKitTestRunner/InjectedBundle/Target.pri:
544         * qmake/mkspecs/features/features.prf:
545
546 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
547
548         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
549
550         Reviewed by Ossy.
551
552         * qmake/mkspecs/features/default_post.prf:
553
554 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
555
556         [Qt] Make sure clean builds are followed by make qmake && make if needed
557
558         On non-GNUmake systems we have to run make qmake so that the generated
559         sources are generated before we run qmake on the target pro files. This
560         is achieved by using the 'incremental' target.
561
562         Reviewed by Ossy.
563
564         * Scripts/webkitdirs.pm:
565         (buildQMakeProjects):
566
567 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
568
569         DumpRenderTree should support preciseTime()
570         https://bugs.webkit.org/show_bug.cgi?id=80397
571
572         Reviewed by Gavin Barraclough.
573
574         * DumpRenderTree/LayoutTestController.cpp:
575         (preciseTimeCallback):
576         (LayoutTestController::staticFunctions):
577
578 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
579
580         Unreviewed, rolling out r109887.
581         http://trac.webkit.org/changeset/109887
582         https://bugs.webkit.org/show_bug.cgi?id=80402
583
584         It broke the build (Requested by Ossy on #webkit).
585
586         * DumpRenderTree/qt/DumpRenderTree.pro:
587         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
588         (WebKit::initializeTestFonts):
589         * QtTestBrowser/QtTestBrowser.pro:
590         * WebKitTestRunner/InjectedBundle/Target.pri:
591         * qmake/mkspecs/features/features.prf:
592
593 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
594
595         Unreviewed, rolling out r109837.
596         http://trac.webkit.org/changeset/109837
597         https://bugs.webkit.org/show_bug.cgi?id=80399
598
599         breaks Mac Productions builds, too late to try and fix it
600         tonight (Requested by eseidel on #webkit).
601
602         * Scripts/build-webkit:
603
604 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
605
606         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
607
608         Reviewed by Simon Hausmann.
609
610         * DumpRenderTree/qt/DumpRenderTree.pro:
611         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
612         (WebKit::initializeTestFonts):
613         * QtTestBrowser/QtTestBrowser.pro:
614         * WebKitTestRunner/InjectedBundle/Target.pri:
615         * qmake/mkspecs/features/features.prf:
616
617 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
618
619         [Qt] Create EWS to build WebKit2
620         https://bugs.webkit.org/show_bug.cgi?id=80277
621
622         Reviewed by Csaba Osztrogonác.
623
624         * QueueStatusServer/model/queues.py:
625         (Queue):
626         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
627         (QtWK2EWS):
628         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
629         (EarlyWarningSytemTest.test_builder_ewses):
630
631 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
632
633         Unreviewed, rolling out r109733.
634         http://trac.webkit.org/changeset/109733
635         https://bugs.webkit.org/show_bug.cgi?id=80378
636
637         It broke Qt5 build system (Requested by Ossy on #webkit).
638
639         * Tools.pro:
640         * qmake/config.tests/gccdepends/empty.cpp: Removed.
641         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
642         * qmake/mkspecs/features/default_pre.prf:
643         * qmake/mkspecs/features/features.prf:
644         * qmake/mkspecs/features/unix/default_pre.prf:
645         * qmake/sync.profile:
646
647 2012-03-05  Eric Seidel  <eric@webkit.org>
648
649         Update JavaScriptCore files to use fully-qualified WTF include path
650         https://bugs.webkit.org/show_bug.cgi?id=79960
651
652         Reviewed by Adam Barth.
653
654         Build WTF/WTF.xcodeproj by default on Mac.
655
656         * Scripts/build-webkit:
657
658 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
659
660         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
661         https://bugs.webkit.org/show_bug.cgi?id=69590
662
663         Reviewed by Ryosuke Niwa.
664
665         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
666         to skip the 'optimize-expectations' step.
667
668         * Scripts/webkitpy/tool/commands/rebaseline.py:
669         (RebaselineExpectations.__init__):
670         (RebaselineExpectations.execute):
671         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
672
673 2012-03-05  Kent Tamura  <tkent@chromium.org>
674
675         [Chromium] Add new popup type: PagePopup
676         https://bugs.webkit.org/show_bug.cgi?id=80106
677
678         Reviewed by Darin Fisher.
679
680         * DumpRenderTree/chromium/WebViewHost.cpp:
681         (WebViewHost::createPopupMenu):
682
683 2012-03-05  Jessie Berlin  <jberlin@apple.com>
684
685         Add myself as a reviewer.
686
687         * Scripts/webkitpy/common/config/committers.py:
688         Also, add my IRC nick so it is easier to find and yell at me.
689
690 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
691
692         Correctly compute the positions of GestureScroll* events on
693         Chromium.
694         https://bugs.webkit.org/show_bug.cgi?id=80075
695
696         Reviewed by Adam Barth.
697
698         * DumpRenderTree/chromium/EventSender.cpp:
699         (EventSender::reset):
700         (EventSender::gestureEvent):
701         * DumpRenderTree/chromium/EventSender.h:
702         (EventSender):
703
704 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
705
706         flakiness dashboard doesn't display baselines for virtual tests correctly
707         https://bugs.webkit.org/show_bug.cgi?id=80341
708
709         Reviewed by Ojan Vafai.
710
711         If the test is part of a virtual test suite, we need to look for
712         baselines in the underlying fallback path for the actual test
713         being run, as well as baselines for the virtual version.
714
715         This patch adds code to handle both branches and also pulls the
716         mapping of the test suites up into a constant.
717
718         * TestResultServer/static-dashboards/flakiness_dashboard.html:
719         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
720         (testLookupVirtualTestSuite):
721         (testBaseTest):
722
723 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
724
725         Unreviewed, rolling out r109760.
726         http://trac.webkit.org/changeset/109760
727         https://bugs.webkit.org/show_bug.cgi?id=80320
728
729         Caused many GTK+ tests to crash (Requested by mrobinson on
730         #webkit).
731
732         * gtk/jhbuild.modules:
733
734 2012-03-05  Charlie Reis  <creis@chromium.org>
735
736         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
737         https://bugs.webkit.org/show_bug.cgi?id=80057
738
739         Reviewed by Darin Fisher.
740
741         * DumpRenderTree/chromium/WebViewHost.cpp:
742         (WebViewHost::createView):
743         * DumpRenderTree/chromium/WebViewHost.h:
744         (WebViewHost):
745
746 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
747
748         [soup] Crash while loading http://www.jusco.cn
749         https://bugs.webkit.org/show_bug.cgi?id=68238
750
751         Reviewed by Philippe Normand.
752
753         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
754         in the jhbuild file.
755
756 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
757
758         Unreviewed, rolling out r109748.
759         http://trac.webkit.org/changeset/109748
760         https://bugs.webkit.org/show_bug.cgi?id=80296
761
762         Made some tests crash, will fix and recommit (Requested by
763         noamr on #webkit).
764
765         * MiniBrowser/qt/main.cpp:
766         (main):
767
768 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
769
770         [GTK] plugins/netscape-plugin-page-cache-works.html fails
771         https://bugs.webkit.org/show_bug.cgi?id=74409
772
773         Reviewed by Martin Robinson.
774
775         Add support for overriding the page-cache-for-plugins preference
776         through DumpRenderTreeSupport.
777
778         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
779         (booleanFromValue): A helper function to convert a string to boolean.
780         (LayoutTestController::overridePreference):
781
782 2012-03-05  Rob Buis  <rbuis@rim.com>
783
784         [BlackBerry] Update Tools/DumpRenderTree
785         https://bugs.webkit.org/show_bug.cgi?id=80287
786
787         Reviewed by Antonio Gomes.
788
789         Update so we are sure we can build our implementation of DRT.
790
791         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
792         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
793         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
794         (AccessibilityController::addNotificationListener): add missing hook.
795         (AccessibilityController::removeNotificationListener): add missing hook.
796         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
797         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
798         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
799         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
800         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
801
802 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
803
804         [Qt] [WK2] Support threaded renderer in WK2
805         https://bugs.webkit.org/show_bug.cgi?id=76661
806
807         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
808
809         Reviewed by Kenneth Rohde Christiansen.
810
811         * MiniBrowser/qt/main.cpp:
812         (main):
813
814 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
815
816         Unreviewed. Add myself to committer list.
817
818         * Scripts/webkitpy/common/config/committers.py:
819
820 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
821
822         [Qt] Use config test to determine if the compiler supports -MD
823
824         We used to assume that unix systems building against Qt5 would have
825         a compiler that supported -MD. Although this was usually the case,
826         we failed to take into account broken tools for distributed builds
827         (e.g. teambuilder or icecream) which would end up producing .d files
828         in the root of the build dir instead of along-side the object file.
829
830         Now that we use a config-test to determine the support, we'll capture
831         those cases, unless distributed builds are enabled after the initial
832         build-webkit run.
833
834         Reviewed by Csaba Osztrogonác.
835
836         * Tools.pro:
837         * qmake/config.tests/gccdepends/empty.cpp: Added.
838         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
839         * qmake/mkspecs/features/default_pre.prf:
840         * qmake/mkspecs/features/features.prf:
841         * qmake/mkspecs/features/unix/default_pre.prf:
842         * qmake/sync.profile:
843
844 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
845
846         Qt API test buildstep throws exception after buildmaster update
847         https://bugs.webkit.org/show_bug.cgi?id=80249
848
849         Reviewed by Zoltan Herczeg.
850
851         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
852         (BuildAndTestFactory.__init__):
853
854 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
855
856         [GTK] Unit tests are noisy when run under jhbuild
857         https://bugs.webkit.org/show_bug.cgi?id=80241
858
859         Reviewed by Philippe Normand.
860
861         Force the 'memory' backend in GSettings so that each unit
862         test doesn't produce a warning when it's forced to fall back
863         to the 'memory' backend.
864
865         * Scripts/run-gtk-tests:
866         (TestRunner.run): Force the 'memory' backend.
867
868 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
869
870         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
871         https://bugs.webkit.org/show_bug.cgi?id=80235
872
873         Reviewed by Philippe Normand.
874
875         * Scripts/run-gtk-tests:
876         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
877         inspector resources path determination is shared by all tests.
878
879 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
880
881         [GTK] REGRESSION: r108278 broke some tests that expect focus
882         https://bugs.webkit.org/show_bug.cgi?id=79084
883
884         Reviewed by Philippe Normand.
885
886         Grab focus when dumping test results and also when sending
887         events. During the course of testing, the WebView may lose
888         focus and this seems to snap it back when tests demand it.
889
890         * DumpRenderTree/gtk/DumpRenderTree.cpp:
891         (dump): Grab focus.
892         * DumpRenderTree/gtk/EventSender.cpp:
893         (dispatchEvent): Ditto.
894
895 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
896
897         Unreviewed, Add myself to committer list.
898         https://bugs.webkit.org/show_bug.cgi?id=80232
899
900         * Scripts/webkitpy/common/config/committers.py:
901
902 2012-03-04  Anders Carlsson  <andersca@apple.com>
903
904         Newer versions of clang fail to compile WebKit.
905
906         Fix build.
907
908         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
909         (descriptionOfValue):
910         (AccessibilityUIElement::rowIndexRange):
911         (AccessibilityUIElement::columnIndexRange):
912         (AccessibilityUIElement::selectedTextRange):
913         * DumpRenderTree/mac/EditingDelegate.mm:
914         (-[DOMRange dump]):
915         * DumpRenderTree/mac/PolicyDelegate.mm:
916         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
917         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
918         (-[NSError _drt_descriptionSuitableForTestResult]):
919         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
920         (WTR::descriptionOfValue):
921         (WTR::AccessibilityUIElement::rowIndexRange):
922         (WTR::AccessibilityUIElement::columnIndexRange):
923         (WTR::AccessibilityUIElement::selectedTextRange):
924
925 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
926
927         [Qt] Fix static_libs_as_shared build
928         https://bugs.webkit.org/show_bug.cgi?id=80214
929
930         Reviewed by Tor Arne Vestbø.
931
932         * WebKitTestRunner/qt/main.cpp:
933         (main): Set the correct environment variable for choosing the theme in the
934         web process.
935
936 2012-03-03  Hans Wennborg  <hans@chromium.org>
937
938         Implement Speech JavaScript API
939         https://bugs.webkit.org/show_bug.cgi?id=80019
940
941         Reviewed by Adam Barth.
942
943         Add ENABLE_SCRIPTED_SPEECH.
944
945         * Scripts/build-webkit:
946         * qmake/mkspecs/features/features.prf:
947
948 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
949
950         Fix commit queue, remove duplicate entry.
951
952         * Scripts/webkitpy/common/config/committers.py:
953
954 2012-03-02  Stephen Chenney  <schenney@chromium.org>
955
956         Unreviewed, add myself as a committer
957
958         * Scripts/webkitpy/common/config/committers.py:
959
960 2012-03-02  Ojan Vafai  <ojan@chromium.org>
961
962         Add the Chromium Lion canary bot to the flakiness dashboard.
963         * TestResultServer/static-dashboards/builders.js:
964
965 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
966
967         links for virtual tests are broken in the flakiness dashboard
968         https://bugs.webkit.org/show_bug.cgi?id=80180
969
970         Reviewed by Ojan Vafai.
971
972         * TestResultServer/static-dashboards/flakiness_dashboard.html:
973         (linkHTMLToOpenWindow):
974         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
975         (testLinkHTMLToOpenWindow): added.
976
977 2012-03-02  Philippe Normand  <pnormand@igalia.com>
978
979         [GTK] security/block-test.html baselines differ from mac
980         https://bugs.webkit.org/show_bug.cgi?id=78343
981
982         Reviewed by Martin Robinson.
983
984         Improved the FrameLoader error heuristics to match mac behavior a
985         bit more.
986
987         * DumpRenderTree/gtk/DumpRenderTree.cpp:
988         (pathFromSoupURI): Handle ftp urls the same as http urls.
989         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
990
991 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
992
993         [Qt][WK2] Fix typo in patch committed in r109575
994
995         Unreviewed typo fix.
996
997         * MiniBrowser/qt/MiniBrowserApplication.cpp:
998         (MiniBrowserApplication::notify): Cache the position
999         in floating point coordinates.
1000
1001 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1002
1003         [Qt][WK2] Infinite loop on history navigation, when panning
1004         https://bugs.webkit.org/show_bug.cgi?id=79119
1005
1006         Reviewed by Simon Hausmann.
1007
1008         Make the touch mocking more robust by creating touch events
1009         directly and sending them synchronously to the browser window.
1010         If the sent touch event was not accepted we propagate the
1011         original mouse event to its target.
1012         This way we make sure we only send either a touch or a mouse
1013         event and do not end up in an infinite loop between our mocking
1014         code and the Qt5 automatic mouse event synthesizing.
1015
1016         * MiniBrowser/qt/BrowserWindow.cpp:
1017         (BrowserWindow::updateVisualMockTouchPoints):
1018         * MiniBrowser/qt/BrowserWindow.h:
1019         (BrowserWindow):
1020         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1021         (touchRectForPosition):
1022         (MiniBrowserApplication::notify):
1023         (MiniBrowserApplication::sendTouchEvent):
1024         * MiniBrowser/qt/MiniBrowserApplication.h:
1025         (MiniBrowserApplication):
1026
1027 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1028
1029         [Qt] Use 'all' as default target when debug_and_release is in effect
1030
1031         When debug_and_release is enabled, in combination with build_all,
1032         qmake will generate an aggregate makefile that calls make on both
1033         the debug and the release makefiles, but with the 'all' target.
1034
1035         In this case we can't use 'first' as the default target, as the
1036         extra targets would then not be run, so we append extra targets
1037         to 'all' instead.
1038
1039         Reviewed by Simon Hausmann.
1040
1041         * qmake/mkspecs/features/default_post.prf:
1042
1043 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1044
1045         [Qt] Make sure activeBuildConfig() returns the right config
1046
1047         Using isActiveConfig fails, as that only checks if the given
1048         argument is in CONFIG, not the order.
1049
1050         Reviewed by Simon Hausmann.
1051
1052         * qmake/mkspecs/features/functions.prf:
1053
1054 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
1055
1056         [Qt] Fix tests run with WTR not using QStyle theme
1057         https://bugs.webkit.org/show_bug.cgi?id=80147
1058
1059         Reviewed by Csaba Osztrogonác.
1060
1061         * WebKitTestRunner/qt/main.cpp:
1062         (main): Set environment variable for web process to use QStyle theme.
1063
1064 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1065
1066         Unreviewed, remove debug print call.
1067
1068         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1069         (descriptionSuitableForTestResult):
1070
1071 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
1072
1073         Updated EventSender to send complete gesture events.
1074         https://bugs.webkit.org/show_bug.cgi?id=80075
1075
1076         Reviewed by Adam Barth.
1077
1078         * DumpRenderTree/chromium/EventSender.cpp:
1079         (EventSender::gestureEvent): set additional parameters in sent events.
1080
1081 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1082
1083         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
1084         https://bugs.webkit.org/show_bug.cgi?id=80033
1085
1086         Reviewed by Gustavo Noronha Silva.
1087
1088         GCC 4.7 no longer includes unistd.h from most of the standard C++
1089         header files, so we need to explicitly include it for getcwd().
1090
1091         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
1092         not only on Mac, but on all Unix platforms.
1093
1094 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1095
1096         Actually look at the args in driver_input :(.
1097
1098         Unreviewed, build fix.
1099
1100         * Scripts/webkitpy/layout_tests/port/chromium.py:
1101         (ChromiumDriver.run_test):
1102
1103 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1104
1105         Fix typo in flag used to run gpu virtual suites.
1106
1107         Unreviewed, build fix.
1108
1109         * Scripts/webkitpy/layout_tests/port/chromium.py:
1110         (ChromiumPort.virtual_test_suites):
1111
1112 2012-03-01  Adam Barth  <abarth@webkit.org>
1113
1114         Unreviewed, rolling out r109317.
1115         http://trac.webkit.org/changeset/109317
1116
1117         Let's try watchlists again now that we're using a pure git
1118         working copy
1119
1120         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1121         (StyleQueueTask.run):
1122         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1123
1124 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1125
1126         webkitpy: test_run_test_pause_before_testing is failing after r109482
1127         https://bugs.webkit.org/show_bug.cgi?id=80084
1128
1129         Unreviewed, build fix.
1130
1131         Fixes the test string compare to ignore the time spent running
1132         the tests.
1133
1134         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1135         (test_run_test_pause_before_testing):
1136
1137 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1138
1139         nrwt: virtual tests aren't being run
1140         https://bugs.webkit.org/show_bug.cgi?id=80083
1141
1142         Reviewed by Eric Seidel.
1143
1144         If we tried to run all of the tests by default (and
1145         didn't specify any paths), the virtual tests weren't
1146         picked up.
1147
1148         * Scripts/webkitpy/layout_tests/port/base.py:
1149         (Port._virtual_tests):
1150         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1151         (PortTest.test_tests):
1152         * Scripts/webkitpy/layout_tests/port/test.py:
1153         (TestPort.virtual_test_suites):
1154
1155 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1156
1157         run-perf-tests should report the test runtime
1158         https://bugs.webkit.org/show_bug.cgi?id=80078
1159
1160         Reviewed by Hajime Morita.
1161
1162         Record and output the aggreated test run time.
1163
1164         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1165         (PerfTestsRunner._run_single_test):
1166
1167 2012-03-01  Michael Nordman  <michaeln@google.com>
1168
1169         [chromium] Use webkit_support to create session storage namespaces in DRT.
1170         https://bugs.webkit.org/show_bug.cgi?id=79933
1171
1172         Reviewed by Tony Chang.
1173
1174         * DumpRenderTree/chromium/WebViewHost.cpp:
1175         (WebViewHost::createSessionStorageNamespace):
1176
1177 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1178
1179         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
1180         https://bugs.webkit.org/show_bug.cgi?id=80048
1181
1182         Reviewed by Adam Barth.
1183
1184         * Scripts/webkitpy/layout_tests/port/base.py:
1185         (Port.test_isfile):
1186         (Port.test_isdir):
1187         (Port):
1188         (Port.test_exists):
1189         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1190         (PortTest.test_test_exists):
1191         (PortTest):
1192         (PortTest.test_test_isfile):
1193         (PortTest.test_test_isdir):
1194         * Scripts/webkitpy/layout_tests/port/test.py:
1195         (TestPort.virtual_test_suites):
1196         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1197         (MainTest.test_virtual):
1198
1199 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1200
1201         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
1202         https://bugs.webkit.org/show_bug.cgi?id=80031
1203
1204         Reviewed by Gustavo Noronha Silva.
1205
1206         Only build the libTestRunnerInjectedBundle.la convenience library when
1207         ENABLE_WEBKIT2 is defined.
1208
1209         * WebKitTestRunner/GNUmakefile.am:
1210
1211 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1212
1213         Unreviewed, second attempt to fix GTK NRWT after r109242.
1214
1215         * Scripts/webkitpy/layout_tests/port/gtk.py:
1216         (GtkDriver._start):
1217
1218 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1219
1220         Unreviewed, GTK NRWT build fix attempt after r109242.
1221
1222         * Scripts/webkitpy/layout_tests/port/gtk.py:
1223         (GtkDriver._start):
1224
1225 2012-03-01  Kentaro Hara  <haraken@chromium.org>
1226
1227         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
1228         https://bugs.webkit.org/show_bug.cgi?id=80008
1229
1230         Reviewed by Adam Barth.
1231
1232         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
1233         to "preprocess-idls.pl". This patch renames it.
1234
1235         Test: Confirm that run-bindings-tests runs.
1236
1237         * Scripts/webkitpy/bindings/main.py:
1238         (BindingsTests.generate_supplemental_dependency):
1239
1240 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
1241
1242         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
1243         https://bugs.webkit.org/show_bug.cgi?id=78047
1244
1245         Reviewed by Kenneth Rohde Christiansen.
1246
1247         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
1248         sending to the item requires the QObject::event re-implementation to dispatch to the correct
1249         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
1250         the event handlers directly, and with the removal of our own dispatching we need to go through
1251         that code path.
1252
1253         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1254         (WTR::PlatformWebView::sendEvent):
1255         (WTR::PlatformWebView::postEvent):
1256
1257 2012-02-29  Adam Barth  <abarth@webkit.org>
1258
1259         Disable watchlist.  It's been spamming CCs.
1260
1261         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1262         (StyleQueueTask.run):
1263         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1264
1265 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1266
1267         need to clone the gpu baselines and expectations into the new "virtual" dir
1268         https://bugs.webkit.org/show_bug.cgi?id=79956
1269
1270         Reviewed by Adam Barth.
1271
1272         * Scripts/webkitpy/layout_tests/port/chromium.py:
1273         (ChromiumPort.virtual_test_suites):
1274
1275 2012-02-29  Mark Rowe  <mrowe@apple.com>
1276
1277         Switch to using json rather than simplejson now that the master is using Python 2.7.
1278
1279         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1280         (loadBuilderConfig):
1281
1282 2012-02-29  David Levin  <levin@chromium.org>
1283
1284         [chromium] Add the ability to turn off autoresize.
1285         https://bugs.webkit.org/show_bug.cgi?id=77452
1286
1287         Reviewed by Darin Fisher.
1288
1289         * DumpRenderTree/chromium/LayoutTestController.cpp:
1290         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
1291         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
1292         (LayoutTestController::disableAutoResizeMode):  Ditto.
1293         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
1294
1295 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1296
1297         nrwt: make --print trace work with virtual tests
1298         https://bugs.webkit.org/show_bug.cgi?id=79952
1299
1300         Reviewed by Adam Barth.
1301
1302         * Scripts/webkitpy/layout_tests/views/printing.py:
1303         (Printer._print_test_trace):
1304         (Printer._print_baseline):
1305
1306 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
1307
1308         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
1309         https://bugs.webkit.org/show_bug.cgi?id=79849
1310
1311         Reviewed by Beth Dakin.
1312
1313         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1314         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
1315
1316 2012-02-29  Lucas Forschler  <lforschler@apple.com>
1317
1318         Removed unused Apple buildslaves from the master configuration
1319         https://bugs.webkit.org/show_bug.cgi?id=79925
1320
1321         Reviewed by Stephanie Lewis.
1322
1323         * BuildSlaveSupport/build.webkit.org-config/config.json:
1324
1325 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1326
1327         nrwt: implement simple 'virtual test suite' support
1328         https://bugs.webkit.org/show_bug.cgi?id=79737
1329
1330         Reviewed by Adam Barth.
1331
1332         Add very basic support for 'virtual test suites' to NRWT:
1333         a virtual suite is a directory that may contain new baselines,
1334         contains a pointer to a "base" directory of tests, and an
1335         optional list of command line arguments to pass to DRT;
1336         it gives us a way to run all of the tests in a given directory
1337         multiple times with multiple (potentially differing) sets of
1338         results and baselines.
1339
1340         This patch implements the support needed for this feature, and
1341         some basic tests, but no actual port will use the feature yet.
1342
1343         This is probably the simplest implementation possible - the
1344         list of virtual suites will be hard-coded into the port's
1345         implementation. One can imagine a more data-driven approach
1346         where the suite instructions are stored in a manifest file
1347         either in LayoutTests (all suites in one file), or per-port,
1348         or per-directory. If this feature ends up being useful we
1349         should probably add something like that so people don't have
1350         to hunt around in the code to add suites.
1351
1352         * Scripts/webkitpy/layout_tests/port/base.py:
1353         (Port.__init__):
1354         (Port.expected_filename):
1355         (Port.tests):
1356         (Port):
1357         (Port._real_tests):
1358         (Port._driver_class):
1359         (Port.virtual_test_suites):
1360         (Port.virtual_suite):
1361         (Port.virtual_suite.VirtualTestSuite):
1362         (Port.virtual_suite.VirtualTestSuite.__init__):
1363         (Port.virtual_suite.VirtualTestSuite.__repr__):
1364         (Port.populated_virtual_test_suites):
1365         (Port._virtual_tests):
1366         (Port.lookup_virtual_test_base):
1367         (Port.lookup_virtual_test_args):
1368         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1369         (PortTest.test_find_with_skipped_directories):
1370         * Scripts/webkitpy/layout_tests/port/driver.py:
1371         (DriverInput.__init__):
1372         (DriverProxy.run_test):
1373         * Scripts/webkitpy/layout_tests/port/test.py:
1374         (TestPort.virtual_test_suites):
1375         (TestDriver.run_test):
1376         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1377         (MainTest.test_all):
1378         (MainTest.test_virtual):
1379
1380 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1381
1382         nrwt: support more than two drivers in DriverProxy
1383         https://bugs.webkit.org/show_bug.cgi?id=79736
1384
1385         Reviewed by Adam Barth.
1386
1387         Now that we can support per-test command lines for
1388         Drivers, modify DriverProxy to keep a map of running
1389         drivers for each needed command-line; this will allow
1390         us to transparently maintain a pool of appropriately
1391         configured DRTs without having to constantly start and stop
1392         them.
1393
1394         Note that this potentially raises a garbage collection
1395         problem - the number of running DRTs will grow with the
1396         number of different sets of command line args. For now
1397         this is no worse than the current code - if you're running
1398         with pixel tests, you will only need one DRT per worker,
1399         and if you aren't, you'll need two (one for text-only tests,
1400         and one for reftests).
1401
1402         An alternative would be to only ever have one running driver,
1403         and restart the driver as the command line changes, but this
1404         might (?) slow down execution in the text-only case - we
1405         should benchmark this because it would be simpler and possibly
1406         allow us to eliminate DriverProxy altogether.
1407
1408         * Scripts/webkitpy/layout_tests/port/driver.py:
1409         (DriverProxy.__init__):
1410         (DriverProxy):
1411         (DriverProxy._make_driver):
1412         (DriverProxy.run_test):
1413         (DriverProxy.has_crashed):
1414         (DriverProxy.stop):
1415         (DriverProxy.cmd_line):
1416         (DriverProxy._cmd_line_as_key):
1417
1418 2012-02-29  Adrienne Walker  <enne@google.com>
1419
1420         Unreviewed, add myself as a reviewer
1421
1422         * Scripts/webkitpy/common/config/committers.py:
1423
1424 2012-02-29  Greg Billock  <gbillock@google.com>
1425
1426         Add more tests for web intents
1427         https://bugs.webkit.org/show_bug.cgi?id=79527
1428
1429         Reviewed by Adam Barth.
1430
1431         * DumpRenderTree/chromium/LayoutTestController.cpp:
1432         (LayoutTestController::LayoutTestController):
1433         (LayoutTestController::sendWebIntentResponse):
1434         * DumpRenderTree/chromium/LayoutTestController.h:
1435         (LayoutTestController):
1436         * DumpRenderTree/chromium/WebViewHost.h:
1437         (WebViewHost):
1438         (WebViewHost::currentIntentRequest):
1439
1440 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1441
1442         nrwt: port/Driver needs to support per-test command line args
1443         https://bugs.webkit.org/show_bug.cgi?id=79733
1444
1445         Reviewed by Adam Barth.
1446
1447         As part of removing the 'gpu' configurations and adding support
1448         for 'virtual test suites', the Driver classes need to support
1449         per-test command lines (since different tests will need to be
1450         run with different command line options).
1451
1452         The per-test args are not yet used, so this change should have
1453         no visible effects and need no additional testing.
1454
1455         * Scripts/webkitpy/layout_tests/port/base.py:
1456         (Port.driver_cmd_line):
1457         * Scripts/webkitpy/layout_tests/port/chromium.py:
1458         (ChromiumDriver.cmd_line):
1459         (ChromiumDriver._start):
1460         (ChromiumDriver.start):
1461         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1462         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
1463         (ChromiumDriverTest):
1464         (ChromiumDriverTest.test_two_drivers):
1465         * Scripts/webkitpy/layout_tests/port/driver.py:
1466         (Driver.cmd_line):
1467         (DriverProxy.__init__):
1468         (DriverProxy.start):
1469         (DriverProxy.cmd_line):
1470         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1471         (DriverTest.test_virtual_driver_methods):
1472         * Scripts/webkitpy/layout_tests/port/gtk.py:
1473         (GtkDriver.cmd_line):
1474         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1475         * Scripts/webkitpy/layout_tests/port/test.py:
1476         (TestPort._path_to_driver):
1477         (TestDriver.cmd_line):
1478         (TestDriver.start):
1479         * Scripts/webkitpy/layout_tests/port/webkit.py:
1480         (WebKitDriver.cmd_line):
1481         (WebKitDriver._start):
1482         (WebKitDriver.run_test):
1483         (WebKitDriver.start):
1484         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1485         (WebKitDriverTest.test_no_timeout):
1486         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1487         (PerfTestsRunner._run_tests_set):
1488         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1489         (test_run_test_pause_before_testing):
1490
1491 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1492
1493         perftestsrunner can call printer.write() after printer.cleanup()
1494         https://bugs.webkit.org/show_bug.cgi?id=79872
1495
1496         Reviewed by Ryosuke Niwa.
1497
1498         This patch fixes a unittest that was incorrectly calling
1499         PerfTestsRunner.run() twice (which led to a weird state in the
1500         printer object).
1501
1502         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1503         (MainTest.test_run_with_upload_json):
1504
1505 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
1506
1507         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1508         https://bugs.webkit.org/show_bug.cgi?id=76546
1509
1510         Reviewed by Simon Hausmann.
1511
1512         Revert the workaround introduced in r107868 and reintroduce
1513         the qml binding so we can test the code path that we are more
1514         interested in. The reason that it did not work before is that
1515         we don't have an active platform window which we now workaround
1516         by propagating the resize through QWindowSystemInterface.
1517
1518         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1519         (WTR::WrapperWindow::handleStatusChanged):
1520         (WTR::PlatformWebView::resizeTo):
1521
1522 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
1523
1524         [GTK] Small fix for cross compilation to not generate gtkdoc.
1525
1526         Rubber-stamped by Csaba Osztrogonác.
1527
1528         * Scripts/webkitdirs.pm:
1529         (isCrossCompilation):
1530
1531 2012-02-28  Lucas Forschler  <lforschler@apple.com>
1532
1533         Fix a typo in config.json
1534         linx -> linux
1535         
1536         * BuildSlaveSupport/build.webkit.org-config/config.json:
1537
1538 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1539
1540         [Qt] Allow read/write to the WebView.url property
1541         https://bugs.webkit.org/show_bug.cgi?id=77554
1542
1543         Reviewed by Tor Arne Vestbø.
1544
1545         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
1546
1547         * MiniBrowser/qt/qml/BrowserWindow.qml:
1548
1549 2012-02-28  Dan Winship  <danw@gnome.org>
1550
1551         [GTK] make tests explicitly request GSettingsBackendMemory
1552         https://bugs.webkit.org/show_bug.cgi?id=79788
1553
1554         Reviewed by Martin Robinson.
1555
1556         Explicitly request the fallback memory-based GSettings backend; if
1557         other backends are available then we don't want to use them,
1558         because they would make tests depend on the user's preferences.
1559         And if other backends aren't available, we don't need glib to
1560         print a warning about that fact.
1561
1562         * Scripts/webkitpy/layout_tests/port/gtk.py:
1563         (GtkPort.setup_environ_for_server):
1564
1565 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1566
1567         Unreviewed, rolling out r109110.
1568         http://trac.webkit.org/changeset/109110
1569         https://bugs.webkit.org/show_bug.cgi?id=79806
1570
1571         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
1572         (Requested by aroben on #webkit).
1573
1574         * Scripts/webkitpy/common/checkout/changelog.py:
1575         (parse_bug_id):
1576         (parse_bug_id_from_changelog):
1577         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1578         * Scripts/webkitpy/common/config/urls.py:
1579
1580 2012-02-28  Adam Roben  <aroben@webkit.org>
1581
1582         Add my new email address
1583
1584         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
1585
1586         Reviewed by Anders Carlsson.
1587
1588         * Scripts/webkitpy/common/config/committers.py:
1589
1590 2012-02-28  Adam Roben  <aroben@apple.com>
1591
1592         Teach webkitpy about wkb.ug URLs
1593
1594         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
1595         use wkb.ug URLs
1596
1597         Reviewed by Anders Carlsson.
1598
1599         * Scripts/webkitpy/common/checkout/changelog.py:
1600         (parse_bug_id):
1601         (parse_bug_id_from_changelog):
1602         Fall back to the tiny URL format if neither the short nor long URL formats work.
1603
1604         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1605         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
1606
1607         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
1608         wkb.ug URLs.
1609
1610 2012-02-28  János Badics  <dicska@gmail.com>
1611
1612         [Qt] build-webkit does not detect the number of CPUs
1613         https://bugs.webkit.org/show_bug.cgi?id=76445
1614
1615         Based on Seo Sanghyeon's work (modification:
1616         Automatically determine the number of CPUs for make
1617         only if -j make argument haven't already been specified.)
1618
1619         Reviewed by Csaba Osztrogonác.
1620
1621         * Scripts/webkitdirs.pm:
1622         (buildQMakeProjects):
1623
1624 2012-02-28  Kent Tamura  <tkent@chromium.org>
1625
1626         Update a pattern for forms files of watchlist
1627         https://bugs.webkit.org/show_bug.cgi?id=79767
1628
1629         Reviewed by Kentaro Hara.
1630
1631         * Scripts/webkitpy/common/config/watchlist:
1632         Catches the following files with the "Forms" pattern.
1633         - HTMLDatListElement.*
1634         - HTMLKeygenElement.*
1635         - HTMLLegendElement.*
1636         - HTMLOutputElement.*
1637         - FormAssociatedElement.*
1638         - SliderThumbElement.*
1639         - TextControlInnerElements.*
1640         - RenderFileUploadControl.*
1641
1642 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1643
1644         Unreviewed, rolling out r109041.
1645         http://trac.webkit.org/changeset/109041
1646         https://bugs.webkit.org/show_bug.cgi?id=79741
1647
1648         Broke Chromium Win build (Requested by bashi on #webkit).
1649
1650         * DumpRenderTree/chromium/LayoutTestController.cpp:
1651         (LayoutTestController::LayoutTestController):
1652         * DumpRenderTree/chromium/LayoutTestController.h:
1653         (LayoutTestController):
1654         * DumpRenderTree/chromium/WebViewHost.h:
1655
1656 2012-02-27  James Robinson  <jamesr@chromium.org>
1657
1658         [chromium] Remove media tests from ChromiumGpu configurations
1659         https://bugs.webkit.org/show_bug.cgi?id=79720
1660
1661         Reviewed by Adam Barth.
1662
1663         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
1664         composited playback path via tests in the compositing/ directory.
1665
1666         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1667         (_default_tests_paths):
1668         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1669         (ChromiumGpuTest.test_default_tests_paths):
1670         (ChromiumGpuTest.test_test_files):
1671
1672 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
1673
1674         nrwt: log multiline stderr/crash output properly
1675         https://bugs.webkit.org/show_bug.cgi?id=79722
1676
1677         Reviewed by Adam Barth.
1678
1679         This cleans up some nits in the log output to make things
1680         slightly easier to read (every line gets timestamped, etc.).
1681
1682         Also tweaks the log message for pixel hash mismatches.
1683
1684         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1685         (SingleTestRunner._handle_error):
1686         (SingleTestRunner._compare_image):
1687
1688 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1689
1690         Touch the master.cfg to force a reconfig.
1691
1692         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1693         (BuildAndTestLeaksFactory):
1694         (NewBuildAndTestFactory):
1695
1696 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
1697
1698         [BlackBerry] Upstream BlackBerry API web page related files
1699         https://bugs.webkit.org/show_bug.cgi?id=74380
1700
1701         Reviewed by Antonio Gomes.
1702
1703         Adapt to the removing of WebPage::mainFrame(), use
1704         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
1705
1706         No new tests as this patch doesn't change behavior.
1707
1708         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1709         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1710         (BlackBerry::WebKit::DumpRenderTree::runTests):
1711
1712 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1713
1714         Add Windows and Linux Chromium perf bots
1715         https://bugs.webkit.org/show_bug.cgi?id=79418
1716
1717         Reviewed by Tony Chang.
1718
1719         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
1720         the dedicated perf bot slave (uses the same hardware).
1721
1722         * BuildSlaveSupport/build.webkit.org-config/config.json:
1723
1724 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1725
1726         Undefined variable 'current' when running chromium_android.py
1727         https://bugs.webkit.org/show_bug.cgi?id=79696
1728
1729         Reviewed by Adam Barth.
1730
1731         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1732         (ChromiumAndroidDriver._read_prompt):
1733
1734 2012-02-27  Greg Billock  <gbillock@google.com>
1735
1736         Add more tests for web intents
1737         https://bugs.webkit.org/show_bug.cgi?id=79527
1738
1739         Reviewed by Adam Barth.
1740
1741         * DumpRenderTree/chromium/LayoutTestController.cpp:
1742         (LayoutTestController::LayoutTestController):
1743         (LayoutTestController::sendWebIntentResponse):
1744         * DumpRenderTree/chromium/LayoutTestController.h:
1745         (LayoutTestController):
1746         * DumpRenderTree/chromium/WebViewHost.h:
1747         (WebViewHost):
1748         (WebViewHost::currentIntentRequest):
1749
1750 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1751
1752         Chromium-Android layout test script: the adb shell prompt is not always '# '
1753         https://bugs.webkit.org/show_bug.cgi?id=79506
1754
1755         Reviewed by Adam Barth.
1756
1757         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1758         (ChromiumAndroidDriver._start):
1759         (ChromiumAndroidDriver._read_prompt):
1760
1761 2012-02-27  Dan Bernstein  <mitz@apple.com>
1762
1763         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
1764         https://bugs.webkit.org/show_bug.cgi?id=79607
1765
1766         Reviewed by Adele Peterson.
1767
1768         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1769         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
1770         (TestWebKitAPI::AcceptsFirstMouse::url):
1771         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
1772         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1773         (TestWebKitAPI::TEST_F):
1774         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
1775
1776 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1777
1778         Unreviewed. Fix make distcheck.
1779
1780         * GNUmakefile.am: Fix typo.
1781
1782 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1783
1784         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
1785
1786         Reviewed by Kenneth Rohde Christiansen..
1787
1788         * qmake/mkspecs/features/features.prf:
1789
1790 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
1791
1792         Add a ChromiumGpuAndroid port.
1793         https://bugs.webkit.org/show_bug.cgi?id=79628
1794
1795         Reviewed by Adam Barth.
1796
1797         Android does have a gpu port, so revert r107697.
1798
1799         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1800         (ChromiumAndroidPort.__init__):
1801         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1802         (ChromiumGpuAndroidPort):
1803         (ChromiumGpuAndroidPort.__init__):
1804         (ChromiumGpuAndroidPort.baseline_search_path):
1805         (ChromiumGpuAndroidPort.default_child_processes):
1806         (ChromiumGpuAndroidPort.tests):
1807         * Scripts/webkitpy/layout_tests/port/factory.py:
1808         (PortFactory):
1809
1810 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1811
1812         Change Build bot with BuildAndTest bot for EFL port.
1813         https://bugs.webkit.org/show_bug.cgi?id=77518
1814
1815         Reviewed by Ryosuke Niwa.
1816
1817         EFL build bot starts to support layout test.
1818
1819         * BuildSlaveSupport/build.webkit.org-config/config.json:
1820         * BuildSlaveSupport/built-product-archive:
1821         (archiveBuiltProduct):
1822         (extractBuiltProduct):
1823         * BuildSlaveSupport/test-result-archive:
1824         (archiveTestResults):
1825         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
1826         (generateBuildSystemFromCMakeProject):
1827
1828 2012-02-24  Darin Fisher  <darin@chromium.org>
1829
1830         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
1831
1832         Reviewed by James Robinson.
1833
1834         * Scripts/webkitpy/common/config/watchlist:
1835
1836 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1837
1838         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
1839         https://bugs.webkit.org/show_bug.cgi?id=79258
1840
1841         Reviewed by Ryosuke Niwa.
1842
1843         Split the fuzzy matching into separate functions so that they
1844         can be sharded and run in parallel.
1845
1846         Also, fix a bug in the svn_blame_regexp that was causing us
1847         to require ChangeLog lines to have at least one space after the
1848         author, making the code require trailing whitespace in the
1849         changelog in some places (this was making my life harder because
1850         I have my text editor set to strip trailing whitespace in python
1851         files, and that was causing test_parse_log_entries_from_changelog() to fail
1852         when the whitespace on line 275 was removed).
1853
1854         * Scripts/webkitpy/common/checkout/changelog.py:
1855         (ChangeLog):
1856         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1857         (test_fuzzy_reviewer_match__none):
1858         (test_fuzzy_reviewer_match_adam_barth):
1859         (test_fuzzy_reviewer_match_darin_adler_et_al):
1860         (test_fuzzy_reviewer_match_dimitri_glazkov):
1861         (test_fuzzy_reviewer_match_george_staikos):
1862         (test_fuzzy_reviewer_match_mark_rowe):
1863
1864 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1865
1866         webkitpy: committers_unittest fuzzy matching is really slow
1867         https://bugs.webkit.org/show_bug.cgi?id=79179
1868
1869         Reviewed by Ryosuke Niwa.
1870
1871         Break the fuzzy matching tests into individual routines for
1872         each contributor so that the intent is a little clearer, so
1873         that it's easier to test individual names (and identify
1874         duplicate tests), and so that we can eventually run
1875         them in parallel.
1876
1877         Also, mark most of them as 'integration' tests so that they
1878         can be skipped if we want to go fast (we leave a few as
1879         regular tests for functional coverage).
1880
1881         * Scripts/webkitpy/common/config/committers_unittest.py:
1882         (CommittersTest):
1883         (CommittersTest.test_contributors_by_fuzzy_match):
1884         (CommittersTest.integration_test_contributors__none):
1885         (CommittersTest.integration_test_contributors__none_2):
1886         (CommittersTest.integration_test_contributors__none_3):
1887         (CommittersTest.integration_test_contributors_ada_chan):
1888         (CommittersTest.integration_test_contributors_adele_peterson):
1889         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
1890         (CommittersTest.integration_test_contributors_alice_liu):
1891         (CommittersTest.integration_test_contributors_alp_toker):
1892         (CommittersTest.integration_test_contributors_anders_carlsson):
1893         (CommittersTest.integration_test_contributors_antti_koivisto):
1894         (CommittersTest.integration_test_contributors_beth_dakin):
1895         (CommittersTest.integration_test_contributors_brady_eidson):
1896         (CommittersTest.integration_test_contributors_cameron_zwarich):
1897         (CommittersTest.integration_test_contributors_chris_blumenberg):
1898         (CommittersTest.integration_test_contributors_dan_bernstein):
1899         (CommittersTest.integration_test_contributors_dan_bernstein_2):
1900         (CommittersTest.integration_test_contributors_darin_adler):
1901         (CommittersTest.integration_test_contributors_david_harrison):
1902         (CommittersTest.integration_test_contributors_david_harrison_2):
1903         (CommittersTest.integration_test_contributors_david_hyatt):
1904         (CommittersTest.integration_test_contributors_david_kilzer):
1905         (CommittersTest.integration_test_contributors_don_melton):
1906         (CommittersTest.integration_test_contributors_eric_seidel):
1907         (CommittersTest.integration_test_contributors_geoffrey_garen):
1908         (CommittersTest.integration_test_contributors_greg_bolsinga):
1909         (CommittersTest.integration_test_contributors_holger_freyther):
1910         (CommittersTest.integration_test_contributors_jon_sullivan):
1911         (CommittersTest.integration_test_contributors_jon_honeycutt):
1912         (CommittersTest.integration_test_contributors_joseph_pecoraro):
1913         (CommittersTest.integration_test_contributors_ken_kocienda):
1914         (CommittersTest.integration_test_contributors_kenneth_russell):
1915         (CommittersTest.integration_test_contributors_kevin_decker):
1916         (CommittersTest.integration_test_contributors_kevin_mccullough):
1917         (CommittersTest.integration_test_contributors_lars_knoll):
1918         (CommittersTest.integration_test_contributors_lars_weintraub):
1919         (CommittersTest.integration_test_contributors_maciej_stachowiak):
1920         (CommittersTest.integration_test_contributors_mark_rowe):
1921         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
1922         (CommittersTest.integration_test_contributors_oliver_hunt):
1923         (CommittersTest.integration_test_contributors_rniwa):
1924         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
1925         (CommittersTest.integration_test_contributors_steve_falkenburg):
1926         (CommittersTest.integration_test_contributors_sam_weinig):
1927         (CommittersTest.integration_test_contributors_tim_omernick):
1928         (CommittersTest.integration_test_contributors_timothy_hatcher):
1929         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
1930         (CommittersTest.integration_test_contributors_vicki_murley):
1931         (CommittersTest.integration_test_contributors_zack_rusin):
1932
1933 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1934
1935         webkitpy: should autoinstall coverage
1936         https://bugs.webkit.org/show_bug.cgi?id=79535
1937
1938         Reviewed by Eric Seidel.
1939
1940         We should automatically print the coverage report after the run, too.
1941
1942         * Scripts/webkitpy/test/main.py:
1943         (Tester._run_tests):
1944         * Scripts/webkitpy/thirdparty/__init__.py:
1945         (AutoinstallImportHook.find_module):
1946         (AutoinstallImportHook._install_coverage):
1947
1948 2012-02-24  Pablo Flouret  <pablof@motorola.com>
1949
1950         Fix copypasta in build-webkit's --vibration option description
1951         https://bugs.webkit.org/show_bug.cgi?id=79528
1952
1953         Reviewed by Andreas Kling.
1954
1955         * Scripts/build-webkit:
1956
1957 2012-02-24  Antonio Gomes  <agomes@rim.com>
1958
1959         Adding myself to ScrollingCoordinator watchlist
1960         https://bugs.webkit.org/show_bug.cgi?id=79525
1961
1962         Reviewed by Rob Buis.
1963
1964         * Scripts/webkitpy/common/config/watchlist:
1965
1966 2012-02-24  Darin Fisher  <darin@chromium.org>
1967
1968         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
1969
1970         Reviewed by Adam Barth.
1971
1972         * Scripts/webkitpy/common/config/watchlist:
1973
1974 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1975
1976         webkitpy: config_unittest is sensitive to other tests that might've already run
1977         https://bugs.webkit.org/show_bug.cgi?id=79382
1978
1979         Reviewed by Adam Barth.
1980
1981         If another test runs prior to config_unittest and pokes the
1982         cached configuration, the first test in config_unittest might
1983         fail; the tearDown() will then allow subsequent tests to pass.
1984         Clearing the configuration prior to each test makes things
1985         slightly slower but safer.
1986
1987         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1988         (ConfigTest.setUp):
1989
1990 2012-02-24  David Kilzer  <ddkilzer@apple.com>
1991
1992         Use xcrun to find compiler paths for Generate Derived Sources build phase script
1993         <http://webkit.org/b/79512>
1994
1995         Reviewed by Dan Bernstein.
1996
1997         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1998         (Generate Derived Sources): Use xcrun to find the path to the
1999         compiler since that works on both iOS and OS X.
2000
2001 2012-02-24  James Robinson  <jamesr@chromium.org>
2002
2003         Create a watchlist for ScrollingCoordinator changes
2004         https://bugs.webkit.org/show_bug.cgi?id=79511
2005
2006         Reviewed by Anders Carlsson.
2007
2008         * Scripts/webkitpy/common/config/watchlist:
2009
2010 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2011
2012         [EFL][DRT] Implement setValueForUser and setAutofilled.
2013         https://bugs.webkit.org/show_bug.cgi?id=79237
2014
2015         Reviewed by Andreas Kling.
2016
2017         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
2018         Those implementations are related with input fields and allow to pass following tests:
2019         fast/forms/onchange-setvalueforuser.html
2020         fast/forms/input-autofilled.html
2021         fast/forms/reset-autofilled.html
2022
2023         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2024         (LayoutTestController::setValueForUser):
2025         (LayoutTestController::setAutofilled):
2026
2027 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2028
2029         [Qt] Allow to use WebCore imagedecoders
2030         https://bugs.webkit.org/show_bug.cgi?id=32410
2031
2032         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2033
2034         Reviewed by Simon Hausmann.
2035
2036         * qmake/mkspecs/features/features.prf:
2037
2038 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
2039
2040         [Qt] Add Qt5 way to force 96 DPI for tests
2041         https://bugs.webkit.org/show_bug.cgi?id=79364
2042
2043         Reviewed by Simon Hausmann.
2044
2045         * DumpRenderTree/qt/main.cpp:
2046         (main):
2047         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2048         (WTR::activateFonts):
2049
2050 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2051
2052         [GTK] MiniBrowser should reload the view then the reload button is clicked
2053         https://bugs.webkit.org/show_bug.cgi?id=79472
2054
2055         Reviewed by Philippe Normand.
2056
2057         * MiniBrowser/gtk/BrowserWindow.c:
2058         (reloadCallback): Call webkit_web_view_reload().
2059         (browser_window_init): Connect reload item clicked even to
2060         reloadCallback instead of activateUriEntryCallback.
2061
2062 2012-02-24  Kentaro Hara  <haraken@chromium.org>
2063
2064         Add performance tests for DOM attribute getters and setters
2065         https://bugs.webkit.org/show_bug.cgi?id=79208
2066
2067         Reviewed by Ryosuke Niwa.
2068
2069         We want to allow perf tests to output info messages
2070         that do not affect the test results. To accomplish this,
2071         this patch modifies perftestsrunner.py so that it ignores
2072         a line that starts from "Info:".
2073
2074         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2075         (PerfTestsRunner):
2076
2077 2012-02-24  Andrew Lo  <anlo@rim.com>
2078
2079         [BlackBerry] Enable requestAnimationFrame
2080         https://bugs.webkit.org/show_bug.cgi?id=79408
2081
2082         Enable requestAnimationFrame for BlackBerry.
2083
2084         Reviewed by Rob Buis.
2085
2086         * Scripts/build-webkit:
2087
2088 2012-02-24  Adam Barth  <abarth@webkit.org>
2089
2090         style-queue tries to apply the patch twice
2091         https://bugs.webkit.org/show_bug.cgi?id=79459
2092
2093         Reviewed by Eric Seidel.
2094
2095         Previously, we applied the patch using both apply-patch and
2096         check-style.  This patch introduces a check-style-local to mirror the
2097         apply-watchlist-local, which operates on the current working diff.
2098
2099         This patch also cleans up some other bugs I found by running the queue
2100         locally for a while.  The queue still prints out a slightly
2101         less-than-ideal message on the bugs when it find an error, but it's ok
2102         for now.  We'll need to iterate a bit.
2103
2104         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2105         (StyleQueueTask.validate):
2106         (StyleQueueTask._check_style):
2107         * Scripts/webkitpy/tool/commands/download.py:
2108         (CheckStyleLocal):
2109         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2110         (EarlyWarningSytemTest._default_expected_stderr):
2111         (EarlyWarningSytemTest._test_testing_ews):
2112         * Scripts/webkitpy/tool/commands/queues.py:
2113         (AbstractReviewQueue.handle_script_error):
2114         (StyleQueue.review_patch):
2115         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2116         * Scripts/webkitpy/tool/commands/queuestest.py:
2117         (QueuesTest.assert_queue_outputs):
2118
2119 2012-02-23  Adam Barth  <abarth@webkit.org>
2120
2121         should_proceed_with_work_item is unused and can be removed
2122         https://bugs.webkit.org/show_bug.cgi?id=79416
2123
2124         Reviewed by Eric Seidel.
2125
2126         We used to use this function to check whether the tree is red.  Now, we
2127         don't use external measures of whether to proceed with work items.
2128         Instead, we analyze them with the idea in mind that the tree might be
2129         red.
2130
2131         * Scripts/webkitpy/tool/bot/queueengine.py:
2132         (QueueEngineDelegate.next_work_item):
2133         (QueueEngine.run):
2134         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2135         (LoggingDelegate):
2136         (LoggingDelegate.next_work_item):
2137         (RaisingDelegate.process_work_item):
2138         (QueueEngineTest.test_terminating_error):
2139         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2140         (AbstractEarlyWarningSystem.__init__):
2141         * Scripts/webkitpy/tool/commands/queues.py:
2142         (AbstractQueue.next_work_item):
2143         (FeederQueue.next_work_item):
2144         (CommitQueue.next_work_item):
2145         (AbstractReviewQueue.next_work_item):
2146         (StyleQueue.__init__):
2147         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2148         (FeederQueueTest.test_feeder_queue):
2149         (CommitQueueTest.test_commit_queue):
2150         (test_commit_queue_failure):
2151         (test_commit_queue_failure_with_failing_tests):
2152         (test_rollout):
2153         (test_rollout_lands):
2154         (StyleQueueTest.test_style_queue_with_style_exception):
2155         (test_style_queue_with_watch_list_exception):
2156         * Scripts/webkitpy/tool/commands/queuestest.py:
2157         (QueuesTest.assert_queue_outputs):
2158         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2159         (SheriffBot.next_work_item):
2160
2161 2012-02-23  Adrienne Walker  <enne@google.com>
2162
2163         Unreviewed, add Stephen Chenney to committers.py as a contributor.
2164
2165         * Scripts/webkitpy/common/config/committers.py:
2166
2167 2012-02-23  Adam Barth  <abarth@webkit.org>
2168
2169         style-queue logs bogus messages to the QueueStatusServer
2170         https://bugs.webkit.org/show_bug.cgi?id=79424
2171
2172         Reviewed by Eric Seidel.
2173
2174         Copy/paste error.
2175
2176         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2177         (StyleQueueTask._check_style):
2178         (StyleQueueTask._apply_watch_list):
2179         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2180
2181 2012-02-23  Eric Seidel  <eric@webkit.org>
2182
2183         Use self._filesystem in more places in the SCM classes
2184         https://bugs.webkit.org/show_bug.cgi?id=79415
2185
2186         Reviewed by Adam Barth.
2187
2188         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2189         (SCMDetectorTest.test_detect_scm_system):
2190         * Scripts/webkitpy/common/checkout/scm/git.py:
2191         (Git.find_checkout_root):
2192         (Git.to_object_name):
2193         * Scripts/webkitpy/common/checkout/scm/scm.py:
2194         (SCM.__init__):
2195         (SCM.in_working_directory):
2196         * Scripts/webkitpy/common/checkout/scm/svn.py:
2197         (SVN.find_uuid):
2198         (SVN.find_checkout_root):
2199
2200 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2201
2202         Unreviewed, rolling out r108685.
2203         http://trac.webkit.org/changeset/108685
2204         https://bugs.webkit.org/show_bug.cgi?id=79414
2205
2206         Broke Chromium builds (Requested by enne on #webkit).
2207
2208         * qmake/mkspecs/features/features.prf:
2209
2210 2012-02-23  Adam Barth  <abarth@webkit.org>
2211
2212         style-queue shouldn't spam bugs if it fails to update its working copy
2213         https://bugs.webkit.org/show_bug.cgi?id=79412
2214
2215         Reviewed by Eric Seidel.
2216
2217         This patch moves style-queue over to the new PatchAnalysisTask
2218         infrastructure, which is smarter about retrying patches when update
2219         fails.
2220
2221         * Scripts/webkitpy/common/system/executive_mock.py:
2222         (MockExecutive.run_and_throw_if_fail):
2223         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2224         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2225         (UnableToApplyPatch):
2226         (UnableToApplyPatch.__init__):
2227         (PatchAnalysisTask.__init__):
2228         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
2229         (StyleQueueTaskDelegate):
2230         (StyleQueueTaskDelegate.parent_command):
2231         (StyleQueueTask):
2232         (StyleQueueTask.validate):
2233         (StyleQueueTask._check_style):
2234         (StyleQueueTask._apply_watch_list):
2235         (StyleQueueTask.run):
2236         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2237         * Scripts/webkitpy/tool/commands/queues.py:
2238         (StyleQueue):
2239         (StyleQueue.should_proceed_with_work_item):
2240         (StyleQueue.review_patch):
2241         (StyleQueue.run_command):
2242         (StyleQueue.command_passed):
2243         (StyleQueue.command_failed):
2244         (StyleQueue.expected_failures):
2245         (StyleQueue.refetch_patch):
2246         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2247         (StyleQueueTest.test_style_queue_with_style_exception):
2248         (test_style_queue_with_watch_list_exception):
2249
2250 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
2251
2252         [Qt] Allow to use WebCore imagedecoders
2253         https://bugs.webkit.org/show_bug.cgi?id=32410
2254
2255         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2256
2257         Reviewed by Simon Hausmann.
2258
2259         * qmake/mkspecs/features/features.prf:
2260
2261 2012-02-23  Eric Seidel  <eric@webkit.org>
2262
2263         Remove old broken find_checkout_root tests now that find_checkout_root is gone
2264         https://bugs.webkit.org/show_bug.cgi?id=79405
2265
2266         Reviewed by Adam Barth.
2267
2268         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
2269         (SCMDetectorTest):
2270         (SCMDetectorTest.test_find_checkout_root):
2271         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2272         (SVNTestRepository.tear_down):
2273
2274 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
2275
2276         [Qt][WK2] Implement proxy authentication dialog.
2277         https://bugs.webkit.org/show_bug.cgi?id=79350
2278
2279         Reviewed by Simon Hausmann.
2280
2281         * MiniBrowser/qt/MiniBrowser.qrc:
2282         * MiniBrowser/qt/qml/BrowserWindow.qml:
2283         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
2284
2285 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
2286
2287         [wx] Build fix, add recently added source dirs.
2288
2289         * waf/build/settings.py:
2290
2291 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
2292
2293         [Qt] Add support for touch cancellation
2294         https://bugs.webkit.org/show_bug.cgi?id=79348
2295
2296         Reviewed by Kenneth Rohde Christiansen.
2297
2298         Added straight-forward touch cancellation event sending to Qt WK1 DRT
2299         and WK2 WTR.
2300
2301         * DumpRenderTree/qt/EventSenderQt.cpp:
2302         (EventSender::touchCancel):
2303         (EventSender::cancelTouchPoint):
2304         * DumpRenderTree/qt/EventSenderQt.h:
2305         (EventSender):
2306         * WebKitTestRunner/EventSenderProxy.h:
2307         (EventSenderProxy):
2308         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2309         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2310         (WTR::EventSendingController::touchCancel):
2311         (WTR):
2312         (WTR::EventSendingController::cancelTouchPoint):
2313         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2314         (EventSendingController):
2315         * WebKitTestRunner/TestController.cpp:
2316         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2317         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2318         (WTR::EventSenderProxy::touchCancel):
2319         (WTR):
2320         (WTR::EventSenderProxy::cancelTouchPoint):
2321
2322 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2323
2324         Unreviewed, rolling out r108626.
2325         http://trac.webkit.org/changeset/108626
2326         https://bugs.webkit.org/show_bug.cgi?id=79370
2327
2328         broke qt-wk2 bot, somehow the workaround does not work on the
2329         bot (Requested by Ossy on #webkit).
2330
2331         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2332         (WTR::WrapperWindow::handleStatusChanged):
2333         (WTR::PlatformWebView::resizeTo):
2334
2335 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
2336
2337         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
2338         https://bugs.webkit.org/show_bug.cgi?id=78481
2339
2340         Reviewed by Gustavo Noronha Silva.
2341
2342         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
2343         to create gdk press key event.
2344         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2345         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2346
2347         * DumpRenderTree/gtk/EventSender.cpp:
2348         (scheduleAsynchronousClickCallback):
2349         (createKeyPressEvent):
2350         (sendKeyDown):
2351         (keyDownCallback):
2352         (sendAsynchronousKeyDown):
2353         (scheduleAsynchronousKeyDownCallback):
2354
2355 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
2356
2357         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2358         https://bugs.webkit.org/show_bug.cgi?id=76546
2359
2360         Reviewed by Simon Hausmann.
2361
2362         Co-authored with Simon Hausmann.
2363
2364         Revert the workaround introduced in r107868 and reintroduce
2365         the qml binding so we can test the code path that we are more
2366         interested in. The reason that it did not work before is that
2367         we don't have an active platform window which we now workaround
2368         by propagating the resize through QWindowSystemInterface.
2369
2370         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2371         (WTR::WrapperWindow::handleStatusChanged):
2372         (WTR::PlatformWebView::resizeTo):
2373
2374 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2375
2376         Unreviewed, rolling out r108577.
2377         http://trac.webkit.org/changeset/108577
2378         https://bugs.webkit.org/show_bug.cgi?id=79359
2379
2380         It doesn't work as expected (Requested by Ossy on #webkit).
2381
2382         * DumpRenderTree/qt/EventSenderQt.cpp:
2383         (EventSender::postEvent):
2384         * DumpRenderTree/qt/EventSenderQt.h:
2385         (EventSender):
2386
2387 2012-02-23  Philippe Normand  <pnormand@igalia.com>
2388
2389         [GTK] FullScreen signals
2390         https://bugs.webkit.org/show_bug.cgi?id=76181
2391
2392         Reviewed by Martin Robinson.
2393
2394         Use the two new entering/leaving fullscreen signals to hide/show
2395         the tool bar, the status bar and ask the user's permission before
2396         entering fullscreen.
2397
2398         * GtkLauncher/main.c:
2399         (webViewFullscreenMessageWindowClose):
2400         (webViewWindowStateEvent):
2401         (hide_widget):
2402         (show_widget):
2403         (webViewEnteringFullScreen):
2404         (webViewLeavingFullScreen):
2405         (createBrowser):
2406         (createWindow):
2407
2408 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
2409
2410         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
2411         https://bugs.webkit.org/show_bug.cgi?id=79076
2412
2413         Reviewed by Andreas Kling.
2414
2415         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
2416         (builtDylibPathForName):
2417
2418 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2419
2420         [Qt] Add eventSender.gestureTap
2421         https://bugs.webkit.org/show_bug.cgi?id=66173
2422
2423         Reviewed by Kenneth Rohde Christiansen.
2424
2425         * DumpRenderTree/qt/EventSenderQt.cpp:
2426         (EventSender::gestureTap):
2427         * DumpRenderTree/qt/EventSenderQt.h:
2428
2429 2012-02-22  Brady Eidson  <beidson@apple.com>
2430
2431         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
2432         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
2433
2434         Reviewed by Anders Carlsson.
2435
2436         Update our tools to the new form of the PageLoadClient.
2437
2438         * MiniBrowser/mac/BrowserWindowController.m:
2439         (-[BrowserWindowController awakeFromNib]): 
2440
2441         * WebKitTestRunner/TestController.cpp:
2442         (WTR::TestController::initialize):
2443
2444 2012-02-22  Daniel Bates  <dbates@webkit.org>
2445
2446         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
2447         https://bugs.webkit.org/show_bug.cgi?id=79277
2448
2449         Reviewed by Adam Barth.
2450
2451         Pass command line argument no-saved-state to run-safari to disable Safari
2452         state restoration for the session on OS 10.7.
2453
2454         * Scripts/webkitpy/layout_tests/port/mac.py:
2455         (MacPort.show_results_html_file):
2456         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2457         (test_show_results_html_file):
2458
2459 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
2460
2461         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
2462         https://bugs.webkit.org/show_bug.cgi?id=77759
2463
2464         Reviewed by Tony Chang.
2465
2466         Fixes build with gcc 4.7.
2467
2468         r100432 added the include only for ANDROID; this changes the ifdef to
2469         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
2470         longer implicitly includes unistd.h from standard headers and other
2471         unix platforms are likely to get gcc 4.7 as well in the future.
2472
2473         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2474
2475 2012-02-22  Philippe Normand  <pnormand@igalia.com>
2476
2477         Unreviewed, rolling out r108522.
2478         http://trac.webkit.org/changeset/108522
2479         https://bugs.webkit.org/show_bug.cgi?id=76181
2480
2481         Broke 4 fullscreen tests on GTK.
2482
2483         * GtkLauncher/main.c:
2484         (createBrowser):
2485         (createWindow):
2486
2487 2012-02-20  Philippe Normand  <pnormand@igalia.com>
2488
2489         [GTK] FullScreen signals
2490         https://bugs.webkit.org/show_bug.cgi?id=76181
2491
2492         Reviewed by Martin Robinson.
2493
2494         Use the two new entering/leaving fullscreen signals to hide/show
2495         the tool bar, the status bar and ask the user's permission before
2496         entering fullscreen.
2497
2498         * GtkLauncher/main.c:
2499         (webViewFullscreenMessageWindowClose):
2500         (webViewWindowStateEvent):
2501         (hide_widget):
2502         (show_widget):
2503         (webViewEnteringFullScreen):
2504         (webViewLeavingFullScreen):
2505         (createBrowser):
2506         (createWindow):
2507
2508 2012-02-22  Rob Flack  <flackr@chromium.org>
2509
2510         Update Linux ChromiumOS builders in flakiness dashboard.
2511         https://bugs.webkit.org/show_bug.cgi?id=79238
2512
2513         Reviewed by Ojan Vafai.
2514
2515         * TestResultServer/static-dashboards/builders.js:
2516
2517 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2518
2519         webkitpy: test_function_length_check_definition_huge_lines is slow
2520         https://bugs.webkit.org/show_bug.cgi?id=79185
2521
2522         Reviewed by Adam Barth.
2523
2524         This test takes ~3 seconds to run, apparently because we're
2525         running a test on a 10,000 line function :). Dropping the
2526         function length to 640 still exercises the code path and
2527         provides a 10x speedup.
2528
2529         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2530         (CppStyleTest):
2531         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
2532
2533 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2534
2535         webkitpy: speed up FileLockTest.test_lock_lifecycle
2536         https://bugs.webkit.org/show_bug.cgi?id=79189
2537
2538         Reviewed by Adam Barth.
2539
2540         The unit test had a second lock trying to acquire a
2541         lock already held, and a hard-coded timeout of one second.
2542         I have changed the timeouts to a tenth of a second (which
2543         is probably still fine) and changed the hard-spin on
2544         the lock to a slow-spin every hundredth of a second.
2545
2546         * Scripts/webkitpy/common/system/file_lock.py:
2547         (FileLock.acquire_lock):
2548         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2549         (FileLockTest.setUp):
2550         (FileLockTest.test_stuck_lock):
2551
2552 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
2553
2554         build-webkit should use environment variable at number of CPU
2555         detection on all platform
2556         https://bugs.webkit.org/show_bug.cgi?id=79227
2557
2558         Reviewed by Martin Robinson.
2559
2560         * Scripts/webkitdirs.pm:
2561         (determineNumberOfCPUs):
2562
2563 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
2564
2565         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
2566         https://bugs.webkit.org/show_bug.cgi?id=78960
2567
2568         Reviewed by Csaba Osztrogonác.
2569
2570         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2571         (LayoutTestController::overridePreference):
2572
2573 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
2574
2575         [chromium] Build WebKit with MEDIA_STREAM disabled.
2576         https://bugs.webkit.org/show_bug.cgi?id=79214
2577
2578         Reviewed by Kent Tamura.
2579
2580         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2581         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
2582         * DumpRenderTree/chromium/WebViewHost.cpp:
2583         (WebViewHost::createMediaPlayer):
2584         * DumpRenderTree/chromium/WebViewHost.h:
2585         (WebViewHost):
2586
2587 2012-02-22  Zeno Albisser  <zeno@webkit.org>
2588
2589         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
2590         https://bugs.webkit.org/show_bug.cgi?id=79124
2591
2592         WebKitTestRunnerPrefix.h should also be included
2593         when building with clang.
2594
2595         Reviewed by Kenneth Rohde Christiansen.
2596
2597         * WebKitTestRunner/Target.pri:
2598
2599 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
2600
2601         <style scoped>: Add runtime-flag
2602         https://bugs.webkit.org/show_bug.cgi?id=79074
2603
2604         Enable the runtime-flag for DRT. 
2605
2606         Reviewed by Dimitri Glazkov.
2607
2608         * DumpRenderTree/chromium/TestShell.cpp:
2609         (TestShell::TestShell):
2610
2611 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2612
2613         Unreviewed, rolling out r107351.
2614         http://trac.webkit.org/changeset/107351
2615         https://bugs.webkit.org/show_bug.cgi?id=53600
2616
2617         Several issues introduced in WebKitGTK+ API
2618
2619         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2620         (createWebView):
2621         * GtkLauncher/main.c:
2622         (createWebViewCb):
2623         (createBrowser):
2624         (createWindow):
2625         (main):
2626
2627 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
2628
2629         JSC should be a triple-tier VM
2630         https://bugs.webkit.org/show_bug.cgi?id=75812
2631         <rdar://problem/10079694>
2632
2633         Reviewed by Gavin Barraclough.
2634
2635         Changed EFL's build system to include a new directory in JavaScriptCore.
2636
2637         * DumpRenderTree/efl/CMakeLists.txt:
2638
2639 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
2640
2641         [chromium] Fix image drag out on Chromium
2642         https://bugs.webkit.org/show_bug.cgi?id=79158
2643
2644         Reviewed by Tony Chang.
2645
2646         * DumpRenderTree/chromium/EventSender.cpp:
2647         (EventSender::dumpFilenameBeingDragged):
2648         (EventSender::beginDragWithFiles):
2649         * DumpRenderTree/chromium/WebViewHost.cpp:
2650         (addDRTFakeFileToDataObject):
2651
2652 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2653
2654         webkitpy: speed up hot filesystem_mock functions
2655         https://bugs.webkit.org/show_bug.cgi?id=79159
2656
2657         Reviewed by Adam Barth.
2658
2659         Profiling run_webkit_tests_integrationtest.py revealed that
2660         isdir(), normpath(), and join() are called a lot and were very
2661         slow.This patch speeds them up substantially, shaving 20 seconds
2662         off of the execution time.
2663
2664         * Scripts/webkitpy/common/system/filesystem_mock.py:
2665         (MockFileSystem.isdir):
2666         (MockFileSystem._slow_but_correct_join):
2667         (MockFileSystem.join):
2668         (MockFileSystem.listdir):
2669         (MockFileSystem._slow_but_correct_normpath):
2670         (MockFileSystem.normpath):
2671         (MockFileSystem.write_binary_file):
2672         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2673         (MockFileSystemTest.quick_check):
2674         (MockFileSystemTest):
2675         (MockFileSystemTest.test_join):
2676         (MockFileSystemTest.test_normpath):
2677         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2678         (get_test_config): Call write_binary_file() instead of updating
2679           filesystem.files directly, so that we create directories as
2680           needed.
2681
2682 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2683
2684         nrwt: make the delay between starting workers configurable per-port
2685         https://bugs.webkit.org/show_bug.cgi?id=79148
2686
2687         Reviewed by Eric Seidel.
2688
2689         Because of bug 79147, we have to sleep a bit in between starting
2690         DRTs; however, doing so across the board slows down the Test
2691         port. Making this configurable shaves 10 seconds off of
2692         run_webkit_tests_integrationtest.py
2693         
2694         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2695         (Manager._run_tests):
2696         * Scripts/webkitpy/layout_tests/port/base.py:
2697         (Port.worker_startup_delay_secs):
2698         * Scripts/webkitpy/layout_tests/port/test.py:
2699         (TestPort.worker_startup_delay_secs):
2700
2701 2012-02-21  Jon Lee  <jonlee@apple.com>
2702
2703         Bring notifications support to WK1 mac
2704         https://bugs.webkit.org/show_bug.cgi?id=78783
2705         <rdar://problem/10610578>
2706
2707         Reviewed by Anders Carlsson.
2708
2709         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
2710         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2711         (-[UIDelegate timerFired]):
2712
2713 2012-02-21  Kentaro Hara  <haraken@chromium.org>
2714
2715         Enable the IDL attribute checker in run-bindings-tests
2716         https://bugs.webkit.org/show_bug.cgi?id=79091
2717
2718         Reviewed by Adam Barth.
2719
2720         We have enabled the IDL attribute checker in Chromium in r108322.
2721         This patch enables the IDL attribute checker in run-bindings-tests.
2722
2723         No tests. I manually checked that [Custommm], [CallWith=],
2724         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
2725         run-bindings-tests failures.
2726
2727         * Scripts/webkitpy/bindings/main.py:
2728         (BindingsTests.generate_supplemental_dependency):
2729
2730 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
2731
2732         Add rafaelw as a committer.
2733
2734         Unreviewed.
2735
2736         * Scripts/webkitpy/common/config/committers.py:
2737
2738 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2739
2740         webkitpy: update names after deleting message_broker
2741         https://bugs.webkit.org/show_bug.cgi?id=79000
2742
2743         Reviewed by Eric Seidel.
2744
2745         Part 3 of 3 in deleting message_broker.py; this change just
2746         adjusts the names for the newly merged symbols so that they are
2747         private as appropriate.
2748
2749         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2750         (get):
2751         (_Broker):
2752         (_BrokerConnection):
2753         (_BrokerConnection.__init__):
2754         (AbstractWorker.__init__):
2755         (_ManagerConnection):
2756         (_ManagerConnection.__init__):
2757         (_WorkerConnection):
2758         (_WorkerConnection.__init__):
2759
2760 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2761
2762         webkitpy: merge message_broker.py into manager_worker_broker.py
2763         https://bugs.webkit.org/show_bug.cgi?id=78999
2764
2765         Reviewed by Tony Chang.
2766
2767         This is pretty much a straight cut-and-paste of one file into
2768         another (broken up so that docstrings and imports are in the
2769         right place).
2770
2771         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2772         (BrokerClient):
2773         (BrokerClient.is_done):
2774         (BrokerClient.name):
2775         (Broker):
2776         (Broker.__init__):
2777         (Broker.add_topic):
2778         (Broker._get_queue_for_topic):
2779         (Broker.post_message):
2780         (Broker.run_message_loop):
2781         (Broker.run_all_pending):
2782         (Broker._run_loop):
2783         (Broker._dispatch_message):
2784         (_Message):
2785         (_Message.loads):
2786         (_Message.__init__):
2787         (_Message.dumps):
2788         (_Message.__repr__):
2789         (BrokerConnection):
2790         (BrokerConnection.__init__):
2791         (BrokerConnection.run_message_loop):
2792         (BrokerConnection.post_message):
2793         (BrokerConnection.raise_exception):
2794         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
2795
2796 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2797
2798         webkitpy: prepare to delete message_broker.py
2799         https://bugs.webkit.org/show_bug.cgi?id=78997
2800
2801         Reviewed by Eric Seidel.
2802
2803         This is part 1 of 3 changes to fix bug 78187. This change
2804         prepares the code for merging message_broker.py into
2805         manager_worker_broker.py; the tests in message_broker_unittest
2806         are merged into manager_worker_broker_unittest, the symbols
2807         needed by the tests are exported from manager_worker_broker.py,
2808         and manager_worker_broker itself is updated to refer to the
2809         symbols directly (without the module prefix).
2810
2811         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2812         (get):
2813         (AbstractWorker):
2814         (AbstractWorker.__init__):
2815         (_ManagerConnection):
2816         (_ManagerConnection.__init__):
2817         (_WorkerConnection):
2818         (_WorkerConnection.__init__):
2819         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2820         (InterfaceTest.test_brokerclient_is_abstract):
2821         (InterfaceTest.test_brokerclient_is_abstract.methods):
2822         (MessageTest):
2823         (MessageTest.test__no_body):
2824         (MessageTest.test__body):
2825         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
2826
2827 2012-02-21  Sam Weinig  <sam@webkit.org>
2828
2829         Attempt to fix the Snow Leopard build.
2830
2831         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2832         * MiniBrowser/Configurations/Base.xcconfig:
2833         * TestWebKitAPI/Configurations/Base.xcconfig:
2834         * WebKitTestRunner/Configurations/Base.xcconfig:
2835
2836 2012-02-21  Sam Weinig  <sam@webkit.org>
2837
2838         Use libc++ when building with Clang on Mac
2839         https://bugs.webkit.org/show_bug.cgi?id=78981
2840
2841         Reviewed by Dan Bernstein.
2842
2843         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2844         * MiniBrowser/Configurations/Base.xcconfig:
2845         * TestWebKitAPI/Configurations/Base.xcconfig:
2846         * WebKitTestRunner/Configurations/Base.xcconfig:
2847
2848 2012-02-21  Adam Roben  <aroben@apple.com>
2849
2850         Roll out r108309, r108323, and r108326
2851
2852         They broke the 32-bit Lion build.
2853
2854         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
2855
2856         * DumpRenderTree/efl/CMakeLists.txt:
2857
2858 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
2859
2860         [Qt][WK2] Get rid of the dependency to QtWidgets
2861         https://bugs.webkit.org/show_bug.cgi?id=76276
2862
2863         Reviewed by Simon Hausmann.
2864
2865         * MiniBrowser/qt/MiniBrowser.pro:
2866         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2867         (MiniBrowserApplication::MiniBrowserApplication):
2868         (MiniBrowserApplication::notify):
2869         (MiniBrowserApplication::sendTouchEvent):
2870         * MiniBrowser/qt/MiniBrowserApplication.h:
2871         (MiniBrowserApplication):
2872         * QtTestBrowser/locationedit.h:
2873         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2874         (WTR::activateFonts):
2875         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2876
2877 2012-02-20  Adam Barth  <abarth@webkit.org>
2878
2879         mastercfg_unittest.py fails without simplejson
2880         https://bugs.webkit.org/show_bug.cgi?id=79070
2881
2882         Reviewed by Csaba Osztrogonác.
2883
2884         Now that we require Python 2.6 (and higher) we can import json rather
2885         than simplejson.  We still need to use the simplejson name because
2886         that's what the master.cfg script expects.
2887
2888         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2889         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
2890
2891 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
2892
2893         JSC should be a triple-tier VM
2894         https://bugs.webkit.org/show_bug.cgi?id=75812
2895         <rdar://problem/10079694>
2896
2897         Reviewed by Gavin Barraclough.
2898
2899         Changed EFL's build system to include a new directory in JavaScriptCore.
2900
2901         * DumpRenderTree/efl/CMakeLists.txt:
2902
2903 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
2904
2905         Update pywebsocket to 0.7.2
2906         https://bugs.webkit.org/show_bug.cgi?id=79066
2907
2908         This version includes vendor-prefixed deflate-frame extension support.
2909
2910         Reviewed by Kent Tamura.
2911
2912         * Scripts/webkitpy/thirdparty/__init__.py:
2913         (AutoinstallImportHook._install_pywebsocket):
2914
2915 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2916
2917         [UNIX] Plugin information fields are not interpreted as UTF-8
2918         https://bugs.webkit.org/show_bug.cgi?id=78635
2919
2920         Reviewed by Gustavo Noronha Silva.
2921
2922         Interpret plugin metadata as UTF8 aways. This matches the behavior
2923         of Chromium and the Totem plugin.
2924
2925         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2926         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
2927
2928 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2929
2930         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
2931         https://bugs.webkit.org/show_bug.cgi?id=78935
2932
2933         Reviewed by Gustavo Noronha Silva.
2934
2935         Move the TestNetscapePlugin headers to a more appropriate directory and update
2936         the build files to match.
2937
2938         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
2939         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
2940         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
2941         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
2942         * GNUmakefile.am: Ditto.
2943
2944 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
2945
2946         Add a new API for the Vibration API(W3C).
2947         https://bugs.webkit.org/show_bug.cgi?id=72010
2948
2949         Reviewed by Hajime Morita.
2950
2951         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
2952
2953 2012-02-20  János Badics  <dicska@gmail.com>
2954
2955         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
2956         https://bugs.webkit.org/show_bug.cgi?id=71816
2957
2958         RunQtAPITests will notify if a timeout occurs during testing.
2959         Added unittest to the master.cfg
2960
2961         Reviewed by Csaba Osztrogonác.
2962
2963         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2964         (RunQtAPITests.evaluateCommand):
2965         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2966         (RunQtAPITestsTest):
2967         (RunQtAPITestsTest.assertResults):
2968         (RunQtAPITestsTest.test_timeout):
2969         (test_success):
2970         (test_failure):
2971         (test_timeout_and_failure):
2972
2973 2012-02-20  Andy Wingo  <wingo@igalia.com>
2974
2975         Add wingo as a committer.
2976
2977         Unreviewed.
2978
2979         * Scripts/webkitpy/common/config/committers.py: Add myself to the
2980         committers list.
2981
2982 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
2983
2984         [chromium] check that we're not running multiple modal dialogs at the same time
2985         https://bugs.webkit.org/show_bug.cgi?id=78486
2986
2987         Reviewed by Kent Tamura.
2988
2989         * DumpRenderTree/chromium/TestShell.cpp:
2990         (TestShell::TestShell):
2991         * DumpRenderTree/chromium/TestShell.h:
2992         (TestShell::setIsDisplayingModalDialog):
2993         (TestShell::isDisplayingModalDialog):
2994         (TestShell):
2995         * DumpRenderTree/chromium/WebViewHost.cpp:
2996         (WebViewHost::runModal):
2997
2998 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2999
3000         Fix WebKit2GTK+ for 'make distcheck'.
3001
3002         Instead of conditionally including WebKit2 GNUmakefiles, always
3003         include them and conditionally activate the final targets.
3004
3005         * MiniBrowser/gtk/GNUmakefile.am:
3006         * WebKitTestRunner/GNUmakefile.am:
3007
3008 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3009
3010         Enable video option for EFL port in build-webkit.
3011         https://bugs.webkit.org/show_bug.cgi?id=79006
3012
3013         Reviewed by Daniel Bates.
3014
3015         * Scripts/build-webkit:
3016
3017 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
3018
3019         [EFL] Use modifier keys to execute pre-rendering.
3020         https://bugs.webkit.org/show_bug.cgi?id=77933
3021
3022         Reviewed by Chang Shu.
3023
3024         Use modifier key to execute pre-rendering instead of using reserved function keys.
3025
3026         * EWebLauncher/main.c:
3027         (on_key_down):
3028
3029 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3030
3031         Fix one more dangling reference to worker_connection.name, delete unused code.
3032
3033         Unreviewed, build fix.
3034
3035         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3036         (Manager.update):
3037         (_WorkerState.__init__):
3038
3039 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3040
3041         Add a change that should've been in r108005.
3042
3043         Unreviewed, build fix.
3044
3045         In the refactoring/cleanup in r108005 I should've changed the
3046         implementation of WorkerConnection to make it match BrokerClient
3047         (and everything else) so that objects had a name() method
3048         instead of a name property.
3049
3050         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3051         (Manager._run_tests):
3052         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3053         (_WorkerConnection.__init__):
3054         (_WorkerConnection.name):
3055         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3056         (_TestWorker.__init__):
3057         (_TestsMixin.name):
3058         (_TestsMixin.test_name):
3059         (_TestsMixin.test_cancel):
3060         (_TestsMixin.test_unknown_message):
3061
3062 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3063
3064         webkitpy: remove webkitpy.common.array_stream
3065         https://bugs.webkit.org/show_bug.cgi?id=78952
3066
3067         Reviewed by Eric Seidel.
3068
3069         Turns out array_stream didn't really do anything that StringIO
3070         didn't do (at least as of Python 2.6). This change removes it
3071         and updates all of the callers. Where possible, I changed the
3072         test assertions in order to capture the intent more clearly,
3073         e.g., instead of calling self.assertTrue('foo' in stream.get()),
3074         we have self.assertContainsLine(stream, 'foo'), and instead of
3075         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
3076         the latter isn't that much more readable, but StringIO doesn't
3077         export an empty() method.
3078
3079         * Scripts/webkitpy/common/array_stream.py: Removed.
3080         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
3081         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3082         (passing_run):
3083         (run_and_capture):
3084         (StreamTestingMixin):
3085         (StreamTestingMixin.assertContains):
3086         (StreamTestingMixin.assertContainsLine):
3087         (StreamTestingMixin.assertEmpty):
3088         (StreamTestingMixin.assertNotEmpty):
3089         (LintTest):
3090         (LintTest.test_lint_test_files):
3091         (LintTest.test_lint_test_files__errors):
3092         (MainTest):
3093         (MainTest.test_child_process_1):
3094         (MainTest.test_child_processes_2):
3095         (MainTest.test_child_processes_min):
3096         (MainTest.test_help_printing):
3097         (MainTest.test_hung_thread):
3098         (MainTest.test_no_tests_found):
3099         (MainTest.test_no_tests_found_2):
3100         (MainTest.test_repeat_each_iterations_num_tests):
3101         (MainTest.test_test_list):
3102         (MainTest.test_unexpected_failures):
3103         (MainTest.test_worker_model__inline_with_child_processes):
3104         (MainTest.test_additional_platform_directory):
3105         (RebaselineTest):
3106         (RebaselineTest.assertBaselines):
3107         (RebaselineTest.test_reset_results):
3108         (RebaselineTest.test_missing_results):
3109         (RebaselineTest.test_new_baseline):
3110         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3111         (MeteredStream.update):
3112         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3113         (TestMeteredStream.test_regular):
3114         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3115         (TestUtilityFunctions.assertEmpty):
3116         (TestUtilityFunctions):
3117         (TestUtilityFunctions.assertNotEmpty):
3118         (TestUtilityFunctions.assertWritten):
3119         (TestUtilityFunctions.test_configure_logging):
3120         (Testprinter.assertEmpty):
3121         (Testprinter):
3122         (Testprinter.assertNotEmpty):
3123         (Testprinter.assertWritten):
3124         (Testprinter.reset):
3125         (Testprinter.get_printer):
3126         (Testprinter.test_help_printer):
3127         (Testprinter.do_switch_tests.do_helper):
3128         (Testprinter.test_print_one_line_summary):
3129         (Testprinter.test_print_test_result):
3130         (Testprinter.test_print_progress):
3131         (Testprinter.test_write_nothing):
3132         (Testprinter.test_write_misc):
3133         (Testprinter.test_write_everything):
3134         (Testprinter.test_write_verbose):
3135         (Testprinter.test_print_unexpected_results):
3136         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3137         (MainTest.assertWritten):
3138         (create_runner):
3139         (test_run_test_set):
3140         (test_run_test_set_kills_drt_per_run):
3141         (test_run_test_set_for_parser_tests):
3142         (test_run_test_set_with_json_output):
3143         (test_run_test_set_with_json_source):
3144         (test_run_test_set_with_multiple_repositories):
3145         (test_upload_json):
3146
3147 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3148
3149         [wx] Add the WebCore/page/scrolling directory to the build dirs.
3150
3151         * waf/build/settings.py:
3152
3153 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3154
3155         [wx] Unreviewed build fix. Don't error out or hang if we have
3156         downloaded dependencies but server update check fails.
3157
3158         * waf/build/build_utils.py:
3159         (download_if_newer):
3160
3161 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3162
3163         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
3164         https://bugs.webkit.org/show_bug.cgi?id=69444
3165
3166         Reviewed by Tony Chang.
3167
3168         Currently if a test's image checksum doesn't match the checksum
3169         in the baseline, but the images themselves match according to
3170         ImageDiff, new-run-webkit-tests ignores the problem. This is
3171         probably bad, but it's not yet clear what the right thing to do
3172         is. This patch will log a warning to stderr, at least (but the
3173         test will still pass).
3174
3175         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3176         (SingleTestRunner._compare_image):
3177         (SingleTestRunner._run_reftest):
3178         * Scripts/webkitpy/layout_tests/port/test.py:
3179         (unit_test_list):
3180         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3181
3182 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3183
3184         NRWT does not report failure for a skipped test
3185         https://bugs.webkit.org/show_bug.cgi?id=78750
3186
3187         Reviewed by Eric Seidel.
3188
3189         If a test is listed in a Skipped file and you run it anyway
3190         with --force, and the test fails, currently NRWT will print
3191         "test ran as expected"; this is confusing, because you probably
3192         expect the test to fail and yet this might lead you to think the
3193         test passed. This patch changes the expected behavior to "PASS",
3194         so tests that fail will be reported.
3195
3196         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3197         (result_was_expected):
3198         (TestExpectationParser):
3199         (TestExpectationParser.expectation_for_skipped_test):
3200         (TestExpectations):
3201         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3202         (test_add_skipped_tests):
3203         * Scripts/webkitpy/layout_tests/port/test.py:
3204         (unit_test_list): Add some tests that are expected to be in a Skipped file.
3205         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
3206
3207 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3208
3209         webkitpy: fix test code after bug 78181
3210         https://bugs.webkit.org/show_bug.cgi?id=78870
3211
3212         Reviewed by Adam Barth.
3213
3214         I forgot to update the test code as per Tony's suggestion in
3215         bug 78181 (r108005). This change does that, and in doing so
3216         it revealed a subtle bug in _InlineWorkerConnection.run() that
3217         I am fixing as part of this (_alive would not be cleared if an
3218         exception was thrown).
3219
3220         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3221         (_InlineWorkerConnection.run):
3222         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3223         (_TestWorker.__init__):
3224         (_TestWorker.handle_stop):
3225         (_TestWorker.handle_test):
3226         (_TestWorker.run):
3227         (_TestsMixin.handle_exception):
3228         (_TestsMixin.test_unknown_message):
3229
3230 2012-02-17  Adam Roben  <aroben@apple.com>
3231
3232         Mac build fix after r108119
3233
3234         * DumpRenderTree/mac/DumpRenderTree.mm:
3235         (runThread):
3236         (runPthread):
3237         (testThreadIdentifierMap):
3238         Updated to match current WTF threading APIs.
3239
3240 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3241
3242         revert r107147 - breaks webkit-patch on Mac SL
3243         https://bugs.webkit.org/show_bug.cgi?id=78866
3244
3245         Reviewed by Adam Barth.
3246
3247         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
3248         which is the version that ships on Mac SL. Reverting this
3249         change until we no longer have to worry about that version.
3250
3251         * Scripts/webkitpy/common/system/autoinstall.py:
3252         (AutoInstaller):
3253         (AutoInstaller._extract_all): Added a comment about SL.
3254         (AutoInstaller._unzip):
3255
3256 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
3257
3258         CSS regions enabled by default
3259         https://bugs.webkit.org/show_bug.cgi?id=78525
3260
3261         Reviewed by David Hyatt.
3262
3263         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
3264         CSSRegions are still enabled by default.
3265         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
3266
3267         * DumpRenderTree/chromium/LayoutTestController.cpp:
3268         (LayoutTestController::overridePreference):
3269         * DumpRenderTree/chromium/WebPreferences.cpp:
3270         (WebPreferences::reset):
3271         (WebPreferences::applyTo):
3272         * DumpRenderTree/chromium/WebPreferences.h:
3273         (WebPreferences):
3274         * DumpRenderTree/mac/DumpRenderTree.mm:
3275         (resetDefaultsToConsistentValues):
3276
3277 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
3278
3279         Some API tests erroneously use = instead of == (causing build failures)
3280         https://bugs.webkit.org/show_bug.cgi?id=78915
3281
3282         Reviewed by Sam Weinig.
3283
3284         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3285         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
3286         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
3287
3288 2012-02-17  Peter Beverloo  <peter@chromium.org>
3289
3290         [Chromium] Include TestShellLinux.cpp in the build for Android
3291         https://bugs.webkit.org/show_bug.cgi?id=78865
3292
3293         Reviewed by Eric Seidel.
3294
3295         Android will be re-using the TestShellLinux.cpp file. I already
3296         added this r104033, but it seems to have gotten lost in the
3297         recent refactorings.
3298
3299         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3300
3301 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3302
3303         Unreviewed, disable video build on EFL until it can be
3304         supported by EFL build bot.
3305
3306         * Scripts/build-webkit:
3307
3308 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3309
3310         [GTK] Implement zoom in/out in MiniBrowser
3311         https://bugs.webkit.org/show_bug.cgi?id=75253
3312
3313         Reviewed by Gustavo Noronha Silva.
3314
3315         * MiniBrowser/gtk/BrowserWindow.c:
3316         (browserWindowCanZoomIn):
3317         (browserWindowCanZoomOut):
3318         (browserWindowUpdateZoomActions):
3319         (webViewZoomLevelChanged):
3320         (zoomInCallback):
3321         (zoomOutCallback):
3322         (browser_window_init):
3323         (browserWindowConstructed):
3324
3325 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
3326
3327         layoutTestController.display() is flaky for SVG tests
3328         https://bugs.webkit.org/show_bug.cgi?id=78021
3329
3330         Reviewed by Adam Roben.
3331
3332         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
3333         Size the web view before running the test, not when dumping.
3334         All platforms handle this correctly now.
3335
3336         * DumpRenderTree/win/DumpRenderTree.cpp:
3337         (dump):
3338         (sizeWebViewForCurrentTest):
3339         (runTest):
3340
3341 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3342
3343         [GTK] Make install is broken when building without --enable-gtk-doc
3344         https://bugs.webkit.org/show_bug.cgi?id=78828
3345
3346         Reviewed by Martin Robinson.
3347
3348         * gtk/generate-gtkdoc:
3349         (rebase_installed_docs): Check documentation has been generated
3350         before trying to rebase it.
3351
3352 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
3353
3354         nrwt: simplify worker interface
3355         https://bugs.webkit.org/show_bug.cgi?id=78181
3356
3357         Reviewed by Tony Chang.
3358
3359         This change moves code in name(), is_done(), run(), and cancel()
3360         from Worker to AbstractWorker, since the logic is pretty much
3361         boilerplate code that any implementation would want to use.
3362
3363         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3364         (get.should):
3365         (AbstractWorker.__init__):
3366         (AbstractWorker):
3367         (AbstractWorker.name):
3368         (AbstractWorker.stop_handling_messages):
3369         (AbstractWorker.run):
3370         (AbstractWorker.is_done):
3371         (AbstractWorker.cancel):
3372         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3373         (Worker.__init__):
3374         (Worker.run):
3375         (Worker.handle_stop):
3376
3377 2012-02-16  Michael Saboff  <msaboff@apple.com>
3378
3379         ENH: Add ability to run subset of JavaScript layout tests with JSC
3380         https://bugs.webkit.org/show_bug.cgi?id=78764
3381
3382         Reviewed by Gavin Barraclough.
3383
3384         New simple test drive shell script that runs a defined
3385         list of javascript tests using jsc and the standalone-{pre,post}.js
3386         wrappers.
3387
3388         * Scripts/run-fast-jsc: Added.
3389
3390 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
3391
3392         Add new Qt performance tester bot to build.webkit.org
3393         https://bugs.webkit.org/show_bug.cgi?id=78795
3394
3395         Reviewed by Adam Roben.
3396
3397         * BuildSlaveSupport/build.webkit.org-config/config.json:
3398
3399 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
3400
3401         Disable inspector on WinCE.
3402
3403         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
3404
3405         * Scripts/build-webkit:
3406
3407 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
3408
3409         WinCE build fix after r107656.
3410
3411         Disable FTPDIR on WinCE, since it does not compile there.
3412
3413         * Scripts/build-webkit:
3414
3415 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
3416
3417         Build fix after r107863.
3418
3419         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3420
3421 2012-02-15  Tony Chang  <tony@chromium.org>
3422
3423         [chromium] add linux dbg back to garden-o-matic
3424         https://bugs.webkit.org/show_bug.cgi?id=78752
3425
3426         Reviewed by Adam Barth.
3427
3428         This reflects the current linux debug bot name (there's only one bot).
3429         I'm also remove the mac clang builder since it doesn't exist (mac
3430         always uses clang now).
3431
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3433         * Scripts/webkitpy/layout_tests/port/builders.py:
3434
3435 2012-02-15  Sam Weinig  <sam@webkit.org>
3436
3437         Add style check for ctype functions that are generally frowned upon in WebKit
3438         https://bugs.webkit.org/show_bug.cgi?id=78748
3439
3440         Reviewed by Anders Carlsson.
3441
3442         Not every platform has DisallowCType.h to check for uses of the ctype.h
3443         functions, so add a style check for them as well.
3444
3445         * Scripts/webkitpy/style/checkers/cpp.py:
3446         (check_ctype_functions):
3447         (check_style):
3448         (CppChecker):
3449         Add check.
3450
3451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3452         (WebKitStyleTest.test_ctype_fucntion):
3453         Add checker.
3454
3455 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
3456
3457         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
3458         https://bugs.webkit.org/show_bug.cgi?id=76546
3459
3460         Reviewed by Simon Hausmann.
3461
3462         Resize the web view programatically because the declarative property binding
3463         does not work. Seems like our qml environment is not initialized fully but it
3464         needs more investigation.
3465
3466         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3467         (WTR::WrapperWindow::handleStatusChanged):
3468         (WTR::PlatformWebView::resizeTo):
3469
3470 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
3471
3472         webkitpy: add a worker_args concept to start_worker()
3473         https://bugs.webkit.org/show_bug.cgi?id=78572
3474
3475         Reviewed by Tony Chang.
3476
3477         This change replaces the three NRWT-specific arguments passed
3478         through the broker to the worker with a generic WorkerArguments
3479         wrapper class and a separate set_inline_arguments() call that can
3480         be used to pass additional data to the worker when it is running
3481         in the same process as the manager (this is needed for testing).
3482         With the addition of set_inline_arguments() we also no longer
3483         need to pass an optional argument to the worker.run() call.
3484
3485         Note that this method is *only* implemented on inline workers,
3486         so calling this on a regular (child process) worker will result
3487         in a runtime error.
3488
3489         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3490         (Manager._run_tests):
3491         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3492         (AbstractWorker.__init__):
3493         (AbstractWorker.run):
3494         (_ManagerConnection.start_worker):
3495         (_InlineManager.start_worker):
3496         (_InlineManager.set_inline_arguments):
3497         (_InlineManager.run_message_loop):
3498         (_MultiProcessManager.start_worker): Reworked signature.
3499         (_WorkerConnection.__init__):
3500         (_InlineWorkerConnection.__init__):
3501         (_InlineWorkerConnection.set_inline_arguments): New method.
3502         (_InlineWorkerConnection):
3503         (_InlineWorkerConnection.run):
3504         (_Process.run):
3505         (_MultiProcessWorkerConnection.__init__):
3506         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3507         (_TestWorker.__init__):
3508         (_TestWorker.set_inline_arguments):
3509         (_TestWorker.handle_test):
3510         (_TestWorker.run):
3511         (_TestsMixin.test_cancel):
3512         (_TestsMixin.test_done):
3513         (_TestsMixin.test_unknown_message):
3514         (InlineBrokerTests): New class for more testing.
3515         (InlineBrokerTests.setUp):
3516         (InlineBrokerTests.test_inline_arguments): New test.
3517         (InterfaceTest.test_managerconnection_is_abstract):
3518         (InterfaceTest.test_workerconnection_is_abstract):
3519         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3520         (WorkerArguments):
3521         (WorkerArguments.__init__):
3522         (Worker.__init__):
3523         (Worker.set_inline_arguments):
3524         (Worker):
3525         (Worker.run):
3526         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
3527         (WorkerTest.test_default_platform_in_worker):
3528
3529 2012-02-15  Adam Klein  <adamk@chromium.org>
3530
3531         Unreviewed, rolling out r107704.
3532         http://trac.webkit.org/changeset/107704
3533         https://bugs.webkit.org/show_bug.cgi?id=78486
3534
3535         Caused layout test crashes in debug builds.
3536
3537         Specific crashing tests:
3538
3539         fast/events/show-modal-dialog-onblur-onfocus.html
3540         fast/harness/show-modal-dialog.html
3541         inspector/console/console-long-eval-crash.html
3542
3543         * DumpRenderTree/chromium/TestShell.cpp:
3544         (TestShell::TestShell):
3545         * DumpRenderTree/chromium/TestShell.h:
3546         (TestShell):
3547         * DumpRenderTree/chromium/WebViewHost.cpp:
3548         (WebViewHost::runModal):
3549
3550 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
3551
3552         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
3553         https://bugs.webkit.org/show_bug.cgi?id=76347
3554
3555         Reviewed by Kenneth Rohde Christiansen.
3556
3557         * MiniBrowser/qt/MiniBrowser.qrc:
3558         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
3559         * MiniBrowser/qt/qml/BrowserWindow.qml:
3560         * MiniBrowser/qt/qml/DialogLineInput.qml:
3561
3562 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
3563
3564         [Qt] Fix WebGL in QtTestBrowser
3565
3566         Reviewed by Tor Arne Vestbø.
3567
3568         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
3569         the options for enabling GL we also pass them on properly.
3570
3571 2012-02-14  Sam Weinig  <sam@webkit.org>
3572
3573         Add #include of unistd.h on the mac for getcwd. 
3574
3575         Reviewed by Anders Carlsson.
3576
3577         This is necessary when building with libc++.
3578
3579         * WebKitTestRunner/TestInvocation.cpp:
3580
3581 2012-02-14  Sam Weinig  <sam@webkit.org>
3582
3583         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
3584         https://bugs.webkit.org/show_bug.cgi?id=78663
3585
3586         Reviewed by Anders Carlsson.
3587
3588         * DumpRenderTree/DumpRenderTreePrefix.h:
3589         * DumpRenderTree/cg/ImageDiffCG.cpp:
3590
3591 2012-02-14  Adam Barth  <abarth@webkit.org>
3592
3593         Implement an adb-based driver for the ChromiumAndroidPort
3594         https://bugs.webkit.org/show_bug.cgi?id=78627
3595
3596         Reviewed by Eric Seidel.
3597
3598         This driver mostly just wires up the ChromiumDriver through adb.  In
3599         some cases, it translates protocol elements, such as URIs, so that the
3600         rest of webkitpy is insulated from the "remoteness" of the target device.
3601
3602         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3603         (ChromiumAndroidPort.start_helper):
3604         (ChromiumAndroidPort._driver_class):
3605         (ChromiumAndroidPort._update_version):
3606         (ChromiumAndroidPort._get_stderr):
3607         (ChromiumAndroidPort):
3608         (ChromiumAndroidPort._get_last_stacktrace):
3609         (ChromiumAndroidPort._teardown_performance):
3610         (ChromiumAndroidDriver):
3611         (ChromiumAndroidDriver.__init__):
3612         (ChromiumAndroidDriver._start):
3613         (ChromiumAndroidDriver.run_test):
3614         (ChromiumAndroidDriver.stop):
3615         (ChromiumAndroidDriver._test_shell_command):
3616         (ChromiumAndroidDriver._write_command_and_read_line):
3617         (ChromiumAndroidDriver._output_image):
3618         (ChromiumAndroidDriver._has_crash_hint):
3619
3620 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3621
3622         webkitpy: the real_name() method in the Port class is no longer needed
3623         https://bugs.webkit.org/show_bug.cgi?id=78651
3624
3625         Reviewed by Eric Seidel.
3626
3627         The change in bug 78565 / r107718 made it no longer necessary
3628         (we can use options.platform instead).
3629
3630         * Scripts/webkitpy/layout_tests/port/base.py:
3631         (Port.name):
3632         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3633         (MockDRTPort.__init__):
3634
3635 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3636
3637         webkitpy: clean up options, port handling in manager_worker_broker
3638         https://bugs.webkit.org/show_bug.cgi?id=78568
3639
3640         Reviewed by Tony Chang.
3641
3642         manager_worker_broker no longer needs options or port objects
3643         directly, so we make them only be passed in start_worker().
3644
3645         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3646         (Manager._run_tests):
3647         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3648         (get):
3649         (_ManagerConnection.__init__):
3650         (_ManagerConnection.start_worker):
3651         (_InlineManager.__init__):
3652         (_InlineManager.start_worker):
3653         (_InlineManager.run_message_loop):
3654         (_MultiProcessManager.__init__):
3655         (_MultiProcessManager):
3656         (_MultiProcessManager.start_worker):
3657         (_InlineWorkerConnection.__init__):
3658         (_InlineWorkerConnection.run):
3659         (_Process.__init__):
3660         (_MultiProcessWorkerConnection.__init__):
3661         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3662         (make_broker):
3663         (_TestWorker.run):
3664         (_TestsMixin.test_cancel):
3665         (_TestsMixin.test_done):
3666         (_TestsMixin.test_unknown_message):
3667         (MultiProcessBrokerTests.setUp):
3668         (InterfaceTest.test_managerconnection_is_abstract):
3669         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
3670         (Broker.__init__):
3671
3672 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3673
3674         nrwt: add a unit test for regression introduced in bug 78565
3675         https://bugs.webkit.org/show_bug.cgi?id=78646
3676
3677         Reviewed by Tony Chang.
3678
3679         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
3680         (FakeConnection):
3681         (FakeConnection.run_message_loop):
3682         (FakeConnection.post_message):
3683         (WorkerTest):
3684         (WorkerTest.test_default_platform_in_worker):
3685
3686 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3687
3688         NRWT is broken for the default port
3689         https://bugs.webkit.org/show_bug.cgi?id=78640
3690     
3691         Reviewed by Tony Chang.
3692
3693         The change in r107718 (bug 78565) broke NRWT if you didn't
3694         specify any sort of --platform flag or equivalent. I didn't
3695         catch this because it's a full integration test (which we don't
3696         have an automated test for) and I missed this command line
3697         variant when testing interactively.
3698
3699         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3700         (Worker.run):
3701
3702 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
3703
3704         Last character display for passwords in Android.
3705         https://bugs.webkit.org/show_bug.cgi?id=78532
3706
3707         Reviewed by Adam Barth.
3708
3709         * DumpRenderTree/chromium/WebPreferences.cpp:
3710         (WebPreferences::applyTo):
3711
3712 2012-02-14  Adam Barth  <abarth@webkit.org>
3713
3714         Finish implementing start_helper for ChromiumAndroidPort
3715         https://bugs.webkit.org/show_bug.cgi?id=78582
3716
3717         Reviewed by Eric Seidel.
3718
3719         This patch contains the remaining odds and ends for the start_helper function.
3720
3721         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3722         (ChromiumAndroidPort.start_helper):
3723         (ChromiumAndroidPort._synchronize_datetime):
3724         (ChromiumAndroidPort):
3725         (ChromiumAndroidPort._check_version):
3726         (ChromiumAndroidPort._run_adb_command):
3727         (ChromiumAndroidPort._copy_device_file):
3728
3729 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3730
3731         webkitpy: create ports in Workers, not in manager_worker_broker
3732         https://bugs.webkit.org/show_bug.cgi?id=78565
3733
3734         Reviewed by Tony Chang.
3735
3736         We will now create the Port object (if necessary) in the Worker
3737         directly, so that the manager_worker_broker module doesn't need
3738         all of this layout_test-specific logic. Part of the fixes for
3739         bug 78171.
3740
3741         These changes are all well-tested by the existing tests in
3742         run_webkit_tests_integrationtest.py.
3743
3744         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3745         (_Process.run):
3746         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3747         (Worker.__init__):
3748         (Worker.safe_init):
3749         (Worker.run):
3750         (Worker.cleanup):
3751         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3752         (parse_args):
3753         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
3754
3755 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
3756
3757         [chromium] check that we're not running multiple modal dialogs at the same time
3758         https://bugs.webkit.org/show_bug.cgi?id=78486
3759
3760         Reviewed by Kent Tamura.
3761
3762         * DumpRenderTree/chromium/TestShell.cpp:
3763         (TestShell::TestShell):
3764         * DumpRenderTree/chromium/TestShell.h:
3765         (TestShell::setIsDisplayingModalDialog):
3766         (TestShell::isDisplayingModalDialog):
3767         (TestShell):
3768         * DumpRenderTree/chromium/WebViewHost.cpp:
3769         (WebViewHost::runModal):
3770
3771 2012-02-14  Adam Barth  <abarth@webkit.org>
3772
3773         Enable the GPU codepath in the chromium-android port
3774         https://bugs.webkit.org/show_bug.cgi?id=78580
3775
3776         Reviewed by James Robinson.
3777
3778         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
3779         Android always uses the GPU codepath, so we set the GPU flags on the
3780         main chromium-android port instead.
3781
3782         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3783         (ChromiumAndroidPort.__init__):
3784
3785 2012-02-14  Adam Barth  <abarth@webkit.org>
3786
3787         NRWT should expose --adb-args flag for Android
3788         https://bugs.webkit.org/show_bug.cgi?id=78579
3789
3790         Reviewed by Eric Seidel.
3791
3792         This flag is already wired up to the ChromiumAndroidPort.
3793
3794         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3795         (parse_args):
3796
3797 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
3798
3799         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
3800         https://bugs.webkit.org/show_bug.cgi?id=78541
3801         <rdar://problem/10036695>
3802
3803         Reviewed by Kent Tamura.
3804
3805         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
3806         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
3807         After each test, reset to using new protocol.
3808
3809 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
3810
3811         Convert svg/animations to use SMIL methods for driving the timeline
3812         https://bugs.webkit.org/show_bug.cgi?id=78422
3813
3814         Reviewed by Dirk Schulze.
3815
3816         Remove no longer needed SVG specific animation sampling functionality from DRT.
3817         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
3818
3819         * DumpRenderTree/LayoutTestController.cpp:
3820         (LayoutTestController::staticFunctions):
3821         * DumpRenderTree/LayoutTestController.h:
3822         (LayoutTestController):
3823         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3824         * DumpRenderTree/chromium/LayoutTestController.cpp:
3825         (LayoutTestController::LayoutTestController):
3826         * DumpRenderTree/chromium/LayoutTestController.h:
3827         (LayoutTestController):
3828         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3829         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3830         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3831         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3832         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3833         (LayoutTestController):
3834         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3835         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3836
3837 2012-02-13  Rob Flack  <flackr@chromium.org>
3838
3839         Add Linux ChromiumOS test results to flakiness dashboard.
3840         https://bugs.webkit.org/show_bug.cgi?id=78495
3841
3842         Reviewed by Ojan Vafai.
3843
3844         * TestResultServer/static-dashboards/builders.js:
3845         * TestResultServer/static-dashboards/dashboard_base.js:
3846
3847 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
3848
3849         [GTK] Mutation Observers build is broken
3850         https://bugs.webkit.org/show_bug.cgi?id=78433
3851
3852         Reviewed by Martin Robinson.
3853
3854         Enabled mutation observers as a default feature for GTK port, too.
3855
3856         * Scripts/build-webkit:
3857
3858 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
3859
3860         Allow to configure ENABLE_FTPDIR in build-webkit
3861         https://bugs.webkit.org/show_bug.cgi?id=65098
3862
3863         Reviewed by Eric Seidel.
3864
3865         Allow to disable ENABLE_FTPDIR by command line.
3866         Remove ENABLE_FTPDIR from --minimal build
3867
3868         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
3869         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
3870         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
3871
3872 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
3873
3874         Add shinyak as committer.
3875
3876         Unreviewed.
3877
3878         * Scripts/webkitpy/common/config/committers.py:
3879
3880 2012-02-13  Adam Barth  <abarth@webkit.org>
3881
3882         Implement start/stop_helper for ChromiumAndroidPort
3883         https://bugs.webkit.org/show_bug.cgi?id=78558
3884
3885         Reviewed by Dirk Pranke.
3886
3887         These functions (and their dependencies) set up the Android device for
3888         testing.
3889
3890         This patch also includes a few tweaks on the previous patch recommended
3891         by dpranke.
3892
3893         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3894         (ChromiumAndroidPort.__init__):
3895         (ChromiumAndroidPort.start_helper):
3896         (ChromiumAndroidPort.stop_helper):
3897         (ChromiumAndroidPort._shut_down_http_server):
3898         (ChromiumAndroidPort):
3899         (ChromiumAndroidPort._push_executable):
3900         (ChromiumAndroidPort._push_fonts):
3901         (ChromiumAndroidPort._restore_system_font):
3902         (ChromiumAndroidPort._push_test_resources):
3903         (ChromiumAndroidPort._push_to_device):
3904         (ChromiumAndroidPort._pull_from_device):
3905         (ChromiumAndroidPort._kill_device_process):
3906         (ChromiumAndroidPort._setup_performance):
3907         (ChromiumAndroidPort._teardown_performance):
3908         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3909         (ChromiumAndroidPortTest):
3910         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3911         (PortTestCase):
3912         (PortTestCase.make_port):
3913         (PortTestCase.test_default_worker_model):
3914
3915 2012-02-13  Adam Barth  <abarth@webkit.org>
3916
3917         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
3918         https://bugs.webkit.org/show_bug.cgi?id=78550
3919
3920         Reviewed by Eric Seidel.
3921
3922         Much of this code just forwards to the "host" port, which seems like a
3923         reasonable thing to do.
3924
3925         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3926         (ChromiumAndroidPort.__init__):
3927         (ChromiumAndroidPort.stop_helper):
3928         (ChromiumAndroidPort):
3929         (ChromiumAndroidPort._build_path):
3930         (ChromiumAndroidPort._path_to_apache):
3931         (ChromiumAndroidPort._path_to_apache_config_file):
3932         (ChromiumAndroidPort._path_to_driver):
3933         (ChromiumAndroidPort._path_to_helper):
3934         (ChromiumAndroidPort._path_to_image_diff):
3935         (ChromiumAndroidPort._path_to_lighttpd):
3936         (ChromiumAndroidPort._path_to_lighttpd_modules):
3937         (ChromiumAndroidPort._path_to_lighttpd_php):
3938         (ChromiumAndroidPort._path_to_wdiff):
3939         (ChromiumAndroidPort._shut_down_http_server):
3940         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3941         (ChromiumAndroidPortTest):
3942         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3943         (PortTestCase):
3944         (PortTestCase.make_port):
3945         (PortTestCase.test_default_worker_model):
3946
3947 2012-02-13  Adam Barth  <abarth@webkit.org>
3948
3949         chromium_android.py should implement "virtual" methods from ChromiumPort
3950         https://bugs.webkit.org/show_bug.cgi?id=78545
3951
3952         Reviewed by Dirk Pranke.
3953
3954         This patch adds basic implementations that specialize a bunch of
3955         functions from ChromiumPort.
3956
3957         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3958         (ChromiumAndroidPort):
3959         (ChromiumAndroidPort.__init__):
3960         (ChromiumAndroidPort.default_child_processes):
3961         (ChromiumAndroidPort.baseline_search_path):
3962         (ChromiumAndroidPort.check_build):
3963         (ChromiumAndroidPort.check_sys_deps):
3964         (ChromiumAndroidPort.default_worker_model):
3965         (ChromiumAndroidPort.test_expectations):
3966         (ChromiumAndroidPort.start_http_server):
3967         (ChromiumAndroidPort.stop_http_server):
3968         (ChromiumAndroidPort.start_helper):
3969         (ChromiumAndroidPort.stop_helper):
3970
3971 2012-02-13  Adam Barth  <abarth@webkit.org>
3972
3973         Add a skeleton ChromiumAndroid port to webkitpy
3974         https://bugs.webkit.org/show_bug.cgi?id=78543
3975
3976         Reviewed by Eric Seidel.
3977
3978         This patch just adds an empty ChromiumAndroid port object to webkitpy
3979         and wires it up to the factory objects.  An actual implementation will
3980         follow.
3981
3982         * Scripts/webkitpy/layout_tests/port/chromium.py:
3983         (ChromiumPort):
3984         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
3985         (ChromiumAndroidPort):
3986         (ChromiumAndroidPort.__init__):
3987         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3988         (ChromiumPortTest.test_all_test_configurations):
3989         * Scripts/webkitpy/layout_tests/port/factory.py:
3990         (PortFactory):
3991
3992 2012-02-13  Adam Barth  <abarth@webkit.org>
3993
3994         NRWT's HTTP servers should support additional directories for resources
3995         https://bugs.webkit.org/show_bug.cgi?id=78528
3996
3997         Reviewed by Eric Seidel.
3998
3999         This functionality will be used by the Chromium-Android port.
4000
4001         * Scripts/webkitpy/layout_tests/port/base.py:
4002         (Port.to.start_http_server):
4003         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4004         (LayoutTestApacheHttpd.__init__):
4005         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4006         (Lighttpd.__init__):
4007         (Lighttpd._prepare_config):
4008
4009 2012-02-13  Ami Fischman  <fischman@chromium.org>
4010
4011         Add fischman as committer.
4012
4013         Unreviewed
4014
4015         * Scripts/webkitpy/common/config/committers.py:
4016
4017 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
4018
4019         [EFL] Drop support for the Curl network backend.
4020         https://bugs.webkit.org/show_bug.cgi?id=77874
4021
4022         Reviewed by Eric Seidel.
4023
4024         Nobody seems to be maintaining the Curl backend in WebCore, the
4025         EFL port developers all seem to be using the Soup backend and the
4026         port itself has many features which are only implemented for the
4027         latter.
4028
4029         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
4030         and always add the required include directories.
4031         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
4032         include directories and link to them.
4033
4034 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
4035
4036         [WebSocket] Update pywebsocket to 0.7.1
4037         https://bugs.webkit.org/show_bug.cgi?id=78484
4038
4039         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
4040
4041         Reviewed by Kent Tamura.
4042
4043         * Scripts/webkitpy/thirdparty/__init__.py:
4044         (AutoinstallImportHook._install_pywebsocket):
4045
4046 2012-02-12  Kangil Han  <kangil.han@samsung.com>
4047
4048         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
4049         https://bugs.webkit.org/show_bug.cgi?id=78091
4050
4051         Reviewed by Hajime Morita.
4052
4053         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
4054         This patch will activate around 1,900 test cases from skipped list in EFL port.
4055
4056         * DumpRenderTree/efl/EventSender.cpp:
4057         (textZoom):
4058         (pageZoom):
4059         (textZoomInCallback):
4060         (textZoomOutCallback):
4061         (zoomPageInCallback):
4062         (zoomPageOutCallback):
4063
4064 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
4065
4066         KeywordLookupGenerator.py script fails in some cases
4067         https://bugs.webkit.org/show_bug.cgi?id=77886
4068
4069         Reviewed by Benjamin Poulain.
4070
4071         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
4072         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
4073         (GlobalVariablesTest.test_path_rules_specifier):
4074
4075 2012-02-12  Joe Thomas  <joethomas@motorola.com>
4076
4077         Add toText and isTextNode helpers in Text class.
4078         https://bugs.webkit.org/show_bug.cgi?id=78140
4079
4080         Unit test case for the new style checker introduced.
4081
4082         Reviewed by Adam Barth.
4083
4084         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4085         (CppStyleTest):
4086         (CppStyleTest.test_static_cast_readability): Added a unit test case.
4087
4088 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4089
4090         Enable features supported by EFL port in build-webkit.
4091         https://bugs.webkit.org/show_bug.cgi?id=78348
4092
4093         Reviewed by Ryosuke Niwa.
4094
4095         Sync build-webkit with OptionEfl.cmake, as some features enabled in
4096         OptionEfl.cmake are not enabled in build-webkit.
4097
4098         * Scripts/build-webkit:
4099
4100 2012-02-12  Joe Thomas  <joethomas@motorola.com>
4101
4102         Add toText and isTextNode helpers in Text class.
4103         https://bugs.webkit.org/show_bug.cgi?id=78140
4104
4105         Added a style checker to use toText rather than static_cast<Text*>.
4106
4107         Reviewed by Adam Barth.
4108
4109         * Scripts/webkitpy/style/checkers/cpp.py:
4110         (check_language): Style checker for static_cast<Text*>.
4111
4112 2012-02-12  Philippe Normand  <pnormand@igalia.com>
4113
4114         Unreviewed, disable Mutation observers build on GTK until it can
4115         actually build.
4116
4117         * Scripts/build-webkit:
4118
4119 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
4120
4121         Add back WTFURL to WebKit
4122         https://bugs.webkit.org/show_bug.cgi?id=77291
4123
4124         Reviewed by Adam Barth.
4125
4126         Add a flag to build-webkit to easily build WebKit with WTFURL.
4127
4128         * Scripts/build-webkit:
4129
4130 2012-02-10  Adam Klein  <adamk@chromium.org>
4131
4132         Enable MUTATION_OBSERVERS by default on all platforms
4133         https://bugs.webkit.org/show_bug.cgi?id=78196
4134
4135         Reviewed by Ojan Vafai.
4136
4137         * Scripts/build-webkit:
4138
4139 2012-02-10  Adam Barth  <abarth@webkit.org>
4140
4141         Move garden-o-matic's All Failures out of experimental
4142         https://bugs.webkit.org/show_bug.cgi?id=78395
4143
4144         Reviewed by Dimitri Glazkov.
4145
4146         Several folks have tried this feature and found it useful.
4147
4148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4149
4150 2012-02-10  Tim Horton  <timothy_horton@apple.com>
4151
4152         NRWT should categorize options in --help
4153         https://bugs.webkit.org/show_bug.cgi?id=76221
4154
4155         Reviewed by Eric Seidel.
4156         
4157         Use optparse's OptionGroup mechanism to logically group NRWT's options,
4158         providing a better experience when scanning all the options.
4159
4160         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4161         (parse_args):
4162
4163 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
4164
4165         [Qt][WK2] Refactor on Qt5 Layout tests' structure
4166         https://bugs.webkit.org/show_bug.cgi?id=77450
4167
4168         Reviewed by Csaba Osztrogonác.
4169
4170         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
4171         to qt-5.0-wk2 and qt-5.0-wk1.
4172
4173         * Scripts/old-run-webkit-tests:
4174         (buildPlatformResultHierarchy):
4175         (readSkippedFiles):
4176         * Scripts/webkitpy/layout_tests/port/qt.py:
4177         (QtPort._wk2_port_name):
4178         (QtPort._skipped_file_search_paths):
4179         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4180         (QtPortTest.test_baseline_search_path):
4181         * Scripts/webkitpy/layout_tests/port/webkit.py:
4182         (WebKitPort._wk2_port_name):
4183
4184 2012-02-09  Philippe Normand  <pnormand@igalia.com>
4185
4186         [GTK] EWS command-line option to run the tests
4187         https://bugs.webkit.org/show_bug.cgi?id=78211
4188
4189         Reviewed by Adam Barth.
4190
4191         New --run-tests option (defaults to False) for the EWS commands.
4192
4193         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4194         (AbstractEarlyWarningSystem):
4195         (AbstractEarlyWarningSystem.__init__):
4196         (AbstractEarlyWarningSystem.review_patch):
4197         (ChromiumLinuxEWS):
4198         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4199         (EarlyWarningSytemTest._test_builder_ews):
4200
4201 2012-02-09  Eric Seidel  <eric@webkit.org>
4202
4203         Rename compare_text and compare_audio to make it clear that they're !=
4204         https://bugs.webkit.org/show_bug.cgi?id=78301
4205
4206         Reviewed by Adam Barth.
4207
4208         I also removed the maybe_create_directory function which was redundant.
4209
4210         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4211         (Manager.set_up_run):
4212         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4213         (TestResultWriter._make_output_directory):
4214         * Scripts/webkitpy/layout_tests/port/base.py:
4215         (Port.do_text_results_differ):
4216         (Port.do_audio_results_differ):
4217         (Port.diff_text):
4218         (Port.driver_name):
4219         (Port.skips_perf_test):
4220         * Scripts/webkitpy/layout_tests/port/win.py:
4221         (WinPort.do_text_results_differ):
4222         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4223         (WinPortTest.test_do_text_results_differ):
4224         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4225         (LayoutTestApacheHttpd.__init__):
4226         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4227         (HttpServerBase.__init__):
4228         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
4229         (Rebaseliner._diff_baselines):
4230
4231 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
4232
4233         [GTK] Add DRT support for modal dialogs
4234         https://bugs.webkit.org/show_bug.cgi?id=53600
4235
4236         Reviewed by Martin Robinson.
4237
4238         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
4239         Most significantly, when creating a new web view in GtkLauncher, the window
4240         of the web view opener is passed around. In DumpRenderTree, the window of
4241         the main web view is always considered as the opener. This is required so
4242         the modal dialog's toplevel can be made transient for the opener's toplevel.
4243
4244         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4245         (webViewRunModalDialog):
4246         (createWebView):
4247         * GtkLauncher/main.c:
4248         (createWebViewCb):
4249         (runModalDialogCb):
4250         (createBrowser):
4251         (createWindow):
4252         (main):
4253
4254 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
4255
4256         [Gtk] security/set-form-autocomplete-attribute.html fails
4257         https://bugs.webkit.org/show_bug.cgi?id=78261
4258
4259         Reviewed by Martin Robinson.
4260
4261         Use the new helper in DumpRenderTreeSupportGtk to properly
4262         test whether an element performs autocompletion.
4263
4264         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4265         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
4266
4267 2012-02-09  James Robinson  <jamesr@chromium.org>
4268
4269         [chromium] Enable mock scrollbars for compositing layout tests
4270         https://bugs.webkit.org/show_bug.cgi?id=78299
4271
4272         Reviewed by Dirk Pranke.
4273
4274         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
4275         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
4276         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
4277
4278         * DumpRenderTree/chromium/TestShell.cpp:
4279         (TestShell::runFileTest):
4280         * DumpRenderTree/chromium/WebPreferences.cpp:
4281         (WebPreferences::reset):
4282         (WebPreferences::applyTo):
4283         * DumpRenderTree/chromium/WebPreferences.h:
4284         (WebPreferences):
4285
4286 2012-02-09  Eric Seidel  <eric@webkit.org>
4287
4288         Remove more uses of "os" from our webkitpy code
4289         https://bugs.webkit.org/show_bug.cgi?id=78292
4290
4291         Reviewed by Adam Barth.
4292
4293         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4294         (MockCheckout.__init__):
4295         (MockCheckout.is_path_to_changelog):
4296         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4297         * Scripts/webkitpy/common/system/filesystem_mock.py:
4298         (MockFileSystem._split):
4299         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
4300         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4301         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4302         * Scripts/webkitpy/layout_tests/port/webkit.py:
4303         * Scripts/webkitpy/tool/bot/queueengine.py:
4304         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
4305         * Scripts/webkitpy/tool/commands/download.py:
4306         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4307         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4308         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4309         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4310         * Scripts/webkitpy/tool/commands/upload.py:
4311         (CreateBug.prompt_for_bug_title_and_comment):
4312         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
4313         * Scripts/webkitpy/tool/steps/attachtobug.py:
4314         (AttachToBug.run):
4315         * Scripts/webkitpy/tool/steps/checkstyle.py:
4316         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4317         * Scripts/webkitpy/tool/steps/commit_unittest.py:
4318         * Scripts/webkitpy/tool/steps/editchangelog.py:
4319         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4320         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4321         (PrepareChangeLogTest.test_ensure_bug_url):
4322         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
4323         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4324         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4325         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4326
4327 2012-02-09  Eric Seidel  <eric@webkit.org>
4328
4329         Remove the cr-mac-ews (it's long been dead)
4330         https://bugs.webkit.org/show_bug.cgi?id=78267
4331
4332         Reviewed by Adam Barth.
4333
4334         * QueueStatusServer/model/queues.py:
4335         (Queue):
4336         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4337         (ChromiumWindowsEWS):
4338         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4339         (EarlyWarningSytemTest._test_builder_ews):
4340         (EarlyWarningSytemTest._test_testing_ews):
4341
4342 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
4343
4344         some tests in webkitpy are being run three times
4345         https://bugs.webkit.org/show_bug.cgi?id=78283
4346
4347         Reviewed by Ryosuke Niwa.
4348
4349         It turns out that if you import a class derived from
4350         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
4351         the unittest framework treats it as if the class was defined in
4352         the file (as well in the original file). This led us to running
4353         the tests in ChangeLogTest three times.
4354
4355         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4356         (PrepareChangeLogTest):
4357         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
4358         (_assert_message_for_revert_output):
4359
4360 2012-02-09  Adam Barth  <abarth@webkit.org>
4361
4362         Remove extraneous line in previous patch.  I forgot to remove this
4363         before landing.
4364
4365         * Scripts/webkitpy/layout_tests/port/driver.py:
4366         (DriverProxy.start):
4367
4368 2012-02-09  Adam Barth  <abarth@webkit.org>
4369
4370         run-perf-tests should have an option to pause before running tests so we can attach Instruments
4371         https://bugs.webkit.org/show_bug.cgi?id=78271
4372
4373         Reviewed by Ryosuke Niwa.
4374
4375         This lets me attach instruments to profile the performance of the test.
4376
4377         * Scripts/webkitpy/layout_tests/port/chromium.py:
4378         (ChromiumDriver.start):
4379         * Scripts/webkitpy/layout_tests/port/driver.py:
4380         (Driver.start):
4381         (DriverProxy.start):
4382         * Scripts/webkitpy/layout_tests/port/server_process.py:
4383         (ServerProcess.start):
4384         * Scripts/webkitpy/layout_tests/port/test.py:
4385         (TestDriver.start):
4386         * Scripts/webkitpy/layout_tests/port/webkit.py:
4387         (WebKitDriver.start):
4388         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4389         (get_tests_run.RecordingTestDriver.start):
4390         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4391         (PerfTestsRunner._parse_args):
4392         (PerfTestsRunner._run_tests_set):
4393         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4394         (start):
4395         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
4396         (test_run_test_set_kills_drt_per_run):
4397         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
4398         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
4399
4400 2012-02-09  Adam Barth  <abarth@webkit.org>
4401
4402         run-perf-tests --chromium should run the chromium port
4403         https://bugs.webkit.org/show_bug.cgi?id=78266
4404
4405         Reviewed by Ryosuke Niwa.
4406
4407         This patch makes run-perf-tests work more like run-webkit-tests.
4408
4409         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4410         (PerfTestsRunner._parse_args):
4411
4412 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
4413
4414         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
4415         https://bugs.webkit.org/show_bug.cgi?id=77466
4416
4417         Reviewed by Dirk Pranke.
4418
4419         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
4420         is set or if we should raise an error. A unit test was added.
4421
4422         * Scripts/webkitpy/layout_tests/port/qt.py:
4423         (QtPort.operating_system):
4424         (QtPort):
4425         (QtPort.check_sys_deps):