Ensure to use compatible liborc version with wanted gstreamer version
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
2
3         Ensure to use compatible liborc version with wanted gstreamer version
4         https://bugs.webkit.org/show_bug.cgi?id=153276
5
6         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
7         The user may have a very recent liborc installed on his system.
8
9         Reviewed by Philippe Normand.
10
11         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
12         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
13
14 2016-01-21  Nan Wang  <n_wang@apple.com>
15
16         AX: [IOS] Implement next/previous text marker functions using TextIterator
17         https://bugs.webkit.org/show_bug.cgi?id=153292
18         <rdar://problem/24268243>
19
20         Reviewed by Chris Fleizach.
21
22         Made text marker tests available on iOS.
23
24         * DumpRenderTree/AccessibilityTextMarker.h:
25         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
26         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
27         (AccessibilityTextMarker::AccessibilityTextMarker):
28         (AccessibilityTextMarker::~AccessibilityTextMarker):
29         (AccessibilityTextMarker::isEqual):
30         (AccessibilityTextMarker::platformTextMarker):
31         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
32         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
33         (AccessibilityTextMarkerRange::isEqual):
34         (AccessibilityTextMarkerRange::platformTextMarkerRange):
35         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
36         (AccessibilityUIElement::pathDescription):
37         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
38         (AccessibilityUIElement::textMarkerRangeForElement):
39         (AccessibilityUIElement::selectedTextMarkerRange):
40         (AccessibilityUIElement::resetSelectedTextMarkerRange):
41         (AccessibilityUIElement::textMarkerRangeLength):
42         (AccessibilityUIElement::textMarkerRangeForMarkers):
43         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
44         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
45         (AccessibilityUIElement::accessibilityElementForTextMarker):
46         (AccessibilityUIElement::endTextMarkerForBounds):
47         (AccessibilityUIElement::startTextMarkerForBounds):
48         (AccessibilityUIElement::textMarkerForPoint):
49         (AccessibilityUIElement::previousTextMarker):
50         (AccessibilityUIElement::nextTextMarker):
51         (AccessibilityUIElement::stringForTextMarkerRange):
52         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
53         (AccessibilityUIElement::indexForTextMarker):
54         (AccessibilityUIElement::isTextMarkerValid):
55         (AccessibilityUIElement::textMarkerForIndex):
56         (AccessibilityUIElement::startTextMarker):
57         (AccessibilityUIElement::endTextMarker):
58         (AccessibilityUIElement::setSelectedVisibleTextRange):
59         (AccessibilityUIElement::getLinkedUIElements):
60         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
61         (AccessibilityTextMarkerRange::platformTextMarkerRange):
62         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
63         (AccessibilityUIElement::removeSelection):
64         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
65         (AccessibilityUIElement::setSelectedVisibleTextRange):
66         (AccessibilityUIElement::supportedActions):
67         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
68         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
69         (WTR::AccessibilityUIElement::textMarkerRangeLength):
70         (WTR::AccessibilityUIElement::previousTextMarker):
71         (WTR::AccessibilityUIElement::nextTextMarker):
72         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
73         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
74         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
75         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
76         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
77         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
78         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
79
80 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
81
82         Unreviewed, revert accidental unreviewed commit.
83
84         * Scripts/display-profiler-output:
85
86 2016-01-20  Jason Marcell  <jmarcell@apple.com>
87
88         Refactor compareIterations to remove duplicate code.
89         https://bugs.webkit.org/show_bug.cgi?id=152913
90
91         Reviewed by Daniel Bates.
92
93         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
94         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
95         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
96         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
97         the same behavior before and after refactor.
98
99 2016-01-20  Dana Burkart  <dburkart@apple.com>
100
101         Botwatcher's dashboard should show an 'X' when the build is broken
102         https://bugs.webkit.org/show_bug.cgi?id=152507
103
104         Reviewed by David Kilzer.
105
106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
107         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
108         (BuildbotStaticAnalyzerQueueView.prototype.update):
109
110 2016-01-19  Jason Marcell  <jmarcell@apple.com>
111
112         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
113         https://bugs.webkit.org/show_bug.cgi?id=153262
114
115         Reviewed by Alexey Proskuryakov.
116
117         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
118         such cases this revisionContentForIteration method does not have any content to return, thus the
119         assertion fails.
120
121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
122         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
123
124 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
125
126         [GTK] Runtime critical warnings when loading a URL after a session restore
127         https://bugs.webkit.org/show_bug.cgi?id=153233
128
129         Reviewed by Michael Catanzaro.
130
131         Add new test case.
132
133         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
134         (viewLoadChanged):
135         (testWebKitWebViewNavigationAfterSessionRestore):
136         (beforeAll):
137
138 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
139
140         [GTK] Remove jhbuild-optional.modules
141         https://bugs.webkit.org/show_bug.cgi?id=152964
142
143         Reviewed by Alex Christensen.
144
145         * gtk/jhbuild-optional.modules: Removed.
146         * gtk/jhbuild.modules:
147
148 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
149
150         [GTK] Add support to load/save session in MiniBrowser
151         https://bugs.webkit.org/show_bug.cgi?id=153201
152
153         Reviewed by Michael Catanzaro.
154
155         It makes it easier to test the new WebView session API.
156
157         * MiniBrowser/gtk/BrowserWindow.c:
158         (browserWindowFinalize): Free the session file path.
159         (browserWindowSaveSession): Save the current WebView session if
160         there's a session file path.
161         (browserWindowDeleteEvent): Call browserWindowSaveSession().
162         (browser_window_load_session): Try to load the session from the
163         given file path, otherwise fall back to homepage and keep the
164         session file to save the session on window close.
165         * MiniBrowser/gtk/BrowserWindow.h:
166         * MiniBrowser/gtk/main.c:
167         (createBrowserWindow): Pass the given session file path when
168         shouldLoadSession is TRUE.
169         (main): Only allow to restore/save session when MiniBrowser is
170         launched without URL arguments.
171
172 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
173
174         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
175
176         Geolocation is no longer allowed for unique origins after r195075.
177
178         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
179         (testWebViewGeolocationPermissionRequests):
180
181 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
182
183         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
184         https://bugs.webkit.org/show_bug.cgi?id=153216
185
186         Reviewed by Michael Catanzaro.
187
188         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
189         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
190
191 2016-01-18  Nan Wang  <n_wang@apple.com>
192
193         AX: [Mac] Implement next/previous text marker functions using TextIterator
194         https://bugs.webkit.org/show_bug.cgi?id=152728
195
196         Reviewed by Chris Fleizach.
197
198         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
199         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
200
201 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
202
203         [cmake] Add testair to the build system
204         https://bugs.webkit.org/show_bug.cgi?id=153126
205
206         Reviewed by Michael Catanzaro.
207
208         * Scripts/build-jsc:
209
210 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
211
212         Remove TextRun::allowsRoundingHacks()
213         https://bugs.webkit.org/show_bug.cgi?id=153185
214
215         Reviewed by Simon Fraser.
216
217         * DumpRenderTree/mac/DumpRenderTree.mm:
218         (resetWebViewToConsistentStateBeforeTesting): Deleted.
219
220 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
221
222         [webkitdirs] Avoid list form of open because it broke WinCairo
223         https://bugs.webkit.org/show_bug.cgi?id=153106
224
225         Reviewed by Alex Christensen.
226
227         * Scripts/webkitdirs.pm:
228         (determineArchitecture):
229
230 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
231
232         Add kdebug_trace signposts for a few WebCore operations
233         https://bugs.webkit.org/show_bug.cgi?id=153136
234         rdar://problem/24208487
235
236         Reviewed by Sam Weinig.
237         
238         Plist used by kdebug_trace() viewing tools.
239
240         * Tracing/SystemTracePoints.plist: Added.
241
242 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
243
244         [webkitdirs] Replaced grep invocation with perl code
245         https://bugs.webkit.org/show_bug.cgi?id=153106
246
247         Reviewed by Alex Christensen.
248
249         * Scripts/webkitdirs.pm:
250         (determineArchitecture):
251
252 2016-01-14  Brian Burg  <bburg@apple.com>
253
254         prepare-changelog does not read paths containing spaces properly
255         https://bugs.webkit.org/show_bug.cgi?id=137982
256
257         Reviewed by Joseph Pecoraro.
258
259         Escape whitespace in filenames before passing the file path to other functions.
260
261         * Scripts/prepare-ChangeLog:
262         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
263
264 2016-01-14  Jason Marcell  <jmarcell@apple.com>
265
266         Standardize the usage of "branch" vs. "branchName".
267         https://bugs.webkit.org/show_bug.cgi?id=152982
268
269         Reviewed by Daniel Bates.
270
271         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
272         "branchName" implies that the variable or property in question is simply a string.
273
274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
275         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
276         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
277         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
279         (Trac.prototype.commitsOnBranch): Change branch to branchName.
280         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
282         (MockTrac): Ditto.
283
284 2016-01-14  Jason Marcell  <jmarcell@apple.com>
285
286         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
287         https://bugs.webkit.org/show_bug.cgi?id=152910
288
289         Reviewed by Daniel Bates.
290
291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
292         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
294         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
295         the need to talk to a real Buildbot server.
296         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
297         without the need to talk to a real Buildbot server.
298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
299         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
300         server.
301         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
302         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
303         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
304         trying to talk to Trac.
305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
306         QUnit unit tests.
307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
308
309 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
310
311         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
312         https://bugs.webkit.org/show_bug.cgi?id=132599
313
314         Reviewed by Michael Catanzaro.
315
316         Check if cmake Ninja generators are installed.
317
318         * Scripts/webkitdirs.pm:
319         (canUseNinjaGenerator):
320         (canUseEclipseNinjaGenerator):
321         (generateBuildSystemFromCMakeProject):
322         (canUseEclipse): Deleted.
323
324 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
325
326         [Cocoa] Testing with font family name "System Font" is unused
327         https://bugs.webkit.org/show_bug.cgi?id=153073
328         <rdar://problem/24091683>
329
330         Reviewed by Brent Fulgham.
331
332         * DumpRenderTree/mac/DumpRenderTree.mm:
333         (allowedFontFamilySet): Deleted.
334         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
335         (WTR::allowedFontFamilySet): Deleted.
336         * WebKitTestRunner/mac/TestControllerMac.mm:
337         (WTR::allowedFontFamilySet): Deleted.
338
339 2016-01-13  Daniel Bates  <dabates@apple.com>
340
341         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
342         https://bugs.webkit.org/show_bug.cgi?id=152871
343
344         Reviewed by Brent Fulgham.
345
346         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
347         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
348
349         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
350
351 2016-01-08  Andy Estes  <aestes@apple.com>
352
353         [Content Filtering] Lazily load platform frameworks
354         https://bugs.webkit.org/show_bug.cgi?id=152881
355         rdar://problem/23270886
356
357         Reviewed by Brady Eidson.
358
359         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
360         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
361         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
362         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
363         is loaded after an HTTPS request.
364
365         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
366         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
367         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
368         also re-enabled on iOS after mistakenly being disabled by r188892.
369
370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
371         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
372         (TestWebKitAPI::TEST):
373         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
374         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
375         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
376         (TEST):
377         (downloadTest):
378         (-[LazilyLoadPlatformFrameworksController init]):
379         (-[LazilyLoadPlatformFrameworksController webView]):
380         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
381         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
382         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
383         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
384         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
385         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
386         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
387         (TestWebKitAPI::TEST):
388         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
389         (TestWebKitAPI::TEST): Deleted.
390         * TestWebKitAPI/cocoa/TestProtocol.h:
391         * TestWebKitAPI/cocoa/TestProtocol.mm:
392         (+[TestProtocol registerWithScheme:]):
393         (+[TestProtocol unregister]):
394
395 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
396
397         Fix the Sunpider converage in slow device.
398         https://bugs.webkit.org/show_bug.cgi?id=152938
399         <rdar://problem/22511411>
400
401         Reviewed by Ryosuke Niwa.
402
403         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
404
405         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
406
407 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
408
409         Add a build flag for custom element
410         https://bugs.webkit.org/show_bug.cgi?id=153005
411
412         Reviewed by Alex Christensen.
413
414         Added --custom-elements option to enable custom elements support.
415
416         * Scripts/webkitperl/FeatureList.pm:
417
418 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
419
420         [JSC] Add a help message when run-jsc-stress-tests fails
421         https://bugs.webkit.org/show_bug.cgi?id=153014
422
423         Reviewed by Csaba Osztrogonác.
424
425         * Scripts/run-jsc-stress-tests:
426
427 2016-01-11  Saam barati  <sbarati@apple.com>
428
429         run-jsc-stress-tests should try to figure out a JSC path
430         https://bugs.webkit.org/show_bug.cgi?id=152971
431
432         Reviewed by Yusuke Suzuki.
433
434         This patch now allows run-jsc-stress-tests to be run
435         without a "--jsc <jsc-path>" argument. It tries
436         to take its best guess at a <jsc-path> automagically.
437         
438         This makes it much easier to just run run-jsc-stress-tests
439         with a directory or a yaml file as an argument.
440         You now just do this:
441         `run-jsc-stress-tests <path-to-yaml>`
442         or
443         `run-jsc-stress-tests <path-to-directory-of-js-files>`
444         
445         I wrote this patch because I'd often find myself hacking the 
446         run-javascriptcore-tests file just to run a particular subset of tests.
447         Because I always forget the arguments to run-jsc-stress-tests (which means
448         I always forgot to provide a --jsc argument), I always found it easier to 
449         just hack on that file instead of calling run-jsc-stress-tests directly.
450         No longer is this true!
451
452         * Scripts/run-jsc-stress-tests:
453
454 2016-01-09  Andy Estes  <aestes@apple.com>
455
456         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
457         https://bugs.webkit.org/show_bug.cgi?id=152950
458         rdar://problem/24066652
459
460         Reviewed by Tim Horton.
461
462         Added an API test.
463
464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
465         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
466         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
467         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
468         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
469         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
470         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
471         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
472         (TEST):
473
474 2016-01-11  Commit Queue  <commit-queue@webkit.org>
475
476         Unreviewed, rolling out r194866.
477         https://bugs.webkit.org/show_bug.cgi?id=152986
478
479         This change broke the mac build (Requested by ryanhaddad on
480         #webkit).
481
482         Reverted changeset:
483
484         "[Cocoa] Add SPI to opt out a URL scheme from the memory
485         cache"
486         https://bugs.webkit.org/show_bug.cgi?id=152950
487         http://trac.webkit.org/changeset/194866
488
489 2016-01-11  Andy Estes  <aestes@apple.com>
490
491         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
492         https://bugs.webkit.org/show_bug.cgi?id=152950
493         rdar://problem/24066652
494
495         Reviewed by Tim Horton.
496
497         Added an API test.
498
499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
500         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
501         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
502         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
503         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
504         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
505         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
506         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
507         (TEST):
508
509 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
510
511         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
512         https://bugs.webkit.org/show_bug.cgi?id=152959
513
514         Reviewed by Brent Fulgham.
515
516         * Scripts/webkitdirs.pm:
517         (determineArchitecture):
518
519 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
520
521         [GTK] W3C CSS2.1 anonymous table tests are failing
522         https://bugs.webkit.org/show_bug.cgi?id=152455
523
524         Reviewed by Mario Sanchez Prada.
525
526         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
527         tests. Add upstream patches to fix detection of XHTML files.
528
529         * gtk/jhbuild.modules:
530         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
531         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
532
533 2016-01-10  Saam barati  <sbarati@apple.com>
534
535         Implement a sampling profiler
536         https://bugs.webkit.org/show_bug.cgi?id=151713
537
538         Reviewed by Filip Pizlo.
539
540         * Scripts/run-jsc-stress-tests:
541
542 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
543
544         [webkitdirs] Try arch and uname commands on non-windows OS
545         https://bugs.webkit.org/show_bug.cgi?id=152958
546
547         Reviewed by Michael Catanzaro.
548
549         Right now, determineArchitecture()  uses `arch` and `uname -m`
550         commands to determine architecture in case of condition (isGtk() ||
551         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
552         instead, because this code is applicable to any non-windows OS WebKit
553         supports (even Haiku which once was supported is moderately
554         POSIX-compliant and has uname command).
555
556         * Scripts/webkitdirs.pm:
557         (determineArchitecture):
558
559 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
560
561         run-webkit-tests mis-counts totals when there are other crashes
562         https://bugs.webkit.org/show_bug.cgi?id=152894
563         <rdar://problem/24098697>
564
565         Reviewed by Alexey Proskuryakov.
566
567         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
568         (TestRunResults.add): Do not update result counters for other crashes.
569
570 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
571
572         webkit-patch build-and-test should have an option to iterate over new tests
573         https://bugs.webkit.org/show_bug.cgi?id=143093
574
575         Reviewed by Michael Catanzaro.
576
577         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
578         It allows running run-webkit-tests on modified or new paths in LayoutTests.
579         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
580         It implements the translation of -expected.* paths to their related tests.
581         It also implements the removal of skipped tests.
582
583         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
584         (LayoutTestFinder.find_touched_tests):
585         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
586         (MockPort):
587         (MockPort.__init__):
588         (MockPort.tests):
589         (LayoutTestFinderTests):
590         (LayoutTestFinderTests.touched_files):
591         (LayoutTestFinderTests.test_touched_test):
592         (LayoutTestFinderTests.test_expected_touched_test):
593         (LayoutTestFinderTests.test_platform_expected_touched_test):
594         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
595         (LayoutTestFinderTests.test_touched_but_skipped_test):
596         * Scripts/webkitpy/port/base.py:
597         (Port.potential_test_names_from_expected_file):
598         * Scripts/webkitpy/tool/commands/download_unittest.py:
599         (DownloadCommandsTest._default_options):
600         * Scripts/webkitpy/tool/steps/options.py:
601         (Options):
602         * Scripts/webkitpy/tool/steps/runtests.py:
603         (RunTests.options):
604         (RunTests.run):
605         (RunTests):
606         (RunTests._new_or_modified_tests):
607         (RunTests._run_webkit_tests):
608         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
609         (RunTestsTest.test_webkit_run_unit_tests):
610         * Scripts/webkitpy/tool/steps/steps_unittest.py:
611         (StepsTest._step_options):
612
613 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
614
615         prepare-ChangeLog should include radar number
616         https://bugs.webkit.org/show_bug.cgi?id=152839
617         <rdar://problem/24093563>
618
619         Reviewed by Daniel Bates.
620
621         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
622         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
623         in the ChangeLog description after the bug URL.
624
625         * Scripts/prepare-ChangeLog:
626         (main): Update signatures.
627         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
628         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
629         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
630         (generateNewChangeLogs): Include radar URL if we found one.
631
632         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
633         Tests for the radar URL extraction.
634
635 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
636
637         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
638         https://bugs.webkit.org/show_bug.cgi?id=152390
639         <rdar://problem/23948321>
640
641         Reviewed by Simon Fraser.
642
643         Fix two use-after-frees.
644
645         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
646         but we may have already progressed to another test by the time the callback fires,
647         having destroyed the TestInvocation.
648         2. UIScriptController is a RefCounted object, but it has a raw pointer to
649         UIScriptContext which has the same lifetime as a TestInvocation.
650         As a result, completion blocks of UIScriptController actions would use a destroyed
651         TestInvocation.
652
653         * WebKitTestRunner/TestInvocation.cpp:
654         (WTR::TestInvocation::~TestInvocation):
655         (WTR::TestInvocation::url):
656         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
657         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
658         (WTR::TestInvocation::runUISideScript):
659         * WebKitTestRunner/TestInvocation.h:
660         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
661         (UIScriptContext::UIScriptContext):
662         (UIScriptContext::~UIScriptContext):
663         (UIScriptContext::runUIScript):
664         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
665         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
666         (WTR::UIScriptController::UIScriptController):
667         (WTR::UIScriptController::contextDestroyed):
668         (WTR::UIScriptController::makeWindowObject):
669         (WTR::UIScriptController::setWillBeginZoomingCallback):
670         (WTR::UIScriptController::willBeginZoomingCallback):
671         (WTR::UIScriptController::setDidEndZoomingCallback):
672         (WTR::UIScriptController::didEndZoomingCallback):
673         (WTR::UIScriptController::setDidEndScrollingCallback):
674         (WTR::UIScriptController::didEndScrollingCallback):
675         (WTR::UIScriptController::setDidShowKeyboardCallback):
676         (WTR::UIScriptController::didShowKeyboardCallback):
677         (WTR::UIScriptController::setDidHideKeyboardCallback):
678         (WTR::UIScriptController::didHideKeyboardCallback):
679         (WTR::UIScriptController::uiScriptComplete):
680         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
681         (WTR::UIScriptController::create):
682         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
683         (WTR::UIScriptController::doAsyncTask):
684         (WTR::UIScriptController::zoomToScale):
685         (WTR::UIScriptController::singleTapAtPoint):
686         (WTR::UIScriptController::doubleTapAtPoint):
687         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
688         (WTR::UIScriptController::contentVisibleRect):
689         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
690         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
691         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
692         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
693         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
694         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
695         (WTR::UIScriptController::doAsyncTask):
696
697 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
698
699         [buildbot] clean-build script should remove untracked files and revert local changes too
700         https://bugs.webkit.org/show_bug.cgi?id=142400
701
702         Reviewed by Ryosuke Niwa.
703
704         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
705         A helper routine SCM.discard_untracked_files is added for that purpose.
706
707         * BuildSlaveSupport/clean-build:
708         (main): Making call to Scripts/clean-webkit
709         * Scripts/clean-webkit: Added.
710         (main): Revert changes and delete untracked files.
711         * Scripts/webkitpy/common/checkout/scm/scm.py:
712         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
713         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
714         (SCMTest._shared_test_discard_untracked_files):
715         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
716
717 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
718
719         Add a setting and preferences to enable display-list drawing. Does nothing yet.
720         https://bugs.webkit.org/show_bug.cgi?id=152807
721
722         Reviewed by Zalan Bujtas.
723         
724         Add an item to the Settings menu to toggle display-list drawing.
725
726         * MiniBrowser/mac/SettingsController.h:
727         * MiniBrowser/mac/SettingsController.m:
728         (-[SettingsController _populateMenu]):
729         (-[SettingsController validateMenuItem:]):
730         (-[SettingsController toggleDisplayListDrawingEnabled:]):
731         (-[SettingsController displayListDrawingEnabled]):
732         * MiniBrowser/mac/WK2BrowserWindowController.m:
733         (-[WK2BrowserWindowController didChangeSettings]):
734
735 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
736
737         Python SCM should be able to retrieve untracked files - Add GIT support
738         https://bugs.webkit.org/show_bug.cgi?id=143135
739
740         Reviewed by Michael Catanzaro.
741
742         * Scripts/webkitpy/common/checkout/scm/git.py:
743         (Git.untracked_files): Adding support for git.
744         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
745         (GitTest.setUp):
746         (GitTest.test_untracked_files): Adding test.
747
748 2016-01-05  Mark Lam  <mark.lam@apple.com>
749
750         Rename badly named JSC_timeout env var to JSCTEST_timeout.
751         https://bugs.webkit.org/show_bug.cgi?id=152748
752
753         Reviewed by Geoffrey Garen.
754
755         Now that we validate JSC options, the badly named JSC_timeout env var causes the
756         bots to have a bad time.
757
758         * Scripts/run-javascriptcore-tests:
759         * Scripts/run-jsc-stress-tests:
760
761 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
762
763         [GTK] Allow to save and restore session
764         https://bugs.webkit.org/show_bug.cgi?id=115600
765
766         Reviewed by Michael Catanzaro.
767
768         Add test case to check the new session API.
769
770         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
771         (testWebKitWebViewSessionState):
772         (testWebKitWebViewSessionStateWithFormData):
773         (beforeAll):
774
775 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
776
777         [EFL] Bump EFL version to 1.16.1
778         https://bugs.webkit.org/show_bug.cgi?id=152688
779
780         Reviewed by Gyuyoung Kim.
781
782         * efl/jhbuild.modules:
783
784 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
785
786         error running layout tests on iOS simulator on latest build
787         https://bugs.webkit.org/show_bug.cgi?id=152719
788         <rdar://problem/24009549>
789
790         Reviewed by Alexey Proskuryakov.
791
792         * Scripts/webkitpy/xcode/simulator.py:
793         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
794           before running simctl spawn command.
795
796 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
797
798         Unreviewed, move Frédéric Wang to committers list
799
800         He seems to be on the contributors list by accident. He has been landing his own commits for
801         about two years now.
802
803         * Scripts/webkitpy/common/config/contributors.json:
804
805 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
806
807         Unreviewed, move Sebastian Dröge to committers list harder
808
809         He accidentally added himself to the reviewers list because the file is confusing. Then I
810         accidentially moved him to the contributors list because the file is confusing, even though
811         I knew the contributors list existed in this file and was attempting to add him to the
812         committers list. Really move him to the committers list now.
813
814         * Scripts/webkitpy/common/config/contributors.json:
815
816 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
817
818         Python SCM should be able to retrieve untracked files - Add SVN support
819         https://bugs.webkit.org/show_bug.cgi?id=152546
820
821         Reviewed by Michael Catanzaro.
822
823         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
824         (test_untracked_files): Activating test for SVN.
825         * Scripts/webkitpy/common/checkout/scm/svn.py:
826         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
827
828 2015-12-31  Andy Estes  <aestes@apple.com>
829
830         Replace WTF::move with WTFMove
831         https://bugs.webkit.org/show_bug.cgi?id=152601
832
833         Reviewed by Brady Eidson.
834
835         * DumpRenderTree/TestRunner.h:
836         (TestRunner::setAllowedHosts):
837         * DumpRenderTree/win/DRTDataObject.cpp:
838         (DRTDataObject::SetData):
839         * TestWebKitAPI/Tests/WTF/Deque.cpp:
840         (TestWebKitAPI::TEST):
841         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
842         (TestWebKitAPI::TEST):
843         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
844         (TestWebKitAPI::TEST):
845         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
846         (TestWebKitAPI::TEST):
847         * TestWebKitAPI/Tests/WTF/Ref.cpp:
848         (TestWebKitAPI::passWithRef):
849         (TestWebKitAPI::TEST):
850         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
851         (TestWebKitAPI::TEST):
852         * TestWebKitAPI/Tests/WTF/Vector.cpp:
853         (TestWebKitAPI::TEST):
854         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
855         (TestWebKitAPI::TEST):
856         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
857         (TestWebKitAPI::TEST):
858         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
859         (TestWebKitAPI::createTestValue):
860         (TestWebKitAPI::TEST):
861         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
862         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
863         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
864         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
865         (TestWebKitAPI::createNFAs):
866         (TestWebKitAPI::TEST_F):
867         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
868         (TestWebKitAPI::combine):
869         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
870         (TestWebKitAPI::createNFAs):
871         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
872         (TEST):
873         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
874         (WebProcessTest::add):
875
876 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
877
878         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
879         https://bugs.webkit.org/show_bug.cgi?id=152634
880
881         Reviewed by Carlos Garcia Campos.
882
883         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
884         (testLoadFromGResource): Added test.
885         (beforeAll):
886         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
887         (registerGResource): Added.
888         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
889         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
890         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
891
892 2015-12-31  David Kilzer  <ddkilzer@apple.com>
893
894         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
895         <https://bugs.webkit.org/show_bug.cgi?id=152601>
896
897         Ignore unknown pragmas on older clangs.  Fixes the following
898         build failure:
899
900             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
901             #pragma clang diagnostic ignored "-Wself-move"
902                                              ^
903             1 error generated.
904
905         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
908         (TestWebKitAPI::TEST):
909
910 2015-12-31  Andy Estes  <aestes@apple.com>
911
912         Update the style checker to advise using WTFMove() instead of WTF::move()
913         https://bugs.webkit.org/show_bug.cgi?id=152601
914
915         Reviewed by Daniel Bates.
916
917         * Scripts/webkitpy/style/checkers/cpp.py:
918         (check_wtf_move):
919         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
920         (WebKitStyleTest.test_wtf_move):
921
922 2015-12-31  Andy Estes  <aestes@apple.com>
923
924         Fix warnings uncovered by migrating to WTF_MOVE
925         https://bugs.webkit.org/show_bug.cgi?id=152601
926
927         Reviewed by Daniel Bates.
928
929         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
930         self-move, even if doing so would trigger a warning.
931
932         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
933         (TestWebKitAPI::TEST):
934         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
935         (TestWebKitAPI::TEST):
936
937 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
938
939         [GTK] The install-dependencies script has a syntax error
940         https://bugs.webkit.org/show_bug.cgi?id=152613
941
942         Reviewed by Michael Catanzaro.
943
944         * gtk/install-dependencies: Add the missing 'then.'
945
946 2015-12-30  Philippe Normand  <pnormand@igalia.com>
947
948         [Mac][GTK] Jhbuild support for OSX
949         https://bugs.webkit.org/show_bug.cgi?id=150799
950
951         Reviewed by Michael Catanzaro.
952
953         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
954         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
955         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
956         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
957
958 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
959
960         Unreviewed, move Sebastian Dröge to committers list
961
962         He accidentally added himself to the reviewers list because the file is confusing.
963
964         * Scripts/webkitpy/common/config/contributors.json:
965
966 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
967
968         Remove the unused #define _USE_MATH_DEFINES
969         https://bugs.webkit.org/show_bug.cgi?id=152034
970
971         Reviewed by Tim Horton.
972         
973         Update this test to use piDouble from MathExtras.h, and
974         std::numeric_limits<>.
975
976         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
977
978 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
979
980         Python SCM should be able to retrieve untracked files - Generic changes
981         https://bugs.webkit.org/show_bug.cgi?id=152536
982
983         Reviewed by Brent Fulgham.
984
985         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
986         No support is yet added to GIT and SVN specific implementations.
987
988         * Scripts/webkitpy/common/checkout/scm/scm.py:
989         (SCM.untracked_files):
990         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
991         (SCMTest._shared_test_untracked_files):
992
993 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
994
995         SVN checkout used by RunBenchmark should be non-interactive
996         https://bugs.webkit.org/show_bug.cgi?id=152542
997
998         Reviewed by Ryosuke Niwa.
999
1000         RunBenchmark should not require user interaction while running.
1001
1002         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1003         (BenchmarkBuilder._checkout_with_subversion):
1004
1005 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1006
1007         Web Inspector: add support for running protocol-test.js tests on Windows
1008         https://bugs.webkit.org/show_bug.cgi?id=148037
1009         <rdar://problem/22292237>
1010
1011         Reviewed by Simon Fraser.
1012
1013         * DumpRenderTree/win/TestRunnerWin.cpp:
1014         (TestRunner::inspectorTestStubURL): Provide implementation.
1015
1016 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1017
1018         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1019         https://bugs.webkit.org/show_bug.cgi?id=152000
1020
1021         Reviewed by Brent Fulgham.
1022
1023         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1024         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1025         (WTR::InjectedBundle::setUserMediaPermission):
1026         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1027         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1028
1029         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1030         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1031         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1032
1033         * WebKitTestRunner/TestController.cpp:
1034         (WTR::TestController::setUserMediaPermissionForOrigin):
1035         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1036         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1037           persistent permission for origin, that can be done from script now.
1038         * WebKitTestRunner/TestController.h:
1039
1040         * WebKitTestRunner/TestInvocation.cpp:
1041         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1042           SetUserMediaPermissionForOrigin.
1043
1044 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1045
1046         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1047
1048         * Scripts/webkitpy/common/system/platforminfo.py:
1049         (PlatformInfo._determine_win_version):
1050
1051 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1052
1053         Content blockers should be able to promote http to https
1054         https://bugs.webkit.org/show_bug.cgi?id=148966
1055
1056         Reviewed by Benjamin Poulain.
1057
1058         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1059         (WebCore::ContentExtensions::operator<<):
1060         (TestWebKitAPI::TEST_F):
1061
1062 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1063
1064         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1065         https://bugs.webkit.org/show_bug.cgi?id=152516
1066
1067         Reviewed by Gyuyoung Kim.
1068
1069         * MiniBrowser/efl/main.c:
1070
1071 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1072
1073         Unreviewed: Add John Wilander as a contributor.
1074
1075         * Scripts/webkitpy/common/config/contributors.json:
1076
1077 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1078
1079         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1080         https://bugs.webkit.org/show_bug.cgi?id=152482
1081
1082         Reviewed by Brent Fulgham.
1083
1084         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1085         for the same property. On WK2, the element returned will not be valid, but is still present and
1086         that can lead to looping.
1087
1088         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1089         (AccessibilityUIElement::horizontalScrollbar):
1090         (AccessibilityUIElement::verticalScrollbar):
1091         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1092         (WTR::AccessibilityUIElement::horizontalScrollbar):
1093         (WTR::AccessibilityUIElement::verticalScrollbar):
1094
1095 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1096
1097         Unreviewed.
1098
1099         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1100
1101 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1102
1103         [EFL] test_ewk2_context failed after r192808
1104         https://bugs.webkit.org/show_bug.cgi?id=151846
1105
1106         Reviewed by Gyuyoung Kim.
1107
1108         Used the added ewk_context_web_process_count_limit_set api
1109         instead of the deprecated ewk_context_process_model_set.
1110
1111         * MiniBrowser/efl/main.c:
1112         (elm_main):
1113
1114 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1115
1116         Unreviewed, move myself to reviewer list.
1117
1118         * Scripts/webkitpy/common/config/contributors.json:
1119
1120 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1121
1122         Unreviewed, add myself to the committers list.
1123
1124         * Scripts/webkitpy/common/config/contributors.json:
1125
1126 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1127
1128         [GTK] jquery.min.js violates DFSG
1129         https://bugs.webkit.org/show_bug.cgi?id=152428
1130
1131         Reviewed by Joseph Pecoraro.
1132
1133         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1134         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1135
1136         * gtk/manifest.txt.in:
1137
1138 2015-12-19  Dan Bernstein  <mitz@apple.com>
1139
1140         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1141         https://bugs.webkit.org/show_bug.cgi?id=152462
1142
1143         Reviewed by Alexey Proskuryakov.
1144
1145         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1146           OS X 10.9:
1147
1148         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1149         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1150         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1151         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1152         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1153
1154         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1155           never getting compiled:
1156
1157         * DumpRenderTree/mac/TextInputController.m:
1158         * MiniBrowser/mac/BrowserWindowController.m:
1159         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1160         * WebKitTestRunner/mac/EventSenderProxy.mm:
1161
1162 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1163
1164         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1165
1166         This is to make it easy to CC it on Bugzilla.
1167
1168         * Scripts/webkitpy/common/config/contributors.json:
1169
1170 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1171
1172         Pasteboard get messed up after running kill-old-processes
1173         https://bugs.webkit.org/show_bug.cgi?id=152426
1174
1175         Reviewed by Alexey Proskuryakov.
1176
1177         * BuildSlaveSupport/kill-old-processes:
1178         (main): Do not kill pasteboard anymore.
1179
1180 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1181
1182         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1183         https://bugs.webkit.org/show_bug.cgi?id=152157
1184         <rdar://problem/23851817>
1185
1186         Reviewed by Alexey Proskuryakov.
1187
1188         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1189         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1190         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1191         (Manager._get_test_inputs): Common method to calculate test_inputs.
1192         (Manager._update_worker_count): Calculate and update required number of workers.
1193
1194 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1195
1196         run-webkit-tests fails to delete Simulator device during cleanup
1197         https://bugs.webkit.org/show_bug.cgi?id=152363
1198
1199         Reviewed by Alexey Proskuryakov.
1200
1201         * Scripts/webkitpy/xcode/simulator.py:
1202         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1203
1204 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1205
1206         [mac-wk2] fast/events force click tests crashing
1207         https://bugs.webkit.org/show_bug.cgi?id=152339
1208
1209         Reviewed by Beth Dakin.
1210
1211         * WebKitTestRunner/mac/EventSenderProxy.mm:
1212         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1213         Set the NSEvent's _type member in addition to overriding -type,
1214         because there are assertions in touch event handling code that depend on it.
1215
1216 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1217
1218         Enforce temporarily bots to sync WebKit and WPT testharness.js
1219         https://bugs.webkit.org/show_bug.cgi?id=152334
1220
1221         Reviewed by Darin Adler.
1222
1223         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1224         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1225
1226 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1227
1228         [Fetch API] Add fetch API compile time flag
1229         https://bugs.webkit.org/show_bug.cgi?id=152254
1230
1231         Reviewed by Darin Adler.
1232
1233         * Scripts/webkitperl/FeatureList.pm:
1234
1235 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1236
1237         Unreviewed.
1238
1239         Added files that have impact in building Streams API to the watchlist.
1240
1241         * Scripts/webkitpy/common/config/watchlist:
1242
1243 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1244
1245         Unreviewed.
1246
1247         Added imported tests to Streams API watchlist.
1248
1249         * Scripts/webkitpy/common/config/watchlist:
1250
1251 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1252
1253         Remove default copy of wpt testharness.js when launching wpt server
1254         https://bugs.webkit.org/show_bug.cgi?id=152298
1255
1256         Reviewed by Darin Adler.
1257
1258         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1259         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1260
1261 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1262
1263         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1264         <http://webkit.org/b/152314>
1265
1266         Reviewed by Daniel Bates.
1267
1268         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1269         code path to exit immediately when calling main().
1270         Unfortunately, DumpRenderTreeMain.mm was used for both
1271         DumpRenderTree command-line binary and DumpRenderTree.app, which
1272         meant that the app would exit immediately with no error code
1273         when run!
1274
1275         The workaround is to introduce a separate source file called
1276         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1277         already does.
1278
1279         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1280         DumpRenderTreeAppMain.mm to the project.  Make it the only
1281         compiled source for the DumpRenderTree.app target.
1282         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1283         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1284         case someone tries mistakenly to use the app.
1285         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1286         Link to JavaScriptCore.framework on iOS for the assert.
1287         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1288         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1289         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1290         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1291         (main): Add assert for iOS so that a crash occurs if someone
1292         tries to run the wrong command.
1293
1294 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1295
1296         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1297         https://bugs.webkit.org/show_bug.cgi?id=152266
1298         <rdar://problem/22092676>
1299
1300         Reviewed by Simon Fraser.
1301
1302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1303         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1304         Add a test that crashed before this change, and doesn't crash after.
1305
1306 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1307
1308         AX: iOS: Text field variations do not have the correct traits
1309         https://bugs.webkit.org/show_bug.cgi?id=152237
1310
1311         Reviewed by Mario Sanchez Prada.
1312
1313         Add iOS calls for determing if an object is a search field or a text area.
1314
1315         * DumpRenderTree/AccessibilityUIElement.cpp:
1316         (getIsSearchFieldCallback):
1317         (getIsTextAreaCallback):
1318         (stringForSelectionCallback):
1319         (AccessibilityUIElement::getJSClass):
1320         * DumpRenderTree/AccessibilityUIElement.h:
1321         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1322         (AccessibilityUIElement::identifier):
1323         (AccessibilityUIElement::isTextArea):
1324         (AccessibilityUIElement::isSearchField):
1325         (AccessibilityUIElement::traits):
1326         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1327         (WTR::AccessibilityUIElement::scrollPageRight):
1328         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1329         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1330         (WTR::AccessibilityUIElement::isSearchField):
1331         (WTR::AccessibilityUIElement::isTextArea):
1332         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1333         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1334         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1335         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1336         (WTR::AccessibilityUIElement::isTextArea):
1337         (WTR::AccessibilityUIElement::isSearchField):
1338         (WTR::AccessibilityUIElement::rowCount):
1339
1340 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1341
1342         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1343         https://bugs.webkit.org/show_bug.cgi?id=152252
1344
1345         Reviewed by Sergio Villar Senin.
1346
1347         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1348         for building the JHBuild on Debian systems.
1349
1350 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1351
1352         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1353         https://bugs.webkit.org/show_bug.cgi?id=152156
1354
1355         Reviewed by Dan Bernstein.
1356
1357         Our frameworks should appropriately prefix all ObjC classes,
1358         not just external symbols.
1359
1360         * Scripts/check-for-inappropriate-objc-class-names:
1361         Remove the -g switch to check all ObjC class names.
1362
1363 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1364
1365         [MediaStream] Expose media capture devices persistent permissions to WebCore
1366         https://bugs.webkit.org/show_bug.cgi?id=152087
1367
1368         Add support for the new user media permission checker page UI client method.
1369
1370         Reviewed by Chris Dumez.
1371
1372         * WebKitTestRunner/TestController.cpp:
1373         (WTR::decidePolicyForUserMediaPermissionRequest):
1374         (WTR::checkUserMediaPermissionForOrigin):
1375         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1376         (WTR::TestController::createWebViewWithOptions): Ditto.
1377         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1378         (WTR::originUserVisibleName): New, create a string for the origin.
1379         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1380           according to the state of the origin permission map.
1381         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1382           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1383         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1384           origin permission map.
1385         * WebKitTestRunner/TestController.h:
1386
1387 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1388
1389         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1390         https://bugs.webkit.org/show_bug.cgi?id=152022
1391         rdar://problem/23763584
1392
1393         Reviewed by Darin Adler.
1394
1395         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1397         (WTR::InjectedBundlePage::willSendRequestForFrame):
1398         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1399         (WTR::TestRunner::setWillSendRequestReturnsNull):
1400         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1401         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1402         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1403         (WTR::TestRunner::willSendRequestHTTPBody):
1404         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1405
1406 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1407
1408         Remove additional simulator checks before running layout-tests
1409         https://bugs.webkit.org/show_bug.cgi?id=152146
1410
1411         Reviewed by Darin Adler.
1412
1413         * Scripts/webkitpy/port/ios.py:
1414         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1415         * Scripts/webkitpy/xcode/simulator.py:
1416         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1417         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1418
1419 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1420
1421         Run atleast one simulator even if max process limit is low
1422         https://bugs.webkit.org/show_bug.cgi?id=152081
1423         <rdar://problem/23819694>
1424
1425         Reviewed by Alexey Proskuryakov.
1426
1427 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1428
1429         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1430         https://bugs.webkit.org/show_bug.cgi?id=144262
1431
1432         Reviewed by Carlos Garcia Campos.
1433
1434         Added new unit test to check the additional scenarios we now
1435         handle for custom URI schemes.
1436
1437         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1438         (generateHTMLContent): New helper function to generate big enough content.
1439         (testWebContextURIScheme): New unit test.
1440
1441 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1442
1443         [EFL] Fix unhandled web process message when launching MiniBrowser
1444         https://bugs.webkit.org/show_bug.cgi?id=152048
1445
1446         Reviewed by Gyuyoung Kim.
1447
1448         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1449         (TestWebKitAPI::TEST):
1450
1451 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1452
1453         [GTK] Add API to handle beforeunload events
1454         https://bugs.webkit.org/show_bug.cgi?id=139090
1455
1456         Reviewed by Gustavo Noronha Silva.
1457
1458         * MiniBrowser/gtk/BrowserWindow.c:
1459         (browserWindowConstructed):
1460         (browserWindowDeleteEvent):
1461         (browser_window_class_init):
1462         Handle delete-event to prevent the window from being closed when
1463         the page has beforeunload handlers. Use
1464         webkit_web_view_try_close() when the window is requested to be
1465         closed.
1466         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1467         (testWebViewJavaScriptDialogs):
1468         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1469         script dialog type.
1470
1471 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1472
1473         Refactored initialization code in LoadTrackingTest.
1474
1475         Rubber-stamped by Carlos Garcia Campos.
1476
1477         Small refactoring to make sure that the state of a LoadTrackingTest
1478         gets properly reset before loading new web content.
1479
1480         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1481         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1482         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1483         functions and reset the remaining local variables.
1484         (LoadTrackingTest::loadURI): Call reset();
1485         (LoadTrackingTest::loadHtml): Ditto.
1486         (LoadTrackingTest::loadPlainText): Ditto.
1487         (LoadTrackingTest::loadBytes): Ditto.
1488         (LoadTrackingTest::loadRequest): Ditto.
1489         (LoadTrackingTest::reload): Ditto.
1490         (LoadTrackingTest::goBack): Ditto.
1491         (LoadTrackingTest::goForward): Ditto.
1492
1493 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1494
1495         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1496         https://bugs.webkit.org/show_bug.cgi?id=151942
1497
1498         Reviewed by Darin Adler.
1499
1500         * MiniBrowser/efl/main.c:
1501         (window_create): Enable offline web application cache feature on MiniBrowser.
1502         (elm_main):
1503
1504 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1505
1506         https://bugs.webkit.org/show_bug.cgi?id=151243
1507         <rdar://problem/22955197>
1508
1509         Reviewed by Alexey Proskuryakov.
1510
1511         * LayoutTestRelay/LayoutTestRelay/main.m:
1512         (getTestingSimDevice): Use separate testing device for each worker.
1513         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1514         (Manager.run): Perform cleanup even if setup fails.
1515         * Scripts/webkitpy/port/ios.py:
1516         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1517         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1518         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1519         (IOSSimulatorPort._quit_ios_simulator): Same
1520         (IOSSimulatorPort.clean_up_test_run): Same
1521         (IOSSimulatorPort.check_sys_deps): Same
1522         (IOSSimulatorPort.testing_device): Same
1523         (IOSSimulatorPort.reset_preferences): Same
1524         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1525         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1526         * Scripts/webkitpy/xcode/simulator.py:
1527         (Device.delete): Delete the simulator device.
1528         (Simulator.delete_device): Same
1529         (Simulator.wait_until_device_is_booted): Wait for device booting.
1530
1531 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1532
1533         [EFL] Add API to provide preferences before creating ewk_view
1534         https://bugs.webkit.org/show_bug.cgi?id=151587
1535
1536         Reviewed by Gyuyoung Kim.
1537
1538         * MiniBrowser/efl/main.c:
1539         (on_key_down):
1540         (quit):
1541         (window_create):
1542         Moved settings related code to configuration() not to update settings
1543         whenever ewk_view is created.
1544         (configuration):
1545         (elm_main):
1546
1547 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1548
1549         Unreviewed. Fix GTK+ API tests after r193639.
1550
1551         The new jhbuild version needs some more variables ot be present in
1552         the builtin dict, even if they are set to None.
1553
1554         * jhbuild/jhbuildutils.py:
1555         (enter_jhbuild_environment_if_available):
1556
1557 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1558
1559         [GTK] Notify WebCore when notification is clicked
1560         https://bugs.webkit.org/show_bug.cgi?id=151951
1561
1562         Reviewed by Carlos Garcia Campos.
1563
1564         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1565         (testWebViewNotification): test the new API.
1566
1567 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1568
1569         'jhbuild build' should fail immediately when building any module fails
1570         https://bugs.webkit.org/show_bug.cgi?id=145697
1571
1572         Reviewed by Carlos Garcia Campos.
1573
1574         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1575         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1576         Everything is placed under lib instead of lib64 now.
1577         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1578         --exit-on-error when running 'jhbuild build'.
1579         * jhbuild/jhbuildrc_common.py:
1580         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1581         jhbuild should be able to handle these for us without breaking things....
1582
1583 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1584
1585         Add support to import w3c tests from a repository with a different root that the main repo dir
1586         https://bugs.webkit.org/show_bug.cgi?id=151751
1587
1588         Reviewed by Ryosuke Niwa and Youenn Fablet.
1589
1590         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1591         in a different directory than the repository root.
1592
1593         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1594         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1595         requires having the copy_path lists including tuples of origin and destination directories.
1596
1597         * Scripts/webkitpy/w3c/test_downloader.py:
1598         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1599         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1600         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1601         (TestImporterTest.test_tests_directory): Test.
1602
1603 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1604
1605         Mock TestRepositories in W3C importer tests
1606         https://bugs.webkit.org/show_bug.cgi?id=151938
1607
1608         Reviewed by Youenn Fablet.
1609
1610         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1611         is because the test repository method reading the file was using the filesystem directly instead of taking the
1612         host one. This patch changes that.
1613
1614         * Scripts/webkitpy/w3c/test_downloader.py:
1615         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1616         default one.
1617         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1618         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1619         (TestImporterTest.test_harnesslinks_conversion):
1620         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1621
1622 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1623
1624         TestNetscapePlugIn: Address review comment on 193607
1625         <http://webkit.org/b/151881>
1626
1627         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1628         (testSetStatus): Initializing std::unique_ptr<char[]> with
1629         nullptr is redundant.
1630
1631 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1632
1633         [GTK] Add webkit_uri_request_get_http_method
1634         https://bugs.webkit.org/show_bug.cgi?id=151601
1635
1636         Reviewed by Martin Robinson.
1637
1638         Add test case to check HTTP method of WebKitURIRequest.
1639
1640         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1641         (testURIRequestHTTPMethod):
1642         (serverCallback):
1643         (beforeAll):
1644         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1645         (sendRequestCallback):
1646
1647 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1648
1649         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1650         https://bugs.webkit.org/show_bug.cgi?id=79918
1651
1652         Reviewed by Gustavo Noronha Silva.
1653
1654         Add unit tests to check the different console messages.
1655
1656         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1657         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1658         (ConsoleMessageTest::ConsoleMessage::operator==):
1659         (ConsoleMessageTest::consoleMessageReceivedCallback):
1660         (ConsoleMessageTest::ConsoleMessageTest):
1661         (ConsoleMessageTest::~ConsoleMessageTest):
1662         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1663         (testWebKitConsoleMessageConsoleAPI):
1664         (testWebKitConsoleMessageJavaScriptException):
1665         (testWebKitConsoleMessageNetworkError):
1666         (testWebKitConsoleMessageSecurityError):
1667         (beforeAll):
1668         (afterAll):
1669         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1670         (consoleMessageSentCallback):
1671         (pageCreatedCallback):
1672
1673 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1674
1675         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1676         https://bugs.webkit.org/show_bug.cgi?id=151934
1677
1678         Reviewed by Csaba Osztrogonác.
1679
1680         * MiniBrowser/efl/main.c:
1681         (on_window_deletion): Revert the changes of r192767.
1682
1683 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1684
1685         [GTK] update-webkitgtk-libs cannot build mesa
1686         https://bugs.webkit.org/show_bug.cgi?id=151535
1687
1688         Reviewed by Martin Robinson.
1689
1690         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1691         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1692         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1693         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1694         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1695         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1696
1697         * gtk/jhbuild.modules:
1698
1699 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1700
1701         [GTK][Mac] libWebExtensionTest link error
1702         https://bugs.webkit.org/show_bug.cgi?id=150802
1703
1704         Reviewed by Carlos Garcia Campos.
1705
1706         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1707
1708 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1709
1710         TestNetscapePlugIn: Fix leaks found by static analyzer
1711         <http://webkit.org/b/151881>
1712
1713         Reviewed by Darin Adler.
1714
1715         Fixes the following leaks found by the static analyzer:
1716             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1717                     return false;
1718                            ^~~~~
1719             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1720                     return false;
1721                            ^~~~~
1722             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1723                     return false;
1724                            ^~~~~
1725
1726         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1727         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1728         early return if allocation fails.
1729         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1730         Make sure to call fclose() on filehandle, even for an early
1731         return.
1732         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1733
1734 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1735
1736         prepare-ChangeLog: Fix some warning messages when using svn
1737         <http://webkit.org/b/151914>
1738
1739         Reviewed by Daniel Bates.
1740
1741         * Scripts/prepare-ChangeLog:
1742         (generateFunctionLists): Simplify logic so that we never call
1743         normalizePath() with an undefined value.
1744         (attributeCommand): Quote $subPath for the shell so that we
1745         don't try to run "svn propget" on invalid paths.
1746
1747 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1748
1749         TestNetscapePlugIn: Fix remaining static analyzer warnings
1750         <http://webkit.org/b/151888>
1751
1752         Reviewed by Alexey Proskuryakov.
1753
1754         Fixes the following static analyzer warnings:
1755             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1756                     CRASH();
1757                     ^~~~~~~
1758             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1759                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1760                 ^~~~~~~~~~~~~~~~
1761             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1762                 return obj->pluginTest->NPP_SetWindow(window);
1763                        ^~~~~~~~~~~~~~~
1764             2 warnings generated.
1765
1766         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1767         (CRASH): Use __builtin_trap() for gcc/clang.
1768         (NPP_SetWindow): Add early return if obj is nullptr.
1769
1770 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1771
1772         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1773         https://bugs.webkit.org/show_bug.cgi?id=151797
1774
1775         Reviewed by Martin Robinson.
1776
1777         Since we switched to use the network process to run the unit tests
1778         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1779         sometimes passes. We are now also getting the notification for the
1780         css image. Since we wait for 3 resources, sometimes the css image
1781         is loaded before and then checkResourceData is called for it, but
1782         not handled. When the css image is the last one loaded the test
1783         passes. So, we just need to wait for the 4 resources.
1784
1785         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1786         (testWebResourceGetData):
1787
1788 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1789
1790         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1791         <http://webkit.org/b/151845>
1792
1793         Reviewed by Simon Fraser.
1794
1795         Fixes the following static analyzer warning:
1796             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1797                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1798                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1799
1800         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1801         (createBitmapContext): Free 'buffer' after using it in logging
1802         to fix the use-after-free.  Assign a value of nullptr to buffer
1803         so we don't return with it set to a freed address.
1804
1805 2015-12-03  Jer Noble  <jer.noble@apple.com>
1806
1807         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1808         https://bugs.webkit.org/show_bug.cgi?id=151830
1809
1810         Reviewed by Anders Carlsson.
1811
1812         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1813
1814         * DumpRenderTree/mac/DumpRenderTree.mm:
1815         (resetWebPreferencesToConsistentValues):
1816         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1817         (WTR::initializeWebViewConfiguration):
1818
1819 2015-12-03  Anders Carlsson  <andersca@apple.com>
1820
1821         Remove Objective-C GC support
1822         https://bugs.webkit.org/show_bug.cgi?id=151819
1823         rdar://problem/23746991
1824
1825         Reviewed by Dan Bernstein.
1826
1827         * asan/asan.xcconfig:
1828
1829 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1830
1831         Allow nil for unspecified benchmark pathes
1832         https://bugs.webkit.org/show_bug.cgi?id=151784
1833
1834         Reviewed by Filip Pizlo.
1835
1836         `Pathname.new(nil)` will raise an error.
1837         Only generate Pathname if the benchmark path is specified.
1838
1839         * Scripts/run-jsc-benchmarks:
1840
1841 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1842
1843         [Win] Run non-http tests without Cygwin
1844         https://bugs.webkit.org/show_bug.cgi?id=151721
1845
1846         Reviewed by Andy Estes.
1847
1848         Support native 32-bit and 64-bit Python (and Perl) builds
1849         for running tests:
1850
1851         1. Use "startswith('win')", rather than "== 'win32'" to support
1852         various Windows build types.
1853         2. Supply full path for some native Windows utilities, since the
1854         path environment does not always have the specified, and they are
1855         guaranteed to exist in those specific locations.
1856         3. Make sure native Windows Python test runs pass proper environment
1857         variables to run programs.
1858         4. Append 'exe' suffix when running Windows executables.
1859         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1860         command doesn't exist.
1861         
1862         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1863         the current Perl executable, rather than requiring a new path search.
1864         * Scripts/webkitpy/common/find_files_unittest.py:
1865         (TestWinNormalize.test_win): Use startswith('win').
1866         * Scripts/webkitpy/common/prettypatch_unittest.py:
1867         (test_pretty_diff_encodings): Ditto.
1868         * Scripts/webkitpy/common/system/executive.py:
1869         (Executive._should_close_fds): Ditto.
1870         (Executive.shell_command_for_script): Use startswith('win').
1871         (Executive.kill_process): Use full path to killall executable.
1872         (Executive.check_running_pid): Use startswith('win').
1873         (Executive.running_pids): Ditto.
1874         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1875         running under native Windows Python.
1876         (Executive._child_process_encoding): Use startswith('win').
1877         (Executive._should_encode_child_process_arguments): Ditto.
1878         (Executive.popen): Recognize proper script engine on Windows, since it
1879         does not support the shebang syntax.
1880         (Executive.run_in_parallel): Use startswith('win').
1881         * Scripts/webkitpy/common/system/executive_unittest.py:
1882         (never_ending_command): Ditto.
1883         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1884         (ExecutiveTest.serial_test_kill_process): Ditto.
1885         (ExecutiveTest.serial_test_kill_all): Ditto.
1886         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1887         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1888         (main): Ditto.
1889         * Scripts/webkitpy/common/system/file_lock.py:
1890         (FileLock._create_lock): Ditto.
1891         (FileLock._remove_lock): Ditto.
1892         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1893         (RealFileSystemTest.test_chdir): Ditto.
1894         (RealFileSystemTest.test_chdir__notexists): Ditto.
1895         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1896         * Scripts/webkitpy/common/system/path_unittest.py:
1897         (AbspathTest.test_abspath_to_uri_win): Ditto.
1898         * Scripts/webkitpy/common/system/platforminfo.py:
1899         (PlatformInfo._determine_os_name): Ditto.
1900         * Scripts/webkitpy/common/system/user.py: Ditto.
1901         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1902         (ManagerTest.integration_test_needs_servers): Ditto.
1903         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1904         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1905         driver letters.
1906         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1907         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1908         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1909         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1910         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1911         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1912         (TestHttpServer.test_start_cmd): Ditto.
1913         * Scripts/webkitpy/port/base.py:
1914         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1915         and 'SYSTEMROOT' in environment passed to test runners.
1916         (Port._apache_config_file_name_for_platform): Use startswith('win').
1917         (Port._build_path): Ditto.
1918         (Port._path_to_driver): Include 'exe' suffix when running under native
1919         Windows.
1920         * Scripts/webkitpy/port/driver.py:
1921         (Driver._setup_environ_for_driver): Explicitly make some environment
1922         variables strings.
1923         * Scripts/webkitpy/port/server_process.py:
1924         (ServerProcess.__init__): Use startswith('win').
1925         * Scripts/webkitpy/port/win.py:
1926         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1927         registry key formats.
1928         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1929         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1930         and regtool on Cygwin.
1931         (WinPort.write_registry_value): Ditto.
1932         (WinPort.setup_crash_log_saving): Ditto.
1933         (WinPort.restore_crash_log_saving): Ditto.
1934         (WinPort.prevent_error_dialogs): Ditto.
1935         (WinPort.allow_error_dialogs): Ditto.
1936         (WinPort.find_system_pid): Revise to use Windows management
1937         infrastructure on native Windows, continue using 'ps' on Cygwin.
1938         (WinPort.read_registry_string): Deleted.
1939         (WinPort.write_registry_string): Deleted.
1940         * Scripts/webkitpy/test/main.py:
1941         (main): Use startswith('win').
1942         (Tester._parse_args): Ditto.
1943
1944 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1945
1946         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1947         https://bugs.webkit.org/show_bug.cgi?id=150792
1948
1949         Reviewed by Saam Barati.
1950
1951         * Scripts/webkitperl/FeatureList.pm:
1952
1953 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1954
1955         Unreviewed, rolling out r192914.
1956         https://bugs.webkit.org/show_bug.cgi?id=151734
1957
1958         JSC tests for this change are failing on 32 and 64-bit bots
1959         (Requested by ryanhaddad on #webkit).
1960
1961         Reverted changeset:
1962
1963         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1964         enable this feature"
1965         https://bugs.webkit.org/show_bug.cgi?id=150792
1966         http://trac.webkit.org/changeset/192914
1967
1968 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1969
1970         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1971         <http://webkit.org/b/151726>
1972
1973         Reviewed by Simon Fraser.
1974
1975         * WebKitTestRunner/mac/EventSenderProxy.mm:
1976         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1977         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1978
1979 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1980
1981         Give String and AtomicString an existingHash() function
1982         https://bugs.webkit.org/show_bug.cgi?id=151717
1983
1984         Reviewed by Andreas Kling.
1985
1986         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1987         (TestWebKitAPI::TEST):
1988         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1989         (TestWebKitAPI::TEST):
1990
1991 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1992
1993         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1994         https://bugs.webkit.org/show_bug.cgi?id=150792
1995
1996         Reviewed by Saam Barati.
1997
1998         * Scripts/webkitperl/FeatureList.pm:
1999
2000 2015-12-01  Sam Weinig  <sam@webkit.org>
2001
2002         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2003         <rdar://problem/23320863>
2004         https://bugs.webkit.org/show_bug.cgi?id=151708
2005
2006         Reviewed by Anders Carlsson.
2007
2008         * WebKitTestRunner/TestController.cpp:
2009         (WTR::TestController::createOtherPage):
2010         (WTR::TestController::createWebViewWithOptions):
2011         Update for new WKPageUIClient.
2012
2013 2015-12-01  Anders Carlsson  <andersca@apple.com>
2014
2015         Remove WebKit2.framework
2016         https://bugs.webkit.org/show_bug.cgi?id=151715
2017
2018         Reviewed by Dan Bernstein.
2019
2020         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2021         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2022         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2023         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2024         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2025         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2026         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2027
2028 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2029
2030         Unreviewed common typo fix "occurance" => "occurrence".
2031
2032         * Scripts/webkitpy/tool/commands/queries.py:
2033         (FindFlakyTests._print_statistics):
2034
2035 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2036
2037         Make ProcessModel always MultipleSecondaryProcesses
2038         https://bugs.webkit.org/show_bug.cgi?id=151662
2039
2040         Reviewed by Antti Koivisto.
2041
2042         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2043         (TestWebKitAPI::TEST):
2044         * WebKitTestRunner/TestController.cpp:
2045         (WTR::TestController::generatePageConfiguration):
2046
2047 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2048
2049         Make usesNetworkProcess always true
2050         https://bugs.webkit.org/show_bug.cgi?id=151580
2051
2052         Reviewed by Darin Adler.
2053
2054         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2055         (TestWebKitAPI::TEST):
2056         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2057         (TestWebKitAPI::TEST):
2058         * WebKitTestRunner/TestController.cpp:
2059         (WTR::TestController::generatePageConfiguration):
2060
2061 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2064
2065         Add a way to skip unit tests only for Debug or Release builds and
2066         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2067
2068         * Scripts/run-gtk-tests:
2069         (SkippedTest):
2070         (SkippedTest.__init__):
2071         (SkippedTest.__str__):
2072         (SkippedTest.skip_entire_suite):
2073         (SkippedTest.skip_for_build_type):
2074         (TestRunner):
2075         (TestRunner.__init__):
2076
2077 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2078
2079         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2080
2081         It's an assert hit because we are reloading a view loaded with
2082         HTML data which is not supported. Use loadURI instead.
2083
2084         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2085         (testWebViewCustomCharset):
2086
2087 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2088
2089         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2090         https://bugs.webkit.org/show_bug.cgi?id=151633
2091
2092         Reviewed by Csaba Osztrogonác.
2093
2094         * TestWebKitAPI/PlatformGTK.cmake:
2095         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2096
2097 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2098
2099         [GTK] Remove the remaining uses of GMainLoopSource
2100         https://bugs.webkit.org/show_bug.cgi?id=151632
2101
2102         Reviewed by Žan Doberšek.
2103
2104         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2105         (testWebViewSyncRequestOnMaxConns):
2106         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2107         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2108         (WTR::TestRunner::TestRunner):
2109         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2110         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2111         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2112         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2113         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2114         (WTR::timeoutSource):
2115         (WTR::TestController::notifyDone):
2116         (WTR::TestController::platformRunUntil):
2117
2118 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2119
2120         [cmake] Add testb3 to the build system
2121         https://bugs.webkit.org/show_bug.cgi?id=151619
2122
2123         Reviewed by Gyuyoung Kim.
2124
2125         * Scripts/build-jsc:
2126
2127 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2128
2129         [jhbuild] Fix pixman build with clang
2130         https://bugs.webkit.org/show_bug.cgi?id=151441
2131
2132         Reviewed by Carlos Garcia Campos.
2133
2134         * efl/jhbuild.modules:
2135         * gtk/jhbuild.modules:
2136
2137 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2138
2139         Extract prependToEnvironmentVariableList
2140         <http://webkit.org/b/151536>
2141
2142         Reviewed by Daniel Bates.
2143
2144         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2145                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2146
2147         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2148         and prependToEnvironmentVariableList.
2149         (appendToEnvironmentVariableList): Simplify variable name.
2150         Switch to use $Config{path_sep}.
2151         (prependToEnvironmentVariableList): Add new method.
2152         (setupMacWebKitEnvironment): Switch to use
2153         prependToEnvironmentVariableList().
2154         (setupIOSWebKitEnvironment): Ditto.
2155
2156         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2157         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2158
2159 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2160
2161         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2162         https://bugs.webkit.org/show_bug.cgi?id=151567
2163
2164         Reviewed by Darin Adler.
2165
2166         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2167         (on_window_deletion):
2168
2169 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2170
2171         [GTK] Use the network process unconditionally
2172         https://bugs.webkit.org/show_bug.cgi?id=151541
2173
2174         Reviewed by Alex Christensen.
2175
2176         Fix TestInspectorServer test. Do not assume we already have the
2177         title we want when the page has been loaded, since the title is
2178         changed afterwards. So, check if the title has already been set,
2179         and if not wait for it.
2180
2181         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2182         (openRemoteDebuggingSession):
2183
2184 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2185
2186         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2187         https://bugs.webkit.org/show_bug.cgi?id=151532
2188
2189         Reviewed by Benjamin Poulain.
2190
2191         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2192         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2193         (TestWebKitAPI::TEST):
2194         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2195         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2196         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2197         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2198         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2199         so it was calling a function on a test object that had gone out of scope.
2200         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2201         but that will become the default soon and that call will be removed.
2202
2203 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2204
2205         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2206         <http://webkit.org/b/151542>
2207
2208         Reviewed by Daniel Bates.
2209
2210         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2211         (base_url): Use the Port object (already passed in) to give us
2212         the path to the LayoutTests directory, which already checks for a
2213         --layout-tests-directory command-line switch.
2214         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2215         argument since we can get this from the Port object already
2216         passed in via Port.results_directory().  Also switch to use
2217         Port.layout_tests_dir() to get the LayoutTests directory.
2218
2219         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2220         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2221         Add test case for custom LayoutTests directory.
2222         (TestWebPlatformTestServer.test_previously_spawned_instance):
2223         Update Port object to set mock results directory as if it was
2224         set on the command-line.  Remove unneeded argument from
2225         WebPlatformTestServer constructor.
2226         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2227
2228         * Scripts/webkitpy/port/base.py:
2229         (Port.to.start_web_platform_test_server): Remove unneeded
2230         argument from WebPlatformTestServer constuctor.
2231
2232 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2233
2234         [GTK] Some unit tests fail when using the network process
2235         https://bugs.webkit.org/show_bug.cgi?id=151490
2236
2237         Reviewed by Martin Robinson.
2238
2239         Run the soup server in a separate thread in TestResources test to
2240         avoid deadlocks.
2241
2242         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2243         /webkit2/WebKitWebResource/get-data when using the network process.
2244
2245         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2246         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2247         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2248         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2249         present, create a WorkQueue to run the server.
2250         (WebKitTestServer::run): Run the server in the work queue if it
2251         has been created.
2252         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2253         type into server options as flags.
2254
2255 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2256
2257         [GTK] ImageDiff should normalize the diff image
2258         https://bugs.webkit.org/show_bug.cgi?id=151261
2259
2260         Reviewed by Sergio Villar Senin.
2261
2262         * ImageDiff/gtk/ImageDiff.cpp:
2263         (readPixbufFromStdin): Fix memory leak.
2264         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2265         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2266
2267 == Rolled over to ChangeLog-2015-11-21 ==