80c72345c3a40e6a1dd7073b42f67377227ebb6d
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Cancel build and similar operations should have authentication
4         https://bugs.webkit.org/show_bug.cgi?id=196520
5
6         Reviewed by Dewei Zhu.
7
8         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
9         environment variables.
10
11 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-build] Do not trigger queues which are not in production yet
14         https://bugs.webkit.org/show_bug.cgi?id=196581
15
16         Reviewed by Dewei Zhu.
17
18         * BuildSlaveSupport/ews-build/config.json:
19
20 2019-04-03  Chris Dumez  <cdumez@apple.com>
21
22         Unreviewed, fix typo in the name of API test added in r243848.
23
24         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
25         (TestWebKitAPI::TEST):
26
27 2019-04-03  Chris Dumez  <cdumez@apple.com>
28
29         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
30         https://bugs.webkit.org/show_bug.cgi?id=196588
31         <rdar://problem/49365787>
32
33         Reviewed by Ryosuke Niwa.
34
35         Add API test coverage.
36
37         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
38         (TestWebKitAPI::nullJavaScriptCallback):
39         (TestWebKitAPI::didCrashCheckFrames):
40         (TestWebKitAPI::TEST):
41
42 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
43
44         run-webkit-tests: Upload test results (new results database)
45         https://bugs.webkit.org/show_bug.cgi?id=196577
46         <rdar://problem/34841155>
47
48         Reviewed by Lucas Forschler.
49
50         * Scripts/webkitpy/layout_tests/controllers/manager.py:
51         (Manager.run): Upload results after each device shard, since the configuration will be
52         different for each device.
53         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
54         uploaded to a results database.
55         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
56         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
57
58 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
59
60         -apple-trailing-word is needed for browser detection
61         https://bugs.webkit.org/show_bug.cgi?id=196575
62
63         Unreviewed.
64
65         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
66
67 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
68
69         [CMake][WTF] Mirror XCode header directories
70         https://bugs.webkit.org/show_bug.cgi?id=191662
71
72         Reviewed by Konstantin Tokarev.
73
74         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
75         builds.
76
77         * CMakeLists.txt:
78         * DumpRenderTree/CMakeLists.txt:
79         * DumpRenderTree/PlatformWin.cmake:
80         * MiniBrowser/win/CMakeLists.txt:
81         * TestWebKitAPI/CMakeLists.txt:
82         * TestWebKitAPI/PlatformWin.cmake:
83         * WebKitTestRunner/PlatformGTK.cmake:
84         * WebKitTestRunner/PlatformWin.cmake:
85
86 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
87
88         [ews-app] Status bubble should not display certain infrastructure status messages
89         https://bugs.webkit.org/show_bug.cgi?id=196550
90
91         Reviewed by Lucas Forschler.
92
93         Do not display the steps which are un-needed for end-user. This information is still avaiable
94         if the user click on the bubble and look at the Buildbot build.
95         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
96         (StatusBubble._steps_messages):
97         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
98
99 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
100
101         [ews-build] Use https for sending data to ews-app
102         https://bugs.webkit.org/show_bug.cgi?id=196492
103
104         Reviewed by Lucas Forschler.
105
106         * BuildSlaveSupport/ews-build/events.py:
107
108 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
109
110         Remove support for -apple-trailing-word
111         https://bugs.webkit.org/show_bug.cgi?id=196525
112
113         Reviewed by Zalan Bujtas.
114
115         This CSS property is nonstandard and not used.
116
117         * Scripts/webkitperl/FeatureList.pm:
118         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
119
120 2019-04-03  Youenn Fablet  <youenn@apple.com>
121
122         Add a test for DOMCache on multiple browsing in case of private browsing
123         https://bugs.webkit.org/show_bug.cgi?id=196524
124
125         Reviewed by Alex Christensen.
126
127         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
128         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
129
130 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
131
132         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
133         https://bugs.webkit.org/show_bug.cgi?id=196540
134
135         Reviewed by Aakash Jain.
136
137         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
138
139 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
140
141         Add plumbing for a compatibility mode preference in WebKit
142         https://bugs.webkit.org/show_bug.cgi?id=196005
143
144         Reviewed by Tim Horton.
145
146         Add new API tests.
147
148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
149         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
150
151 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
152
153         [WPE][GTK] Update libsrtp dependency package for Debian
154         https://bugs.webkit.org/show_bug.cgi?id=196528
155
156         Reviewed by Frédéric Wang.
157
158         * gtk/install-dependencies:
159         * wpe/install-dependencies:
160
161 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
162
163         [WK2] Add support for Window's beforeprint / afterprint events
164         https://bugs.webkit.org/show_bug.cgi?id=196478
165         <rdar://problem/49535124>
166
167         Unreviewed build fix for MSVC.
168
169         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
170
171         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
172
173         * WebKitTestRunner/TestController.cpp:
174         (WTR::printFrame): Use int and float literals.
175
176 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
177
178         [ews-build] Reassign bots to queues
179
180         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
181
182 2019-04-02  Chris Dumez  <cdumez@apple.com>
183
184         [WK2] Add support for Window's beforeprint / afterprint events
185         https://bugs.webkit.org/show_bug.cgi?id=196478
186
187         Reviewed by Alex Christensen.
188
189         Add minimal implementation for printFrame in WebKitTestRunner.
190
191         * WebKitTestRunner/TestController.cpp:
192         (WTR::printFrame):
193         (WTR::TestController::createOtherPage):
194         (WTR::TestController::createWebViewWithOptions):
195
196 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
197
198         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
199         https://bugs.webkit.org/show_bug.cgi?id=196491
200
201         Reviewed by Lucas Forschler.
202
203         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
204
205 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
206
207         [ews-build] Configure buildbot try credentials in environment variables
208         https://bugs.webkit.org/show_bug.cgi?id=196501
209
210         Reviewed by Lucas Forschler.
211
212         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
213         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
214         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
215
216 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
217
218         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
219         https://bugs.webkit.org/show_bug.cgi?id=196496
220         <rdar://problem/49521634>
221
222         Reviewed by Chris Dumez.
223
224         Add new API tests (see WebKit ChangeLog for more detail).
225
226         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
227         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
228         (TEST):
229
230 2019-04-02  David Kilzer  <ddkilzer@apple.com>
231
232         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
233         <https://webkit.org/b/196499>
234
235         Reviewed by Alexey Proskuryakov.
236
237         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
238         ENABLE_ADDRESS_SANITIZER.
239
240 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
241
242         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
243         https://bugs.webkit.org/show_bug.cgi?id=182757
244
245         Reviewed by Don Olmstead.
246
247         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
248         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
249
250 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
251
252         run-api-tests: Upload test results
253         https://bugs.webkit.org/show_bug.cgi?id=196323
254         <rdar://problem/49356714>
255
256         Reviewed by Lucas Forschler.
257
258         * Scripts/webkitpy/api_tests/manager.py:
259         (Manager):
260         (Manager.run): Upload results to a results database.
261         * Scripts/webkitpy/api_tests/run_api_tests.py:
262         (parse_args): Add upload arguments.
263         * Scripts/webkitpy/port/base.py:
264         (Port):
265         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
266         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
267         with commits from any other associated repositories.
268         * Scripts/webkitpy/port/device.py:
269         (Device):
270         (Device.build_version): Access build_versoin of underlying platform device.
271         * Scripts/webkitpy/port/ios_simulator_unittest.py:
272         (IOSSimulatorTest):
273         (IOSSimulatorTest.test_configuration_for_upload):
274         * Scripts/webkitpy/port/device_port.py:
275         (DevicePort):
276         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
277         the same as the machine uploading results.
278         * Scripts/webkitpy/port/mac.py:
279         (MacPort):
280         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
281         * Scripts/webkitpy/port/mac_unittest.py:
282         (MacTest):
283         (MacTest.test_configuration_for_upload):
284         * Scripts/webkitpy/xcode/simulated_device.py:
285         (SimulatedDeviceManager._create_device_with_runtime):
286         (SimulatedDevice.__init__): Create simulated device with a build_version.
287         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
288         (test_existing_simulator):
289
290 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
291
292         Remove extra newline characters (Follow-up fix to r243707)
293
294         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
295
296 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
297
298         [ews-app] Use API_KEY to accept results data
299         https://bugs.webkit.org/show_bug.cgi?id=196461
300
301         Reviewed by Dewei Zhu.
302
303         * BuildSlaveSupport/ews-app/ews/views/results.py:
304         (Results.post): Validate EWS_API_KEY before accepting any data.
305         * BuildSlaveSupport/ews-build/events.py:
306         (Events.sendData): Send EWS_API_KEY if available along with event data.
307
308 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
309
310         Unable to copy and paste a PDF from Notes into Mail compose body
311         https://bugs.webkit.org/show_bug.cgi?id=196442
312         <rdar://problem/48573098>
313
314         Reviewed by Tim Horton.
315
316         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
317         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
318         to be specified on the item providers.
319
320         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
321         (TestWebKitAPI::mapItemForTesting):
322         (TestWebKitAPI::contactItemForTesting):
323
324 2019-04-01  Tim Horton  <timothy_horton@apple.com>
325
326         Make UIWKDocumentContext rects per-character instead of per-word
327         https://bugs.webkit.org/show_bug.cgi?id=196459
328
329         Reviewed by Wenson Hsieh.
330
331         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
332         (TEST):
333         Adjust test results due to switching to per-character rects.
334
335 2019-04-01  Chris Dumez  <cdumez@apple.com>
336
337         UIProcess crash when a prewarmed process is terminated
338         https://bugs.webkit.org/show_bug.cgi?id=196451
339         <rdar://problem/49245471>
340
341         Reviewed by Geoffrey Garen.
342
343         Add API test coverage.
344
345         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
346         (TEST):
347
348 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
349
350         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
351         https://bugs.webkit.org/show_bug.cgi?id=196449
352
353         Reviewed by Lucas Forschler.
354
355         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
356         (StatusBubble.get_os_details): Method to get OS and Xcode details.
357         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
358         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
359
360 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
361
362         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
363         https://bugs.webkit.org/show_bug.cgi?id=196444
364
365         Reviewed by Lucas Forschler.
366
367         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
368
369 2019-04-01  Alex Christensen  <achristensen@webkit.org>
370
371         Add SPI to canonicalize NSURLs with WTF::URL
372         https://bugs.webkit.org/show_bug.cgi?id=196415
373         <rdar://problem/44980271>
374
375         Reviewed by Darin Adler.
376
377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
378         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
379         (TestWebKitAPI::TEST):
380
381 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
382
383         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
384         https://bugs.webkit.org/show_bug.cgi?id=196441
385
386         Reviewed by Carlos Garcia Campos.
387
388         Don't cache the wpe_view_backend object that might not exist yet at the
389         time of EventSenderProxy constructor invocation, but instead retrieve
390         that object whenever it's required for event dispatching. This should
391         avoid crashes in this constructor now that it's invoked before any
392         PlatformWindow has been set up (as changed in r243496).
393
394         * WebKitTestRunner/EventSenderProxy.h:
395         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
396         (WTR::viewBackend):
397         (WTR::EventSenderProxy::EventSenderProxy):
398         (WTR::EventSenderProxy::mouseDown):
399         (WTR::EventSenderProxy::mouseUp):
400         (WTR::EventSenderProxy::mouseMoveTo):
401         (WTR::EventSenderProxy::mouseScrollBy):
402         (WTR::EventSenderProxy::keyDown):
403         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
404
405 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
406
407         [Win][WebKit] MiniBrowser should support high DPI display
408         https://bugs.webkit.org/show_bug.cgi?id=196391
409
410         Reviewed by Alex Christensen.
411
412         * MiniBrowser/win/WebKitBrowserWindow.cpp:
413         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
414         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
415         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
416
417 2019-03-31  Sam Weinig  <weinig@apple.com>
418
419         Remove more i386 specific configurations
420         https://bugs.webkit.org/show_bug.cgi?id=196430
421
422         Reviewed by Alexey Proskuryakov.
423
424         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
425         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
426
427 2019-03-31  Andy Estes  <aestes@apple.com>
428
429         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
430         https://bugs.webkit.org/show_bug.cgi?id=196433
431         <rdar://problem/49293305>
432
433         Reviewed by Tim Horton.
434
435         Enhanced API test coverage to include all navigation response policy decisions in both
436         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
437
438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
439         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
440         (TestWebKitAPI::TEST):
441         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
442         (readFile):
443         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
444         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
445         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
446         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
447         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
448         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
449         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
450         (-[QuickLookDelegate _downloadDidStart:]):
451         (-[QuickLookDelegate _download:didReceiveResponse:]):
452         (-[QuickLookDelegate _download:didReceiveData:]):
453         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
454         (-[QuickLookDelegate _downloadDidFinish:]):
455         (-[QuickLookDelegate _download:didFailWithError:]):
456         (-[QuickLookDelegate _downloadDidCancel:]):
457         (-[QuickLookDelegate verifyDownload]):
458         (runTest):
459         (runTestDecideBeforeLoading):
460         (runTestDecideAfterLoading):
461         (TEST):
462         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
463         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
464         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
465         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
466         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
467         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
468         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
469         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
470         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
471         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
472         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
473         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
474         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
475         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
476
477 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
478
479         [CMake] add testdfg as target with build-jsc
480         https://bugs.webkit.org/show_bug.cgi?id=196393
481
482         Reviewed by Saam Barati.
483
484         Added testdfg as one of the targets to build when
485         using CMake.
486
487         * Scripts/build-jsc:
488
489 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
490
491         Delete WebMetal implementation in favor of WebGPU
492         https://bugs.webkit.org/show_bug.cgi?id=195418
493
494         Reviewed by Dean Jackson.
495
496         * DumpRenderTree/mac/DumpRenderTree.mm:
497         (enableExperimentalFeatures):
498         (resetWebPreferencesToConsistentValues):
499         * Scripts/webkitperl/FeatureList.pm:
500         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
502         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
503         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
504         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
505         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
506         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
507         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
508         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
509         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
510         (WTR::InjectedBundle::beginTesting):
511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
512         (WTR::TestRunner::setWebMetalEnabled): Deleted.
513         * WebKitTestRunner/InjectedBundle/TestRunner.h:
514
515 2019-03-29  Chris Dumez  <cdumez@apple.com>
516
517         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
518         https://bugs.webkit.org/show_bug.cgi?id=196405
519         <rdar://problem/49428130>
520
521         Reviewed by Wenson Hsieh.
522
523         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
524         the popover presentation methods to be no-ops. Use this in the new test added in
525         r243523 so that we do not swizzle those methods for all tests. This is needed because
526         those WatchOS tests rely on the popover getting presented and interactive.
527
528         * WebKitTestRunner/TestController.cpp:
529         (WTR::updateTestOptionsFromTestHeader):
530         * WebKitTestRunner/TestController.h:
531         * WebKitTestRunner/TestOptions.h:
532         (WTR::TestOptions::hasSameInitializationOptions const):
533         * WebKitTestRunner/ios/TestControllerIOS.mm:
534         (WTR::TestController::platformInitialize):
535         (WTR::TestController::platformResetStateToConsistentValues):
536
537 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
538
539         [Curl] Add Server Trust Evaluation Support.
540         https://bugs.webkit.org/show_bug.cgi?id=191646
541
542         Reviewed by Fujii Hironori.
543
544         Implemented MiniBrowser UI for asking if user trusts the server.
545
546         * MiniBrowser/win/Common.cpp:
547         (askServerTrustEvaluation):
548         (replaceString):
549         * MiniBrowser/win/Common.h:
550         * MiniBrowser/win/MiniBrowserLib.rc:
551         * MiniBrowser/win/MiniBrowserLibResource.h:
552         * MiniBrowser/win/WebKitBrowserWindow.cpp:
553         (createPEMString):
554         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
555         (WebKitBrowserWindow::canTrustServerCertificate):
556         * MiniBrowser/win/WebKitBrowserWindow.h:
557
558 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
559
560         Implement ResizeObserver.
561         https://bugs.webkit.org/show_bug.cgi?id=157743
562
563         Reviewed by Simon Fraser.
564
565         Support resizeObserverEnabled webPreferences.
566
567         * DumpRenderTree/TestOptions.cpp:
568         (TestOptions::TestOptions):
569         * DumpRenderTree/TestOptions.h:
570         * DumpRenderTree/mac/DumpRenderTree.mm:
571         (setWebPreferencesForTestOptions):
572         * DumpRenderTree/win/DumpRenderTree.cpp:
573         (enableExperimentalFeatures):
574         * Scripts/webkitperl/FeatureList.pm:
575         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
576
577 2019-03-28  John Wilander  <wilander@apple.com>
578
579         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
580         https://bugs.webkit.org/show_bug.cgi?id=196281
581         <rdar://problem/48938748>
582
583         Reviewed by Alex Christensen.
584
585         This patch adds the function isStatisticsHasLocalStorage() to the
586         TestRunner. With it, the page can query the WebsiteDataStore in the
587         UI process to make sure that it sees LocalStorage.
588
589         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
591         (WTR::TestRunner::isStatisticsHasLocalStorage):
592         * WebKitTestRunner/InjectedBundle/TestRunner.h:
593         * WebKitTestRunner/TestController.cpp:
594         (WTR::TestController::isStatisticsHasLocalStorage):
595         * WebKitTestRunner/TestController.h:
596         * WebKitTestRunner/TestInvocation.cpp:
597         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
598
599 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
600
601         API::Data::createWithoutCopying should do a null check before calling CFRelease
602         https://bugs.webkit.org/show_bug.cgi?id=196276
603         <rdar://problem/48059859>
604
605         Reviewed by Alex Christensen.
606
607         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
608
609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
610         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
611         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
612         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
613         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
614         (TestWebKitAPI::TEST):
615
616 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
617
618         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
619         https://bugs.webkit.org/show_bug.cgi?id=186276
620
621         Reviewed by Carlos Garcia Campos.
622
623         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
624         (webViewLoadChanged):
625         (testWebResourceGetDataError):
626         (testWebResourceGetDataEmpty):
627         (beforeAll):
628         (webViewloadChanged): Deleted.
629
630 2019-03-27  Andy Estes  <aestes@apple.com>
631
632         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
633         https://bugs.webkit.org/show_bug.cgi?id=196317
634
635         Reviewed by Dan Bernstein.
636
637         package-root copies built products into a staging directory using ditto(1), which does not
638         follow symbolic links as it traverses a directory. Now that the files in
639         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
640         itself, these become broken links when ditto'd into the staging directory.
641
642         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
643
644         * Scripts/package-root:
645
646 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
647
648         [ews-app] Update display text of Submit for ews analysis
649         https://bugs.webkit.org/show_bug.cgi?id=196309
650
651         Reviewed by Dewei Zhu.
652
653         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
654
655 2019-03-27  David Kilzer  <ddkilzer@apple.com>
656
657         run-webkit-tests should check for leaks in WebKit processes
658         <https://webkit.org/b/193772>
659         <rdar://problem/46526680>
660
661         Reviewed by Ryosuke Niwa.
662
663         This works by doing the following:
664         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
665           The list of child processes are returned one per line:
666           process.name: pid
667         - Run the "#LIST CHILD PROCESSES" command just before the
668           "#CHECK FOR WORLD LEAKS" command, and store the list of child
669           processes on the ServerProcess object.
670         - When the `--leaks` switch is handled, run check_for_leaks() on
671           each child process after the main test harness.
672
673         * DumpRenderTree/mac/DumpRenderTree.mm:
674         (handleControlCommand):
675         - Use strncmp() instead of strcmp().
676         - Add support for handling "#LIST CHILD PROCESSES" command.
677
678         * Scripts/webkitpy/port/base.py:
679         (Port.check_for_leaks):
680         * Scripts/webkitpy/port/darwin.py:
681         (DarwinPort.check_for_leaks):
682         - Rename redundant 'process_pid' argument to 'process_id'.
683
684         * Scripts/webkitpy/port/driver.py:
685         (Driver.do_post_tests_work):
686         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
687           longer the only command this sends to WebKitTestRunner.
688         - If the `--leaks` switch is present, send the
689           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
690           result using Port.set_webkit_processes().
691         (Driver._parse_child_processes_output):
692         - Add helper method to parse list of child process names and
693           process IDs returned from WebKitTestRunner.
694
695         * Scripts/webkitpy/port/ios_device.py:
696         (IOSDevicePort.check_for_leaks):
697         - Rename redundant 'process_pid' argument to 'process_id'.
698
699         * Scripts/webkitpy/port/leakdetector.py:
700         (LeakDetector._parse_leaks_output):
701         - Return early if there is no leaks_output.
702         (LeakDetector.check_for_leaks):
703         - Rename redundant 'process_pid' argument to 'process_id'.
704
705         * Scripts/webkitpy/port/server_process.py:
706         (ServerProcess.__init__):
707         (ServerProcess.child_processes):
708         (ServerProcess.set_child_processes):
709         - Add instance variable to Port to store list of child process
710           names and process IDs returned from WebKitTestRunner.
711         (ServerProcess._start):
712         - Clear self._child_processes.
713         (ServerProcess.stop):
714         - If self._child_processes is set, call
715           self._port.check_for_leaks() for each child process.
716
717         * Scripts/webkitpy/port/server_process_unittest.py:
718         (TrivialMockPort.check_for_leaks):
719         - Rename redundant 'process_pid' argument to 'process_id'.
720
721         * Scripts/webkitpy/port/simulator_process.py:
722         (SimulatorProcess.stop):
723         - If self._child_processes is set, call
724           self._port.check_for_leaks() for each child process.
725
726         * Scripts/webkitpy/port/watch_device.py:
727         (WatchDevicePort.check_for_leaks):
728         - Rename redundant 'process_pid' argument to 'process_id'.
729
730         * WebKitTestRunner/TestController.cpp:
731         (WTR::TestController::dumpResponse):
732         - Extract method from findAndDumpWorldLeaks() so that it may be
733           reused by findAndDumpWebKitProcessIdentifiers().
734         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
735         - Add method to output process name and process ID of both the
736           WebContent and Networking processes.
737         (WTR::TestController::findAndDumpWorldLeaks):
738         - Fix missing newline in output when there were no abandoned
739           documents.
740         - Call dumpResponse() for extracted code.
741         (WTR::TestController::handleControlCommand):
742         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
743         - Use strncmp() instead of strcmp().
744         - Call findAndDumpWebKitProcessIdentifiers() when
745           "#LIST CHILD PROCESSES" command is sent.
746         * WebKitTestRunner/TestController.h:
747         (WTR::TestController::dumpResponse):
748         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
749         - Declare methods.
750
751 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
752
753         Unreviewed. Add GLib API test cases after r243434.
754
755         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
756         (testWebViewActiveURI):
757         (serverCallback):
758         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
759         (sendRequestCallback):
760
761 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
762
763         Geolocation request not complete when watch request was started in a different web process
764         https://bugs.webkit.org/show_bug.cgi?id=195996
765
766         Reviewed by Alex Christensen.
767
768         Add a test case.
769
770         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
771         (TestWebKitAPI::runJavaScriptAlert):
772         (TestWebKitAPI::TEST):
773
774 2019-03-26  Keith Rollin  <krollin@apple.com>
775
776         Update the way generate-xcfilelists returns strings from functions
777         https://bugs.webkit.org/show_bug.cgi?id=195975
778         <rdar://problem/49040807>
779
780         Reviewed by Dean Jackson.
781
782         There are places where generate-xcfilelists executes assignments with
783         statements like:
784
785             FOO=$(some_function)
786
787         where "some_function" return a string by echoing it. E.g.
788
789             some_function()
790             {
791                 echo "Hello, World"
792             }
793
794         This is a common idiom, but it has a problem if "some_function" needs
795         to call "exit" in an attempt to halt the entire script right then and
796         there. Since "some_function" is called inside of $(), it's being
797         executed in a sub-shell. Calling exit in that sub-shell simply exits
798         that shell; it doesn't not exit the outer shell in which the main part
799         of the script is still running. As such, the main script keeps
800         executing when the intent was for the script to halt.
801
802         The solution to this is to use a different idiom for returning
803         strings. The one we now is to pass in the name of the variable to
804         receive the string result:
805
806             some_function()
807             {
808                 variable_name=$1
809                 eval $variable_name ="Hello, World"
810             }
811
812         The call site now looks like
813
814             some_function FOO
815
816         Because there's no invocation of a sub-shell, some_function can now
817         call "exit" if it wants to, and the entire script will exit at that
818         point.
819
820         * Scripts/generate-xcfilelists:
821
822 2019-03-26  Chris Dumez  <cdumez@apple.com>
823
824         Add basic layout test coverage for File Picker on iOS
825         https://bugs.webkit.org/show_bug.cgi?id=196265
826
827         Reviewed by Wenson Hsieh.
828
829         Add layout test infrastructure to test the file picker on iOS.
830
831         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
832         (WTR::UIScriptController::dismissFilePicker):
833         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
834         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
835         (WTR::UIScriptController::dismissFilePicker):
836         * TestRunnerShared/UIScriptContext/UIScriptController.h:
837         * WebKitTestRunner/TestController.cpp:
838         (WTR::TestController::createWebViewWithOptions):
839         (WTR::updateTestOptionsFromTestHeader):
840         * WebKitTestRunner/TestOptions.h:
841         (WTR::TestOptions::hasSameInitializationOptions const):
842         * WebKitTestRunner/ios/TestControllerIOS.mm:
843         (overridePresentViewController):
844         (WTR::TestController::platformInitialize):
845         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
846         (WTR::UIScriptController::dismissFilePicker):
847
848 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
849
850         Implement async paste method on UIWKInteractionViewProtocol
851         https://bugs.webkit.org/show_bug.cgi?id=196267
852         <rdar://problem/49236346>
853
854         Reviewed by Tim Horton.
855
856         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
857         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
858         are now a part of all iOS 12 internal SDKs.
859
860         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
861
862         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
863         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
864
865         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
866         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
867         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
868         * TestWebKitAPI/ios/UIKitSPI.h:
869
870 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
871
872         [ews-build] Use PostgreSQL for ews.webkit.org database
873         https://bugs.webkit.org/show_bug.cgi?id=196270
874
875         Reviewed by Lucas Forschler.
876
877         * BuildSlaveSupport/ews-app/ews-app/settings.py:
878
879 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
880
881         [ews] Reset simctl states on reboot
882         https://bugs.webkit.org/show_bug.cgi?id=196260
883
884         Rubber-stamped by Aakash Jain.
885
886         * EWSTools/start-queue-mac.sh:
887
888 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
889
890         [ews-build] Use PostgreSQL for ews-build database
891         https://bugs.webkit.org/show_bug.cgi?id=196229
892
893         Reviewed by Lucas Forschler.
894
895         * BuildSlaveSupport/ews-build/master.cfg:
896
897 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
898
899         [ews-build] Get master_hostname dynamically in master.cfg
900         https://bugs.webkit.org/show_bug.cgi?id=196255
901
902         Reviewed by Lucas Forschler.
903
904         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
905         send events data in test mode.
906
907 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
908
909         [ews-app] Set db_constraint to False for Foreign Keys
910         https://bugs.webkit.org/show_bug.cgi?id=196252
911
912         Reviewed by Lucas Forschler.
913
914         * BuildSlaveSupport/ews-app/ews/models/build.py:
915         * BuildSlaveSupport/ews-app/ews/models/step.py:
916
917 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
918
919         [ews-build] is_test_mode_enabled should default to True
920         https://bugs.webkit.org/show_bug.cgi?id=196248
921
922         Reviewed by Lucas Forschler.
923
924         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
925
926 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
927
928         [ews-app] Add webkitperl to ENABLED_QUEUES
929         https://bugs.webkit.org/show_bug.cgi?id=196253
930
931         Reviewed by Lucas Forschler.
932
933         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
934
935 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
936
937         Address NSWindow sometimes using WebKitTestRunnerEvent too early
938         https://bugs.webkit.org/show_bug.cgi?id=196211
939         rdar://problem/49110552
940
941         Reviewed by Tim Horton.
942
943         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
944         Make sure that EventSenderProxy always exists when running tests. We used to create
945         it when resetting before the first test, which is a bit too late.
946
947         * WebKitTestRunner/TestController.h:
948         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
949         (WTR::TestController::platformCreateWebView):
950         (WTR::TestController::platformCreateOtherPage):
951         (WTR::TestController::finishCreatingPlatformWebView):
952         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
953         (WTR::PlatformWebView::PlatformWebView):
954         Moved some code that made NSWindow use NSEvent during web view creation. We may
955         need to move more if some other case us found, but this is enough for now.
956
957 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
958
959         Unreviewed. Fix typo in GLib geolocation API after r243285.
960
961         gelocation -> geolocation.
962
963         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
964         (testGeolocationManagerWatchPosition):
965
966 2019-03-25  Alex Christensen  <achristensen@webkit.org>
967
968         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
969         https://bugs.webkit.org/show_bug.cgi?id=196213
970
971         Reviewed by Geoff Garen.
972
973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
974         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
975         (credentialWithIdentityAndKeychainPath):
976         (-[ChallengeDelegate webView:didFinishNavigation:]):
977         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
978         (TestWebKitAPI::TEST):
979
980 2019-03-25  Alex Christensen  <achristensen@webkit.org>
981
982         Expected shouldn't assume its contained types are copyable
983         https://bugs.webkit.org/show_bug.cgi?id=195986
984
985         Reviewed by JF Bastien.
986
987         * TestWebKitAPI/Tests/WTF/Expected.cpp:
988         (TestWebKitAPI::NonCopyable::operator== const):
989         (TestWebKitAPI::NonCopyable::operator!= const):
990         (TestWebKitAPI::TEST):
991
992 2019-03-25  Tim Horton  <timothy_horton@apple.com>
993
994         Remove some now-unnecessary dynamic class lookup
995         https://bugs.webkit.org/show_bug.cgi?id=196237
996
997         Reviewed by Simon Fraser.
998
999         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1000         (makeRequest):
1001         (TEST):
1002
1003 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1004
1005         Unreviewed, rolling out r243450.
1006
1007         AppleWin and WinCairo port builds get broken.
1008
1009         Reverted changeset:
1010
1011         "Add test for fix of #196095"
1012         https://bugs.webkit.org/show_bug.cgi?id=196097
1013         https://trac.webkit.org/changeset/243450
1014
1015 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1016
1017         Unreviewed, rolling out r243465.
1018         https://bugs.webkit.org/show_bug.cgi?id=196226
1019
1020         the test doesn't build (Requested by thorton on #webkit).
1021
1022         Reverted changeset:
1023
1024         "Do not terminate the NetworkProcess if a third party
1025         application sends a NSCredential with a SecIdentityRef"
1026         https://bugs.webkit.org/show_bug.cgi?id=196213
1027         https://trac.webkit.org/changeset/243465
1028
1029 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1030
1031         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1032         https://bugs.webkit.org/show_bug.cgi?id=196213
1033
1034         Reviewed by Geoff Garen.
1035
1036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1037         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1038         (credentialWithIdentityAndKeychainPath):
1039         (-[ChallengeDelegate webView:didFinishNavigation:]):
1040         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1041         (TestWebKitAPI::TEST):
1042
1043 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1044
1045         [ews-build] Gracefully handle missing patch_id in events
1046         https://bugs.webkit.org/show_bug.cgi?id=196216
1047
1048         Reviewed by Lucas Forschler.
1049
1050         * BuildSlaveSupport/ews-build/events.py:
1051
1052 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1053
1054         [ews-build] use lz4 compression for improving buildbot performance
1055         https://bugs.webkit.org/show_bug.cgi?id=196155
1056
1057         Reviewed by Lucas Forschler.
1058
1059         * BuildSlaveSupport/ews-build/master.cfg:
1060
1061 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1062
1063         Pull some API testing helper methods out of TestWKWebView
1064         https://bugs.webkit.org/show_bug.cgi?id=196212
1065
1066         Reviewed by Tim Horton.
1067
1068         Refactor some more API testing utility methods, so that they can be used in
1069         tests that do not use TestWKWebView.
1070
1071         * TestWebKitAPI/cocoa/TestWKWebView.h:
1072         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1073         (-[WKWebView loadTestPageNamed:]):
1074         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1075         (-[WKWebView synchronouslyLoadHTMLString:]):
1076         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1077         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1078         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1079         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1080         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1081
1082 2019-03-25  Jer Noble  <jer.noble@apple.com>
1083
1084         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1085         https://bugs.webkit.org/show_bug.cgi?id=196097
1086
1087         Reviewed by Eric Carlson.
1088
1089         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1090
1091         * DumpRenderTree/mac/DumpRenderTree.mm:
1092         (resetWebPreferencesToConsistentValues):
1093         * WebKitTestRunner/TestController.cpp:
1094         (WTR::TestController::resetPreferencesToConsistentValues):
1095
1096 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1097
1098         Pull IPadUserInterfaceSwizzler out into a separate header file
1099         https://bugs.webkit.org/show_bug.cgi?id=196193
1100
1101         Reviewed by Anders Carlsson.
1102
1103         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1104         be used in other API tests.
1105
1106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1107         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1108         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1109         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1110         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1111         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1112         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1113
1114 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1115
1116         Remove NavigatorContentUtils in WebCore/Modules
1117         https://bugs.webkit.org/show_bug.cgi?id=196070
1118
1119         Reviewed by Alex Christensen.
1120
1121         NavigatorContentUtils was to support the custom scheme spec [1].
1122         However, in WebKit side, no port has supported the feature in
1123         WebKit layer after EFL port was removed. So there has been the
1124         only IDL implementation of the NavigatorContentUtils in WebCore.
1125         So we don't need to keep the implementation in WebCore anymore.
1126
1127         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1128
1129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1130
1131 2019-03-24  Andy Estes  <aestes@apple.com>
1132
1133         [watchOS] Remove unused Proximity Networking code
1134         https://bugs.webkit.org/show_bug.cgi?id=196188
1135
1136         Reviewed by Tim Horton.
1137
1138         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1139         (TEST):
1140
1141 2019-03-23  Keith Miller  <keith_miller@apple.com>
1142
1143         Refactor clz/ctz and fix getLSBSet.
1144         https://bugs.webkit.org/show_bug.cgi?id=196162
1145
1146         Reviewed by Saam Barati.
1147
1148         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1149
1150         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1151         (TestWebKitAPI::TEST):
1152
1153 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1154
1155         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1156         https://bugs.webkit.org/show_bug.cgi?id=196143
1157
1158         Reviewed by Michael Catanzaro.
1159
1160         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1161         directories.
1162
1163         * Scripts/webkitpy/style/checkers/cpp.py:
1164         (check_identifier_name_in_declaration):
1165         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1166         (WebKitStyleTest.test_names):
1167
1168 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1169
1170         [Flatpak] Manifest expanding fails for qt WPE extension
1171         https://bugs.webkit.org/show_bug.cgi?id=196148
1172
1173         Reviewed by Alex Christensen.
1174
1175         * flatpak/flatpakutils.py:
1176         (expand_submodules_recurse): The last recurse manifest expand
1177         iteration might lead to a single module so take it into account
1178         and don't try to recurse further.
1179
1180 2019-03-22  Chris Dumez  <cdumez@apple.com>
1181
1182         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1183         https://bugs.webkit.org/show_bug.cgi?id=195348
1184         <rdar://problem/48622090>
1185
1186         Reviewed by Alex Christensen.
1187
1188         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1189         to NO when test.options().shouldIgnoreMetaViewport is false.
1190
1191         * WebKitTestRunner/ios/TestControllerIOS.mm:
1192         (WTR::TestController::platformConfigureViewForTest):
1193
1194 2019-03-22  Chris Dumez  <cdumez@apple.com>
1195
1196         Prewarmed processes should be usable with any website data store
1197         https://bugs.webkit.org/show_bug.cgi?id=196104
1198
1199         Reviewed by Alex Christensen.
1200
1201         Add API test coverage.
1202
1203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1204         (runInitialWarmedProcessUsedTest):
1205         (TEST):
1206
1207 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1208
1209         Back out local changes to Alex's Subversion working directory
1210
1211         They were accidentally committed.
1212
1213         * Scripts/webkitpy/common/system/abstractexecutive.py:
1214         (AbstractExecutive.wait_newest):
1215         * Scripts/webkitpy/common/system/executive.py:
1216         (Executive.running_pids):
1217         * Scripts/webkitpy/common/system/executive_mock.py:
1218         (MockExecutive.running_pids):
1219         * Scripts/webkitpy/common/system/executive_unittest.py:
1220         (ExecutiveTest.serial_test_running_pids):
1221         * Scripts/webkitpy/port/darwin.py:
1222         (DarwinPort.check_for_leaks):
1223         * Scripts/webkitpy/port/leakdetector.py:
1224         (LeakDetector.check_for_leaks):
1225         - This was the hack attached to Bug 193772.
1226
1227         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1228         (+[WebKitTestRunnerEvent mouseLocation]):
1229         - This works around a crash on an internal build.
1230
1231 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1232
1233         Fix the build after r243354
1234         https://bugs.webkit.org/show_bug.cgi?id=196138
1235         <rdar://problem/49145951>
1236
1237         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1238         (TEST):
1239         * TestWebKitAPI/ios/UIKitSPI.h:
1240
1241 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1242
1243         Adopt UIWKDocumentContext
1244         https://bugs.webkit.org/show_bug.cgi?id=196040
1245         <rdar://problem/48642440>
1246
1247         Reviewed by Ryosuke Niwa.
1248
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1251         (makeRequest):
1252         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1253         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1254         (applyStyle):
1255         (TEST):
1256         Add tests for UIWKDocumentContext.
1257
1258         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1259         (TEST):
1260         (recursiveFindWKContentView): Deleted.
1261         * TestWebKitAPI/cocoa/TestWKWebView.h:
1262         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1263         (recursiveFindWKContentView):
1264         (-[TestWKWebView wkContentView]):
1265         * TestWebKitAPI/ios/UIKitSPI.h:
1266         Share the WKContentView finding code between tests.
1267
1268 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1269
1270         [iOS WK2] Turn on async overflow scrolling by default
1271         https://bugs.webkit.org/show_bug.cgi?id=196011
1272         rdar://problem/48453859
1273
1274         Reviewed by Antti Koivisto.
1275         
1276         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1277         since so many basic layout tests have different results when compositing is triggered for
1278         overflow.
1279         
1280         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1281
1282         * WebKitTestRunner/TestController.cpp:
1283         (WTR::TestController::resetPreferencesToConsistentValues):
1284
1285 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1286
1287         [ews-build] Retry API test in case of failures
1288         https://bugs.webkit.org/show_bug.cgi?id=196004
1289
1290         Reviewed by Lucas Forschler.
1291
1292         * BuildSlaveSupport/ews-build/steps.py:
1293         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1294         (CompileWebKitToT.doStepIf): Ditto.
1295         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1296         (ReRunAPITests): Re-run API tests.
1297         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1298         (RunAPITestsWithoutPatch): Run API tests without patch.
1299         (RunAPITestsWithoutPatch.doStepIf):
1300         (RunAPITestsWithoutPatch.hideStepIf):
1301         (RunAPITestsWithoutPatch.evaluateCommand):
1302         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1303         (AnalyzeAPITestsResults.start):
1304         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1305         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1306         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1307         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1308
1309 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-build] Update queues configurations
1312         https://bugs.webkit.org/show_bug.cgi?id=196074
1313
1314         Reviewed by Dewei Zhu.
1315
1316         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1317         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1318
1319 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1320
1321         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1322         https://bugs.webkit.org/show_bug.cgi?id=195680
1323         <rdar://problem/48903534>
1324
1325         Unreviewed infrastructure fix.
1326
1327         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1328         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1329
1330 2019-03-21  Andy Estes  <aestes@apple.com>
1331
1332         [iOS] Apple Pay should be available in documents with no user agent scripts
1333         https://bugs.webkit.org/show_bug.cgi?id=196061
1334         <rdar://problem/48649391>
1335
1336         Reviewed by Brady Eidson.
1337
1338         Added API tests and related infrastructure.
1339
1340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1341         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1342         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1343         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1344         (TestWebKitAPI::TEST):
1345         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1346         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1347         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1348         * TestWebKitAPI/cocoa/TestProtocol.mm:
1349         (-[TestProtocol startLoading]):
1350         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1351         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1352         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1353         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1354
1355 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1356
1357         REGRESSSION (r243297): webkitpy tests broken
1358         https://bugs.webkit.org/show_bug.cgi?id=196108
1359
1360         Reviewed by Aakash Jain.
1361
1362         r243297 updated contributors.json, which broke a few unit tests.
1363
1364         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1365         (IRCCommandTest.test_whois):
1366         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1367
1368 2019-03-21  Chris Dumez  <cdumez@apple.com>
1369
1370         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1371         https://bugs.webkit.org/show_bug.cgi?id=196041
1372         <rdar://problem/49083230>
1373
1374         Reviewed by Alex Christensen.
1375
1376         Add API test coverage.
1377
1378         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1379         (TEST):
1380
1381 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1382
1383         Add SPI to inform applications of WKContentRuleList actions
1384         https://bugs.webkit.org/show_bug.cgi?id=195965
1385         <rdar://problem/42664365>
1386
1387         Reviewed by Geoff Garen.
1388
1389         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1390         (TestWebKitAPI::allActionsForResourceLoad):
1391         (TestWebKitAPI::testRequest):
1392         (TestWebKitAPI::TEST_F):
1393         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1394         (Notification::description):
1395         (Notification::operator== const):
1396         (toVector):
1397         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1398         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1399         (makeContentRuleList):
1400         (TEST):
1401         (makeWarnContentRuleList): Deleted.
1402
1403 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1404
1405         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1406         https://bugs.webkit.org/show_bug.cgi?id=196088
1407
1408         Reviewed by Brian Burg.
1409
1410         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1411         Support checks when only one platform is specified. Also deprecate macosx() and
1412         force the use of macos() instead.
1413
1414         * Scripts/webkitpy/style/checkers/cpp.py:
1415         (check_min_versions_of_wk_api_available):
1416         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1417         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1418
1419 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1420
1421         Update status inactive committers' status to 'contributor'.
1422
1423         * Scripts/webkitpy/common/config/contributors.json:
1424
1425 2019-03-21  Xan Lopez  <xan@igalia.com>
1426
1427         [JSC][x86] Drop support for x87 floating point
1428         https://bugs.webkit.org/show_bug.cgi?id=194853
1429
1430         Reviewed by Don Olmstead.
1431
1432         Force SSE2 on x86/32bit builds.
1433
1434         * Scripts/webkitdirs.pm:
1435         (generateBuildSystemFromCMakeProject):
1436
1437 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1438
1439         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1440         https://bugs.webkit.org/show_bug.cgi?id=196073
1441
1442         Reviewed by Michael Catanzaro.
1443
1444         Add test cases to check functions and constructors with no arguments but receiving user data.
1445
1446         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1447         (checkUserData):
1448         (testJSCFunction):
1449         (fooCreateWithUserData):
1450         (testJSCClass):
1451
1452 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1453
1454         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1455
1456         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1457
1458         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1459
1460 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1461
1462         [GTK][WPE] Add API to provide geolocation information
1463         https://bugs.webkit.org/show_bug.cgi?id=195940
1464
1465         Reviewed by Michael Catanzaro.
1466
1467         Add a new test to check the new API.
1468
1469         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1470         (testGeolocationManagerCurrentPosition):
1471         (testGeolocationManagerWatchPosition):
1472         (beforeAll):
1473         (afterAll):
1474         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1475         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1476         (beforeAll): Ditto.
1477         * TestWebKitAPI/glib/CMakeLists.txt:
1478
1479 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1480
1481         [GLib] Returning G_TYPE_OBJECT from a method does not work
1482         https://bugs.webkit.org/show_bug.cgi?id=195574
1483
1484         Reviewed by Michael Catanzaro.
1485
1486         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1487
1488         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1489         (getGFile):
1490         (getParent):
1491         (createGString):
1492         (getGString):
1493         (getGStringCopyWillRaise):
1494         (getGStringCopy):
1495         (getGStringStr):
1496         (getGStringLen):
1497         (freeGString):
1498         (testJSCClass):
1499
1500 2019-03-20  Saam Barati  <sbarati@apple.com>
1501
1502         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1503         https://bugs.webkit.org/show_bug.cgi?id=195721
1504
1505         Reviewed by Filip Pizlo.
1506
1507         * Scripts/run-javascriptcore-tests:
1508
1509 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1510
1511         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1512         https://bugs.webkit.org/show_bug.cgi?id=196049
1513
1514         Reviewed by Tim Horton.
1515
1516         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1517         overflow scrolling in general, so rename it.
1518
1519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1520
1521 2019-03-20  Daniel Bates  <dabates@apple.com>
1522
1523         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1524         https://bugs.webkit.org/show_bug.cgi?id=196031
1525         <rdar://problem/49078172>
1526
1527         Reviewed by Tim Horton.
1528
1529         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1530         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1531         same code path used when the Done button is pressed to dismiss the <select> picker.
1532
1533         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1534         (TestWebKitAPI::TEST):
1535
1536 2019-03-20  Chris Dumez  <cdumez@apple.com>
1537
1538         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1539         https://bugs.webkit.org/show_bug.cgi?id=196029
1540         <rdar://problem/48954651>
1541
1542         Reviewed by Tim Horton.
1543
1544         Add API test coverage.
1545
1546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1547
1548 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1549
1550         [ews-build] Improve failure summary string for ApplyPatch step
1551         https://bugs.webkit.org/show_bug.cgi?id=195995
1552
1553         Reviewed by Alexey Proskuryakov.
1554
1555         * BuildSlaveSupport/ews-build/steps.py:
1556         (ApplyPatch.getResultSummary): Override getResultSummary.
1557
1558 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1559
1560         AX: Implement support for new meter ARIA role
1561         https://bugs.webkit.org/show_bug.cgi?id=195966
1562
1563         Reviewed by Chris Fleizach.
1564
1565         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1566         to AXLevelIndicator.
1567
1568         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1569
1570 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1571
1572         [WebAuthN] Implement FIDO AppID extension
1573         https://bugs.webkit.org/show_bug.cgi?id=143491
1574         <rdar://problem/48298273>
1575
1576         Reviewed by Brent Fulgham.
1577
1578         Add a test that covers the new flag of convertToU2fSignCommand.
1579
1580         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1581         (TestWebKitAPI::TEST):
1582         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1583         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1584         (TestWebKitAPI::TEST):
1585
1586 2019-03-19  Keith Rollin  <krollin@apple.com>
1587
1588         Add support for more platforms to generate-xcfilelists
1589         https://bugs.webkit.org/show_bug.cgi?id=195977
1590
1591         Reviewed by Alexey Proskuryakov.
1592
1593         generate-xcfilelists incorrectly complains when involved with building
1594         WebKit for iphonesimulator:
1595
1596             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1597             …
1598             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1599
1600         Address this by teaching generate-xcfilelists about more platforms.
1601
1602         * Scripts/generate-xcfilelists:
1603
1604 2019-03-19  John Wilander  <wilander@apple.com>
1605
1606         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1607         https://bugs.webkit.org/show_bug.cgi?id=195923
1608         <rdar://problem/49001272>
1609
1610         Reviewed by Alex Christensen.
1611
1612         This patch does the following to the TestRunner:
1613         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1614         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1615         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1616
1617         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1619         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1620         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1621         * WebKitTestRunner/TestController.cpp:
1622         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1623         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1624         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1625         * WebKitTestRunner/TestController.h:
1626         * WebKitTestRunner/TestInvocation.cpp:
1627         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1628
1629 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1630
1631         [CMake] Support more clang and gcc sanitizers
1632         https://bugs.webkit.org/show_bug.cgi?id=195956
1633
1634         Reviewed by Michael Catanzaro.
1635
1636         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1637
1638 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1639
1640         [ews-build] Improve summary for PrintConfiguration step
1641         https://bugs.webkit.org/show_bug.cgi?id=195945
1642
1643         Reviewed by Lucas Forschler.
1644
1645         * BuildSlaveSupport/ews-build/steps.py:
1646         (PrintConfiguration.getResultSummary): Override getResultSummary.
1647
1648 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1649
1650         [ews-build] Improve summary for CheckOutSource step
1651         https://bugs.webkit.org/show_bug.cgi?id=195963
1652
1653         Reviewed by Lucas Forschler.
1654
1655         * BuildSlaveSupport/ews-build/steps.py:
1656         (CheckOutSource.getResultSummary):
1657
1658 2019-03-19  Daniel Bates  <dabates@apple.com>
1659
1660         [iOS] Focus not preserved when switching between tabs
1661         https://bugs.webkit.org/show_bug.cgi?id=195820
1662         <rdar://problem/43614450>
1663
1664         Reviewed by Brent Fulgham.
1665
1666         Add tests to ensure that we restore focus when resigning and becoming first responder.
1667
1668         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1669         (TestWebKitAPI::TEST):
1670
1671 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1672
1673         Make WTFLogChannelState and WTFLogLevel enum classes
1674         https://bugs.webkit.org/show_bug.cgi?id=195904
1675
1676         Reviewed by Eric Carlson.
1677
1678         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1679         (TestWebKitAPI::TEST_F):
1680
1681 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1682
1683         [GStreamer][EME] Backported mssdemux protection data crash fix
1684         https://bugs.webkit.org/show_bug.cgi?id=195918
1685
1686         Reviewed by Philippe Normand.
1687
1688         * gstreamer/jhbuild.modules:
1689         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1690
1691 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1692
1693         Unreviewed, rolling out r243132.
1694
1695         Broke GTK build
1696
1697         Reverted changeset:
1698
1699         "Make WTFLogChannelState and WTFLogLevel enum classes"
1700         https://bugs.webkit.org/show_bug.cgi?id=195904
1701         https://trac.webkit.org/changeset/243132
1702
1703 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1704
1705         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1706
1707         * Scripts/webkitdirs.pm:
1708         (builtDylibPathForName): Adjust the shared library name that's changed
1709         with the API version bump in r243073.
1710
1711 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1712
1713         Make WTFLogChannelState and WTFLogLevel enum classes
1714         https://bugs.webkit.org/show_bug.cgi?id=195904
1715
1716         Reviewed by Eric Carlson.
1717
1718         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1719         (TestWebKitAPI::TEST_F):
1720
1721 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1722
1723         Disable flaky test added in r2431100
1724         https://webkit.org/b/195785
1725
1726         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1727         (TestWebKitAPI::TEST):
1728         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1729
1730 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1731
1732         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1733         https://bugs.webkit.org/show_bug.cgi?id=195916
1734
1735         Reviewed by Tim Horton.
1736
1737         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1738         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1739
1740 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1741
1742         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1743
1744         * Scripts/webkitpy/common/config/contributors.json:
1745
1746 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1747
1748         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1749         https://bugs.webkit.org/show_bug.cgi?id=195785
1750
1751         Reviewed by Geoffrey Garen.
1752
1753         * TestWebKitAPI/TCPServer.cpp: Added.
1754         (TestWebKitAPI::TCPServer::TCPServer):
1755         (TestWebKitAPI::TCPServer::~TCPServer):
1756         (TestWebKitAPI::TCPServer::socketBindListen):
1757         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1758         * TestWebKitAPI/TCPServer.h: Added.
1759         (TestWebKitAPI::TCPServer::port const):
1760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1761         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1762         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1763         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1764         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1765         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1766         (TestWebKitAPI::respondSlowly):
1767         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1768         (TestWebKitAPI::downloadAtRate):
1769         (TestWebKitAPI::TEST):
1770
1771 2019-03-18  Saam Barati  <sbarati@apple.com>
1772
1773         Add a plan file for JetStream 2
1774         https://bugs.webkit.org/show_bug.cgi?id=190734
1775
1776         Reviewed by Mark Lam.
1777
1778         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1779
1780 2019-03-18  Chris Dumez  <cdumez@apple.com>
1781
1782         Delay WebProcess launch until a load is triggered in a Web view
1783         https://bugs.webkit.org/show_bug.cgi?id=195758
1784         <rdar://problem/48126013>
1785
1786         Reviewed by Geoff Garen.
1787
1788         Add API test coverage. Also update some existing API tests to not expect
1789         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1790
1791         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1792         (TestWebKitAPI::TEST):
1793         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1794         (TestWebKitAPI::TEST):
1795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1796         (TEST):
1797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1798         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1799         (TEST):
1800         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1801         (TEST):
1802         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1803
1804 2019-03-18  Xan Lopez  <xan@igalia.com>
1805
1806         [CMake] Prevent potential warning when determining $architecture
1807         https://bugs.webkit.org/show_bug.cgi?id=195891
1808
1809         Reviewed by Michael Catanzaro.
1810
1811         It's possible for generateBuildSystemForCMakeProject to be called
1812         before determineArchitecture() is ever called. This will make the
1813         first eq check with $architecture to be bogus (and print a
1814         warning). Change that to an eq check with architecture(), which
1815         implicitly calls determineArchitecture() if needed, and change all
1816         the other similar cases in the method in the same way to prevent
1817         future bugs like this one.
1818
1819         * Scripts/webkitdirs.pm:
1820         (generateBuildSystemFromCMakeProject):
1821
1822 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1823
1824         [WPE] Tarballs generated with “make dist” cannot build documentation
1825         https://bugs.webkit.org/show_bug.cgi?id=195885
1826
1827         Reviewed by Carlos Garcia Campos.
1828
1829         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1830
1831 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1832
1833         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1834         https://bugs.webkit.org/show_bug.cgi?id=195883
1835
1836         Reviewed by Carlos Garcia Campos.
1837
1838         * gtkdoc/gtkdoc.py:
1839         (GTKDoc._run_command): When commands fail to run, include the full command line for
1840         the program invocation and the output it has generated on the standard error stream.
1841
1842 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1843
1844         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1845         https://bugs.webkit.org/show_bug.cgi?id=195786
1846
1847         Reviewed by Philippe Normand.
1848
1849         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1850         * wpe/jhbuild.modules: Ditto.
1851
1852 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1853
1854         [ews-build] Don't run clean builds on EWS builders
1855         https://bugs.webkit.org/show_bug.cgi?id=195851
1856
1857         Reviewed by Geoffrey Garen.
1858
1859         * BuildSlaveSupport/ews-build/factories.py:
1860
1861 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1862
1863         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1864         https://bugs.webkit.org/show_bug.cgi?id=195849
1865
1866         Reviewed by Chris Dumez.
1867
1868         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1869
1870         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1871         (runWebsiteDataStoreCustomPaths):
1872
1873 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1874
1875         webkitpy: Upload test results
1876         https://bugs.webkit.org/show_bug.cgi?id=195755
1877         <rdar://problem/48896182>
1878
1879         Reviewed by Aakash Jain.
1880
1881         Establish a new format for uploading results that is not tied to layout tests, apply
1882         that format to webkitpy tests.
1883
1884         * Scripts/webkitpy/common/checkout/scm/git.py:
1885         (Git.native_branch): Return what branch the current checkout is on.
1886         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1887         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1888         * Scripts/webkitpy/common/checkout/scm/svn.py:
1889         (SVN.native_branch): Ditto.
1890         * Scripts/webkitpy/common/system/platforminfo.py:
1891         (PlatformInfo.build_version): Return a build version for Mac.
1892         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1893         (MockPlatformInfo.__init__):
1894         (MockPlatformInfo.build_version):
1895         * Scripts/webkitpy/results: Added.
1896         * Scripts/webkitpy/results/__init__.py: Added.
1897         * Scripts/webkitpy/results/options.py: Added.
1898         (upload_options): OptParse list for upload options.
1899         * Scripts/webkitpy/results/upload.py: Added.
1900         (Upload): Class which enforces the upload format expected by the results server.
1901         (Upload.Expectations):
1902         (Upload.create_configuration):
1903         (Upload.create_commit):
1904         (Upload.create_details):
1905         (Upload.create_run_stats):
1906         (Upload.create_test_result):
1907         (Upload.__init__):
1908         (Upload.Encoder): Encode Upload object as json.
1909         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1910         * Scripts/webkitpy/results/upload_unittest.py: Added.
1911         * Scripts/webkitpy/test/main.py:
1912         (Tester._parse_args): Add upload arguments.
1913         (Tester._run_tests): Allow results to be uploaded.
1914         * Scripts/webkitpy/test/runner.py:
1915         (Runner.__init__): Record which tests were run, rather than just counting them.
1916         (Runner.handle):
1917         * Scripts/webkitpy/test/runner_unittest.py:
1918         (RunnerTest.test_run):
1919         * Scripts/webkitpy/thirdparty/__init__.py:
1920         (AutoinstallImportHook.find_module): Add requests auto-install.
1921         (AutoinstallImportHook._install_requests):
1922         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1923         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1924
1925 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1926
1927         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1928         https://bugs.webkit.org/show_bug.cgi?id=195810
1929
1930         Reviewed by Tim Horton.
1931
1932         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1933         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1934         ending certain layout tests.
1935
1936         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1937         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1938         (-[TestRunnerWKWebView dealloc]):
1939         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1940
1941         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1942         helper method when destroying the web view, and when resetting state between tests.
1943
1944         * WebKitTestRunner/ios/TestControllerIOS.mm:
1945         (WTR::TestController::platformResetStateToConsistentValues):
1946
1947         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1948
1949 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1950
1951         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1952         https://bugs.webkit.org/show_bug.cgi?id=190350
1953         <rdar://problem/45089503>
1954
1955         Reviewed by Geoffrey Garen.
1956
1957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1958         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1959         (TEST):
1960         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1961         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1962         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1963         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1964         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1965         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1966         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1967         (runTest):
1968         (createDirectories):
1969         (TEST):
1970         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1971         (TEST):
1972         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1973         (TEST):
1974
1975 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1976
1977         Add support to WebPage for getting the contents as an attributed string.
1978         https://bugs.webkit.org/show_bug.cgi?id=195636
1979         rdar://problem/45055697
1980
1981         Reviewed by Tim Horton.
1982
1983         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1984         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1985
1986 2019-03-15  Chris Dumez  <cdumez@apple.com>
1987
1988         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1989         https://bugs.webkit.org/show_bug.cgi?id=195747
1990
1991         Reviewed by Geoff Garen.
1992
1993         Add API test coverage.
1994
1995         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1996
1997 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1998
1999         Unreviewed, rolling out r242952.
2000
2001         Causing API failures on iOS Simulator
2002
2003         Reverted changeset:
2004
2005         "[PSON] Make sure the WebProcessCache is leverage when
2006         relaunching a process after termination"
2007         https://bugs.webkit.org/show_bug.cgi?id=195747
2008         https://trac.webkit.org/changeset/242952
2009
2010 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2011
2012         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2013         https://bugs.webkit.org/show_bug.cgi?id=195740
2014
2015         Reviewed by Ross Kirsling.
2016
2017         window.open doesn't work for WebKitBrowserWindow because it is not
2018         implemented yet.
2019
2020         1. Implemented createNewPage callback of WKPageUIClient.
2021         2. Changed MainWindow to take a BrowserWindow factory function
2022           instead of BrowserWindowType to be flexible to create
2023           BrowserWindow with extra settings.
2024         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2025           because it is not relevant with MainWindow anymore.
2026
2027         * MiniBrowser/win/Common.cpp:
2028         (parseCommandLine):
2029         * MiniBrowser/win/Common.h:
2030         (CommandLineOptions::CommandLineOptions):
2031         * MiniBrowser/win/MainWindow.cpp:
2032         (MainWindow::MainWindow):
2033         (MainWindow::create):
2034         (MainWindow::init):
2035         (MainWindow::WndProc):
2036         * MiniBrowser/win/MainWindow.h:
2037         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2038         (PrintWebUIDelegate::createWebViewWithRequest):
2039         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2040         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2041         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2042         (WebKitBrowserWindow::updateProxySettings):
2043         (WebKitBrowserWindow::createNewPage):
2044         * MiniBrowser/win/WebKitBrowserWindow.h:
2045         * MiniBrowser/win/WinMain.cpp:
2046         (wWinMain):
2047
2048 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2049
2050         Make it possible to test scrolling tree layer manipulation more easily
2051         https://bugs.webkit.org/show_bug.cgi?id=195780
2052
2053         Reviewed by Tim Horton.
2054         
2055         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2056         cuts off communication of scrolling tree scrolls back to the web process
2057         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2058         allows tests to trigger scrolls which run the scrolling tree layer positioning
2059         logic, but never get another commit from the web process that might mask
2060         scrolling tree bugs.
2061         
2062         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2063         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2064         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2065
2066         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2067         (WTR::UIScriptController::scrollUpdatesDisabled const):
2068         (WTR::UIScriptController::setScrollUpdatesDisabled):
2069         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2070         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2071         (WTR::UIScriptController::scrollUpdatesDisabled const):
2072         (WTR::UIScriptController::setScrollUpdatesDisabled):
2073         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2074         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2075         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2076         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2077         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2078         * WebKitTestRunner/ios/TestControllerIOS.mm:
2079         (WTR::TestController::platformResetStateToConsistentValues):
2080         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2081         (WTR::UIScriptController::scrollUpdatesDisabled const):
2082         (WTR::UIScriptController::setScrollUpdatesDisabled):
2083
2084 2019-03-14  Youenn Fablet  <youenn@apple.com>
2085
2086         Move IDB storage in private browsing mode to NetworkProcess
2087         https://bugs.webkit.org/show_bug.cgi?id=195602
2088
2089         Reviewed by Brady Eidson.
2090
2091         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2092         (TEST):
2093
2094 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2095
2096         [ews-build] Make descriptionDone messages more readable
2097         https://bugs.webkit.org/show_bug.cgi?id=195760
2098
2099         Reviewed by Lucas Forschler.
2100
2101         * BuildSlaveSupport/ews-build/steps.py:
2102         * BuildSlaveSupport/ews-build/steps_unittest.py:
2103
2104 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-build] Generate status-bubble hover-over messages
2107         https://bugs.webkit.org/show_bug.cgi?id=195680
2108
2109         Reviewed by Lucas Forschler.
2110
2111         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2112         (StatusBubble):
2113         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2114         on hover-over.
2115         (StatusBubble._iso_time):
2116         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2117         hover-over message.
2118         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2119
2120 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2121
2122         [ews-app] Gracefully handle the case when state_string is None
2123         https://bugs.webkit.org/show_bug.cgi?id=195753
2124
2125         Reviewed by Lucas Forschler.
2126
2127         * BuildSlaveSupport/ews-app/ews/models/build.py:
2128         * BuildSlaveSupport/ews-app/ews/models/step.py:
2129
2130 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2131
2132         [ews-app] Status bubble display pending for currently running build step
2133         https://bugs.webkit.org/show_bug.cgi?id=195744
2134
2135         Reviewed by Lucas Forschler.
2136
2137         * BuildSlaveSupport/ews-build/events.py:
2138         (Events.stepStarted): If state_string is pending, replace it with step name.
2139
2140 2019-03-14  Chris Dumez  <cdumez@apple.com>
2141
2142         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2143         https://bugs.webkit.org/show_bug.cgi?id=195750
2144
2145         Reviewed by Geoffrey Garen.
2146
2147         Add API test coverage.
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2150         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2151         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2152         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2153
2154 2019-03-14  Chris Dumez  <cdumez@apple.com>
2155
2156         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2157         https://bugs.webkit.org/show_bug.cgi?id=195747
2158
2159         Reviewed by Geoff Garen.
2160
2161         Add API test coverage.
2162
2163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2164
2165 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2166
2167         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2168         https://bugs.webkit.org/show_bug.cgi?id=195725
2169         <rdar://problem/48545062>
2170
2171         Reviewed by Tim Horton.
2172
2173         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2174         handler is nil.
2175
2176         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2177         (TestWebKitAPI::TEST):
2178
2179 2019-03-13  Sam Weinig  <sam@webkit.org>
2180
2181         Add utility function to allow easy reverse range-based iteration of a container
2182         https://bugs.webkit.org/show_bug.cgi?id=195542
2183
2184         Reviewed by Antti Koivisto.
2185
2186         * TestWebKitAPI/CMakeLists.txt:
2187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2188         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2189         (TestWebKitAPI::TEST):
2190         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2191
2192 2019-03-13  Chris Dumez  <cdumez@apple.com>
2193
2194         Use a ServiceWorker process per registrable domain
2195         https://bugs.webkit.org/show_bug.cgi?id=195649
2196
2197         Reviewed by Youenn Fablet.
2198
2199         Update API test coverage.
2200
2201         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2202
2203 2019-03-13  Chris Dumez  <cdumez@apple.com>
2204
2205         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2206         https://bugs.webkit.org/show_bug.cgi?id=195684
2207         <rdar://problem/48294714>
2208
2209         Reviewed by Antti Koivisto.
2210
2211         Add API test coverage.
2212
2213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2214
2215 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2216
2217         [ews-app] Remove unused patch view
2218         https://bugs.webkit.org/show_bug.cgi?id=195669
2219
2220         Reviewed by Lucas Forschler.
2221
2222         * BuildSlaveSupport/ews-app/ews/urls.py:
2223         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2224
2225 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2226
2227         [ews-app] Use Buildbot result code variables
2228         https://bugs.webkit.org/show_bug.cgi?id=195668
2229
2230         Reviewed by Alexey Proskuryakov.
2231
2232         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2233         (Buildbot): Added Buildbot result code variables.
2234         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2235         (StatusBubble._build_bubble): Used Buildbot result code variables.
2236
2237 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2238
2239         [Flatpak] Expand submodule recursively
2240         https://bugs.webkit.org/show_bug.cgi?id=195672
2241
2242         Building WPE with flatpak was impossible without that as it was raising an exception.
2243         Also update wpebackend-fdo to match what is built in jhbuild
2244
2245         Reviewed by Philippe Normand.
2246
2247         * flatpak/flatpakutils.py:
2248         (expand_submodules_recurse):
2249         (expand_manifest):
2250         * flatpak/org.webkit.WPEModules.yaml:
2251
2252 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2253
2254         [ews-app] status bubble should be hidden for certain builds
2255         https://bugs.webkit.org/show_bug.cgi?id=194597
2256
2257         Reviewed by Dewei Zhu.
2258
2259         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2260         (StatusBubble._build_bubble):
2261         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2262         because the patch didn't have relevant changes.
2263         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2264         in production yet.
2265
2266 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2267
2268         [Win] Fix a slew of simple clang-cl warnings.
2269         https://bugs.webkit.org/show_bug.cgi?id=195652
2270
2271         Reviewed by Don Olmstead.
2272
2273         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2274         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2275
2276 2019-03-12  Justin Fan  <justin_fan@apple.com>
2277
2278         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2279         https://bugs.webkit.org/show_bug.cgi?id=195518
2280         <rdar://problem/46322356>
2281
2282         Reviewed by Myles C. Maxfield.
2283
2284         * DumpRenderTree/DerivedSources-input.xcfilelist:
2285         * DumpRenderTree/DerivedSources-output.xcfilelist:
2286
2287 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2288
2289         Unreviewed, rolling out r242825.
2290         https://bugs.webkit.org/show_bug.cgi?id=195648
2291
2292         "Broke webkitpy tests with my change to
2293         lldb_dump_class_layout.py" (Requested by rmorisset on
2294         #webkit).
2295
2296         Reverted changeset:
2297
2298         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2299         classes with suspicious padding"
2300         https://bugs.webkit.org/show_bug.cgi?id=195573
2301         https://trac.webkit.org/changeset/242825
2302
2303 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2304
2305         [ews-build] Show status bubbles while the patch is waiting in queue
2306         https://bugs.webkit.org/show_bug.cgi?id=195618
2307
2308         Reviewed by Lucas Forschler.
2309
2310         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2311         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2312         enabled in initial deployment.
2313         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2314         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2315         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2316         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2317         (StatusBubble._build_bubbles_for_patch):
2318
2319 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2320
2321         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2322         https://bugs.webkit.org/show_bug.cgi?id=195573
2323
2324         Reviewed by Simon Fraser.
2325
2326         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2327
2328         * Scripts/dump-class-layout:
2329         (main):
2330         * lldb/lldb_dump_class_layout.py:
2331         (ClassLayout.__init__):
2332         (ClassLayout._compute_padding_recursive):
2333         (LLDBDebuggerInstance.dump_layout_for_classname):
2334         (LLDBDebuggerInstance):
2335         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2336         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2337
2338 2019-03-12  Chris Dumez  <cdumez@apple.com>
2339
2340         Device Orientation access permission should be denied unless explicitly granted by the client
2341         https://bugs.webkit.org/show_bug.cgi?id=195625
2342
2343         Reviewed by Youenn Fablet.
2344
2345         add API test coverage.
2346
2347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2348         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2349         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2350         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2351         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2352         (runDeviceOrientationTest):
2353         (TEST):
2354         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2355         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2356
2357 2019-03-12  Jer Noble  <jer.noble@apple.com>
2358
2359         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2360         https://bugs.webkit.org/show_bug.cgi?id=195137
2361         <rdar://problem/48810307>
2362
2363         Reviewed by Eric Carlson.
2364
2365         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2366         (TestWebKitAPI::TEST):
2367
2368 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2369
2370         [ews-build] Change urls from uat to production
2371         https://bugs.webkit.org/show_bug.cgi?id=195566
2372
2373         Reviewed by Lucas Forschler.
2374
2375         * BuildSlaveSupport/ews-app/ews/config.py:
2376         * BuildSlaveSupport/ews-build/events.py:
2377         * BuildSlaveSupport/ews-build/steps.py:
2378
2379 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-build] change max_builds for local-worker to 1
2382         https://bugs.webkit.org/show_bug.cgi?id=195568
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/ews-build/loadConfig.py:
2387
2388 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2389
2390         Fix the build
2391
2392         * TestRunnerShared/spi/PencilKitTestSPI.h:
2393         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2394
2395 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2396
2397         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2398         https://bugs.webkit.org/show_bug.cgi?id=194131
2399
2400         Reviewed by Michael Catanzaro.
2401
2402         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2403         (uriChanged):
2404         (testUnfinishedSubresourceLoad):
2405         (serverCallback):
2406         (beforeAll):
2407
2408 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2409
2410         WTF::Expected should use std::addressof instead of operator&
2411         https://bugs.webkit.org/show_bug.cgi?id=195604
2412
2413         Reviewed by Myles Maxfield.
2414
2415         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2416         (TestWebKitAPI::Unique::Unique):
2417         (TestWebKitAPI::Unique::operator&):
2418         (TestWebKitAPI::TEST):
2419
2420 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2421
2422         Add Optional to Forward.h.
2423         https://bugs.webkit.org/show_bug.cgi?id=195586
2424
2425         Reviewed by Darin Adler.
2426
2427         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2428         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2429         Remove unnecessary includes from headers.
2430
2431 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2432
2433         Add testing API to hit-test and scroll overflow scrollers
2434         https://bugs.webkit.org/show_bug.cgi?id=195278
2435
2436         Reviewed by Antti Koivisto.
2437         
2438         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2439         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2440         
2441         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2442
2443         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2444         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2445         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2446         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2447         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2448         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2449         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2450         (WTR::enclosingScrollViewIncludingSelf):
2451         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2452
2453 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2454
2455         API test WebKit.RequestTextInputContext fails on iOS
2456         https://bugs.webkit.org/show_bug.cgi?id=195585
2457
2458         Reviewed by Wenson Hsieh and Simon Fraser.
2459
2460         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2461         (applyStyle):
2462         (TEST):
2463         Add a viewport, so that the coordinates match up on iOS.
2464         Scroll by moving the UIScrollView's contentOffset.
2465
2466 2019-03-11  Chris Dumez  <cdumez@apple.com>
2467
2468         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2469         https://bugs.webkit.org/show_bug.cgi?id=195506
2470         <rdar://problem/48733477>
2471
2472         Reviewed by Alex Christensen.
2473
2474         Add API test coverage.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2477
2478 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2479
2480         Adding myself to contributors.json
2481
2482         Unreviewed, addming myself to contributors.json .
2483
2484         * Scripts/webkitpy/common/config/contributors.json:
2485
2486 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2487
2488         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2489         https://bugs.webkit.org/show_bug.cgi?id=195511
2490         <rdar://problem/44873269>
2491
2492         Reviewed by Darin Adler.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2495         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2496         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2497         (TEST_F):
2498
2499 2019-03-11  Chris Dumez  <cdumez@apple.com>
2500
2501         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2502         https://bugs.webkit.org/show_bug.cgi?id=195561
2503
2504         Reviewed by Youenn Fablet.
2505
2506         Make sure the JS in the test requests for permission to receive device orientation events.
2507
2508         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2509
2510 2019-03-11  Youenn Fablet  <youenn@apple.com>
2511
2512         Allow storage quota increase by default in WTR
2513         https://bugs.webkit.org/show_bug.cgi?id=195541
2514
2515         Reviewed by Geoffrey Garen.
2516
2517         Allow storage quota increase by default in WTR.
2518         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2519         Use this for tests that explicitly need cache increase.
2520
2521         Instead of increasing quota by 2, make sure the next request is
2522         granted by adding all given parameters.
2523
2524         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2525         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2526         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2527         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2529         * WebKitTestRunner/TestController.cpp:
2530         (WTR::TestController::setAllowStorageQuotaIncrease):
2531         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2532         * WebKitTestRunner/TestController.h:
2533         * WebKitTestRunner/TestInvocation.cpp:
2534         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2535         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2536         (WTR::TestController::cocoaResetStateToConsistentValues):
2537         (WTR::TestController::setAllowStorageQuotaIncrease):
2538         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2539         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2540         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2541
2542 2019-03-11  Xan Lopez  <xan@igalia.com>
2543
2544         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2545         https://bugs.webkit.org/show_bug.cgi?id=194147
2546
2547         Reviewed by Michael Saboff.
2548
2549         To make --32-bit work correctly on Linux/64bit we need to:
2550
2551         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2552         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2553         unfortunately CMake only allows us to do this during
2554         crosscompilation, which is overkill here.
2555         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2556         pkg-config detection module uses the x86 .pc files instead of the
2557         x86_64 ones.
2558         - Set the -m32 flags for the compiler.
2559
2560         * Scripts/webkitdirs.pm:
2561         (generateBuildSystemFromCMakeProject):
2562
2563 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2564
2565         Add MotionMark-1.1 plan file for run-benchmark script.
2566         https://bugs.webkit.org/show_bug.cgi?id=195481
2567
2568         Rubber-stamped by Darin Adler.
2569
2570         Run-benchmark script should support MontionMark-1.1.
2571
2572         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2573
2574 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2575
2576         [ews-app] Add support for submit-to-ews url
2577         https://bugs.webkit.org/show_bug.cgi?id=195477
2578
2579         Reviewed by Lucas Forschler.
2580
2581         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2582         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2583         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2584         * BuildSlaveSupport/ews-app/ews/urls.py:
2585         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2586
2587 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2588
2589         Unreviewed, rolling out r242688, r242643, r242624.
2590
2591         Caused multiple layout test failures and crashes on iOS and macOS.
2592
2593         Reverted changeset:
2594
2595         "requestAnimationFrame should execute before the next frame"
2596         https://bugs.webkit.org/show_bug.cgi?id=177484
2597         https://trac.webkit.org/changeset/242624/webkit
2598
2599         * Tracing/SystemTracePoints.plist:
2600
2601 2019-03-11  John Wilander  <wilander@apple.com>
2602
2603         Resource Load Statistics: Make it possible exclude localhost from classification
2604         https://bugs.webkit.org/show_bug.cgi?id=195474
2605         <rdar://problem/47520577>
2606
2607         Reviewed by Brent Fulgham.
2608
2609         This patch allows for localhost to be excluded from classification and
2610         treatment as a prevalent resource.
2611
2612         The WebKit Tools change adds a new function called
2613         testRunner.setStatisticsIsRunningTest() which can be used to control this
2614         behavior.
2615
2616         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2618         (WTR::TestRunner::setStatisticsIsRunningTest):
2619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2620         * WebKitTestRunner/TestController.cpp:
2621         (WTR::TestController::setStatisticsIsRunningTest):
2622         * WebKitTestRunner/TestController.h:
2623         * WebKitTestRunner/TestInvocation.cpp:
2624         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2625
2626 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2627
2628         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2629         https://bugs.webkit.org/show_bug.cgi?id=195560
2630
2631         Reviewed by Lucas Forschler.
2632
2633         * BuildSlaveSupport/ews-build/master.cfg:
2634
2635 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2636
2637         Unreviewed, rolling out r242698.
2638
2639         API test crashes on bots.
2640
2641         Reverted changeset:
2642
2643         "Add a WKContentRuleList variant that uses copied memory
2644         instead of mmap'd shared memory for class A containerized
2645         apps"
2646         https://bugs.webkit.org/show_bug.cgi?id=195511
2647         https://trac.webkit.org/changeset/242698
2648
2649 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2650
2651         [WPE] Enable web process sandbox
2652         https://bugs.webkit.org/show_bug.cgi?id=195169
2653
2654         Reviewed by Daniel Bates.
2655
2656         * wpe/install-dependencies:
2657         * wpe/jhbuild.modules:
2658
2659 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2660
2661         [ews-app] Use port 17000 for worker communication
2662         https://bugs.webkit.org/show_bug.cgi?id=195558
2663
2664         Reviewed by Lucas Forschler.
2665
2666         * BuildSlaveSupport/ews-build/master.cfg:
2667
2668 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2669
2670         [ews-build] unit-tests fail when passwords.json is missing
2671         https://bugs.webkit.org/show_bug.cgi?id=195557
2672
2673         Reviewed by Lucas Forschler.
2674
2675         * BuildSlaveSupport/ews-build/loadConfig.py:
2676         (loadBuilderConfig):
2677         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2678         (ConfigDotJSONTest.test_configuration):
2679         * BuildSlaveSupport/ews-build/master.cfg:
2680
2681 2019-03-11  Truitt Savell  <tsavell@apple.com>
2682
2683         Unreviewed, rolling out r242702.
2684
2685         Broke High Sierra builders.
2686
2687         Reverted changeset:
2688
2689         "Add utility function to allow easy reverse range-based
2690         iteration of a container"
2691         https://bugs.webkit.org/show_bug.cgi?id=195542
2692         https://trac.webkit.org/changeset/242702
2693
2694 2019-03-11  Sam Weinig  <sam@webkit.org>
2695
2696         Add utility function to allow easy reverse range-based iteration of a container
2697         https://bugs.webkit.org/show_bug.cgi?id=195542
2698
2699         Reviewed by Antti Koivisto.
2700
2701         * TestWebKitAPI/CMakeLists.txt:
2702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2703         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2704         (TestWebKitAPI::TEST):
2705         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2706
2707 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2708
2709         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2710         https://bugs.webkit.org/show_bug.cgi?id=195511
2711         <rdar://problem/44873269>
2712
2713         Reviewed by Darin Adler.
2714
2715         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2716         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2717         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2718         (TEST_F):
2719
2720 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2721
2722         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2723         https://bugs.webkit.org/show_bug.cgi?id=195499
2724
2725         Reviewed by Darin Adler.
2726
2727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2728         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2729         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2730         (-[WKWebView synchronouslyFocusTextInputContext:]):
2731         (applyStyle):
2732         (applyIframe):
2733         (TEST):
2734         Add some tests for this SPI.
2735
2736 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2737
2738         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2739         https://bugs.webkit.org/show_bug.cgi?id=181151
2740
2741         Reviewed by Don Olmstead.
2742
2743         * TestWebKitAPI/CMakeLists.txt:
2744         * TestWebKitAPI/PlatformWin.cmake:
2745         Enable TestWTF RunLoop tests in all platforms.
2746
2747         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2748         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2749         (TestWebKitAPI::DerivedOneShotTimer::fired):
2750         (TestWebKitAPI::TEST):
2751         Only a few platforms support nested RunLoop.
2752
2753         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2754         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2755
2756 2019-03-10  David Quesada  <david_quesada@apple.com>
2757
2758         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2759         https://bugs.webkit.org/show_bug.cgi?id=152480
2760
2761         Reviewed by Chris Dumez.
2762
2763         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2764         there are no additional references to the process pool besides the one held by
2765         the download, waits for the download to finish (in the sense that the
2766         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2767         measure, also check that the process pool has been deallocated at the end of the
2768         test. The test wouldn't be meaningful if the process pool were still alive.
2769
2770         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2771         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2772         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2773             The download will be canceled because the delegate does not implement the
2774             method to decide the download's destination, so this is where we know the
2775             DownloadProxyMap is done with the DownloadProxy.
2776         (TEST):
2777
2778 2019-03-08  Chris Dumez  <cdumez@apple.com>
2779
2780         Add support for Device Orientation / Motion permission API
2781         https://bugs.webkit.org/show_bug.cgi?id=195329
2782         <rdar://problem/47645367>
2783
2784         Reviewed by Geoffrey Garen.
2785
2786         Add test infrastructure to help test the Device Orientation / Motion permission API.
2787
2788         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2790         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2791         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2792         * WebKitTestRunner/TestController.cpp:
2793         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2794         (WTR::TestController::createWebViewWithOptions):
2795         (WTR::TestController::resetStateToConsistentValues):
2796         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2797         * WebKitTestRunner/TestController.h:
2798         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2799         * WebKitTestRunner/TestInvocation.cpp:
2800         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2801
2802 2019-03-08  Saam barati  <sbarati@apple.com>
2803
2804         Add a compare-results script to compare benchmark results
2805         https://bugs.webkit.org/show_bug.cgi?id=195486
2806         <rdar://problem/48723397>
2807
2808         Reviewed by Geoffrey Garen.
2809
2810         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2811         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2812         to extend it to learn about our other benchmarks.
2813
2814         * Scripts/compare-results: Added.
2815         (readJSONFile):
2816         (detectJetStream2):
2817         (JetStream2Results):
2818         (detectSpeedometer2):
2819         (Speedometer2Results):
2820         (detectPLT5):
2821         (PLT5Results):
2822         (detectBenchmark):
2823         (biggerIsBetter):
2824         (ttest):
2825         (getOptions):
2826         (main):
2827
2828 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2829
2830         Ensure old tab state is cleared between iterations of run-benchmark
2831         https://bugs.webkit.org/show_bug.cgi?id=195393
2832         <rdar://problem/46885583>
2833
2834         Reviewed by Dewei Zhu.
2835
2836         a) ensure the default to restore state is not set
2837         b) terminate Safari correctly
2838         c) Set the system default to ignore Persistent State in Safari
2839
2840         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2841         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2842         (OSXBrowserDriver.prepare_env): 
2843         (OSXBrowserDriver.restore_env):
2844         (OSXBrowserDriver.close_browsers):
2845         (OSXBrowserDriver._terminate_processes):
2846         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2847         (OSXChromeDriver):
2848         (OSXChromeCanaryDriver):
2849         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2850         (OSXFirefoxDriver):
2851         (OSXFirefoxNightlyDriver):
2852         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2853         (OSXSafariDriver):
2854         (OSXSafariDriver.prepare_env):
2855
2856 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2857
2858         [GTK] Several InputMethodFilter tests are failing
2859         https://bugs.webkit.org/show_bug.cgi?id=195408
2860
2861         Reviewed by Carlos Garcia Campos.
2862
2863         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2864         Regressed in r241751.
2865         Hexadecimal values of keycodes are expressed now in upper letters.
2866         Composited characters should be cast to UTF8 strings.
2867
2868         (TestWebKitAPI::TEST):
2869
2870 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2871
2872         [GTK] Make Tools/gtkdoc python3 compatible
2873         https://bugs.webkit.org/show_bug.cgi?id=195359
2874
2875         Reviewed by Carlos Garcia Campos.
2876
2877         * gtkdoc/generate-gtkdoc:
2878         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2879         work with Python 2 and 3.
2880         (get_gtkdoc_module_paths):
2881         The iteritems() was removed in Python 3, so let's use items() that's
2882         available in Python 2 and 3.
2883         (get_generator_for_config):
2884         * gtkdoc/gtkdoc.py:
2885         (GTKDoc._run_command):
2886         The sys.stdout.write() is expecting str in Python 3 and not bytes
2887         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2888         for passing the bytes there.
2889
2890 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2891
2892         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2893         https://bugs.webkit.org/show_bug.cgi?id=195346
2894         <rdar://problem/48667048>
2895
2896         Unreviewed build fix for clang-cl.
2897
2898         * DumpRenderTree/win/DumpRenderTree.cpp:
2899         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2900
2901 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2902
2903         requestAnimationFrame should execute before the next frame
2904         https://bugs.webkit.org/show_bug.cgi?id=177484
2905
2906         Reviewed by Simon Fraser.
2907
2908         Add trace points for the page RenderingUpdate.
2909
2910         * Tracing/SystemTracePoints.plist:
2911
2912 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2913
2914         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2915         https://bugs.webkit.org/show_bug.cgi?id=195353
2916         <rdar://problem/48626394>
2917
2918         Reviewed by Simon Fraser.
2919
2920         * WebKitTestRunner/ios/TestControllerIOS.mm:
2921         (WTR::TestController::platformResetPreferencesToConsistentValues):
2922
2923 2019-03-07  John Wilander  <wilander@apple.com>
2924
2925         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2926         https://bugs.webkit.org/show_bug.cgi?id=195383
2927         <rdar://problem/48570136>
2928
2929         Reviewed by Brent Fulgham.
2930
2931         This patch adds test infrastructure to purge only script-accessible cookies,
2932         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2933
2934         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2935         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2936         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2937         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2938         * WebKitTestRunner/TestController.cpp:
2939         (WTR::TestController::statisticsDeleteCookiesForHost):
2940         * WebKitTestRunner/TestController.h:
2941         * WebKitTestRunner/TestInvocation.cpp:
2942         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2943
2944 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2945
2946         Unreviewed, rolling out r242354.
2947         https://bugs.webkit.org/show_bug.cgi?id=195402
2948
2949         breaks layout tests in all configurations (Requested by
2950         zdobersek on #webkit).
2951
2952         Reverted changeset:
2953
2954         "[WPE] Enable web process sandbox"
2955         https://bugs.webkit.org/show_bug.cgi?id=195169
2956         https://trac.webkit.org/changeset/242354
2957
2958 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2959
2960         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2961         https://bugs.webkit.org/show_bug.cgi?id=195346
2962
2963         Reviewed by Fujii Hironori.
2964
2965         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2966         (TestWebKitAPI::TEST):
2967         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2968
2969         * DumpRenderTree/win/DumpRenderTree.cpp:
2970         (findFontFallback):
2971         (addFontFallbackIfPresent):
2972         (removeFontFallbackIfPresent):
2973         (main):
2974         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2975         (TestWebKitAPI::Util::moduleDirectory):
2976         (TestWebKitAPI::Util::createInjectedBundlePath):
2977         Use wchar helpers as needed.
2978
2979 2019-03-06  Rob Buis  <rbuis@igalia.com>
2980
2981         Consider supporting the `referrerpolicy` attribute.
2982         https://bugs.webkit.org/show_bug.cgi?id=179053
2983
2984         Reviewed by Darin Adler.
2985
2986         Add a runtime flag for referrerpolicy attribute.
2987
2988         * DumpRenderTree/mac/DumpRenderTree.mm:
2989         (enableExperimentalFeatures):
2990
2991 2019-03-05  Daniel Bates  <dabates@apple.com>
2992
2993         Update expected API test result following r242379
2994         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2995
2996         Update expected x-coordinate of selection rect now that the left padding of
2997         a textarea is sized in ems (so dependent on the font size) just like the left
2998         padding of a text field.
2999
3000         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3001         (TestWebKitAPI::TEST):
3002
3003 2019-03-05  David Quesada  <david_quesada@apple.com>
3004
3005         [WK2] It should be possible to follow links with 'download' attributes
3006         https://bugs.webkit.org/show_bug.cgi?id=195145
3007         rdar://problem/48462642
3008
3009         Reviewed by Alex Christensen.
3010
3011         Add a unit test to verify that activating links with 'download' attributes now
3012         navigates to the linked resource, rather than starts downloading it. Add another
3013         to verify that it is still possible to explicitly download the link via the
3014         'Download' navigation action policy.
3015
3016         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3017         (-[DownloadAttributeTestDelegate init]):
3018         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3019         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3020         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3021         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3022         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3023         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3024         (TEST):
3025         * WebKitTestRunner/TestController.cpp:
3026         (WTR::TestController::decidePolicyForNavigationAction):
3027         * WebKitTestRunner/TestController.h:
3028
3029 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3030
3031         [Curl] Implement Cookie Accept Policy.
3032         https://bugs.webkit.org/show_bug.cgi?id=191645
3033
3034         Reviewed by Fujii Hironori.
3035
3036         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3037         (TestWebKitAPI::Curl::TEST_F):
3038
3039 2019-03-05  Youenn Fablet  <youenn@apple.com>
3040
3041         Rename requestCacheStorageSpace to requestStorageSpace
3042         https://bugs.webkit.org/show_bug.cgi?id=195282
3043
3044         Reviewed by Chris Dumez.
3045
3046         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3047         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3048         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3049
3050 2019-03-05  Brady Eidson  <beidson@apple.com>
3051
3052         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3053         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3054
3055         Reviewed by Tim Horton.
3056
3057         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3058         different directory into that same WKWebView should work.
3059
3060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3061         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3062
3063 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         Add WeakHashSet
3066         https://bugs.webkit.org/show_bug.cgi?id=195152
3067
3068         Reviewed by Antti Koivisto.
3069
3070         Added tests for WeakHashSet.
3071
3072         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3073         (TestWebKitAPI::Base::Base): Moved.
3074         (TestWebKitAPI::Derived::foo): Moved.
3075         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3076         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3077         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3078         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3079
3080 2019-03-04  Chris Dumez  <cdumez@apple.com>
3081
3082         Do not share WebProcesses between private and regular sessions
3083         https://bugs.webkit.org/show_bug.cgi?id=195189
3084         <rdar://problem/48421064>
3085
3086         Reviewed by Alex Christensen.
3087
3088         Add API test coverage.
3089
3090         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3091         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3092
3093 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3094
3095         [WPE] Enable web process sandbox
3096         https://bugs.webkit.org/show_bug.cgi?id=195169
3097
3098         Reviewed by Daniel Bates.
3099
3100         * wpe/install-dependencies:
3101         * wpe/jhbuild.modules:
3102
3103 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3104
3105         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3106         https://bugs.webkit.org/show_bug.cgi?id=195206
3107
3108         Reviewed by Žan Doberšek.
3109
3110         Add a new test case.
3111
3112         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3113         (testJSCClass):
3114
3115 2019-03-04  Charlie Turner  <cturner@igalia.com>
3116
3117         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3118         https://bugs.webkit.org/show_bug.cgi?id=194898
3119
3120         Reviewed by Žan Doberšek.
3121
3122         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3123         a GCC extension that permits arithmetic on void* pointer. Inline
3124         the macro until this issue is fixed upstream.
3125
3126 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3127
3128         Rid the world of WK_API_ENABLED
3129         https://bugs.webkit.org/show_bug.cgi?id=195263
3130
3131         Reviewed by Dan Bernstein.
3132
3133         List of changed files elided because it's useless.
3134
3135 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3136
3137         Unreviewed follow-up to r242292.
3138
3139         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3140
3141         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3142         (TestWebKitAPI::testStrip): Renamed from strip.
3143         (TestWebKitAPI::TEST):
3144
3145 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3146
3147         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3148
3149         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3150         and bug #194272 for details.
3151
3152         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3153
3154 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3155
3156         Remove some more unused 32-bit code
3157         https://bugs.webkit.org/show_bug.cgi?id=195255
3158
3159         Reviewed by Darin Adler.
3160
3161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3162         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3163         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3164         (NPP_New):
3165         (NPP_HandleEvent):
3166         (handleEventCarbon): Deleted.
3167
3168 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3169
3170         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3171
3172         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3173         (TestWebKitAPI::TEST):
3174
3175 2019-03-01  Darin Adler  <darin@apple.com>
3176
3177         Finish removing String::format
3178         https://bugs.webkit.org/show_bug.cgi?id=194893
3179
3180         Reviewed by Daniel Bates.
3181 '
3182         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3183
3184 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3185
3186         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3187         https://bugs.webkit.org/show_bug.cgi?id=195229
3188         <rdar://problem/48520362>
3189
3190         Reviewed by Chris Dumez.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3193         (TEST):
3194
3195 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3196
3197         Add a system trace scope for event region building
3198         https://bugs.webkit.org/show_bug.cgi?id=195226
3199
3200         Reviewed by Jon Lee.
3201
3202         This trace scope measures the time spend converting element rects into Region objects,
3203         which can be large on some pages.
3204
3205         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3206
3207         * Tracing/SystemTracePoints.plist:
3208
3209 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3210
3211         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3212         https://bugs.webkit.org/show_bug.cgi?id=194612
3213
3214         Reviewed by Alex Christensen.
3215
3216         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3217         Just test the new string-processing function and don't touch the actual environment.
3218         (Test cases are all as before, but based on operator== instead of strcmp.)
3219
3220 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3221
3222         [ews-app] Update primary keys for handling multiple Buildbot instances
3223         https://bugs.webkit.org/show_bug.cgi?id=195120
3224
3225         Reviewed by Stephanie Lewis.
3226
3227         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3228         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3229         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3230
3231         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3232         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3233         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3234         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3235         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3236         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3237
3238 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3239
3240         [WinCairo] Enable service worker
3241         https://bugs.webkit.org/show_bug.cgi?id=188318
3242
3243         Reviewed by Youenn Fablet.
3244
3245         * DumpRenderTree/DumpRenderTreePrefix.h:
3246         * TestWebKitAPI/PlatformWin.cmake:
3247         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3248         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3249         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3250
3251 2019-03-01  Justin Fan  <justin_fan@apple.com>
3252
3253         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3254         https://bugs.webkit.org/show_bug.cgi?id=195191
3255
3256         Rubber-stamped by Dean Jackson.
3257
3258         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3259
3260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3261
3262 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3263
3264         Unreviewed, fix lldb webkitpy tests
3265         https://bugs.webkit.org/show_bug.cgi?id=194375
3266
3267         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3268
3269         * lldb/lldb_webkit.py:
3270         (WTFStringImplProvider.is_8bit):
3271
3272 2019-02-28  David Quesada  <david_quesada@apple.com>
3273
3274         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3275         https://bugs.webkit.org/show_bug.cgi?id=195121
3276         rdar://problem/48450302
3277
3278         Reviewed by Alex Christensen.
3279
3280         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3281         configurations where the 'download' attribute is absent, blank, or populated
3282         with a filename, and where the anchor element is same-origin or cross-origin
3283         (meaning the 'download' attribute shouldn't be honored).
3284
3285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3286         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3287         (-[NavigationActionTestDelegate init]):
3288         (-[NavigationActionTestDelegate navigationAction]):
3289         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3290         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3291         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3292         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3293         (TEST):
3294
3295 2019-02-28  Antoine Quint  <graouts@apple.com>
3296
3297         Enable the Pointer Events runtime flag by default
3298         https://bugs.webkit.org/show_bug.cgi?id=195156
3299
3300         Reviewed by Dean Jackson.
3301
3302         * DumpRenderTree/mac/DumpRenderTree.mm:
3303         (enableExperimentalFeatures):
3304
3305 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3306
3307         Several PasteImage API tests are flaky
3308         https://bugs.webkit.org/show_bug.cgi?id=195160
3309
3310         Reviewed by Tim Horton.
3311
3312         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3313         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3314         listening for a "load" event after image load is already complete.
3315
3316         To address this, make these tests first register a "load" event handler, then run script to insert an image
3317         element into the document, and finally wait until the load event is observed before checking image size.
3318
3319         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3320
3321 2019-02-28  Chris Dumez  <cdumez@apple.com>
3322
3323         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3324         https://bugs.webkit.org/show_bug.cgi?id=195107
3325
3326         Reviewed by Alex Christensen.
3327
3328         Give some time for the zoom level to get restored.
3329
3330         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3331
3332 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3333
3334         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3335         https://bugs.webkit.org/show_bug.cgi?id=194958
3336
3337         Reviewed by Geoffrey Garen.
3338
3339         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3340         (TEST):
3341
3342 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3343
3344         [ews-app] Update method to save build to handle builder_display_name
3345         https://bugs.webkit.org/show_bug.cgi?id=195047
3346
3347         Reviewed by Dewei Zhu.
3348
3349         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3350         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3351
3352 2019-02-28  Justin Fan  <justin_fan@apple.com>
3353
3354         [Web GPU] Enable Web GPU only on 64-bit
3355         https://bugs.webkit.org/show_bug.cgi?id=195139
3356
3357         Because Metal is only supported on 64 bit apps.
3358
3359         Unreviewed build fix.
3360
3361         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3362
3363 2019-02-27  Youenn Fablet  <youenn@apple.com>
3364
3365         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3366         https://bugs.webkit.org/show_bug.cgi?id=194959
3367
3368         Reviewed by Chris Dumez.
3369
3370         Spin loop until getting the condition to remove flakiness.
3371
3372         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3373
3374 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3375
3376         [ews-build] Buildbot should include builder_display_name in the build events
3377         https://bugs.webkit.org/show_bug.cgi?id=195045
3378
3379         Reviewed by Dewei Zhu.
3380
3381         * BuildSlaveSupport/ews-build/events.py:
3382         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3383         buildername to builder_name to be consistent in naming style.
3384         (Events.buildFinished): Ditto.
3385
3386 2019-02-27  Chris Dumez  <cdumez@apple.com>
3387
3388         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3389         https://bugs.webkit.org/show_bug.cgi?id=194480
3390
3391         Reviewed by Brady Eidson.
3392
3393         Update existing API test to make it more likely to reproduce the issue.
3394
3395         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3396
3397 2019-02-27  Brady Eidson  <beidson@apple.com>
3398
3399         Universal links from Google search results pages don't open the app.
3400         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3401
3402         Reviewed by Geoffrey Garen.
3403
3404         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3405         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3406         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3407         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3408
3409 2019-02-27  Chris Dumez  <cdumez@apple.com>
3410
3411         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3412         https://bugs.webkit.org/show_bug.cgi?id=195102
3413
3414         Reviewed by Geoffrey Garen.
3415
3416         If the number of processes is not yet what we expect, wait a bit and check again to give
3417         processes some time to exit.
3418
3419         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3420
3421 2019-02-27  Chris Dumez  <cdumez@apple.com>
3422
3423         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3424         https://bugs.webkit.org/show_bug.cgi?id=194545
3425
3426         Reviewed by Brady Eidson.
3427
3428         Make sure the test navigates forward and then back only once. Previously, navigating
3429         back would trigger a navigation again in a timer.
3430
3431         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3432
3433 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3434
3435         High Sierra Debug JSC test queue should use faster hardware
3436         https://bugs.webkit.org/show_bug.cgi?id=194603
3437
3438         Rubber-stamped by Alexey Proskuryakov.
3439
3440         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3441
3442         * BuildSlaveSupport/build.webkit.org-config/config.json:
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3444         (BubbleQueueServer):
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3446         (WebKitBuildbot):
3447         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3448         * QueueStatusServer/config/queues.py:
3449         * Scripts/webkitpy/common/config/ews.json:
3450         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3451         (test_ews_name):
3452
3453 2019-02-27  John Wilander  <wilander@apple.com>
3454
3455         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3456         https://bugs.webkit.org/show_bug.cgi?id=195071
3457         <rdar://problem/48417690>
3458
3459         Reviewed by Alex Christensen and Brent Fulgham.
3460
3461         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3462         (TestWebKitAPI::createURL):
3463             Convenience function.
3464         (TestWebKitAPI::TEST):
3465             WebCore::AdClickAttribution now takes a URL when creating Source and
3466             Destination.
3467         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3468         (TestWebKitAPI::TEST):
3469             WebCore::AdClickAttribution now takes a URL when creating Source and
3470             Destination.
3471
3472 2019-02-27  Antoine Quint  <graouts@apple.com>
3473
3474         Support Pointer Events on macOS
3475         https://bugs.webkit.org/show_bug.cgi?id=195008
3476         <rdar://problem/47454419>
3477
3478         Reviewed by Dean Jackson.
3479
3480         * DumpRenderTree/mac/DumpRenderTree.mm:
3481         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3482         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3483
3484 2019-02-26  Mark Lam  <mark.lam@apple.com>
3485
3486         Remove remaining poisoning code.
3487         https://bugs.webkit.org/show_bug.cgi?id=194138
3488
3489         Reviewed by Saam Barati.
3490
3491         * TestWebKitAPI/CMakeLists.txt:
3492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3493         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3494         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3495         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3496         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3497         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3498         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3499
3500 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3501
3502         Move ephemeral local storage from WebProcess to UIProcess
3503         https://bugs.webkit.org/show_bug.cgi?id=195074
3504         <rdar://problem/47937975>
3505
3506         Reviewed by Geoff Garen.
3507
3508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3509
3510 2019-02-20  Jer Noble  <jer.noble@apple.com>
3511
3512         [Cocoa] Media elements will restart network buffering just before suspending
3513         https://bugs.webkit.org/show_bug.cgi?id=193691
3514
3515         Reviewed by Eric Carlson.
3516
3517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3518         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3519         (TEST):
3520
3521 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3522
3523         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3524         https://bugs.webkit.org/show_bug.cgi?id=191652
3525
3526         Reviewed by Alex Christensen.
3527
3528         Fix WinCairo MiniBrowser behavior of authentication dialog.
3529
3530         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3531         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3532
3533 2019-02-26  Youenn Fablet  <youenn@apple.com>
3534
3535         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3536         https://bugs.webkit.org/show_bug.cgi?id=195028
3537         <rdar://problem/48243733>
3538
3539         Reviewed by Eric Carlson.
3540
3541         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3542
3543 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3544
3545         [WPE] Add API for webview background color configuration
3546         https://bugs.webkit.org/show_bug.cgi?id=192305
3547
3548         Reviewed by Michael Catanzaro.
3549
3550         * MiniBrowser/wpe/main.cpp:
3551         (main): Add a new option to configure the webview background
3552         color. Example: --bg-color=transparent.
3553         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3554         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3555         (beforeAll): Ditto.
3556
3557 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3558
3559         scalableNativeWebpageParameters() is not preserved on new page navigation.
3560         https://bugs.webkit.org/show_bug.cgi?id=194892
3561         <rdar://problem/47538280>
3562
3563         Reviewed by Wenson Hsieh.
3564         
3565         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3566
3567         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3568         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3569         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3570         (WTR::UIScriptController::allowsViewportShrinkToFit):
3571         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3572         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3573         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3574         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3575         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3576         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3577
3578 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3579
3580         [ews-app] Add model for handling multiple Buildbot instances
3581         https://bugs.webkit.org/show_bug.cgi?id=194863
3582
3583         Reviewed by Stephanie Lewis.
3584
3585         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3586
3587 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3588
3589         [ews-app] Remove BuilderMapping table
3590         https://bugs.webkit.org/show_bug.cgi?id=194961
3591
3592         Reviewed by Stephanie Lewis.
3593
3594         Store builder name directly in build table, instead of having a separate
3595         table for it.
3596
3597         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3598         * BuildSlaveSupport/ews-app/ews/models/build.py:
3599         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3600         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3601
3602 2019-02-25  John Wilander  <wilander@apple.com>
3603
3604         Introduce and adopt new class RegistrableDomain for eTLD+1
3605         https://bugs.webkit.org/show_bug.cgi?id=194791
3606         <rdar://problem/48179240>
3607
3608         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3609
3610         This patch adds an API test and replaces two instances of
3611         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3612
3613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3614         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3615         (TestWebKitAPI::TEST):
3616             Changed two strings to make sure the registrable domains are still considered
3617             invalid and pass the test.
3618         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3619         (TestWebKitAPI::TEST):
3620         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3621         (WTR::InjectedBundle::didReceiveMessageToPage):
3622
3623 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3624
3625         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3626         https://bugs.webkit.org/show_bug.cgi?id=195001
3627
3628         Reviewed by Carlos Garcia Campos.
3629
3630         API version 1.0 always includes the functionality previously guarded with
3631         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3632         unconditionally.
3633
3634         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3635         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3636         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3637         (WebViewTest::showInWindow): Ditto.
3638         (WebViewTest::hideView): Ditto.
3639         * wpe/backends/HeadlessViewBackend.cpp:
3640         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3641         * wpe/backends/ViewBackend.cpp:
3642         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3643         * wpe/backends/WindowViewBackend.cpp:
3644         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3645         WPE_BACKEND_CHECK_VERSION().
3646         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3647
3648 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3649
3650         [Flatpak] Add support for flatpak > 1.1.2
3651         https://bugs.webkit.org/show_bug.cgi?id=194088
3652
3653         Flatpak 1.2 is now out so we need to support that
3654         version now.
3655
3656         Reviewed by Michael Catanzaro.
3657
3658         * flatpak/flatpakutils.py:
3659         (check_flatpak):
3660         (FlatpakPackages.__init__):
3661         (FlatpakPackages.__detect_packages):
3662         (FlatpakPackages.__detect_packages.in):
3663         (FlatpakRepos.update):
3664
3665 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3666
3667         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3668         https://bugs.webkit.org/show_bug.cgi?id=194998
3669
3670         Reviewed by Carlos Garcia Campos.
3671
3672         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3673         to a Git checkout and using the latest commit containing various fixes
3674         and improvements.
3675
3676 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3677
3678         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3679         https://bugs.webkit.org/show_bug.cgi?id=194981
3680
3681         Reviewed by Žan Doberšek.
3682
3683         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3684         (TestWebKitAPI::TEST):
3685
3686 2019-02-23  Keith Miller  <keith_miller@apple.com>
3687
3688         Add new mac target numbers
3689         https://bugs.webkit.org/show_bug.cgi?id=194955
3690
3691         Reviewed by Tim Horton.
3692
3693         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3694         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3695         * MiniBrowser/Configurations/Base.xcconfig:
3696         * TestWebKitAPI/Configurations/Base.xcconfig:
3697         * WebKitTestRunner/Configurations/Base.xcconfig:
3698
3699 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3700
3701         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3702         https://bugs.webkit.org/show_bug.cgi?id=194846
3703
3704         Reviewed by Don Olmstead.
3705
3706         Added _search_paths() and _port_specific_expectations_files() for
3707         WinCairoPort.
3708
3709         * Scripts/webkitpy/port/win.py:
3710         (WinCairoPort.default_baseline_search_path):
3711         (WinCairoPort):
3712         (WinCairoPort._port_specific_expectations_files):
3713         (WinCairoPort._search_paths):
3714
3715 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3716
3717         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3718         https://bugs.webkit.org/show_bug.cgi?id=194963
3719
3720         Reviewed by Dean Jackson.
3721
3722         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3723         Do a `contains` check instead of `equals`, because in debug builds we
3724         put the GraphicsLayer pointer in a prefix.
3725
3726 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3727
3728         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3729         https://bugs.webkit.org/show_bug.cgi?id=194873
3730         <rdar://problem/46701974>
3731
3732         Reviewed by Tim Horton.
3733
3734         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3735
3736         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3737         (WTR::UIScriptController::menuRect const):
3738         (WTR::UIScriptController::isShowingMenu const):
3739         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3740         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3741         (WTR::UIScriptController::menuRect const):
3742
3743         Add a function to query the bounds of the callout menu in content coordinates.
3744
3745         (WTR::UIScriptController::isShowingMenu const):
3746
3747         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3748
3749         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3750         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3751         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3752         (WTR::UIScriptController::rectForMenuAction const):
3753         (WTR::UIScriptController::menuRect const):
3754         (WTR::UIScriptController::isShowingMenu const):
3755         (WTR::findViewInHierarchyOfType): Deleted.
3756
3757 2019-02-22  Chris Dumez  <cdumez@apple.com>
3758
3759         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3760         https://bugs.webkit.org/show_bug.cgi?id=194954
3761         <rdar://problem/48127957>
3762
3763         Reviewed by Alex Christensen.
3764
3765         Add API test coverage.
3766
3767         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3768         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3769         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3770         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3771
3772 2019-02-22  Chris Dumez  <cdumez@apple.com>
3773
3774         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3775         https://bugs.webkit.org/show_bug.cgi?id=194924
3776         <rdar://problem/48216125>
3777
3778         Reviewed by Geoffrey Garen.
3779
3780         Add API test coverage.
3781
3782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3783
3784 2019-02-22  Chris Dumez  <cdumez@apple.com>
3785
3786         Unreviewed, disable API test added in r241928 on iOS.
3787
3788         The cache is not enabled on devices with less than 3GB of RAM.
3789
3790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3791
3792 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3793
3794         Hardcode Visual Viewports on everywhere except iOS WK1
3795         https://bugs.webkit.org/show_bug.cgi?id=194928
3796
3797         Reviewed by Zalan Bujtas.
3798
3799         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3800         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3801         set it to false. The setting has shipped for several years and there's no need to turn
3802         it off now.
3803
3804         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3805         Visual Viewports are not enabled.
3806         
3807         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3808         that only runs in WK2
3809
3810         * MiniBrowser/mac/SettingsController.h:
3811         * MiniBrowser/mac/SettingsController.m:
3812         (-[SettingsController init]):
3813         (-[SettingsController _populateMenu]):
3814         (-[SettingsController validateMenuItem:]):
3815         (-[SettingsController visualViewportEnabled]): Deleted.
3816         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3817         * MiniBrowser/mac/WK1BrowserWindowController.m:
3818         (-[WK1BrowserWindowController didChangeSettings]):
3819         * MiniBrowser/mac/WK2BrowserWindowController.m:
3820         (-[WK2BrowserWindowController didChangeSettings]):
3821
3822 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3823
3824         Discard cached processes when clearing website data store
3825         https://bugs.webkit.org/show_bug.cgi?id=194894
3826
3827         Reviewed by Chris Dumez.
3828
3829         Added a test case.
3830
3831         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3832         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3833
3834 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3835
3836         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3837         https://bugs.webkit.org/show_bug.cgi?id=194914
3838         <rdar://problem/47586889>
3839
3840         Reviewed by Geoffrey Garen.
3841
3842         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3843         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3844         (TEST):
3845         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3846
3847 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3848
3849         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3850         <https://webkit.org/b/194761>
3851
3852         Reviewed by Myles Maxfield.
3853
3854         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3855         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3856         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3857         to use ARC-compliant cast.
3858         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3859         ARC-compliant cast.
3860         (WTR::installFakeHelvetica): Log `error` to console if
3861         CTFontManagerRegisterFontsForURL() fails, but only on supported
3862         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3863         Call CFRelease() on `error` to fix the leak.  Update to use
3864         ARC-compliant cast.
3865         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3866         cast.
3867
3868 2019-02-21  Chris Dumez  <cdumez@apple.com>
3869
3870         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3871         https://bugs.webkit.org/show_bug.cgi?id=194481
3872
3873         Reviewed by Alex Christensen.
3874
3875         Give the processes a chance to shutdown and wait until we reached the expected number
3876         of processes.
3877
3878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3879
3880 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3881
3882         Fix the macOS build
3883
3884         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3885
3886 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3887
3888         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3889
3890         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3891         I am a backwards.
3892
3893 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3894
3895         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3896
3897         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3898         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3899         We could force on UI-side compositing, but I feel like the test might be more
3900         valuable exercising the normal path on each platform (though the original
3901         bug was also UI-side specific). Though we can't validate that the overlay
3902         layer was installed successfully, there are layout tests that do that.
3903
3904 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3905
3906         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3907         https://bugs.webkit.org/show_bug.cgi?id=194845
3908         <rdar://problem/47944579>
3909
3910         Reviewed by Antti Koivisto.
3911
3912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3913         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3914
3915 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3916
3917         [LFC][Floats] Add support for placing formatting roots in-between floats.
3918         https://bugs.webkit.org/show_bug.cgi?id=194902
3919
3920         Reviewed by Antti Koivisto.
3921
3922         * LayoutReloaded/misc/LFC-passing-tests.txt:
3923
3924 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3925
3926         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3927         https://bugs.webkit.org/show_bug.cgi?id=194901
3928
3929         Unreviewed build fix.
3930
3931         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3932         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3933         WPEBackend-fdo-0.1 as library name.
3934
3935 2019-02-21  Rob Buis  <rbuis@igalia.com>
3936
3937         Update MIME type parser
3938         https://bugs.webkit.org/show_bug.cgi?id=180526
3939
3940         Reviewed by Darin Adler.
3941
3942         Add tests involving leading and trailing whitespace, non-token
3943         characters and quoted strings.
3944
3945         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3946         (TestWebKitAPI::TEST):
3947
3948 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3949
3950         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3951         https://bugs.webkit.org/show_bug.cgi?id=194884
3952
3953         Reviewed by Michael Catanzaro.
3954
3955         * PlatformWin.cmake:
3956
3957 2019-02-20  Chris Dumez  <cdumez@apple.com>
3958
3959         Add API test for <rdar://problem/47471222>
3960         https://bugs.webkit.org/show_bug.cgi?id=194847
3961
3962         Reviewed by Alex Christensen.
3963
3964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3965
3966 2019-02-20  Chris Dumez  <cdumez@apple.com>
3967
3968         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3969         https://bugs.webkit.org/show_bug.cgi?id=194872
3970         <rdar://problem/47924500>
3971
3972         Reviewed by Alex Christensen.
3973
3974         Add API test coverage.
3975
3976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3977
3978 2019-02-20  Jer Noble  <jer.noble@apple.com>
3979
3980         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3981         https://bugs.webkit.org/show_bug.cgi?id=191332
3982
3983         Reviewed by Dean Jackson.
3984
3985         * Scripts/git-is-in-range: Added.
3986
3987 2019-02-20  Andy Estes  <aestes@apple.com>
3988
3989         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3990         https://bugs.webkit.org/show_bug.cgi?id=194869
3991
3992         Rubber-stamped by Jer Noble.
3993
3994         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3995         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3996         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3997         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3999         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4000
4001 2019-02-20  Chris Dumez  <cdumez@apple.com>
4002
4003         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4004         https://bugs.webkit.org/show_bug.cgi?id=194857
4005         <rdar://problem/47759323>
4006
4007         Reviewed by Alex Christensen.
4008
4009         Add API test coverage.
4010
4011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4012
4013 2019-02-20  Chris Dumez  <cdumez@apple.com>
4014
4015         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4016         https://bugs.webkit.org/show_bug.cgi?id=194829
4017         <rdar://problem/47889906>
4018
4019         Reviewed by Alexey Proskuryakov.
4020
4021         Every time the TestOptions were changing we were creating both a new Web view and
4022         a new WKContext, which would start a new Network process. In most cases, we only
4023         need to contruct a new Web view and we do can keep reusing the same WKContext.
4024         This patch implements this optimization and thus avoids spinning a lot of new
4025         Network processes while running the layout tests.
4026
4027         * WebKitTestRunner/TestController.cpp:
4028         (WTR::TestController::generateContextConfiguration const):
4029         (WTR::TestController::generatePageConfiguration):
4030         (WTR::TestController::createWebViewWithOptions):
4031         (WTR::TestController::resetPreferencesToConsistentValues):
4032         (WTR::updateTestOptionsFromTestHeader):
4033         * WebKitTestRunner/TestController.h:
4034         * WebKitTestRunner/TestOptions.h:
4035         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4036         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4037         (WTR::TestOptions::hasSameInitializationOptions const):
4038         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4039         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4040         (WTR::TestController::platformAddTestOptions const):
4041
4042 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4043
4044         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4045         https://bugs.webkit.org/show_bug.cgi?id=167941
4046
4047         Reviewed by Carlos Garcia Campos.
4048
4049         * MiniBrowser/gtk/main.c:
4050         (filterSavedCallback): Added.
4051         (main): Support loading a JSON rule set file for content filtering.
4052         * MiniBrowser/wpe/main.cpp:
4053         (filterSavedCallback): Added.
4054         (main): Support loading a JSON rule set file for content filtering.
4055         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4056         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4057         (WTF::derefGPtr): Ditto.
4058         (testEmptyStore):
4059         (testSaveInvalidFilter):
4060         (testSaveLoadFilter):
4061         (testSavedFilterIdentifierMatch):
4062         (testRemoveFilter):
4063         (testSaveMultipleFilters):
4064         (testSaveFilterFromFile):
4065         (testFilterPersistence):
4066         (beforeAll):
4067         (afterAll):
4068         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4069         (removeOldInjectedContentAndResetLists): Also reset content filters.
4070         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4071         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4072         the element affected by the style sheet.
4073         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4074         and returns it to be used by tests.
4075         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4076         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4077         (serverCallback): Add support for serving a CSS style sheet for testing.
4078         (beforeAll): Add call to testUserContentManagerContentFilter().
4079         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4080
4081 2019-02-19  Keith Rollin  <krollin@apple.com>
4082
4083         Add timing information to build output
4084         https://bugs.webkit.org/show_bug.cgi?id=194839
4085         <rdar://problem/48219609>
4086
4087         Reviewed by Alexey Proskuryakov.
4088
4089         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4090         emit each project's build time to its output. E.g.,
4091
4092             ** BUILD SUCCEEDED ** [0.132 sec]
4093
4094         * Scripts/webkitdirs.pm:
4095         (XcodeOptions):
4096
4097 2019-02-19  Truitt Savell  <tsavell@apple.com>
4098
4099         Unreviewed, rolling out r241784.
4100
4101         Broke all OpenSource builds.
4102
4103         Reverted changeset:
4104
4105         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4106         instances view"
4107         https://bugs.webkit.org/show_bug.cgi?id=172848
4108         https://trac.webkit.org/changeset/241784
4109
4110 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4111
4112         [LFC][Floats] Remove redundant intersecting logic
4113         https://bugs.webkit.org/show_bug.cgi?id=194804
4114
4115         Reviewed by Antti Koivisto.
4116
4117         * LayoutReloaded/misc/LFC-passing-tests.txt:
4118
4119 2019-02-19  Dean Jackson  <dino@apple.com>
4120
4121         Clean-up output from generate-xcfilelists so it can be filtered
4122         https://bugs.webkit.org/show_bug.cgi?id=194795
4123
4124         Reviewed by Joseph Pecoraro (and Keith Rollin).
4125
4126         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4127         make a slight tweak to filter-build-webkit so such lines are marked
4128         as plain.
4129
4130         * Scripts/filter-build-webkit:
4131         * Scripts/generate-xcfilelists:
4132
4133 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4134
4135         pytest is not correctly auto-installed
4136         https://bugs.webkit.org/show_bug.cgi?id=194707
4137
4138         Reviewed by Carlos Garcia Campos.
4139
4140         * Scripts/webkitpy/thirdparty/__init__.py:
4141         (AutoinstallImportHook._install_pytest):
4142
4143 2019-02-18  Chris Dumez  <cdumez@apple.com>
4144
4145         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4146         https://bugs.webkit.org/show_bug.cgi?id=194797
4147         <rdar://problem/48055151>
4148
4149         Reviewed by Geoffrey Garen.
4150
4151         Add API test coverage.
4152
4153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4154
4155 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4156
4157         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4158         https://bugs.webkit.org/show_bug.cgi?id=194670
4159         <rdar://problem/39066529>
4160
4161         Reviewed by Tim Horton.
4162
4163         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4164         pasted in an editable area as attachment elements.
4165
4166         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4167         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4168         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4169         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4170         (TestWebKitAPI::TEST):
4171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4172         (WTR::InjectedBundlePage::InjectedBundlePage):
4173
4174 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4175
4176         Fix API test after r241728
4177        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4178
4179         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4180         (TEST):
4181         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4182
4183 2019-02-18  Daniel Bates  <dabates@apple.com>
4184
4185         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4186         https://bugs.webkit.org/show_bug.cgi?id=192824
4187         <rdar://problem/47100332>
4188
4189         Reviewed by Wenson Hsieh.
4190
4191         Fix a bug where the wrong usage code was used for F13 thru F24.
4192
4193         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4194         (keyCodeForDOMFunctionKey):
4195
4196 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4197
4198         Bytecode cache should a have a boot-specific validation
4199         https://bugs.webkit.org/show_bug.cgi?id=194769
4200         <rdar://problem/48149509>
4201
4202         Reviewed by Keith Miller.
4203
4204         Add test for WTF::bootSessionUUIDString()
4205
4206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4207         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4208         (TEST):
4209
4210 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4211
4212         Disable safe browsing in WKWebView and remove its WKPreferences API
4213         https://bugs.webkit.org/show_bug.cgi?id=194723
4214         <rdar://problem/48122993>
4215
4216         Reviewed by Geoffrey Garen.
4217
4218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4219         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4220         (TEST):
4221         (safeBrowsingView):
4222         Make tests use SPI instead of API.
4223
4224 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4225
4226         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4227         https://bugs.webkit.org/show_bug.cgi?id=194586
4228
4229         Reviewed by Ross Kirsling.
4230
4231         * DumpRenderTree/win/DumpRenderTree.cpp:
4232         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4233         * Scripts/webkitpy/port/driver.py:
4234         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4235
4236 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4237
4238         Unreviewed, rolling out r241620.
4239
4240         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4241         (Requested by ddkilzer on #webkit.)
4242
4243         Reverted changeset:
4244
4245         "[WTF] Add environment variable helpers"
4246         https://bugs.webkit.org/show_bug.cgi?id=192405
4247         https://trac.webkit.org/changeset/241620
4248
4249 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4250
4251         [LFC] RenderImage's default intrinsic size is 0.
4252         https://bugs.webkit.org/show_bug.cgi?id=194745
4253
4254         Reviewed by Antti Koivisto.
4255
4256         * LayoutReloaded/misc/LFC-passing-tests.txt:
4257
4258 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4259
4260         [LFC][BFC] Add support for block replaced intrinsic width.
4261         https://bugs.webkit.org/show_bug.cgi?id=194705
4262
4263         Reviewed by Simon Fraser.
4264
4265         * LayoutReloaded/misc/LFC-passing-tests.txt:
4266
4267 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4268
4269         [LFC] Apply min/max width constraints to preferred width computation
4270         https://bugs.webkit.org/show_bug.cgi?id=194739
4271
4272         Reviewed by Simon Fraser.
4273
4274         * LayoutReloaded/misc/LFC-passing-tests.txt:
4275
4276 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4277
4278         [WTF] Add environment variable helpers
4279         https://bugs.webkit.org/show_bug.cgi?id=192405
4280
4281         Reviewed by Michael Catanzaro.
4282
4283         * DumpRenderTree/mac/DumpRenderTree.mm:
4284         (libraryPathForDumpRenderTree):
4285         * DumpRenderTree/win/DumpRenderTree.cpp:
4286         (libraryPathForDumpRenderTree):
4287         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4288         (setUpIOSLayoutTestCommunication):
4289         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4290         (beforeAll):
4291         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4292         (main):
4293         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4294         (WebKitTestBus::run):
4295         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4296         (WTR::getOutputDir):
4297         (WTR::initializeFontConfigSetting):
4298         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4299         (WTR::InjectedBundle::platformInitialize):
4300         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4301         (WTR::topLevelPath):
4302         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4303         (WTR::topLevelPath):
4304         (WTR::getOutputDir):
4305         (WTR::activateFonts):
4306         * WebKitTestRunner/TestController.cpp:
4307         (WTR::TestController::libraryPathForTesting):
4308         (WTR::TestController::generateContextConfiguration const):
4309         (WTR::TestController::generatePageConfiguration):
4310         (WTR::TestController::decideDestinationWithSuggestedFilename):
4311         (WTR::TestController::platformAdjustContext):
4312         * WebKitTestRunner/TestController.h:
4313         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4314         (WTR::TestController::cocoaPlatformInitialize):
4315         (WTR::TestController::platformAdjustContext):
4316         * WebKitTestRunner/gtk/main.cpp:
4317         (main):
4318         * WebKitTestRunner/mac/TestControllerMac.mm:
4319         (WTR::TestController::configureContentExtensionForTest):
4320         * WebKitTestRunner/wpe/main.cpp:
4321         (main):
4322         Utilize WTF::Environment where possible.
4323
4324 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4325
4326         [iOS] WKWebView callout bar is missing Change Writing Direction item
4327         https://bugs.webkit.org/show_bug.cgi?id=190015
4328         <rdar://problem/44810366>
4329
4330         Reviewed by Tim Horton.
4331
4332         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4333         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4334
4335         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4336         (TestWebKitAPI::TEST):
4337
4338 2019-02-15  Chris Dumez  <cdumez@apple.com>
4339
4340         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4341         https://bugs.webkit.org/show_bug.cgi?id=194717
4342         <rdar://problem/47884404>
4343
4344         Reviewed by Brady Eidson.
4345
4346         Add API test coverage.
4347
4348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4349
4350 2019-02-15  Youenn Fablet  <youenn@apple.com>
4351
4352         Make navigator.mediaDevices SecureContext
4353         https://bugs.webkit.org/show_bug.cgi?id=194666
4354
4355         Reviewed by Eric Carlson.
4356
4357         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4358         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4359         (TEST_F):
4360
4361 2019-02-15  Brian Burg  <bburg@apple.com>
4362
4363         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4364         https://bugs.webkit.org/show_bug.cgi?id=194411
4365         <rdar://problem/47787614>
4366
4367         Reviewed by Joseph Pecoraro.
4368
4369         Remove unnecessary soft linking macro usage.
4370
4371         * DumpRenderTree/mac/TestRunnerMac.mm:
4372         (TestRunner::inspectorTestStubURL):
4373         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4374         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4375         (WTR::TestRunner::inspectorTestStubURL):
4376
4377 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4378
4379         Unreviewed, rolling out r241559 and r241566.
4380         https://bugs.webkit.org/show_bug.cgi?id=194710
4381
4382         Causes layout test crashes under GuardMalloc (Requested by
4383         ryanhaddad on #webkit).
4384
4385         Reverted changesets: