webkit-patch rebaseline-expectations doesn't work w/o failures specified
[WebKit-https.git] / Tools / ChangeLog
1 2012-10-09  Dirk Pranke  <dpranke@chromium.org>
2
3         webkit-patch rebaseline-expectations doesn't work w/o failures specified
4         https://bugs.webkit.org/show_bug.cgi?id=98810
5
6         Reviewed by Ojan Vafai.
7
8         If you try to mark a test as foo.html [ Rebaseline ] it wasn't
9         getting picked up for rebaselining; we needed to think the test
10         was failing.
11
12         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
13         (TestExpectations.get_rebaselining_failures):
14         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
15         (RebaseliningTest.test_get_rebaselining_failures):
16
17 2012-10-09  Daniel Bates  <dbates@webkit.org>
18
19         VCSUtils.pm doesn't support SVN 1.7 diff files
20         <https://bugs.webkit.org/show_bug.cgi?id=80762>
21
22         Reviewed by Eric Seidel.
23
24         Implement support for the SVN 1.7 diff format.
25
26         * Scripts/VCSUtils.pm:
27         (parseChunkRange): Modified to support parsing an SVN 1.7 chunk range
28         that begins and ends with "##" (e.g. ## -0,0 +1,7 ##). For comparison,
29         earlier versions of SVN parsed chunk ranges of the form "@@ -0,0 +1,7 @@".
30
31         (parseSvnDiffHeader): Modified to parse an SVN 1.7 binary diff; SVN 1.7
32         has an unusual display format for a binary diff. It repeats the first
33         two lines of the diff header.
34
35         (parseSvnProperty): Modified to ignore both an SVN 1.7 chunk range and
36         lines of the form "\ No newline at end of property". SVN 1.7 emits the latter
37         message after a property value that doesn't end in a newline.
38
39         (parseSvnPropertyValue): Stop parsing an SVN property value when we encounter
40         a line of the form "\ No newline at end of property" (emitted by svn diff as of
41         SVN 1.7).
42
43         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
44           - Added the following unit tests:
45           "Line count is 0"
46           "New line count is 1"
47
48         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
49           - Added the following unit tests:
50           "svn:executable followed by custom property using SVN 1.7 syntax"
51           "svn:executable followed by custom property without newline using SVN 1.7 syntax"
52
53         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
54           - Updated test results for test "binary file".
55           - Added unit test "binary file using SVN 1.7 syntax".
56
57         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
58           - Added the following unit tests:
59           "simple: add svn:executable using SVN 1.7 syntax"
60           "simple: delete svn:executable using SVN 1.7 syntax"
61           "add svn:mime-type and add svn:executable using SVN 1.7 syntax"
62
63         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
64           - Added the following unit tests:
65           "singe-line '+' change using SVN 1.7 syntax"
66           "single-line '-' change using SVN 1.7 syntax"
67
68 2012-10-09  James Robinson  <jamesr@chromium.org>
69
70         Unreviewed, rolling out r128488.
71         http://trac.webkit.org/changeset/128488
72         https://bugs.webkit.org/show_bug.cgi?id=96678
73
74         The bot is fixed now
75
76         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
77         (.):
78
79 2012-10-09  Zan Dobersek  <zandobersek@gmail.com>
80
81         XvfbDriver unit test is flaky on Linux builders
82         https://bugs.webkit.org/show_bug.cgi?id=98346
83
84         Reviewed by Adam Barth.
85
86         Temporarily skip the XvfbDriver test case that tests
87         the display number of the next free display. The test
88         is flaky on Linux builders.
89
90         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
91         (XvfbDriverTest.disabled_test_next_free_display):
92
93 2012-10-09  Ojan Vafai  <ojan@chromium.org>
94
95         Don't duplicated build numbers when merging flakiness dashboard JSON
96         https://bugs.webkit.org/show_bug.cgi?id=98812
97
98         Reviewed by Dirk Pranke.
99
100         In general, build numbers are not unique, but we should basically never
101         get the same build number uploaded twice in a row. This is a workaround
102         for https://bugs.webkit.org/show_bug.cgi?id=97643, which frequently hits this
103         because we update results_small.json and timeout updating results.json and then
104         we retry the whole request.
105
106         * TestResultServer/model/jsonresults.py:
107         (JsonResults.merge):
108         * TestResultServer/model/jsonresults_unittest.py:
109         (JsonResultsTest.test_merge_duplicate_build_number):
110
111 2012-10-09  Alexis Menard  <alexis@webkit.org>
112
113         [GTK] Shadow builds are not working anymore.
114         https://bugs.webkit.org/show_bug.cgi?id=98785
115
116         Reviewed by Martin Robinson.
117
118         When setting WEBKITOUTPUTDIR the build was failing with a python
119         error : the os.execve expect three arguments. Also the condition
120         to check whether we build the GTK port with jhbuild or not was buggy
121         as it was always assuming an in source build. We can use now jhbuildutils
122         which has a convenient function to locate the directory where 
123         the dependencies built with jhbuild are and take into account WEBKITOUTPUTDIR.
124         If the Dependencies path does not exist then the build was not done using
125         jhbuild so we can fallback to a regular build against system libraries.
126
127         * gtk/run-with-jhbuild:
128
129 2012-10-08  Simon Fraser  <simon.fraser@apple.com>
130
131         Remove DRT/WTR implementations of layerTreeAsText
132         https://bugs.webkit.org/show_bug.cgi?id=98697
133
134         Reviewed by Tim Horton, James Robinson, Alexey Proskuryakov.
135
136         Remove code related to layerTreeAsText(), which is now on window.internals.
137
138         * DumpRenderTree/TestRunner.cpp:
139         (TestRunner::staticFunctions):
140         * DumpRenderTree/TestRunner.h:
141         (TestRunner):
142         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
143         * DumpRenderTree/chromium/DRTTestRunner.cpp:
144         (DRTTestRunner::DRTTestRunner):
145         * DumpRenderTree/chromium/DRTTestRunner.h:
146         (DRTTestRunner):
147         * DumpRenderTree/efl/TestRunnerEfl.cpp:
148         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
149         * DumpRenderTree/mac/TestRunnerMac.mm:
150         * DumpRenderTree/qt/TestRunnerQt.cpp:
151         * DumpRenderTree/qt/TestRunnerQt.h:
152         (TestRunner):
153         * DumpRenderTree/win/TestRunnerWin.cpp:
154         * DumpRenderTree/wx/TestRunnerWx.cpp:
155         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
156         * WebKitTestRunner/InjectedBundle/TestRunner.h:
157
158 2012-10-09  Zoltan Horvath  <zoltan@webkit.org>
159
160         Unreviewed. Remove myself from QtWebKit2 subscriptions.
161
162         * Scripts/webkitpy/common/config/watchlist:
163
164 2012-10-09  Harald Alvestrand  <hta@google.com>
165
166         Change PeerConnection getStats function to single value local / remote
167         elements in RTCStatsReport.
168         https://bugs.webkit.org/show_bug.cgi?id=98753
169
170         Reviewed by Adam Barth.
171
172         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
173         (MockWebRTCPeerConnectionHandler::getStats):
174
175 2012-10-09  Sadrul Habib Chowdhury  <sadrul@chromium.org>
176
177         [chromium] Make sure events are transformed correctly for plugins.
178         https://bugs.webkit.org/show_bug.cgi?id=89250
179
180         Reviewed by Tony Chang.
181
182         Update the test plugin to print event details for mouse and gesture events.
183
184         * DumpRenderTree/chromium/TestWebPlugin.cpp:
185         (printEventDetails):
186
187 2012-10-09  Simon Hausmann  <simon.hausmann@digia.com>
188
189         Unreviewed trivial Qt build fix: Remove stray closing braces from r130758.
190
191         * qmake/mkspecs/features/features.prf:
192
193 2012-10-09  Simon Hausmann  <simon.hausmann@digia.com>
194
195         [Qt] Clean up Qt module detection
196
197         Reviewed by Tor Arne Vestbø.
198
199         Replace the use of MOBILITY_CONFIG (not supported anymore) with modern use of haveQtModule.
200
201         * qmake/mkspecs/features/features.prf:
202
203 2012-10-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
204
205         [GTK] Respect WEBKITOUTPUTDIR in run-with-jhbuild.
206         https://bugs.webkit.org/show_bug.cgi?id=98732
207
208         Reviewed by Gustavo Noronha Silva.
209
210         Follow-up to r113066: if the WEBKITOUTPUTDIR environment variable
211         was used when running update-webkitgtk-libs,
212         WebKitBuild/Dependencies will not exist, so we now check its
213         contents first and then fall back to WebKitBuild/.
214
215         * gtk/run-with-jhbuild:
216
217 2012-10-09  Zan Dobersek  <zandobersek@gmail.com>
218
219         Unreviewed GTK gardening.
220
221         Skipping the accept-policy test in TestCookieManager API test that's
222         currently failing. The test failure is covered by
223         https://bugs.webkit.org/show_bug.cgi?id=98738.
224
225         * Scripts/run-gtk-tests:
226         (TestRunner):
227
228 2012-10-09  Laszlo Gombos  <l.gombos@samsung.com>
229
230         [Qt] Remove redundant JAVASCRIPTCORE_JIT variable
231         https://bugs.webkit.org/show_bug.cgi?id=50000
232
233         Reviewed by Simon Hausmann.
234
235         Use ENABLE_JIT instead.
236
237         * qmake/mkspecs/features/valgrind.prf:
238
239 2012-10-08  Kiran Muppala  <cmuppala@apple.com>
240
241         Throttle DOM timers on hidden pages.
242         https://bugs.webkit.org/show_bug.cgi?id=98474
243
244         Reviewed by Maciej Stachowiak.
245
246         Implement testRunner.setPageVisibility on mac for testing throttling
247         of timers on hidden pages using DumpRenderTree.
248
249         * DumpRenderTree/mac/Configurations/Base.xcconfig:
250         Fix build error on mac-ews bot.  Add JSC copy of ICU headers to search path.
251
252         * DumpRenderTree/mac/TestRunnerMac.mm:
253         (TestRunner::resetPageVisibility):
254         (TestRunner::setPageVisibility):
255
256 2012-10-08  Dirk Pranke  <dpranke@chromium.org>
257
258         results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
259         https://bugs.webkit.org/show_bug.cgi?id=98706
260
261         Reviewed by Ojan Vafai.
262
263         FAIL is supposed to map onto Failure which is supposed to map
264         onto the old [ TEXT, IMAGE_PLUS_TEXT, AUDIO ] mapping.
265         results.html was including IMAGE in this and garden-o-matic was
266         including CRASH and TIMEOUT as well :(.
267
268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
270
271 2012-10-08  Ryuan Choi  <ryuan.choi@samsung.com>
272
273         [EFL] Build ControlTheme only when necessary
274         https://bugs.webkit.org/show_bug.cgi?id=98519
275
276         Reviewed by Eric Seidel.
277
278         * EWebLauncher/ControlTheme/CMakeLists.txt:
279         Added custom command keyword not to build ControlTheme every time.
280         In addition, removed `ALL` keyword because targets, which use ControlTheme,
281         already have dependency.
282
283 2012-10-08  Peter Rybin  <peter.rybin@gmail.com>
284
285         Do not swallow fatal messages in qt/DumpRenderTree
286         https://bugs.webkit.org/show_bug.cgi?id=98211
287
288         Reviewed by Eric Seidel.
289
290         Fix condition in message type filtering.
291
292         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
293         (messageHandler):
294
295 2012-10-08  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
296
297         Unreviewed. Moving myself from Committer to Reviewer list.
298         http://lists.webkit.org/pipermail/webkit-dev/2012-October/022460.html
299
300         * Scripts/webkitpy/common/config/committers.py:
301
302 2012-10-08  Dirk Pranke  <dpranke@chromium.org>
303
304         nrwt: [chromium] run http tests in parallel on bigger machines
305         https://bugs.webkit.org/show_bug.cgi?id=98562
306
307         Reviewed by Eric Seidel.
308
309         The "locked tests" shard (which includes the http tests and the
310         perf tests) is the long pole on machines where we have 4 or more
311         workers, so we should start making sure that
312         we can run http tests in parallel, following the normal sharding
313         rules (all tests in the same directory are in the same shard by
314         default). We should still probably limit the number of workers
315         hitting the web server in parallel where we can; a heuristic of
316         no more than 25% of them seems okay for a start. This will
317         likely only affect developer workstations and a couple of bots
318         at first, so should be low risk and a good reward.
319
320         * Scripts/webkitpy/layout_tests/port/base.py:
321         (Port.default_max_locked_shards):
322         * Scripts/webkitpy/layout_tests/port/chromium.py:
323         (ChromiumPort.default_max_locked_shards):
324         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
325         (ChromiumPortTestCase.test_default_max_locked_shards):
326         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
327         (PortTestCase.test_default_max_locked_shards):
328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
329         (_set_up_derived_options):
330         (parse_args):
331         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
332         (MainTest.test_max_locked_shards):
333
334 2012-10-08  Zan Dobersek  <zandobersek@gmail.com>
335
336         GTK port should warn if bug modifier is missing in TestExpectations
337         https://bugs.webkit.org/show_bug.cgi?id=98678
338
339         Reviewed by Dirk Pranke.
340
341         Reimplement the warn_if_bug_missing_in_test_expectations method in
342         GtkPort, returning True for producing a warning in such cases.
343
344         * Scripts/webkitpy/layout_tests/port/gtk.py:
345         (GtkPort.warn_if_bug_missing_in_test_expectations):
346
347 2012-10-08  Ryuan Choi  <ryuan.choi@samsung.com>
348
349         [EFL][DRT] Switch default backing store to single
350         https://bugs.webkit.org/show_bug.cgi?id=98591
351
352         Reviewed by Eric Seidel.
353
354         There are two backing stores for WebKit/Efl, Single Backing Store(SBS) and
355         Tiled Backing Store(TBS), and DRT/Efl has used TBS.
356         But, TBS is not suitable to run pixel tests because it does not have a good way
357         to render mock scrollbars well.
358
359         So, this patch changes the default backing store to SBS.
360         In addition, this changes the environment variable from DRT_USE_SINGLE_BACKING_STORE
361         to DRT_USE_TILED_BACKING_STORE.
362
363         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
364         (shouldUseTiledBackingStore):
365         (chooseAndInitializeAppropriateSmartClass):
366
367 2012-10-08  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
368
369         [WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
370         https://bugs.webkit.org/show_bug.cgi?id=98638
371
372         Reviewed by Eric Seidel.
373
374         Add implementation for testRunner.dispatchPendingLoadRequests in
375         WebKitTestRunner.
376
377         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
378         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
379         (WTR::TestRunner::dispatchPendingLoadRequests):
380         (WTR):
381         * WebKitTestRunner/InjectedBundle/TestRunner.h:
382         (TestRunner):
383
384 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
385
386         [EFL][WK2] Add support for window.close in Minibrowser
387         https://bugs.webkit.org/show_bug.cgi?id=98667
388
389         Reviewed by Laszlo Gombos.
390
391         When calling window.close() from JavaScript, MiniBrowser
392         now closes the given window.
393
394         * MiniBrowser/efl/main.c:
395         (window_close):
396         (on_ecore_evas_delete):
397         (on_close_window):
398         (window_create):
399
400 2012-10-08  Ojan Vafai  <ojan@chromium.org>
401
402         Properly strip new tests from the test results json if they are pass/nodata/skip.
403         https://bugs.webkit.org/show_bug.cgi?id=98669
404
405         Reviewed by Eric Seidel.
406
407         In _merge_json, we had a codepath that didn't call _normalize_results_json
408         for tests that aren't already in the aggregated results.
409         Instead, now do all the merging first and then normalize the aggregated results.
410
411         * TestResultServer/model/jsonresults.py:
412         (JsonResults._merge_json):
413         (JsonResults._merge_tests):
414         (JsonResults._normalize_results):
415         (JsonResults):
416         (JsonResults._should_delete_leaf):
417         * TestResultServer/model/jsonresults_unittest.py:
418         Removed test_merge_build_directory_hierarchy_old_version since there is
419         no longer any version 3 json to support.
420         (JsonResultsTest.test_merge_remove_new_test):
421         (JsonResultsTest.test_merge_prune_extra_results_with_new_result_of_same_type):
422
423 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
424
425         [EFL][WK2] Simplify frame flattening support in MiniBrowser
426         https://bugs.webkit.org/show_bug.cgi?id=98657
427
428         Reviewed by Kenneth Rohde Christiansen.
429
430         Simplify frame flattening support code in MiniBrowser to
431         avoid passing the setting around to window_create()
432         function().
433
434         * MiniBrowser/efl/main.c:
435         (on_key_down):
436         (on_new_window):
437         (window_create):
438         (main):
439
440 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
441
442         [EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
443         https://bugs.webkit.org/show_bug.cgi?id=98655
444
445         Reviewed by Kenneth Rohde Christiansen.
446
447         Use "Ctrl+n" shortcut instead of "F9" to open a new window in
448         MiniBrowser and EWebLauncher. This is the shortcut that is
449         commonly used for this action.
450
451         * EWebLauncher/main.c:
452         (on_key_down):
453         * MiniBrowser/efl/main.c:
454         (on_key_down):
455
456 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
457
458         [EFL][WK2] Add support for window.create in Minibrowser
459         https://bugs.webkit.org/show_bug.cgi?id=98649
460
461         Reviewed by Kenneth Rohde Christiansen.
462
463         Calling window.create() from JavaScript now creates a
464         new window in Minibrowser, as directed.
465
466         * MiniBrowser/efl/main.c:
467         (on_new_window):
468         (window_create):
469
470 2012-10-08  Andreas Kling  <kling@webkit.org>
471
472         Using float/double as WTF hash table key is unreliable.
473         <http://webkit.org/b/98627>
474
475         Reviewed by Geoffrey Garen.
476
477         Add a test case checking that using double as the hash table key type won't
478         have problems distinguishing between keys that are considered equal by operator==
479         but have different binary representations.
480
481         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
482         (TestDoubleHashTraits):
483
484 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
485
486         [EFL][WK2] Use URL instead of URI in the API
487         https://bugs.webkit.org/show_bug.cgi?id=98643
488
489         Reviewed by Kenneth Rohde Christiansen.
490
491         Update Minibrowser to reflect API changes. We now
492         use URL instead of URI in WK2 EFL API.
493
494         * EWebLauncher/url_bar.c:
495         (on_urlbar_key_down):
496         * MiniBrowser/efl/CMakeLists.txt:
497         * MiniBrowser/efl/main.c:
498         (on_url_changed):
499         (window_create):
500
501 2012-10-08  Balazs Kelemen  <kbalazs@webkit.org>
502
503         [Qt] Reenable plugin tests
504         https://bugs.webkit.org/show_bug.cgi?id=98528
505
506         Reviewed by Csaba Osztrogonác.
507
508         Uncomment this function so we can pick up the test plugin.
509         It was commented out because of https://bugs.webkit.org/show_bug.cgi?id=86620
510         and that bug seems to be fixed now.
511
512         * WebKitTestRunner/qt/TestControllerQt.cpp:
513         (WTR::TestController::initializeTestPluginDirectory):
514
515 2012-10-08  Jinwoo Song  <jinwoo7.song@samsung.com>
516
517         [EFL][WK2] Support multiple window creation for MiniBrowser
518         https://bugs.webkit.org/show_bug.cgi?id=97884
519
520         Reviewed by Kenneth Rohde Christiansen.
521
522         Implement the multiple window creation for MiniBrowser and bind the 'F9' key for opening a new window.
523         Also, refactored MiniBrowser codes according to EFL coding style.
524
525         * MiniBrowser/efl/main.c:
526         (_Browser_Window):
527         (window_free):
528         (main_signal_exit):
529         (on_ecore_evas_delete):
530         (on_ecore_evas_resize):
531         (on_key_down):
532         (on_title_changed):
533         (on_url_changed):
534         (on_progress):
535         (window_create):
536         (main):
537
538 2012-10-07  Seokju Kwon  <seokju.kwon@samsung.com>
539
540         [EFL] Add Web Inspector to EWebLauncher
541         https://bugs.webkit.org/show_bug.cgi?id=91718
542
543         Reviewed by Gyuyoung Kim.
544
545         Implementation of Web Inspector in EWebLauncher.
546         The Web Inspector can be opened or closed by pressing ctrl+i on web page.
547
548         * EWebLauncher/main.c:
549         (on_browser_ecore_evas_resize):
550         (on_web_inspector_ecore_evas_resize):
551         (on_key_down):
552         (on_web_inspector_view_create):
553         (on_web_inspector_view_close):
554         (on_web_inspector_view_destroyed):
555         (browserCreate):
556         (webInspectorCreate):
557         (windowCreate):
558         (closeWindow):
559         (main_signal_exit):
560         (parseUserArguments):
561
562 2012-10-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
563
564         Rename first/second to key/value in HashMap iterators
565         https://bugs.webkit.org/show_bug.cgi?id=82784
566
567         Reviewed by Eric Seidel.
568
569         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
570         (MockWebSpeechInputController::addMockRecognitionResult):
571         * DumpRenderTree/chromium/NotificationPresenter.cpp:
572         (NotificationPresenter::simulateClick):
573         (NotificationPresenter::show):
574         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
575         (CppBoundClass::~CppBoundClass):
576         (CppBoundClass::invoke):
577         (CppBoundClass::getProperty):
578         (CppBoundClass::setProperty):
579         (CppBoundClass::bindCallback):
580         (CppBoundClass::bindProperty):
581         * DumpRenderTree/chromium/WebPreferences.cpp:
582         (applyFontMap):
583         * DumpRenderTree/chromium/WebViewHost.cpp:
584         (WebViewHost::printResourceDescription):
585         * DumpRenderTree/mac/TestRunnerMac.mm:
586         (worldIDForWorld):
587         (TestRunner::evaluateScriptInIsolatedWorld):
588         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
589         (AccessibilityController::~AccessibilityController):
590         (AccessibilityController::winNotificationReceived):
591         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
592         (ResourceLoadDelegate::descriptionSuitableForTestResult):
593         * DumpRenderTree/win/TestRunnerWin.cpp:
594         (worldIDForWorld):
595         (TestRunner::evaluateScriptInIsolatedWorld):
596         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
597         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
598         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
599         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
600         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
601         (WTR::TestRunner::worldIDForWorld):
602         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
603
604 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
605
606         Unreviewed, rolling out r130596.
607         http://trac.webkit.org/changeset/130596
608         https://bugs.webkit.org/show_bug.cgi?id=98616
609
610         Broke build bots without IPV6 support
611
612         * Scripts/webkitpy/common/system/platforminfo_mock.py:
613         (MockPlatformInfo.is_cygwin):
614         * Scripts/webkitpy/layout_tests/port/base.py:
615         (Port.baseline_version_dir):
616         (Port.to.start_websocket_server):
617         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
618         (PortTest.test_operating_system):
619         (PortTest.test_build_path):
620         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
621         (LayoutTestApacheHttpd):
622         (LayoutTestApacheHttpd.__init__):
623
624 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
625
626         webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files.
627         https://bugs.webkit.org/show_bug.cgi?id=98602
628
629         Reviewed by Eric Seidel.
630
631         Unify all the different `Listen' directives present in the several
632         httpd.conf files we have in LayoutTests/http/conf. For one, we
633         were already passing `Listen 127.0.0.1:8000' via webkitpy before,
634         and opening the other ports from the conf files.
635
636         The configuration files differed mostly in the way they handled
637         IPV6 ports. Some of them did not listen to IPV6 ports because the
638         systems which used them sometimes did not have IPV6 support. The
639         `http_server_supports_ipv6' method has been added to Port to
640         address that. cygwin, on its turn, still seems to use Apache 1.3,
641         which does not support IPV6 at all; the newly-added method has a
642         special case for that.
643
644         * Scripts/webkitpy/common/system/platforminfo_mock.py:
645         (MockPlatformInfo.is_cygwin):
646         * Scripts/webkitpy/layout_tests/port/base.py:
647         (Port.baseline_version_dir):
648         (Port.to.start_websocket_server):
649         (Port.to):
650         (Port.to.http_server_supports_ipv6):
651         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
652         (PortTest.test_http_server_supports_ipv6):
653         (PortTest.test_build_path):
654         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
655         (LayoutTestApacheHttpd):
656         (LayoutTestApacheHttpd.__init__):
657
658 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
659
660         Attempt to fix the SnowLeopard build to making the implementation of
661         -isPaginated come before its use.
662
663         * MiniBrowser/mac/WK1BrowserWindowController.m:
664         (-[WK1BrowserWindowController reload:]):
665         (-[WK1BrowserWindowController forceRepaint:]):
666         (-[WK1BrowserWindowController goBack:]):
667         (-[WK1BrowserWindowController goForward:]):
668         (-[WK1BrowserWindowController isPaginated]):
669
670 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
671
672         Provide a way to run WebKit1
673         https://bugs.webkit.org/show_bug.cgi?id=98568
674
675         Reviewed by Tim Horton.
676
677         Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.
678         
679         Turn BrowserWindowController into a base class; subclassed by
680         WK1BrowserWindowController and WK2BrowserWindowController, each of
681         which implement the BrowserController protocol.
682         
683         Use Command-N to get a WebKit1 window, and Command-Option-N to
684         get a WK2 window. Also add "Open Location" to focus the URL bar,
685         and code to add an http:// if missing.
686         
687         Hook up window title callbacks; append " [WK1/2]" to window title
688         as appropriate.
689
690         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
691         * MiniBrowser/mac/AppDelegate.m:
692         (-[BrowserAppDelegate newWindow:]):
693         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
694         * MiniBrowser/mac/BrowserWindowController.h:
695         * MiniBrowser/mac/BrowserWindowController.m:
696         (-[BrowserWindowController initWithWindow:]):
697         (-[BrowserWindowController windowDidLoad]):
698         (-[BrowserWindowController openLocation:]):
699         (-[BrowserWindowController loadURLString:]):
700         (-[BrowserWindowController applicationTerminating]):
701         (-[BrowserWindowController addProtocolIfNecessary:]):
702         * MiniBrowser/mac/MainMenu.xib:
703         * MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
704         (WebView):
705         * MiniBrowser/mac/WK1BrowserWindowController.m: Added.
706         (-[WK1BrowserWindowController awakeFromNib]):
707         (-[WK1BrowserWindowController dealloc]):
708         (-[WK1BrowserWindowController loadURLString:]):
709         (-[WK1BrowserWindowController fetch:]):
710         (-[WK1BrowserWindowController showHideWebView:]):
711         (-[WK1BrowserWindowController removeReinsertWebView:]):
712         (-[WK1BrowserWindowController validateMenuItem:]):
713         (-[WK1BrowserWindowController reload:]):
714         (-[WK1BrowserWindowController forceRepaint:]):
715         (-[WK1BrowserWindowController goBack:]):
716         (-[WK1BrowserWindowController goForward:]):
717         (-[WK1BrowserWindowController validateUserInterfaceItem:]):
718         (-[WK1BrowserWindowController validateToolbar]):
719         (-[WK1BrowserWindowController windowShouldClose:]):
720         (-[WK1BrowserWindowController windowWillClose:]):
721         (-[WK1BrowserWindowController applicationTerminating]):
722         (-[WK1BrowserWindowController currentZoomFactor]):
723         (-[WK1BrowserWindowController canZoomIn]):
724         (-[WK1BrowserWindowController zoomIn:]):
725         (-[WK1BrowserWindowController canZoomOut]):
726         (-[WK1BrowserWindowController zoomOut:]):
727         (-[WK1BrowserWindowController canResetZoom]):
728         (-[WK1BrowserWindowController resetZoom:]):
729         (-[WK1BrowserWindowController toggleZoomMode:]):
730         (-[WK1BrowserWindowController isPaginated]):
731         (-[WK1BrowserWindowController togglePaginationMode:]):
732         (-[WK1BrowserWindowController find:]):
733         (-[WK1BrowserWindowController dumpSourceToConsole:]):
734         (-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
735         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
736         * MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
737         * MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.
738         (-[WK2BrowserWindowController initWithContext:pageGroup:]):
739         (-[WK2BrowserWindowController dealloc]):
740         (-[WK2BrowserWindowController fetch:]):
741         (-[WK2BrowserWindowController showHideWebView:]):
742         (-[WK2BrowserWindowController removeReinsertWebView:]):
743         (-[WK2BrowserWindowController validateMenuItem:]):
744         (-[WK2BrowserWindowController reload:]):
745         (-[WK2BrowserWindowController forceRepaint:]):
746         (-[WK2BrowserWindowController goBack:]):
747         (-[WK2BrowserWindowController goForward:]):
748         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
749         (-[WK2BrowserWindowController validateToolbar]):
750         (-[WK2BrowserWindowController windowShouldClose:]):
751         (-[WK2BrowserWindowController windowWillClose:]):
752         (-[WK2BrowserWindowController applicationTerminating]):
753         (-[WK2BrowserWindowController currentZoomFactor]):
754         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
755         (-[WK2BrowserWindowController canZoomIn]):
756         (-[WK2BrowserWindowController zoomIn:]):
757         (-[WK2BrowserWindowController canZoomOut]):
758         (-[WK2BrowserWindowController zoomOut:]):
759         (-[WK2BrowserWindowController canResetZoom]):
760         (-[WK2BrowserWindowController resetZoom:]):
761         (-[WK2BrowserWindowController toggleZoomMode:]):
762         (-[WK2BrowserWindowController isPaginated]):
763         (-[WK2BrowserWindowController togglePaginationMode:]):
764         (-[WK2BrowserWindowController dumpSourceToConsole:]):
765         (didStartProvisionalLoadForFrame):
766         (didReceiveServerRedirectForProvisionalLoadForFrame):
767         (didFailProvisionalLoadWithErrorForFrame):
768         (didCommitLoadForFrame):
769         (didFinishDocumentLoadForFrame):
770         (didFinishLoadForFrame):
771         (didFailLoadWithErrorForFrame):
772         (didSameDocumentNavigationForFrame):
773         (didReceiveTitleForFrame):
774         (didFirstLayoutForFrame):
775         (didFirstVisuallyNonEmptyLayoutForFrame):
776         (didRemoveFrameFromHierarchy):
777         (didDisplayInsecureContentForFrame):
778         (didRunInsecureContentForFrame):
779         (didDetectXSSForFrame):
780         (didStartProgress):
781         (didChangeProgress):
782         (didFinishProgress):
783         (didBecomeUnresponsive):
784         (didBecomeResponsive):
785         (processDidExit):
786         (didChangeBackForwardList):
787         (decidePolicyForNavigationAction):
788         (decidePolicyForNewWindowAction):
789         (decidePolicyForResponse):
790         (createNewPage):
791         (showPage):
792         (closePage):
793         (runJavaScriptAlert):
794         (runJavaScriptConfirm):
795         (runJavaScriptPrompt):
796         (setStatusText):
797         (mouseDidMoveOverElement):
798         (getWindowFrame):
799         (setWindowFrame):
800         (runBeforeUnloadConfirmPanel):
801         (runOpenPanel):
802         (-[WK2BrowserWindowController awakeFromNib]):
803         (-[WK2BrowserWindowController didStartProgress]):
804         (-[WK2BrowserWindowController didChangeProgress:]):
805         (-[WK2BrowserWindowController didFinishProgress]):
806         (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
807         (-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
808         (-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
809         (-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
810         (-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
811         (-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
812         (-[WK2BrowserWindowController didCommitLoadForFrame:]):
813         (-[WK2BrowserWindowController loadURLString:]):
814         (-[WK2BrowserWindowController performFindPanelAction:]):
815         (-[WK2BrowserWindowController find:]):
816
817 2012-10-05  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
818
819         [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
820         https://bugs.webkit.org/show_bug.cgi?id=98524
821
822         Reviewed by Alexey Proskuryakov.
823
824         Add implementation for testRunner.setSerializeHTTPLoads in
825         WebKitTestRunner.
826
827         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
828         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
829         (WTR::InjectedBundle::beginTesting):
830         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
831         (WTR::TestRunner::setSerializeHTTPLoads):
832         (WTR):
833         * WebKitTestRunner/InjectedBundle/TestRunner.h:
834         (TestRunner):
835
836 2012-10-05  Richard Larocque  <rlarocque@chromium.org>
837
838         TestResultsServer does not display sync_integration_tests results
839         https://bugs.webkit.org/show_bug.cgi?id=98551
840
841         Reviewed by Ojan Vafai.
842
843         Allow builders whose name contains "Sync" to pass through the
844         isChromiumWebkitDepsTestRunner filter.
845
846         The test expectations in flakiness_dashboard_unittests.js have been
847         updated to match the new behaviour.
848
849         * TestResultServer/static-dashboards/builders.js:
850         (isChromiumDepsGTestRunner):
851
852 2012-10-05  Roger Fong  <roger_fong@apple.com>
853
854         Tests in webkitpy involving child processes are flaky. 
855         Skipping run_webkit_tests_integrationtest.py.
856         https://bugs.webkit.org/show_bug.cgi?id=98559
857
858         Reviewed by Dirk Pranke.
859
860         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
861         (MainTest.test_verbose_in_child_processes):
862
863 2012-10-05  Zan Dobersek  <zandobersek@gmail.com>
864
865         [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
866         https://bugs.webkit.org/show_bug.cgi?id=91009
867
868         Reviewed by Martin Robinson.
869
870         Include libxml2 into the jhbuild module. Version 2.8.0 introduces
871         a more correct (but not completely correct) behavior in the
872         fast/xsl/xslt-missing-namespace-in-xslt.html test.
873
874         * gtk/jhbuild.modules:
875
876 2012-10-05  Rob Buis  <rbuis@rim.com>
877
878         [BlackBerry] Implement TestRunner.setMockDeviceOrientation
879         https://bugs.webkit.org/show_bug.cgi?id=98542
880
881         Reviewed by Antonio Gomes.
882
883         PR 120681
884
885         This fixes tests in fast/dom/DeviceOrientation.
886
887         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
888         (TestRunner::setMockDeviceOrientation):
889
890 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
891
892         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
893         https://bugs.webkit.org/show_bug.cgi?id=98256
894
895         Reviewed by Kenneth Rohde Christiansen.
896
897         Implement UIClient's focus callbacks for the main page in
898         WebKitTestRunner.
899
900         * WebKitTestRunner/TestController.cpp:
901         (WTR::focus):
902         (WTR::TestController::initialize):
903
904 2012-10-05  Mark Hahnenberg  <mhahnenberg@apple.com>
905
906         JSC should have a way to gather and log Heap memory use and pause times
907         https://bugs.webkit.org/show_bug.cgi?id=98431
908
909         Reviewed by Geoffrey Garen.
910
911         * DumpRenderTree/mac/DumpRenderTree.mm:
912         (main): Added a check as to whether we should dump our JSC Heap statistics on exit.
913
914 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
915
916         [EFL][WK2] Fix mktemp() compilation warning in Minibrowser
917         https://bugs.webkit.org/show_bug.cgi?id=98493
918
919         Reviewed by Kenneth Rohde Christiansen.
920
921         Fix wrong mktemp usage causing a compilation warning
922         in MiniBrowser.
923
924         * MiniBrowser/efl/main.c:
925         (on_download_request):
926
927 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
928
929         [WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
930         https://bugs.webkit.org/show_bug.cgi?id=98503
931
932         Reviewed by Kenneth Rohde Christiansen.
933
934         Avoid the need for duplicating UIClient callbacks for main page
935         and other pages by passing the view as clientInfo
936         for those callbacks.
937
938         Previously, callbacks for the main page were passed the
939         TestController as clientInfo while the callbacks for other pages
940         were passed the PlatformWebView as clientInfo. This was error prone
941         and leads to useless code duplication.
942
943         * WebKitTestRunner/TestController.cpp:
944         (WTR::getWindowFrame):
945         (WTR::setWindowFrame):
946         (WTR::runBeforeUnloadConfirmPanel):
947         (WTR::TestController::createOtherPage):
948         (WTR::TestController::initialize):
949         (WTR::TestController::decidePolicyForNotificationPermissionRequest):
950
951 2012-10-05  Sadrul Habib Chowdhury  <sadrul@chromium.org>
952
953         [chromium] Allow dragging into plugins.
954         https://bugs.webkit.org/show_bug.cgi?id=98277
955
956         Reviewed by Tony Chang.
957
958         Update the TestWebPlugin to receive drag events and print them out.
959
960         * DumpRenderTree/chromium/TestWebPlugin.cpp:
961         (TestWebPlugin::handleDragStatusUpdate):
962         * DumpRenderTree/chromium/TestWebPlugin.h:
963         (TestWebPlugin):
964
965 2012-10-05  Jongseok Yang  <js45.yang@samsung.com>
966
967         [EFL][WK2] Remove "web" word from ewk_web_error APIs
968         https://bugs.webkit.org/show_bug.cgi?id=97886
969
970         Reviewed by Gyuyoung Kim.
971
972         Remove "web" word from ewk_web_error APIs.
973         "web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.
974
975         * MiniBrowser/efl/main.c:
976         (on_error):
977
978 2012-10-05  Csaba Osztrogonác  <ossy@webkit.org>
979
980         [Qt] Enable CSS compositing by default
981         https://bugs.webkit.org/show_bug.cgi?id=98490
982
983         Reviewed by Simon Hausmann.
984
985         * qmake/mkspecs/features/features.pri:
986
987 2012-10-05  Sheriff Bot  <webkit.review.bot@gmail.com>
988
989         Unreviewed, rolling out r130466.
990         http://trac.webkit.org/changeset/130466
991         https://bugs.webkit.org/show_bug.cgi?id=98495
992
993         It made 12 tests crash on Qt-WK2 (Requested by Ossy on
994         #webkit).
995
996         * WebKitTestRunner/TestController.cpp:
997         (WTR::focus):
998         (WTR::TestController::initialize):
999
1000 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
1001
1002         [EFL] Fix window resizing / moving in WK1 and WKTR
1003         https://bugs.webkit.org/show_bug.cgi?id=98486
1004
1005         Reviewed by Gyuyoung Kim.
1006
1007         Fix PlatformWebView::windowFrame() and
1008         PlatformWebView::setWindowFrame() in EFL's WKTR so
1009         that it resizes / moves the window, not the view.
1010
1011         The new code matches the implementation in EwkView's
1012         UIClient.
1013
1014         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1015         (WTR::PlatformWebView::windowFrame):
1016         (WTR::PlatformWebView::setWindowFrame):
1017
1018 2012-10-04  KyungTae Kim  <ktf.kim@samsung.com>
1019
1020         [EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
1021         https://bugs.webkit.org/show_bug.cgi?id=98334
1022
1023         Reviewed by Gyuyoung Kim.
1024
1025         Add callback functions for download requests to Minibrowser to set the destination path for download.
1026         Set the destination path with suggested file name as (destination folder) + (suggested file name).
1027         The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.
1028
1029         Additionally, for printing out the download status, 
1030         use the info macro and set the verbose variable to 1 to enable it.
1031
1032         * MiniBrowser/efl/main.c:
1033         (on_download_request):
1034         (on_download_finished):
1035         (on_download_failed):
1036         (browserCreate):
1037
1038 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1039
1040         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
1041         https://bugs.webkit.org/show_bug.cgi?id=98256
1042
1043         Reviewed by Kenneth Rohde Christiansen.
1044
1045         Implement UIClient's focus callbacks in WebKitTestRunner.
1046
1047         * WebKitTestRunner/TestController.cpp:
1048         (WTR::focus):
1049         (WTR::TestController::initialize):
1050
1051 2012-10-04  Rik Cabanier  <cabanier@adobe.com>
1052
1053         Turn Compositing on by default in WebKit build
1054         https://bugs.webkit.org/show_bug.cgi?id=98315
1055
1056         Reviewed by Simon Fraser.
1057
1058         enable -webkit-blend-mode on trunk.
1059
1060         * Scripts/webkitperl/FeatureList.pm:
1061
1062 2012-10-04  Ryuan Choi  <ryuan.choi@samsung.com>
1063
1064         [EFL][WK2] Add APIs to get/set the frame flattening.
1065         https://bugs.webkit.org/show_bug.cgi?id=95982
1066
1067         Reviewed by Gyuyoung Kim.
1068
1069         * MiniBrowser/efl/main.c: Added frame flattening option to test.
1070         (browserCreate):
1071         (main):
1072
1073 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1074
1075         [EFL] Add libxml 2.8.0 to jhbuild
1076         https://bugs.webkit.org/show_bug.cgi?id=98418
1077
1078         Reviewed by Laszlo Gombos.
1079
1080         Add libxml 2.8.0 to EFL's jhbuild for consistency.
1081
1082         * efl/jhbuild.modules:
1083
1084 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
1085
1086         [WK2] Support all attributes of GeolocationPosition
1087         https://bugs.webkit.org/show_bug.cgi?id=98212
1088
1089         Reviewed by Sam Weinig.
1090
1091         Expand WebKitTestRunner and DumpRenderTree to test all the attributes
1092         of GeolocationPosition.
1093
1094         * DumpRenderTree/TestRunner.cpp:
1095         (setMockGeolocationPositionCallback):
1096         * DumpRenderTree/TestRunner.h:
1097         (TestRunner):
1098         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1099         (TestRunner::setMockGeolocationPosition):
1100         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1101         (TestRunner::setMockGeolocationPosition):
1102         * DumpRenderTree/mac/TestRunnerMac.mm:
1103         (TestRunner::setMockGeolocationPosition):
1104         * DumpRenderTree/win/TestRunnerWin.cpp:
1105         (TestRunner::setMockGeolocationPosition):
1106         * DumpRenderTree/wx/TestRunnerWx.cpp:
1107         (TestRunner::setMockGeolocationPosition):
1108         * WebKitTestRunner/GeolocationProviderMock.cpp:
1109         (WTR::GeolocationProviderMock::setPosition):
1110         * WebKitTestRunner/GeolocationProviderMock.h:
1111         (GeolocationProviderMock):
1112         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1113         (_platformTypeVariableDeclaration):
1114         Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
1115         to build the pointer outself.
1116         This is necessary to support optional JSValueRef properly.
1117
1118         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1119         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1120         (WTR::InjectedBundle::setMockGeolocationPosition):
1121         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1122         (InjectedBundle):
1123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1124         (WTR::TestRunner::setMockGeolocationPosition):
1125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1126         (TestRunner):
1127         * WebKitTestRunner/TestController.cpp:
1128         (WTR::TestController::setMockGeolocationPosition):
1129         * WebKitTestRunner/TestController.h:
1130         (TestController):
1131         * WebKitTestRunner/TestInvocation.cpp:
1132         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1133
1134 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1135
1136         Make the Xvfb driver recognize `X' as a valid X server binary.
1137         https://bugs.webkit.org/show_bug.cgi?id=98434
1138
1139         Reviewed by Dirk Pranke.
1140
1141         The X server binary can also be called `X', so account for that
1142         possibility in the _next_free_display regexp.
1143
1144         Additionally, make the regular expression require at least one
1145         space character after the `ps comm' part.
1146
1147         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1148         (XvfbDriver._next_free_display):
1149         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1150         (XvfbDriverTest.test_next_free_display):
1151
1152 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1153
1154         webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
1155         https://bugs.webkit.org/show_bug.cgi?id=98436
1156
1157         Reviewed by Dirk Pranke.
1158
1159         The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
1160         the environment for the server process, and the WEBKITOUTPUTDIR
1161         environment variable was not being passed through, causing the
1162         build directory to be wrongfully set to WebKitBuild/ all the time.
1163
1164         * Scripts/webkitpy/layout_tests/port/base.py:
1165         (Port.to.setup_environ_for_server):
1166
1167 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1168
1169         [EFL][WK2] Add setting to allow file access from file:// URLs
1170         https://bugs.webkit.org/show_bug.cgi?id=98121
1171
1172         Reviewed by Laszlo Gombos.
1173
1174         Allow file access from file:// URLs by default in Minibrowser
1175         to facilitate testing.
1176
1177         * MiniBrowser/efl/main.c:
1178         (browserCreate):
1179
1180 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1181
1182         [EFL] Run unit tests with Xvfb
1183         https://bugs.webkit.org/show_bug.cgi?id=98389
1184
1185         Reviewed by Laszlo Gombos.
1186
1187         Run EFL unit tests with Xvfb, similarly to GTK port.
1188
1189         * Scripts/run-efl-tests:
1190
1191 2012-10-04  Adrian Perez de Castro  <aperez@igalia.com>
1192
1193         [GTK] Enable inspector by default in GtkLauncher/MiniBrowser
1194         https://bugs.webkit.org/show_bug.cgi?id=98333
1195
1196         Reviewed by Xan Lopez.
1197
1198         Both MiniBrowser and GtkLauncher are tools for testing, so in
1199         the end every time we want to test the inspector we have to
1200         manually enable enable the “developer extras” setting when using
1201         them. It make sense to have this setting enabled by default.
1202
1203         * GtkLauncher/main.c:
1204         (main):
1205         * MiniBrowser/gtk/main.c:
1206         (main):
1207
1208 2012-10-04  Harald Alvestrand  <hta@google.com>
1209
1210         Change RTCPeerConnection GetStats to use Date timestamp format
1211         https://bugs.webkit.org/show_bug.cgi?id=98263
1212
1213         Reviewed by Yury Semikhatsky.
1214
1215         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1216         (MockWebRTCPeerConnectionHandler::getStats):
1217
1218 2012-10-04  Dirk Pranke  <dpranke@chromium.org>
1219
1220         [NRWT] --skipped option is ignored when --test-list is used
1221         https://bugs.webkit.org/show_bug.cgi?id=98260
1222
1223         Reviewed by Ojan Vafai.
1224
1225         Adds a --skipped=always flag that will skip any tests listed in
1226         TestExpectations even if they're listed explicitly on the
1227         command line.
1228
1229         This is most useful if you are using --test-list to specify a
1230         long list of files but you still want to skip some of them
1231         depending on what's in TestExpectations.
1232
1233         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1234         (LayoutTestFinder.skip_tests):
1235         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1236         (parse_args):
1237         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1238         (MainTest.test_skipped_flag):
1239
1240 2012-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1241
1242         Unreviewed, rolling out r130377.
1243         http://trac.webkit.org/changeset/130377
1244         https://bugs.webkit.org/show_bug.cgi?id=98392
1245
1246         Chromium Win compilation is broken (Requested by yurys on
1247         #webkit).
1248
1249         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1250         (MockWebRTCPeerConnectionHandler::getStats):
1251
1252 2012-10-04  Harald Alvestrand  <hta@google.com>
1253
1254         Change RTCPeerConnection GetStats to use Date timestamp format
1255         https://bugs.webkit.org/show_bug.cgi?id=98263
1256
1257         Reviewed by Adam Barth.
1258
1259         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1260         (MockWebRTCPeerConnectionHandler::getStats):
1261
1262 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1263
1264         Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.
1265
1266         * Scripts/webkitperl/FeatureList.pm:
1267
1268 2012-10-03  Philip Rogers  <pdr@google.com>
1269
1270         Force GC between PageLoad tests.
1271         https://bugs.webkit.org/show_bug.cgi?id=98203
1272
1273         Reviewed by Ryosuke Niwa.
1274
1275         Previously, our PageLoad PerfTests had multi-modal distributions,
1276         typically with a small cluster at 1-2x the median. This turned out
1277         to be caused by not garbage collecting between tests!
1278
1279         This patch adds a new file, force-gc.html, and loads this file between
1280         PageLoad tests to force a GC. I manually verified that this cleans up
1281         our perf test outliers.
1282
1283         * Scripts/webkitpy/performance_tests/perftest.py:
1284         (PageLoadingPerfTest.__init__):
1285         (PageLoadingPerfTest):
1286         (PageLoadingPerfTest.run_single):
1287
1288             This function now loads two pages: one to force a gc and
1289             then the test to run.
1290
1291         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1292
1293             Modified several existing tests to show that the force-gc file
1294             is loaded.
1295
1296         (MockPort):
1297         (MockPort.__init__):
1298         (MockPort.perf_tests_dir):
1299         (TestPageLoadingPerfTest.MockDriver.__init__):
1300         (TestPageLoadingPerfTest.MockDriver.run_test):
1301         (TestPageLoadingPerfTest.test_run):
1302         (TestPageLoadingPerfTest.test_run_with_bad_output):
1303         (TestReplayPerfTest.ReplayTestPort):
1304         (TestReplayPerfTest.ReplayTestPort.__init__):
1305         (TestReplayPerfTest.test_run_single.run_test):
1306         (TestReplayPerfTest.test_run_single):
1307         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1308         (TestPerfTestFactory.test_regular_test):
1309         (TestPerfTestFactory.test_inspector_test):
1310         (TestPerfTestFactory.test_page_loading_test):
1311
1312 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
1313
1314         [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
1315         https://bugs.webkit.org/show_bug.cgi?id=98231
1316
1317         Reviewed by Gyuyoung Kim.
1318
1319         Enable use of X11 in DumpRenderTree / WebKitTestRunner.
1320         Call ecore_evas_new() instead of ecore_evas_buffer_new()
1321         in EFL's DumpRenderTree and WebKitTestRunner.
1322         It is safe to do this now that we are using XvfbDriver
1323         for the layout tests.
1324
1325         * DumpRenderTree/efl/DumpRenderTree.cpp:
1326         (parseCommandLineOptions):
1327         (initEcoreEvas):
1328         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1329         (WTR::initEcoreEvas):
1330         * WebKitTestRunner/efl/main.cpp:
1331         (main):
1332
1333 2012-10-03  Dirk Pranke  <dpranke@chromium.org>
1334
1335         run-webkit-tests tests on win32 after r127302
1336         https://bugs.webkit.org/show_bug.cgi?id=98323
1337
1338         Reviewed by Eric Seidel.
1339
1340         run-webkit-tests tests on win32 after r127302
1341         https://bugs.webkit.org/show_bug.cgi?id=98323
1342
1343         Reviewed by Eric Seidel.
1344
1345         Looks like when we converted the json-building logic to use scm
1346         to try and get the svn revision, we missed a win32-ism and
1347         didn't check to make sure had initialized the scm subsystem.
1348
1349         This change fixes that and renames _initialize_scm to be a public method.
1350
1351         * Scripts/webkitpy/common/host.py:
1352         (Host.initialize_scm):
1353         * Scripts/webkitpy/common/host_mock.py:
1354         (MockHost.__init__):
1355         (MockHost.initialize_scm):
1356         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1357         (summarize_results):
1358         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1359         (JSONResultsGeneratorBase.get_json):
1360         (JSONResultsGeneratorBase._get_result_char):
1361         (JSONResultsGeneratorBase._get_svn_revision):
1362         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1363         (PerfTestsRunner.__init__):
1364         * Scripts/webkitpy/style/checkers/test_expectations.py:
1365         (TestExpectationsChecker.__init__):
1366         * Scripts/webkitpy/style/main.py:
1367         (CheckWebKitStyle.main):
1368         * Scripts/webkitpy/tool/main.py:
1369         (WebKitPatch.handle_global_options):
1370         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1371         (get_test_baselines):
1372
1373 2012-10-03  Adrian Perez de Castro  <aperez@igalia.com>
1374
1375         [GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
1376         https://bugs.webkit.org/show_bug.cgi?id=98310
1377
1378         Reviewed by Martin Robinson.
1379
1380         Make MiniBrowser/GtkLauncher define the path to the inspector
1381         resources by setting the WEBKIT_INSPECTOR_PATH environment
1382         variable pointing to the copy of the inspector resources in
1383         the build directory. If the environment variable is already
1384         defined, its value is not overwritten. The path is derived
1385         from the WEBKIT_EXEC_PATH macro defined in the makefiles.
1386
1387         * GNUmakefile.am:
1388         * GtkLauncher/main.c:
1389         (main):
1390         * MiniBrowser/gtk/main.c:
1391         (main):
1392
1393 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
1394
1395         Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
1396         https://bugs.webkit.org/show_bug.cgi?id=97608
1397
1398         Reviewed by Sam Weinig.
1399
1400         The test fast/dom/Geolocation/window-close-crash.html was crashing because
1401         handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
1402         the page was created, the void* clientInfo can either be a PlatformWebView or
1403         a TestController.
1404
1405         Using the global TestController fixes the issue.
1406
1407         * WebKitTestRunner/GeolocationProviderMock.cpp:
1408         (WTR::GeolocationProviderMock::setPosition):
1409         (WTR::GeolocationProviderMock::setPositionUnavailableError):
1410         To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
1411         to clear the error and vice versa.
1412         This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.
1413
1414         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
1415         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
1416         Some tests expect the position/error cant be sent multiple time,
1417         just keep the position after sending.
1418
1419         * WebKitTestRunner/TestController.cpp:
1420         (WTR::decidePolicyForGeolocationPermissionRequest):
1421         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
1422         * WebKitTestRunner/TestController.h:
1423         Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
1424         client would have to do.
1425
1426 2012-10-03  Otto Derek Cheung  <otcheung@rim.com>
1427
1428         [BlackBerry] Implementing the NetworkInfo API for BB port
1429         https://bugs.webkit.org/show_bug.cgi?id=98273
1430
1431         Reviewed by Rob Buis.
1432
1433         Enabling NetworkInfo API for the BlackBerry port.
1434
1435         * Scripts/webkitperl/FeatureList.pm:
1436
1437 2012-10-03  Anders Carlsson  <andersca@apple.com>
1438
1439         Exception thrown when running accessibility/container-node-delete-causes-crash.html test
1440         https://bugs.webkit.org/show_bug.cgi?id=98291
1441
1442         Reviewed by Andreas Kling.
1443
1444         The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
1445         to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
1446         when trying to access the children of an element that didn't have any children. Fix this by adding
1447         BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
1448
1449         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1450         (findAccessibleObjectById):
1451
1452 2012-10-03  Ojan Vafai  <ojan@chromium.org>
1453
1454         Make partytime work when loading garden-o-matic from trac.webkit.org
1455         https://bugs.webkit.org/show_bug.cgi?id=98283
1456
1457         Reviewed by Adam Barth.
1458
1459         CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1461
1462 2012-10-03  Roger Fong  <roger_fong@apple.com>
1463
1464         Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
1465         https://bugs.webkit.org/show_bug.cgi?id=98288
1466
1467         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1468         (ChromiumAndroidDriverTest.test_command_from_driver_input):
1469
1470 2012-10-03  Ojan Vafai  <ojan@chromium.org>
1471
1472         Get rid of warning about non-existant platform name when loading garden-o-matic
1473         https://bugs.webkit.org/show_bug.cgi?id=98282
1474
1475         Reviewed by Adam Barth.
1476
1477         If you loaded without a platform query parameter we'd return "null" as the platform name
1478         instead of null.
1479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1481
1482 2012-10-03  Balazs Kelemen  <kbalazs@webkit.org>
1483
1484         [Qt] Enable mock scrollbars
1485         https://bugs.webkit.org/show_bug.cgi?id=98011
1486
1487         Reviewed by Csaba Osztrogonác.
1488
1489         Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.
1490
1491         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1492         (WebCore::DumpRenderTree::DumpRenderTree):
1493         * WebKitTestRunner/TestController.cpp:
1494         (WTR::TestController::resetStateToConsistentValues):
1495
1496 2012-10-03  Alberto Garcia  <agarcia@igalia.com>
1497
1498         [GTK] [WK2] Add favicon support to the MiniBrowser
1499         https://bugs.webkit.org/show_bug.cgi?id=98063
1500
1501         Reviewed by Carlos Garcia Campos.
1502
1503         Set the icon in the URI text entry using the favicon property of
1504         the WebKitWebView.
1505
1506         * MiniBrowser/gtk/BrowserWindow.c:
1507         (_BrowserWindow):
1508         (updateUriEntryIcon):
1509         (uriEntryTextChanged):
1510         (faviconChanged):
1511         (browserWindowFinalize):
1512         (browser_window_init):
1513         (browserWindowConstructed):
1514
1515 2012-10-03  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1516
1517         [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
1518         https://bugs.webkit.org/show_bug.cgi?id=98200
1519
1520         Reviewed by Csaba Osztrogonác.
1521
1522         * DumpRenderTree/qt/TestRunnerQt.cpp:
1523         (TestRunner::overridePreference):
1524
1525 2012-10-03  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1526
1527         [Qt][WRT] Fix build error with MSVC on Windows.
1528         https://bugs.webkit.org/show_bug.cgi?id=97697
1529
1530         Reviewed by Simon Hausmann.
1531
1532         WTR build is failing when WebKit directory is located on a longer path.
1533         This seems to caused by source files that has the same name in
1534         WTR and DRT directories. The solution is removing referencies 
1535         from Target.pri to DRT directory and adding an alternate version of
1536         the required files to WTR. Those files simply include the real ones from DRT.
1537
1538         * WebKitTestRunner/InjectedBundle/Target.pri:
1539         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
1540         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
1541
1542 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
1543
1544         [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
1545         https://bugs.webkit.org/show_bug.cgi?id=98238
1546
1547         Reviewed by Csaba Osztrogonác.
1548
1549         Reset AlwaysAcceptCookies setting between tests to avoid
1550         flakiness due to TestRunner.setAlwaysAcceptCookies().
1551
1552         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1553         (WTR::InjectedBundle::beginTesting):
1554
1555 2012-10-03  Harald Alvestrand  <hta@google.com>
1556
1557         Add data passing to the GetStats interface of RTCPeerConnection
1558         https://bugs.webkit.org/show_bug.cgi?id=98003
1559
1560         Reviewed by Adam Barth.
1561
1562         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1563         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
1564         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1565         (MockWebRTCPeerConnectionHandler::addStream):
1566         (MockWebRTCPeerConnectionHandler::removeStream):
1567         (MockWebRTCPeerConnectionHandler::getStats):
1568         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1569         (MockWebRTCPeerConnectionHandler):
1570
1571 == Rolled over to ChangeLog-2012-10-02 ==