7fbb0247351bc93d70a2dd427a918f15f2c6ba6e
[WebKit-https.git] / Tools / ChangeLog
1 2017-04-05  Keith Miller  <keith_miller@apple.com>
2
3         Add debug option to run-jsc script
4         https://bugs.webkit.org/show_bug.cgi?id=170503
5
6         Reviewed by Yusuke Suzuki.
7
8         Adds a new option to the run-jsc script so that when passed
9         "--debug" it will wrap the jsc call with an lldb invocation. If
10         someone wishes to use a different debugger they can set the
11         DEBUGGER environment variable. Additionally, run-jsc now exits
12         with the exit status of the jsc call.
13
14         * Scripts/run-jsc:
15
16 2017-04-05  Andy Estes  <aestes@apple.com>
17
18         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
19         https://bugs.webkit.org/show_bug.cgi?id=170365
20         <rdar://problem/29205721>
21
22         Reviewed by Tim Horton.
23
24         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
25         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
26         (TEST): Re-enabled the test, which now passes.
27
28 2017-04-05  Andy Estes  <aestes@apple.com>
29
30         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
31         https://bugs.webkit.org/show_bug.cgi?id=167594
32
33         Re-enabled this API test now that webkit.org/b/161967 is fixed.
34
35         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
36         (TEST):
37
38 2017-04-05  Andy Estes  <aestes@apple.com>
39
40         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
41         https://bugs.webkit.org/show_bug.cgi?id=161967
42
43         Reviewed by Alexey Proskuryakov.
44
45         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
46         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
47
48 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
49
50         Various settings in Minibrowser are off by default, and should be on
51         https://bugs.webkit.org/show_bug.cgi?id=170465
52         rdar://problem/31421543
53
54         Reviewed by Tim Horton.
55
56         Explicitly set preferences that should be on by default to enabled, if they have not been
57         set previously.
58
59         * MiniBrowser/mac/SettingsController.m:
60         (-[SettingsController init]):
61
62 2017-04-04  JF Bastien  <jfbastien@apple.com>
63
64         Add JF Bastien as reviewer
65         https://bugs.webkit.org/show_bug.cgi?id=170481
66
67         Reviewed by Mark Lam.
68
69         * Scripts/webkitpy/common/config/contributors.json:
70
71 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
72
73         Increase timeouts for simulator testing
74
75         Unreviewed infrastructure fix.
76
77         * Scripts/webkitpy/port/simulator_process.py:
78         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
79         * Scripts/webkitpy/xcode/simulated_device.py:
80         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
81
82 2017-04-04  Tim Horton  <timothy_horton@apple.com>
83
84         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
85         https://bugs.webkit.org/show_bug.cgi?id=165801
86         <rdar://problem/29649535>
87
88         Reviewed by Wenson Hsieh.
89
90         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
91         (TEST):
92         Add some tests for wrapping finds.
93
94 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
95
96         Add some new patterns to filter-build-webkit
97         https://bugs.webkit.org/show_bug.cgi?id=170429
98
99         Reviewed by Alexey Proskuryakov.
100
101         * Scripts/filter-build-webkit:
102         (setOutputFormatOption):
103
104 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
105
106         Data interaction should register type identifiers in order of priority
107         https://bugs.webkit.org/show_bug.cgi?id=170428
108         <rdar://problem/30633296>
109
110         Reviewed by Tim Horton.
111
112         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
113         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
114         test for data interaction from a textarea to an input.
115
116         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
117         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
118         (TestWebKitAPI::TEST):
119         * TestWebKitAPI/ios/DataInteractionSimulator.h:
120         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
121         (-[DataInteractionSimulator _advanceProgress]):
122         (-[DataInteractionSimulator sourceItemProviders]):
123         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
124
125 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
126
127         [GTK][JHBuild] Update mesa repository url for tarballs
128         https://bugs.webkit.org/show_bug.cgi?id=170431
129
130         Reviewed by Michael Catanzaro.
131
132         * gtk/jhbuild.modules:
133
134 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
135
136         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
137         https://bugs.webkit.org/show_bug.cgi?id=170430
138
139         Reviewed by Alexey Proskuryakov.
140
141         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
142         Eliminate one of the copies of Ahem.ttf.
143
144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
145         Once eliminated, there is now only one Ahem.ttf that is copied
146         to the Resources bundle. Drive-by sort the project file.
147
148 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
149
150         Allow MiniBrowser windows to receive local file drags again
151         https://bugs.webkit.org/show_bug.cgi?id=170422
152
153         Reviewed by Wenson Hsieh.
154
155         Adopt the new UIDelegate SPI to allow drops.
156
157         * MiniBrowser/mac/WK2BrowserWindowController.m:
158         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
159
160 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
161
162         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
163         https://bugs.webkit.org/show_bug.cgi?id=170426
164
165         Reviewed by Michael Catanzaro.
166
167         * gtk/jhbuild.modules:
168
169 2017-04-03  Nan Wang  <n_wang@apple.com>
170
171         AX: Expose link children when doing search predication on iOS
172         https://bugs.webkit.org/show_bug.cgi?id=170424
173         <rdar://problem/31413335>
174
175         Reviewed by Chris Fleizach.
176
177         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
178         (AccessibilityUIElement::uiElementForSearchPredicate):
179         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
180         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
181
182 2017-04-03  Brian Burg  <bburg@apple.com>
183
184         run-safari should support launching with custom language and locale
185         https://bugs.webkit.org/show_bug.cgi?id=170397
186
187         Reviewed by Alexey Proskuryakov.
188
189         Hook up -AppleLanguages and -AppleLocale to command line options.
190
191         * Scripts/webkitdirs.pm:
192         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
193         (argumentsForRunAndDebugMacWebKitApp):
194
195 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
196
197         webkitpy: Provide option to skip install
198         https://bugs.webkit.org/show_bug.cgi?id=170344
199
200         Reviewed by Alexey Proskuryakov.
201
202         Installing can take time for on device testing.  Provide an option to skip install
203         and use whatever driver is currently installed on the device or simulator.
204
205         * Scripts/webkitpy/port/base.py:
206         (Port.check_build): Do not check driver if skipping install.
207         * Scripts/webkitpy/port/factory.py:
208         (platform_options): Add '--no-install' option.
209         * Scripts/webkitpy/port/ios.py:
210         (IOSPort.setup_test_run): Check install option before installing.
211
212 2017-04-03  Keith Miller  <keith_miller@apple.com>
213
214         WebAssembly: Update spec tests
215         https://bugs.webkit.org/show_bug.cgi?id=170361
216
217         Rubber-stamped by Saam Barati.
218
219         Update the runner to know the new wasm spec test harness code.
220
221         * Scripts/run-jsc-stress-tests:
222
223 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
224
225         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
226
227         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
228         https://bugs.webkit.org/show_bug.cgi?id=170365
229
230         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
231
232 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
233
234         Mac cmake buildfix after 214586.
235         https://bugs.webkit.org/show_bug.cgi?id=170381
236
237         Unreviewed speculative buildfix.
238
239         * WebKitTestRunner/PlatformMac.cmake:
240
241 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
242
243         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
244         https://bugs.webkit.org/show_bug.cgi?id=161675
245
246         * WebKitTestRunner/PlatformMac.cmake:
247
248 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
249
250         webkitpy: Add target host concept
251         https://bugs.webkit.org/show_bug.cgi?id=170186
252         <rdar://problem/31301797>
253
254         Reviewed by Alexey Proskuryakov.
255
256         Adding the idea of a target host. Target hosts are objects conforming to the
257         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
258         Target hosts are the hosts associated with a worker process.
259
260         * Scripts/webkitpy/common/system/filesystem.py:
261         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
262         host to an absolute path on this host.
263         (FileSystem.move_to_base_host): Move file from this host to the base host.
264         (FileSystem.move_from_base_host): Move file from the base host to this host.
265         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
266         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
267         * Scripts/webkitpy/common/system/filesystem_mock.py:
268         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
269         host to an absolute path on this host.
270         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
271         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
272         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
273         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
274         * Scripts/webkitpy/port/base.py:
275         (Port.target_host): Return host determined by worker number.
276         (Port.abspath_for_test): Accept optional target_host argument to return location
277         of test on a target host.
278         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
279         directory on a target host.
280         (Port.sample_process): Accept optional target_host argument to sample process on
281         a target host.
282         * Scripts/webkitpy/port/darwin.py:
283         (DarwinPort.sample_process): Run sample process on target host.
284         (DarwinPort.sample_file_path): Accept directory for file.
285         (DarwinPort.spindump_file_path): Ditto.
286         * Scripts/webkitpy/port/darwin_testcase.py:
287         (DarwinTest.test_spindump): Check file movement.
288         (DarwinTest.test_sample_process): Ditto.
289         (DarwinTest.test_sample_process_exception):
290         * Scripts/webkitpy/port/driver.py:
291         (Driver.__init__): Add and set self._target_host variable.
292         (Driver._start): Pass target host to _driver_tempdir().
293         (Driver.stop): Call the target host's rmtree.
294         (Driver._check_for_driver_timeout): Pass target host to sample_process.
295         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
296         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
297         layout test directory to target host.
298         * Scripts/webkitpy/port/ios.py:
299         (IOSPort):
300         (IOSPort.target_host): Replaced device_for_worker_number.
301         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
302         (IOSPort.device_for_worker_number): Replaced with target_host.
303         * Scripts/webkitpy/port/server_process.py:
304         (ServerProcess.__init__): Accept target_host instead of worker_number.
305         (ServerProcess._start): Replace _host with _target_host.
306         (ServerProcess._handle_timeout): Ditto.
307         (ServerProcess._kill): Ditto.
308         * Scripts/webkitpy/port/simulator_process.py:
309         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
310         (SimulatorProcess._start): Replace _device with _target_host.
311         (SimulatorProcess.stop): Ditto.
312         (SimulatorProcess._kill): Deleted.
313
314 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
315
316         Unreviewed fix after r214569
317         https://bugs.webkit.org/show_bug.cgi?id=170255
318
319         Unreviewed infrastructure fix.
320
321         * Scripts/webkitpy/port/ios.py:
322         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
323
324 2017-03-31  Andy Estes  <aestes@apple.com>
325
326         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
327         https://bugs.webkit.org/show_bug.cgi?id=170365
328         <rdar://problem/29205721>
329
330         Reviewed by Tim Horton.
331
332         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
333         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
334         (TEST): Re-enabled the test, which now passes.
335
336 2017-03-31  Tim Horton  <timothy_horton@apple.com>
337
338         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
339         https://bugs.webkit.org/show_bug.cgi?id=170326
340         <rdar://problem/30330395>
341
342         Reviewed by Simon Fraser.
343
344         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
345         (TEST):
346
347 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
348
349         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
350
351         Fixes: http/tests/ssl/upgrade-origin-usage.html
352                http/tests/websocket/tests/hybi/network-process-crash-error.html
353                http/tests/websocket/tests/hybi/simple-wss.html
354
355         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
356         (WTR::TestController::platformContext): Return the context.
357
358 2017-03-30  Sam Weinig  <sam@webkit.org>
359
360         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
361         https://bugs.webkit.org/show_bug.cgi?id=170315
362
363         Reviewed by Simon Fraser.
364
365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
366         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
367         Add test showing the completion handler is called.
368
369 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
370
371         Air should support linear scan for optLevel<2
372         https://bugs.webkit.org/show_bug.cgi?id=170161
373
374         Reviewed by Saam Barati.
375         
376         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
377         pipeline.
378
379         * Scripts/run-jsc-stress-tests:
380
381 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
382
383         Support tvOS and watchOS in webkitdirs.pm
384         https://bugs.webkit.org/show_bug.cgi?id=170267
385
386         Reviewed by Alexey Proskuryakov.
387
388         * Scripts/webkitdirs.pm:
389         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
390         (xcodeSDKPlatformName): Added support for tvos and watchos.
391         (determinePortName): Same.
392         (isAppleCocoaWebKit): Same.
393         (willUseAppleTVDeviceSDK): Added.
394         (willUseAppleTVSimulatorSDK): Added.
395         (willUseWatchDeviceSDK): Added.
396         (willUseWatchSimulatorSDK): Added.
397         (isTVOSWebKit): Added.
398         (isWATCHOSWebKit): Added.
399         (isIOSLikeWebKit): Added.
400
401 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
402
403         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
404         https://bugs.webkit.org/show_bug.cgi?id=170291
405         <rdar://problem/31301388>
406
407         Reviewed by Tim Horton.
408
409         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
410         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
411         shared UIApplication, and verify that data interaction completes successfully.
412
413         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
414         (TestWebKitAPI::TEST):
415         * TestWebKitAPI/ios/DataInteractionSimulator.h:
416         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
417         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
418         (-[DataInteractionSimulator initWithWebView:]):
419         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
420         (-[DataInteractionSimulator runFrom:to:]):
421         (-[DataInteractionSimulator _advanceProgress]):
422         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
423
424 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
425
426         [Win] Pass close_fds = True in Python popen call.
427         https://bugs.webkit.org/show_bug.cgi?id=170172
428
429         Reviewed by Brent Fulgham.
430
431         This was previously not supported on Windows, but in Python 2.7.10 it is.
432
433         * Scripts/webkitpy/common/system/executive.py:
434         (Executive._should_close_fds):
435         * Scripts/webkitpy/port/server_process.py:
436         (ServerProcess._start):
437
438 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
439
440         Change my status to be a WebKit reviewer.
441
442         Unreviewed status update edit.
443
444         * Scripts/webkitpy/common/config/contributors.json:
445
446 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
447
448         Change my status to be a WebKit reviewer.
449
450         Unreviewed status update edit.
451
452         * Scripts/webkitpy/common/config/contributors.json:
453
454 2017-03-29  Tim Horton  <timothy_horton@apple.com>
455
456         Swipe gesture tests don't work on macOS Sierra
457         https://bugs.webkit.org/show_bug.cgi?id=161675
458         <rdar://problem/23379930>
459
460         Reviewed by Darin Adler.
461
462         * DumpRenderTree/mac/UIScriptControllerMac.mm:
463         (WTR::UIScriptController::platformPlayBackEventStream):
464         (WTR::UIScriptController::beginBackSwipe):
465         (WTR::UIScriptController::completeBackSwipe):
466         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h: Copied from Tools/DumpRenderTree/mac/UIScriptControllerMac.mm.
467         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: Added.
468         (eventIsOfType):
469         (eventIsOfTypes):
470         (eventIsOfGestureType):
471         (eventIsOfGestureTypes):
472         (+[EventSerializer dictionaryForEvent:relativeToTime:]):
473         (+[EventSerializer createEventForDictionary:inWindow:relativeToTime:]):
474         (+[EventSerializer playEventStream:inWindow:completionHandler:]):
475         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm.
476         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm: Added.
477         (beginSwipeBackEventStream):
478         (completeSwipeBackEventStream):
479         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
480         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
481         (WTR::UIScriptController::playBackEventStream):
482         (WTR::UIScriptController::beginBackSwipe):
483         (WTR::UIScriptController::completeBackSwipe):
484         (WTR::UIScriptController::platformPlayBackEventStream):
485         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
486         * TestRunnerShared/UIScriptContext/UIScriptController.h:
487         * TestRunnerShared/spi/CoreGraphicsSPI.h: Added.
488         * TestRunnerShared/spi/IOKitSPI.h: Renamed from Tools/WebKitTestRunner/ios/IOKitSPI.h.
489         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
490         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
491         (WTR::playBackEvents):
492         (WTR::UIScriptController::beginBackSwipe):
493         (WTR::UIScriptController::completeBackSwipe):
494         (WTR::UIScriptController::platformPlayBackEventStream):
495
496 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
497
498         webkitpy: Robust test clean-up
499         https://bugs.webkit.org/show_bug.cgi?id=170255
500
501         Reviewed by Alexey Proskuryakov.
502
503         On-device testing is the motivation for this change.  Failure to run clean-up functions can
504         result in zombie processes, residual NFS mounts and other undesirable remnants from a failed
505         test run.  Make an effort to clean-up even if exceptions are thrown during set-up or clean-up.
506
507         * Scripts/webkitpy/layout_tests/controllers/manager.py:
508         (Manager._set_up_run): Clean up test run if set-up fails.
509         * Scripts/webkitpy/port/ios.py:
510         (IOSPort.clean_up_test_run): Continue cleaning up devices even after an exception is thrown.
511
512 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
513
514         Simulator testing stops after the first crash
515         <rdar://problem/31325362>
516
517         Unreviewed infrastructure fix.
518
519         * Scripts/webkitpy/xcode/simulated_device.py:
520         (SimulatedDevice):
521         (SimulatedDevice.launch_app): Increase timeout when attempting to launch app.
522
523 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
524
525         webkitpy: Standardize web-server port definitions
526         https://bugs.webkit.org/show_bug.cgi?id=170144
527         <rdar://problem/31284026>
528
529         Reviewed by Daniel Bates.
530
531         Default web-server ports should be declared in global variables.
532         Add functions to web-servers which return the ports these servers
533         are using so that other tools can forward them.
534
535         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
536         (LayoutTestApacheHttpd.__init__): Use shared constants in http_server_base.py.
537         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
538         (TestLayoutTestApacheHttpd.test_start_cmd): Check port_to_forward for expected values.
539         * Scripts/webkitpy/layout_tests/servers/http_server.py:
540         (Lighttpd.__init__): Use shared constants in http_server_base.py.
541         (Lighttpd._prepare_config): Ditto.
542         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
543         (HttpServerBase): Add default port constants.
544         (HttpServerBase.ports_to_forward): Add function to return ports used for http server.
545         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
546         (TestHttpServer.test_start_cmd): Check port_to_forward for expected values.
547         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
548          (WebPlatformTestServer.ports_to_forward): Add function to return ports used for web-platform tests.
549         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
550         (PyWebSocket): Make default port values public.
551         (PyWebSocket.__init__): Use public default port.
552         (PyWebSocket.ports_to_forward): Return port used in an array.
553         * Scripts/webkitpy/port/base.py:
554         (Port.to.ports_to_forward): Return all ports used the various web-servers managed by the port object.
555         (Port.to.start_websocket_server): Use PyWebSocket port constants.
556
557 2017-03-29  Wenson Hsieh  <wenson_hsieh@apple.com>
558
559         Links with empty hrefs should not be drag sources
560         https://bugs.webkit.org/show_bug.cgi?id=170241
561         <rdar://problem/31305505>
562
563         Reviewed by Tim Horton.
564
565         Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
566
567         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
568         (TestWebKitAPI::TEST):
569         * TestWebKitAPI/ios/DataInteractionSimulator.h:
570
571         Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
572
573         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
574         (-[DataInteractionSimulator phase]):
575
576 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
577
578         Use TCP instead of FIFOs for Simulator/Device communication
579         https://bugs.webkit.org/show_bug.cgi?id=169419
580         <rdar://problem/30949615>
581
582         Reviewed by Alexey Proskuryakov.
583
584         Using TCP instead of FIFOs when communicating with devices allows the device being tested
585         to be on a different machine then the one handling the management of the test run.
586
587         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
588         * DumpRenderTree/mac/DumpRenderTree.mm:
589         (dumpRenderTree): Call setUp/tearDownIOSLayoutTestCommunication() instead of using FIFOs.
590         * Scripts/webkitpy/port/device.py:
591         (Device.__init__): Initialize the listening_socket.
592         (Device.listening_port): Return port of listening socket.
593         (Device.prepare_for_testing): Open listening socket on an open port, prepare platform device
594         fro testing.
595         (Device.finished_testing): Close listening socket associated with this device, call the
596         platform device's finished_testing function if it exists.
597         * Scripts/webkitpy/port/ios.py:
598         (IOSPort.setup_test_run): Prepare each device for testing.
599         (IOSPort.clean_up_test_run): Notify each device that testing has completed.
600         * Scripts/webkitpy/port/ios_simulator.py:
601         (IOSSimulatorPort): Work around device persistence bug.
602         (IOSSimulatorPort.__init__): Ditto.
603         * Scripts/webkitpy/port/simulator_process.py:
604         (SimulatorProcess):
605         (SimulatorProcess.NonBlockingFileFromSocket): Add to work around shortcomings in
606         Python 2’s makefile.
607         (SimulatorProcess.NonBlockingFileFromSocket.__init__): Initialize file with socket.
608         (SimulatorProcess.ReadFileSocket.close): Close file and then socket;
609         (SimulatorProcess.__init__): Pass TCP port over environment, remove FIFO names.
610         (SimulatorProcess.__getattr__): Expose all file attributes.
611         (SimulatorProcess._accept_connection_create_file): Wait for connection from server and
612         create and return a file-like object from the incoming connection.
613         (SimulatorProcess._start): Use TCP connections instead of FIFOs.
614         (SimulatorProcess._start.handler): Output server port in timeout exception.
615         (SimulatorProcess._reset): Deleted.
616         * TestRunnerShared/IOSLayoutTestCommunication.cpp: Added.
617         (connectToServer): Return socket connected to the provided server address.
618         (setupiOSLayoutTestCommunication): Connect stdin, stdout and stderr as socket to a
619         TCP server running on localhost.
620         (tearDownIOSLayoutTestCommunication): Close stdin, stdout and stderr TCP sockets.
621         * TestRunnerShared/IOSLayoutTestCommunication.h: Added.
622         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
623         * WebKitTestRunner/ios/TestControllerIOS.mm:
624         (WTR::TestController::platformInitialize): Call setUpIOSLayoutTestCommunication()
625         instead of using FIFOs.
626         (WTR::TestController::platformDestroy): Call tearDownIOSLayoutTestCommunication().
627
628 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
629
630         webkitpy: Add IOSDevicePort and IOSPort tests
631         https://bugs.webkit.org/show_bug.cgi?id=170206
632         <rdar://problem/31308364>
633
634         Reviewed by Alexey Proskuryakov.
635
636         * Scripts/webkitpy/port/darwin_testcase.py: Removed unused import.
637         * Scripts/webkitpy/port/ios_device_unittest.py: Added.
638         (iosDeviceTest): Contains tests for the IOSDevicePort.
639         (iosDeviceTest.make_port): Creates an IOSDevicePort with arguments.
640         (iosDeviceTest.test_operating_system): Check for the correct operating system.
641         * Scripts/webkitpy/port/ios_simulator_unittest.py: Moved from Tools/Scripts/webkitpy/port/ios_unittest.py.
642         (iosSimulatorTest): Inherit from ios_testcase.
643         (iosSimulatorTest.make_port): Ditto.
644         (iosSimulatorTest.test_get_crash_log): Ditto.
645         * Scripts/webkitpy/port/ios_testcase.py: Added.
646         (iOSTest): Contains shared tests for the IOSDevicePort and IOSSimulatorPort.
647         (iOSTest.test_driver_name): Tests for iOS app driver.
648         (iOSTest.test_baseline_searchpath): Check that ios and ios-wk1 are in the baseline search path.
649         * Scripts/webkitpy/port/ios_unittest.py: Moved to ios_simulator_unittest.py.
650         * Scripts/webkitpy/port/port_testcase.py:
651         (PortTestCase): Rename is_simulator to disable_setup to more accurately describe it's meaning.
652         (PortTestCase.test_diff_image): Use disable_setup instead of is_simulator.
653         (PortTestCase.test_diff_image_crashed): Ditto.
654
655 2017-03-28  Jason Marcell  <jmarcell@apple.com>
656
657         Fix `index-expected.txt` for dashboard test results.
658         https://bugs.webkit.org/show_bug.cgi?id=170214
659
660         Reviewed by Alexey Proskuryakov.
661
662         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:
663
664 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
665
666         Bot watcher's dashboard has separate settings for "mac" and "macos"
667         https://bugs.webkit.org/show_bug.cgi?id=170164
668
669         Reviewed by Tim Horton.
670
671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
672         (Settings.prototype.parsePlatformFamily): Aded a special case for "macos".
673
674 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
675
676         Fix dashboard test results on the dashboard
677         https://bugs.webkit.org/show_bug.cgi?id=170158
678
679         Reviewed by Tim Horton.
680
681         Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
682         further improved, as it's not super readable, but stdio is entirely useless in this context.
683
684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
685         (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
686
687         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
688         Fixed a typo in step name, so that it's actually treated as productive.
689
690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
691         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
692         (BuildbotTesterQueueView.prototype.update):
693         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
694         Added special handling for dashboard test results.
695
696 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
697
698         Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
699         https://bugs.webkit.org/show_bug.cgi?id=170193
700
701         Reviewed by Alexey Proskuryakov.
702
703         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
704         Fixed the order of arguments.
705
706 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
707
708         Dashboard tests fails to fetch the revision from commits
709         https://bugs.webkit.org/show_bug.cgi?id=170191
710
711         Reviewed by Alexey Proskuryakov.
712
713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
714         Added recordedCommitIndicesByRevisionNumber.
715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
716         (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
717
718 2017-03-28  Timothy Horton  <timothy_horton@apple.com>
719
720         Safari crashes when attempting to close tab that is displaying PDF
721         https://bugs.webkit.org/show_bug.cgi?id=170201
722         <rdar://problem/31242019>
723
724         Reviewed by Wenson Hsieh.
725
726         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
727         (TEST):
728         Add a test for doAfterNextStablePresentationUpdate just like the existing
729         non-stable one.
730
731 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
732
733         webkitpy: Use host pattern for devices
734         https://bugs.webkit.org/show_bug.cgi?id=170121
735
736         Reviewed by Daniel Bates.
737
738         Devices should be treated like hosts throughout webkitpy
739         so that more code can be re-used.  Add the needed properties
740         and use executive over custom implemented polling/killing
741         functions.
742
743         * Scripts/webkitpy/port/device.py:
744         (Device):
745         (Device.executive): Add optional executive property.
746         (Device.filesystem): Add optional filesystem property.
747         (Device.user): Add optional user property.
748         (Device.platform): Add optional platform property.
749         (Device.workspace): Add optional workspace property.
750         (Device.poll): Deleted.
751         * Scripts/webkitpy/port/simulator_process.py:
752         (SimulatorProcess.Popen.poll): Use the devices executive.
753         (SimulatorProcess.stop): Ditto.
754         (SimulatorProcess._kill): Ditto.
755         * Scripts/webkitpy/xcode/simulated_device.py:
756         (SimulatedDevice.__init__): Add executive, filesystem, user, platform
757         and workspace to the platform device.
758         (SimulatedDevice.poll): Deleted.
759
760 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
761
762         Dashboard test fails with error: latestIterationGetter is not a function
763         https://bugs.webkit.org/show_bug.cgi?id=170167
764
765         Reviewed by Alexey Proskuryakov.
766
767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
768         (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
769
770 2017-03-27  Lucas Forschler  <lforschler@apple.com>
771
772         Another test v8.
773
774 2017-03-27  Lucas Forschler  <lforschler@apple.com>
775
776         Another test v7.
777
778 2017-03-27  Lucas Forschler  <lforschler@apple.com>
779
780         Another test v6.
781
782 2017-03-27  Lucas Forschler  <lforschler@apple.com>
783
784         Another test v5.
785
786 2017-03-27  Lucas Forschler  <lforschler@apple.com>
787
788         Another test v4.
789
790 2017-03-27  Lucas Forschler  <lforschler@apple.com>
791
792         Another test v3.
793
794 2017-03-27  Lucas Forschler  <lforschler@apple.com>
795
796         Another test v2.
797
798 2017-03-27  Lucas Forschler  <lforschler@apple.com>
799
800         Another test.
801
802 2017-03-27  Lucas Forschler  <lforschler@apple.com>
803
804         <rdar://problem/30949128>
805         Update build.webkit.org to use port 16000 for PBChangeSource.
806         
807         Reviewed by Alexey Proskuryakov.
808
809         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
810
811 2017-03-27  Jason Marcell  <jmarcell@apple.com>
812
813         Bots should run the dashboard tests
814         https://bugs.webkit.org/show_bug.cgi?id=168994
815
816         Reviewed by Daniel Bates and David Kilzer.
817
818         We pull the `--results-directory` argument value out so that `RunDashboardTests` can override it so that we can separately run the dashboard layout tests.
819
820         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
821         (RunWebKitTests): Define a class variable called resultDirectory for the `--results-directory` argument so that subclasses can override this if needed.
822         (RunWebKitTests.start): Set the `--results-directory` argument value to the value of self.resultDirectory.
823         (RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
824         (RunDashboardTests.start): Override the `--layout-tests-directory` to point to the dashboard layout tests.
825         (ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
826         (TestFactory.__init__): Update unit tests to account for new RunDashboardTests step.
827         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
829
830 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
831
832         webkitpy: Look for 'ios' test expectations for IOSPorts
833         https://bugs.webkit.org/show_bug.cgi?id=169413
834
835         Reviewed by Alexey Proskuryakov.
836
837         Test expectations for iOS tests should include the 'ios' folder.  Modify
838         default_baseline_search_path to include 'ios' folder and derivatives for
839         IOSPort.
840
841         * Scripts/webkitpy/port/ios.py:
842         (IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
843         (IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
844         (IOSPort.test_expectations_file_position): Added for testing.
845         * Scripts/webkitpy/port/ios_simulator.py:
846         (IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
847         (IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.
848
849 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
850
851         REGRESSION: Reseting _device_map on each child process
852         <rdar://problem/31274476>
853
854         Unreviewed infrastructure fix.
855
856         * Scripts/webkitpy/port/ios_simulator.py:
857         (IOSSimulatorPort): Add _DEVICE_MAP class variable.
858         (IOSSimulatorPort.__init__): Use shared class variable
859         (IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
860         (IOSSimulatorPort._create_devices): Ditto.
861         (IOSSimulatorPort._quit_ios_simulator): Ditto.
862         (IOSSimulatorPort.clean_up_test_run): Ditto.
863
864 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
865
866         REGRESSION: Failing to iterate over Simulator.managed_devices map
867         <rdar://problem/31274476>
868
869         Unreviewed infrastructure fix.
870
871         * Scripts/webkitpy/port/ios_simulator.py:
872         (IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.
873
874 2017-03-27  Alex Christensen  <achristensen@webkit.org>
875
876         Make WebSockets work in network process
877         https://bugs.webkit.org/show_bug.cgi?id=169930
878
879         Reviewed by Youenn Fablet.
880
881         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
882         Add terminateNetworkProcess for the new test
883         http/tests/websocket/tests/hybi/network-process-crash-error.html
884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
885         (WTR::TestRunner::setAllowsAnySSLCertificate):
886         (WTR::TestRunner::terminateNetworkProcess):
887         * WebKitTestRunner/InjectedBundle/TestRunner.h:
888         * WebKitTestRunner/TestController.cpp:
889         (WTR::TestController::setAllowsAnySSLCertificate):
890         (WTR::TestController::terminateNetworkProcess):
891         * WebKitTestRunner/TestController.h:
892         * WebKitTestRunner/TestInvocation.cpp:
893         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
894         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
895         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
896         (WTR::TestController::platformContext):
897         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
898         (WTR::TestController::platformContext):
899         (WTR::TestController::platformLibraryPathForTesting):
900         Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
901         which calls testRunner.setAllowsAnySSLCertificate.  It used to only be effective
902         for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
903         and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
904         which tests that wss works, but our test certificate has an invalid certificate chain.
905         We want production software to not have the ability to have its security weakened, so this
906         is a test code path that is only implemented in WebKitTestRunner.
907
908 2017-03-25  Jonathan Bedard  <jbedard@apple.com>
909
910         webkitpy: Use generalized device instead of platform specific one
911         https://bugs.webkit.org/show_bug.cgi?id=170078
912
913         Reviewed by Daniel Bates.
914
915         SimulatedDevice is re-created each time 'xcrun simctl list' is called.  Device
916         should remain persistent.  Changing Device to a more explicit interface.
917         SimulatedDevice no longer inherits from Device and IOSSimulator returns Devices
918         wrapping SimulatedDevices.
919
920         * Scripts/webkitpy/port/device.py: Added.
921         (Device):
922         (Device.__init__): Construct with platform device.
923         (Device.install_app): Install app at app path on platform device.
924         (Device.launch_app): Launch app with bundle ID on platform device.
925         (Device.poll): Poll platform device.
926         (Device.udid): Access platform device UDID.
927         (Device.__nonzero__): Check if instantiated with a valid platform device.
928         (Device.__eq__): Compare by udid.
929         (Device.__ne__): Ditto.
930         (Device.__repr__): Print out platform_device representation.
931         * Scripts/webkitpy/port/ios_simulator.py:
932         (IOSSimulatorPort.__init__): Initialize the _device_map to an empty dictionary.
933         (IOSSimulatorPort._device_for_worker_number_map):  Return self._device_map.
934         (IOSSimulatorPort._create_simulators): Call Simulator.managed_devices directly.
935         (IOSSimulatorPort._create_devices): Place Simulator.managed_devices into the
936         device map.
937         (IOSSimulatorPort._quit_ios_simulator): Reset self._device_map.
938         * Scripts/webkitpy/xcode/device.py: Removed.
939         * Scripts/webkitpy/xcode/simulated_device.py:
940         (SimulatedDevice):
941         (SimulatedDevice.__init__): Move host, name and did to SimulatedDevice.
942         (SimulatedDevice.__eq__): Compare two simulated devices.
943         (SimulatedDevice.__ne__): Ditto.
944         (SimulatedDevice.__repr__): Print name and udid.
945
946 2017-03-25  Adrian Perez de Castro  <aperez@igalia.com>
947
948         [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
949         https://bugs.webkit.org/show_bug.cgi?id=170059
950
951         Reviewed by Carlos Garcia Campos.
952
953         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration,
954         the only use of the method in this same file ignores the returned value anyway.
955
956 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
957
958         webkitpy should be able to run API tests
959         https://bugs.webkit.org/show_bug.cgi?id=170028
960
961         Reviewed by Alexey Proskuryakov.
962
963         * Scripts/webkitpy/common/config/ports.py:
964         (DeprecatedPort.run_api_tests_command): Added.
965         * Scripts/webkitpy/port/base.py:
966         (Port.api_results_directory): Added.
967         * Scripts/webkitpy/tool/steps/runtests.py:
968         (RunTests.run): Check if we should be running API tests.
969         (RunTests._run_api_tests): Generate script to run API tests with json output.
970         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
971
972 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
973
974         Add JSON results for API tests
975         https://bugs.webkit.org/show_bug.cgi?id=170021
976
977         Reviewed by Alexey Proskuryakov.
978
979         * Scripts/run-api-tests:
980         (runTestsBySuite): Appends failures and timeouts to JSON data.
981         (writeJsonDataIfApplicable): Writes JSON data to a file.
982
983 2017-03-24  Lucas Forschler  <lforschler@apple.com>
984
985         update committer_auth.py to be python 2.7 compliant
986         https://bugs.webkit.org/show_bug.cgi?id=170063
987         
988         Reviewed by Alexey Proskuryakov.
989
990         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
991         (CommitterAuth.authenticate):
992             convert e.message to e.args[0]
993
994 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
995
996         webkitpy: Parse JSON results from run-api-tests
997         https://bugs.webkit.org/show_bug.cgi?id=170062
998
999         Reviewed by Alexey Proskuryakov.
1000
1001         * Scripts/webkitpy/common/net/apitestresults.py: Added.
1002         (APITestResults): Structure to represent API test results.
1003         (APITestResults.__init__):
1004         (APITestResults.intersection): Return the failures common to both sets of results.
1005         (APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
1006         (APITestResults.equals): Return True if both results were the same.
1007         (APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
1008         (APITestResults.all_passed): Return True if everything passed.
1009         (APITestResults.failing_tests): List of tests that didn't pass.
1010         (APITestResults.did_exceed_test_failure_limit): Always False.
1011         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.
1012         (APITestResultsTest): Unit tests.
1013         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.
1014         (APITestResultsReader): Read contents of JSON results file.
1015
1016 2017-03-24  Alex Christensen  <achristensen@webkit.org>
1017
1018         REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
1019         https://bugs.webkit.org/show_bug.cgi?id=169167
1020
1021         Reviewed by Simon Fraser.
1022
1023         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1024         (TestWebKitAPI::TEST_F):
1025         Test an example of a selector that was incorrectly determined to be invalid.
1026
1027 2017-03-24  Jonathan Bedard  <jbedard@apple.com>
1028
1029         Increase timeout for booting simulators.
1030         <rdar://problem/31080009>
1031
1032         Unreviewed infrastructure fix.
1033
1034         * Scripts/webkitpy/xcode/simulator.py:
1035         (Simulator.wait_until_device_is_booted): Increase timeout.
1036         (Simulator.wait_until_device_is_in_state): Increase timeout.
1037
1038 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1039
1040         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.
1041
1042         Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
1043         in our unit tests to work.
1044
1045         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1046         (testWebViewJavaScriptDialogs):
1047
1048 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1049
1050         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
1051         https://bugs.webkit.org/show_bug.cgi?id=170001
1052
1053         Reviewed by Michael Catanzaro.
1054
1055         Ignore style of xdgmime sources.
1056
1057         * Scripts/webkitpy/tool/steps/checkstyle.py:
1058
1059 2017-03-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1060
1061         Dragging on a large image should not revert to a file icon if data interaction is enabled
1062         https://bugs.webkit.org/show_bug.cgi?id=170018
1063         <rdar://problem/31184508>
1064
1065         Reviewed by Tim Horton.
1066
1067         Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
1068         AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.
1069
1070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1071         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
1072         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1073         (TestWebKitAPI::TEST):
1074
1075 2017-03-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1076
1077         Update WinCairoRequirements.zip
1078         https://bugs.webkit.org/show_bug.cgi?id=169950
1079
1080         Reviewed by Alex Christensen.
1081
1082         * Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
1083
1084 == Rolled over to ChangeLog-2017-03-23 ==