Tools/ChangeLog

   1 2011-09-22  Adam Roben  <aroben@apple.com>
   2
   3         Use the "direct object" form of system() to run WebKit.exe
   4
   5         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
   6         path to WebKit.exe.
   7
   8         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
   9         %WEBKITOUTPUTDIR%
  10
  11         Reviewed by Steve Falkenburg.
  12
  13         * Scripts/webkitdirs.pm:
  14         (runSafari):
  15
  16 2011-09-22  Adam Roben  <aroben@apple.com>
  17
  18         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
  19
  20         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
  21         spaces in the path to the WebKit source tree
  22
  23         Reviewed by John Sullivan.
  24
  25         * Scripts/webkitdirs.pm:
  26         (setupCygwinEnv):
  27
  28 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
  29
  30         [Qt] Use same DPI for application font as rest of app in DRT and WTR
  31
  32         QApplication will initialize the default application font based
  33         on the application DPI at construction time, but we then override
  34         the application DPI using QX11Info (hard-coding it to 96 for
  35         consistency). This hard-coding is not reflected in the application
  36         font, so we explicitly have update the font ourselves.
  37
  38         The 6 test results that are updated were originally produced with
  39         a DPI of 75, as this is the default fallback DPI when a QFont is
  40         constructed before QApplication. This was wrong, and the results
  41         are updated to match a DPI of 96.
  42
  43         Reviewed by Csaba Osztrogonác.
  44
  45         * DumpRenderTree/qt/main.cpp:
  46         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  47
  48 2011-09-21  Anna Cavender  <annacc@chromium.org>
  49
  50         Update committers.py with a new contributor contact
  51         https://bugs.webkit.org/show_bug.cgi?id=68565
  52
  53         Reviewed by Eric Carlson.
  54
  55         * Scripts/webkitpy/common/config/committers.py:
  56
  57 2011-09-21  Chang Shu  <cshu@webkit.org>
  58
  59         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
  60         https://bugs.webkit.org/show_bug.cgi?id=68108
  61
  62         This patch implements the event sender mouse events through WebKit2 UIProcess which is
  63         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
  64         platform as the first step so the existing code is still kept for other platforms.
  65
  66         Reviewed by Darin Adler.
  67
  68         * WebKitTestRunner/EventSenderProxy.h:
  69         (WTR::EventSenderProxy::EventSenderProxy):
  70         (WTR::EventSenderProxy::leapForward):
  71         (WTR::EventSenderProxy::currentEventTime):
  72         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  73         (WTR::EventSendingController::EventSendingController):
  74         (WTR::EventSendingController::mouseDown):
  75         (WTR::EventSendingController::mouseUp):
  76         (WTR::EventSendingController::mouseMoveTo):
  77         (WTR::EventSendingController::leapForward):
  78         (WTR::EventSendingController::keyDown):
  79         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  80         * WebKitTestRunner/TestController.cpp:
  81         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  82         * WebKitTestRunner/mac/EventSenderProxy.mm:
  83         (WTR::eventTypeForMouseButtonAndAction):
  84         (WTR::operator==):
  85         (WTR::EventSenderProxy::updateClickCountForButton):
  86         (WTR::EventSenderProxy::mouseDown):
  87         (WTR::EventSenderProxy::mouseUp):
  88         (WTR::EventSenderProxy::mouseMoveTo):
  89         (WTR::EventSenderProxy::keyDown):
  90         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  91         (WTR::EventSenderProxy::keyDown):
  92         (WTR::EventSenderProxy::mouseDown):
  93         (WTR::EventSenderProxy::mouseUp):
  94         (WTR::EventSenderProxy::mouseMoveTo):
  95
  96 2011-09-21  Dan Bernstein  <mitz@apple.com>
  97
  98         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
  99         https://bugs.webkit.org/show_bug.cgi?id=68451
 100
 101         Reviewed by Darin Adler.
 102
 103         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
 104         Objective-C classes with names not having one of a list of prefixes
 105         passed on the command line.
 106
 107 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
 108
 109         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
 110         https://bugs.webkit.org/show_bug.cgi?id=68206
 111
 112         Reviewed by Tony Chang.
 113
 114         * Scripts/webkitdirs.pm:
 115         (determineBaseProductDir): add support for chromium-mac
 116         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
 117         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
 118
 119 2011-09-21  Adam Barth  <abarth@webkit.org>
 120
 121         garden-o-matic command should explain that it is starting a local server
 122         https://bugs.webkit.org/show_bug.cgi?id=68486
 123
 124         Reviewed by Dimitri Glazkov.
 125
 126         In the user study, both participants didn't understand why the
 127         garden-o-matic command appeared to hang.  This patch adds an
 128         explaination of what's going on.  It also adds a confirmation prompt
 129         before launching the browser to give the user a chance to read the
 130         text.  If that's too much of a speed bump, we can iterate.
 131
 132         * Scripts/webkitpy/tool/commands/gardenomatic.py:
 133
 134 2011-09-21  Chang Shu  <cshu@webkit.org>
 135
 136         [Qt] Implement KeyDown function for WebKit2 EventSender.
 137         https://bugs.webkit.org/show_bug.cgi?id=56485
 138
 139         Implement the KeyDown function on Qt platform.
 140
 141         Reviewed by Andreas Kling.
 142
 143         * WebKitTestRunner/PlatformWebView.h:
 144         * WebKitTestRunner/TestController.cpp:
 145         (WTR::TestController::TestController):
 146         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
 147         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
 148         (WTR::getModifiers):
 149         (WTR::EventSenderProxy::keyDown):
 150         (buildModifierFlags):
 151         (EventSenderProxy::keyDown):
 152         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 153         (WTR::PlatformWebView::sendEvent):
 154         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 155
 156 2011-09-20  Adam Barth  <abarth@webkit.org>
 157
 158         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
 159         https://bugs.webkit.org/show_bug.cgi?id=68496
 160
 161         Reviewed by Dimitri Glazkov.
 162
 163         This patch adds a bunch of sorting to make sure things happen in a
 164         predictable order in both JavaScriptCore and V8.  We've talked before
 165         about whether these two JavaScript engines should enumerate
 166         dictionaries in the same order, but the consensus has been that they
 167         shouldn't.  Personally, I disagree with that consensus, but such is life.
 168
 169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
 170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
 171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
 172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
 173
 174 2011-09-20  Adam Barth  <abarth@webkit.org>
 175
 176         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
 177         https://bugs.webkit.org/show_bug.cgi?id=68495
 178
 179         Reviewed by Dimitri Glazkov.
 180
 181         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
 182
 183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
 184
 185 2011-09-20  Eric Seidel  <eric@webkit.org>
 186
 187         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
 188         https://bugs.webkit.org/show_bug.cgi?id=65781
 189
 190         Reviewed by Ryosuke Niwa.
 191
 192         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
 193         to resolve the passed in url relative to the absolute url for the test.
 194         For http tests, since the test url is an http url, we can't resolve relative
 195         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
 196         for resolving.
 197
 198         I believe this is a better approach than the on used in the Qt and Chromium DRT's
 199         (which resolves the path relative to the built location of the DRT executable)
 200         and we should move this new code into a shared location in a follow-up patch.
 201
 202         It turns out that there was a second use for pathToLocalResource, used by one
 203         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
 204         To support this test I made the new pathToLocalResource smart enough to map
 205         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
 206
 207         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 208         (LayoutTestController::pathToLocalResource):
 209         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
 210
 211 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
 212
 213         Need to specify a django version, instead of using default
 214         https://bugs.webkit.org/show_bug.cgi?id=68398
 215
 216         Reviewed by Eric Seidel.
 217
 218         * QueueStatusServer/__init__.py:
 219         * QueueStatusServer/main.py:
 220
 221 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
 222
 223         Update committers.py with a few more contributor contacts
 224         https://bugs.webkit.org/show_bug.cgi?id=68487
 225
 226         Reviewed by Eric Seidel.
 227
 228         * Scripts/webkitpy/common/config/committers.py:
 229
 230 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
 231
 232         Fix webkitpy unit tests after 95547 and 95549
 233         https://bugs.webkit.org/show_bug.cgi?id=68483
 234
 235         Reviewed by Adam Barth.
 236
 237         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
 238
 239         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
 240         parse_entries_from_file(), use StringIO and entry.reviewer_text().
 241         While testing parse_latest_entry_from_file(), expect the correct
 242         touched_files() list.
 243
 244 2011-09-20  Adam Barth  <abarth@webkit.org>
 245
 246         garden-o-matic makes it hard to compare images when scroll bars appear
 247         https://bugs.webkit.org/show_bug.cgi?id=68482
 248
 249         Reviewed by Eric Seidel.
 250
 251         Because we autoscale image width, the images rescale if we overflow
 252         vertically and get a scrollbar.  That makes it hard to compare two sets
 253         of images.  This patch reserves space for the scrollbar so we won't
 254         have the layout change.
 255
 256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
 257
 258 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 259
 260         Unreviewed, rolling out r95565.
 261         http://trac.webkit.org/changeset/95565
 262         https://bugs.webkit.org/show_bug.cgi?id=68470
 263
 264         Broke builds (Requested by andersca on #webkit).
 265
 266         * MiniBrowser/gtk/BrowserWindow.c:
 267         (mouseDidMoveOverElement):
 268
 269 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
 270
 271         Get hover'ed element URL from HitTest.
 272
 273         mouseDidMoveOverElement now gets the hover'ed element link using
 274         WKHitTestResult API's.
 275         https://bugs.webkit.org/show_bug.cgi?id=68426
 276
 277         Reviewed by Anders Carlsson.
 278
 279         * MiniBrowser/gtk/BrowserWindow.c:
 280         (mouseDidMoveOverElement):
 281
 282 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
 283
 284         Changelog class should have a method to return all entries
 285         https://bugs.webkit.org/show_bug.cgi?id=68399
 286
 287         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
 288         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
 289
 290         Reviewed by Ryosuke Niwa.
 291
 292         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
 293         and adapt it to become a generator.
 294         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
 295
 296 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
 297
 298         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
 299         https://bugs.webkit.org/show_bug.cgi?id=51159
 300
 301         Permit any URL with a local scheme to set a user style sheet. Allow qrc
 302         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
 303
 304         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
 305
 306         Reviewed by Kenneth Rohde Christiansen.
 307
 308         * DumpRenderTree/qt/DumpRenderTree.pro:
 309         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
 310         * DumpRenderTree/qt/resources/user.css: Added.
 311         (body):
 312         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 313         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
 314         * WebKitTestRunner/qt/resources/user.css: Added.
 315         (body):
 316
 317 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
 318
 319         ChangeLogEntry class should contain a list of touched files
 320         https://bugs.webkit.org/show_bug.cgi?id=68115
 321
 322         Reviewed by Eric Seidel.
 323
 324         Add method to return the list of files touched in a ChangeLog entry.
 325
 326         * Scripts/webkitpy/common/checkout/changelog.py: Add
 327         touched_files_regexp and touched_files() method.
 328         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
 329         unit tests for touched_files() method.
 330
 331 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 332
 333         Unreviewed, rolling out r95526 and r95541.
 334         http://trac.webkit.org/changeset/95526
 335         http://trac.webkit.org/changeset/95541
 336         https://bugs.webkit.org/show_bug.cgi?id=68443
 337
 338         It broke 6 tests (Requested by ossy_ on #webkit).
 339
 340         * DumpRenderTree/qt/main.cpp:
 341         (main):
 342         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
 343         (WTR::activateFonts):
 344
 345 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
 346
 347         Fix patch and bug numbering in the mocktool simulation code
 348         https://bugs.webkit.org/show_bug.cgi?id=68374
 349
 350         Reviewed by Adam Barth.
 351
 352         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 353         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
 354         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 355         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
 356         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
 357         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
 358         * Scripts/webkitpy/tool/commands/download_unittest.py:
 359         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 360         * Scripts/webkitpy/tool/commands/queries_unittest.py:
 361         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 362         * Scripts/webkitpy/tool/commands/queuestest.py:
 363         * Scripts/webkitpy/tool/commands/upload_unittest.py:
 364         * Scripts/webkitpy/tool/mocktool.py:
 365         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 366         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
 367
 368 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 369
 370         [Qt] Don't override default QApplication font for DRT and WTR
 371
 372         Revision 95526 moved the relevant code below the QApplication
 373         constructor, to fix a potential crash, and that made the code
 374         take effect, breaking 6 tests.
 375
 376         We should rely on the QWebSettings to set default fonts, and
 377         this QApplication::setFont() is a relic from when we didn't
 378         have that option, so we remove the code.
 379
 380         Reviewed by Csaba Osztrogonác.
 381
 382         * DumpRenderTree/qt/main.cpp:
 383         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
 384
 385 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 386
 387         WebKitTestRunner: Provide usage if run without arguments
 388
 389         If WTR is run without either one or more filenames, or
 390         a '-' to indicate server mode, we don't need to start
 391         up the test machinery. Doing so might actually crash,
 392         as we'll exit the application immedeatly after anyways.
 393
 394         Reviewed by Simon Hausmann.
 395
 396         * WebKitTestRunner/TestController.cpp:
 397         (WTR::TestController::initialize):
 398
 399 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 400
 401         [Qt] Don't use QFont before initializing QApplication
 402
 403         Could potentially result in crash.
 404
 405         Reviewed by Simon Hausmann.
 406
 407         * DumpRenderTree/qt/main.cpp:
 408         (main):
 409
 410 2011-09-19  Adam Barth  <abarth@webkit.org>
 411
 412         Always enable ENABLE(EVENTSOURCE)
 413         https://bugs.webkit.org/show_bug.cgi?id=68414
 414
 415         Reviewed by Eric Seidel.
 416
 417         * Scripts/build-webkit:
 418
 419 2011-09-19  David Levin  <levin@chromium.org>
 420
 421         Sheriffbot rollout should be more intuitive.
 422         https://bugs.webkit.org/show_bug.cgi?id=68415
 423
 424         Reviewed by Adam Barth.
 425
 426         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
 427         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
 428           and a few others cases.
 429         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
 430
 431 2011-09-19  David Levin  <levin@chromium.org>
 432
 433         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
 434         https://bugs.webkit.org/show_bug.cgi?id=68391
 435
 436         Reviewed by Darin Adler.
 437
 438         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
 439         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
 440
 441 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
 442
 443         Style checker should not check public Qt WK2 API for parameter_name.
 444         https://bugs.webkit.org/show_bug.cgi?id=68359
 445
 446         Reviewed by Andreas Kling.
 447
 448         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
 449         Add an exception in the style checker to disable the check. Also added the test for it.
 450
 451         * Scripts/webkitpy/style/checker.py:
 452         * Scripts/webkitpy/style/checker_unittest.py:
 453
 454 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
 455
 456         GTK DRT leaks memory while comparing history items
 457         https://bugs.webkit.org/show_bug.cgi?id=68086
 458
 459         Reviewed by Martin Robinson.
 460
 461         webkit_web_history_item_get_target() returns a g_strdup()'d string,
 462         so memory must be freed before compareHistoryItems() returns.
 463
 464         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 465         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
 466
 467 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 468
 469         Buildbot marks a nrwt bot red when tests are missing results
 470         https://bugs.webkit.org/show_bug.cgi?id=64812
 471
 472         Reviewed by Ryosuke Niwa.
 473
 474         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 475         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 476
 477 2011-09-19  Jessie Berlin  <jberlin@apple.com>
 478
 479         Sites that use history pushState or replaceState are recorded in history in Private Browsing
 480         mode.
 481         https://bugs.webkit.org/show_bug.cgi?id=68208
 482
 483         Reviewed by Brady Eidson.
 484
 485         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
 486         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
 487
 488         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
 489         (TestWebKitAPI::didNavigateWithNavigationData):
 490         This is a context history client callback, so it should not be called when in Private
 491         Browsing. Add a call to FAIL().
 492         (TestWebKitAPI::didSameDocumentNavigationForFrame):
 493         This is a page load client callback that happens after the didNavigateWithNavigationData
 494         callback. End the test.
 495         (TestWebKitAPI::TEST):
 496         Enable Private Browsing and load a page that uses history.pushState.
 497
 498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 499         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
 500         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
 501         Ditto.
 502         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 503         Ditto.
 504         * TestWebKitAPI/win/copy-resources.cmd:
 505         Ditto.
 506
 507 2011-09-16  Elliot Poger  <epoger@google.com>
 508
 509         add non-CG Webkit-Mac builds to flakiness dashboard
 510         https://bugs.webkit.org/show_bug.cgi?id=68265
 511
 512         Reviewed by Adam Barth.
 513
 514         As Chromium-on-Mac approaches the switchover from Core Graphics to
 515         Skia, we need to add the Skia version to the flakiness dashboard.
 516
 517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
 518         * TestResultServer/static-dashboards/builders.js:
 519         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
 520
 521 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
 522
 523         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
 524         https://bugs.webkit.org/show_bug.cgi?id=68071
 525
 526         Reviewed by Adam Barth.
 527
 528         * DumpRenderTree/chromium/WebPermissions.cpp:
 529         (WebPermissions::allowImage):
 530         * DumpRenderTree/chromium/WebPermissions.h:
 531
 532 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
 533
 534         update-webkit-chromium should retry the gclient call if it fails once
 535         https://bugs.webkit.org/show_bug.cgi?id=68252
 536
 537         Reviewed by Adam Barth.
 538
 539         * Scripts/update-webkit-chromium:
 540
 541 2011-09-16  Rob Buis  <rbuis@rim.com>
 542
 543         Add Eli's rim address and change the nick.
 544
 545         * Scripts/webkitpy/common/config/committers.py:
 546
 547 2011-09-16  Anders Carlsson  <andersca@apple.com>
 548
 549         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
 550         https://bugs.webkit.org/show_bug.cgi?id=68269
 551
 552         Reviewed by Geoffrey Garen.
 553
 554         Update client function signatures.
 555
 556         * MiniBrowser/gtk/BrowserWindow.c:
 557         (browserWindowUIClientInit):
 558         * MiniBrowser/mac/BrowserWindowController.m:
 559         (mouseDidMoveOverElement):
 560         (-[BrowserWindowController awakeFromNib]):
 561         * MiniBrowser/win/BrowserView.cpp:
 562         (BrowserView::create):
 563         * WebKitTestRunner/TestController.cpp:
 564         (WTR::TestController::createOtherPage):
 565         (WTR::TestController::initialize):
 566
 567 2011-09-16  Anders Carlsson  <andersca@apple.com>
 568
 569         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
 570         https://bugs.webkit.org/show_bug.cgi?id=68266
 571
 572         Reviewed by John Sullivan.
 573
 574         * MiniBrowser/mac/BrowserWindowController.m:
 575         (mouseDidMoveOverElement):
 576
 577 2011-09-16  Vincent Scheib  <scheib@chromium.org>
 578
 579         Add Vincent Scheib to the committers list.
 580
 581         * Scripts/webkitpy/common/config/committers.py:
 582
 583 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
 584
 585         Unreviewed, rolling out r95285.
 586         http://trac.webkit.org/changeset/95285
 587         https://bugs.webkit.org/show_bug.cgi?id=68247
 588
 589         It broke a webkitpy test (Requested by ossy on #webkit).
 590
 591         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 592
 593 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 594
 595         Buildbot marks a nrwt bot red when tests are missing results
 596         https://bugs.webkit.org/show_bug.cgi?id=64812
 597
 598         Reviewed by Dirk Pranke.
 599
 600         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 601
 602 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
 603
 604         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
 605         https://bugs.webkit.org/show_bug.cgi?id=68178
 606
 607         Reviewed by Xan Lopez.
 608
 609         Add a work-around to enable WebKit2 when using build-webkit.
 610
 611         * Scripts/webkitdirs.pm:
 612         (buildAutotoolsProject):
 613
 614 2011-09-15  James Robinson  <jamesr@chromium.org>
 615
 616         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
 617
 618         * Scripts/webkitpy/common/config/committers.py:
 619
 620 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
 621
 622         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
 623         https://bugs.webkit.org/show_bug.cgi?id=68003
 624
 625         Reviewed by Adam Barth.
 626
 627         * Scripts/webkitpy/tool/mocktool.py:
 628         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
 629         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
 630
 631 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
 632
 633         Python version check is confusing in test-webkitpy
 634         https://bugs.webkit.org/show_bug.cgi?id=68004
 635
 636         Reviewed by Adam Barth.
 637
 638         * Scripts/test-webkitpy:
 639
 640 2011-09-15  Eric Seidel  <eric@webkit.org>
 641
 642         Reviewed by Adam Barth.
 643
 644         webkit-patch should be able to find users and add them to bugzilla groups
 645         https://bugs.webkit.org/show_bug.cgi?id=63351
 646
 647         These are both very basic commands.  But it's now possible to find
 648         all users matching a regexp, as well as add all users matching a regexp
 649         to a set of groups.
 650
 651         bugzilla.py already knew how to find users (for validate-committer-lists)
 652         but now it has the ability to modify the user records.
 653
 654         I split some of the logic out into a new EditUsersParser class
 655         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
 656
 657         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 658         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
 659         * Scripts/webkitpy/tool/commands/__init__.py:
 660         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
 661         * Scripts/webkitpy/tool/commands/findusers.py: Added.
 662
 663 2011-09-15  Eric Seidel  <eric@webkit.org>
 664
 665         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
 666         https://bugs.webkit.org/show_bug.cgi?id=68182
 667
 668         Reviewed by Adam Barth.
 669
 670         * Scripts/build-webkit:
 671         * waf/build/settings.py:
 672
 673 2011-09-15  Eric Seidel  <eric@webkit.org>
 674
 675         Unreviewed.  Make contributor email look-up case-insensitive.
 676
 677         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
 678         was missing from committers.py due to case sensitivity.
 679
 680         This also includes a test expectations update to committers_unittest.py
 681         after my previous change.
 682
 683         * Scripts/webkitpy/common/config/committers.py:
 684         * Scripts/webkitpy/common/config/committers_unittest.py:
 685         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
 686
 687 2011-09-15  Eric Seidel  <eric@webkit.org>
 688
 689         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
 690
 691         Add a bunch of email aliases to committers.py for regular contributors
 692         who are committing using other email addresses than they have listed in the file.
 693
 694         * Scripts/webkitpy/common/config/committers.py:
 695
 696 2011-09-15  Eric Seidel  <eric@webkit.org>
 697
 698         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
 699         https://bugs.webkit.org/show_bug.cgi?id=68022
 700
 701         Reviewed by Ryosuke Niwa.
 702
 703         * Scripts/build-webkit:
 704         * waf/build/settings.py:
 705
 706 2011-09-15  Anders Carlsson  <andersca@apple.com>
 707
 708         Fix Mac build by including config.h where needed.
 709
 710         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
 711         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
 712         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
 713         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
 714         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
 715         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
 716         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
 717         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
 718         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
 719         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
 720         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
 721         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
 722         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
 723         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
 724         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
 725         * TestWebKitAPI/mac/main.mm:
 726
 727 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
 728
 729         Let TestWebKitAPI work for chromium
 730         https://bugs.webkit.org/show_bug.cgi?id=67756
 731
 732         Reviewed by Sam Weinig.
 733
 734         * Scripts/build-api-tests:
 735         * Scripts/run-api-tests:
 736         (isSupportedPlatform):
 737         (runTest):
 738         (populateTests):
 739         * Scripts/webkitdirs.pm:
 740         (determineBaseProductDir):
 741         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
 742         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
 743         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
 744         * TestWebKitAPI/InjectedBundleController.cpp:
 745         * TestWebKitAPI/InjectedBundleMain.cpp:
 746         * TestWebKitAPI/JavaScriptTest.cpp:
 747         * TestWebKitAPI/PlatformUtilities.cpp:
 748         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
 749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 750         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
 751         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 752         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
 753         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
 754         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
 755         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
 756         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
 757         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
 758         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
 759         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
 760         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
 761         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
 762         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
 763         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
 764         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
 765         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
 766         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
 767         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
 768         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
 769         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
 770         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
 771         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
 772         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
 773         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
 774         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
 775         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
 776         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
 777         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
 778         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
 779         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
 780         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
 781         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
 782         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
 783         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
 784         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
 785         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
 786         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
 787         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
 788         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
 789         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
 790         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
 791         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
 792         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
 793         * TestWebKitAPI/TestsController.cpp:
 794         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
 795         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
 796         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
 797         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
 798         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 799         * TestWebKitAPI/win/main.cpp:
 800
 801 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
 802
 803         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
 804         https://bugs.webkit.org/show_bug.cgi?id=68145
 805
 806         This will allow for other classes in DumpRenderTree to reuse this functionality
 807
 808         Reviewed by David Levin.
 809
 810         * DumpRenderTree/chromium/TestShell.cpp:
 811         (normalizeLayoutTestURLInternal):
 812         (dumpHistoryItem):
 813         (TestShell::normalizeLayoutTestURL):
 814         * DumpRenderTree/chromium/TestShell.h:
 815
 816 2011-09-14  Ada Chan  <adachan@apple.com>
 817
 818         Add test for WKBundleFrameCopyWebArchive().
 819         https://bugs.webkit.org/show_bug.cgi?id=67857
 820
 821         Reviewed by Anders Carlsson.
 822
 823         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
 824         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
 825         the returned data is a valid webarchive.
 826         (TestWebKitAPI::setInjectedBundleClient):
 827         (TestWebKitAPI::didFinishLoadForFrame):
 828         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
 829         injected bundle for the webarchive and check the returned webarchive.
 830         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
 831         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
 832         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
 833         the web archive.
 834
 835         Add files to project.
 836         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
 837         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
 838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 839
 840 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
 841
 842         committers.py should support multiple IRC nicknames
 843         https://bugs.webkit.org/show_bug.cgi?id=68110
 844
 845         Reviewed by Eric Seidel.
 846
 847         Add multiple IRC nickname support to committers.py
 848
 849         * Scripts/webkitpy/common/config/committers.py:
 850         * Scripts/webkitpy/common/config/committers_unittest.py:
 851         * Scripts/webkitpy/tool/bot/irc_command.py:
 852         * Scripts/webkitpy/tool/bot/sheriff.py:
 853
 854 2011-09-14  Jon Lee  <jonlee@apple.com>
 855
 856         Implement globalFlag for WebKitTestRunner
 857         https://bugs.webkit.org/show_bug.cgi?id=68033
 858         <rdar://problem/10119204>
 859
 860         Reviewed by Sam Weinig.
 861
 862         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
 863         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 864         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
 865         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
 866         (WTR::LayoutTestController::globalFlag): simple getter
 867         (WTR::LayoutTestController::setGlobalFlag): simple setter
 868
 869 2011-09-13  Eric Seidel  <eric@webkit.org>
 870
 871         Remove ENABLE_SVG_USE as <use> is required by HTML5
 872         https://bugs.webkit.org/show_bug.cgi?id=68019
 873
 874         Reviewed by Ryosuke Niwa.
 875
 876         * Scripts/build-webkit:
 877         * waf/build/settings.py:
 878
 879 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
 880
 881         Remove Jan Erik Hanssen (added in my r95078) from the list for now
 882         since I can't confirm acceptable his committership.
 883
 884         * Scripts/webkitpy/common/config/committers.py:
 885
 886 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
 887
 888         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
 889         https://bugs.webkit.org/show_bug.cgi?id=68066
 890
 891         Reviewed by Adam Barth.
 892
 893         * DumpRenderTree/chromium/WebViewHost.cpp:
 894         * DumpRenderTree/chromium/WebViewHost.h:
 895
 896 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
 897
 898         committers.py is missing some contributors
 899         https://bugs.webkit.org/show_bug.cgi?id=68059
 900
 901         Reviewed by Adam Barth.
 902
 903         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
 904
 905         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
 906
 907         * Scripts/webkitpy/common/config/committers.py:
 908
 909 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
 910
 911         Fix webkit python test after r95061.
 912
 913         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
 914
 915 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
 916
 917         Add myself as a contributor. No review needed.
 918
 919         * Scripts/webkitpy/common/config/committers.py:
 920
 921 2011-09-13  Adam Barth  <abarth@webkit.org>
 922
 923         garden-o-matic has unfriendly error messages when the local server is not available
 924         https://bugs.webkit.org/show_bug.cgi?id=68042
 925
 926         Reviewed by Dimitri Glazkov.
 927
 928         This patch moves us from using alert to showing the error inline in the
 929         progress dialog.
 930
 931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
 932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
 933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
 934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
 935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
 936
 937 2011-09-13  Adam Barth  <abarth@webkit.org>
 938
 939         FailureGrid in garden-o-matic should link to the builder's waterfall page
 940         https://bugs.webkit.org/show_bug.cgi?id=68036
 941
 942         Reviewed by Dimitri Glazkov.
 943
 944         One of the users in the user study thought the configurations names in
 945         the failure grid would link to the underlying bots.  That makes sense,
 946         so this patch adds the behavior.
 947
 948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
 949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
 950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
 951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
 952
 953 2011-09-13  Adam Barth  <abarth@webkit.org>
 954
 955         garden-o-matic should be able to mark failures as expected
 956         https://bugs.webkit.org/show_bug.cgi?id=68027
 957
 958         Reviewed by Dimitri Glazkov.
 959
 960         All the back-end infrastructure exists for this operation.  This patch
 961         just adds some UI to the front-end and wires that UI up to the back
 962         end.  This exact UI will likely need some more polish, but this should
 963         be a reasonable first cut.
 964
 965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
 966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
 967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
 968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
 969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
 970
 971 2011-09-13  Adam Barth  <abarth@webkit.org>
 972
 973         garden-o-matic should tell you about the progress of your rebaseline
 974         https://bugs.webkit.org/show_bug.cgi?id=67967
 975
 976         Reviewed by Dimitri Glazkov.
 977
 978         This patch adds ui.MessageBox, which is a light wrapper around jQuery
 979         UI's dialog widget.  We then use ui.MessageBox to show status messages
 980         about in-progress rebaselines.  As each baseline is downloaded, the
 981         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
 982
 983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
 984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
 985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
 986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
 987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
 988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
 989
 990 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
 991
 992         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
 993         https://bugs.webkit.org/show_bug.cgi?id=68024
 994
 995         Reviewed by Gustavo Noronha Silva.
 996
 997         Using g_list_count() and g_list_nth_data() together on a loop is
 998         inneficient since they're both O(n). Iterate over lists in a saner
 999         way.
1000
1001         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1002         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
1003         iterate on it using g_list_next(). Free the list after done with it.
1004         (dumpBackForwardListForWebView): Instead of appending (which is
1005         expensive in GLists) history items and then iterating from the tail
1006         of the itemsToPrint list, prepend items and walk forwards as usual.
1007         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
1008         remove the (unneeded) viewList variable.
1009
1010 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1011
1012         Add Eric's IRC nick.
1013
1014         * Scripts/webkitpy/common/config/committers.py:
1015
1016 2011-09-13  Anders Carlsson  <andersca@apple.com>
1017
1018         Disable C++ exceptions when building with clang
1019         https://bugs.webkit.org/show_bug.cgi?id=68031
1020         <rdar://problem/9556880>
1021
1022         Reviewed by Mark Rowe.
1023
1024         * MiniBrowser/Configurations/Base.xcconfig:
1025         * TestWebKitAPI/Configurations/Base.xcconfig:
1026         * WebKitTestRunner/Configurations/Base.xcconfig:
1027
1028 2011-09-13  Ojan Vafai  <ojan@chromium.org>
1029
1030         [chromium] fix flakiness dashboard for chromium interactive tests
1031         https://bugs.webkit.org/show_bug.cgi?id=68029
1032
1033         Reviewed by Tony Chang.
1034
1035         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1036         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1037
1038 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1039
1040         Add Alice and Aryeh to the list of contributors.
1041
1042         * Scripts/webkitpy/common/config/committers.py:
1043
1044 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1045
1046         sheriffbot whois should also tell us email addresses
1047         https://bugs.webkit.org/show_bug.cgi?id=67975
1048
1049         Reviewed by Eric Seidel and David Levin.
1050
1051         Taught sheriffbot how to tell us contributor's email addresses.
1052
1053         * Scripts/webkitpy/tool/bot/irc_command.py:
1054         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1055
1056 2011-09-13  Eric Seidel  <eric@webkit.org>
1057
1058         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
1059         https://bugs.webkit.org/show_bug.cgi?id=68018
1060
1061         Reviewed by Ryosuke Niwa.
1062
1063         * Scripts/build-webkit:
1064         * waf/build/settings.py:
1065
1066 2011-09-13  Chang Shu  <cshu@webkit.org>
1067
1068         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
1069         https://bugs.webkit.org/show_bug.cgi?id=57515
1070
1071         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
1072         TestController synchronously. The latter then sends simulated event to WebKit2 module,
1073         which is synchronous, too.
1074
1075         Reviewed by Darin Adler.
1076
1077         * WebKitTestRunner/EventSenderProxy.h: Added.
1078         (WTR::EventSenderProxy::EventSenderProxy):
1079         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1080         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1081         (WTR::EventSendingController::keyDown):
1082         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1083         * WebKitTestRunner/PlatformWebView.h:
1084         (WTR::PlatformWebView::platformWindow):
1085         * WebKitTestRunner/TestController.cpp:
1086         (WTR::TestController::TestController):
1087         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1088         * WebKitTestRunner/TestController.h:
1089         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1090         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
1091         (WTR::buildModifierFlags):
1092         (WTR::EventSenderProxy::keyDown):
1093
1094 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
1095
1096         [EFL] DRT: Add DumpRenderTreeEfl.h
1097         https://bugs.webkit.org/show_bug.cgi?id=63993
1098
1099         Reviewed by Eric Seidel.
1100
1101         This header contains some global variables used by EFL's
1102         DumpRenderTree implementation.
1103
1104         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
1105         appropriate.
1106         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
1107
1108 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
1109
1110         [EFL] Send the right key names for PageUp and PageDown.
1111         https://bugs.webkit.org/show_bug.cgi?id=67044
1112
1113         Reviewed by Kenneth Rohde Christiansen.
1114
1115         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
1116         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
1117         However, EventSender was sending "Page_Up" and "Page_Down", so tests
1118         such as editing/input/page-up-down-scrolls.html were timing out due to
1119         the right key down events not being sent.
1120
1121         * DumpRenderTree/efl/EventSender.cpp:
1122         (keyPadNameFromJSValue):
1123         (keyNameFromJSValue):
1124
1125 2011-09-12  Eric Seidel  <eric@webkit.org>
1126
1127         sheriffbot whois is case sensitive
1128         https://bugs.webkit.org/show_bug.cgi?id=67972
1129
1130         Reviewed by Adam Barth.
1131
1132         I also fixed a typo in the "More than 5 contributors" message
1133         from my previous commit.
1134
1135         * Scripts/webkitpy/common/config/committers.py:
1136         * Scripts/webkitpy/common/config/committers_unittest.py:
1137         * Scripts/webkitpy/tool/bot/irc_command.py:
1138         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1139
1140 2011-09-12  Eric Seidel  <eric@webkit.org>
1141
1142         sheriffbot whois should be smarter
1143         https://bugs.webkit.org/show_bug.cgi?id=67971
1144
1145         Reviewed by Adam Barth.
1146
1147         This makes sheriffbot whois basically grep the committers list
1148         making it much easier to find a contributor by name.
1149
1150         Unfortunately the current unittests depend on the real committers.py
1151         file, so as we add more eric's to the project, this unittest result will
1152         change.  I think that's OK for now.  We'll fix it when it breaks.
1153
1154         * Scripts/webkitpy/common/config/committers.py:
1155         * Scripts/webkitpy/tool/bot/irc_command.py:
1156         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1157
1158 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1159
1160         Unreviewed, rolling out r94976.
1161         http://trac.webkit.org/changeset/94976
1162         https://bugs.webkit.org/show_bug.cgi?id=67953
1163
1164         Broke a bunch of security/load& tests (Requested by rniwa on
1165         #webkit).
1166
1167         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1168         (LayoutTestController::pathToLocalResource):
1169
1170 2011-09-12  Eric Seidel  <eric@webkit.org>
1171
1172         Rubber-stamped by Adam Barth.
1173
1174         Remove the "the tree is burning!" warning previously shown
1175         when landing patches.  It was a dream.  But it's just noise now.
1176
1177         Some bots will require a restart to notice the removal of the option
1178         so I've left the --ignore-builders option in for now.
1179
1180         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1181         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1182         * Scripts/webkitpy/tool/commands/download.py:
1183         * Scripts/webkitpy/tool/commands/download_unittest.py:
1184         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1185         * Scripts/webkitpy/tool/steps/__init__.py:
1186         * Scripts/webkitpy/tool/steps/commit.py:
1187         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
1188         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1189
1190 2011-09-12  Eric Seidel  <eric@webkit.org>
1191
1192         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1193         https://bugs.webkit.org/show_bug.cgi?id=65781
1194
1195         Reviewed by Ryosuke Niwa.
1196
1197         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
1198         to resolve the passed in url relative to the absolute url for the test.
1199
1200         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1201         (which resolves the path relative to the built location of the DRT executable)
1202         and we should move this new code into a shared location in a follow-up patch.
1203
1204         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1205         (LayoutTestController::pathToLocalResource):
1206
1207 2011-09-12  Eric Seidel  <eric@webkit.org>
1208
1209         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1210         https://bugs.webkit.org/show_bug.cgi?id=67530
1211
1212         Reviewed by Adam Barth.
1213
1214         I believe I've fixed the bug in the original patch which prompted the rollout.
1215         The previous patch was using the wrong deadline for the initial read,
1216         subtracting time.time() twice from the deadline value.
1217
1218         * Scripts/webkitpy/layout_tests/port/webkit.py:
1219         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1220
1221 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
1222
1223         [Qt][WK2] WebKitTestRunner does not produce crash logs
1224         https://bugs.webkit.org/show_bug.cgi?id=67714
1225
1226         Reviewed by Chang Shu.
1227
1228         Added a simple way of generating backtrace on crash
1229         to the web process. The implementation is similar what
1230         we have in DRT. It depends on GNU libc functionality
1231         so it is only enabled where we are running in such an environment.
1232
1233         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1234         (WTR::printBacktrace):
1235         (WTR::crashHandler):
1236         (WTR::InjectedBundle::platformInitialize):
1237
1238 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
1239
1240         Added my IRC nick to the committers file.
1241
1242         * Scripts/webkitpy/common/config/committers.py:
1243
1244 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1245
1246         The executable allocator makes it difficult to free individual
1247         chunks of executable memory
1248         https://bugs.webkit.org/show_bug.cgi?id=66363
1249
1250         Reviewed by Oliver Hunt.
1251
1252         Introduced a best-fit, balanced-tree based allocator. The allocator
1253         required a balanced tree that does not allocate memory and that
1254         permits the removal of individual nodes directly (as opposed to by
1255         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1256         Changed all references to executable code to use a reference counted
1257         handle.
1258
1259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1260         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1261         (TestWebKitAPI::TEST_F):
1262         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1263         (TestWebKitAPI::Pair::findExact):
1264         (TestWebKitAPI::Pair::remove):
1265         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1266         (TestWebKitAPI::Pair::assertFoundAndRemove):
1267         (TestWebKitAPI::Pair::assertEqual):
1268         (TestWebKitAPI::Pair::assertSameValuesForKey):
1269         (TestWebKitAPI::Pair::testDriver):
1270         (TestWebKitAPI::TEST_F):
1271
1272 2011-09-10  Andy Estes  <aestes@apple.com>
1273
1274         Move myself from committers_unable_to_review to reviewers_list.
1275
1276         * Scripts/webkitpy/common/config/committers.py:
1277
1278 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1279
1280         [wx] Unreviewed build fix. MSW build fixes.
1281
1282         * DumpRenderTree/config.h:
1283         * waf/build/wxpresets.py:
1284
1285 2011-09-10  Andreas Kling  <kling@webkit.org>
1286
1287         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1288         https://bugs.webkit.org/show_bug.cgi?id=59328
1289
1290         Reviewed by Kenneth Rohde Christiansen.
1291
1292         * MiniBrowser/mac/BrowserWindowController.m:
1293         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1294
1295 2011-09-10  Adam Barth  <abarth@webkit.org>
1296
1297         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1298         and does not have access to notImplemented().
1299
1300         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1301         (openStartupDialog):
1302
1303 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1304
1305         Add a script to create a monolithic script-test
1306         https://bugs.webkit.org/show_bug.cgi?id=67747
1307
1308         Reviewed by Darin Adler.
1309
1310         * Scripts/make-new-script-test: Added.
1311
1312 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1313
1314         Adding myself to the reviewers list.
1315
1316         * Scripts/webkitpy/common/config/committers.py:
1317
1318 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1319
1320         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1321         https://bugs.webkit.org/show_bug.cgi?id=67855
1322
1323         Reviewed by Dirk Pranke.
1324
1325         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1326         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1327
1328         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1329
1330         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1331
1332 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1333
1334         Add myself to committers.py
1335         https://bugs.webkit.org/show_bug.cgi?id=67853
1336
1337         Reviewed by Darin Adler.
1338
1339         * Scripts/webkitpy/common/config/committers.py:
1340
1341 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1342
1343         [Qt] Remove common.pri
1344         https://bugs.webkit.org/show_bug.cgi?id=67814
1345
1346         Reviewed by Andreas Kling.
1347
1348         * Tools.pro:
1349
1350 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1351
1352         [NRWT] the nrwt check httpd with --no-http option
1353         https://bugs.webkit.org/show_bug.cgi?id=67835
1354
1355         Reviewed by Tony Chang.
1356
1357         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1358         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1359
1360 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1361
1362         [chromium] Implement DRT support for Android.
1363         https://bugs.webkit.org/show_bug.cgi?id=67590
1364
1365         Reviewed by Tony Chang.
1366
1367         Add 2 mechanism to make DRT interaction more robust on Android:
1368         - Send 'QUIT' to DRT to make it stop.
1369         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1370         input commands before it starts.
1371         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1372         and <clocale> for 'LC_ALL' to compile on Android.
1373
1374         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1375         as signal() man page recommends using sigaction().
1376
1377         * DumpRenderTree/DumpRenderTree.gypi:
1378         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1379         (main):
1380         * DumpRenderTree/chromium/LayoutTestController.cpp:
1381         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1382         (AlarmHandler):
1383         (TestShell::waitTestFinished):
1384         (platformInit):
1385         (openStartupDialog):
1386         (checkLayoutTestSystemDependencies):
1387         * DumpRenderTree/chromium/TestShellGtk.cpp:
1388         (AlarmHandler):
1389         (TestShell::waitTestFinished):
1390
1391 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1392
1393         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1394
1395         * waf/build/settings.py:
1396
1397 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1398
1399         Unreviewed, rolling out r94851.
1400         http://trac.webkit.org/changeset/94851
1401         https://bugs.webkit.org/show_bug.cgi?id=67847
1402
1403         It broke a webkitpy test (Requested by ossy on #webkit).
1404
1405         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1406
1407 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1408
1409         [NRWT] the nrwt check httpd with --no-http option
1410         https://bugs.webkit.org/show_bug.cgi?id=67835
1411
1412         Reviewed by Csaba Osztrogonác.
1413
1414         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1415
1416 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1417
1418         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1419         https://bugs.webkit.org/show_bug.cgi?id=67794
1420         <rdar://problem/9892024>
1421
1422         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1423
1424         Reviewed by Brady Eidson.
1425
1426         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1427         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1428         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1429         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1430             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1431             didPerformServerRedirect.
1432
1433         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1434         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1435             our InjectedBundleTest.
1436         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1437             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1438             the request.
1439         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1440
1441         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1442
1443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1444         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1445         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1446         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1447
1448 2011-09-08  David Levin  <levin@chromium.org>
1449
1450         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1451         https://bugs.webkit.org/show_bug.cgi?id=67797
1452
1453         Reviewed by Eric Seidel.
1454
1455         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1456         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1457
1458 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1459
1460         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1461         https://bugs.webkit.org/show_bug.cgi?id=67723
1462
1463         Reviewed by Adam Barth.
1464
1465         * DumpRenderTree/chromium/EventSender.h:
1466         * DumpRenderTree/chromium/LayoutTestController.cpp:
1467         (LayoutTestController::LayoutTestController):
1468         (LayoutTestController::enableFixedLayoutMode):
1469         (LayoutTestController::setFixedLayoutSize):
1470         * DumpRenderTree/chromium/LayoutTestController.h:
1471
1472 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
1473
1474         Add standalone script that filters the output of build-webkit to be more human-readable
1475         https://bugs.webkit.org/show_bug.cgi?id=44081
1476
1477         Reviewed by Daniel Bates.
1478
1479         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
1480         a build script (e.g. build-webkit) and it spits out a prettier version.
1481         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
1482         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
1483
1484 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
1485
1486         Add myself to committers.py
1487         https://bugs.webkit.org/show_bug.cgi?id=67696
1488
1489         Reviewed by Kent Tamura.
1490
1491         * Scripts/webkitpy/common/config/committers.py:
1492
1493 2011-09-07  Adam Barth  <abarth@webkit.org>
1494
1495         rebaseline button in garden-o-matic details view should work
1496         https://bugs.webkit.org/show_bug.cgi?id=67738
1497
1498         Reviewed by Dimitri Glazkov.
1499
1500         This patch wires up the rebaseline button in garden-o-matic results
1501         details view.  The button is current per-test, so there isn't a way to
1502         rebaseline individual bots.  This is a place to start.  If we decide we
1503         want per-bot rebaselining, we'll need to think of some better UI.
1504
1505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1509
1510 2011-09-07  Eric Seidel  <eric@webkit.org>
1511
1512         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
1513         https://bugs.webkit.org/show_bug.cgi?id=67737
1514
1515         Reviewed by Adam Barth.
1516
1517         I got a little over-eager when deprecating host.port_factory in the previous commit.
1518         Turns out that Host.port_factory was already the "modern" port/factory.py
1519         it was just the Module object.  I un-deprecated the variable, and changed it from
1520         being the module to being an actual PortFactory, passing it a host object.
1521         I also taught PortFactory how to set user/executive/filesystem in the kwargs
1522         when instantiating a new Port object.
1523         This magically fixed the test_rebaseline test, since its now no longer talking
1524         to the real filesystem.
1525
1526         * Scripts/webkitpy/common/host.py:
1527         * Scripts/webkitpy/layout_tests/port/factory.py:
1528         * Scripts/webkitpy/tool/commands/queries.py:
1529         * Scripts/webkitpy/tool/mocktool.py:
1530
1531 2011-09-07  Eric Seidel  <eric@webkit.org>
1532
1533         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
1534         https://bugs.webkit.org/show_bug.cgi?id=67734
1535
1536         Reviewed by Adam Barth.
1537
1538         Right now every place that creates a Port object has to be very careful
1539         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
1540         The correct fix is for port/factory.py (which creates most port objects)
1541         to know how to pass these in automatically.  However, currently all port/factory.py
1542         functions are free functions instead of being on an object.  This patch
1543         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
1544
1545         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
1546         pass along the proper scm/user/filesystem to the Port object.
1547
1548         * Scripts/webkitpy/common/host.py:
1549         * Scripts/webkitpy/layout_tests/port/factory.py:
1550         * Scripts/webkitpy/tool/commands/queries.py:
1551         * Scripts/webkitpy/tool/mocktool.py:
1552
1553 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1554
1555         Unreviewed, rolling out r94441.
1556         http://trac.webkit.org/changeset/94441
1557         https://bugs.webkit.org/show_bug.cgi?id=67731
1558
1559         "MacEWSes are backed up due to new machines not able to reach
1560         git.webkit.org.  Disabling tests for now" (Requested by
1561         eseidel2 on #webkit).
1562
1563         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1564
1565 2011-09-07  Elliot Poger  <epoger@google.com>
1566
1567         filter test_expectations properly for chromium-mac vs chromium-cg-mac
1568         https://bugs.webkit.org/show_bug.cgi?id=67324
1569
1570         Reviewed by Dirk Pranke.
1571
1572         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1573         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1574         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1575         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1576         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1577
1578 2011-09-07  Eric Boren  <borenet@gmail.com>
1579
1580         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1581         https://bugs.webkit.org/show_bug.cgi?id=66800
1582
1583         Reviewed by Darin Fisher.
1584
1585         * DumpRenderTree/chromium/EventSender.cpp:
1586         (EventSender::sendCurrentTouchEvent):
1587
1588 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
1589
1590         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1591         https://bugs.webkit.org/show_bug.cgi?id=67254
1592
1593         Reviewed by Csaba Osztrogonác.
1594
1595         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1596         derived from the running location of DumpRenderTree binary.
1597
1598         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1599         (LayoutTestController::pathToLocalResource):
1600         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
1601
1602 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1603
1604         REGRESSION(r94288) build-webkit doesn't work on Symbian
1605         https://bugs.webkit.org/show_bug.cgi?id=67706
1606
1607         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
1608         (buildQMakeProject):
1609
1610 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1611
1612         REGRESSION(r94288) build-webkit doesn't work on Windows
1613         https://bugs.webkit.org/show_bug.cgi?id=67646
1614
1615         Roll back r94655 with a small fix.
1616
1617         * Scripts/webkitdirs.pm:
1618         (buildQMakeProject):
1619
1620 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1621
1622         Unreviewed, rolling out r94635.
1623         http://trac.webkit.org/changeset/94635
1624         https://bugs.webkit.org/show_bug.cgi?id=67704
1625
1626         Linux Touch build is failing to compile this change.
1627         (Requested by loislo on #webkit).
1628
1629         * DumpRenderTree/chromium/EventSender.cpp:
1630         (EventSender::sendCurrentTouchEvent):
1631
1632 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1633
1634         Unreviewed, rolling out r94655.
1635         http://trac.webkit.org/changeset/94655
1636         https://bugs.webkit.org/show_bug.cgi?id=67703
1637
1638         It broke Leopard debug bot (Requested by ossy on #webkit).
1639
1640         * Scripts/webkitdirs.pm:
1641
1642 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1643
1644         REGRESSION(r94288) build-webkit doesn't work on Windows
1645         https://bugs.webkit.org/show_bug.cgi?id=67646
1646
1647         Reviewed by Csaba Osztrogonác.
1648
1649         * Scripts/webkitdirs.pm:
1650
1651 2011-09-06  Eric Boren  <borenet@gmail.com>
1652
1653         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1654         https://bugs.webkit.org/show_bug.cgi?id=66800
1655
1656         Reviewed by Darin Fisher.
1657
1658         * DumpRenderTree/chromium/EventSender.cpp:
1659         (EventSender::sendCurrentTouchEvent):
1660
1661 2011-09-06  Adam Barth  <abarth@webkit.org>
1662
1663         garden-o-matic details view should having working rebaseline and next/previous buttons
1664         https://bugs.webkit.org/show_bug.cgi?id=67659
1665
1666         Reviewed by Dimitri Glazkov.
1667
1668         This patch wires up basic back/forward buttons that let you traverse
1669         through the results we're examining in the details view.  This ended up
1670         being more code than I expected, but I wanted to keep all the state
1671         information in the DOM itself.
1672
1673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1676
1677 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
1678
1679         fix MockFileSystem.glob(), refactor filesystem tests
1680         https://bugs.webkit.org/show_bug.cgi?id=67462
1681
1682         Reviewed by Eric Seidel.
1683
1684         In debugging why my proposed change for MockFileSystem.glob()
1685         in bug 66228 didn't work, I stumbled across two real bugs
1686         that cancelled each other out for the unit tests. I fixed those
1687         (glob shouldn't recurse into subdirs, and we weren't populating
1688         self.dirs from self.files properly).
1689
1690         I have also created a "mixin" class for tests that can be shared
1691         between the real filesystem and the mock filesystem - MockFileSystem
1692         is being used enough it needs its own tests.
1693
1694         * Scripts/webkitpy/common/system/filesystem_mock.py:
1695         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
1696         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1697
1698 2011-09-06  Anders Carlsson  <andersca@apple.com>
1699
1700         Move NPAPI headers in bridge to plugins
1701         https://bugs.webkit.org/show_bug.cgi?id=67661
1702
1703         Update forwarding headers.
1704
1705         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1706         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1707
1708 2011-09-06  Tony Chang  <tony@chromium.org>
1709
1710         [chromium] Check in 'build' for compiled binaries first
1711         https://bugs.webkit.org/show_bug.cgi?id=67549
1712
1713         Reviewed by Dirk Pranke.
1714
1715         I'm working on moving the windows build output to a common location
1716         rather than relative to the sln file.  Because of that, we need to
1717         check those build locations first for DumpRenderTree.exe.
1718
1719         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1720
1721 2011-09-06  Adam Barth  <abarth@webkit.org>
1722
1723         Use a hierarchial structure for the garden-o-matic results view
1724         https://bugs.webkit.org/show_bug.cgi?id=67620
1725
1726         Reviewed by Dimitri Glazkov.
1727
1728         This patch re-organizes the results view to use a hierachial structure
1729         for selection.  At the top-level are sections for each test.  Expanding
1730         the test section shows a tab selector for builders.
1731
1732         This structure prepares us for wiring up various actions to this view.
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1735         (.):
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1737         ():
1738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1739         (.):
1740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1742         (.results-view>.toolbar):
1743         (.results-view>.toolbar ul.actions):
1744         (.results-view>.toolbar ul.actions li):
1745         (.results-grid table):
1746         (.results-grid table td, .results-view table th):
1747         (.results-grid table th):
1748         (.results-grid .text-result):
1749         (.results-grid .image-result):
1750
1751 2011-09-06  Adam Barth  <abarth@webkit.org>
1752
1753         garden-o-matic's base.probe generates spam in the JavaScript console
1754         https://bugs.webkit.org/show_bug.cgi?id=67622
1755
1756         Reviewed by Dimitri Glazkov.
1757
1758         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
1759         instead of HTMLScriptElement to test whether results exist.  This
1760         reduces the console.log spam and saves bandwidth because we can use a
1761         HEAD request instead of a GET request.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1764
1765 2011-09-05  Adam Barth  <abarth@webkit.org>
1766
1767         Add a tab to garden-o-matic for viewing expected failures
1768         https://bugs.webkit.org/show_bug.cgi?id=67619
1769
1770         Reviewed by Dimitri Glazkov.
1771
1772         This patch adds a basic tab to garden-o-matic that shows all the tests
1773         failing on the bots, including the expected failures.  This patch
1774         mostly involves refactoring existing classes to allow new subclasses.
1775
1776         This view is useful for when gardeners mark tests as expected to fail
1777         and then rebaseline them later.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1786
1787 2011-09-05  Adam Barth  <abarth@webkit.org>
1788
1789         Fix global variable leak in garden-o-matic
1790         https://bugs.webkit.org/show_bug.cgi?id=67617
1791
1792         Reviewed by Dimitri Glazkov.
1793
1794         Caught by running the unit tests with noglobals turned on.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1797
1798 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
1799
1800         [Qt][WK2] Add pixel test support
1801         https://bugs.webkit.org/show_bug.cgi?id=66283
1802
1803         Reviewed by Andreas Kling.
1804
1805         Implemented pixel result generation by reusing the logic
1806         that we have in DumpRenderTree.
1807         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1808         (WTR::dumpImage):
1809         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1810
1811 2011-09-04  Robin Dunn  <robin@alldunn.com>
1812
1813         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
1814         https://bugs.webkit.org/show_bug.cgi?id=67577
1815
1816         Reviewed by Kevin Ollivier.
1817
1818         * waf/build/settings.py:
1819
1820 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1821
1822         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1823
1824         * waf/build/settings.py:
1825
1826 2011-09-03  Dan Bernstein  <mitz@apple.com>
1827
1828         32-bit build fix.
1829
1830         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1831         (TestWebKitAPI::Util::toSTD):
1832
1833 2011-09-03  Dan Bernstein  <mitz@apple.com>
1834
1835         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1836         https://bugs.webkit.org/show_bug.cgi?id=67559
1837
1838         Reviewed by Darin Adler.
1839
1840         * DumpRenderTree/mac/DumpRenderTree.mm:
1841         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1842         the call to it.
1843         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1845         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1846         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1847         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1848         (TestWebKitAPI::Util::toSTD): Added.
1849
1850 2011-09-03  Adam Barth  <abarth@webkit.org>
1851
1852         garden-o-matic results view should have a better results selector
1853         https://bugs.webkit.org/show_bug.cgi?id=67542
1854
1855         Reviewed by Dimitri Glazkov.
1856
1857         This patch adds a basic grid-based results selector to the results
1858         view.  Currently, this grid just shows how the tests fail on the
1859         various bots.  A future patch will let you select which failure to view
1860         and to mark the failures for rebaselining.
1861
1862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1864           - Add some more basic functions for manipulating dictionaries.
1865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1868
1869 2011-09-03  Adam Barth  <abarth@webkit.org>
1870
1871         garden-o-matic results view should show Actual and Expected results for text failures
1872         https://bugs.webkit.org/show_bug.cgi?id=67536
1873
1874         Reviewed by Eric Seidel.
1875
1876         In the past, we didn't show actual and expected text results (we just
1877         showed the diff) because we didn't have the awesome six-by-two results
1878         grid.  Now that we do, we can move show these results.
1879
1880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1882           - Fixed some typos that were preventing these unit tests from running.
1883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1884         (.):
1885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1886           - Report -actual.txt and -expected.txt as possible results URLs.
1887
1888 2011-09-03  Adam Barth  <abarth@webkit.org>
1889
1890         garden-o-matic shows "ghost" failures that are already fixed
1891         https://bugs.webkit.org/show_bug.cgi?id=67535
1892
1893         Reviewed by Eric Seidel.
1894
1895         About 10% of writes fail to stick on test-results.appspot.com.  This
1896         patch causes us to fetch the full_results.json blob directly from
1897         build.chromium.org rather than relying upon AppEngine.
1898
1899         Unforuntately, we still need to get historical information from
1900         AppEngine.  That will take several patches to fix becuase I need to
1901         change the bots to write the full_results.json file to the
1902         build-specific directory in addition to the zip file.
1903
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1907
1908 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1909
1910         Unreviewed, rolling out r94458.
1911         http://trac.webkit.org/changeset/94458
1912         https://bugs.webkit.org/show_bug.cgi?id=67558
1913
1914         Caused appcache test to fail on various bots (Requested by
1915         rniwa on #webkit).
1916
1917         * Scripts/webkitpy/layout_tests/port/webkit.py:
1918         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1919
1920 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1921
1922         Unreviewed, rolling out r94453.
1923         http://trac.webkit.org/changeset/94453
1924         https://bugs.webkit.org/show_bug.cgi?id=67557
1925
1926         Caused appcache test to fail on various bots (Requested by
1927         rniwa on #webkit).
1928
1929         * Scripts/webkitpy/layout_tests/port/webkit.py:
1930
1931 2011-09-02  Michael Saboff  <msaboff@apple.com>
1932
1933         Add JSC:RegExp functional tests
1934         https://bugs.webkit.org/show_bug.cgi?id=67339
1935
1936         New perl script to build JavaScriptCore and run the RegExp tests.
1937
1938         Reviewed by Gavin Barraclough.
1939
1940         * Scripts/run-regexp-tests: Added.
1941
1942 2011-09-02  Michael Saboff  <msaboff@apple.com>
1943
1944         Add JSC:RegExp functional tests
1945         https://bugs.webkit.org/show_bug.cgi?id=67339
1946
1947         New perl script to build JavaScriptCore and run the RegExp tests.
1948
1949         Reviewed by Gavin Barraclough.
1950
1951         * Scripts/run-regexp-tests: Added.
1952
1953 2011-09-02  Eric Seidel  <eric@webkit.org>
1954
1955         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1956         https://bugs.webkit.org/show_bug.cgi?id=67530
1957
1958         Unreviewed.  Fixing typo from previous commit.
1959
1960         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1961         which exercises the code I previously made a typo in.
1962
1963         * Scripts/webkitpy/layout_tests/port/webkit.py:
1964         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1965
1966 2011-09-02  Eric Seidel  <eric@webkit.org>
1967
1968         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1969         https://bugs.webkit.org/show_bug.cgi?id=67530
1970
1971         Reviewed by Adam Barth.
1972
1973         No functional change, just reshuffling code.
1974
1975         * Scripts/webkitpy/layout_tests/port/webkit.py:
1976
1977 2011-09-02  Darin Adler  <darin@apple.com>
1978
1979         Added Subversion ignore for .pyc generated files.
1980
1981         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1982         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1983         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1984
1985 2011-09-02  Adam Barth  <abarth@webkit.org>
1986
1987         Enable testing on mac-ews
1988         https://bugs.webkit.org/show_bug.cgi?id=67505
1989
1990         Reviewed by Eric Seidel.
1991
1992         This patch enables testing on the Mac EWS, which should help
1993         contributors not turn the Mac bots red.
1994
1995         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1996
1997 2011-09-01  Beth Dakin  <bdakin@apple.com>
1998
1999         https://bugs.webkit.org/show_bug.cgi?id=67451
2000         Add a test for going back to a cached page after changing the device scale factor
2001
2002         Reviewed by Adam Roben.
2003
2004         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
2007         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2008         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
2009         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2010         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
2011         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
2012         (TestWebKitAPI::TEST_F):
2013
2014         Added new function to WebKitAgnosticTest to goBack. Separated
2015         waitForLoadToFinish() into its own function (instead of being a part of
2016         loadAndWaitUntilFinished()) so that it can be called from goBack as
2017         well. Also added initializeView() so we can set the cache model.
2018         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
2019         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
2020         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2021         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
2022         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2023         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2024         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
2025         (TestWebKitAPI::WebKitAgnosticTest::goBack):
2026         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
2027
2028 2011-09-02  Anders Carlsson  <andersca@apple.com>
2029
2030         Build fix.
2031
2032         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
2033         (PrivateBrowsing::ScriptableObject::pluginTest):
2034
2035 2011-09-02  Anders Carlsson  <andersca@apple.com>
2036
2037         Move private browsing test to a PluginTest subclass
2038         https://bugs.webkit.org/show_bug.cgi?id=67498
2039
2040         Reviewed by Darin Adler.
2041
2042         * DumpRenderTree/DumpRenderTree.gypi:
2043         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2044         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2045         (pluginGetProperty):
2046         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2047         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2048         (PluginTest::NPP_SetValue):
2049         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2050         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
2051         (PrivateBrowsing::PrivateBrowsing):
2052         (PrivateBrowsing::privateBrowsingEnabled):
2053         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
2054         (PrivateBrowsing::ScriptableObject::hasProperty):
2055         (PrivateBrowsing::ScriptableObject::getProperty):
2056         (PrivateBrowsing::ScriptableObject::pluginTest):
2057         (PrivateBrowsing::NPP_New):
2058         (PrivateBrowsing::NPP_GetValue):
2059         (PrivateBrowsing::NPP_SetValue):
2060         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2061         (NPP_New):
2062         (NPP_SetValue):
2063         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2064         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2065         * GNUmakefile.am:
2066
2067 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
2068
2069         [Qt] Build dependency problems
2070         https://bugs.webkit.org/show_bug.cgi?id=38054
2071
2072         Trivial fix after r94288.
2073
2074         Rubber-stamped by Andras Becsi.
2075
2076         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
2077         (buildQMakeProject):
2078
2079 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
2080
2081         Remove my old e-mail address and add my new one.
2082
2083         Rubber-stamped by Tor Arne Vestbø.
2084
2085         * Scripts/webkitpy/common/config/committers.py:
2086
2087 2011-09-02  Philippe Normand  <pnormand@igalia.com>
2088
2089         [GTK] run-gtk-tests leaves a zombie Xvfb process
2090         https://bugs.webkit.org/show_bug.cgi?id=67389
2091
2092         Reviewed by Martin Robinson.
2093
2094         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
2095         child process instead of doing shell redirection.
2096
2097 2011-09-01  Mark Rowe  <mrowe@apple.com>
2098
2099         Fix the build by adding some more missing return types.
2100
2101         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2102         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2103
2104 2011-09-01  Eric Seidel  <eric@webkit.org>
2105
2106         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
2107         https://bugs.webkit.org/show_bug.cgi?id=66228
2108
2109         Reviewed by Dirk Pranke.
2110
2111         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
2112         The LeaksViewer tool globs for all *-leaks.txt files.
2113         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
2114
2115         In order to test this I had to fix a limitation in our MockFileSystem.glob
2116         method.  However, doing so uncovered a typo and bug in the integration tests.
2117         I've disabled the offending integration tests.
2118
2119         * Scripts/webkitpy/common/system/filesystem_mock.py:
2120         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2121         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2122
2123 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
2124
2125         Adds a LayoutTestController method to make it possible to test
2126         starting speech input via an API call.
2127         https://bugs.webkit.org/show_bug.cgi?id=60170
2128
2129         Reviewed by Dimitri Glazkov.
2130
2131         * DumpRenderTree/LayoutTestController.h:
2132         * DumpRenderTree/chromium/LayoutTestController.cpp:
2133         (LayoutTestController::LayoutTestController):
2134         (LayoutTestController::startSpeechInput):
2135         * DumpRenderTree/chromium/LayoutTestController.h:
2136         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2137         (LayoutTestController::startSpeechInput):
2138         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2139         (LayoutTestController::startSpeechInput):
2140         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2141         (LayoutTestController::startSpeechInput):
2142         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2143         (LayoutTestController::startSpeechInput):
2144         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2145         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2146         (LayoutTestController::startSpeechInput):
2147         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2148         (LayoutTestController::startSpeechInput):
2149
2150 2011-09-01  Tim Horton  <hortont424@gmail.com>
2151
2152         Fix TestWebKitAPI build on clang-2.0
2153
2154         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2155
2156 2011-09-01  Adam Barth  <abarth@webkit.org>
2157
2158         Remove unused "extension" parameter from rebaseline gardeningserver handler
2159         https://bugs.webkit.org/show_bug.cgi?id=67384
2160
2161         Reviewed by James Robinson.
2162
2163         This parameter hasn't done anything in a while.
2164
2165         * Scripts/webkitpy/tool/commands/rebaseline.py:
2166         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2167         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2168
2169 2011-09-01  Eric Seidel  <eric@webkit.org>
2170
2171         Unreviewed.
2172
2173         Fix a typo in unittests.  Unfortunately fixing it
2174         caused several assertions.  Just disabling the test
2175         instead, since it was providing no value before due to the typo.
2176
2177         * Scripts/webkitpy/layout_tests/port/test.py:
2178
2179 2011-09-01  Adam Barth  <abarth@webkit.org>
2180
2181         Add a "rebaseline" button to the garden-o-matic summary page
2182         https://bugs.webkit.org/show_bug.cgi?id=67382
2183
2184         Reviewed by Dimitri Glazkov.
2185
2186         As much as we might wish folks to not rebaseline entire test groups at
2187         once, the truth is that doing so is a common operation.  Adding a
2188         button for this operation is likely to make folks happy.
2189
2190         This patch also cleans up a bunch of plumbing surrounding failureInfo
2191         objects.
2192
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2203
2204 2011-09-01  Adam Barth  <abarth@webkit.org>
2205
2206         garden-o-matic should let the gardener assign blame for a group of test failures
2207         https://bugs.webkit.org/show_bug.cgi?id=67379
2208
2209         Reviewed by Dimitri Glazkov.
2210
2211         If a group of test failures has a large revision range, the gardener
2212         might wish to blame a specific revision for the failure.  Currently,
2213         this only effect of assigning blame in this way is to hide the other
2214         suspect commits.
2215
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2219
2220 2011-09-01  Adam Barth  <abarth@webkit.org>
2221
2222         Hide garden-o-matic failure table until hover
2223         https://bugs.webkit.org/show_bug.cgi?id=67376
2224
2225         Reviewed by Dimitri Glazkov.
2226
2227         This patch removes the failure table for build failures (because it
2228         does not make sense) and hides the failure table for test groups until
2229         the user hovers over the test failure block, reducing visual noise.
2230
2231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2234
2235 2011-09-01  Adam Barth  <abarth@webkit.org>
2236
2237         Switch garden-o-matic from commitData.title to commitData.summary
2238         https://bugs.webkit.org/show_bug.cgi?id=67375
2239
2240         Reviewed by Dimitri Glazkov.
2241
2242         commitData.title is a string provided by Trac, which isn't great in all
2243         cases.  commitData.summary is my attempt to find the most important
2244         one-line summary of the commit.  This patch switches garden-o-matic
2245         over to summary.
2246
2247         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2248         and reduce visual noise.
2249
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2253
2254 2011-09-01  Adam Barth  <abarth@webkit.org>
2255
2256         Group failing tests in garden-o-matic if there are more than three in a folder
2257         https://bugs.webkit.org/show_bug.cgi?id=67373
2258
2259         Reviewed by Dimitri Glazkov.
2260
2261         Sometimes a failure will cause many tests in a given directory to fail.
2262         When that happens, it's better to list the directory as a single item
2263         (with a count) rather than spamming all the test names.
2264
2265         (This patch also updates a bunch of unit test expected results after my last commit.)
2266
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2272
2273 2011-09-01  Adam Barth  <abarth@webkit.org>
2274
2275         Lower the visual noise from the failing builders display
2276         https://bugs.webkit.org/show_bug.cgi?id=67369
2277
2278         Reviewed by Dimitri Glazkov.
2279
2280         This patch ensures that the "Building" row in the failing builders
2281         display is always last and dims it by 50% to reduce visual noise.  This
2282         lets the gardener focus on the actual failures.
2283
2284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2287
2288 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2289
2290         [Qt] Build dependency problems
2291         https://bugs.webkit.org/show_bug.cgi?id=38054
2292
2293         Make clean build after the defines are changed.
2294
2295         Reviewed by Csaba Osztrogonác.
2296
2297         * Scripts/webkitdirs.pm:
2298         (buildQMakeProject):
2299
2300 2011-08-31  Adam Barth  <abarth@webkit.org>
2301
2302         Move DumpRenderTree to WebKitPlatformSupport
2303         https://bugs.webkit.org/show_bug.cgi?id=67331
2304
2305         Reviewed by Darin Fisher.
2306
2307         This patch update DumpRenderTree to account for the WebKitClient =>
2308         WebKitPlatformSupport rename.
2309
2310         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2311         (NotificationPresenter::show):
2312         * DumpRenderTree/chromium/Task.cpp:
2313         (postTask):
2314
2315 2011-08-31  Eric Seidel  <eric@webkit.org>
2316
2317         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2318         https://bugs.webkit.org/show_bug.cgi?id=67314
2319
2320         Reviewed by Adam Barth.
2321
2322         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2323         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2324         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2325
2326         I also moved a bunch of code into dashboard.css which belonged there.
2327
2328         * QueueStatusServer/handlers/activebots.py: Added.
2329         * QueueStatusServer/main.py:
2330         * QueueStatusServer/stylesheets/dashboard.css:
2331         (.queue_bubble):
2332         (.queue_name):
2333         (.last_heard_from):
2334         (.status_text):
2335         (.alive):
2336         (.behind):
2337         (.dead):
2338         * QueueStatusServer/templates/activebots.html: Added.
2339         * QueueStatusServer/templates/dashboard.html:
2340         * QueueStatusServer/templates/recentstatus.html:
2341
2342 2011-08-31  Oliver Hunt  <oliver@apple.com>
2343
2344         Move CheckedArithmeticOperations.cpp to the intended location
2345
2346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2347         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2348
2349 2011-08-31  Elliot Poger  <epoger@google.com>
2350
2351         add unittest to validate the complete set of Chromium configurations
2352         https://bugs.webkit.org/show_bug.cgi?id=67211
2353
2354         Reviewed by Adam Barth.
2355
2356         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2357
2358 2011-08-31  Nico Weber  <thakis@chromium.org>
2359
2360         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2361         https://bugs.webkit.org/show_bug.cgi?id=67297
2362
2363         Reviewed by Tony Chang.
2364
2365         Explicitly disable smooth scrolling in chromium's DRT.
2366
2367         * DumpRenderTree/chromium/WebPreferences.cpp:
2368         (WebPreferences::applyTo):
2369
2370 2011-08-31  Oliver Hunt  <oliver@apple.com>
2371
2372         Add Checked<> tests to windows build
2373
2374         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2375
2376 2011-08-30  Oliver Hunt  <oliver@apple.com>
2377
2378         Add support for checked arithmetic
2379         https://bugs.webkit.org/show_bug.cgi?id=67095
2380
2381         Reviewed by Sam Weinig.
2382
2383         Add test cases for Checked<>
2384
2385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2386         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2387
2388 2011-08-31  Adam Barth  <abarth@webkit.org>
2389
2390         Move summary.html to garden-o-matic.html.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2396
2397 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2398
2399         [chromium] DRT linux should pass nativeKeyCode to plugins
2400         https://bugs.webkit.org/show_bug.cgi?id=66679
2401
2402         Reviewed by Tony Chang.
2403
2404         * DumpRenderTree/chromium/EventSender.cpp:
2405         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2406         (simulated) nativeKeyCode for the given input keyboard code.
2407
2408 2011-08-31  Adam Barth  <abarth@webkit.org>
2409
2410         Tighen up UI for garden-o-matic tab strip
2411         https://bugs.webkit.org/show_bug.cgi?id=67266
2412
2413         Reviewed by Dimitri Glazkov.
2414
2415         This patch add CSS to move the tab strip to the edges of the page and
2416         to remove some gratuitous border-radius.
2417
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2420
2421 2011-08-31  Adam Barth  <abarth@webkit.org>
2422
2423         garden-o-matic results view shouldn't be horrifically ugly
2424         https://bugs.webkit.org/show_bug.cgi?id=67264
2425
2426         Reviewed by Dimitri Glazkov.
2427
2428         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2429
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2433
2434 2011-08-31  Adam Barth  <abarth@webkit.org>
2435
2436         garden-o-matic needs a tabstrip
2437         https://bugs.webkit.org/show_bug.cgi?id=67263
2438
2439         Reviewed by Dimitri Glazkov.
2440
2441         This patch adds a basic tabstrip to garden-o-matic.  The results
2442         details view now opens in the "Results" tab, and the user can flip back
2443         and forth between the Summary and the Results tab quickly.  There's
2444         also a stub for a "Commits" tab, which is disabled.
2445
2446         This patch isn't the most beautiful in the world, but it gets the ball
2447         rolling on a multi-modal UI.
2448
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2454
2455 2011-08-31  Ai Makabi  <makabi@google.com>
2456
2457         Extract reference links from reftest test file.
2458         https://bugs.webkit.org/show_bug.cgi?id=66838
2459
2460         Reviewed by Shinichiro Hamaji.
2461
2462         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2463         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2464         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2465
2466 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2467
2468         [webkitpy] missing log import in common/net/resultsjsonparser.py
2469         https://bugs.webkit.org/show_bug.cgi?id=65606
2470
2471         Reviewed by Martin Robinson.
2472
2473         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
2474
2475 2011-08-30  Philippe Normand  <pnormand@igalia.com>
2476
2477         [stylechecker] complains about NULL usage in some gst_structure_ calls
2478         https://bugs.webkit.org/show_bug.cgi?id=67194
2479
2480         Reviewed by Martin Robinson.
2481
2482         Don't warn about NULL in some gst_structure_ calls. 0 can't be
2483         used for these, a proper sentinel is required.
2484
2485         * Scripts/webkitpy/style/checkers/cpp.py:
2486         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2487
2488 2011-08-30  Adam Barth  <abarth@webkit.org>
2489
2490         Remove old-style UI from garden-o-matic
2491         https://bugs.webkit.org/show_bug.cgi?id=67257
2492
2493         Reviewed by Dimitri Glazkov.
2494
2495         This code is nowhere near as awesome as the new hotness.  Let's remove
2496         it so it doesn't weigh us down.
2497
2498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
2503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
2504
2505 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2506
2507         [WebSocket] update pywebsocket to 0.6b5.
2508         https://bugs.webkit.org/show_bug.cgi?id=66924
2509
2510         Reviewed by Kent Tamura.
2511
2512         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2513         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
2514         0.6b3 or later supports a closing handshake handler and it is useful to
2515         verify client's closing handshake implementation.
2516         0.6b4 supports AbortedByUserException. It is useful to eliminate
2517         unnecessary server warning messages on intended abnormal closures.
2518         0.6b5 supports Python 2.5.1 or Mac 10.5.
2519
2520         * Scripts/webkitpy/thirdparty/__init__.py:
2521         Update download URL and directory path.
2522
2523 2011-08-30  Dan Bernstein  <mitz@apple.com>
2524
2525         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
2526         https://bugs.webkit.org/show_bug.cgi?id=67230
2527
2528         Reviewed by Darin Adler.
2529
2530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2531         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
2532         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
2533         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
2534         (TestWebKitAPI::TEST):
2535
2536 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
2537
2538         Add MediaSource API to HTMLMediaElement
2539         https://bugs.webkit.org/show_bug.cgi?id=64731
2540
2541         Reviewed by Eric Carlson.
2542
2543         * Scripts/build-webkit:
2544
2545 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2546
2547         Emit last progress notification before calling dispatchDidFinishLoad
2548         https://bugs.webkit.org/show_bug.cgi?id=28851
2549
2550         Reviewed by Adam Barth.
2551
2552         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
2553         Chromium and GTK ports. The first two were simple changes.
2554
2555         Some refactoring was needed in GTK port to assure that the dumps are emitted
2556         correctly and the processing after the page load finished is in the right place.
2557
2558         To detect the load finished, we use the callback for the "load-status" notifier
2559         signal of the top loading frame. And we use the deprecated "load-finished" signal
2560         for dumping (if enabled) the progress finished expected output.
2561
2562         * DumpRenderTree/LayoutTestController.cpp:
2563         (LayoutTestController::LayoutTestController):
2564         (dumpProgressFinishedCallbackCallback):
2565         (LayoutTestController::staticFunctions):
2566         * DumpRenderTree/LayoutTestController.h:
2567         (LayoutTestController::dumpProgressFinishedCallback):
2568         (LayoutTestController::setDumpProgressFinishedCallback):
2569         * DumpRenderTree/chromium/LayoutTestController.cpp:
2570         (LayoutTestController::LayoutTestController):
2571         (LayoutTestController::dumpProgressFinishedCallback):
2572         (LayoutTestController::reset):
2573         * DumpRenderTree/chromium/LayoutTestController.h:
2574         (LayoutTestController::shouldDumpProgressFinishedCallback):
2575         (LayoutTestController::setShouldDumpProgressFinishedCallback):
2576         * DumpRenderTree/chromium/WebViewHost.cpp:
2577         (WebViewHost::didStopLoading):
2578         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2579         (webViewLoadFinished):
2580         (topLoadingFrameLoadFinished):
2581         (webFrameLoadStatusNotified):
2582         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2583         (LayoutTestController::reset):
2584         (LayoutTestController::dumpProgressFinishedCallback):
2585         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2586
2587 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
2588
2589         JavaScriptCore does not have a good mechanism for performance
2590         regression testing
2591         https://bugs.webkit.org/show_bug.cgi?id=67177
2592
2593         Reviewed by Darin Adler.
2594
2595         Added a new script, which allows for testing one, two, or more VMs
2596         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
2597         are interleaved at random to minimize systematics.  The results
2598         that bencher prints includes all possible relevant information about
2599         how bencher was invoked.  Bencher can be easily used to measure
2600         performance changes down to fractions of a percent.
2601
2602         Bencher also includes experimental support for running benchmarks in
2603         a DumpRenderTree release build.  This works in SunSpider and V8, but
2604         not yet in Kraken.  Running benchmarks in DumpRenderTree more
2605         closely mimics the performance when running in browser.
2606
2607         * Scripts/bencher: Added.
2608
2609 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
2610
2611         DumpRenderTree should begin each test with an empty cookie store
2612         https://bugs.webkit.org/show_bug.cgi?id=63545
2613         <rdar://problem/5666907>
2614
2615         Reviewed by Darin Adler.
2616
2617         * DumpRenderTree/mac/DumpRenderTree.mm:
2618         (resetDefaultsToConsistentValues):
2619         (setDefaultsToConsistentValuesForTesting):
2620         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2621         (LayoutTestController::setAlwaysAcceptCookies):
2622         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2623         (WTR::InjectedBundle::beginTesting):
2624         Use new SPIs to manipulate sessions.
2625
2626 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2627
2628         Unreviewed, rolling out r94055 and r94057.
2629         http://trac.webkit.org/changeset/94055
2630         http://trac.webkit.org/changeset/94057
2631         https://bugs.webkit.org/show_bug.cgi?id=67191
2632
2633         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
2634
2635         * Scripts/webkitpy/thirdparty/__init__.py:
2636
2637 2011-08-30  Adam Barth  <abarth@webkit.org>
2638
2639         Chromium Android should not be a core builder
2640         https://bugs.webkit.org/show_bug.cgi?id=67184
2641
2642         Reviewed by Ryosuke Niwa.
2643
2644         This bot hasn't been consistently green yet because it has never actually run!
2645
2646         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2647         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2648
2649 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2650
2651         [WebSocket] update pywebsocket to 0.6b4.
2652         https://bugs.webkit.org/show_bug.cgi?id=66924
2653
2654         Reviewed by Kent Tamura.
2655
2656         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2657         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
2658         0.6b3 or later supports a closing handshake handler and it is useful to
2659         verify client's closing handshake implementation.
2660         0.6b4 supports AbortedByUserException. It is useful to eliminate
2661         unnecessary server warning messages on intended abnormal closures.
2662
2663         * Scripts/webkitpy/thirdparty/__init__.py:
2664         Update download URL and directory path.
2665
2666 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
2667
2668         sheriffbot "usage" help statements are wrong
2669         https://bugs.webkit.org/show_bug.cgi?id=67170
2670
2671         Reviewed by Adam Barth.
2672
2673         * Scripts/webkitpy/tool/bot/irc_command.py:
2674         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2675         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2676
2677 2011-08-29  Adam Barth  <abarth@webkit.org>
2678
2679         Add support for chomium-mac (non-CoreGraphics) baselines
2680         https://bugs.webkit.org/show_bug.cgi?id=67163
2681
2682         Reviewed by Eric Seidel.
2683
2684         This patch teaches the non-CG chromium-mac bots to look at non-CG
2685         baselines.  However, the patch still leaves CG as the default set of
2686         baselines.
2687
2688         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2689         * Scripts/webkitpy/common/config/build.py:
2690         * Scripts/webkitpy/common/config/build_unittest.py:
2691         * Scripts/webkitpy/layout_tests/port/builders.py:
2692         * Scripts/webkitpy/layout_tests/port/chromium.py:
2693         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2694         * Scripts/webkitpy/layout_tests/port/factory.py:
2695         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2696         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2697         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2698         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2699
2700 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
2701
2702         Small fix in chromium port of new-run-webkit-tests.
2703         https://bugs.webkit.org/show_bug.cgi?id=67078
2704
2705         Reviewed by Dirk Pranke.
2706
2707         * Scripts/webkitpy/layout_tests/port/chromium.py:
2708
2709 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2710
2711         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2712         r93999.
2713         http://trac.webkit.org/changeset/93987
2714         http://trac.webkit.org/changeset/93992
2715         http://trac.webkit.org/changeset/93995
2716         http://trac.webkit.org/changeset/93998
2717         http://trac.webkit.org/changeset/93999
2718         https://bugs.webkit.org/show_bug.cgi?id=67147
2719
2720         Many failing tests (Requested by ap on #webkit).
2721
2722         * DumpRenderTree/mac/DumpRenderTree.mm:
2723         (setDefaultsToConsistentValuesForTesting):
2724         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2725         (WTR::InjectedBundle::beginTesting):
2726
2727 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
2728
2729         DumpRenderTree should begin each test with an empty cookie store
2730         https://bugs.webkit.org/show_bug.cgi?id=63545
2731         <rdar://problem/5666907>
2732
2733         Reviewed by Darin Adler.
2734
2735         * DumpRenderTree/mac/DumpRenderTree.mm:
2736         (setDefaultsToConsistentValuesForTesting):
2737         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2738         (WTR::InjectedBundle::beginTesting):
2739         Tell WebCore to use a temporary session, starting with a clean cookie store.
2740
2741 2011-08-23  Chris Marrin  <cmarrin@apple.com>
2742
2743         [mac] requestAnimationFrame support for mac port
2744         https://bugs.webkit.org/show_bug.cgi?id=59146
2745
2746         Reviewed by Simon Fraser.
2747
2748         Add support for request-animation-callback flag
2749
2750         * Scripts/build-webkit:
2751
2752 2011-08-27  Peter Beverloo  <peter@chromium.org>
2753
2754         Add a build bot for Chromium with OS(ANDROID)
2755         https://bugs.webkit.org/show_bug.cgi?id=66687
2756
2757         Reviewed by Adam Barth.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/config.json:
2760
2761 2011-08-27  Peter Beverloo  <peter@chromium.org>
2762
2763         Update the master build bot configuration script to properly
2764         deal with the --chromium-android switch.
2765         https://bugs.webkit.org/show_bug.cgi?id=66687
2766
2767         The --chromium-android switch is needed when running
2768         update-webkit-chromium and build-webkit, as it'll tell the
2769         scripts to pull in the right dependencies and cross-compile
2770         WebKit using the Android NDK.
2771
2772         Reviewed by Adam Barth.
2773
2774         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2775
2776 2011-08-27  Peter Beverloo  <peter@chromium.org>
2777
2778         Teach the update and build scripts how to handle dependencies
2779         and cross-compiling rules for the Chromium port on OS(ANDROID).
2780         https://bugs.webkit.org/show_bug.cgi?id=66687
2781
2782         Reviewed by Adam Barth.
2783
2784         * Scripts/build-webkit:
2785         * Scripts/update-webkit:
2786         * Scripts/update-webkit-chromium:
2787         * Scripts/webkitdirs.pm:
2788         (argumentsForConfiguration):
2789         (isChromium):
2790         (isChromiumAndroid):
2791         (determineIsChromiumAndroid):
2792         (buildChromium):
2793
2794 2011-08-26  Adam Barth  <abarth@webkit.org>
2795
2796         garden-o-matic should let me know that I need to run the local server
2797         https://bugs.webkit.org/show_bug.cgi?id=66985
2798
2799         Reviewed by Dimitri Glazkov.
2800
2801         The patch triggers an alert dialog whenever the user tries to use a
2802         feature that requires the local server.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2805         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2807
2808 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2809
2810         garden-o-matic summary view should have pretty commit data information.
2811         https://bugs.webkit.org/show_bug.cgi?id=67069
2812
2813         Reviewed by Adam Barth.
2814
2815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2819
2820 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2821
2822         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2823         https://bugs.webkit.org/show_bug.cgi?id=67066
2824
2825         Reviewed by Adam Barth.
2826
2827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2829
2830 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2831
2832         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2833         https://bugs.webkit.org/show_bug.cgi?id=67041
2834
2835         Reviewed by Martin Robinson.
2836
2837         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2838         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2839         when the GTK+ port was being built.
2840
2841         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2842
2843 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2844
2845         Clean up and line up layout in garden-o-matic summary view.
2846         https://bugs.webkit.org/show_bug.cgi?id=67057
2847
2848         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2849         2) Rearranged DOM structure a bit to accommodate recent changes;
2850         3) Added minimal CSS to line things up.
2851
2852         Reviewed by Adam Barth.
2853
2854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2861         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2864
2865 2011-08-26  Alice Liu  <alice.liu@apple.com>
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=66823
2868         Add the request info to the WebPageProxy::CreateNewPage message
2869
2870         Reviewed by Anders Carlsson.
2871
2872         Update function declarations with additional parameter:
2873         * MiniBrowser/gtk/BrowserWindow.c:
2874         (createNewPage):
2875         * MiniBrowser/mac/BrowserWindowController.m:
2876         (createNewPage):
2877         * MiniBrowser/win/BrowserView.cpp:
2878         (createNewPage):
2879         * WebKitTestRunner/TestController.cpp:
2880         (WTR::TestController::createOtherPage):
2881         * WebKitTestRunner/TestController.h:
2882
2883 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2884
2885         Make show-pretty-diff work on linux
2886         https://bugs.webkit.org/show_bug.cgi?id=67017
2887
2888         Reviewed by Adam Barth.
2889
2890         * Scripts/show-pretty-diff:
2891
2892 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2893
2894         Reorganize garden-o-matic CSS files to match JS-built views.
2895         https://bugs.webkit.org/show_bug.cgi?id=66998
2896
2897         Reviewed by Adam Barth.
2898
2899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2905
2906 2011-08-25  Adam Barth  <abarth@webkit.org>
2907
2908         garden-o-matic should be able to roll out patches
2909         https://bugs.webkit.org/show_bug.cgi?id=66982
2910
2911         Reviewed by Dimitri Glazkov.
2912
2913         This patch just wires the rollout event through the controller to the
2914         local server, which is already set up to perform rollouts.
2915
2916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2918         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2920
2921 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2922
2923         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2924         https://bugs.webkit.org/show_bug.cgi?id=66951
2925
2926         Reviewed by Andreas Kling.
2927
2928         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2929         width and height one by one and setWidth cause geometryChange event in QTouchWebView.
2930
2931         * MiniBrowser/qt/BrowserView.cpp:
2932         (BrowserView::resizeEvent):
2933
2934 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2935
2936         garden-o-matic summary view should provide information on builders still in flight.
2937         https://bugs.webkit.org/show_bug.cgi?id=66992
2938
2939         Reviewed by Adam Barth.
2940
2941         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2946
2947 2011-08-25  Adam Barth  <abarth@webkit.org>
2948
2949         webkit-patch rebaseline-expectations don't work when run outside the root
2950         https://bugs.webkit.org/show_bug.cgi?id=66966
2951
2952         Reviewed by Eric Seidel.
2953
2954         Turns out tool.path() used to be relative, which caused problems when
2955         running webkit-patch outside the root directory.  This patch makes it
2956         absolute.  I checked all callers, and they all appear to want this
2957         behavior.
2958
2959         It was unclear to me how to test this change because we only really
2960         have a testing strategy for webkitpy, not for the main script.
2961
2962         * Scripts/webkit-patch:
2963
2964 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2965
2966         garden-o-matic summary needs a mock view that could be used for working on styling
2967         https://bugs.webkit.org/show_bug.cgi?id=66971
2968
2969         Reviewed by Adam Barth.
2970
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2973
2974 2011-08-25  Anders Carlsson  <andersca@apple.com>
2975
2976         Return the correct value for NPNVsupportsCarbonBool
2977         https://bugs.webkit.org/show_bug.cgi?id=66964
2978
2979         Add a test.
2980
2981         Reviewed by Adam Roben.
2982
2983         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2984         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2985         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2986         (SupportsCarbonEventModel::testConvert):
2987         (SupportsCarbonEventModel::runTest):
2988         (SupportsCarbonEventModel::NPP_New):
2989
2990 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2991
2992         garden-o-matic summary view should not be broken.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2995         (table.comparison): Added more specificity.
2996
2997 2011-08-25  Adam Barth  <abarth@webkit.org>
2998
2999         This command has been broken for a while.  This patch updates the
3000         callsite to the new API.
3001
3002         * Scripts/webkitpy/tool/commands/rebaseline.py:
3003
3004 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3005
3006         garden-o-matic needs a way to report where and how tests are failing in the summary view.
3007         https://bugs.webkit.org/show_bug.cgi?id=66955
3008
3009         Introduce FailureGrid, your one-stop failure-indicating destination.
3010
3011         Reviewed by Adam Barth.
3012
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
3015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
3016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
3019
3020 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3021
3022         Add myself to the committers list
3023         https://bugs.webkit.org/show_bug.cgi?id=66941
3024
3025         Reviewed by Andreas Kling.
3026
3027         * Scripts/webkitpy/common/config/committers.py:
3028
3029 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3030
3031         Unreviewed, rolling out r93767.
3032         http://trac.webkit.org/changeset/93767
3033         https://bugs.webkit.org/show_bug.cgi?id=66931
3034
3035         Broke Qt bot. (Requested by yutak on #webkit).
3036
3037         * Scripts/webkitpy/thirdparty/__init__.py:
3038
3039 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
3040
3041         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
3042         https://bugs.webkit.org/show_bug.cgi?id=66924
3043
3044         Reviewed by Kent Tamura.
3045
3046         * Scripts/webkitpy/thirdparty/__init__.py:
3047
3048 2011-08-24  Adam Barth  <abarth@webkit.org>
3049
3050         The user can't close the details view in garden-o-matic
3051         https://bugs.webkit.org/show_bug.cgi?id=66911
3052
3053         Reviewed by Dimitri Glazkov.
3054
3055         In addition to adding a close button, this patch changes the test
3056         selector to use a <select> element and refactors the test selector to
3057         share code with the builder selector.
3058
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3063
3064 2011-08-24  James Robinson  <jamesr@chromium.org>
3065
3066         [chromium] Stacktrace not in test output when a test crashes
3067         https://bugs.webkit.org/show_bug.cgi?id=66806
3068
3069         Reviewed by Dirk Pranke.
3070
3071         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
3072         trace.
3073
3074         * Scripts/webkitpy/layout_tests/port/chromium.py:
3075
3076 2011-08-24  Adam Barth  <abarth@webkit.org>
3077
3078         Remove empty directory.
3079
3080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
3081
3082 2011-08-24  Adam Barth  <abarth@webkit.org>
3083
3084         Finish writing up details-view in garden-o-matic
3085         https://bugs.webkit.org/show_bug.cgi?id=66891
3086
3087         Reviewed by Dimitri Glazkov.
3088
3089         This patch mostly just copies a bunch of CSS from main.css to
3090         summary.css.  Presumably we'll delete main.css soon.
3091
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3097
3098 2011-08-24  James Robinson  <jamesr@chromium.org>
3099
3100         Some compositing LayoutTests flakily crashing on Mac 10.6
3101         https://bugs.webkit.org/show_bug.cgi?id=66740
3102
3103         Reviewed by Adam Barth.
3104
3105         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
3106         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
3107         chromium configuration.
3108
3109         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3110         (NPP_Destroy):
3111
3112 2011-08-24  Anton D'Auria  <adauria@apple.com>
3113
3114         No review necessary.
3115
3116         Adding myself to list of committers.
3117
3118         * Scripts/webkitpy/common/config/committers.py:
3119
3120 2011-08-24  Avi Drissman  <avi@google.com>
3121
3122         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
3123         https://bugs.webkit.org/show_bug.cgi?id=66875
3124
3125         Reviewed by James Robinson.
3126
3127         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3128         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3129
3130 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3131
3132         Make notifications appear in time order again.
3133         https://bugs.webkit.org/show_bug.cgi?id=66815
3134
3135         Reviewed by Adam Barth.
3136
3137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
3138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
3139
3140 2011-08-23  James Robinson  <jamesr@chromium.org>
3141
3142         [chromium] Need a way to test lost compositor context recovery
3143         https://bugs.webkit.org/show_bug.cgi?id=66820
3144
3145         Reviewed by Kenneth Russell.
3146
3147         Exposes a LayoutTestController interface in chromium to simulate a
3148         lost compositor context.
3149
3150         * DumpRenderTree/chromium/LayoutTestController.cpp:
3151         (LayoutTestController::LayoutTestController):
3152         (LayoutTestController::loseCompositorContext):
3153         * DumpRenderTree/chromium/LayoutTestController.h:
3154
3155 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3156
3157         Change garden-o-matic frontend builder array to be a configuration map.
3158         https://bugs.webkit.org/show_bug.cgi?id=66816
3159
3160         Reviewed by Adam Barth.
3161
3162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
3163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
3164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
3166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
3167
3168 2011-08-23  Cary Clark  <caryclark@google.com>
3169
3170         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
3171         https://bugs.webkit.org/show_bug.cgi?id=66803
3172
3173         This fixes the WebKit Canaries, in particular avoids a crash on tests
3174         like css1/basic/comments.html.
3175
3176         Reviewed by James Robinson.
3177
3178         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3179         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3180         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
3181         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
3182         and treated it as if it were a CGContextRef.
3183
3184 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3185
3186         Fix mergeChangeLogs test on native windows
3187         https://bugs.webkit.org/show_bug.cgi?id=66797
3188
3189         Reviewed by Adam Roben.
3190
3191         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
3192         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
3193
3194         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3195         (writeTempFile):
3196
3197 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3198
3199         garden-o-matic relative time is wrong and updates too frequently.
3200         https://bugs.webkit.org/show_bug.cgi?id=66802
3201
3202         Reviewed by Adam Barth.
3203
3204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
3207
3208 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3209
3210         Add missing quotes around filenames in mergeChangeLogs
3211         https://bugs.webkit.org/show_bug.cgi?id=66794
3212
3213         Reviewed by Adam Roben.
3214
3215         * Scripts/VCSUtils.pm:
3216         (mergeChangeLogs):
3217
3218 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3219
3220         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
3221         https://bugs.webkit.org/show_bug.cgi?id=49080
3222
3223         Reviewed by Adam Roben.
3224
3225         Use the string form of pipe open instead (like we do at all other places).
3226
3227         * Scripts/VCSUtils.pm:
3228         (mergeChangeLogs):
3229
3230 2011-08-23  Adam Barth  <abarth@webkit.org>
3231
3232         garden-o-matic summary should be able to examine failures
3233         https://bugs.webkit.org/show_bug.cgi?id=66748
3234
3235         Reviewed by Dimitri Glazkov.
3236
3237         This patch refactors a bunch of code from summary.js to independent
3238         controllers in controllers.js.  This patch also contains the first
3239         iteration of binding the "examine" event to a the behavior showing the
3240         details view for the tests.  There's more work to do here to make this
3241         work properly (and elegantly), but this patch is a start.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3252
3253 2011-08-23  Adam Barth  <abarth@webkit.org>
3254
3255         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
3256         https://bugs.webkit.org/show_bug.cgi?id=66737
3257
3258         Reviewed by Steve Block.
3259
3260         This directory doesn't exist anymore now that the Android port shares
3261         more code with Chromium.
3262
3263         * Scripts/webkitpy/common/config/build.py:
3264
3265 2011-08-22  Eric Seidel  <eric@webkit.org>
3266
3267         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
3268         I won't have ssh access to the bot again for a couple days, so
3269         attempting to fix by changing this script.  If this doesn't
3270         work we'll just live with the it hung for now.
3271
3272         Unreviewed.
3273
3274         * EWSTools/start-queue.sh:
3275
3276 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3277
3278         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
3279         https://bugs.webkit.org/show_bug.cgi?id=66727
3280
3281         Reviewed by Adam Barth.
3282
3283         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
3284             in which case the serializer treats all expectations as unparsed.
3285         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
3286
3287 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3288
3289         Update unit test expectations after r93530.
3290
3291         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
3292         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3293
3294 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3295
3296         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
3297         https://bugs.webkit.org/show_bug.cgi?id=66705
3298
3299         Reviewed by Adam Barth.
3300
3301         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
3302         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
3303
3304 2011-08-22  James Robinson  <jamesr@chromium.org>
3305
3306         [chromium] Update builder names for chromium gpu bots due to CG switchover
3307         https://bugs.webkit.org/show_bug.cgi?id=66693
3308
3309         Reviewed by Dirk Pranke.
3310
3311         Update the port and builder names for the chromium mac gpu bots to
3312         account for the CG transition.
3313
3314         * Scripts/webkitpy/layout_tests/port/builders.py:
3315
3316 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
3317
3318         fix the GPU bot names on the layout test dashboard
3319         https://bugs.webkit.org/show_bug.cgi?id=66697
3320
3321         Reviewed by Dimitri Glazkov.
3322
3323         * TestResultServer/static-dashboards/builders.js:
3324
3325 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3326
3327         garden-o-matic's relative time display should be updated regularly.
3328         https://bugs.webkit.org/show_bug.cgi?id=66682
3329
3330         Reviewed by Adam Barth.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
3333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
3334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
3335
3336 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3337
3338         Pass --makeargs of build-webkit to chromium linux builder
3339         https://bugs.webkit.org/show_bug.cgi?id=66361
3340
3341         Reviewed by Tony Chang.
3342
3343         * Scripts/build-webkit:
3344         * Scripts/webkitdirs.pm:
3345         (buildChromiumMakefile):
3346         (buildChromium):
3347
3348 2011-08-22  Peter Beverloo  <peter@chromium.org>
3349
3350         Add myself to the contributor list.
3351         https://bugs.webkit.org/show_bug.cgi?id=66674
3352
3353         Reviewed by Tony Gentilcore.
3354
3355         * Scripts/webkitpy/common/config/committers.py:
3356
3357 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
3358
3359         [Qt] ImageDiff does not consider --tolerance
3360         https://bugs.webkit.org/show_bug.cgi?id=66299
3361
3362         Reviewed by Csaba Osztrogonác.
3363
3364         * DumpRenderTree/qt/ImageDiff.cpp:
3365         (main):
3366
3367 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
3368
3369         Update contributor list.
3370
3371         Reviewed by Zoltan Herczeg.
3372
3373         * Scripts/webkitpy/common/config/committers.py:
3374
3375 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3376
3377         [ORWT] Fix --reset-results --add-platform-exceptions combo
3378         https://bugs.webkit.org/show_bug.cgi?id=65464
3379
3380         Reviewed by Csaba Osztrogonác.
3381
3382         * Scripts/old-run-webkit-tests:
3383
3384 2011-08-20  Adam Barth  <abarth@webkit.org>
3385
3386         garden-o-matic summary.html should have UI for examining failures
3387         https://bugs.webkit.org/show_bug.cgi?id=66625
3388
3389         Reviewed by Dimitri Glazkov.
3390
3391         This patch introduces the notion of UI actions and converts our
3392         existing manual <button> manipulation with this new abstraction.  The
3393         patch also adds an Examine button to failure notifications.  In a
3394         future patch, I'll add a controller that wires this button up to
3395         something useful.
3396
3397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
3400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
3401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3405
3406 2011-08-20  Adam Barth  <abarth@webkit.org>
3407
3408         garden-o-matic summary page should indiciate compile failures
3409         https://bugs.webkit.org/show_bug.cgi?id=66624
3410
3411         Reviewed by Dimitri Glazkov.
3412
3413         This patch creates a notification-based UI for build failures.  The new
3414         UI displays the same information that used to be displayed in the
3415         infobar.  There's lots of room for improvement in surfacing more
3416         information, but this is a start.
3417
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3421
3422 2011-08-19  James Robinson  <jamesr@chromium.org>
3423
3424         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
3425         https://bugs.webkit.org/show_bug.cgi?id=66606
3426
3427         Reviewed by Dirk Pranke.
3428
3429         The chromium GPU configuration does not (currently) contain any tests
3430         incompatible with --experimental-fully-parallel, and this flag is a
3431         significan speedup because of the directory canvas/philip/tests which
3432         contains 802 tests in the same directory. Setting this option by
3433         default on this configuration is a 2x speed in release, 44s to 22s,
3434         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
3435
3436         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3437         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3439
3440 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3441
3442         Unreviewed, rolling out r93426.
3443         http://trac.webkit.org/changeset/93426
3444         https://bugs.webkit.org/show_bug.cgi?id=66607
3445
3446         Broke the Mac build by not building gtest.framework anymore
3447         (Requested by andersca on #webkit).
3448
3449         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3450
3451 2011-08-19  James Robinson  <jamesr@chromium.org>
3452
3453         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
3454         https://bugs.webkit.org/show_bug.cgi?id=66603
3455
3456         Reviewed by Dirk Pranke.
3457
3458         The various ChromiumGpu ports should use the same child worker
3459         selection logic as other ports so they can run with full
3460         parallelization on multicore systems.
3461
3462         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3463         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3464
3465 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
3466
3467         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
3468         https://bugs.webkit.org/show_bug.cgi?id=66570
3469
3470         Reviewed by Mihai Parparita.
3471
3472         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3473         (WebThemeControlDRTWin::draw):
3474         (WebThemeControlDRTWin::drawTextField):
3475         (WebThemeControlDRTWin::drawProgressBar):
3476         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3477
3478 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3479
3480         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
3481         https://bugs.webkit.org/show_bug.cgi?id=66521
3482
3483         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
3484
3485         Reviewed by David Levin.
3486
3487         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
3488
3489 2011-08-19  Adam Roben  <aroben@apple.com>
3490
3491         Add project file changes I left out in r93417
3492
3493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3494
3495 2011-08-19  Adam Roben  <aroben@apple.com>
3496
3497         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
3498
3499         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
3500         NSScreen
3501
3502         Reviewed by Anders Carlsson.
3503
3504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3505
3506         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3507         (-[SimpleObject setValue:]): Original implementation.
3508
3509         (TestWebKitAPI::setValue2):
3510         (TestWebKitAPI::setValue3):
3511         Swizzled implementations.
3512
3513         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
3514         instance method.
3515
3516         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
3517         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3518         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
3519         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
3520
3521 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
3522
3523         Fix _path_to_apache() error reporting
3524         https://bugs.webkit.org/show_bug.cgi?id=66486
3525
3526         Reviewed by Ryosuke Niwa.
3527
3528         * Scripts/webkitpy/layout_tests/port/webkit.py:
3529
3530 2011-08-19  Adam Roben  <aroben@apple.com>
3531
3532         Windows build fix after r93404
3533
3534         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
3535
3536 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
3537
3538         Add leandrogracia to the committers list
3539         https://bugs.webkit.org/show_bug.cgi?id=66552
3540
3541         Also fix line endings in file.
3542
3543         No reviewed required.
3544
3545         * Scripts/webkitpy/common/config/committers.py:
3546
3547 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
3548
3549         Fix compilation issue in WebKitTestRunner
3550         https://bugs.webkit.org/show_bug.cgi?id=66554
3551
3552         Reviewed by Martin Robinson.
3553
3554         * WebKitTestRunner/PixelDumpSupport.cpp:
3555
3556 2011-08-19  Adam Roben  <aroben@apple.com>
3557
3558         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
3559
3560         This will make it easier to write other WebKit-agnostic tests
3561
3562         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
3563         code in other WebKit-agnostic tests
3564
3565         Reviewed by Anders Carlsson.
3566
3567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3568
3569         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
3570         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
3571         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
3572         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
3573         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
3574         WebKitAgnosticTest handles for us.
3575         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
3576
3577         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
3578         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
3579         DynamicDeviceScaleFactor::runTest.
3580
3581         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
3582         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
3583         DynamicDeviceScaleFactor.WebKit.
3584         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
3585         DynamicDeviceScaleFactor.WebKit2.
3586
3587 2011-08-19  Adam Roben  <aroben@apple.com>
3588
3589         Clean up #includes in TestWebKitAPI
3590
3591         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
3592
3593         Reviewed by Anders Carlsson.
3594
3595         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
3596         files and WebKit/WebKit.h for ObjC files.
3597
3598         * TestWebKitAPI/InjectedBundleController.cpp:
3599         * TestWebKitAPI/JavaScriptTest.h:
3600         * TestWebKitAPI/PlatformUtilities.h:
3601         * TestWebKitAPI/PlatformWebView.h:
3602         * TestWebKitAPI/Test.h:
3603         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3604         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3605         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
3606         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3607         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3608         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3609         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3610         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3611         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3612         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3613         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3614         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3615         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3616         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3617         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3618         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3619         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3620         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3621         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3622         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3623         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3624         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3625         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3626         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3627         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3628         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3629         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3630         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3631         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3632         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3633         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3634         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3635         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3636         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3637         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3638         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3639         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3640         * TestWebKitAPI/TestsController.cpp:
3641         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3642         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
3643         #includes since it is no longer a special header.
3644
3645 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
3646
3647         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
3648         https://bugs.webkit.org/show_bug.cgi?id=64886
3649