AX: Make SVG Group containers accessible elements
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2
3         AX: Make SVG Group containers accessible elements
4         https://bugs.webkit.org/show_bug.cgi?id=113939
5
6         Reviewed by Simon Fraser.
7
8         Implement axController.elementAtPoint for iOS.
9         Implement a correct version of clickPoint for iOS.
10
11         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
12         (AccessibilityController::elementAtPoint):
13         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
14         (AccessibilityUIElement::clickPointX):
15         (AccessibilityUIElement::clickPointY):
16
17 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
18
19         Unreviewed, rolling out r147773 and r147774.
20         http://trac.webkit.org/changeset/147773
21         http://trac.webkit.org/changeset/147774
22         https://bugs.webkit.org/show_bug.cgi?id=114056
23
24         Causing some exceptions on AppEngine I don't understand
25         (Requested by rniwa on #webkit).
26
27         * QueueStatusServer/config/queues.py:
28         * QueueStatusServer/model/queues.py:
29         (Queue.short_name):
30         (Queue.display_name):
31         * QueueStatusServer/model/queues_unittest.py:
32         (QueueTest.test_short_name):
33         (QueueTest.test_display_name):
34         (QueueTest.test_name_with_underscores):
35
36 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
37
38         Fixed run-bindings-tests by removing V8
39         https://bugs.webkit.org/show_bug.cgi?id=114053
40
41         Reviewed by Benjamin Poulain.
42
43         * Scripts/run-bindings-tests:
44         (main):
45
46 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
47
48         Build fix.
49
50         * QueueStatusServer/model/queues.py:
51         (Queue.short_name):
52         (Queue.display_name):
53
54 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
55
56         Remove Chromium EWS bots from the queue status server
57         https://bugs.webkit.org/show_bug.cgi?id=113988
58
59         Reviewed by Benjamin Poulain.
60
61         Removed Chromium EWS bots.
62
63         * QueueStatusServer/config/queues.py:
64         * QueueStatusServer/model/queues.py:
65         (Queue.short_name):
66         (Queue.display_name):
67         * QueueStatusServer/model/queues_unittest.py:
68         (QueueTest.test_short_name):
69         (QueueTest.test_display_name):
70         (QueueTest.test_name_with_underscores):
71
72 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
73
74         [EFL] Enable indexed database
75         https://bugs.webkit.org/show_bug.cgi?id=107248
76
77         Reviewed by Alexis Menard.
78
79         * Scripts/webkitperl/FeatureList.pm:
80
81 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
82
83         Remove vestiges of Chromium bits from watchlists.
84         https://bugs.webkit.org/show_bug.cgi?id=114047
85
86         Reviewed by Ryosuke Niwa.
87
88         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
89
90 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
91
92         Add James Craig to the contributors list.
93
94         * Scripts/webkitpy/common/config/committers.py:
95
96 2013-04-04  Kent Tamura  <tkent@chromium.org>
97
98         Remove ChromiumPublicApi pattern, and cc/message rules for it.
99
100         * Scripts/webkitpy/common/config/watchlist:
101
102 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
103
104         Temporarily disable the Python unittests broken by the commit queue not running layout tests
105         https://bugs.webkit.org/show_bug.cgi?id=113997
106
107         Reviewed by Ryosuke Niwa.
108
109         Disable the tests until Ryosuke gets the time and hardware to have
110         a testing commit-queue.
111
112         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
113         (CommitQueueTaskTest):
114         * Scripts/webkitpy/tool/commands/queues_unittest.py:
115         (CommitQueueTest):
116
117 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
118
119         Remove Chromium builders from build.webkit.org
120         https://bugs.webkit.org/show_bug.cgi?id=113990
121
122         Reviewed by Benjamin Poulain.
123
124         Land the part to disable triggering of Chromium builders first so that we may start
125         deleting more Chromium code that breaks the update step.
126
127         * BuildSlaveSupport/build.webkit.org-config/config.json:
128
129 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
130
131         Remove Chromium's DumpRenderTree
132         https://bugs.webkit.org/show_bug.cgi?id=113989
133
134         Reviewed by Kent Tamura.
135
136         On second thought, let's not go to Camelot. It is a silly place.
137
138         * DumpRenderTree/mac/DumpRenderTree.mm:
139         (resetDefaultsToConsistentValues):
140
141 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
142
143         Nixed the defunct chromium folder from DumpRenderTree
144         https://bugs.webkit.org/show_bug.cgi?id=113993
145
146         Reviewed by Ryosuke Niwa.
147
148         * DumpRenderTree/chromium: Removed.
149         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
150         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
151         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
152         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
153         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
154         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
155         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
156         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
157         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
158         * DumpRenderTree/chromium/MockPlatform.h: Removed.
159         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
160         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
161         * DumpRenderTree/chromium/Task.cpp: Removed.
162         * DumpRenderTree/chromium/Task.h: Removed.
163         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
164         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
165         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
166         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
167         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
168         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
169         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
170         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
171         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
172         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
173         * DumpRenderTree/chromium/TestRunner: Removed.
174         * DumpRenderTree/chromium/TestRunner/public: Removed.
175         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
176         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
177         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
178         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
179         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
180         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
181         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
182         * DumpRenderTree/chromium/TestRunner/src: Removed.
183         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
184         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
185         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
186         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
187         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
188         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
189         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
190         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
191         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
192         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
193         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
194         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
195         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
196         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
197         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
198         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
199         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
200         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
201         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
202         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
203         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
204         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
205         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
206         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
207         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
208         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
209         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
210         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
211         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
212         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
213         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
214         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
215         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
216         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
217         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
218         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
219         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
220         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
221         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
222         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
223         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
224         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
225         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
226         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
227         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
228         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
229         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
230         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
231         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
232         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
233         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
234         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
235         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
236         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
237         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
238         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
239         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
240         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
241         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
242         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
243         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
244         * DumpRenderTree/chromium/TestShell.cpp: Removed.
245         * DumpRenderTree/chromium/TestShell.h: Removed.
246         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
247         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
248         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
249         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
250         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
251         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
252         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
253         * DumpRenderTree/chromium/WebViewHost.h: Removed.
254         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
255         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
256         * DumpRenderTree/chromium/config.h: Removed.
257         * DumpRenderTree/chromium/fonts.conf: Removed.
258
259 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
260
261         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
262
263         Rubber stamped by Benjamin Poulain.
264
265         * RebaselineQueueServer: Removed.
266         * RebaselineQueueServer/app.yaml: Removed.
267         * RebaselineQueueServer/handlers: Removed.
268         * RebaselineQueueServer/handlers/__init__.py: Removed.
269         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
270         * RebaselineQueueServer/handlers/pages.py: Removed.
271         * RebaselineQueueServer/index.yaml: Removed.
272         * RebaselineQueueServer/main.py: Removed.
273         * RebaselineQueueServer/model: Removed.
274         * RebaselineQueueServer/model/__init__.py: Removed.
275         * RebaselineQueueServer/model/queueentry.py: Removed.
276         * RebaselineQueueServer/static: Removed.
277         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
278         * RebaselineQueueServer/static/styles.css: Removed.
279         * RebaselineQueueServer/templates: Removed.
280         * RebaselineQueueServer/templates/builder-picker.html: Removed.
281         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
282         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
283         * RebaselineQueueServer/templates/home.html: Removed.
284
285 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
286
287         Fix setup-commit-queue and temporarily disable testing on commit-queue
288         https://bugs.webkit.org/show_bug.cgi?id=113979
289
290         Reviewed by Benjamin Poulain.
291
292         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
293         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
294
295         * EWSTools/setup-commit-queue.sh:
296         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
297         (CommitQueueTask.run):
298
299 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
300
301         temporarily make flakiness dashboard work again webkit.org bots
302         https://bugs.webkit.org/show_bug.cgi?id=113972
303
304         Reviewed by Ojan Vafai.
305
306         This patch disables the chromium.org layout test bots TestExpectations
307         parsing temporarily until we can work out the right way to split into
308         two instances for webkit.org and chromium.org and figure out which
309         code to delete where :).
310
311         * TestResultServer/static-dashboards/flakiness_dashboard.js:
312
313 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
314
315         Fix webkitpy tests after r147678.
316
317         * Scripts/webkitpy/tool/commands/queues_unittest.py:
318         (CommitQueueTest.test_commit_queue):
319         (test_manual_reject_during_processing):
320
321 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
322
323         The commit queue should use Mac MountainLion port
324         https://bugs.webkit.org/show_bug.cgi?id=113971
325
326         Reviewed by Lucas Forschler.
327
328         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
329         * Scripts/webkitpy/tool/commands/queues.py:
330         (CommitQueue):
331
332 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
333
334         turn off running tests on chromium linux EWS bots
335         https://bugs.webkit.org/show_bug.cgi?id=113959
336
337         Reviewed by Geoffrey Garen.
338
339         Now that the Chromium port is no longer being maintained
340         there's little point in running the tests. Soon we should
341         just shut this bot off altogether.
342
343         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
344         (ChromiumLinuxEWS):
345
346 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
347
348         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
349
350         * Scripts/webkitpy/common/config/watchlist:
351
352 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
353
354         Indentation fix to get webkit-patch working again after r147625
355
356         Unreviewed.
357
358         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
359         (MacEWS):
360         (MacWK2EWS):
361
362 2013-04-04  Lucas Forschler  <lforschler@apple.com>
363
364         Turn tests back on for Mac WK1/WK2 EWS.
365         
366         Unreviewed.
367         
368         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
369         (MacEWS):
370         (MacWK2EWS):
371
372 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
373
374         [GTK][WK2] MiniBrowser custom URI scheme support
375         https://bugs.webkit.org/show_bug.cgi?id=112419
376
377         Reviewed by Carlos Garcia Campos.
378
379         Add support for about URIs in MiniBrowser. An example about page is show
380         with URI "about:minibrowser", the rest of the cases it will show a
381         proper message explaining that the about page didn't exist.
382
383         Internally it uses "minibrowser-about" prefix instead of "about", but
384         from the user point of view it works with "about" prefix.
385
386         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
387         (getInternalURI): Method to convert URIs from "about" prefix to
388         "minibrowser-about".
389         (getExternalURI): Opposite method.
390         (webViewURIChanged): Use "about" prefix to show the URI to users.
391         (webViewEnterFullScreen): Ditto.
392         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
393         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
394         (aboutURISchemeRequestCallback): Callback to manage about calls.
395         (main): Register the URI scheme to manage about URIs.
396
397 2013-04-03  Roger Fong  <roger_fong@apple.com>
398
399         Re-enable WinEWS tests.
400
401         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
402         (WinEWS):
403
404 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
405
406         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
407         https://bugs.webkit.org/show_bug.cgi?id=113883
408
409         Reviewed by Martin Robinson.
410
411         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
412         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
413         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
414
415 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
416
417         [GTK] Include Pango in jhbuild-optional.modules
418         https://bugs.webkit.org/show_bug.cgi?id=113878
419
420         Reviewed by Martin Robinson.
421
422         Since r147547 Pango 1.32.0 is required. Including the module in the
423         JHBuild optional moduleset.
424
425         * gtk/jhbuild-optional.modules: Add Pango module.
426
427 2013-04-03  Zeno Albisser  <zeno@webkit.org>
428
429         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
430         https://bugs.webkit.org/show_bug.cgi?id=113864
431
432         Moving setDefersLoading from TestRunnerQt to TestRunner
433         requires access to the non-Qt TestRunner.
434         As long as we instantiate both TestRunner and TestRunnerQt,
435         we need a separate getter for the non-Qt TestRunner instance.
436
437         Reviewed by Simon Hausmann.
438
439         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
440         (WebPage::resetSettings):
441         * DumpRenderTree/qt/DumpRenderTreeQt.h:
442         (DumpRenderTree::jscTestRunner):
443         * DumpRenderTree/qt/TestRunnerQt.cpp:
444         (TestRunner::setDefersLoading):
445             Moving setDefersLoading from TestRunnerQt
446             to TestRunner.
447         * DumpRenderTree/qt/TestRunnerQt.h:
448         (TestRunnerQt):
449
450 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
451
452         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
453         https://bugs.webkit.org/show_bug.cgi?id=104779
454
455         Reviewed by Carlos Garcia Campos.
456
457         * Scripts/run-gtk-tests:
458         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
459         passing in current trunk.
460
461 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
462
463         Fix HAVE(QTTESTSUPPORT) logic
464
465         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
466         resulting in HAVE(QTTESTSUPPORT) never being true.
467         Move that logic down in sanitizeFeatures.
468
469         Rubber-stamped by Tor Arne Vestbø.
470
471         * qmake/mkspecs/features/features.prf:
472
473 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
474
475         [GTK] Bump required versions of some dependencies
476         https://bugs.webkit.org/show_bug.cgi?id=113282
477
478         Reviewed by Martin Robinson.
479
480         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
481
482 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
483
484         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
485         https://bugs.webkit.org/show_bug.cgi?id=113809
486
487         Reviewed by Philippe Normand.
488
489         Newer Linux kernels have removed some deprecated macros from v4l2
490         headers, causing gst-plugins-good's build to break. We don't need it
491         right now, so just disable it.
492
493         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
494
495 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
496
497         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
498         https://bugs.webkit.org/show_bug.cgi?id=113535
499
500         Reviewed by Simon Hausmann.
501
502         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
503
504         * qmake/mkspecs/features/features.prf:
505
506 2013-04-03  Zeno Albisser  <zeno@webkit.org>
507
508         [Qt] Move logic of simple forwarding functions to TestRunner.
509         https://bugs.webkit.org/show_bug.cgi?id=113863
510
511         Reviewed by Simon Hausmann.
512
513         * DumpRenderTree/qt/TestRunnerQt.cpp:
514         (TestRunner::setTextDirection):
515         (TestRunner::goBack):
516         (TestRunner::evaluateScriptInIsolatedWorld):
517         (TestRunner::addUserStyleSheet):
518         * DumpRenderTree/qt/TestRunnerQt.h:
519         (TestRunnerQt):
520
521 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
522
523         [Qt] Disable media support using QuickTime if deployment target != SDK
524
525         We link to a single libWebKitSystemInterface static lib, so unless the
526         deployment target matches the SDK let's not pretend like we'll be able
527         to run on anything lower than the SDK version.
528
529         Reviewed by Simon Hausmann.
530
531         * qmake/mkspecs/features/features.prf:
532
533 2013-04-02  James Craig  <james@cookiecrook.com>
534
535         AXRoleDescripton for DL is "list"; should be "description list"
536         https://bugs.webkit.org/show_bug.cgi?id=111665
537
538         Reviewed by Chris Fleizach.
539
540         Defining the role and description strings.
541
542         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
543
544 2013-04-02  Roger Fong  <roger_fong@apple.com>
545
546         Unreviewed. Disable running tests on Win EWS queue.
547
548         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
549         (WinEWS):
550
551 2013-04-02  Lucas Forschler  <lforschler@apple.com>
552
553         Disable running tests on the MAC WK2 EWS queue.
554         
555         Unreviewed.
556         
557         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
558         (MacWK2EWS):
559
560 2013-04-02  Julie Parent  <jparent@chromium.org>
561
562         Dashboard refactor: Move dashboard specific history related features to History.
563         https://bugs.webkit.org/show_bug.cgi?id=113717
564
565         Reviewed by Ojan Vafai.
566         
567         Each dashboard now creates its own History object, with a custom
568         configuration. This changes from just overriding global functions
569         to passing in callbacks for generatePage, handleValidHashParameter,
570         and handleQueryParameterChange. Same with passing in defaultStateValues
571         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
572         variables.
573         
574         All functions related to these features are now (mostly) private
575         function on History. 
576         
577         Loader no longer needs a loadingComplete callback, since it can just
578         initialize the history object itself.
579
580         * TestResultServer/static-dashboards/aggregate_results.js:
581         (handleValidHashParameter):
582         * TestResultServer/static-dashboards/dashboard_base.js:
583         * TestResultServer/static-dashboards/flakiness_dashboard.js:
584         (generatePage):
585         (.switch.return):
586         (handleQueryParameterChange):
587         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
588         (resetGlobals):
589         * TestResultServer/static-dashboards/history.js:
590         (.):
591         * TestResultServer/static-dashboards/loader.js:
592         (.):
593         * TestResultServer/static-dashboards/loader_unittests.js:
594         * TestResultServer/static-dashboards/timeline_explorer.js:
595         (generatePage):
596         (initCurrentBuilderTestResults):
597         * TestResultServer/static-dashboards/treemap.js:
598         (generatePage):
599         (.switch.return):
600         (handleQueryParameterChange):
601
602 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
603
604         Unreviewed, rolling out r147401.
605         http://trac.webkit.org/changeset/147401
606         https://bugs.webkit.org/show_bug.cgi?id=113767
607
608         The patch makes it extremely hard to set up the dependencies
609         properly on the GTK builders (Requested by zdobersek on
610         #webkit).
611
612         * gtk/jhbuild.modules:
613
614 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
615
616         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
617         https://bugs.webkit.org/show_bug.cgi?id=113382
618
619         Reviewed by Gyuyoung Kim.
620
621         Do not show the empty tooltip box if the text is null.
622
623         * MiniBrowser/efl/main.c:
624         (popup_menu_populate):
625
626 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
627
628         [GTK] Bump required versions of some dependencies
629         https://bugs.webkit.org/show_bug.cgi?id=113282
630
631         Reviewed by Martin Robinson.
632
633         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
634
635 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
636
637         Unreviewed, rolling out r147319.
638         http://trac.webkit.org/changeset/147319
639         https://bugs.webkit.org/show_bug.cgi?id=113707
640
641         The unit test is still failing on the buildbot (Requested by
642         zdobersek on #webkit).
643
644         * Scripts/run-gtk-tests:
645         (TestRunner):
646
647 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
648
649         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
650         https://bugs.webkit.org/show_bug.cgi?id=104779
651
652         Reviewed by Carlos Garcia Campos.
653
654         * Scripts/run-gtk-tests:
655         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
656         passing in current trunk.
657
658 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
659
660         Unreviewed, rolling out r147289.
661         http://trac.webkit.org/changeset/147289
662         https://bugs.webkit.org/show_bug.cgi?id=113678
663
664         broke Win7 (dbg) build (Requested by shinyak|gardener on
665         #webkit).
666
667         * DumpRenderTree/DumpRenderTree.gypi:
668         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
669         (WebTestRunner):
670         (WebUserMediaClientMock):
671         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
672         (WebTestRunner::WebUserMediaClientMock::taskList):
673         * Scripts/webkitpy/style/checkers/cpp.py:
674         (check_function_definition):
675
676 2013-03-31  Adam Barth  <abarth@webkit.org>
677
678         configure-svn-config.sh fails
679         https://codereview.chromium.org/13392007/
680
681         Reviewed by Eric Seidel.
682
683         This script was trying to use "svn checkout" to dowload a file from
684         svn.webkit.org, but "svn checkout" only works with directories.
685         Instead, we should use "svn export".
686
687         * EWSTools/configure-svn-config.sh:
688
689 2013-03-31  Wei Jia  <wjia@chromium.org>
690
691         Allow WebUserMediaClientMock to be used by client
692         https://bugs.webkit.org/show_bug.cgi?id=113633
693
694         Reviewed by Adam Barth.
695
696         Export WebUserMediaClientMock.
697         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
698
699         * DumpRenderTree/DumpRenderTree.gypi:
700         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
701         (WebUserMediaClientMock):
702         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
703         * Scripts/webkitpy/style/checkers/cpp.py:
704         (check_function_definition):
705
706 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
707
708         Expose FeatureObserver data to WebKit clients
709         https://bugs.webkit.org/show_bug.cgi?id=113613
710
711         Reviewed by Sam Weinig.
712
713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
714         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
715
716 2013-03-29  Greg Hughes  <ghughes@apple.com>
717
718         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
719         https://bugs.webkit.org/show_bug.cgi?id=112276
720
721         Reviewed by Chris Fleizach.
722
723         Added support to test accessibility search predicates with multiple keys.  
724
725         * DumpRenderTree/AccessibilityUIElement.cpp:
726         (uiElementForSearchPredicateCallback):
727         * DumpRenderTree/AccessibilityUIElement.h:
728         (AccessibilityUIElement):
729         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
730         (AccessibilityUIElement::uiElementForSearchPredicate):
731         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
732         (AccessibilityUIElement::uiElementForSearchPredicate):
733         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
734         (AccessibilityUIElement::uiElementForSearchPredicate):
735         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
736         (AccessibilityUIElement::uiElementForSearchPredicate):
737         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
738         (AccessibilityUIElement::uiElementForSearchPredicate):
739         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
740         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
741         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
742         (AccessibilityUIElement):
743         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
744         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
745         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
746         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
747         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
748
749 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
750
751         Fix a typo in r147147 to fix Mac EWS.
752
753         * Scripts/webkitpy/tool/commands/queues.py:
754         (PatchProcessingQueue._new_port_name_from_old):
755
756 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
757
758         [EFL] Build break with latest EFL libraries after r146265
759         https://bugs.webkit.org/show_bug.cgi?id=113558
760
761         Unreviewed build fix.
762
763         * TestWebKitAPI/PlatformWebView.h:
764         * WebKitTestRunner/PlatformWebView.h:
765
766 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
767
768         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
769
770         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
771         in libgcrypt build.
772
773 2013-03-28  Lucas Forschler  <lforschler@apple.com>
774
775         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
776
777         Unreviewed.
778
779         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
780         (MacEWS):
781
782 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
783
784         Use the right OS name on Mac EWS instead of mac-future.
785
786         Rubber-stamped by Dirk Pranke.
787
788         * Scripts/webkitpy/tool/commands/queues.py:
789         (PatchProcessingQueue._new_port_name_from_old):
790         (PatchProcessingQueue.begin_work_queue):
791         (PatchProcessingQueue._upload_results_archive_for_patch):
792
793 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
794
795         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
796         https://bugs.webkit.org/show_bug.cgi?id=112546
797
798         Reviewed by Martin Robinson.
799
800         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
801         moved back to Source/WebCore/platform. Fix an indentation issue as well.
802
803 2013-03-28  Ming Xie  <mxie@blackberry.com>
804
805         [BlackBerry] Committer Email Updates
806         https://bugs.webkit.org/show_bug.cgi?id=113435
807
808         Reviewed by Rob Buis.
809
810         Add the @blackberry.com email address for all our BlackBerry
811         WebKit committers. This is the first step for our email address
812         migration.
813
814         * Scripts/webkitpy/common/config/committers.py:
815
816 2013-03-28  Philippe Normand  <pnormand@igalia.com>
817
818         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
819         https://bugs.webkit.org/show_bug.cgi?id=113508
820
821         Reviewed by Martin Robinson.
822
823         Prevent the GStreamer plugin scanner to load system-wide
824         plugins. Only the ones built in JHBuild should be loaded and used
825         at runtime.
826
827         * efl/jhbuildrc:
828         * gtk/jhbuildrc:
829
830 2013-03-27  Philippe Normand  <pnormand@igalia.com>
831
832         [GTK] run-launcher --gtk -2 fails on a WK2-only build
833         https://bugs.webkit.org/show_bug.cgi?id=113386
834
835         Reviewed by Carlos Garcia Campos.
836
837         * Scripts/webkitdirs.pm:
838         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
839         version to 3.0. Reflect this change so the builtDylibPathForName
840         function doesn't fail to report the library as found.
841
842 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
843
844         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
845         https://bugs.webkit.org/show_bug.cgi?id=113484
846
847         Unreviewed build fix.
848
849         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
850
851         * TestWebKitAPI/CMakeLists.txt:
852         * WebKitTestRunner/CMakeLists.txt:
853
854 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
855
856         Revision for the internal jhbuild is too old
857         https://bugs.webkit.org/show_bug.cgi?id=113324
858
859         Reviewed by Martin Robinson.
860
861         Update the minimum required version to a point where jhbuild won't
862         fail installing packages when trying to remove a symlink to a directory.
863
864         * jhbuild/jhbuild-wrapper: Updated revision.
865
866 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
867
868         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
869         https://bugs.webkit.org/show_bug.cgi?id=113203
870
871         Reviewed by Philippe Normand.
872
873         We build our libsoup without GNOME support. gst-plugins-good does separate
874         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
875         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
876         build failures as the headers of those diverge. We do not use souphttpsrc, so
877         disable it when building gst-plugins-good.
878
879         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
880
881 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
882
883         Build fix after r146852. Please another reference to the Lion leaks builder.
884
885         * BuildSlaveSupport/build.webkit.org-config/config.json:
886
887 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
888
889         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
890         https://bugs.webkit.org/show_bug.cgi?id=113421
891
892         Reviewed by Dirk Pranke.
893
894         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
895         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
896         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
897         in the GTK-specific TestExpectations files.
898
899         To avoid this only enable the warnings only when not using WKTR.
900
901         * Scripts/webkitpy/layout_tests/port/gtk.py:
902         (GtkPort.warn_if_bug_missing_in_test_expectations):
903
904 2013-03-27  Antti Koivisto  <antti@apple.com>
905
906         Fix Zalan's email.
907
908         * Scripts/webkitpy/common/config/committers.py:
909
910 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
911
912         master.cfg cleanup
913         https://bugs.webkit.org/show_bug.cgi?id=113195
914
915         Reviewed by Ryosuke Niwa.
916
917         * BuildSlaveSupport/build.webkit.org-config/config.json:
918         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
919
920 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
921
922         master.cfg fine-tuning for Qt Mountain Lion Release bot
923         https://bugs.webkit.org/show_bug.cgi?id=113191
924
925         Reviewed by Ryosuke Niwa.
926
927         * BuildSlaveSupport/build.webkit.org-config/config.json:
928           - Rename the slave due to its location change.
929           - Update the platform of the slave.
930         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
931         (RunQtAPITests): Enable running WK2 API tests on Qt.
932         (RunQtAPITests.start):
933         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
934         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
935
936 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
937
938         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
939         https://bugs.webkit.org/show_bug.cgi?id=113403
940
941         Reviewed by Kenneth Rohde Christiansen.
942
943         As of Evas 1.7.5, when Wayland is detected on the system, support for
944         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
945         The code, however, seems to depend on a few other flags which must be
946         explicitly enabled.
947
948         If those additional GL-related options are passed, we end up
949         having issues on the WebKit side, so disable Wayland support for
950         now.
951
952         * efl/jhbuild.modules:
953
954 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
955
956         Unreviewed, rolling out r146864.
957         http://trac.webkit.org/changeset/146864
958         https://bugs.webkit.org/show_bug.cgi?id=113391
959
960         causes crashes on Wk2 EFL release bot (Requested by drott on
961         #webkit).
962
963         * Scripts/webkitperl/FeatureList.pm:
964
965 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
966
967         [jhbuild] Correctly specify an alternate number of make jobs.
968         https://bugs.webkit.org/show_bug.cgi?id=113396
969
970         Reviewed by Philippe Normand.
971
972         So far, we were using the `MAKEFLAGS' environment variable to pass the
973         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
974         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
975
976         We now behave more closely to the rest of the WebKit tools by first
977         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
978         not set, just letting jhbuild itself figure out how many jobs to use.
979
980         * efl/jhbuildrc:
981         * gtk/jhbuildrc:
982
983 2013-03-27  Zeno Albisser  <zeno@webkit.org>
984
985         [Qt] Remove Qt specific WorkQueueItem definitions.
986         https://bugs.webkit.org/show_bug.cgi?id=112891
987
988         This patch is preparation work for removing
989         WorkQueue related code from TestRunnerQt and
990         replacing it with generic TestRunner code.
991
992         Reviewed by Benjamin Poulain.
993
994         * DumpRenderTree/qt/TestRunnerQt.cpp:
995         (TestRunnerQt::queueBackNavigation):
996         (TestRunnerQt::queueForwardNavigation):
997         (TestRunnerQt::queueLoadHTMLString):
998         (TestRunnerQt::queueReload):
999         (TestRunnerQt::queueLoadingScript):
1000         (TestRunnerQt::queueNonLoadingScript):
1001         (TestRunner::queueLoad):
1002         * DumpRenderTree/qt/TestRunnerQt.h:
1003         (TestRunnerQt):
1004         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1005         (LoadItem::invoke):
1006         (LoadHTMLStringItem::invoke):
1007         (LoadAlternateHTMLStringItem::invoke):
1008         (ReloadItem::invoke):
1009         (ScriptItem::invoke):
1010         (BackForwardItem::invoke):
1011         * DumpRenderTree/qt/WorkQueueItemQt.h:
1012         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1013         (LoadAlternateHTMLStringItem):
1014
1015 2013-03-26  Julie Parent  <jparent@chromium.org>
1016
1017         Flakiness dashboard: simplify logic around which tests to show.
1018         https://bugs.webkit.org/show_bug.cgi?id=113250
1019
1020         Reviewed by Ojan Vafai.
1021         
1022         The different filters for showing results are only used for layout
1023         tests, otherwise, we show everything.
1024         
1025         Change the defaults to false (what layout tests used), and only
1026         look at the values when viewing layout tests.
1027
1028         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1029         (htmlForTestsWithExpectationsButNoFailures):
1030         (shouldHideTest):
1031
1032 2013-03-26  Isaac Levy  <ilevy@google.com>
1033
1034         Update bots on test-results.appspot
1035         https://bugs.webkit.org/show_bug.cgi?id=113333
1036
1037         Reviewed by Ojan Vafai.
1038
1039         * TestResultServer/static-dashboards/builders.jsonp:
1040
1041 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1042
1043         Unreviewed GTK gardening.
1044
1045         * Scripts/run-gtk-tests:
1046         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1047
1048 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1049
1050         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1051         https://bugs.webkit.org/show_bug.cgi?id=113287
1052
1053         Reviewed by Jocelyn Turcotte.
1054
1055         * Scripts/run-qtwebkit-tests:
1056         (Options.__init__):
1057
1058 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1059
1060         [EFL] Enable IndexedDB by default
1061         https://bugs.webkit.org/show_bug.cgi?id=107248
1062
1063         Reviewed by Laszlo Gombos.
1064
1065         * Scripts/webkitperl/FeatureList.pm:
1066         Enable IndexedDB by default on EFL.
1067
1068 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1069
1070         Sheriffbot should explain rollout failures in a human readable form.
1071         https://bugs.webkit.org/show_bug.cgi?id=107092
1072
1073         Reviewed by Ryosuke Niwa.
1074
1075         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1076
1077         * Scripts/webkitpy/tool/bot/irc_command.py:
1078         (Rollout._check_diff_failure):
1079         (Rollout.execute):
1080         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1081         (IRCCommandTest.test_rollout):
1082
1083 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1084
1085         Unreviewed GTK gardening.
1086
1087         * Scripts/run-gtk-tests:
1088         (TestRunner): Skipping a failing unit test after r146518.
1089
1090 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1091
1092         Remove Lion leaks builder
1093         https://bugs.webkit.org/show_bug.cgi?id=113252
1094
1095         Reviewed by Andreas Kling.
1096
1097         Removed.
1098
1099         * BuildSlaveSupport/build.webkit.org-config/config.json:
1100
1101 2013-03-25  Kent Tamura  <tkent@chromium.org>
1102
1103         Rename ENABLE_INPUT_TYPE_DATETIME
1104         https://bugs.webkit.org/show_bug.cgi?id=113254
1105
1106         Reviewed by Kentaro Hara.
1107
1108         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1109         Actually I'd like to remove the code, but we shouldn't remove it yet
1110         because we shipped products with it on some platforms.
1111
1112         * Scripts/webkitperl/FeatureList.pm:
1113         * qmake/mkspecs/features/features.pri:
1114
1115 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1116
1117         Remove one more line that was intended to be removed in r146657.
1118
1119         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1120         (summarize_results):
1121
1122 2013-03-25  Roger Fong  <roger_fong@apple.com>
1123
1124         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1125         Re-enable WinEWS tests.
1126
1127         * Scripts/webkitpy/common/config/ports.py:
1128         (WinPort.run_bindings_tests_command):
1129         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1130         (WinEWS):
1131
1132 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1133
1134         Unreviewed, rolling out r146793.
1135         http://trac.webkit.org/changeset/146793
1136         https://bugs.webkit.org/show_bug.cgi?id=113248
1137
1138         Fix did not work (Requested by rfong on #webkit).
1139
1140         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1141         (WinEWS):
1142
1143 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1144
1145         REGRESSION(r146657): Test failures reported incorrectly
1146         https://bugs.webkit.org/show_bug.cgi?id=113223
1147
1148         Reviewed by Dirk Pranke.
1149
1150         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1151
1152         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1153         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1154
1155         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1156         (Manager.run):
1157
1158         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1159         (RunDetails.__init__):
1160         (summarize_results): Remove the line I intended to remove in r146657.
1161
1162         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1163         (logging_run): Return details instead of the exit code.
1164         (run_and_capture): Ditto.
1165
1166         (RunTest.test_full_results_html):
1167         (RunTest.test_hung_thread):
1168         (RunTest.test_no_tests_found):
1169         (RunTest.test_no_tests_found_2):
1170         (RunTest.test_repeat_each_iterations_num_tests):
1171         (RunTest.test_run_singly_actually_runs_tests):
1172         (RunTest.test_test_list):
1173         (RunTest.test_missing_and_unexpected_results):
1174         (RunTest.test_pixel_test_directories):
1175         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1176         (RunTest.test_crash_with_stderr):
1177         (RunTest.test_no_image_failure_with_image_diff):
1178         (RunTest.test_crash_log):
1179         (RunTest.test_exit_after_n_failures_upload):
1180         (RunTest.test_results_directory_absolute):
1181         (RunTest.test_results_directory_relative):
1182         (RunTest.test_retrying_and_flaky_tests):
1183         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1184         (RunTest.test_retrying_uses_retries_directory):
1185         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1186         (RunTest.test_output_diffs):
1187         (EndToEndTest.test_reftest_with_two_notrefs):
1188         (RebaselineTest.test_reset_results):
1189         (RebaselineTest.test_missing_results):
1190         (RebaselineTest.test_new_baseline):
1191
1192         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1193         (BuildBotPrinter.print_results):
1194         (BuildBotPrinter.print_unexpected_results):
1195         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1196         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1197
1198 2013-03-25  Julie Parent  <jparent@chromium.org>
1199
1200         Dashboard refactor: Move cross dashboard history related code into history.js.
1201         https://bugs.webkit.org/show_bug.cgi?id=113104
1202
1203         Reviewed by Ojan Vafai.
1204
1205         All functions relating to cross dashboard behavior move from being
1206         globals to methods on the history.History object. Names stay the same,
1207         except many are made private, ones that should have been constants now
1208         are, and the long standing TODO to change "currentState" to 
1209         dashboardSpecificState is done.
1210         
1211         We now create a global history object in dashboard_base, as an 
1212         intermediate measure.  Once the dashboard specific code is
1213         added to history, each DB will need to create its own, and this
1214         global will be eliminated.
1215         
1216         * TestResultServer/static-dashboards/aggregate_results.js:
1217         (handleValidHashParameter):
1218         (htmlForBuilder):
1219         (rawValuesHTML):
1220         * TestResultServer/static-dashboards/dashboard_base.js:
1221         (parseDashboardSpecificParameters):
1222         (defaultValue):
1223         (currentBuilderGroupCategory):
1224         (currentBuilderGroupName):
1225         (handleLocationChange):
1226         (expectationsMap):
1227         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1228         (generatePage):
1229         (.switch.return):
1230         (platformAndBuildType):
1231         (individualTests):
1232         (substringList):
1233         (processMissingAndExtraExpectations):
1234         (pathToFailureLog):
1235         (showPopupForBuild):
1236         (htmlForTestsWithExpectationsButNoFailures):
1237         (shouldHideTest):
1238         (isCrossBuilderView):
1239         (tableHeaders):
1240         (htmlForSingleTestRow):
1241         (htmlForTableColumnHeader):
1242         (generatePageForExpectationsUpdate):
1243         (handleUpdate):
1244         (nextUpdate):
1245         (setUpdateIndex):
1246         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1247         (.appendExpectationsItem):
1248         (loadExpectations):
1249         (.dummyNode.onload):
1250         (loadExpectationsLayoutTests):
1251         (appendExpectations):
1252         (htmlForNavBar):
1253         (checkBoxToToggleState):
1254         (linkHTMLToToggleState):
1255         (generatePageForBuilder):
1256         (isInvalidKeyForCrossBuilderView):
1257         (handleQueryParameterChange):
1258         (showLegend):
1259         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1260         (resetGlobals):
1261         (test):
1262         * TestResultServer/static-dashboards/history.js:
1263         (.):
1264         * TestResultServer/static-dashboards/history_unittests.js:
1265         * TestResultServer/static-dashboards/loader.js:
1266         (.):
1267         * TestResultServer/static-dashboards/loader_unittests.js:
1268         * TestResultServer/static-dashboards/timeline_explorer.js:
1269         (generatePage):
1270         (initCurrentBuilderTestResults):
1271         (selectBuild):
1272         (showResultsDelta):
1273         * TestResultServer/static-dashboards/treemap.js:
1274         (generatePage):
1275         (.switch.return):
1276         (handleFocus):
1277         * TestResultServer/static-dashboards/ui.js:
1278
1279 2013-03-25  Roger Fong  <roger_fong@apple.com>
1280
1281         Unreviewed. Enable WinEWS tests again.
1282
1283         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1284         (WinEWS):
1285
1286 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1287
1288         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1289         https://bugs.webkit.org/show_bug.cgi?id=112166
1290
1291         HarfBuzz 0.9.14 merged my patch for icu detection without
1292         pkg-config files, as needed by for example Ubuntu 12.04.
1293         This obsoletes our local workaround. Removed it for GTK and EFL.
1294
1295         Reviewed by Martin Robinson.
1296
1297         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1298         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1299         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1300         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1301
1302 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1303
1304         Unreviewed.  Move self from contributor to committer list.
1305
1306         * Scripts/webkitpy/common/config/committers.py:
1307
1308 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1309
1310         EWS should use a human readable port name when uploading layout test archives
1311         https://bugs.webkit.org/show_bug.cgi?id=113099
1312
1313         Reviewed by Dirk Pranke.
1314
1315         Use new port's object's name() method to report human readable port names.
1316         This will also help us resolving the bug to apply layout test results posted by EWS.
1317
1318         * Scripts/webkitpy/tool/bot/botinfo.py:
1319         (BotInfo.__init__): Take port's name.
1320         (BotInfo.summary_text):
1321
1322         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1323         (BotInfoTest.test_summary_text):
1324
1325         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1326         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1327
1328         * Scripts/webkitpy/tool/commands/queues.py:
1329         (PatchProcessingQueue.__init__): Initialize self._port.
1330         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1331         and use that for the attachment filename and the comment posted.
1332
1333         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1334         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1335         "mac-snowleopard" as expected for TestPort.
1336
1337 2013-03-22  Roger Fong  <roger_fong@apple.com>
1338
1339         Unreviewed. Turn off EWS test on Win again.
1340         The battle continues.
1341
1342         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1343         (WinEWS):
1344
1345 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1346
1347         NRWT: Enable pixel tests when retrying tests
1348         https://bugs.webkit.org/show_bug.cgi?id=112898
1349
1350         Reviewed by Dirk Pranke.
1351
1352         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1353         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1354         if we've forced pixel tests in the retry.
1355         (Manager._run_tests):
1356         (Manager._clean_up_run): Fixed the capitalizations.
1357         (Manager._force_pixel_tests_if_needed): Added.
1358
1359         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1360         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1361         'image_diff_percent' if it doesn't already exist.
1362
1363         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1364         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1365         treat this as a regular regression instead of a flakiness.
1366
1367         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1368         run had image diffs.
1369
1370         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1371         (summarized_results):
1372
1373         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1374         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1375         Also removed some dead code.
1376
1377         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1378         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1379         is set and pixel_tests_enabled is set to false.
1380         (EndToEndTest.test_reftest_with_two_notrefs):
1381
1382 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1383
1384         Make it possible to run layout tests on Retina MBP
1385         https://bugs.webkit.org/show_bug.cgi?id=93673
1386
1387         Reviewed by Ryosuke Niwa.
1388
1389         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1390         windows on 2x machines still run at 1x.
1391
1392         * DumpRenderTree/mac/DumpRenderTree.mm:
1393         (createWebViewAndOffscreenWindow):
1394         Reset the window resolution to 1x on creation.
1395         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1396         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1397         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1398         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1399         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1400         (WTR::PlatformWebView::PlatformWebView):
1401         Add NSWindow details, reset the window resolution to 1x on creation.
1402
1403 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1404
1405         Leak bots shouldn't build
1406         https://bugs.webkit.org/show_bug.cgi?id=112774
1407
1408         Reviewed by Simon Fraser.
1409
1410         Since leak bots use regular debug builds, there is no need to build on these bots.
1411         Simply downloading builds will dramatically improve the cycle time of these bots.
1412
1413         * BuildSlaveSupport/build.webkit.org-config/config.json:
1414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1415         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1416         TestFactory instead of BuildAndTestFactory.
1417
1418 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1419
1420         [Qt] Fix the TestWebKitAPI build
1421         https://bugs.webkit.org/show_bug.cgi?id=113044
1422
1423         Reviewed by Tor Arne Vestbø.
1424
1425         The generate-forwarding-headers script would only be run
1426         after the targets in InjectedBundle.pri since the second
1427         addStrictSubdirOrderBetween call in
1428         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1429         the derived_sources -> injected_bundle order in SUBDIRS.
1430
1431         Fix it by only moving the dependent target at the end of
1432         SUBDIRS, don't touch its dependency.
1433
1434         * qmake/mkspecs/features/functions.prf:
1435
1436 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1437
1438         [EFL][WK2] View is not focused when fullscreen mode toggled
1439         https://bugs.webkit.org/show_bug.cgi?id=113009
1440
1441         Reviewed by Laszlo Gombos.
1442
1443         Set focus on view when fullscreen mode enabled/disabled
1444         by FullScreen API.
1445
1446         * MiniBrowser/efl/main.c:
1447         (on_fullscreen_accept):
1448         (on_fullscreen_deny):
1449
1450 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1451
1452         nrwt is no longer saving retry results in the retries/ subdirectory
1453         https://bugs.webkit.org/show_bug.cgi?id=112995
1454
1455         Reviewed by Ojan Vafai.
1456
1457         I think this has been broken a long time, unfortunately. This
1458         patch should fix that.
1459
1460         In order to do so, I had to pass the directory to use from
1461         the Worker object through the SingleTestWriter to the
1462         TestResultWriter. While I was plumbing that through, I rationalized
1463         the order of the parameter arguments a bit ...
1464
1465         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1466         (Worker._run_single_test):
1467         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1468         (run_single_test):
1469         (SingleTestRunner.__init__):
1470         (SingleTestRunner._run_compare_test):
1471         (SingleTestRunner._run_rebaseline):
1472         (SingleTestRunner._run_reftest):
1473         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1474         (write_test_result):
1475         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1476         (TestResultWriterTest.test_reftest_diff_image):
1477         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1478         (RunTest.test_retrying_uses_retries_directory):
1479
1480 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1481
1482         JSC profiler should have an at-a-glance report of the success of DFG optimization
1483         https://bugs.webkit.org/show_bug.cgi?id=112988
1484
1485         Reviewed by Geoffrey Garen.
1486
1487         * Scripts/display-profiler-output:
1488
1489 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1490
1491         [chromium] Linux ASAN WebKit canary is running out of memory
1492         https://bugs.webkit.org/show_bug.cgi?id=112978
1493
1494         Reviewed by Tony Chang.
1495
1496         Running the AddressSanitizer on a crash takes a lot of
1497         memory, so we should serialize access to it to avoid running
1498         out of memory on a machine.
1499
1500         * Scripts/webkitpy/layout_tests/port/chromium.py:
1501         (ChromiumPort._get_crash_log):
1502         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1503         (HttpLock.__init__):
1504         (HttpLock.wait_for_httpd_lock):
1505
1506 2013-03-21  Min Qin  <qinmin@chromium.org>
1507
1508         Cleanup android media layout test code
1509         https://bugs.webkit.org/show_bug.cgi?id=112944
1510
1511         Reviewed by Adam Barth.
1512
1513         Chromium change: https://codereview.chromium.org/12892010/
1514         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1515         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1516         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1517         Instead, we should switch to use content shell for layout tests.
1518
1519         * DumpRenderTree/chromium/TestShell.cpp:
1520         (TestShell::resetTestController):
1521
1522 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1523
1524         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1525         https://bugs.webkit.org/show_bug.cgi?id=112953
1526
1527         Reviewed by Tony Chang.
1528
1529         When I created the DumpRenderTree_resources target in r144863 I
1530         forgot to declare the needed dependencies on the other resource
1531         targets. Due to a quirk of ordering, this appears to have been fine
1532         w/ ninja but not w/ Xcode (which is still being used on the chromium
1533         mac valgrind bots). Declaring the dependencies fixes the build
1534         failures.
1535
1536         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1537
1538 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1539
1540         [WinCairo] Correct assert in Empty BitmapImage Test.
1541         https://bugs.webkit.org/show_bug.cgi?id=112934
1542
1543         Reviewed by Tim Horton.
1544
1545         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1546         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1547         to avoid ref counting assertion when leaving test scope.
1548
1549 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1550
1551         [GTK] generate-feature-defines-files is incompatible with Python3
1552         https://bugs.webkit.org/show_bug.cgi?id=112956
1553
1554         Reviewed by Martin Robinson.
1555
1556         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1557         method on the dictionary objects when iterating through said dictionaries.
1558
1559         * gtk/generate-feature-defines-files:
1560         (write_feature_defines_header):
1561         (write_flattened_feature_defines_file):
1562
1563 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1564
1565         kill-old-processes spits out error messages on Mac
1566         https://bugs.webkit.org/show_bug.cgi?id=112878
1567
1568         Reviewed by Jessie Berlin.
1569
1570         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1571         included in the list of options grep --help shows.
1572
1573         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1574
1575         * BuildSlaveSupport/kill-old-processes:
1576         (main):
1577
1578 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1579
1580         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1581         https://bugs.webkit.org/show_bug.cgi?id=112597
1582
1583         Reviewed by Xan Lopez.
1584
1585         These were introduced for the Chromium port in r105295. We need
1586         dummy implementations in order to compile the BlackBerry port.
1587
1588         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1589         (AccessibilityUIElement::scrollToMakeVisible):
1590         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1591         (AccessibilityUIElement::scrollToGlobalPoint):
1592
1593 2013-03-21  Roger Fong  <roger_fong@apple.com>
1594
1595         Re-enable WinEWS tests following r146376.
1596
1597         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1598         (WinEWS):
1599
1600 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1601
1602         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1603
1604         * Scripts/webkitpy/common/config/committers.py:
1605
1606 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1607
1608         [GTK] Missing atk in install-dependencies script
1609         https://bugs.webkit.org/show_bug.cgi?id=112272
1610
1611         Reviewed by Gustavo Noronha Silva.
1612
1613         * gtk/install-dependencies: Add missing atk dependency.
1614
1615 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1616
1617         [GTK] Missing backslash in install-dependencies script
1618         https://bugs.webkit.org/show_bug.cgi?id=112907
1619
1620         Reviewed by Philippe Normand.
1621
1622         * gtk/install-dependencies: Add missing backslash to dependencies
1623         list.
1624
1625 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1626
1627         EWS bots have stopped uploading results to bugzilla
1628         https://bugs.webkit.org/show_bug.cgi?id=101091
1629
1630         Reviewed by Adam Barth.
1631
1632         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1633         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1634         this relative file path resoled to a file inside a non-existent directory for "zip".
1635
1636         Fixed the bug by resolving both test results directory and zip archive paths in
1637         LayoutTestResultsReader.archive.
1638
1639         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1640         in the future.
1641
1642         * Scripts/webkitpy/common/system/filesystem_mock.py:
1643         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1644
1645         * Scripts/webkitpy/common/system/workspace.py:
1646         (Workspace.create_zip): Log the source path when "zip" failed.
1647
1648         * Scripts/webkitpy/common/system/workspace_mock.py:
1649         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1650
1651         * Scripts/webkitpy/common/system/workspace_unittest.py:
1652         (WorkspaceTest.test_create_zip_exception): Test that.
1653
1654         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1655         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1656         This is the actual bug fix.
1657
1658         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1659         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1660
1661 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1662
1663         [chromium] move WebThemeEngine implementations to TestRunner library
1664         https://bugs.webkit.org/show_bug.cgi?id=112751
1665
1666         Reviewed by Adam Barth.
1667
1668         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1669         * DumpRenderTree/DumpRenderTree.gypi:
1670         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1671         (WebKit):
1672         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1673         (WebTestRunner::TestInterfaces::themeEngine):
1674         (WebTestRunner):
1675         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1676         (WebKit):
1677         (TestInterfaces):
1678         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1679         (WebTestRunner::WebTestInterfaces::themeEngine):
1680         (WebTestRunner):
1681         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1682         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1683         (WebTestRunner):
1684         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1685         (WebTestRunner::WebTestThemeControlWin::box):
1686         (WebTestRunner::WebTestThemeControlWin::line):
1687         (WebTestRunner::WebTestThemeControlWin::triangle):
1688         (WebTestRunner::WebTestThemeControlWin::roundRect):
1689         (WebTestRunner::WebTestThemeControlWin::oval):
1690         (WebTestRunner::WebTestThemeControlWin::circle):
1691         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1692         (WebTestRunner::WebTestThemeControlWin::markState):
1693         (WebTestRunner::WebTestThemeControlWin::draw):
1694         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1695         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1696         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1697         (WebTestRunner):
1698         (WebTestThemeControlWin):
1699         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1700         (WebTestRunner):
1701         (WebTestThemeEngineMac):
1702         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1703         (+[FakeActiveWindow alwaysActiveWindow]):
1704         (+[FakeActiveWindow alwaysInactiveWindow]):
1705         (-[FakeActiveWindow initWithActiveControls:]):
1706         (-[FakeActiveWindow _hasActiveControls]):
1707         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1708         (WebTestRunner):
1709         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1710         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1711         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1712         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1713         (WebTestRunner):
1714         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1715         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1716         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1717         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1718         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1719         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1720         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1721         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1722         (WebTestRunner::WebTestThemeEngineWin::getSize):
1723         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1724         (WebTestRunner):
1725         (WebTestThemeEngineWin):
1726         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1727         * DumpRenderTree/chromium/TestShell.cpp:
1728         (TestShell::initialize):
1729         * DumpRenderTree/chromium/TestShell.h:
1730         (WebKit):
1731         * DumpRenderTree/chromium/TestShellMac.mm:
1732         (platformInit):
1733         * DumpRenderTree/chromium/TestShellWin.cpp:
1734         (platformInit):
1735         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1736
1737 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1738
1739         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1740
1741         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1742         New property sheet that does not link against CoreFoundation and
1743         CFNetwork.
1744         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1745         Use new TestWebKitAPICommonWinCairo property sheet.
1746         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1747         Ditto.
1748
1749 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1750
1751         [WinCairo] Unreviewed build fix for VS2010.
1752
1753         Had to add WinCairo-specific property sheets to deal with some
1754         library and path differences with the main Apple port.
1755
1756         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1757         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1758         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1759         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1760         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1761         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1762
1763 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1764
1765         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1766         https://bugs.webkit.org/show_bug.cgi?id=112849
1767
1768         Reviewed by Sam Weinig.
1769
1770         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1771         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1773
1774 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1775
1776         [WinCairo] Build WebKit Tools under VS2010
1777         https://bugs.webkit.org/show_bug.cgi?id=112821
1778
1779         Reviewed by Tim Horton.
1780
1781         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1782         Add WinCairo-specific build target.
1783         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1784         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1785         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1786         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1787         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1788         Add WinCairo-specific build target.
1789         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1790         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1791         Add WinCairo-specific build target.
1792         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1793         WinCairo-specific build target.
1794         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1795         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1796         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1797         specific build target.
1798         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1799         WinCairo-specific build target.
1800         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1801         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1802         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1803
1804 2013-03-20  Roger Fong  <roger_fong@apple.com>
1805
1806         API test gardening AppleWin port.
1807
1808         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1809
1810         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1811         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1812
1813 2013-03-20  Roger Fong  <roger_fong@apple.com>
1814
1815         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1816
1817         * EWSTools/start-queue-win.sh:
1818
1819 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1820
1821         Unreviewed, add myself to committers.py.
1822
1823 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1824
1825         Unreviewed. Adding another email for me.
1826
1827         * Scripts/webkitpy/common/config/committers.py:
1828
1829 2013-03-20  Justin Novosad  <junov@google.com>
1830
1831         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1832         https://bugs.webkit.org/show_bug.cgi?id=112605
1833
1834         Reviewed by James Robinson.
1835
1836         Deleting all the code that was used for propagating and supporting
1837         the Chromium setting for disabling deferred 2d canvas rendering.
1838
1839         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1840         (main):
1841         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1842         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1843         (WebTestRunner::WebPreferences::reset):
1844         (WebTestRunner::WebPreferences::applyTo):
1845         * DumpRenderTree/chromium/TestShell.cpp:
1846         (TestShell::TestShell):
1847         (TestShell::resetWebSettings):
1848         (TestShell::runFileTest):
1849         * DumpRenderTree/chromium/TestShell.h:
1850         (TestShell):
1851
1852 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1853
1854         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1855         https://bugs.webkit.org/show_bug.cgi?id=112699.
1856
1857         Reviewed by Adam Barth.
1858
1859         * Scripts/webkitpy/layout_tests/port/qt.py:
1860         (QtPort._search_paths):
1861         (QtPort._port_specific_expectations_files):
1862         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1863         (QtPortTest):
1864         (QtPortTest._assert_search_path):
1865         (QtPortTest._assert_expectations_files):
1866
1867 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1868
1869         [Qt] Enable kerning by default
1870         https://bugs.webkit.org/show_bug.cgi?id=112704
1871
1872         Reviewed by Jocelyn Turcotte.
1873
1874         Disable kerning by default, since some reference test expectations
1875         expect kerning to be default off.
1876
1877         * DumpRenderTree/qt/TestRunnerQt.cpp:
1878         (TestRunnerQt::reset):
1879         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1880         (WTR::activateFonts):
1881
1882 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1883
1884         [Qt] Remove empty function stubs from TestRunnerQt.
1885         https://bugs.webkit.org/show_bug.cgi?id=112799
1886
1887         We are reducing the code in TestRunnerQt step by step,
1888         in order to finally replace all of it with the generic
1889         TestRunner implementation.
1890         This patch removes several simple function stubs that
1891         currently do not implement any actual functionality.
1892
1893         Reviewed by Kenneth Rohde Christiansen.
1894
1895         * DumpRenderTree/qt/TestRunnerQt.cpp:
1896         * DumpRenderTree/qt/TestRunnerQt.h:
1897         (TestRunnerQt):
1898
1899 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1900
1901         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1902         https://bugs.webkit.org/show_bug.cgi?id=112687
1903
1904         Reviewed by Kenneth Rohde Christiansen.
1905
1906         Hide the SearchBar by default on window creation.
1907
1908         * MiniBrowser/efl/main.c:
1909         (window_create):
1910
1911 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1912
1913         Unreviewed, rolling out r146304.
1914         http://trac.webkit.org/changeset/146304
1915         https://bugs.webkit.org/show_bug.cgi?id=112788
1916
1917         to many expectations to update (Requested by antonm on
1918         #webkit).
1919
1920         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1921         * DumpRenderTree/DumpRenderTree.gypi:
1922         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1923         (WebKit):
1924         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1925         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1926         (TestInterfaces):
1927         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1928         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1929         * DumpRenderTree/chromium/TestShell.cpp:
1930         (TestShell::initialize):
1931         * DumpRenderTree/chromium/TestShell.h:
1932         (WebKit):
1933         * DumpRenderTree/chromium/TestShellMac.mm:
1934         (platformInit):
1935         * DumpRenderTree/chromium/TestShellWin.cpp:
1936         (platformInit):
1937         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1938         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1939         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1940         (WebThemeControlDRTWin::box):
1941         (WebThemeControlDRTWin::line):
1942         (WebThemeControlDRTWin::triangle):
1943         (WebThemeControlDRTWin::roundRect):
1944         (WebThemeControlDRTWin::oval):
1945         (WebThemeControlDRTWin::circle):
1946         (WebThemeControlDRTWin::nestedBoxes):
1947         (WebThemeControlDRTWin::markState):
1948         (WebThemeControlDRTWin::draw):
1949         (WebThemeControlDRTWin::drawTextField):
1950         (WebThemeControlDRTWin::drawProgressBar):
1951         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1952         (WebThemeControlDRTWin):
1953         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1954         (WebThemeEngineDRTMac):
1955         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1956         (+[FakeActiveWindow alwaysActiveWindow]):
1957         (+[FakeActiveWindow alwaysInactiveWindow]):
1958         (-[FakeActiveWindow initWithActiveControls:]):
1959         (-[FakeActiveWindow _hasActiveControls]):
1960         (WebThemeEngineDRTMac::paintScrollbarThumb):
1961         (stateToHIEnableState):
1962         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1963         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1964         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1965         (webRectToSkIRect):
1966         (drawControl):
1967         (drawTextField):
1968         (drawProgressBar):
1969         (WebThemeEngineDRTWin::paintButton):
1970         (WebThemeEngineDRTWin::paintMenuList):
1971         (WebThemeEngineDRTWin::paintScrollbarArrow):
1972         (WebThemeEngineDRTWin::paintScrollbarThumb):
1973         (WebThemeEngineDRTWin::paintScrollbarTrack):
1974         (WebThemeEngineDRTWin::paintSpinButton):
1975         (WebThemeEngineDRTWin::paintTextField):
1976         (WebThemeEngineDRTWin::paintTrackbar):
1977         (WebThemeEngineDRTWin::paintProgressBar):
1978         (WebThemeEngineDRTWin::getSize):
1979         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1980         (WebThemeEngineDRTWin):
1981         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1982
1983 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1984
1985         [Qt] Support -webkit-font-smoothing
1986         https://bugs.webkit.org/show_bug.cgi?id=106009
1987
1988         Reviewed by Jocelyn Turcotte.
1989
1990         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1991
1992         * DumpRenderTree/qt/TestRunnerQt.cpp:
1993         (TestRunnerQt::reset):
1994
1995 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1996
1997         [GTK] accessibility/aria-scrollbar-role.html is failing
1998         https://bugs.webkit.org/show_bug.cgi?id=98358
1999
2000         Reviewed by Martin Robinson.
2001
2002         Adds support for checking accessibility object's orientation.
2003         Orientation is checked by retrieving proper state of accessibility object.
2004
2005         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2006         (checkElementState):
2007         (AccessibilityUIElement::orientation):
2008         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2009         (WTR::AccessibilityUIElement::orientation):
2010
2011 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2012
2013         [chromium] move WebThemeEngine implementations to TestRunner library
2014         https://bugs.webkit.org/show_bug.cgi?id=112751
2015
2016         Reviewed by Adam Barth.
2017
2018         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2019         * DumpRenderTree/DumpRenderTree.gypi:
2020         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2021         (WebKit):
2022         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2023         (WebTestRunner::TestInterfaces::themeEngine):
2024         (WebTestRunner):
2025         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2026         (WebKit):
2027         (TestInterfaces):
2028         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2029         (WebTestRunner::WebTestInterfaces::themeEngine):
2030         (WebTestRunner):
2031         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2032         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2033         (WebTestRunner):
2034         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2035         (WebTestRunner::WebTestThemeControlWin::box):
2036         (WebTestRunner::WebTestThemeControlWin::line):
2037         (WebTestRunner::WebTestThemeControlWin::triangle):
2038         (WebTestRunner::WebTestThemeControlWin::roundRect):
2039         (WebTestRunner::WebTestThemeControlWin::oval):
2040         (WebTestRunner::WebTestThemeControlWin::circle):
2041         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2042         (WebTestRunner::WebTestThemeControlWin::markState):
2043         (WebTestRunner::WebTestThemeControlWin::draw):
2044         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2045         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2046         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2047         (WebTestRunner):
2048         (WebTestThemeControlWin):
2049         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2050         (WebTestRunner):
2051         (WebTestThemeEngineMac):
2052         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2053         (+[FakeActiveWindow alwaysActiveWindow]):
2054         (+[FakeActiveWindow alwaysInactiveWindow]):
2055         (-[FakeActiveWindow initWithActiveControls:]):
2056         (-[FakeActiveWindow _hasActiveControls]):
2057         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2058         (WebTestRunner):
2059         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2060         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2061         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2062         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2063         (WebTestRunner):
2064         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2065         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2066         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2067         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2068         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2069         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2070         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2071         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2072         (WebTestRunner::WebTestThemeEngineWin::getSize):
2073         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2074         (WebTestRunner):
2075         (WebTestThemeEngineWin):
2076         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2077         * DumpRenderTree/chromium/TestShell.cpp:
2078         (TestShell::initialize):
2079         * DumpRenderTree/chromium/TestShell.h:
2080         (WebKit):
2081         * DumpRenderTree/chromium/TestShellMac.mm:
2082         (platformInit):
2083         * DumpRenderTree/chromium/TestShellWin.cpp:
2084         (platformInit):
2085         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2086
2087 2013-03-19  Tony Chang  <tony@chromium.org>
2088
2089         Move testRunner.setTouchDragDropEnabled to internals.settings
2090         https://bugs.webkit.org/show_bug.cgi?id=112739
2091
2092         Reviewed by Adam Barth.
2093
2094         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2095         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2096         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2097         (TestRunner): Remove unnecessary code.
2098         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2099         (WebTestRunner::WebPreferences::reset):
2100         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2101
2102 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2103
2104         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2105         https://bugs.webkit.org/show_bug.cgi?id=112754
2106
2107         Reviewed by Darin Fisher.
2108
2109         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2110         now that it's always defined.
2111
2112         * DumpRenderTree/chromium/WebViewHost.cpp:
2113         * DumpRenderTree/chromium/WebViewHost.h:
2114         (WebViewHost):
2115
2116 2013-03-19  Kenneth Russell  <kbr@google.com>
2117
2118         Unreviewed, rolling out r146290.
2119         http://trac.webkit.org/changeset/146290
2120         https://bugs.webkit.org/show_bug.cgi?id=112751
2121
2122         Broke Chromium Mac build.
2123
2124         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2125         * DumpRenderTree/DumpRenderTree.gypi:
2126         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2127         (WebKit):
2128         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2129         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2130         (TestInterfaces):
2131         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2132         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2133         * DumpRenderTree/chromium/TestShell.cpp:
2134         (TestShell::initialize):
2135         * DumpRenderTree/chromium/TestShell.h:
2136         (WebKit):
2137         * DumpRenderTree/chromium/TestShellMac.mm:
2138         (platformInit):
2139         * DumpRenderTree/chromium/TestShellWin.cpp:
2140         (platformInit):
2141         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2142         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2143         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2144         (WebThemeControlDRTWin::box):
2145         (WebThemeControlDRTWin::line):
2146         (WebThemeControlDRTWin::triangle):
2147         (WebThemeControlDRTWin::roundRect):
2148         (WebThemeControlDRTWin::oval):
2149         (WebThemeControlDRTWin::circle):
2150         (WebThemeControlDRTWin::nestedBoxes):
2151         (WebThemeControlDRTWin::markState):
2152         (WebThemeControlDRTWin::draw):
2153         (WebThemeControlDRTWin::drawTextField):
2154         (WebThemeControlDRTWin::drawProgressBar):
2155         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2156         (WebThemeControlDRTWin):
2157         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2158         (WebThemeEngineDRTMac):
2159         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2160         (+[FakeActiveWindow alwaysActiveWindow]):
2161         (+[FakeActiveWindow alwaysInactiveWindow]):
2162         (-[FakeActiveWindow initWithActiveControls:]):
2163         (-[FakeActiveWindow _hasActiveControls]):
2164         (WebThemeEngineDRTMac::paintScrollbarThumb):
2165         (stateToHIEnableState):
2166         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2167         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2168         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2169         (webRectToSkIRect):
2170         (drawControl):
2171         (drawTextField):
2172         (drawProgressBar):
2173         (WebThemeEngineDRTWin::paintButton):
2174         (WebThemeEngineDRTWin::paintMenuList):
2175         (WebThemeEngineDRTWin::paintScrollbarArrow):
2176         (WebThemeEngineDRTWin::paintScrollbarThumb):
2177         (WebThemeEngineDRTWin::paintScrollbarTrack):
2178         (WebThemeEngineDRTWin::paintSpinButton):
2179         (WebThemeEngineDRTWin::paintTextField):
2180         (WebThemeEngineDRTWin::paintTrackbar):
2181         (WebThemeEngineDRTWin::paintProgressBar):
2182         (WebThemeEngineDRTWin::getSize):
2183         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2184         (WebThemeEngineDRTWin):
2185         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2186
2187 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2188
2189         [EFL] canvas-fallback-content.html is failing
2190         https://bugs.webkit.org/show_bug.cgi?id=111998
2191
2192         Reviewed by Chris Fleizach.
2193
2194         Adds support for getting platform name.
2195
2196         * DumpRenderTree/TestRunner.cpp:
2197         (TestRunner::staticValues):
2198         * DumpRenderTree/TestRunner.h:
2199         (TestRunner):
2200         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2201         (TestRunner::platformName):
2202
2203 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2204
2205         [chromium] move WebThemeEngine implementations to TestRunner library
2206         https://bugs.webkit.org/show_bug.cgi?id=112751
2207
2208         Reviewed by Adam Barth.
2209
2210         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2211         * DumpRenderTree/DumpRenderTree.gypi:
2212         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2213         (WebKit):
2214         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2215         (WebTestRunner::TestInterfaces::themeEngine):
2216         (WebTestRunner):
2217         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2218         (WebKit):
2219         (TestInterfaces):
2220         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2221         (WebTestRunner::WebTestInterfaces::themeEngine):
2222         (WebTestRunner):
2223         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2224         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2225         (WebTestRunner):
2226         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2227         (WebTestRunner::WebTestThemeControlWin::box):
2228         (WebTestRunner::WebTestThemeControlWin::line):
2229         (WebTestRunner::WebTestThemeControlWin::triangle):
2230         (WebTestRunner::WebTestThemeControlWin::roundRect):
2231         (WebTestRunner::WebTestThemeControlWin::oval):
2232         (WebTestRunner::WebTestThemeControlWin::circle):
2233         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2234         (WebTestRunner::WebTestThemeControlWin::markState):
2235         (WebTestRunner::WebTestThemeControlWin::draw):
2236         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2237         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2238         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2239         (WebTestRunner):
2240         (WebTestThemeControlWin):
2241         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2242         (WebTestRunner):
2243         (WebTestThemeEngineMac):
2244         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2245         (+[FakeActiveWindow alwaysActiveWindow]):
2246         (+[FakeActiveWindow alwaysInactiveWindow]):
2247         (-[FakeActiveWindow initWithActiveControls:]):
2248         (-[FakeActiveWindow _hasActiveControls]):
2249         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2250         (WebTestRunner):
2251         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2252         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2253         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2254         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2255         (WebTestRunner):
2256         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2257         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2258         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2259         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2260         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2261         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2262         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2263         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2264         (WebTestRunner::WebTestThemeEngineWin::getSize):
2265         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2266         (WebTestRunner):
2267         (WebTestThemeEngineWin):
2268         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2269         * DumpRenderTree/chromium/TestShell.cpp:
2270         (TestShell::initialize):
2271         * DumpRenderTree/chromium/TestShell.h:
2272         (WebKit):
2273         * DumpRenderTree/chromium/TestShellMac.mm:
2274         (platformInit):
2275         * DumpRenderTree/chromium/TestShellWin.cpp:
2276         (platformInit):
2277         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2278
2279 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2280
2281         [EFL][WK2] Separate WebView further from EwkView
2282         https://bugs.webkit.org/show_bug.cgi?id=111591
2283
2284         Reviewed by Caio Marcelo de Oliveira Filho.
2285
2286         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2287         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2288         since we can afford it having EWKViewGetWKView() private API to access WKView.
2289
2290         * TestWebKitAPI/PlatformWebView.h:
2291         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2292         (TestWebKitAPI::TEST):
2293         * TestWebKitAPI/efl/PlatformWebView.cpp:
2294         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2295         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2296         (TestWebKitAPI::PlatformWebView::resizeTo):
2297         (TestWebKitAPI::PlatformWebView::page):
2298         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2299         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2300         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2301         * WebKitTestRunner/PlatformWebView.h:
2302         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2303         (WTR::EventSenderProxy::dispatchEvent):
2304         (WTR::EventSenderProxy::keyDown):
2305         (WTR::EventSenderProxy::sendTouchEvent):
2306         (WTR::EventSenderProxy::setTouchModifier):
2307         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2308         (WTR::PlatformWebView::PlatformWebView):
2309         (WTR::PlatformWebView::~PlatformWebView):
2310         (WTR::PlatformWebView::resizeTo):
2311         (WTR::PlatformWebView::page):
2312         (WTR::PlatformWebView::focus):
2313         (WTR::PlatformWebView::windowSnapshotImage):
2314
2315 2013-03-19  Roger Fong  <roger_fong@apple.com>
2316
2317         Changes to VS2010 project files should only trigger builds on Windows bots.
2318         https://bugs.webkit.org/show_bug.cgi?id=112731
2319
2320         Reviewed by Timothy Horton.
2321
2322         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2323         (_should_file_trigger_build):
2324
2325 2013-03-19  Roger Fong  <roger_fong@apple.com>
2326
2327         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2328
2329         * Scripts/webkitpy/tool/steps/runtests.py:
2330         (RunTests.run):
2331         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2332         (RunTestsTest.test_webkit_run_unit_tests):
2333
2334 2013-03-19  Julie Parent  <jparent@chromium.org>
2335
2336         Dashboards: Introduce history namespace and unit tests.
2337         https://bugs.webkit.org/show_bug.cgi?id=112645
2338
2339         Reviewed by Ojan Vafai.
2340         
2341         Laying the framework for introducing the new history object and
2342         namespace.  This moves only static functions into the history
2343         namespace, and moves corresponding unit tests into seperate
2344         unit test file.
2345
2346         * TestResultServer/static-dashboards/aggregate_results.html:
2347         * TestResultServer/static-dashboards/dashboard_base.js:
2348         (parseCrossDashboardParameters):
2349         (parseDashboardSpecificParameters):
2350         (parseParameters):
2351         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2352         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2353         (.switch.return):
2354         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2355         * TestResultServer/static-dashboards/history.js: Added.
2356         * TestResultServer/static-dashboards/history_unittests.js: Added.
2357         * TestResultServer/static-dashboards/loader.js:
2358         (.):
2359         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2360         * TestResultServer/static-dashboards/run-unittests.html:
2361         * TestResultServer/static-dashboards/timeline_explorer.html:
2362         * TestResultServer/static-dashboards/timeline_explorer.js:
2363         * TestResultServer/static-dashboards/treemap.html:
2364         * TestResultServer/static-dashboards/treemap.js:
2365         (.switch.return):
2366         * TestResultServer/static-dashboards/ui.js:
2367
2368 2013-03-19  Daniel Bates  <dbates@webkit.org>
2369
2370         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2371         https://bugs.webkit.org/show_bug.cgi?id=112732
2372
2373         Reviewed by Eric Seidel.
2374
2375         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2376         of an existing file cannot be applied.
2377
2378         In particular, svn-{apply, unapply} compensate for differences in line endings
2379         by converting the line endings in a diff to match the line endings in the target
2380         file. The diff(1) command precedes the last line of a diff that adds a newline
2381         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2382         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2383         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2384         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2385         the newline characters in this special character sequence to match the line endings
2386         in the target file.
2387
2388         * Scripts/VCSUtils.pm:
2389         (parseDiff):
2390         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2391         Added tests:
2392             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2393             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2394             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2395             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2396         (escapeNewLineCharacters): Added.
2397         (toMacLineEndings): Added.
2398
2399 2013-03-19  James Robinson  <jamesr@chromium.org>
2400
2401         [chromium] Remove compositor settings that don't go through WebKit
2402         https://bugs.webkit.org/show_bug.cgi?id=112718
2403
2404         Reviewed by Adam Barth.
2405
2406         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2407         (main):
2408         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2409         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2410         (WebTestRunner::WebPreferences::reset):
2411         (WebTestRunner::WebPreferences::applyTo):
2412         * DumpRenderTree/chromium/TestShell.cpp:
2413         (TestShell::TestShell):
2414         (TestShell::resetWebSettings):
2415         * DumpRenderTree/chromium/TestShell.h:
2416         (TestShell):
2417
2418 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2419
2420         Unreviewed, rolling out r146101.
2421         https://bugs.webkit.org/show_bug.cgi?id=111884
2422
2423         re-enable custom freetype on asan; this needs to be on
2424         now that the bot is running lucid.
2425
2426         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2427
2428 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2429
2430         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2431         https://bugs.webkit.org/show_bug.cgi?id=112365
2432
2433         Reviewed by Benjamin Poulain.
2434
2435         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2436         harcoding it in wtf/Platform.h
2437
2438         * Scripts/webkitperl/FeatureList.pm:
2439
2440 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2441
2442         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2443         https://bugs.webkit.org/show_bug.cgi?id=94782
2444
2445         Based on patch by Csaba Osztrogonác.
2446         Reviewed by Jocelyn Turcotte.
2447
2448         The diff image is generated with bright red indicating errors, but letting the base image
2449         shine through so the context of the error-pixel can be identified.
2450
2451         * DumpRenderTree/qt/ImageDiff.cpp:
2452         (main):
2453
2454 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2455
2456         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2457
2458         Rubber-stamped by Csaba Osztrogonác.
2459
2460         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2461         since the latter might not cover the former.
2462
2463         * QtTestBrowser/launcherwindow.cpp:
2464         (LauncherWindow::print):
2465
2466 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2467
2468         Style tweeks to default.css.
2469         
2470         Rubber-stamped by David Kilzer.
2471         
2472         Give visited links a different color to other links, so you can
2473         see which builds you've viewed.
2474         
2475         Make the <small> text less tiny.
2476
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2478         (small):
2479         (a:link,a:visited,a:active):
2480         (a:visited):
2481
2482 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2483
2484         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2485         https://bugs.webkit.org/show_bug.cgi?id=112494
2486
2487         Reviewed by Dirk Pranke.
2488
2489         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2490         Also merged two pairs of methods to cleanup the code.
2491
2492         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2493         (PerfTestsRunner.run): Merged _upload_and_show_results.
2494         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2495
2496 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2497
2498         [chromium] build xdisplaycheck when building DRT
2499         https://bugs.webkit.org/show_bug.cgi?id=112636
2500
2501         Reviewed by Tony Chang.
2502
2503         It appears that we need xdisplaycheck to be built in order for
2504         Xvfb to be started correctly on the bots, and DRT was missing
2505         a dependency on it. This may be the cause of the ASAN bot not
2506         starting up properly (it only builds DRT).
2507
2508         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2509
2510 2013-03-18  David Levin  <levin@chromium.org>
2511
2512         Implement icon change notification dump for Chromium's test shell.
2513         https://bugs.webkit.org/show_bug.cgi?id=112614
2514
2515         This was previously implemented for some other platforms in r58111
2516         and r116547.
2517
2518         In r122806, fast/dom/icon-url-property.html stopped using it, but
2519         it is useful for tests, so I plan to re-add it to that test again.
2520
2521         Reviewed by Jochen Eisinger.
2522
2523         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2524         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2525          icon change notifications from WebKit may be logged in test output.
2526         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2527         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2528         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2529         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2530         (WebTestRunner):
2531         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2532         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2533         (TestRunner):
2534         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2535         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2536         (WebTestRunner):
2537         * DumpRenderTree/chromium/WebViewHost.cpp:
2538         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2539         * DumpRenderTree/chromium/WebViewHost.h:
2540         (WebViewHost):
2541
2542 2013-03-18  Julie Parent  <jparent@chromium.org>
2543
2544         Cleanup: Move js for treemap and aggregate_results into own js files.
2545         https://bugs.webkit.org/show_bug.cgi?id=112618
2546
2547         Reviewed by Dirk Pranke.
2548         
2549         No functional changes, just moving the code into separate js file
2550         rather than inlined in the html, so we can test it, make it more
2551         modular, etc.  Other dashboard types are already done this way.
2552
2553         * TestResultServer/static-dashboards/aggregate_results.html:
2554         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2555         (generatePage):
2556         (handleValidHashParameter):
2557         (htmlForBuilder):
2558         (rawValuesHTML):
2559         (chartHTML):
2560         (filteredValues):
2561         (chart):
2562         (htmlForRevisionRows):
2563         (wrapHTMLInTable):
2564         (htmlForSummaryTable):
2565         (valuesPerExpectation):
2566         (htmlForTestType):
2567         (htmlForTableRow):
2568         (extendedEncode):
2569         * TestResultServer/static-dashboards/treemap.html:
2570         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2571         (humanReadableTime):
2572         (convertToWebTreemapFormat):
2573         (reverseSortByAverage):
2574         (generatePage):
2575         (focusPath):
2576         (.switch.return):
2577         (handleQueryParameterChange):
2578         (extractName):
2579         (fullName):
2580         (handleFocus.):
2581         (handleFocus):
2582
2583 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2584
2585         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2586         https://bugs.webkit.org/show_bug.cgi?id=112622
2587
2588         Reviewed by Dirk Pranke.
2589
2590         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2591         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2592
2593 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2594
2595         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2596         https://bugs.webkit.org/show_bug.cgi?id=112619
2597
2598         Reviewed by Dirk Pranke.
2599
2600         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2601         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2602
2603         * Scripts/webkitpy/layout_tests/port/gtk.py:
2604         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2605         Port._webkit_baseline_path method.
2606         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2607         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2608         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2609         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2610         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2611         that are expected based on the builder name.
2612
2613 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2614
2615         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2616         https://bugs.webkit.org/show_bug.cgi?id=112571
2617
2618         Reviewed by Adam Barth.
2619
2620         Update function declarations for new WebFileSystemType enum. (All
2621         changes are behind an #ifdef so we can sync required changes in embedders.)
2622
2623         * DumpRenderTree/chromium/WebViewHost.cpp:
2624         (WebViewHost::openFileSystem):
2625         (WebViewHost::deleteFileSystem):
2626         * DumpRenderTree/chromium/WebViewHost.h:
2627         (WebViewHost):
2628
2629 2013-03-18  Julie Parent  <jparent@chromium.org>
2630
2631         Cleanup: Move timeline_exporer js out of html file into js.
2632         https://bugs.webkit.org/show_bug.cgi?id=112188
2633
2634         Reviewed by Dirk Pranke.
2635         
2636         Moves the javascript out of the html file and into a new js file.
2637         This follows the format of flakiness_dashboard.{html|js}.
2638         
2639         Also moves code from dashboard_base that is used only by this one
2640         dashboard, and makes it private to the dashboard.
2641
2642         * TestResultServer/static-dashboards/dashboard_base.js:
2643         * TestResultServer/static-dashboards/timeline_explorer.html:
2644         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2645         (generatePage):
2646         (initCurrentBuilderTestResults):
2647         (shouldShowWebKitRevisionsOnly):
2648         (updateTimelineForBuilder.):
2649         (updateTimelineForBuilder):
2650         (selectBuild):
2651         (updateBuildIndicator):
2652         (.addRow):
2653         (.addNumberRow):
2654         (.inspectorNode.getElementsByTagName.0.onclick):
2655         (.inspectorNode.getElementsByTagName.1.onclick):
2656         (.inspectorNode.getElementsByTagName.2.onclick):
2657         (updateBuildInspector):
2658         (showResultsDelta):
2659         (decompressResults.addFlakyDelta):
2660         (decompressResults):
2661
2662 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2663
2664         Unreviewed, rolling out r145272.
2665         http://trac.webkit.org/changeset/145272
2666         https://bugs.webkit.org/show_bug.cgi?id=111884
2667
2668         Turns out the ASAN build is still broken; possibly there's
2669         something still setting LD_LIBRARY_PATH, or possibly there's
2670         something else wrong. In the meantime, we need it to work again.
2671
2672         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2673
2674 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2675
2676         delete-stale-build-files is too aggressive
2677         https://bugs.webkit.org/show_bug.cgi?id=112595
2678
2679         Reviewed by Tim Horton.
2680
2681         It appears that whitelisting file extensions to keep is not a good idea.
2682         Blacklist files to delete instead, and only delete .o files for now.
2683         We can add more file extensions as needed.
2684
2685         * BuildSlaveSupport/delete-stale-build-files:
2686
2687 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2688
2689         Disable accessibility notifications after each test
2690         https://bugs.webkit.org/show_bug.cgi?id=112579
2691
2692         Reviewed by Tim Horton.
2693         
2694         In WebKitTestRunner, if any tests triggered accessibility notifications,
2695         the global notification handler would thereafter be active, and fire
2696         notifications for all subsequent tests.
2697         
2698         Fix by implementing AccessibilityController::resetToConsistentState() for
2699         Mac, and using it to clear the global notification handler.
2700
2701         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2702         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2703         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2704         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2705         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2706         (e.g. because of -autorelease).
2707         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2708         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2709         if there is one.
2710         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2711         Add -stopObserving
2712         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2713         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2714         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2715         center.
2716
2717 2013-03-18  Dana Jansens  <danakj@chromium.org>
2718
2719         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2720         https://bugs.webkit.org/show_bug.cgi?id=112392
2721
2722         Reviewed by James Robinson.
2723
2724         Removes the command line flag option from DRT.
2725
2726         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2727         (main):
2728
2729 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2730
2731         [GTK] plugins/plugin-clip-subframe.html is failing
2732         https://bugs.webkit.org/show_bug.cgi?id=112570
2733
2734         Reviewed by Martin Robinson.
2735
2736         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2737
2738 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2739
2740         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2741         https://bugs.webkit.org/show_bug.cgi?id=112442
2742
2743         Reviewed by Gustavo Noronha Silva.
2744
2745         * GtkLauncher/main.c:
2746         (reloadCb):
2747         (createToolbar):
2748         (createWindow):
2749
2750 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2751
2752         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2753         https://bugs.webkit.org/show_bug.cgi?id=112205
2754
2755         Disable this API test until Geoff can fix it.
2756
2757         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2758         (TestWebKitAPI::TEST):
2759
2760 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2761
2762         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2763         https://bugs.webkit.org/show_bug.cgi?id=112478
2764
2765         Reviewed by Tony Chang.
2766
2767         There is nothing that ensures that the log messages from the plugin
2768         come in before the layout test finished loading.
2769
2770         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2771         (PassDifferentNPPStruct::NPP_SetWindow):
2772         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2773         (NPP_SetWindow):
2774
2775 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2776
2777         Have the mac port support per_test_timeout in webkitpy
2778         https://bugs.webkit.org/show_bug.cgi?id=112466
2779
2780         Reviewed by Dirk Pranke.
2781         
2782         Both WTR and DRT handle --timeout arguments, so we can
2783         have the scripts pass the timeout values down to the tools.
2784
2785         * Scripts/webkitpy/layout_tests/port/mac.py:
2786         (MacPort.supports_per_test_timeout):
2787
2788 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2789
2790         Remove setAsynchronousSpellCheckingEnabled from test runners
2791         https://bugs.webkit.org/show_bug.cgi?id=112362
2792
2793         Reviewed by Tony Chang.
2794
2795         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2796         in internals.settings, so all ports can share it.
2797
2798         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2799         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2800         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2801         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2802         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2803         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2804         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2805         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2806         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2807         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2808         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2809         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2810
2811 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2812
2813         Fix the stupid unit tests.
2814
2815         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2816         (test_sample_process):
2817
2818 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2819
2820         Collect samples for unresponsive web processes
2821         https://bugs.webkit.org/show_bug.cgi?id=112409
2822
2823         Reviewed by Tim Horton.
2824         
2825         When we detect that a subprocess was unresponsive, run the 'sample'
2826         tool on that process, for the Mac port.
2827         
2828         The sample will be linked to from the results.html page, next
2829         to the crash log link.
2830
2831         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2832         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2833         look for samples on disk.
2834         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2835         (TestResultWriter):
2836         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2837         -sample.txt files, and have it copy their contents to a new file
2838         next to the test that spawned them (as we do for crash logs).
2839         * Scripts/webkitpy/layout_tests/port/base.py:
2840         (Port.look_for_new_samples): Base class does nothing for sampling.
2841         * Scripts/webkitpy/layout_tests/port/driver.py:
2842         (Driver._check_for_driver_crash): Kick off a sample if we detected
2843         that the subprocess was unresponsive.
2844         * Scripts/webkitpy/layout_tests/port/mac.py:
2845         (MacPort.sample_file_path): Utility to generate the file path
2846         to the generated sample files at the top level of layout-test-results.
2847         (MacPort.look_for_new_crash_logs): Fix typo
2848         (MacPort.look_for_new_samples): New function to find sample files.
2849         (MacPort.sample_process): Use the utility function to get the file path.
2850
2851 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2852
2853         [Qt] Remove simple getters and setters from TestRunnerQt
2854         https://bugs.webkit.org/show_bug.cgi?id=112343
2855
2856         Reviewed by Benjamin Poulain.
2857
2858         The removed functions and boolean members
2859         are being replaced by the implementations in the
2860         generic TestRunner.h.
2861
2862         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2863         (DumpRenderTree::dumpFrameScrollPosition):
2864         (DumpRenderTree::dumpFramesAsText):
2865         (DumpRenderTree::dump):
2866         (DumpRenderTree::titleChanged):
2867         (DumpRenderTree::dumpDatabaseQuota):
2868         (DumpRenderTree::dumpApplicationCacheQuota):
2869         (DumpRenderTree::statusBarMessage):
2870         (DumpRenderTree::createWindow):
2871         * DumpRenderTree/qt/TestRunnerQt.cpp:
2872         (TestRunnerQt::reset):
2873         * DumpRenderTree/qt/TestRunnerQt.h:
2874         (TestRunnerQt):
2875
2876 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2877
2878         Update the link on build.webkit.org to refer to perf.webkit.org
2879         https://bugs.webkit.org/show_bug.cgi?id=112416
2880
2881         Reviewed by Philip Rogers.
2882
2883         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2884
2885         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2886
2887 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2888
2889         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2890         https://bugs.webkit.org/show_bug.cgi?id=112394
2891
2892         Reviewed by Philippe Normand.
2893
2894         * GtkLauncher/main.c:
2895         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2896
2897 2013-03-14  Andreas Kling  <akling@apple.com>
2898
2899         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2900         <http://webkit.org/b/111815>
2901         <rdar://problem/13380145>
2902
2903         Reviewed by Anders Carlsson.
2904
2905         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2906         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2907         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2908
2909         * WebKitTestRunner/PlatformWebView.h:
2910         (PlatformWebView):
2911         * WebKitTestRunner/TestController.cpp:
2912         (WTR::TestController::createOtherPage):
2913         (WTR::TestController::createWebViewWithOptions):
2914         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2915         (WTR::PlatformWebView::didInitializeClients):
2916
2917 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2918
2919         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2920         https://bugs.webkit.org/show_bug.cgi?id=112122
2921
2922         Reviewed by Kenneth Rohde Christiansen.
2923
2924         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2925
2926         * MiniBrowser/efl/main.c:
2927         (_Browser_Window):
2928         (search_box_show):
2929         (search_box_hide):
2930         (on_key_down):
2931         (on_url_changed):
2932         (on_search_field_aborted):
2933         (on_search_field_activated):
2934         (on_search_field_clicked):
2935         (on_search_backward_button_clicked):
2936         (on_search_forward_button_clicked):
2937         (window_create):
2938
2939 2013-03-14  Julie Parent  <jparent@chromium.org>
2940
2941         Cleanup: Remove g_resourceLoader.
2942         https://bugs.webkit.org/show_bug.cgi?id=112305
2943
2944         Reviewed by Dirk Pranke.
2945         
2946         Removing another global.
2947         
2948         Now, each dashboard creates its own loader, rather than having
2949         a general global one.
2950         
2951         Remove usage of g_resourceLoader.isLoadingComplete from 
2952         handleLocationChange by ensuring that handleLocationChange is
2953         never called before the loader is done.  It was called in two
2954         places before: 1 was from the callback when the loader is done,
2955         so that was obviously true, and the other was from onhashchange,
2956         where it would just return rather than running.  Instead, lets
2957         only register the onhashchange handler once the loader is
2958         setup, so the check is no longer necessary.
2959         
2960         Remove isLoadingComplete since it is now unused.
2961         
2962         Callback for loader is now initializeHistory, rather than just
2963         handleLocationChange which will set up the hashchange handler now.
2964         This will all eventually be moving to a new History object.
2965
2966         * TestResultServer/static-dashboards/aggregate_results.html:
2967         * TestResultServer/static-dashboards/dashboard_base.js:
2968         (handleLocationChange):
2969         (intializeHistory):
2970         (decompressResults):
2971         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2972         (generatePage):
2973         * TestResultServer/static-dashboards/loader.js:
2974         (.):
2975         * TestResultServer/static-dashboards/loader_unittests.js:
2976         * TestResultServer/static-dashboards/timeline_explorer.html:
2977         * TestResultServer/static-dashboards/treemap.html:
2978
2979 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2980
2981         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2982         https://bugs.webkit.org/show_bug.cgi?id=109404
2983
2984         Reviewed by Tony Chang.
2985
2986         Removes all the code related to smartInsertDeleteEnabled and
2987         selectTrailingWhitespaceEnabled settings as they will be managed from
2988         internals from now on.
2989
2990         * DumpRenderTree/TestRunner.cpp:
2991         (TestRunner::staticFunctions):
2992         * DumpRenderTree/TestRunner.h:
2993         (TestRunner):
2994         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2995         (WebKit):
2996         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2997         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2998         (DumpRenderTree):
2999         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3000         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3001         (WebTestRunner::WebTestProxy::didStopLoading):
3002         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3003         (WebTestRunner::TestRunner::TestRunner):
3004         (WebTestRunner::TestRunner::reset):
3005         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3006         (TestRunner):
3007         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3008         (WebTestRunner::WebPreferences::applyTo): Set default values for
3009         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3010         Chromium DRT default values are different from Chromium browser.
3011         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3012         * DumpRenderTree/chromium/WebViewHost.cpp:
3013         * DumpRenderTree/chromium/WebViewHost.h:
3014         (WebViewHost):
3015         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3016         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3017         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3018         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3019         (resetDefaultsToConsistentValues):
3020         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3021         * DumpRenderTree/mac/DumpRenderTree.mm:
3022         (resetWebViewToConsistentStateBeforeTesting):
3023         * DumpRenderTree/mac/TestRunnerMac.mm:
3024         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3025         (WebCore::WebPage::resetSettings):
3026         * DumpRenderTree/qt/TestRunnerQt.cpp:
3027         * DumpRenderTree/qt/TestRunnerQt.h:
3028         (TestRunnerQt):
3029         * DumpRenderTree/win/DumpRenderTree.cpp:
3030         (resetWebViewToConsistentStateBeforeTesting):
3031         * DumpRenderTree/win/TestRunnerWin.cpp:
3032         * DumpRenderTree/wx/TestRunnerWx.cpp:
3033
3034 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3035
3036         [Qt] Disable DRT on Windows
3037
3038         Reviewed by Jocelyn Turcotte.
3039
3040         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3041
3042         * qmake/mkspecs/features/configure.prf:
3043
3044 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3045
3046         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3047         https://bugs.webkit.org/show_bug.cgi?id=110728
3048
3049         Reviewed by Gyuyoung Kim.
3050
3051         Use the page group to create the view object.
3052
3053         * MiniBrowser/efl/main.c:
3054         (window_create):
3055
3056 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3057
3058         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3059
3060         Reviewed by Tor Arne Vestbø.
3061
3062         The mock versions of these web facing features should be instantiated when
3063         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3064         such as QtLocation are actually needed.
3065
3066         This patch decouples enabling device orientation/motion and geolocation from
3067         the underlying Qt modules and makes them available in developer builds
3068         (!production_build) and backed by mock backends when running in drt.
3069
3070         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3071         developers the web facing features are always enabled (although requests will
3072         time out) and the mock backends are enabled inside DRT, allowing for the layout
3073         tests to run with less dependencies.
3074
3075         In addition this also enables the mock device motion client, which was
3076         previously never instantiated.
3077
3078         * qmake/mkspecs/features/features.prf:
3079
3080 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3081
3082         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3083         https://bugs.webkit.org/show_bug.cgi?id=112340
3084
3085         Reviewed by Simon Hausmann.
3086
3087         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3088         (DumpRenderTree::dump):
3089             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3090         (DumpRenderTree::dumpApplicationCacheQuota):
3091         * DumpRenderTree/qt/TestRunnerQt.cpp:
3092         (TestRunnerQt::reset):
3093         * DumpRenderTree/qt/TestRunnerQt.h:
3094         (TestRunnerQt):
3095
3096 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3097
3098         [Qt] Port DRT to use TestRunner::dumpAsText()
3099         https://bugs.webkit.org/show_bug.cgi?id=112260
3100
3101         Reviewed by Benjamin Poulain.
3102
3103         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3104         (WebCore::DumpRenderTree::open):
3105         (WebCore::methodNameStringForFailedTest):
3106             Change parameter from type TestRunnerQt* to TestRunner*.
3107         (WebCore::DumpRenderTree::dump):
3108             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3109             Instead we should rely on TestRunner::generatePixelResults().
3110         * DumpRenderTree/qt/TestRunnerQt.cpp:
3111         (TestRunnerQt::reset):
3112         * DumpRenderTree/qt/TestRunnerQt.h:
3113         (TestRunnerQt):
3114
3115 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3116
3117         Implement FontLoader interface
3118         https://bugs.webkit.org/show_bug.cgi?id=98395
3119
3120         Reviewed by Eric Seidel.
3121
3122         Enable FontLoadEvents runtime flag for TestShell.
3123
3124         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3125         (WebTestRunner::TestInterfaces::TestInterfaces):
3126
3127 2013-03-13  Julie Parent  <jparent@chromium.org>
3128
3129         CLeanup: remove unnecessary call to parseParameters.
3130         https://bugs.webkit.org/show_bug.cgi?id=112309
3131
3132         Reviewed by Ojan Vafai.
3133         
3134         We call parseCrossDashboardParameters when the dashboard initially
3135         loads to set the state required for loadBuildersList, and then we
3136         call it again once we are fully done with loading, so there is no
3137         reason to call it in the middle of the loading process here.
3138
3139         * TestResultServer/static-dashboards/loader.js:
3140         (.):
3141
3142 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3143
3144         Unreviewed. Now I'm a reviewer :)
3145
3146         * Scripts/webkitpy/common/config/committers.py:
3147
3148 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3149
3150         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3151         https://bugs.webkit.org/show_bug.cgi?id=112277
3152
3153         Reviewed by Adam Barth.
3154
3155         * Scripts/webkitperl/FeatureList.pm:
3156         * qmake/mkspecs/features/features.pri:
3157
3158 2013-03-13  Adam Barth  <abarth@webkit.org>
3159
3160         run-perf-tests should support content_shell
3161         https://bugs.webkit.org/show_bug.cgi?id=112291
3162
3163         Reviewed by Eric Seidel.
3164
3165         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3166         (PerfTestsRunner._parse_args):
3167
3168 2013-03-13  Oliver Hunt  <oliver@apple.com>
3169
3170         Simplify Checked<> multiplication
3171         https://bugs.webkit.org/show_bug.cgi?id=112286
3172
3173         Reviewed by James Robinson.
3174
3175         Add tests for multiplication by zero and max to ensure we don't
3176         mess them up should we ever make changes to Checked<> in future.
3177
3178         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3179         (TestWebKitAPI):
3180
3181 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3182
3183         [Qt] Unreviewed prospective Windows build fix
3184
3185         Do the usual thing, include the moc generated code in the .cpp file instead
3186         of compiling it standalone, to ensure that config.h is included, too, and
3187         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3188
3189         * DumpRenderTree/qt/EventSenderQt.cpp:
3190
3191 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3192
3193         [Qt] Port TestRunner::findString to shared interface
3194         https://bugs.webkit.org/show_bug.cgi?id=112147
3195
3196         Reviewed by Jocelyn Turcotte.
3197
3198         This patch also removes DumpRenderTree and some other helper classes from
3199         the WebCore namespace, to which they do not really belong.
3200
3201         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3202         (main):
3203         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3204         (DumpRenderTree::DumpRenderTree):
3205         (DumpRenderTree::~DumpRenderTree):
3206         (DumpRenderTree::instance):
3207         (DumpRenderTree::setShouldTimeout):
3208         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3209         (DumpRenderTree):
3210         * DumpRenderTree/qt/EventSenderQt.cpp:
3211         (EventSender::contextClick):
3212         (EventSender::sendEvent):
3213         (EventSender::postEvent):
3214         * DumpRenderTree/qt/EventSenderQt.h:
3215         (EventSender::isGraphicsBased):
3216         * DumpRenderTree/qt/TestRunnerQt.cpp:
3217         (TestRunnerQt::TestRunnerQt):
3218         (TestRunner::findString):
3219         (TestRunnerQt::setMockDeviceOrientation):
3220         (TestRunnerQt::setGeolocationPermission):
3221         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3222         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3223         (TestRunnerQt::setMockGeolocationPosition):
3224         * DumpRenderTree/qt/TestRunnerQt.h:
3225         (TestRunnerQt):
3226
3227 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3228
3229         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3230         https://bugs.webkit.org/show_bug.cgi?id=112129
3231
3232         Reviewed by Adam Barth.
3233
3234         Following Chromium
3235         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3236         this is being renamed to better explain what it does.
3237
3238         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3239
3240 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3241
3242         [Qt] Unreviewed trivial typo fix
3243
3244         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3245         TextRunner.h. Thanks Zeno :)
3246
3247 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3248
3249         [Qt] Prepare DRT for transition to shared TestRunner interface
3250         https://bugs.webkit.org/show_bug.cgi?id=112144
3251
3252         Reviewed by Benjamin Poulain.
3253
3254         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3255         the JSC C API based one.
3256
3257         This is impplemented by instantiating the QObject based testRunner in
3258         the global object, then instantiating the JSC C based TestRunner
3259         separately and placing it "behind" the QObject based testRunner through
3260         injection of the individual functions through proxies. (prototype
3261         chaining doesn't work due to the this object and Function.prototype.bind
3262         doesn't work due to the native function)
3263
3264         This allows for porting over method by method by removing the method
3265         from the QObject TestRunnerQt and implementing it in the JSC C based
3266         TestRunner.
3267
3268         In order for this to link and run dummy implementations of all the
3269         necessary TestRunner functions are provided.
3270
3271         * DumpRenderTree/qt/DumpRenderTree.pro:
3272         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3273         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3274         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3275         (WebCore::DumpRenderTree::initJSObjects):
3276         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3277         (DumpRenderTree):
3278         * DumpRenderTree/qt/TestRunnerQt.cpp:
3279         (TestRunner::~TestRunner):
3280         (TestRunner::addDisallowedURL):
3281         (TestRunner::queueLoad):
3282         (TestRunner::removeAllVisitedLinks):
3283         (TestRunner::setAcceptsEditing):
3284         (TestRunner::simulateLegacyWebNotificationClick):
3285         (TestRunner::setWindowIsKey):
3286         (TestRunner::setAlwaysAcceptCookies):
3287         (TestRunner::addOriginAccessWhitelistEntry):
3288         (TestRunner::setWebViewEditable):
3289         (TestRunner::clearAllApplicationCaches):
3290         (TestRunner::setTextDirection):
3291         (TestRunner::notifyDone):
3292         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3293         (TestRunner::overridePreference):
3294         (TestRunner::pathToLocalResource):
3295         (TestRunner::removeAllWebNotificationPermissions):
3296         (TestRunner::simulateWebNotificationClick):
3297         (TestRunner::closeIdleLocalStorageDatabases):
3298         (TestRunner::focusWebView):
3299         (TestRunner::setBackingScaleFactor):
3300         (TestRunner::removeChromeInputField):
3301         (TestRunner::addChromeInputField):
3302         (TestRunner::originsWithLocalStorage):
3303         (TestRunner::deleteAllLocalStorage):
3304         (TestRunner::deleteLocalStorageForOrigin):
3305         (TestRunner::observeStorageTrackerNotifications):
3306         (TestRunner::syncLocalStorage):
3307         (TestRunner::windowCount):
3308         (TestRunner::setWaitToDump):
3309         (TestRunner::waitForPolicyDelegate):
3310         (TestRunner::webHistoryItemCount):
3311         (TestRunner::showWebInspector):
3312         (TestRunner::closeWebInspector):
3313         (TestRunner::evaluateInWebInspector):
3314         (TestRunner::setSerializeHTTPLoads):
3315         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3316         (TestRunner::setCustomPolicyDelegate):
3317         (TestRunner::setDatabaseQuota):
3318         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3319         (TestRunner::resetPageVisibility):
3320         (TestRunner::keepWebHistory):
3321         (TestRunner::goBack):
3322         (TestRunner::originsWithApplicationCache):
3323         (TestRunner::applicationCacheDiskUsageForOrigin):
3324         (TestRunner::display):
3325         (TestRunner::dispatchPendingLoadRequests):
3326         (TestRunner::clearPersistentUserStyleSheet):
3327         (TestRunner::callShouldCloseOnWebView):
3328         (TestRunner::copyDecodedHostName):
3329         (TestRunner::clearBackForwardList):
3330         (TestRunner::clearAllDatabases):
3331         (TestRunner::clearApplicationCacheForOrigin):
3332         (TestRunner::apiTestGoToCurrentBackForwardItem):
3333         (TestRunner::authenticateSession):
3334         (TestRunner::abortModal):
3335         (TestRunner::setStorageDatabaseIdleInterval):
3336         (TestRunner::setAsynchronousSpellCheckingEnabled):
3337         (TestRunner::setXSSAuditorEnabled):
3338         (TestRunner::setSpatialNavigationEnabled):
3339         (TestRunner::setScrollbarPolicy):
3340         (TestRunner::setJavaScriptCanAccessClipboard):
3341         (TestRunner::setAutomaticLinkDetectionEnabled):
3342         (TestRunner::setUserStyleSheetEnabled):
3343         (TestRunner::setUserStyleSheetLocation):
3344         (TestRunner::setUseDashboardCompatibilityMode):
3345         (TestRunner::setTabKeyCyclesThroughElements):
3346         (TestRunner::setSmartInsertDeleteEnabled):
3347         (TestRunner::setSelectTrailingWhitespaceEnabled):
3348         (TestRunner::setPrivateBrowsingEnabled):
3349         (TestRunner::setPluginsEnabled):
3350         (TestRunner::setPopupBlockingEnabled):
3351         (TestRunner::setMockSpeechInputDumpRect):
3352         (TestRunner::setPersistentUserStyleSheetLocation):
3353         (TestRunner::setMockGeolocationPosition):
3354         (TestRunner::setMockGeolocationPositionUnavailableError):
3355         (TestRunner::setMockDeviceOrientation):
3356         (TestRunner::setMainFrameIsFirstResponder):
3357         (TestRunner::setIconDatabaseEnabled):
3358         (TestRunner::setGeolocationPermission):
3359         (TestRunner::setDefersLoading):
3360         (TestRunner::setCacheModel):
3361         (TestRunner::setAuthorAndUserStylesEnabled):
3362         (TestRunner::setAllowFileAccessFromFileURLs):
3363         (TestRunner::setAppCacheMaximumSize):
3364         (TestRunner::setAllowUniversalAccessFromFileURLs):
3365         (TestRunner::setApplicationCacheOriginQuota):
3366         (TestRunner::denyWebNotificationPermission):
3367         (TestRunner::grantWebNotificationPermission):
3368         (TestRunner::setValueForUser):
3369         (TestRunner::setViewModeMediaFeature):
3370         (TestRunner::setPageVisibility):
3371         (TestRunner::addMockSpeechInputResult):
3372         (TestRunner::removeOriginAccessWhitelistEntry):
3373         (TestRunner::addUserScript):
3374         (TestRunner::isCommandEnabled):
3375         (TestRunner::evaluateScriptInIsolatedWorld):
3376         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3377         (TestRunner::copyEncodedHostName):
3378         (TestRunner::addUserStyleSheet):
3379         (TestRunner::findString):
3380         (TestRunner::execCommand):
3381         (TestRunner::localStorageDiskUsageForOrigin):
3382
3383 2013-03-12  Julie Parent  <jparent@chromium.org>
3384
3385         Cleanup: Move flatten-trie to loader.
3386         https://bugs.webkit.org/show_bug.cgi?id=112196
3387
3388         Reviewed by Dirk Pranke.
3389
3390         flatten-trie is used only by the loader, so move it there and make it
3391         private, rather than global in dashbaord_base. Moved the corresponding
3392         unit test from flakiness_dashboard_unittests to loader_unittests.
3393         
3394         * TestResultServer/static-dashboards/dashboard_base.js:
3395         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3396         * TestResultServer/static-dashboards/loader.js:
3397         (.):
3398         * TestResultServer/static-dashboards/loader_unittests.js:
3399
3400 2013-03-12  Oliver Hunt  <oliver@apple.com>
3401
3402         Unbreak api tests
3403
3404         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3405         (TestWebKitAPI):
3406
3407 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3408
3409         Unreviewed, disabling tests for Win EWS.
3410
3411         win-ews obviously cannot keep up with running tests, it's >300 behind.
3412         Probably doesn't help that its (likely) running tests serially.
3413
3414         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3415         (WinEWS):
3416
3417 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3418
3419         Add a --build-directory argument to delete-stale-build-files
3420         https://bugs.webkit.org/show_bug.cgi?id=112198
3421
3422         Reviewed by Ryosuke Niwa.
3423
3424         * BuildSlaveSupport/delete-stale-build-files:
3425         (main): Add --build-directory argument.
3426
3427 2013-03-12  Oliver Hunt  <oliver@apple.com>
3428
3429         Appease MSVC
3430
3431         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3432         (TestWebKitAPI):
3433
3434 2013-03-12  Oliver Hunt  <oliver@apple.com>
3435
3436         Add more Checked<> tests
3437         https://bugs.webkit.org/show_bug.cgi?id=112190
3438
3439         Reviewed by Geoffrey Garen.
3440
3441         Tests!
3442
3443         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3444         (TestWebKitAPI):
3445
3446 2013-03-12  Julie Parent  <jparent@chromium.org>
3447
3448         Cleanup: Move loading complete function into callback, rather than global.
3449         https://bugs.webkit.org/show_bug.cgi?id=112167
3450
3451         Reviewed by Dirk Pranke.
3452         
3453         Stop calling global functions, pass in proper handler to Loader
3454         constructor. Note that the callback is optional, as tests, and
3455         some potential dashboards, do not need one.
3456
3457         * TestResultServer/static-dashboards/dashboard_base.js:
3458         * TestResultServer/static-dashboards/loader.js:
3459         (.):
3460         * TestResultServer/static-dashboards/loader_unittests.js:
3461
3462 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3463
3464         [EFL][WK2] Add popup menu support to MiniBrowser
3465         https://bugs.webkit.org/show_bug.cgi?id=108934
3466
3467         Reviewed by Kenneth Rohde Christiansen.
3468
3469         Implement popup menu support in MiniBrowser by handling popup_menu_show
3470         and popup_menu_hide smart functions on the view and using the Ewk popup
3471         menu API.
3472
3473         * MiniBrowser/efl/main.c:
3474         (_Browser_Window):
3475         (on_popup_menu_discarded):
3476         (on_popup_menu_item_clicked):
3477         (popup_menu_populate):
3478         (on_popup_menu_show):
3479         (on_popup_menu_hide):
3480         (window_create): Use calloc() instead of malloc() to allocate memory for
3481         Browser_Window. This makes sure all the structs members are initialized
3482         to 0 (such as the new elm_popup_menu pointer).
3483
3484 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3485
3486         [GTK] Set up the libPlatformGtk.la library
3487         https://bugs.webkit.org/show_bug.cgi?id=111738
3488
3489         Reviewed by Martin Robinson.
3490
3491         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3492         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3493         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3494
3495 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3496
3497         [GTK] Enable Web Audio in development builds
3498         https://bugs.webkit.org/show_bug.cgi?id=111831
3499
3500         Reviewed by Philippe Normand.
3501
3502         Web Audio is already quite well supported on the GTK port but still has a few issues
3503         that must be addressed before it is enabled by default. Despite that it should be enabled
3504         in development builds just so we are up-to-date with future feature infrastructure changes.
3505         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3506         that's an obvious goal before enabling the feature in release builds.
3507
3508         * Scripts/webkitperl/FeatureList.pm:
3509
3510 2013-03-11  Andreas Kling  <akling@apple.com>
3511
3512         [Mac][WK1] Add support for alert() in MiniBrowser.
3513         <http://webkit.org/b/112090>
3514
3515         Reviewed by Anders Carlsson.
3516
3517         * MiniBrowser/mac/WK1BrowserWindowController.m:
3518         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3519
3520 2013-03-11  Julie Parent  <jparent@chromium.org>
3521
3522         Dashboard cleanup: Create ui.Errors
3523         https://bugs.webkit.org/show_bug.cgi?id=111785
3524
3525         Reviewed by Ojan Vafai.
3526         
3527         Create ui.Errors for handling errors the dashboards
3528         encounter. Loader now has a Error object that it can add to,
3529         and individual dashboards can show errors when desired.
3530         Currently, only flakiness_db shows errors, but this is 
3531         generic and there is no reason why other dbs wouldn't want to
3532         show errors.
3533
3534         * TestResultServer/static-dashboards/dashboard_base.js:
3535         (resourceLoadingComplete):
3536         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3537         (generatePage):
3538         * TestResultServer/static-dashboards/loader.js:
3539         (.):
3540         * TestResultServer/static-dashboards/ui.js:
3541         (.):
3542
3543 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3544
3545         Some StringHasher tests are broken because of missing null termination
3546         https://bugs.webkit.org/show_bug.cgi?id=111284
3547
3548         Reviewed by Darin Adler.
3549
3550         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3551         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3552         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3553         the bug caught by it is now fixed.
3554
3555 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3556
3557         Unreviewed, rolling out r145200.
3558         http://trac.webkit.org/changeset/145200
3559         https://bugs.webkit.org/show_bug.cgi?id=112063
3560
3561         Broke a couple of unit tests (Requested by zdobersek on
3562         #webkit).
3563
3564         * Scripts/webkitperl/FeatureList.pm:
3565
3566 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3567
3568         [GTK] WebKit2-only build fails
3569         https://bugs.webkit.org/show_bug.cgi?id=112033
3570
3571         Reviewed by Gustavo Noronha Silva.
3572
3573         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3574         generic part, WebKit1-specific part and WebKit2-specific part.
3575         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3576         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3577         directly.
3578
3579 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3580
3581         Adding myself to the committers list.
3582
3583         Unreviewed.
3584
3585         * Scripts/webkitpy/common/config/committers.py:
3586
3587 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3588
3589         [BlackBerry] Disable MathML support
3590         https://bugs.webkit.org/show_bug.cgi?id=111929
3591
3592         Reviewed by Rob Buis.
3593
3594         * Scripts/webkitperl/FeatureList.pm:
3595
3596 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3597
3598         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3599         https://bugs.webkit.org/show_bug.cgi?id=111970
3600
3601         Reviewed by Chris Fleizach.
3602
3603         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3604         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3605         undefined symbol.
3606
3607         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3608         (WTR::AccessibilityUIElement::supportedActions):
3609         (WTR):
3610
3611 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3612
3613         [chromium] Android apk targets should depend directly on Java library targets
3614         https://bugs.webkit.org/show_bug.cgi?id=111746
3615
3616         Reviewed by Eric Seidel.
3617
3618         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3619         Make DumpRenderTree_apk depend directly on base_java and net_java.
3620         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3621         Make TestWebKitAPI_apk depend directly on base_java.
3622
3623 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3624
3625         [chromium] remove obsolete user gesture methods from WebFrame
3626         https://bugs.webkit.org/show_bug.cgi?id=111696
3627
3628         Reviewed by Adam Barth.
3629
3630         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3631         (WebTestRunner::TestPlugin::handleInputEvent):
3632         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3633
3634 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3635
3636         Unreviewed, add myself to commiters.py.
3637
3638         * Scripts/webkitpy