Rebaseline and enable media/modern-media-controls/airplay-support
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [WPE] Add an install-dependencies script
4         https://bugs.webkit.org/show_bug.cgi?id=172948
5
6         Reviewed by Žan Doberšek.
7
8         It is based on the gtk/install-dependencies script.
9         Includes support for Debian based distrubutions, Fedora and Arch.
10         It has been tested on a minimal Debian 9 chroot.
11
12         * wpe/install-dependencies: Added.
13
14 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
15
16         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
17         https://bugs.webkit.org/show_bug.cgi?id=172891
18         <rdar://problem/32204540>
19
20         Reviewed by Darin Adler.
21
22         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
23         contenteditable. See WebCore ChangeLog for more details.
24
25         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
26         (TestWebKitAPI::TEST):
27
28 2017-06-05  Daniel Bates  <dabates@apple.com>
29
30         webkitpy: Abstract Executive class
31         https://bugs.webkit.org/show_bug.cgi?id=172928
32         <rdar://problem/32569531>
33
34         Reviewed by Ryosuke Niwa.
35
36         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
37         This will make it straightforward to create additional derived classes that
38         adhere to the same interface, say for iOS on-device testing.
39
40         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
41         (AbstractExecutive):
42         (AbstractExecutive.run_and_throw_if_fail):
43         (AbstractExecutive.cpu_count):
44         (AbstractExecutive.interpreter_for_script):
45         (AbstractExecutive.shell_command_for_script):
46         (AbstractExecutive.kill_process):
47         (AbstractExecutive.check_running_pid):
48         (AbstractExecutive.running_pids):
49         (AbstractExecutive.wait_newest):
50         (AbstractExecutive.wait_limited):
51         (AbstractExecutive.interrupt):
52         (AbstractExecutive.default_error_handler):
53         (AbstractExecutive.ignore_error):
54         (AbstractExecutive._stringify_args):
55         (AbstractExecutive.command_for_printing):
56         (AbstractExecutive.run_command):
57         (AbstractExecutive.popen):
58         (AbstractExecutive.run_in_parallel):
59         * Scripts/webkitpy/common/system/executive.py:
60         (Executive):
61         (Executive.cpu_count):
62         (Executive.running_pids):
63         (Executive.kill_all):
64         (Executive._compute_stdin):
65         (Executive.interpreter_for_script): Deleted.
66         (Executive.shell_command_for_script): Deleted.
67         (Executive.wait_newest): Deleted.
68         (Executive.wait_limited): Deleted.
69         (Executive.default_error_handler): Deleted.
70         (Executive.ignore_error): Deleted.
71         (Executive.command_for_printing): Deleted.
72
73 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
74
75         webkitpy: Add iOS to platform
76         https://bugs.webkit.org/show_bug.cgi?id=172931
77
78         Reviewed by Daniel Bates.
79
80         * Scripts/webkitpy/common/system/platforminfo.py:
81         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
82         (PlatformInfo.is_ios): Added.
83         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
84         * Scripts/webkitpy/common/system/platforminfo_mock.py:
85         (MockPlatformInfo.is_ios): Added.
86
87 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
88
89         [WPE][JHBuild] Switch github repository from git:// to https://
90         https://bugs.webkit.org/show_bug.cgi?id=172921
91
92         Reviewed by Alex Christensen.
93
94         * wpe/jhbuild.modules:
95
96 2017-06-05  Tim Horton  <timothy_horton@apple.com>
97
98         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
99         https://bugs.webkit.org/show_bug.cgi?id=172887
100         <rdar://problem/32546061>
101
102         Reviewed by Sam Weinig.
103
104         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
105         (WTR::UIScriptController::applyAutocorrection):
106         applyAutocorrection can call its completion handler synchronously,
107         which makes UIScriptController unhappy (see bug 172884).
108
109 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
110
111         webkitpy: Add contextmanager to disable logging for a block
112         https://bugs.webkit.org/show_bug.cgi?id=172876
113
114         Reviewed by Daniel Bates.
115
116         Add a context manager which will use an OutputCapture object to capture logging
117         in a block and hold it in a variable.
118
119         * Scripts/webkitpy/common/system/outputcapture.py:
120         (OutputCaptureScope):
121         (OutputCaptureScope.__init__): Construct with OutputCapture object.
122         (OutputCaptureScope.__enter__): Begin capturing output. 
123         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
124         output and retain the resulting log.
125         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
126         (OutputCaptureTest.test_output_capture_scope): Added.
127
128 2017-06-02  Zalan Bujtas  <zalan@apple.com>
129
130         Cleanup FrameView::autoSizeIfEnabled.
131         https://bugs.webkit.org/show_bug.cgi?id=172889
132         <rdar://problem/32550783>
133
134         Reviewed by Tim Horton.
135
136         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
137         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
138         (TEST):
139
140 2017-06-02  Chris Dumez  <cdumez@apple.com>
141
142         ResourceLoadStatistics are not using unique paths during test runs
143         https://bugs.webkit.org/show_bug.cgi?id=172861
144         <rdar://problem/32442251>
145
146         Reviewed by Darin Adler.
147
148         Make sure WebKitTestRunner sets a temporary path for saving resource
149         load statistics.
150
151         * WebKitTestRunner/TestController.cpp:
152         (WTR::TestController::generateContextConfiguration):
153
154 2017-06-02  Brady Eidson  <beidson@apple.com>
155
156         Prevent scheme handlers from handling all built-in URL schemes.
157         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
158
159         Reviewed by Andy Estes.
160
161         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
162
163 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
164
165         [JSCOnly] Build static jsc.exe on Windows
166         https://bugs.webkit.org/show_bug.cgi?id=172833
167
168         Reviewed by Konstantin Tokarev.
169
170         * CMakeLists.txt:
171         * Scripts/build-jsc:
172
173 2017-06-02  Zalan Bujtas  <zalan@apple.com>
174
175         Disable ViewportSizeForViewportUnits tests on iOS.
176         https://bugs.webkit.org/show_bug.cgi?id=172872
177
178         Reviewed by Tim Horton.
179
180         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
181
182 2017-06-02  Zalan Bujtas  <zalan@apple.com>
183
184         Allow clients to override viewport size for CSS viewport units.
185         https://bugs.webkit.org/show_bug.cgi?id=172838
186         <rdar://problem/32523441>
187
188         Reviewed by Tim Horton.
189
190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
191         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
192         (TEST):
193
194 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
195
196         Get <chrono> out of StdLibExtras.h
197         https://bugs.webkit.org/show_bug.cgi?id=172744
198
199         Reviewed by Zalan Bujtas.
200
201         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
202
203 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
204
205         [WPE] Enable SUBTLE_CRYPTO
206         https://bugs.webkit.org/show_bug.cgi?id=172756
207
208         Reviewed by Michael Catanzaro.
209
210         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
211         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
212         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
213         exhausting entropy when running the crypto layout tests.
214
215 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
216
217         [GTK] Bump GTK+ and its dependencies in jhbuild
218         https://bugs.webkit.org/show_bug.cgi?id=171918
219
220         Reviewed by Carlos Alberto Lopez Perez.
221
222         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
223         (WTR::initializeGtkSettings):
224         * gtk/jhbuild.modules:
225         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
226         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
227
228 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
229
230         [GTK] Bump wayland and weston in jhbuild
231         https://bugs.webkit.org/show_bug.cgi?id=171921
232
233         Reviewed by Carlos Alberto Lopez Perez.
234
235         * gtk/jhbuild.modules:
236         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
237
238 2017-06-01  Andy Estes  <aestes@apple.com>
239
240         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
241         https://bugs.webkit.org/show_bug.cgi?id=172828
242
243         Reviewed by Beth Dakin.
244
245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
246
247 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
248
249         webkitpy: Remove unneeded simulator teardown
250         https://bugs.webkit.org/show_bug.cgi?id=171891
251
252         Reviewed by Aakash Jain.
253
254         * Scripts/webkitpy/port/ios_simulator.py:
255         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
256         for communication between Python and WebKitTestRunner/DumpRenderTree.
257
258 2017-06-01  Keith Miller  <keith_miller@apple.com>
259
260         Undo rollout in r217638 with bug fix
261         https://bugs.webkit.org/show_bug.cgi?id=172824
262
263         Unreviewed, reland patch with unused set_state code removed.
264
265         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
266         (runThreadMessageTest):
267         (TEST):
268
269 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
270
271         webkitpy: Do not send 0 or -1 as a pid to kill_process
272         https://bugs.webkit.org/show_bug.cgi?id=172818
273
274         Reviewed by Darin Adler.
275
276         Sending a signal to process 0 will result in all processes in the group receiving 
277         the signal. Sending a signal to process -1 will result in all non-system processes
278         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
279         should consider these cases
280
281         * Scripts/webkitpy/common/system/executive.py:
282         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
283         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
284         never be running, although os.kill may succeed.
285         * Scripts/webkitpy/port/simulator_process.py:
286         (SimulatorProcess.stop): Do not kill process if it is undefined.
287
288 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
289
290         JSC EWS bot does not run on WTF only patches
291         https://bugs.webkit.org/show_bug.cgi?id=172777
292         rdar://problem/32495975
293
294         Reviewed by Aakash Jain.
295
296         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
297         (CheckPatchRelevance): Add a missing comma.
298
299 2017-05-31  Commit Queue  <commit-queue@webkit.org>
300
301         Unreviewed, rolling out r217611 and r217631.
302         https://bugs.webkit.org/show_bug.cgi?id=172785
303
304         "caused wasm-hashset-many.html to become flaky." (Requested by
305         keith_miller on #webkit).
306
307         Reverted changesets:
308
309         "Reland r216808, underlying lldb bug has been fixed."
310         https://bugs.webkit.org/show_bug.cgi?id=172759
311         http://trac.webkit.org/changeset/217611
312
313         "Use dispatch queues for mach exceptions"
314         https://bugs.webkit.org/show_bug.cgi?id=172775
315         http://trac.webkit.org/changeset/217631
316
317 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
318
319         EWS bots should reboot themselves more frequently
320         https://bugs.webkit.org/show_bug.cgi?id=172402
321
322         Reviewed by Alexey Proskuryakov.
323
324         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
325
326         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
327
328 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
329
330         Reallocate hardware for iOS bots.
331         https://bugs.webkit.org/show_bug.cgi?id=172657
332
333         Reviewed by Alexey Proskuryakov.
334
335         * BuildSlaveSupport/build.webkit.org-config/config.json:
336
337 2017-05-31  Andy Estes  <aestes@apple.com>
338
339         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
340         https://bugs.webkit.org/show_bug.cgi?id=172366
341
342         Reviewed by Daniel Bates.
343
344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
345
346 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
347
348         Unreviewed, add Jiewen Tan as a reviewer
349
350         * Scripts/webkitpy/common/config/contributors.json:
351
352 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
353
354         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
355         https://bugs.webkit.org/show_bug.cgi?id=172770
356
357         Reviewed by Michael Catanzaro.
358
359         * MiniBrowser/gtk/BrowserWindow.c:
360         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
361         which caused the body of the if-clause to be accidentally empty.
362
363 2017-05-31  Keith Miller  <keith_miller@apple.com>
364
365         Reland r216808, underlying lldb bug has been fixed.
366         https://bugs.webkit.org/show_bug.cgi?id=172759
367
368         Unreviewed, relanding old patch. See: rdar://problem/31183352
369
370         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
371         (runThreadMessageTest):
372         (TEST):
373
374 2017-05-31  Matt Lewis  <jlewis3@apple.com>
375
376         Unreviewed, rolling out r217603.
377
378         This patch broke the internal builds.
379
380         Reverted changeset:
381
382         "Get <chrono> out of StdLibExtras.h"
383         https://bugs.webkit.org/show_bug.cgi?id=172744
384         http://trac.webkit.org/changeset/217603
385
386 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
387
388         Make ResourceLoadStatistics testing more reliable
389         https://bugs.webkit.org/show_bug.cgi?id=172730
390         <rdar://problem/32028373>
391
392         Reviewed by Andy Estes.
393
394         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
395         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
396
397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
398         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
399
400 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
401
402         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
403         https://bugs.webkit.org/show_bug.cgi?id=172757
404
405         Reviewed by Xabier Rodriguez-Calvar.
406
407         When needed, add the jhbuild wrapper at the beginning of the array
408         that will be invoked to execute the run-jsc-stress-test or testapi
409         commands.
410
411         * Scripts/run-javascriptcore-tests:
412         (runJSCStressTests):
413         * Scripts/webkitdirs.pm:
414         (shouldUseJhbuild):
415
416 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
417
418         Get <chrono> out of StdLibExtras.h
419         https://bugs.webkit.org/show_bug.cgi?id=172744
420
421         Reviewed by Saam Barati.
422
423         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
424
425 2017-05-30  Tim Horton  <timothy_horton@apple.com>
426
427         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
428         https://bugs.webkit.org/show_bug.cgi?id=172735
429         <rdar://problem/32015977>
430
431         Reviewed by Enrica Casucci.
432
433         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
434         (WTR::UIScriptController::applyAutocorrection):
435         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
436         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
437         (WTR::UIScriptController::applyAutocorrection):
438         * TestRunnerShared/UIScriptContext/UIScriptController.h:
439         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
440         (WTR::UIScriptController::applyAutocorrection):
441         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
442         because I don't know how to tap the button in the autocorrection bar from a test.
443
444 2017-05-30  Daniel Bates  <dabates@apple.com>
445
446         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
447         https://bugs.webkit.org/show_bug.cgi?id=172671
448
449         Reviewed by Alex Christensen.
450
451         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
452         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
453
454         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
455         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
456         to trigger a navigation to test it.
457         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
458         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
459
460 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
461
462         webkitpy: Start servers before setting-up for testing
463         https://bugs.webkit.org/show_bug.cgi?id=172176
464         <rdar://problem/32225538>
465
466         Reviewed by Alexey Proskuryakov.
467
468         On-device testing requires that servers are started before ports set-up their
469         test environments.
470
471         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
472         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
473         Servers are unconditionally stopped on exit.
474         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
475         Manager now stops servers.
476         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
477         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
478         * Scripts/webkitpy/layout_tests/controllers/manager.py:
479         (Manager.__init__): Delay construction of the test runner until we can determine
480         if servers need to be started.
481         (Manager.run): Determine if servers need to be started and construct the test runner.
482         Shut servers down when the test run is finished.
483         (Manager._run_tests): Move the determination of servers to run into Manager.run.
484         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
485         (is_wpt_server_running): Server is not running if no config is found.
486         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
487         (PyWebSocket.is_running): Check if this WebSocket server is running.
488         * Scripts/webkitpy/port/base.py:
489         (Port.__init__): Define secure WebSocket server.
490         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
491
492 2017-05-30  Daniel Bates  <dabates@apple.com>
493
494         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
495         https://bugs.webkit.org/show_bug.cgi?id=172603
496         <rdar://problem/32471306>
497
498         Reviewed by Brady Eidson.
499
500         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
501         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
502         unloading is initiated for a page that registered a onbeforeunload handler.
503
504         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
505         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
506         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
507
508         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
509         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
510         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
511         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
512
513         * MiniBrowser/mac/WK2BrowserWindowController.m:
514         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
515         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
516         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
517         (sawDialog):
518         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
519         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
520         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
521
522 2017-05-30  Alex Christensen  <achristensen@webkit.org>
523
524         Update libwebrtc configuration
525         https://bugs.webkit.org/show_bug.cgi?id=172727
526
527         Reviewed by Geoffrey Garen.
528
529         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
530
531 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
532
533         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
534         https://bugs.webkit.org/show_bug.cgi?id=172702
535
536         Reviewed by Alex Christensen.
537
538         EGL PlatformDisplay needs to be shut down before existing a
539         program on Windows.
540
541         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
542         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
543         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
544         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
545
546 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
547
548         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
549         https://bugs.webkit.org/show_bug.cgi?id=172709
550
551         Reviewed by Brent Fulgham.
552
553         Exit fullscreen mode after a fullscreen test.
554
555         * DumpRenderTree/win/DumpRenderTree.cpp:
556         (resetWebViewToConsistentStateBeforeTesting):
557
558 2017-05-30  Antti Koivisto  <antti@apple.com>
559
560         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
561         https://bugs.webkit.org/show_bug.cgi?id=172713
562
563         Reviewed by Zalan Bujtas.
564
565         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
566         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
567
568             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
569             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
570             because on Mac WK1 it may get invoked from middle of a layout.
571
572             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
573
574 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
575
576         Add a WPE EWS queue
577         https://bugs.webkit.org/show_bug.cgi?id=172693
578
579         Reviewed by Carlos Garcia Campos.
580
581         * QueueStatusServer/config/queues.py:
582         * QueueStatusServer/model/queues.py: Capitalize the name of the
583         port on the tooltip of the bubbles. Do the same for the GTK port.
584         (Queue.display_name):
585         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
586         for the GTK+ EWS also. Set for both ports as watcher the alias
587         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
588         * Scripts/webkitpy/common/config/ports.py:
589         (DeprecatedPort.port):
590         (WpePort):
591         (WpePort.build_webkit_command):
592         (WpePort.run_webkit_tests_command):
593         * Scripts/webkitpy/common/config/ports_unittest.py:
594         (DeprecatedPortTest):
595         (DeprecatedPortTest.test_wpe_port):
596         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
597         (test_ews_name):
598
599 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
600
601         Unreviewed. Bumping the WPEBackend-mesa dependency version.
602
603         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
604         priorities for IPC communication.
605
606 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
607
608         [JSC] Map and Set constructors should have fast path for cloning
609         https://bugs.webkit.org/show_bug.cgi?id=172413
610
611         Reviewed by Saam Barati.
612
613         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
614         (TestWebKitAPI::TEST):
615
616 2017-05-27  Zalan Bujtas  <zalan@apple.com>
617
618         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
619         https://bugs.webkit.org/show_bug.cgi?id=172676
620
621         Reviewed by Simon Fraser.
622
623         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
624         (TestWebKitAPI::TEST):
625
626 2017-05-26  Zalan Bujtas  <zalan@apple.com>
627
628         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
629         https://bugs.webkit.org/show_bug.cgi?id=172674
630
631         Reviewed by Simon Fraser.
632
633         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
634         (TestWebKitAPI::TEST):
635
636 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
637
638         Add test resources back into TestWebKitAPI Copy Resources phase
639
640         Rubber-stamped by Beth Dakin.
641
642         Add two files back into the Copy Resources phase after they were unintentionally
643         removed in r217447 and r217496.
644
645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
646
647 2017-05-26  Beth Dakin  <bdakin@apple.com>
648
649         Media documents inside iframes should not get controls in the TouchBar unless the 
650         video is playing
651         https://bugs.webkit.org/show_bug.cgi?id=172620
652         -and corresponding-
653         rdar://problem/32165477
654
655         Reviewed by Jon Lee.
656
657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
658         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
659         (TestWebKitAPI::TEST):
660         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
661
662 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
663
664         _WKUserStyleSheet and WKUserScript leak string data
665         https://bugs.webkit.org/show_bug.cgi?id=172583
666         <rdar://problem/32395209>
667
668         Reviewed by Sam Weinig.
669
670         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
671         We should not have been adopting an autoreleased object.
672
673 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
674
675         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
676         https://bugs.webkit.org/show_bug.cgi?id=172554
677         <rdar://problem/31247133>
678
679         Reviewed by Simon Fraser.
680
681         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
682         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
683         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
684         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
685         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
686         codepath.
687
688         * DumpRenderTree/TestOptions.h:
689         * DumpRenderTree/TestOptions.mm:
690         (TestOptions::TestOptions):
691         (TestOptions::webViewIsCompatibleWithOptions):
692         * DumpRenderTree/mac/DumpRenderTree.mm:
693         (shouldIgnoreWebCoreNodeLeaks):
694         (allowedFontFamilySet):
695         (-[DRTMockScroller rectForPart:]):
696         (-[DRTMockScroller drawKnob]):
697         (-[DRTMockScroller drawRect:]):
698         (createWebViewAndOffscreenWindow):
699         (initializeGlobalsFromCommandLineOptions):
700         (prepareConsistentTestingEnvironment):
701         (dumpRenderTree):
702         (dumpAudio):
703         (dumpHistoryItem):
704         (dumpBackForwardListForWebView):
705         (resetWebViewToConsistentStateBeforeTesting):
706         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
707         (runTest):
708
709 2017-05-25  Sam Weinig  <sam@webkit.org>
710
711         [WebIDL] Use the term 'operation' more consistently
712         https://bugs.webkit.org/show_bug.cgi?id=172601
713
714         Reviewed by Chris Dumez.
715
716         We were using the term 'operation', a WebIDL term for function-like
717         constructs, inconsistently in the code generator. Now, when we use
718         'operation' when referring to the IDL concept (usually the object the
719         parser produces) and 'function' when referring to code being generated.
720
721         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
722         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
723
724 2017-05-25  Jer Noble  <jer.noble@apple.com>
725
726         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
727
728         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
729
730 2017-05-25  Jer Noble  <jer.noble@apple.com>
731
732         System sleeps while playing to wireless target, ending stream.
733         https://bugs.webkit.org/show_bug.cgi?id=172541
734
735         Reviewed by Eric Carlson.
736
737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
738         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
739         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
740         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
741         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
742         (TestWebKitAPI::simulateKeyDown):
743         (TestWebKitAPI::hasAssertionType):
744         (TestWebKitAPI::TEST):
745
746 2017-05-25  Commit Queue  <commit-queue@webkit.org>
747
748         Unreviewed, rolling out r217423 and r217424.
749         https://bugs.webkit.org/show_bug.cgi?id=172607
750
751         These caused an api failure on all testers. (Requested by
752         mlewis13 on #webkit).
753
754         Reverted changesets:
755
756         "REGRESSION (r216977): 4 leaks introduced in new
757         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
758         https://bugs.webkit.org/show_bug.cgi?id=172558
759         http://trac.webkit.org/changeset/217423
760
761         "REGRESSION (r217423): Fix last-second typo in 'auto'"
762         http://trac.webkit.org/changeset/217424
763
764 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
765
766         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
767         https://bugs.webkit.org/show_bug.cgi?id=172355
768
769         Reviewed by Chris Fleizach.
770
771         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
772         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
773         releases which support the new platform footnote accessibility role.
774
775         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
776         * gtk/jhbuild.modules:
777
778 2017-05-25  David Kilzer  <ddkilzer@apple.com>
779
780         REGRESSION (r217423): Fix last-second typo in 'auto'
781
782         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
783         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
784
785 2017-05-24  David Kilzer  <ddkilzer@apple.com>
786
787         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
788         <https://webkit.org/b/172558>
789
790         Reviewed by Sam Weinig.
791
792         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
793         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
794
795 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
796
797         [CMake] Consolidate CMake code related to Cairo
798         https://bugs.webkit.org/show_bug.cgi?id=172568
799
800         Reviewed by Alex Christensen.
801
802         * DumpRenderTree/config.h:
803         * TestWebKitAPI/config.h:
804
805 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
806
807         Plumb additional image metadata to item providers when beginning data interaction on an image
808         https://bugs.webkit.org/show_bug.cgi?id=172536
809         <rdar://problem/32371300>
810
811         Reviewed by Beth Dakin.
812
813         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
814         source item providers.
815
816         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
817         (checkSuggestedNameAndEstimatedSize):
818         (TestWebKitAPI::TEST):
819
820 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
821
822         [Win] Create unique network storage session for each DRT.
823         https://bugs.webkit.org/show_bug.cgi?id=172540
824
825         Reviewed by Brent Fulgham.
826
827         During layout testing, each DRT instance should have its own network storage session.
828
829         * DumpRenderTree/win/DumpRenderTree.cpp:
830         (prepareConsistentTestingEnvironment):
831
832 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
833
834         Respect image UTIs when writing to item providers when beginning data interaction on an image
835         https://bugs.webkit.org/show_bug.cgi?id=172436
836         <rdar://problem/31786569>
837
838         Reviewed by Beth Dakin.
839
840         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
841         details.
842
843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
844         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
845         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
846
847         Create a new test page containing a GIF and a file input.
848
849         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
850         (checkTypeIdentifierIsRegisteredAtIndex):
851         (TestWebKitAPI::TEST):
852
853 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
854
855         [Win] Increase test timeout for slow tests.
856         https://bugs.webkit.org/show_bug.cgi?id=172449
857
858         Reviewed by Alexey Proskuryakov.
859
860         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
861         timeout member in the TestRunner class.
862
863         * DumpRenderTree/win/TestRunnerWin.cpp:
864         (TestRunner::setWaitToDump):
865
866 2017-05-15  Matt Rajca  <mrajca@apple.com>
867
868         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
869         https://bugs.webkit.org/show_bug.cgi?id=172138
870
871         Reviewed by Alex Christensen.
872
873         Added API tests.
874
875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
876         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
877         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
878         (TEST):
879         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
880
881 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
882
883         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
884         https://bugs.webkit.org/show_bug.cgi?id=172522
885         rdar://problem/31071812
886
887         Reviewed by Sam Weinig.
888
889         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
890         We set this in the .xib file now.
891
892         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
893
894 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
895
896         Snapshotting via -renderInContext: should do synchronous image decodes
897         https://bugs.webkit.org/show_bug.cgi?id=172485
898         rdar://problem/32276146
899
900         Reviewed by Tim Horton.
901
902         New API test.
903
904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
905         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
906         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
907         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
908         (TestWebKitAPI::getPixelIndex):
909         (TestWebKitAPI::TEST):
910
911 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
912
913         Remove dead ENABLE(FONT_LOAD_EVENTS) code
914         https://bugs.webkit.org/show_bug.cgi?id=172517
915
916         Rubber-stamped by Simon Fraser.
917
918         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
919
920 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
921
922         Multiple links should be inserted separately when performing data interaction
923         https://bugs.webkit.org/show_bug.cgi?id=172489
924         <rdar://problem/31510832>
925
926         Reviewed by Dan Bernstein.
927
928         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
929
930         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
931         (TestWebKitAPI::TEST):
932
933 2017-05-23  Tim Horton  <timothy_horton@apple.com>
934
935         REGRESSION: API test WebKit2.WKObject is failing
936         https://bugs.webkit.org/show_bug.cgi?id=172497
937         <rdar://problem/31694641>
938
939         Reviewed by Geoff Garen.
940
941         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
942         (TestWebKitAPI::TEST):
943         Add a test that ensures that we pretend to at least be *some* kind of
944         NSString, which my first fix would not have passed.
945
946 2017-05-23  youenn fablet  <youenn@apple.com>
947
948         There should be an easy way to run HTTP/WPT served tests on a browser
949         https://bugs.webkit.org/show_bug.cgi?id=172068
950
951         Reviewed by Sam Weinig.
952
953         Adding a new script open-layout-test to open a layout-test in a
954         browser and making sure it is served as done through run-webkit-tests.
955         In case tests should be run using a server, detecting whether the
956         server are running. If not, calling run-webkit-httpd to run the
957         servers and open the URL in a browser.
958         Otherwise, open directly the URL.
959
960         Adding an option in run-webkit-httpd to open an URL after having
961         started the servers.
962
963         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
964         This allows running run-webkit-httpd once and not having to restart
965         servers everytime a test should be served.
966
967         Moving most of run-webkit-httpd logic in its own python file to reuse
968         it in open-layout-test script.
969
970         Adding routines to check whether HTTP and WPT servers are running.
971
972         * Scripts/open-layout-test: Added.
973         (parse_args):
974         (main):
975         * Scripts/run-webkit-httpd:
976         (main):
977         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
978         (LayoutTestFinder.find_tests):
979         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
980         (LayoutTestRunner.run_tests):
981         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
982         (parse_args):
983         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
984         (HttpServerBase._is_server_running_on_all_ports):
985         (HttpServerBase):
986         (HttpServerBase._is_running_on_port):
987         (HttpServerBase._check_that_all_ports_are_available):
988         (is_http_server_running):
989         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
990         (parse_args):
991         (main):
992         (run_server):
993         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
994         (is_wpt_server_running):
995         * Scripts/webkitpy/port/base.py:
996         (Port.to.is_http_server_running):
997         (Port.to):
998         (Port.to.is_wpt_server_running):
999         (Port.to.start_web_platform_test_server):
1000         * Scripts/webkitpy/port/driver.py:
1001         (DriverProxy.is_web_platform_test):
1002         (DriverProxy):
1003         (DriverProxy.is_webkit_specific_web_platform_test):
1004
1005 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
1006
1007         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1008         https://bugs.webkit.org/show_bug.cgi?id=171984
1009
1010         Reviewed by Antti Koivisto.
1011
1012         * DumpRenderTree/mac/DumpRenderTree.mm:
1013         (enableExperimentalFeatures):
1014         * WebKitTestRunner/TestController.cpp:
1015         (WTR::TestController::resetPreferencesToConsistentValues):
1016
1017 2017-05-20  Alex Christensen  <achristensen@webkit.org>
1018
1019         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
1020         https://bugs.webkit.org/show_bug.cgi?id=172406
1021         <rdar://32109532>
1022
1023         Reviewed by Brady Eidson.
1024
1025         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1026         (TestWebKitAPI::checkBuffer):
1027         (TestWebKitAPI::TEST_F):
1028
1029 2017-05-22  Jason Marcell  <jmarcell@apple.com>
1030
1031         Do not enter Subversion-specific logic when parsing Git-based Trac data.
1032         https://bugs.webkit.org/show_bug.cgi?id=172433
1033         <rdar://problem/32234188>
1034
1035         Reviewed by Alexey Proskuryakov.
1036
1037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1038         (Trac.prototype._convertCommitInfoElementToObject):
1039
1040 2017-05-22  Tim Horton  <timothy_horton@apple.com>
1041
1042         ExplicitSnapshotsChangeUponNavigation API test often fails
1043         https://bugs.webkit.org/show_bug.cgi?id=172475
1044         <rdar://problem/31688322>
1045
1046         Reviewed by Simon Fraser.
1047
1048         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1049         (-[TestWKWebView _setUpTestWindow:]):
1050         Make TestWKWebView's window layer-backed. This is now the default,
1051         and it's also easy to accidentally write a test that depends on it
1052         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
1053         which becomes layer backed, just like the WKWebView, but with no
1054         common layer-backed ancestor).
1055
1056 2017-05-22  youenn fablet  <youenn@apple.com>
1057
1058         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
1059         https://bugs.webkit.org/show_bug.cgi?id=172426
1060
1061         Reviewed by Chris Dumez.
1062
1063         * Scripts/webkitpy/w3c/test_importer.py:
1064         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
1065
1066 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
1067
1068         Unreviewed, change my status to reviewer and fill "expertise" field
1069
1070         * Scripts/webkitpy/common/config/contributors.json:
1071
1072 2017-05-22  Tomas Popela  <tpopela@redhat.com>
1073
1074         Remove some of the EFL port leftovers
1075         https://bugs.webkit.org/show_bug.cgi?id=172440
1076
1077         Reviewed by Carlos Garcia Campos.
1078
1079         * BuildSlaveSupport/built-product-archive:
1080         (archiveBuiltProduct):
1081         (extractBuiltProduct):
1082         * BuildSlaveSupport/test-result-archive:
1083         (archiveTestResults):
1084         * ImageDiff/PlatformEfl.cmake: Removed.
1085         * Scripts/run-efl-tests: Removed.
1086         * Scripts/webkit-build-directory:
1087         * Scripts/webkitpy/common/config/contributionareas.py:
1088         * Scripts/webkitpy/common/config/watchlist:
1089         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1090         (parse_args):
1091         (_set_up_derived_options):
1092         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1093         (PerfTestsRunner.__init__):
1094         * Scripts/webkitpy/style/checker.py:
1095         * Scripts/webkitpy/style/checker_unittest.py:
1096         (GlobalVariablesTest.test_path_rules_specifier):
1097         * gtk/manifest.txt.in:
1098         * jhbuild/jhbuild-wrapper:
1099
1100 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1101
1102         Unreviewed. Do not include WPE files in GTK+ tarballs.
1103
1104         * gtk/manifest.txt.in:
1105
1106 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1107
1108         [GTK] Add webkit_context_menu_item_new_from_gaction
1109         https://bugs.webkit.org/show_bug.cgi?id=159631
1110
1111         Reviewed by Michael Catanzaro.
1112
1113         Update context menu tests to check the new GAction API.
1114
1115         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1116         (testContextMenuPopulateMenu):
1117
1118 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1119
1120         [GTK] Remove Firefox user agent quirk for Google domains
1121         https://bugs.webkit.org/show_bug.cgi?id=171941
1122
1123         Reviewed by Carlos Garcia Campos.
1124
1125         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1126         (TestWebKitAPI::TEST):
1127         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
1128
1129 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
1130
1131         [GTK] gtkdoc-fixxref needs --module argument to work
1132         https://bugs.webkit.org/show_bug.cgi?id=172415
1133
1134         Reviewed by Michael Catanzaro.
1135
1136         * gtk/gtkdoc.py:
1137         (GTKDoc._run_gtkdoc_fixxref):
1138
1139 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
1140
1141         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
1142         https://bugs.webkit.org/show_bug.cgi?id=172416
1143
1144         Reviewed by Daniel Bates.
1145
1146         * Scripts/make-new-script-test:
1147
1148 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1149
1150         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
1151         https://bugs.webkit.org/show_bug.cgi?id=172267
1152
1153         Reviewed by Per Arne Vollan.
1154
1155         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
1156         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
1157         should link only with WebKit.
1158
1159         Unfortunately, there is a layer violation at the moment.
1160         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
1161         in WebKit. This change contains a stub of loadResourceIntoBuffer
1162         in TestWebCoreLib for the workaround.
1163
1164         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
1165         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
1166         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
1167         (loadResourceIntoBuffer): Added a stub.
1168
1169 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
1170
1171         Fix dump-class-layout to handle different file architectures
1172         https://bugs.webkit.org/show_bug.cgi?id=172392
1173
1174         Reviewed by Zalan Bujtas.
1175
1176         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
1177         and use the first architecture reported. Also add a "--architecture" argument
1178         to allow the user to specify an architecture.
1179
1180         * Scripts/dump-class-layout:
1181         (import_lldb):
1182         (verify_type_recursive):
1183         (get_first_file_architecture):
1184         (dump_class):
1185         (main):
1186         (find_build_directory): Deleted.
1187
1188 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1189
1190         Unreviewed infrastructure fix.
1191
1192         * Scripts/webkitpy/port/ios_simulator.py:
1193         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
1194
1195 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1196
1197         webkitpy: Use simctl boot to run multiple simulators at once
1198         https://bugs.webkit.org/show_bug.cgi?id=172374
1199
1200         Reviewed by Alexey Proskuryakov.
1201
1202         * Scripts/webkitpy/common/system/platforminfo.py:
1203         (PlatformInfo.xcode_version): Return the current version of Xcode.
1204         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1205         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
1206         * Scripts/webkitpy/port/ios_simulator.py:
1207         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
1208         run multiple Simulator.app instances.
1209         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
1210         versions of Xcode.
1211         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
1212         an older version of Xcode.
1213
1214 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1215
1216         Unreviewed, fix the build on the latest internal SDK.
1217
1218         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1219         (TestWebKitAPI::TEST):
1220
1221 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
1222
1223         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
1224         https://bugs.webkit.org/show_bug.cgi?id=172369
1225
1226         Reviewed by Mark Lam.
1227         
1228         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
1229         would be a good idea to write this down.
1230
1231         * Scripts/run-jsc-stress-tests:
1232
1233 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1234
1235         webkitpy: Layout tests which have no output will succeed
1236         https://bugs.webkit.org/show_bug.cgi?id=172322
1237         <rdar://problem/32258350>
1238
1239         Reviewed by David Kilzer.
1240
1241         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1242         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
1243         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1244         (determine_result_type): FailureNotTested means that the test could not be loaded. This
1245         is classified as a MISSING failure.
1246         (FailureNotTested): Added.
1247         (FailureNotTested.message):
1248
1249 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1250
1251         Add SixSpeed benchmark to PerformanceTests
1252         https://bugs.webkit.org/show_bug.cgi?id=172326
1253
1254         Reviewed by Sam Weinig.
1255
1256         * Scripts/run-jsc-benchmarks:
1257
1258 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1259
1260         [WK1] MiniBrowser should navigate when handling a dropped URL
1261         https://bugs.webkit.org/show_bug.cgi?id=172350
1262
1263         Reviewed by Tim Horton.
1264
1265         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
1266
1267         * MiniBrowser/mac/WK1BrowserWindowController.m:
1268         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
1269
1270 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
1271
1272         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
1273         https://bugs.webkit.org/show_bug.cgi?id=172077
1274
1275         Reviewed by Chris Dumez.
1276
1277         Fixed perftest.py by updating the lines to ignore in Speedometer.
1278
1279         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
1280
1281         * Scripts/webkitpy/performance_tests/perftest.py:
1282         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
1283         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1284         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
1285         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
1286         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1287         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
1288
1289 2017-05-18  Andy Estes  <aestes@apple.com>
1290
1291         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1292         https://bugs.webkit.org/show_bug.cgi?id=172305
1293
1294         Reviewed by Anders Carlsson.
1295
1296         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1297
1298 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1299
1300         Selection around attachment elements should not persist when beginning a drag
1301         https://bugs.webkit.org/show_bug.cgi?id=172319
1302         <rdar://problem/32283008>
1303
1304         Reviewed by Tim Horton.
1305
1306         Tests that temporary selection around an attachment does not persist longer than it needs to.
1307
1308         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1309         (TestWebKitAPI::TEST):
1310
1311 2017-05-18  John Wilander  <wilander@apple.com>
1312
1313         Resource Load Statistics: Grandfather domains for existing data records
1314         https://bugs.webkit.org/show_bug.cgi?id=172155
1315         <rdar://problem/24913532>
1316
1317         Reviewed by Alex Christensen.
1318
1319         Adds test infrastructure needed for the added functionality.
1320
1321         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1322         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1323         (WTR::InjectedBundle::didReceiveMessageToPage):
1324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1325         (WTR::TestRunner::setStatisticsGrandfathered):
1326         (WTR::TestRunner::isStatisticsGrandfathered):
1327         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1328         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
1329         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1330         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1331         * WebKitTestRunner/TestController.cpp:
1332         (WTR::TestController::setStatisticsGrandfathered):
1333         (WTR::TestController::isStatisticsGrandfathered):
1334         (WTR::TestController::setStatisticsGrandfatheringTime):
1335         * WebKitTestRunner/TestController.h:
1336         * WebKitTestRunner/TestInvocation.cpp:
1337         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1338
1339 2017-05-18  Saam Barati  <sbarati@apple.com>
1340
1341         WebAssembly: perform stack checks
1342         https://bugs.webkit.org/show_bug.cgi?id=165546
1343         <rdar://problem/29760307>
1344
1345         Reviewed by Filip Pizlo.
1346
1347         Add some new testing modes for using and not using fast TLS wasm contexts.
1348
1349         * Scripts/run-jsc-stress-tests:
1350
1351 2017-05-18  Daniel Bates  <dabates@apple.com>
1352
1353         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
1354         window CSP when object-src 'none' is set
1355         https://bugs.webkit.org/show_bug.cgi?id=172038
1356         <rdar://problem/32258262>
1357
1358         Reviewed by Andy Estes.
1359
1360         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
1361         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
1362
1363         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1364         (NPP_New):
1365
1366 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
1367
1368         [Win] Many layout tests are failing.
1369         https://bugs.webkit.org/show_bug.cgi?id=172286
1370
1371         Reviewed by Brent Fulgham.
1372
1373         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
1374  
1375         * DumpRenderTree/win/TestRunnerWin.cpp:
1376         (TestRunner::grantWebNotificationPermission):
1377         (TestRunner::denyWebNotificationPermission):
1378         (TestRunner::removeAllWebNotificationPermissions):
1379         (TestRunner::simulateWebNotificationClick):
1380
1381 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
1382
1383         [Win] Remove usage of _snprintf
1384         https://bugs.webkit.org/show_bug.cgi?id=172251
1385
1386         Reviewed by Per Arne Vollan.
1387
1388         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1389         * MiniBrowser/win/PageLoadTestClient.cpp:
1390         (PageLoadTestClient::dumpRunStatistics):
1391
1392 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
1393
1394         Unreviewed, rolling out r217014.
1395
1396         This change caused mac-wk2 LayoutTests to exit early due to
1397         crashes.
1398
1399         Reverted changeset:
1400
1401         "Resource Load Statistics: Grandfather domains for existing
1402         data records"
1403         https://bugs.webkit.org/show_bug.cgi?id=172155
1404         http://trac.webkit.org/changeset/217014
1405
1406 2017-05-17  John Wilander  <wilander@apple.com>
1407
1408         Resource Load Statistics: Grandfather domains for existing data records
1409         https://bugs.webkit.org/show_bug.cgi?id=172155
1410         <rdar://problem/24913532>
1411
1412         Reviewed by Alex Christensen.
1413
1414         Adds test infrastructure needed for the added functionality.
1415
1416         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1417         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1418         (WTR::InjectedBundle::didReceiveMessageToPage):
1419         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1420         (WTR::TestRunner::setStatisticsGrandfathered):
1421         (WTR::TestRunner::isStatisticsGrandfathered):
1422         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1423         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
1424         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1426         * WebKitTestRunner/TestController.cpp:
1427         (WTR::TestController::setStatisticsGrandfathered):
1428         (WTR::TestController::isStatisticsGrandfathered):
1429         (WTR::TestController::setStatisticsGrandfatheringTime):
1430         * WebKitTestRunner/TestController.h:
1431         * WebKitTestRunner/TestInvocation.cpp:
1432         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1433
1434 2017-05-17  Alex Christensen  <achristensen@webkit.org>
1435
1436         Fix ios-simulator API test after r216977
1437         https://bugs.webkit.org/show_bug.cgi?id=171987
1438
1439         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1440         (TEST):
1441         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
1442         not as urgent as having the rest of this working. Notably the ephemeral part of the
1443         test works, so something is just wrong with the persistent part.
1444
1445 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
1446
1447         Unreviewed, rolling out r216955.
1448
1449         This change caused strange behavior with web-platform-tests
1450         locally and on EWS.
1451
1452         Reverted changeset:
1453
1454         "webkitpy: Start servers before setting-up for testing"
1455         https://bugs.webkit.org/show_bug.cgi?id=172176
1456         http://trac.webkit.org/changeset/216955
1457
1458 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1459
1460         A URL type is vended for a non-URL plain text string when starting data interaction
1461         https://bugs.webkit.org/show_bug.cgi?id=172228
1462         <rdar://problem/32166729>
1463
1464         Reviewed by Andy Estes.
1465
1466         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
1467         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
1468         still vended when beginning data interaction on something that resembles a link.
1469
1470         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1471
1472 2017-05-17  David Kilzer  <ddkilzer@apple.com>
1473
1474         BlobDataFileReference::generateReplacementFile() should use mkstemp()
1475         <https://webkit.org/b/172192>
1476
1477         Reviewed by Brent Fulgham.
1478
1479         * Scripts/webkitpy/style/checkers/cpp.py:
1480         (check_language): Add check for mktemp.
1481         (CppChecker): Add 'security/temp_file' category.
1482         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1483         (CppStyleTest.test_insecure_temp_file): Add test.
1484
1485 2017-05-17  Devin Rousso  <drousso@apple.com>
1486
1487         Unreviewed, change my email.
1488
1489         * Scripts/webkitpy/common/config/contributors.json:
1490
1491 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1492
1493         Unreviewed, rolling out r216974.
1494
1495         Revision caused consistent timeouts on all platforms.
1496
1497         Reverted changeset:
1498
1499         "Add a RuntimeEnabledFeature for display: contents, defaulted
1500         to false."
1501         https://bugs.webkit.org/show_bug.cgi?id=171984
1502         http://trac.webkit.org/changeset/216974
1503
1504 2017-05-17  Alex Christensen  <achristensen@webkit.org>
1505
1506         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
1507         https://bugs.webkit.org/show_bug.cgi?id=171987
1508
1509         Reviewed by Brady Eidson.
1510
1511         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1512         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1513         (TEST):
1514
1515 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1516
1517         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1518         https://bugs.webkit.org/show_bug.cgi?id=171984
1519
1520         Reviewed by Antti Koivisto.
1521
1522         * DumpRenderTree/mac/DumpRenderTree.mm:
1523         (enableExperimentalFeatures):
1524         * WebKitTestRunner/TestController.cpp:
1525         (WTR::TestController::resetPreferencesToConsistentValues):
1526
1527 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
1528
1529         Fix the build
1530
1531         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1532         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1533
1534 2017-05-16  Tim Horton  <timothy_horton@apple.com>
1535
1536         PageVisibilityStateWithWindowChanges tests sometimes time out
1537         https://bugs.webkit.org/show_bug.cgi?id=172202
1538         <rdar://problem/29653266>
1539
1540         Reviewed by Dean Jackson.
1541
1542         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1543         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1544         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
1545
1546 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
1547
1548         webkitpy: Start servers before setting-up for testing
1549         https://bugs.webkit.org/show_bug.cgi?id=172176
1550         <rdar://problem/32225538>
1551
1552         Reviewed by Alexey Proskuryakov.
1553
1554         On-device testing requires that servers are started before ports set-up their
1555         test environments.
1556
1557         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1558         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
1559         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
1560         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1561         (Manager.__init__): Delay construction of the test runner until we can determine
1562         if servers need to be started.
1563         (Manager.run): Determine if servers need to be started and construct the test runner.
1564         (Manager._run_tests): Move the determination of servers to run into Manager.run.
1565
1566 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
1567
1568         Unreviewed, adding myself to contributors.json
1569
1570         * Scripts/webkitpy/common/config/contributors.json:
1571
1572 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
1573
1574         [GTK] Tests that always pass when run alone, but fail in the bots
1575         https://bugs.webkit.org/show_bug.cgi?id=168572
1576
1577         Reviewed by Michael Catanzaro.
1578
1579         PlatformWebView::viewSupportsOptions() is basically a comparison
1580         that checks that the passed options are the ones supported by the
1581         web view. There is no reason for them to be implemented for each
1582         platform differently. In fact doing so causes issues each time a
1583         new option is added, if the corresponding platform implementation
1584         is not updated accordingly.
1585
1586         A consequence of not updating the viewSupportOptions()
1587         implementations when new options are added is that tests that need
1588         these options might fail if they are executed after a test that
1589         didn't need the option, as the webview will be reused even if the
1590         option is not supported. This cannot be spotted when running the
1591         tests individually. See bug #165133 for other example of the same
1592         problem.
1593
1594         Remove the platform implementations and make the comparison a
1595         method of the TestOptions structure, so that the check is in one
1596         place. For the time being, only include in the comparison the
1597         options that were checked in the mac platform, which seem to be
1598         the only ones relevant this far (unless newer ones have also been
1599         forgotten).
1600
1601         * WebKitTestRunner/PlatformWebView.h:
1602         (WTR::PlatformWebView::viewSupportsOptions): Use the method
1603         defined below.
1604         * WebKitTestRunner/TestOptions.h:
1605         (WTR::TestOptions::hasSameInitializationOptions): Added.
1606         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1607         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1608         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1609         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1610         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1611         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1612         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
1613         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1614
1615 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
1616
1617         [JSC] Build testapi in non Apple ports
1618         https://bugs.webkit.org/show_bug.cgi?id=172103
1619
1620         Reviewed by Filip Pizlo.
1621
1622         Now testapi is drived in JSCOnly, GTK and WPE ports too.
1623
1624         * Scripts/build-jsc:
1625         * Scripts/run-javascriptcore-tests:
1626
1627 2017-05-15  Youenn Fablet  <youenn@apple.com>
1628
1629         WPT test importer should not account for slow manual tests
1630         https://bugs.webkit.org/show_bug.cgi?id=172127
1631
1632         Reviewed by Ryosuke Niwa.
1633
1634         Making sure manual tests are not triggering updating tests-options.json file.
1635
1636         * Scripts/webkitpy/w3c/test_importer.py:
1637         (TestImporter.find_importable_tests):
1638         (TestImporter._already_identified_as_resource_file):
1639         (TestImporter.update_tests_options):
1640         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1641         (test_manual_slow_test):
1642
1643 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
1644
1645         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
1646         https://bugs.webkit.org/show_bug.cgi?id=172142
1647
1648         Reviewed by Tim Horton.
1649
1650         * Scripts/webkitpy/xcode/simulator.py:
1651         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
1652         around runtime identifiers.
1653         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
1654
1655 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1656
1657         Update ARES-6 plan file to use the latest version
1658         https://bugs.webkit.org/show_bug.cgi?id=172139
1659
1660         Reviewed by Keith Miller.
1661
1662         Include r216538.
1663
1664         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1665
1666 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
1667
1668         Disable Picture In Picture API tests on unsupported platforms.
1669         https://bugs.webkit.org/show_bug.cgi?id=172125
1670         rdar://problem/32199477
1671
1672         Reviewed by Simon Fraser.
1673
1674         The callbacks and allowing picture-in-picture require new SPI.
1675
1676         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
1677
1678 2017-05-15  Brady Eidson  <beidson@apple.com>
1679
1680         [ios-simulator] API test WKWebView.ClearAppCache is failing.
1681         https://bugs.webkit.org/show_bug.cgi?id=172120
1682
1683         Unreviewed test gardening.
1684
1685         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1686         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
1687           Restoring that code fixes this.
1688
1689 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
1690
1691         Null deref under WebContentReader::readURL when interacting with a file URL
1692         https://bugs.webkit.org/show_bug.cgi?id=172045
1693         <rdar://problem/25880647>
1694
1695         Reviewed by Wenson Hsieh.
1696
1697         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1698         (TestWebKitAPI::TEST):
1699         The text of the file URL is pasted because a textual version of it gets
1700         onto the pasteboard. However, this test would have crashed before. Also
1701         tests that we don't make an <a>.
1702
1703 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
1704
1705         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
1706         https://bugs.webkit.org/show_bug.cgi?id=172071
1707
1708         Reviewed by Alexey Proskuryakov.
1709
1710         * DumpRenderTree/win/DumpRenderTree.cpp:
1711         (resetWebPreferencesToConsistentValues):
1712
1713 2017-05-14  Chris Dumez  <cdumez@apple.com>
1714
1715         Drop PassRefPtr class from WTF
1716         https://bugs.webkit.org/show_bug.cgi?id=172091
1717
1718         Reviewed by Alex Christensen.
1719
1720         Drop API test coverage.
1721
1722         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1723         (TestWebKitAPI::TEST):
1724         (TestWebKitAPI::passWithPassRefPtr): Deleted.
1725
1726 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
1727
1728         [MediaStream] deviceId constraint doesn't work with getUserMedia
1729         https://bugs.webkit.org/show_bug.cgi?id=171877
1730         <rdar://problem/31899730>
1731
1732         Reviewed by Jer Noble.
1733
1734         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
1735         implement the "checkUserMediaPermission" callback.
1736         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1737         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1738         (TestWebKitAPI::checkUserMediaPermissionCallback):
1739         (TestWebKitAPI::TEST):
1740
1741         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
1742         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1743
1744 2017-05-13  Chris Dumez  <cdumez@apple.com>
1745
1746         Stop using RefPtr::release()
1747         https://bugs.webkit.org/show_bug.cgi?id=172074
1748
1749         Reviewed by Geoffrey Garen.
1750
1751         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1752         (TestWebKitAPI::TEST):
1753
1754 2017-05-13  Commit Queue  <commit-queue@webkit.org>
1755
1756         Unreviewed, rolling out r216808.
1757         https://bugs.webkit.org/show_bug.cgi?id=172075
1758
1759         caused lldb to hang when debugging (Requested by smfr on
1760         #webkit).
1761
1762         Reverted changeset:
1763
1764         "Use Mach exceptions instead of signals where possible"
1765         https://bugs.webkit.org/show_bug.cgi?id=171865
1766         http://trac.webkit.org/changeset/216808
1767
1768 2017-05-12  Alex Christensen  <achristensen@webkit.org>
1769
1770         Rename WKContentExtension to WKContentRuleList
1771         https://bugs.webkit.org/show_bug.cgi?id=172053
1772         <rdar://problem/32141005>
1773
1774         Reviewed by Geoffrey Garen.
1775
1776         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
1777         (WKContentRuleListStoreTest::SetUp):
1778         (TEST_F):
1779         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1780         (WKContentExtensionStoreTest::SetUp): Deleted.
1781         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
1782
1783 2017-05-12  Keith Miller  <keith_miller@apple.com>
1784
1785         Use Mach exceptions instead of signals where possible
1786         https://bugs.webkit.org/show_bug.cgi?id=171865
1787
1788         Reviewed by Mark Lam.
1789
1790         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1791         (runThreadMessageTest):
1792         (TEST):
1793
1794 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
1795
1796         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
1797         https://bugs.webkit.org/show_bug.cgi?id=172048
1798         rdar://problem/32163054
1799
1800         Reviewed by Simon Fraser.
1801
1802         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
1803
1804         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
1805         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
1806         (hasVideoInPictureInPictureDidChange):
1807         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
1808         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
1809         (TestWebKitAPI::TEST):
1810
1811 2017-05-12  Brady Eidson  <beidson@apple.com>
1812
1813         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1814         https://bugs.webkit.org/show_bug.cgi?id=172030
1815
1816         Unreviewed - Test gardening
1817
1818         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
1819         before the test starts.
1820
1821         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1822         (defaultWebsiteCacheDirectory):
1823         (defaultApplicationCacheDirectory):
1824         (TEST):
1825         (defaultWebsiteDataDirectory): Deleted.
1826
1827 2017-05-12  David Quesada  <david_quesada@apple.com>
1828
1829         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
1830         https://bugs.webkit.org/show_bug.cgi?id=172000
1831         rdar://problem/32144756
1832
1833         Reviewed by Simon Fraser.
1834
1835         Added API tests to verify that WKWebView provides the expected value for
1836         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
1837         inside a scrollview but not clipped, clipped by an ancestor scrollview,
1838         clipped by the webview's _enclosingViewForExposedRectComputation)
1839
1840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1841         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
1842         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
1843         (TestWebKitAPI::TEST):
1844
1845 2017-05-12  Brady Eidson  <beidson@apple.com>
1846
1847         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1848         https://bugs.webkit.org/show_bug.cgi?id=172030
1849
1850         Unreviewed - Test gardening, in effect...
1851
1852         More exploration as to why this continues to fail on the bots.
1853         
1854         This change should give us a smoking gun.
1855         
1856         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1857         (TEST):
1858
1859 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1860
1861         [GTK] Fix compile warnings in PlatformImageCairo.cpp
1862         https://bugs.webkit.org/show_bug.cgi?id=171850
1863
1864         Reviewed by Michael Catanzaro.
1865
1866         * ImageDiff/cairo/PlatformImageCairo.cpp:
1867         (ImageDiff::PlatformImage::createFromStdin):
1868         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1869
1870 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
1871
1872         Add UIClient callback for when picture-in-picture is activated.
1873         https://bugs.webkit.org/show_bug.cgi?id=172023
1874
1875         Reviewed by Simon Fraser.
1876
1877         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
1878
1879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1880         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
1881         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
1882         (onLoadedCompletedCallback):
1883         (waitUntilOnLoadIsCompleted):
1884         (didFinishLoadForFrame):
1885         (setHasVideoInPictureInPicture):
1886         (TestWebKitAPI::TEST):
1887
1888 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
1889
1890         Unreviewed follow-up to r216776.
1891
1892         * Scripts/webkitpy/port/base.py:
1893         (Port.path_to_crash_logs): Raise not implemented.
1894         * Scripts/webkitpy/port/test.py:
1895         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
1896         * Scripts/webkitpy/port/win.py:
1897         (WinPort.path_to_crash_logs): Ditto.
1898
1899 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
1900
1901         Bot watcher's dashboard shows results links twice sometimes
1902         https://bugs.webkit.org/show_bug.cgi?id=172043
1903
1904         Reviewed by Tim Horton.
1905
1906         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1907         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1908
1909 2017-05-12  Brady Eidson  <beidson@apple.com>
1910
1911         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1912         https://bugs.webkit.org/show_bug.cgi?id=172030
1913
1914         Unreviewed - Test gardening, in effect...
1915
1916         This failure is only being seen by the bots.
1917         
1918         I believe this test is utterly broken in the first place; when it checks the .wal file's
1919         size that is not actually an indicator that the records were deleted.
1920         
1921         But that isn't what's coming up as failure on the bots.
1922         
1923         This patch is an attempt to:
1924         1 - More forcefully clear the Website data directory of leftovers before the test starts.
1925         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
1926
1927         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1928         (defaultWebsiteDataDirectory):
1929         (defaultApplicationCacheDirectory):
1930         (TEST):
1931
1932 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
1933
1934         webkitpy: Pass directory with crash logs into CrashLogs
1935         https://bugs.webkit.org/show_bug.cgi?id=172033
1936         <rdar://problem/32157616>
1937
1938         Reviewed by Daniel Bates.
1939
1940         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
1941         the location of crash logs.
1942
1943         * Scripts/webkitpy/common/system/crashlogs.py:
1944         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
1945         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
1946         generating one.
1947         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
1948         self._results_directory.
1949         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
1950         generating one.
1951         (CrashLogs._log_directory_darwin): Moved to port.
1952         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
1953         to the crash log is no longer owned by CrashLogs.
1954         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
1955         directory for uploading crash logs. Note that crash logs are only supported on Mac
1956         and Windows.
1957         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
1958         * Scripts/webkitpy/port/base.py:
1959         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
1960         to be in the results directory.
1961         * Scripts/webkitpy/port/darwin.py:
1962         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
1963         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
1964         (DarwinPort._get_crash_log): Ditto.
1965         * Scripts/webkitpy/port/darwin_testcase.py:
1966         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
1967         the path to crash logs.
1968         * Scripts/webkitpy/port/ios_device.py:
1969         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
1970         * Scripts/webkitpy/port/ios_device_unittest.py:
1971         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
1972         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
1973         * Scripts/webkitpy/port/mac.py: Ditto.
1974         * Scripts/webkitpy/port/test.py:
1975         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
1976         * Scripts/webkitpy/port/win.py:
1977         (WinPort._get_crash_log): Ditto.
1978         * Scripts/webkitpy/tool/commands/queries.py:
1979         (execute): Construct a port object since this is the object which owns the path to crash logs.
1980
1981 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1982
1983         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
1984
1985         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
1986         URL parameter using the default value "about:blank" when not provided.
1987
1988         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1989         (testWebViewCreateNavigationData):
1990
1991 2017-05-11  Youenn Fablet  <youenn@apple.com>
1992
1993         Allow WPT server to serve specific WebKit test
1994         https://bugs.webkit.org/show_bug.cgi?id=171479
1995
1996         Reviewed by Ryosuke Niwa.
1997
1998         Adding a new mount point to WPT server.
1999         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
2000
2001         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
2002
2003         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2004         (Manager.__init__):
2005         (Manager._is_http_test):
2006         (Manager._needs_web_platform_test):
2007         (Manager._run_tests):
2008         (Manager._is_web_platform_test): Deleted.
2009         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2010         (build_routes):
2011         (main):
2012         * Scripts/webkitpy/port/driver.py:
2013         (Driver):
2014         (Driver.is_webkit_specific_web_platform_test):
2015         (Driver.test_to_uri):
2016         (Driver._command_from_driver_input):
2017
2018 2017-05-11  Brady Eidson  <beidson@apple.com>
2019
2020         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
2021         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
2022
2023         Reviewed by Andy Estes.
2024         Informal review by Maureen Daum.
2025
2026         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2027         (TEST):
2028
2029 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
2030
2031         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
2032         https://bugs.webkit.org/show_bug.cgi?id=171989
2033
2034         Reviewed by Brian Burg.
2035
2036         * lldb/lldb_webkit.py:
2037         (WTFStringImplProvider.get_data8):
2038         (WTFStringImplProvider.get_data16):
2039         m_data8 and m_data16 are now part of the superclass StringImplShape
2040         instead of directly in StringImpl. So first get the shape by getting
2041         index 0, and the data properties are the same offset within that.
2042
2043 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
2044
2045         Remove Vibration API
2046         https://bugs.webkit.org/show_bug.cgi?id=171766
2047
2048         Rubber-stamped by Alexey Proskuryakov.
2049
2050         * Scripts/webkitperl/FeatureList.pm:
2051
2052 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2053
2054         Add WPE release bots
2055         https://bugs.webkit.org/show_bug.cgi?id=171973
2056
2057         Reviewed by Žan Doberšek.
2058
2059         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
2060         It also adds a new WPE buildbot category.
2061
2062         * BuildSlaveSupport/build.webkit.org-config/config.json:
2063         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2064         (InstallWpeDependencies):
2065         (appendCustomBuildFlags):
2066         (Factory.__init__):
2067         (loadBuilderConfig):
2068         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2069         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2070
2071 2017-05-09  Sam Weinig  <sam@webkit.org>
2072
2073         Remove support for legacy Notifications
2074         https://bugs.webkit.org/show_bug.cgi?id=171487
2075
2076         Reviewed by Jon Lee.
2077
2078         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2079         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2080         * Scripts/webkitperl/FeatureList.pm:
2081         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2082         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
2083
2084 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2085
2086         Remove user agent quirk for Slack
2087         https://bugs.webkit.org/show_bug.cgi?id=171869
2088
2089         Reviewed by Carlos Garcia Campos.
2090
2091         Remove the corresponding test.
2092
2093         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2094         (TestWebKitAPI::TEST):
2095
2096 2017-05-10  Commit Queue  <commit-queue@webkit.org>
2097
2098         Unreviewed, rolling out r216578.
2099         https://bugs.webkit.org/show_bug.cgi?id=171920
2100
2101         Broke the GTK+ build with Wayland enabled (Requested by KaL on
2102         #webkit).
2103
2104         Reverted changeset:
2105
2106         "[GTK] Bump GTK+ and its dependencies in jhbuild"
2107         https://bugs.webkit.org/show_bug.cgi?id=171918
2108         http://trac.webkit.org/changeset/216578
2109
2110 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2111
2112         [GTK] Bump GTK+ and its dependencies in jhbuild
2113         https://bugs.webkit.org/show_bug.cgi?id=171918
2114
2115         Reviewed by Carlos Alberto Lopez Perez.
2116
2117         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2118         (WTR::initializeGtkSettings):
2119         * gtk/jhbuild.modules:
2120         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2121         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2122
2123 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
2124
2125         [Win] Set CMake args in build-webkit
2126         https://bugs.webkit.org/show_bug.cgi?id=171436
2127
2128         Reviewed by Per Arne Vollan.
2129
2130         * Scripts/build-webkit:
2131
2132 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2133
2134         ImageDiff: Add CG implementation for new ImageDiff
2135         https://bugs.webkit.org/show_bug.cgi?id=170608
2136
2137         Reviewed Alex Christensen.
2138
2139         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2140         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
2141         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
2142         * ImageDiff/CMakeLists.txt:
2143         * ImageDiff/Cairo.cmake:
2144         * ImageDiff/ImageDiff.cpp:
2145         (main):
2146         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2147         * ImageDiff/PlatformImage.cpp:
2148         * ImageDiff/PlatformImage.h:
2149         * ImageDiff/cairo/PlatformImageCairo.cpp:
2150         * ImageDiff/cg/ImageDiff.cpp: Removed.
2151         * ImageDiff/cg/PlatformImageCG.cpp: Added.
2152         (ImageDiff::PlatformImage::createFromStdin):
2153         (ImageDiff::PlatformImage::createFromDiffData):
2154         (ImageDiff::PlatformImage::PlatformImage):
2155         (ImageDiff::PlatformImage::~PlatformImage):
2156         (ImageDiff::PlatformImage::width):
2157         (ImageDiff::PlatformImage::height):
2158         (ImageDiff::PlatformImage::rowBytes):
2159         (ImageDiff::PlatformImage::hasAlpha):
2160         (ImageDiff::PlatformImage::pixels):
2161         (ImageDiff::PlatformImage::writeAsPNGToStdout):
2162
2163 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
2164
2165         Enable FTL JIT by default on AArch64
2166         https://bugs.webkit.org/show_bug.cgi?id=144039
2167
2168         Reviewed by Yusuke Suzuki.
2169
2170         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
2171         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
2172         as an unsupported FTL platform.
2173         * Scripts/webkitdirs.pm:
2174         (isARM64): Returns 1 if the determined architecture is 'arm64'.
2175         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
2176
2177 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2178
2179         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
2180         https://bugs.webkit.org/show_bug.cgi?id=170857
2181         <rdar://problem/31635373>
2182
2183         Reviewed by Aakash Jain.
2184
2185         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
2186         code to search for crash logs.
2187
2188         * Scripts/webkitpy/port/darwin.py:
2189         (DarwinPort._get_crash_log): Moved from MacPort.
2190         * Scripts/webkitpy/port/darwin_testcase.py:
2191         (DarwinTest.test_get_crash_log): Moved from MacTest.
2192         * Scripts/webkitpy/port/ios_device.py:
2193         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
2194         devices must search for crash-logs remotely.
2195         * Scripts/webkitpy/port/ios_simulator.py:
2196         (IOSSimulatorPort._get_crash_log): Deleted.
2197         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2198         (IOSSimulatorTest.test_get_crash_log): Deleted.
2199         * Scripts/webkitpy/port/mac.py:
2200         (MacPort._get_crash_log): Moved to DarwinPort
2201         * Scripts/webkitpy/port/mac_unittest.py:
2202         (MacTest.test_get_crash_log): Moved to DarwinTest.
2203
2204 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2205
2206         build ImageDiff with host SDK from Make
2207         https://bugs.webkit.org/show_bug.cgi?id=171835
2208
2209         Reviewed by Alexey Proskuryakov.
2210
2211         ImageDiff should be built for the default SDK and default architecture when
2212         the SDKROOT is set to either iOS device or iOS simulator. Check the
2213         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
2214
2215         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
2216         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
2217
2218 2017-05-09  Matt Lewis  <jlewis3@apple.com>
2219
2220         Unreviewed, adding myself to contributors.json
2221
2222         * Scripts/webkitpy/common/config/contributors.json:
2223
2224 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2225
2226         REGRESSION: ImageDiff not building with make
2227         https://bugs.webkit.org/show_bug.cgi?id=171788
2228
2229         Reviewed by Alex Christensen.
2230
2231         * Makefile: Build ImageDiff for all platforms.
2232
2233 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2234
2235         [Win] ImageDiff isn't built since Bug 168945
2236         https://bugs.webkit.org/show_bug.cgi?id=171847
2237
2238         Reviewed by Alex Christensen.
2239
2240         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
2241         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
2242         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
2243
2244 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
2245
2246         Upstream the WPE port
2247         https://bugs.webkit.org/show_bug.cgi?id=171110
2248
2249         Reviewed by Alex Christensen.
2250
2251         webkit-dev thread:
2252         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
2253
2254         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
2255         In-file changes removed from this ChangeLog entry for brevity.
2256
2257         * BuildSlaveSupport/built-product-archive:
2258         * BuildSlaveSupport/test-result-archive:
2259         * CMakeLists.txt:
2260         * ImageDiff/PlatformWPE.cmake: Added.
2261         * Scripts/build-dumprendertree:
2262         * Scripts/build-webkit:
2263         * Scripts/build-webkittestrunner:
2264         * Scripts/update-webkit-libs-jhbuild:
2265         * Scripts/update-webkitwpe-libs: Added.
2266         * Scripts/webkitdirs.pm:
2267         * Scripts/webkitperl/FeatureList.pm:
2268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2269         * Scripts/webkitpy/port/factory.py:
2270         * Scripts/webkitpy/port/wpe.py: Added.
2271         * TestWebKitAPI/PlatformWPE.cmake: Added.
2272         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2273         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
2274         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2275         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2276         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2277         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2278         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2279         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2280         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2281         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
2282         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
2283         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
2284         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2285         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2286         * WebKitTestRunner/PlatformWPE.cmake: Added.
2287         * WebKitTestRunner/PlatformWebView.h:
2288         * WebKitTestRunner/TestController.cpp:
2289         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
2290         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
2291         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
2292         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
2293         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
2294         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2295         * jhbuild/jhbuild-wrapper:
2296         * wpe/generate-inspector-gresource-manifest.py: Added.
2297         * wpe/jhbuild.modules: Added.
2298         * wpe/jhbuildrc: Added.
2299         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
2300         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2301         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
2302         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
2303         * wpe/patches/glib-warning-fix.patch: Added.
2304         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
2305         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
2306         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2307         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2308         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
2309
2310 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
2311
2312         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
2313         https://bugs.webkit.org/show_bug.cgi?id=169421
2314         <rdar://problem/30950171>
2315
2316         Reviewed by Tim Horton.
2317
2318         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2319         (createBitmapContextFromWebView): Implement for IOSurface.
2320         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2321         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
2322
2323 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
2324
2325         buildbot: Cleanup simulators after running tests
2326         https://bugs.webkit.org/show_bug.cgi?id=171679
2327
2328         Reviewed by Aakash Jain.
2329
2330         simctl is partitioned for each user. Since kill-old-processes
2331         is run as root, we need to specify the buildbot user when tearing
2332         down simulators between steps.
2333
2334         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2335         (KillOldProcesses): Pass buildbot user to kill-old-processes.
2336         * BuildSlaveSupport/kill-old-processes:
2337         (main): Specify the user for simctl if one has been provided.
2338
2339 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2340
2341         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
2342         https://bugs.webkit.org/show_bug.cgi?id=171681
2343
2344         Reviewed by Carlos Garcia Campos.
2345
2346         * gtk/install-dependencies:
2347
2348 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2349
2350         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
2351
2352         Glib uses now Unicode quotes in error messages.
2353
2354         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2355         (testWebKitConsoleMessageNetworkError):
2356
2357 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2358
2359         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
2360
2361         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
2362         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
2363         characters to the input. Also fix typo in the function name.
2364
2365         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2366         (testWebViewJavaScriptDialogs):
2367
2368 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2369
2370         [GTK] Cannot sign in with new Google sign-in page
2371         https://bugs.webkit.org/show_bug.cgi?id=171770
2372
2373         Unreviewed. This just adds a test.
2374
2375         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2376         (TestWebKitAPI::TEST):
2377
2378 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
2379
2380         [iOS WK2] Make rotation tests more reliable
2381         https://bugs.webkit.org/show_bug.cgi?id=171778
2382
2383         Reviewed by Tim Horton.
2384
2385         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
2386         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
2387         with override layout parameters, and an override orientation, and these caused viewport
2388         size to leak into later tests, and WebCore orientation to not get reset correctly.
2389
2390         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
2391         an override orientation was set, and would never re-register, causing lost orientationchanged
2392         events.
2393
2394         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
2395         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
2396
2397         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
2398         the WebProcess is caught up before proceeding with the test.
2399
2400         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2401         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
2402         * WebKitTestRunner/ios/TestControllerIOS.mm:
2403         (WTR::TestController::platformResetStateToConsistentValues):
2404         (WTR::TestController::platformConfigureViewForTest):
2405
2406 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
2407
2408         [Mac][cmake] Buildfix after r216047
2409         https://bugs.webkit.org/show_bug.cgi?id=171769
2410
2411         Unreviewed buildfix.
2412
2413         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2414
2415 2017-05-05  Brady Eidson  <beidson@apple.com>
2416
2417         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
2418         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
2419
2420         Reviewed by Andy Estes.
2421
2422         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2423         (TEST):
2424
2425 2017-05-05  Brian Burg  <bburg@apple.com>
2426
2427         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
2428         https://bugs.webkit.org/show_bug.cgi?id=171748
2429         <rdar://problem/32027327>
2430
2431         Reviewed by Michael Catanzaro.
2432
2433         Remove temporary workaround now that the assertion failure is fixed.
2434
2435         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2436         (TEST):
2437
2438 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
2439
2440         Make it possible to test rotation in iOS WebKitTestRunner
2441         https://bugs.webkit.org/show_bug.cgi?id=171755
2442
2443         Reviewed by Tim Horton.
2444
2445         Add to UIScriptController:
2446             void simulateRotation(DeviceOrientation orientation, object callback);
2447             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
2448
2449         The former just does a view resize, as a simple WKWebView app would do. The second does
2450         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
2451         layout size and interface orientation. The two behaviors produce different resize and
2452         orientationchange events and sizes, and both need to be tested.
2453
2454         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
2455         which is now a custom subclass (PlatformWebViewController).
2456
2457         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2458         (WTR::UIScriptController::simulateRotation):
2459         (WTR::UIScriptController::simulateRotationLikeSafari):
2460         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2461         (WTR::UIScriptController::simulateRotation):
2462         (WTR::UIScriptController::simulateRotationLikeSafari):
2463         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2464         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2465         (WTR::toDeviceOrientation):
2466         (WTR::UIScriptController::simulateRotation):
2467         (WTR::UIScriptController::simulateRotationLikeSafari):
2468         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2469         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2470         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2471         (-[TestRunnerWKWebView dealloc]):
2472         (-[TestRunnerWKWebView _didEndRotation]):
2473         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2474         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
2475         (WTR::PlatformWebView::PlatformWebView):
2476         * WebKitTestRunner/ios/TestControllerIOS.mm:
2477         (WTR::TestController::platformResetStateToConsistentValues):
2478         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2479         (WTR::toUIDeviceOrientation):
2480         (WTR::UIScriptController::simulateRotation):
2481         (WTR::UIScriptController::simulateRotationLikeSafari):
2482         (WTR::UIScriptController::platformClearAllCallbacks):
2483         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2484         (WTR::UIScriptController::simulateRotation):
2485         (WTR::UIScriptController::simulateRotationLikeSafari):
2486
2487 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2488
2489         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
2490         https://bugs.webkit.org/show_bug.cgi?id=168945
2491         <rdar://problem/30745695>
2492
2493         Reviewed by David Kilzer.
2494
2495         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
2496         target SDK. These two changes must happen simultaneously because some archives will
2497         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
2498
2499         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
2500         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
2501         tools directory still includes ImageDiff.
2502         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
2503         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
2504         * Scripts/webkitpy/port/darwin.py: 
2505         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
2506         locally or when running archives.
2507         * Scripts/webkitpy/port/image_diff.py:
2508         (IOSSimulatorImageDiffer): Deleted.
2509         * Scripts/webkitpy/port/ios_simulator.py:
2510         (IOSSimulatorPort.diff_image): Deleted.
2511
2512 2017-05-05  Brian Burg  <bburg@apple.com>
2513
2514         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
2515         https://bugs.webkit.org/show_bug.cgi?id=171748
2516
2517         Unreviewed test gardening.
2518
2519         The assertion failure will be investigated separately in order to avoid rolling out
2520         the fix for "secure" cookies. This assertion fails even without r216258 applied.
2521
2522         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2523         (TEST):
2524
2525 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2526
2527         Unreviewed, rolling out r216260.
2528
2529         Breaks internal iOS testers
2530
2531         Reverted changeset:
2532
2533         "Use ImageDiff built by host SDK and remove ImageDiff from
2534         DumpRenderTree"
2535         https://bugs.webkit.org/show_bug.cgi?id=168945
2536         http://trac.webkit.org/changeset/216260
2537
2538 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2539
2540         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
2541         https://bugs.webkit.org/show_bug.cgi?id=168945
2542         <rdar://problem/30745695>
2543
2544         Reviewed by David Kilzer.
2545
2546         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
2547         target SDK. These two changes must happen simultaneously because some archives will
2548         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
2549
2550         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
2551         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
2552         tools directory still includes ImageDiff.
2553         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
2554         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
2555         * Scripts/webkitpy/port/darwin.py: 
2556         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
2557         locally or when running archives.
2558         * Scripts/webkitpy/port/image_diff.py:
2559         (IOSSimulatorImageDiffer): Deleted.
2560         * Scripts/webkitpy/port/ios_simulator.py:
2561         (IOSSimulatorPort.diff_image): Deleted.
2562
2563 2017-05-05  Brian Burg  <bburg@apple.com>
2564
2565         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
2566         https://bugs.webkit.org/show_bug.cgi?id=171700
2567         <rdar://problem/32017975>
2568
2569         Reviewed by Brady Eidson.
2570
2571         Fix a mistake in the test that should have caught this bug.
2572
2573         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2574         (TEST):
2575         The assertions that were meant to check round-tripping were actually checking
2576         the properties of the original cookie objects, not the round-tripped ones.
2577         This test now fails without the bugfix and passes when it is applied.
2578
2579 2017-05-05  Daniel Bates  <dabates@apple.com>
2580
2581         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
2582         https://bugs.webkit.org/show_bug.cgi?id=171698
2583
2584         Reviewed by Darin Adler.
2585
2586         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
2587         so that we get pretty diff output when the actual string differs from the expected
2588         string as opposed to seeing a boolean result. The former makes makes it straightforward
2589         to diagnose a regression without reading the code for the test or instrumenting it to
2590         determine the actual string that was compared.
2591
2592         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
2595         (TestWebKitAPI::TEST_F):
2596         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
2597         (TestWebKitAPI::TEST_F):
2598
2599 2017-05-05  Chris Dumez  <cdumez@apple.com>
2600
2601         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
2602         https://bugs.webkit.org/show_bug.cgi?id=171624
2603
2604         Reviewed by Dan Bernstein.
2605
2606         Extend API test coverage to cover crashes in addition to terminations requested by the client.
2607
2608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2609         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
2610         (TestWebKitAPI::webProcessWasTerminatedByClient):
2611         (TestWebKitAPI::webProcessCrashed):
2612         (TestWebKitAPI::TEST):
2613
2614 2017-05-04  Mark Lam  <mark.lam@apple.com>
2615
2616         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
2617         https://bugs.webkit.org/show_bug.cgi?id=171716
2618         <rdar://problem/30878027>
2619
2620         Reviewed by Saam Barati.
2621
2622         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
2623         does JS conversion and therefore, potentially JS allocations) and accessing
2624         methods of internal JS data structures (which may do JS invocation, etc).
2625
2626         * DumpRenderTree/TestRunner.cpp:
2627         (setAudioResultCallback):
2628
2629 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2630
2631         buildbot: Cleanup simulators after running tests
2632         https://bugs.webkit.org/show_bug.cgi?id=171679
2633         <rdar://problem/31994361>
2634
2635         Reviewed by Aakash Jain.
2636
2637         We shutdown the simulator process between tests, but in some cases, this is not
2638         sufficient. Explicitly shutdown every booted simulator.
2639
2640         * BuildSlaveSupport/kill-old-processes:
2641         (main): Shutdown all booted simulators.
2642
2643 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2644
2645         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
2646         https://bugs.webkit.org/show_bug.cgi?id=171644
2647
2648         Reviewed by Michael Catanzaro.
2649
2650         Check that only one WebKitWebContext can have automation enabled.
2651
2652         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2653         (testAutomationSessionRequestSession):
2654
2655 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2656
2657         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
2658         https://bugs.webkit.org/show_bug.cgi?id=171724
2659
2660         Reviewed by Michael Catanzaro.
2661
2662         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
2663
2664         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2665         (WTR::timeoutSource):
2666
2667 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2668
2669         Unreviewed. Fix wrong assert after r215176.
2670
2671         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
2672         could also be RGB24 when created from a web view snapshot.
2673
2674         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2675         (WTR::computeMD5HashStringForCairoSurface):
2676
2677 2017-05-04  Brian Burg  <bburg@apple.com>
2678
2679         lldb_webkit.py should provide a type summary for WebCore::URL
2680         https://bugs.webkit.org/show_bug.cgi?id=171670
2681
2682         Reviewed by Jer Noble.
2683
2684         Just print out the underlying string using the WTFString provider.
2685
2686         * lldb/lldb_webkit.py:
2687         (__lldb_init_module):
2688         (WebCoreURL_SummaryProvider):
2689         (WebCoreURLProvider):
2690         (WebCoreURLProvider.__init__):
2691         (WebCoreURLProvider.to_string):
2692
2693 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2694
2695         Unreviewed, rolling out r216206.
2696         https://bugs.webkit.org/show_bug.cgi?id=171714
2697
2698         Multiple LayoutTests crashing in Document::page() (Requested
2699         by ap on #webkit).
2700
2701         Reverted changeset:
2702
2703         "Remove support for legacy Notifications"
2704         https://bugs.webkit.org/show_bug.cgi?id=171487
2705         http://trac.webkit.org/changeset/216206
2706
2707 2017-05-04  Mark Lam  <mark.lam@apple.com>
2708
2709         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
2710         https://bugs.webkit.org/show_bug.cgi?id=171702
2711
2712         Reviewed by Filip Pizlo.
2713
2714         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
2715         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
2716         confirm that the test will detect a regression.  Unfortunately, I forgot to
2717         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
2718         This patch fixes that.
2719
2720         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2721         (TestWebKitAPI::neverDestroyedString):
2722
2723 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
2724
2725         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
2726         https://bugs.webkit.org/show_bug.cgi?id=170195
2727
2728         Unreviewed test gardening.
2729
2730         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2731         (TEST):
2732
2733 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
2734
2735         [Win] Remove redundant macros that are set in the CMake config
2736         https://bugs.webkit.org/show_bug.cgi?id=171571
2737
2738         Reviewed by Brent Fulgham.
2739
2740         * DumpRenderTree/config.h:
2741         * MiniBrowser/win/stdafx.h:
2742         * TestWebKitAPI/config.h:
2743
2744 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2745
2746         Add testRunner.display() to force displaying the web page for testing
2747         https://bugs.webkit.org/show_bug.cgi?id=171694
2748
2749         Reviewed by Simon Fraser.
2750
2751         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
2752         drawing the web page but without track repaints.
2753
2754         * DumpRenderTree/TestRunner.cpp:
2755         (displayCallback):
2756         (TestRunner::staticFunctions):
2757         * DumpRenderTree/TestRunner.h:
2758         * DumpRenderTree/mac/TestRunnerMac.mm:
2759         (TestRunner::display):
2760         * DumpRenderTree/win/TestRunnerWin.cpp:
2761         (TestRunner::display):
2762         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2763         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2764         (WTR::TestRunner::display):
2765         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2766
2767 2017-05-04  Mark Lam  <mark.lam@apple.com>
2768
2769         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
2770         https://bugs.webkit.org/show_bug.cgi?id=171586
2771         <rdar://problem/31873190>
2772
2773         Reviewed by Yusuke Suzuki.
2774
2775         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
2776
2777         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2778         (TestWebKitAPI::neverDestroyedString):
2779         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
2780         (TestWebKitAPI::TEST):
2781
2782 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2783
2784         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
2785         https://bugs.webkit.org/show_bug.cgi?id=171585
2786         <rdar://problem/31544320>
2787
2788         Reviewed by Beth Dakin and Zalan Bujtas.
2789
2790         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
2791         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
2792         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
2793         operation rather than a copy.
2794
2795         See WebCore ChangeLog for more details.
2796
2797         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
2798                 DataInteractionSimulator.ContentEditableToTextarea
2799                 DataInteractionSimulator.ContentEditableMoveParagraphs
2800                 DataInteractionSimulator.TextAreaToInput
2801
2802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2803         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
2804         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2805         (TestWebKitAPI::TEST):
2806         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2807         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2808         (-[DataInteractionSimulator initWithWebView:]):
2809         (-[DataInteractionSimulator dealloc]):
2810         (-[DataInteractionSimulator _advanceProgress]):
2811         (-[DataInteractionSimulator waitForInputSession]):
2812         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
2813         (-[DataInteractionSimulator _webView:didStartInputSession:]):
2814
2815 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2816
2817         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
2818         https://bugs.webkit.org/show_bug.cgi?id=171641
2819
2820         Reviewed by Simon Fraser.
2821
2822         The plan is to add back the TestRunner.display() which does the display
2823         only without track repaints.
2824
2825         * DumpRenderTree/DumpRenderTree.h:
2826         * DumpRenderTree/TestRunner.cpp:
2827         (displayAndTrackRepaintsCallback):
2828         (TestRunner::staticFunctions):
2829         (displayCallback): Deleted.
2830         (displayInvalidatedRegionCallback): Deleted.
2831         * DumpRenderTree/TestRunner.h:
2832         * DumpRenderTree/mac/DumpRenderTree.mm:
2833         (displayWebView):
2834         (displayAndTrackRepaintsWebView):
2835         * DumpRenderTree/mac/TestRunnerMac.mm:
2836         (TestRunner::displayAndTrackRepaints):
2837         (TestRunner::display): Deleted.
2838         * DumpRenderTree/win/TestRunnerWin.cpp:
2839         (TestRunner::displayAndTrackRepaints):
2840         (TestRunner::display): Deleted.
2841         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2842         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2843         (WTR::TestRunner::displayAndTrackRepaints):
2844         (WTR::TestRunner::display): Deleted.
2845         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2846
2847 2017-05-04  Brady Eidson  <beidson@apple.com>
2848
2849         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
2850         https://bugs.webkit.org/show_bug.cgi?id=171513
2851
2852         Unreviewed gardening.
2853
2854         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2855         (TEST): Skip the failing parts of the test on iOS for now.
2856
2857 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
2858
2859         Make ImageDiff stand-alone
2860         https://bugs.webkit.org/show_bug.cgi?id=168939
2861
2862         Reviewed by David Kilzer.
2863
2864         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
2865         stand-alone project. Note that this change does not eliminate the ImageDiff inside
2866         the DumpRenderTree project.
2867
2868         * ImageDiff/ImageDiff.xcodeproj: Added.
2869         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
2870         * ImageDiff/Makefile: Use ImageDiff project.
2871         * ImageDiff/PlatformMac.cmake: Added.
2872         * ImageDiff/PlatformWin.cmake: Added.
2873         * ImageDiff/cg: Added.
2874         * ImageDiff/cg/Configurations: Added.
2875         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
2876         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
2877         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
2878         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
2879         (createImageFromStdin): Stop using RetainPtr.
2880         (createDifferenceImage): Ditto.
2881         (main): Ditto.
2882         * Scripts/build-imagediff: Stop building WTF and bmalloc.
2883
2884 2017-05-04  Sam Weinig  <sam@webkit.org>
2885
2886         Remove support for legacy Notifications
2887         https://bugs.webkit.org/show_bug.cgi?id=171487
2888
2889         Reviewed by Jon Lee.
2890
2891         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2892         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2893         * Scripts/webkitperl/FeatureList.pm:
2894         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2895         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
2896
2897 2017-05-04  Andy Estes  <aestes@apple.com>
2898
2899         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
2900         https://bugs.webkit.org/show_bug.cgi?id=171673
2901
2902         Reviewed by Dan Bernstein.
2903
2904         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2905         (TEST):
2906         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2907         (TEST):
2908         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2909         (TEST):
2910         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2911         (TEST):
2912         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
2913         (TEST):
2914         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2915         (configurationWithContentFilterSettings):
2916         (-[LazilyLoadPlatformFrameworksController init]):
2917         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2918         (TEST):
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
2920         (runTestWithWidth):
2921         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
2922         (TEST):
2923         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2924         (TestWebKitAPI::TEST):
2925         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2926         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2927         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
2928         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
2929         +_test_configurationWithTestPlugInClassName:
2930
2931 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
2932
2933         [MediaStream] Allow host application to enable/disable media capture
2934         https://bugs.webkit.org/show_bug.cgi?id=171292
2935         <rdar://problem/31821492>
2936
2937         Reviewed by Jer Noble.
2938
2939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2940         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2941         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2942         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2943         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2944         (MediaCaptureDisabledTest::SetUp):
2945         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2946         (TEST_F):
2947         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2948
2949 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
2950
2951         Unreviewed, Adding self to contributors.json
2952
2953         * Scripts/webkitpy/common/config/contributors.json: Added name.
2954
2955 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
2956
2957         Fix compilation with ICU 59.1
2958         https://bugs.webkit.org/show_bug.cgi?id=171612
2959
2960         Reviewed by Mark Lam.
2961
2962         ICU 59.1 has broken source compatibility. Now it defines UChar as
2963         char16_t, which does not allow automatic type conversion from unsigned
2964         short in C++ code.
2965
2966         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2967         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
2968
2969 2017-05-04  Andy Estes  <aestes@apple.com>
2970
2971         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
2972         https://bugs.webkit.org/show_bug.cgi?id=171646
2973         <rdar://problem/30306321>
2974
2975         Reviewed by Tim Horton.
2976
2977         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
2978         (runTestWithWidth):
2979         (TEST):
2980         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
2981         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
2982         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2983         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
2984         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2985         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
2986
2987 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
2988
2989         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
2990         https://bugs.webkit.org/show_bug.cgi?id=171649
2991
2992         Reviewed by Carlos Garcia Campos.
2993
2994         Add two patches picked from the upstream repository to fix building of
2995         the Fontconfig module in JHBuild. Additionally, this needed a patch to
2996         add "autogen.sh" as it is not included in release tarballs. Also:
2997         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
2998         being regenerated (which is needed) so this is disabled for the
2999         Fontconfig module.
3000
3001         * gtk/jhbuild.modules:
3002         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
3003         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
3004         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
3005
3006 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3007
3008         Unreviewed, rolling out r216172.
3009         https://bugs.webkit.org/show_bug.cgi?id=171654
3010
3011         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
3012         implementation. (Requested by ddkilzer on #webkit).
3013
3014         Reverted changeset:
3015
3016         "[MediaStream] Allow host application to enable/disable media
3017         capture"
3018         https://bugs.webkit.org/show_bug.cgi?id=171292
3019         http://trac.webkit.org/changeset/216172
3020
3021 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3022
3023         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
3024         https://bugs.webkit.org/show_bug.cgi?id=171595
3025
3026         Reviewed by Xabier Rodriguez-Calvar.
3027
3028         * gtk/jhbuild.modules:
3029         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3030         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3031         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
3032         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
3033         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
3034         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3035         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3036
3037 2017-05-03  Saam Barati  <sbarati@apple.com>
3038
3039         How we build polymorphic cases is wrong when making a call from Wasm
3040         https://bugs.webkit.org/show_bug.cgi?id=171527
3041
3042         Reviewed by JF Bastien.
3043
3044         * Scripts/run-jsc-stress-tests:
3045
3046 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
3047
3048         [MediaStream] Allow host application to enable/disable media capture
3049         https://bugs.webkit.org/show_bug.cgi?id=171292
3050         <rdar://problem/31821492>
3051
3052         Reviewed by Jer Noble.
3053
3054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3055         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
3056         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
3057         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3058         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3059         (MediaCaptureDisabledTest::SetUp):
3060         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3061         (TEST_F):
3062         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
3063
3064 2017-05-03  John Wilander  <wilander@apple.com>
3065
3066         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
3067         https://bugs.webkit.org/show_bug.cgi?id=171584
3068         <rdar://problem/24702576>
3069
3070         Reviewed by Brent Fulgham.
3071
3072         New function to call the clear function that takes a modifiedSince parameter.
3073
3074         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3075         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3076         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3077         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3078         * WebKitTestRunner/TestController.cpp:
3079         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3080         * WebKitTestRunner/TestController.h:
3081         * WebKitTestRunner/TestInvocation.cpp:
3082         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3083
3084 2017-05-03  Commit Queue  <commit-queue@webkit.org>
3085
3086         Unreviewed, rolling out r216160 and r216161.
3087         https://bugs.webkit.org/show_bug.cgi?id=171640
3088
3089         These changes broke the iOS build. (Requested by mlewis13 on
3090         #webkit).
3091
3092         Reverted changesets:
3093
3094         "[MediaStream] Allow host application to enable/disable media
3095         capture"
3096         https://bugs.webkit.org/show_bug.cgi?id=171292
3097         http://trac.webkit.org/changeset/216160
3098
3099         "[MediaStream] Allow host application to enable/disable media
3100         capture"
3101         https://bugs.webkit.org/show_bug.cgi?id=171292
3102         http://trac.webkit.org/changeset/216161
3103
3104 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
3105
3106         [MediaStream] Allow host application to enable/disable media capture
3107         https://bugs.webkit.org/show_bug.cgi?id=171292
3108         <rdar://problem/31821492>
3109
3110         Reviewed by Jer Noble.
3111
3112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3113         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
3114         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
3115         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3116         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3117         (MediaCaptureDisabledTest::SetUp):
3118         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3119         (TEST_F):
3120         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
3121
3122 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
3123
3124         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
3125         https://bugs.webkit.org/show_bug.cgi?id=171350
3126         <rdar://problem/28600836>
3127
3128         Patched by Brady Eidson.
3129
3130         Reviewed by Brent Fulgham.
3131
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
3134         (TestWebKitAPI::runJavaScriptAlert):
3135         (TestWebKitAPI::decidePolicyForNavigationAction):
3136         (TestWebKitAPI::decidePolicyForNavigationResponse):
3137         (TestWebKitAPI::TEST):
3138         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
3139
3140 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
3141
3142         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
3143         https://bugs.webkit.org/show_bug.cgi?id=171619
3144         https://bugs.webkit.org/show_bug.cgi?id=170195
3145
3146         Reviewed by Tim Horton.
3147
3148         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
3149
3150         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3151         (TEST):
3152
3153 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3154
3155         YouTube user agent quirk breaks new YouTube
3156         https://bugs.webkit.org/show_bug.cgi?id=171603
3157
3158         Reviewed by Carlos Garcia Campos.
3159
3160         Remove the YouTube quirk test.
3161
3162         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3163         (TestWebKitAPI::TEST):
3164
3165 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
3166
3167         Async image decoding should be disabled for snapshots, printing and preview
3168         https://bugs.webkit.org/show_bug.cgi?id=171467
3169
3170         Reviewed by Simon Fraser.
3171
3172         Add a API test for snapshotting with large images. Ensure the images are
3173         drawn correctly which implies they should have been synchronously decoded.
3174
3175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3176         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
3177         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
3178         (TEST):
3179
3180 2017-05-03  Chris Dumez  <cdumez@apple.com>
3181
3182         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
3183         https://bugs.webkit.org/show_bug.cgi?id=171565
3184         <rdar://problem/31204417>
3185
3186         Reviewed by Sam Weinig.
3187
3188         Add API test coverage.
3189
3190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3191         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
3192         (TestWebKitAPI::didFinishNavigation):
3193         (TestWebKitAPI::didCrashWithReason):
3194         (TestWebKitAPI::TEST):
3195
3196 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3197
3198         check-webkit-style should also keep js-test-post[-async].js in sync
3199         <https://webkit.org/b/171568>
3200
3201         Reviewed by Joseph Pecoraro.
3202
3203         * Scripts/webkitpy/style/checker.py:
3204         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
3205         JavaScript files not to be skipped.
3206         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
3207         (CheckerDispatcher._create_checker): Update to use
3208         _NEVER_SKIPPED_JS_FILES.
3209
3210         * Scripts/webkitpy/style/checkers/jstest.py:
3211         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
3212         This is the list of files containing functions that need to be
3213         kept in sync.
3214         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
3215         we can keep more sets of files in sync between
3216         LayoutTests/resources and LayoutTests/http/tests/resources.
3217         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
3218         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
3219         (JSTestChecker.check_js_test_files): Add 'file_group' argument
3220         for list of files to check instead of using
3221         KEEP_JS_TEST_FILES_IN_SYNC.
3222         (JSTestChecker.check_js_test_functions): Update for
3223         ALL_JS_TEST_FUNCTION_FILES rename.
3224
3225         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
3226         (JSTestCheckerTestCase):
3227         (JSTestCheckerTestCase.test_map_functions_to_dict):
3228         - Add test case for map_functions_to_dict() in jstest.py.
3229
3230 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
3231
3232         ews should indicate in logs when it fails to fetch the attachment
3233         https://bugs.webkit.org/show_bug.cgi?id=171583
3234
3235         Reviewed by Alexey Proskuryakov.
3236
3237         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3238         (Bugzilla.fetch_attachment): Added log statement.
3239
3240 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3241
3242         Rolling out jstest_unittest.py so it can be reviewed
3243
3244         Follow-up fix for:
3245         check-webkit-style should keep JavaScript test functions in sync
3246         <https://webkit.org/b/171424>
3247
3248         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
3249
3250 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3251
3252         check-webkit-style should keep JavaScript test functions in sync
3253         <https://webkit.org/b/171424>
3254
3255         Reviewed by Joseph Pecoraro.
3256
3257         Add a new JSTestChecker for check-webkit-style that keeps these
3258         two files in sync:
3259
3260             LayoutTests/http/tests/resources/js-test-pre.js
3261             LayoutTests/resources/js-test-pre.js
3262
3263         And keeps implementations of shouldBe(), shouldNotBe(),
3264         shouldNotThrow(), and shouldThrow() in sync across multiple
3265         files (with the ability to add more functions later):
3266
3267             JSTests/stress/resources/standalone-pre.js
3268             LayoutTests/http/tests/resources/js-test-pre.js
3269             LayoutTests/resources/js-test-pre.js
3270             LayoutTests/resources/js-test.js
3271             LayoutTests/resources/standalone-pre.js
3272
3273         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
3274         import for JSTestChecker.
3275         (_NEVER_SKIPPED_FILES): Add array of file names that are never
3276         skipped regardless of other rules.
3277         (_all_categories): Add JSTestChecker categories.
3278         (CheckerDispatcher.should_skip_without_warning): Use
3279         _NEVER_SKIPPED_FILES.
3280         (CheckerDispatcher._create_checker): Return JSTestChecker for
3281         the files to check.
3282
3283         * Scripts/webkitpy/style/checkers/jstest.py: Add.
3284         (map_functions_to_dict): Parse JavaScript source by splitting on
3285         /^function\s+/ regex.  This is good enough for the sanity checks
3286         to keep function implementations in sync.
3287         (strip_blank_lines_and_comments): Strips blank lines and lines
3288         with comments from the end of a chunk of text representing a
3289         function.
3290         (JSTestChecker): New checker.
3291         (JSTestChecker.__init__):
3292         (JSTestChecker.check):
3293         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
3294         (JSTestChecker.check_js_test_functions): Keeps individual
3295         functions in sync.
3296
3297         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
3298         case.
3299         (JSTestTestCase):
3300         (JSTestTestCase.test_map_functions_to_dict):
3301
3302 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
3303
3304         AX: Update implementation of aria-orientation
3305         https://bugs.webkit.org/show_bug.cgi?id=171166
3306
3307         Reviewed by Chris Fleizach.
3308
3309         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
3310         are both absent from the state set. Before we were returning an empty string
3311         which was not consistent with what the Mac port does, thus making shared tests
3312         harder.
3313
3314         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3315         (WTR::AccessibilityUIElement::orientation):
3316
3317 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3318
3319         Stop using sprintf() in JavaScriptCore debugger
3320         <https://webkit.org/b/171512>
3321
3322         Reviewed by Keith Miller.
3323
3324         * Scripts/webkitpy/style/checker.py:
3325         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
3326         Source/JavaScriptCore/disassembler/udis86/ is generated code.
3327
3328 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
3329
3330         Expose viewport-fit instead of clip-to-safe-area
3331         https://bugs.webkit.org/show_bug.cgi?id=171503
3332         <rdar://problem/31918249>
3333
3334         Reviewed by Simon Fraser.
3335
3336         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3337         (WTR::UIScriptController::setSafeAreaInsets):
3338         (WTR::UIScriptController::setObscuredInsets): Deleted.
3339         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3340         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3341         (WTR::UIScriptController::setSafeAreaInsets):
3342         (WTR::UIScriptController::setObscuredInsets): Deleted.
3343         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3344         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3345         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3346         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
3347         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
3348         * WebKitTestRunner/ios/TestControllerIOS.mm:
3349         (WTR::TestController::platformResetStateToConsistentValues):
3350         * WebKitTestRunner/ios/UIKitSPI.h:
3351         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3352         (WTR::UIScriptController::setSafeAreaInsets):
3353         (WTR::UIScriptController::setObscuredInsets): Deleted.
3354         Expose a safe area inset setter instead of obscured insets.
3355
3356 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3357
3358         Unreviewed, fix the build on a new internal SDK
3359
3360         Replace usages of NSItemProviderRepresentationVisibilityAll with
3361         UIItemProviderRepresentationOptionsVisibilityAll.
3362
3363         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3364         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
3365         (TestWebKitAPI::TEST):
3366
3367 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3368
3369         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
3370         <https://webkit.org/b/171493>
3371
3372         Reviewed by Dan Bernstein.
3373
3374         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3375         Remove UIKit soft-link since TestWebKitAPI links to
3376         UIKit.framework.
3377         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
3378         UIWindow and UIWebView classes directly.
3379         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3380         Remove UIKit soft-link since TestWebKitAPI links to
3381         UIKit.framework.
3382         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
3383         class directly.
3384
3385 2017-05-01  Brady Eidson  <beidson@apple.com>
3386
3387         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
3388         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
3389
3390         Reviewed by Andy Estes.
3391
3392         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3393         (-[SchemeHandler webView:startURLSchemeTask:]):
3394         (-[SchemeHandler webView:stopURLSchemeTask:]):
3395         (-[SchemeHandler webView:startTask:]): Deleted.
3396         (-[SchemeHandler webView:stopTask:]): Deleted.
3397
3398 2017-05-01  Jason Marcell  <jmarcell@apple.com>
3399
3400         Add a new function for getting the Git hash for a pure git directory.
3401         https://bugs.webkit.org/show_bug.cgi?id=171450
3402
3403         Reviewed by David Kilzer.
3404
3405         * Scripts/VCSUtils.pm:
3406         (gitHashForDirectory):
3407
3408 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
3409
3410         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
3411         https://bugs.webkit.org/show_bug.cgi?id=171496
3412
3413         Reviewed by Chris Fleizach.
3414
3415         Add new attribute names so that the values of the object attributes can be tested.
3416
3417         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3418         (WTR::AccessibilityUIElement::numberAttributeValue):
3419
3420 2017-05-01  Beth Dakin  <bdakin@apple.com>
3421
3422         On-screen panel for candidate bar is in the wrong place when the caret is at the 
3423         start of a paragraph
3424         https://bugs.webkit.org/show_bug.cgi?id=171453
3425         -and corresponding-
3426         rdar://problem/29779764
3427
3428         Reviewed by Tim Horton.
3429
3430         This test hard-codes the y-coordinate for the expected candidateRect. 
3431         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3432         (TEST):
3433
3434 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3435
3436         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
3437         <https://webkit.org/b/171494>
3438
3439         Reviewed by Brent Fulgham.
3440
3441         * Scripts/webkitpy/style/checkers/cpp.py:
3442         (check_language): Change categories for certain checkers from
3443         'runtime/printf' to 'security/printf' so they are no longer
3444         filtered.
3445         (CppChecker.categories): Add 'security/printf'.
3446         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3447         (CppStyleTest.test_insecure_string_operations): Add new test for
3448         sprintf(), strcat() and strcpy().
3449         (CppStyleTest.test_format_strings): Update test results for new
3450         'security/printf' category use.
3451
3452 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
3453
3454         AX: [GTK] Add support to query for aria-current
3455         https://bugs.webkit.org/show_bug.cgi?id=149016
3456
3457         Reviewed by Chris Fleizach.
3458
3459         Implement support for "AXARIACurrent" string attribute value.
3460
3461         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3462
3463 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3464
3465         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
3466
3467         Unreviewed.
3468
3469         Follow-up fix for:
3470         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
3471         https://bugs.webkit.org/show_bug.cgi?id=171486
3472
3473         * Scripts/webkitpy/style/checkers/cpp.py:
3474         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
3475         match and capture the function name.  The latter also mistakenly
3476         matches C-preprocessor directives.
3477         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
3478         is a requirement for the CppChecker class.
3479
3480 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3481
3482         [GTK] Add automation session API
3483         https://bugs.webkit.org/show_bug.cgi?id=171428
3484
3485         Reviewed by Carlos Alberto Lopez Perez.
3486
3487         Add an automation mode to MiniBrowser using the new API and add a unit test too.
3488
3489         * MiniBrowser/gtk/BrowserWindow.c:
3490         (webViewTitleChanged):
3491         (webViewDecidePolicy):
3492         (newTabCallback):
3493         (openPrivateWindow):
3494         (browserWindowFinalize):
3495         (browser_window_init):
3496         (browser_window_get_or_create_web_view_for_automation):
3497         * MiniBrowser/gtk/BrowserWindow.h:
3498         * MiniBrowser/gtk/main.c:
3499         (createBrowserTab):
3500         (createWebViewForAutomationCallback):
3501         (automationStartedCallback):
3502         (main):
3503         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3504         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
3505         (testAutomationSessionRequestSession):
3506         (beforeAll):
3507         (afterAll):
3508
3509 2017-04-30  Dan Bernstein  <mitz@apple.com>
3510
3511         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
3512         https://bugs.webkit.org/show_bug.cgi?id=171486
3513
3514         Reviewed by Sam Weinig.
3515
3516         * Scripts/webkitpy/style/checkers/cpp.py:
3517         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
3518           alloc…Instance() instead.
3519         (check_style): Invoke new check.
3520
3521 2017-04-30  Brady Eidson  <beidson@apple.com>
3522
3523         More fixing after r215991
3524         https://bugs.webkit.org/show_bug.cgi?id=171483
3525
3526         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3527         (TEST):
3528
3529 2017-04-30  Brady Eidson  <beidson@apple.com>
3530
3531         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
3532         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
3533
3534         Reviewed by Geoff Garen (and kind of Andy Estes).
3535
3536         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3537         (TEST):
3538
3539 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3540
3541         [ATK] Implement support for aria-autocomplete
3542         https://bugs.webkit.org/show_bug.cgi?id=171167
3543
3544         Reviewed by Chris Fleizach.
3545
3546         Add "AXSupportsAutoCompletion" attribute so the presence of
3547         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
3548
3549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3550         (WTR::AccessibilityUIElement::boolAttributeValue):
3551
3552 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3553
3554         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
3555         https://bugs.webkit.org/show_bug.cgi?id=171170
3556
3557         Reviewed by Chris Fleizach.
3558
3559         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
3560
3561         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3562         (WTR::AccessibilityUIElement::boolAttributeValue):
3563
3564 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3565
3566         [ATK] Emit object:state-changed:busy event when aria-busy value changes
3567         https://bugs.webkit.org/show_bug.cgi?id=171181
3568
3569         Reviewed by Chris Fleizach.
3570
3571         Add handler for AXElementBusyChanged notifications.
3572
3573         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3574
3575 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
3576
3577         Use PEP8 style guide for raising exceptions in webkitpy.
3578         https://bugs.webkit.org/show_bug.cgi?id=171439
3579
3580         Reviewed by Daniel Bates.
3581
3582         As per https://www.python.org/dev/peps/pep-0008/
3583         "When raising an exception in Python 2, use raise ValueError('message') 
3584         instead of the older form raise ValueError, 'message'"
3585
3586         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
3587         * Scripts/webkitpy/common/thread/messagepump.py: Same.
3588         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
3589         * Scripts/webkitpy/tool/commands/queues.py: Same.
3590         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
3591         * Scripts/webkitpy/tool/multicommandtool.py: Same.
3592         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
3593
3594 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
3595
3596         Add system trace points for Document::updateTouchEventRegions()
3597         https://bugs.webkit.org/show_bug.cgi?id=171470
3598         rdar://problem/31901239
3599
3600         Reviewed by Tim Horton.
3601
3602         Add trace markers for updateTouchEventRegions.
3603
3604         * Tracing/SystemTracePoints.plist:
3605
3606 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
3607
3608         webkitpy: Add apple_additions to webkitpy to insert Internal tools
3609         https://bugs.webkit.org/show_bug.cgi?id=170461
3610         <rdar://problem/31433077>
3611
3612         Reviewed by Daniel Bates.
3613
3614         Allow a package to be pulled in by run-webkit-tests which provides an interface to
3615         run layout tests on an iOS device.  If this package is not available, throw an
3616         exception when attempting to run layout tests on an iOS device.
3617
3618         * Scripts/webkitpy/port/config.py:
3619         (apple_additions): Import apple_additions package.
3620         * Scripts/webkitpy/port/device.py:
3621         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
3622         installed on a device.
3623         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
3624         host, the bundle id of the app to be used for testing and a path to the layout test
3625         directory to be mounted on the device.
3626         (Device.finished_testing):
3627         * Scripts/webkitpy/port/factory.py:
3628         (platform_options): Add apple_additions platform options if apple_additions exists.
3629         * Scripts/webkitpy/port/ios.py:
3630         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
3631         to forward, the bundle ID of the testing app and the layout tests directory to
3632         each device.
3633         * Scripts/webkitpy/port/ios_device.py:
3634         (IOSDevicePort):
3635         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
3636         processes to be run.
3637         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
3638         a single device is used, it is still accessed through an array.
3639         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
3640         for worker number map.
3641         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
3642         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
3643         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
3644         (IOSDevicePort.look_for_new_crash_logs): Ditto.
3645         (IOSDevicePort.look_for_new_samples): Ditto.
3646         (IOSDevicePort.sample_process): Ditto.
3647         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
3648         (IOSDevicePort._create_devices): Check that devices are available for testing and check
3649         that we have enough devices for each child process.
3650         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
3651         * Scripts/webkitpy/port/ios_device_unittest.py:
3652         (IOSDeviceTest.test_operating_system):
3653         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
3654         (IOSDeviceTest.test_sample_process): Ditto.
3655         (IOSDeviceTest.test_sample_process_exception): Ditto.
3656
3657 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3658
3659         Fix and re-enable data interaction unit tests
3660         https://bugs.webkit.org/show_bug.cgi?id=171446
3661         <rdar://problem/31820646>
3662
3663 &n