[EFL] [DRT] Implement scheduleAsynchronousKeyDown.
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
2
3         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
4         https://bugs.webkit.org/show_bug.cgi?id=79601
5
6         Reviewed by Gustavo Noronha Silva.
7
8         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
9         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
10         and is taken over to sendKeyDown.
11         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
12         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
13
14         * DumpRenderTree/efl/EventSender.cpp:
15         (KeyEventInfo::KeyEventInfo):
16         (KeyEventInfo):
17         (createKeyEventInfo):
18         (sendKeyDown):
19         (keyDownCallback):
20         (sendAsynchronousKeyDown):
21         (scheduleAsynchronousKeyDownCallback):
22
23 2012-03-12  Ojan Vafai  <ojan@chromium.org>
24
25         webkit-patch optimize-baselines sometimes creates a mac-future result
26         https://bugs.webkit.org/show_bug.cgi?id=80717
27
28         Reviewed by Adam Barth.
29
30         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
31         (_baseline_search_hypergraph):
32         (BaselineOptimizer._find_optimal_result_placement):
33         (BaselineOptimizer._filter_virtual_ports):
34         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
35         (BaselineOptimizerTest.test_no_add_mac_future):
36
37 2012-03-12  Jessie Berlin  <jberlin@apple.com>
38
39         More Windows build fixing.
40
41         * DumpRenderTree/win/WorkQueueItemWin.cpp:
42
43 2012-03-12  Jessie Berlin  <jberlin@apple.com>
44
45         More Windows build fixing.
46
47         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
48         * DumpRenderTree/win/EditingDelegate.cpp:
49         * DumpRenderTree/win/EventSender.cpp:
50         * DumpRenderTree/win/FrameLoadDelegate.cpp:
51         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
52         * DumpRenderTree/win/UIDelegate.cpp:
53
54 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
55
56         remove the 'gpu' group from the flakiness dashboard
57         https://bugs.webkit.org/show_bug.cgi?id=80353
58
59         Reviewed by Adam Barth.
60
61         Since those bots are obsolete, we don't need this any more.
62
63         * TestResultServer/static-dashboards/builders.js:
64         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
65         (testPlatformAndBuildType):
66         (testHtmlForTestTypeSwitcherGroup):
67
68 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
69
70         remove graphics_type from webkitpy.layout_tests.models.test_configuration
71         https://bugs.webkit.org/show_bug.cgi?id=80643
72
73         Reviewed by Ojan Vafai.
74
75         Now that the chromium-gpu ports are gone, there's no need for
76         the graphics_type CPU/GPU distinction. Most of this change is
77         just updating tests accordingly.
78
79         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
80         (TestExpectationEditorTests):
81         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
82         (TestConfiguration.__init__):
83         (TestConfiguration.category_order):
84         (TestConfiguration.__str__):
85         (TestConfiguration.__repr__):
86         (TestConfiguration.__hash__):
87         (TestConfigurationConverter.to_specifiers_list):
88         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
89         (make_mock_all_test_configurations_set):
90         (TestConfigurationTest.test_items):
91         (TestConfigurationTest.test_keys):
92         (TestConfigurationTest.test_str):
93         (TestConfigurationTest.test_repr):
94         (TestConfigurationTest.test_hash):
95         (TestConfigurationTest.test_hash.query_unknown_key):
96         (TestConfigurationTest.test_eq):
97         (TestConfigurationTest.test_values):
98         (SpecifierSorterTest.test_specifier_priority):
99         (SpecifierSorterTest.test_sort_specifiers):
100         (TestConfigurationConverterTest.test_to_config_set):
101         (TestConfigurationConverterTest.test_macro_expansion):
102         (TestConfigurationConverterTest.test_to_specifier_lists):
103         (TestConfigurationConverterTest.test_converter_macro_collapsing):
104         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
105         (test_error_on_different_build_type):
106         (TestExpectationSerializerTests.test_parsed_to_string):
107         (TestExpectationSerializerTests.test_reconstitute_only_these):
108         * Scripts/webkitpy/layout_tests/port/apple.py:
109         (ApplePort._generate_all_test_configurations):
110         * Scripts/webkitpy/layout_tests/port/base.py:
111         (Port.__init__):
112         (Port.name):
113         (Port.version):
114         (Port.test_configuration):
115         * Scripts/webkitpy/layout_tests/port/builders.py:
116         * Scripts/webkitpy/layout_tests/port/chromium.py:
117         (ChromiumPort):
118         (ChromiumPort._generate_all_test_configurations):
119         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
120         (ChromiumLinuxPort.__init__):
121         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
122         (ChromiumLinuxPortTest.test_check_illegal_port_names):
123         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
124         (ChromiumMacPortTest.test_baseline_path):
125         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
126         (ChromiumPortTest.test_all_test_configurations):
127         * Scripts/webkitpy/layout_tests/port/efl.py:
128         (EflPort._generate_all_test_configurations):
129         * Scripts/webkitpy/layout_tests/port/gtk.py:
130         (GtkPort._generate_all_test_configurations):
131         * Scripts/webkitpy/layout_tests/port/qt.py:
132         (QtPort._generate_all_test_configurations):
133         * Scripts/webkitpy/layout_tests/port/test.py:
134         (TestPort.all_test_configurations):
135         (TestPort._all_build_types):
136         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
137         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
138         (BuildCoverageExtrapolatorTest.test_extrapolate):
139         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
140         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
141         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
142         (GardeningExpectationsUpdaterTest.test_pass_expectation):
143         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
144         (GardeningExpectationsUpdaterTest.test_spurious_updates):
145
146 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
147
148         _runtime_feature_list isn't supported on Apple Mac DRT
149         https://bugs.webkit.org/show_bug.cgi?id=80906
150
151         Reviewed by Eric Seidel.
152
153         It looks like this feature is actually only supported on the Win
154         DRT port, so this patch reworks the code to make that clearer
155         and reduce unnecessary overrides.
156
157         * Scripts/webkitpy/layout_tests/port/efl.py:
158         (EflPort._path_to_webcore_library):
159         * Scripts/webkitpy/layout_tests/port/gtk.py:
160         (GtkPort._path_to_webcore_library):
161         * Scripts/webkitpy/layout_tests/port/qt.py:
162         (QtPort._skipped_file_search_paths):
163         * Scripts/webkitpy/layout_tests/port/webkit.py:
164         (WebKitPort._runtime_feature_list):
165         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
166         (TestWebKitPort.__init__):
167         (TestWebKitPort.all_test_configurations):
168         (test_skipped_directories_for_features):
169         * Scripts/webkitpy/layout_tests/port/win.py:
170         (WinPort):
171         (WinPort._runtime_feature_list):
172         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
173         (WinPortTest.test_operating_system):
174         (WinPortTest):
175         (WinPortTest.test_runtime_feature_list):
176
177 2012-03-12  Peter Beverloo  <peter@chromium.org>
178
179         [Chromium] Temporary build-fix for the Android bot
180         https://bugs.webkit.org/show_bug.cgi?id=80862
181
182         Reviewed by Adam Barth.
183
184         Manually set the environmental variables required to compile source
185         files through the Android NDK instead of relying on the envsetup.sh
186         script. A proper fix will be landed to Chromium ASAP, and following
187         a Chromium roll into WebKit this code will be removed.
188
189         * Scripts/webkitdirs.pm:
190         (buildChromiumMakefile):
191
192 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
193
194         [Qt] Use right construct to detect config_test_gccdepends
195
196         Reviewed by Andreas Kling.
197
198         * qmake/mkspecs/features/default_pre.prf:
199
200 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
201
202         [Qt] Expose location of WebKit's bin and imports dir through module file
203
204         Reviewed by Andreas Kling.
205
206         * qmake/qt_webkit.pri:
207
208 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
209
210         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
211         https://bugs.webkit.org/show_bug.cgi?id=80832
212
213         Reviewed by Tor Arne Vestbø.
214
215         Add a basic scroll indicator component to MiniBrowser so that it
216         behaves similar to the ScrollDecorator QML component.
217
218         * MiniBrowser/qt/MiniBrowser.qrc:
219         * MiniBrowser/qt/qml/BrowserWindow.qml:
220         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
221
222 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
223
224         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
225         https://bugs.webkit.org/show_bug.cgi?id=80809
226
227         Reviewed by Philippe Normand.
228
229         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
230
231 2012-03-12  Ming Xie  <mxie@rim.com>
232
233         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
234         https://bugs.webkit.org/show_bug.cgi?id=80812
235
236         Reviewed by Rob Buis.
237
238         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
239         * Scripts/webkitdirs.pm:
240         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
241
242
243 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
244
245         [Qt] Fix build with newer Qt 5.
246
247         Reviewed by Tor Arne Vestbø.
248
249         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
250         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
251         we should disable -Werror.
252
253         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
254         implicit load was removed recently.
255
256         * qmake/mkspecs/features/default_pre.prf:
257         * qmake/mkspecs/features/unix/default_post.prf:
258
259 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
260
261         Add --instruments option to sunspider to profile with Instruments
262         https://bugs.webkit.org/show_bug.cgi?id=80783
263
264         Reviewed by Filip Pizlo.
265
266         * Scripts/run-sunspider:
267
268 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
269
270         [Qt] [WK2] Support threaded renderer in WK2
271         https://bugs.webkit.org/show_bug.cgi?id=76661
272
273         Remove disabling of threaded rendering.
274
275         Reviewed by Noam Rosenthal.
276
277         * MiniBrowser/qt/main.cpp:
278         (main):
279
280 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
281
282         [WK2] run-perf-tests should be able to run with WTR
283         https://bugs.webkit.org/show_bug.cgi?id=80042
284
285         Reviewed by Martin Robinson.
286
287         Add an option to PerfTestRunner to use WebKitTestRunner instead of
288         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
289         to avoid timing out when running performance tests.
290
291         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
292         (PerfTestsRunner._parse_args):
293         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
294         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
295         to true.
296         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
297         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
298         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
299         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
300         publicly accessible.
301         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
302         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
303         is required.
304         * WebKitTestRunner/TestController.cpp:
305         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
306         to true.
307         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
308         if '--no-timeout' option is present.
309         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
310         value, or -1.0 if timeout should not occur.
311         * WebKitTestRunner/TestController.h:
312         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
313         publicly accessible.
314         * WebKitTestRunner/TestInvocation.cpp:
315         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
316         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
317         Waiting for final message should not time out if not necessary.
318         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
319         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
320         * WebKitTestRunner/qt/TestControllerQt.cpp:
321         (WTR::TestController::platformRunUntil): Ditto.
322         * WebKitTestRunner/mac/TestControllerMac.mm:
323         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
324         is missing.
325         * WebKitTestRunner/win/TestControllerWin.cpp:
326         (WTR::TestController::platformRunUntil): Ditto.
327
328 2012-03-09  Jon Lee  <jonlee@apple.com>
329
330         Rename NotificationPresenter to NotificationClient
331         https://bugs.webkit.org/show_bug.cgi?id=80488
332         <rdar://problem/10965558>
333
334         Reviewed by Kentaro Hara.
335
336         Refactor to use renamed WebCore::NotificationClient.
337         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
338         (DRTDesktopNotificationPresenter::checkNotificationPermission):
339
340 2012-03-07  James Robinson  <jamesr@chromium.org>
341
342         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
343         https://bugs.webkit.org/show_bug.cgi?id=80523
344
345         Reviewed by Darin Fisher.
346
347         * DumpRenderTree/chromium/WebViewHost.cpp:
348         (WebViewHost::createGraphicsContext3D):
349         * DumpRenderTree/chromium/WebViewHost.h:
350         (WebViewHost):
351
352 2012-03-09  Eric Seidel  <eric@webkit.org>
353
354         build-webkit should build Source/WTF on Mac
355         https://bugs.webkit.org/show_bug.cgi?id=80728
356
357         Reviewed by Adam Barth.
358
359         We'll add other ports to this list in future commits.
360
361         * Scripts/build-webkit:
362
363 2012-03-09  Jon Lee  <jonlee@apple.com>
364
365         Add support for ENABLE(LEGACY_NOTIFICATIONS)
366         https://bugs.webkit.org/show_bug.cgi?id=80497
367
368         Reviewed by Adam Barth.
369
370         Prep for b80472: Update API for Web Notifications
371         * Scripts/build-webkit:
372         * qmake/mkspecs/features/features.prf:
373
374 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
375
376         Bash scripts should support LF endings only
377         https://bugs.webkit.org/show_bug.cgi?id=79509
378
379         Reviewed by David Kilzer.
380
381         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
382         * EWSTools/start-queue.sh: Added property svn:eol-style.
383         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
384         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
385         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
386         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
387
388 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
389
390         [BUILD] use detected python to run generate-gtkdoc
391         https://bugs.webkit.org/show_bug.cgi?id=80695
392
393         Reviewed by Gustavo Noronha Silva.
394
395         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
396
397 2012-03-09  Nat Duca  <nduca@chromium.org>
398
399         Make check-webkit-style complain about "no new tests" lines in changelogs
400         https://bugs.webkit.org/show_bug.cgi?id=80582
401
402         Reviewed by David Levin.
403
404         * Scripts/webkitpy/style/checkers/changelog.py:
405         (ChangeLogChecker.check_entry):
406         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
407         (ChangeLogCheckerTest.test_no_new_tests):
408
409 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
410
411         Unreviewed, rolling out r110250.
412         http://trac.webkit.org/changeset/110250
413         https://bugs.webkit.org/show_bug.cgi?id=80682
414
415         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
416         qt-linux at all. (Requested by Ossy on #webkit).
417
418         * Scripts/old-run-webkit-tests:
419         * Scripts/webkitpy/layout_tests/port/qt.py:
420         (QtPort):
421         (QtPort.determine_full_port_name):
422         (QtPort.baseline_search_path):
423         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
424         (QtPortTest):
425         (QtPortTest._assert_search_path):
426         (QtPortTest.test_baseline_search_path):
427
428 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
429
430         [Qt] Use Qt's module system for install rules and depending on QtWebKit
431
432         Instead of rolling our own install rules we now use the same approach as
433         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
434
435         This ensures that we follow the same semantics as the rest of Qt on
436         what sort of config options are enabled by default (create_cmake eg.).
437         It also allows us to use QT += webkit instead of the workaround we had
438         with CONFIG += qtwebkit.
439
440         We do however force Qt to always treat our build as a non-developer build,
441         so the libraries will end up in the WebKit lib directory instead of the
442         qtbase directory (as with a normal developer-build). This allows us to
443         keep the webkit-build self-contained. If Qt is a developer build we still
444         copy the module file manually to Qt, so that you don't have to install
445         WebKit to make it available.
446
447         For non-developer builds of Qt, it is still possible to use the built
448         WebKit libraries without having to install them, by having the variable
449         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
450         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
451
452         https://bugs.webkit.org/show_bug.cgi?id=80590
453
454         Reviewed by Simon Hausmann.
455
456         * DumpRenderTree/qt/DumpRenderTree.pro:
457         * MiniBrowser/qt/BrowserWindow.cpp:
458         * MiniBrowser/qt/MiniBrowser.pro:
459         * MiniBrowser/qt/MiniBrowserApplication.cpp:
460         * MiniBrowser/qt/UrlLoader.cpp:
461         * QtTestBrowser/QtTestBrowser.pro:
462         * Tools.pro:
463         * WebKitTestRunner/InjectedBundle/Target.pri:
464         * WebKitTestRunner/Target.pri:
465         * qmake/mkspecs/features/default_post.prf:
466         * qmake/mkspecs/features/default_pre.prf:
467         * qmake/mkspecs/features/functions.prf:
468         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
469         * qmake/mkspecs/features/qtwebkit.prf:
470         * qmake/mkspecs/features/rpath.prf:
471         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
472         * qmake/qt_webkit.pri: Added.
473
474 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
475
476         Unreviewed. Update my email.
477
478         * Scripts/webkitpy/common/config/committers.py:
479
480 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
481
482         Recent changes to chromium.py etc. broke chromium_android.py
483         https://bugs.webkit.org/show_bug.cgi?id=80623
484
485         Reviewed by Dirk Pranke.
486
487         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
488         (ChromiumAndroidDriver.__init__):
489         (ChromiumAndroidDriver._start):
490
491 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
492
493         [Chromium] Exception running reftest with --no-pixel-tests
494         https://bugs.webkit.org/show_bug.cgi?id=80642
495
496         Reviewed by Dirk Pranke.
497
498         * Scripts/webkitpy/layout_tests/port/chromium.py:
499         (ChromiumDriver.__init__):
500         (ChromiumDriver._wrapper_options):
501
502 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
503
504         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
505         https://bugs.webkit.org/show_bug.cgi?id=72489
506
507         Reviewed by Dirk Pranke.
508
509         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
510         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
511         --platform will override the platform name and then we'll use it.
512
513         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
514         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
515         override it in the end.
516
517         * Scripts/old-run-webkit-tests:
518         * Scripts/webkitpy/layout_tests/port/qt.py:
519         (QtPort):
520         (QtPort.determine_full_port_name):
521         (QtPort.baseline_search_path):
522         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
523         (QtPortTest):
524         (QtPortTest._assert_search_path):
525         (QtPortTest.test_baseline_search_path):
526
527 2012-03-08  Beth Dakin  <bdakin@apple.com>
528
529         https://bugs.webkit.org/show_bug.cgi?id=80463
530         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
531         -and corresponding-
532         <rdar://problem/10970221>
533
534         Reviewed by Dan Bernstein.
535
536         New test!
537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
538         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
539         (TestWebKitAPI):
540         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
541         (TestWebKitAPI::setPageLoaderClient):
542         (TestWebKitAPI::TEST):
543         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
544         (TestWebKitAPI):
545         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
546         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
547         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
548         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
549
550 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
551
552         [Qt] Prospective Windows build fix
553
554         Don't assume that windows-builds will always run inside a cmd.exe shell.
555
556         * qmake/mkspecs/features/default_pre.prf:
557
558 2012-03-08  Dan Bernstein  <mitz@apple.com>
559
560         <rdar://problem/10981173> Dashboard regions should not be in device space
561
562         Reviewed by John Sullivan.
563
564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
565         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
566         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
567         (TestWebKitAPI):
568         (TestWebKitAPI::TEST):
569
570 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
571
572         webkit-patch works oddly on local Git branches
573         https://bugs.webkit.org/show_bug.cgi?id=76958
574
575         Reviewed by Ojan Vafai.
576
577         This change makes the '-g' flag to webkit-patch behave a
578         little more consistently with git. The 'HEAD..' syntax
579         is changed to 'HEAD....' (four dots), so as to not
580         collide with the underlying git syntax. We also generalize
581         the syntax to support any refname, so 'foo....' means
582         diff against foo and include working copy changes.
583
584         This change also adds the 'UPSTREAM' shortcut to identify
585         whatever the current upstream/tracking branch is; this is
586         useful if you have multiple local branches stacked up.
587
588         * Scripts/webkitpy/common/checkout/scm/git.py:
589         (Git._branch_from_ref):
590         (Git):
591         (Git._current_branch):
592         (Git._upstream_branch):
593         (Git.merge_base):
594         (Git._commit_on_branch):
595         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
596         (GitSVNTest._second_local_commit):
597         (GitSVNTest._two_local_commits):
598         (GitSVNTest.test_commit_with_message_git_commit_range):
599         (GitSVNTest.test_upstream_branch):
600         (GitSVNTest.test_create_patch_working_copy_only):
601         (GitSVNTest.test_changed_files_local_plus_working_copy):
602         (GitSVNTest.test_changed_files_working_copy_only):
603         (GitSVNTest.test_changed_files_upstream):
604         * Scripts/webkitpy/tool/steps/options.py:
605         (Options):
606
607 2012-03-08  John Sullivan  <sullivan@apple.com>
608
609         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
610
611         Reviewed by Eric Carlson.
612
613         * Scripts/extract-localizable-strings:
614         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
615         with NSLocalized. Also improved an error message to include the troublesome token.
616
617 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
618
619         Unreviewed, rolling out r110115.
620         http://trac.webkit.org/changeset/110115
621         https://bugs.webkit.org/show_bug.cgi?id=80581
622
623         broke test-webkitpy (Requested by philn-tp on #webkit).
624
625         * Scripts/old-run-webkit-tests:
626         * Scripts/webkitpy/layout_tests/port/qt.py:
627         (QtPort):
628         (QtPort.determine_full_port_name):
629         (QtPort.baseline_search_path):
630
631 2012-03-08  Kentaro Hara  <haraken@chromium.org>
632
633         Unreviewed. Added myself to watchlist.
634
635         * Scripts/webkitpy/common/config/watchlist:
636
637 2012-03-07  Jessie Berlin  <jberlin@apple.com>
638
639         Clean Windows build fails after r110033
640         https://bugs.webkit.org/show_bug.cgi?id=80553
641
642         Rubber-stamped by Jon Honeycutt and Eric Seidel.
643
644         Add the new JavaScriptCore include directory to some more vsprops files.
645
646         * DumpRenderTree/win/ImageDiffCommon.vsprops:
647         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
648         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
649
650 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
651
652         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
653         https://bugs.webkit.org/show_bug.cgi?id=72489
654
655         Reviewed by Dirk Pranke.
656
657         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
658         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
659         --platform will override the platform name and then we'll use it.
660
661         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
662         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
663         override it in the end.
664
665         * Scripts/old-run-webkit-tests:
666         * Scripts/webkitpy/layout_tests/port/qt.py:
667         (QtPort):
668         (QtPort.determine_full_port_name):
669         (QtPort.baseline_search_path):
670
671 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
672
673         [Qt][WK2] MiniBrowser on desktop does not react to click events
674         https://bugs.webkit.org/show_bug.cgi?id=80314
675
676         Reviewed by Kenneth Rohde Christiansen.
677
678         Do not enable touch mocking on desktop mode.
679
680         * MiniBrowser/qt/MiniBrowserApplication.cpp:
681         (MiniBrowserApplication::handleUserOptions):
682
683 2012-03-07  Ojan Vafai  <ojan@chromium.org>
684
685         Automatically move to the next test after rebaseline in the results view
686         https://bugs.webkit.org/show_bug.cgi?id=80527
687
688         Reviewed by Dimitri Glazkov.
689
690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
692
693 2012-03-07  Ojan Vafai  <ojan@chromium.org>
694
695         garden-o-matic rebaseline is broken for ports that don't have a fallback port
696         https://bugs.webkit.org/show_bug.cgi?id=80526
697
698         Reviewed by Adam Barth.
699
700         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
701         since there is no "None" port.
702
703         * Scripts/webkitpy/tool/servers/gardeningserver.py:
704         (GardeningHTTPRequestHandler.rebaseline):
705         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
706         (GardeningServerTest.test_rebaseline):
707
708 2012-03-07  James Robinson  <jamesr@chromium.org>
709
710         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
711         https://bugs.webkit.org/show_bug.cgi?id=80521
712
713         Reviewed by Kenneth Russell.
714
715         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
716         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
717         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
718
719         Covered by platform/chromium/compositing/plugins/*
720
721         * DumpRenderTree/chromium/TestWebPlugin.cpp:
722         (TestWebPlugin::TestWebPlugin):
723         (TestWebPlugin::initialize):
724         (TestWebPlugin::updateGeometry):
725         (TestWebPlugin::initScene):
726         (TestWebPlugin::destroyScene):
727         * DumpRenderTree/chromium/TestWebPlugin.h:
728         (TestWebPlugin):
729         * DumpRenderTree/chromium/WebViewHost.cpp:
730         (WebViewHost::createPlugin):
731
732 2012-03-07  Philippe Normand  <pnormand@igalia.com>
733
734         [GTK] remove webkitpy dependency in run-gtk-tests
735         https://bugs.webkit.org/show_bug.cgi?id=80500
736
737         Reviewed by Martin Robinson.
738
739         Replace Executive calls with bare subprocess calls.
740
741         * Scripts/run-gtk-tests:
742         (TestRunner):
743         (TestRunner._lookup_atspi2_binary):
744         (TestRunner.run):
745         (TestRunner.run.run_for_real):
746
747 2012-03-07  Philippe Normand  <pnormand@igalia.com>
748
749         Unreviewed, GTK build fix after r110059.
750
751         * Scripts/run-gtk-tests:
752         (TestRunner._check_if_tests_have_timed_out):
753         (TestRunner.run.run_tests):
754         (TestRunner):
755
756 2012-03-07  Philippe Normand  <pnormand@igalia.com>
757
758         [GTK] race condition in run-gtk-tests
759         https://bugs.webkit.org/show_bug.cgi?id=80495
760
761         Reviewed by Martin Robinson.
762
763         Refactored the script to wait the a11y dbus service becomes
764         available before starting the tests.
765
766         * Scripts/run-gtk-tests:
767         (TestRunner._lookup_atspi2_binary):
768         (TestRunner):
769         (TestRunner._wait_dbus_service_and_run):
770         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
771         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
772         (TestRunner.run):
773         (TestRunner.run.bailout):
774         (TestRunner.run.run_for_real):
775
776 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
777
778         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
779         https://bugs.webkit.org/show_bug.cgi?id=80425
780
781         Reviewed by Simon Hausmann.
782
783         Set startScreenPos in mock touch point
784
785         * MiniBrowser/qt/MiniBrowserApplication.cpp:
786         (MiniBrowserApplication::notify):
787         * MiniBrowser/qt/MiniBrowserApplication.h:
788         (MiniBrowserApplication):
789
790 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
791
792         [Qt] Windows build fix.
793
794         Reviewed by Tor Arne Vestbø.
795
796         Pass the -j parameter only to "make", not "nmake".
797
798         * Scripts/webkitdirs.pm:
799         (buildQMakeProjects):
800
801 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
802
803         [Qt] Fix compilation without QtQuick1
804         https://bugs.webkit.org/show_bug.cgi?id=80503
805
806         Reviewed by Tor Arne Vestbø.
807
808         Introduce HAVE_QQUICK1 as feature and added haveQtModule
809         as convenience function.
810
811         * qmake/mkspecs/features/features.prf:
812         * qmake/mkspecs/features/functions.prf:
813
814 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
815
816         [Qt] Add qmake config tests for JPEG and PNG library
817         https://bugs.webkit.org/show_bug.cgi?id=80398
818
819         Add JPEG and PNG library tests to config.tests and
820         add error() abort to WebCore.pri if tests don't work.
821
822         Reviewed by Tor Arne Vestbø.
823
824         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
825         (main):
826         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
827         * qmake/config.tests/libpng/libpng.cpp: Added.
828         (main):
829         * qmake/config.tests/libpng/libpng.pro: Added.
830         * qmake/sync.profile:
831
832 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
833
834         [EFL] Build warning: Fix warn_unused_result warnings.
835         https://bugs.webkit.org/show_bug.cgi?id=79194
836
837         Reviewed by Filip Pizlo.
838
839         Fixed build warning which is getting generated when not using return
840         value of a fuction, especially declared with warn_unused_result
841         attribute.
842
843         * DumpRenderTree/efl/ImageDiff.cpp:
844         (printImage):
845
846 2012-03-07  Kangil Han  <kangil.han@samsung.com>
847
848         [DRT] Remove PlainTextController implementations.
849         https://bugs.webkit.org/show_bug.cgi?id=79959
850
851         Reviewed by Hajime Morita.
852
853         PlainTextController usages in existing tests have been
854         replaced by internals API by bug 78570.
855         So this patch will remove PlainTextController implementations
856         to avoid further usage in new tests.
857
858         * DumpRenderTree/DumpRenderTree.gypi:
859         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
860         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
861         * DumpRenderTree/chromium/PlainTextController.h: Removed.
862         * DumpRenderTree/chromium/TestShell.cpp:
863         (TestShell::TestShell):
864         (TestShell::bindJSObjectsToWindow):
865         * DumpRenderTree/chromium/TestShell.h:
866         (TestShell):
867         * DumpRenderTree/gtk/DumpRenderTree.cpp:
868         (webViewWindowObjectCleared):
869         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
870         * DumpRenderTree/gtk/PlainTextController.h: Removed.
871         * DumpRenderTree/mac/FrameLoadDelegate.mm:
872         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
873         * DumpRenderTree/mac/PlainTextController.h: Removed.
874         * DumpRenderTree/mac/PlainTextController.mm: Removed.
875         * DumpRenderTree/qt/DumpRenderTree.pro:
876         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
877         (WebCore::DumpRenderTree::DumpRenderTree):
878         (WebCore::DumpRenderTree::initJSObjects):
879         * DumpRenderTree/qt/DumpRenderTreeQt.h:
880         (DumpRenderTree):
881         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
882         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
883         * GNUmakefile.am:
884
885 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
886
887         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
888         https://bugs.webkit.org/show_bug.cgi?id=80137
889
890         Reviewed by Eric Seidel.
891
892         Adds implementation LayoutTestController's setPopupBlockingEnabled.
893         To pass popup-blocking-click-in-iframe.html EventSender should not
894         repeat click events in idler's function. EventSender allows to
895         asynchronously send click event through ecore_idler_add.
896         This event will be called repeatedly as long as it return true.
897         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
898
899         * DumpRenderTree/efl/EventSender.cpp:
900         (sendMouseEvent): Changed return value from bool to void because it always returns true.
901         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
902         (mouseDownCallback): Remove unnecessary checking of return value.
903         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
904         (LayoutTestController::setPopupBlockingEnabled):
905
906 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
907
908         rebaseline_chromium_webkit_tests is obsolete and should be removed
909         https://bugs.webkit.org/show_bug.cgi?id=80347
910
911         Reviewed by Tony Chang.
912
913         * Scripts/rebaseline-chromium-webkit-tests: Removed.
914         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
915         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
916
917 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
918
919         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
920         https://bugs.webkit.org/show_bug.cgi?id=80468
921
922         Unreviewed, build fix.
923
924         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
925
926         * Scripts/webkitpy/layout_tests/servers/http_server.py:
927         (Lighttpd._prepare_config):
928
929 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
930
931         remove chromium_gpu ports
932         https://bugs.webkit.org/show_bug.cgi?id=80345
933
934         Reviewed by Ojan Vafai.
935
936         This change leaves in the 'graphics_type' distinction in the
937         test_expectations; removing that will require more updates and a
938         pass over test_expectations.txt, so I'm separating that out.
939
940         * Scripts/webkitpy/layout_tests/port/builders.py:
941         * Scripts/webkitpy/layout_tests/port/chromium.py:
942         (ChromiumPort):
943         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
944         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
945         * Scripts/webkitpy/layout_tests/port/factory.py:
946         (PortFactory):
947         (PortFactory.get):
948         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
949         (FactoryTest.test_qt):
950         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
951         (TestRebaseline.test_rebaseline_expectations):
952
953 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
954
955         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
956         https://bugs.webkit.org/show_bug.cgi?id=80282
957
958         Reviewed by Antonio Gomes.
959
960         Remove transitive library dependencies; they are especially
961         dangerous when one ends up linking against WTF, JSC and then WTF
962         again, since some symbols will not be defined.
963
964         Passing --no-copy-dt-needed-entries and --as-needed to the linker
965         (which some recent Linux distros do by default) makes the issue
966         even more evident.
967
968         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
969         as the other libraries have the needed symbols. Explicitly link
970         against fontconfig.
971
972 2012-03-06  Dean Jackson  <dino@apple.com>
973
974         filter-build-webkit needs more filters
975         https://bugs.webkit.org/show_bug.cgi?id=80440
976
977         Reviewed by Joseph Pecoraro.
978
979         Added as many missing filters as I could find for Apple
980         builds. Plus a few minor style updates.
981
982         * Scripts/filter-build-webkit:
983         (printLine):
984
985 2012-03-06  Ojan Vafai  <ojan@chromium.org>
986
987         Copying old baselines throws an error if the new directory doesn't exist
988         https://bugs.webkit.org/show_bug.cgi?id=80443
989
990         Reviewed by Adam Barth.
991
992         Existing tests cover the new code with the fix to filesystem_mock.
993
994         * Scripts/webkitpy/common/system/filesystem_mock.py:
995         (MockFileSystem.copyfile):
996         Fix the mock to better match python's copyfile semantics.
997
998         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
999         (Rebaseliner._create_html_baseline_files):
1000         * Scripts/webkitpy/tool/commands/rebaseline.py:
1001         (RebaselineTest._copy_existing_baseline):
1002
1003 2012-03-05  Ojan Vafai  <ojan@chromium.org>
1004
1005         Add a mechanism to rebaseline new ports
1006         https://bugs.webkit.org/show_bug.cgi?id=80355
1007
1008         Reviewed by Adam Barth.
1009
1010         For a test that's only failing on a new port, we want
1011         to first copy the existing result into the location for the
1012         port it's replacing in order to not break that port.
1013
1014         For example, bringing up the chromium-lion port, if we just
1015         stick the results in the chromium-mac directory, the snow leopard
1016         will start failing. Instead, we first copy the existing result
1017         to the chromium-mac-snowleopard directory.
1018
1019         * Scripts/webkitpy/layout_tests/port/builders.py:
1020         (builder_path_for_port_name):
1021         (fallback_port_name_for_new_port):
1022         * Scripts/webkitpy/tool/commands/rebaseline.py:
1023         (RebaselineTest):
1024         (RebaselineTest._copy_existing_baseline):
1025         (RebaselineTest._rebaseline_test):
1026         (RebaselineTest.execute):
1027         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1028         (TestRebaseline.test_rebaseline_test):
1029         (TestRebaseline):
1030         (TestRebaseline.test_rebaseline_and_copy_test):
1031         (test_rebaseline_and_copy_test_no_existing_result):
1032         (test_rebaseline_and_copy_test_with_lion_result):
1033         (test_rebaseline_and_copy_no_overwrite_test):
1034         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1035         (GardeningHTTPRequestHandler.rebaseline):
1036         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1037         (GardeningServerTest.test_rebaseline):
1038         (GardeningServerTest):
1039         (GardeningServerTest.test_rebaseline_new_port):
1040
1041 2012-03-06  Beth Dakin  <bdakin@apple.com>
1042
1043         https://bugs.webkit.org/show_bug.cgi?id=80351
1044         InlineTextBox is using the wrong origin when calling 
1045         addRelevantRepaintedObject
1046         -and corresponding-
1047         <rdar://problem/10970221>
1048
1049         Reviewed by Sam Weinig.
1050
1051         This test has actually been broken since revision 109273. This change makes 
1052         the test pass again, and it makes it specifically exercise the fix for this 
1053         bug.
1054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1055         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1056         (TestWebKitAPI::TEST):
1057
1058         Adjust comments in the other tests to reflect the API changes from 109273.
1059         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1060         (TestWebKitAPI::TEST):
1061         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1062         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
1063         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1064         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
1065         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1066         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
1067         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
1068
1069 2012-03-06  Hans Wennborg  <hans@chromium.org>
1070
1071         Speech JavaScript API: add SpeechRecognitionError
1072         https://bugs.webkit.org/show_bug.cgi?id=80410
1073
1074         Chromium: enable the runtime flag for scripted speech so we can run
1075         the layout tests for it.
1076
1077         Reviewed by Adam Barth.
1078
1079         * DumpRenderTree/chromium/TestShell.cpp:
1080         (TestShell::TestShell):
1081
1082 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
1083
1084         Enable universal newlines in chromium android layout test runner
1085         https://bugs.webkit.org/show_bug.cgi?id=80418
1086
1087         Reviewed by Adam Barth.
1088
1089         The Chromium Android layout test runner uses the 'adb' program to
1090         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
1091         output lines from the test runner, while the test expectation files are
1092         written with LF ('\n') delimiters. This causes the results to have
1093         spurious whitespace differences, making them more difficult to
1094         interpret.
1095
1096         The fix is to enable universal newlines for the DumpRenderTree pipe,
1097         causing the output to only contain LF newlines like on other platforms.
1098
1099         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1100         (ChromiumAndroidDriver._start):
1101
1102 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1103
1104         [Qt] Revert r109900, it was completly busted
1105
1106         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
1107
1108         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
1109         of manual define checks.
1110
1111         Reviewed by Ossy.
1112
1113         * DumpRenderTree/qt/DumpRenderTree.pro:
1114         * QtTestBrowser/QtTestBrowser.pro:
1115         * WebKitTestRunner/InjectedBundle/Target.pri:
1116         * qmake/mkspecs/features/features.prf:
1117
1118 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1119
1120         [Qt] Use config test to determine if the compiler supports -MD
1121
1122         We used to assume that unix systems building against Qt5 would have
1123         a compiler that supported -MD. Although this was usually the case,
1124         we failed to take into account broken tools for distributed builds
1125         (e.g. teambuilder or icecream) which would end up producing .d files
1126         in the root of the build dir instead of along-side the object file.
1127
1128         Now that we use a config-test to determine the support, we'll capture
1129         those cases, unless distributed builds are enabled after the initial
1130         build-webkit run.
1131
1132         Reviewed by Csaba Osztrogonác.
1133
1134         * Tools.pro:
1135         * qmake/config.tests/gccdepends/empty.cpp: Added.
1136         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
1137         * qmake/mkspecs/features/default_pre.prf:
1138         * qmake/mkspecs/features/features.prf:
1139         * qmake/mkspecs/features/unix/default_pre.prf:
1140         * qmake/sync.profile:
1141
1142 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1143
1144         REGRESSION(r109294): It broke the unittest of master.cfg
1145         https://bugs.webkit.org/show_bug.cgi?id=80253
1146
1147         Reviewed by Tor Arne Vestbø.
1148
1149         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
1150         (BuildBotConfigLoader._create_mock_passwords_dict):
1151         (BuildBotConfigLoader._mock_open):
1152         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
1153         (BuildBotConfigLoader.load_config):
1154
1155 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1156
1157         Qt API test buildstep throws exception after buildmaster update
1158         https://bugs.webkit.org/show_bug.cgi?id=80249
1159
1160         This patch based on Peter Gal's work.
1161
1162         Reviewed by Csaba Osztrogonác.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1165         (RunQtAPITests):
1166         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
1167
1168 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1169
1170         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
1171
1172         Reviewed by Simon Hausmann.
1173         Reviewed by Ossy.
1174
1175         * DumpRenderTree/qt/DumpRenderTree.pro:
1176         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1177         (WebKit::initializeTestFonts):
1178         * QtTestBrowser/QtTestBrowser.pro:
1179         * WebKitTestRunner/InjectedBundle/Target.pri:
1180         * qmake/mkspecs/features/features.prf:
1181
1182 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1183
1184         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
1185
1186         Reviewed by Ossy.
1187
1188         * qmake/mkspecs/features/default_post.prf:
1189
1190 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1191
1192         [Qt] Make sure clean builds are followed by make qmake && make if needed
1193
1194         On non-GNUmake systems we have to run make qmake so that the generated
1195         sources are generated before we run qmake on the target pro files. This
1196         is achieved by using the 'incremental' target.
1197
1198         Reviewed by Ossy.
1199
1200         * Scripts/webkitdirs.pm:
1201         (buildQMakeProjects):
1202
1203 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
1204
1205         DumpRenderTree should support preciseTime()
1206         https://bugs.webkit.org/show_bug.cgi?id=80397
1207
1208         Reviewed by Gavin Barraclough.
1209
1210         * DumpRenderTree/LayoutTestController.cpp:
1211         (preciseTimeCallback):
1212         (LayoutTestController::staticFunctions):
1213
1214 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1215
1216         Unreviewed, rolling out r109887.
1217         http://trac.webkit.org/changeset/109887
1218         https://bugs.webkit.org/show_bug.cgi?id=80402
1219
1220         It broke the build (Requested by Ossy on #webkit).
1221
1222         * DumpRenderTree/qt/DumpRenderTree.pro:
1223         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1224         (WebKit::initializeTestFonts):
1225         * QtTestBrowser/QtTestBrowser.pro:
1226         * WebKitTestRunner/InjectedBundle/Target.pri:
1227         * qmake/mkspecs/features/features.prf:
1228
1229 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1230
1231         Unreviewed, rolling out r109837.
1232         http://trac.webkit.org/changeset/109837
1233         https://bugs.webkit.org/show_bug.cgi?id=80399
1234
1235         breaks Mac Productions builds, too late to try and fix it
1236         tonight (Requested by eseidel on #webkit).
1237
1238         * Scripts/build-webkit:
1239
1240 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1241
1242         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
1243
1244         Reviewed by Simon Hausmann.
1245
1246         * DumpRenderTree/qt/DumpRenderTree.pro:
1247         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1248         (WebKit::initializeTestFonts):
1249         * QtTestBrowser/QtTestBrowser.pro:
1250         * WebKitTestRunner/InjectedBundle/Target.pri:
1251         * qmake/mkspecs/features/features.prf:
1252
1253 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1254
1255         [Qt] Create EWS to build WebKit2
1256         https://bugs.webkit.org/show_bug.cgi?id=80277
1257
1258         Reviewed by Csaba Osztrogonác.
1259
1260         * QueueStatusServer/model/queues.py:
1261         (Queue):
1262         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1263         (QtWK2EWS):
1264         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1265         (EarlyWarningSytemTest.test_builder_ewses):
1266
1267 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1268
1269         Unreviewed, rolling out r109733.
1270         http://trac.webkit.org/changeset/109733
1271         https://bugs.webkit.org/show_bug.cgi?id=80378
1272
1273         It broke Qt5 build system (Requested by Ossy on #webkit).
1274
1275         * Tools.pro:
1276         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1277         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1278         * qmake/mkspecs/features/default_pre.prf:
1279         * qmake/mkspecs/features/features.prf:
1280         * qmake/mkspecs/features/unix/default_pre.prf:
1281         * qmake/sync.profile:
1282
1283 2012-03-05  Eric Seidel  <eric@webkit.org>
1284
1285         Update JavaScriptCore files to use fully-qualified WTF include path
1286         https://bugs.webkit.org/show_bug.cgi?id=79960
1287
1288         Reviewed by Adam Barth.
1289
1290         Build WTF/WTF.xcodeproj by default on Mac.
1291
1292         * Scripts/build-webkit:
1293
1294 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1295
1296         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
1297         https://bugs.webkit.org/show_bug.cgi?id=69590
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
1302         to skip the 'optimize-expectations' step.
1303
1304         * Scripts/webkitpy/tool/commands/rebaseline.py:
1305         (RebaselineExpectations.__init__):
1306         (RebaselineExpectations.execute):
1307         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1308
1309 2012-03-05  Kent Tamura  <tkent@chromium.org>
1310
1311         [Chromium] Add new popup type: PagePopup
1312         https://bugs.webkit.org/show_bug.cgi?id=80106
1313
1314         Reviewed by Darin Fisher.
1315
1316         * DumpRenderTree/chromium/WebViewHost.cpp:
1317         (WebViewHost::createPopupMenu):
1318
1319 2012-03-05  Jessie Berlin  <jberlin@apple.com>
1320
1321         Add myself as a reviewer.
1322
1323         * Scripts/webkitpy/common/config/committers.py:
1324         Also, add my IRC nick so it is easier to find and yell at me.
1325
1326 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
1327
1328         Correctly compute the positions of GestureScroll* events on
1329         Chromium.
1330         https://bugs.webkit.org/show_bug.cgi?id=80075
1331
1332         Reviewed by Adam Barth.
1333
1334         * DumpRenderTree/chromium/EventSender.cpp:
1335         (EventSender::reset):
1336         (EventSender::gestureEvent):
1337         * DumpRenderTree/chromium/EventSender.h:
1338         (EventSender):
1339
1340 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1341
1342         flakiness dashboard doesn't display baselines for virtual tests correctly
1343         https://bugs.webkit.org/show_bug.cgi?id=80341
1344
1345         Reviewed by Ojan Vafai.
1346
1347         If the test is part of a virtual test suite, we need to look for
1348         baselines in the underlying fallback path for the actual test
1349         being run, as well as baselines for the virtual version.
1350
1351         This patch adds code to handle both branches and also pulls the
1352         mapping of the test suites up into a constant.
1353
1354         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1355         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1356         (testLookupVirtualTestSuite):
1357         (testBaseTest):
1358
1359 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1360
1361         Unreviewed, rolling out r109760.
1362         http://trac.webkit.org/changeset/109760
1363         https://bugs.webkit.org/show_bug.cgi?id=80320
1364
1365         Caused many GTK+ tests to crash (Requested by mrobinson on
1366         #webkit).
1367
1368         * gtk/jhbuild.modules:
1369
1370 2012-03-05  Charlie Reis  <creis@chromium.org>
1371
1372         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
1373         https://bugs.webkit.org/show_bug.cgi?id=80057
1374
1375         Reviewed by Darin Fisher.
1376
1377         * DumpRenderTree/chromium/WebViewHost.cpp:
1378         (WebViewHost::createView):
1379         * DumpRenderTree/chromium/WebViewHost.h:
1380         (WebViewHost):
1381
1382 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
1383
1384         [soup] Crash while loading http://www.jusco.cn
1385         https://bugs.webkit.org/show_bug.cgi?id=68238
1386
1387         Reviewed by Philippe Normand.
1388
1389         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
1390         in the jhbuild file.
1391
1392 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1393
1394         Unreviewed, rolling out r109748.
1395         http://trac.webkit.org/changeset/109748
1396         https://bugs.webkit.org/show_bug.cgi?id=80296
1397
1398         Made some tests crash, will fix and recommit (Requested by
1399         noamr on #webkit).
1400
1401         * MiniBrowser/qt/main.cpp:
1402         (main):
1403
1404 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
1405
1406         [GTK] plugins/netscape-plugin-page-cache-works.html fails
1407         https://bugs.webkit.org/show_bug.cgi?id=74409
1408
1409         Reviewed by Martin Robinson.
1410
1411         Add support for overriding the page-cache-for-plugins preference
1412         through DumpRenderTreeSupport.
1413
1414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1415         (booleanFromValue): A helper function to convert a string to boolean.
1416         (LayoutTestController::overridePreference):
1417
1418 2012-03-05  Rob Buis  <rbuis@rim.com>
1419
1420         [BlackBerry] Update Tools/DumpRenderTree
1421         https://bugs.webkit.org/show_bug.cgi?id=80287
1422
1423         Reviewed by Antonio Gomes.
1424
1425         Update so we are sure we can build our implementation of DRT.
1426
1427         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
1428         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
1429         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
1430         (AccessibilityController::addNotificationListener): add missing hook.
1431         (AccessibilityController::removeNotificationListener): add missing hook.
1432         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1433         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
1434         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1435         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
1436         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
1437
1438 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
1439
1440         [Qt] [WK2] Support threaded renderer in WK2
1441         https://bugs.webkit.org/show_bug.cgi?id=76661
1442
1443         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
1444
1445         Reviewed by Kenneth Rohde Christiansen.
1446
1447         * MiniBrowser/qt/main.cpp:
1448         (main):
1449
1450 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1451
1452         Unreviewed. Add myself to committer list.
1453
1454         * Scripts/webkitpy/common/config/committers.py:
1455
1456 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1457
1458         [Qt] Use config test to determine if the compiler supports -MD
1459
1460         We used to assume that unix systems building against Qt5 would have
1461         a compiler that supported -MD. Although this was usually the case,
1462         we failed to take into account broken tools for distributed builds
1463         (e.g. teambuilder or icecream) which would end up producing .d files
1464         in the root of the build dir instead of along-side the object file.
1465
1466         Now that we use a config-test to determine the support, we'll capture
1467         those cases, unless distributed builds are enabled after the initial
1468         build-webkit run.
1469
1470         Reviewed by Csaba Osztrogonác.
1471
1472         * Tools.pro:
1473         * qmake/config.tests/gccdepends/empty.cpp: Added.
1474         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
1475         * qmake/mkspecs/features/default_pre.prf:
1476         * qmake/mkspecs/features/features.prf:
1477         * qmake/mkspecs/features/unix/default_pre.prf:
1478         * qmake/sync.profile:
1479
1480 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1481
1482         Qt API test buildstep throws exception after buildmaster update
1483         https://bugs.webkit.org/show_bug.cgi?id=80249
1484
1485         Reviewed by Zoltan Herczeg.
1486
1487         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
1488         (BuildAndTestFactory.__init__):
1489
1490 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1491
1492         [GTK] Unit tests are noisy when run under jhbuild
1493         https://bugs.webkit.org/show_bug.cgi?id=80241
1494
1495         Reviewed by Philippe Normand.
1496
1497         Force the 'memory' backend in GSettings so that each unit
1498         test doesn't produce a warning when it's forced to fall back
1499         to the 'memory' backend.
1500
1501         * Scripts/run-gtk-tests:
1502         (TestRunner.run): Force the 'memory' backend.
1503
1504 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1505
1506         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
1507         https://bugs.webkit.org/show_bug.cgi?id=80235
1508
1509         Reviewed by Philippe Normand.
1510
1511         * Scripts/run-gtk-tests:
1512         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
1513         inspector resources path determination is shared by all tests.
1514
1515 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1516
1517         [GTK] REGRESSION: r108278 broke some tests that expect focus
1518         https://bugs.webkit.org/show_bug.cgi?id=79084
1519
1520         Reviewed by Philippe Normand.
1521
1522         Grab focus when dumping test results and also when sending
1523         events. During the course of testing, the WebView may lose
1524         focus and this seems to snap it back when tests demand it.
1525
1526         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1527         (dump): Grab focus.
1528         * DumpRenderTree/gtk/EventSender.cpp:
1529         (dispatchEvent): Ditto.
1530
1531 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
1532
1533         Unreviewed, Add myself to committer list.
1534         https://bugs.webkit.org/show_bug.cgi?id=80232
1535
1536         * Scripts/webkitpy/common/config/committers.py:
1537
1538 2012-03-04  Anders Carlsson  <andersca@apple.com>
1539
1540         Newer versions of clang fail to compile WebKit.
1541
1542         Fix build.
1543
1544         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1545         (descriptionOfValue):
1546         (AccessibilityUIElement::rowIndexRange):
1547         (AccessibilityUIElement::columnIndexRange):
1548         (AccessibilityUIElement::selectedTextRange):
1549         * DumpRenderTree/mac/EditingDelegate.mm:
1550         (-[DOMRange dump]):
1551         * DumpRenderTree/mac/PolicyDelegate.mm:
1552         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
1553         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1554         (-[NSError _drt_descriptionSuitableForTestResult]):
1555         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1556         (WTR::descriptionOfValue):
1557         (WTR::AccessibilityUIElement::rowIndexRange):
1558         (WTR::AccessibilityUIElement::columnIndexRange):
1559         (WTR::AccessibilityUIElement::selectedTextRange):
1560
1561 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
1562
1563         [Qt] Fix static_libs_as_shared build
1564         https://bugs.webkit.org/show_bug.cgi?id=80214
1565
1566         Reviewed by Tor Arne Vestbø.
1567
1568         * WebKitTestRunner/qt/main.cpp:
1569         (main): Set the correct environment variable for choosing the theme in the
1570         web process.
1571
1572 2012-03-03  Hans Wennborg  <hans@chromium.org>
1573
1574         Implement Speech JavaScript API
1575         https://bugs.webkit.org/show_bug.cgi?id=80019
1576
1577         Reviewed by Adam Barth.
1578
1579         Add ENABLE_SCRIPTED_SPEECH.
1580
1581         * Scripts/build-webkit:
1582         * qmake/mkspecs/features/features.prf:
1583
1584 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
1585
1586         Fix commit queue, remove duplicate entry.
1587
1588         * Scripts/webkitpy/common/config/committers.py:
1589
1590 2012-03-02  Stephen Chenney  <schenney@chromium.org>
1591
1592         Unreviewed, add myself as a committer
1593
1594         * Scripts/webkitpy/common/config/committers.py:
1595
1596 2012-03-02  Ojan Vafai  <ojan@chromium.org>
1597
1598         Add the Chromium Lion canary bot to the flakiness dashboard.
1599         * TestResultServer/static-dashboards/builders.js:
1600
1601 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
1602
1603         links for virtual tests are broken in the flakiness dashboard
1604         https://bugs.webkit.org/show_bug.cgi?id=80180
1605
1606         Reviewed by Ojan Vafai.
1607
1608         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1609         (linkHTMLToOpenWindow):
1610         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1611         (testLinkHTMLToOpenWindow): added.
1612
1613 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1614
1615         [GTK] security/block-test.html baselines differ from mac
1616         https://bugs.webkit.org/show_bug.cgi?id=78343
1617
1618         Reviewed by Martin Robinson.
1619
1620         Improved the FrameLoader error heuristics to match mac behavior a
1621         bit more.
1622
1623         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1624         (pathFromSoupURI): Handle ftp urls the same as http urls.
1625         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
1626
1627 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1628
1629         [Qt][WK2] Fix typo in patch committed in r109575
1630
1631         Unreviewed typo fix.
1632
1633         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1634         (MiniBrowserApplication::notify): Cache the position
1635         in floating point coordinates.
1636
1637 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1638
1639         [Qt][WK2] Infinite loop on history navigation, when panning
1640         https://bugs.webkit.org/show_bug.cgi?id=79119
1641
1642         Reviewed by Simon Hausmann.
1643
1644         Make the touch mocking more robust by creating touch events
1645         directly and sending them synchronously to the browser window.
1646         If the sent touch event was not accepted we propagate the
1647         original mouse event to its target.
1648         This way we make sure we only send either a touch or a mouse
1649         event and do not end up in an infinite loop between our mocking
1650         code and the Qt5 automatic mouse event synthesizing.
1651
1652         * MiniBrowser/qt/BrowserWindow.cpp:
1653         (BrowserWindow::updateVisualMockTouchPoints):
1654         * MiniBrowser/qt/BrowserWindow.h:
1655         (BrowserWindow):
1656         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1657         (touchRectForPosition):
1658         (MiniBrowserApplication::notify):
1659         (MiniBrowserApplication::sendTouchEvent):
1660         * MiniBrowser/qt/MiniBrowserApplication.h:
1661         (MiniBrowserApplication):
1662
1663 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1664
1665         [Qt] Use 'all' as default target when debug_and_release is in effect
1666
1667         When debug_and_release is enabled, in combination with build_all,
1668         qmake will generate an aggregate makefile that calls make on both
1669         the debug and the release makefiles, but with the 'all' target.
1670
1671         In this case we can't use 'first' as the default target, as the
1672         extra targets would then not be run, so we append extra targets
1673         to 'all' instead.
1674
1675         Reviewed by Simon Hausmann.
1676
1677         * qmake/mkspecs/features/default_post.prf:
1678
1679 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1680
1681         [Qt] Make sure activeBuildConfig() returns the right config
1682
1683         Using isActiveConfig fails, as that only checks if the given
1684         argument is in CONFIG, not the order.
1685
1686         Reviewed by Simon Hausmann.
1687
1688         * qmake/mkspecs/features/functions.prf:
1689
1690 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
1691
1692         [Qt] Fix tests run with WTR not using QStyle theme
1693         https://bugs.webkit.org/show_bug.cgi?id=80147
1694
1695         Reviewed by Csaba Osztrogonác.
1696
1697         * WebKitTestRunner/qt/main.cpp:
1698         (main): Set environment variable for web process to use QStyle theme.
1699
1700 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1701
1702         Unreviewed, remove debug print call.
1703
1704         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1705         (descriptionSuitableForTestResult):
1706
1707 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
1708
1709         Updated EventSender to send complete gesture events.
1710         https://bugs.webkit.org/show_bug.cgi?id=80075
1711
1712         Reviewed by Adam Barth.
1713
1714         * DumpRenderTree/chromium/EventSender.cpp:
1715         (EventSender::gestureEvent): set additional parameters in sent events.
1716
1717 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1718
1719         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
1720         https://bugs.webkit.org/show_bug.cgi?id=80033
1721
1722         Reviewed by Gustavo Noronha Silva.
1723
1724         GCC 4.7 no longer includes unistd.h from most of the standard C++
1725         header files, so we need to explicitly include it for getcwd().
1726
1727         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
1728         not only on Mac, but on all Unix platforms.
1729
1730 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1731
1732         Actually look at the args in driver_input :(.
1733
1734         Unreviewed, build fix.
1735
1736         * Scripts/webkitpy/layout_tests/port/chromium.py:
1737         (ChromiumDriver.run_test):
1738
1739 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1740
1741         Fix typo in flag used to run gpu virtual suites.
1742
1743         Unreviewed, build fix.
1744
1745         * Scripts/webkitpy/layout_tests/port/chromium.py:
1746         (ChromiumPort.virtual_test_suites):
1747
1748 2012-03-01  Adam Barth  <abarth@webkit.org>
1749
1750         Unreviewed, rolling out r109317.
1751         http://trac.webkit.org/changeset/109317
1752
1753         Let's try watchlists again now that we're using a pure git
1754         working copy
1755
1756         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1757         (StyleQueueTask.run):
1758         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1759
1760 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1761
1762         webkitpy: test_run_test_pause_before_testing is failing after r109482
1763         https://bugs.webkit.org/show_bug.cgi?id=80084
1764
1765         Unreviewed, build fix.
1766
1767         Fixes the test string compare to ignore the time spent running
1768         the tests.
1769
1770         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1771         (test_run_test_pause_before_testing):
1772
1773 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1774
1775         nrwt: virtual tests aren't being run
1776         https://bugs.webkit.org/show_bug.cgi?id=80083
1777
1778         Reviewed by Eric Seidel.
1779
1780         If we tried to run all of the tests by default (and
1781         didn't specify any paths), the virtual tests weren't
1782         picked up.
1783
1784         * Scripts/webkitpy/layout_tests/port/base.py:
1785         (Port._virtual_tests):
1786         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1787         (PortTest.test_tests):
1788         * Scripts/webkitpy/layout_tests/port/test.py:
1789         (TestPort.virtual_test_suites):
1790
1791 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1792
1793         run-perf-tests should report the test runtime
1794         https://bugs.webkit.org/show_bug.cgi?id=80078
1795
1796         Reviewed by Hajime Morita.
1797
1798         Record and output the aggreated test run time.
1799
1800         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1801         (PerfTestsRunner._run_single_test):
1802
1803 2012-03-01  Michael Nordman  <michaeln@google.com>
1804
1805         [chromium] Use webkit_support to create session storage namespaces in DRT.
1806         https://bugs.webkit.org/show_bug.cgi?id=79933
1807
1808         Reviewed by Tony Chang.
1809
1810         * DumpRenderTree/chromium/WebViewHost.cpp:
1811         (WebViewHost::createSessionStorageNamespace):
1812
1813 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1814
1815         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
1816         https://bugs.webkit.org/show_bug.cgi?id=80048
1817
1818         Reviewed by Adam Barth.
1819
1820         * Scripts/webkitpy/layout_tests/port/base.py:
1821         (Port.test_isfile):
1822         (Port.test_isdir):
1823         (Port):
1824         (Port.test_exists):
1825         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1826         (PortTest.test_test_exists):
1827         (PortTest):
1828         (PortTest.test_test_isfile):
1829         (PortTest.test_test_isdir):
1830         * Scripts/webkitpy/layout_tests/port/test.py:
1831         (TestPort.virtual_test_suites):
1832         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1833         (MainTest.test_virtual):
1834
1835 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1836
1837         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
1838         https://bugs.webkit.org/show_bug.cgi?id=80031
1839
1840         Reviewed by Gustavo Noronha Silva.
1841
1842         Only build the libTestRunnerInjectedBundle.la convenience library when
1843         ENABLE_WEBKIT2 is defined.
1844
1845         * WebKitTestRunner/GNUmakefile.am:
1846
1847 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1848
1849         Unreviewed, second attempt to fix GTK NRWT after r109242.
1850
1851         * Scripts/webkitpy/layout_tests/port/gtk.py:
1852         (GtkDriver._start):
1853
1854 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1855
1856         Unreviewed, GTK NRWT build fix attempt after r109242.
1857
1858         * Scripts/webkitpy/layout_tests/port/gtk.py:
1859         (GtkDriver._start):
1860
1861 2012-03-01  Kentaro Hara  <haraken@chromium.org>
1862
1863         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
1864         https://bugs.webkit.org/show_bug.cgi?id=80008
1865
1866         Reviewed by Adam Barth.
1867
1868         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
1869         to "preprocess-idls.pl". This patch renames it.
1870
1871         Test: Confirm that run-bindings-tests runs.
1872
1873         * Scripts/webkitpy/bindings/main.py:
1874         (BindingsTests.generate_supplemental_dependency):
1875
1876 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
1877
1878         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
1879         https://bugs.webkit.org/show_bug.cgi?id=78047
1880
1881         Reviewed by Kenneth Rohde Christiansen.
1882
1883         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
1884         sending to the item requires the QObject::event re-implementation to dispatch to the correct
1885         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
1886         the event handlers directly, and with the removal of our own dispatching we need to go through
1887         that code path.
1888
1889         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1890         (WTR::PlatformWebView::sendEvent):
1891         (WTR::PlatformWebView::postEvent):
1892
1893 2012-02-29  Adam Barth  <abarth@webkit.org>
1894
1895         Disable watchlist.  It's been spamming CCs.
1896
1897         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1898         (StyleQueueTask.run):
1899         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1900
1901 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1902
1903         need to clone the gpu baselines and expectations into the new "virtual" dir
1904         https://bugs.webkit.org/show_bug.cgi?id=79956
1905
1906         Reviewed by Adam Barth.
1907
1908         * Scripts/webkitpy/layout_tests/port/chromium.py:
1909         (ChromiumPort.virtual_test_suites):
1910
1911 2012-02-29  Mark Rowe  <mrowe@apple.com>
1912
1913         Switch to using json rather than simplejson now that the master is using Python 2.7.
1914
1915         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1916         (loadBuilderConfig):
1917
1918 2012-02-29  David Levin  <levin@chromium.org>
1919
1920         [chromium] Add the ability to turn off autoresize.
1921         https://bugs.webkit.org/show_bug.cgi?id=77452
1922
1923         Reviewed by Darin Fisher.
1924
1925         * DumpRenderTree/chromium/LayoutTestController.cpp:
1926         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
1927         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
1928         (LayoutTestController::disableAutoResizeMode):  Ditto.
1929         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
1930
1931 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1932
1933         nrwt: make --print trace work with virtual tests
1934         https://bugs.webkit.org/show_bug.cgi?id=79952
1935
1936         Reviewed by Adam Barth.
1937
1938         * Scripts/webkitpy/layout_tests/views/printing.py:
1939         (Printer._print_test_trace):
1940         (Printer._print_baseline):
1941
1942 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
1943
1944         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
1945         https://bugs.webkit.org/show_bug.cgi?id=79849
1946
1947         Reviewed by Beth Dakin.
1948
1949         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1950         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
1951
1952 2012-02-29  Lucas Forschler  <lforschler@apple.com>
1953
1954         Removed unused Apple buildslaves from the master configuration
1955         https://bugs.webkit.org/show_bug.cgi?id=79925
1956
1957         Reviewed by Stephanie Lewis.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/config.json:
1960
1961 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1962
1963         nrwt: implement simple 'virtual test suite' support
1964         https://bugs.webkit.org/show_bug.cgi?id=79737
1965
1966         Reviewed by Adam Barth.
1967
1968         Add very basic support for 'virtual test suites' to NRWT:
1969         a virtual suite is a directory that may contain new baselines,
1970         contains a pointer to a "base" directory of tests, and an
1971         optional list of command line arguments to pass to DRT;
1972         it gives us a way to run all of the tests in a given directory
1973         multiple times with multiple (potentially differing) sets of
1974         results and baselines.
1975
1976         This patch implements the support needed for this feature, and
1977         some basic tests, but no actual port will use the feature yet.
1978
1979         This is probably the simplest implementation possible - the
1980         list of virtual suites will be hard-coded into the port's
1981         implementation. One can imagine a more data-driven approach
1982         where the suite instructions are stored in a manifest file
1983         either in LayoutTests (all suites in one file), or per-port,
1984         or per-directory. If this feature ends up being useful we
1985         should probably add something like that so people don't have
1986         to hunt around in the code to add suites.
1987
1988         * Scripts/webkitpy/layout_tests/port/base.py:
1989         (Port.__init__):
1990         (Port.expected_filename):
1991         (Port.tests):
1992         (Port):
1993         (Port._real_tests):
1994         (Port._driver_class):
1995         (Port.virtual_test_suites):
1996         (Port.virtual_suite):
1997         (Port.virtual_suite.VirtualTestSuite):
1998         (Port.virtual_suite.VirtualTestSuite.__init__):
1999         (Port.virtual_suite.VirtualTestSuite.__repr__):
2000         (Port.populated_virtual_test_suites):
2001         (Port._virtual_tests):
2002         (Port.lookup_virtual_test_base):
2003         (Port.lookup_virtual_test_args):
2004         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2005         (PortTest.test_find_with_skipped_directories):
2006         * Scripts/webkitpy/layout_tests/port/driver.py:
2007         (DriverInput.__init__):
2008         (DriverProxy.run_test):
2009         * Scripts/webkitpy/layout_tests/port/test.py:
2010         (TestPort.virtual_test_suites):
2011         (TestDriver.run_test):
2012         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2013         (MainTest.test_all):
2014         (MainTest.test_virtual):
2015
2016 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2017
2018         nrwt: support more than two drivers in DriverProxy
2019         https://bugs.webkit.org/show_bug.cgi?id=79736
2020
2021         Reviewed by Adam Barth.
2022
2023         Now that we can support per-test command lines for
2024         Drivers, modify DriverProxy to keep a map of running
2025         drivers for each needed command-line; this will allow
2026         us to transparently maintain a pool of appropriately
2027         configured DRTs without having to constantly start and stop
2028         them.
2029
2030         Note that this potentially raises a garbage collection
2031         problem - the number of running DRTs will grow with the
2032         number of different sets of command line args. For now
2033         this is no worse than the current code - if you're running
2034         with pixel tests, you will only need one DRT per worker,
2035         and if you aren't, you'll need two (one for text-only tests,
2036         and one for reftests).
2037
2038         An alternative would be to only ever have one running driver,
2039         and restart the driver as the command line changes, but this
2040         might (?) slow down execution in the text-only case - we
2041         should benchmark this because it would be simpler and possibly
2042         allow us to eliminate DriverProxy altogether.
2043
2044         * Scripts/webkitpy/layout_tests/port/driver.py:
2045         (DriverProxy.__init__):
2046         (DriverProxy):
2047         (DriverProxy._make_driver):
2048         (DriverProxy.run_test):
2049         (DriverProxy.has_crashed):
2050         (DriverProxy.stop):
2051         (DriverProxy.cmd_line):
2052         (DriverProxy._cmd_line_as_key):
2053
2054 2012-02-29  Adrienne Walker  <enne@google.com>
2055
2056         Unreviewed, add myself as a reviewer
2057
2058         * Scripts/webkitpy/common/config/committers.py:
2059
2060 2012-02-29  Greg Billock  <gbillock@google.com>
2061
2062         Add more tests for web intents
2063         https://bugs.webkit.org/show_bug.cgi?id=79527
2064
2065         Reviewed by Adam Barth.
2066
2067         * DumpRenderTree/chromium/LayoutTestController.cpp:
2068         (LayoutTestController::LayoutTestController):
2069         (LayoutTestController::sendWebIntentResponse):
2070         * DumpRenderTree/chromium/LayoutTestController.h:
2071         (LayoutTestController):
2072         * DumpRenderTree/chromium/WebViewHost.h:
2073         (WebViewHost):
2074         (WebViewHost::currentIntentRequest):
2075
2076 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2077
2078         nrwt: port/Driver needs to support per-test command line args
2079         https://bugs.webkit.org/show_bug.cgi?id=79733
2080
2081         Reviewed by Adam Barth.
2082
2083         As part of removing the 'gpu' configurations and adding support
2084         for 'virtual test suites', the Driver classes need to support
2085         per-test command lines (since different tests will need to be
2086         run with different command line options).
2087
2088         The per-test args are not yet used, so this change should have
2089         no visible effects and need no additional testing.
2090
2091         * Scripts/webkitpy/layout_tests/port/base.py:
2092         (Port.driver_cmd_line):
2093         * Scripts/webkitpy/layout_tests/port/chromium.py:
2094         (ChromiumDriver.cmd_line):
2095         (ChromiumDriver._start):
2096         (ChromiumDriver.start):
2097         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2098         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
2099         (ChromiumDriverTest):
2100         (ChromiumDriverTest.test_two_drivers):
2101         * Scripts/webkitpy/layout_tests/port/driver.py:
2102         (Driver.cmd_line):
2103         (DriverProxy.__init__):
2104         (DriverProxy.start):
2105         (DriverProxy.cmd_line):
2106         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2107         (DriverTest.test_virtual_driver_methods):
2108         * Scripts/webkitpy/layout_tests/port/gtk.py:
2109         (GtkDriver.cmd_line):
2110         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2111         * Scripts/webkitpy/layout_tests/port/test.py:
2112         (TestPort._path_to_driver):
2113         (TestDriver.cmd_line):
2114         (TestDriver.start):
2115         * Scripts/webkitpy/layout_tests/port/webkit.py:
2116         (WebKitDriver.cmd_line):
2117         (WebKitDriver._start):
2118         (WebKitDriver.run_test):
2119         (WebKitDriver.start):
2120         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2121         (WebKitDriverTest.test_no_timeout):
2122         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2123         (PerfTestsRunner._run_tests_set):
2124         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2125         (test_run_test_pause_before_testing):
2126
2127 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2128
2129         perftestsrunner can call printer.write() after printer.cleanup()
2130         https://bugs.webkit.org/show_bug.cgi?id=79872
2131
2132         Reviewed by Ryosuke Niwa.
2133
2134         This patch fixes a unittest that was incorrectly calling
2135         PerfTestsRunner.run() twice (which led to a weird state in the
2136         printer object).
2137
2138         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2139         (MainTest.test_run_with_upload_json):
2140
2141 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
2142
2143         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2144         https://bugs.webkit.org/show_bug.cgi?id=76546
2145
2146         Reviewed by Simon Hausmann.
2147
2148         Revert the workaround introduced in r107868 and reintroduce
2149         the qml binding so we can test the code path that we are more
2150         interested in. The reason that it did not work before is that
2151         we don't have an active platform window which we now workaround
2152         by propagating the resize through QWindowSystemInterface.
2153
2154         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2155         (WTR::WrapperWindow::handleStatusChanged):
2156         (WTR::PlatformWebView::resizeTo):
2157
2158 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
2159
2160         [GTK] Small fix for cross compilation to not generate gtkdoc.
2161
2162         Rubber-stamped by Csaba Osztrogonác.
2163
2164         * Scripts/webkitdirs.pm:
2165         (isCrossCompilation):
2166
2167 2012-02-28  Lucas Forschler  <lforschler@apple.com>
2168
2169         Fix a typo in config.json
2170         linx -> linux
2171         
2172         * BuildSlaveSupport/build.webkit.org-config/config.json:
2173
2174 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2175
2176         [Qt] Allow read/write to the WebView.url property
2177         https://bugs.webkit.org/show_bug.cgi?id=77554
2178
2179         Reviewed by Tor Arne Vestbø.
2180
2181         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
2182
2183         * MiniBrowser/qt/qml/BrowserWindow.qml:
2184
2185 2012-02-28  Dan Winship  <danw@gnome.org>
2186
2187         [GTK] make tests explicitly request GSettingsBackendMemory
2188         https://bugs.webkit.org/show_bug.cgi?id=79788
2189
2190         Reviewed by Martin Robinson.
2191
2192         Explicitly request the fallback memory-based GSettings backend; if
2193         other backends are available then we don't want to use them,
2194         because they would make tests depend on the user's preferences.
2195         And if other backends aren't available, we don't need glib to
2196         print a warning about that fact.
2197
2198         * Scripts/webkitpy/layout_tests/port/gtk.py:
2199         (GtkPort.setup_environ_for_server):
2200
2201 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2202
2203         Unreviewed, rolling out r109110.
2204         http://trac.webkit.org/changeset/109110
2205         https://bugs.webkit.org/show_bug.cgi?id=79806
2206
2207         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
2208         (Requested by aroben on #webkit).
2209
2210         * Scripts/webkitpy/common/checkout/changelog.py:
2211         (parse_bug_id):
2212         (parse_bug_id_from_changelog):
2213         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2214         * Scripts/webkitpy/common/config/urls.py:
2215
2216 2012-02-28  Adam Roben  <aroben@webkit.org>
2217
2218         Add my new email address
2219
2220         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
2221
2222         Reviewed by Anders Carlsson.
2223
2224         * Scripts/webkitpy/common/config/committers.py:
2225
2226 2012-02-28  Adam Roben  <aroben@apple.com>
2227
2228         Teach webkitpy about wkb.ug URLs
2229
2230         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
2231         use wkb.ug URLs
2232
2233         Reviewed by Anders Carlsson.
2234
2235         * Scripts/webkitpy/common/checkout/changelog.py:
2236         (parse_bug_id):
2237         (parse_bug_id_from_changelog):
2238         Fall back to the tiny URL format if neither the short nor long URL formats work.
2239
2240         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2241         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
2242
2243         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
2244         wkb.ug URLs.
2245
2246 2012-02-28  János Badics  <dicska@gmail.com>
2247
2248         [Qt] build-webkit does not detect the number of CPUs
2249         https://bugs.webkit.org/show_bug.cgi?id=76445
2250
2251         Based on Seo Sanghyeon's work (modification:
2252         Automatically determine the number of CPUs for make
2253         only if -j make argument haven't already been specified.)
2254
2255         Reviewed by Csaba Osztrogonác.
2256
2257         * Scripts/webkitdirs.pm:
2258         (buildQMakeProjects):
2259
2260 2012-02-28  Kent Tamura  <tkent@chromium.org>
2261
2262         Update a pattern for forms files of watchlist
2263         https://bugs.webkit.org/show_bug.cgi?id=79767
2264
2265         Reviewed by Kentaro Hara.
2266
2267         * Scripts/webkitpy/common/config/watchlist:
2268         Catches the following files with the "Forms" pattern.
2269         - HTMLDatListElement.*
2270         - HTMLKeygenElement.*
2271         - HTMLLegendElement.*
2272         - HTMLOutputElement.*
2273         - FormAssociatedElement.*
2274         - SliderThumbElement.*
2275         - TextControlInnerElements.*
2276         - RenderFileUploadControl.*
2277
2278 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2279
2280         Unreviewed, rolling out r109041.
2281         http://trac.webkit.org/changeset/109041
2282         https://bugs.webkit.org/show_bug.cgi?id=79741
2283
2284         Broke Chromium Win build (Requested by bashi on #webkit).
2285
2286         * DumpRenderTree/chromium/LayoutTestController.cpp:
2287         (LayoutTestController::LayoutTestController):
2288         * DumpRenderTree/chromium/LayoutTestController.h:
2289         (LayoutTestController):
2290         * DumpRenderTree/chromium/WebViewHost.h:
2291
2292 2012-02-27  James Robinson  <jamesr@chromium.org>
2293
2294         [chromium] Remove media tests from ChromiumGpu configurations
2295         https://bugs.webkit.org/show_bug.cgi?id=79720
2296
2297         Reviewed by Adam Barth.
2298
2299         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
2300         composited playback path via tests in the compositing/ directory.
2301
2302         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2303         (_default_tests_paths):
2304         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2305         (ChromiumGpuTest.test_default_tests_paths):
2306         (ChromiumGpuTest.test_test_files):
2307
2308 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
2309
2310         nrwt: log multiline stderr/crash output properly
2311         https://bugs.webkit.org/show_bug.cgi?id=79722
2312
2313         Reviewed by Adam Barth.
2314
2315         This cleans up some nits in the log output to make things
2316         slightly easier to read (every line gets timestamped, etc.).
2317
2318         Also tweaks the log message for pixel hash mismatches.
2319
2320         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2321         (SingleTestRunner._handle_error):
2322         (SingleTestRunner._compare_image):
2323
2324 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2325
2326         Touch the master.cfg to force a reconfig.
2327
2328         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2329         (BuildAndTestLeaksFactory):
2330         (NewBuildAndTestFactory):
2331
2332 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
2333
2334         [BlackBerry] Upstream BlackBerry API web page related files
2335         https://bugs.webkit.org/show_bug.cgi?id=74380
2336
2337         Reviewed by Antonio Gomes.
2338
2339         Adapt to the removing of WebPage::mainFrame(), use
2340         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
2341
2342         No new tests as this patch doesn't change behavior.
2343
2344         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2345         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2346         (BlackBerry::WebKit::DumpRenderTree::runTests):
2347
2348 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2349
2350         Add Windows and Linux Chromium perf bots
2351         https://bugs.webkit.org/show_bug.cgi?id=79418
2352
2353         Reviewed by Tony Chang.
2354
2355         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
2356         the dedicated perf bot slave (uses the same hardware).
2357
2358         * BuildSlaveSupport/build.webkit.org-config/config.json:
2359
2360 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2361
2362         Undefined variable 'current' when running chromium_android.py
2363         https://bugs.webkit.org/show_bug.cgi?id=79696
2364
2365         Reviewed by Adam Barth.
2366
2367         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2368         (ChromiumAndroidDriver._read_prompt):
2369
2370 2012-02-27  Greg Billock  <gbillock@google.com>
2371
2372         Add more tests for web intents
2373         https://bugs.webkit.org/show_bug.cgi?id=79527
2374
2375         Reviewed by Adam Barth.
2376
2377         * DumpRenderTree/chromium/LayoutTestController.cpp:
2378         (LayoutTestController::LayoutTestController):
2379         (LayoutTestController::sendWebIntentResponse):
2380         * DumpRenderTree/chromium/LayoutTestController.h:
2381         (LayoutTestController):
2382         * DumpRenderTree/chromium/WebViewHost.h:
2383         (WebViewHost):
2384         (WebViewHost::currentIntentRequest):
2385
2386 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2387
2388         Chromium-Android layout test script: the adb shell prompt is not always '# '
2389         https://bugs.webkit.org/show_bug.cgi?id=79506
2390
2391         Reviewed by Adam Barth.
2392
2393         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2394         (ChromiumAndroidDriver._start):
2395         (ChromiumAndroidDriver._read_prompt):
2396
2397 2012-02-27  Dan Bernstein  <mitz@apple.com>
2398
2399         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
2400         https://bugs.webkit.org/show_bug.cgi?id=79607
2401
2402         Reviewed by Adele Peterson.
2403
2404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2405         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
2406         (TestWebKitAPI::AcceptsFirstMouse::url):
2407         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
2408         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2409         (TestWebKitAPI::TEST_F):
2410         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
2411
2412 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2413
2414         Unreviewed. Fix make distcheck.
2415
2416         * GNUmakefile.am: Fix typo.
2417
2418 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2419
2420         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
2421
2422         Reviewed by Kenneth Rohde Christiansen..
2423
2424         * qmake/mkspecs/features/features.prf:
2425
2426 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
2427
2428         Add a ChromiumGpuAndroid port.
2429         https://bugs.webkit.org/show_bug.cgi?id=79628
2430
2431         Reviewed by Adam Barth.
2432
2433         Android does have a gpu port, so revert r107697.
2434
2435         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2436         (ChromiumAndroidPort.__init__):
2437         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2438         (ChromiumGpuAndroidPort):
2439         (ChromiumGpuAndroidPort.__init__):
2440         (ChromiumGpuAndroidPort.baseline_search_path):
2441         (ChromiumGpuAndroidPort.default_child_processes):
2442         (ChromiumGpuAndroidPort.tests):
2443         * Scripts/webkitpy/layout_tests/port/factory.py:
2444         (PortFactory):
2445
2446 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2447
2448         Change Build bot with BuildAndTest bot for EFL port.
2449         https://bugs.webkit.org/show_bug.cgi?id=77518
2450
2451         Reviewed by Ryosuke Niwa.
2452
2453         EFL build bot starts to support layout test.
2454
2455         * BuildSlaveSupport/build.webkit.org-config/config.json:
2456         * BuildSlaveSupport/built-product-archive:
2457         (archiveBuiltProduct):
2458         (extractBuiltProduct):
2459         * BuildSlaveSupport/test-result-archive:
2460         (archiveTestResults):
2461         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
2462         (generateBuildSystemFromCMakeProject):
2463
2464 2012-02-24  Darin Fisher  <darin@chromium.org>
2465
2466         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
2467
2468         Reviewed by James Robinson.
2469
2470         * Scripts/webkitpy/common/config/watchlist:
2471
2472 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2473
2474         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
2475         https://bugs.webkit.org/show_bug.cgi?id=79258
2476
2477         Reviewed by Ryosuke Niwa.
2478
2479         Split the fuzzy matching into separate functions so that they
2480         can be sharded and run in parallel.
2481
2482         Also, fix a bug in the svn_blame_regexp that was causing us
2483         to require ChangeLog lines to have at least one space after the
2484         author, making the code require trailing whitespace in the
2485         changelog in some places (this was making my life harder because
2486         I have my text editor set to strip trailing whitespace in python
2487         files, and that was causing test_parse_log_entries_from_changelog() to fail
2488         when the whitespace on line 275 was removed).
2489
2490         * Scripts/webkitpy/common/checkout/changelog.py:
2491         (ChangeLog):
2492         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2493         (test_fuzzy_reviewer_match__none):
2494         (test_fuzzy_reviewer_match_adam_barth):
2495         (test_fuzzy_reviewer_match_darin_adler_et_al):
2496         (test_fuzzy_reviewer_match_dimitri_glazkov):
2497         (test_fuzzy_reviewer_match_george_staikos):
2498         (test_fuzzy_reviewer_match_mark_rowe):
2499
2500 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2501
2502         webkitpy: committers_unittest fuzzy matching is really slow
2503         https://bugs.webkit.org/show_bug.cgi?id=79179
2504
2505         Reviewed by Ryosuke Niwa.
2506
2507         Break the fuzzy matching tests into individual routines for
2508         each contributor so that the intent is a little clearer, so
2509         that it's easier to test individual names (and identify
2510         duplicate tests), and so that we can eventually run
2511         them in parallel.
2512
2513         Also, mark most of them as 'integration' tests so that they
2514         can be skipped if we want to go fast (we leave a few as
2515         regular tests for functional coverage).
2516
2517         * Scripts/webkitpy/common/config/committers_unittest.py:
2518         (CommittersTest):
2519         (CommittersTest.test_contributors_by_fuzzy_match):
2520         (CommittersTest.integration_test_contributors__none):
2521         (CommittersTest.integration_test_contributors__none_2):
2522         (CommittersTest.integration_test_contributors__none_3):
2523         (CommittersTest.integration_test_contributors_ada_chan):
2524         (CommittersTest.integration_test_contributors_adele_peterson):
2525         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
2526         (CommittersTest.integration_test_contributors_alice_liu):
2527         (CommittersTest.integration_test_contributors_alp_toker):
2528         (CommittersTest.integration_test_contributors_anders_carlsson):
2529         (CommittersTest.integration_test_contributors_antti_koivisto):
2530         (CommittersTest.integration_test_contributors_beth_dakin):
2531         (CommittersTest.integration_test_contributors_brady_eidson):
2532         (CommittersTest.integration_test_contributors_cameron_zwarich):
2533         (CommittersTest.integration_test_contributors_chris_blumenberg):
2534         (CommittersTest.integration_test_contributors_dan_bernstein):
2535         (CommittersTest.integration_test_contributors_dan_bernstein_2):
2536         (CommittersTest.integration_test_contributors_darin_adler):
2537         (CommittersTest.integration_test_contributors_david_harrison):
2538         (CommittersTest.integration_test_contributors_david_harrison_2):
2539         (CommittersTest.integration_test_contributors_david_hyatt):
2540         (CommittersTest.integration_test_contributors_david_kilzer):
2541         (CommittersTest.integration_test_contributors_don_melton):
2542         (CommittersTest.integration_test_contributors_eric_seidel):
2543         (CommittersTest.integration_test_contributors_geoffrey_garen):
2544         (CommittersTest.integration_test_contributors_greg_bolsinga):
2545         (CommittersTest.integration_test_contributors_holger_freyther):
2546         (CommittersTest.integration_test_contributors_jon_sullivan):
2547         (CommittersTest.integration_test_contributors_jon_honeycutt):
2548         (CommittersTest.integration_test_contributors_joseph_pecoraro):
2549         (CommittersTest.integration_test_contributors_ken_kocienda):
2550         (CommittersTest.integration_test_contributors_kenneth_russell):
2551         (CommittersTest.integration_test_contributors_kevin_decker):
2552         (CommittersTest.integration_test_contributors_kevin_mccullough):
2553         (CommittersTest.integration_test_contributors_lars_knoll):
2554         (CommittersTest.integration_test_contributors_lars_weintraub):
2555         (CommittersTest.integration_test_contributors_maciej_stachowiak):
2556         (CommittersTest.integration_test_contributors_mark_rowe):
2557         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
2558         (CommittersTest.integration_test_contributors_oliver_hunt):
2559         (CommittersTest.integration_test_contributors_rniwa):
2560         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
2561         (CommittersTest.integration_test_contributors_steve_falkenburg):
2562         (CommittersTest.integration_test_contributors_sam_weinig):
2563         (CommittersTest.integration_test_contributors_tim_omernick):
2564         (CommittersTest.integration_test_contributors_timothy_hatcher):
2565         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
2566         (CommittersTest.integration_test_contributors_vicki_murley):
2567         (CommittersTest.integration_test_contributors_zack_rusin):
2568
2569 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2570
2571         webkitpy: should autoinstall coverage
2572         https://bugs.webkit.org/show_bug.cgi?id=79535
2573
2574         Reviewed by Eric Seidel.
2575
2576         We should automatically print the coverage report after the run, too.
2577
2578         * Scripts/webkitpy/test/main.py:
2579         (Tester._run_tests):
2580         * Scripts/webkitpy/thirdparty/__init__.py:
2581         (AutoinstallImportHook.find_module):
2582         (AutoinstallImportHook._install_coverage):
2583
2584 2012-02-24  Pablo Flouret  <pablof@motorola.com>
2585
2586         Fix copypasta in build-webkit's --vibration option description
2587         https://bugs.webkit.org/show_bug.cgi?id=79528
2588
2589         Reviewed by Andreas Kling.
2590
2591         * Scripts/build-webkit:
2592
2593 2012-02-24  Antonio Gomes  <agomes@rim.com>
2594
2595         Adding myself to ScrollingCoordinator watchlist
2596         https://bugs.webkit.org/show_bug.cgi?id=79525
2597
2598         Reviewed by Rob Buis.
2599
2600         * Scripts/webkitpy/common/config/watchlist:
2601
2602 2012-02-24  Darin Fisher  <darin@chromium.org>
2603
2604         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
2605
2606         Reviewed by Adam Barth.
2607
2608         * Scripts/webkitpy/common/config/watchlist:
2609
2610 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2611
2612         webkitpy: config_unittest is sensitive to other tests that might've already run
2613         https://bugs.webkit.org/show_bug.cgi?id=79382
2614
2615         Reviewed by Adam Barth.
2616
2617         If another test runs prior to config_unittest and pokes the
2618         cached configuration, the first test in config_unittest might
2619         fail; the tearDown() will then allow subsequent tests to pass.
2620         Clearing the configuration prior to each test makes things
2621         slightly slower but safer.
2622
2623         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2624         (ConfigTest.setUp):
2625
2626 2012-02-24  David Kilzer  <ddkilzer@apple.com>
2627
2628         Use xcrun to find compiler paths for Generate Derived Sources build phase script
2629         <http://webkit.org/b/79512>
2630
2631         Reviewed by Dan Bernstein.
2632
2633         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2634         (Generate Derived Sources): Use xcrun to find the path to the
2635         compiler since that works on both iOS and OS X.
2636
2637 2012-02-24  James Robinson  <jamesr@chromium.org>
2638
2639         Create a watchlist for ScrollingCoordinator changes
2640         https://bugs.webkit.org/show_bug.cgi?id=79511
2641
2642         Reviewed by Anders Carlsson.
2643
2644         * Scripts/webkitpy/common/config/watchlist:
2645
2646 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2647
2648         [EFL][DRT] Implement setValueForUser and setAutofilled.
2649         https://bugs.webkit.org/show_bug.cgi?id=79237
2650
2651         Reviewed by Andreas Kling.
2652
2653         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
2654         Those implementations are related with input fields and allow to pass following tests:
2655         fast/forms/onchange-setvalueforuser.html
2656         fast/forms/input-autofilled.html
2657         fast/forms/reset-autofilled.html
2658
2659         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2660         (LayoutTestController::setValueForUser):
2661         (LayoutTestController::setAutofilled):
2662
2663 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2664
2665         [Qt] Allow to use WebCore imagedecoders
2666         https://bugs.webkit.org/show_bug.cgi?id=32410
2667
2668         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2669
2670         Reviewed by Simon Hausmann.
2671
2672         * qmake/mkspecs/features/features.prf:
2673
2674 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
2675
2676         [Qt] Add Qt5 way to force 96 DPI for tests
2677         https://bugs.webkit.org/show_bug.cgi?id=79364
2678
2679         Reviewed by Simon Hausmann.
2680
2681         * DumpRenderTree/qt/main.cpp:
2682         (main):
2683         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2684         (WTR::activateFonts):
2685
2686 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         [GTK] MiniBrowser should reload the view then the reload button is clicked
2689         https://bugs.webkit.org/show_bug.cgi?id=79472
2690
2691         Reviewed by Philippe Normand.
2692
2693         * MiniBrowser/gtk/BrowserWindow.c:
2694         (reloadCallback): Call webkit_web_view_reload().
2695         (browser_window_init): Connect reload item clicked even to
2696         reloadCallback instead of activateUriEntryCallback.
2697
2698 2012-02-24  Kentaro Hara  <haraken@chromium.org>
2699
2700         Add performance tests for DOM attribute getters and setters
2701         https://bugs.webkit.org/show_bug.cgi?id=79208
2702
2703         Reviewed by Ryosuke Niwa.
2704
2705         We want to allow perf tests to output info messages
2706         that do not affect the test results. To accomplish this,
2707         this patch modifies perftestsrunner.py so that it ignores
2708         a line that starts from "Info:".
2709
2710         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2711         (PerfTestsRunner):
2712
2713 2012-02-24  Andrew Lo  <anlo@rim.com>
2714
2715         [BlackBerry] Enable requestAnimationFrame
2716         https://bugs.webkit.org/show_bug.cgi?id=79408
2717
2718         Enable requestAnimationFrame for BlackBerry.
2719
2720         Reviewed by Rob Buis.
2721
2722         * Scripts/build-webkit:
2723
2724 2012-02-24  Adam Barth  <abarth@webkit.org>
2725
2726         style-queue tries to apply the patch twice
2727         https://bugs.webkit.org/show_bug.cgi?id=79459
2728
2729         Reviewed by Eric Seidel.
2730
2731         Previously, we applied the patch using both apply-patch and
2732         check-style.  This patch introduces a check-style-local to mirror the
2733         apply-watchlist-local, which operates on the current working diff.
2734
2735         This patch also cleans up some other bugs I found by running the queue
2736         locally for a while.  The queue still prints out a slightly
2737         less-than-ideal message on the bugs when it find an error, but it's ok
2738         for now.  We'll need to iterate a bit.
2739
2740         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2741         (StyleQueueTask.validate):
2742         (StyleQueueTask._check_style):
2743         * Scripts/webkitpy/tool/commands/download.py:
2744         (CheckStyleLocal):
2745         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2746         (EarlyWarningSytemTest._default_expected_stderr):
2747         (EarlyWarningSytemTest._test_testing_ews):
2748         * Scripts/webkitpy/tool/commands/queues.py:
2749         (AbstractReviewQueue.handle_script_error):
2750         (StyleQueue.review_patch):
2751         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2752         * Scripts/webkitpy/tool/commands/queuestest.py:
2753         (QueuesTest.assert_queue_outputs):
2754
2755 2012-02-23  Adam Barth  <abarth@webkit.org>
2756
2757         should_proceed_with_work_item is unused and can be removed
2758         https://bugs.webkit.org/show_bug.cgi?id=79416
2759
2760         Reviewed by Eric Seidel.
2761
2762         We used to use this function to check whether the tree is red.  Now, we
2763         don't use external measures of whether to proceed with work items.
2764         Instead, we analyze them with the idea in mind that the tree might be
2765         red.
2766
2767         * Scripts/webkitpy/tool/bot/queueengine.py:
2768         (QueueEngineDelegate.next_work_item):
2769         (QueueEngine.run):
2770         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2771         (LoggingDelegate):
2772         (LoggingDelegate.next_work_item):
2773         (RaisingDelegate.process_work_item):
2774         (QueueEngineTest.test_terminating_error):
2775         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2776         (AbstractEarlyWarningSystem.__init__):
2777         * Scripts/webkitpy/tool/commands/queues.py:
2778         (AbstractQueue.next_work_item):
2779         (FeederQueue.next_work_item):
2780         (CommitQueue.next_work_item):
2781         (AbstractReviewQueue.next_work_item):
2782         (StyleQueue.__init__):
2783         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2784         (FeederQueueTest.test_feeder_queue):
2785         (CommitQueueTest.test_commit_queue):
2786         (test_commit_queue_failure):
2787         (test_commit_queue_failure_with_failing_tests):
2788         (test_rollout):
2789         (test_rollout_lands):
2790         (StyleQueueTest.test_style_queue_with_style_exception):
2791         (test_style_queue_with_watch_list_exception):
2792         * Scripts/webkitpy/tool/commands/queuestest.py:
2793         (QueuesTest.assert_queue_outputs):
2794         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2795         (SheriffBot.next_work_item):
2796
2797 2012-02-23  Adrienne Walker  <enne@google.com>
2798
2799         Unreviewed, add Stephen Chenney to committers.py as a contributor.
2800
2801         * Scripts/webkitpy/common/config/committers.py:
2802
2803 2012-02-23  Adam Barth  <abarth@webkit.org>
2804
2805         style-queue logs bogus messages to the QueueStatusServer
2806         https://bugs.webkit.org/show_bug.cgi?id=79424
2807
2808         Reviewed by Eric Seidel.
2809
2810         Copy/paste error.
2811
2812         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2813         (StyleQueueTask._check_style):
2814         (StyleQueueTask._apply_watch_list):
2815         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2816
2817 2012-02-23  Eric Seidel  <eric@webkit.org>
2818
2819         Use self._filesystem in more places in the SCM classes
2820         https://bugs.webkit.org/show_bug.cgi?id=79415
2821
2822         Reviewed by Adam Barth.
2823
2824         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2825         (SCMDetectorTest.test_detect_scm_system):
2826         * Scripts/webkitpy/common/checkout/scm/git.py:
2827         (Git.find_checkout_root):
2828         (Git.to_object_name):
2829         * Scripts/webkitpy/common/checkout/scm/scm.py:
2830         (SCM.__init__):
2831         (SCM.in_working_directory):
2832         * Scripts/webkitpy/common/checkout/scm/svn.py:
2833         (SVN.find_uuid):
2834         (SVN.find_checkout_root):
2835
2836 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2837
2838         Unreviewed, rolling out r108685.
2839         http://trac.webkit.org/changeset/108685
2840         https://bugs.webkit.org/show_bug.cgi?id=79414
2841
2842         Broke Chromium builds (Requested by enne on #webkit).
2843
2844         * qmake/mkspecs/features/features.prf:
2845
2846 2012-02-23  Adam Barth  <abarth@webkit.org>
2847
2848         style-queue shouldn't spam bugs if it fails to update its working copy
2849         https://bugs.webkit.org/show_bug.cgi?id=79412
2850
2851         Reviewed by Eric Seidel.
2852
2853         This patch moves style-queue over to the new PatchAnalysisTask
2854         infrastructure, which is smarter about retrying patches when update
2855         fails.
2856
2857         * Scripts/webkitpy/common/system/executive_mock.py:
2858         (MockExecutive.run_and_throw_if_fail):
2859         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2860         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2861         (UnableToApplyPatch):
2862         (UnableToApplyPatch.__init__):
2863         (PatchAnalysisTask.__init__):
2864         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
2865         (StyleQueueTaskDelegate):
2866         (StyleQueueTaskDelegate.parent_command):
2867         (StyleQueueTask):
2868         (StyleQueueTask.validate):
2869         (StyleQueueTask._check_style):
2870         (StyleQueueTask._apply_watch_list):
2871         (StyleQueueTask.run):
2872         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2873         * Scripts/webkitpy/tool/commands/queues.py:
2874         (StyleQueue):
2875         (StyleQueue.should_proceed_with_work_item):
2876         (StyleQueue.review_patch):
2877         (StyleQueue.run_command):
2878         (StyleQueue.command_passed):
2879         (StyleQueue.command_failed):
2880         (StyleQueue.expected_failures):
2881         (StyleQueue.refetch_patch):
2882         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2883         (StyleQueueTest.test_style_queue_with_style_exception):
2884         (test_style_queue_with_watch_list_exception):
2885
2886 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
2887
2888         [Qt] Allow to use WebCore imagedecoders
2889         https://bugs.webkit.org/show_bug.cgi?id=32410
2890
2891         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2892
2893         Reviewed by Simon Hausmann.
2894
2895         * qmake/mkspecs/features/features.prf:
2896
2897 2012-02-23  Eric Seidel  <eric@webkit.org>
2898
2899         Remove old broken find_checkout_root tests now that find_checkout_root is gone
2900         https://bugs.webkit.org/show_bug.cgi?id=79405
2901
2902         Reviewed by Adam Barth.
2903
2904         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
2905         (SCMDetectorTest):
2906         (SCMDetectorTest.test_find_checkout_root):
2907         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2908         (SVNTestRepository.tear_down):
2909
2910 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
2911
2912         [Qt][WK2] Implement proxy authentication dialog.
2913         https://bugs.webkit.org/show_bug.cgi?id=79350
2914
2915         Reviewed by Simon Hausmann.
2916
2917         * MiniBrowser/qt/MiniBrowser.qrc:
2918         * MiniBrowser/qt/qml/BrowserWindow.qml:
2919         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
2920
2921 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
2922
2923         [wx] Build fix, add recently added source dirs.
2924
2925         * waf/build/settings.py:
2926
2927 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
2928
2929         [Qt] Add support for touch cancellation
2930         https://bugs.webkit.org/show_bug.cgi?id=79348
2931
2932         Reviewed by Kenneth Rohde Christiansen.
2933
2934         Added straight-forward touch cancellation event sending to Qt WK1 DRT
2935         and WK2 WTR.
2936
2937         * DumpRenderTree/qt/EventSenderQt.cpp:
2938         (EventSender::touchCancel):
2939         (EventSender::cancelTouchPoint):
2940         * DumpRenderTree/qt/EventSenderQt.h:
2941         (EventSender):
2942         * WebKitTestRunner/EventSenderProxy.h:
2943         (EventSenderProxy):
2944         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2945         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2946         (WTR::EventSendingController::touchCancel):
2947         (WTR):
2948         (WTR::EventSendingController::cancelTouchPoint):
2949         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2950         (EventSendingController):
2951         * WebKitTestRunner/TestController.cpp:
2952         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2953         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2954         (WTR::EventSenderProxy::touchCancel):
2955         (WTR):
2956         (WTR::EventSenderProxy::cancelTouchPoint):
2957
2958 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2959
2960         Unreviewed, rolling out r108626.
2961         http://trac.webkit.org/changeset/108626
2962         https://bugs.webkit.org/show_bug.cgi?id=79370
2963
2964         broke qt-wk2 bot, somehow the workaround does not work on the
2965         bot (Requested by Ossy on #webkit).
2966
2967         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2968         (WTR::WrapperWindow::handleStatusChanged):
2969         (WTR::PlatformWebView::resizeTo):
2970
2971 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
2972
2973         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
2974         https://bugs.webkit.org/show_bug.cgi?id=78481
2975
2976         Reviewed by Gustavo Noronha Silva.
2977
2978         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
2979         to create gdk press key event.
2980         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2981         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2982
2983         * DumpRenderTree/gtk/EventSender.cpp:
2984         (scheduleAsynchronousClickCallback):
2985         (createKeyPressEvent):
2986         (sendKeyDown):
2987         (keyDownCallback):
2988         (sendAsynchronousKeyDown):
2989         (scheduleAsynchronousKeyDownCallback):
2990
2991 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
2992
2993         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2994         https://bugs.webkit.org/show_bug.cgi?id=76546
2995
2996         Reviewed by Simon Hausmann.
2997
2998         Co-authored with Simon Hausmann.
2999
3000         Revert the workaround introduced in r107868 and reintroduce
3001         the qml binding so we can test the code path that we are more
3002         interested in. The reason that it did not work before is that
3003         we don't have an active platform window which we now workaround
3004         by propagating the resize through QWindowSystemInterface.
3005
3006         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3007         (WTR::WrapperWindow::handleStatusChanged):
3008         (WTR::PlatformWebView::resizeTo):
3009
3010 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3011
3012         Unreviewed, rolling out r108577.
3013         http://trac.webkit.org/changeset/108577
3014         https://bugs.webkit.org/show_bug.cgi?id=79359
3015
3016         It doesn't work as expected (Requested by Ossy on #webkit).
3017
3018         * DumpRenderTree/qt/EventSenderQt.cpp:
3019         (EventSender::postEvent):
3020         * DumpRenderTree/qt/EventSenderQt.h:
3021         (EventSender):
3022
3023 2012-02-23  Philippe Normand  <pnormand@igalia.com>
3024
3025         [GTK] FullScreen signals
3026         https://bugs.webkit.org/show_bug.cgi?id=76181
3027
3028         Reviewed by Martin Robinson.
3029
3030         Use the two new entering/leaving fullscreen signals to hide/show
3031         the tool bar, the status bar and ask the user's permission before
3032         entering fullscreen.
3033
3034         * GtkLauncher/main.c:
3035         (webViewFullscreenMessageWindowClose):
3036         (webViewWindowStateEvent):
3037         (hide_widget):
3038         (show_widget):
3039         (webViewEnteringFullScreen):
3040         (webViewLeavingFullScreen):
3041         (createBrowser):
3042         (createWindow):
3043
3044 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
3045
3046         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
3047         https://bugs.webkit.org/show_bug.cgi?id=79076
3048
3049         Reviewed by Andreas Kling.
3050
3051         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
3052         (builtDylibPathForName):
3053
3054 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3055
3056         [Qt] Add eventSender.gestureTap
3057         https://bugs.webkit.org/show_bug.cgi?id=66173
3058
3059         Reviewed by Kenneth Rohde Christiansen.
3060
3061         * DumpRenderTree/qt/EventSenderQt.cpp:
3062         (EventSender::gestureTap):
3063         * DumpRenderTree/qt/EventSenderQt.h:
3064
3065 2012-02-22  Brady Eidson  <beidson@apple.com>
3066
3067         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
3068         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
3069
3070         Reviewed by Anders Carlsson.
3071
3072         Update our tools to the new form of the PageLoadClient.
3073
3074         * MiniBrowser/mac/BrowserWindowController.m:
3075         (-[BrowserWindowController awakeFromNib]): 
3076
3077         * WebKitTestRunner/TestController.cpp:
3078         (WTR::TestController::initialize):
3079
3080 2012-02-22  Daniel Bates  <dbates@webkit.org>
3081
3082         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
3083         https://bugs.webkit.org/show_bug.cgi?id=79277
3084
3085         Reviewed by Adam Barth.
3086
3087         Pass command line argument no-saved-state to run-safari to disable Safari
3088         state restoration for the session on OS 10.7.
3089
3090         * Scripts/webkitpy/layout_tests/port/mac.py:
3091         (MacPort.show_results_html_file):
3092         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3093         (test_show_results_html_file):
3094
3095 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
3096
3097         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
3098         https://bugs.webkit.org/show_bug.cgi?id=77759
3099
3100         Reviewed by Tony Chang.
3101
3102         Fixes build with gcc 4.7.
3103
3104         r100432 added the include only for ANDROID; this changes the ifdef to
3105         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
3106         longer implicitly includes unistd.h from standard headers and other
3107         unix platforms are likely to get gcc 4.7 as well in the future.
3108
3109         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3110
3111 2012-02-22  Philippe Normand  <pnormand@igalia.com>
3112
3113         Unreviewed, rolling out r108522.
3114         http://trac.webkit.org/changeset/108522
3115         https://bugs.webkit.org/show_bug.cgi?id=76181
3116
3117         Broke 4 fullscreen tests on GTK.
3118
3119         * GtkLauncher/main.c:
3120         (createBrowser):
3121         (createWindow):
3122
3123 2012-02-20  Philippe Normand  <pnormand@igalia.com>
3124
3125         [GTK] FullScreen signals
3126         https://bugs.webkit.org/show_bug.cgi?id=76181
3127
3128         Reviewed by Martin Robinson.
3129
3130         Use the two new entering/leaving fullscreen signals to hide/show
3131         the tool bar, the status bar and ask the user's permission before
3132         entering fullscreen.
3133
3134         * GtkLauncher/main.c:
3135         (webViewFullscreenMessageWindowClose):
3136         (webViewWindowStateEvent):
3137         (hide_widget):
3138         (show_widget):
3139         (webViewEnteringFullScreen):
3140         (webViewLeavingFullScreen):
3141         (createBrowser):
3142         (createWindow):
3143
3144 2012-02-22  Rob Flack  <flackr@chromium.org>
3145
3146         Update Linux ChromiumOS builders in flakiness dashboard.
3147         https://bugs.webkit.org/show_bug.cgi?id=79238
3148
3149         Reviewed by Ojan Vafai.
3150
3151         * TestResultServer/static-dashboards/builders.js:
3152
3153 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
3154
3155         webkitpy: test_function_length_check_definition_huge_lines is slow
3156         https://bugs.webkit.org/show_bug.cgi?id=79185
3157
3158         Reviewed by Adam Barth.
3159
3160         This test takes ~3 seconds to run, apparently because we're
3161         running a test on a 10,000 line function :). Dropping the
3162         function length to 640 still exercises the code path and
3163         provides a 10x speedup.
3164
3165         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3166         (CppStyleTest):
3167         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
3168
3169 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
3170
3171         webkitpy: speed up FileLockTest.test_lock_lifecycle
3172         https://bugs.webkit.org/show_bug.cgi?id=79189
3173
3174         Reviewed by Adam Barth.
3175
3176         The unit test had a second lock trying to acquire a
3177         lock already held, and a hard-coded timeout of one second.
3178         I have changed the timeouts to a tenth of a second (which
3179         is probably still fine) and changed the hard-spin on
3180         the lock to a slow-spin every hundredth of a second.
3181
3182         * Scripts/webkitpy/common/system/file_lock.py:
3183         (FileLock.acquire_lock):
3184         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
3185         (FileLockTest.setUp):
3186         (FileLockTest.test_stuck_lock):
3187
3188 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
3189
3190         build-webkit should use environment variable at number of CPU
3191         detection on all platform
3192         https://bugs.webkit.org/show_bug.cgi?id=79227
3193
3194         Reviewed by Martin Robinson.
3195
3196         * Scripts/webkitdirs.pm:
3197         (determineNumberOfCPUs):
3198
3199 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
3200
3201         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
3202         https://bugs.webkit.org/show_bug.cgi?id=78960
3203
3204         Reviewed by Csaba Osztrogonác.
3205
3206         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3207         (LayoutTestController::overridePreference):
3208
3209 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
3210
3211         [chromium] Build WebKit with MEDIA_STREAM disabled.
3212         https://bugs.webkit.org/show_bug.cgi?id=79214
3213
3214         Reviewed by Kent Tamura.
3215
3216         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3217         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3218         * DumpRenderTree/chromium/WebViewHost.cpp:
3219         (WebViewHost::createMediaPlayer):
3220         * DumpRenderTree/chromium/WebViewHost.h:
3221         (WebViewHost):
3222
3223 2012-02-22  Zeno Albisser  <zeno@webkit.org>
3224
3225         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
3226         https://bugs.webkit.org/show_bug.cgi?id=79124
3227
3228         WebKitTestRunnerPrefix.h should also be included
3229         when building with clang.
3230
3231         Reviewed by Kenneth Rohde Christiansen.
3232
3233         * WebKitTestRunner/Target.pri:
3234
3235 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
3236
3237         <style scoped>: Add runtime-flag
3238         https://bugs.webkit.org/show_bug.cgi?id=79074
3239
3240         Enable the runtime-flag for DRT. 
3241
3242         Reviewed by Dimitri Glazkov.
3243
3244         * DumpRenderTree/chromium/TestShell.cpp:
3245         (TestShell::TestShell):
3246
3247 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3248
3249         Unreviewed, rolling out r107351.
3250         http://trac.webkit.org/changeset/107351
3251         https://bugs.webkit.org/show_bug.cgi?id=53600
3252
3253         Several issues introduced in WebKitGTK+ API
3254
3255         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3256         (createWebView):
3257         * GtkLauncher/main.c:
3258         (createWebViewCb):
3259         (createBrowser):
3260         (createWindow):
3261         (main):
3262
3263 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
3264
3265         JSC should be a triple-tier VM
3266         https://bugs.webkit.org/show_bug.cgi?id=75812
3267         <rdar://problem/10079694>
3268
3269         Reviewed by Gavin Barraclough.
3270
3271         Changed EFL's build system to include a new directory in JavaScriptCore.
3272
3273         * DumpRenderTree/efl/CMakeLists.txt:
3274
3275 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
3276
3277         [chromium] Fix image drag out on Chromium
3278         https://bugs.webkit.org/show_bug.cgi?id=79158
3279
3280         Reviewed by Tony Chang.
3281
3282         * DumpRenderTree/chromium/EventSender.cpp:
3283         (EventSender::dumpFilenameBeingDragged):
3284         (EventSender::beginDragWithFiles):
3285         * DumpRenderTree/chromium/WebViewHost.cpp:
3286         (addDRTFakeFileToDataObject):
3287
3288 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3289
3290         webkitpy: speed up hot filesystem_mock functions
3291         https://bugs.webkit.org/show_bug.cgi?id=79159
3292
3293         Reviewed by Adam Barth.
3294
3295         Profiling run_webkit_tests_integrationtest.py revealed that
3296         isdir(), normpath(), and join() are called a lot and were very
3297         slow.This patch speeds them up substantially, shaving 20 seconds
3298         off of the execution time.
3299
3300         * Scripts/webkitpy/common/system/filesystem_mock.py:
3301         (MockFileSystem.isdir):
3302         (MockFileSystem._slow_but_correct_join):
3303         (MockFileSystem.join):
3304         (MockFileSystem.listdir):
3305         (MockFileSystem._slow_but_correct_normpath):
3306         (MockFileSystem.normpath):
3307         (MockFileSystem.write_binary_file):
3308         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3309         (MockFileSystemTest.quick_check):
3310         (MockFileSystemTest):
3311         (MockFileSystemTest.test_join):
3312         (MockFileSystemTest.test_normpath):
3313         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3314         (get_test_config): Call write_binary_file() instead of updating
3315           filesystem.files directly, so that we create directories as
3316           needed.
3317
3318 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3319
3320         nrwt: make the delay between starting workers configurable per-port
3321         https://bugs.webkit.org/show_bug.cgi?id=79148
3322
3323         Reviewed by Eric Seidel.
3324
3325         Because of bug 79147, we have to sleep a bit in between starting
3326         DRTs; however, doing so across the board slows down the Test
3327         port. Making this configurable shaves 10 seconds off of
3328         run_webkit_tests_integrationtest.py
3329         
3330         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3331         (Manager._run_tests):
3332         * Scripts/webkitpy/layout_tests/port/base.py:
3333         (Port.worker_startup_delay_secs):
3334         * Scripts/webkitpy/layout_tests/port/test.py:
3335         (TestPort.worker_startup_delay_secs):
3336
3337 2012-02-21  Jon Lee  <jonlee@apple.com>
3338
3339         Bring notifications support to WK1 mac
3340         https://bugs.webkit.org/show_bug.cgi?id=78783
3341         <rdar://problem/10610578>
3342
3343         Reviewed by Anders Carlsson.
3344
3345         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
3346         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3347         (-[UIDelegate timerFired]):
3348
3349 2012-02-21  Kentaro Hara  <haraken@chromium.org>
3350
3351         Enable the IDL attribute checker in run-bindings-tests
3352         https://bugs.webkit.org/show_bug.cgi?id=79091
3353
3354         Reviewed by Adam Barth.
3355
3356         We have enabled the IDL attribute checker in Chromium in r108322.
3357         This patch enables the IDL attribute checker in run-bindings-tests.
3358
3359         No tests. I manually checked that [Custommm], [CallWith=],
3360         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
3361         run-bindings-tests failures.
3362
3363         * Scripts/webkitpy/bindings/main.py:
3364         (BindingsTests.generate_supplemental_dependency):
3365
3366 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
3367
3368         Add rafaelw as a committer.
3369
3370         Unreviewed.
3371
3372         * Scripts/webkitpy/common/config/committers.py:
3373
3374 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3375
3376         webkitpy: update names after deleting message_broker
3377         https://bugs.webkit.org/show_bug.cgi?id=79000
3378
3379         Reviewed by Eric Seidel.
3380
3381         Part 3 of 3 in deleting message_broker.py; this change just
3382         adjusts the names for the newly merged symbols so that they are
3383         private as appropriate.
3384
3385         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3386         (get):
3387         (_Broker):
3388         (_BrokerConnection):
3389         (_BrokerConnection.__init__):
3390         (AbstractWorker.__init__):
3391         (_ManagerConnection):
3392         (_ManagerConnection.__init__):
3393         (_WorkerConnection):
3394         (_WorkerConnection.__init__):
3395
3396 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3397
3398         webkitpy: merge message_broker.py into manager_worker_broker.py
3399         https://bugs.webkit.org/show_bug.cgi?id=78999
3400
3401         Reviewed by Tony Chang.
3402
3403         This is pretty much a straight cut-and-paste of one file into
3404         another (broken up so that docstrings and imports are in the
3405         right place).
3406
3407         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3408         (BrokerClient):
3409         (BrokerClient.is_done):
3410         (BrokerClient.name):
3411         (Broker):
3412         (Broker.__init__):
3413         (Broker.add_topic):
3414         (Broker._get_queue_for_topic):
3415         (Broker.post_message):
3416         (Broker.run_message_loop):
3417         (Broker.run_all_pending):
3418         (Broker._run_loop):
3419         (Broker._dispatch_message):
3420         (_Message):
3421         (_Message.loads):
3422         (_Message.__init__):
3423         (_Message.dumps):
3424         (_Message.__repr__):
3425         (BrokerConnection):
3426         (BrokerConnection.__init__):
3427         (BrokerConnection.run_message_loop):
3428         (BrokerConnection.post_message):
3429         (BrokerConnection.raise_exception):
3430         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
3431
3432 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3433
3434         webkitpy: prepare to delete message_broker.py
3435         https://bugs.webkit.org/show_bug.cgi?id=78997
3436
3437         Reviewed by Eric Seidel.
3438
3439         This is part 1 of 3 changes to fix bug 78187. This change
3440         prepares the code for merging message_broker.py into
3441         manager_worker_broker.py; the tests in message_broker_unittest
3442         are merged into manager_worker_broker_unittest, the symbols
3443         needed by the tests are exported from manager_worker_broker.py,
3444         and manager_worker_broker itself is updated to refer to the
3445         symbols directly (without the module prefix).
3446
3447         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3448         (get):
3449         (AbstractWorker):
3450         (AbstractWorker.__init__):
3451         (_ManagerConnection):
3452         (_ManagerConnection.__init__):
3453         (_WorkerConnection):
3454         (_WorkerConnection.__init__):
3455         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3456         (InterfaceTest.test_brokerclient_is_abstract):
3457         (InterfaceTest.test_brokerclient_is_abstract.methods):
3458         (MessageTest):
3459         (MessageTest.test__no_body):
3460         (MessageTest.test__body):
3461         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
3462
3463 2012-02-21  Sam Weinig  <sam@webkit.org>
3464
3465         Attempt to fix the Snow Leopard build.
3466
3467         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3468         * MiniBrowser/Configurations/Base.xcconfig:
3469         * TestWebKitAPI/Configurations/Base.xcconfig:
3470         * WebKitTestRunner/Configurations/Base.xcconfig:
3471
3472 2012-02-21  Sam Weinig  <sam@webkit.org>
3473
3474         Use libc++ when building with Clang on Mac
3475         https://bugs.webkit.org/show_bug.cgi?id=78981
3476
3477         Reviewed by Dan Bernstein.
3478
3479         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3480         * MiniBrowser/Configurations/Base.xcconfig:
3481         * TestWebKitAPI/Configurations/Base.xcconfig:
3482         * WebKitTestRunner/Configurations/Base.xcconfig:
3483
3484 2012-02-21  Adam Roben  <aroben@apple.com>
3485
3486         Roll out r108309, r108323, and r108326
3487
3488         They broke the 32-bit Lion build.
3489
3490         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
3491
3492         * DumpRenderTree/efl/CMakeLists.txt:
3493
3494 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
3495
3496         [Qt][WK2] Get rid of the dependency to QtWidgets
3497         https://bugs.webkit.org/show_bug.cgi?id=76276
3498
3499         Reviewed by Simon Hausmann.
3500
3501         * MiniBrowser/qt/MiniBrowser.pro:
3502         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3503         (MiniBrowserApplication::MiniBrowserApplication):
3504         (MiniBrowserApplication::notify):
3505         (MiniBrowserApplication::sendTouchEvent):
3506         * MiniBrowser/qt/MiniBrowserApplication.h:
3507         (MiniBrowserApplication):
3508         * QtTestBrowser/locationedit.h:
3509         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3510         (WTR::activateFonts):
3511         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3512
3513 2012-02-20  Adam Barth  <abarth@webkit.org>
3514
3515         mastercfg_unittest.py fails without simplejson
3516         https://bugs.webkit.org/show_bug.cgi?id=79070
3517
3518         Reviewed by Csaba Osztrogonác.
3519
3520         Now that we require Python 2.6 (and higher) we can import json rather
3521         than simplejson.  We still need to use the simplejson name because
3522         that's what the master.cfg script expects.
3523
3524         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3525         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3526
3527 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
3528
3529         JSC should be a triple-tier VM
3530         https://bugs.webkit.org/show_bug.cgi?id=75812
3531         <rdar://problem/10079694>
3532
3533         Reviewed by Gavin Barraclough.
3534
3535         Changed EFL's build system to include a new directory in JavaScriptCore.
3536
3537         * DumpRenderTree/efl/CMakeLists.txt:
3538
3539 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
3540
3541         Update pywebsocket to 0.7.2
3542         https://bugs.webkit.org/show_bug.cgi?id=79066
3543
3544         This version includes vendor-prefixed deflate-frame extension support.
3545
3546         Reviewed by Kent Tamura.
3547
3548         * Scripts/webkitpy/thirdparty/__init__.py:
3549         (AutoinstallImportHook._install_pywebsocket):
3550
3551 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3552
3553         [UNIX] Plugin information fields are not interpreted as UTF-8
3554         https://bugs.webkit.org/show_bug.cgi?id=78635
3555
3556         Reviewed by Gustavo Noronha Silva.
3557
3558         Interpret plugin metadata as UTF8 aways. This matches the behavior
3559         of Chromium and the Totem plugin.
3560
3561         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3562         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
3563
3564 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3565
3566         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
3567         https://bugs.webkit.org/show_bug.cgi?id=78935
3568
3569         Reviewed by Gustavo Noronha Silva.
3570
3571         Move the TestNetscapePlugin headers to a more appropriate directory and update
3572         the build files to match.
3573
3574         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
3575         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
3576         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
3577         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
3578         * GNUmakefile.am: Ditto.
3579
3580 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
3581
3582         Add a new API for the Vibration API(W3C).
3583         https://bugs.webkit.org/show_bug.cgi?id=72010
3584
3585         Reviewed by Hajime Morita.
3586
3587         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
3588
3589 2012-02-20  János Badics  <dicska@gmail.com>
3590
3591         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
3592         https://bugs.webkit.org/show_bug.cgi?id=71816
3593
3594         RunQtAPITests will notify if a timeout occurs during testing.
3595         Added unittest to the master.cfg
3596
3597         Reviewed by Csaba Osztrogonác.
3598
3599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3600         (RunQtAPITests.evaluateCommand):
3601         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3602         (RunQtAPITestsTest):
3603         (RunQtAPITestsTest.assertResults):
3604         (RunQtAPITestsTest.test_timeout):
3605         (test_success):
3606         (test_failure):
3607         (test_timeout_and_failure):
3608
3609 2012-02-20  Andy Wingo  <wingo@igalia.com>
3610
3611         Add wingo as a committer.
3612
3613         Unreviewed.
3614
3615         * Scripts/webkitpy/common/config/committers.py: Add myself to the
3616         committers list.
3617
3618 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
3619
3620         [chromium] check that we're not running multiple modal dialogs at the same time
3621         https://bugs.webkit.org/show_bug.cgi?id=78486
3622
3623         Reviewed by Kent Tamura.
3624
3625         * DumpRenderTree/chromium/TestShell.cpp:
3626         (TestShell::TestShell):
3627         * DumpRenderTree/chromium/TestShell.h:
3628         (TestShell::setIsDisplayingModalDialog):
3629         (TestShell::isDisplayingModalDialog):
3630         (TestShell):
3631         * DumpRenderTree/chromium/WebViewHost.cpp:
3632         (WebViewHost::runModal):
3633
3634 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3635
3636         Fix WebKit2GTK+ for 'make distcheck'.
3637
3638         Instead of conditionally including WebKit2 GNUmakefiles, always
3639         include them and conditionally activate the final targets.
3640
3641         * MiniBrowser/gtk/GNUmakefile.am:
3642         * WebKitTestRunner/GNUmakefile.am:
3643
3644 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3645
3646         Enable video option for EFL port in build-webkit.
3647         https://bugs.webkit.org/show_bug.cgi?id=79006
3648
3649         Reviewed by Daniel Bates.
3650
3651         * Scripts/build-webkit:
3652
3653 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
3654
3655         [EFL] Use modifier keys to execute pre-rendering.
3656         https://bugs.webkit.org/show_bug.cgi?id=77933
3657
3658         Reviewed by Chang Shu.
3659
3660         Use modifier key to execute pre-rendering instead of using reserved function keys.
3661
3662         * EWebLauncher/main.c:
3663         (on_key_down):
3664
3665 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3666
3667         Fix one more dangling reference to worker_connection.name, delete unused code.
3668
3669         Unreviewed, build fix.
3670
3671         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3672         (Manager.update):
3673         (_WorkerState.__init__):
3674
3675 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3676
3677         Add a change that should've been in r108005.
3678
3679         Unreviewed, build fix.
3680
3681         In the refactoring/cleanup in r108005 I should've changed the
3682         implementation of WorkerConnection to make it match BrokerClient
3683         (and everything else) so that objects had a name() method
3684         instead of a name property.
3685
3686         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3687         (Manager._run_tests):
3688         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3689         (_WorkerConnection.__init__):
3690         (_WorkerConnection.name):
3691         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3692         (_TestWorker.__init__):
3693         (_TestsMixin.name):
3694         (_TestsMixin.test_name):
3695         (_TestsMixin.test_cancel):
3696         (_TestsMixin.test_unknown_message):
3697
3698 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3699
3700         webkitpy: remove webkitpy.common.array_stream
3701         https://bugs.webkit.org/show_bug.cgi?id=78952
3702
3703         Reviewed by Eric Seidel.
3704
3705         Turns out array_stream didn't really do anything that StringIO
3706         didn't do (at least as of Python 2.6). This change removes it
3707         and updates all of the callers. Where possible, I changed the
3708         test assertions in order to capture the intent more clearly,
3709         e.g., instead of calling self.assertTrue('foo' in stream.get()),
3710         we have self.assertContainsLine(stream, 'foo'), and instead of
3711         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
3712         the latter isn't that much more readable, but StringIO doesn't
3713         export an empty() method.
3714
3715         * Scripts/webkitpy/common/array_stream.py: Removed.
3716         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
3717         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3718         (passing_run):
3719         (run_and_capture):
3720         (StreamTestingMixin):
3721         (StreamTestingMixin.assertContains):
3722         (StreamTestingMixin.assertContainsLine):