7e8228233bad064eac30e2534b98692f123457cb
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-02  Daniel Bates  <dabates@apple.com>
2
3         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
4         (https://bugs.webkit.org/show_bug.cgi?id=149753)
5
6         For now, pass --ios-simulator.
7
8         * Scripts/webkitpy/port/ios.py:
9         (IOSSimulatorPort._build_relay):
10
11 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
12
13         Remove a "nullable" that breaks the iOS 8 build.
14
15         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
16         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
17
18 2015-10-02  Daniel Bates  <dabates@apple.com>
19
20         LayoutTestRelay is not built and archived when building for iOS Simulator
21         https://bugs.webkit.org/show_bug.cgi?id=149753
22
23         Reviewed by Alexey Proskuryakov and Andy Estes.
24
25         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
26         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
27         product archive when building for iOS Simulator, respectively.
28
29         * BuildSlaveSupport/built-product-archive:
30         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
31         differentiate between iOS device and iOS Simulator platforms.
32         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
33         from determineWebKitBuildDirectories() into this function so that it can be used by both
34         determineWebKitBuildDirectories() and archiveBuiltProduct().
35         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
36         webkitBuildDirectoryForConfigurationAndPlatform().
37         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
38         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
39         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
40         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
41         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
42         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
43         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
44         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
45         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
46         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
47         * Scripts/build-layouttestrelay:
48             - Remove unnecessary include of Perl module POSIX.
49             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
50         * Scripts/build-webkit:
51             - Invoke script build-layouttestrelay when building for iOS Simulator.
52
53 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
54
55         [Win] Unreviewed test fix.
56
57         You cannot run 'run-webkit-tests' from the command line because it does not know
58         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
59         because they explicitly set use the 'root' argument to provide the full path to
60         the test binaries.
61
62         * Scripts/webkitpy/port/win.py:
63         (WinPort._build_path): Added.
64
65 2015-10-02  Alex Christensen  <achristensen@webkit.org>
66
67         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
68         https://bugs.webkit.org/show_bug.cgi?id=149430
69         rdar://problem/22742222
70
71         Reviewed by Geoffrey Garen.
72
73         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
74         (WTR::TestController::cocoaResetStateToConsistentValues):
75         * WebKitTestRunner/mac/TestControllerMac.mm:
76         (WTR::TestController::platformConfigureViewForTest):
77         Test what happens when you disable content blockers from the SPI.
78
79 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
80
81         [Win] Unreviewed build fix for run-api-tests
82
83         * Scripts/run-api-tests:
84         (testToolPaths): Windows run needs to specify the binary path.
85
86 2015-10-01  Daniel Bates  <dabates@apple.com>
87
88         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
89         (https://bugs.webkit.org/show_bug.cgi?id=149695)
90
91         Following r190424 we can now rely on webkit-build-directory to return the path to
92         the correct configuration-specific build directory on Windows.
93
94         * BuildSlaveSupport/built-product-archive:
95         (archiveBuiltProduct):
96
97 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
98
99         [Win] Unreviewed build fix.
100
101         * Scripts/webkitdirs.pm:
102         (setupAppleWinEnv): Use 64-bit build tools if available
103
104 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
105
106         [Win] Fix TestWebKitAPI build under CMake.
107
108         Reviewed by Alex Christensen.
109
110         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
111         for Psapi.lib.
112
113 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
114
115         [Win] Fix behavior of webkit-build-directory script
116         https://bugs.webkit.org/show_bug.cgi?id=149718
117
118         Reviewed by Alex Christensen.
119
120         * Scripts/webkitdirs.pm:
121         (determineConfigurationProductDir): Do not include the binary
122         sub-directory in the configuration product directory output.
123         (jscProductDir): Append correct binary path for Windows build.
124         (setPathForRunningWebKitApp): Include properly binary subdirectories.
125         (runSafari): Update for revised productDir behavior.
126         (runMiniBrowser): Ditto.
127
128 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
129
130         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
131         use iOS SDK, like with all the others.
132
133         * Scripts/build-webkit:
134
135 2015-10-01  Daniel Bates  <dabates@apple.com>
136
137         Attempt to fix the iOS 9 Simulator testers
138
139         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
140         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
141         LayoutTestRelay when building for iOS Simulator.
142
143         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
144         * Scripts/build-webkit:
145
146 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
147
148         [GTK] Websites with invalid auth header keep loading forever
149         https://bugs.webkit.org/show_bug.cgi?id=149710
150
151         Reviewed by Martin Robinson.
152
153         Add test case to check that we can authenticate sites with an
154         empty realm.
155
156         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
157         (testWebViewAuthenticationEmptyRealm):
158         (serverCallback):
159         (beforeAll):
160
161 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
162
163         [Mac] Make run-api-tests work with System Integrity Protection
164         https://bugs.webkit.org/show_bug.cgi?id=149711
165         rdar://problem/22928202
166
167         Reviewed by Dan Bernstein.
168
169         * Scripts/run-api-tests:
170         (runTest):
171         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
172
173 2015-10-01  Daniel Bates  <dabates@apple.com>
174
175         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
176         (https://bugs.webkit.org/show_bug.cgi?id=149695)
177
178         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
179         For now, use the path to the top-level WebKit build directory instead of using the configuration-
180         specific build directory.
181
182         * BuildSlaveSupport/built-product-archive:
183         (archiveBuiltProduct):
184
185 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
186
187         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
188         https://bugs.webkit.org/show_bug.cgi?id=145837
189
190         Reviewed by Philippe Normand.
191
192         * efl/jhbuild.modules:
193         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
194         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
195
196 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
197
198         Unreviewed. Fix the iOS build after r190407.
199
200         * WebKitTestRunner/ios/IOKitSPI.h:
201
202 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
203
204         Implement keyboard event sending for iOS in WebKitTestRunner
205         https://bugs.webkit.org/show_bug.cgi?id=149676
206
207         Reviewed by Simon Fraser.
208
209         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
210         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
211         allows us to run code when the keyboard is shown or hidden.
212
213         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
214         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
215         (WTR::UIScriptController::setDidShowKeyboardCallback):
216         (WTR::UIScriptController::didShowKeyboardCallback):
217         (WTR::UIScriptController::setDidHideKeyboardCallback):
218         (WTR::UIScriptController::didHideKeyboardCallback):
219         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
220         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
221         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
222         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
223         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
224         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
225         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
226                 the notifications that the keyboard has been raised or lowered.
227         (-[TestRunnerWKWebView _keyboardDidShow:]):
228         (-[TestRunnerWKWebView _keyboardDidHide:]):
229         * WebKitTestRunner/ios/HIDEventGenerator.h:
230         * WebKitTestRunner/ios/HIDEventGenerator.m:
231         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
232         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
233         (hidUsageCodeForCharacter): Ditto.
234         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
235                 a keyDown event in WebKit.
236         * WebKitTestRunner/ios/IOKitSPI.h:
237         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
238
239 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
240
241         Unreviewed, rolling out r190399.
242
243         Tests are still failing even after r190362
244
245         Reverted changeset:
246
247         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
248         http://trac.webkit.org/changeset/190399
249
250 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
251
252         [jhbuild] switch to new upstream usrsctp library
253         https://bugs.webkit.org/show_bug.cgi?id=149494
254
255         Reviewed by Philippe Normand.
256
257         * efl/jhbuild.modules:
258         * gtk/jhbuild.modules:
259
260 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
261
262         Unreviewed. Unskip GTK+ user media unit tests after r190362.
263
264         They should pass now.
265
266         * Scripts/run-gtk-tests:
267         (TestRunner):
268
269 2015-09-30  Daniel Bates  <dabates@apple.com>
270
271         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
272         (https://bugs.webkit.org/show_bug.cgi?id=149695)
273
274         * BuildSlaveSupport/built-product-archive:
275         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
276         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
277
278 2015-09-30  Daniel Bates  <dabates@apple.com>
279
280         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
281         (https://bugs.webkit.org/show_bug.cgi?id=149695)
282
283         Actually, we need to pass --configuration to script webkit-build-directory to have
284         it return the path to the configuration-specific build directory.
285
286         * BuildSlaveSupport/built-product-archive:
287         (determineWebKitBuildDirectories):
288
289 2015-09-30  Daniel Bates  <dabates@apple.com>
290
291         built-product-archive archives incorrect build directory for iOS port
292         https://bugs.webkit.org/show_bug.cgi?id=149695
293
294         Reviewed by Darin Adler.
295
296         Fixes an issue where the script built-product-archive archives a non-existent
297         build directory for the iOS port. Without loss of generality, the script assumes
298         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
299         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
300
301         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
302         to determine the top-level build directory and computes the configuration-specific
303         build directory to be the concatenation of the the top-level build directory and
304         the configuration (e.g. Release). This is incorrect. Instead we should call
305         webkit-build-directory omitting the flag --top-level to compute the path to the
306         configuration-specific build directory.
307
308         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
309         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
310         its purpose and added global variable _configurationBuildDirectory to store the path
311         to the configuration-specific build directory. Ensure that we have a non-empty string
312         for both the top-level and configuration-specific build directories.
313         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
314         Compute the configuration-specific build directory and store it in the global variable
315         _configurationBuildDirectory.
316         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
317         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
318         as needed.
319         (determineWebKitBuildDirectory): Deleted.
320
321 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
322
323         [EFL] css3/device-adapt/* tests failed after r190335.
324         https://bugs.webkit.org/show_bug.cgi?id=149655
325
326         Reviewed by Simon Fraser.
327
328         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
329         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
330
331         * WebKitTestRunner/efl/TestControllerEfl.cpp:
332         (WTR::shouldUseFixedLayout):
333
334 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
335
336         Extend JetStream timeout for slow devices.
337
338         Reviewed by Chris Dumez.
339
340         Extend JetStream timeout to 20 minutes.
341
342         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
343
344 2015-09-30  Daniel Bates  <dabates@apple.com>
345
346         Rename iOS builders/testers to include version
347         https://bugs.webkit.org/show_bug.cgi?id=149685
348
349         Reviewed by Simon Fraser.
350
351         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
352         make it clear to a reader the version of iOS these builders/testers are using.
353
354         * BuildSlaveSupport/build.webkit.org-config/config.json:
355         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
356
357 2015-09-30  Daniel Bates  <dabates@apple.com>
358
359         Add iOS criterion for triggering a build
360         https://bugs.webkit.org/show_bug.cgi?id=149679
361
362         Rubber-stamped by Alexey Proskuryakov.
363
364         First pass at defining criterion for triggering an iOS build.
365
366         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
367         (_should_file_trigger_build):
368         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
369         (ShouldBuildTest):
370         (ShouldBuildTest.test_should_build):
371
372 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
373
374         [iOS] Allow tests to generate user gestures for UI testing
375         https://bugs.webkit.org/show_bug.cgi?id=149653
376
377         Reviewed by Tim Horton.
378
379         Expose functionality in UIScriptController to allow for testing single- and double-tap,
380         and to listen for completion of scrolling and zooming in the WKWebView.
381         
382         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
383         which hides the complexity of creating these events. Event dispatch is asynchronous.
384         We detect when the last event has been handled by dispatching a vendor-specific event,
385         which is detected via -_handleHIDEvent: in our UIApplication subclass.
386         
387         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
388         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
389         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
390         single and double taps.
391         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
392         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
393         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
394         (UIScriptContext::unregisterCallback):
395         (UIScriptContext::callbackWithID):
396         (UIScriptContext::fireCallback):
397         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
398         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
399         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
400         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
401         (WTR::UIScriptController::setDidEndZoomingCallback):
402         (WTR::UIScriptController::didEndZoomingCallback):
403         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
404         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
405         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
406         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
407         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
408         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
409         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
410         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
411         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
412         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
413         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
414         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
415         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
416         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
417         (simpleDragCurve):
418         (calculateNextLocation):
419         (delayBetweenMove):
420         (+[HIDEventGenerator sharedHIDEventGenerator]):
421         (+[HIDEventGenerator nextEventCallbackID]):
422         (-[HIDEventGenerator init]):
423         (-[HIDEventGenerator _createIOHIDEventType:]):
424         (-[HIDEventGenerator _sendHIDEvent:]):
425         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
426         (-[HIDEventGenerator _updateTouchPoints:count:]):
427         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
428         (-[HIDEventGenerator touchDown:touchCount:]):
429         (-[HIDEventGenerator touchDown:]):
430         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
431         (-[HIDEventGenerator liftUp:touchCount:]):
432         (-[HIDEventGenerator liftUp:]):
433         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
434         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
435         (-[HIDEventGenerator tap:completionBlock:]):
436         (-[HIDEventGenerator doubleTap:completionBlock:]):
437         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
438         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
439         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
440         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
441         (-[HIDEventGenerator markerEventReceived:]):
442         * WebKitTestRunner/ios/IOKitSPI.h: Added.
443         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
444         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
445         (WTR::globalToContentCoordinates):
446         (WTR::UIScriptController::singleTapAtPoint):
447         (WTR::UIScriptController::doubleTapAtPoint):
448         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
449         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
450         * WebKitTestRunner/ios/mainIOS.mm:
451         (-[WebKitTestRunnerApp _handleHIDEvent:]):
452
453 2015-09-30  Dana Burkart  <dburkart@apple.com>
454
455         git-add-reviewer should trim trailing spaces/newlines
456         https://bugs.webkit.org/show_bug.cgi?id=149513
457
458         Reviewed by Darin Adler.
459
460         * Scripts/git-add-reviewer:
461         (nonInteractive):
462
463 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
464
465         REGRESSION(r190262): User media unit test failures after r190262
466         https://bugs.webkit.org/show_bug.cgi?id=149580
467
468         Reviewed by Darin Adler.
469
470         * WebKitTestRunner/TestController.cpp:
471         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
472           order to WKUserMediaPermissionRequestAllow.
473
474 2015-09-30  Daniel Bates  <dabates@apple.com>
475
476         Add iOS builders and testers
477         https://bugs.webkit.org/show_bug.cgi?id=149549
478
479         Reviewed by Alexey Proskuryakov.
480
481         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
482         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
483
484         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
485         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
486
487 2015-09-30  Timothy Hatcher  <timothy@apple.com>
488
489         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
490         https://bugs.webkit.org/show_bug.cgi?id=149674
491
492         Reviewed by Lucas Forschler.
493
494         * WebKitLauncher/WebKitLauncher.entitlements: Added.
495         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
496
497 2015-09-30  Jason Marcell  <jmarcell@apple.com>
498
499         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
500         have an associated trac instance.
501         https://bugs.webkit.org/show_bug.cgi?id=149673
502
503         Reviewed by Alexey Proskuryakov.
504
505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
506         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
507         have an associated trac instance.
508
509 2015-09-30  Daniel Bates  <dabates@apple.com>
510
511         Prioritize testing latest build request on iOS test bots
512         https://bugs.webkit.org/show_bug.cgi?id=149669
513
514         Reviewed by Darin Adler.
515
516         We should prioritize testing of the latest build request on the iOS test bots
517         as we do for Mac and Windows test bots.
518
519         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
520         (loadBuilderConfig):
521
522 2015-09-30  Daniel Bates  <dabates@apple.com>
523
524         Add buildbot category for iOS builders and testers
525         https://bugs.webkit.org/show_bug.cgi?id=149667
526
527         Reviewed by Darin Adler.
528
529         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
530         for iOS to the build.webkit.org home page.
531
532         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
533         (loadBuilderConfig):
534         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
535
536 2015-09-30  Daniel Bates  <dabates@apple.com>
537
538         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
539         (https://bugs.webkit.org/show_bug.cgi?id=149539)
540
541         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
542         in <http://trac.webkit.org/changeset/190351>.
543
544         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
545         (CompileWebKit.start):
546
547 2015-09-30  Daniel Bates  <dabates@apple.com>
548
549         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
550         (https://bugs.webkit.org/show_bug.cgi?id=149539)
551
552         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
553         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
554
555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
556         (CompileWebKit.start):
557
558 2015-09-30  Lucas Forschler  <lforschler@apple.com>
559
560         bot210 was configured for a queue instead of bot126.
561         
562         Unreviewed config.json fix.
563         
564         * BuildSlaveSupport/build.webkit.org-config/config.json:
565
566 2015-09-30  Lucas Forschler  <lforschler@apple.com>
567
568         Bring El Capitan buildbot infrastructure online.
569         https://bugs.webkit.org/show_bug.cgi?id=149605
570         
571         Reviewed by Darin Adler.
572
573         * BuildSlaveSupport/build.webkit.org-config/config.json:
574
575 2015-09-30  Tomas Popela  <tpopela@redhat.com>
576
577         [GTK] Deprecation warnings in DOMNodeTest
578         https://bugs.webkit.org/show_bug.cgi?id=149663
579
580         After the webkit_dom_document_get_elements_by_tag_name deprecation we
581         need to update the tests to use webkit_dom_document_query_selector_all
582         to avoid compilation warnings.
583
584         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
585         (the suggested replacement for the deprecated function).
586
587         Reviewed by Carlos Garcia Campos.
588
589         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
590         (WebKitDOMNodeTest::testTagNamesNodeList):
591         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
592         (registerTests):
593         (WebKitDOMNodeTest::testTagNames): Deleted.
594         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
595         (prepareDOMForTagNamesTests):
596         (testWebKitDOMNodeTagNamesNodeList):
597         (testWebKitDOMNodeTagNamesHTMLCollection):
598         (beforeAll):
599         (testWebKitDOMNodeTagNames): Deleted.
600
601 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
602
603         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
604         https://bugs.webkit.org/show_bug.cgi?id=149650
605
606         Reviewed by Tim Horton.
607         
608         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
609         looks at the file path, and not the custom options that come from file comments.
610         
611         Fix by computing TestOptions before making the TestInvocation, and setting them
612         as const TestInvocation data. This meant changing various call sites to take
613         the std::string pathOrURL, rather than the TestInvocation itself.
614         
615         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
616
617         * WebKitTestRunner/CMakeLists.txt:
618         * WebKitTestRunner/TestController.cpp:
619         (WTR::TestController::ensureViewSupportsOptionsForTest):
620         (WTR::testPath):
621         (WTR::createTestURL):
622         (WTR::updateTestOptionsFromTestHeader):
623         (WTR::TestController::testOptionsForTest):
624         (WTR::TestController::updateWebViewSizeForTest):
625         (WTR::TestController::updateWindowScaleForTest):
626         (WTR::TestController::runTest):
627         * WebKitTestRunner/TestController.h:
628         * WebKitTestRunner/TestInvocation.cpp:
629         (WTR::TestInvocation::TestInvocation):
630         (WTR::TestInvocation::invoke):
631         (WTR::createWKURL): Deleted.
632         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
633         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
634         * WebKitTestRunner/TestInvocation.h:
635         (WTR::TestInvocation::options):
636         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
637         (WTR::pathContains):
638         (WTR::shouldMakeViewportFlexible):
639         (WTR::shouldUseFixedLayout):
640         (WTR::isSVGTestPath):
641         (WTR::isHiDPITestPath):
642         (WTR::TestOptions::TestOptions):
643         * WebKitTestRunner/TestOptions.h:
644         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
645         * WebKitTestRunner/efl/TestControllerEfl.cpp:
646         (WTR::pathContains):
647         (WTR::shouldUseFixedLayout):
648         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
649         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
650         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
651         * WebKitTestRunner/ios/TestControllerIOS.mm:
652         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
653         * WebKitTestRunner/mac/TestControllerMac.mm:
654         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
655
656 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
657
658         Flakiness dashboard should support OS X El Capitan
659         https://bugs.webkit.org/show_bug.cgi?id=149648
660
661         Reviewed by Alexey Proskuryakov.
662
663         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
664         difference between new appscale and old Google App Engine implementation.
665         * TestResultServer/app.yaml: Same.
666         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
667
668 2015-09-29  Daniel Bates  <dabates@apple.com>
669
670         configure-xcode-for-ios-development does not work with Xcode 7
671         https://bugs.webkit.org/show_bug.cgi?id=149640
672
673         Reviewed by Alexey Proskuryakov.
674
675         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
676         because it cannot find the Xcode specification files for iOS simulator and device. These
677         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
678         relevant definitions to the Xcode 7 specification files directly as opposed to creating
679         new specification files with the added definitions (as we did in older versions of Xcode)
680         in order for Xcode 7 to honor these definitions.
681
682         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
683         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
684         (updateXcode7SpecificationFile): Added.
685         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
686         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
687         appropriate success message.
688         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
689         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
690         (createXcodeSpecificationFromSpecificationAndId): Deleted.
691
692 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
693
694         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
695         https://bugs.webkit.org/show_bug.cgi?id=149639
696
697         Reviewed by Alex Christensen.
698
699         * Scripts/VCSUtils.pm:
700         (exitStatus): Use 'isWindows()' method.
701         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
702         an error. This method could probably just go away.
703         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
704         always changing to Unix style. 
705         (unixPath): Added. Needed so Windows can always show a Unix path in the
706         ChangeLog file.
707         (changeLogName): Work around the fact that 'getpwuid' is not available on
708         a pure Windows build of Perl.
709         * Scripts/prepare-ChangeLog:
710         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
711         path on Windows.
712         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
713         support using arrays for 'open' arguments.
714         (resolveChangeLogsPath): Ditto.
715         (resolveConflictedChangeLogs): Use new helper functions.
716         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
717         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
718         quotes. Unix systems are happy either way.
719         (statusCommand): Ditto.
720         * Scripts/webkitdirs.pm:
721         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
722
723 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
724
725         [Win] Unreviewed 64-bit build fix after switch to CMake.
726
727         * Scripts/webkitdirs.pm:
728         (determineIsWin64FromArchitecture): Added.
729
730 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
731
732         printing does not use minimum page zoom factor
733         https://bugs.webkit.org/show_bug.cgi?id=108507
734
735         Reviewed by Darin Adler.
736
737         WebKitTestRunner always takes the snapshots from the UI process
738         (expect for IOS), so in the case of printing, the layout in the
739         web view is not the expected one. When printing, we need to take
740         the snapshot in the web process and ensure it's rendered with a
741         PrintContext.
742
743         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
744         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
745         kWKSnapshotOptionsPrinting option to
746         WKBundlePageCreateSnapshotWithOptions() when printing.
747
748 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
749
750         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
751         https://bugs.webkit.org/show_bug.cgi?id=149595
752
753         Reviewed by Tim Horton.
754
755         All ports except IOS implement
756         PlatformWebView::windowSnapshotImage() to generate the snapshot
757         for the pixel tests in the UI process. But we are still generating
758         a snapshot for pixel tests in the Web process too, that is passed
759         to the UI process but ignored.
760         Whether a pixel result is needed or not, is only known by the web
761         process depending on whether the test called dumpAsText with
762         dumpPixels == true or not. Since the pixels are now dump in the UI
763         process, we need to pass that information to the UI process when
764         the test is done. For that we set a PixelResultIsPending bool
765         parameter to the Done message, and we only add the PixelResult
766         when UI process doesn't need to generate the pixels dump.
767
768         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
769         (WTR::InjectedBundle::didReceiveMessageToPage): Set
770         m_pixelResultIsPending to false on reset.
771         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
772         Done message, and set the PixelResult if m_pixelResultIsPending is false.
773         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
774         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
775         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
776         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
777         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
778         port.
779         * WebKitTestRunner/TestInvocation.cpp:
780         (WTR::TestInvocation::dumpResults): Use either the pixel result
781         from the web process or generate a pixel result from the web view
782         if need it.
783         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
784         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
785         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
786         is created by the caller now, but the CG implementation needs to
787         know if it's a Web or UI process snapshot.
788         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
789         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
790         cairo surface for the given image.
791         * WebKitTestRunner/cg/TestInvocationCG.cpp:
792         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
793         CGContext for the given image.
794
795 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
796
797         Fix JS errors on dashboard metrics page
798         https://bugs.webkit.org/show_bug.cgi?id=149608
799
800         Reviewed by Alexey Proskuryakov.
801
802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
803         (initPlatformsByFamily): 
804         (updateHiddenPlatforms):
805         (parsePlatformFamily): Deleted.
806         (updateToggleButtons): Deleted.
807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
808         (updateHiddenPlatforms): Added to remove errors.
809         (initPlatformsByFamily): Added to remove errors.
810         (unhiddenQueues): Updated to use Settings.
811         (documentReady): Added logic to add toggle buttons to the settings menu.
812         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
813         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
814         MetricsMain.js to Settings.
815         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
816         MetricsMain.js to Settings.
817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
818         (QueueView.prototype._updateHiddenState): Updated to use Settings.
819
820 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
821
822         Appscale query fails because of missing index
823         https://bugs.webkit.org/show_bug.cgi?id=149609
824
825         Reviewed by Darin Adler.
826
827         * QueueStatusServer/index.yaml: Added the required index.
828
829 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
830
831         [Win] Fix the 64-bit build after switch to cmake.
832
833         Reviewed by Alex Christensen.
834
835         * Scripts/webkitdirs.pm:
836         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
837         run a 64-bit build.
838
839 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
840
841         [Win] Allow Windows to run test-webkitpy without Cygwin
842         https://bugs.webkit.org/show_bug.cgi?id=149602
843
844         Reviewed by Alex Christensen.
845
846         These changes mostly shift from hard-coded paths using UNIX-style
847         separators to Python's "os.path.join" syntax that uses the correct
848         path separator for each platform.
849         
850         * Scripts/webkitpy/common/system/path.py:
851         (cygpath): Don't pass paths through Cygpath on native Windows.
852         * Scripts/webkitpy/port/win.py:
853         (WinPort._path_to_apache): Use os.path.join.
854         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
855         in 64-bit environments).
856         * Scripts/webkitpy/style/checker.py: Use os.path.join.
857         * Scripts/webkitpy/style/checker_unittest.py:
858         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
859         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
860         (GlobalVariablesTest): Ditto.
861         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
862         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
863         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
864         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
865         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
866         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
867         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
868         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
869         (StyleProcessor_CodeCoverageTest): Ditto.
870         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
871         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
872         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
873         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
874         manual string concatenation of paths.
875
876 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
877
878         Add bugzilla addresses of committers to contributors.json
879         https://bugs.webkit.org/show_bug.cgi?id=149520
880
881         Reviewed by Darin Adler.
882
883         * Scripts/webkitpy/common/config/contributors.json:
884
885 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
886
887         validate-committer-lists -b shouldn't need edituser privileges
888         https://bugs.webkit.org/show_bug.cgi?id=149519
889
890         Reviewed by Darin Adler.
891
892         * Scripts/validate-committer-lists:
893         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
894         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
895         (BugzillaQueries.is_invalid_bugzilla_email):
896         (BugzillaQueries): Deleted.
897         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
898
899 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
900
901         Unreviewed. Gardening: skip media stream tests failing after r190262.
902
903         * Scripts/run-gtk-tests:
904         (TestRunner):
905
906 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
907
908         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
909         https://bugs.webkit.org/show_bug.cgi?id=149571
910
911         Reviewed by Dan Bernstein.
912
913         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
914
915         * DumpRenderTree/mac/Configurations/Base.xcconfig:
916         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
917         * LayoutTestRelay/Configurations/Base.xcconfig:
918         * MiniBrowser/Configurations/Base.xcconfig:
919         * MiniBrowser/Configurations/DebugRelease.xcconfig:
920         * TestWebKitAPI/Configurations/Base.xcconfig:
921         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
922         * WebEditingTester/Configurations/Base.xcconfig:
923         * WebEditingTester/Configurations/DebugRelease.xcconfig:
924         * WebKitTestRunner/Configurations/Base.xcconfig:
925         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
926         * WebKitTestRunner/iOS.xcconfig: Removed.
927
928 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
929
930         Clean up user media request internal API
931         https://bugs.webkit.org/show_bug.cgi?id=149527
932
933         Reviewed by Tim Horton.
934
935         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
936         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
937
938         * WebKitTestRunner/TestController.cpp:
939         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
940
941 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
942
943         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
944         https://bugs.webkit.org/show_bug.cgi?id=149577
945
946         Reviewed by Tim Horton.
947         
948         When calling testRunner.runUIScript() from a page load event, the script could run
949         in the UI process before the current remote layer tree transaction had been handled
950         there. This meant that runUIScript() could query state which was about to change.
951         
952         Fix by delaying the execution of the UI script until a layer tree transaction has
953         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
954
955         * WebKitTestRunner/TestInvocation.cpp:
956         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
957         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
958         * WebKitTestRunner/TestInvocation.h:
959
960 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
961
962         [Mac] Media tests start to time out after a few days of bot uptime
963         https://bugs.webkit.org/show_bug.cgi?id=149468
964
965         Reviewed by Darin Adler.
966
967         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
968         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
969         all temporary and cache files go to a custom location.
970
971         * Scripts/webkitpy/port/base.py:
972         * Scripts/webkitpy/port/driver.py:
973         * Scripts/webkitpy/port/mac.py:
974         * Scripts/webkitpy/port/win.py:
975         (WinPort._driver_tempdir_for_environment): Deleted unused function.
976
977 2015-09-25  Dan Bernstein  <mitz@apple.com>
978
979         Removed MiniBrowser.entitlements.
980
981         Rubber-stamped by Anders Carlsson.
982
983         The entitlements weren’t used anyway.
984
985         * MiniBrowser/MiniBrowser.entitlements: Removed.
986         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
987
988 2015-09-24  Daniel Bates  <dabates@apple.com>
989
990         Add WebKitSystemInterface for iOS 9.0
991         https://bugs.webkit.org/show_bug.cgi?id=149550
992
993         Rubber-stamped by Alexey Proskuryakov.
994
995         * Scripts/copy-webkitlibraries-to-product-directory:
996
997 2015-09-24  Daniel Bates  <dabates@apple.com>
998
999         Support building for arbitrary architectures
1000         https://bugs.webkit.org/show_bug.cgi?id=149539
1001
1002         Reviewed by Alexey Proskuryakov.
1003
1004         Teach buildbot to pass the architectures associated with the builder to build-webkit
1005         when building on OS X and iOS. As a side effect of this change we now support building
1006         universal binaries when multiples architectures are specified.
1007
1008         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1009         (CompileWebKit.start):
1010
1011 2015-09-24  Daniel Bates  <dabates@apple.com>
1012
1013         Fix the build after <http://trac.webkit.org/changeset/190212>
1014         (http://trac.webkit.org/changeset/190212)
1015
1016         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1017
1018         * BuildSlaveSupport/built-product-archive:
1019         (main):
1020
1021 2015-09-24  Daniel Bates  <dabates@apple.com>
1022
1023         Support running unit tests on iOS Simulator test bot
1024         https://bugs.webkit.org/show_bug.cgi?id=149536
1025
1026         Reviewed by Alexey Proskuryakov.
1027
1028         Implements support for running unit tests on a iOS test bot. At the time of writing,
1029         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1030
1031         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1032         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1033         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1034
1035 2015-09-24  Daniel Bates  <dabates@apple.com>
1036
1037         Add support infrastructure for OpenSource iOS builders and testers
1038         https://bugs.webkit.org/show_bug.cgi?id=149534
1039
1040         Reviewed by Darin Adler.
1041
1042         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1043         scripts about iOS.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1046         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1047         --ios-simulator or --device for a builder/tester whose full platform name begins with
1048         "ios-simulator" or "ios", respectively.
1049         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1050         * BuildSlaveSupport/built-product-archive:
1051         (main): Pass the full platform name to determineWebKitBuildDirectory().
1052         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1053         command line flag when building for iOS.
1054         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1055         parameter fullPlatform. This parameter was originally added in r125066 to support the
1056         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1057         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1058         * BuildSlaveSupport/clean-build:
1059         (main): Call script webkit-build-directory with the appropriate command line flag when
1060         building for iOS.
1061         * BuildSlaveSupport/delete-stale-build-files:
1062         (main): Use the same logic for iOS as we do for Mac.
1063         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1064         flag when building for iOS.
1065         * BuildSlaveSupport/test-result-archive:
1066         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1067
1068 2015-09-24  Daniel Bates  <dabates@apple.com>
1069
1070         Remove Chromium-specific changes to script built-product-archive
1071         https://bugs.webkit.org/show_bug.cgi?id=149530
1072
1073         Rubber-stamped by Csaba Osztrogonác.
1074
1075         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1076         Chromium code has long since been removed from the OpenSource WebKit Project.
1077
1078         * BuildSlaveSupport/built-product-archive:
1079         (createZipManually):
1080         (createZip):
1081         (archiveBuiltProduct):
1082
1083 2015-09-24  Dan Bernstein  <mitz@apple.com>
1084
1085         Build fix.
1086
1087         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1088
1089 2015-09-24  Mark Lam  <mark.lam@apple.com>
1090
1091         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1092
1093         * Scripts/webkitpy/common/config/contributors.json:
1094
1095 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1096
1097         Unreviewed. Fix GObject DOM API breaks after r190120.
1098
1099         Bring back code removed in r169931 to handle documentation of
1100         deleted classes.
1101
1102         * gtk/webkitdom.py:
1103         (WebKitDOMDocGenerator):
1104         (WebKitDOMDocGenerator.write_deleted_classes):
1105         (WebKitDOMDocGenerator.generate):
1106         (write_deleted_classes):
1107         (WebKitDOMDocGeneratorSections._deleted_class):
1108         (WebKitDOMDocGeneratorSections._deleted_class.in):
1109         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1110         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1111
1112 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1113
1114         [Cocoa] [Font Features] Implement font-variant-*
1115         https://bugs.webkit.org/show_bug.cgi?id=148413
1116
1117         Reviewed by Darin Adler.
1118
1119         Update test font to use "lnum" feature.
1120
1121         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1122         (Generator::appendGSUBTable):
1123
1124 2015-09-22  Andy Estes  <aestes@apple.com>
1125
1126         ContentFiltering.AllowDownloadAfterAddData is very flaky
1127         https://bugs.webkit.org/show_bug.cgi?id=148885
1128         <rdar://problem/22729563>
1129
1130         Reviewed by Alexey Proskuryakov.
1131
1132         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1133         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1134         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1135
1136         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1137         (downloadTest):
1138
1139 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
1140
1141         Mavericks: Media tests start to time out after a few days of bot uptime
1142         https://bugs.webkit.org/show_bug.cgi?id=149468
1143
1144         Reviewed by Chris Dumez.
1145
1146         * Scripts/webkitpy/port/base.py:
1147         * Scripts/webkitpy/port/driver.py:
1148         * Scripts/webkitpy/port/mac.py:
1149
1150 2015-09-22  Nan Wang  <n_wang@apple.com>
1151
1152         Unreviewed, add myself to the committers list.
1153
1154         * Scripts/webkitpy/common/config/contributors.json:
1155
1156 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1157
1158         Remove 'nullable' to fix older iOS builds.
1159
1160         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1161         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1162
1163 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1164
1165         [Win] Show tiled drawing debug overlay on Windows
1166         https://bugs.webkit.org/show_bug.cgi?id=149426
1167
1168         Reviewed by Dean Jackson.
1169
1170         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1171         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1172         * MiniBrowser/win/Common.cpp:
1173         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1174         flag if needed.
1175         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1176
1177 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1178
1179         [Win] Use command-line argument to launch in regular or High DPI mode.
1180         https://bugs.webkit.org/show_bug.cgi?id=149417
1181
1182         Reviewed by Dean Jackson.
1183
1184         * MiniBrowser/win/Common.cpp:
1185         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1186         very start of execution, before the MiniBrowser.dll is loaded.
1187         * win/DLLLauncher/DLLLauncherMain.cpp:
1188         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1189         present. On WinCairo, always use High DPI.
1190
1191 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1192
1193         32-bit Mac build fix attempt after r190065.
1194
1195         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1196
1197 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
1198
1199         [OS X] Update for Xcode 7.0 on Yosemite
1200         https://bugs.webkit.org/show_bug.cgi?id=149389
1201
1202         Reviewed by Dan Bernstein.
1203
1204         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1205         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1206         Removed unneeded declarations - conforming to a protocol is sufficient.
1207
1208         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1209         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1210         Changed the definitions to be compiled whenever the SDK requires it (so we will have
1211         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1212
1213 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1214
1215         Add the ability for tests to run script in the UI process in WebKitTestRunner
1216         https://bugs.webkit.org/show_bug.cgi?id=149356
1217
1218         Reviewed by Tim Horton.
1219
1220         This change adds testRunner.runUIScript(script, callback), which allows a test
1221         to execute script in a JSContext which runs in the UI process. That context
1222         has bindings exposed through the UIScriptController interface; currently one test
1223         function, and some iOS-specific functions are included. UIScriptController can be
1224         async with a callback, and runUIScript() itself is asynchronous. When the UI 
1225         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1226         is a string passed back to the web process, and given to the runUIScript()
1227         callback function.
1228         
1229         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1230
1231         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1232         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1233         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1234         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1235         complete, call back into TestRunner.
1236         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1237         (WTR::nextUIScriptCallbackID):
1238         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1239         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1240         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1241         * WebKitTestRunner/PlatformWebView.h:
1242         * WebKitTestRunner/TestController.cpp:
1243         (WTR::updateTestOptionsFromTestHeader):
1244         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1245         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1246         * WebKitTestRunner/TestInvocation.cpp:
1247         (WTR::TestInvocation::shouldUseFixedLayout):
1248         (WTR::TestInvocation::shouldUseThreadedScrolling):
1249         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1250         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1251         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1252         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1253         * WebKitTestRunner/TestInvocation.h:
1254         * WebKitTestRunner/TestOptions.h:
1255         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1256         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1257         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1258         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1259         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1260         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1261         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1262         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1263         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1264         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1265         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1266         (WTR::UIScriptController::doAsyncTask):
1267         (WTR::UIScriptController::zoomToScale):
1268         (WTR::UIScriptController::zoomScale):
1269         (WTR::UIScriptController::minimumZoomScale):
1270         (WTR::UIScriptController::maximumZoomScale):
1271         (WTR::UIScriptController::contentVisibleRect):
1272         * WebKitTestRunner/mac/EventSenderProxy.mm:
1273         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1274         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1275         * WebKitTestRunner/mac/TestControllerMac.mm:
1276         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1277         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1278         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1279         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1280         (UIScriptContext::UIScriptContext):
1281         (UIScriptContext::~UIScriptContext):
1282         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1283         asynchronous, call the callback.
1284         (UIScriptContext::nextTaskCallbackID):
1285         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1286         that has a callback). Has to store the callbackID of the script, so code called from the completion
1287         callback knows which UI script invoked it.
1288         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1289         (UIScriptContext::uiScriptComplete):
1290         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1291         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1292         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1293         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1294         (WTR::UIScriptController::UIScriptController):
1295         (WTR::UIScriptController::makeWindowObject):
1296         (WTR::UIScriptController::wrapperClass):
1297         (WTR::UIScriptController::doAsyncTask):
1298         (WTR::UIScriptController::zoomToScale):
1299         (WTR::UIScriptController::zoomScale):
1300         (WTR::UIScriptController::minimumZoomScale):
1301         (WTR::UIScriptController::maximumZoomScale):
1302         (WTR::UIScriptController::contentVisibleRect):
1303         (WTR::UIScriptController::uiScriptComplete):
1304         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1305         (WTR::UIScriptController::create):
1306         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1307
1308 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1309
1310         Turn on threaded scrolling by default in the tests
1311         https://bugs.webkit.org/show_bug.cgi?id=149377
1312
1313         Reviewed by Simon Fraser.
1314
1315         * WebKitTestRunner/mac/TestControllerMac.mm:
1316         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1317         (WTR::shouldUseThreadedScrolling): Deleted.
1318         Turn on threaded scrolling by default.
1319
1320 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1321
1322         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1323         https://bugs.webkit.org/show_bug.cgi?id=149252
1324
1325         Reviewed by Darin Adler.
1326
1327         In case of glib tests the test runner notifies about tests
1328         crashing, but for google tests we don't get any feedback, which
1329         means that in case of a test crashing we get a list of **PASS**
1330         messages and at the summary we are notified that the test suite
1331         has failed, but it's impossible to know which test cases have failed.
1332
1333         * Scripts/run-gtk-tests:
1334         (TestRunner._run_google_test): Add a **CRASH** message if test
1335         case crashed.
1336
1337 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1338
1339         WebKitTestRunner can leak user content script results between tests
1340         https://bugs.webkit.org/show_bug.cgi?id=149391
1341
1342         Reviewed by Sam Weinig.
1343
1344         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1345         about:blank, and thus about:blank doesn't have unintended side effects.
1346
1347         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1348         (WTR::InjectedBundle::beginTesting):
1349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1350         (WTR::InjectedBundlePage::resetAfterTest):
1351
1352 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1353
1354         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1355         https://bugs.webkit.org/show_bug.cgi?id=149384
1356
1357         Reviewed by Chris Fleizach.
1358
1359         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1360         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1361         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1362         regardless of whether someone else holds a reference (we also call -stopListening in
1363         -dealloc).
1364
1365         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1366         (AccessibilityController::platformResetToConsistentState):
1367         (AccessibilityController::addNotificationListener):
1368         Ditto.
1369
1370 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1371
1372         Remove XHR_TIMEOUT compilation guard
1373         https://bugs.webkit.org/show_bug.cgi?id=149260
1374
1375         Reviewed by Benjamin Poulain.
1376
1377         * Scripts/webkitperl/FeatureList.pm:
1378
1379 2015-09-19  Dan Bernstein  <mitz@apple.com>
1380
1381         Attempted build fix.
1382
1383         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1384
1385 2015-09-18  Commit Queue  <commit-queue@webkit.org>
1386
1387         Unreviewed, rolling out r189908.
1388         https://bugs.webkit.org/show_bug.cgi?id=149368
1389
1390         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1391
1392         Reverted changeset:
1393
1394         "printing does not use minimum page zoom factor"
1395         https://bugs.webkit.org/show_bug.cgi?id=108507
1396         http://trac.webkit.org/changeset/189908
1397
1398 2015-09-18  Andy Estes  <aestes@apple.com>
1399
1400         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1401         https://bugs.webkit.org/show_bug.cgi?id=149360
1402
1403         Reviewed by Tim Horton.
1404
1405         Added an API test.
1406
1407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1408         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1409         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1410         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1411         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1412         (TEST):
1413         * TestWebKitAPI/ios/pages.pages: Added.
1414
1415 2015-09-18  Nan Wang  <n_wang@apple.com>
1416
1417         AX: Implement ARIA 1.1 @aria-current on iOS
1418         https://bugs.webkit.org/show_bug.cgi?id=149297
1419
1420         Reviewed by Chris Fleizach.
1421
1422         Added support to test aria-current on iOS.
1423
1424         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1425         (AccessibilityUIElement::stringAttributeValue):
1426         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1427         (WTR::AccessibilityUIElement::stringAttributeValue):
1428
1429 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
1430
1431         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1432         https://bugs.webkit.org/show_bug.cgi?id=149352
1433
1434         Reviewed by Simon Fraser.
1435
1436         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1437         m_context can be null. This may indicate a bug in webkitpy too, but
1438         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1439         wrong with opening and immediately closing it.
1440
1441 2015-09-18  Daniel Bates  <dabates@apple.com>
1442
1443         isGitSVNDirectory() returns true when Git is not installed
1444         https://bugs.webkit.org/show_bug.cgi?id=149351
1445
1446         Reviewed by Alexey Proskuryakov.
1447
1448         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1449         Git is not installed on the machine.
1450
1451         * Scripts/VCSUtils.pm:
1452         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1453         status code 0 (success).
1454
1455 2015-09-18  Alex Christensen  <achristensen@webkit.org>
1456
1457         Prevent build-webkit from building four times on Windows 
1458         https://bugs.webkit.org/show_bug.cgi?id=149336
1459
1460         Reviewed by Brent Fulgham.
1461
1462         * Scripts/build-webkit:
1463         Move the Windows code out of the for loop iterating over each subdirectory to be build.
1464         They're built all at once.
1465         * Scripts/webkitdirs.pm:
1466         (buildVisualStudioProject):
1467         (cmakeGeneratedBuildfile):
1468         Don't generate the Visual Studio solution if it already exists.
1469         It will run CMake again if necessary.
1470
1471 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1472
1473         [iOS WK2] WTR fails to set the key window in the UIKit sense
1474         https://bugs.webkit.org/show_bug.cgi?id=149325
1475
1476         Reviewed by Tim Horton.
1477
1478         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1479         This causes UIKit to bypass code that actually sets the key window, resulting in
1480         [UIAppliation sharedApplication].keyWindow always being nil.
1481
1482         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1483         -[WebKitTestRunnerWindow isKeyWindow] call super.
1484
1485         * WebKitTestRunner/PlatformWebView.h:
1486         (WTR::PlatformWebView::setWindowIsKey): Deleted.
1487         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1488         (WTR::PlatformWebView::setWindowIsKey):
1489         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1490         (WTR::PlatformWebView::setWindowIsKey):
1491         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1492         (-[WebKitTestRunnerWindow isKeyWindow]):
1493         (WTR::PlatformWebView::PlatformWebView):
1494         (WTR::PlatformWebView::~PlatformWebView):
1495         (WTR::PlatformWebView::setWindowIsKey):
1496         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1497         (WTR::PlatformWebView::setWindowIsKey):
1498
1499 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1500
1501         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1502         https://bugs.webkit.org/show_bug.cgi?id=149321
1503
1504         Reviewed by Tim Horton.
1505         
1506         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
1507         enabled the "testing" viewport configuration, which disables page scaling.
1508         
1509         If we're running viewport tests, we want the normal web page configuration.
1510         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1511         based on whether the test is in a "viewport" directory.
1512
1513         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1514         (WTR::InjectedBundle::beginTesting):
1515         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1516         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1517         * WebKitTestRunner/TestInvocation.cpp:
1518         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1519         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1520         (WTR::TestInvocation::shouldMakeViewportFlexible):
1521         (WTR::TestInvocation::invoke):
1522         * WebKitTestRunner/TestInvocation.h:
1523         * WebKitTestRunner/ios/TestControllerIOS.mm:
1524         (WTR::TestController::platformConfigureViewForTest):
1525         (WTR::shouldMakeViewportFlexible): Deleted.
1526
1527 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1528
1529         Give iOS WebKitTestRunner a launch storyboard
1530         https://bugs.webkit.org/show_bug.cgi?id=149314
1531
1532         Reviewed by Dan Bates.
1533         
1534         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1535         that it's been built for specific device configurations, and puts the window
1536         at the top of the screen. This simplifies coordinate conversions in a future patch.
1537
1538         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1539         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1540         * WebKitTestRunner/ios/Launch.storyboard: Added.
1541
1542 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1543
1544         Update licence in r189890
1545         https://bugs.webkit.org/show_bug.cgi?id=149306
1546
1547         Reviewed by Dean Jackson.
1548
1549         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1550         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1551         * FontWithFeatures/FontWithFeatures/main.cpp:
1552
1553 2015-09-17  Mark Lam  <mark.lam@apple.com>
1554
1555         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1556         https://bugs.webkit.org/show_bug.cgi?id=149285
1557
1558         Reviewed by Saam Barati.
1559
1560         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1561
1562         * Scripts/run-javascriptcore-tests:
1563         (runJSCStressTests):
1564
1565 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1566
1567         Switch AppleWin build to use CMake
1568         https://bugs.webkit.org/show_bug.cgi?id=149163
1569
1570         Reviewed by Brent Fulgham.
1571
1572         * Scripts/build-webkit:
1573         * Scripts/run-api-tests:
1574         (runTest):
1575         (listAllTests):
1576         (prepareEnvironmentForRunningTestTool):
1577         (testToolPaths):
1578         (testToolPath): Deleted.
1579         Run the API tests as separate executables on Windows.
1580         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1581         * Scripts/webkitdirs.pm:
1582         (checkRequiredSystemConfig):
1583         (jhbuildWrapperPrefixIfNeeded):
1584         (generateBuildSystemFromCMakeProject):
1585         Fix configuration quirks.
1586
1587 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1588
1589         Added toggle options for hiding and showing certain platform families on the dashboard.
1590         https://bugs.webkit.org/show_bug.cgi?id=148403
1591
1592         Reviewed by David Kilzer.
1593
1594         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1595         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1596         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1597         in lieu of an "all" button in the toggle menu.
1598
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1600         (parsePlatformFamily): Helper function to parse out a platform family.
1601         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1602         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1603         (updateToggleButtons): Updates the status of the toggle buttons.
1604         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1605         (documentReady): Added creation of toggle buttons.
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1607         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1608         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1609         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
1610         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1612         (QueueView): Updated to use hiddenPlatformFamilies.
1613         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1615         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1616         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1617         (Settings.prototype.toggleHiddenPlatform): Deleted.
1618         (Settings.prototype.clearHiddenPlatforms): Deleted.
1619         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1621         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1622         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1623         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1624         (table.queue-grid tr.headers th):
1625         (div.settingsWrapper.hide):
1626         (div.settingsWrapper):
1627         (div.familyToggleWrapper):
1628         (div.platformFamilyToggleButton):
1629         (div.platformFamilyShowToggleButton:not(:last-child)):
1630         (div.familyShown):
1631         (div.accessibilityButton):
1632         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1633         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1634         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1635         platformFamilyToggleButton and settingsWrapper class.
1636         (.accessibilityButton): Deleted.
1637
1638 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1639
1640         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1641         https://bugs.webkit.org/show_bug.cgi?id=148904
1642
1643         Reviewed by Myles Maxfield.
1644
1645         * WebKitTestRunner/TestController.cpp:
1646         (WTR::parseBooleanTestHeaderValue):
1647         (WTR::updateViewOptionsFromTestHeader):
1648         Check for the key "useThreadedScrolling".
1649         Add some code to check for "true" and "false" for boolean options.
1650
1651         (WTR::TestController::viewOptionsForTest):
1652         Apply the test's overrides last, even after the platform's.
1653
1654 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1655
1656         printing does not use minimum page zoom factor
1657         https://bugs.webkit.org/show_bug.cgi?id=108507
1658
1659         Reviewed by Darin Adler.
1660
1661         WebKitTestRunner always takes the snapshots from the UI process
1662         (expect for IOS), so in the case of printing, the layout in the
1663         web view is not the expected one. When printing, we need to take
1664         the snapshot in the web process and ensure it's rendered with a
1665         PrintContext.
1666
1667         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1668         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1669         kWKSnapshotOptionsPrinting option to
1670         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1671         printing, don't even create the snapshot, since it will be ignored
1672         by the UI process that always creates its own from the WebView (expect for IOS platform)
1673         * WebKitTestRunner/TestInvocation.cpp:
1674         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1675         received from the web process if any when comparing pixel
1676         results. Now we only receive a snapshot from the web process in
1677         case of printing, or when platform is IOS. Otherwhise, generate
1678         the snapshot from the WebView as usual.
1679         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1680         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1681         is created by the caller now, but the CG implementation needs to
1682         know if it's a Web or UI process snapshot.
1683         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1684         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1685         cairo surface for the given image.
1686         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1687         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1688         CGContext for the given image.
1689
1690 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1691
1692         Create a font which can be used for testing font features
1693         https://bugs.webkit.org/show_bug.cgi?id=149237
1694
1695         Reviewed by Simon Fraser.
1696
1697         This patch adds a new project in the Tools/ directory which generates a font which can
1698         be used for testing font features. This is a standalone project consisting of two files:
1699         1. A file which actually generates the byte vector representing the font. This file has
1700         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1701         specific, and only relies on the C++ STL.
1702         2. A file with a main() which calls generateFont() and writes out the font, as well as
1703         uses the font to render some demonstration text into a .png file. This file is platform
1704         specific.
1705
1706         The font itself only supports the following characters:
1707         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1708         However, the shape of these letters are either an X or a check mark.
1709
1710         The letter "A" always is a check mark.
1711         The letter "B" always is an X.
1712         Without any font features turned on, the rest of the letters are shown as X.
1713
1714         Each font feature has an letter associated with it. When the font feature is enabled,
1715         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1716         as a check mark.
1717
1718         Here are the mappings of font features to letters:
1719         liga: C
1720         clig: D
1721         dlig: E
1722         hlig: F
1723         calt: G
1724         subs: H
1725         sups: I
1726         smcp: J
1727         c2sc: K
1728         pcap: L
1729         c2pc: M
1730         unic: N
1731         titl: O
1732         onum: P
1733         pnum: Q
1734         tnum: R
1735         frac: S
1736         afrc: T
1737         ordn: U
1738         zero: V
1739         hist: W
1740         jp78: X
1741         jp83: Y
1742         jp90: Z
1743         jp04: a
1744         smpl: b
1745         trad: c
1746         fwid: d
1747         pwid: e
1748         ruby: f
1749
1750         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1751         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1752         (integralLog2):
1753         (roundDownToPowerOfTwo):
1754         (isFourByteAligned):
1755         (clampTo):
1756         (append32):
1757         (writeCFFEncodedNumber):
1758         (CFFBuilder::CFFBuilder):
1759         (CFFBuilder::takeResult):
1760         (CFFBuilder::moveTo):
1761         (CFFBuilder::lineTo):
1762         (CFFBuilder::curveToCubic):
1763         (CFFBuilder::closePath):
1764         (CFFBuilder::writePoint):
1765         (generateBoxCharString):
1766         (generateCheckCharString):
1767         (generateXCharString):
1768         (charStringForGlyph):
1769         (Generator::generate):
1770         (Generator::Placeholder::Placeholder):
1771         (Generator::Placeholder::populate):
1772         (Generator::Placeholder::~Placeholder):
1773         (Generator::placeholder):
1774         (Generator::append16):
1775         (Generator::append32):
1776         (Generator::append32BitCode):
1777         (Generator::overwrite16):
1778         (Generator::overwrite32):
1779         (Generator::appendCFFTable):
1780         (Generator::appendSubstitutionSubtable):
1781         (Generator::appendScriptSubtable):
1782         (Generator::appendGSUBTable):
1783         (Generator::appendOS2Table):
1784         (Generator::appendFormat12CMAPTable):
1785         (Generator::appendFormat4CMAPTable):
1786         (Generator::appendCMAPTable):
1787         (Generator::appendHEADTable):
1788         (Generator::appendHHEATable):
1789         (Generator::appendHMTXTable):
1790         (Generator::appendMAXPTable):
1791         (Generator::appendNAMETable):
1792         (Generator::appendPOSTTable):
1793         (Generator::calculateChecksum):
1794         (Generator::appendTable):
1795         (generateFont):
1796         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1797         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1798         (drawTextWithFeature):
1799         (main):
1800
1801 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1802
1803         Unreviewed, rolling out r189875 and r189878.
1804         https://bugs.webkit.org/show_bug.cgi?id=149235
1805
1806         cygwin cmake build not ready yet (Requested by alexchristensen
1807         on #webkit).
1808
1809         Reverted changesets:
1810
1811         "Switch AppleWin build to use CMake"
1812         https://bugs.webkit.org/show_bug.cgi?id=149163
1813         http://trac.webkit.org/changeset/189875
1814
1815         "Cygwin build fix after r189875"
1816         http://trac.webkit.org/changeset/189878
1817
1818 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1819
1820         Cygwin build fix after r189875
1821
1822         * Scripts/build-webkit:
1823         * Scripts/webkitdirs.pm:
1824         (jhbuildWrapperPrefixIfNeeded):
1825         (generateBuildSystemFromCMakeProject):
1826         Make things work with cygwin and cmake.
1827
1828 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1829
1830         Switch AppleWin build to use CMake
1831         https://bugs.webkit.org/show_bug.cgi?id=149163
1832
1833         Reviewed by Brent Fulgham.
1834
1835         * Scripts/build-webkit:
1836         Build with CMake.
1837         * Scripts/run-api-tests:
1838         (runTest):
1839         (listAllTests):
1840         (prepareEnvironmentForRunningTestTool):
1841         (testToolPaths):
1842         (testToolPath): Deleted.
1843         Run the API tests as separate executables on Windows.
1844         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1845
1846 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1847
1848         Add newer build.webkit.org pages to robots.txt
1849         https://bugs.webkit.org/show_bug.cgi?id=149219
1850
1851         Reviewed by Darin Adler.
1852
1853         Indexing bot watcher's dashboard can't be good.
1854
1855         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1856
1857 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1858
1859         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1860
1861         * BuildSlaveSupport/built-product-archive:
1862         (unzipArchive):
1863
1864 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1865
1866         [EFL] Fix the help message of separated web process option of MiniBrowser
1867         https://bugs.webkit.org/show_bug.cgi?id=149212
1868
1869         Reviewed by Gyuyoung Kim.
1870
1871         * MiniBrowser/efl/main.c:
1872
1873 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1874
1875         Fix python syntax after r189851.
1876
1877         * BuildSlaveSupport/built-product-archive:
1878         (unzipArchive):
1879         For loops need a colon.
1880
1881 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1882
1883         Fix Windows test bots after changing to non-cygwin build
1884         https://bugs.webkit.org/show_bug.cgi?id=149196
1885
1886         Reviewed by Daniel Bates.
1887
1888         * BuildSlaveSupport/built-product-archive:
1889         (unzipArchive):
1890         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1891         prevent us from executing files from the archive on the test bots.
1892
1893 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1894
1895         Add ShadowRoot interface and Element.prototype.attachShadow
1896         https://bugs.webkit.org/show_bug.cgi?id=149187
1897
1898         Reviewed by Antti Koivisto.
1899
1900         * Scripts/webkitperl/FeatureList.pm:
1901
1902 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1903
1904         Appscale queue status json output lacks bots
1905         https://bugs.webkit.org/show_bug.cgi?id=149194
1906         <rdar://problem/22171089>
1907
1908         Reviewed by Alexey Proskuryakov.
1909
1910         * QueueStatusServer/handlers/queuestatusjson.py:
1911         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1912         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1913
1914 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1915
1916         [Win] Provide a means for viewing the layer tree
1917         https://bugs.webkit.org/show_bug.cgi?id=149165
1918
1919         Reviewed by Simon Fraser.
1920
1921         Update MiniBrowser with a new Debug menu option that will
1922         dump the current layer tree to the debug console.
1923         
1924         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1925         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1926         * MiniBrowser/win/Common.cpp:
1927         (WndProc): Add handler for 'Print Layer Tree' menu option.
1928         * MiniBrowser/win/MiniBrowser.cpp:
1929         (MiniBrowser::printLayerTree): Added Handler.
1930         * MiniBrowser/win/MiniBrowser.h:
1931
1932 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1933
1934         WebKitTestRunner declarative language setting is broken for iOS
1935         https://bugs.webkit.org/show_bug.cgi?id=149119
1936
1937         Unreviewed.
1938
1939         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1940         lost in the final version which got committed. This simply implements the existing
1941         OS X behavior on iOS.
1942
1943         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1944         (WTR::InjectedBundle::platformInitialize):
1945
1946 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1947
1948         Unreviewed, add myself to committers list.
1949
1950         * Scripts/webkitpy/common/config/contributors.json:
1951
1952 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1953
1954         [Cocoa] Allow testing with the system language
1955         https://bugs.webkit.org/show_bug.cgi?id=148671
1956
1957         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1958
1959         React to tests marked with language=lang1,lang2,etc in their header.
1960         Once this information is parsed, pass it to
1961         WKContextConfigurationSetOverrideLanguages().
1962
1963         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1964         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1965         list.
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::createWebViewWithOptions): Call
1968         WKContextConfigurationSetOverrideLanguages().
1969         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1970         * WebKitTestRunner/TestOptions.h:
1971         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1972         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1973         option to restart the web process.
1974         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1975         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1976
1977 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1978
1979         [WKTR] Allow changing the WKContextConfiguration between successive tests
1980         https://bugs.webkit.org/show_bug.cgi?id=148833
1981
1982         Reviewed by Tim Horton.
1983
1984         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1985         However, there are certain tests which require specifying options in this object. This patch makes
1986         our existing code for recreating the test runner web view also recreate the WKContext.
1987
1988         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1989         class.
1990
1991         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1992         * WebKitTestRunner/PlatformWebView.h:
1993         (WTR::PlatformWebView::options):
1994         * WebKitTestRunner/TestController.cpp:
1995         (WTR::TestController::initialize):
1996         (WTR::TestController::generateContextConfiguration):
1997         (WTR::TestController::generatePageConfiguration):
1998         (WTR::TestController::createWebViewWithOptions):
1999         (WTR::TestController::ensureViewSupportsOptionsForTest):
2000         (WTR::updateContextConfigurationOptionsFromTestHeader):
2001         (WTR::TestController::contextConfigurationOptionsForTest):
2002         (WTR::TestController::platformCreateWebView):
2003         (WTR::TestController::platformCreateOtherPage):
2004         (WTR::updateViewOptionsFromTestHeader): Deleted.
2005         (WTR::TestController::viewOptionsForTest): Deleted.
2006         * WebKitTestRunner/TestController.h:
2007         (WTR::TestController::injectedBundlePath):
2008         (WTR::TestController::testPluginDirectory):
2009         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2011         (WTR::TestController::platformCreateWebView):
2012         (WTR::TestController::platformCreateOtherPage):
2013         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2014         (WTR::PlatformWebView::PlatformWebView):
2015         (WTR::PlatformWebView::viewSupportsOptions):
2016         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2017         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2018         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2019         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2020         (WTR::PlatformWebView::PlatformWebView):
2021         (WTR::PlatformWebView::viewSupportsOptions):
2022         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2023         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2024         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2025         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2026         (WTR::PlatformWebView::PlatformWebView):
2027         (WTR::PlatformWebView::viewSupportsOptions):
2028         * WebKitTestRunner/ios/TestControllerIOS.mm:
2029         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2030         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2031         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2032         (WTR::PlatformWebView::PlatformWebView):
2033         (WTR::PlatformWebView::viewSupportsOptions):
2034         * WebKitTestRunner/mac/TestControllerMac.mm:
2035         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2036         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2037
2038 2015-09-11  Michael Saboff  <msaboff@apple.com>
2039
2040         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2041         https://bugs.webkit.org/show_bug.cgi?id=149083
2042
2043         Reviewed by Alexey Proskuryakov.
2044
2045         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2046
2047         * DumpRenderTree/mac/LayoutTestHelper.m:
2048         (colorProfileURLForDisplay):
2049
2050 2015-09-11  Saam barati  <sbarati@apple.com>
2051
2052         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2053         https://bugs.webkit.org/show_bug.cgi?id=149058
2054
2055         Reviewed by Geoffrey Garen.
2056
2057         * Scripts/run-jsc-stress-tests:
2058
2059 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2060
2061         Unreviewed, rolling out r189595.
2062         https://bugs.webkit.org/show_bug.cgi?id=149052
2063
2064         The tests still fail (Requested by ap on #webkit).
2065
2066         Reverted changeset:
2067
2068         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2069         error -1"
2070         https://bugs.webkit.org/show_bug.cgi?id=142929
2071         http://trac.webkit.org/changeset/189595
2072
2073 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2074
2075         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2076         https://bugs.webkit.org/show_bug.cgi?id=142929
2077
2078         Reviewed by Brent Fulgham.
2079
2080         Silence the logging. We'll track fixing the root cause in Radar.
2081
2082         * Scripts/webkitpy/port/mac.py:
2083         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2084
2085         * Scripts/webkitpy/port/win.py:
2086         (WinPort.logging_patterns_to_strip): Added.
2087
2088 2015-09-09  Andy Estes  <aestes@apple.com>
2089
2090         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2091         https://bugs.webkit.org/show_bug.cgi?id=149022
2092
2093         Reviewed by Daniel Bates.
2094
2095         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2096         did not account for this.
2097
2098         * Scripts/webkitpy/xcode/simulator.py:
2099         (Simulator): Optionally matched a revision at the end of a runtime version number.
2100         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2101
2102 2015-09-09  Andy Estes  <aestes@apple.com>
2103
2104         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2105         https://bugs.webkit.org/show_bug.cgi?id=149029
2106         <rdar://problem/22432624>
2107
2108         Reviewed by Daniel Bates.
2109
2110         * Scripts/webkitpy/xcode/simulator.py:
2111         (Simulator): Taught to parse tvOS runtimes.
2112         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2113
2114 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Fix bit rot on bot watcher's dashboard page
2117         https://bugs.webkit.org/show_bug.cgi?id=149012
2118
2119         Reviewed by Tim Horton.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2122         The code path used by the metrics page was trying to add properties to an undefined.
2123
2124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2125         Silence an expection that would occur when the step has no logs. This should never
2126         happen, but it did (perhaps buildbot was misconfigured for a while).
2127
2128 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2129
2130         Update LayoutTestRelay xcconfig file.
2131
2132         Rubber-stamped by Dan Bernstein.
2133
2134         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2135
2136 2015-09-09  Saam barati  <sbarati@apple.com>
2137
2138         DFG should have a debugging option that runs a phase that flushes all locals
2139         https://bugs.webkit.org/show_bug.cgi?id=148916
2140
2141         Reviewed by Filip Pizlo.
2142
2143         * Scripts/run-jsc-stress-tests:
2144
2145 2015-09-09  Commit Queue  <commit-queue@webkit.org>
2146
2147         Unreviewed, rolling out r189530 and r189534.
2148         https://bugs.webkit.org/show_bug.cgi?id=148996
2149
2150         Caused assertion failures on Yosemite (Requested by litherum
2151         on #webkit).
2152
2153         Reverted changesets:
2154
2155         "[WKTR] Allow changing the WKContextConfiguration between
2156         successive tests"
2157         https://bugs.webkit.org/show_bug.cgi?id=148833
2158         http://trac.webkit.org/changeset/189530
2159
2160         "[Cocoa] Fix the tests after r189530"
2161         http://trac.webkit.org/changeset/189534
2162
2163 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2164
2165         [Cocoa] Fix the tests after r189530
2166
2167         Unreviewed.
2168
2169         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2170         (WTR::initializeWebViewConfiguration):
2171
2172 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2173
2174         [WKTR] Allow changing the WKContextConfiguration between successive tests
2175         https://bugs.webkit.org/show_bug.cgi?id=148833
2176
2177         Reviewed by Tim Horton.
2178
2179         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2180         However, there are certain tests which require specifying options in this object. This patch makes
2181         our existing code for recreating the test runner web view also recreate the WKContext.
2182
2183         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2184         class.
2185
2186         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2187         * WebKitTestRunner/PlatformWebView.h:
2188         (WTR::PlatformWebView::options):
2189         * WebKitTestRunner/TestController.cpp:
2190         (WTR::TestController::initialize):
2191         (WTR::TestController::generateContextConfiguration):
2192         (WTR::TestController::generatePageConfiguration):
2193         (WTR::TestController::createWebViewWithOptions):
2194         (WTR::TestController::ensureViewSupportsOptionsForTest):
2195         (WTR::updateContextConfigurationOptionsFromTestHeader):
2196         (WTR::TestController::contextConfigurationOptionsForTest):
2197         (WTR::TestController::platformCreateWebView):
2198         (WTR::TestController::platformCreateOtherPage):
2199         (WTR::updateViewOptionsFromTestHeader): Deleted.
2200         (WTR::TestController::viewOptionsForTest): Deleted.
2201         * WebKitTestRunner/TestController.h:
2202         (WTR::TestController::injectedBundlePath):
2203         (WTR::TestController::testPluginDirectory):
2204         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2205         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2206         (WTR::TestController::platformCreateWebView):
2207         (WTR::TestController::platformCreateOtherPage):
2208         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2209         (WTR::PlatformWebView::PlatformWebView):
2210         (WTR::PlatformWebView::viewSupportsOptions):
2211         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2212         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2213         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2214         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2215         (WTR::PlatformWebView::PlatformWebView):
2216         (WTR::PlatformWebView::viewSupportsOptions):
2217         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2218         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2219         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2220         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2221         (WTR::PlatformWebView::PlatformWebView):
2222         (WTR::PlatformWebView::viewSupportsOptions):
2223         * WebKitTestRunner/ios/TestControllerIOS.mm:
2224         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2225         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2226         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2227         (WTR::PlatformWebView::PlatformWebView):
2228         (WTR::PlatformWebView::viewSupportsOptions):
2229         * WebKitTestRunner/mac/TestControllerMac.mm:
2230         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2231         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2232
2233 2015-09-08  Daniel Bates  <dabates@apple.com>
2234
2235         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2236         https://bugs.webkit.org/show_bug.cgi?id=148980
2237
2238         Reviewed by Alexey Proskuryakov.
2239
2240         Add setting to enable/disable accelerated drawing so as to support testing
2241         this feature in MiniBrowser on Mac.
2242
2243         * MiniBrowser/mac/SettingsController.h:
2244         * MiniBrowser/mac/SettingsController.m:
2245         (-[SettingsController _populateMenu]): Add menu item.
2246         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2247         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2248         (-[SettingsController acceleratedDrawingEnabled]): Added.
2249         * MiniBrowser/mac/WK1BrowserWindowController.m:
2250         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2251         * MiniBrowser/mac/WK2BrowserWindowController.m:
2252         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2253
2254 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2255
2256         Unreviewed. Added myself as a commiter in contributors.json.
2257
2258         * Scripts/webkitpy/common/config/contributors.json:
2259
2260 2015-09-08  Keith Miller  <keith_miller@apple.com>
2261
2262         Unreviewed, added myself to the list of contributors.
2263
2264         * Scripts/webkitpy/common/config/contributors.json:
2265
2266 2015-09-08  Daniel Bates  <dabates@apple.com>
2267
2268         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2269         https://bugs.webkit.org/show_bug.cgi?id=148921
2270
2271         Reviewed by Alexey Proskuryakov.
2272
2273         The ring image is positioned above the platform icon in markup and we specify the CSS
2274         property z-index for the ring image so that it is painted on top of the platform icon
2275         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2276         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2277         property z-index to achieve a similar effect.
2278
2279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2280         (documentReady): Create the platform icon image element before the ring image such that
2281         the ring image is painted on top of the platform icon.
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2283         (table.queue-grid td.logo img.ring): Removed property z-index.
2284
2285 2015-09-08  Daniel Bates  <dabates@apple.com>
2286
2287         Dashboard: Remove duplicate gear icon data URLs
2288         https://bugs.webkit.org/show_bug.cgi?id=148920
2289
2290         Reviewed by Alexey Proskuryakov.
2291
2292         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2293         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2294         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2295         as a mask and make use of the CSS background-color to define the fill color for each of these three
2296         states.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2299         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
2300         (.settings:hover): Override CSS background-color for hover state.
2301         (.settings-visible .settings): Override CSS background-color for expanded state.
2302
2303 2015-09-07  Andy Estes  <aestes@apple.com>
2304
2305         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2306         https://bugs.webkit.org/show_bug.cgi?id=148946
2307         <rdar://problem/22603981>
2308
2309         Reviewed by Dan Bernstein.
2310
2311         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2312         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2313
2314 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2315
2316         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2317         https://bugs.webkit.org/show_bug.cgi?id=148927
2318
2319         Reviewed by Csaba Osztrogonác.
2320
2321         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2322         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2323
2324         * WebKitTestRunner/TestController.cpp:
2325         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2326         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2327         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2328
2329 2015-09-07  Andy Estes  <aestes@apple.com>
2330
2331         Fix the Production build after r189455.
2332
2333         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2334         In-App Purchase template instead of the Aggregate template. Whoops.
2335
2336 2015-09-06  Andy Estes  <aestes@apple.com>
2337
2338         WebKit.xcworkspace should be be able to build iOS platforms
2339         https://bugs.webkit.org/show_bug.cgi?id=148881
2340
2341         Reviewed by Daniel Bates.
2342
2343         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2344         for all supported platforms.
2345
2346         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2347         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2348         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2349         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2350
2351 2015-09-06  Andy Estes  <aestes@apple.com>
2352
2353         WebKitTestRunner should build for iOS using the default target
2354         https://bugs.webkit.org/show_bug.cgi?id=148918
2355
2356         Reviewed by Daniel Bates.
2357
2358         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2359         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2360         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2361
2362         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2363         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2364         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2365         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2366         WebKitTestRunner is skipped when installing on iOS.
2367
2368         The target dependency graph now looks like this:
2369
2370             All
2371                 WebKitTestRunnerApp
2372                     WebKitTestRunner (Library)
2373                         WebKitTestRunnerInjectedBundle
2374                             Derived Sources
2375                 WebKitTestRunner
2376                     WebKitTestRunner (Library)
2377                         WebKitTestRunnerInjectedBundle
2378                             Derived Sources
2379
2380         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2381         * Scripts/build-webkittestrunner: Ditto.
2382         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2383         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2384         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2385         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2386         excluded iOS-only files, and skipped installing on iOS.
2387         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2388         excluded Mac-only files, and skipped installing on Mac.
2389         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2390         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2391         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2392         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2393         new configuration files.
2394
2395 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
2396
2397         Web Inspector: Improve prepare-ChangeLog for multiple cases
2398         https://bugs.webkit.org/show_bug.cgi?id=148875
2399
2400         Reviewed by Timothy Hatcher.
2401
2402         * Scripts/prepare-ChangeLog:
2403         (get_function_line_ranges_for_javascript):
2404         - We were ignoring everything inside of an anonymous function expression,
2405           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2406           Better handle this by inserting a few tweaks.
2407         - Allow method syntax outside of classes as long as they are at the global level.
2408         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2409
2410         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2411         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2412         (Foo.prototype.method1):
2413         (Foo.prototype.method2):
2414         (Foo.prototype.method3.innerFunction):
2415         (Foo.prototype.method3):
2416         (insideGlobalAnonymousFunctionExpression):
2417         (foo.insideGlobalFunctionExpression):
2418         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2419         (IssueWithMapGetAndSet.prototype.method1):
2420         (IssueWithMapGetAndSet.prototype.method2):
2421         (IssueWithMapGetAndSet.prototype.method3):
2422         (IssueWithMapGetAndSet):
2423
2424 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2425
2426         [ES6] Enable ES6 Module in JSC shell by default
2427         https://bugs.webkit.org/show_bug.cgi?id=148689
2428
2429         Reviewed by Geoffrey Garen.
2430
2431         * Scripts/run-javascriptcore-tests:
2432         (runJSCStressTests):
2433         * Scripts/run-jsc-stress-tests:
2434
2435 2015-09-04  Basile Clement  <basile_clement@apple.com>
2436
2437         Unreviewed, change my email address.
2438
2439         * Scripts/webkitpy/common/config/contributors.json:
2440
2441 2015-09-04  Beth Dakin  <bdakin@apple.com>
2442
2443         Should have a test to make sure links don't navigate after a cancelled force 
2444         click
2445         https://bugs.webkit.org/show_bug.cgi?id=148846
2446
2447         Reviewed by Tim Horton.
2448
2449         New EventSender function for a started then cancelled force click.
2450         * WebKitTestRunner/EventSenderProxy.h:
2451         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2452         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2453         (WTR::EventSendingController::mouseForceClick):
2454         (WTR::EventSendingController::startAndCancelMouseForceClick):
2455         (WTR::EventSendingController::mouseForceDown):
2456         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2457         * WebKitTestRunner/TestController.cpp:
2458         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2459         * WebKitTestRunner/mac/EventSenderProxy.mm:
2460         (WTR::EventSenderProxy::mouseForceClick):
2461         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2462         (WTR::EventSenderProxy::mouseForceDown):
2463         (WTR::EventSenderProxy::mouseMoveTo):
2464
2465 2015-09-04  Tim Horton  <timothy_horton@apple.com>
2466
2467         Add a test for r179736 (programmatic navigation during swipe causing a crash)
2468         https://bugs.webkit.org/show_bug.cgi?id=148830
2469
2470         Reviewed by Beth Dakin.
2471
2472         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2473         (WTR::InjectedBundle::beginTesting):
2474         Make sure that TestRunner callbacks don't leak between tests!
2475
2476 2015-09-04  Anders Carlsson  <andersca@apple.com>
2477
2478         It should be possible to pass relative HTTP test paths to DumpRenderTree
2479         https://bugs.webkit.org/show_bug.cgi?id=148825
2480         <rdar://problem/22583866>
2481
2482         Reviewed by Tim Horton.
2483
2484         Convert the path to an absolute path if needed.
2485
2486         * DumpRenderTree/mac/DumpRenderTree.mm:
2487         (computeTestURL):
2488
2489 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2490
2491         Fix Swift unit tests for prepare-ChangeLog.
2492         https://bugs.webkit.org/show_bug.cgi?id=148817
2493
2494         Reviewed by Alexey Proskuryakov.
2495
2496         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2497         Swift unit tests for prepare-ChangeLog.
2498
2499 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2500
2501         Modifications to the webkit-nightly logic.
2502         
2503         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2504         (updateAlertPanel):
2505         * WebKitLauncher/main.m:
2506         (displayErrorAndQuit):
2507
2508 2015-09-04  Beth Dakin  <bdakin@apple.com>
2509
2510         Speculative build fix.
2511
2512         * WebKitTestRunner/mac/EventSenderProxy.mm:
2513
2514 2015-09-04  Brian Burg  <bburg@apple.com>
2515
2516         Web Inspector: InspectorController should support multiple frontend channels
2517         https://bugs.webkit.org/show_bug.cgi?id=148538
2518
2519         Reviewed by Joseph Pecoraro.
2520
2521         InspectorClients must explicitly disconnect their frontend channel(s) from the
2522         inspected page's InspectorController.
2523
2524         To make this possible, DumpRenderTree should not destroy non-primary views until
2525         it has tried to close any abandoned Web Inspector instances. Performing teardown
2526         in the reverse order prevents disconnection of the frontend channel because that
2527         prematurely destroys the inspector frontend client.
2528
2529         * DumpRenderTree/mac/DumpRenderTree.mm:
2530         (runTest):
2531         * DumpRenderTree/win/DumpRenderTree.cpp:
2532         (runTest):
2533
2534 2015-09-04  Beth Dakin  <bdakin@apple.com>
2535
2536         Need to be able to test default behaviors on force click
2537         https://bugs.webkit.org/show_bug.cgi?id=148758
2538
2539         Reviewed by Tim Horton.
2540
2541         This patch adds a new eventSender method to do a full, completed force click, 
2542         and it re-works all of the existing force methods to dispatch their events in 
2543         such a way that they will trigger the NSImmediateAction gesture recognizer. 
2544         To do this, first we need to send the events to the app rather than straight 
2545         to the view, and also needed to tweak some state and send the events in a 
2546         delayed fashion.
2547
2548         New public function mouseForceClick() and private helper functions to make 
2549         NSEvents.
2550         * WebKitTestRunner/EventSenderProxy.h:
2551
2552         New public function mouseForceClick().
2553         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2554         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2555         (WTR::EventSendingController::mouseMoveTo):
2556         (WTR::EventSendingController::mouseForceClick):
2557         (WTR::EventSendingController::mouseForceDown):
2558         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2559         * WebKitTestRunner/TestController.cpp:
2560         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2561
2562         initPressureEventAtLocation needs to take a stageTransition and a window.
2563         * WebKitTestRunner/mac/EventSenderProxy.mm:
2564         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2565         (-[EventSenderSyntheticEvent stageTransition]):
2566         (-[EventSenderSyntheticEvent timestamp]):
2567         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2568         (-[EventSenderSyntheticEvent window]):
2569
2570         In order to enter the gesture recognizer, we need to start with a mouse down 
2571         that has a NSEventMaskPressure modifier.
2572         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2573
2574         This ensures that the events queue properly for the force monitor in AppKit.
2575         (WTR::spinRunLoopForForce):
2576
2577          We need to start the pressure change events with a began.
2578         (WTR::EventSenderProxy::beginPressureEvent):
2579
2580         These functions can be used to create the NSEvent for a pressure change every 
2581         time we need one.
2582         (WTR::EventSenderProxy::pressureChangeEvent):
2583
2584         Send the right series of events to emulate a full, completed force click.
2585         (WTR::EventSenderProxy::mouseForceClick):
2586
2587         Use all of the new things for these existing functions.
2588         (WTR::EventSenderProxy::mouseForceDown):
2589         (WTR::EventSenderProxy::mouseForceUp):
2590         (WTR::EventSenderProxy::mouseForceChanged):
2591
2592         Set NSFakeForceTouchDevice to YES.
2593         * WebKitTestRunner/mac/main.mm:
2594         (setDefaultsToConsistentValuesForTesting):
2595
2596 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2597
2598         prepare-ChangeLog needs to know how to parse Swift files.
2599         https://bugs.webkit.org/show_bug.cgi?id=148784
2600         <rdar://problem/22510062>
2601
2602         Reviewed by Darin Adler.
2603
2604         * Scripts/prepare-ChangeLog:
2605         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2606         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2607         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2608         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2609         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2610         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2611         (freeFunction): Ditto.
2612         (MyClass.function): Ditto.
2613         (MyClass.functionWithArgument(_:)): Ditto.
2614         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2615         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2616         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2617         (MyClass.classFunction): Ditto.
2618         (MyClass.readWriteComputedVariable): Ditto.
2619         (MyClass.readOnlyComputedVariable): Ditto.
2620
2621 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2622
2623         Import css/css-color-3
2624         https://bugs.webkit.org/show_bug.cgi?id=148803
2625
2626         Reviewed by Chris Dumez.
2627
2628         Fixed a bug that the imported reference files used the same extention as tests.
2629         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2630
2631         * Scripts/webkitpy/w3c/test_importer.py:
2632         (TestImporter.find_importable_tests):
2633
2634 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2635
2636         Unreviewed, rolling out r189338.
2637         https://bugs.webkit.org/show_bug.cgi?id=148785
2638
2639         Caused tons of crashes (Requested by cdumez on #webkit).
2640
2641         Reverted changeset:
2642
2643         "Web Inspector: InspectorController should support multiple
2644         frontend channels"
2645         https://bugs.webkit.org/show_bug.cgi?id=148538
2646         http://trac.webkit.org/changeset/189338
2647
2648 2015-09-03  Brian Burg  <bburg@apple.com>
2649
2650         Web Inspector: InspectorController should support multiple frontend channels
2651         https://bugs.webkit.org/show_bug.cgi?id=148538
2652
2653         Reviewed by Joseph Pecoraro.
2654
2655         InspectorClients must explicitly disconnect their frontend channel(s) from the
2656         inspected page's InspectorController.
2657
2658         To make this possible, DumpRenderTree should not destroy non-primary views until
2659         it has tried to close any abandoned Web Inspector instances. Performing teardown
2660         in the reverse order prevents disconnection of the frontend channel because that
2661         prematurely destroys the inspector frontend client.
2662
2663         * DumpRenderTree/mac/DumpRenderTree.mm:
2664         (runTest):
2665         * DumpRenderTree/win/DumpRenderTree.cpp:
2666         (runTest):
2667
2668 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2669
2670         Update WebKit nightly icon to be more like Safari
2671         https://bugs.webkit.org/show_bug.cgi?id=148768
2672
2673         Reviewed by Joseph Pecoraro.
2674
2675         * WebKitLauncher/webkit.icns:
2676
2677 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2678
2679         JavaScriptCore should have some ES6 conformance tests
2680         https://bugs.webkit.org/show_bug.cgi?id=148771
2681
2682         Reviewed by Chris Dumez.
2683
2684         * Scripts/run-javascriptcore-tests:
2685         (runJSCStressTests): Added es6 as a test suite.
2686
2687         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2688
2689         Some of these tests currently fail, so I also added a way to expect
2690         failure for now. We'll migrate failing tests to expected passes as we
2691         fix them.
2692
2693 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2694
2695         Add a test for swipe-start hysteresis
2696         https://bugs.webkit.org/show_bug.cgi?id=148756
2697
2698         Reviewed by Anders Carlsson.
2699
2700         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2701         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2702         (WTR::cacheTestRunnerCallback):
2703         (WTR::TestRunner::clearTestRunnerCallbacks):
2704         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2705         Make sure that we log if a client tries to install a callback twice
2706         (since we use .add, the second call would not work).
2707
2708         Also, add clearTestRunnerCallbacks so tests can swap out installed
2709         callbacks.
2710
2711 2015-09-03  Anders Carlsson  <andersca@apple.com>
2712
2713         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2714         https://bugs.webkit.org/show_bug.cgi?id=148746
2715         rdar://problem/22568073
2716
2717         Reviewed by Tim Horton.
2718
2719         * DumpRenderTree/mac/DumpRenderTree.mm:
2720         (computeTestURL):
2721         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
2722
2723         (runTest):
2724         Call computeTestURL.
2725
2726         (testPathFromURL):
2727         Get rid of this; computeTestURL does this for us now.
2728
2729         * Scripts/webkitpy/port/driver.py:
2730         (Driver._command_from_driver_input):
2731         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2732
2733 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2734
2735         Swipe tests fail on Mavericks
2736         https://bugs.webkit.org/show_bug.cgi?id=148752
2737
2738         Reviewed by Beth Dakin.
2739
2740         * WebKitTestRunner/mac/EventSenderProxy.mm:
2741
2742 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2743
2744         Fix the 32-bit build
2745
2746         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2747         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2748
2749 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2750
2751         Remove some logging that wasn't meant to be in the tree
2752
2753         * WebKitTestRunner/mac/EventSenderProxy.mm:
2754         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2755
2756 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2757
2758         [Mac] Add support for testing swipes
2759         https://bugs.webkit.org/show_bug.cgi?id=148700
2760
2761         Reviewed by Beth Dakin.
2762
2763         * WebKitTestRunner/EventSenderProxy.h:
2764         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2765         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2766         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2767         (WTR::cgEventPhaseFromString):
2768         (WTR::cgEventMomentumPhaseFromString):
2769         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2770         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2771         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2772         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2773         (WTR::InjectedBundle::didReceiveMessageToPage):
2774         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2775         (WTR::TestRunner::installDidBeginSwipeCallback):
2776         (WTR::TestRunner::installWillEndSwipeCallback):
2777         (WTR::TestRunner::installDidEndSwipeCallback):
2778         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2779         (WTR::TestRunner::callDidBeginSwipeCallback):
2780         (WTR::TestRunner::callWillEndSwipeCallback):
2781         (WTR::TestRunner::callDidEndSwipeCallback):
2782         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2783         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2784         * WebKitTestRunner/TestController.cpp:
2785         (WTR::TestController::createOtherPage):
2786         (WTR::TestController::createWebViewWithOptions):
2787         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2788         (WTR::TestController::didBeginNavigationGesture):
2789         (WTR::TestController::willEndNavigationGesture):
2790         (WTR::TestController::didEndNavigationGesture):
2791         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2792         * WebKitTestRunner/TestController.h:
2793         * WebKitTestRunner/TestInvocation.cpp:
2794         (WTR::TestInvocation::didBeginSwipe):
2795         (WTR::TestInvocation::willEndSwipe):
2796         (WTR::TestInvocation::didEndSwipe):
2797         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2798         * WebKitTestRunner/TestInvocation.h:
2799         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2800         when the snapshot is removed.
2801
2802         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2803         mouseScrollBy function.
2804
2805         * WebKitTestRunner/mac/EventSenderProxy.mm:
2806         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2807         (-[EventSenderSyntheticEvent type]):
2808         (-[EventSenderSyntheticEvent subtype]):
2809         (-[EventSenderSyntheticEvent locationInWindow]):
2810         (-[EventSenderSyntheticEvent location]):
2811         (-[EventSenderSyntheticEvent momentumPhase]):
2812         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2813         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2814         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2815         more adjustable values.
2816
2817         (WTR::EventSenderProxy::mouseForceDown):
2818         (WTR::EventSenderProxy::mouseForceUp):
2819         (WTR::EventSenderProxy::mouseForceChanged):
2820         Adopt EventSenderSyntheticEvent.
2821
2822         (WTR::nsEventPhaseFromCGEventPhase):
2823         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2824         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2825
2826         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2827         (WTR::PlatformWebView::PlatformWebView):
2828         Enable swipe.
2829
2830 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2831
2832         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2833         https://bugs.webkit.org/show_bug.cgi?id=148723
2834
2835         Reviewed by Anders Carlsson.
2836
2837         * WebKitTestRunner/TestController.cpp:
2838         (WTR::testPath):
2839         (WTR::updateViewOptionsFromTestHeader):
2840         (WTR::TestController::viewOptionsForTest):
2841
2842 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2843
2844         Test commit.
2845
2846 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2847
2848         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2849         https://bugs.webkit.org/show_bug.cgi?id=148693
2850
2851         Reviewed by Anders Carlsson.
2852
2853         * WebKitTestRunner/TestController.cpp:
2854         (WTR::TestController::createOtherPage):
2855         (WTR::TestController::createWebViewWithOptions):
2856
2857 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2858
2859         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2860         https://bugs.webkit.org/show_bug.cgi?id=148529
2861
2862         Reviewed by Darin Adler.
2863
2864         When there are pending EventSender messages after a test finishes,
2865         they could be processed in the main loop started by the
2866         resetStateToConsistentValues(), but the old EventSender has been
2867         replaced by a new one at that point. The new Eventsender can crash
2868         when processing messages that were sent to the old one. To avoid
2869         this, we return early when receiving an EventSender message and
2870         the TestController state is not RunningTest.
2871
2872         * WebKitTestRunner/TestController.cpp:
2873         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2874         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2875
2876 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2877
2878         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2879         https://bugs.webkit.org/show_bug.cgi?id=148528
2880
2881         Reviewed by Darin Adler.
2882
2883         Before r188548 resetStateToConsistentValues() was called in
2884         TestController::run(), before tests are run, but now it's called
2885         for every test in TestInvocation::invoke(), after m_status has
2886         changed to RunningTest.
2887
2888         * WebKitTestRunner/TestController.cpp:
2889         (WTR::TestController::resetStateToConsistentValues): Use
2890         TemporaryChange to reset m_state ot its previous value after reset
2891         is done.
2892
2893 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2894
2895         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2896         that are marked as requiring corresponding tests.
2897         https://bugs.webkit.org/show_bug.cgi?id=148498
2898         <rdar://problem/21555314>
2899
2900         Reviewed by Dan Bernstein and David Kilzer.
2901
2902         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2903         simulate Git's attribute behevaior.
2904         (main): Added "requiresTests" array to contain files that require tests.
2905         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2906         section in ChangeLog.
2907         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2908         however, we check if the file or any containing folder has the given property set to "1" and
2909         return 1 if so; return 0 otherwise.
2910         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2911         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2912
2913 2015-08-26  Andy Estes  <aestes@apple.com>
2914
2915         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2916         https://bugs.webkit.org/show_bug.cgi?id=148506
2917
2918         Reviewed by Brady Eidson.
2919
2920         Added download API tests covering every decision and decision point.
2921         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2922
2923         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2924         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2925         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2926         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2927         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2928         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2929         decision and decision point as a bundle parameter.
2930         (+[MockContentFilterEnabler supportsSecureCoding]):
2931         (-[MockContentFilterEnabler copyWithZone:]):
2932         (-[MockContentFilterEnabler initWithCoder:]):
2933         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2934         (-[MockContentFilterEnabler encodeWithCoder:]):
2935         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2936         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2937         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2938         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2939         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2940         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2941         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2942         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2943         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2944         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2945         (+[MockContentFilterEnabler supportsSecureCoding]):
2946         (-[MockContentFilterEnabler copyWithZone:]):
2947         (-[MockContentFilterEnabler initWithCoder:]):
2948         (-[MockContentFilterEnabler dealloc]):
2949         (-[MockContentFilterEnabler encodeWithCoder:]):
2950         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2951         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2952         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2953         (+[ServerRedirectPlugIn initialize]): Deleted.
2954         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2955         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2956         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2957         (TEST): Deleted.
2958
2959 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2960
2961         Skip slow lock tests on Windows/debug
2962         https://bugs.webkit.org/show_bug.cgi?id=148643
2963
2964         Reviewed by Alexey Proskuryakov.
2965
2966         The lock tests simulate a critical section by doing some floating point math, and then either
2967         make those critical sections very long or invoke them many times. This appears to be
2968         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2969         that kind of computation slow.
2970
2971         These tests are almost as useful in release as they are in debug, so it's probably better to
2972         just skip the in debug on platforms where this causes timeouts.
2973
2974         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2975         (TestWebKitAPI::runLockTest):
2976         (TestWebKitAPI::skipSlow):
2977         (TestWebKitAPI::TEST):
2978
2979 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2980
2981         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2982         https://bugs.webkit.org/show_bug.cgi?id=125720
2983
2984         Reviewed by Daniel Bates.
2985
2986         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2987
2988         * DumpRenderTree/AccessibilityUIElement.cpp:
2989         (pressCallback):
2990         (scrollToMakeVisibleWithSubFocusCallback):
2991         (scrollToGlobalPointCallback):
2992         (scrollToMakeVisibleCallback):
2993         (AccessibilityUIElement::getJSClass):
2994         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2995         (AccessibilityUIElement::scrollToMakeVisible):
2996         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2997         (AccessibilityUIElement::scrollToGlobalPoint):
2998         (AccessibilityUIElement::selectedTextRange):
2999         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3000         (AccessibilityUIElement::AccessibilityUIElement):
3001         (AccessibilityUIElement::mathPrescriptsDescription):
3002         (AccessibilityUIElement::scrollToMakeVisible):
3003         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3004         (AccessibilityUIElement::scrollToGlobalPoint):
3005         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3006         (WTR::AccessibilityUIElement::isTextMarkerValid):
3007         (WTR::AccessibilityUIElement::textMarkerForIndex):
3008         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3009         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3010         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3011         (WTR::AccessibilityUIElement::supportedActions):
3012         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3013         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3014         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3015         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3016         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3017         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3018         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3019         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3020         (WTR::AccessibilityUIElement::selectedTextRange):
3021         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3022         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3023         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3024         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3025         (WTR::AccessibilityUIElement::selectedTextRange):
3026
3027 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3028
3029         Add a mysteriously nonproblematic missing comma.
3030
3031         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3032         (TestExpectationParser._collect_matching_tests):
3033         (TestExpectationParser):
3034
3035 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3036
3037         Remove an old temporary script that has served its purpose
3038
3039         * Scripts/convert-test-expectations: Removed.
3040
3041 2015-08-28  Jer Noble  <jer.noble@apple.com>
3042
3043         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3044         https://bugs.webkit.org/show_bug.cgi?id=148579
3045
3046         Reviewed by Anders Carlsson.
3047
3048         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3049
3050         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3051         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3052
3053         * DumpRenderTree/mac/DumpRenderTree.mm:
3054         (resetWebPreferencesToConsistentValues):
3055         (resetWebViewToConsistentStateBeforeTesting): 
3056         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3057         (WTR::initializeWebViewConfiguration):
3058
3059 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3060
3061         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3062         https://bugs.webkit.org/show_bug.cgi?id=148592
3063
3064         Reviewed by Tim Horton.
3065
3066         * Scripts/webkitpy/port/base.py:
3067         (Port.to.setup_environ_for_server):
3068         (Port.to):
3069         (Port.to._append_value_colon_separated):
3070         (Port.to.show_results_html_file):
3071         * Scripts/webkitpy/port/ios.py:
3072         (IOSSimulatorPort.setup_environ_for_server):
3073         * Scripts/webkitpy/port/mac.py:
3074         (MacPort.setup_environ_for_server):
3075
3076 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
3077
3078         LICM should be sound even if the CFG has changed
3079         https://bugs.webkit.org/show_bug.cgi?id=148259
3080
3081         Reviewed by Benjamin Poulain.
3082
3083         Add a utility for creating tests that set some uncommon option.
3084
3085         * Scripts/run-jsc-stress-tests:
3086
3087 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
3088
3089         [Win] Unreviewed EWS correction.
3090
3091         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
3092
3093 2015-08-28  Jer Noble  <jer.noble@apple.com>
3094
3095         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
3096         https://bugs.webkit.org/show_bug.cgi?id=147512
3097
3098         Reviewed by Anders Carlsson.
3099
3100         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
3101         to a consistent (true) value.
3102
3103         * DumpRenderTree/mac/DumpRenderTree.mm:
3104         (setDefaultsToConsistentValuesForTesting):
3105         * WebKitTestRunner/TestController.cpp:
3106         (WTR::TestController::resetPreferencesToConsistentValues):
3107
3108 2015-08-28  Tim Horton  <timothy_horton@apple.com>
3109
3110         Add navigation gesture callbacks to WKPageNavigationClient
3111         https://bugs.webkit.org/show_bug.cgi?id=148568
3112         <rdar://problem/22371346>
3113
3114         Reviewed by Anders Carlsson.
3115
3116         * WebKitTestRunner/TestController.cpp:
3117         (WTR::TestController::createOtherPage):
3118         (WTR::TestController::createWebViewWithOptions):
3119         Add some zeroes.
3120
3121 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3122
3123         [Mac] kill-old-processes should kill more processes
3124         https://bugs.webkit.org/show_bug.cgi?id=148577
3125
3126         Reviewed by Tim Horton.
3127
3128         * BuildSlaveSupport/kill-old-processes:
3129
3130 2015-08-28  Jason Marcell  <jmarcell@apple.com>
3131
3132         The status message for combined builder queues should say "all builds succeeded" if everything
3133         built correctly.
3134         https://bugs.webkit.org/show_bug.cgi?id=148535
3135
3136         Reviewed by David Kilzer and Alexey Proskuryakov.
3137
3138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3139         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
3140         say "all builds succeeded" if everything built correctly.
3141
3142 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3143
3144         [GTK] Simplify the internal API to create a WebView
3145         https://bugs.webkit.org/show_bug.cgi?id=148570
3146
3147         Reviewed by Žan Doberšek.
3148
3149         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
3150         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3151         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
3152         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
3153         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
3154         passing the received PageConfiguration.
3155         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3156         (WTR::PlatformWebView::PlatformWebView): Create the WebView
3157         passing the received PageConfiguration.
3158
3159 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
3160
3161         iOS Simulator API tests fails as Simulator is not running
3162         https://bugs.webkit.org/show_bug.cgi?id=148501
3163         rdar://problem/22447525
3164
3165         Reviewed by Daniel Bates.
3166
3167         This change is a workaround for <rdar://problem/22388812>.
3168
3169          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
3170          and quit it on program termination when running tests on the iOS port.
3171          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
3172          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
3173
3174 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3175
3176         Make DLLLauncherMain executables dependent on dll
3177         https://bugs.webkit.org/show_bug.cgi?id=148548
3178
3179         Reviewed by Brent Fulgham.
3180
3181         * DumpRenderTree/CMakeLists.txt:
3182         * DumpRenderTree/PlatformWin.cmake:
3183         * MiniBrowser/win/CMakeLists.txt:
3184         * TestWebKitAPI/CMakeLists.txt:
3185         * TestWebKitAPI/PlatformWin.cmake:
3186
3187 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3188
3189         Remove Mac slaves 188/189 after being replaced with 400/401.
3190         
3191         Unreviewed.
3192         
3193         * BuildSlaveSupport/build.webkit.org-config/config.json:
3194
3195 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3196
3197         Add two bots to the Mac Yosemite queue.
3198         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
3199         
3200         Unreviewed.
3201         
3202         * BuildSlaveSupport/build.webkit.org-config/config.json:
3203
3204 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3205
3206         [Win CMake] Fix incremental build after r188673
3207         https://bugs.webkit.org/show_bug.cgi?id=148539
3208
3209         Reviewed by Brent Fulgham.
3210
3211         * TestWebKitAPI/PlatformWin.cmake:
3212         Copy forwarding headers from WebCore before building in case that was not yet done.
3213         It used to be done when running CMake, but now it's a build step.
3214
3215 2015-08-27  Nan Wang  <n_wang@apple.com>
3216
3217         AX: Fix accessibility/select-element-at-index.html test
3218         https://bugs.webkit.org/show_bug.cgi?id=148516
3219
3220         Reviewed by Chris Fleizach.
3221
3222         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
3223
3224         * DumpRenderTree/AccessibilityUIElement.cpp:
3225         (setSelectedChildCallback):
3226         (setSelectedChildAtIndexCallback):
3227         (removeSelectionAtIndexCallback):
3228         (elementAtPointCallback):
3229         (sentenceAtOffsetCallback):
3230         (stringForSelectionCallback):
3231         (AccessibilityUIElement::getJSClass):
3232         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3233         (AccessibilityUIElement::setSelectedChild):
3234         (AccessibilityUIElement::setSelectedChildAtIndex):
3235         (AccessibilityUIElement::removeSelectionAtIndex):
3236         (AccessibilityUIElement::accessibilityValue):
3237         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3238         (WTR::AccessibilityUIElement::wordAtOffset):
3239         (WTR::AccessibilityUIElement::lineAtOffset):
3240         (WTR::AccessibilityUIElement::sentenceAtOffset):
3241         (WTR::AccessibilityUIElement::isSelectable):
3242         (WTR::AccessibilityUIElement::isMultiSelectable):
3243         (WTR::AccessibilityUIElement::setSelectedChild):
3244         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3245         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3246         (WTR::AccessibilityUIElement::selectedChildrenCount):
3247         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3248         (WTR::AccessibilityUIElement::isExpanded):
3249         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3250         (WTR::AccessibilityUIElement::setSelectedChild):
3251         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3252         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3253         (WTR::AccessibilityUIElement::accessibilityValue):
3254
3255 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3256
3257         Build fix after r188982
3258
3259         * MiniBrowser/win/CMakeLists.txt:
3260         The directory structure changed in the move.
3261
3262 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3263
3264         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
3265
3266         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
3267
3268         * gtk/install-dependencies:
3269
3270 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3271
3272         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
3273
3274         * Scripts/run-gtk-tests:
3275         (TestRunner):
3276
3277 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3278
3279         Fix GTK+ WTR crashes in initializeMainRunLoop()
3280
3281         Rubber-stamped by Žan Doberšek.
3282
3283         Initialize threading and main thread before
3284         RunLoop::initializeMainRunLoop(), since the GLib implementation of
3285         the RunLoop uses isMainThread() to decide whether to create a new
3286         GMainContext or use the default one. Also use RunLoop::run() and
3287         ::stop() instead of gtk_main/quit.
3288
3289         * WebKitTestRunner/TestController.cpp:
3290         (WTR::TestController::initialize):
3291         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3292         (WTR::TestController::notifyDone):
3293         (WTR::TestController::platformRunUntil):
3294
3295 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
3296
3297         Unreviewed, further shorten a test that times out because it's very long
3298         running.
3299
3300         I've locally run these tests on repeat for 24 hours and found no genuine
3301         failures, like deadlocks. So, the timeouts are probably because the test
3302         machine is slow and debug is slow. We should just run this test for fewer
3303         iterations.
3304
3305         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3306         (TestWebKitAPI::TEST):
3307
3308 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3309
3310         Unreviewed build fix attempt on EFL
3311
3312         * WebKitTestRunner/PlatformEfl.cmake:
3313
3314 2015-08-26  Alex Christensen  <achristensen@webkit.org>
3315
3316         Build fix after r188982
3317
3318         * MiniBrowser/win/CMakeLists.txt:
3319         Find .rc files in correct directory.
3320
3321 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3322
3323         [EFL] Bump cairo version to 1.14.2
3324         https://bugs.webkit.org/show_bug.cgi?id=148474
3325
3326         Reviewed by Csaba Osztrogonác.
3327
3328         * efl/jhbuild.modules:
3329
3330 2015-08-26  Andy Estes  <aestes@apple.com>
3331
3332         Crash when following a Google search link to Twitter with Limit Adult Content enabled
3333         https://bugs.webkit.org/show_bug.cgi?id=147651
3334
3335         Rubber-stamped by Brady Eidson.
3336
3337         Taught TestRunner how to decide the navigation policy after a delay.
3338
3339         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3340         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3341         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3342         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3343         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3344         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3345         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3346         * WebKitTestRunner/TestController.cpp:
3347         (WTR::TestController::initialize):
3348         (WTR::TestController::resetStateToConsistentValues):
3349         (WTR::TestController::decidePolicyForNavigationAction):
3350         * WebKitTestRunner/TestController.h:
3351         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3352         * WebKitTestRunner/TestInvocation.cpp:
3353         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3354
3355 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3356
3357         [Win] Rename 'WinLauncher' to 'MiniBrowser'
3358         https://bugs.webkit.org/show_bug.cgi?id=148485
3359
3360         Reviewed by Alex Christensen
3361
3362         Move the WinLauncher project and source files to a subdirectory
3363         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3364         source code and project files.
3365         
3366         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3367         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3368         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3369         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3370         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3371         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3372         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3373         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3374         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3375         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3376         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
3377         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
3378         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
3379         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
3380         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
3381         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
3382         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
3383         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
3384         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
3385         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
3386         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
3387         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
3388         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
3389         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
3390         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
3391         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
3392         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
3393         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
3394         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
3395         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
3396         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
3397         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
3398         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
3399         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
3400         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3401         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
3402         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
3403         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3404         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3405         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
3406         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
3407         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
3408         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
3409         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
3410         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
3411         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
3412         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
3413         * MiniBrowser/win: Copied from WinLauncher.
3414         * MiniBrowser/win/Common.cpp:
3415         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
3416         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
3417         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
3418         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
3419         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
3420         * MiniBrowser/win/PageLoadTestClient.cpp:
3421         * MiniBrowser/win/PageLoadTestClient.h:
3422         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3423         * MiniBrowser/win/ResourceLoadDelegate.h:
3424         * MiniBrowser/win/WinLauncher.cpp: Removed.
3425         * MiniBrowser/win/WinLauncher.h: Removed.
3426         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
3427         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3428         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3429         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3430         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3431         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3432         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3433         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3434         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3435         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3436         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3437         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3438         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3439         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3440         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3441         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3442         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3443         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3444         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3445         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3446         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3447         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3448         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3449         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3450         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
3451         * MiniBrowser/win/WinLauncherReplace.h: Removed.
3452         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
3453         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
3454         * MiniBrowser/win/WinMain.cpp:
3455         * WinLauncher: Removed.
3456         * WinLauncher/AccessibilityDelegate.cpp: Removed.
3457         * WinLauncher/AccessibilityDelegate.h: Removed.
3458         * WinLauncher/CMakeLists.txt: Removed.
3459         * WinLauncher/Common.cpp: Removed.
3460         * WinLauncher/DOMDefaultImpl.cpp: Removed.
3461         * WinLauncher/DOMDefaultImpl.h: Removed.
3462         * WinLauncher/PageLoadTestClient.cpp: Removed.
3463         * WinLauncher/PageLoadTestClient.h: Removed.
3464         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
3465         * WinLauncher/PrintWebUIDelegate.h: Removed.
3466         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
3467         * WinLauncher/ResourceLoadDelegate.h: Removed.
3468         * WinLauncher/WebDownloadDelegate.cpp: Removed.
3469         * WinLauncher/WebDownloadDelegate.h: Removed.
3470         * WinLauncher/WinLauncher.cpp: Removed.
3471         * WinLauncher/WinLauncher.h: Removed.
3472         * WinLauncher/WinLauncher.vcxproj: Removed.
3473         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3474         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3475         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3476         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3477         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3478         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3479         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3480         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3481         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3482         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3483         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3484         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3485         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3486         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3487         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3488         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3489         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3490         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3491         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3492         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3493         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3494         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3495         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3496         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
3497         * WinLauncher/WinLauncherReplace.h: Removed.
3498         * WinLauncher/WinLauncherWebHost.cpp: Removed.
3499         * WinLauncher/WinLauncherWebHost.h: Removed.
3500         * WinLauncher/WinMain.cpp: Removed.
3501         * WinLauncher/resource.h: Removed.
3502         * WinLauncher/stdafx.cpp: Removed.
3503         * WinLauncher/stdafx.h: Removed.
3504         * win/AssembleBuildLogs/AssembleLogs.cmd:
3505
3506 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3507
3508         [Win] Simplify menu handling code in WinLauncher
3509         https://bugs.webkit.org/show_bug.cgi?id=148461
3510
3511         Reviewed by Zalan Bujtas.
3512
3513         Revise 'ToggleMenuItem' to return a boolean value indicating if
3514         it handled the message. Revise WndProc to use this to decide if it
3515         should pass the message on to the default handler, rather than
3516         duplicating the logic in both places.
3517         
3518         * WinLauncher/Common.cpp:
3519         (ToggleMenuItem): Return true if the menu item message was handled.
3520         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3521         the message tothe default handler.
3522
3523 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3524
3525         Remove unused code after r188948
3526         https://bugs.webkit.org/show_bug.cgi?id=148467
3527
3528         Reviewed by Gyuyoung Kim.
3529
3530         * WebKitTestRunner/TestController.cpp:
3531         (WTR::TestController::platformPreferences): Deleted.
3532
3533 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3534
3535         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3536         https://bugs.webkit.org/show_bug.cgi?id=148377
3537
3538         Reviewed by Carlos Garcia Campos.
3539
3540         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3541         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3542         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3543         EFL and GTK at the moment.
3544
3545         * WebKitTestRunner/TestController.cpp:
3546         (WTR::TestController::platformWillRunTest):
3547         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3548         (WTR::TestController::platformPreferences):
3549         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3550         (WTR::TestController::platformPreferences):
3551
3552 2015-08-25  Nan Wang  <n_wang@apple.com>
3553
3554         AX: Enable accessibility/aria-controls.html test for mac
3555         https://bugs.webkit.org/show_bug.cgi?id=148458
3556
3557         Reviewed by Chris Fleizach.
3558
3559         Implemented ariaControlsElementAtIndex(unsigned index).
3560
3561         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3562         (AccessibilityUIElement::ariaControlsElementAtIndex):
3563         (AccessibilityUIElement::disclosedRowAtIndex):
3564         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3565         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3566
3567 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3568
3569         Remove python tests for PassRefPtr 
3570         https://bugs.webkit.org/show_bug.cgi?id=148463
3571
3572         Reviewed by Andy Estes.
3573
3574         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3575
3576         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3577         (PassPtrTest): Deleted.
3578         (PassPtrTest.assert_pass_ptr_check): Deleted.
3579         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3580         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3581         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3582         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3583         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3584         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3585
3586 2015-08-25  Andy Estes  <aestes@apple.com>
3587
3588         [iOS] run-webkit-tests fails if watchOS SDK is installed
3589         https://bugs.webkit.org/show_bug.cgi?id=148453
3590
3591         Reviewed by David Kilzer.
3592
3593         * Scripts/webkitpy/xcode/simulator.py:
3594         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3595         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3596
3597 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
3598
3599         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3600         https://bugs.webkit.org/show_bug.cgi?id=148197
3601         rdar://problem/22334382
3602
3603         Reviewed by Daniel Bates.
3604
3605         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3606         * Scripts/webkitpy/port/ios.py:
3607         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3608         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3609         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3610         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3611         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3612
3613 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3614
3615         Remove PassRefPtr style check rule
3616         https://bugs.webkit.org/show_bug.cgi?id=148432
3617
3618         Reviewed by Andreas Kling.
3619
3620         PassRefPtr is being removed. Thus style rule needs to be removed as well.
3621
3622         * Scripts/webkitpy/style/checkers/cpp.py:
3623         (_check_parameter_name_against_text): Deleted.
3624         (check_function_definition_and_pass_ptr): Deleted.
3625         (check_function_definition): Deleted.
3626         (check_pass_ptr_usage): Deleted.
3627         (process_line): Deleted.
3628         (CppChecker): Deleted.
3629
3630 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
3631
3632         [Win] Expose "Inverted Colors" option in WinLauncher
3633         https://bugs.webkit.org/show_bug.cgi?id=148451
3634
3635         Reviewed by Tim Horton.
3636
3637         Add the ability to toggle the "Inverted Colors" preference
3638         in WinLauncher.
3639         
3640         * WinLauncher/Common.cpp:
3641         (ToggleMenuItem): Toggle the feature when the menu item
3642         is selected.
3643         (WndProc): Recognize the new menu option.
3644         * WinLauncher/WinLauncher.cpp:
3645         (WinLauncher::setToDefaultPreferences): Launch with "Invert
3646         Colors" turned off.
3647         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3648         entry for "Invert Colors".
3649         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3650
3651 2015-08-25  Nan Wang  <n_wang@apple.com>
3652
3653         [Mac] accessibility/document-attributes.html fails
3654         https://bugs.webkit.org/show_bug.cgi?id=116636
3655
3656         Reviewed by Chris Fleizach.
3657
3658         Implemented documentURI() and documentEncoding().
3659
3660         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3661         (AccessibilityUIElement::documentEncoding):
3662         (AccessibilityUIElement::documentURI):
3663         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3664         (WTR::AccessibilityUIElement::documentEncoding):
3665         (WTR::AccessibilityUIElement::documentURI):
3666
3667 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
3668
3669         [Win] Unreviewed test gardening.
3670
3671         Fix another case where the logging string is constructed using the variable 'frame',
3672         but the method argument is not given a name. This causes the global 'frame' value to
3673         be used, producing incorrect output.
3674
3675         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3676         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3677         argument.
3678
3679 2015-08-24  Tim Horton  <timothy_horton@apple.com>
3680
3681         (Finally...) get rid of WKViewIOS
3682         https://bugs.webkit.org/show_bug.cgi?id=148404
3683
3684         Reviewed by Anders Carlsson.
3685
3686         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3687         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3688         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3689         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3690         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3691         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3692         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3693         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3694         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3695         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3696         Mark tests that use WKBrowsingContextController as Mac-only.
3697
3698         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3699         (WTR::AccessibilityController::addNotificationListener):
3700         * WebKitTestRunner/ios/mainIOS.mm:
3701         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3702         Import UIKit instead of depending on WKView.h to do so.
3703
3704 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3705
3706         Add support to dashboard for displaying Git SHA's as revisions.
3707         https://bugs.webkit.org/show_bug.cgi?id=148387
3708
3709         Reviewed by Daniel Bates.
3710
3711         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3712         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3714         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3716         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3717
3718 2015-08-24  Andy Estes  <aestes@apple.com>
3719
3720         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3721
3722         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3723
3724 2015-08-23  Andy Estes  <aestes@apple.com>
3725
3726         Addressed a missed piece of review feedback from r188851.
3727
3728         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3729
3730 2015-08-23  Andy Estes  <aestes@apple.com>
3731
3732         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3733         https://bugs.webkit.org/show_bug.cgi?id=147872
3734         rdar://problem/22044000
3735
3736         Reviewed by Dan Bernstein.
3737         
3738         Added an API test.
3739
3740         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3742         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3743         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3744         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3745         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3746         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3747         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3748         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3749         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3750         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3751
3752 2015-08-23  Andy Estes  <aestes@apple.com>
3753
3754         Fixed the 32-bit Mac build after r188844.
3755
3756         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3757         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3758
3759 2015-08-22  Andy Estes  <aestes@apple.com>
3760
3761         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3762         https://bugs.webkit.org/show_bug.cgi?id=148317
3763
3764         Reviewed by Dan Bernstein.
3765
3766         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3767         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3768         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3769         when creating WKWebViews.
3770
3771         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3772         added a new API test for bundle parameters.
3773
3774         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3775         named its executable TestWebKitAPI.bundle.
3776         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3778         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3779         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3780         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3781         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3782         bundle parameter and asked for an initial notification.
3783         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3784         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3785         mirror its value in the main frame's JSContext.
3786         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3787         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3788         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3789         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3790         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3791         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3792         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3793         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3794         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3795         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3796
3797 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3798
3799         URTBF after r188828.
3800
3801         * WebKitTestRunner/PlatformWebView.h:
3802
3803 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3804
3805         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3806         https://bugs.webkit.org/show_bug.cgi?id=148356
3807
3808         Reviewed by Darin Adler.
3809
3810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3811         (BuildbotCombinedQueueView.prototype.update):
3812
3813 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3814
3815         build.webkit.org/dashboard: Respect step's hidden flag
3816         https://bugs.webkit.org/show_bug.cgi?id=148357
3817
3818         Reviewed by Darin Adler.
3819
3820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3821         (BuildbotIteration.prototype._parseData):
3822
3823 2015-08-23  Nan Wang  <n_wang@apple.com>
3824
3825         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3826         https://bugs.webkit.org/show_bug.cgi?id=148328
3827
3828         Reviewed by Darin Adler.
3829
3830         We should only expose stringValue() when value attribute is set.
3831
3832         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3833         (AccessibilityUIElement::stringValue):
3834         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3835         (WTR::AccessibilityUIElement::stringValue):
3836
3837 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3838
3839         Remove style checking rule regarding OwnPtr and PassOwnPtr
3840         https://bugs.webkit.org/show_bug.cgi?id=148360
3841
3842         Reviewed by Darin Adler.
3843
3844         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3845         Removed it.
3846
3847         * Scripts/do-webcore-rename:
3848         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3849         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3850         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3851         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3852         (WebKitStyleTest.test_names): Deleted.
3853
3854 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3855
3856         WebKitTestRunner should use WKWebView on OS X and iOS
3857         https://bugs.webkit.org/show_bug.cgi?id=143743
3858         <rdar://problem/16947123>
3859
3860         Reviewed by Anders Carlsson.
3861         Patch by Enrica Casucci and myself.
3862
3863         * WebKitTestRunner/PlatformWebView.h:
3864         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3865         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3866         instead of WKContext and WKPageGroup.
3867
3868         Remove the unused, always-true windowSnapshotEnabled().
3869         While technically some platforms don't have window snapshotting,
3870         they just return null instead of implementing windowSnapshotEnabled().
3871
3872         * WebKitTestRunner/TestController.h:
3873         * WebKitTestRunner/TestController.cpp:
3874         (WTR::TestController::createOtherPage):
3875         (WTR::TestController::initialize):
3876         (WTR::TestController::createWebViewWithOptions):
3877         Delegate to the various platforms for creating PlatformWebView instances,
3878         for creating WKContexts, and for accessing WKPreferences,
3879         so that they can do special things (like, use WKWebView instead!).
3880
3881         (WTR::TestController::resetPreferencesToConsistentValues):
3882         Make explicit WebKitTestRunner's desired default for two preferences
3883         which have differing defaults between the antique and modern API,
3884         for consistency's sake.
3885
3886         (WTR::TestController::resetStateToConsistentValues):
3887         Add platformResetStateToConsistentValues.
3888
3889         * WebKitTestRunner/TestInvocation.cpp:
3890         (WTR::TestInvocation::dumpResults):
3891         Adjust to the aforementioned removal of windowSnapshotEnabled().
3892
3893         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3894         (WTR::TestController::platformResetStateToConsistentValues):
3895         (WTR::TestController::platformPreferences):
3896         (WTR::TestController::platformCreateWebView):
3897         (WTR::TestController::platformCreateOtherPage):
3898         (WTR::TestController::platformInitializeConfiguration):
3899         Implement the new platform functions for the Modern WebKit2 API,
3900         in a new TestControllerCocoa file that is shared between iOS and Mac.
3901         
3902         For platformMaybeCreateContext, use the trick that we know we can cast
3903         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3904         WKWebView's configuration.
3905
3906         Ditto for WKPreferencesRef and WKPreferences.
3907
3908         Remove user content filters on the WKWebView's userContentController.
3909
3910         * WebKitTestRunner/mac/TestControllerMac.mm:
3911         * WebKitTestRunner/ios/TestControllerIOS.mm:
3912         Move code into TestControllerCocoa.
3913
3914         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3915         (WTR::InjectedBundle::beginTesting):
3916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3917         (WTR::TestRunner::addUserScript):
3918         (WTR::TestRunner::addUserStyleSheet):
3919         Adopt WKBundlePage API for user scripts/sheets.
3920
3921         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3922         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3923         Make and keep a WKWebView instead of a WKView.
3924         
3925         * WebKitTestRunner/mac/EventSenderProxy.mm:
3926         (WTR::EventSenderProxy::mouseUp):
3927         (WTR::EventSenderProxy::mouseMoveTo):
3928         Reach inside the WKWebView to the WKView when dispatching events.
3929         This is fairly ugly and we should come up with a better solution.
3930         Also, fix some flipping and style errors.
3931
3932 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3933
3934         Unreviewed, attempt to fix GTK build after r188718
3935
3936         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3937         (WTR::PlatformWebView::PlatformWebView):
3938
3939 2015-08-21  Commit Queue  <commit-queue@webkit.org>
3940
3941         Unreviewed, rolling out r188807, r188813, and r188815.
3942         https://bugs.webkit.org/show_bug.cgi?id=148349
3943
3944         lots of 32-bit build problems, better to resolve separately
3945         and try again (Requested by thorton on #webkit).
3946
3947         Reverted changesets:
3948
3949         "WebKitTestRunner should use WKWebView on OS X and iOS"
3950         https://bugs.webkit.org/show_bug.cgi?id=143743
3951         http://trac.webkit.org/changeset/188807
3952
3953         "Stop building WebKitTestRunner for 32-bit platforms"
3954         https://bugs.webkit.org/show_bug.cgi?id=143743
3955         http://trac.webkit.org/changeset/188813
3956
3957         "Stop building WebKitTestRunner for 32-bit platforms"
3958         https://bugs.webkit.org/show_bug.cgi?id=143743
3959         http://trac.webkit.org/changeset/188815
3960
3961 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3962
3963         Stop building WebKitTestRunner for 32-bit platforms
3964         https://bugs.webkit.org/show_bug.cgi?id=143743
3965         <rdar://problem/16947123>
3966
3967         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3968         This is a restriction on the valid set, not the desired set.
3969
3970 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3971
3972         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
3973         to work with these new objects.
3974         https://bugs.webkit.org/show_bug.cgi?id=148188
3975
3976         Reviewed by Daniel Bates.
3977
3978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3979         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3981         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
3982         (repository, "branch name")-pair.
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
3984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3985         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3987         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
3988         objects which represent a (repository, "branch name")-pair.
3989         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3990         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3991         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
3992         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
3993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
3994         BuildbotQueue.branch to BuildbotQueue.branches.
3995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3996         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
3997
3998 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3999
4000         Stop building WebKitTestRunner for 32-bit platforms
4001         https://bugs.webkit.org/show_bug.cgi?id=143743
4002         <rdar://problem/16947123>
4003
4004         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4005         WKWebView is not available on 32-bit OS X.
4006
4007 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
4008
4009         [Win] Unreviewed test correction after r188709.
4010
4011         I removed a function argument that happened to be mirrored by a global
4012         value with the same name. This prevented a compile error, but testing
4013         showed that the wrong value was being used in the function.
4014
4015         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4016         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
4017         back
4018
4019 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
4020
4021         WebKitTestRunner should use WKWebView on OS X and iOS
4022         https://bugs.webkit.org/show_bug.cgi?id=143743
4023         <rdar://problem/16947123>
4024
4025         Reviewed by Anders Carlsson.
4026         Patch by Enrica Casucci and myself.
4027
4028         * WebKitTestRunner/PlatformWebView.h:
4029         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
4030         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
4031         instead of WKContext and WKPageGroup.
4032
4033         Remove the unused, always-true windowSnapshotEnabled().
4034         While technically some platforms don't have window snapshotting,
4035         they just return null instead of implementing windowSnapshotEnabled().
4036
4037         * WebKitTestRunner/TestController.h:
4038         * WebKitTestRunner/TestController.cpp:
4039         (WTR::TestController::createOtherPage):
4040         (WTR::TestController::initialize):
4041         (WTR::TestController::createWebViewWithOptions):
4042         Delegate to the various platforms for creating PlatformWebView instances,
4043         for creating WKContexts, and for accessing WKPreferences,
4044         so that they can do special things (like, use WKWebView instead!).
4045
4046         (WTR::TestController::resetPreferencesToConsistentValues):
4047         Make explicit WebKitTestRunner's desired default for two preferences
4048         which have differing defaults between the antique and modern API,
4049         for consistency's sake.
4050
4051         (WTR::TestController::resetStateToConsistentValues):
4052         Add platformResetStateToConsistentValues.
4053
4054         * WebKitTestRunner/TestInvocation.cpp:
4055         (WTR::TestInvocation::dumpResults):
4056         Adjust to the aforementioned removal of windowSnapshotEnabled().
4057
4058         * WebKitTestRunner/ios/TestControllerCocoa.mm:
4059         (WTR::TestController::platformResetStateToConsistentValues):
4060         (WTR::TestController::platformPreferences):
4061         (WTR::TestController::platformCreateWebView):
4062         (WTR::TestController::platformCreateOtherPage):
4063         (WTR::TestController::platformInitializeConfiguration):
4064         Implement the new platform functions for the Modern WebKit2 API,
4065         in a new TestControllerCocoa file that is shared between iOS and Mac.
4066         
4067         For platformMaybeCreateContext, use the trick that we know we can cast
4068         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
4069         WKWebView's configuration.
4070
4071         Ditto for WKPreferencesRef and WKPreferences.
4072
4073         Remove user content filters on the WKWebView's userContentController.
4074
4075         * WebKitTestRunner/mac/TestControllerMac.mm:
4076         * WebKitTestRunner/ios/TestControllerIOS.mm:
4077         Move code into TestControllerCocoa.
4078
4079         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4080         (WTR::InjectedBundle::beginTesting):
4081         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4082         (WTR::TestRunner::addUserScript):
4083         (WTR::TestRunner::addUserStyleSheet):
4084         Adopt WKBundlePage API for user scripts/sheets.
4085
4086         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4087         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4088         Make and keep a WKWebView instead of a WKView.
4089         
4090         * WebKitTestRunner/mac/EventSenderProxy.mm:
4091         (WTR::EventSenderProxy::mouseUp):
4092         (WTR::EventSenderProxy::mouseMoveTo):
4093         Reach inside the WKWebView to the WKView when dispatching events.
4094         This is fairly ugly and we should come up with a better solution.
4095         Also, fix some flipping and style errors.
4096
4097 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
4098
4099         Improve how UI events are dispatched by WebKitTestRunner
4100         https://bugs.webkit.org/show_bug.cgi?id=148326
4101
4102         Reviewed by Anders Carlsson.
4103
4104         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4105         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4106         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
4107         asynchronous (and really, it has always been for the most part).
4108
4109         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4110         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
4111         (WTR::EventSendingController::mouseUp): Ditto.
4112         (WTR::EventSendingController::mouseMoveTo): Ditto.
4113         (WTR::EventSendingController::mouseForceDown): Ditto.
4114         (WTR::EventSendingController::mouseForceUp): Ditto.
4115         (WTR::EventSendingController::mouseForceChanged): Ditto.
4116         (WTR::EventSendingController::leapForward): Ditto.
4117         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
4118         (WTR::EventSendingController::keyDown): Ditto.
4119         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
4120         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
4121         to be done in custom WebKit2 code for test wheel event handling.
4122         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
4123         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
4124         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
4125         (WTR::EventSendingController::addTouchPoint): Ditto.
4126         (WTR::EventSendingController::updateTouchPoint): Ditto.
4127         (WTR::EventSendingController::setTouchModifier): Ditto.
4128         (WTR::EventSendingController::setTouchPointRadius): Ditto.
4129         (WTR::EventSendingController::touchStart): Ditto.
4130         (WTR::EventSendingController::touchMove): Ditto.
4131         (WTR::EventSendingController::touchEnd): Ditto.
4132         (WTR::EventSendingController::touchCancel): Ditto.
4133         (WTR::EventSendingController::clearTouchPoints): Ditto.
4134         (WTR::EventSendingController::releaseTouchPoint): Ditto.
4135         (WTR::EventSendingController::cancelTouchPoint): Ditto.
4136
4137         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4138         (WTR::InjectedBundle::postSetWindowIsKey):
4139         (WTR::InjectedBundle::postSimulateWebNotificationClick):
4140         (WTR::InjectedBundle::isGeolocationProviderActive):
4141         (WTR::InjectedBundle::shouldProcessWorkQueue):
4142         Updated for WKBundlePagePostSynchronousMessage renaming.
4143
4144         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4145         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
4146
4147         * WebKitTestRunner/TestController.cpp:
4148         (WTR::TestController::initialize): Allow handling the new test style messages.
4149         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
4150         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
4151         (WTR::TestController::didReceiveMessageFromInjectedBundle):
4152         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
4153         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
4154
4155         * WebKitTestRunner/mac/EventSenderProxy.mm:
4156         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
4157         (WTR::EventSenderProxy::keyDown): Ditto.
4158         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
4159         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
4160
4161 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
4162
4163         Skip no-llint tests that fail due to running out of executable memory after r188969
4164         https://bugs.webkit.org/show_bug.cgi?id=148273
4165
4166         Reviewed by Michael Saboff.
4167
4168         * Scripts/run-jsc-stress-tests:
4169
4170 2015-08-21  Nan Wang  <n_wang@apple.com>
4171
4172         [Mac] accessibility/selection-states.html fails
4173         https://bugs.webkit.org/show_bug.cgi?id=116637
4174
4175         Reviewed by Chris Fleizach.