[iOS] run-webkit-tests should check that simctl can boot and shutdown simulator devic...
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-17  Daniel Bates  <dabates@apple.com>
2
3         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
4         https://bugs.webkit.org/show_bug.cgi?id=141718
5
6         Reviewed by Alex Christensen.
7
8         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
9
10         * Scripts/webkitpy/port/ios.py:
11         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
12         Log a error and return False if we are unable to boot the simulator device so that the caller can take
13         appropriate action, say exit(3) before running any layout tests.
14         * Scripts/webkitpy/xcode/simulator.py:
15         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
16         with the specified UDID.
17         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
18         with the specified UDID can successfully boot and shut down. We make at most two attempts to
19         boot and shut down the device, erasing the device between tries so as to restore the device
20         to a known good state.
21
22 2015-02-17  Daniel Bates  <dabates@apple.com>
23
24         run_webkit_tests.py should not know about iOS Simulator details
25         https://bugs.webkit.org/show_bug.cgi?id=141711
26
27         Reviewed by Alex Christensen.
28
29         Run_webkit_tests.py should only parse the iOS-specific command
30         line options --runtime and --device-type. Let the port-specific
31         logic in ios.py validate the parsed options and instantiate
32         internal data structures.
33
34         Currently run_webkit_tests.py parses the iOS-specific command
35         line options --runtime and --device-type, validates them, and
36         instantiates internal data structures from the parsed strings.
37         Instead the validation logic and instantiation of internal
38         data structures should be handled by the iOS port object.
39
40         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
41         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
42         and instantiate internal data structures for them.
43         * Scripts/webkitpy/port/driver.py:
44         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
45         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
46         respectively.
47         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
48         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
49         object from --runtime, if specified. Otherwise, instantiates a Runtime
50         object for the latest installed iphonesimulator SDK version.
51         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
52         object from --device-type, if specified. Otherwise, instantiates
53         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
54         machine, respectively.
55         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
56         runtime is available to use.
57         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
58         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
59         * Scripts/webkitpy/xcode/simulator.py:
60         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
61         with a runtime identifier for the specified iOS version.
62
63 2015-02-17  Dana Burkart  <dburkart@apple.com>
64
65         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
66         https://bugs.webkit.org/show_bug.cgi?id=141672
67
68         Reviewed by David Kilzer.
69
70         * asan/webkit-asan-ignore.txt:
71
72 2015-02-17  Alex Christensen  <achristensen@webkit.org>
73
74         Remove WebCore.exp.in and clean up.
75         https://bugs.webkit.org/show_bug.cgi?id=141491
76
77         Reviewed by Andreas Kling.
78
79         * Scripts/sort-export-file: Removed.
80         * Scripts/webkitpy/style/checker.py:
81         (_all_categories):
82         (FileType):
83         (CheckerDispatcher._file_type):
84         (CheckerDispatcher._create_checker):
85         Don't check if the export files are sorted.
86         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
87         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
88
89 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
90
91         Unreviewed. Fix GTK+ make distcheck.
92
93         Do not exclude bmalloc directory from the tarball.
94
95         * gtk/manifest.txt.in:
96
97 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
98
99         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
100
101         I forgot to add the return of a bool function.
102
103         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
104         (WebKitDOMNodeTest::testDOMCache):
105
106 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
107
108         [GTK] GObject DOM bindings object are cached forever
109         https://bugs.webkit.org/show_bug.cgi?id=141558
110
111         Reviewed by Sergio Villar Senin.
112
113         Add checks for all DOM objects to ensure they are not leaked. Also
114         add a dedicated test for the DOM Object Cache.
115
116         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
117         (WebKitDOMNodeFilterTest::testTreeWalker):
118         (WebKitDOMNodeFilterTest::testNodeIterator):
119         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
120         (WebKitDOMNodeTest::testHierarchyNavigation):
121         (WebKitDOMNodeTest::testInsertion):
122         (WebKitDOMNodeTest::testTagNames):
123         (WebKitDOMNodeTest::testDOMCache):
124         (registerTests):
125         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
126         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
127         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
128         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
129         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
130         (testWebKitDOMObjectCache):
131         (beforeAll):
132         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
133         (documentLoadedCallback):
134
135 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
136
137         [GTK] WebKitFrame objects are never released
138         https://bugs.webkit.org/show_bug.cgi?id=141641
139
140         Reviewed by Martin Robinson.
141
142         Add a way to check GObjects leaks for WebProcess tests and check
143         WebKitFrame objects are not leaked.
144
145         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
146         (WebKitFrameTest::testMainFrame):
147         (WebKitFrameTest::testURI):
148         (WebKitFrameTest::testJavaScriptContext):
149         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
150         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
151         (runTest):
152         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
153
154 2015-02-16  Tim Horton  <timothy_horton@apple.com>
155
156         Fix the MiniBrowser build with newer clang
157
158         * MiniBrowser/mac/SettingsController.m:
159         (-[SettingsController _toggleBooleanDefault:]):
160         * MiniBrowser/mac/WK1BrowserWindowController.m:
161         (-[WK1BrowserWindowController windowWillClose:]):
162         * MiniBrowser/mac/WK2BrowserWindowController.m:
163         (-[WK2BrowserWindowController windowWillClose:]):
164         NSApp is id and clang gets confused about which -delegate we're talking about.
165
166 2015-02-16  Antti Koivisto  <antti@apple.com>
167
168         Develop/Disable Caches does not properly disable disk cache
169         https://bugs.webkit.org/show_bug.cgi?id=141636
170
171         Reviewed by Anders Carlsson.
172
173         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
174         the network process too.
175
176         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
177
178         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
179         (WTR::InjectedBundle::beginTesting):
180         (WTR::InjectedBundle::setCacheModel):
181         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
182         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
183
184             Forward to TestController.
185
186         (WTR::TestRunner::setCacheModel):
187         * WebKitTestRunner/TestInvocation.cpp:
188         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
189
190 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
191
192         Unreviewed. Add myself as a committer.
193
194         * Scripts/webkitpy/common/config/contributors.json:
195
196 2015-02-15  David Kilzer  <ddkilzer@apple.com>
197
198         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
199         <http://webkit.org/b/141607>
200
201         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
202         externals in Source/WebCore/Configurations/WebCore.unexp when
203         building with Xcode 5.x.
204         (readXcode5SymbolsToIgnore): Add.
205
206 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
207
208         [EFL] fix Evas GL engine error.
209         https://bugs.webkit.org/show_bug.cgi?id=141621
210
211         Reviewed by Gyuyoung Kim.
212
213         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
214
215         * MiniBrowser/efl/main.c:
216         (elm_main):
217
218 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
219
220         [buildbot] Enable run-api-tests on release Mac bots
221         https://bugs.webkit.org/show_bug.cgi?id=141518
222
223         Reviewed by Darin Adler.
224
225         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
226         (RunUnitTests):
227         (BuildFactory.__init__):
228         (TestFactory.__init__):
229         (BuildAndTestFactory.__init__):
230         (RunUnitTests.start): Deleted.
231         (unitTestsSupported): Deleted.
232
233 2015-02-13  Anders Carlsson  <andersca@apple.com>
234
235         Add a move constructor and move assignment operator to Deque
236         https://bugs.webkit.org/show_bug.cgi?id=141571
237
238         Reviewed by Andreas Kling.
239
240         * TestWebKitAPI/Tests/WTF/Deque.cpp:
241         (TestWebKitAPI::TEST):
242
243 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
244
245         run-jsc-stress-tests --remote should skip profiler tests
246         https://bugs.webkit.org/show_bug.cgi?id=141470
247
248         Reviewed by Filip Pizlo.
249
250         * Scripts/run-jsc-stress-tests:
251
252 2015-02-13  Anders Carlsson  <andersca@apple.com>
253
254         Add an initializer list constructor to Deque
255         https://bugs.webkit.org/show_bug.cgi?id=141565
256
257         Reviewed by Andreas Kling.
258
259         * TestWebKitAPI/Tests/WTF/Deque.cpp:
260         (TestWebKitAPI::TEST):
261
262 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
263
264         [buildbot] Remove buildJSCTool cruft from master.cfg
265         https://bugs.webkit.org/show_bug.cgi?id=141513
266
267         Reviewed by Alexey Proskuryakov.
268
269         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
270         (RunJavaScriptCoreTests):
271         (RunJavaScriptCoreTests.start):
272         (RunWebKitTests):
273         (RunWebKitTests.start):
274         (TestFactory.__init__):
275         (TestLeaksFactory.__init__):
276         (RunJavaScriptCoreTests.__init__): Deleted.
277         (RunWebKitTests.__init__): Deleted.
278
279 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
280
281         Unreviewed, remove empty directories.
282
283         * DumpRenderTree/gtk: Removed.
284         * DumpRenderTree/gtk/fonts: Removed.
285         * DumpRenderTree/unix: Removed.
286         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
287         * GtkLauncher: Removed.
288         * TestWebKitAPI/Tests/WebKitGtk: Removed.
289         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
290         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
291         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
292
293 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
294
295         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
296         https://bugs.webkit.org/show_bug.cgi?id=141519
297
298         Reviewed by Alexey Proskuryakov.
299
300         * Scripts/build-webkittestrunner:
301
302 2015-02-12  Alex Christensen  <achristensen@webkit.org>
303
304         Removed empty directory.
305
306         * WinCELauncher: Removed.
307
308 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
309
310         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
311         https://bugs.webkit.org/show_bug.cgi?id=141202
312
313         Reviewed by Darin Adler.
314
315         * Scripts/run-jsc-stress-tests:
316
317 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
318
319         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
320         https://bugs.webkit.org/show_bug.cgi?id=141517
321
322         Reviewed by Anders Carlsson.
323
324         We do not need to locate or use the DLL's that came with Safari, so stop
325         failing when we cannot find them. Also remove some old Qt cruft from this
326         script.
327
328         * BuildSlaveSupport/built-product-archive:
329         (archiveBuiltProduct): 
330         (extractBuiltProduct):
331
332 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
333
334         [Win] [64-bit] Work around MSVC2013 Runtime Bug
335         https://bugs.webkit.org/show_bug.cgi?id=141498
336         <rdar://problem/19803642>
337
338         Reviewed by Anders Carlsson.
339
340         Disable FMA3 instruction use in the MSVC math library to
341         work around a VS2013 runtime crash. We can remove this
342         workaround when we switch to VS2015.
343
344         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
345         disable FMA3 support.
346         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
347         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
348         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
349         * Scripts/webkitperl/httpd.pm: Ditto.
350         * TestWebKitAPI/win/main.cpp: Ditto.
351         * WinLauncher/Common.cpp: Ditto.
352         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
353
354 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
355
356         run-jsc-stress-tests should accept remote host config from JSON file
357         https://bugs.webkit.org/show_bug.cgi?id=141509
358
359         Reviewed by Michael Saboff.
360
361         * Scripts/run-javascriptcore-tests:
362         (runJSCStressTests):
363         * Scripts/run-jsc-stress-tests:
364
365 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
366
367         [GTK] Add API to allow overriding the default color chooser implementation
368         https://bugs.webkit.org/show_bug.cgi?id=98935
369
370         Reviewed by Gustavo Noronha Silva.
371
372         Add a color chooser implementation for MiniBrowser using
373         GtkPopover when the GTK+ version is recent enough.
374         And a test case to check the new color chooser API.
375
376         * MiniBrowser/gtk/BrowserWindow.c:
377         (colorChooserRGBAChanged):
378         (popoverColorClosed):
379         (colorChooserRequestFinished):
380         (runColorChooserCallback):
381         (browserWindowConstructed):
382         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
383         (testWebViewColorChooserRequest):
384         (beforeAll):
385
386 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
387
388         Make run-jsc-stress-tests --remote work with make-based runner
389         https://bugs.webkit.org/show_bug.cgi?id=141079
390
391         Reviewed by Darin Adler.
392
393         * Scripts/run-javascriptcore-tests:
394         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
395         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
396         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
397         to avoid code duplication.
398
399 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
400
401         run-jsc-stress tests should detect the number of processors on the remote machine too
402         https://bugs.webkit.org/show_bug.cgi?id=141196
403
404         Reviewed by Darin Adler.
405
406         * Scripts/run-javascriptcore-tests:
407         (runJSCStressTests): Pass through the --child-processes argument.
408         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
409         to detect the number of local and remote processors with the same algorithm.
410         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
411         same as $numProcessors.
412
413 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
414
415         run-jsc-stress-tests should pass JSC_timeout to remote hosts
416         https://bugs.webkit.org/show_bug.cgi?id=141164
417
418         Reviewed by Darin Adler.
419
420         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
421
422         * Scripts/run-jsc-stress-tests:
423
424 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         [GTK] Add default color chooser implementation using GtkColorChooserDialog
427         https://bugs.webkit.org/show_bug.cgi?id=141392
428
429         Reviewed by Gustavo Noronha Silva.
430
431         Enable INPUT_TYPE_COLOR by default for GTK+ port.
432
433         * Scripts/webkitperl/FeatureList.pm:
434
435 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
436
437         run-jsc-stress-tests shell test runner should run tests in fixed order
438         https://bugs.webkit.org/show_bug.cgi?id=141383
439
440         Reviewed by Darin Adler.
441
442         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
443
444 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
445
446         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
447         https://bugs.webkit.org/show_bug.cgi?id=140485
448
449         Reviewed by Anders Carlsson.
450
451         Implement takeFocus() as a way to set focus through accessibility wrappers.
452
453         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
454         (AccessibilityUIElement::takeFocus):
455         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
456         (WTR::AccessibilityUIElement::takeFocus):
457
458 2015-02-08  Darin Adler  <darin@apple.com>
459
460         Remove the SVG instance tree
461         https://bugs.webkit.org/show_bug.cgi?id=140602
462
463         Reviewed by Dean Jackson.
464
465         * Scripts/check-for-global-initializers: Removed special case for
466         SVGElementInstance.o.
467
468 2015-02-07  David Kilzer  <ddkilzer@apple.com>
469
470         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
471         <http://webkit.org/b/141365>
472
473         Reviewed by Daniel Bates.
474
475         * Scripts/webkitpy/xcode/simulator.py:
476         (Simulator): Add unavailable_version_re precompiled regex.
477         (Simulator._parse_devices): Check for unavailable versions and
478         ignore them if found when parsing the output of
479         `xcrun simctl list`.
480         * Scripts/webkitpy/xcode/simulator_unittest.py:
481         (test_unavailable_devices): Add test with output from
482         `xcrun simctl list` with unavailable runtimes that fails before
483         the fix.
484
485 2015-02-07  Chris Dumez  <cdumez@apple.com>
486
487         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
488         https://bugs.webkit.org/show_bug.cgi?id=141321
489
490         Reviewed by Darin Adler.
491
492         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
493
494 2015-02-07  David Kilzer  <ddkilzer@apple.com>
495
496         [iOS] Make Simulator class testable
497         <http://webkit.org/b/141358>
498
499         Rubber-stamped by Darin Adler.
500
501         * Scripts/webkitpy/common/system/platforminfo.py:
502         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
503         command to here from Simulator.refresh() in xcode/simulator.py
504         so that the output of the command can be mocked.
505
506         * Scripts/webkitpy/common/system/platforminfo_mock.py:
507         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
508         to None.
509         (MockPlatformInfo.xcode_simctl_list): Add method that returns
510         self.expected_xcode_simctl_list expectation.
511
512         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
513         and license header.
514         (Simulator.__init__): Add optional 'host' parameter to make it
515         possible to pass in a mock object for testing.  Set self._host
516         to 'host' parameter or create Host() object.
517         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
518         method.
519
520         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
521         for current code.
522         (SimulatorTest):
523         (SimulatorTest.setUp):
524         (SimulatorTest._set_expected_xcrun_simctl_list):
525         (SimulatorTest.test_simulator_device_types):
526         (test_invalid_device_types_header):
527         (test_invalid_runtimes_header):
528         (test_invalid_devices_header):
529
530 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
531
532         run-jsc-stress-tests --remote should use the default ssh port
533         https://bugs.webkit.org/show_bug.cgi?id=141287
534
535         Reviewed by Darin Adler.
536
537         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
538
539 2015-02-06  Dana Burkart  <dburkart@apple.com>
540
541         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
542         https://bugs.webkit.org/show_bug.cgi?id=141349
543
544         Reviewed by Alexey Proskuryakov.
545
546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
547         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
548         (BuildbotTesterQueueView.prototype.update):
549
550 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
551
552         Report network process crashes during layout tests
553         https://bugs.webkit.org/show_bug.cgi?id=139646
554
555         Reviewed by Anders Carlsson.
556
557         * WebKitTestRunner/TestController.cpp:
558         (WTR::TestController::initialize):
559         (WTR::TestController::networkProcessName):
560         (WTR::TestController::networkProcessDidCrash):
561         * WebKitTestRunner/TestController.h:
562
563 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
564
565         run-jsc-stress-tests --remote should create remote directory before copying the bundle
566         https://bugs.webkit.org/show_bug.cgi?id=141329
567
568         Reviewed by Michael Saboff.
569
570         * Scripts/run-jsc-stress-tests:
571
572 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
573
574         [GTK] Remove WebKitWebView::close-notification signal
575         https://bugs.webkit.org/show_bug.cgi?id=141330
576
577         Reviewed by Gustavo Noronha Silva.
578
579         Update notifications unit tests according to the API changes, and
580         add a test case to check that onclose event is fired when a
581         notification is closed by the user.
582
583         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
584         (testWebViewNotification):
585
586 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
587
588         Dashboard doesn't consider building ASan a productive step
589         https://bugs.webkit.org/show_bug.cgi?id=141312
590
591         Reviewed by Simon Fraser.
592
593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
594
595 2015-02-05  Daniel Bates  <dabates@apple.com>
596
597         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
598         https://bugs.webkit.org/show_bug.cgi?id=141306
599
600         Reviewed by Alexey Proskuryakov.
601
602         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
603         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
604         existent runtime.
605
606         * Scripts/webkitpy/xcode/simulator.py:
607         (Runtime.from_identifier):
608
609 2015-02-05  Daniel Bates  <dabates@apple.com>
610
611         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
612         https://bugs.webkit.org/show_bug.cgi?id=139746
613         <rdar://problem/19283658>
614
615         Reviewed by Alexey Proskuryakov.
616
617         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
618         if the simulator device is not in state Booted.
619
620         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
621         launching/relaunching the iOS Simulator app and a simulator app can only be installed
622         on a device that is in the Booted state. LayoutTestRelay may run before the
623         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
624         We should defer executing LayoutTestRelay until the simulator device booted by
625         iOS Simulator is in the Booted state.
626
627         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
628         Simulator methods with the module name, simulator.
629         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
630         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
631         before launching iOS Simulator to boot it.
632         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
633         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
634         * Scripts/webkitpy/xcode/simulator.py:
635         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
636         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
637         interested in the state of the device are more likely interested in the current state of the device as
638         opposed to the state of the device when the Device object was created.
639         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
640         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
641         from both this function and Simulator.device_state().
642         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
643         (Simulator.DeviceState): Added; class of constants.
644         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
645         device is in the specified state.
646         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
647         (Simulator.device_directory): Added.
648         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
649
650 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
651
652         Disable retries on Mac debug testers
653         https://bugs.webkit.org/show_bug.cgi?id=141296
654
655         Reviewed by Simon Fraser.
656
657         * BuildSlaveSupport/build.webkit.org-config/config.json:
658
659 2015-02-05  Dan Bernstein  <mitz@apple.com>
660
661         Need a way to force $xcodeSDK in webkitdirs.pm
662         https://bugs.webkit.org/show_bug.cgi?id=141291
663
664         Reviewed by Anders Carlsson.
665
666         * Scripts/webkitdirs.pm:
667         (setXcodeSDK): Added.
668
669 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
670
671         [Streams API] Implement a barebone ReadableStream interface
672         https://bugs.webkit.org/show_bug.cgi?id=141045
673
674         Reviewed by Benjamin Poulain.
675
676         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
677
678 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
679
680         filter-build-webkit: reduce more unfiltered output
681         https://bugs.webkit.org/show_bug.cgi?id=141282
682
683         Reviewed by Daniel Bates.
684
685         * Scripts/filter-build-webkit:
686         Report CompileDTraceScript and Preprocess lines as successful.
687
688 2015-02-04  Dana Burkart  <dburkart@apple.com>
689
690         Botwatcher's Dashboard is cramped
691         https://bugs.webkit.org/show_bug.cgi?id=140273
692
693         Reviewed by Alexey Proskuryakov.
694
695         Add a heading key which will allow for arbitrary headings in builder queues.
696
697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
698         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
699         (BuildbotBuilderQueueView.prototype.update):
700         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
702         (BuildbotIteration.prototype._parseData):
703         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
704         (BuildbotLeaksQueueView.prototype.update):
705         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
707         (BuildbotPerformanceQueueView.prototype.update):
708         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
709         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
710         (BuildbotQueue):
711         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
712         (BuildbotQueueView.prototype._unauthorizedAccess):
713         (BuildbotQueueView.prototype._appendBuild):
714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
715         (BuildbotTestResults):
716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
717         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
718         (BuildbotTesterQueueView.prototype.update):
719         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
720
721 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
722
723         WKTR should not use -mainScreen to pick a color profile
724         https://bugs.webkit.org/show_bug.cgi?id=141265
725
726         Reviewed by Tim Horton.
727         
728         -[NSScreen mainScreen] depends on the active window, so use the first screen
729         (which is the one we put the window on anyway).
730         
731         Do some cleanup in DRT that makes the code look similar.
732
733         * DumpRenderTree/mac/DumpRenderTree.mm:
734         (createWebViewAndOffscreenWindow):
735         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
736         (WTR::PlatformWebView::PlatformWebView):
737
738 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
739
740         LayoutTestHelper should set the color profile of all displays
741         https://bugs.webkit.org/show_bug.cgi?id=141260
742
743         Reviewed by Tim Horton.
744         
745         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
746         which is the screen with the active window. Make things more robust by changing
747         the colorspace of all displays, not just the main screen, when running layout tests.
748
749         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
750         * DumpRenderTree/mac/LayoutTestHelper.m: 
751         (originalColorProfileURLs):
752         (colorProfileURLForDisplay):
753         (displayUUIDStrings):
754         (saveDisplayColorProfiles):
755         (setDisplayColorProfile):
756         (restoreDisplayColorProfiles):
757         (installLayoutTestColorProfile):
758         (restoreUserColorProfile):
759         (main):        
760         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
761         toll-free bridged, sadly). Use the map to restore all profiles on exit.
762         Convert to use more Obj-C types.
763
764 2015-02-04  Daniel Bates  <dabates@apple.com>
765
766         test-webkitpy fails on Mac without iphoneos SDK
767         https://bugs.webkit.org/show_bug.cgi?id=141255
768         <rdar://problem/19619691>
769
770         I inadvertently committed the wrong exception message. Fix up the exception message
771         to instruct a person to install the iOS SDK when it cannot be found.
772
773         * Scripts/webkitpy/port/ios.py:
774         (IOSPort.determine_full_port_name):
775
776 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
777
778         W3C test importer should sort the list of files when generating the w3c-import.log
779         https://bugs.webkit.org/show_bug.cgi?id=141156
780
781         Reviewed by Bem Jones-Bey.
782
783         Sort explicitly the list of imported files written in the w3c-import.log.
784         Removed logging of the import date.
785
786         * Scripts/webkitpy/w3c/test_importer.py:
787         (TestImporter.write_import_log):
788
789 2015-02-04  Daniel Bates  <dabates@apple.com>
790
791         test-webkitpy fails on Mac without iphoneos SDK
792         https://bugs.webkit.org/show_bug.cgi?id=141255
793         <rdar://problem/19619691>
794
795         Reviewed by David Kilzer and Alexey Proskuryakov.
796
797         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
798         should not require the iphoneos SDK to be installed to run the webkitpy tests.
799
800         * Scripts/webkitpy/common/system/platforminfo.py:
801         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
802         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
803         to standard output if the SDK is installed to return the empty string if the SDK is
804         not installed.
805         * Scripts/webkitpy/common/system/platforminfo_mock.py:
806         (MockPlatformInfo.xcode_sdk_version): Added.
807         * Scripts/webkitpy/port/ios.py:
808         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
809         to get the version of the iphoneos SDK, if installed.
810
811 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
812
813         run-webkit-tests doesn't always capture ASan violation reports
814         https://bugs.webkit.org/show_bug.cgi?id=141231
815
816         Reviewed by Darin Adler.
817
818         * Scripts/webkitpy/port/driver.py:
819         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
820         by the driver already (as is the case with ASan violations, which are printed to
821         stderr).
822         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
823         report.
824         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
825         a separate variable for reporting.
826
827 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
828
829         [webkitpy] Add platform specific Skipped file mechanism for performance tests
830         https://bugs.webkit.org/show_bug.cgi?id=141152
831
832         Reviewed by Csaba Osztrogonác.
833
834         Support a test-expectation-like syntax in performance tests' skipped files.
835         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
836
837         * Scripts/webkitpy/port/base.py:
838         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
839
840         * Scripts/webkitpy/port/base_unittest.py:
841         (PortTest.test_skipped_perf_tests): Test the new syntax.
842
843 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
844
845         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
846         https://bugs.webkit.org/show_bug.cgi?id=141236
847
848         Reviewed by Sam Weinig.
849
850         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
851         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
852
853 2015-02-04  Chris Dumez  <cdumez@apple.com>
854
855         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
856         https://bugs.webkit.org/show_bug.cgi?id=141192
857
858         Reviewed by Benjamin Poulain.
859
860         Add API tests for Vector::removeFirst(value) and
861         Vector::removeAll(value).
862
863         * TestWebKitAPI/Tests/WTF/Vector.cpp:
864         (TestWebKitAPI::TEST):
865
866 2015-02-03  Tim Horton  <timothy_horton@apple.com>
867
868         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
869         https://bugs.webkit.org/show_bug.cgi?id=141217
870
871         Reviewed by Sam Weinig.
872
873         * WebKitTestRunner/TestController.cpp:
874         (WTR::copyWebCryptoMasterKey):
875         (WTR::TestController::createOtherPage):
876         (WTR::TestController::createWebViewWithOptions):
877         (WTR::TestController::ensureViewSupportsOptions):
878         (WTR::TestController::didCommitNavigation):
879         (WTR::TestController::didFinishNavigation):
880         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
881         (WTR::TestController::didReceiveAuthenticationChallenge):
882         (WTR::TestController::decidePolicyForPluginLoad):
883         (WTR::TestController::decidePolicyForNavigationAction):
884         (WTR::TestController::decidePolicyForNavigationResponse):
885         (WTR::TestController::didCommitLoadForFrame): Deleted.
886         (WTR::TestController::didFinishLoadForFrame): Deleted.
887         * WebKitTestRunner/TestController.h:
888         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
889
890 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
891
892         Unreviewed. Add myself as a committer.
893
894         * Scripts/webkitpy/common/config/contributors.json:
895
896 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
897
898         [Win] Unreviewed test fix.
899
900         * DumpRenderTree/win/PolicyDelegate.cpp:
901         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
902         so was not matching expected output.
903
904 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
905
906         Unreviewed. Moving myself to the committer section at last.
907
908         * Scripts/webkitpy/common/config/contributors.json:
909
910 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
911
912         [Win] Tests fail because DRT reports '(null)' instead of an empty string
913         https://bugs.webkit.org/show_bug.cgi?id=141205
914
915         Reviewed by Anders Carlsson.
916
917         * DumpRenderTree/win/HistoryDelegate.cpp:
918         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
919         properly so that we match expected DumpRenderTree output.
920
921 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
922
923         [GTK] TestWebKitAccessibility is not skipped
924         https://bugs.webkit.org/show_bug.cgi?id=141179
925
926         Reviewed by Carlos Garcia Campos.
927
928         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
929         skipped, and it apparently works reliably on the bots.
930
931         * Scripts/run-gtk-tests:
932         (TestRunner):
933
934 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
935
936         run-perf-tests: allow to specify a wrapper command.
937         https://bugs.webkit.org/show_bug.cgi?id=141172
938
939         Reviewed by Ryosuke Niwa.
940
941         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
942         (parse_args): Update text to indicate is also valid for WTR.
943         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
944         (PerfTestsRunner._parse_args): Add wrapper command.
945
946 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
947
948         [Win] Correct version parsing warning in update-webkit
949         https://bugs.webkit.org/show_bug.cgi?id=141200
950
951         Reviewed by Anders Carlsson.
952
953         * Scripts/webkitdirs.pm:
954         (setupAppleWinEnv): Strip out any specific version build level
955         from the Cygwin version information.
956   
957
958 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
959
960         [Win] Attempt to improve the reliability of HTTP service
961         https://bugs.webkit.org/show_bug.cgi?id=141191
962
963         Reviewed by Darin Adler.
964
965         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
966         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
967         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
968         when stopping the service doesn't do so on its own (for Windows runs).
969
970 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
971
972         Web platform test server should not need to create __init__.py files
973         https://bugs.webkit.org/show_bug.cgi?id=141030
974
975         Reviewed by Ryosuke Niwa.
976
977         W3C TestImporter ensures that copied __init__.py files are not empty.
978         If needed, a comment is inserted in __init__.py files.
979         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
980
981         * Scripts/webkitpy/common/system/filesystem.py:
982         (FileSystem.getsize):
983         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
984         (TestWebPlatformTestServer.test_start_cmd):
985         (TestWebPlatformTestServer):
986         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
987         * Scripts/webkitpy/w3c/test_importer.py:
988         (TestImporter.import_tests):
989
990 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
991
992         Unreviewed. Moving myself to the committer section.
993
994         * Scripts/webkitpy/common/config/contributors.json:
995
996 2015-02-02  Saam Barati  <saambarati1@gmail.com>
997
998         Create tests for JSC's Control Flow Profiler
999         https://bugs.webkit.org/show_bug.cgi?id=141123
1000
1001         Reviewed by Filip Pizlo.
1002
1003         * Scripts/run-javascriptcore-tests:
1004         (runJSCStressTests):
1005         * Scripts/run-jsc-stress-tests:
1006
1007 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1008
1009         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
1010         https://bugs.webkit.org/show_bug.cgi?id=141158
1011
1012         Reviewed by Darin Adler.
1013
1014         * Scripts/run-jsc-stress-tests:
1015
1016 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1017
1018         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
1019         https://bugs.webkit.org/show_bug.cgi?id=141142
1020
1021         Reviewed by Carlos Garcia Campos.
1022
1023         * MiniBrowser/gtk/BrowserWindow.c:
1024         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
1025
1026 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1027
1028         Web platform test server is not always launching properly on Mac EWS bots
1029         https://bugs.webkit.org/show_bug.cgi?id=141141
1030
1031         Unreviewed.
1032
1033         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1034         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
1035
1036 2015-01-31  Sam Weinig  <sam@webkit.org>
1037
1038         Remove even more Mountain Lion support
1039         https://bugs.webkit.org/show_bug.cgi?id=141124
1040
1041         Reviewed by Alexey Proskuryakov.
1042
1043         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1044         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1045         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1046         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1047         * DumpRenderTree/mac/DumpRenderTree.mm:
1048         (activateTestingFonts):
1049         (prepareConsistentTestingEnvironment):
1050         * DumpRenderTree/mac/EventSendingController.mm:
1051         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1052         (-[EventSendingController contextClick]):
1053         * DumpRenderTree/mac/TextInputController.m:
1054         * LayoutTestRelay/Configurations/Base.xcconfig:
1055         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1056         * MiniBrowser/Configurations/Base.xcconfig:
1057         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1058         * MiniBrowser/mac/WK2BrowserWindowController.m:
1059         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1060         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1061         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1062         * TestWebKitAPI/Configurations/Base.xcconfig:
1063         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1064         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1065         (-[DownloadDelegate _downloadDidFinish:]):
1066         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1067         (TestWebKitAPI::TEST):
1068         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1069         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1070         * WebKitLauncher/Configurations/Base.xcconfig:
1071         * WebKitTestRunner/Configurations/Base.xcconfig:
1072         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1073         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1074         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1075         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1076         (WTR::activateFonts):
1077         * WebKitTestRunner/TestController.cpp:
1078         (WTR::TestController::initialize):
1079         (WTR::TestController::webProcessName):
1080         * WebKitTestRunner/mac/EventSenderProxy.mm:
1081         * asan/asan.xcconfig:
1082
1083 2015-01-31  Commit Queue  <commit-queue@webkit.org>
1084
1085         Unreviewed, rolling out r179408.
1086         https://bugs.webkit.org/show_bug.cgi?id=141117
1087
1088         This didn't fully fix the issue (Requested by anttik on
1089         #webkit).
1090
1091         Reverted changeset:
1092
1093         "OSObjectPtr does not work with dispatch_data_t on Maverics"
1094         https://bugs.webkit.org/show_bug.cgi?id=141081
1095         http://trac.webkit.org/changeset/179408
1096
1097 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1098
1099         https://trac.webkit.org/changeset/179439 breaks a python test
1100         https://bugs.webkit.org/show_bug.cgi?id=141114
1101
1102         Unreviewed.
1103
1104         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1105         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
1106
1107 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1108
1109         Import W3C web platform tests infrastructure
1110         https://bugs.webkit.org/show_bug.cgi?id=140934
1111
1112         Reviewed by Ryosuke Niwa.
1113
1114         Loading necessary web platform tests modules before launching server.
1115         Ensuring that some empty __init__.py files are present and create them if necessary. 
1116
1117         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1118         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1119
1120 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1121
1122         [Win] Another unreviewed test fix.
1123
1124         Correct copy/paste error in buildbot handling.
1125
1126         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1127         (LayoutTestApacheHttpd.__init__):
1128         (LayoutTestApacheHttpd._get_apache_config_file_path):
1129
1130 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1131
1132         [Win] Unreviewed test fix.
1133
1134         Correct path handling based on failures on test bots to get things running again.
1135
1136         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1137         (LayoutTestApacheHttpd.__init__):
1138         (LayoutTestApacheHttpd._get_apache_config_file_path):
1139
1140 2015-01-30  Chris Dumez  <cdumez@apple.com>
1141
1142         Unreviewed. Fix Windows build after r179409.
1143
1144         * DumpRenderTree/win/TestRunnerWin.cpp:
1145         (TestRunner::notifyDone):
1146         (TestRunner::queueLoad):
1147
1148 2015-01-30  Chris Dumez  <cdumez@apple.com>
1149
1150         Rename shared() static member functions to singleton() for singleton classes.
1151         https://bugs.webkit.org/show_bug.cgi?id=141088
1152
1153         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1154
1155         Rename shared() static member functions to singleton() for singleton
1156         classes as per the recent coding style change.
1157
1158 2015-01-30  Antti Koivisto  <antti@apple.com>
1159
1160         OSObjectPtr does not work with dispatch_data_t on Maverics
1161         https://bugs.webkit.org/show_bug.cgi?id=141081
1162
1163         Reviewed by Pratik Solanki.
1164
1165         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1166         (TestWebKitAPI::TEST):
1167
1168 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1169
1170         [Win] Switch to Apache on Windows
1171         https://bugs.webkit.org/show_bug.cgi?id=141060
1172
1173         Reviewed by Alexey Proskuryakov.
1174
1175         Update our scripts under Windows (and Cygwin) to locate and use
1176         the XAMPP installation of Apache for running tests.
1177
1178         * Scripts/run-webkit-httpd:
1179         * Scripts/webkitperl/httpd.pm:
1180         (getHTTPDPath):
1181         (getDefaultConfigForTestDirectory):
1182         (getHTTPDConfigPathForTestDirectory):
1183         * Scripts/webkitpy/common/system/executive_unittest.py:
1184         (ExecutiveTest.serial_test_kill_process):
1185         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1186         (LayoutTestApacheHttpd.__init__):
1187         (LayoutTestApacheHttpd._get_apache_config_file_path):
1188         (LayoutTestApacheHttpd._stop_running_server):
1189         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1190         (HttpServerBase._is_server_running_on_all_ports):
1191         * Scripts/webkitpy/port/base.py:
1192         (Port._apache_config_file_name_for_platform):
1193         * Scripts/webkitpy/port/port_testcase.py:
1194         (test_apache_config_file_name_for_platform):
1195         * Scripts/webkitpy/port/win.py:
1196         (WinPort.show_results_html_file):
1197         (WinPort._uses_apache):
1198         (WinPort):
1199         (WinPort._path_to_apache):
1200
1201 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1202
1203         Built result takes too long to be compressed on bots
1204         https://bugs.webkit.org/show_bug.cgi?id=141056
1205
1206         Reviewed by Daniel Bates.
1207
1208         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1209
1210         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1211
1212 2015-01-29  Sam Weinig  <sam@webkit.org>
1213
1214         Remove support for screen font substitution
1215         https://bugs.webkit.org/show_bug.cgi?id=141038
1216
1217         Reviewed by Tim Horton.
1218
1219         * DumpRenderTree/win/DumpRenderTree.cpp:
1220         (resetWebPreferencesToConsistentValues):
1221         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1222
1223 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1224
1225         Make run-jsc-stress-tests --remote work on Linux too
1226         https://bugs.webkit.org/show_bug.cgi?id=141000
1227
1228         Reviewed by Darin Adler.
1229
1230         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1231         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1232         use bash/dash compatible functions.
1233         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1234
1235 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1236
1237         [buildbot] Simplify jscore-test buildstep
1238         https://bugs.webkit.org/show_bug.cgi?id=140821
1239
1240         Reviewed by Alexey Proskuryakov.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1243         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1244         (RunJavaScriptCoreTests.countFailures): Added.
1245         (RunJavaScriptCoreTests.commandComplete): Deleted.
1246         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1247         (RunJavaScriptCoreTests.getText): Deleted.
1248         (RunJavaScriptCoreTests.getText2): Deleted.
1249         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1250         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1251         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1252         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1253         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1254
1255 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1256
1257         Unreviewed, revert r179337, we don't need this dependency.
1258
1259         * efl/install-dependencies:
1260         * gtk/install-dependencies:
1261
1262 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1263
1264         Unreviewed. Moving myself to the committer section.
1265
1266         * Scripts/webkitpy/common/config/contributors.json:
1267
1268 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1269
1270         URTBF after r179326, added uuid-dev package as new dependency.
1271
1272         * efl/install-dependencies:
1273         * gtk/install-dependencies:
1274
1275 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1276
1277         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1278         https://bugs.webkit.org/show_bug.cgi?id=140673
1279
1280         Reviewed by Sam Weinig.
1281
1282         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1283         Add a DTrace script that outputs a small blob of JSON per message.
1284
1285 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1286
1287         Removed fastMallocForbid / fastMallocAllow
1288         https://bugs.webkit.org/show_bug.cgi?id=141012
1289
1290         Reviewed by Mark Hahnenberg.
1291
1292         Fixed a test bug I noticed while testing.
1293
1294         * DumpRenderTree/JavaScriptThreading.cpp:
1295         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1296         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1297
1298 2015-01-28  Dana Burkart  <dburkart@apple.com>
1299
1300         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1301         https://bugs.webkit.org/show_bug.cgi?id=141015
1302
1303         Reviewed by Alexey Proskuryakov.
1304
1305         * asan/asan.xcconfig:
1306
1307 2015-01-28  Sam Weinig  <sam@webkit.org>
1308
1309         Fix the build.
1310
1311         * Scripts/copy-webkitlibraries-to-product-directory:
1312
1313 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1314
1315         Increase the FileUpload block size in an attempt to improve network performance.
1316         
1317         Reviewed by Alexey Proskuryakov.
1318         
1319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1320         (UploadBuiltProduct.__init__):
1321
1322 2015-01-28  Dana Burkart  <dburkart@apple.com>
1323
1324         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1325         https://bugs.webkit.org/show_bug.cgi?id=136765
1326
1327         Reviewed by Alexey Proskuryakov.
1328
1329         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1330         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1331         * LayoutTestRelay/Configurations/Base.xcconfig:
1332         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1333         * MiniBrowser/Configurations/Base.xcconfig:
1334         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1335         * TestWebKitAPI/Configurations/Base.xcconfig:
1336         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1337         * WebKitLauncher/Configurations/Base.xcconfig:
1338         * WebKitTestRunner/Configurations/Base.xcconfig:
1339         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1340
1341 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1342
1343         AX: [ATK] Implement support for new AtkRole types for MathML
1344         https://bugs.webkit.org/show_bug.cgi?id=140916
1345
1346         Reviewed by Chris Fleizach.
1347
1348         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1349         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1350
1351 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1352
1353         [GTK] Stop removing color marks from unit tests output
1354         https://bugs.webkit.org/show_bug.cgi?id=140996
1355
1356         Reviewed by Philippe Normand.
1357
1358         Since r178236 google tests use a custom simplified output without
1359         any colors, so we don't need to handle the case of non ttys to
1360         remove the color marks.
1361
1362         * Scripts/run-gtk-tests:
1363         (TestRunner.__init__):
1364         (TestRunner._run_test_command.parse_line):
1365
1366 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1367
1368         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1369         https://bugs.webkit.org/show_bug.cgi?id=131731
1370
1371         Reviewed by Žan Doberšek.
1372
1373         A web page loaded offscreen is in prerender state not hidden.
1374
1375         * Scripts/run-gtk-tests:
1376         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1377         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1378         (testWebViewPageVisibility):
1379
1380 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1381
1382         Partially revert r178802.
1383
1384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1386
1387 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1388
1389         build.webkit.org/dashboard asserts on some commits
1390         https://bugs.webkit.org/show_bug.cgi?id=140926
1391
1392         Reviewed by Tim Horton.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1395         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1396
1397 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1398
1399         Make flakiness dashboard OS list actually match test_expectations.py
1400         https://bugs.webkit.org/show_bug.cgi?id=140969
1401
1402         Reviewed by Ryosuke Niwa.
1403
1404         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1405
1406 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1407
1408         [Win] WinLauncher crashes on eleventh site visited
1409         https://bugs.webkit.org/show_bug.cgi?id=140960
1410
1411         Reviewed by Anders Carlsson.
1412
1413         * WinLauncher/WinLauncher.cpp:
1414         (WinLauncher::showLastVisitedSites): Don't access off the end of
1415         the history array.
1416
1417 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1418
1419         [Mac] Disable building Java applets by default
1420         https://bugs.webkit.org/show_bug.cgi?id=140957
1421         rdar://problem/19619529
1422
1423         Reviewed by Anders Carlsson.
1424
1425         It was actually already disabled unconditionally, by accident.
1426
1427         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1428         * Scripts/webkitpy/port/mac.py:
1429         (MacPort._check_port_build):
1430         (MacPort._build_java_test_support):
1431
1432 2015-01-27  Daniel Bates  <dabates@apple.com>
1433
1434         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1435         https://bugs.webkit.org/show_bug.cgi?id=140949
1436
1437         Reviewed by Alexey Proskuryakov.
1438
1439         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1440         builders so that run-webkit-tests can lint the appropriate TestExpectation
1441         files.
1442
1443         * Scripts/webkitpy/port/builders.py:
1444         * Scripts/webkitpy/port/ios.py:
1445         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1446         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1447         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1448         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1449         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1450         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1451         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1452
1453
1454 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1455
1456         Update bots on the flakiness dashboard
1457         https://bugs.webkit.org/show_bug.cgi?id=140956
1458
1459         Reviewed by Ryosuke Niwa.
1460
1461         * TestResultServer/static-dashboards/builders.jsonp:
1462         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1463
1464 2015-01-27  Daniel Bates  <dabates@apple.com>
1465
1466         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1467         https://bugs.webkit.org/show_bug.cgi?id=140942
1468
1469         Reviewed by Alexey Proskuryakov.
1470
1471         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1472         are applicable to all WebKit2 ports. We should make use of this information when
1473         running layout tests using iOS WebKit2.
1474
1475         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1476         of the WebKit2 port instead of directly using string concatenation.
1477
1478         * Scripts/webkitpy/port/ios.py:
1479         (IOSSimulatorPort.default_baseline_search_path):
1480
1481 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1482
1483         [Win] Disable FTL stress tests
1484         https://bugs.webkit.org/show_bug.cgi?id=140932
1485
1486         Reviewed by Brent Fulgham.
1487
1488         * Scripts/run-javascriptcore-tests:
1489
1490 2015-01-27  Daniel Bates  <dabates@apple.com>
1491
1492         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1493         https://bugs.webkit.org/show_bug.cgi?id=140939
1494
1495         Reviewed by Eric Carlson.
1496
1497         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1498
1499         * Scripts/webkitdirs.pm:
1500         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1501         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1502         and define a function called wanted.
1503
1504 2015-01-27  Daniel Bates  <dabates@apple.com>
1505
1506         Teach run-webkit-app --simulator how to install custom built app
1507         https://bugs.webkit.org/show_bug.cgi?id=140691
1508
1509         Fix inadvertent omission of directory test flag in expression to check for the
1510         existence of the iOS simulator device-specific directory for user installed apps.
1511
1512         * Scripts/webkitdirs.pm:
1513         (hasUserInstalledAppInSimulatorDevice):
1514
1515 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1516
1517         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1518         https://bugs.webkit.org/show_bug.cgi?id=87426
1519         <rdar://problem/11527899>
1520
1521         Reviewed by Darin Adler.
1522
1523         Revise COMPtr to work better with our HashMap implementation. Use
1524         modern loop syntax.
1525
1526         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1527         (AccessibilityController::~AccessibilityController):
1528         (AccessibilityController::winNotificationReceived):
1529         * DumpRenderTree/win/DumpRenderTree.cpp:
1530         (dumpBackForwardListForAllWindows):
1531
1532 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1533
1534         [Win] Enable JSC stress tests by default
1535         https://bugs.webkit.org/show_bug.cgi?id=128307
1536
1537         Reviewed by Brent Fulgham.
1538
1539         * Scripts/run-javascriptcore-tests:
1540
1541 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1542
1543         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1544         arguments for build and test scripts
1545         https://bugs.webkit.org/show_bug.cgi?id=139748
1546
1547         Reviewed by Daniel Bates.
1548
1549         There was much confusion resulting from the multitude of aliases used to build/test for
1550         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1551         tests directory.
1552
1553         This fixes an issue where run-api-tests and some other scripts failed when run with
1554         --simulator.
1555
1556         * Scripts/build-webkit:
1557         * Scripts/package-root:
1558         (usage):
1559         * Scripts/webkitdirs.pm:
1560         (argumentsForConfiguration):
1561         (determineXcodeSDK):
1562         * Scripts/webkitpy/port/factory.py:
1563         (platform_options):
1564
1565 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1566
1567         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1568         https://bugs.webkit.org/show_bug.cgi?id=140203
1569         rdar://problem/19198492
1570
1571         Reviewed by Sam Weinig.
1572
1573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1574         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1575         (TEST):
1576
1577 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1578
1579         Add iOS EWS to build.webkit.org/dashboard
1580         <http://webkit.org/b/140627>
1581
1582         Reviewed by Alexey Proskuryakov.
1583
1584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1587         (BubbleQueueServer): Add ios-ews queue info.
1588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1589         Add iOS8Device platform.
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1591         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1592         iOS device logo.
1593
1594 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1595
1596         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1597         https://bugs.webkit.org/show_bug.cgi?id=140896
1598
1599         Reviewed by Michael Saboff.
1600         
1601         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1602         makes our script do this.
1603         
1604         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1605         this would be harder given llvm's autoconf setup.
1606
1607         * Scripts/copy-webkitlibraries-to-product-directory:
1608
1609 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1610
1611         Update bot assignments.
1612
1613         * BuildSlaveSupport/build.webkit.org-config/config.json:
1614
1615 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1616
1617         Integrate WP python server into WebKit test framework
1618         https://bugs.webkit.org/show_bug.cgi?id=127094
1619
1620         Reviewed by Ryosuke Niwa.
1621
1622         This patch adds W3C web server (wptserver) as a new HTTP server.
1623         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1624         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1625
1626         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1627         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1628         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1629
1630         * Scripts/webkitpy/common/system/executive_mock.py:
1631         (MockProcess.communicate):
1632         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1633         (LayoutTestRunner.__init__):
1634         (LayoutTestRunner.run_tests):
1635         (LayoutTestRunner.start_servers):
1636         (LayoutTestRunner.stop_servers):
1637         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1638         (LayoutTestRunnerTests._run_tests):
1639         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1640         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1641         (LayoutTestRunnerTests):
1642         (LayoutTestRunnerTests.test_servers_started):
1643         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1644         (Manager.__init__):
1645         (Manager._is_http_test):
1646         (Manager._is_web_platform_test):
1647         (Manager._run_tests):
1648         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1649         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1650         (ManagerTest.test_needs_servers.get_manager):
1651         (ManagerTest.test_needs_servers):
1652         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1653         (parse_args):
1654         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1655         (main):
1656         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1657         (doc_root):
1658         (base_url):
1659         (WebPlatformTestServer):
1660         (WebPlatformTestServer.__init__):
1661         (WebPlatformTestServer._set_start_cmd):
1662         (WebPlatformTestServer._copy_webkit_test_files):
1663         (WebPlatformTestServer._clean_webkit_test_files):
1664         (WebPlatformTestServer._prepare_config):
1665         (WebPlatformTestServer._spawn_process):
1666         (WebPlatformTestServer._stop_running_server):
1667         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1668         (TestWebPlatformTestServer):
1669         (TestWebPlatformTestServer.test_start_cmd):
1670         * Scripts/webkitpy/port/base.py:
1671         (Port.__init__):
1672         (Port.to.start_web_platform_test_server):
1673         (Port.to):
1674         (Port.to.web_platform_test_server_doc_root):
1675         (Port.to.web_platform_test_server_base_url):
1676         (Port.to.stop_web_platform_test_server):
1677         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
1678         (Driver.__init__):
1679         (Driver.is_web_platform_test):
1680         (Driver.test_to_uri):
1681         (Driver.uri_to_test):
1682         (Driver._command_from_driver_input):
1683         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
1684         (DriverTest.test_test_to_uri):
1685         (DriverTest.test_uri_to_test):
1686
1687 2015-01-26  Daniel Bates  <dabates@apple.com>
1688
1689         Teach run-webkit-app --simulator how to install custom built app
1690         https://bugs.webkit.org/show_bug.cgi?id=140691
1691
1692         Reviewed by David Kilzer.
1693
1694         We should teach run-webkit-app --simulator how to install a custom built app.
1695
1696         Currently run-webkit-app --simulator can only run a system app or an app that
1697         was installed using the simctl command line tool. For convenience we should
1698         teach run-webkit-app --simulator how to install a custom built app.
1699
1700         As a side effect of this change run-safari --simulator will install and run
1701         a custom built of MobileSafari (if it exists).
1702
1703         * Scripts/webkitdirs.pm:
1704         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
1705         Perl from the structure of the device.plist file.
1706         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
1707         file system check to determine the plist path for a Mac app bundle.
1708         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
1709         it will complain that it cannot find the file: "Domain ... does not exist".
1710         (appDisplayNameFromBundle): Ditto.
1711         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
1712         until a simulator device is the specified state.
1713         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
1714         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
1715         the specified device.
1716         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
1717         As implied by its name, this function will not return until the specified simulator
1718         device UDID is in the shutdown state.
1719         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
1720         device with the specified UDID.
1721         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
1722         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
1723         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
1724         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
1725         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
1726         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
1727         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
1728         (hasUserInstalledAppInSimulatorDevice): Added.
1729         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
1730         "Booted" state.
1731         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
1732         switching between a system installed app and a custom built version of the same app (e.g.
1733         custom build of MobileSafari) will erase all contents and settings in the simulator device.
1734         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
1735         as that was the only caller of this function.
1736         (bootedIOSSimulatorDevice): Deleted.
1737         (openIOSSimulator): Deleted.
1738
1739 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1740
1741         Update bot assignments.
1742
1743         * BuildSlaveSupport/build.webkit.org-config/config.json:
1744
1745 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1746
1747         Leaks bot shouldn't run JSC tests
1748         https://bugs.webkit.org/show_bug.cgi?id=140877
1749
1750         Reviewed by Darin Adler.
1751
1752         Shaves off 48 minutes of time.
1753
1754         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1755         (TestLeaksFactory): Slim down the leaks queue.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1758         * Scripts/webkitpy/port/ios.py:
1759         (IOSSimulatorPort.print_leaks_summary):
1760         * Scripts/webkitpy/port/mac.py:
1761         (MacPort.print_leaks_summary):
1762         Don't yell when leaks are detected.
1763
1764 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1765
1766         Refactor run-javascriptcore-tests
1767         https://bugs.webkit.org/show_bug.cgi?id=140824
1768
1769         Reviewed by Darin Adler.
1770
1771         Separated mozilla, stress test code paths and
1772         determining skipped mozilla tests into subroutines.
1773
1774         * Scripts/run-javascriptcore-tests:
1775         (runMozillaTests):
1776         (runJSCStressTests):
1777         (defaultJsDriverArgsForMozillaTests):
1778
1779 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1780
1781         [buildbot] Fix grammar of TestWithFailureCount
1782         https://bugs.webkit.org/show_bug.cgi?id=140884
1783
1784         Reviewed by Alexey Proskuryakov.
1785
1786         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1787         (TestWithFailureCount):
1788         (TestWithFailureCount.commandComplete):
1789         (TestWithFailureCount.getText2):
1790         (RunUnitTests):
1791         (RunPythonTests):
1792         (RunPerlTests):
1793         (RunLLINTCLoopTests):
1794         (Run32bitJSCTests):
1795         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1796         (RunLLINTCLoopTestsTest.test_failure):
1797         (Run32bitJSCTestsTest.test_failure):
1798         (RunUnitTestsTest.assertFailures):
1799
1800 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1801
1802         Unreviewed. Moving myself to the committer section.
1803
1804         * Scripts/webkitpy/common/config/contributors.json:
1805
1806 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1807
1808         [GTK] gtkdoc does not appear in DevHelp
1809         https://bugs.webkit.org/show_bug.cgi?id=139369
1810
1811         Reviewed by Philippe Normand.
1812
1813         * gtk/generate-gtkdoc: Create the generators in the main function
1814         and use them to get the local cross renference dependencies. Also
1815         pass the generator module name to webkitdom.write_doc_files().
1816         (get_gtkdoc_module_paths): Receive a list of local cross reference
1817         dependencies.
1818         (get_generator_for_config): Set the main_sgml_file property of the
1819         GtkDoc object from the configuration file.
1820         (generate_documentation): Generate the documentation for the given
1821         generator.
1822         (generate_documentation_for_config): Deleted.
1823         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1824         * gtk/webkitdom.py:
1825         (write_doc_files): Receive the module name used to build the
1826         -sections.txt filename.
1827
1828 2015-01-26  Commit Queue  <commit-queue@webkit.org>
1829
1830         Unreviewed, rolling out r179107.
1831         https://bugs.webkit.org/show_bug.cgi?id=140880
1832
1833         The GCC in the bots doesn't support the AsyncTask
1834         implementation (Requested by KaL on #webkit).
1835
1836         Reverted changeset:
1837
1838         "[GTK] Enable IndexedDB"
1839         https://bugs.webkit.org/show_bug.cgi?id=98932
1840         http://trac.webkit.org/changeset/179107
1841
1842 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1843
1844         [EFL] Bump libseccomp version to 2.1.1
1845         https://bugs.webkit.org/show_bug.cgi?id=140357
1846
1847         Reviewed by Gyuyoung Kim.
1848
1849         * efl/jhbuild.modules:
1850
1851 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1852
1853         [GTK] Enable IndexedDB
1854         https://bugs.webkit.org/show_bug.cgi?id=98932
1855
1856         Reviewed by Žan Doberšek.
1857
1858         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1859
1860 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
1861
1862         Would like leaks bot results at build.webkit.org/dashboard
1863         https://bugs.webkit.org/show_bug.cgi?id=122657
1864
1865         Reviewed by Darin Adler.
1866
1867         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1868         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1869         than necessary, could use the ones from buildbot in more places.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1872         (BuildbotQueue): Reflect configuration option for leaks queues.
1873
1874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1875         Add leaks queues to performance column. First, leaks are about performance indeed,
1876         and second, this is where we have some space to spare.
1877
1878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1879         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1880         least a year.
1881
1882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1883         (table.queue-grid td): Moved height from queue-view - we can now have more than one
1884         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1885         results - once the results are loaded, all rows are currently higher than that.
1886
1887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1888         (.leaks-popover): Added.
1889
1890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1891         Added.
1892
1893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1894         Load BuildbotLeaksQueueView.js.
1895
1896 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
1897
1898         [Win] Add WebKit message loop interface.
1899         https://bugs.webkit.org/show_bug.cgi?id=140857
1900
1901         Reviewed by Brent Fulgham.
1902
1903         Added message loop interface which will run the message loop,
1904         and perform required tasks (like calling CFRunLoopRunInMode)
1905         on each iteration of the loop.
1906
1907         * WinLauncher/WinMain.cpp:
1908         (wWinMain): Use new message loop interface.
1909
1910 2015-01-24  Dan Bernstein  <mitz@apple.com>
1911
1912         update-webkit’s --internal option is unused
1913         https://bugs.webkit.org/show_bug.cgi?id=140861
1914
1915         Reviewed by Anders Carlsson.
1916
1917         * Scripts/update-webkit: Removed the option.
1918
1919 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
1920
1921         DumpRenderTree needs to run with Windows native controls on Windows
1922         https://bugs.webkit.org/show_bug.cgi?id=25592
1923
1924         Reviewed by Anders Carlsson.
1925
1926         * DumpRenderTree/win/DumpRenderTree.cpp:
1927         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1928         (prepareConsistentTestingEnvironment): Ditto.
1929
1930 2015-01-23  David Kilzer  <ddkilzer@apple.com>
1931
1932         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1933         <http://webkit.org/b/140787>
1934
1935         Reviewed by Daniel Bates.
1936
1937         * Scripts/webkitpy/port/ios.py:
1938         (IOSPort.determine_full_port_name): Instead of checking the type
1939         of the current host, test if /usr/bin/xcrun exists before trying
1940         to use it.
1941
1942 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
1943
1944         Fix the false positive build failures on the Windows buildbots
1945         https://bugs.webkit.org/show_bug.cgi?id=140819
1946
1947         Reviewed by Brent Fulgham.
1948
1949         Increase the build timeout (without producing output) to 2 hours for Windows bots,
1950         the default 20 minutes is enough for others since they produce output during the build.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1953         (BuildFactory.__init__):
1954
1955 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1956
1957         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1958         https://bugs.webkit.org/show_bug.cgi?id=140839
1959
1960         Reviewed by Dean Jackson.
1961
1962         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1963         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1964         from the IA2Locale structure and pass it to DRT.
1965
1966 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1967
1968         [Win] Update DRT Accessibility implementation to better match Mac.
1969         https://bugs.webkit.org/show_bug.cgi?id=140830
1970
1971         Reviewed by Dean Jackson.
1972
1973         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1974         (AccessibilityUIElement::titleUIElement):
1975         (AccessibilityUIElement::parentElement):
1976         (convertToDRTLabel):
1977         (AccessibilityUIElement::role):
1978         (AccessibilityUIElement::title):
1979         (AccessibilityUIElement::description):
1980         (AccessibilityUIElement::stringValue):
1981         (AccessibilityUIElement::helpText):
1982         (AccessibilityUIElement::isFocused):
1983
1984 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
1985
1986         REGRESSION: run-perf-tests --profiler= seems to have broken
1987         https://bugs.webkit.org/show_bug.cgi?id=113528
1988
1989         Reviewed by Daniel Bates.
1990
1991         The problem is that "perf --record" (or the equivalent call for
1992         other profilers) is never called whenever there is a wrapper
1993         option in the port. We should inject the profiler call first
1994         (should it exists) and then use the port wrapper.
1995
1996         * Scripts/webkitpy/port/driver.py:
1997         (Driver._command_wrapper):
1998         * Scripts/webkitpy/port/driver_unittest.py:
1999         (DriverTest.test_profiler_and_wrapper): New unit test.
2000
2001 2015-01-22  David Kilzer  <ddkilzer@apple.com>
2002
2003         configure-xcode-for-ios-development needs to import webkitdirs.pm
2004         <http://webkit.org/b/140704>
2005
2006         Fixes the following runtime error:
2007
2008             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
2009
2010         * Scripts/configure-xcode-for-ios-development: Add back code to
2011         import webkitdirs.pm for the exitStatus() method.  Not sure why
2012         I removed it before patch review.
2013
2014 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
2015
2016         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
2017         https://bugs.webkit.org/show_bug.cgi?id=140795
2018
2019         Reviewed by Jon Honeycutt.
2020
2021         * BuildSlaveSupport/build.webkit.org-config/config.json:
2022         r178847 accidentally remove the scheduler for this bot. Re-add it to the
2023         Yosemite scheduler.
2024
2025 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
2026
2027         [Win] Expose missing editing features through WebView interface
2028         https://bugs.webkit.org/show_bug.cgi?id=140773
2029         <rdar://problem/19565421>
2030
2031         Reviewed by Dean Jackson.
2032
2033         Connect the various WebView editing delegate methods to our
2034         test infrastructure. Also prefer _bstr_t to raw BSTR types
2035         to simplify life cycle management.
2036
2037         * DumpRenderTree/win/DumpRenderTree.cpp:
2038         (resetWebViewToConsistentStateBeforeTesting):
2039         * DumpRenderTree/win/EditingDelegate.cpp:
2040         (EditingDelegate::QueryInterface):
2041         (dumpPath):
2042         (dump):
2043         (EditingDelegate::shouldBeginEditingInDOMRange):
2044         (EditingDelegate::shouldEndEditingInDOMRange):
2045         (EditingDelegate::shouldInsertNode):
2046         (EditingDelegate::shouldInsertText):
2047         (EditingDelegate::shouldDeleteDOMRange):
2048         (EditingDelegate::shouldChangeSelectedDOMRange):
2049         (EditingDelegate::shouldApplyStyle):
2050         (EditingDelegate::shouldChangeTypingStyle):
2051         (EditingDelegate::doPlatformCommand):
2052         (EditingDelegate::webViewDidBeginEditing):
2053         (EditingDelegate::webViewDidChange):
2054         (EditingDelegate::webViewDidEndEditing):
2055         (EditingDelegate::webViewDidChangeTypingStyle):
2056         (EditingDelegate::webViewDidChangeSelection):
2057         (EditingDelegate::checkSpellingOfString):
2058         (EditingDelegate::onNotify):
2059         * DumpRenderTree/win/EditingDelegate.h:
2060
2061 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2062
2063         Add a build flag for ES6 class syntax
2064         https://bugs.webkit.org/show_bug.cgi?id=140760
2065
2066         Reviewed by Michael Saboff.
2067
2068         * Scripts/webkitperl/FeatureList.pm:
2069
2070 2015-01-22  Daniel Bates  <dabates@apple.com>
2071
2072         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
2073         runtime in simctl output
2074         https://bugs.webkit.org/show_bug.cgi?id=140751
2075
2076         Reviewed by David Kilzer.
2077
2078         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
2079         with an error because it does not know how to parse the output of the simctl tool
2080         to identify an Apple Internal runtime.
2081
2082         * Scripts/webkitpy/xcode/simulator.py:
2083         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
2084         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
2085         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
2086         the runtime is an internal runtime.
2087         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
2088         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
2089         appropriate value.
2090         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
2091         it updates the appropriate Runtime object.
2092         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
2093         looking up a Runtime object for an internal runtime.
2094
2095 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
2096
2097         LeaksViewer doesn't show recent builds if there are less than 10
2098         https://bugs.webkit.org/show_bug.cgi?id=140716
2099
2100         Reviewed by Tim Horton.
2101
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2103
2104 2015-01-22  Lucas Forschler  <lforschler@apple.com>
2105
2106         Add Apple build slaves.
2107         Fixed text alignment for slave list.
2108         
2109         Unreviewed.
2110         
2111         * BuildSlaveSupport/build.webkit.org-config/config.json:
2112
2113 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2114
2115         Teach build.webkit.org about bot308 and bot309.
2116         
2117         Unreviewed.
2118         
2119         * BuildSlaveSupport/build.webkit.org-config/config.json:
2120
2121 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2122
2123         Add two Apple Mavericks slaves.
2124         
2125         Unreviewed.
2126         
2127         * BuildSlaveSupport/build.webkit.org-config/config.json:
2128
2129 2015-01-21  Daniel Bates  <dabates@apple.com>
2130
2131         Add iOS WebKit1 TestExpectation file
2132         https://bugs.webkit.org/show_bug.cgi?id=140739
2133
2134         Reviewed by David Kilzer.
2135
2136         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
2137         expectations in directory LayoutTests/platform/ios-simulator-wk1.
2138
2139         * Scripts/webkitpy/port/ios.py:
2140         (IOSSimulatorPort.default_baseline_search_path):
2141
2142 2015-01-21  David Kilzer  <ddkilzer@apple.com>
2143
2144         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
2145         <http://webkit.org/b/140704>
2146
2147         Reviewed by Daniel Bates.
2148
2149         * Scripts/configure-xcode-for-ios-development:
2150         - Update copyright.
2151         - Remove FIXME addressed by r178709.
2152         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2153         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2154         missing headers from iphonesimulator SDK to iphoneos SDK.
2155         (sdkDirectory): Add method that returns SDK directory.
2156         (sdkPlatformDirectory): Extract method from
2157         xcodeSDKSpecificationsPath() that returns SDK platform
2158         directory.
2159         (xcodeSDKSpecificationsPath): Update to use
2160         sdkPlatformDirectory().
2161
2162 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
2163
2164         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2165         https://bugs.webkit.org/show_bug.cgi?id=140731
2166
2167         Reviewed by Tim Horton.
2168
2169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2170         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2171
2172 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2173
2174         [Win] eventSender does not support scalePageBy
2175         https://bugs.webkit.org/show_bug.cgi?id=140726
2176         <rdar://problem/19549865>
2177
2178         Reviewed by Dean Jackson.
2179
2180         * DumpRenderTree/win/EventSender.cpp:
2181         (scalePageByCallback): Provide implementation using new WebView method.
2182
2183 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2184
2185         Remove Apple Mountain Lion Build & Test slaves.
2186         
2187         Unreviewed.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/config.json:
2190
2191 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2192
2193         Remove ENABLE(INSPECTOR) ifdef guards
2194         https://bugs.webkit.org/show_bug.cgi?id=140668
2195
2196         Reviewed by Darin Adler.
2197
2198         * DumpRenderTree/mac/TestRunnerMac.mm:
2199         (TestRunner::showWebInspector):
2200         (TestRunner::closeWebInspector):
2201         (TestRunner::evaluateInWebInspector):
2202         * Scripts/webkitperl/FeatureList.pm:
2203         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2204         (WTR::TestRunner::showWebInspector):
2205         (WTR::TestRunner::closeWebInspector):
2206         (WTR::TestRunner::evaluateInWebInspector):
2207         * WebKitTestRunner/TestInvocation.cpp:
2208         (WTR::TestInvocation::invoke):
2209
2210 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2211
2212         Update build.webkit.org/dashboard to match current Mac queues.
2213
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2221         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2222         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2223
2224 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2225
2226         Update Apple MountainLion Leaks slave to Yosemite
2227         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2228         
2229         Unreviewed.
2230
2231         * BuildSlaveSupport/build.webkit.org-config/config.json:
2232
2233 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2234
2235         Update LeaksViewer from MountainLion to Yosemite
2236         
2237         Reviewed by Alexey Proskuryakov.
2238
2239         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2240         (LeaksViewer._displayURLPrompt):
2241
2242 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2243
2244         Fix EWS python unit tests and address code comments as per 140476
2245         https://bugs.webkit.org/show_bug.cgi?id=140637
2246
2247         Reviewed by David Kilzer.
2248
2249         * Scripts/webkitpy/port/base.py:
2250         (Port):
2251         (Port.__init__):
2252         Adds DEFAULT_ARCHITECTURE member.
2253         (Port.architecture):
2254         Removes architecture member and instead uses
2255         self.get_option('architecture'). Also removes redundant architecture
2256         method.
2257         (Port.set_architecture):
2258         Adds a setter for the architecture variable to be able to set a flag
2259         upon modification.
2260         (Port.test_configuration):
2261         Uses self.architecture() instead of self._architecture.
2262         * Scripts/webkitpy/port/ios.py:
2263         Overrides DEFAULT_ARCHITECTURE.
2264         (IOSPort):
2265         (IOSPort.determine_full_port_name):
2266         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2267         strip. Fixes regex to not match arbitrary characters after the
2268         relevent digits are matched.
2269         (IOSPort.__init__):
2270         Removes old _architecture defaulting strategy.
2271         (IOSPort._build_driver_flags):
2272         Uses self.architecture() instead of self._architecture.
2273         (IOSSimulatorPort):
2274         Overrides DEFAULT_ARCHITECTURE.
2275         (IOSSimulatorPort.__init__):
2276         Removes old _architecture defaulting strategy.
2277         * Scripts/webkitpy/port/mac.py:
2278         (MacPort):
2279         Overrides DEFAULT_ARCHITECTURE.
2280         (MacPort.__init__):
2281         Removes old _architecture defaulting strategy.
2282         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2283         (AbstractEarlyWarningSystem.run_command):
2284         Checks the did_override_architecture flag to determine whether to add
2285         the --architecture option.
2286         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2287         Uses ews.architecture rather than trying to discern the correct
2288         architecture using a port object.
2289         (EarlyWarningSystemTest._default_expected_logs):
2290         * Scripts/webkitpy/tool/commands/queues.py:
2291         Removes use of optparse, and removes the import statement.
2292         (AbstractQueue.__init__):
2293         (PatchProcessingQueue.begin_work_queue):
2294
2295 2015-01-20  Sam Weinig  <sam@webkit.org>
2296
2297         Attempt to fix Mountain Lion and EFL tests.
2298
2299         * WebKitTestRunner/TestController.cpp:
2300         (WTR::TestController::initialize):
2301         Disable Process-per-tab and network process on Mountain Lion and EFL.
2302
2303 2015-01-20  Darin Adler  <darin@apple.com>
2304
2305         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2306         https://bugs.webkit.org/show_bug.cgi?id=140679
2307
2308         Reviewed by Anders Carlsson.
2309
2310         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2311         Removed a reference to SVGElementInstanceList.
2312
2313 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2314
2315         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2316         https://bugs.webkit.org/show_bug.cgi?id=140028
2317
2318         Reviewed by Carlos Garcia Campos.
2319
2320         This won't work as expected, since this function is called before the
2321         WebViewTest constructor completes.
2322
2323         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2324
2325 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2326
2327         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2328         <http://webkit.org/b/140661>
2329
2330         Reviewed by Daniel Bates.
2331
2332         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2333         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2334         "iphoneos" and "iphonesimulator" SDKs.
2335         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2336         the main body of the script.
2337
2338 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2339
2340         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2341         https://bugs.webkit.org/show_bug.cgi?id=139443
2342
2343         Reviewed by Carlos Garcia Campos.
2344
2345         Create the new test cases for setting the editable property on the web
2346         view and on the contenteditable enabled document. Also rework the
2347         current tests that are expecting that the web view is editable.
2348
2349         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2350         (loadTestHtml):
2351         (testWebViewEditorCutCopyPasteNonEditable):
2352         (testWebViewEditorCutCopyPasteEditable):
2353         (testWebViewEditorSelectAllNonEditable):
2354         (testWebViewEditorSelectAllEditable):
2355         (runEditorEditableCutTests):
2356         (testWebViewEditorEditableOnNonEditable):
2357         (testWebViewEditorEditableOnContentEditable):
2358         (testWebViewEditorNonEditable):
2359         (beforeAll):
2360         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2361         (WebViewTest::isEditable):
2362         (WebViewTest::setEditable):
2363
2364 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2365
2366         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2367         https://bugs.webkit.org/show_bug.cgi?id=140617
2368
2369         Reviewed by Gustavo Noronha Silva.
2370
2371         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2372         (testWebViewSnapshot): Check that the same snapshot with
2373         transparent background is different than the default one filled
2374         with white.
2375
2376 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2377
2378         [GTK] Add API to change the WebKitWebView background color
2379         https://bugs.webkit.org/show_bug.cgi?id=140610
2380
2381         Reviewed by Gustavo Noronha Silva.
2382
2383         Add --bg-color command line option to MiniBrowser to be able to
2384         manually test the API passing any RGBA color to MiniBrowser.
2385         Also add a simple unit test to check that getting and setting
2386         colors from the API point of view.
2387
2388         * MiniBrowser/gtk/BrowserWindow.c:
2389         (browser_window_set_background_color):
2390         * MiniBrowser/gtk/BrowserWindow.h:
2391         * MiniBrowser/gtk/main.c:
2392         (createBrowserWindow):
2393         (parseBackgroundColor):
2394         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2395         (testWebViewBackgroundColor):
2396         (beforeAll):
2397
2398 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2399
2400         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2401         https://bugs.webkit.org/show_bug.cgi?id=140665
2402
2403         Reviewed by Brian Burg.
2404
2405         * DumpRenderTree/win/UIDelegate.cpp:
2406         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2407         match expected test output.
2408
2409 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2410
2411         Remove the support for custom suffixes on ChangeLog
2412         https://bugs.webkit.org/show_bug.cgi?id=140648
2413
2414         Reviewed by David Kilzer.
2415
2416         Custom suffixes were used for the iOS branch of WebKit.
2417         Now that everything is opensource, there is no need for it.
2418
2419         * Scripts/VCSUtils.pm:
2420         (changeLogSuffix): Deleted.
2421         (changeLogFileName): Deleted.
2422         * Scripts/commit-log-editor:
2423         * Scripts/prepare-ChangeLog:
2424         (getLatestChangeLogs):
2425         (generateNewChangeLogs):
2426         (generateFileList):
2427         * Scripts/resolve-ChangeLogs:
2428         (findChangeLog):
2429
2430 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2431
2432         Adjust naming of action menu SPI
2433         https://bugs.webkit.org/show_bug.cgi?id=140644
2434         <rdar://problem/19448129>
2435
2436         Reviewed by Brian Weinstein.
2437
2438         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2439         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2440         (TestWebKitAPI::TEST):
2441
2442 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2443
2444         [GTK] Generate the make dist manifest from a CMake template file
2445         https://bugs.webkit.org/show_bug.cgi?id=139387
2446
2447         Reviewed by Martin Robinson.
2448
2449         Remove the code that performs variable substitution on manifest.txt.
2450         Replace the custom variables used in that file with CMake variables.
2451
2452         * gtk/make-dist.py:
2453         (Manifest.add_directory):
2454         (Manifest.get_full_source_path):
2455         (Manifest.process_line):
2456         (Manifest.resolve_variables): Deleted.
2457         (Manifest.get_full_tarball_path): Deleted.
2458         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2459
2460 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2461
2462         [Win] Correct merge error in last commit.
2463
2464         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2465         (findAccessibleObjectById): Undo accidental paste made during landing.
2466
2467 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2468
2469         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2470         https://bugs.webkit.org/show_bug.cgi?id=139906
2471
2472         Reviewed by Dean Jackson.
2473
2474         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2475         to use them. This patch fixes that.
2476
2477         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2478         (findAccessibleObjectById):
2479         (AccessibilityController::focusedElement):
2480         (logEventProc):
2481         (notificationListenerProc):
2482         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2483         (AccessibilityUIElement::getChildAtIndex):
2484         (AccessibilityUIElement::titleUIElement):
2485         (self):
2486         (AccessibilityUIElement::role):
2487         (AccessibilityUIElement::valueDescription):
2488         (accessibilityState):
2489         (AccessibilityUIElement::isChecked):
2490         * DumpRenderTree/win/DumpRenderTree.cpp:
2491         (dumpFrameScrollPosition):
2492         (dumpFramesAsText):
2493         * DumpRenderTree/win/PolicyDelegate.cpp:
2494         (PolicyDelegate::decidePolicyForNavigationAction):
2495         * DumpRenderTree/win/UIDelegate.cpp:
2496         (UIDelegate::exceededDatabaseQuota):
2497         * WinLauncher/Common.cpp:
2498         (setWindowText):
2499
2500 2015-01-19  Dean Jackson  <dino@apple.com>
2501
2502         Add "override" to fix the build with newer clangs.
2503
2504         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2505         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2506
2507 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2508
2509         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2510         <http://webkit.org/b/140623>
2511
2512         Reviewed by Daniel Bates.
2513
2514         * Scripts/build-webkit: Update help for --device switch.
2515         * Scripts/webkitdirs.pm:
2516         (determineXcodeSDK): When passing --device, prefer the internal
2517         iOS SDK if it exists, else fall back to the external iOS SDK.
2518         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2519         xcodebuild instead of trying to sanitize values.
2520
2521 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2522
2523         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2524         https://bugs.webkit.org/show_bug.cgi?id=140606
2525
2526         Reviewed by Csaba Osztrogonác.
2527
2528         * Scripts/webkitpy/bindings/main.py:
2529         (BindingsTests.generate_supplemental_dependency):
2530         (BindingsTests.main):
2531
2532 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2533
2534         [GTK] [WK2] TestWebKitWebView snapshot fails
2535         https://bugs.webkit.org/show_bug.cgi?id=120404
2536
2537         Reviewed by Žan Doberšek.
2538
2539         Rework the test to make sure the snapshot is always created at the
2540         desired size.
2541
2542         * Scripts/run-gtk-tests:
2543         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2544         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2545         (testWebViewSnapshot): Use a fixed size for the document, and
2546         disable scrollbars to make sure the visible area is always the
2547         WebView size.
2548         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2549         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2550         and height parameters to create the window with a given size.
2551         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2552
2553 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2554
2555         iOS EWS queue name should be consistent
2556         <http://webkit.org/b/140585>
2557
2558         Reviewed by Daniel Bates.
2559
2560         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2561         to 'ios'.
2562         * Scripts/webkitpy/common/config/ports.py: Ditto.
2563         (DeprecatedPort.port):
2564         (IOSPort):
2565         * Scripts/webkitpy/port/ios.py: Ditto.
2566         (IOSPort):
2567
2568         * Scripts/webkitpy/port/factory.py:
2569         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2570         appears before ios.IOSPort.  If this is not done,
2571         `run-webkit-tests --ios-simulator` will get the wrong Port class
2572         (IOSPort instead of IOSSimulatorPort) due to the way that
2573         PortFactory.get() uses prefix matching of <Port>.port_name to
2574         find the correct class to use.
2575
2576 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2577
2578         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2579         https://bugs.webkit.org/show_bug.cgi?id=140595
2580
2581         Reviewed by Csaba Osztrogonác.
2582
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2584         (BubbleQueueServer):
2585
2586 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2587
2588         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2589
2590         * Scripts/webkitpy/port/ios.py:
2591         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2592         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2593         the Mountain Lion and Mavericks bots.
2594
2595 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2596
2597         Attempt to fix webkitpy tests on GTK Linux ports
2598
2599         * Scripts/webkitpy/port/ios.py:
2600         (IOSPort.determine_full_port_name): Set a sensible default if
2601         not running on a Mac platform or if no iOS SDK is installed.
2602
2603 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2604
2605         Create iOS-EWS client queue
2606         https://bugs.webkit.org/show_bug.cgi?id=140476
2607
2608         Reviewed by Alexey Proskuryakov.
2609
2610         * EWSTools/start-queue-mac.sh:
2611         Adds call to configure-xcode-for-ios-development for iOS EWS.
2612         * Scripts/webkitpy/common/config/ews.json:
2613         Adds the iOS EWS config entry.
2614         * Scripts/webkitpy/common/config/ports.py:
2615         (DeprecatedPort.port):
2616         Adds IOSPort to the port map.
2617         (IOSPort):
2618         (IOSPort.build_webkit_command):
2619         Adds --sdk=iphoneos to the webkit build command.
2620         * Scripts/webkitpy/port/base.py:
2621         (Port.architecture):
2622         Adds an accessor for the architecture member variable.
2623         * Scripts/webkitpy/port/factory.py:
2624         (PortFactory):
2625         Adds IOSPort to the port class list.
2626         * Scripts/webkitpy/port/ios.py:
2627         Adds the IOSPort to encapsulate iOS-specific things.
2628         (IOSPort):
2629         (IOSPort.determine_full_port_name):
2630         (IOSPort.__init__):
2631         (IOSPort._build_driver_flags):
2632         (IOSPort.operating_system):
2633         * Scripts/webkitpy/tool/commands/download_unittest.py:
2634         Adds the archetecture option to the mock options.
2635         (DownloadCommandsTest._default_options):
2636         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2637         Appends the archetecture option into calls to webkit-patch.
2638         (AbstractEarlyWarningSystem.review_patch):
2639         (AbstractEarlyWarningSystem.run_command):
2640         (AbstractEarlyWarningSystem.load_ews_classes):
2641         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2642         Adds logic to soothe the unittest now that --architecture is being
2643         thrown around everywhere.
2644         (EarlyWarningSystemTest._default_expected_logs):
2645         * Scripts/webkitpy/tool/commands/queues.py:
2646         Adds glue code to ferry the --architecture option around.
2647         (AbstractQueue.__init__):
2648         (PatchProcessingQueue.begin_work_queue):
2649         * Scripts/webkitpy/tool/steps/abstractstep.py:
2650         Adds the archetecture option to all AbstractSteps so that
2651         EarlyWarningSystem doesn't start shoving --architecture into
2652         unsuspecting commands.
2653         (AbstractStep.options):
2654         * Scripts/webkitpy/tool/steps/build.py:
2655         Translates the --architecture option into an ARCHS= format to pass to
2656         build-webkit.
2657         (Build.build):
2658         * Scripts/webkitpy/tool/steps/options.py:
2659         Adds a definition for the --architecture option.
2660         (Options):
2661
2662 2015-01-16  Sam Weinig  <sam@webkit.org>
2663
2664         Add a basic configuration object for WKView
2665         https://bugs.webkit.org/show_bug.cgi?id=140559
2666
2667         Reviewed by Anders Carlsson.
2668
2669         Add tests for WKPageConfigurationRef.
2670
2671         * TestWebKitAPI/PlatformWebView.h:
2672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2673         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
2674         (TestWebKitAPI::TEST):
2675         (TestWebKitAPI::didFinishLoadForFrame):
2676         (TestWebKitAPI::setPageLoaderClient):
2677         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2678         (TestWebKitAPI::PlatformWebView::initialize):
2679         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2680
2681 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2682
2683         WeakPtr functions crash when created with default constructor
2684         https://bugs.webkit.org/show_bug.cgi?id=140479
2685
2686         Reviewed by Andreas Kling.
2687
2688         Add WeakPtr API tests.
2689
2690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2691         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
2692         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
2693
2694 2015-01-16  Chris Dumez  <cdumez@apple.com>
2695
2696         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
2697         https://bugs.webkit.org/show_bug.cgi?id=140568
2698
2699         Reviewed by Alexey Proskuryakov.
2700
2701         Fix the script parsing CSSPropertyNames.in to stop splitting lines
2702         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
2703         e.g. "Longhands=background-position-x|background-position-y".
2704         This would confuse the script and treat this as a CSS property:
2705         "background-position-x|background-position-y".
2706
2707         We now split on white space and treat the first string on the line
2708         to be the property name (this is the syntax in this file).
2709
2710         * Scripts/webkitpy/w3c/test_converter.py:
2711         (_W3CTestConverter.__init__):
2712         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2713
2714 2015-01-16  Daniel Bates  <dabates@apple.com>
2715
2716         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
2717         https://bugs.webkit.org/show_bug.cgi?id=135589
2718
2719         Reviewed by David Kilzer.
2720
2721         Derived from a patch by David Farler.
2722
2723         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
2724         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
2725         in terms of the simctl command line utility.
2726
2727         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
2728         (eraseIOSSimulatorDevice): Added.
2729         (bootedIOSSimulatorDevice): Added.
2730         (iosSimulatorApplicationsPath): Added.
2731         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
2732         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
2733         (quitIOSSimulator): Added.
2734         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
2735         the specified name and currently selected iOS runtime.
2736         (isIOSSimulatorSystemInstalledApp): Added.
2737         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
2738         (deleteiOSSimulatorDevice): Deleted.
2739         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
2740         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
2741
2742 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
2743
2744         Resurrect the WinCairo bot.
2745         https://bugs.webkit.org/show_bug.cgi?id=139908
2746
2747         Reviewed by Csaba Osztrogonác.
2748
2749         * BuildSlaveSupport/build.webkit.org-config/config.json:
2750         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2751         (appendCustomBuildFlags):
2752         * BuildSlaveSupport/test-result-archive:
2753         (archiveTestResults):
2754         Add WinCairo buildbot.
2755
2756 2015-01-16  Chris Dumez  <cdumez@apple.com>
2757
2758         webkit-patch should auto-install the keyring python module
2759         https://bugs.webkit.org/show_bug.cgi?id=140547
2760
2761         Reviewed by David Kilzer.
2762
2763         Auto-install the keyring python module. This is the module that
2764         webkit-patch uses for cross-platform access to the keyring
2765         service.
2766
2767         Without this module, if the password if not in the keychain,
2768         webkit-patch will keep asking for your username / password and
2769         never remember them.
2770
2771         * Scripts/webkitpy/common/net/credentials.py:
2772         * Scripts/webkitpy/thirdparty/__init__.py:
2773         (AutoinstallImportHook.find_module):
2774         (AutoinstallImportHook._install_keyring):
2775
2776 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2777
2778         Remove ENABLE(SQL_DATABASE) guards
2779         https://bugs.webkit.org/show_bug.cgi?id=140434
2780
2781         Reviewed by Darin Adler.
2782
2783         * Scripts/webkitperl/FeatureList.pm:
2784
2785 2015-01-15  Daniel Bates  <dabates@apple.com>
2786
2787         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2788         https://bugs.webkit.org/show_bug.cgi?id=139685
2789         <rdar://problem/19281317>
2790
2791         Reviewed by Simon Fraser.
2792
2793         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2794         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2795
2796         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2797         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2798         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2799         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2800         dumping the test result again. Instead we want DRT to dump the test result synchronously
2801         such that we capture the state of the web page either when the page is loaded or when
2802         window.testRunner.notifyDone() is called.
2803
2804         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2805         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2806         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2807         flush CA transactions to the window.
2808         * DumpRenderTree/mac/DumpRenderTree.mm:
2809         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2810         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2811         (dump): Renamed; formerly named dumpTestResults().
2812         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2813         enabling repaint support on iOS.
2814         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2815         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2816         (dumpTestResults): Deleted.
2817
2818 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
2819
2820         [Win] Miscellaneous DRT fixes
2821         https://bugs.webkit.org/show_bug.cgi?id=116562
2822
2823         Reviewed by Tim Horton.
2824
2825         While investigating the cause of several Windows crashes, I found:
2826         (1) Messy conversions to and from BSTR types
2827         (2) Weird mixes of wide-string and narrow string conversions
2828         (3) Passing nullptr to some CoreFoundation routines that do not
2829             permit null arguments.
2830         (4) Commands to link the executable to the VS2005 runtime.
2831
2832         This patch cleans up these issues to improve DRT reliability on
2833         Windows.
2834
2835         * DumpRenderTree/cg/ImageDiffCG.cpp:
2836         (main): Get rid of VS2005 runtime linking.
2837         * DumpRenderTree/win/DumpRenderTree.cpp:
2838         (urlSuitableForTestResult): Protect against being asked
2839         to process an empty URL.
2840         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2841         than converting to/from wchar_t buffers.
2842         (runTest): Simplify string and BSTR handling.
2843         (createWebViewAndOffscreenWindow): Ditto.
2844         (main): Get rid of VS2005 runtime linking.
2845         * DumpRenderTree/win/TestRunnerWin.cpp:
2846         (jsStringRefToWString): Simplify code.
2847         (TestRunner::pathToLocalResource):
2848         (TestRunner::setUserStyleSheetLocation):
2849         * TestWebKitAPI/win/main.cpp: Get rid of
2850         VS2005 runtime linking.
2851         * win/DLLLauncher/DLLLauncherMain.cpp:
2852         (wWinMain): Ditto.
2853
2854 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
2855
2856         Stop hardcoding mac-mountainlion in commit queue
2857         https://bugs.webkit.org/show_bug.cgi?id=140492
2858
2859         Reviewed by Anders Carlsson.
2860
2861         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2862         there should be no change in behavior, because:
2863         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2864         using it to create a port object.
2865         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2866         is actually correct to use "mac" for the name there. We only used to get the expected
2867         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2868         for unknown deprecated port names.
2869
2870         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2871
2872 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
2873
2874         Create iOS-EWS server queue
2875         https://bugs.webkit.org/show_bug.cgi?id=140473
2876
2877         Reviewed by Benjamin Poulain.
2878
2879         * QueueStatusServer/app.yaml: Updates the SVN version number.
2880         * QueueStatusServer/config/queues.py: Add ios-ews queue.
2881         * QueueStatusServer/model/queues.py:         
2882         (Queue.display_name): Makes sure the display name is pretty!
2883
2884 2015-01-14  Daniel Bates  <dabates@apple.com>
2885
2886         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2887         https://bugs.webkit.org/show_bug.cgi?id=140301
2888         <rdar://problem/19389266>
2889
2890         Reviewed by Jon Honeycutt.
2891
2892         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2893         with an unavailable runtime.
2894
2895         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2896         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2897         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2898         specified runtime cannot be used because it is unavailable.
2899         * Scripts/webkitpy/port/ios.py:
2900         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2901         which was formerly named testing_device.
2902         * Scripts/webkitpy/xcode/simulator.py:
2903         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2904         more robust than looking up the simulator device by name and runtime. This approach also
2905         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2906         unavailable runtimes under the same iOS heading it would use to show it as available).
2907         (Simulator.find_device_by_udid): Added.
2908         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2909         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2910         (Simulator.available_runtimes): Added.
2911         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2912         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2913         first element of the sorted list is the runtime with the highest version number.
2914         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2915
2916 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
2917
2918         Remove WK2 Windows cruft
2919         https://bugs.webkit.org/show_bug.cgi?id=140440
2920
2921         Reviewed by Anders Carlsson.
2922
2923         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2924         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2925         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2926
2927 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
2928
2929         Fix TestWTF failed in TestWebKitAPI
2930         https://bugs.webkit.org/show_bug.cgi?id=140333
2931
2932         Reviewed by Sam Weinig.
2933
2934         Clear the std::ostringstream before starting test.
2935
2936         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2937         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2938
2939 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2940
2941         TestWebKitWebContext depends on British English spellcheck dictionary
2942         https://bugs.webkit.org/show_bug.cgi?id=140403
2943
2944         Reviewed by Martin Robinson.
2945
2946         Install all English hunspell dictionaries on Fedora and Arch.
2947
2948         * gtk/install-dependencies:
2949
2950 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2951
2952         [GTK] install-dependencies should grok dnf
2953         https://bugs.webkit.org/show_bug.cgi?id=140396
2954
2955         Reviewed by Martin Robinson.
2956
2957         Fedora: install dependencies with dnf if yum is not installed.
2958
2959         * gtk/install-dependencies:
2960
2961 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
2962
2963         [EFL][GTK] Fix build after r178309  
2964         https://bugs.webkit.org/show_bug.cgi?id=140381
2965
2966         Reviewed by Gyuyoung Kim.
2967
2968         * TestWebKitAPI/CMakeLists.txt: Added the API directory
2969
2970 2015-01-11  Sam Weinig  <sam@webkit.org>
2971
2972         Remove support for SharedWorkers
2973         https://bugs.webkit.org/show_bug.cgi?id=140344
2974
2975         Reviewed by Anders Carlsson.
2976
2977         * Scripts/webkitperl/FeatureList.pm:
2978
2979 2015-01-12  Anders Carlsson  <andersca@apple.com>
2980
2981         Make delegates conform to formal delegate protocols
2982         https://bugs.webkit.org/show_bug.cgi?id=140370
2983
2984         Reviewed by Dan Bernstein.
2985
2986         * DumpRenderTree/mac/TestRunnerMac.mm:
2987         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2988         (TestRunner::setGeolocationPermission):
2989
2990 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2991
2992         build-webkit: silence output of 'which'
2993         https://bugs.webkit.org/show_bug.cgi?id=140278
2994
2995         Reviewed by Daniel Bates.
2996
2997         Use a more elegent test for the existance of ninja and eclipse.
2998
2999         * Scripts/webkitdirs.pm:
3000         (commandExists): Don't assume the command supports --version
3001         (canUseNinja): Use commandExists()
3002         (canUseEclipse): Use commandExists()
3003
3004 2015-01-09  Sam Weinig  <sam@webkit.org>
3005
3006         Update the output format for run-api-tests
3007         https://bugs.webkit.org/show_bug.cgi?id=140332
3008
3009         Reviewed by Dan Bernstein.
3010
3011         Changes the output format for run-api-tests be a bit simpler (no longer 
3012         indented based on suite, as we were not really using suite very well) but
3013         also include details in the case of failure.
3014
3015         Changes verbose mode to no longer spew out the gtest default printer output,
3016         as the custom printer now includes the failure information.
3017
3018         * Scripts/run-api-tests:
3019         (runTestsBySuite):
3020         (runTest):
3021         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
3022         with colorized variants and strip out leaks spew (the leaks can be added back using
3023         the new --show-leaks argument).
3024
3025         * TestWebKitAPI/TestsController.cpp:
3026         (TestWebKitAPI::Printer::OnTestPartResult):
3027         (TestWebKitAPI::Printer::OnTestEnd):
3028         (TestWebKitAPI::TestsController::run):
3029         Implement a custom result printer that just prints out the information we want.
3030
3031 2015-01-09  Sam Weinig  <sam@webkit.org>
3032
3033         TestWebKitAPI should print out the lists that fail at the end
3034         https://bugs.webkit.org/show_bug.cgi?id=140329
3035
3036         Reviewed by Tim Horton.
3037
3038         * Scripts/run-api-tests:
3039         (runTestsBySuite):
3040         Print out failures and timeouts in all modes, not just verbose.
3041
3042 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
3043
3044         Make bmalloc work with ASan
3045         https://bugs.webkit.org/show_bug.cgi?id=140194
3046
3047         Reviewed by Mark Lam.
3048
3049         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
3050         ASan automatically (by forwarding to system malloc at runtime).
3051
3052 2015-01-09  Daniel Bates  <dabates@apple.com>
3053
3054         [iOS] Make DumpRenderTree build with public SDK
3055         https://bugs.webkit.org/show_bug.cgi?id=140311
3056
3057         Reviewed by Sam Weinig.
3058
3059         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
3060         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
3061         Additionally, remove unused header CoreGraphics/CGFontDB.h.
3062
3063         * DumpRenderTree/mac/DumpRenderTree.mm:
3064         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
3065
3066 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
3067
3068         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
3069         https://bugs.webkit.org/show_bug.cgi?id=140300
3070
3071         Reviewed by Simon Fraser.
3072
3073         * WebKitTestRunner/TestController.cpp:
3074         (WTR::TestController::createOtherPage):
3075         (WTR::TestController::updateWindowScaleForTest):
3076         (WTR::TestController::configureViewForTest):
3077         * WebKitTestRunner/TestController.h:
3078
3079 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3080
3081         Unreviewed. Moving myself to the committer section.
3082
3083         * Scripts/webkitpy/common/config/contributors.json:
3084
3085 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3086
3087         Add a script to check for platform layering violations
3088         https://bugs.webkit.org/show_bug.cgi?id=140248
3089
3090         Reviewed by Darin Adler.
3091
3092         It prints all the cases where files inside platform include
3093         headers that are not in platform directory.
3094
3095         * Scripts/check-for-platform-layering-violations: Added.
3096         (get_platform_headers):
3097         (check_source_file):
3098
3099 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3100
3101         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
3102         https://bugs.webkit.org/show_bug.cgi?id=139884
3103
3104         Reviewed by Tim Horton.
3105
3106         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3107         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
3108         what the "nominal resolution" is, but this appears to work in practice.
3109
3110 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
3111
3112         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
3113         https://bugs.webkit.org/show_bug.cgi?id=140256
3114
3115         Reviewed by Anders Carlsson.
3116
3117         * DumpRenderTree/win/DumpRenderTree.cpp:
3118         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
3119         running with heap validation checks.
3120         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
3121         the "svg\\W3C-SVG-1.1" test directory.
3122         (removeFontFallbackIfPresent): Use nullptr instead of 0.
3123         * DumpRenderTree/win/TestRunnerWin.cpp:
3124         (TestRunner::clearPersistentUserStyleSheet): Ditto.
3125
3126 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3127
3128         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3129         https://bugs.webkit.org/show_bug.cgi?id=140218
3130
3131         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
3132         Undone an accidental change - check for self.has_crashed() again. This code path
3133         is for ports that don't have a signal handler printing #CRASHED when main process
3134         crashes.
3135
3136         * Scripts/webkitpy/port/driver_unittest.py:
3137         (DriverTest.test_check_for_driver_crash.assert_crash):
3138         (DriverTest.test_check_for_driver_crash):
3139         Updated the tests, all changes are expected.
3140
3141 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3142
3143         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3144         https://bugs.webkit.org/show_bug.cgi?id=140218
3145
3146         Reviewed by Darin Adler.
3147
3148         * Scripts/webkitpy/port/driver.py:
3149         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
3150         "process crashed" condition. These don't make sense together - it's either a crash
3151         or a timeout, and we should detect those properly at a much lower level.
3152         (Driver.run_test): Ditto.
3153         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
3154         cases.
3155
3156         * WebKitTestRunner/TestController.h:
3157         * WebKitTestRunner/TestController.cpp:
3158         (WTR::TestController::webProcessName): 
3159         (WTR::TestController::processDidCrash):
3160         Factored out hardcoded child process names, as we now use these in two places.
3161
3162         * WebKitTestRunner/TestInvocation.cpp:
3163         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
3164         process name, so that it can be sampled (fixes sampling on Mavericks and above).
3165
3166 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3167
3168         Reorder my list of email addresses, keeping the Bugzilla address at the
3169         top since Bugzilla and other webkitpy scripts rely on that ordering.
3170
3171         * Scripts/webkitpy/common/config/contributors.json:
3172
3173 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3174
3175         Moving myself to the reviewers section and updating
3176         the list of my email addresses.
3177
3178         * Scripts/webkitpy/common/config/contributors.json:
3179
3180 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3181
3182         [GTK] Build gtk-doc without gtkdoc-mktmpl
3183         https://bugs.webkit.org/show_bug.cgi?id=140225
3184
3185         Reviewed by Darin Adler.
3186
3187         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3188         don't modify the tmpl files that it generates, it's not doing anything
3189         for us.
3190
3191         * gtk/gtkdoc.py:
3192         (GTKDoc.generate):
3193         (GTKDoc._run_gtkdoc_scangobj):
3194         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3195
3196 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
3197
3198         [GTK][ThreadedCompositor] Add support for threaded compositor.
3199         https://bugs.webkit.org/show_bug.cgi?id=118265
3200
3201         Reviewed by Martin Robinson.
3202
3203         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3204         autotools build systems. The feature is disabled by default.
3205         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3206         from the feature flags.
3207
3208         * Scripts/webkitperl/FeatureList.pm:
3209
3210 2015-01-07  Daniel Bates  <dabates@apple.com>
3211
3212         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3213         https://bugs.webkit.org/show_bug.cgi?id=137371
3214
3215         Reviewed by David Kilzer.
3216
3217         Use SPI wrapper headers instead of directly referencing private SPI headers.
3218
3219         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3220         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3221         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3222         to the list of iOS header search directories so that we can include header UIKitSPI.h.
3223         * DumpRenderTree/mac/DumpRenderTree.mm:
3224         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3225         * DumpRenderTree/mac/EventSendingController.mm:
3226         * DumpRenderTree/mac/TestRunnerMac.mm:
3227
3228 2015-01-07  Commit Queue  <commit-queue@webkit.org>
3229
3230         Unreviewed, rolling out r178068.
3231         https://bugs.webkit.org/show_bug.cgi?id=140235
3232
3233         Breaks the iOS build (Requested by enrica on #webkit).
3234
3235         Reverted changeset:
3236
3237         "[iOS] Make WebKit2 build with public iOS SDK and more build
3238         fixes for DRT"
3239         https://bugs.webkit.org/show_bug.cgi?id=137371
3240         http://trac.webkit.org/changeset/178068
3241
3242 2015-01-07  Daniel Bates  <dabates@apple.com>
3243
3244         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3245         https://bugs.webkit.org/show_bug.cgi?id=137371
3246
3247         Reviewed by David Kilzer.
3248
3249         Use SPI wrapper headers instead of directly referencing private SPI headers.
3250
3251         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3252         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3253         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3254         to the list of header search directories so that we can include header UIKitSPI.h.
3255         * DumpRenderTree/mac/DumpRenderTree.mm:
3256         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3257         * DumpRenderTree/mac/EventSendingController.mm:
3258         * DumpRenderTree/mac/TestRunnerMac.mm:
3259
3260 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
3261
3262         [Win] Unreviewed test change to improve run reproducibility
3263
3264         * Scripts/webkitpy/port/win.py:
3265         (WinPort.default_child_processes): Run a single DRT instance to help
3266         identify failures caused by earlier test runs.
3267
3268 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3269
3270         Myles C. Maxfield is a reviewer now
3271         https://bugs.webkit.org/show_bug.cgi?id=140196
3272
3273         Reviewed by Dean Jackson.
3274
3275         * Scripts/webkitpy/common/config/contributors.json:
3276
3277 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3278
3279         Make webkit-patch try harder to find keychain credentials
3280         https://bugs.webkit.org/show_bug.cgi?id=140170
3281
3282         Reviewed by Ryosuke Niwa.
3283
3284         When the user manually enters a password into webkit-patch, we hand that off to the
3285         Keyring Python module. However, that module creates a generic password entry instead
3286         of an internet password entry. We should look for both kinds.
3287
3288         * Scripts/webkitpy/common/net/credentials.py:
3289         (Credentials._run_security_tool):
3290         (Credentials._credentials_from_keychain):
3291         * Scripts/webkitpy/common/net/credentials_unittest.py:
3292         (test_security_output_parse_entry_not_found):
3293         (_assert_security_call):
3294
3295 2015-01-06  Anders Carlsson  <andersca@apple.com>
3296
3297         Try to fix the Mountain Lion build.
3298
3299         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3300         (TestWebKitAPI::didGetImageForMatchResult):
3301
3302 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3303
3304         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3305         https://bugs.webkit.org/show_bug.cgi?id=140095
3306
3307         Reviewed by Anders Carlsson.
3308
3309         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3310         builds, but not in debug ones.
3311
3312 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
3313
3314         [Win] Extend WinLauncher with support for Page Zoom
3315         https://bugs.webkit.org/show_bug.cgi?id=140152
3316
3317         Reviewed by Anders Carlsson.
3318
3319         * WinLauncher/Common.cpp:
3320         (WndProc):
3321         * WinLauncher/WinLauncher.cpp:
3322         (WinLauncher::resetZoom):
3323         (WinLauncher::zoomIn):
3324         (WinLauncher::zoomOut):
3325         * WinLauncher/WinLauncher.h:
3326         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3327         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3328         * win/DLLLauncher/DLLLauncherMain.cpp:
3329         (wWinMain):
3330
3331 2015-01-06  Anders Carlsson  <andersca@apple.com>
3332
3333         Fix API tests that are broken under HiDPI
3334         https://bugs.webkit.org/show_bug.cgi?id=140146
3335
3336         Reviewed by Tim Horton.
3337
3338         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3339         (TestWebKitAPI::didGetImageForMatchResult):
3340         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
3341
3342         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3343         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3344         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
3345         out in a window that has a backing scale factor of 1.
3346  
3347         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3348         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
3349         Ditto.
3350
3351 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3352
3353         ADDRESS_SANITIZER macro is overloaded
3354         https://bugs.webkit.org/show_bug.cgi?id=140130
3355
3356         Reviewed by Anders Carlsson.
3357
3358         * WebKitTestRunner/TestController.cpp: Use the new macro.
3359
3360 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
3361
3362         Remove some stale class names in check-for-inappropriate-objc-class-names
3363         https://bugs.webkit.org/show_bug.cgi?id=140104
3364
3365         Reviewed by Darin Adler.
3366
3367         * Scripts/check-for-inappropriate-objc-class-names:
3368         These UIWK* classes no longer exist.
3369
3370 2015-01-05  Anders Carlsson  <andersca@apple.com>
3371
3372         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
3373         https://bugs.webkit.org/show_bug.cgi?id=140096
3374         rdar://problem/19368938
3375
3376         Reviewed by Alexey Proskuryakov.
3377
3378         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
3379         since clientInfo points to a web view, not the test controller.
3380
3381         * WebKitTestRunner/TestController.cpp:
3382         (WTR::TestController::createOtherPage):
3383
3384 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
3385
3386         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
3387         https://bugs.webkit.org/show_bug.cgi?id=140077
3388
3389         Reviewed by Csaba Osztrogonác.
3390
3391         WebKit C SPI is available on EFL,GTK.
3392         Changed the define order to pass the API test.
3393
3394         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3395         (TestWebKitAPI::TEST):
3396
3397 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
3398
3399         Simplify WebKitTestRunner timeout tracking
3400         https://bugs.webkit.org/show_bug.cgi?id=140036
3401
3402         Reviewed by Darin Adler.
3403
3404         The code for configuring timeouts was mostly dead, because run-webkit-tests never
3405         passes the --timeout option to WebKitTestRunner.
3406
3407         * WebKitTestRunner/Options.h:
3408         * WebKitTestRunner/Options.cpp:
3409         (WTR::Options::Options):
3410         (WTR::OptionsHandler::OptionsHandler):
3411         (WTR::handleOptionTimeout): Deleted.
3412         Removed support for --timeout. Timeouts are passed for each test individually,
3413         and defaults are good enough for the rare cases where WebKitTestRunner is run
3414         manually without run-webkit-tests.
3415
3416         * WebKitTestRunner/TestController.cpp:
3417         (WTR::TestController::TestController):
3418         (WTR::TestController::initialize):
3419         (WTR::TestController::resetStateToConsistentValues):
3420         (WTR::TestController::reattachPageToWebProcess):
3421         (WTR::TestController::runUntil):
3422         * WebKitTestRunner/TestController.h:
3423         Simplified runUntil by passing the actual timeout, not an enum.
3424         Increased short timeout for ASan enabled builds, as WebProcess launching takes
3425         quite a while.
3426
3427         * WebKitTestRunner/TestInvocation.cpp:
3428         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
3429
3430         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3431         (WTR::TestController::platformRunUntil):
3432         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3433         (WTR::TestController::platformRunUntil):
3434         Build fixes.
3435
3436 2015-01-02  Anders Carlsson  <andersca@apple.com>
3437
3438         Remove now unused storage tracker glue from DumpRenderTree
3439         https://bugs.webkit.org/show_bug.cgi?id=140045
3440
3441         Reviewed by Darin Adler.
3442
3443         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3444         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
3445         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
3446         * DumpRenderTree/TestRunner.cpp:
3447         (TestRunner::staticFunctions):
3448         (syncLocalStorageCallback): Deleted.
3449         (observeStorageTrackerNotificationsCallback): Deleted.
3450         (deleteAllLocalStorageCallback): Deleted.
3451         (deleteLocalStorageForOriginCallback): Deleted.
3452         (localStorageDiskUsageForOriginCallback): Deleted.
3453         (originsWithLocalStorageCallback): Deleted.
3454         * DumpRenderTree/TestRunner.h:
3455         * DumpRenderTree/mac/DumpRenderTree.mm:
3456         (allocateGlobalControllers):
3457         (releaseGlobalControllers):
3458         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3459         * DumpRenderTree/mac/TestRunnerMac.mm:
3460         (TestRunner::syncLocalStorage): Deleted.
3461         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3462         (TestRunner::observeStorageTrackerNotifications): Deleted.
3463         (TestRunner::deleteAllLocalStorage): Deleted.
3464         (TestRunner::originsWithLocalStorage): Deleted.
3465         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3466         * DumpRenderTree/win/TestRunnerWin.cpp:
3467         (TestRunner::syncLocalStorage): Deleted.
3468         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3469         (TestRunner::observeStorageTrackerNotifications): Deleted.
3470         (TestRunner::deleteAllLocalStorage): Deleted.
3471         (TestRunner::originsWithLocalStorage): Deleted.
3472         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3473
3474 2015-01-01  Darin Adler  <darin@apple.com>
3475
3476         We often misspell identifier as "identifer"
3477         https://bugs.webkit.org/show_bug.cgi?id=140025
3478
3479         Reviewed by Michael Saboff.
3480
3481         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3482         * Scripts/webkitdirs.pm:
3483         (appIdentifierFromBundle):
3484         (installAndLaunchIOSWebKitAppInSimulator):
3485         Fix misspellings
3486
3487 2015-01-01  Zalan Bujtas  <zalan@apple.com>
3488
3489         Saturated arithmetics: Incorrect float/double clamping.
3490         https://bugs.webkit.org/show_bug.cgi?id=139888
3491         rdar://problem/19330885
3492
3493         Reviewed by Simon Fraser.
3494
3495         Clamp float and double values correctly when applying saturated arithmetics.
3496
3497         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3498         (TestWebKitAPI::TEST):
3499
3500 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
3501
3502         [EFL] Bump version of ATK used by jhbuild to 2.15.2
3503         https://bugs.webkit.org/show_bug.cgi?id=139816
3504
3505         Reviewed by Gyuyoung Kim.
3506
3507         Bump version of ATK used by jhbuild to 2.15.2
3508
3509         * efl/jhbuild.modules:
3510
3511 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
3512
3513         [jhBuild] cairo build error (-flto)
3514         https://bugs.webkit.org/show_bug.cgi?id=139056
3515
3516         Reviewed by Philippe Normand.
3517
3518         cairo fails to link  with gcc 4.9 due to lto
3519         related issue. This problem has been partially
3520         addressed by cairo:
3521         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
3522         use the cairo --disable-lto option and remove jhbuild
3523         makeargs fixes the issue.
3524
3525         * gtk/jhbuild.modules:
3526         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
3527
3528 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
3529         [Mac] Enable kerning, ligatures, and printer fonts 
3530         https://bugs.webkit.org/show_bug.cgi?id=139970
3531
3532         Rubber stamped by Simon Fraser.
3533
3534         Flip the switch.
3535
3536         * DumpRenderTree/mac/DumpRenderTree.mm:
3537         * WebKitTestRunner/TestController.cpp:
3538         * WebKitTestRunner/mac/main.mm:
3539
3540 2014-12-26  Dan Bernstein  <mitz@apple.com>
3541
3542         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
3543         https://bugs.webkit.org/show_bug.cgi?id=139950
3544
3545         Reviewed by David Kilzer.
3546
3547         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
3548         in a manner that works with Xcode 5.1.1.
3549
3550 2014-12-24  Dan Bernstein  <mitz@apple.com>
3551
3552         Engineering builds of MiniBrowser ignore deprecated declaration warnings
3553         https://bugs.webkit.org/show_bug.cgi?id=139941
3554
3555         Reviewed by Darin Adler.
3556
3557         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
3558         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
3559         to YES.
3560         * MiniBrowser/mac/AppDelegate.m:
3561         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
3562         deprecated NSOKButton.
3563
3564 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3565
3566         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
3567         https://bugs.webkit.org/show_bug.cgi?id=134763
3568
3569         Reviewed by Ryosuke Niwa.
3570
3571         Adding an option to disable test harness link conversion.
3572
3573         * Scripts/webkitpy/w3c/test_converter.py:
3574         (convert_for_webkit):
3575         (_W3CTestConverter.__init__):
3576         (_W3CTestConverter.convert_attributes_if_needed):
3577         * Scripts/webkitpy/w3c/test_importer.py:
3578         (parse_args):
3579         (TestImporter.import_tests):
3580
3581 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3582
3583         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
3584         https://bugs.webkit.org/show_bug.cgi?id=139933
3585
3586         Reviewed by Daniel Bates.
3587
3588         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
3589         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
3590         until ReportCrash lets it go.
3591
3592         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
3593         even get the actual crash log eventually - even when it times out waiting for the log, it
3594         makes a second lookup at the very end, after all tests finish. There may be further
3595         improvements needed here, but this small fix addresses most cases that happen in practice.
3596
3597         * DumpRenderTree/mac/DumpRenderTree.mm:
3598         (writeCrashedMessageOnFatalError):
3599         (dumpRenderTree):
3600         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
3601
3602         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
3603         unhelpful comment.
3604
3605 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3606
3607         Don't force -O1 for debug ASan builds
3608         https://bugs.webkit.org/show_bug.cgi?id=139926
3609
3610         Reviewed by Darin Adler.
3611
3612         * asan/asan.xcconfig:
3613
3614 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3615
3616         Simplify building with ASan
3617         https://bugs.webkit.org/show_bug.cgi?id=139916
3618
3619         Reviewed by Mark Rowe.
3620
3621         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
3622         We could also update Configuration file format, but that's a little scary because
3623         of how many places in code read it.
3624
3625         * Scripts/webkitdirs.pm:
3626         (determineASanIsEnabled): Read it from ASan configuration file.
3627         (argumentsForConfiguration): Added a FIXME.
3628         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
3629         (XcodeOptions): Pass the options needed for ASan.
3630
3631         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
3632         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
3633         that automatically.
3634
3635 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3636
3637         TestWebKitAPI build is broken when ASan is enabled
3638         https://bugs.webkit.org/show_bug.cgi?id=139902
3639
3640         Reviewed by Darin Adler.
3641
3642         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3643         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
3644         Inherit linker flags from DebugRelease, which respects ASAN.
3645
3646 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
3647
3648         Sort the Xcode project file.
3649
3650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3651
3652 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3653
3654         Update apple-mac-114 to bot629.
3655