7e0e43170af799e6a9e97e7f393f0ec290010ae4
[WebKit-https.git] / Tools / ChangeLog
1 2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
2
3         [EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
4         https://bugs.webkit.org/show_bug.cgi?id=86117
5
6         Reviewed by Adam Barth.
7
8         Simplify the code used to wrap driver calls with jhbuild: we can
9         just define the 'wrapper' option instead of having to create a
10         Driver class just for that.
11
12         * Scripts/webkitpy/layout_tests/port/efl.py:
13         (EflPort.__init__):
14         (EflPort._port_flag_for_scripts):
15
16 2012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
17
18         Unreviewed, rolling out r116633.
19         http://trac.webkit.org/changeset/116633
20         https://bugs.webkit.org/show_bug.cgi?id=86093
21
22         Breaks EFL tests (Requested by kov on #webkit).
23
24         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
25         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
26         * DumpRenderTree/efl/EventSender.cpp:
27         (keyDownCallback):
28         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
29         (LayoutTestController::setTabKeyCyclesThroughElements):
30
31 2012-05-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
32
33         [EFL] Memory leaks found in EFL DRT
34         https://bugs.webkit.org/show_bug.cgi?id=85889
35
36         Reviewed by Gustavo Noronha Silva.
37
38         Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
39         created with JSStringCreateWithUTF8CString.
40
41         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
42         (DumpRenderTreeChrome::onWindowObjectCleared):
43         * DumpRenderTree/efl/EventSender.cpp:
44         (modifiersFromJSValue):
45
46 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
47
48         [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
49         https://bugs.webkit.org/show_bug.cgi?id=82864
50
51         Reviewed by Gustavo Noronha Silva.
52
53         Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
54         in order to unskip fast/events/keypress-insert-tab.html
55
56         * DumpRenderTree/efl/EventSender.cpp:
57         (keyDownCallback):
58         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
59         (LayoutTestController::setTabKeyCyclesThroughElements):
60
61 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
62
63         [EFL][DRT] EventSender - set delayed event information if it was not set before
64         https://bugs.webkit.org/show_bug.cgi?id=85972
65
66         Reviewed by Gustavo Noronha Silva.
67
68         Reset delayed event information if it is missing.
69
70         * DumpRenderTree/efl/EventSender.cpp:
71         (feedOrQueueMouseEvent):
72
73 2012-05-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
74
75         WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
76         https://bugs.webkit.org/show_bug.cgi?id=85806
77
78         The m_pendingAPIRequestURL member is used (presumably) to mask over the async
79         nature of WebKit2, so that starting a load of a URL will reflect that URL
80         immedeatly from activeURL, even if the request has not been passed over to
81         the web process yet and reflected there.
82
83         This works well, except in the case of the initial request, where the main
84         frame creation happens on the web process side and is notified back to the
85         UI process. Until we've recived the notification we don't know about the main
86         frame, and this race condition will potentially give us an empty url instead
87         of the pending request.
88
89         To solve this we always return the pending API request if it's set, even
90         when there's no mainframe yet (that we known about).
91
92         Reviewed by Simon Hausmann.
93
94         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
95
96 2012-05-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
97
98         [EFL][DRT] Clear added user style sheets before a new testcase execution.
99         https://bugs.webkit.org/show_bug.cgi?id=84792
100
101         Reviewed Gustavo Noronha Silva.
102
103         The added user style sheets from the previous testcases are cleared in order to avoid 
104         flaky results.
105
106         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
107         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
108
109 2012-05-09  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
110
111         Move suspendAnimations to use Internals interface.
112         https://bugs.webkit.org/show_bug.cgi?id=85986
113
114         Reviewed by Ryosuke Niwa.
115
116         Remove suspendAnimations functions, because it is able to work in the 
117         cross-port way through the Internals interface
118
119         * DumpRenderTree/LayoutTestController.cpp:
120         (LayoutTestController::staticFunctions):
121         * DumpRenderTree/LayoutTestController.h:
122         (LayoutTestController):
123         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
124         * DumpRenderTree/chromium/LayoutTestController.cpp:
125         (LayoutTestController::LayoutTestController):
126         * DumpRenderTree/chromium/LayoutTestController.h:
127         (LayoutTestController):
128         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
129         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
130         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
131         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
132         * DumpRenderTree/qt/LayoutTestControllerQt.h:
133         (LayoutTestController):
134         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
135         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
136
137 2012-05-09  Kent Tamura  <tkent@chromium.org>
138
139         [Chromium] Attempt to fix an Android build error.
140         https://bugs.webkit.org/show_bug.cgi?id=86045
141
142         * DumpRenderTree/DumpRenderTree.gypi:
143
144 2012-05-09  Ojan Vafai  <ojan@chromium.org>
145
146         Don't show partytime if there are non-layout test failures.
147         https://bugs.webkit.org/show_bug.cgi?id=86056
148
149         Reviewed by Dimitri Glazkov.
150
151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
154
155 2012-05-09  Hayato Ito  <hayato@chromium.org>
156
157         Improve a warning message for a reftest having an unused expectation file.
158         https://bugs.webkit.org/show_bug.cgi?id=85975
159
160         Reviewed by Adam Barth.
161
162         The current warning message is not intuitive. It might be better to update the message
163         so that it encourage users to remove unused expectation files.
164
165         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
166         (SingleTestRunner.__init__):
167
168 2012-05-09  Ojan Vafai  <ojan@chromium.org>
169
170         Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
171         https://bugs.webkit.org/show_bug.cgi?id=86043
172
173         Reviewed by Adam Barth.
174
175         -Get rid of the gtest iframe.
176         -Cover all non-layout test problems. Before we wouldn't catch compile failures
177         or gtest failures since they were not on the webkit testing bots.
178         -Include the list of failing steps next to the builder name. This is a lot less
179         cluttered than you'd expect and already helped me find a compile failure early.
180
181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
184         Delete unused map.
185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
193
194 2012-05-09  Jessie Berlin  <jberlin@apple.com>
195
196         Crash using the new WKBundleDOMWindowExtensions APIs.
197         https://bugs.webkit.org/show_bug.cgi?id=85888
198
199         Reviewed by Brady Eidson.
200
201         Cached frames can live slightly longer than the page, but most clients unregister themselves
202         and do other cleanup in the willDestroyPage callback, making them miss the
203         willDestroyGlobalObjectForDOMWindowExtension callbacks.
204
205         The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
206         test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
207         to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.
208
209         Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
210         pages that don't go into the page cache.
211
212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
213         Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
214         and simple-iframe-unload.html
215
216         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
217         (TestWebKitAPI):
218         Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
219         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
220         Do not bother to keep track of the live extension count - all of them are expected to be
221         live until the test completes.
222         (TestWebKitAPI::TEST):
223         Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
224         message failures will be clearer.
225         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
226         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
227         Clean up the BundleDOMWindowExtensions.
228         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
229         Add an ASSERT_NOT_REACHED.
230
231         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.
232         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
233         Keep track of the messages received so they can be checked at the end of the test.
234         (TestWebKitAPI::TEST):
235         Navigate to uncacheable pages and back.
236         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.
237         (DOMWindowExtensionNoCache):
238         (TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
239         Set up all the states for each BundleDOMWindowExtension.
240         (TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
241         Tell the UI Process about the states of the BundleDOMWindowExtensions.
242         (TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
243         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
244         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
245         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
246         Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
247         (TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
248         (TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
249         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
250         (TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
251         ASSERT that these pages not going into the page cache are not getting disconnected to go into
252         the page cache.
253         (TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
254         Ditto about getting reconnected when coming out of the page cache.
255         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
256         Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
257         (TestWebKitAPI::didFinishLoadForFrameCallback):
258         (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
259         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
260         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
261         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
262
263         * TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
264         * TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
265
266 2012-05-09  Adam Barth  <abarth@webkit.org>
267
268         [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
269         https://bugs.webkit.org/show_bug.cgi?id=86045
270
271         Reviewed by Eric Seidel.
272
273         * DumpRenderTree/DumpRenderTree.gypi:
274
275 2012-05-09  Adam Barth  <abarth@webkit.org>
276
277         [Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
278         https://bugs.webkit.org/show_bug.cgi?id=86041
279
280         Reviewed by Eric Seidel.
281
282         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
283
284 2012-05-09  Adam Barth  <abarth@webkit.org>
285
286         [Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
287         https://bugs.webkit.org/show_bug.cgi?id=86040
288
289         Reviewed by Kent Tamura.
290
291         * DumpRenderTree/chromium/TestShell.cpp:
292         (TestShell::dumpImage):
293
294 2012-05-09  Raphael Kubo da Costa  <rakuco@webkit.org>
295
296         [EFL] Build fix after r116464.
297
298         `ulong' is a type defined by glibc, so it is not very
299         portable. Use `unsigned long' instead.
300
301         * DumpRenderTree/efl/EventSender.cpp:
302         (DelayedEvent::DelayedEvent):
303         (DelayedEvent):
304         (leapForwardCallback):
305
306 2012-05-09  Adam Barth  <abarth@webkit.org>
307
308         [Chromium] LayoutTestController should use ENABLE guards for some features
309         https://bugs.webkit.org/show_bug.cgi?id=86030
310
311         Reviewed by Eric Seidel.
312
313         These features are disabled on OS(ANDROID) and so shouldn't be compiled
314         when the feature is off.
315
316         * DumpRenderTree/chromium/LayoutTestController.cpp:
317         (LayoutTestController::LayoutTestController):
318         * DumpRenderTree/chromium/LayoutTestController.h:
319         (LayoutTestController):
320         * DumpRenderTree/chromium/TestShell.h:
321         (TestShell):
322
323 2012-05-09  Tom Zakrajsek  <tomz@codeaurora.org>
324
325         Fix overzealous re-opened since blocked by... message
326         https://bugs.webkit.org/show_bug.cgi?id=86020
327
328         Reviewed by Adam Barth.
329
330         Changed CreateBug behavior to only re-open a blocked bug if it
331         was RESOLVED.  Also had to update the test infrastructure slightly
332         to allow for distinct mock commit revisions, so one could point
333         to a RESOLVED bug for testing while another pointed to an OPEN bug.
334
335         Also moved default created mock bug to be 60001 instead of 50004
336         which already exists as a reference mock bug.
337
338         * Scripts/webkitpy/common/checkout/checkout_mock.py:
339         (MockCheckout.__init__):
340         (MockCheckout.commit_info_for_revision):
341         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
342         (MockBugzilla.create_bug):
343         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
344         * Scripts/webkitpy/tool/commands/download_unittest.py:
345         (test_create_rollout_resolved):
346         * Scripts/webkitpy/tool/commands/queries_unittest.py:
347         (FailureReasonTest.test_blame_line_for_revision):
348         * Scripts/webkitpy/tool/steps/createbug.py:
349         (CreateBug.run):
350
351 2012-05-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
352
353         Use suitable viewport values on XHTML-MP pages.
354         https://bugs.webkit.org/show_bug.cgi?id=85425
355
356         Reviewed by Kenneth Rohde Christiansen.
357
358         Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
359
360         * qmake/mkspecs/features/features.prf:
361
362 2012-05-09  Jochen Eisinger  <jochen@chromium.org>
363
364         When creating a new page during a navigation, prime the initial document with the correct referrer policy
365         https://bugs.webkit.org/show_bug.cgi?id=86001
366
367         Reviewed by Adam Barth.
368
369         Store the referrer policy in the request, so the network stack can comply with it.
370
371         * DumpRenderTree/chromium/WebViewHost.cpp:
372         (WebViewHost::willSendRequest):
373
374 2012-05-09  Vivek Galatage  <vivekgalatage@gmail.com>
375
376         Remove CYGWIN=tty from environment variable as its no longer supported
377         https://bugs.webkit.org/show_bug.cgi?id=85791
378
379         The CYGWIN=tty environment variable is no longer supported from Cygwin
380         version 1.7.10. This fix avoids addition of this environment variable
381         for Cygwin versions greater than 1.7.9. For supporting older versions
382         i.e. 1.7.9 or older, the script takes care of retaining the environment
383         variable.
384
385         Reviewed by Adam Roben.
386
387         * Scripts/webkitdirs.pm:
388         (setupAppleWinEnv):
389
390 2012-05-09  Dirk Pranke  <dpranke@chromium.org>
391
392         nrwt: --skip-failing-tests should also skip flaky tests
393         https://bugs.webkit.org/show_bug.cgi?id=85941
394
395         Reviewed by Ojan Vafai.
396
397         This changes --skip-failing-tests so that we skip tests that
398         are believed to pass sometimes as well as tests that are
399         believed to always fail.
400
401         In addition, in testing this I discovered that we had lousy
402         test coverage of the details of retrying test failures and
403         --clobber-old-results, so I wrote some more tests.
404
405         * Scripts/webkitpy/layout_tests/controllers/manager.py:
406         (Manager.prepare_lists_and_print_output):
407         * Scripts/webkitpy/layout_tests/port/test.py:
408         (unit_test_list):
409         (TestPort.__init__):
410         (TestDriver.run_test):
411         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
412         (MainTest.test_skip_failing_tests):
413         (MainTest.test_retrying_and_flaky_tests):
414
415 2012-05-09  Christophe Dumez  <christophe.dumez@intel.com>
416
417         [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
418         https://bugs.webkit.org/show_bug.cgi?id=84435
419
420         Reviewed by Antonio Gomes.
421
422         Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
423         to support LayoutTestController's dumpIconChanges().
424
425         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
426         (DumpRenderTreeChrome::createView):
427         (DumpRenderTreeChrome::onFrameIconChanged):
428         (DumpRenderTreeChrome::onFrameCreated):
429         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
430         (DumpRenderTreeChrome):
431
432 2012-05-09  Dominik Röttsches  <dominik.rottsches@intel.com>
433
434         webkit-patch upload Fails Behind Load-balancing Proxies
435         https://bugs.webkit.org/show_bug.cgi?id=85980
436
437         Reviewed by Adam Barth.
438
439         Unchecking the login restriction to IP to allow the tool
440         to function behind load-balancing proxies that use multiple
441         outgoing IPs.
442
443         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
444         (Bugzilla.authenticate):
445
446 2012-05-09  Hao Zheng  <zhenghao@chromium.org>
447
448         [Chromium-android] Add unit test for Android layout test script (chromium_android.py)
449         https://bugs.webkit.org/show_bug.cgi?id=80852
450
451         Reviewed by Adam Barth.
452
453         Add some tests to ensure that chromium android port works to some
454         extent. Some methods is hard to test, as they rely on the actual
455         behavior on device, e.g. pushing files to device.
456
457         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
458         (ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
459         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
460         (ChromiumAndroidPortTest):
461         (ChromiumAndroidPortTest.test_attributes):
462         (ChromiumAndroidPortTest.test_get_last_stacktrace):
463         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
464         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
465         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
466         (ChromiumAndroidDriverTest):
467         (ChromiumAndroidDriverTest.setUp):
468         (ChromiumAndroidDriverTest.test_get_drt_return_value):
469         (ChromiumAndroidDriverTest.test_has_crash_hint):
470         (ChromiumAndroidDriverTest.test_read_prompt):
471         (ChromiumAndroidDriverTest.test_test_shell_command):
472         (ChromiumAndroidDriverTest.test_write_command_and_read_line):
473
474 2012-05-09  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
475
476         [Qt] ORWT fails with Qt 5 and WK2.
477         https://bugs.webkit.org/show_bug.cgi?id=85968
478
479         Reviewed by Csaba Osztrogonác.
480
481         The Qt5 binary does not have a -style argument, so avoid using it.
482
483         * Scripts/old-run-webkit-tests:
484
485 2012-05-09  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
486
487         [EFL][DRT] LayoutTestController addUserScript implementation
488         https://bugs.webkit.org/show_bug.cgi?id=84718
489
490         Reviewed by Antonio Gomes.
491
492         Added implementation of addUserScript() to LayoutTestController.
493
494         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
495         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
496         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
497         (LayoutTestController::addUserScript): added implementation
498
499 2012-05-09  Dan Bernstein  <mitz@apple.com>
500
501         Made build-webkit copy WebKitLibraries to the right location again after r116257
502
503         Reviewed by Mark Rowe.
504
505         * Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
506         * Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
507         product directory.
508
509 2012-05-08  Ojan Vafai  <ojan@chromium.org>
510
511         Show the chromium non-layout test bots in garden-o-matic
512         https://bugs.webkit.org/show_bug.cgi?id=85903
513
514         Reviewed by Eric Seidel.
515
516         This is just a single-line high-level overview of the chromium non-layout test bots.
517         This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
518         order to do their job.
519
520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
524         (#chromium-gtests iframe):
525         (#chromium-gtests):
526         (#gtest-label):
527
528 2012-05-08  Kangil Han  <kangil.han@samsung.com>
529
530         [EFL][DRT] Implement TextInputController.
531         https://bugs.webkit.org/show_bug.cgi?id=78559
532
533         Reviewed by Martin Robinson.
534
535         TextInputController has been created for an input emulation purpose in DRT.
536         However, not like other ports, EFL doesn't have it.
537         Therefore, this patch will enable EFL port to have an input emulation in DRT.
538
539         * DumpRenderTree/efl/CMakeLists.txt:
540         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
541         (DumpRenderTreeChrome::onWindowObjectCleared):
542         * DumpRenderTree/efl/TextInputController.cpp: Added.
543         (setMarkedTextCallback):
544         (hasMarkedTextCallback):
545         (markedRangeCallback):
546         (insertTextCallback):
547         (unmarkTextCallback):
548         (firstRectForCharacterRangeCallback):
549         (selectedRangeCallback):
550         (makeTextInputController):
551         * DumpRenderTree/efl/TextInputController.h: Added.
552
553 2012-04-23  Raphael Kubo da Costa  <rakuco@webkit.org>
554
555         [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
556         https://bugs.webkit.org/show_bug.cgi?id=84634
557
558         Reviewed by Gustavo Noronha Silva.
559
560         Drop unnecessary const char* -> WTF::String conversions by
561         creating String objects directly in LayoutTestController out of
562         JSStringRef's and passing them to DumpRenderTreeSupportEfl.
563
564         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
565         (LayoutTestController::queueLoad):
566         (LayoutTestController::setValueForUser):
567         (LayoutTestController::findString):
568         (LayoutTestController::addUserStyleSheet):
569
570 2012-05-08  Alexander Shalamov  <alexander.shalamov@intel.com>
571
572         [EFL][DRT] EventSender needs implementation of leapForward function
573         https://bugs.webkit.org/show_bug.cgi?id=83486
574
575         Reviewed by Eric Seidel.
576
577         Implemented leapForward function in Efl's DRT. This function is required
578         to delay and queue event execution and simulate real user behavior.
579
580         * DumpRenderTree/efl/EventSender.cpp:
581         (DelayedEvent):
582         (MouseEventInfo::MouseEventInfo):
583         (MouseEventInfo):
584         (sendClick):
585         (mouseDownCallback):
586         (mouseUpCallback):
587         (mouseMoveToCallback):
588         (leapForwardCallback):
589         (mouseScrollByCallback):
590         (feedOrQueueMouseEvent):
591         (feedMouseEvent):
592         (feedQueuedMouseEvents):
593
594 2012-05-08  Ryuan Choi  <ryuan.choi@samsung.com>
595
596         [EFL][DRT] WebKit/DRT should not paint webview for the pixel tests.
597         https://bugs.webkit.org/show_bug.cgi?id=79853
598
599         Reviewed by Eric Seidel.
600
601         Screen buffer can be different from rendered results.
602         For example, WebKit/Efl just moves tiles for ewk_view_tiled when scrolling
603         contents.
604         It means that pixel tests can't check regression of ewk_view_tiled.
605
606         This patch changes a way to provide bitmap from painting webview to capturing
607         evas.
608
609         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
610         (createBitmapContextFromWebView):
611
612 2012-05-08  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
613
614         [GTK] Memory leak in DRT EventSender.cpp
615         https://bugs.webkit.org/show_bug.cgi?id=85886
616
617         Reviewed by Martin Robinson.
618
619         Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
620         JSString created with JSStringCreateWithUTF8CString.
621
622         * DumpRenderTree/gtk/EventSender.cpp:
623         (gdkModifersFromJSValue):
624
625 2012-05-08  Christophe Dumez  <christophe.dumez@intel.com>
626
627         [EFL] glib dependency needs to be updated in jhbuild
628         https://bugs.webkit.org/show_bug.cgi?id=85878
629
630         Reviewed by Martin Robinson.
631
632         Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
633         addresses flakiness in media tests due to possible deadlock with the
634         following output on stderr:
635         GStreamer-WARNING **: wrong STREAM_LOCK count 0
636
637         The bug was fixed upstream by:
638         http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f
639
640         * efl/jhbuild.modules:
641
642 2012-05-07  Alexis Menard  <alexis.menard@openbossa.org>
643
644         [Qt] Unbreak debugging of WebKit2.
645         https://bugs.webkit.org/show_bug.cgi?id=85839
646
647         Reviewed by Simon Hausmann.
648
649         When you attach GDB to a running process, it stops it.
650         http://trac.webkit.org/changeset/115958 introduced a pause() 
651         call to wait the debugger to be attached to then continue 
652         the execution of the WebProcess. Unfortunately the pause()
653         function does not return unless a signal handler is called.
654         This patch introduce an event handler to exit from the paused
655         state when the debugger send the signal SIGCONT. The old code
656         works with older version of GDB (<7.0) but not with newer
657         versions where the behavior of pause() is correct.
658
659         * WebKitTestRunner/qt/main.cpp:
660         (sigcontHandler):
661         (main):
662
663 2012-05-08  Christophe Dumez  <christophe.dumez@intel.com>
664
665         [EFL][DRT] EFL's DRT does not fully support page visibility
666         https://bugs.webkit.org/show_bug.cgi?id=85032
667
668         Reviewed by Antonio Gomes.
669
670         * DumpRenderTree/LayoutTestController.cpp:
671         (resetPageVisibilityCallback): Fix incorrect argumentCount check.
672         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
673         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
674         reset page visibility setting between tests.
675         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
676         (LayoutTestController::setPageVisibility): Add support for "preview"
677         visibility state.
678
679 2012-05-08  Gavin Peters  <gavinp@chromium.org>
680
681         [webkit-patch] Return meaningful results from single-result queries.
682         https://bugs.webkit.org/show_bug.cgi?id=85367
683
684         Reviewed by Dirk Pranke.
685
686         Sometimes a quicksearch returns a single result by just redirecting to the page for that single
687         bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
688         a result list consisting of that one bug.
689
690         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
691         (BugzillaQueries._fetch_bugs_from_advanced_query):
692
693 2012-05-08  Gavin Peters  <gavinp@chromium.org>
694
695         [webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
696         https://bugs.webkit.org/show_bug.cgi?id=85368
697
698         Reviewed by Eric Seidel.
699
700         * Scripts/webkitpy/common/config/urls.py:
701         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
702         (MockBugzillaQueries.fetch_bugs_matching_quicksearch):
703         * Scripts/webkitpy/common/net/omahaproxy.py: Added.
704         (OmahaProxy):
705         (OmahaProxy.__init__):
706         (OmahaProxy.set_url):
707         (OmahaProxy._json_url):
708         (OmahaProxy._get_json):
709         (OmahaProxy.get_revisions):
710         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.
711         (MockOmahaProxy):
712         (MockOmahaProxy.__init__):
713         (OmahaProxyTest):
714         (OmahaProxyTest.test_get_revisions):
715         * Scripts/webkitpy/tool/commands/__init__.py:
716         * Scripts/webkitpy/tool/commands/bugsearch.py:
717         (BugSearch):
718         * Scripts/webkitpy/tool/commands/chromechannels.py: Added.
719         (ChromeChannels):
720         (__init__):
721         (execute):
722         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.
723         (MockOmahaProxy):
724         (MockOmahaProxy.get_revisions):
725         (TestableChromeChannels):
726         (TestableChromeChannels.__init__):
727         (ChromeChannelsTest):
728         (ChromeChannelsTest.test_single_bug):
729         (ChromeChannelsTest.test_with_query):
730
731 2012-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
732
733         Unreviewed. Fix GTK+ unit tests.
734
735         * gtk/common.py:
736         (pkg_config_file_variable):
737
738 2012-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
739
740         [GTK] Google tests that time out are leaked
741         https://bugs.webkit.org/show_bug.cgi?id=84973
742
743         Reviewed by Philippe Normand.
744
745         Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
746         leaving run-gtk-tests as simple wrapper that runs run-api-tests in
747         a jhbuild environment when jhbuild is available.
748
749         * Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or
750         with jhbuild if present.
751         * gtk/common.py:
752         (pkg_config_file_variable): Generic function to get a variable
753         from a pkg-config file.
754         (prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.
755         * gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.
756         (TestRunner.__init__): Use common.build_path() to get the programs path.
757         (TestRunner._lookup_atspi2_binary): Use
758         common.pkg_config_file_variable() to get the 'exec_prefix'.
759         (TestRunner._start_accessibility_daemons): Use subprocess.Popen()
760         directly instead of helper _create_process that has been removed.
761         (TestRunner._setup_testing_environment): Use subprocess.Popen()
762         directly instead of helper _create_process that has been
763         removed. Use common.top_level_path() and common.build_path()
764         instead of custom methods that have been removed too.
765         (TestRunner._run_test_command): Use subprocess.Popen() directly
766         instead of helper _create_process that has been removed.
767
768 2012-05-08  Thiago Marcos P. Santos  <thiago.santos@intel.com>
769
770         [EFL] [DRT] Clear extra views before setting a blank page
771         https://bugs.webkit.org/show_bug.cgi?id=85608
772
773         Reviewed by Kenneth Rohde Christiansen.
774
775         We need to clear the extra views before setting a blank page,
776         otherwise it will cause more events interactions and sometimes
777         trigger a unload(). This was causing frame-crash-with-page-cache.html
778         to leak events to the next test causing any subsequent test to
779         fail.
780
781         * DumpRenderTree/efl/DumpRenderTree.cpp:
782         (runTest):
783         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
784         (DumpRenderTreeChrome::clearExtraViews):
785         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
786         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
787         (DumpRenderTreeChrome):
788
789 2012-05-08  Balazs Kelemen  <kbalazs@webkit.org>
790
791         [Qt] X11 plugins need to be reworked for Qt5+WK1
792         https://bugs.webkit.org/show_bug.cgi?id=80691
793
794         Reviewed by Simon Hausmann.
795
796         Implement basic windowless plugin support with Qt5.
797
798         * qmake/mkspecs/features/features.prf:
799         Enable NPAPI plugins if X11 libraries are available.
800         * qmake/mkspecs/features/functions.prf:
801         Added a convenience function to determine availability
802         of X11 libraries.
803
804 2012-05-07  Raphael Kubo da Costa  <rakuco@webkit.org>
805
806         [webkitpy] Remove Python 2.5-specific workaround from http_server_base.py.
807         https://bugs.webkit.org/show_bug.cgi?id=85852
808
809         Reviewed by Dirk Pranke.
810
811         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
812         (HttpServerBase._is_server_running_on_all_ports): Revert the part
813         of r89412 which was a workaround for an issue with Python 2.5 on
814         Mac 10.5.
815
816 2012-05-07  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
817
818         webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
819         https://bugs.webkit.org/show_bug.cgi?id=81481
820
821         Reviewed by Dirk Pranke.
822
823         FreeBSD has the same sysctl interface present in Darwin to query
824         the number of CPUs available, so use that too.
825
826         * Scripts/webkitdirs.pm:
827         (determineNumberOfCPUs): Share the sysctl call with Darwin.
828         (isFreeBSD): Added.
829
830 2012-05-07  Alexis Menard  <alexis.menard@openbossa.org>
831
832         Unreviewed Qt build fix in Debug.
833
834         We need some system includes here for getpid() to be recognized.
835
836         * WebKitTestRunner/qt/main.cpp:
837
838 2012-05-07  Ojan Vafai  <ojan@chromium.org>
839
840         When embedding the flakiness dashboard, hide popups when the frame is blurred.
841         https://bugs.webkit.org/show_bug.cgi?id=85684
842
843         Reviewed by Dirk Pranke.
844
845         If you show a popup, then click elsewhere in garden-o-matic, it will now
846         properly hide it.
847
848         * TestResultServer/static-dashboards/dashboard_base.js:
849         (showPopup):
850         * TestResultServer/static-dashboards/flakiness_dashboard.js:
851         (showPopupForBuild):
852         (generatePageForIndividualTests.if):
853         (generatePageForIndividualTests):
854         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
855         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
856         * TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
857
858 2012-05-07  Ian Vollick  <vollick@chromium.org>
859
860         [chromium] WebViewHost should setCompositorSurfaceReady
861         https://bugs.webkit.org/show_bug.cgi?id=85418
862
863         Reviewed by James Robinson.
864
865         * DumpRenderTree/chromium/WebViewHost.cpp:
866         (WebViewHost::setWebWidget):
867
868 2012-05-07  Jon Lee  <jonlee@apple.com>
869
870         WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
871         https://bugs.webkit.org/show_bug.cgi?id=42331
872         <rdar://problem/8193641>
873
874         Reviewed by Darin Adler.
875
876         This patch sets up the framework for supporting dumpFrameLoadCallbacks, as well as
877         outputting some of the required strings. As tests become unskipped the other callbacks
878         can be supported.
879
880         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Add dumpFrameLoadCallbacks()
881         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
882         (WTR::InjectedBundle::didReceiveMessage): pass in the dictionary containing keys needed to initialize
883         dump callbacks for the layoutTestController.
884         (WTR::InjectedBundle::booleanForKey): Helper function to extract boolean value from key in WKDictionaryRef.
885         Output some warning if we are trying to extract a value that is not a boolean.
886         (WTR::InjectedBundle::beginTesting): Update to take in the dictionary passed in by the TestController.
887         We cannot set the bits on the layoutTestController until it has been created in beginTesting().
888         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
889         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
890         (WTR::InjectedBundle::didReceiveMessage):
891         (WTR):
892         (WTR::InjectedBundle::beginTesting):
893         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
894         (InjectedBundle):
895         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
896         (WTR):
897         (WTR::dumpFrameDescriptionSuitableForTestResult): Static function similar to
898         -[WebFrame _drt_descriptionSuitableForTestResult] in DumpRenderTree.
899         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Output string.
900         (WTR::InjectedBundlePage::didCommitLoadForFrame): Output string.
901         (WTR::InjectedBundlePage::didFinishLoadForFrame): Output string.
902         (WTR::InjectedBundlePage::didReceiveTitleForFrame): Output string.
903         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame): Output string.
904         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Output string. In WK1 it's
905         "willPerformClientRedirectToURL" so we will have to use that value here.
906         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Output string.
907         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): Output string.
908         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
909         (WTR::LayoutTestController::LayoutTestController): Initialize to not dump frame load callbacks.
910         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
911         (WTR::LayoutTestController::dumpFrameLoadCallbacks): Change to use setShouldDumpFrameLoadCallbacks.
912         (WTR::LayoutTestController::setShouldDumpFrameLoadCallbacks): Set bit.
913         (WTR::LayoutTestController::shouldDumpFrameLoadCallbacks): Return bit.
914         (LayoutTestController): Added m_dumpFrameLoadCallbacks to track whether to dump the output.
915         * WebKitTestRunner/TestInvocation.cpp:
916         (WTR::shouldLogFrameLoadDelegates): Similar to DRT.
917         (WTR::TestInvocation::invoke): Based on the URL loaded, set the bit in the dictionary that gets passed
918         to the injected bundle.
919
920 2012-05-07  Tommy Widenflycht  <tommyw@google.com>
921
922         [chromium] MediaStream API: Enhance WebUserMediaClientMock and add a test for it
923         https://bugs.webkit.org/show_bug.cgi?id=85618
924
925         Reviewed by Adam Barth.
926
927         Adding the capability to control which MediaStreamTracks actually get created,
928         and adding a test that exercises the JS api using that capability.
929
930         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
931         (WebKit::WebUserMediaClientMock::requestUserMedia):
932         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
933         * DumpRenderTree/chromium/WebViewHost.cpp:
934         (WebViewHost::testMediaStreamClient):
935         * DumpRenderTree/chromium/WebViewHost.h:
936         (WebViewHost):
937
938 2012-05-07  Zan Dobersek  <zandobersek@gmail.com>
939
940         [Gtk] WebGL feature is not built anymore through build-webkit after r116251
941         https://bugs.webkit.org/show_bug.cgi?id=85788
942
943         Reviewed by Martin Robinson.
944
945         Enable WebGL by default for the Gtk port. The feature is already enabled by
946         default in configure.ac, so there's no reason it shouldn't be enabled when
947         building through build-webkit.
948
949         * Scripts/webkitperl/FeatureList.pm:
950
951 2012-05-07  Csaba Osztrogonác  <ossy@webkit.org>
952
953         Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
954         We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.
955
956         Reviewed by Tor Arne Vestbø.
957
958         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
959         (IRCCommandTest.test_whois):
960
961 2012-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
962
963         Unreviewed, rolling out r116299, r116301, and r116303.
964         http://trac.webkit.org/changeset/116299
965         http://trac.webkit.org/changeset/116301
966         http://trac.webkit.org/changeset/116303
967         https://bugs.webkit.org/show_bug.cgi?id=85795
968
969         Build is still broken (Requested by Ossy on #webkit).
970
971         * DumpRenderTree/qt/DumpRenderTree.pro:
972         * DumpRenderTree/qt/main.cpp:
973         (main):
974         * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
975         * QtTestPlatformPlugin/TestIntegration.cpp: Removed.
976         * QtTestPlatformPlugin/TestIntegration.h: Removed.
977         * QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
978         * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
979         * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
980         * QtTestPlatformPlugin/main.cpp: Removed.
981         * QtTestPlatformPlugin/testplatform.json: Removed.
982         * Tools.pro:
983         * WebKitTestRunner/Target.pri:
984         * WebKitTestRunner/qt/main.cpp:
985         (main):
986
987 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
988
989         Unreviewed Qt build fix.
990
991         One more try to learn how to use
992         const with a pointer array.
993
994         * DumpRenderTree/qt/main.cpp:
995         (initializeTestPlatformPlugin):
996
997 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
998
999         Unreviewed build fix after r116299.
1000
1001         * DumpRenderTree/qt/main.cpp:
1002         (initializeTestPlatformPlugin):
1003
1004 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
1005
1006         [Qt] Add test specific platform plugin to achieve unified layout test results
1007         https://bugs.webkit.org/show_bug.cgi?id=80996
1008
1009         Reviewed by Simon Hausmann.
1010
1011         Added QtTestPlatformPlugin as a new project under Tools.
1012         This is a Qt5-ish platform plugin that can be used to tweak the
1013         platform support interfaces in order to unify layout test results.
1014         For now it only overrides the font database on Mac and redirects
1015         everything else to the real platform plugin. The font database it
1016         provides mimics the way how we set up test fonts with fontconfig on Linux.
1017         Make DumpRenderTree and WebKitTestRunner use this platform plugin.
1018
1019         * DumpRenderTree/qt/DumpRenderTree.pro:
1020         * DumpRenderTree/qt/main.cpp:
1021         (initializeTestPlatformPlugin):
1022         (main):
1023         * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
1024         * QtTestPlatformPlugin/TestIntegration.cpp: Added.
1025         (TestIntegration::TestIntegration):
1026         (TestIntegration::fontDatabase):
1027         * QtTestPlatformPlugin/TestIntegration.h: Added.
1028         (TestIntegration):
1029         (TestIntegration::hasCapability):
1030         (TestIntegration::createPlatformPixmap):
1031         (TestIntegration::createPlatformWindow):
1032         (TestIntegration::createPlatformBackingStore):
1033         (TestIntegration::createPlatformOpenGLContext):
1034         (TestIntegration::createPlatformSharedGraphicsCache):
1035         (TestIntegration::guiThreadEventDispatcher):
1036         (TestIntegration::clipboard):
1037         (TestIntegration::drag):
1038         (TestIntegration::inputContext):
1039         (TestIntegration::accessibility):
1040         (TestIntegration::nativeInterface):
1041         (TestIntegration::services):
1042         (TestIntegration::styleHint):
1043         (TestIntegration::platformTheme):
1044         * QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.
1045         (TestFontDatabase):
1046         * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.
1047         (TestFontDatabase::populateFontDatabase):
1048         * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.
1049         (TestIntegration::fontDatabase):
1050         * QtTestPlatformPlugin/main.cpp: Added.
1051         (TestIntegrationPlugin::keys):
1052         (TestIntegrationPlugin::create):
1053         (TestIntegrationPlugin::initialize):
1054         * QtTestPlatformPlugin/testplatform.json: Added.
1055         * Tools.pro:
1056         * WebKitTestRunner/Target.pri:
1057         * WebKitTestRunner/qt/main.cpp:
1058         (main):
1059
1060 2012-05-07  Christophe Dumez  <christophe.dumez@intel.com>
1061
1062         [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
1063         https://bugs.webkit.org/show_bug.cgi?id=85609
1064
1065         Reviewed by Simon Hausmann.
1066
1067         Flakiness was caused by the fact that
1068         media/crash-closing-page-with-media-as-plugin-fallback.html and
1069         media/video-poster-blocked-by-willsendrequest.html use the same PNG
1070         file as poster attribute in the video tag. The PNG file gets cached
1071         when the first test is executed and this somehow causes the second
1072         test to fail. 
1073
1074         The flakiness was addressed by clearing the memory and page caches
1075         between tests.
1076
1077         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1078         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1079
1080 2012-05-07  Eric Seidel  <eric@webkit.org>
1081
1082         Add values for all features to Qt's features.pri
1083         https://bugs.webkit.org/show_bug.cgi?id=85746
1084
1085         Reviewed by Tor Arne Vestbø.
1086
1087         When generate-feature-files generates features.pri it provides a value
1088         for every possible ENABLE_.  In prepration for landing generate-feature-files
1089         it seems appropriate to add a value for all possible ENABLEs to the existing
1090         features.pri.  This lets me make sure that I'm getting them all right!
1091
1092         * qmake/mkspecs/features/features.pri:
1093
1094 2012-05-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1095
1096         Added myself as a committer.
1097
1098         Not reviewed.
1099
1100         * Scripts/webkitpy/common/config/committers.py:
1101
1102 2012-05-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1103
1104         [EFL][DRT] Implement LayoutTestController::execCommand
1105         https://bugs.webkit.org/show_bug.cgi?id=82286
1106
1107         Reviewed by Antonio Gomes.
1108
1109         Add missing implementation execCommand and isCommandEnabled to EFL's
1110         LayoutTestController. 
1111
1112         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1113         (LayoutTestController::execCommand):
1114         (LayoutTestController::isCommandEnabled):
1115
1116 2012-05-06  Hayato Ito  <hayato@chromium.org>
1117
1118         [prepare-ChangeLog] Excludes a reference file used by reftests from test files.
1119         https://bugs.webkit.org/show_bug.cgi?id=74268
1120
1121         Reviewed by Ryosuke Niwa.
1122
1123         * Scripts/prepare-ChangeLog:
1124         (generateFileList):
1125
1126 2012-05-06  Mary Wu  <mary.wu@torchmobile.com.cn>
1127
1128         Add a contributor to committers.py
1129         https://bugs.webkit.org/show_bug.cgi?id=85761
1130
1131         Reviewed by Unreviewed.
1132
1133         Add myself to committers.py contributor.
1134
1135         * Scripts/webkitpy/common/config/committers.py:
1136
1137 2012-05-06  Dan Bernstein  <mitz@apple.com>
1138
1139         Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
1140         https://bugs.webkit.org/show_bug.cgi?id=85739
1141
1142         Reviewed by Daniel Bates.
1143
1144         * Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory
1145         from here...
1146         * Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.
1147
1148 2012-05-06  Andy Estes  <aestes@apple.com>
1149
1150         Fix the build after r116246.
1151
1152         * DumpRenderTree/LayoutTestController.cpp: Remove an unused function.
1153
1154 2012-05-06  Eric Seidel  <eric@webkit.org>
1155
1156         Update several build-webkit options to match the #defines they toggle
1157         https://bugs.webkit.org/show_bug.cgi?id=85744
1158
1159         Reviewed by Adam Barth.
1160
1161         Most notable here is fixing --3d-canvas to be --webgl these days --
1162         the define was renamed 15 months ago!
1163
1164         * Scripts/webkitperl/FeatureList.pm:
1165
1166 2012-05-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1167
1168         [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
1169         https://bugs.webkit.org/show_bug.cgi?id=83687
1170
1171         Reviewed by Antonio Gomes.
1172
1173         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1174         (LayoutTestController::setJavaScriptCanAccessClipboard):
1175
1176 2012-05-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1177
1178         Convert isPageBoxVisible to use Internals interface.
1179         https://bugs.webkit.org/show_bug.cgi?id=85692
1180
1181         Reviewed by Darin Adler.
1182
1183         Remove isPageBoxVisible functions, because it is able to work in the
1184         cross-port way through the Internals interface.
1185
1186         * DumpRenderTree/LayoutTestController.cpp:
1187         (LayoutTestController::staticFunctions):
1188         * DumpRenderTree/LayoutTestController.h:
1189         (LayoutTestController):
1190         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1191         * DumpRenderTree/chromium/LayoutTestController.cpp:
1192         (LayoutTestController::LayoutTestController):
1193         * DumpRenderTree/chromium/LayoutTestController.h:
1194         (LayoutTestController):
1195         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1196         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1197         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1198         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1199         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1200         (LayoutTestController):
1201         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1202         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1203
1204 2012-05-06  Tom Zakrajsek  <tomz@codeaurora.org>
1205
1206         sheriffbot isn't reopening patches after it lands rollouts
1207         https://bugs.webkit.org/show_bug.cgi?id=64418
1208
1209         Reviewed by Adam Barth.
1210
1211         * Scripts/webkitpy/tool/commands/download_unittest.py:
1212         * Scripts/webkitpy/tool/steps/createbug.py:
1213         (CreateBug.run):
1214
1215 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
1216
1217         webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
1218         https://bugs.webkit.org/show_bug.cgi?id=85697
1219
1220         Reviewed by Eric Seidel.
1221
1222         * Scripts/new-run-webkit-tests: Instead of manually detecting whether
1223         the path separator should be ':' or ';' by checking sys.platform, rely
1224         on os.pathsep which has exactly the same information (os.pathsep is
1225         ':' for Cygwin, from what I could check in Python's sources).
1226
1227 2012-05-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1228
1229         Unreviewed, rolling out r116223.
1230         http://trac.webkit.org/changeset/116223
1231         https://bugs.webkit.org/show_bug.cgi?id=85718
1232
1233         The bots need to set XDG_DATA_DIRS (Requested by rakuco on
1234         #webkit).
1235
1236         * efl/jhbuildrc:
1237         * gtk/jhbuildrc:
1238
1239 2012-05-05  Raphael Kubo da Costa  <rakuco@webkit.org>
1240
1241         [jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
1242         https://bugs.webkit.org/show_bug.cgi?id=85717
1243
1244         Reviewed by Martin Robinson.
1245
1246         After r116209, the XDG_DATA_DIRS environment variable is now
1247         passed by webkitpy's layout_tests code to run-with-jhbuild, so
1248         instead of setting a few defaults in jhbuildrc we can now rely on
1249         the values set and really used by each system.
1250
1251         * efl/jhbuildrc:
1252         * gtk/jhbuildrc:
1253
1254 2012-05-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1255
1256         [Qt] Buildfix for --minimal build after r116107.
1257
1258         Reviewed by Csaba Osztrogonác.
1259
1260         * qmake/mkspecs/features/features.prf:
1261
1262 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
1263
1264         [Gtk] GtkDriver is not required anymore after r116134
1265         https://bugs.webkit.org/show_bug.cgi?id=85699
1266
1267         Reviewed by Csaba Osztrogonác.
1268
1269         Remove GtkDriver as it was replaced by the XvfbDriver and is
1270         no longer needed.
1271
1272         * Scripts/webkitpy/layout_tests/port/gtk.py:
1273
1274 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
1275
1276         Increase the display ID for the Xvfb process to use if pixel_tests argument
1277         is true rather than if pixel_tests option is present. This fixes the
1278         XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.
1279
1280         Rubber-stamped by Csaba Osztrogonác.
1281
1282         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1283         (XvfbDriver._start):
1284
1285 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
1286
1287         webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
1288         https://bugs.webkit.org/show_bug.cgi?id=85694
1289
1290         Reviewed by Martin Robinson.
1291
1292         This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
1293         preserved, as it is particularly useful for Linux/Unix
1294         environments.  As a real use case, if shared-mime-info is
1295         installed into a non-trivial prefix, Glib and other libraries will
1296         have trouble to properly identify mimetypes (in ResourceResponses,
1297         for example) as the base freedesktop.org mimetype file will not be
1298         found.
1299
1300         * Scripts/webkitpy/layout_tests/port/base.py:
1301         (Port.to.setup_environ_for_server):
1302
1303 2012-05-04  Gustavo Noronha Silva  <gns@gnome.org>
1304
1305         [GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
1306         https://bugs.webkit.org/show_bug.cgi?id=85691
1307
1308         * GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
1309
1310 2012-05-04  Eric Seidel  <eric@webkit.org>
1311
1312         Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
1313         https://bugs.webkit.org/show_bug.cgi?id=85583
1314
1315         Reviewed by Daniel Bates.
1316
1317         * Scripts/webkitperl/FeatureList.pm:
1318
1319 2012-05-04  Eric Seidel  <eric@webkit.org>
1320
1321         Sort entries in FeaturesList.pm to make them easier to autogenerate
1322         https://bugs.webkit.org/show_bug.cgi?id=85584
1323
1324         Reviewed by Daniel Bates.
1325
1326         No functional changes, only sorting.
1327
1328         * Scripts/webkitperl/FeatureList.pm:
1329
1330 2012-05-04  Andy Estes  <aestes@apple.com>
1331
1332         REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
1333         https://bugs.webkit.org/show_bug.cgi?id=85675
1334
1335         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1336         (TestWebKitAPI::TEST): Disable the test.
1337
1338 2012-04-30  Jer Noble  <jer.noble@apple.com>
1339
1340         Full screen will exit during a provisional load of a non-ancestor iframe.
1341         https://bugs.webkit.org/show_bug.cgi?id=85230
1342
1343         Reviewed by Maciej Stachowiak .
1344
1345         Add support for the new UIDelegate webView:closeFullScreenWithListener: method:
1346         * DumpRenderTree/mac/UIDelegate.mm:
1347         (-[UIDelegate webView:closeFullScreenWithListener:]):
1348
1349         Add support for the new closeFullScreen injected bundle method:
1350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1351         (WTR::InjectedBundlePage::InjectedBundlePage):
1352         (WTR::InjectedBundlePage::closeFullScreen):
1353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1354
1355 2012-05-04  Ojan Vafai  <ojan@chromium.org>
1356
1357         Fix test naming to be camel-case like the methods they are testing.
1358
1359         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1360         (test):
1361
1362 2012-05-04  Ojan Vafai  <ojan@chromium.org>
1363
1364         Show the results links in the embedded flakiness dashboard
1365         https://bugs.webkit.org/show_bug.cgi?id=85660
1366
1367         Reviewed by Adam Barth.
1368
1369         Turns out these links don't add much visual noise and it's annoying
1370         to have to go to the dashboard from garden-o-matic just to view the
1371         results for a test.
1372
1373         This is useful for cases where garden-o-matic doesn't properly show the
1374         results (e.g. missing tests). If we address all those cases, then
1375         we could easily hide the results links again if we wanted to.
1376
1377         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1378         (showUpdateInfoForTest):
1379         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1380         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1381         (test):
1382
1383 2012-05-04  Dirk Pranke  <dpranke@chromium.org>
1384
1385         Revert to using chromium --test-shell mode on SL in NRWT
1386
1387         https://bugs.webkit.org/show_bug.cgi?id=83076
1388
1389         Unreviewed, build fix.
1390
1391         We seem to be seeing a lot more flakiness on the bot since
1392         I switched NRWT to "DRT" mode. We'll try reverting back and
1393         see if this helps things.
1394
1395         * Scripts/webkitpy/layout_tests/port/chromium.py:
1396         (ChromiumDriver.__init__):
1397
1398 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
1399
1400         [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
1401         https://bugs.webkit.org/show_bug.cgi?id=84941
1402
1403         Reviewed by Martin Robinson.
1404
1405         Print MIME type detection messages in EFL's DumpRenderTree if
1406         LayoutTestController's dumpResourceResponseMIMETypes() returns true.
1407
1408         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1409         (DumpRenderTreeChrome::onResponseReceived):
1410
1411 2012-05-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1412
1413         [GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
1414         https://bugs.webkit.org/show_bug.cgi?id=85134
1415
1416         Reviewed by Martin Robinson.
1417
1418         Add missing implementation setDefersLoading and goBack to GTK's
1419         LayoutTestController so that the test case rely on these methods
1420         can be enabled.
1421
1422         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1423         (resetDefaultsToConsistentValues):
1424         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1425         (LayoutTestController::goBack):
1426         (LayoutTestController::setDefersLoading):
1427
1428 2012-05-04  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1429
1430         [Qt][NRWT] Run each DRT in it's own xvfb
1431         https://bugs.webkit.org/show_bug.cgi?id=77335
1432
1433         Reviewed by Dirk Pranke.
1434
1435         * Scripts/webkitpy/layout_tests/port/gtk.py:
1436         (GtkPort._driver_class):
1437         * Scripts/webkitpy/layout_tests/port/qt.py:
1438         (QtPort._driver_class):
1439         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
1440         (XvfbDriver):
1441         (XvfbDriver._start):
1442         (XvfbDriver._start.x_filter):
1443         (XvfbDriver.stop):
1444
1445 2012-05-04  Zan Dobersek  <zandobersek@gmail.com>
1446
1447         Use destructuring assingment for the return values of the
1448         port.diff_image() method call.
1449
1450         Rubber-stamped by Dirk Pranke.
1451
1452         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1453         (write_test_result):
1454
1455 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1456
1457         Store fewer runs by default in the flakiness dashboard
1458         https://bugs.webkit.org/show_bug.cgi?id=85568
1459
1460         Reviewed by Dirk Pranke.
1461
1462         This will greatly shrink the size of the json files we load,
1463         resulting in a much faster initial load. People rarely care
1464         about more than 100 runs. For the cases they do, they can still click
1465         the show all runs checkbox to show 500 runs.
1466
1467         * TestResultServer/model/jsonresults.py:
1468
1469 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
1470
1471         [EFL] Frame load callbacks output is missing for redirections
1472         https://bugs.webkit.org/show_bug.cgi?id=85173
1473
1474         Reviewed by Antonio Gomes.
1475
1476         Catch the new ewk_frame signals to print the expected output in case
1477         of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
1478         returns true.
1479
1480         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1481         (DumpRenderTreeChrome::createView):
1482         (DumpRenderTreeChrome::onWillSendRequest):
1483         (DumpRenderTreeChrome::onFrameCreated):
1484         (DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
1485         (DumpRenderTreeChrome::onFrameRedirectRequested):
1486         (DumpRenderTreeChrome::onResponseReceived):
1487         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1488         (DumpRenderTreeChrome):
1489
1490 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1491
1492         [Qt] Fix up warning about missing GLib/Gio/GStreamer
1493
1494         We don't actually fall back.
1495
1496         Rubber-stamped by Csaba Osztrogonác.
1497
1498         * qmake/mkspecs/features/features.prf:
1499
1500 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1501
1502         [Qt] Clarify warning about missing GLib/Gio/GStreamer for media support
1503
1504         And only print it once.
1505
1506         Reviewed by Csaba Osztrogonác.
1507
1508         * qmake/mkspecs/features/features.prf:
1509
1510 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1511
1512         [Qt] Clean up and split features.prf into a static list of defaults
1513
1514         The static list of feature defaults is used as a fallback for any
1515         feature that's not dynamically detected or overriden on the command
1516         line (though build-webkit or passing DEFINES+= to qmake).
1517
1518         The static list is complete, which allows for auto-generation based
1519         on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=85611
1522
1523         Reviewed by Simon Hausmann.
1524
1525         * Scripts/build-webkit:
1526         * Tools.pro:
1527         * qmake/mkspecs/features/features.prf:
1528         * qmake/mkspecs/features/features.pri: Added.
1529
1530 2012-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1531
1532         Unreviewed, rolling out r116085, r116091, and r116095.
1533         http://trac.webkit.org/changeset/116085
1534         http://trac.webkit.org/changeset/116091
1535         http://trac.webkit.org/changeset/116095
1536         https://bugs.webkit.org/show_bug.cgi?id=85628
1537
1538         We are not ready with dependencies on all platform yet (mac) +
1539         problems with debug builds. (Requested by Zoltan on #webkit).
1540
1541         * qmake/mkspecs/features/features.prf:
1542
1543 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
1544
1545         [EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
1546         https://bugs.webkit.org/show_bug.cgi?id=85171
1547
1548         Reviewed by Andreas Kling.
1549
1550         Implement support for overriding "WebKitLoadSiteIconsKey" setting in
1551         EFL's LayoutTestController.
1552
1553         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1554         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1555         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1556         (LayoutTestController::overridePreference):
1557
1558 2012-05-03  Alexis Menard  <alexis.menard@openbossa.org>
1559
1560         [Qt] Enable fullscreen API for WebKit2.
1561         https://bugs.webkit.org/show_bug.cgi?id=85498
1562
1563         Reviewed by Simon Hausmann.
1564
1565         Enable the fullscreen API on the MiniBrowser and turn
1566         it default on WebKit2, disable it on WK1.
1567
1568         * MiniBrowser/qt/BrowserWindow.cpp:
1569         (BrowserWindow::BrowserWindow):
1570         * MiniBrowser/qt/qml/BrowserWindow.qml:
1571         * Scripts/webkitperl/FeatureList.pm:
1572         * qmake/mkspecs/features/features.prf:
1573
1574 2012-05-04  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1575
1576         REGRESSION(r116008) old-run-webkit-tests broken
1577         https://bugs.webkit.org/show_bug.cgi?id=85597
1578
1579         Reviewed by Simon Hausmann.
1580
1581         Reinstate libraryContainsSymbol.
1582
1583         * Scripts/webkitperl/features.pm:
1584         (libraryContainsSymbol):
1585
1586 2012-05-04  Zoltan Horvath  <zoltan@webkit.org>
1587
1588         [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
1589         https://bugs.webkit.org/show_bug.cgi?id=80400
1590
1591         Remove WTF_USE_QT_IMAGE_DECODER macro.
1592
1593         Reviewed by Simon Hausmann.
1594
1595         * qmake/mkspecs/features/features.prf:
1596
1597 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
1598
1599         [EFL] DRT should obey layoutTestController's addURLToRedirect()
1600         https://bugs.webkit.org/show_bug.cgi?id=82722
1601
1602         Reviewed by Maciej Stachowiak.
1603
1604         Implement support for layoutTestController's addURLToRedirect()
1605         in EFL's DRT so that it redirects properly when indicated.
1606
1607         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1608         (DumpRenderTreeChrome::onWillSendRequest):
1609
1610 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
1611
1612         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
1613         https://bugs.webkit.org/show_bug.cgi?id=82704
1614
1615         Reviewed by Antonio Gomes.
1616
1617         EFL's DRT needs to obey LayoutTestController's
1618         willSendRequestReturnsNullOnRedirect().
1619
1620         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1621         (DumpRenderTreeChrome::onWillSendRequest):
1622
1623 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
1624
1625         git-add-reviewer: Do not put the bug title and its URL in the same line in the commit message.
1626         https://bugs.webkit.org/show_bug.cgi?id=85570
1627
1628         Reviewed by Adam Roben.
1629
1630         The standard format of commit messages and ChangeLog entries has a
1631         short summary in the first line, followed by the bug URL in
1632         Bugzilla. Passing "%s" in the pretty format line to git-rev-list
1633         merges these two lines into a single one separated by a space
1634         character, which is not what we want.
1635
1636         Since "%s%n%n%b" is in practice "%B" (raw message), use it
1637         instead, as the first two lines do not end up being merged
1638         together.
1639
1640         * Scripts/git-add-reviewer:
1641         (writeCommitMessageToFile):
1642
1643 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1644
1645         Improve UI for garden-o-matic examine view when there are fewer than 5 tests.
1646         https://bugs.webkit.org/show_bug.cgi?id=85566
1647
1648         Reviewed by Adam Barth.
1649
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1651         (.):
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1653         (.):
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1655
1656 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
1657
1658         webkitpy: Recognize FreeBSD as a valid platform.
1659         https://bugs.webkit.org/show_bug.cgi?id=81467
1660
1661         Reviewed by Adam Barth.
1662
1663         Add PlatformInfo.is_freebsd() so that trying to use webkit-patch
1664         on FreeBSD does not raise an "unrecognized platform" exception.
1665
1666         Most of this patch contains some unit tests for the mentioned
1667         method, as currently platform-specific code is needed only on
1668         Windows.
1669
1670         * Scripts/webkitpy/common/system/platforminfo.py:
1671         (PlatformInfo.__init__):
1672         (PlatformInfo.is_freebsd):
1673         (PlatformInfo._determine_os_name):
1674         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1675         (MockPlatformInfo.is_freebsd):
1676         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1677         (fake_platform):
1678         (fake_platform.FakePlatformModule.release):
1679         (TestPlatformInfo.test_real_code):
1680         (TestPlatformInfo.test_os_name_and_wrappers):
1681         (TestPlatformInfo.test_os_version):
1682         (TestPlatformInfo.test_display_name):
1683         (TestPlatformInfo.test_total_bytes_memory):
1684         (TestPlatformInfo.test_free_bytes_memory):
1685         * Scripts/webkitpy/layout_tests/port/factory.py:
1686         (PortFactory._default_port):
1687
1688 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1689
1690         Make the table headers white-space:nowrap. This decreases the vertical size,
1691         which makes for more minimal embedding in garden-o-matic.
1692
1693         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
1694         (.table-header-content *):
1695
1696 2012-05-03  Eric Seidel  <eric@webkit.org>
1697
1698         Split build-webkit's feature option list off into its own module in preparation for autogeneration
1699         https://bugs.webkit.org/show_bug.cgi?id=85548
1700
1701         Reviewed by Daniel Bates.
1702
1703         My Perl-fu is very weak.  This moves the feature option list off into a separate module
1704         file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
1705         It's a bit odd to have an array which we return out to build-webkit to modify, but it turns out
1706         not to matter.  Also, build-webkit doesn't actually use any of the variables we're using to
1707         store the results from the option parse, so those end up inaccessible from build-webkit (except by reference)
1708         which is actually cleaner.  Callers can't assume that they would get a new array every time, but someone
1709         with more Perl-fu than I could create something fancier than this if we need in the future.
1710
1711         * Scripts/build-webkit:
1712         * Scripts/webkitperl/FeatureList.pm: Added.
1713         (getFeatureOptionList):
1714
1715 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
1716
1717         REGRESSION: run-webkit-tests failing on Chromium Mac
1718         https://bugs.webkit.org/show_bug.cgi?id=85459
1719
1720         Unreviewed, build fix.
1721
1722         Turns out select doesn't throw IOErrors, it has it's own kind of
1723         error :(. Trap that instead.
1724
1725         * Scripts/webkitpy/layout_tests/port/server_process.py:
1726         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1727
1728 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
1729
1730         [CMake] Rewrite FindCairo.cmake.
1731         https://bugs.webkit.org/show_bug.cgi?id=84895
1732
1733         Reviewed by Daniel Bates.
1734
1735         The old approach relied on pkg-config for finding Cairo (which
1736         introduced a dependency on pkg-config that could be avoided), used
1737         the LibFindMacros code that we should probably remove in the
1738         future and did not use the FindPackageHandleStandardArguments
1739         module.
1740
1741         Change all that by rewriting the module.
1742         - Use the pkg-config output optionally instead of requiring it
1743         like LibFindMacros did.
1744         - Remove the implicit dependency on FreeType which often found it
1745         the wrong way via pkg-config and without considering
1746         CMAKE_PREFIX_PATH.
1747         - Retrieve the Cairo version by looking at cairo-version.h instead
1748         of relying on pkg-config. It requires some additional code for
1749         checking if the desired version has been found, but that will not
1750         be needed once we start depending on CMake 2.8.3 or later.
1751
1752         The only downside is that FPHSA sets <UPPERCASED_NAME>_FOUND
1753         instead of <Name>_FOUND, and to keep things consistent
1754         Cairo_LIBRARIES and Cairo_INCLUDE_DIRS have become CAIRO_LIBRARIES
1755         and CAIRO_INCLUDE_DIRS.
1756
1757         * DumpRenderTree/efl/CMakeLists.txt: Use CAIRO_FOO instead of
1758         Cairo_FOO.
1759         * EWebLauncher/CMakeLists.txt: Ditto.
1760
1761 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1762
1763         Fix modifier and bug sorting on the flakiness dashboard
1764         https://bugs.webkit.org/show_bug.cgi?id=85554
1765
1766         Reviewed by Dirk Pranke.
1767
1768         The sorting assumes that the column header name matches a field
1769         in the testResults object and uses that field for sorting.
1770         Filter the bugs out of the modifiers list and put them in a bugs field
1771         and only put the non-bug modifiers in the modifiers list.
1772
1773         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1774         (populateExpectationsData):
1775         (htmlForSingleTestRow):
1776         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1777
1778 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1779
1780         Fix some state resetting when running unittests. HtmlForSingleTestRow
1781         was flaky.
1782
1783         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1784         (htmlForSingleTestRow):
1785         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1786         (resetGlobals):
1787
1788 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
1789
1790         webkitpy: Use PlatformInfo wherever possible in the User class.
1791         https://bugs.webkit.org/show_bug.cgi?id=85549
1792
1793         Reviewed by Dirk Pranke.
1794
1795         Instead of relying on sys.platform to detect whether the current
1796         platform is a Mac, use the PlatformInfo class instead.
1797
1798         * Scripts/webkitpy/common/system/user.py:
1799         (User.__init__):
1800         (User.edit_changelog):
1801
1802 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1803
1804         Remove the percent failed column from the flakiness dashboard
1805         https://bugs.webkit.org/show_bug.cgi?id=85552
1806
1807         Reviewed by Dirk Pranke.
1808
1809         This column isn't useful enough to justify the visual noise.
1810
1811         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1812         (processMissingAndExtraExpectations):
1813         (tableHeaders):
1814         (htmlForSingleTestRow):
1815         (sortTests):
1816         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1817         (test):
1818
1819 2012-05-03  Eric Seidel  <eric@webkit.org>
1820
1821         --coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
1822         https://bugs.webkit.org/show_bug.cgi?id=85542
1823
1824         Reviewed by Daniel Bates.
1825
1826         Remove these last two odd-men-out, so that we can generate the default feature options
1827         for build-webkit using the new generate-feature-files command.
1828         The Mac build system has some special casing for ENABLE_ defines which gets them
1829         defined as -D on the build command, even though initially they start out as
1830         environment variables ENABLE_FOO = ENABLE_FOO.  The Feature options in build-webkit
1831         depend on this support, but it doesn't work for WTF_USE_ defines like WTF_USE_WTF_URL.
1832         I'm told that WTF_URL is not actively being worked on, so just removing it for now.
1833         It should probably come back to life as an ENABLE_, or build-webkit or the Xcode projects
1834         should be made generically smarter about these USE_WTF defines.
1835         (There is still WTF_USE_TILED_BACKING_STORE in the feature list, but it only seems
1836         used by Qt.  If someone tried build-webkit --tiled-backing-store on Mac today it
1837         would not work!)
1838
1839         * Scripts/build-webkit:
1840
1841 2012-05-03  Eric Seidel  <eric@webkit.org>
1842
1843         Remove the last bits of Leopard support from our perl scripts
1844         https://bugs.webkit.org/show_bug.cgi?id=85545
1845
1846         Reviewed by Daniel Bates.
1847
1848         Chromium still supports Leopard (for a little while yet), but AppleMacWebKit dropped
1849         Leopard support several months ago.  Remove the last bits of isLeopard() branching
1850         in our Perl scripts, since no one is using this (Chromium has never used this Perl code).
1851
1852         * Scripts/build-webkit:
1853         * Scripts/old-run-webkit-tests:
1854         (countAndPrintLeaks):
1855         (captureSavedCrashLog):
1856         * Scripts/webkitdirs.pm:
1857         (determineArchitecture):
1858         (argumentsForRunAndDebugMacWebKitApp):
1859
1860 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1861
1862         [Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
1863         https://bugs.webkit.org/show_bug.cgi?id=85551
1864
1865         Reviewed by Dirk Pranke.
1866
1867         It's not uploading results and in the short term we don't plan to have it start.
1868
1869         * TestResultServer/static-dashboards/builders.js:
1870         (isChromiumWebkitTipOfTreeTestRunner):
1871         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1872
1873 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1874
1875         Show the test name in the dashboard if showChrome==false and we're showing multiple tests
1876         https://bugs.webkit.org/show_bug.cgi?id=85243
1877
1878         Reviewed by Dirk Pranke.
1879
1880         This happens for cases where a test name matches multiple tests.
1881         In practice, this only happens for virtual test suites (e.g. the canvas tests).
1882
1883         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1884         (htmlForIndividualTestOnAllBuildersWithChrome):
1885         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1886         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
1887         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1888         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1889         (testHtmlForIndividualTests):
1890
1891 2012-05-03  Ojan Vafai  <ojan@chromium.org>
1892
1893         Port the flakiness dashboard unittests to qunit
1894         https://bugs.webkit.org/show_bug.cgi?id=85544
1895
1896         Reviewed by Adam Barth.
1897
1898         * TestResultServer/static-dashboards/dashboard_base.js:
1899         (appendJSONScriptElements):
1900         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1901         (resetGlobals):
1902         (runExpectationsTest):
1903         (test):
1904         * TestResultServer/static-dashboards/run-unittests.html: Added.
1905
1906 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
1907
1908         webkitpy: Remove check for readline on Mac.
1909         https://bugs.webkit.org/show_bug.cgi?id=85547
1910
1911         Reviewed by Eric Seidel.
1912
1913         Python 2.5 is not supported by the WebKit project anymore, and
1914         Python's readline documentation does not mention the module not
1915         being available in the supported versions.
1916
1917         * Scripts/webkitpy/common/system/user.py:
1918
1919 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1920
1921         [NRWT] Run performance tests with lock
1922         https://bugs.webkit.org/show_bug.cgi?id=78628
1923
1924         Reviewed by Tony Chang.
1925
1926         Locking performance tests (like we do for http tests) will force them
1927         to run in serial. This reduces the load of the machine when running perf
1928         tests and minimizes the chances of the tests to fail, specially
1929         timeouts.
1930
1931         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1932         (Manager.__init__):
1933         (Manager._is_perf_test):
1934         (Manager._test_requires_lock):
1935         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1936
1937 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
1938
1939         Attempt to fix a crash on SL ...
1940
1941         Unreviewed, build fix.
1942
1943         It looks like we may be getting an IOError raised during
1944         select() on chromium mac, and that error isn't being caught.
1945         Pushing it into the try/catch block will hopefully catch this
1946         and allow us to see why the subprocess is crashing.
1947
1948         * Scripts/webkitpy/layout_tests/port/server_process.py:
1949         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1950
1951 2012-05-02  Jon Honeycutt  <jhoneycutt@apple.com>
1952
1953         WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
1954         implemented for WebKit2
1955         https://bugs.webkit.org/show_bug.cgi?id=84304
1956
1957         Reviewed by Jessie Berlin.
1958
1959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1960         Added new files to project.
1961
1962         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Added.
1963         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1964         Look for the "DidReceiveWillSendSubmitEvent" message. The message body
1965         will be the dictionary of form control names and values passed to the
1966         injected bundle's willSendSubmitEvent handler; look for the pairs
1967         "textField" -> "text field" and "passwordField" -> "password field".
1968         Check that "hiddenField" is not included.
1969         (TestWebKitAPI::setInjectedBundleClient):
1970         (TestWebKitAPI::TEST):
1971
1972         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Added.
1973         (TestWebKitAPI::willSendSubmitEvent):
1974         Post a message to the TestWebKitAPI process with the dictionary of form
1975         control names and values that we received.
1976         (TestWebKitAPI::WillSendSubmitEventTest::WillSendSubmitEventTest):
1977         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
1978         Set up the page's form client.
1979
1980         * TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Added.
1981
1982 2012-05-03  Eric Seidel  <eric@webkit.org>
1983
1984         Remove dead code from build-webkit for working around old XCode dependency bug
1985         https://bugs.webkit.org/show_bug.cgi?id=85535
1986
1987         Reviewed by Adam Barth.
1988
1989         Xcode used to have a bug whereby it didn't notice if you changed the #defines
1990         passed on the command line to xcodebuild.  I wrote code to work around this
1991         while bringing up SVG support 5-6 years ago.  I think we can finally remove this
1992         code from build-webkit, since SVG is the only feature flag to ever use it
1993         (modern in-progress features like MathML don't seem to be using the support)
1994         an I suspect the XCode bug has long been fixed.
1995
1996         * Scripts/build-webkit:
1997         * Scripts/webkitperl/features.pm:
1998
1999 2012-05-03  Andy Estes  <aestes@apple.com>
2000
2001         InjectedBundleControllerMac.mm needs to include config.h
2002         https://bugs.webkit.org/show_bug.cgi?id=85531
2003
2004         Reviewed by Andreas Kling.
2005
2006         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2007
2008 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
2009
2010         webkitpy: Use PlatformInfo whenever possible in server_process.py.
2011         https://bugs.webkit.org/show_bug.cgi?id=85516
2012
2013         Reviewed by Eric Seidel.
2014
2015         Eliminate direct access to sys.platform wherever possible by using
2016         PlatformInfo.is_win() instead.
2017
2018         * Scripts/webkitpy/layout_tests/port/server_process.py:
2019         (ServerProcess.__init__): Remove the executive parameter as it was
2020         not passed by any caller, obtain a SystemHost from port_obj
2021         instead.
2022         (ServerProcess._log): Style, remove extra empty line.
2023         (ServerProcess._start):
2024         (ServerProcess.stop):
2025         (ServerProcess.kill):
2026         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2027         (TrivialMockPort.__init__): Create a MockSystemHost used by
2028         ServerProcess.
2029         (TestServerProcess.test_broken_pipe): Test different platforms.
2030
2031 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2032
2033         webkitpy: Style checker broken when committing a PNG
2034         https://bugs.webkit.org/show_bug.cgi?id=85504
2035
2036         Reviewed by Dirk Pranke.
2037
2038         * Scripts/webkitpy/style/checkers/png.py:
2039         (PNGChecker.__init__):
2040
2041 2012-05-03  Philippe Normand  <pnormand@igalia.com>
2042
2043         Unreviewed, fix another call to join(), similar to the ones landed
2044         in r115975.
2045
2046         * Scripts/webkitdirs.pm:
2047         (jhbuildConfigurationChanged):
2048
2049 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
2050
2051         webkitpy: Remove sys.platform accesses in CrashLogs.
2052         https://bugs.webkit.org/show_bug.cgi?id=85436
2053
2054         Reviewed by Dirk Pranke.
2055
2056         Instead of directly checking for sys.platform == 'darwin', use a
2057         SystemHost and call PlatformInfo.is_mac().
2058
2059         * Scripts/webkitpy/common/system/crashlogs.py:
2060         (CrashLogs.__init__):
2061         (CrashLogs.find_newest_log):
2062         (CrashLogs._log_directory_darwin):
2063         (CrashLogs._find_newest_log_darwin):
2064         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2065         (CrashLogsTest.test_find_log_darwin):
2066         * Scripts/webkitpy/layout_tests/port/mac.py:
2067         (MacPort._get_crash_log):
2068         * Scripts/webkitpy/layout_tests/port/test.py:
2069         (TestDriver.run_test):
2070         * Scripts/webkitpy/tool/commands/queries.py:
2071         (execute):
2072
2073 2012-05-03  Philippe Normand  <pnormand@igalia.com>
2074
2075         [GTK] join() is wrongly used in webkitdirs.pm since r115532
2076         https://bugs.webkit.org/show_bug.cgi?id=85501
2077
2078         Reviewed by Martin Robinson.
2079
2080         * Scripts/webkitdirs.pm:
2081         (getJhbuildPath):
2082         (buildAutotoolsProject):
2083
2084 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
2085
2086         [Gtk] ImageDiff crashes when it can't open a display
2087         https://bugs.webkit.org/show_bug.cgi?id=85476
2088
2089         Reviewed by Martin Robinson.
2090
2091         Replace gdk_init() initialization call with the g_type_init()
2092         call. GdkPixbufLoader doesn't actually need the current call to be
2093         made and this change will also remove crashes when ImageDiff
2094         is started in an environment without a DISPLAY env.
2095
2096         * DumpRenderTree/gtk/ImageDiff.cpp:
2097         (main):
2098
2099 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
2100
2101         ImageDiff should be run inside a properly established environment
2102         https://bugs.webkit.org/show_bug.cgi?id=85292
2103
2104         Reviewed by Martin Robinson.
2105
2106         When creating the ImageDiff server process, pass along a freshly-set-up environment
2107         in which the process should be executed in.
2108
2109         * Scripts/webkitpy/layout_tests/port/webkit.py:
2110         (WebKitPort._start_image_diff_process):
2111
2112 2012-05-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2113
2114         [Qt] Allow the web process and WTR to be paused on startup
2115
2116         Makes it easier to debug the web process or run-webkit-tests -2, as you
2117         have ample time to attach gdb to the process.
2118
2119         Reviewed by Simon Hausmann.
2120
2121         * Scripts/webkitpy/layout_tests/port/qt.py:
2122         (QtPort.setup_environ_for_server):
2123         * WebKitTestRunner/qt/main.cpp:
2124         (main):
2125
2126 2012-05-03  Csaba Osztrogonác  <ossy@webkit.org>
2127
2128         Password protect "Stop build" button
2129         https://bugs.webkit.org/show_bug.cgi?id=81982
2130
2131         Reviewed by Ryosuke Niwa.
2132
2133         Only authenticated users should be able to use stopBuild, stopAllBuilds, cancelPendingBuild
2134         features to prevent killing builds on build.webkit.org by SPAM bots.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2137
2138 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
2139
2140         [DRT] Remove the name of parameter, visibility, from the setPageVisibility stub implementations.
2141         https://bugs.webkit.org/show_bug.cgi?id=85468
2142
2143         Reviewed by Nikolas Zimmermann.
2144
2145         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2146         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
2147         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2148         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
2149         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2150         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
2151         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2152         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
2153         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2154         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
2155
2156 2012-05-03  Stephanie Lewis  <slewis@apple.com>
2157
2158         https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
2159         <rdar://problem/11320059> REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run
2160
2161         Reviewed by Brady Eidson.
2162
2163         The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
2164         for every world, even those that did not need the callback.  This had the side effect of creating a
2165         JSDOMWindowShell that the associated world didn't necessarily know to clean up.  Instead of creating
2166         unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
2167         in the API.  The object can be accessed later by those worlds which require it.
2168
2169         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2170         (TestWebKitAPI):
2171         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2172         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2173         (TestWebKitAPI):
2174         (DOMWindowExtensionBasic):
2175         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
2176         (TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
2177         (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
2178
2179 2012-05-03  Nikolas Zimmermann  <nzimmermann@rim.com>
2180
2181         Not reviewed. Fix mac build, it was missing setPageVisibility/resetPageVisibility stub implementations.
2182
2183         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2184         (LayoutTestController::resetPageVisibility):
2185         (LayoutTestController::setPageVisibility):
2186
2187 2012-05-02  Alexander Færøy  <ahf@0x90.dk>
2188
2189         Rename deviceDPI to devicePixelRatio
2190         https://bugs.webkit.org/show_bug.cgi?id=85049
2191
2192         Reviewed by Kenneth Rohde Christiansen.
2193
2194         Use 1.5 as device pixel ratio for the Qt MiniBrowser.
2195
2196         * MiniBrowser/qt/qml/BrowserWindow.qml:
2197
2198 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
2199
2200         [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
2201         https://bugs.webkit.org/show_bug.cgi?id=85347
2202
2203         Reviewed by Nikolas Zimmermann.
2204
2205         * DumpRenderTree/LayoutTestController.h:
2206         (LayoutTestController):
2207         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2208         (LayoutTestController::resetPageVisibility): Not implemented.
2209         (LayoutTestController::setPageVisibility): Not implemented.
2210         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2211         (LayoutTestController::resetPageVisibility): Reset the page visibility.
2212         (LayoutTestController::setPageVisibility): Set the page visibility.
2213         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2214         (LayoutTestController::resetPageVisibility): Not implemented.
2215         (LayoutTestController::setPageVisibility): Not implemented.
2216         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2217         (LayoutTestController::resetPageVisibility): Not implemented.
2218         (LayoutTestController::setPageVisibility): Not implemented.
2219         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2220         (LayoutTestController::resetPageVisibility): Not implemented.
2221         (LayoutTestController::setPageVisibility): Not implemented.
2222         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2223         (LayoutTestController::resetPageVisibility): Not implemented.
2224         (LayoutTestController::setPageVisibility): Not implemented.
2225
2226 2012-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2227
2228         Unreviewed, rolling out r115918.
2229         http://trac.webkit.org/changeset/115918
2230         https://bugs.webkit.org/show_bug.cgi?id=85452
2231
2232         "Broke test-webkitpy on Apple Lion bots" (Requested by estes
2233         on #webkit).
2234
2235         * Scripts/webkitpy/common/system/crashlogs.py:
2236         (CrashLogs.__init__):
2237         (CrashLogs.find_newest_log):
2238         (CrashLogs._log_directory_darwin):
2239         (CrashLogs._find_newest_log_darwin):
2240         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2241         (CrashLogsTest.test_find_log_darwin):
2242         * Scripts/webkitpy/layout_tests/port/mac.py:
2243         (MacPort._get_crash_log):
2244         * Scripts/webkitpy/layout_tests/port/test.py:
2245         (TestDriver.run_test):
2246         * Scripts/webkitpy/tool/commands/queries.py:
2247         (execute):
2248
2249 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2250
2251         webkitpy: Remove sys.platform accesses in CrashLogs.
2252         https://bugs.webkit.org/show_bug.cgi?id=85436
2253
2254         Reviewed by Dirk Pranke.
2255
2256         Instead of directly checking for sys.platform == 'darwin', use a
2257         SystemHost and call PlatformInfo.is_mac().
2258
2259         * Scripts/webkitpy/common/system/crashlogs.py:
2260         (CrashLogs.__init__):
2261         (CrashLogs.find_newest_log):
2262         (CrashLogs._log_directory_darwin):
2263         (CrashLogs._find_newest_log_darwin):
2264         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2265         (CrashLogsTest.test_find_log_darwin):
2266         * Scripts/webkitpy/layout_tests/port/mac.py:
2267         (MacPort._get_crash_log):
2268         * Scripts/webkitpy/layout_tests/port/test.py:
2269         (TestDriver.run_test):
2270         * Scripts/webkitpy/tool/commands/queries.py:
2271         (execute):
2272
2273 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2274
2275         webkitpy: Special-case win32 calls in file_lock and executive.
2276         https://bugs.webkit.org/show_bug.cgi?id=85431
2277
2278         Reviewed by Dirk Pranke.
2279
2280         Simplify accesses to sys.platform by only checking if sys.platform
2281         is "win32" and removing explicit checks for the else case.
2282
2283         * Scripts/webkitpy/common/system/executive.py:
2284         (Executive.check_running_pid):
2285         * Scripts/webkitpy/common/system/file_lock.py:
2286         (FileLock._create_lock):
2287         (FileLock._remove_lock):
2288
2289 2012-05-02  Ojan Vafai  <ojan@chromium.org>
2290
2291         Remove pink from flakiness dashboard
2292         https://bugs.webkit.org/show_bug.cgi?id=85422
2293
2294         Reviewed by Dirk Pranke.
2295
2296         The pink indicates that the test doesn't match it's listing in test_expectations.txt.
2297         In practice, this just added noise and confused people.
2298
2299         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2300         (htmlForSingleTestRow):
2301         (showLegend):
2302         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
2303         (#legend-contents *):
2304         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2305         (testHtmlForSingleTestRow):
2306
2307 2012-05-02  Gustavo Noronha Silva  <gns@gnome.org>
2308
2309         Unreviewed. Fix mistake I committed when applying review comments.
2310
2311         * jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
2312         appended to its path, so jhbuild itself was being cloned and
2313         installed in the wrong place when using WEBKITOUTPUTDIR.
2314
2315 2012-05-02  Dirk Pranke  <dpranke@chromium.org>
2316
2317         nrwt: make ServerProcess work on chromium win
2318         https://bugs.webkit.org/show_bug.cgi?id=85333
2319
2320         Reviewed by Ojan Vafai.
2321
2322         This change implements a poor man's select() that will
2323         slow-spin doing non-blocking reads on the stdout and stderr
2324         named pipes connecting the worker to the driver. Seems to work
2325         and I have yet to see much overhead or ill effects but it
2326         probably needs more testing.
2327
2328         * Scripts/webkitpy/layout_tests/port/chromium.py:
2329         (ChromiumDriver.__init__):
2330         * Scripts/webkitpy/layout_tests/port/server_process.py:
2331         (ServerProcess._start):
2332         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2333         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2334         (ServerProcess):
2335         (ServerProcess._non_blocking_read_win32):
2336         (ServerProcess._read):
2337         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2338         (TestServerProcess.test_basic): Added.
2339
2340 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2341
2342         webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
2343         https://bugs.webkit.org/show_bug.cgi?id=85426
2344
2345         Reviewed by Dirk Pranke.
2346
2347         r115880 replaced the direct use of sys.platform with a
2348         PlatformInfo object. Dirk Pranke later told me SystemHost objects
2349         should be preferred, as nothing out of webkitpy.common.system
2350         should create its own PlatformInfo instances.
2351
2352         * Scripts/webkitpy/common/system/systemhost_mock.py:
2353         (MockSystemHost.__init__): Make it possible to specify a custom
2354         filesystem object.
2355         * Scripts/webkitpy/style/checkers/png.py:
2356         (PNGChecker.__init__): Accept a host object instead of a
2357         filesystem one, which is now obtained from host.
2358         (PNGChecker._config_file_path): Retrieve PlatformInfo from
2359         SystemHost.
2360         * Scripts/webkitpy/style/checkers/png_unittest.py:
2361         (PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
2362         constructor signature.
2363         (PNGCheckerTest.test_check): Ditto.
2364
2365 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2366
2367         webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
2368         https://bugs.webkit.org/show_bug.cgi?id=85424
2369
2370         Reviewed by Tony Chang.
2371
2372         We should reduce direct usage of sys.platform in webkitpy and use
2373         PlatformInfo instead.
2374
2375         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2376         (Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
2377         checking for 'darwin' directly.
2378         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2379         (HttpServerBase.__init__): Ditto.
2380
2381 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2382
2383         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
2384         https://bugs.webkit.org/show_bug.cgi?id=85419
2385
2386         Reviewed by Dirk Pranke.
2387
2388         As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
2389         be created directly, we should should a SystemHost instead.
2390
2391         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2392         (MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
2393         object from it instead of creating PlatformInfo directly.
2394
2395 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2396
2397         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
2398         https://bugs.webkit.org/show_bug.cgi?id=85419
2399
2400         Rubber-stamped by Dirk Pranke.
2401
2402         Follow-up patch to r115887 which fixes some capitalization problems
2403         pointed out in comments 2 and 4.
2404
2405         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2406         (MainTest.setUp):
2407         (MainTest.test_child_processes_2):
2408         (MainTest.test_child_processes_min):
2409         (MainTest.test_exception_raised):
2410         (MainTest.test_keyboard_interrupt):
2411
2412 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2413
2414         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
2415         https://bugs.webkit.org/show_bug.cgi?id=85419
2416
2417         Reviewed by Dirk Pranke.
2418
2419         Another part of the work towards replacing direct sys.platform
2420         usage with PlatformInfo.
2421
2422         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2423         (MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
2424         here. Even though it is costlier, unittest.setUpClass was
2425         introduced in Python 2.7.
2426         (MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
2427         (MainTest.test_child_processes_min): Ditto.
2428         (MainTest.test_exception_raised): Ditto.
2429         (MainTest.test_keyboard_interrupt): Ditto.
2430         (MainTest.test_crash_log): Check for PlatformInfo.is_mac().
2431         (MainTest.test_web_process_crash_log): Ditto, and remove duplicate
2432         check at the end.
2433         (MainTest.test_no_http_tests): Remove check for (cygwin && Python
2434         2.5.2), as we only support Python 2.6+.
2435
2436 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2437
2438         webkitpy: Remove direct sys.platform usage in the PNG checker.
2439         https://bugs.webkit.org/show_bug.cgi?id=85407
2440
2441         Reviewed by Tony Chang.
2442
2443         Work towards replacing direct sys.platform usage with
2444         PlatformInfo.
2445
2446         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2447         (MockPlatformInfo.__init__): Accept os_name and os_version as
2448         arguments.
2449         * Scripts/webkitpy/style/checkers/png.py:
2450         (PNGChecker.__init__): Create a PlatformInfo object instead of
2451         using sys.platform when needed.
2452         (PNGChecker._config_file_path): Check for the current platform via
2453         PlatformInfo.
2454         * Scripts/webkitpy/style/checkers/png_unittest.py:
2455         (PNGCheckerTest.test_check): Update tests after the changes above.
2456
2457 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
2458
2459         [watchlist] Update watchlist rules for EFL-related patches.
2460         http://bugs.webkit.org/show_bug.cgi?id=85160
2461
2462         Reviewed by Eric Seidel.
2463
2464         * Scripts/webkitpy/common/config/watchlist: Monitor
2465         Source/WTF/wtf/efl and LayoutTests/platform/efl as well.
2466
2467 2012-05-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2468
2469         Revert r115191 - "Make the web view's url property follow the active url"
2470
2471         It uncovered/caused issues in the icon-implementation that can't be
2472         easily fixed, so rolling out instead.
2473
2474         https://bugs.webkit.org/show_bug.cgi?id=77554
2475
2476         Rubber-stamped by Simon Hausmann.
2477
2478         * MiniBrowser/qt/qml/BrowserWindow.qml:
2479         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2480         (TestWebKitAPI::TEST):
2481
2482 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
2483
2484         Reftest mismatches are providing undefined diff percent in results.html
2485         https://bugs.webkit.org/show_bug.cgi?id=85283
2486
2487         Reviewed by Ojan Vafai.
2488
2489         When writing test results for a reftest mismatch, also take into account the
2490         difference percent that is produced when generating image diff. This value is
2491         then used when creating test results in the form of dictionaries, stored under
2492         the 'image_diff_percent' key. It ultimately ends up in JSON results data,
2493         providing additional information about the reftest difference.
2494
2495         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2496         (interpret_test_failures): Store the diff percent for reftest failure under the
2497         'image_diff_percent' key.
2498         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2499         (write_test_result): Also set the new diff_percent attribute of the reftest
2500         mismatch failure to the value of the difference percent ImageDiff outputs.
2501         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2502         (FailureReftestMismatch.__init__): Add the new diff_percent attribute with the
2503         default value of None.
2504         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2505         (EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.
2506
2507 2012-05-02  Terry Anderson  <tdanderson@chromium.org>
2508
2509         Addition of a contributor to committers.py
2510         https://bugs.webkit.org/show_bug.cgi?id=85324
2511
2512         Reviewed by Unreviewed.
2513
2514         * Scripts/webkitpy/common/config/committers.py:
2515
2516 2012-05-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2517
2518         [EFL] EFL's LayoutTestController overridePreference implementation
2519         https://bugs.webkit.org/show_bug.cgi?id=83007
2520
2521         Reviewed by Antonio Gomes.
2522
2523         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2524         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2525         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2526         (toBool): aux function converting JSStringRef to bool
2527         (toInt): aux function converting JSStringRef to int
2528         (LayoutTestController::overridePreference): added implementation
2529
2530 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
2531
2532         webkitpy: Fix sys.platform check in find_files_unittest.
2533         https://bugs.webkit.org/show_bug.cgi?id=85339
2534
2535         Reviewed by Ryosuke Niwa.
2536
2537         Follow-up to r101618 -- 'win' is not a valid sys.platform value,
2538         'win32' should be used instead. The check always returned false
2539         due to this, so assert_normalize() was never called.
2540
2541         * Scripts/webkitpy/common/find_files_unittest.py:
2542         (TestWinNormalize.test_win): Add the missing import for the
2543         FileSystem class and fix the sys.platform check.
2544
2545 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
2546
2547         [GTK] drag&drop related failures
2548         https://bugs.webkit.org/show_bug.cgi?id=84675
2549
2550         Reviewed by Philippe Normand.
2551
2552         Rather than checking options to see whether we're running pixel tests
2553         the pixel_tests argument passed to GtkDriver._start should be used as
2554         it also covers cases when pixel tests should be run because of testing
2555         reftests. This again creates different Xvfb processes with proper
2556         display IDs for a worker that's performing both ordinary and pixel
2557         tests, as was the case before changes made in r114788.
2558
2559         * Scripts/webkitpy/layout_tests/port/gtk.py:
2560         (GtkDriver._start):
2561
2562 2012-05-02  Simon Hausmann  <simon.hausmann@nokia.com>
2563
2564         [Qt] Enable device orientation/motion with Qt 5
2565
2566         Reviewed by Tor Arne Vestbø.
2567
2568         Enable device orientation/motion features with Qt 5 if Qt Sensors is available.
2569
2570         * qmake/mkspecs/features/features.prf:
2571
2572 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
2573
2574         webkitpy: Remove unused platform imports.
2575         https://bugs.webkit.org/show_bug.cgi?id=85341
2576
2577         Reviewed by Eric Seidel.
2578
2579         Remove a few uses of `import platform' which were either rendered
2580         unneeded after r105931 or were never needed at all.
2581
2582         * Scripts/webkitpy/common/system/executive.py:
2583         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2584
2585 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
2586
2587         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
2588         https://bugs.webkit.org/show_bug.cgi?id=85289
2589
2590         Reviewed by Eric Seidel.
2591
2592         * DumpRenderTree/chromium/EventSender.cpp:
2593         (EventSender::gestureEvent):
2594             This change will allow for testing of WK85101. Currently
2595             no tests use the extra parameters deltaX and deltaY. Added
2596             a check for the size of |arguments|.
2597
2598 2012-05-01  Eric Seidel  <eric@webkit.org>
2599
2600         Add myself to the watchlist to watch all rendering changes, as well as sort the watchers in the list
2601         https://bugs.webkit.org/show_bug.cgi?id=85305
2602
2603         Reviewed by Adam Barth.
2604
2605         * Scripts/webkitpy/common/config/watchlist:
2606
2607 2012-05-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2608
2609         Unreviewed, rolling out r115735.
2610         http://trac.webkit.org/changeset/115735
2611         https://bugs.webkit.org/show_bug.cgi?id=85314
2612
2613         cause two tests to crash due to an ASSERTION failure
2614         (Requested by zhenyao on #webkit).
2615
2616         * DumpRenderTree/chromium/EventSender.cpp:
2617         (EventSender::gestureEvent):
2618
2619 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
2620
2621         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
2622         https://bugs.webkit.org/show_bug.cgi?id=85289
2623
2624         Reviewed by Eric Seidel.
2625
2626         * DumpRenderTree/chromium/EventSender.cpp:
2627         (EventSender::gestureEvent):
2628             This change will allow for testing of WK85101. Currently no tests use the extra
2629             parameters deltaX and deltaY.
2630
2631 2012-05-01  Zan Dobersek  <zandobersek@gmail.com>
2632
2633         Print out stderr output of ImageDiff if it is present
2634         https://bugs.webkit.org/show_bug.cgi?id=85285
2635
2636         Reviewed by Philippe Normand.
2637
2638         Log the stderr output of ImageDiff as a warning if present. This is
2639         especially helpful when ImageDiff crashes and stderr data might contain
2640         relevant information about what caused the crash.
2641
2642         * Scripts/webkitpy/layout_tests/port/webkit.py:
2643         (WebKitPort._read_image_diff):
2644
2645 2012-05-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2646
2647         [Qt] Add an experimental extension to set the min. contents width
2648         https://bugs.webkit.org/show_bug.cgi?id=85281
2649
2650         Reviewed by Antonio Gomes.
2651
2652         * MiniBrowser/qt/qml/BrowserWindow.qml:
2653
2654         Set the value of preferredMinimumContentsWidth to 980.
2655
2656 2012-04-30  Ojan Vafai  <ojan@chromium.org>
2657
2658         Fix tests to not depend on the actual list of builders at build.chromium.org.
2659
2660         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2661         (testHtmlForIndividualTestOnAllBuildersWithChrome):
2662         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
2663
2664 2012-04-29  Sam Weinig  <sam@webkit.org>
2665
2666         Remove BlobBuilder
2667         https://bugs.webkit.org/show_bug.cgi?id=84036
2668
2669         Reviewed by Anders Carlsson.
2670
2671         * Scripts/build-webkit:
2672         * qmake/mkspecs/features/features.prf:
2673         Make exposing the WebKitBlobBuilder JS object conditional on a new
2674         ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
2675         but do for everyone else.
2676
2677 2012-04-30  Amruth Raj Padmanabhuni  <amruthraj@motorola.com>
2678
2679         [GTK] Add glib as a dependency to build glib-networking
2680         https://bugs.webkit.org/show_bug.cgi?id=85181
2681
2682         Reviewed by Martin Robinson.
2683
2684         * gtk/jhbuild.modules:
2685
2686 2012-04-30  Alexis Menard  <alexis.menard@openbossa.org>
2687
2688         Move myself to reviewers.
2689
2690         Reviewed by Andreas Kling.
2691
2692         * Scripts/webkitpy/common/config/committers.py:
2693
2694 2012-04-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2695
2696         Unreviewed, move myself to reviewers
2697
2698         * Scripts/webkitpy/common/config/committers.py:
2699
2700 2012-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2701
2702         Unreviewed. Fix make distcheck.
2703
2704         * TestWebKitAPI/GNUmakefile.am: Add missing headers to compilation
2705         and resources to EXTRA_DIST.
2706
2707 2012-04-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2708
2709         [GTK] DRT support for layoutTestController.removeOriginAccessWhitelistEntry
2710         https://bugs.webkit.org/show_bug.cgi?id=85156
2711
2712         Reviewed by Martin Robinson.
2713
2714         Add missing implementation removeOriginAccessWhitelistEntry to
2715         GTK's LayoutTestController.
2716
2717         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2718         (LayoutTestController::removeOriginAccessWhitelistEntry):
2719
2720 2012-04-29  Maciej Stachowiak  <mjs@apple.com>
2721
2722         REGRESSION: On Lion, run-webkit-tests changes the display color profile even when not running pixel tests
2723         https://bugs.webkit.org/show_bug.cgi?id=81729
2724
2725         Reviewed by Dan Bernstein.
2726
2727         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2728         (Manager._set_up_run): Only launch LayoutTestHelper when running pixel tests.
2729
2730 2012-04-29  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2731
2732         [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
2733         https://bugs.webkit.org/show_bug.cgi?id=85131
2734
2735         Reviewed by Martin Robinson.
2736
2737         Add missing implementation setDomainRelaxationForbiddenForURLScheme to
2738         GTK's LayoutTestController.
2739
2740         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2741         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2742
2743 2012-04-28  Sam Weinig  <sam@webkit.org>
2744
2745         Smooth scrolling needs a new key
2746         <rdar://problem/11331632>
2747
2748         Reviewed by Dan Bernstein.
2749
2750         * DumpRenderTree/mac/DumpRenderTree.mm:
2751         (resetDefaultsToConsistentValues):
2752         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2753         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2754         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2755         (WTR::InjectedBundle::platformInitialize):
2756         Update for new key.
2757
2758 2012-04-28  Zan Dobersek  <zandobersek@gmail.com>
2759
2760         [WK2] http/tests/navigation/anchor-frames-gbk.html fails
2761         https://bugs.webkit.org/show_bug.cgi?id=76896
2762
2763         Reviewed by Darin Adler.
2764
2765         Only dump as text if currently dumping render tree. This ensures that
2766         calling dumpAsText in a test with dumpChildFramesAsText already being
2767         called doesn't override the first decision, possibly making tests fail.
2768
2769         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2770         (WTR::LayoutTestController::dumpAsText):
2771
2772 2012-04-28  Dan Winship  <danw@gnome.org>
2773
2774         Unreviewed; Add me to the SoupNetwork watchlist
2775
2776         * Scripts/webkitpy/common/config/watchlist:
2777
2778 2012-04-27  Gustavo Noronha Silva  <gns@gnome.org>
2779
2780         [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
2781         https://bugs.webkit.org/show_bug.cgi?id=76161
2782
2783         Reviewed by Martin Robinson.
2784
2785         * Scripts/webkitdirs.pm:
2786         (getJhbuildPath): New method to obtain the jhbuild base directory,
2787         using the product base directory
2788         (jhbuildConfigurationChanged): Use the new method
2789         (buildAutotoolsProject): Ditto.
2790         * efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
2791         * gtk/jhbuildrc: Ditto.
2792         * jhbuild/jhbuild-wrapper: Ditto.
2793
2794 2012-04-27  Scott Graham  <scottmg@chromium.org>
2795
2796         [chromium] make case of npTestNetscapePlugIn.dll match case in copy rule
2797         https://bugs.webkit.org/show_bug.cgi?id=85083
2798
2799         Reviewed by Dirk Pranke.
2800
2801         Make output product_name for npTestNetscapePlugIn.dll match the case
2802         of the copy_TestNetscapePlugIn rule. This is required for ninja, which
2803         is more particular about case matching in rules than the VS build.
2804
2805         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2806
2807 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
2808
2809         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
2810         https://bugs.webkit.org/show_bug.cgi?id=84917
2811
2812         Unreviewed, build fix.
2813
2814         Reland the change in r115453 with a fix for chromium win.
2815         The logic in ChromiumDriver was busted on windows, causing DRT
2816         to get launched without the --test-shell flag.
2817
2818         * Scripts/webkitpy/layout_tests/port/chromium.py:
2819         (ChromiumDriver):
2820         (ChromiumDriver.__init__):
2821         (ChromiumDriver._wrapper_options):
2822         (ChromiumDriver.cmd_line):
2823         (ChromiumDriver._start):
2824         (ChromiumDriver.has_crashed):
2825         (ChromiumDriver.run_test):
2826         (ChromiumDriver.stop):
2827         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2828         (ChromiumDriverTest.setUp):
2829         (ChromiumDriverTest.test_stop):
2830         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
2831         (ChromiumDriverTest.test_two_drivers):
2832
2833 2012-04-27  Peter Beverloo  <peter@chromium.org>
2834
2835         Add John Grabowski as a non-committer to committers.py
2836         https://bugs.webkit.org/show_bug.cgi?id=85080
2837
2838         Reviewed by Dirk Pranke.
2839
2840         He's being CC'ed often enough because of his involvement in the Chromium
2841         side of Chrome for Android upstreaming.
2842
2843         * Scripts/webkitpy/common/config/committers.py:
2844           add jrg@chromium.org
2845
2846 2012-04-27  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2847
2848         [Qt] Fix minimal build.
2849         https://bugs.webkit.org/show_bug.cgi?id=85045
2850
2851         Reviewed by Tor Arne Vestbø.
2852
2853         Do not set conflicting values of ENABLE_XSLT.
2854
2855         * qmake/mkspecs/features/features.prf:
2856
2857 2012-04-27  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2858
2859         [EFL][DRT] EFL should sanitize pulseaudio module configuration too
2860         https://bugs.webkit.org/show_bug.cgi?id=85047
2861
2862         Reviewed by Dirk Pranke.
2863
2864         PulseAudio test setup sanitization shared between EFL and GTK.
2865
2866         * Scripts/webkitpy/layout_tests/port/efl.py:
2867         (EflPort):
2868         (EflPort.setup_test_run):
2869         (EflPort.clean_up_test_run):
2870         * Scripts/webkitpy/layout_tests/port/gtk.py:
2871         (GtkPort): Moving pulseaudio unload/restore out to shared class.
2872         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py: Added.
2873         (PulseAudioSanitizer):
2874         (PulseAudioSanitizer._unload_pulseaudio_module):
2875         (PulseAudioSanitizer._restore_pulseaudio_module):
2876
2877 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
2878
2879         Unreviewed, revert r115453 - broke chromium win bots
2880
2881         * Scripts/webkitpy/layout_tests/port/chromium.py:
2882         (ChromiumPort._path_to_image_diff):
2883         (ChromiumDriver):
2884         (ChromiumDriver.__init__):
2885         (ChromiumDriver._wrapper_options):
2886         (ChromiumDriver.cmd_line):
2887         (ChromiumDriver.stop):
2888         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2889         (ChromiumDriverTest.setUp):
2890         (ChromiumDriverTest.test_stop):
2891         (ChromiumDriverTest.test_two_drivers):
2892         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
2893
2894 2012-04-27  Ryosuke Niwa  <rniwa@webkit.org>
2895
2896         Chromium Windows Perf bots timeout due to not output
2897         https://bugs.webkit.org/show_bug.cgi?id=84940
2898
2899         Reviewed by Dirk Pranke.
2900
2901         Dirk and I investigated the issue on the bot but we couldn't figure out what is going wrong.
2902         Since we run-perf-tests don't need any of fancy feature printer provides, just use python's
2903         built-in logging module instead. Printing out to stdout and stderr seem to work so hopefully
2904         this will fix the issue on the bot.
2905
2906         * Scripts/run-perf-tests:
2907         * Scripts/webkitpy/performance_tests/perftest.py:
2908         (PerfTest.run):
2909         (PerfTest.run_failed):
2910         (PerfTest.parse_output):
2911         (PerfTest.output_statistics):
2912         (ChromiumStylePerfTest.parse_output):
2913         (PageLoadingPerfTest.run):
2914         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2915         (MainTest.test_parse_output):
2916         (MainTest.test_parse_output_with_failing_line):
2917         (TestPageLoadingPerfTest):
2918         (TestPageLoadingPerfTest.test_run):
2919         (TestPageLoadingPerfTest.test_run_with_bad_output):
2920         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2921         (PerfTestsRunner.__init__):
2922         (PerfTestsRunner._parse_args):
2923         (PerfTestsRunner.run):
2924         (PerfTestsRunner._upload_json):
2925         (PerfTestsRunner._print_status):
2926         (PerfTestsRunner._run_tests_set):
2927         (PerfTestsRunner._run_single_test):
2928         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2929         (create_runner):
2930         (test_run_test_set):
2931         (test_run_test_set_kills_drt_per_run):
2932         (test_run_test_pause_before_testing):
2933         (test_run_test_set_for_parser_tests):
2934         (test_run_test_set_with_json_output):
2935         (test_run_test_set_with_json_source):
2936         (test_run_test_set_with_multiple_repositories):
2937         (test_upload_json):
2938         (test_parse_args):
2939
2940 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
2941
2942         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
2943         https://bugs.webkit.org/show_bug.cgi?id=84917
2944
2945         Reviewed by Ojan Vafai.
2946
2947         This change changes the chromium new-run-webkit-tests
2948         implementation to use the code in WebKitDriver and ServerProcess
2949         by default on Mac and Linux, instead of using the old-style
2950         Chromium/test_shell style of output.
2951
2952         We will still use the test_shell style on Windows for now
2953         and you can still get the old style of behavior with
2954         new-run-webkit-tests --additional-drt-flag --test-shell
2955
2956         * Scripts/webkitpy/layout_tests/port/chromium.py:
2957         (ChromiumDriver):
2958         (ChromiumDriver.__init__):
2959         (ChromiumDriver._wrapper_options):
2960         (ChromiumDriver.cmd_line):
2961         (ChromiumDriver._start):
2962         (ChromiumDriver.has_crashed):
2963         (ChromiumDriver.run_test):
2964         (ChromiumDriver.stop):
2965         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2966         (ChromiumDriverTest.setUp):
2967         (ChromiumDriverTest.test_stop):
2968         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
2969         (ChromiumDriverTest.test_two_drivers):
2970
2971 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
2972
2973         webkitpy: fix race in unit tests for manager_worker_broker
2974         https://bugs.webkit.org/show_bug.cgi?id=84925
2975
2976         Reviewed by Ojan Vafai.
2977
2978         I have been intermittently seeing hangs when running
2979         test-webkitpy on Mac SL; it appears that there's a bug (?) in
2980         the multiprocessing module where queue references are getting
2981         leaked or not cleaned up somehow. By explicitly closing the
2982         queues, things seem to be happy, so this patch adds a cleanup()
2983         method to the message broker and modifies the manager (and the
2984         unit tests) to call it. This may get rid of the intermittent
2985         error on shutdown on Linux I've seen as well.
2986
2987         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2988         (Manager._run_tests):
2989         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2990         (_Broker.__del__):
2991         (_Broker):
2992         (_Broker.cleanup):
2993         (_BrokerConnection.cleanup):
2994         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2995         (_TestsMixin.test_name):
2996         (_TestsMixin.test_cancel):
2997         (_TestsMixin.test_done):
2998         (_TestsMixin.test_unknown_message):
2999
3000 2012-04-27  Gavin Peters  <gavinp@chromium.org>
3001
3002         Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
3003         https://bugs.webkit.org/show_bug.cgi?id=84871
3004
3005         Reviewed by Adam Barth.
3006
3007         Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
3008         API separates it from prefetching.  Having separate include guards lets ports enable prefetching,
3009         a relatively easy change, without needing to build the infrastructure for prerendering, which
3010         is considerably more complicated.
3011
3012 2012-04-27  Philippe Normand  <pnormand@igalia.com>
3013
3014         Unreviewed, GTK gardening.
3015
3016         * Scripts/run-gtk-tests:
3017         (TestRunner): Skip flaky WebKit2 API test.
3018
3019 2012-04-27  Philippe Normand  <pnormand@igalia.com>
3020
3021         Unreviewed, GTK gardening.
3022
3023         * Scripts/run-gtk-tests:
3024         (TestRunner): Fix another typo. So easy to get confused by a Test
3025         name and the actual name of the executable...
3026
3027 2012-04-27  Philippe Normand  <pnormand@igalia.com>
3028
3029         Unreviewed, GTK gardening.
3030
3031         * Scripts/run-gtk-tests:
3032         (TestRunner): Skip failing WebKit2 API test.
3033
3034 2012-04-27  Christophe Dumez  <christophe.dumez@intel.com>
3035
3036         [EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()
3037         https://bugs.webkit.org/show_bug.cgi?id=81891
3038
3039         Reviewed by Philippe Normand.
3040
3041         Implement support for LayoutTestController's
3042         dumpResourceLoadCallbacks() in EFL's DumpRenderTree by catching new
3043         ewk_view signals about resource loading and print out the expected
3044         information. This allows for several test cases to be removed from the
3045         skip list.
3046
3047         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3048         (DumpRenderTreeChrome::createView):
3049         (descriptionSuitableForTestResult):
3050         (DumpRenderTreeChrome::onResponseReceived):
3051         (DumpRenderTreeChrome::onResourceLoadFinished):
3052         (DumpRenderTreeChrome::onResourceLoadFailed):
3053         (DumpRenderTreeChrome::onNewResourceRequest):
3054         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3055         (DumpRenderTreeChrome):
3056
3057 2012-04-27  Philippe Normand  <pnormand@igalia.com>
3058
3059         Unreviewed, GTK typo fix.
3060
3061         * Scripts/run-gtk-tests:
3062         (TestRunner): Fix-up skipped WebKit2 API test name TestWKConnection.
3063
3064 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3065
3066         [SOUP] Add a way to register custom uri schemes in WebKit2
3067         https://bugs.webkit.org/show_bug.cgi?id=84130
3068
3069         Reviewed by Martin Robinson.
3070
3071         * Scripts/webkitpy/style/checkers/cpp.py:
3072         (check_identifier_name_in_declaration): Add webkit_soup prefix to
3073         the list of exceptions to the underscores in identifiers rule.
3074
3075 2012-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3076
3077         Extract PerfTestFactory
3078         https://bugs.webkit.org/show_bug.cgi?id=83944
3079
3080         Reviewed by Dirk Pranke.
3081         
3082         Extracted PerfTestFactory out of PerfTest. This class creates appropriate PerfTest object given
3083         a test name and a path. Also removed dirname from the constructors of PerfTest and its subclasses.
3084
3085         Also added simple test cases to sanity check PerfTestFactory.
3086
3087         * Scripts/webkitpy/performance_tests/perftest.py:
3088         (PerfTest.__init__):
3089         (PerfTest.test_name):
3090         (ChromiumStylePerfTest.__init__):
3091         (PageLoadingPerfTest.__init__):
3092         (PageLoadingPerfTest.run):
3093         (PerfTestFactory):
3094         (PerfTestFactory.create_perf_test):
3095         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3096         (MainTest.test_parse_output):
3097         (MainTest.test_parse_output_with_failing_line):
3098         (TestPageLoadingPerfTest.test_run):
3099         (TestPageLoadingPerfTest.test_run_with_bad_output):
3100         (TestPerfTestFactory):
3101         (TestPerfTestFactory.test_regular_test):
3102         (TestPerfTestFactory.test_inspector_test):
3103         (TestPerfTestFactory.test_page_loading_test):
3104         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3105         (PerfTestsRunner):
3106         (PerfTestsRunner._collect_tests):
3107         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3108         (run_test):
3109         (_tests_for_runner):
3110
3111 2012-04-26  Dirk Pranke  <dpranke@chromium.org>
3112
3113         nrwt: clean up server process, webkit driver so chromium can use it
3114         https://bugs.webkit.org/show_bug.cgi?id=84910
3115
3116         Reviewed by Ojan Vafai.
3117
3118         This change moves the "sample a process" logic out of
3119         server_process.py and into a port-specific class (where really
3120         only the mac has an implementation), and also preemptively kills
3121         DRT when a test times out in WebKitDriver (rather than waiting through the
3122         additional delays caused by calling stop() when we would want to
3123         restart the driver generically in worker.py).
3124
3125         These changes will make it possible for the chromium port to
3126         switch over to the stock WebKitDriver implementation, at least
3127         on mac and linux.
3128
3129         * Scripts/webkitpy/layout_tests/port/base.py:
3130         (Port.sample_process):
3131         * Scripts/webkitpy/layout_tests/port/mac.py:
3132         (MacPort.sample_process):
3133         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3134         (test_helper_fails_to_stop):
3135         (test_sample_process):
3136         (test_sample_process.logging_run_command):
3137         (test_sample_process_throws_exception):
3138         (test_sample_process_throws_exception.throwing_run_command):
3139         * Scripts/webkitpy/layout_tests/port/server_process.py:
3140         (ServerProcess._log):
3141         (ServerProcess._handle_timeout):
3142         (ServerProcess.stop):
3143         (ServerProcess):
3144         (ServerProcess.kill): Here we add a method to immediately stop
3145         the process rather than trying to shut it down cleanly.
3146         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3147         (TestServerProcess.test_broken_pipe):
3148         * Scripts/webkitpy/layout_tests/port/webkit.py:
3149         (WebKitDriver.run_test): Fix an issue where we weren't passing
3150         along any per-test args (only needed for Chromium, but still).
3151         Also, kill the driver immediately if we time out a test.
3152
3153 2012-04-26  Benjamin Poulain  <bpoulain@apple.com>
3154
3155         ObjcClass::methodsNamed() can leak if buffer is dynamically allocated
3156         https://bugs.webkit.org/show_bug.cgi?id=84668
3157
3158         Reviewed by Alexey Proskuryakov.
3159
3160         Extend ObjCPlugin to support the new layout tests of the Objective-C bridge.
3161
3162         * DumpRenderTree/mac/ObjCPlugin.m:
3163         (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
3164         (+[ObjCPlugin webScriptNameForSelector:]):
3165         (-[ObjCPlugin methodMappedToLongName]):
3166         (-[ObjCPlugin testConversionColon:]):
3167         (-[ObjCPlugin _:]):
3168
3169 2012-04-26  Dimitri Glazkov  <dglazkov@chromium.org>
3170
3171         Unreviewed, rolling out r115340.
3172         http://trac.webkit.org/changeset/115340
3173         https://bugs.webkit.org/show_bug.cgi?id=83048
3174
3175         Does not work with Windows.
3176
3177         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3178         (SingleTestRunner._run_reftest):
3179         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3180         (copy_file):
3181         * Scripts/webkitpy/layout_tests/port/base.py:
3182         (Port._parse_reftest_list):
3183         (Port.reference_files):
3184         (Port._real_tests):
3185         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3186         (PortTest.test_reference_files):
3187         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3188         (ChromiumDriverTest.test_write_command_and_read_line):
3189
3190 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
3191
3192         [EFL] Enable VIDEO_TRACK feature
3193         https://bugs.webkit.org/show_bug.cgi?id=84830
3194
3195         Reviewed by Gustavo Noronha Silva.
3196
3197         Enable VIDEO_TRACK by default on EFL port whenever build-webkit is
3198         used.
3199
3200         * Scripts/build-webkit:
3201
3202 2012-04-08  Robert Hogan  <robert@webkit.org>
3203
3204         new-webkit-run-tests: handle ref tests from the CSS test suite
3205         https://bugs.webkit.org/show_bug.cgi?id=83048
3206
3207         Reviewed by Ryosuke Niwa.
3208
3209         This allows new-run-webkit-tests to run reference tests created for the CSS test suite. It removes a big swathe
3210         of pixel and text results that are no longer required now that the reference results are used and adds in the support
3211         files from the CSS test suite that allow the ref tests to run.
3212
3213         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3214         (SingleTestRunner._run_reftest): Assert that the reference result exists. Previously the test would
3215          run without it and report a pass!
3216         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3217         (copy_file): ensure the output directory exists, it may not if the reference test is
3218           contained in a folder that contains nothing but reference tests.
3219         * Scripts/webkitpy/layout_tests/port/base.py:
3220         (Port.available_reference_files): Add as a helper. Handle embedded relative paths, e.g: some/../path
3221         (Port.reference_files): Only return reference results in the reftest list that actually exist on
3222           disk. Also, don't ignore potential reference results on disk that are not in the reftest list, and
3223           don't ignore them just because we have a reftest list for the test's directory.
3224         (Port._real_tests): ignore anything that looks like a test in a 'support' directory, this semantic
3225           is used by the CSS 2.1 test suite.
3226         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3227         (PortTest.test_reference_files_when_reftestlist_and_reference_file_present): Ensure that a test with a reference result
3228           on disk but no reference result listed in the directory's reftest list picks up its reference result.
3229         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3230         (ChromiumDriverTest.test_strip_uri): Test that some/test.html and some/other/../test.html are treated
3231          as the same file.
3232
3233 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3234
3235         Unreviewed. Fix GTK+ build after r115314.
3236
3237         For some reason it fails while bulding GtkVersioning for WTR, but
3238         it didn't fail neither in EWS nor in my laptop. We don't really
3239         need GtkVersioning in WTR since it already depends on GTK+3
3240         unconditionally.
3241
3242         * WebKitTestRunner/GNUmakefile.am: Remove GtkVersioning.c from
3243         compilation.
3244         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3245         (WTR::EventSenderProxy::createMouseButtonEvent): Use GTK+ 3 API
3246         directly instead of getDefaultGDKPointerDevice() helper.
3247         (WTR::EventSenderProxy::keyDown): Ditto.
3248         (WTR::EventSenderProxy::mouseMoveTo): Ditto.
3249
3250 2012-04-24  Ojan Vafai  <ojan@chromium.org>
3251
3252         Show flakiness dashboard data in garden-o-matic
3253         https://bugs.webkit.org/show_bug.cgi?id=83716
3254
3255         Reviewed by Dimitri Glazkov.
3256
3257         Put an iframe below the expected/actual results in the Results view.
3258         Size the iframe to it's height.
3259
3260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3267
3268 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3269
3270         [EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
3271         https://bugs.webkit.org/show_bug.cgi?id=84576
3272
3273         Reviewed by Martin Robinson.
3274
3275         Add missing implementation setJavaScriptProfilingEnabled to EFL's
3276         LayoutTestController in order to unskip tests rely on this setting.
3277
3278         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3279         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3280         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3281         (LayoutTestController::setJavaScriptProfilingEnabled):
3282
3283 2012-04-26  Xianzhu Wang  <wangxianzhu@chromium.org>
3284
3285         Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
3286
3287         Not reviewed.
3288
3289         * Scripts/webkitpy/common/config/committers.py:
3290
3291 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3292
3293         [GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
3294         https://bugs.webkit.org/show_bug.cgi?id=84957
3295
3296         Reviewed by Martin Robinson.
3297
3298         * Scripts/run-gtk-tests:
3299         (TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
3300         TestNewFirstVisuallyNonEmptyLayoutForImages.
3301         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3302         (TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
3303         toplevel window containing the web view to make sure events are
3304         received.
3305
3306 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         Unreviewed. Add bug numbers to skipped tests.
3309
3310         * Scripts/run-gtk-tests:
3311         (TestRunner):
3312
3313 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3314
3315         [GTK] Build and run TestWebKitAPI WebKit2 unit tests
3316         https://bugs.webkit.org/show_bug.cgi?id=84446
3317
3318         Reviewed by Philippe Normand.
3319
3320         * Scripts/run-gtk-tests:
3321         (TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
3322         containing tests. Unskip FunctionalTest.RefCountedStorage, since
3323         we are now using a custom main that initializes WTF threading.
3324         (TestRunner._setup_testing_environment): Set environment variables
3325         required to run WebKit2 tests.
3326         * TestWebKitAPI/GNUmakefile.am:
3327         * TestWebKitAPI/JavaScriptTest.cpp: Use
3328         JavaScriptCore/JSContextRef.h instead of
3329         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
3330         unconditionally.
3331         * TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
3332         PlatformWindow for GTK.
3333         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
3334         unneded header that breaks the build of GTK port.
3335         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
3336         JavaScriptCore/JSContextRef.h instead of
3337         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
3338         unconditionally.
3339         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3340         (TestWebKitAPI::TEST): Add expected values for GTK+ port.
3341         * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
3342         (TestWebKitAPI):
3343         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3344         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
3345         (TestWebKitAPI::Util::checkTestFinished):
3346         (TestWebKitAPI::Util::run):
3347         (TestWebKitAPI::Util::sleep):
3348         (TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
3349         (TestWebKitAPI::Util::createInjectedBundlePath):
3350         (TestWebKitAPI::Util::createURLForResource):
3351         (TestWebKitAPI::Util::URLForNonExistentResource):
3352         (TestWebKitAPI::Util::isKeyDown):
3353         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
3354         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3355         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3356         (TestWebKitAPI::PlatformWebView::page):
3357         (TestWebKitAPI::PlatformWebView::resizeTo):
3358         (TestWebKitAPI::doKeyStroke):
3359         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3360         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3361         (TestWebKitAPI::doMouseButtonEvent):
3362         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3363         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3364         * TestWebKitAPI/gtk/main.cpp:
3365         (main):
3366
3367 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3368
3369         [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
3370         https://bugs.webkit.org/show_bug.cgi?id=84695
3371
3372         Reviewed by Philippe Normand.
3373
3374         It also adds a command line option to be able to pass a custom
3375         timeout value, instead of hard-coding it. The default timeout is 10
3376         seconds if no other value is passed to the script.
3377
3378         * Scripts/run-gtk-tests:
3379         (TestTimeout): Exception raised when a test times out.
3380         (TestRunner._get_child_pid_from_test_output): Helper function to
3381         get the pid of the running test from gtester output.
3382         (TestRunner._kill_process): Helper funtion ot kill a process
3383         ignoring exceptions if the process is already died.
3384         (TestRunner._run_test_command): Run the test command raising
3385         TestTimeout exception if the test doesn't finish before the given
3386         timeout in seconds.
3387         (TestRunner._run_test_command.alarm_handler): Alarm handler that
3388         raises TestTimeout exception.
3389         (TestRunner._run_test_glib): Use _run_test_command() to run the test.
3390         (TestRunner._run_test_google): Ditto.
3391         (TestRunner.run_tests): Add current test to the list of timed out
3392         test if TestTimeout exception is raised. Show the list of timed
3393         out test at the end.
3394
3395 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3396
3397         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
3398         https://bugs.webkit.org/show_bug.cgi?id=83880
3399
3400         Reviewed by Antonio Gomes.
3401
3402         Add missing implementation addOriginAccessWhitelistEntry and
3403         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
3404         in order to unskip tests which rely on this.
3405
3406         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3407         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3408         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3409         (LayoutTestController::addOriginAccessWhitelistEntry):
3410         (LayoutTestController::removeOriginAccessWhitelistEntry):
3411
3412 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3413
3414         [GTK] Add downloads support to MiniBrowser
3415         https://bugs.webkit.org/show_bug.cgi?id=73662
3416
3417         Reviewed by Philippe Normand.
3418
3419         * MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
3420         (browserDownloadsBarChildRemoved): Close the downloads bar if
3421         there aren't active downloads.
3422         (browserDownloadsBarResponse): Destroy the downloads bar when
3423         closed.
3424         (browser_downloads_bar_init):
3425         (browser_downloads_bar_class_init):
3426         (browser_downloads_bar_new): Create a new downloads bar.
3427         (actionButtonClicked): Cancel the download if cancel button was
3428         clicked, or open the downloaded file if the download finished.
3429         (browserDownloadFinalize):
3430         (browser_download_init):
3431         (browser_download_class_init):
3432         (downloadReceivedResponse): Update download message using the
3433         response URI.
3434         (remainingTime): Helper function to get human readable remaining
3435         time.
3436         (downloadProgress): Update downloads progress.
3437         (downloadReceivedData):
3438         (downloadFinished): Update download message and turn download
3439         button into open.
3440         (downloadFailed): Show error message or destroy the download UI if
3441         it was cancelled.
3442         (browserDownloadNew): Create a new download widget for the given
3443         WebKitDownload.
3444         (browser_downloads_bar_add_download): Add download widget to the
3445         downloads bar.
3446         * MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
3447         * MiniBrowser/gtk/BrowserWindow.c:
3448         (downloadStarted): Create a download widget and add it to the
3449         downloads bar when a new download is started.
3450         (browserWindowConstructed): Connect to
3451         WebKitWebContext::download-started signal.
3452         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
3453
3454 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3455
3456         Unreviewed. Skip unit test failing in debug bot.
3457
3458         * Scripts/run-gtk-tests:
3459         (TestRunner):
3460
3461 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
3462
3463         [EFL][DRT] "resource,request,willsend" signal needs to provide more information
3464         https://bugs.webkit.org/show_bug.cgi?id=84670
3465
3466         Reviewed by Andreas Kling.
3467
3468         Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
3469         passed with the "resource,request,willsend" signal and dump
3470         information about the network request and the possible network
3471         response if LayoutTestController's dumpResourceLoadCallbacks() returns
3472         true.
3473
3474         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3475         (pathSuitableForTestResult):
3476         (urlSuitableForTestResult):
3477         (descriptionSuitableForTestResult):
3478         (DumpRenderTreeChrome::onWillSendRequest):
3479
3480 2012-04-25  Csaba Osztrogonác  <ossy@webkit.org>
3481
3482         [Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
3483         http://trac.webkit.org/changeset/113703
3484         https://bugs.webkit.org/show_bug.cgi?id=83024
3485
3486         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3487         * Tools.pro:
3488         * qmake/mkspecs/features/features.prf:
3489         * qmake/mkspecs/features/functions.prf:
3490
3491 2012-04-25  Maciej Stachowiak  <mjs@apple.com>
3492
3493         Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
3494         https://bugs.webkit.org/show_bug.cgi?id=84931
3495
3496         Reviewed by Filip Pizlo.
3497
3498         * DumpRenderTree/mac/LayoutTestHelper.m:
3499         (installLayoutTestColorProfile): Account for the possibility of the default
3500         profile being a factory profile.
3501
3502 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3503
3504         Unreviewed, rolling out r115240.
3505         http://trac.webkit.org/changeset/115240
3506         https://bugs.webkit.org/show_bug.cgi?id=84928
3507
3508         It broke everything (Requested by Ossy_HOME on #webkit).
3509
3510         * Scripts/webkitpy/layout_tests/port/gtk.py:
3511         (GtkDriver):
3512         (GtkDriver._start):
3513         (GtkDriver._start.x_filter):
3514         (GtkDriver.stop):
3515         (GtkPort._driver_class):
3516         * Scripts/webkitpy/layout_tests/port/qt.py:
3517         (QtPort._build_driver):
3518         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
3519
3520 2012-04-25  Dirk Pranke  <dpranke@chromium.org>
3521
3522         [chromium] change DRT's "DRT" output to match the other ports
3523         https://bugs.webkit.org/show_bug.cgi?id=84904
3524
3525         Reviewed by Kent Tamura.
3526
3527         Since we run Chromium's DRT in --test-shell mode, the
3528         non-test-shell output has never been really beaten on to make
3529         sure it's right. This fixes a few issues and will be tested
3530         with upcoming NRWT changes that'll land in a separate patch.
3531         In particular we should never output framing text like "\n"
3532         or "#EOF" outside of something outside of TestEventPrinter,
3533         and we weren't handling audio output properly at all.
3534
3535         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3536         (DRTPrinter):
3537         (TestShellPrinter):
3538         (DRTPrinter::handleTextFooter):
3539         (DRTPrinter::handleAudioFooter):
3540         (DRTPrinter::handleTestFooter):
3541         (TestShellPrinter::handleAudioFooter):
3542         * DumpRenderTree/chromium/TestEventPrinter.h:
3543         (TestEventPrinter):
3544         * DumpRenderTree/chromium/TestShell.cpp:
3545         (TestShell::TestShell):
3546         (TestShell::dump):
3547
3548 2012-04-25  Joshua Bell  <jsbell@chromium.org>
3549
3550         Unreviewed: Adding Alec Flett as a contributor (non-committer).
3551
3552         * Scripts/webkitpy/common/config/committers.py:
3553
3554 2012-04-25  Abhishek Arya  <inferno@chromium.org>
3555
3556         Mark myself as a reviewer.
3557         https://bugs.webkit.org/show_bug.cgi?id=84902
3558
3559         Reviewed by Dimitri Glazkov.
3560
3561         * Scripts/webkitpy/common/config/committers.py:
3562
3563 2012-04-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3564
3565         [Qt][NRWT] Run each DRT in it's own xvfb
3566         https://bugs.webkit.org/show_bug.cgi?id=77335
3567
3568         Reviewed by Dirk Pranke.
3569
3570         * Scripts/webkitpy/layout_tests/port/gtk.py:
3571         (GtkPort._driver_class):
3572         * Scripts/webkitpy/layout_tests/port/qt.py:
3573         (QtPort._driver_class):
3574         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
3575         (XvfbDriver):
3576         (XvfbDriver._start):
3577         (XvfbDriver._start.x_filter):
3578         (XvfbDriver.stop):
3579
3580 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3581
3582         Unreviewed, rolling out r115222.
3583         http://trac.webkit.org/changeset/115222
3584         https://bugs.webkit.org/show_bug.cgi?id=84874
3585
3586         Caused test regressions on the EFL build (Requested by rakuco
3587         on #webkit).
3588
3589         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3590         (LayoutTestController::addOriginAccessWhitelistEntry):
3591         (LayoutTestController::removeOriginAccessWhitelistEntry):
3592
3593 2012-04-25  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3594
3595         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
3596         https://bugs.webkit.org/show_bug.cgi?id=83880
3597
3598         Reviewed by Antonio Gomes.
3599
3600         Add missing implementation addOriginAccessWhitelistEntry and
3601         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
3602         in order to unskip tests which rely on this.
3603
3604         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3605         (LayoutTestController::addOriginAccessWhitelistEntry):
3606         (LayoutTestController::removeOriginAccessWhitelistEntry):
3607
3608 2012-04-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3609
3610         [EFL] [DRT] Reset text zoom factor before running a test
3611         https://bugs.webkit.org/show_bug.cgi?id=84861
3612
3613         Reviewed by Antonio Gomes.
3614
3615         This fix eliminates most of the current flakiness on EFL build
3616         bots, although some CSS tests will now need rebasiling.
3617
3618         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3619         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3620
3621 2012-04-25  Milian Wolff  <milian.wolff@kdab.com>
3622
3623         [Qt] add LayoutTestController::setPrinting support to Qt unit tests
3624         https://bugs.webkit.org/show_bug.cgi?id=84246
3625
3626         Reviewed by Simon Hausmann.
3627
3628         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3629         (WebCore::DumpRenderTree::dump):
3630
3631 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3632
3633         [Qt] Make the web view's url property follow the active url
3634
3635         https://bugs.webkit.org/show_bug.cgi?id=77554
3636
3637         Update  the location bar in the minibrowser to behave
3638         a bit more like normal browsers in terms of when the url will change
3639         and how active focus is handled.
3640
3641         Reviewed by Simon Hausmann.
3642
3643         * MiniBrowser/qt/qml/BrowserWindow.qml:
3644
3645 2012-04-25  Philippe Normand  <pnormand@igalia.com>
3646
3647         Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
3648         https://bugs.webkit.org/show_bug.cgi?id=81913
3649
3650         Reviewed by Tor Arne Vestbø.
3651
3652         * qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
3653         and gstreamer-plugins-base >= 0.10.30 just like the GTK port
3654         does. 0.10.27 is unfortunately not recent enough to get the media
3655         player working reliably.
3656
3657
3658 2012-04-25  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3659
3660         [BlackBerry] Run tests in '/http/tests/local' with local URI
3661         https://bugs.webkit.org/show_bug.cgi?id=84820
3662
3663         Reviewed by Nikolas Zimmermann.
3664
3665         Currently we run all tests under folder "/http/tests/" as HTTP
3666         tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
3667         'http/tests/local' are run with local path (like '/developer/LayoutTests
3668         /http/tests/local/absolute-url-strip-whitespace.html').
3669         With this patch we can keep the same behaviour as other portings.
3670
3671         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3672         (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
3673
3674 2012-04-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3675
3676         [EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
3677         https://bugs.webkit.org/show_bug.cgi?id=84709
3678
3679         Reviewed by Eric Seidel.
3680
3681         Not all the settings that can be changed by layout testcases through a JS API were 
3682         reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
3683
3684         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3685         (defaultEditingBehavior): returns editing behavior depending on current platform.
3686         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
3687
3688 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
3689
3690         nrwt: add ASAN handling to chromium crash logs
3691         https://bugs.webkit.org/show_bug.cgi?id=84664
3692
3693         Reviewed by Ojan Vafai.
3694
3695         * Scripts/webkitpy/layout_tests/port/chromium.py:
3696         (ChromiumPort._get_crash_log):
3697
3698 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
3699
3700         webkit-patch rebaseline-test is retrieving stale expectations
3701         https://bugs.webkit.org/show_bug.cgi?id=84762
3702
3703         Reviewed by Ojan Vafai.
3704
3705         webkit-patch rebaseline-expectations is fetching files directly
3706         from the layout-test-results directory on the buildbots, rather
3707         than fetching them from the archive. This is problematic because
3708         we don't clobber the directory after each run and so you can end
3709         up fetching stale failing results.
3710
3711         This change temporarily changes the code to fetch the zip file
3712         instead -- making things much slower -- until I can confer w/
3713         abarth and ojan over the best way to fix this for the long-term.
3714
3715         * Scripts/webkitpy/tool/commands/rebaseline.py:
3716         (RebaselineTest.__init__):
3717         (RebaselineTest._zip_file_set):
3718         (RebaselineTest):
3719         (RebaselineTest._fetch_baseline):
3720         (RebaselineTest._rebaseline_test):
3721         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3722         (TestRebaseline.stub_rebaseline_test_command_and_tool):
3723         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
3724         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
3725         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
3726         (test_rebaseline_updates_expectations_file):
3727         (test_rebaseline_test):
3728         (test_rebaseline_and_copy_test):
3729         (test_rebaseline_and_copy_test_no_existing_result):
3730         (test_rebaseline_and_copy_test_with_lion_result):
3731         (test_rebaseline_and_copy_no_overwrite_test):
3732
3733 2012-04-24  Ojan Vafai  <ojan@chromium.org>
3734
3735         Improve code for embedding flakiness dashboard as an iframe
3736         https://bugs.webkit.org/show_bug.cgi?id=84782
3737
3738         Reviewed by Dirk Pranke.
3739
3740         -Include the horizontal scrollbar height in the measured height of the page.
3741         -Post a message everytime the height changes instead of in response to a queryContentHeight message.
3742         This way, the embedder doesn't need to poll.
3743
3744         No new tests. This is hard to test because it involves postMessage and iframes.
3745         Once we switch the dashboard tests over to qunit, we should be able to write an
3746         asyncTest for this.
3747
3748         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3749         (generatePage):
3750         (appendHTML):
3751         (appendExpectations):
3752         (postHeightChangedMessage):
3753         (generatePageForIndividualTests.if):
3754         (generatePageForIndividualTests):
3755         * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
3756
3757 2012-04-16  Ojan Vafai  <ojan@chromium.org>
3758
3759         Replace garden-o-matic accordion UI with a panel UI
3760         https://bugs.webkit.org/show_bug.cgi?id=84081
3761
3762         Reviewed by Dimitri Glazkov.
3763
3764         This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
3765         since we can reuse the same iframe without moving it in the DOM.
3766
3767         Also, excise unnecessary jquery-isms.
3768
3769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3772
3773 2012-04-24  Peter Beverloo  <peter@chromium.org>
3774
3775         [Chromium] DumpRenderTree should depend on base.gyp:test_support_base
3776         https://bugs.webkit.org/show_bug.cgi?id=84729
3777
3778         Reviewed by Dirk Pranke.
3779
3780         This dependency is necessary for Android since it'll soon be
3781         calling InitAndroidOSPathStub() in it's platform support. The
3782         TestWebKitAPI and webkit_unit_tests already have this dependency.
3783
3784         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3785
3786 2012-04-24  Ojan Vafai  <ojan@chromium.org>
3787
3788         Replace vague informative statement with the list of builders where the test isn't listed
3789         https://bugs.webkit.org/show_bug.cgi?id=84779
3790
3791         Reviewed by Dirk Pranke.
3792
3793         This is more informative and more likely to be noticed. With the old UI, people never
3794         read the line and if they did, they didn't really understand what it meant. Hopefully
3795         have the list of builders will be more clear.
3796
3797         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3798         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
3799         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3800
3801 2012-04-24  Tommy Widenflycht  <tommyw@google.com>
3802
3803         MediaStream API: Create a new flag for PeerConnection
3804         https://bugs.webkit.org/show_bug.cgi?id=84723
3805
3806         Reviewed by Dimitri Glazkov.
3807
3808         To allow Chrome to make the GetUserMedia functionality available by default we
3809         need another flag for the PeerConnection related parts. This new flag is in
3810         addition to the general media stream flag, and both need to be enabled for
3811         PeerConnection object creation.
3812
3813         * DumpRenderTree/chromium/TestShell.cpp:
3814         (TestShell::TestShell):
3815
3816 2012-04-24  Joe Mason  <jmason@rim.com>
3817
3818         [BlackBerry] Revert broken changes to authentication dialog
3819         https://bugs.webkit.org/show_bug.cgi?id=80135
3820
3821         Reviewed by Antonio Gomes.
3822
3823         The previous patches from this bug caused an infinite loop when using digest auth;
3824         apparently they were only tested with basic.
3825
3826         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3827         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3828         (WebCore):
3829
3830 2012-04-24  Zan Dobersek  <zandobersek@gmail.com>
3831
3832         [TestResultsServer] Add a unit test for changes in r114868
3833         https://bugs.webkit.org/show_bug.cgi?id=84713
3834
3835         Reviewed by Ojan Vafai.
3836
3837         Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
3838         that is created for either DEPS or ToT builder groups. The unit test covers changes
3839         made in r114868.
3840
3841         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3842         (testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
3843         (testBuilderGroupIsToTWebKitAttribute.assertEquals):
3844
3845 2012-04-24  Brady Eidson  <beidson@apple.com>
3846
3847         <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
3848          Need DOMWindow mechanism to supplement UserScripts for page cache notifications
3849
3850         Reviewed by Sam Weinig.
3851
3852         Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
3853
3854         It makes sure new extensions can be added at the right times, and that all of the expected
3855         callbacks are made.
3856
3857         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
3858         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
3859         (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
3860            bundle to a set of known expected messages.
3861
3862         Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
3863         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
3864         (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
3865         (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
3866         (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
3867         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
3868         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
3869         (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
3870         (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
3871         (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
3872         (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
3873         (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
3874         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
3875         (TestWebKitAPI::didFinishLoadForFrameCallback):
3876         (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
3877         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
3878         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
3879         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
3880
3881         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3882         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
3883
3884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3885
3886 2012-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3887
3888         [GTK] Build and run TestWebKitAPI unit tests
3889         https://bugs.webkit.org/show_bug.cgi?id=84325
3890
3891         Reviewed by Philippe Normand.
3892
3893         We only build WTF unit tests for now. WebKit2 tests will be
3894         enabled in a follow up patch.
3895
3896         * Scripts/run-gtk-tests:
3897         (TestRunner): Add TestWebKitAPI/WTF to the list of directories
3898         containing unit tests.
3899         (TestRunner._run_test_glib): Run glib tests using gtester.
3900         (TestRunner._run_test_google): Run google tests.
3901         (TestRunner._run_test): Use _run_test_glib or _run_test_google
3902         depending on whether given test is glib or google test
3903         * TestWebKitAPI/GNUmakefile.am: Added.
3904         * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
3905         warning with -Wundef. Include WebKit2 headers only when building
3906         WebKit2.
3907
3908 2012-04-24  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3909
3910         [Qt][WK2] Convert touch-point area
3911         https://bugs.webkit.org/show_bug.cgi?id=84434
3912
3913         Reviewed by Kenneth Rohde Christiansen.
3914
3915         Fix failing test after r114917 by also adding the new EventSender API
3916         to WebKitTestRunner.
3917
3918         * WebKitTestRunner/EventSenderProxy.h:
3919         (EventSenderProxy):
3920         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3921         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3922         (WTR::EventSendingController::setTouchPointRadius):
3923         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3924         (EventSendingController):
3925         * WebKitTestRunner/TestController.cpp:
3926         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3927         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3928         (WTR::EventSenderProxy::addTouchPoint):
3929         (WTR::EventSenderProxy::updateTouchPoint):
3930         (WTR::EventSenderProxy::setTouchPointRadius):
3931         (WTR::EventSenderProxy::clearTouchPoints):
3932
3933 2012-04-24  Mikhail Naganov  <mnaganov@chromium.org>
3934
3935         [Chromium] Unreviewed test expectations update.
3936         https://bugs.webkit.org/show_bug.cgi?id=84726
3937
3938         Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
3939
3940         * Scripts/webkitpy/test/test_finder.py:
3941         (TestFinder._default_names):
3942
3943 2012-04-24  Christophe Dumez  <christophe.dumez@intel.com>
3944
3945         [EFL] Enable Web Timing
3946         https://bugs.webkit.org/show_bug.cgi?id=84705
3947
3948         Reviewed by Tony Gentilcore.
3949
3950         Enable web timing by default whenever build-webkit is used.
3951
3952         * Scripts/build-webkit:
3953
3954 2012-04-23  Eriq Augustine  <eaugusti@chromium.org>
3955
3956         Return value from executed script in Chromium.
3957         https://bugs.webkit.org/show_bug.cgi?id=79851
3958
3959         Reviewed by Adam Barth.
3960
3961         Adding a function to LayoutTestController that evaluates a script in
3962         an isolated wold an returns the result of the evaluation.
3963
3964         * DumpRenderTree/LayoutTestController.cpp:
3965         (evaluateScriptInIsolatedWorldAndReturnValue):
3966         (LayoutTestController::staticFunctions):
3967         * DumpRenderTree/LayoutTestController.h:
3968         (LayoutTestController):
3969         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3970         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3971         * DumpRenderTree/chromium/LayoutTestController.cpp:
3972         (LayoutTestController::LayoutTestController):
3973         (LayoutTestController::setXSSAuditorEnabled):
3974         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3975         * DumpRenderTree/chromium/LayoutTestController.h:
3976         (LayoutTestController):
3977         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3978         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3979         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3980         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3981         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3982         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3983         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3984         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3985         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3986         (LayoutTestController):
3987         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3988         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3989         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3990         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
3991
3992 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
3993
3994         run-perf-tests fail intermittently with an exception
3995         https://bugs.webkit.org/show_bug.cgi?id=83532
3996
3997         Reviewed by Ryosuke Niwa.
3998
3999         This bulletproofs port.get_option('child_processes')
4000         against the case where the option wasn't set.
4001
4002         * Scripts/webkitpy/layout_tests/port/mac.py:
4003         (MacPort._get_crash_log):
4004         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4005         (test_get_crash_log):
4006         (test_get_crash_log.fake_time_cb):
4007
4008 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
4009
4010         [Qt] Add desktop zooming support for QQuickWebView
4011         https://bugs.webkit.org/show_bug.cgi?id=82337
4012
4013         Unreviewed typo fix after r114900.
4014
4015         * MiniBrowser/qt/BrowserWindow.cpp:
4016         (BrowserWindow::BrowserWindow): Fix the mistyped
4017         value of a zoom level.
4018
4019 2012-04-23  Hao Zheng  <zhenghao@chromium.org>
4020
4021         [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
4022         https://bugs.webkit.org/show_bug.cgi?id=84580
4023
4024         Reviewed by Ojan Vafai.
4025
4026         Android's first fallback font is changed to DroidSansArabic.ttf in JB.
4027         Take the opportunity to get rid of the trick.
4028
4029         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4030         (ChromiumAndroidPort.start_helper):
4031         (ChromiumAndroidPort._push_fonts):
4032
4033 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
4034
4035         test-webkitpy is failing
4036         https://bugs.webkit.org/show_bug.cgi?id=84617
4037
4038         Reviewed by Eric Seidel.
4039
4040         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
4041         (HttpLockTestWithRealFileSystem.clean_all_lockfile):
4042
4043 2012-04-23  Ojan Vafai  <ojan@chromium.org>
4044
4045         Split up flakiness_dashboard.html into multiple files. This is a step in the direction
4046         of making the code more maintainable (e.g. being able to use qunit for testing).
4047
4048         * TestResultServer/static-dashboards/dashboard_base.js:
4049         * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
4050         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4051         * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
4052         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
4053         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
4054
4055 2012-04-23  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
4056
4057         [Qt][WK2] Convert touch-point area.
4058         https://bugs.webkit.org/show_bug.cgi?id=84434
4059
4060         Reviewed by Kenneth Rohde Christiansen.
4061
4062         Add feature to set touch-point radius for emitted touch-events.
4063
4064         * DumpRenderTree/qt/EventSenderQt.cpp:
4065         (EventSender::addTouchPoint):
4066         (EventSender::updateTouchPoint):
4067         (EventSender::setTouchPointRadius):
4068         (EventSender::clearTouchPoints):
4069         * DumpRenderTree/qt/EventSenderQt.h:
4070         (EventSender):
4071
4072 2012-04-23  Christophe Dumez  <christophe.dumez@intel.com>
4073
4074         [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
4075         https://bugs.webkit.org/show_bug.cgi?id=84425
4076
4077         Reviewed by Antonio Gomes.
4078
4079         Use the new helper in DumpRenderTreeSupportEfl to properly
4080         test whether an element performs autocompletion.
4081
4082         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4083         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
4084
4085 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
4086
4087         master.cfg cleanup, remove dead codes after r92792.
4088         https://bugs.webkit.org/show_bug.cgi?id=84433
4089
4090         Relanding r114881 after typo fix in UploadBuiltProduct.
4091
4092         Reviewed by Ryosuke Niwa.
4093
4094         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4095
4096 2012-04-23  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
4097
4098         [EFL][DRT] Need to support requestAnimationFrame
4099         https://bugs.webkit.org/show_bug.cgi?id=84585
4100
4101         Reviewed by Martin Robinson.
4102
4103         Making requestAnimationFrame() support a default on the EFL build.
4104
4105         * Scripts/build-webkit:
4106
4107 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
4108
4109         [Qt] Add desktop zooming support for QQuickWebView
4110         https://bugs.webkit.org/show_bug.cgi?id=82337
4111
4112         Reviewed by Simon Hausmann.
4113
4114         Add zooming support for MiniBrowser to
4115         test the new API.
4116
4117         * MiniBrowser/qt/BrowserWindow.cpp:
4118         (BrowserWindow::BrowserWindow):
4119         (BrowserWindow::zoomIn):
4120         (BrowserWindow::zoomOut):
4121         (BrowserWindow::keyPressEvent):
4122         (BrowserWindow::wheelEvent):
4123         * MiniBrowser/qt/BrowserWindow.h:
4124         (BrowserWindow):
4125
4126 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
4127
4128         Unreviewed rolling out r114881, because it broke upload buildstep.
4129
4130         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4131         (ConfigureBuild.__init__):
4132         (ConfigureBuild.start):
4133         (CompileWebKit.start):
4134         (UploadBuiltProduct):
4135         (UploadBuiltProduct.determineExtraFeatures):
4136         (Factory.__init__):
4137         (BuildFactory.__init__):
4138         (TestFactory.__init__):
4139         (loadBuilderConfig):
4140
4141 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
4142
4143         master.cfg cleanup, remove dead codes after r92792.
4144         https://bugs.webkit.org/show_bug.cgi?id=84433
4145
4146         Reviewed by Ryosuke Niwa.
4147
4148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4149
4150 2012-04-23  Milian Wolff  <mail@milianw.de>
4151
4152         [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
4153         https://bugs.webkit.org/show_bug.cgi?id=84327
4154
4155         Reviewed by Csaba Osztrogonác.
4156
4157         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4158         (WebCore::DumpRenderTree::dump):
4159
4160 2012-04-22  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
4161
4162         [Gtk] Added MOZ_X11 build flag for TARGET_X11
4163         https://bugs.webkit.org/show_bug.cgi?id=40785
4164
4165         Reviewed by Anders Carlsson.
4166
4167         * GNUmakefile.am:
4168
4169 2012-04-22  Zan Dobersek  <zandobersek@gmail.com>
4170
4171         [TestResultsServer] Impossible to inspect builds on non-Chromium builders
4172         https://bugs.webkit.org/show_bug.cgi?id=84544
4173
4174         Reviewed by Ryosuke Niwa.
4175
4176         Use the groupEnum parameter that is passed through to the onBuilderListLoad
4177         function rather than an undefined attribute of the BuilderGroup object. This
4178         makes it again possible to inspect builds on non-Chromium builders in the
4179         test results server by not trying to always add Chromium revision links.
4180
4181         * TestResultServer/static-dashboards/builders.js:
4182
4183 2012-04-20  Martin Robinson  <mrobinson@igalia.com>
4184
4185         [GTK] Revert changes that disabled Cairo fonts metrics hinting
4186         https://bugs.webkit.org/show_bug.cgi?id=84502
4187
4188         Reviewed by Daniel Bates.
4189
4190         Re-enable Cairo metrics hinting, which seems to ensure consistent results in
4191         reference and pixel test results. This makes our font metrics a bit different
4192         than the Mac port's, but it's a decent price to pay for consistent results.
4193
4194         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4195         (initializeGtkFontSettings):
4196         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4197         (WTR::initializeGtkSettings):
4198
4199 2012-04-04  Jer Noble  <jer.noble@apple.com>
4200
4201         apple.com top navigation bar appears inside video during full screen exit animation
4202         https://bugs.webkit.org/show_bug.cgi?id=83095
4203
4204         Reviewed by Eric Carlson.
4205
4206         Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
4207         disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
4208         Document methods from within the script.  This allows subtle timing bugs to be consistently reproduced
4209         from within LayoutTests.
4210
4211         Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
4212         * DumpRenderTree/LayoutTestController.cpp:
4213         (setHasCustomFullScreenBehaviorCallback):
4214         (LayoutTestController::staticFunctions):
4215         * DumpRenderTree/LayoutTestController.h:
4216         (LayoutTestController::setHasCustomFullScreenBehavior):
4217         (LayoutTestController::hasCustomFullScreenBehavior):
4218         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4219         (WTR::InjectedBundlePage::enterFullScreenForElement):
4220         (WTR::InjectedBundlePage::exitFullScreenForElement):
4221         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4222         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4223         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4224         (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
4225         (WTR::LayoutTestController::hasCustomFullScreenBehavior):
4226         * DumpRenderTree/chromium/LayoutTestController.cpp:
4227         (LayoutTestController::LayoutTestController):
4228         (LayoutTestController::reset):
4229         * DumpRenderTree/chromium/LayoutTestController.h:
4230         (LayoutTestController::setHasCustomFullScreenBehavior):
4231         (LayoutTestController::hasCustomFullScreenBehavior):
4232
4233         Query the new methods before calling will/did/Enter/ExitFullScreen:
4234         * DumpRenderTree/chromium/WebViewHost.cpp:
4235         (WebViewHost::enterFullScreenNow):
4236         (WebViewHost::exitFullScreenNow):
4237         * DumpRenderTree/mac/UIDelegate.mm:
4238         (-[UIDelegate webView:enterFullScreenForElement:listener:]):
4239         (-[UIDelegate webView:exitFullScreenForElement:listener:]):
4240
4241 2012-04-20  Nandor Huszka  <hnandor@inf.u-szeged.hu>
4242
4243         NRWT: option --skip-pixel-test-if-no-baseline support on DRT
4244         https://bugs.webkit.org/show_bug.cgi?id=72841
4245
4246         Reviewed by Dirk Pranke
4247
4248         This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
4249         instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
4250         and 'reference_files' fields to the TestInput objects, and use those flags
4251         to select the right driver to use in the DriverProxy.
4252
4253         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4254         (SingleTestRunner.__init__):
4255         (SingleTestRunner._driver_input):
4256         (SingleTestRunner._run_reftest):
4257         * Scripts/webkitpy/layout_tests/controllers/worker.py:
4258         (Worker.handle_test_list):
4259         (Worker._update_test_input):
4260         * Scripts/webkitpy/layout_tests/models/test_input.py:
4261         (TestInput):
4262         (TestInput.__init__):
4263         (TestInput.__repr__):
4264         * Scripts/webkitpy/layout_tests/port/chromium.py:
4265         (ChromiumDriver._wrapper_options):
4266         (ChromiumDriver.run_test):
4267         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4268         (ChromiumDriverTest.test_crash_log):
4269         * Scripts/webkitpy/layout_tests/port/driver.py:
4270         (DriverInput.__init__):
4271         (Driver.__init__):
4272         (DriverProxy.__init__):
4273         (DriverProxy.run_test):
4274         (DriverProxy.start):
4275         (DriverProxy.cmd_line):
4276         * Scripts/webkitpy/layout_tests/port/gtk.py:
4277         (GtkDriver._start):
4278         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
4279         (MockDRT.run):
4280         (MockDRT.input_from_line):
4281         (MockDRT.output_for_test):
4282         (MockDRT.write_test_output):
4283         (MockChromiumDRT.input_from_line):
4284         (MockChromiumDRT.output_for_test):
4285         (MockChromiumDRT.write_test_output):
4286         * Scripts/webkitpy/layout_tests/port/webkit.py:
4287         (WebKitDriver.cmd_line):
4288         (WebKitDriver.run_test):
4289         * WebKitTestRunner/TestController.cpp:
4290         (WTR::TestController::TestController):
4291         (WTR::TestController::initialize):
4292         (WTR::TestController::runTest):
4293         * WebKitTestRunner/TestController.h:
4294         (TestController):
4295         * WebKitTestRunner/TestInvocation.cpp:
4296         (WTR::TestInvocation::TestInvocation):
4297         (WTR::TestInvocation::setIsPixelTest):
4298         * WebKitTestRunner/TestInvocation.h:
4299         (TestInvocation):
4300
4301 2012-04-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4302
4303         [EFL] Make it possible to define offline storage quota per origin
4304         https://bugs.webkit.org/show_bug.cgi?id=84170
4305
4306      &n