7dbe237af7309b4430d74c65bc2bbb162112ccd1
[WebKit-https.git] / Tools / ChangeLog
1 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
2
3         Add --ios-simulator to run-api-tests --help.
4
5         Rubber-stamped by Dan Bates.
6
7         * Scripts/run-api-tests:
8
9 2015-07-22  Jason Marcell  <jmarcell@apple.com>
10
11         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
12         https://bugs.webkit.org/show_bug.cgi?id=147043
13
14         Reviewed by Daniel Bates and Alexey Proskuryakov.
15
16         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
17         (Buildbot.prototype._normalizeQueueInfo):
18         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
19         in cases where the queue.branch property is not set and the queue is not a combined queue.
20         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
21         (BuildbotCombinedQueueView):
22         Ensuring uniformity of repository branches within a combined queue.
23         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
24         (WebKitBuildbot.prototype.get defaultBranches):
25         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
26         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
27         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
28         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
29         implement defaultBranches so that a person can either update the definition of the sub-queue or
30         implement defaultBranches in the derived Buildbot class they are using.
31
32 2015-07-22  Alex Christensen  <achristensen@webkit.org>
33
34         Switch WinCairo build to use CMake.
35         https://bugs.webkit.org/show_bug.cgi?id=147169
36
37         Reviewed by Brent Fulgham.
38
39         * Scripts/build-webkit:
40         * Scripts/webkitdirs.pm:
41         (determineConfiguration):
42         (determineArchitecture):
43         (determinePassedConfiguration):
44         (passedConfiguration):
45         (jhbuildWrapperPrefixIfNeeded):
46         (generateBuildSystemFromCMakeProject):
47         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
48
49 2015-07-22  Alex Christensen  <achristensen@webkit.org>
50
51         Fix quirks in CMake build on Mac and Windows
52         https://bugs.webkit.org/show_bug.cgi?id=147174
53
54         Reviewed by Gyuyoung Kim.
55
56         * CMakeLists.txt:
57         Don't build DumpRenderTree with CMake for now (until we get that working).
58         * WinLauncher/CMakeLists.txt:
59         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
60
61 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
62
63         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
64         https://bugs.webkit.org/show_bug.cgi?id=147146
65
66         Reviewed by Darin Adler.
67
68         * Scripts/webkitpy/style/checkers/cpp.py:
69         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
70         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
71         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
72
73 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
74
75         Fixed VM pool allocation should have a reserve for allocations that cannot fail
76         https://bugs.webkit.org/show_bug.cgi?id=147154
77         rdar://problem/21847618
78
79         Reviewed by Geoffrey Garen.
80         
81         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
82         mitigations work, these should all pass. Prior to this patch there were >20 failures.
83
84         * Scripts/run-jsc-stress-tests:
85
86 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
87
88         [GTK] Add API to be notified about editor state changes
89         https://bugs.webkit.org/show_bug.cgi?id=145875
90
91         Reviewed by Gustavo Noronha Silva.
92
93         Update the typing attributes toggle buttons state according to the
94         editor state in MiniBrowser, and add a test case to the
95         WebViewEditor unit tests.
96
97         * MiniBrowser/gtk/BrowserWindow.c:
98         (browserWindowEditingCommandToggleButtonSetActive):
99         (typingAttributesChanged):
100         (browserWindowSetupEditorToolbar):
101         (browserWindowConstructed):
102         (browser_window_init):
103         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
104         (testWebViewEditorEditorStateTypingAttributes):
105         (beforeAll):
106
107 2015-07-20  Tomas Popela  <tpopela@redhat.com>
108
109         [GTK] Add selection-changed signal to the WebKit2 API
110         https://bugs.webkit.org/show_bug.cgi?id=137116
111
112         Reviewed by Carlos Garcia Campos.
113
114         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
115         (namely the selection-changed signal).
116
117         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
118         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
119         (WebKitWebEditorTest::create):
120         (WebKitWebEditorTest::selectionChangedCallback):
121         (WebKitWebEditorTest::testSelectionSelectAll):
122         (WebKitWebEditorTest::testSelectionCollapse):
123         (WebKitWebEditorTest::testSelectionModifyMove):
124         (WebKitWebEditorTest::testSelectionModifyExtend):
125         (WebKitWebEditorTest::testSelectionUnselect):
126         (registerTests):
127         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
128         (testWebKitWebEditorSelectionChanged):
129         (beforeAll):
130         (afterAll):
131
132 2015-07-20  Alex Christensen  <achristensen@webkit.org>
133
134         Resurrect CMake build on Windows.
135         https://bugs.webkit.org/show_bug.cgi?id=147083
136
137         Reviewed by Gyuyoung Kim.
138
139         * DumpRenderTree/CMakeLists.txt:
140         * DumpRenderTree/PlatformWin.cmake: Added.
141         * WinLauncher/CMakeLists.txt:
142
143 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
144
145         [GTK] Enable seccomp filter API tests
146         https://bugs.webkit.org/show_bug.cgi?id=140071
147
148         Reviewed by Žan Doberšek.
149
150         These tests will now be run by the run-gtk-tests script.
151
152         * TestWebKitAPI/PlatformGTK.cmake:
153
154 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
155
156         [GTK] Add seccomp filters support
157         https://bugs.webkit.org/show_bug.cgi?id=110014
158
159         Reviewed by Žan Doberšek.
160
161         Add libseccomp to jhbuild modulesets.
162
163         * gtk/jhbuild.modules:
164
165 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
166
167         MiniBrowser window title is just "Window" when page has no <title>
168         https://bugs.webkit.org/show_bug.cgi?id=147076
169
170         Reviewed by Tim Horton.
171         
172         Make MiniBrowser windows show the filename from the URL if we never get a title changed
173         notification.
174
175         * MiniBrowser/mac/WK1BrowserWindowController.m:
176         (-[WK1BrowserWindowController updateTitle:]):
177         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
178         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
179         * MiniBrowser/mac/WK2BrowserWindowController.m:
180         (-[WK2BrowserWindowController updateTitle:]):
181         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
182         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
183
184 2015-07-17  Andy Estes  <aestes@apple.com>
185
186         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
187         https://bugs.webkit.org/show_bug.cgi?id=147044
188         rdar://problem/21567820
189
190         Reviewed by Brady Eidson.
191
192         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
193         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
194         This matches the behavior of DumpRenderTree.
195
196 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
197
198         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
199         https://bugs.webkit.org/show_bug.cgi?id=147032
200
201         Reviewed by Alex Christensen.
202
203         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
204         Test that the useless terms are eliminated by counting
205         the number of NFA nodes generated.
206
207 2015-07-17  Dan Bernstein  <mitz@apple.com>
208
209         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
210         https://bugs.webkit.org/show_bug.cgi?id=147040
211
212         Reviewed by Dean Jackson.
213
214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
215         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
216         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
217         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
218         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
219         (TEST):
220
221 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
222
223         webkit-patch uses incorrect credentials from keychain to login until account lockout
224         https://bugs.webkit.org/show_bug.cgi?id=146923
225
226         Reviewed by Daniel Bates.
227
228         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
229         provide incorrect credentials then ask for them to be saved to the keychain
230         webkit-patch will then use those incorrect credentials until 5 total attempts
231         have been made to log in. This will lock the user out of Bugzilla for a
232         half hour.
233
234         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
235         (Bugzilla.authenticate): Added argument to read_credentials() that
236         passes in whether or not to use stored credentials.
237         * Scripts/webkitpy/common/net/credentials.py:
238         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
239         that specifies whether or not to use credentials stored on the system. If it
240         does, we do not auto-fill credentials since either the credentials caused
241         the failure, or they weren't used in the first place so there is no reason
242         to try and use them again if a failure happened.
243         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
244         use_stored_credentials argument.
245         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
246         retrieve username/password information from the local system (environment, Git, keychain,
247         keyring) are never called. It also tests that we get back our mocked username and password.
248         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
249         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
250         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
251         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
252         is never called.
253         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
254         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
255         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
256         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
257         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
258         against.
259
260 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
261
262         Unreviewed, remove my redundant email information.
263
264         * Scripts/webkitpy/common/config/contributors.json:
265
266 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
267
268         Unreviewed. Add Hyungwook Lee as a committer.
269
270         * Scripts/webkitpy/common/config/contributors.json:
271
272 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
273
274         Added myself to the list of contributors.
275
276         Reviewed by Brent Fulgham.
277
278         * Scripts/webkitpy/common/config/contributors.json:
279
280 2015-07-16  Alex Christensen  <achristensen@webkit.org>
281
282         [Content Extensions] Cache domain actions
283         https://bugs.webkit.org/show_bug.cgi?id=146817
284
285         Reviewed by Benjamin Poulain.
286
287         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
288         (TestWebKitAPI::TEST_F):
289         Test if-domain and unless-domain with multiple load types.
290
291 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
292
293         [Content extensions] Combine suffixes when generating NFAs
294         https://bugs.webkit.org/show_bug.cgi?id=146961
295
296         Reviewed by Alex Christensen.
297
298         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
299         (TestWebKitAPI::compareContents):
300         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
301
302 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
303
304         [GTK] Input method filter is always enabled when the view is focused
305         https://bugs.webkit.org/show_bug.cgi?id=146965
306
307         Reviewed by Martin Robinson.
308
309         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
310
311         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
312         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
313
314 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
315
316         [EFL] Bump libseccomp version to 2.2.3
317         https://bugs.webkit.org/show_bug.cgi?id=146980
318
319         Reviewed by Gyuyoung Kim.
320
321         * efl/jhbuild.modules:
322
323 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
324
325         [Win] Maintain consistent COM Interfaces
326         https://bugs.webkit.org/show_bug.cgi?id=146983
327         <rdar://problem/21822278>
328
329         Reviewed by Dean Jackson.
330
331         Update DumpRenderTree and WinLauncher to use the properly
332         versioned COM interface objects.
333
334         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
335         (AccessibilityController::rootElement):
336         * DumpRenderTree/win/DumpRenderTree.cpp:
337         (resetWebPreferencesToConsistentValues):
338         (resetWebViewToConsistentStateBeforeTesting):
339         (runTest):
340         (createWebViewAndOffscreenWindow):
341         * DumpRenderTree/win/EditingDelegate.cpp:
342         (EditingDelegate::QueryInterface):
343         (EditingDelegate::shouldEndEditingInDOMRange):
344         (EditingDelegate::shouldInsertNode):
345         * DumpRenderTree/win/EditingDelegate.h:
346         * DumpRenderTree/win/EventSender.cpp:
347         (scalePageByCallback):
348         * DumpRenderTree/win/FrameLoadDelegate.cpp:
349         (FrameLoadDelegate::didCommitLoadForFrame):
350         * DumpRenderTree/win/TestRunnerWin.cpp:
351         (TestRunner::callShouldCloseOnWebView):
352         (TestRunner::applicationCacheDiskUsageForOrigin):
353         (TestRunner::clearApplicationCacheForOrigin):
354         (TestRunner::setDefersLoading):
355         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
356         (TestRunner::setTabKeyCyclesThroughElements):
357         (TestRunner::setValueForUser):
358         (TestRunner::dispatchPendingLoadRequests):
359         (TestRunner::setWindowIsKey):
360         (TestRunner::execCommand):
361         (TestRunner::addOriginAccessWhitelistEntry):
362         (TestRunner::removeOriginAccessWhitelistEntry):
363         (TestRunner::addUserScript):
364         (TestRunner::addUserStyleSheet):
365         (TestRunner::showWebInspector):
366         (TestRunner::closeWebInspector):
367         (TestRunner::evaluateInWebInspector):
368         (TestRunner::setSerializeHTTPLoads):
369         * DumpRenderTree/win/TextInputControllerWin.cpp:
370         (TextInputController::setMarkedText):
371         (TextInputController::hasMarkedText):
372         (TextInputController::unmarkText):
373         (TextInputController::markedRange):
374         (TextInputController::insertText):
375         (TextInputController::firstRectForCharacterRange):
376         (TextInputController::selectedRange):
377         * DumpRenderTree/win/UIDelegate.h:
378         (UIDelegate::unused2):
379         (UIDelegate::unused3):
380         (UIDelegate::webViewScrolled):
381         (UIDelegate::webViewShouldInterruptJavaScript):
382         (UIDelegate::webViewReceivedFocus):
383         (UIDelegate::unused4): Deleted.
384         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
385         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
386         * WinLauncher/PageLoadTestClient.cpp:
387         (PageLoadTestClient::didStartProvisionalLoad):
388         * WinLauncher/WinLauncher.cpp:
389         (WinLauncher::init):
390         * WinLauncher/WinLauncher.h:
391         * WinLauncher/WinLauncherWebHost.cpp:
392         (WinLauncherWebHost::didFinishLoadForFrame):
393         (WinLauncherWebHost::didFirstLayoutInFrame):
394         * WinLauncher/WinLauncherWebHost.h:
395
396 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
397
398         Many test failures in scm_unittest.py
399         https://bugs.webkit.org/show_bug.cgi?id=143967
400
401         Reviewed by Daniel Bates. 
402
403         * Scripts/webkitpy/common/checkout/scm/detection.py:
404         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
405         absolute canonical file paths. Two mutually exclusive issues cause this
406         to be a problem.
407             1) Python's os.path.relpath() function does not return correct relative
408             paths between two filepaths that point to the same file, if symlinks are
409             involved.
410                 On Mac, /tmp points to /private/tmp
411                 ex. os.path.relpath('/tmp', '/private/tmp')
412                     returns '../../tmp'
413             What we want is actually just '.'
414             2) Git does not allow file paths to trace outside of
415             the Git repository. This means that if you have a repository in
416             /tmp and you refer to that repository when invoking a git command as
417             ../tmp, Git will produce errors about working outside of the repository.
418         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
419         its default behavior and such, needed to be updated.
420         (Git.changed_files): '--' was added into the command so that patch_directories
421         were taken as positional arguments.
422         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
423         in the GitSVNTest class to more closely emulate the version of Git that the tests
424         assumed a system had. Also fixed a small side-effect from the absolute canonical
425         path fix in SCMDetector.detect_scm_system
426         (SVNTestRepository.setup): A relative filepath was previously passed as the
427         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
428         an absolute canonical path before being passed in. The failing test
429         was a "sanity check" that the svn.checkout_root and scm.checkout_root
430         were the same.
431         (GitSVNTest._setup_git_checkout):
432             1) Added "--prefix ''" option to `git clone` since Git changed its default
433             behavior in version 2.0.
434             2) The branch master was renamed to trunk to more closely emulate what
435             tests expected when they were written. 
436         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
437         original tests failed because the tests expected the trunk branch
438         to produce its parent's commit, whereas Git merely provides the HEAD commit
439         for a given branch (trunk in this case). Based on other tests written
440         in the same commit, it appears these tests were failing from the point they
441         were written.
442
443 2015-07-14  Anders Carlsson  <andersca@apple.com>
444
445         Assertions.h should include ExportMacros.h
446         https://bugs.webkit.org/show_bug.cgi?id=146948
447
448         Reviewed by Tim Horton.
449
450         Remove now unneeded WTF_EXPORT_PRIVATE define.
451
452         * DumpRenderTree/cg/ImageDiffCG.cpp:
453
454 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
455
456         [GTK] [Wayland] Build by default the X11 and Wayland targets.
457         https://bugs.webkit.org/show_bug.cgi?id=146057
458
459         Reviewed by Carlos Garcia Campos.
460
461         * gtk/install-dependencies:
462
463 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
464
465         [Mac] Unable to dismiss context menu during test runs
466         https://bugs.webkit.org/show_bug.cgi?id=146836
467
468         Reviewed by Tim Horton.
469
470         Since Context Menus are modal, the test system would block on the displayed context menu,
471         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
472         mouse click and generate the menu contents, but not ask AppKit to display it.
473
474         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
475
476         * DumpRenderTree/mac/EventSendingController.mm:
477         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
478         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
479         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
480         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
481         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
482         work without actually calling on AppKit to display the menu.
483         ask WebCore to do all the work EXCEPT displaying the menu.
484         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
485         * WebKitTestRunner/mac/EventSenderProxy.mm:
486         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
487
488 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
489
490         It should be possible to run the OSR exit fuzzer
491         https://bugs.webkit.org/show_bug.cgi?id=146814
492
493         Reviewed by Mark Lam.
494         
495         This runs a test command to detect how many static OSR exit sites it had, and then for
496         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
497         middle opportunity), plus a mode where the check always exits. This is an exhaustive
498         search, so in the future it'll be very appropriate for cases where we have a simple test
499         and we want to see what happens when you eventually exit in this test.
500         
501         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
502         and it seems to do the right thing.
503
504         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
505         (fail):
506
507 2015-07-10  Alex Christensen  <achristensen@webkit.org>
508
509         Add tests for r186649
510         https://bugs.webkit.org/show_bug.cgi?id=146821
511
512         Reviewed by Darin Adler.
513
514         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
515         (TestWebKitAPI::TEST_F):
516         (TestWebKitAPI::compareContents):
517         (TestWebKitAPI::expectedIndex):
518         Add some larger tests to test large jumps.
519
520 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
521
522         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
523         https://bugs.webkit.org/show_bug.cgi?id=146820
524
525         Reviewed by Ryosuke Niwa.
526
527         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
528         (OSXBrowserDriver):
529         (OSXBrowserDriver.close_browsers):
530         (OSXBrowserDriver._terminiate_processes):
531         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
532         (OSXChromeDriver):
533         (OSXChromeCanaryDriver):
534         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
535         (OSXFirefoxDriver):
536         (OSXFirefoxNightlyDriver):
537         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
538         (OSXSafariDriver):
539
540 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
541
542         [GTK] pango should be included in the default jhbuild moduleset
543         https://bugs.webkit.org/show_bug.cgi?id=146683
544
545         Reviewed by Martin Robinson.
546
547         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
548         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
549         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
550         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
551         the same problem again the next time pango wants to use a new fontconfig feature), or remove
552         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
553         best.
554
555         * gtk/jhbuild-optional.modules: Remove pango
556         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
557
558 2015-07-09  Devin Rousso  <drousso@apple.com>
559
560         Unreviewed.  Added myself as a committer.
561
562         * Scripts/webkitpy/common/config/contributors.json:
563
564 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
565
566         Add a way to set the default URL from Minibrowser UI
567         https://bugs.webkit.org/show_bug.cgi?id=146780
568
569         Reviewed by Simon Fraser.
570
571         * MiniBrowser/mac/AppDelegate.m:
572         (-[BrowserAppDelegate didChangeSettings]):
573         * MiniBrowser/mac/BrowserWindowController.h:
574         * MiniBrowser/mac/BrowserWindowController.m:
575         (-[BrowserWindowController fetch:]):
576         (-[BrowserWindowController reload:]):
577         (-[BrowserWindowController forceRepaint:]):
578         (-[BrowserWindowController goBack:]):
579         (-[BrowserWindowController goForward:]):
580         (-[BrowserWindowController showHideWebView:]):
581         (-[BrowserWindowController removeReinsertWebView:]):
582         (-[BrowserWindowController zoomIn:]):
583         (-[BrowserWindowController zoomOut:]):
584         (-[BrowserWindowController resetZoom:]):
585         (-[BrowserWindowController canZoomIn]):
586         (-[BrowserWindowController canZoomOut]):
587         (-[BrowserWindowController canResetZoom]):
588         (-[BrowserWindowController toggleZoomMode:]):
589         (-[BrowserWindowController setScale:]):
590         (-[BrowserWindowController toggleShrinkToFit:]):
591         (-[BrowserWindowController dumpSourceToConsole:]):
592         (-[BrowserWindowController find:]):
593         (-[BrowserWindowController didChangeSettings]):
594         (-[BrowserWindowController currentURL]):
595         Get rid of the BrowserController protocol. It was a bad idea and confused
596         Interface Builder more than I thought possible.
597
598         * MiniBrowser/mac/SettingsController.m:
599         (-[SettingsController _populateMenu]):
600         (-[SettingsController setDefaultURLToCurrentURL:]):
601         If we have a BrowserWindowController, grab its URL and set the relevant default.
602
603         * MiniBrowser/mac/WK1BrowserWindowController.h:
604         * MiniBrowser/mac/WK1BrowserWindowController.m:
605         (-[WK1BrowserWindowController currentURL]):
606         * MiniBrowser/mac/WK2BrowserWindowController.h:
607         * MiniBrowser/mac/WK2BrowserWindowController.m:
608         (-[WK2BrowserWindowController currentURL]):
609         Retrieve the current URL from the WKView/WebView.
610
611 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
612
613         Increase MiniBrowser location bar maximum width
614         https://bugs.webkit.org/show_bug.cgi?id=146779
615
616         Reviewed by Simon Fraser.
617
618         * MiniBrowser/mac/BrowserWindow.xib:
619         Have an enormous maximum width on the location bar, so that it doesn't
620         stop expanding with the window at 800px.
621
622 2015-07-08  Brady Eidson  <beidson@apple.com>
623
624         Crash calling [WebView close] in didFinishLoadForFrame callback.
625         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
626
627         Reviewed by David Kilzer.
628
629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
630         
631         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
632         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
633         (TestWebKitAPI::TEST):
634
635 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
636
637         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
638         https://bugs.webkit.org/show_bug.cgi?id=146546
639
640         Reviewed by Darin Adler.
641
642         We did't reset pendingNavigationID value when request url is empty.
643         Hence we need to ignore ASSERT check in this case.
644
645         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
646         (TestWebKitAPI::TEST):
647
648 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
649
650         [Content Extensions] Fuse undistinguishable actions as much as possible
651         https://bugs.webkit.org/show_bug.cgi?id=146762
652
653         Reviewed by Alex Christensen.
654
655         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
656         Test that combinations and flags still work as expected.
657
658 2015-07-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
659
660         [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset.
661         https://bugs.webkit.org/show_bug.cgi?id=146056
662
663         Reviewed by Martin Robinson.
664
665         * gtk/install-dependencies: libepoxy is now required for building GTK+.
666         * gtk/jhbuild-wayland.modules: Removed. Not longer needed.
667         * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building:
668         Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1).
669         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed.
670         Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb.
671         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed.
672         GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98.
673
674 2015-07-06  Matt Rajca  <mrajca@apple.com>
675
676         Media Session: propagate metadata changes to UI clients
677         https://bugs.webkit.org/show_bug.cgi?id=146660
678
679         Reviewed by Tim Horton.
680
681         * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient.
682         (WTR::TestController::createOtherPage):
683         (WTR::TestController::createWebViewWithOptions):
684
685 2015-07-07  Brady Eidson  <beidson@apple.com>
686
687         HTTP Auth cached after disabling private browsing/reset.
688         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
689
690         Reviewed by Tim Horton.
691
692         * DumpRenderTree/mac/DumpRenderTree.mm:
693         (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs.
694
695 2015-07-06  Alex Christensen  <achristensen@webkit.org>
696
697         [Content Extensions] Remove memory page reporting
698         https://bugs.webkit.org/show_bug.cgi?id=146659
699
700         Reviewed by Benjamin Poulain.
701
702         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
703         (TestWebKitAPI::TEST_F):
704
705 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
706
707         [Content Extensions] Make the DFA transitions ranges instead of characters
708         https://bugs.webkit.org/show_bug.cgi?id=146575
709
710         Reviewed by Alex Christensen.
711
712         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
713         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
714         Since the minimizer is perfect, we get the minimal solution now,
715         which is really cool!
716
717 2015-07-06  Brady Eidson  <beidson@apple.com>
718
719         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
720         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
721
722         Reviewed by Geoff Garen.
723
724         * WebKitTestRunner/TestInvocation.cpp:
725         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
726           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
727
728 2015-07-06  Daniel Bates  <dabates@apple.com>
729
730         Unreviewed, rolling out r170639.
731
732         Broke using webkit-patch apply-attachment to apply an
733         attachment from a security bug. The patch incorrectly assumed
734         that Bugzilla returns a non-HTTP 200 status code in its HTTP
735         response when authentication is required.
736
737         Reverted changeset:
738
739         "webkit-patch apply-from-bug / apply-attachment should not ask
740         for credentials if none are required"
741         https://bugs.webkit.org/show_bug.cgi?id=40095
742         http://trac.webkit.org/changeset/170639
743
744 2015-07-04  Chris Dumez  <cdumez@apple.com>
745
746         Drop RefPtr::clear() method
747         https://bugs.webkit.org/show_bug.cgi?id=146556
748
749         Reviewed by Brady Eidson.
750
751         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
752
753 2015-07-03  Dan Bernstein  <mitz@apple.com>
754
755         Fixed the iOS build.
756
757         * DumpRenderTree/mac/EventSendingController.mm:
758         (+[EventSendingController isSelectorExcludedFromWebScript:]):
759         (+[EventSendingController webScriptNameForSelector:]):
760
761 2015-07-03  Dan Bernstein  <mitz@apple.com>
762
763         [Xcode] Update some build settings as recommended by Xcode 7
764         https://bugs.webkit.org/show_bug.cgi?id=146597
765
766         Reviewed by Sam Weinig.
767
768         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
769
770         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
771         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
772         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
773         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
774         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
775
776         * DumpRenderTree/mac/EventSendingController.mm:
777         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
778         which was removed in r19101.
779
780         * DumpRenderTree/mac/TextInputController.m:
781         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
782         around used of a selector not that is not declared anywhere.
783
784         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
785
786         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
787
788         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
789         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
790         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
791         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
792         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
793
794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
795
796 2015-07-02  Daniel Bates  <dabates@apple.com>
797
798         [iOS] Add WebKitSystemInterface for iOS 8.4
799         https://bugs.webkit.org/show_bug.cgi?id=146548
800
801         Rubber-stamped by Zalan Bujtas.
802
803         * Scripts/copy-webkitlibraries-to-product-directory:
804
805 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
806
807         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
808         https://bugs.webkit.org/show_bug.cgi?id=146234
809
810         Reviewed by Sergio Villar Senin.
811
812         Enable the WebSQL directory test that was disabled because of this bug.
813
814         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
815         (testWebContextConfiguration):
816
817 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
818
819         Enabled MEDIA_STREAM flag
820         https://bugs.webkit.org/show_bug.cgi?id=145947
821         <rdar://problem/21365829>
822         
823         Reviewed by Eric Carlson.
824
825         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
826
827 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
828
829         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
830         https://bugs.webkit.org/show_bug.cgi?id=144828
831
832         Reviewed by Carlos Garcia Campos.
833
834         * WebKitTestRunner/gtk/main.cpp:
835         (main): Use the new WKTextChecker API to set the spell checking languages
836         when the process is starting up.
837
838 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
839
840         Implement ECMAScript Internationalization API
841         https://bugs.webkit.org/show_bug.cgi?id=90906
842
843         Reviewed by Benjamin Poulain.
844
845         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
846
847 2015-06-30  Jonathan Davis  <jond@apple.com>
848
849         Unreviewed. Added myself as a committer.
850
851         * Scripts/webkitpy/common/config/contributors.json:
852
853 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
854
855         Unreviewed build fix.
856
857         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
858         to developer.apple.com to get update libraries.
859
860 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
861
862         Add timeout in run-webkit-tests for launching the simulator
863         https://bugs.webkit.org/show_bug.cgi?id=146371
864
865         Reviewed by Darin Adler.
866
867         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
868         for the otherwise infinitely patient wait_until_device_is_in_state method.
869
870         * Scripts/webkitpy/xcode/simulator.py:
871         (Simulator.DeviceState):
872         (Simulator):
873         (Simulator.wait_until_device_is_in_state):
874         (Simulator.device_state):
875
876 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
877
878         Make the NFA transitions range-based
879         https://bugs.webkit.org/show_bug.cgi?id=146338
880
881         Reviewed by Alex Christensen.
882
883         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
884         Test some new interesting cases.
885
886 2015-06-28  Dan Bernstein  <mitz@apple.com>
887
888         [Xcode] Use the same environment for command-line and IDE builds
889         https://bugs.webkit.org/show_bug.cgi?id=146401
890
891         Reviewed by Anders Carlsson.
892
893         * Scripts/webkitdirs.pm:
894         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
895         xcodebuild use the same environment Xcode uses.
896
897 2015-06-28  Dan Bernstein  <mitz@apple.com>
898
899         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
900         https://bugs.webkit.org/show_bug.cgi?id=146396
901
902         Reviewed by Anders Carlsson.
903
904         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
905         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
906         (TestWebKitAPI::TEST): Updated for renames.
907         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
908         (runJavaScriptAlert): Removed suffix.
909         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
910         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
911         (runJavaScriptAlert): Removed suffix.
912         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
913
914 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
915
916         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
917         https://bugs.webkit.org/show_bug.cgi?id=146318
918
919         Reviewed by Sergio Villar Senin.
920
921         Copy mac PublicSuffix test to the common directory and add it to
922         the GTK+ build.
923
924         * TestWebKitAPI/PlatformGTK.cmake:
925         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
926         (TestWebKitAPI::TEST_F):
927
928 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
929
930         WinLauncher fails to download files.
931         https://bugs.webkit.org/show_bug.cgi?id=146242
932
933         Reviewed by Alex Christensen.
934
935         Added WinLauncher download delegate.
936
937         * WinLauncher/Common.cpp:
938         * WinLauncher/WebDownloadDelegate.cpp: Added.
939         (WebDownloadDelegate::WebDownloadDelegate):
940         (WebDownloadDelegate::~WebDownloadDelegate):
941         (WebDownloadDelegate::QueryInterface):
942         (WebDownloadDelegate::AddRef):
943         (WebDownloadDelegate::Release):
944         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
945         (WebDownloadDelegate::didCancelAuthenticationChallenge):
946         (WebDownloadDelegate::didCreateDestination):
947         (WebDownloadDelegate::didFailWithError):
948         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
949         (WebDownloadDelegate::didReceiveDataOfLength):
950         (WebDownloadDelegate::didReceiveResponse):
951         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
952         (WebDownloadDelegate::willResumeWithResponse):
953         (WebDownloadDelegate::willSendRequest):
954         (WebDownloadDelegate::didBegin):
955         (WebDownloadDelegate::didFinish):
956         * WinLauncher/WebDownloadDelegate.h: Added.
957         * WinLauncher/WinLauncher.cpp:
958         (WinLauncher::setAccessibilityDelegate):
959         (WinLauncher::setResourceLoadDelegate):
960         (WinLauncher::setDownloadDelegate):
961         (WinLauncher::mainFrame):
962         * WinLauncher/WinLauncher.h:
963         (WinLauncher::standardPreferences):
964         (WinLauncher::privatePreferences):
965         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
966         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
967         * WinLauncher/WinMain.cpp:
968         (wWinMain):
969
970 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
971
972         [EFL] Bump libseccomp version to 2.2.1
973         https://bugs.webkit.org/show_bug.cgi?id=146341
974
975         Reviewed by Gyuyoung Kim.
976
977         * efl/jhbuild.modules:
978         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
979         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
980
981 2015-06-25  Alex Christensen  <achristensen@webkit.org>
982
983         [Content Extensions] Add a way to match a domain but not subdomains
984         https://bugs.webkit.org/show_bug.cgi?id=146241
985         rdar://problem/21557754
986
987         Reviewed by Darin Adler.
988
989         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
990         (TestWebKitAPI::TEST_F):
991         Update subdomain test because of changed behavior and add test for new '*' functionality.
992
993 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
994
995         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
996         https://bugs.webkit.org/show_bug.cgi?id=146308
997
998         Reviewed by Csaba Osztrogonác.
999
1000         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
1001
1002         * Scripts/webkitperl/FeatureList.pm:
1003
1004 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1005
1006         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
1007         https://bugs.webkit.org/show_bug.cgi?id=146149
1008
1009         Reviewed by Sergio Villar Senin.
1010
1011         Update unit tests to use WebKitWebsiteDataManager.
1012
1013         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1014         (testWebContextConfiguration):
1015         (serverCallback):
1016         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1017         (Test::Test): Use WebKitWebsiteDataManager and set all possible
1018         values to ensure unit tests don't write outside the temporary directory.
1019         (Test::~Test): Explicitly reset the web context to ensure its
1020         objects are released before the leaks check.
1021         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1022         (WebViewTest::wait): Fix the GSource used, since we are receiving
1023         a double in seconds, but using g_timeout_add_seconds() that
1024         expects an unsigned in seconds. Use GMainLoopSource to correctly
1025         handle the value and simplify the code.
1026
1027 2015-06-24  Jason Marcell  <jmarcell@apple.com>
1028
1029         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
1030         https://bugs.webkit.org/show_bug.cgi?id=146126
1031         <rdar://problem/18226291>
1032
1033         Reviewed by Alexey Proskuryakov.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1036         (documentReady): Using combined queues to display iOS projects
1037
1038 2015-06-24  Doug Russell  <d_russell@apple.com>
1039
1040         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
1041         when posting a selection notification when on the border between two accessibilityObjects
1042         https://bugs.webkit.org/show_bug.cgi?id=146177
1043
1044         Reviewed by Darin Adler.
1045
1046         Add support for mapping WebCore Accessibility types into JSValueRef types
1047         so they can be used in tests.
1048
1049         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1050         (webAccessibilityObjectWrapperClass):
1051         (-[AccessibilityNotificationHandler startObserving]):
1052         (makeValueRefForValue):
1053         (makeArrayRefForArray):
1054         (makeObjectRefForDictionary):
1055         (-[AccessibilityNotificationHandler _notificationReceived:]):
1056         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1057         (webAccessibilityObjectWrapperClass):
1058         (-[AccessibilityNotificationHandler startObserving]):
1059         (makeValueRefForValue):
1060         (makeArrayRefForArray):
1061         (makeObjectRefForDictionary):
1062         (-[AccessibilityNotificationHandler _notificationReceived:]):
1063
1064 2015-06-24  Zalan Bujtas  <zalan@apple.com>
1065
1066         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
1067         https://bugs.webkit.org/show_bug.cgi?id=146273
1068         rdar://problem/18509840
1069
1070         Reviewed by Simon Fraser.
1071
1072         Due to the floating point approximate representation, we can't always produce
1073         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
1074         and by changing the rounding in roundToDevicePixel() from float to double.
1075
1076         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1077         (TestWebKitAPI::TEST):
1078
1079 2015-06-24  Brady Eidson  <beidson@apple.com>
1080
1081         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
1082         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
1083
1084         Reviewed by Alex Christensen.
1085
1086         - Update WKTR to the new client structure.
1087         - Update existing TestWebKitAPI tests to either use the new client structure or
1088           assign the old function signature to the updated variable name.
1089         - Include a new test.
1090
1091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1092
1093         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
1094         (TestWebKitAPI::runJavaScriptAlert):
1095
1096         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1097         (TestWebKitAPI::TEST):
1098
1099         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
1100         (TestWebKitAPI::analyzeDialogArguments):
1101         (TestWebKitAPI::runJavaScriptAlert):
1102         (TestWebKitAPI::runJavaScriptConfirm):
1103         (TestWebKitAPI::runJavaScriptPrompt):
1104         (TestWebKitAPI::createNewPage):
1105         (TestWebKitAPI::TEST):
1106
1107         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1108         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1109
1110         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1111         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1112
1113         * WebKitTestRunner/TestController.cpp:
1114         (WTR::TestController::createOtherPage):
1115         (WTR::TestController::createWebViewWithOptions):
1116
1117 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
1118
1119         Refactoring benchmark runner script to follow pep8 code style.
1120         https://bugs.webkit.org/show_bug.cgi?id=146264
1121
1122         Reviewed by Ryosuke Niwa.
1123
1124         Refactor benchmark runner script to follow pep8 code style.
1125
1126         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1127         (GenericBenchmarkBuilder.prepare):
1128         (GenericBenchmarkBuilder._run_create_script):
1129         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
1130         (GenericBenchmarkBuilder._fetch_remote_archive):
1131         (GenericBenchmarkBuilder):
1132         (GenericBenchmarkBuilder._checkout_with_subversion):
1133         (GenericBenchmarkBuilder._apply_patch):
1134         (GenericBenchmarkBuilder.clean):
1135         (GenericBenchmarkBuilder._runCreateScript): Deleted.
1136         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
1137         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
1138         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
1139         (GenericBenchmarkBuilder._applyPatch): Deleted.
1140         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1141         (BenchmarkRunner.__init__):
1142         (BenchmarkRunner._find_plan_file):
1143         (BenchmarkRunner.execute):
1144         (BenchmarkRunner._cleanup):
1145         (BenchmarkRunner._dump):
1146         (BenchmarkRunner._wrap):
1147         (BenchmarkRunner._merge):
1148         (BenchmarkRunner._show_results):
1149         (BenchmarkRunner._findPlanFile): Deleted.
1150         (BenchmarkRunner.cleanup): Deleted.
1151         (BenchmarkRunner.dump): Deleted.
1152         (BenchmarkRunner.wrap): Deleted.
1153         (BenchmarkRunner.merge): Deleted.
1154         (BenchmarkRunner.show_results): Deleted.
1155         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1156         (BrowserDriver.prepare_env):
1157         (BrowserDriver.launch_url):
1158         (BrowserDriver.close_browsers):
1159         (BrowserDriver.prepareEnv): Deleted.
1160         (BrowserDriver.launchUrl): Deleted.
1161         (BrowserDriver.closeBrowser): Deleted.
1162         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1163         (OSXBrowserDriver):
1164         (OSXBrowserDriver.prepare_env):
1165         (OSXBrowserDriver.close_browsers):
1166         (OSXBrowserDriver._launch_process):
1167         (OSXBrowserDriver._terminiate_processes):
1168         (OSXBrowserDriver._launch_process_with_caffinate):
1169         (OSXBrowserDriver._screen_size):
1170         (OSXBrowserDriver.prepareEnv): Deleted.
1171         (OSXBrowserDriver.closeBrowsers): Deleted.
1172         (OSXBrowserDriver.launchProcess): Deleted.
1173         (OSXBrowserDriver.terminateProcesses): Deleted.
1174         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
1175         (OSXBrowserDriver.screenSize): Deleted.
1176         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1177         (OSXChromeDriver):
1178         (OSXChromeDriver.launch_url):
1179         (OSXChromeCanaryDriver):
1180         (OSXChromeCanaryDriver.launch_url):
1181         (OSXChromeDriver.launchUrl): Deleted.
1182         (OSXChromeCanaryDriver.launchUrl): Deleted.
1183         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1184         (OSXFirefoxDriver):
1185         (OSXFirefoxDriver.launch_url):
1186         (OSXFirefoxNightlyDriver):
1187         (OSXFirefoxNightlyDriver.launch_url):
1188         (OSXFirefoxDriver.launchUrl): Deleted.
1189         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
1190         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1191         (OSXSafariDriver):
1192         (OSXSafariDriver.prepare_env):
1193         (OSXSafariDriver.launch_url):
1194         (OSXSafariDriver.close_browsers):
1195         (OSXSafariDriver._maximize_window):
1196         (OSXSafariDriver.prepareEnv): Deleted.
1197         (OSXSafariDriver.launchUrl): Deleted.
1198         (OSXSafariDriver.closeBrowsers): Deleted.
1199         (OSXSafariDriver.maximizeWindow): Deleted.
1200         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1201         (HTTPServerDriver.fetch_result):
1202         (HTTPServerDriver.kill_server):
1203         (HTTPServerDriver.get_return_code):
1204         (HTTPServerDriver.set_device_id):
1205         (HTTPServerDriver.fetchResult): Deleted.
1206         (HTTPServerDriver.killServer): Deleted.
1207         (HTTPServerDriver.getReturnCode): Deleted.
1208         (HTTPServerDriver.setDeviceID): Deleted.
1209         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1210         (SimpleHTTPServerDriver.serve):
1211         (SimpleHTTPServerDriver.base_url):
1212         (SimpleHTTPServerDriver.fetch_result):
1213         (SimpleHTTPServerDriver.kill_server):
1214         (SimpleHTTPServerDriver.get_return_code):
1215         (SimpleHTTPServerDriver): Deleted.
1216         (SimpleHTTPServerDriver.baseUrl): Deleted.
1217         (SimpleHTTPServerDriver.fetchResult): Deleted.
1218         (SimpleHTTPServerDriver.killServer): Deleted.
1219         (SimpleHTTPServerDriver.getReturnCode): Deleted.
1220         * Scripts/webkitpy/benchmark_runner/utils.py:
1221         (get_path_from_project_root):
1222         (force_remove):
1223         (getPathFromProjectRoot): Deleted.
1224         (forceRemove): Deleted.
1225
1226 2015-06-23  Anders Carlsson  <andersca@apple.com>
1227
1228         Add operator! and copy/move constructors to WeakObjCPtr
1229         https://bugs.webkit.org/show_bug.cgi?id=146255
1230
1231         Reviewed by Andreas Kling.
1232
1233         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1234         (TEST):
1235
1236 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
1237
1238         Expose some more rendering progress events, and have MiniBrowser log for each of them
1239         https://bugs.webkit.org/show_bug.cgi?id=146227
1240
1241         Reviewed by Darin Adler.
1242
1243         Register for layout milestones/rendering progress events in the WK1 and WK2
1244         browser window controllers, and, if logging is turned on, log when they are
1245         reached.
1246
1247         * MiniBrowser/mac/WK1BrowserWindowController.m:
1248         (-[WK1BrowserWindowController awakeFromNib]):
1249         (-[WK1BrowserWindowController webView:didLayout:]):
1250         * MiniBrowser/mac/WK2BrowserWindowController.m:
1251         (-[WK2BrowserWindowController awakeFromNib]):
1252         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
1253
1254 2015-06-23  Brady Eidson  <beidson@apple.com>
1255
1256         WKFrameInfo should have an accessor for the Frame's current security origin.
1257         https://bugs.webkit.org/show_bug.cgi?id=146162
1258
1259         Reviewed by Dan Bernstein.
1260
1261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1262         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
1264         (sawDialog):
1265         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1266         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1267         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1268         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1269         (TEST):
1270
1271 2015-06-23  Tanay C  <tanay.c@samsung.com>
1272
1273         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
1274         https://bugs.webkit.org/show_bug.cgi?id=146007
1275
1276         Reviewed by Darin Adler.
1277
1278         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1279         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
1280         (pluginLogWithWindowObject):
1281         (pluginLogWithArguments):
1282         (pluginLog):
1283         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
1284         (PluginTest::executeScript):
1285         (PluginTest::log):
1286
1287 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
1288
1289         [EFL] Add libhyphen-dev as dependency after r185862
1290         https://bugs.webkit.org/show_bug.cgi?id=146230
1291
1292         Reviewed by Gyuyoung Kim.
1293
1294         * efl/install-dependencies:
1295
1296 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
1297
1298         [EFL] Hyphenation is not supported
1299         https://bugs.webkit.org/show_bug.cgi?id=89830
1300
1301         Reviewed by Gyuyoung Kim.
1302
1303         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
1304
1305 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
1306
1307         Get rid of factory json files in benchmark_runner
1308         https://bugs.webkit.org/show_bug.cgi?id=146175
1309
1310         Reviewed by Ryosuke Niwa.
1311
1312         Get rid of factory json files in benchmark_runner and refactoring the code.
1313
1314         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
1315         (benchmark_builder_loader):
1316         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
1317         (BenchmarkBuilderFactory):
1318         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
1319         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1320         (GenericBenchmarkBuilder):
1321         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1322         (BenchmarkRunner.__init__):
1323         (BenchmarkRunner.execute):
1324         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
1325         (browser_driver_loader):
1326         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1327         (BrowserDriver):
1328         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1329         (BrowserDriverFactory):
1330         (BrowserDriverFactory.available_platforms):
1331         (BrowserDriverFactory.available_browsers):
1332         (BrowserDriverFactory.add_browser_driver):
1333         (BrowserDriverFactory.create):
1334         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
1335         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1336         (OSXBrowserDriver):
1337         (OSXBrowserDriver.prepareEnv):
1338         (OSXBrowserDriver.terminateProcesses):
1339         (OSXBrowserDriver.screenSize):
1340         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1341         (OSXChromeDriver):
1342         (OSXChromeCanaryDriver):
1343         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1344         (OSXFirefoxDriver):
1345         (OSXFirefoxNightlyDriver):
1346         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1347         (OSXSafariDriver):
1348         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1349         (GenericFactory.create):
1350         (GenericFactory.add):
1351         (GenericFactory.iterateGetItem): Deleted.
1352         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
1353         (http_server_driver_loader):
1354         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1355         (HTTPServerDriver):
1356         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
1357         (HTTPServerDriverFactory):
1358         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
1359         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1360         (SimpleHTTPServerDriver):
1361         * Scripts/webkitpy/benchmark_runner/utils.py:
1362         (is_subclass):
1363         (load_subclasses):
1364         (ModuleNotFoundError): Deleted.
1365         (loadModule): Deleted.
1366         (loadJSONFromFile): Deleted.
1367
1368 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
1369
1370         Make it possible to enable incremental rendering suppression in MiniBrowser
1371         https://bugs.webkit.org/show_bug.cgi?id=146223
1372         
1373         Reviewed by Tim Horton.
1374
1375         Add a menu item to enable incremental rendering suppression to MiniBrowser.
1376         
1377         For WK1, this just toggles a pref, and takes effect immediately.
1378         
1379         For WK2, this is a WKConfiguration property, so only affects new web views.
1380         
1381         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
1382         logging on launch.
1383
1384         * MiniBrowser/mac/AppDelegate.m:
1385         (defaultConfiguration):
1386         * MiniBrowser/mac/BrowserWindow.xib:
1387         * MiniBrowser/mac/SettingsController.h:
1388         * MiniBrowser/mac/SettingsController.m:
1389         (-[SettingsController _populateMenu]):
1390         (-[SettingsController validateMenuItem:]):
1391         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
1392         (-[SettingsController incrementalRenderingSuppressed]):
1393         * MiniBrowser/mac/WK1BrowserWindowController.m:
1394         (-[WK1BrowserWindowController didChangeSettings]):
1395
1396 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
1397
1398         Run CDjs as part of JSC stress testing
1399         https://bugs.webkit.org/show_bug.cgi?id=146174
1400
1401         Reviewed by Geoffrey Garen.
1402
1403         * Scripts/run-javascriptcore-tests:
1404         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
1405         * Scripts/run-jsc-stress-tests:
1406         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
1407         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
1408         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
1409
1410 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
1411
1412         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
1413         https://bugs.webkit.org/show_bug.cgi?id=146121
1414         rdar://problem/21395180
1415
1416         Reviewed by Darin Adler.
1417
1418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1419         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
1420         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
1421         (TestWebKitAPI::overrideAppleLanguages):
1422         (TestWebKitAPI::languageForSystemLanguage):
1423         (TestWebKitAPI::TEST):
1424
1425 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1426
1427         [CMake] Ignore warnings from system headers when compiling Tools
1428         https://bugs.webkit.org/show_bug.cgi?id=146185
1429
1430         Reviewed by Martin Robinson.
1431
1432         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
1433         from system headers that we don't control.
1434
1435         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1436         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
1437         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
1438         * ImageDiff/PlatformGTK.cmake:
1439         * MiniBrowser/efl/CMakeLists.txt:
1440         * MiniBrowser/gtk/CMakeLists.txt:
1441         * TestWebKitAPI/PlatformEfl.cmake:
1442         * TestWebKitAPI/PlatformGTK.cmake:
1443         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1444         * WebKitTestRunner/CMakeLists.txt:
1445         * WebKitTestRunner/PlatformEfl.cmake:
1446         * WebKitTestRunner/PlatformGTK.cmake:
1447
1448 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1449
1450         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
1451         https://bugs.webkit.org/show_bug.cgi?id=146186
1452
1453         Reviewed by Martin Robinson.
1454
1455         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
1456         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
1457
1458         * MiniBrowser/gtk/CMakeLists.txt:
1459
1460 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
1461
1462         Build fix after r146125.
1463
1464         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1465         (OSXSafariDriver):
1466         (OSXSafariDriver.prepareEnv):
1467
1468 2015-06-19  Brady Eidson  <beidson@apple.com>
1469
1470         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
1471         https://bugs.webkit.org/show_bug.cgi?id=146152
1472
1473         Reviewed by Dan Bernstein.
1474
1475         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1476         * WebKitTestRunner/WebNotificationProvider.cpp:
1477
1478 2015-06-19  Mark Lam  <mark.lam@apple.com>
1479
1480         CheckedArithmetic's operator bool() and operator==() is broken.
1481         https://bugs.webkit.org/show_bug.cgi?id=146129
1482
1483         Reviewed by Geoffrey Garen and Oliver Hunt.
1484
1485         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
1486         and overflow scenarios in usage of the Checked arithmetic class.
1487
1488         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1489         (TestWebKitAPI::OverflowCrashLogger::overflowed):
1490         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
1491         (TestWebKitAPI::OverflowCrashLogger::crash):
1492         (TestWebKitAPI::OverflowCrashLogger::reset):
1493         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
1494         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
1495         (TestWebKitAPI::OverflowCrashLogger::didCrash):
1496         - crash logger for verifying that a crash occurs when expected. 
1497
1498         (TestWebKitAPI::resetOverflow):
1499         - convenience function for resetting a test value to an initial overflowed state
1500           before a crash.  We will use this value in the overflow testing.
1501
1502         (TestWebKitAPI::CheckedArithmeticTester::run):
1503         - Added new tests for all the comparison operators.
1504
1505 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
1506
1507         Fix the Windows build after r185721
1508         https://bugs.webkit.org/show_bug.cgi?id=146146
1509
1510         Reviewed by Csaba Osztrogonác.
1511
1512         Speculative buildfix.
1513
1514         * DumpRenderTree/win/UIDelegate.h:
1515         (UIDelegate::unused4): Added.
1516         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
1517
1518 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
1519
1520         Unreviewed. Add myself as a committer.
1521
1522         * Scripts/webkitpy/common/config/contributors.json:
1523
1524 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
1525
1526         Remove unnecessary svn:executable flags
1527         https://bugs.webkit.org/show_bug.cgi?id=146107
1528
1529         Reviewed by Alexey Proskuryakov.
1530
1531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
1532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
1533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
1535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
1536         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
1537         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
1538         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
1539         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
1540         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
1541         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
1542         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
1543         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
1544         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
1545
1546 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
1547
1548         Disable tests on the WinCairo buildbot
1549         https://bugs.webkit.org/show_bug.cgi?id=146106
1550
1551         Reviewed by Alexey Proskuryakov.
1552
1553         * BuildSlaveSupport/build.webkit.org-config/config.json:
1554         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1555
1556 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
1557
1558         [EFL] Fix the minibrowser after r185725
1559         https://bugs.webkit.org/show_bug.cgi?id=146135
1560
1561         Reviewed by Gyuyoung Kim.
1562
1563         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
1564         for the elm_config_accel_preference_set() to set the config of acceleration preference.
1565
1566         * MiniBrowser/efl/main.c:
1567         (elm_main): Deleted the HAVE_ECORE_X guard.
1568
1569 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
1570
1571         Extend capability of run-benchmark script to support mobile device
1572         https://bugs.webkit.org/show_bug.cgi?id=146125
1573
1574         Reviewed by Ryosuke Niwa.
1575
1576         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
1577         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
1578
1579         * Scripts/run-benchmark:
1580         (main): Deleted.
1581         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1582         (BenchmarkRunner.__init__):
1583         (BenchmarkRunner.execute):
1584         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1585         (BrowserDriver.prepareEnv):
1586         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1587         (OSXBrowserDriver.prepareEnv):
1588         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1589         (OSXSafariDriver.prepareEnv):
1590         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1591         (HTTPServerDriver.getReturnCode):
1592         (HTTPServerDriver):
1593         (HTTPServerDriver.setDeviceID):
1594         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
1595         (parse_args):
1596         (start):
1597         (main):
1598         * Scripts/webkitpy/benchmark_runner/utils.py:
1599         (getPathFromProjectRoot):
1600
1601 2015-06-18  Jon Lee  <jonlee@apple.com>
1602
1603         Unreviewed. Add Matt Daiter as a contributor.
1604
1605         * Scripts/webkitpy/common/config/contributors.json:
1606
1607 2015-06-18  Mark Lam  <mark.lam@apple.com>
1608
1609         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
1610         https://bugs.webkit.org/show_bug.cgi?id=146103
1611
1612         Not reviewed.
1613
1614         Follow up to fix some typos not caught before original patch was landed.
1615
1616         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1617         (TestWebKitAPI::CheckedArithmeticTester::run):
1618         (TestWebKitAPI::AllowMixedSignednessTest::run):
1619         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
1620
1621 2015-06-18  Daniel Bates  <dabates@apple.com>
1622
1623         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
1624         https://bugs.webkit.org/show_bug.cgi?id=146082
1625
1626         Reviewed by Darin Adler.
1627
1628         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
1629         working directory after being invoked in a different Git checkout. In particular,
1630         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
1631         a pure Git checkout g will fail to update g.
1632
1633         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
1634         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
1635         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
1636         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
1637         different than the current working directory). Instead runGitUpdate() should check
1638         whether the current working directory is a Git SVN checkout on each invocation.
1639
1640         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
1641         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
1642         SVN directory from isGitSVN().
1643         (isGitSVN): Implemented in terms of isGitSVNDirectory().
1644         * Scripts/webkitdirs.pm:
1645         (runGitUpdate): Modified to use isGitSVNDirectory().
1646
1647 2015-06-18  Mark Lam  <mark.lam@apple.com>
1648
1649         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
1650         https://bugs.webkit.org/show_bug.cgi?id=146103
1651
1652         Reviewed by Anders Carlsson.
1653
1654         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
1655         part of a large macro.  This makes them harder to:
1656
1657         1. write: no editor help with indentations, have to add trailing '\'s,
1658            inconvenient to add line breaks and comments.
1659
1660         2. read: no chroma coding / syntax highlighting.
1661
1662         3. debug: compile time errors are reported as being on the single line where
1663            the macro is used.
1664
1665         Refactoring the tests to use C++ templates solves all these issues.
1666
1667         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1668         (TestWebKitAPI::CheckedArithmeticTester::run):
1669         (TestWebKitAPI::AllowMixedSignednessTest::run):
1670         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
1671         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
1672         (TestWebKitAPI::CoerceLiteralNop::coerce):
1673
1674 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1675
1676         [EFL][WK2] Use Web Browser cache model in MiniBrowser
1677         https://bugs.webkit.org/show_bug.cgi?id=112273
1678
1679         Reviewed by Laszlo Gombos.
1680
1681         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
1682         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
1683         This way we have a decent cache capacity and the page cache actually works.
1684
1685         * MiniBrowser/efl/main.c:
1686         (elm_main):
1687
1688 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1689
1690         Remove redundant Chromium bug keyword
1691         https://bugs.webkit.org/show_bug.cgi?id=146097
1692
1693         Reviewed by Csaba Osztrogonác.
1694
1695         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1696         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
1697         (TestExpectationLine._format_line): Deleted.
1698
1699 2015-06-17  Daniel Bates  <dabates@apple.com>
1700
1701         Client may receive began editing callback for already focused text field
1702         https://bugs.webkit.org/show_bug.cgi?id=146074
1703         <rdar://problem/21293562>
1704
1705         Reviewed by Darin Adler.
1706
1707         Add a unit test to ensure that a client receives exactly one began editing
1708         callback when a text field is newly focused. In particular, dispatching
1709         a DOM focus event at an already focused text field does not dispatch a
1710         began editing callback to the client.
1711
1712         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1713         (TestWebKitAPI::TEST_F):
1714
1715 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1716
1717         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
1718         https://bugs.webkit.org/show_bug.cgi?id=26481
1719
1720         Reviewed by Darin Adler.
1721
1722         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
1723
1724         * DumpRenderTree/win/TestRunnerWin.cpp:
1725         (TestRunner::dispatchPendingLoadRequests):
1726         (TestRunner::overridePreference):
1727
1728 2015-06-17  Alex Christensen  <achristensen@webkit.org>
1729
1730         [Content Extensions] Fail to parse invalid arrays
1731         https://bugs.webkit.org/show_bug.cgi?id=146079
1732         rdar://problem/21422649
1733
1734         Reviewed by Benjamin Poulain.
1735
1736         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1737         (TestWebKitAPI::TEST_F):
1738         Correct and add parsing tests with invalid arrays.
1739
1740 2015-06-17  Matt Rajca  <mrajca@apple.com>
1741
1742         Unreviewed. Added myself as a committer.
1743
1744         * Scripts/webkitpy/common/config/contributors.json:
1745
1746 2015-06-17  Daniel Bates  <dabates@apple.com>
1747
1748         Export VCSUtils::gitTreeDirectory()
1749         <rdar://problem/21248901>
1750
1751         Rubber-stamped by Alexey Proskuryakov.
1752
1753         * Scripts/VCSUtils.pm:
1754
1755 2015-06-17  Tim Horton  <timothy_horton@apple.com>
1756
1757         Safari tabs still have shrunken content after coming out of fullscreen
1758         https://bugs.webkit.org/show_bug.cgi?id=146037
1759         <rdar://problem/21105960>
1760
1761         Reviewed by Simon Fraser and Darin Adler.
1762
1763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1764         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
1765         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
1766         (TEST):
1767         Add a test that ensures that disabling scale-to-fit mode correctly updates
1768         the page's layout.
1769
1770 2015-06-17  Dan Bernstein  <mitz@apple.com>
1771
1772         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
1773         https://bugs.webkit.org/show_bug.cgi?id=145957
1774
1775         Reviewed by Darin Adler.
1776
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1778         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
1779
1780 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
1781
1782         AX:  iOS accessibility tests are not running because we need WKTR support
1783         https://bugs.webkit.org/show_bug.cgi?id=145991
1784
1785         Reviewed by Daniel Bates.
1786
1787         Add support for WKTR iOS accessibility.
1788         Utilize the notification handling mechanisms that Mac already uses.
1789         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
1790
1791         * DumpRenderTree/AccessibilityUIElement.cpp:
1792         (stringForSelectionCallback):
1793         (getIdentifierCallback):
1794         (getTraitsCallback):
1795         (getElementTextPositionCallback):
1796         (getElementTextLengthCallback):
1797         (AccessibilityUIElement::getJSClass):
1798         (getIPhoneLabelCallback): Deleted.
1799         (getIPhoneHintCallback): Deleted.
1800         (getIPhoneValueCallback): Deleted.
1801         (getIPhoneIdentifierCallback): Deleted.
1802         (getIPhoneTraitsCallback): Deleted.
1803         (getIPhoneIsElementCallback): Deleted.
1804         (getIPhoneElementTextPositionCallback): Deleted.
1805         (getIPhoneElementTextLengthCallback): Deleted.
1806         * DumpRenderTree/AccessibilityUIElement.h:
1807         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1808         (AccessibilityUIElement::identifier):
1809         (AccessibilityUIElement::traits):
1810         (AccessibilityUIElement::elementTextPosition):
1811         (AccessibilityUIElement::elementTextLength):
1812         (AccessibilityUIElement::description):
1813         (AccessibilityUIElement::orientation):
1814         (AccessibilityUIElement::stringValue):
1815         (AccessibilityUIElement::language):
1816         (AccessibilityUIElement::helpText):
1817         (AccessibilityUIElement::intValue):
1818         (AccessibilityUIElement::isSelected):
1819         (AccessibilityUIElement::isExpanded):
1820         (AccessibilityUIElement::documentURI):
1821         (AccessibilityUIElement::addNotificationListener):
1822         (AccessibilityUIElement::removeNotificationListener):
1823         (AccessibilityUIElement::isFocusable):
1824         (AccessibilityUIElement::isIgnored):
1825         (AccessibilityUIElement::hasPopup):
1826         (AccessibilityUIElement::iphoneLabel): Deleted.
1827         (AccessibilityUIElement::iphoneHint): Deleted.
1828         (AccessibilityUIElement::iphoneValue): Deleted.
1829         (AccessibilityUIElement::iphoneIdentifier): Deleted.
1830         (AccessibilityUIElement::iphoneTraits): Deleted.
1831         (AccessibilityUIElement::iphoneIsElement): Deleted.
1832         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
1833         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
1834         (_accessibilityNotificationCallback): Deleted.
1835         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1836         (WTR::AccessibilityUIElement::isValid):
1837         (WTR::AccessibilityUIElement::identifier):
1838         (WTR::AccessibilityUIElement::traits):
1839         (WTR::AccessibilityUIElement::elementTextPosition):
1840         (WTR::AccessibilityUIElement::elementTextLength):
1841         (WTR::AccessibilityUIElement::stringForSelection):
1842         (WTR::AccessibilityUIElement::elementsForRange):
1843         (WTR::AccessibilityUIElement::increaseTextSelection):
1844         (WTR::AccessibilityUIElement::decreaseTextSelection):
1845         (WTR::AccessibilityUIElement::linkedElement):
1846         (WTR::AccessibilityUIElement::headerElementAtIndex):
1847         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1848         (WTR::AccessibilityUIElement::characterAtOffset):
1849         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1850         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1851         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1852         (WTR::findAccessibleObjectById):
1853         (WTR::AccessibilityController::accessibleElementById):
1854         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1855         (+[NSString stringWithJSStringRef:]):
1856         (-[NSString createJSStringRef]):
1857         (WTR::convertNSArrayToVector):
1858         (WTR::concatenateAttributeAndValue):
1859         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1860         (WTR::AccessibilityUIElement::isEqual):
1861         (WTR::AccessibilityUIElement::headerElementAtIndex):
1862         (WTR::AccessibilityUIElement::linkedElement):
1863         (WTR::AccessibilityUIElement::getLinkedUIElements):
1864         (WTR::AccessibilityUIElement::elementAtPoint):
1865         (WTR::convertElementsToObjectArray):
1866         (WTR::AccessibilityUIElement::elementsForRange):
1867         (WTR::AccessibilityUIElement::indexOfChild):
1868         (WTR::AccessibilityUIElement::stringAttributeValue):
1869         (WTR::AccessibilityUIElement::description):
1870         (WTR::AccessibilityUIElement::orientation):
1871         (WTR::AccessibilityUIElement::stringValue):
1872         (WTR::AccessibilityUIElement::language):
1873         (WTR::AccessibilityUIElement::helpText):
1874         (WTR::AccessibilityUIElement::x):
1875         (WTR::AccessibilityUIElement::clickPointX):
1876         (WTR::AccessibilityUIElement::clickPointY):
1877         (WTR::AccessibilityUIElement::intValue):
1878         (WTR::AccessibilityUIElement::minValue):
1879         (WTR::AccessibilityUIElement::maxValue):
1880         (WTR::AccessibilityUIElement::valueDescription):
1881         (WTR::AccessibilityUIElement::isSelected):
1882         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1883         (WTR::AccessibilityUIElement::stringForRange):
1884         (WTR::AccessibilityUIElement::attributedStringForRange):
1885         (WTR::AccessibilityUIElement::attributesOfHeader):
1886         (WTR::AccessibilityUIElement::traits):
1887         (WTR::AccessibilityUIElement::identifier):
1888         (WTR::AccessibilityUIElement::rowCount):
1889         (WTR::AccessibilityUIElement::rowIndexRange):
1890         (WTR::AccessibilityUIElement::columnIndexRange):
1891         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1892         (WTR::AccessibilityUIElement::horizontalScrollbar):
1893         (WTR::AccessibilityUIElement::documentURI):
1894         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1895         (WTR::AccessibilityUIElement::increaseTextSelection):
1896         (WTR::AccessibilityUIElement::decreaseTextSelection):
1897         (WTR::AccessibilityUIElement::stringForSelection):
1898         (WTR::AccessibilityUIElement::elementTextPosition):
1899         (WTR::AccessibilityUIElement::elementTextLength):
1900         (WTR::AccessibilityUIElement::url):
1901         (WTR::AccessibilityUIElement::addNotificationListener):
1902         (WTR::AccessibilityUIElement::removeNotificationListener):
1903         (WTR::AccessibilityUIElement::isFocusable):
1904         (WTR::AccessibilityUIElement::isIgnored):
1905         (WTR::AccessibilityUIElement::hasPopup):
1906         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1907         (WTR::_CGPathEnumerationIteration):
1908         (WTR::AccessibilityUIElement::pathDescription):
1909         (WTR::AccessibilityUIElement::supportedActions):
1910
1911 2015-06-16  Mark Lam  <mark.lam@apple.com>
1912
1913         Use NakedPtr<Exception>& to return exception results.
1914         https://bugs.webkit.org/show_bug.cgi?id=145870
1915
1916         Reviewed by Anders Carlsson and Filip Pizlo.
1917
1918         * TestWebKitAPI/CMakeLists.txt:
1919         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1920         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1922         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
1923         (TestWebKitAPI::TEST):
1924         (TestWebKitAPI::nakedPtrFoo):
1925
1926 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
1927
1928         Unreviewed. Adding myself as a committer.
1929
1930         * Scripts/webkitpy/common/config/contributors.json:
1931
1932 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
1933
1934         Add test expectations for El Capitan
1935         https://bugs.webkit.org/show_bug.cgi?id=146005
1936
1937         Rubber-stamped by Dan Bernstein.
1938
1939         Add appropriate tools code.
1940
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1945         Added dashboard support.
1946
1947         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1948         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1949         Trigger the right build queues on check-in.
1950
1951         * Scripts/webkitpy/common/system/platforminfo.py:
1952         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1953         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1954         * Scripts/webkitpy/port/mac.py:
1955         * Scripts/webkitpy/port/mac_unittest.py:
1956         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1957         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1958         Added cases for El Capitan, and updated tests for new baseline search paths.
1959
1960 2015-06-15  Alex Christensen  <achristensen@webkit.org>
1961
1962         [Content Extensions] Make max NFA size and max rule count user defaults.
1963         https://bugs.webkit.org/show_bug.cgi?id=145663
1964
1965         Reviewed by Benjamin Poulain.
1966
1967         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1968         (TestWebKitAPI::TEST_F):
1969
1970 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1971
1972         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
1973         https://bugs.webkit.org/show_bug.cgi?id=145900
1974
1975         Reviewed by Sam Weinig.
1976
1977         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1978         (TEST): Added tests.
1979
1980 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1981
1982         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
1983         https://bugs.webkit.org/show_bug.cgi?id=145969
1984
1985         Reviewed by Sergio Villar Senin.
1986
1987         Add a test case to the custom URI schemes unit test.
1988
1989         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1990         (testWebContextURIScheme):
1991
1992 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1993
1994         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
1995         https://bugs.webkit.org/show_bug.cgi?id=145922
1996
1997         Reviewed by Carlos Garcia Campos.
1998
1999         * gtk/jhbuild.modules:
2000         * gtk/patches/glib-warning-fix.patch: Added.
2001
2002 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
2003
2004         Update springLoadingHighlight type
2005         https://bugs.webkit.org/show_bug.cgi?id=145939
2006         rdar://problem/20880213
2007
2008         Reviewed by Darin Adler.
2009
2010         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2011         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2012         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2013         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2014
2015 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
2016
2017         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
2018         https://bugs.webkit.org/show_bug.cgi?id=145945
2019
2020         Reviewed by Stephanie Lewis.
2021
2022         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2023         (OSXBrowserDriver.prepareEnv):
2024         (OSXBrowserDriver.moveCursor): Deleted.
2025         (OSXBrowserDriver): Deleted.
2026         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2027         (OSXSafariDriver.prepareEnv):
2028
2029 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
2030
2031         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
2032         https://bugs.webkit.org/show_bug.cgi?id=145938
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
2037         LWP::UserAgent to get access to more robust HTTPS support.
2038
2039 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2040
2041         [GTK] Fix return type warning in WebViewTest.cpp
2042         https://bugs.webkit.org/show_bug.cgi?id=145914
2043
2044         Reviewed by Darin Adler.
2045
2046         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2047         (WebViewTest::isEditable):
2048
2049 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
2050
2051         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
2052         https://bugs.webkit.org/show_bug.cgi?id=145799
2053
2054         Reviewed by Carlos Garcia Campos.
2055
2056         Update header inclusions for headers that have been moved
2057         to Source/WTF/wtf/glib/.
2058
2059         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
2060         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
2061
2062         * TestWebKitAPI/PlatformGTK.cmake:
2063         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
2064         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2065         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2066         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2067         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
2068         (TestWebKitAPI::GMainLoopSourceTest::finish):
2069         (TestWebKitAPI::GMainLoopSourceTest::source):
2070         (TestWebKitAPI::basicRescheduling):
2071         (TestWebKitAPI::TEST):
2072         (TestWebKitAPI::reentrantRescheduling):
2073         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2074         (TestWebKitAPI::basicDestroyCallbacks):
2075         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2076         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2077         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
2078         (log):
2079         (takeLogStr):
2080         (TestWebKitAPI::TEST):
2081         (TestWebKitAPI::returnOutChar):
2082         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2083         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2084         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
2085         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
2086         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
2087         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
2088         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
2089         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
2090         (TestWebKitAPI::basicRescheduling): Deleted.
2091         (TestWebKitAPI::TEST): Deleted.
2092         (TestWebKitAPI::reentrantRescheduling): Deleted.
2093         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
2094         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
2095         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
2096         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
2097         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
2098         (log): Deleted.
2099         (takeLogStr): Deleted.
2100         (TestWebKitAPI::TEST): Deleted.
2101         (TestWebKitAPI::returnOutChar): Deleted.
2102         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
2103         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2104         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2105         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2106         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2107         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2108         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2109         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2110         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2111         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2112         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2113         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2114         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2115         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
2116         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2117         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
2118         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
2119         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2120         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2121         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2122         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2123         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2124         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2125         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2126         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2127         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
2128         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2129         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2130         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
2131         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
2132         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2133         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
2134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2136         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2137         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2138         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
2139         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2140         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2141         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2142         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2143         * WebKitTestRunner/PlatformGTK.cmake:
2144         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2145         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2146
2147 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2148
2149         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
2150         https://bugs.webkit.org/show_bug.cgi?id=145913
2151
2152         Reviewed by Gyuyoung Kim.
2153
2154         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2155         (TestWebKitAPI::setupGeolocationProvider):
2156         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2157         (TestWebKitAPI::setPageLoaderClient):
2158         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2159         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2160         * WebKitTestRunner/GeolocationProviderMock.cpp:
2161         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2162         * WebKitTestRunner/WebNotificationProvider.cpp:
2163         (WTR::WebNotificationProvider::provider):
2164
2165 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2166
2167         Fix the libusrsctp build with clang
2168         https://bugs.webkit.org/show_bug.cgi?id=145128
2169
2170         Reviewed by Gyuyoung Kim.
2171
2172         * efl/jhbuild.modules:
2173         * gtk/jhbuild.modules:
2174
2175 2015-06-11  Mark Lam  <mark.lam@apple.com>
2176
2177         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
2178         https://bugs.webkit.org/show_bug.cgi?id=145872
2179
2180         Reviewed by Michael Saboff.
2181
2182         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
2183         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2184         - Exercises the JSC ObjC API to call a function which throws an exception.  That
2185           exception will be returned as a JSValue instead of an Exception object.  We
2186           will use this JSValue to test WebCore::reportException() to confirm that it is
2187           able to handle an exception value which is not an Exception object.
2188
2189 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
2190
2191         Move cursor to corner and fix safari window size before running benchmark
2192         https://bugs.webkit.org/show_bug.cgi?id=145858
2193
2194         Reviewed by Ryosuke Niwa
2195
2196         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2197         (OSXBrowserDriver.prepareEnv):
2198         (OSXBrowserDriver):
2199         (OSXBrowserDriver.moveCursor):
2200         (OSXBrowserDriver.getScreenSize):
2201         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2202         (OSXChromeDriver.launchUrl):
2203         (OSXChromeCanaryDriver.launchUrl):
2204         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2205         (OSXFirefoxDriver.launchUrl):
2206         (OSXFirefoxNightlyDriver.launchUrl):
2207         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2208         (OSXSafariDriver.prepareEnv):
2209         (OSXSafariDriver):
2210         (OSXSafariDriver.maximizeWindow):
2211
2212 2015-06-11  Daniel Bates  <dabates@apple.com>
2213
2214         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
2215         https://bugs.webkit.org/show_bug.cgi?id=145319
2216
2217         Reviewed by David Kilzer.
2218
2219         Add SPI wrapper header for CoreSimulator and update the source files to reference
2220         it instead of directly referencing the CoreSimulator header.
2221
2222         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
2223         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
2224         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2225         * LayoutTestRelay/LayoutTestRelay/main.m:
2226
2227 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
2228
2229         [EFL] dimmed area for popup does not cover the fullscreen mode.
2230         https://bugs.webkit.org/show_bug.cgi?id=145133
2231
2232         Reviewed by Gyuyoung Kim.
2233
2234         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
2235         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
2236
2237         * MiniBrowser/efl/main.c:
2238         (on_fullscreen_accept):
2239         (on_fullscreen_deny):
2240         (on_fullscreen_enter):
2241
2242 2015-06-10  Commit Queue  <commit-queue@webkit.org>
2243
2244         Unreviewed, rolling out r185442.
2245         https://bugs.webkit.org/show_bug.cgi?id=145871
2246
2247         seems to have broken WTF.StringOperators test (Requested by
2248         alexchristensen on #webkit).
2249
2250         Reverted changeset:
2251
2252         "[Content Extensions] Limit number of rules."
2253         https://bugs.webkit.org/show_bug.cgi?id=145663
2254         http://trac.webkit.org/changeset/185442
2255
2256 2015-06-10  Alex Christensen  <achristensen@webkit.org>
2257
2258         [Content Extensions] Make max NFA size and max rule count user defaults.
2259         https://bugs.webkit.org/show_bug.cgi?id=145663
2260         rdar://problem/21242407
2261
2262         Reviewed by Benjamin Poulain.
2263
2264         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2265         (TestWebKitAPI::TEST_F):
2266
2267 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2268
2269         [EFL] Execute Javascript method in mini browser address bar.
2270         https://bugs.webkit.org/show_bug.cgi?id=145725
2271
2272         Reviewed by Gyuyoung Kim.
2273
2274         Support 'javascript:' scheme in WebKit EFL Mini Browser.
2275
2276         * MiniBrowser/efl/main.c:
2277         (url_from_user_input):
2278         (url_load_from_user_input):
2279         (on_url_bar_activated):
2280         (elm_main):
2281
2282 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2283
2284         Implement dumpProgressFinishedCallback() for Win layoutTestController.
2285         https://bugs.webkit.org/show_bug.cgi?id=66773
2286
2287         Reviewed by Darin Adler.
2288
2289         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2290         * DumpRenderTree/win/FrameLoadDelegate.h:
2291
2292 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
2293
2294         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
2295         https://bugs.webkit.org/show_bug.cgi?id=145764
2296
2297         Reviewed by Darin Adler.
2298
2299         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
2300         JetStream and SunSpider.
2301
2302         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2303         (GenericBenchmarkBuilder):
2304         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
2305         the whole JSON as the input.
2306         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
2307         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
2308         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2309         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
2310         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
2311         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2312         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2313
2314 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2315
2316         Remove ewstool scripts used by chromium port
2317         https://bugs.webkit.org/show_bug.cgi?id=145789
2318
2319         Reviewed by Csaba Osztrogonác.
2320
2321         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
2322         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
2323         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
2324         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
2325         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
2326
2327 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2328
2329         Unreviewed, updated my list of email addresses.
2330
2331         * Scripts/webkitpy/common/config/contributors.json:
2332
2333 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
2334
2335         [cmake] Fix the style issues in cmake project files
2336         https://bugs.webkit.org/show_bug.cgi?id=145755
2337
2338         Reviewed by Darin Adler.
2339
2340         * TestWebKitAPI/CMakeLists.txt:
2341         * TestWebKitAPI/PlatformEfl.cmake:
2342
2343 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2344
2345         Fix a typo in r185345.
2346
2347         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2348         (OSXSafariDriver.closeBrowsers):
2349
2350 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2351
2352         Yet another unreviewed build fix :(
2353
2354         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2355         (OSXSafariDriver):
2356         (OSXSafariDriver.launchUrl):
2357         (OSXSafariDriver.closeBrowsers):
2358
2359 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2360
2361         Unreviewed build fix. Initialize result in the case things blow up below.
2362
2363         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2364         (BenchmarkRunner.execute):
2365
2366 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2367
2368         Partially revert and fix after r185243.
2369
2370         * Scripts/benchmark_runner/benchmark_runner.py:
2371         * Scripts/run-benchmark:
2372
2373 2015-06-08  Daniel Bates  <dabates@apple.com>
2374
2375         Many LayoutTests/http tests time out in DumpRenderTree
2376         https://bugs.webkit.org/show_bug.cgi?id=145770
2377         <rdar://problem/19593910>
2378
2379         Reviewed by Alexey Proskuryakov.
2380
2381         * DumpRenderTree/ios/Info.plist: Add ATS key.
2382         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2383         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
2384         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
2385         that make use of testRunner.pathToLocalResource().
2386
2387 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
2388
2389         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
2390         https://bugs.webkit.org/show_bug.cgi?id=145759
2391
2392         Reviewed by Carlos Garcia Campos.
2393
2394         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2395         (testWebViewSave):
2396
2397 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2398
2399         [GTK] Add editor mode to MiniBrowser
2400         https://bugs.webkit.org/show_bug.cgi?id=145595
2401
2402         Reviewed by Sergio Villar Senin.
2403
2404         It loads an empty editable web view with an edit toolbar. It makes
2405         easier to test the editor, editing commands and input methods.
2406
2407         * MiniBrowser/gtk/BrowserWindow.c:
2408         (editingCommandCallback):
2409         (browserWindowSetupEditorToolbar):
2410         (browserWindowConstructed):
2411         * MiniBrowser/gtk/main.c:
2412         (createBrowserWindow):
2413
2414 2015-06-05  Zalan Bujtas  <zalan@apple.com>
2415
2416         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
2417
2418         Reviewed by Dan Bernstein.
2419
2420         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2421         (TestWebKitAPI::TEST):
2422
2423 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2424
2425         [EFL] API test has been broken since r184357
2426         https://bugs.webkit.org/show_bug.cgi?id=145635
2427
2428         Reviewed by Darin Adler.
2429
2430         r184357 suppress cmake build warning using TARGET_FILE property. However
2431         many EFL API test cases have been broken after applying it.
2432
2433         * TestWebKitAPI/CMakeLists.txt:
2434
2435 2015-06-05  Anders Carlsson  <andersca@apple.com>
2436
2437         Make the network cache directory part of WKContextConfigurationRef
2438         https://bugs.webkit.org/show_bug.cgi?id=145711
2439
2440         Reviewed by Antti Koivisto.
2441
2442         * WebKitTestRunner/TestController.cpp:
2443         (WTR::TestController::initialize):
2444
2445 2015-06-05  Anders Carlsson  <andersca@apple.com>
2446
2447         Make the application cache directory part of WKContextConfigurationRef
2448         https://bugs.webkit.org/show_bug.cgi?id=145704
2449
2450         Reviewed by Geoffrey Garen.
2451
2452         * WebKitTestRunner/TestController.cpp:
2453         (WTR::TestController::initialize):
2454
2455 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2456
2457         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
2458         https://bugs.webkit.org/show_bug.cgi?id=145680
2459
2460         Reviewed by Brent Fulgham.
2461
2462         * Scripts/webkitpy/style/checkers/cpp.py:
2463         (check_for_null):
2464         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2465         (WebKitStyleTest.test_null_false_zero):
2466
2467 2015-06-05  Stephanie Lewis  <slewis@apple.com>
2468
2469         Make the web server more robust to timing issues..
2470
2471         Reviewed by Ryosuke Niwa.
2472
2473         Cleaned up exception handling.
2474         Test server is actually serving pages before returning.
2475         Clean up some style issues.
2476
2477         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2478         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2479         (SimpleHTTPServerDriver.__init__):
2480         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
2481         (SimpleHTTPServerDriver.baseUrl): 
2482         (SimpleHTTPServerDriver.fetchResult):
2483         (SimpleHTTPServerDriver.killServer):
2484         (SimpleHTTPServerDriver.getReturnCode):
2485
2486 2015-06-05  Stephanie Lewis  <slewis@apple.com>
2487
2488
2489         Add errors to run-benchmark exception handling.
2490
2491         Reviewed by Ryosuke Niwa.
2492
2493         * Scripts/run-benchmark:
2494         (main):
2495         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2496         (GenericBenchmarkBuilder.prepare):
2497         (GenericBenchmarkBuilder._runCreateScript):
2498         (GenericBenchmarkBuilder._applyPatch):
2499         (GenericBenchmarkBuilder.clean):
2500         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2501         (BenchmarkRunner.__init__):
2502         (BenchmarkRunner.execute):
2503         (BenchmarkRunner):
2504         (BenchmarkRunner.cleanup):
2505         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
2506         (GenericFactory.iterateGetItem):
2507         (GenericFactory.create):
2508         * Scripts/webkitpy/benchmark_runner/utils.py:
2509         (loadModule):
2510         (loadJSONFromFile):
2511         (forceRemove):
2512
2513 2015-06-05  Stephanie Lewis  <slewis@apple.com>
2514
2515         Streamline run-benchmark browser
2516
2517         Reviewed by Ryosuke Niwa.
2518
2519         Add Caffeinate so computer won't sleep while running.
2520         Remove calls to collect output since we were just dumping to stdout anyway.
2521         Add xpc dyld_path.
2522         Default to system safari.
2523
2524         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2525         (OSXBrowserDriver.launchProcess):
2526         (OSXBrowserDriver.terminateProcesses):
2527         (OSXBrowserDriver):
2528         (OSXBrowserDriver.launchCaffeinateForProcess):
2529         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2530         (OSXSafariDriver.launchUrl):
2531         (OSXSafariDriver.closeBrowsers):
2532
2533 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
2534
2535         Combine tiny DFAs into slightly larger ones
2536         https://bugs.webkit.org/show_bug.cgi?id=145572
2537
2538         Reviewed by Alex Christensen.
2539
2540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2541         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
2542         (TestWebKitAPI::DFACombinerTest::SetUp):
2543         (TestWebKitAPI::combine):
2544         (TestWebKitAPI::TEST_F):
2545         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
2546         (TestWebKitAPI::countLiveNodes):
2547         (TestWebKitAPI::createNFAs):
2548         (TestWebKitAPI::buildDFAFromPatterns):
2549         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2550         (TestWebKitAPI::countLiveNodes): Deleted.
2551         (TestWebKitAPI::createNFAs): Deleted.
2552         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
2553
2554 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
2555
2556         WebKitTestRunner leaks strings in generateWhitelist()
2557         https://bugs.webkit.org/show_bug.cgi?id=145665
2558
2559         Reviewed by Myles C. Maxfield.
2560
2561         * WebKitTestRunner/mac/TestControllerMac.mm:
2562         (WTR::generateWhitelist):
2563
2564 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2565
2566         Fix options in build-jsc for CMake builds
2567         https://bugs.webkit.org/show_bug.cgi?id=145636
2568
2569         Reviewed by Gyuyoung Kim.
2570
2571         CMake only accepts -DXXX=YYY style options.
2572         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
2573
2574         * Scripts/build-jsc:
2575
2576 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
2577
2578         Added a patch so that the colors displayed on the page could be toggled
2579         in case people need accessibility colors displayed in their browser.
2580         https://bugs.webkit.org/show_bug.cgi?id=145570
2581         <rdar://problem/20994468>
2582
2583         Added in CSS colors and toggle buttons for checkmarks in the page, so that
2584         the page could be rendered in a specific way for accessibility needs if needed.
2585
2586         Reviewed by Alexey Proskuryakov.
2587
2588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2589         (updateHiddenPlatforms):
2590         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
2591         (toggleAccessibilityColors): Toggle colors on and off
2592         (documentReady): Needed to make changes to the initialization
2593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2594         (a:hover):
2595         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
2596         (div.cellButton.hide, div.accessibilityButton.hide):
2597         (div.cellButton.unhide, div.accessibilityButton.unhide):
2598         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
2599         (.popover-tracking:hover):
2600         (.accessibilityButton):
2601         (div.cellButton): Deleted.
2602         (div.cellButton.hide): Deleted.
2603         (div.cellButton.unhide): Deleted.
2604         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
2605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2606         (.status-line.neutral .bubble):
2607         (.status-line.unauthorized .bubble):
2608         (.status-line.danger .bubble.pictogram):
2609         (.status-line.bad .bubble.pictogram):
2610         (.status-line.no-bubble .message):
2611         (.status-line.bad .bubble):
2612         (.status-line.good .bubble):
2613         (.status-line.good .message):
2614         (.status-line.bad .message):
2615         (body.accessibility-colors .status-line.good .bubble):
2616         (body.accessibility-colors .status-line.bad .bubble):
2617         (body.accessibility-colors .status-line.good .message):
2618         (body.accessibility-colors .status-line.bad .message):
2619         (.status-line.danger .message):
2620         (.status-line.unauthorized .message):
2621
2622 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
2623
2624         Unreviewed build fix for Dromaeo.
2625
2626         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2627         (BenchmarkResults._aggregate_results_for_test):
2628
2629 2015-06-03  Anders Carlsson  <andersca@apple.com>
2630
2631         Fix build.
2632
2633         * DumpRenderTree/mac/TestRunnerMac.mm:
2634
2635 2015-06-03  Daniel Bates  <dabates@apple.com>
2636
2637         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
2638         https://bugs.webkit.org/show_bug.cgi?id=145616
2639
2640         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
2641         of the test. Further investigation is needed.
2642
2643         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
2644         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
2645
2646 2015-06-03  Brady Eidson  <beidson@apple.com>
2647
2648         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
2649         https://bugs.webkit.org/show_bug.cgi?id=145580
2650
2651         Reviewed by Mark Lam.
2652
2653         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2654         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
2655
2656 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
2657
2658         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
2659
2660         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2661         (TestWebKitAPI::TEST): Update the syntax.
2662
2663 2015-06-02  Mark Lam  <mark.lam@apple.com>
2664
2665         build-jsc's --cloop option is broken.
2666         https://bugs.webkit.org/show_bug.cgi?id=145516
2667
2668         Reviewed by Darin Adler.
2669
2670         * Scripts/build-jsc:
2671         - Make sure to disable the JIT when --cloop is specified.
2672           Did analogous fix for --ftljit.
2673
2674 2015-06-02  Daniel Bates  <dabates@apple.com>
2675
2676         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
2677
2678         Rubber-stamped by Alexey Proskuryakov.
2679
2680         * MiniBrowser/mac/Info.plist:
2681         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2682
2683 2015-06-01  Commit Queue  <commit-queue@webkit.org>
2684
2685         Unreviewed, rolling out r185066.
2686         https://bugs.webkit.org/show_bug.cgi?id=145543
2687
2688         it breaks the FTL JIT builds with a local checkout of llvm
2689         (Requested by pizlo on #webkit).
2690
2691         Reverted changeset:
2692
2693         "build-jsc's --cloop option is broken."
2694         https://bugs.webkit.org/show_bug.cgi?id=145516
2695         http://trac.webkit.org/changeset/185066
2696
2697 2015-06-01  Daniel Bates  <dabates@apple.com>
2698
2699         Notify client that we began editing when text field is focused
2700         https://bugs.webkit.org/show_bug.cgi?id=145439
2701         <rdar://problem/21142108>
2702
2703         Reviewed by Anders Carlsson.
2704
2705         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
2706         a text field is focused and defocused.
2707
2708         * TestWebKitAPI/CMakeLists.txt:
2709         * TestWebKitAPI/PlatformEfl.cmake:
2710         * TestWebKitAPI/PlatformGTK.cmake:
2711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2712         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
2713         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
2714         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
2715         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
2716         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
2717         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
2718         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
2719         (TestWebKitAPI::TEST_F):
2720         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
2721         (TestWebKitAPI::textFieldDidBeginEditing):
2722         (TestWebKitAPI::textFieldDidEndEditing):
2723         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
2724         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
2725         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
2726
2727 2015-06-01  Alex Christensen  <achristensen@webkit.org>
2728
2729         [Content Extensions] resource-type and load-type should be independent.
2730         https://bugs.webkit.org/show_bug.cgi?id=145528
2731         rdar://problem/21190765
2732
2733         Reviewed by Benjamin Poulain.
2734
2735         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2736         (TestWebKitAPI::TEST_F):
2737
2738 2015-06-01  Daniel Bates  <dabates@apple.com>
2739
2740         Add ATS keys to WebKitTestRunnerApp
2741         https://bugs.webkit.org/show_bug.cgi?id=145519
2742
2743         Reviewed by Alexey Proskuryakov.
2744
2745         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
2746
2747         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2748
2749 2015-06-01  Brady Eidson  <beidson@apple.com>
2750
2751         Add WKTR support for "should open external URLs".
2752         https://bugs.webkit.org/show_bug.cgi?id=145505
2753
2754         Reviewed by Darin Adler.
2755
2756         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
2757           "should open external URLs" bit set.
2758         
2759         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
2760           the policy delegate, including whether or not the bit was set.
2761         
2762         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2763         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2764         (WTR::TestRunner::queueLoad):
2765         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2766         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
2767         (WTR::TestRunner::shouldDumpPolicyCallbacks):
2768         
2769         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2770         (WTR::InjectedBundle::queueLoad):
2771         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2772
2773         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2774         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2775
2776         * WebKitTestRunner/TestInvocation.cpp:
2777         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2778
2779         * WebKitTestRunner/WorkQueueManager.cpp:
2780         (WTR::WorkQueueManager::queueLoad):
2781         * WebKitTestRunner/WorkQueueManager.h:
2782
2783 2015-06-01  Mark Lam  <mark.lam@apple.com>
2784
2785         build-jsc's --cloop option is broken.
2786         https://bugs.webkit.org/show_bug.cgi?id=145516
2787
2788         Reviewed by Darin Adler.
2789
2790         * Scripts/build-jsc:
2791         - Make sure to disable the JIT when --cloop is specified.
2792           Did analogous fix for --ftljit.
2793
2794 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2795
2796         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
2797         https://bugs.webkit.org/show_bug.cgi?id=144959
2798
2799         Reviewed by Darin Adler.
2800
2801         * Scripts/webkitpy/style/checkers/cmake.py:
2802         (CMakeChecker.check): Use enumerate instead of xrange.
2803         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
2804         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2805         (CMakeCheckerTest.test_check): Update the expected results.
2806
2807 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2808
2809         Fix the webkitpy scm unittests after r174051
2810         https://bugs.webkit.org/show_bug.cgi?id=145511
2811
2812         Reviewed by Darin Adler.
2813
2814         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2815         (GitTestWithMock.make_scm):
2816
2817 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2818
2819         EWS provides misleading information for not applyable patches
2820         https://bugs.webkit.org/show_bug.cgi?id=145307
2821
2822         Reviewed by Alexey Proskuryakov.
2823
2824         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
2825
2826 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
2827
2828         Further tweak results of WebKit1.StringTruncator after r184965.
2829
2830         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2831
2832 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
2833
2834         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
2835         https://bugs.webkit.org/show_bug.cgi?id=145264
2836
2837         Reviewed by Carlos Garcia Campos.
2838
2839         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
2840
2841 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
2842
2843         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
2844
2845         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2846         (BenchmarkResults._lint_subtest_results):
2847         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
2848         (test_aggregate_nested_results):
2849         (test_lint_results):
2850         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
2851
2852 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
2853
2854         run-benchmark should print out the results
2855         https://bugs.webkit.org/show_bug.cgi?id=145398
2856
2857         Reviewed by Antti Koivisto.
2858
2859         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
2860         of the output to catch early errors.
2861
2862         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
2863         (BenchmarkResults): Added.
2864         (BenchmarkResults.__init__): Added.
2865         (BenchmarkResults.format): Added.
2866         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
2867         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
2868         Uses the sample standard deviation to compute the significant figures for the value.
2869         (BenchmarkResults._unit_from_metric): Added.
2870         (BenchmarkResults._aggregate_results): Added.
2871         (BenchmarkResults._aggregate_results_for_test): Added.
2872         (BenchmarkResults._flatten_list): Added.
2873         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
2874         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
2875         (BenchmarkResults._aggregate_values): Added.
2876         (BenchmarkResults._lint_results): Added.
2877         (BenchmarkResults._lint_subtest_results): Added.
2878         (BenchmarkResults._lint_aggregator_list): Added.
2879         (BenchmarkResults._lint_configuration): Added.
2880         (BenchmarkResults._lint_values): Added.
2881         (BenchmarkResults._is_numeric): Added.
2882         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
2883         (BenchmarkResultsTest):
2884         (BenchmarkResultsTest.test_init):
2885         (BenchmarkResultsTest.test_format):
2886         (test_format_values_with_large_error):
2887         (test_format_values_with_small_error):
2888         (test_format_values_with_time):
2889         (test_format_values_with_no_error):
2890         (test_format_values_with_small_difference):
2891         (test_aggregate_results):
2892         (test_aggregate_results_with_gropus):
2893         (test_aggregate_nested_results):
2894         (test_lint_results):
2895         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2896         (BenchmarkRunner.execute): Added a call to show_results
2897         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
2898         (BenchmarkRunner.show_results): Added.
2899
2900 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2901
2902         run_benchmark should have an option to specify the number of runs
2903         https://bugs.webkit.org/show_bug.cgi?id=145091
2904
2905         Reviewed by Antti Koivisto.
2906
2907         Added --count option.
2908
2909         * Scripts/run-benchmark:
2910         (main):
2911         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2912         (BenchmarkRunner.__init__):
2913
2914 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2915
2916         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
2917
2918         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2919
2920 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
2921
2922         Update results of WebKit1.StringTruncator after r184965.
2923
2924         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
2925
2926 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2927
2928         Unreviewed, updated my list of email addresses.
2929
2930         * Scripts/webkitpy/common/config/contributors.json:
2931
2932 2015-05-27  Dean Jackson  <dino@apple.com>
2933
2934         img.currentSrc problem in strict mode with old picturefill
2935         https://bugs.webkit.org/show_bug.cgi?id=144095
2936         <rdar://problem/21087013>
2937
2938         Reviewed by Simon Fraser.
2939
2940         Add a PICTURE_SIZES flag.
2941
2942         * Scripts/webkitperl/FeatureList.pm:
2943
2944 2015-05-26  Dana Burkart  <dburkart@apple.com>
2945
2946         Fixes compatibility issues with recent dashboard cleanup.
2947         https://bugs.webkit.org/show_bug.cgi?id=144814
2948
2949         Reviewed by Alexey Proskuryakov.
2950
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2952         (BuildbotStaticAnalyzerQueueView):
2953         (BuildbotStaticAnalyzerQueueView.prototype.update):
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2955         (documentReady):
2956
2957 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2958
2959         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
2960         https://bugs.webkit.org/show_bug.cgi?id=143091
2961         rdar://problem/19330328
2962
2963         Reviewed by Darin Adler and Timothy Hatcher.
2964
2965         We have many of these, which are hard to fit on the dashboard. Added a view that
2966         collapses to a single green bubble when everything is good, and expands when there
2967         are failures (or manually).
2968
2969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
2970
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2972         (Buildbot.prototype.set isAuthenticated):
2973         (Buildbot.prototype._normalizeQueueInfo):
2974         (Buildbot.prototype._normalizeQueuesInfo):
2975         (Buildbot.prototype.updateQueues):
2976         Moved queue info normalization here from BuildbitQueue. The latter is a model class
2977         that shouldn't have to know about presentation, and this lets us leep the knowledge
2978         about combined queues out if it. Later, we can refactor existing code, and move out
2979         all knowledge about headings and such.
2980
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2982         Added the new view. It's not quite universal, and doesn't have as helpful popovers
2983         as other views, but we can extend it when/if we use it for more than JSC.
2984
2985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2986         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
2987
2988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2989         (documentReady): Added support for combined queues. These are currently always ending up
2990         in Other column, but it's easy to customize in the future if we need to.
2991
2992         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2993         (WebKitBuildbot): Added JSC queus.
2994
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2996         (.combined-queue-popover):
2997         (.combined-queue-popover .revision):
2998         Added styles for the combined view.
2999
3000 2015-05-26  Dan Bernstein  <mitz@apple.com>
3001
3002         Changed a file to use Unix line endings.
3003
3004         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3005
3006 2015-05-26  Dan Bernstein  <mitz@apple.com>
3007
3008         <rdar://problem/21104551> Update build settings
3009
3010         Reviewed by Anders Carlsson.
3011
3012         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3013         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3014         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3015         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3016         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3017         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3018         * asan/asan.xcconfig:
3019
3020 2015-05-26  Anders Carlsson  <andersca@apple.com>
3021
3022         Fix build.
3023
3024         * WebKitTestRunner/mac/EventSenderProxy.mm:
3025         (WTR::EventSenderProxy::mouseForceDown):
3026         (WTR::EventSenderProxy::mouseForceUp):
3027         (WTR::EventSenderProxy::mouseForceChanged):
3028
3029 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
3030
3031         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
3032         https://bugs.webkit.org/show_bug.cgi?id=145342
3033
3034         Reviewed by Darin Adler.
3035
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3037         (BuildbotIteration.prototype._parseData):
3038
3039 2015-05-26  Milan Crha  <mcrha@redhat.com>
3040
3041         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
3042         https://bugs.webkit.org/show_bug.cgi?id=138134
3043
3044         Reviewed by Žan Doberšek.
3045
3046         * gtk/generate-inspector-gresource-manifest.py:
3047         (get_filenames): Command line with expanded resources exceeds 32KB, which
3048         is a limit on Windows. It's better to expand wildcards inside the python script.
3049
3050 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3051
3052         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
3053         https://bugs.webkit.org/show_bug.cgi?id=140882
3054
3055         Reviewed by Gustavo Noronha Silva.
3056
3057         Make sure unit tests write IndexedDB databases to the temporary
3058         directory, and add a test case to check that the directory is
3059         correctly created at the expected path.
3060
3061         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3062         (testWebContextConfiguration):
3063         (serverCallback):
3064         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3065         (Test::Test):
3066
3067 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3068
3069         [GTK] Enable IndexedDB
3070         https://bugs.webkit.org/show_bug.cgi?id=98932
3071
3072         Reviewed by Žan Doberšek.
3073
3074         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
3075
3076 2015-05-24  Sam Weinig  <sam@webkit.org>
3077
3078         Crash when using a removed ScriptMessageHandler
3079         <rdar://problem/20888499>
3080         https://bugs.webkit.org/show_bug.cgi?id=145359
3081
3082         Reviewed by Dan Bernstein.
3083
3084         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3085         Add tests for removing script message handlers.
3086
3087 2015-05-23  Dan Bernstein  <mitz@apple.com>
3088
3089         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
3090         https://bugs.webkit.org/show_bug.cgi?id=145345
3091
3092         Reviewed by Sam Weinig.
3093
3094         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3095         * LayoutTestRelay/Configurations/Base.xcconfig:
3096         * TestWebKitAPI/Configurations/Base.xcconfig:
3097         * WebKitTestRunner/Configurations/Base.xcconfig:
3098
3099 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3100
3101         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
3102         https://bugs.webkit.org/show_bug.cgi?id=144848
3103
3104         Reviewed by Darin Adler.
3105
3106         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
3107
3108         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3109
3110 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
3111
3112         Fix one more merge error in static analyzer support.
3113
3114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
3115         (BuildbotStaticAnalyzerQueueView):
3116
3117 2015-05-22  Dana Burkart  <dburkart@apple.com>
3118
3119         Fix internal dashboard breakage from recent commit.
3120         https://bugs.webkit.org/show_bug.cgi?id=144814
3121
3122         Unreviewed build fix.
3123
3124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
3125         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
3126         (BuildbotStaticAnalyzerQueueView.prototype.update):
3127
3128 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
3129
3130         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
3131         https://bugs.webkit.org/show_bug.cgi?id=130463
3132         rdar://problem/20461342
3133
3134         Reviewed by Tim Horton.
3135
3136         This was more of a timing related flakiness than an actual OS version specific bug,
3137         we weren't getting window visibility notifications.
3138         
3139         I will look into adding this function call to DumpRenderTree separately, layout tests
3140         might actually rely on the broken behavior.
3141
3142         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3143         (TestWebKitAPI::TEST_F):
3144         * TestWebKitAPI/mac/mainMac.mm:
3145         (main):
3146
3147 2015-05-22  Dana Burkart  <dburkart@apple.com>
3148
3149         Add missing file from r184804 (mis-applied diff).
3150         https://bugs.webkit.org/show_bug.cgi?id=144814
3151
3152         Reviewed by Alexey Proskuryakov.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
3155         (BuildbotStaticAnalyzerQueueView):
3156         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
3157         (BuildbotStaticAnalyzerQueueView.prototype.update):
3158
3159 2015-05-22  Dana Burkart  <dburkart@apple.com>
3160
3161         Add support to the botwatchers dashboard for a static analyzer bot.
3162         https://bugs.webkit.org/show_bug.cgi?id=144814
3163
3164         Reviewed by Alexey Proskuryakov.
3165
3166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3167         scan-build should be considered a productive step.
3168
3169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3170         (BuildbotQueue):
3171         Adds support for the staticAnalyzer property
3172
3173         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3174         (BuildbotTestResults.prototype._parseResults):
3175         Get bug count from the scan-build step output
3176
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3178         (documentReady):
3179         Rename the performance column 'Other', and merge the current 'Other' column with it.
3180
3181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3182         (WebKitBuildbot):
3183         Now that performance bots are part of the 'Other' column, give them better headings.
3184
3185 2015-05-22  Tim Horton  <timothy_horton@apple.com>
3186
3187         Turn on autosaving of toolbar configuration in MiniBrowser
3188
3189         Rubber-stamped by Dan Bernstein.
3190
3191         * MiniBrowser/mac/BrowserWindow.xib:
3192
3193 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
3194
3195         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
3196         https://bugs.webkit.org/show_bug.cgi?id=145297
3197
3198         Reviewed by Tim Horton.
3199
3200         This is a refactoring to simplify code, and to make it more logical.
3201
3202         It is up to the view to decide how to present the queues, and whether to split
3203         them into debug and release, or in some different way.
3204
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3206         (BuildbotBuilderQueueView.filterQueues):
3207         (BuildbotBuilderQueueView):
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3209         (BuildbotLeaksQueueView):
3210         (BuildbotLeaksQueueView.prototype.update):
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3212         (BuildbotPerformanceQueueView):
3213         (BuildbotPerformanceQueueView.prototype.update):
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3215         (BuildbotQueueView):
3216         (BuildbotQueueView.prototype._updateQueues):
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3218         (BuildbotTesterQueueView):
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3220         (documentReady):
3221
3222 2015-05-22  Tim Horton  <timothy_horton@apple.com>
3223
3224         Remove action menu support
3225         https://bugs.webkit.org/show_bug.cgi?id=145305
3226         <rdar://problem/21070771>
3227
3228         Reviewed by Anders Carlsson.
3229
3230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3231         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
3232         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
3233         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
3234         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
3235         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
3236         Remove the tests.
3237
3238 2015-05-22  Dan Bernstein  <mitz@apple.com>
3239
3240         Removed the Use Shrink To Fit button from the toolbar’s default set.
3241
3242         Rubber-stamped by Tim Horton.
3243
3244         * MiniBrowser/mac/BrowserWindow.xib:
3245
3246 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
3247
3248         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
3249         https://bugs.webkit.org/show_bug.cgi?id=128420
3250
3251         Reviewed by Chris Fleizach.
3252
3253         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3254         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
3255
3256 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
3257
3258         [EFL] Bump libsoup version to 2.50.0
3259         https://bugs.webkit.org/show_bug.cgi?id=145127
3260
3261         Reviewed by Gyuyoung Kim.
3262
3263         * efl/jhbuild.modules:
3264         * efl/patches/soup-clang-warning-fix1.patch: Removed.
3265         * efl/patches/soup-clang-warning-fix2.patch: Removed.
3266
3267 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
3268
3269         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
3270         https://bugs.webkit.org/show_bug.cgi?id=145117
3271
3272         Reviewed by Csaba Osztrogonác.
3273
3274         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
3275         Tools/TestWebKitAPI/Tests/WTF/glib/.
3276
3277         * TestWebKitAPI/PlatformGTK.cmake:
3278         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
3279         (TestWebKitAPI::TEST):
3280
3281 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
3282
3283         [EFL] fix efreet error
3284         https://bugs.webkit.org/show_bug.cgi?id=143670
3285
3286         Reviewed by Gyuyoung Kim.
3287
3288         Fix efreet error by using external variable efreet_cache_update.
3289         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
3290         efreet error for efreet_cache does not occur.
3291
3292         * MiniBrowser/efl/main.c:
3293         (elm_main):
3294
3295 2015-05-20  Michael Saboff  <msaboff@apple.com>
3296
3297         Add option to run_jsc_stress_tests to disable JIT testing
3298         https://bugs.webkit.org/show_bug.cgi?id=145233
3299
3300         Reviewed by Mark Lam.
3301
3302         Added --no-jit option.
3303
3304         * Scripts/run-jsc-stress-tests:
3305
3306 2015-05-20  Alex Christensen  <achristensen@webkit.org>
3307
3308         Use correct String for StringView in WTF API tests
3309         https://bugs.webkit.org/show_bug.cgi?id=145226
3310         rdar://problem/20361786
3311
3312         Reviewed by Benjamin Poulain.
3313
3314         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3315         (TestWebKitAPI::TEST):
3316         Use patternHolder for pattern.
3317
3318 2015-05-20  Alex Christensen  <achristensen@webkit.org>
3319
3320         [Content Extensions] Relax restrictions on triggers that match everything.
3321         https://bugs.webkit.org/show_bug.cgi?id=145069
3322
3323         Reviewed by Benjamin Poulain.
3324
3325         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3326         (TestWebKitAPI::TEST_F):
3327         Update and add tests for new possibilities with .*
3328
3329 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
3330
3331         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
3332         https://bugs.webkit.org/show_bug.cgi?id=144992
3333
3334         Reviewed by Gyuyoung Kim.
3335
3336         * MiniBrowser/efl/main.c:
3337         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
3338         (on_key_down):
3339         (on_fullscreen_enter):
3340         (on_fullscreen_exit):
3341         (window_create):
3342
3343 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3344
3345         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
3346         https://bugs.webkit.org/show_bug.cgi?id=145109
3347
3348         Reviewed by Darin Adler.
3349
3350         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3351         (TestWebKitAPI::TEST):
3352
3353 2015-05-19  Anders Carlsson  <andersca@apple.com>
3354
3355         Add alternate menu items for performing operations on the default data store
3356         https://bugs.webkit.org/show_bug.cgi?id=145184
3357
3358         Reviewed by Sam Weinig.
3359
3360         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
3361         associated with a data store.
3362
3363         * MiniBrowser/mac/AppDelegate.m:
3364         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
3365         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
3366         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
3367         * MiniBrowser/mac/MainMenu.xib:
3368
3369 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
3370
3371         Fix tautological-compare warning in AtomicString.cpp
3372         https://bugs.webkit.org/show_bug.cgi?id=145120
3373
3374         Reviewed by Alexey Proskuryakov.
3375
3376         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3377         (TestWebKitAPI::TEST): Removed always true assert.
3378
3379 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
3380
3381         [EFL] Fix unsequenced warning in MiniBrowser's main.c
3382         https://bugs.webkit.org/show_bug.cgi?id=145123
3383
3384         Reviewed by Gyuyoung Kim.
3385
3386         * MiniBrowser/efl/main.c:
3387         (on_key_down):
3388
3389 2015-05-18  Daniel Bates  <dabates@apple.com>
3390
3391         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
3392         when staged non-empty file for commit
3393         https://bugs.webkit.org/show_bug.cgi?id=145082
3394
3395         Reviewed by Darin Adler.
3396
3397         Fixes two issues when running prepare-ChangeLog:
3398             1. The function above a deleted function is reported as changed.
3399             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
3400             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
3401             included in this patch).
3402
3403         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
3404         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
3405         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
3406         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
3407         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
3408         VCSUtil::parseChunkRange() has existing test coverage.
3409
3410         * Scripts/prepare-ChangeLog:
3411         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
3412         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
3413         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
3414         examine files that only have deletions. Currently this works as a side effect of the behavior of
3415         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
3416         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
3417         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
3418         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
3419         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
3420         We return (-1, -1) when the change represents a deletion.
3421         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
3422         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
3423         We return (-1, -1) when the change represents an addition.
3424         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
3425         unit tests.
3426
3427 2015-05-18  Anders Carlsson  <andersca@apple.com>
3428
3429         Add ATS keys to MiniBrowser
3430         https://bugs.webkit.org/show_bug.cgi?id=145141
3431
3432         Reviewed by Sam Weinig.
3433
3434         * MiniBrowser/mac/Info.plist:
3435
3436 2015-05-17  David Kilzer  <ddkilzer@apple.com>
3437
3438         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
3439         <http://webkit.org/b/145100>
3440
3441         Reviewed by Darin Adler.
3442
3443         * Scripts/bisect-builds:
3444         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
3445         - Switch to using PROMPT_RESPONSE_* constants when testing the
3446           value of $didReproduceBug.
3447         - Add do { } while loops to implement 'retry' mode.
3448         (promptForTest):
3449         - Switch to returning PROMPT_RESPONSE_* constants.
3450         - Add support for 'retry' response.
3451
3452 2015-05-16  Tanay C  <tanay.c@samsung.com>
3453
3454         [EFL][WK2] Minibrowser : Add search icon to search bar
3455         https://bugs.webkit.org/show_bug.cgi?id=139773
3456
3457         Reviewed by Gyuyoung Kim.
3458
3459         * MiniBrowser/efl/main.c: 
3460         (search_icon_show): Added.
3461         (search_box_show): Modified.
3462
3463 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
3464
3465         run_benchmark should have an option to specify the number of runs
3466         https://bugs.webkit.org/show_bug.cgi?id=145091
3467
3468         Reviewed by Stephanie Lewis.
3469
3470         Added --count option.
3471
3472         * Scripts/run-benchmark:
3473         (main):
3474         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3475         (BenchmarkRunner.__init__):
3476
3477 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
3478
3479         Temporarily disable failing API test.
3480
3481         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3482         (TestWebKitAPI::TEST):
3483
3484 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
3485
3486         User interruption while running of run-webkit-tests should also generate results.html
3487         https://bugs.webkit.org/show_bug.cgi?id=122154
3488
3489         Reviewed by Csaba Osztrogonác.
3490
3491         Generation of results.html on execution of run-webkit-tests happens only
3492         on completion of entire layout tests run. It should be created even when
3493         the execution has been interrupted - either by user (by pressing Ctrl+C)
3494         or because of other interruptions (like exit-after-n-failures option).
3495
3496         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3497         (LayoutTestRunner.run_tests):
3498         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3499         (Manager.run):
3500         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3501         (TestRunResults.__init__):
3502         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3503         (main):
3504         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3505         (RunTest.test_keyboard_interrupt):
3506         (MainTest.test_exception_handling):
3507
3508 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
3509
3510         [buildbot] Fix the URL of the performance bots
3511         https://bugs.webkit.org/show_bug.cgi?id=145043
3512
3513         Reviewed by Ryosuke Niwa.
3514
3515         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3516
3517 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
3518
3519         Add a layout mode that scales down the view to try to fit the document
3520         https://bugs.webkit.org/show_bug.cgi?id=145022
3521         <rdar://problem/19790341>
3522
3523         Reviewed by Dean Jackson.
3524
3525         * MiniBrowser/mac/BrowserWindow.xib:
3526         * MiniBrowser/mac/BrowserWindowController.h:
3527         * MiniBrowser/mac/WK2BrowserWindowController.m:
3528         (-[WK2BrowserWindowController toggleShrinkToFit:]):
3529         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
3530         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
3531
3532 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3533
3534         [CMake] Don't read the LOCATION property of targets
3535         https://bugs.webkit.org/show_bug.cgi?id=145018
3536
3537         Reviewed by Martin Robinson.
3538
3539         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
3540         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
3541         be the same at configure-time as it is at generate-time.
3542
3543         * TestWebKitAPI/CMakeLists.txt:
3544
3545 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
3546
3547         Add String literal overloads to equalIgnoringASCIICase()
3548         https://bugs.webkit.org/show_bug.cgi?id=145008
3549
3550         Reviewed by Benjamin Poulain.
3551
3552         Test changes to WTF.
3553
3554         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3555         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
3556         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
3557         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3558         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
3559         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
3560
3561 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3562
3563         SharedBuffer::createWithContentsOfFile should use map file routines
3564         https://bugs.webkit.org/show_bug.cgi?id=144192
3565
3566         Reviewed by Darin Adler.
3567
3568         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
3569
3570         * TestWebKitAPI/PlatformGTK.cmake:
3571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3572         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
3573         (TestWebKitAPI::FileSystemTest::tempFilePath):
3574         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
3575         (TestWebKitAPI::TEST_F):
3576         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
3577         (TestWebKitAPI::SharedBufferTest::tempFilePath):
3578         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
3579         (TestWebKitAPI::TEST_F):
3580
3581 2015-05-13  Alex Christensen  <achristensen@webkit.org>
3582
3583         [Content Extensions] Test interactions between multiple extensions and multiple domains.
3584         https://bugs.webkit.org/show_bug.cgi?id=144967
3585
3586         Reviewed by Benjamin Poulain.
3587
3588         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3589         Xcode wanted to fix an alphabetization issue.
3590         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3591         (TestWebKitAPI::TEST_F):
3592         Test interactions that worked but were not explicitly tested before.
3593
3594 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
3595
3596         Unreviewed build fix.
3597
3598         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
3599
3600         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
3601
3602 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
3603
3604         Fix the previous commit, which made both bubbles green.
3605
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3607         (.status-line.good .bubble):
3608         (.status-line.bad .bubble):
3609         (.status-line.good .message):
3610
3611 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
3612
3613         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
3614         https://bugs.webkit.org/show_bug.cgi?id=144929
3615
3616         Reviewed by Eric Carlson.
3617
3618         Tweaked colors as I see fit.
3619
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3621         (.status-line.good .bubble):
3622         (.status-line.bad .bubble):
3623
3624 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
3625
3626         [Mac] Share cookie storage between UI process and secondary processes
3627         https://bugs.webkit.org/show_bug.cgi?id=144820
3628         rdar://problem/20572830
3629
3630         Reviewed by Darin Adler.
3631
3632         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3633         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
3634         for testing.
3635
3636 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
3637
3638         Fix internal build configuration issues
3639         https://bugs.webkit.org/show_bug.cgi?id=144762
3640
3641         Reviewed by David Kilzer.
3642
3643         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
3644
3645         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3646         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3647         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3648         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3649         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
3650         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
3651         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
3652         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
3653
3654 2015-05-12  David Kilzer  <ddkilzer@apple.com>
3655
3656         Switch to launching iOS Simulator using bundle ID
3657         <rdar://problem/20916096>
3658
3659         This is required to fix the layout tests on internal bots.
3660
3661         * Scripts/webkitdirs.pm:
3662         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
3663         Simulator.  Add FIXME.
3664         (quitIOSSimulator): Add FIXME.
3665         * Scripts/webkitpy/port/ios.py:
3666         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
3667         launch iOS Simulator.  Add FIXME.
3668         (IOSSimulatorPort.check_sys_deps): Add FIXME.
3669
3670 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
3671
3672         Fix run-javascriptcore-tests step on the WinCairo bot
3673         https://bugs.webkit.org/show_bug.cgi?id=144866
3674
3675         Reviewed by Csaba Osztrogonác.
3676
3677         Catch exception when failing to create soft link, so we can fall back to copy.
3678
3679         * Scripts/run-jsc-stress-tests:
3680
3681 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
3682
3683         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
3684         https://bugs.webkit.org/show_bug.cgi?id=116971
3685
3686         Reviewed by Chris Fleizach.
3687
3688         Implement rowAtIndex for ATK.
3689
3690         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3691         (WTR::AccessibilityUIElement::rowAtIndex):
3692
3693 2015-05-11  Dan Bernstein  <mitz@apple.com>
3694
3695         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
3696
3697         Reviewed by Alexey Proskuryakov.
3698
3699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3700         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
3701         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
3702         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
3703
3704 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
3705
3706         Fix internal build configuration issues
3707         https://bugs.webkit.org/show_bug.cgi?id=144762
3708
3709         Reviewed by Darin Adler.
3710
3711         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
3712
3713         * TestWebKitAPI/Configurations/Base.xcconfig:
3714         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3715         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3716         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3717         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3718         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3719         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3720
3721 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
3722
3723         [Win] Move Windows build target to Windows 7 (or newer)
3724         https://bugs.webkit.org/show_bug.cgi?id=144890
3725         <rdar://problem/20707307>
3726
3727         Reviewed by Anders Carlsson.
3728
3729         Update linked SDK and minimal Windows level to be compatible with
3730         Windows 7 or newer.
3731
3732         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3733         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3734         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3735         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3736         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3737         * DumpRenderTree/config.h:
3738         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3739         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3740         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3741         * WinLauncher/stdafx.h:
3742
3743 2015-05-11  Commit Queue  <commit-queue@webkit.org>
3744
3745         Unreviewed, rolling out r184119.
3746         https://bugs.webkit.org/show_bug.cgi?id=144888
3747
3748         broke JSC tests on Apple Windows bots (Requested by kling on
3749         #webkit).
3750
3751         Reverted changeset:
3752
3753         "Fix run-javascriptcore-tests step on the WinCairo bot"
3754         https://bugs.webkit.org/show_bug.cgi?id=144866
3755         http://trac.webkit.org/changeset/184119
3756
3757 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3758
3759         run-benchmark should support Dromaeo
3760         https://bugs.webkit.org/show_bug.cgi?id=144849
3761
3762         Reviewed by Chris Dumez.
3763
3764         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
3765         they can take as much as 15 minutes to run each.
3766
3767         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
3768         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
3769         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
3770         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
3771
3772 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3773
3774         Build fix. jetstream has a local copy, not remote archive.
3775
3776         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3777
3778 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3779
3780         run-benchmark should support SunSpider, Kraken and Octane
3781         https://bugs.webkit.org/show_bug.cgi?id=144840
3782
3783         Reviewed by Darin Adler.
3784
3785         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
3786         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
3787         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
3788         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
3789
3790         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
3791         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
3792
3793         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
3794         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
3795
3796         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
3797         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
3798         now has the ability to run an arbitrary "create script".
3799
3800         * Scripts/run-benchmark:
3801         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
3802         This also overrides the remote archive URL specified in the plan.
3803
3804         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
3805
3806         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
3807         JetStreamBenchmarkBuilder.
3808
3809         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
3810         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
3811         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
3812         _runCreateScript and _applyPatch to clean after themselves.
3813         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
3814         JetStream, SunSpider, Kraken all use this feature.
3815         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
3816         the leaf directory name since the latter is not available when a remote ZIP file is used.
3817         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
3818         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
3819         the benchmark name in the patches.
3820
3821         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
3822
3823         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3824         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
3825         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
3826         the browser opens by planName as the plan file no longer contains that.
3827
3828         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
3829         the top directory of JetStream instead of its parent.
3830         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
3831         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
3832         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
3833         the top directory of JetStream instead of its parent.
3834         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
3835         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
3836         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
3837         done in JetStream.patch.
3838         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
3839         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
3840         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
3841         path from the top directory of JetStream as done in JetStream.patch.
3842         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
3843
3844 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
3845
3846         Fix run-javascriptcore-tests step on the WinCairo bot
3847         https://bugs.webkit.org/show_bug.cgi?id=144866
3848
3849         Reviewed by Darin Adler.
3850
3851         * Scripts/run-jsc-stress-tests:
3852
3853 2015-05-11  Alex Christensen  <achristensen@webkit.org>
3854
3855         [Content Extensions] Support domain-specific rules and exceptions.
3856         https://bugs.webkit.org/show_bug.cgi?id=144833
3857
3858         Reviewed by Darin Adler.
3859
3860         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3861         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3862         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3863         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3864         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
3865         (TestWebKitAPI::mainDocumentRequest):
3866         (TestWebKitAPI::subResourceRequest):
3867         (TestWebKitAPI::TEST_F):
3868         (TestWebKitAPI::checkCompilerError):
3869         Added tests for parsing and functionality of if-domain and unless-domain.
3870
3871 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
3872
3873         run-benchmark should support Chrome Canary and Firefox Nightly
3874         https://bugs.webkit.org/show_bug.cgi?id=144850
3875
3876         Reviewed by Darin Adler.
3877
3878         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
3879
3880         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
3881
3882         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
3883         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
3884         (OSXBrowserDriver):
3885         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
3886         (OSXBrowserDriver.closeBrowsers): Ditto.
3887         (OSXBrowserDriver.launchProcess): Ditto.
3888         (OSXBrowserDriver.terminateProcesses): Ditto.
3889         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3890         (OSXChromeDriver): Removed the unused self.chromePreferences.
3891         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
3892         (OSXChromeDriver.closeBrowsers): Ditto.
3893         (OSXChromeDriver.launchUrl):
3894         (OSXChromeCanaryDriver): Added.
3895         (OSXChromeCanaryDriver.launchUrl):
3896         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
3897         (OSXFirefoxDriver): Added.
3898         (OSXFirefoxDriver.launchUrl):
3899         (OSXFirefoxNightlyDriver): Added.
3900         (OSXFirefoxNightlyDriver.launchUrl):
3901         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3902         (OSXSafariDriver):
3903         (OSXSafariDriver.closeBrowsers):
3904
3905 2015-05-11  Tim Horton  <timothy_horton@apple.com>
3906
3907         Page overlay action context override should indicate the source of the request
3908         https://bugs.webkit.org/show_bug.cgi?id=144832
3909         <rdar://problem/20562594>
3910
3911         Reviewed by Darin Adler.
3912
3913         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
3914         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
3915
3916 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
3917
3918         [GTK] fast/events/page-visibility-transition-test.html is timing out
3919         https://bugs.webkit.org/show_bug.cgi?id=114789
3920
3921         Reviewed by Darin Adler.
3922
3923         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3924         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
3925         requests visibility changes.
3926
3927 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3928
3929         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
3930         https://bugs.webkit.org/show_bug.cgi?id=144798
3931
3932         Reviewed by Darin Adler.
3933
3934         * efl/install-dependencies:
3935
3936 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
3937
3938         Make arguments of run-benchmark more user friendly
3939         https://bugs.webkit.org/show_bug.cgi?id=144835
3940
3941         Reviewed by Darin Adler.
3942
3943         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
3944         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
3945         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
3946         default values from --platform and --browser as they are required arguments.
3947
3948         * Scripts/run-benchmark:
3949         (main): Made --build-directory optional, and removed default values from --platform and --browser.
3950         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
3951         are not dynamically obtained via BrowserDriverFactory.
3952         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3953         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
3954         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
3955         run any benchmark in that case.
3956         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
3957         the specified file isn't a valid relative or an absolute path.
3958         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3959         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
3960         and browsers.
3961         (BrowserDriverFactory.available_browsers): Ditto.
3962         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3963         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
3964         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
3965         browserBuildPath was None.
3966         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3967         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
3968         so that we can use locally built WebKit to launch Safari.
3969
3970 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
3971
3972         Remove the PICTURE_SIZES build flag
3973         https://bugs.webkit.org/show_bug.cgi?id=144679
3974
3975         Reviewed by Benjamin Poulain.
3976
3977         Removed the PICTURE_SIZES build time flag.
3978
3979         * Scripts/webkitperl/FeatureList.pm:
3980
3981 2015-05-09  David Kilzer  <ddkilzer@apple.com>
3982
3983         Layout tests broke due to unexpected simctl output
3984
3985         * Scripts/webkitpy/xcode/simulator.py:
3986         (Simulator._parse_devices): Handle new Device Pairs header.
3987         * Scripts/webkitpy/xcode/simulator_unittest.py:
3988         (test_device_pairs): Add unit test for Device Pairs header.
3989
3990 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3991
3992         Remove convenience constructors for TextRun
3993         https://bugs.webkit.org/show_bug.cgi?id=144752
3994
3995         Reviewed by Anders Carlsson.
3996
3997         Test the StringView which takes a StringImpl*.
3998
3999         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4000         (StringView8Bit): Testing is8Bit() on StringView
4001
4002 2015-05-07  Sam Weinig  <sam@webkit.org>
4003
4004         [Content Extensions] Add simple tester that takes an extension and compiles it
4005         https://bugs.webkit.org/show_bug.cgi?id=144781
4006
4007         Reviewed by Dan Bates.
4008
4009         * ContentExtensionTester: Added.
4010         * ContentExtensionTester/Configurations: Added.
4011         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
4012         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
4013         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
4014         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
4015         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
4016         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
4017         * ContentExtensionTester/main.m: Added.
4018         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
4019
4020 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
4021
4022         Build fix.
4023
4024         Reviewed by Dan Bernstein.
4025
4026         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
4027         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
4028         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
4029         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
4030         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
4031         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
4032         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
4033         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
4034
4035 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
4036
4037         [GTK] Some tests fail because they do not assume the popup menu captures click events
4038         https://bugs.webkit.org/show_bug.cgi?id=40601
4039
4040         Reviewed by Carlos Garcia Campos.
4041
4042         Popdown all attached menus when moving between tests and between each new
4043         event sent to the WebView. This prevents context and popup menus from eating
4044         events.
4045
4046         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
4047         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
4048         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4049         (WTR::dispatchEvent): Popdown all menus between dispatching events.
4050         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
4051         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
4052         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4053         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
4054         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4055         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
4056         longer in the platform-independent file.
4057         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
4058
4059 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
4060
4061         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
4062         https://bugs.webkit.org/show_bug.cgi?id=144746
4063
4064         Reviewed by Carlos Garcia Campos.
4065
4066         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
4067
4068         * MiniBrowser/gtk/main.c:
4069         (main):
4070
4071 2015-05-08  Commit Queue  <commit-queue@webkit.org>
4072
4073         Unreviewed, rolling out r183996.
4074         https://bugs.webkit.org/show_bug.cgi?id=144806
4075
4076         ASan detected use-after free (Requested by ap on #webkit).
4077
4078         Reverted changeset:
4079
4080         "Remove convenience constructors for TextRun"
4081         https://bugs.webkit.org/show_bug.cgi?id=144752
4082         http://trac.webkit.org/changeset/183996
4083
4084 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
4085
4086         Remove convenience constructors for TextRun
4087         https://bugs.webkit.org/show_bug.cgi?id=144752
4088
4089         Reviewed by Anders Carlsson.
4090
4091         Test the StringView which takes a StringImpl*.
4092
4093         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4094         (StringView8Bit): Testing is8Bit() on StringView
4095
4096 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
4097
4098         [GTK] WTR doesn't correctly handle the Escape key
4099         https://bugs.webkit.org/show_bug.cgi?id=144788
4100
4101         Reviewed by Martin Robinson.
4102
4103         Correctly handle 0x001B character code in GTK+ event sender to be
4104         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
4105         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
4106         to dismiss popup menus.
4107
4108         Fixes editing/selection/5354455-1.html.
4109
4110         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4111         (WTR::getGDKKeySymForKeyRef):
4112
4113 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
4114
4115         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
4116         https://bugs.webkit.org/show_bug.cgi?id=144748
4117
4118         Reviewed by Sergio Villar Senin.
4119
4120         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
4121         (testWebKitSettings): Check the new setting is correctly
4122         initialized and updated.
4123         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
4124         (testWebContextSecurityFileXHR): Check XHR to local files is
4125         allowed from file URLs after changing the setting.
4126         (beforeAll): Add new test.
4127
4128 2015-05-08  Commit Queue  <commit-queue@webkit.org>
4129
4130         Unreviewed, rolling out r183945.
4131         https://bugs.webkit.org/show_bug.cgi?id=144789
4132
4133         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
4134
4135         Reverted changeset:
4136
4137         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
4138         https://bugs.webkit.org/show_bug.cgi?id=144746
4139         http://trac.webkit.org/changeset/183945
4140
4141 2015-05-07  Anders Carlsson  <andersca@apple.com>
4142
4143         Build fixes.
4144
4145         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
4146         (TestWebKitAPI::TEST):
4147         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
4148         (TestWebKitAPI::TEST):
4149         Add casts.
4150
4151 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
4152
4153         GC has trouble with pathologically large array allocations
4154         https://bugs.webkit.org/show_bug.cgi?id=144609
4155
4156         Reviewed by Geoffrey Garen.
4157         
4158         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
4159         and it's a frequently requested feature.
4160         
4161         Also add the ability to run a test pretending that your system has a particular RAM size.
4162         This is useful for GC tests, and the new GC test that I added uses this.
4163
4164         * Scripts/run-javascriptcore-tests:
4165         (runJSCStressTests):
4166         * Scripts/run-jsc-stress-tests:
4167
4168 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
4169
4170         [EFL] Bump EFL version to 1.14.0
4171         https://bugs.webkit.org/show_bug.cgi?id=144743
4172
4173         Reviewed by Darin Adler.
4174
4175         Bump EFL and elementary version to 1.14.0 and removed
4176         md5sum, because it isn't used at all if hash is present.
4177
4178         * efl/jhbuild.modules:
4179
4180 2015-05-07  Saam Barati  <saambarati1@gmail.com>
4181
4182         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
4183         https://bugs.webkit.org/show_bug.cgi?id=144753
4184
4185         Reviewed by Mark Lam.
4186
4187         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
4188
4189 2015-05-07  Beth Dakin  <bdakin@apple.com>
4190
4191         New force-related DOM events should fire in WK1 views
4192         https://bugs.webkit.org/show_bug.cgi?id=144663
4193         -and corresponding-
4194         rdar://problem/20281886
4195
4196         Reviewed by Sam Weinig.
4197
4198         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
4199         now. Just send nil. 
4200         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
4201         (TestWebKitAPI::buildAndPerformTest):
4202
4203 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
4204
4205         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
4206         https://bugs.webkit.org/show_bug.cgi?id=144746
4207
4208         Reviewed by Martin Robinson.
4209
4210         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
4211
4212         * MiniBrowser/gtk/main.c:
4213         (main):
4214
4215 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
4216
4217         Revert "Introducing the Platform Abstraction Layer (PAL)"
4218         https://bugs.webkit.org/show_bug.cgi?id=144751
4219
4220         Unreviewed.
4221
4222         PAL should be a new target inside WebCore, rather than a top-level folder.
4223
4224         * Scripts/build-webkit: Add it to build-webkit.
4225
4226 2015-05-07  Ada Chan  <adachan@apple.com>
4227
4228         Add a test for WKPageCopySessionState() with filtering.
4229         https://bugs.webkit.org/show_bug.cgi?id=144666
4230
4231         Reviewed by Darin Adler.
4232
4233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4234         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
4235         (TestWebKitAPI::didFinishLoadForFrame):
4236         (TestWebKitAPI::setPageLoaderClient):
4237         (TestWebKitAPI::filterFirstItemCallback):
4238         (TestWebKitAPI::filterAllItemsCallback):
4239         (TestWebKitAPI::createSessionStates):
4240         (TestWebKitAPI::TEST):
4241
4242 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
4243
4244         iOS build fix attempt
4245
4246         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
4247
4248         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4249
4250 2015-05-06  Matt Baker  <mattbaker@apple.com>
4251
4252         Unreviewed, updated my list of email addresses.
4253
4254         * Scripts/webkitpy/common/config/contributors.json:
4255
4256 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
4257
4258         Do not link tools to WebKit2.framework
4259         https://bugs.webkit.org/show_bug.cgi?id=144699
4260
4261         Unreviewed build fix.
4262
4263         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4264         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
4265         These linked to WebKit2 in two ways, eliminating the other one.
4266
4267 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
4268
4269         Introducing the Platform Abstraction Layer (PAL)
4270         https://bugs.webkit.org/show_bug.cgi?id=143358
4271
4272         Reviewed by Simon Fraser.
4273
4274         * Scripts/build-webkit: Add it to build-webkit.
4275
4276 2015-05-06  Alex Christensen  <achristensen@webkit.org>
4277
4278         Fix api tests after r183877.
4279
4280         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4281         (TestWebKitAPI::TEST_F):
4282         Generate all DFAs before compiling them.
4283
4284 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
4285
4286         Do not link tools to WebKit2.framework
4287         https://bugs.webkit.org/show_bug.cgi?id=144699
4288
4289         Reviewed by Tim Horton.
4290
4291         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4293         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4294
4295 2015-05-06  Alex Christensen  <achristensen@webkit.org>
4296
4297         [Content Extensions] Test splitting NFAs by max NFA size.
4298         https://bugs.webkit.org/show_bug.cgi?id=144659
4299
4300         Reviewed by Darin Adler.
4301
4302         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: