[ews-build] Improve summary for PrintConfiguration step
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Improve summary for PrintConfiguration step
4         https://bugs.webkit.org/show_bug.cgi?id=195945
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (PrintConfiguration.getResultSummary): Override getResultSummary.
10
11 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-build] Improve summary for CheckOutSource step
14         https://bugs.webkit.org/show_bug.cgi?id=195963
15
16         Reviewed by Lucas Forschler.
17
18         * BuildSlaveSupport/ews-build/steps.py:
19         (CheckOutSource.getResultSummary):
20
21 2019-03-19  Daniel Bates  <dabates@apple.com>
22
23         [iOS] Focus not preserved when switching between tabs
24         https://bugs.webkit.org/show_bug.cgi?id=195820
25         <rdar://problem/43614450>
26
27         Reviewed by Brent Fulgham.
28
29         Add tests to ensure that we restore focus when resigning and becoming first responder.
30
31         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
32         (TestWebKitAPI::TEST):
33
34 2019-03-19  Alex Christensen  <achristensen@webkit.org>
35
36         Make WTFLogChannelState and WTFLogLevel enum classes
37         https://bugs.webkit.org/show_bug.cgi?id=195904
38
39         Reviewed by Eric Carlson.
40
41         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
42         (TestWebKitAPI::TEST_F):
43
44 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
45
46         [GStreamer][EME] Backported mssdemux protection data crash fix
47         https://bugs.webkit.org/show_bug.cgi?id=195918
48
49         Reviewed by Philippe Normand.
50
51         * gstreamer/jhbuild.modules:
52         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
53
54 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
55
56         Unreviewed, rolling out r243132.
57
58         Broke GTK build
59
60         Reverted changeset:
61
62         "Make WTFLogChannelState and WTFLogLevel enum classes"
63         https://bugs.webkit.org/show_bug.cgi?id=195904
64         https://trac.webkit.org/changeset/243132
65
66 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
67
68         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
69
70         * Scripts/webkitdirs.pm:
71         (builtDylibPathForName): Adjust the shared library name that's changed
72         with the API version bump in r243073.
73
74 2019-03-18  Alex Christensen  <achristensen@webkit.org>
75
76         Make WTFLogChannelState and WTFLogLevel enum classes
77         https://bugs.webkit.org/show_bug.cgi?id=195904
78
79         Reviewed by Eric Carlson.
80
81         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
82         (TestWebKitAPI::TEST_F):
83
84 2019-03-18  Alex Christensen  <achristensen@webkit.org>
85
86         Disable flaky test added in r2431100
87         https://webkit.org/b/195785
88
89         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
90         (TestWebKitAPI::TEST):
91         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
92
93 2019-03-18  Timothy Hatcher  <timothy@apple.com>
94
95         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
96         https://bugs.webkit.org/show_bug.cgi?id=195916
97
98         Reviewed by Tim Horton.
99
100         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
101         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
102
103 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
104
105         Add a secondary e-mail address for Fujii Hironori to make tools happier.
106
107         * Scripts/webkitpy/common/config/contributors.json:
108
109 2019-03-18  Alex Christensen  <achristensen@webkit.org>
110
111         Implement DownloadMonitor to prevent long-running slow downloads from background apps
112         https://bugs.webkit.org/show_bug.cgi?id=195785
113
114         Reviewed by Geoffrey Garen.
115
116         * TestWebKitAPI/TCPServer.cpp: Added.
117         (TestWebKitAPI::TCPServer::TCPServer):
118         (TestWebKitAPI::TCPServer::~TCPServer):
119         (TestWebKitAPI::TCPServer::socketBindListen):
120         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
121         * TestWebKitAPI/TCPServer.h: Added.
122         (TestWebKitAPI::TCPServer::port const):
123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
124         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
125         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
126         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
127         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
128         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
129         (TestWebKitAPI::respondSlowly):
130         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
131         (TestWebKitAPI::downloadAtRate):
132         (TestWebKitAPI::TEST):
133
134 2019-03-18  Saam Barati  <sbarati@apple.com>
135
136         Add a plan file for JetStream 2
137         https://bugs.webkit.org/show_bug.cgi?id=190734
138
139         Reviewed by Mark Lam.
140
141         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
142
143 2019-03-18  Chris Dumez  <cdumez@apple.com>
144
145         Delay WebProcess launch until a load is triggered in a Web view
146         https://bugs.webkit.org/show_bug.cgi?id=195758
147         <rdar://problem/48126013>
148
149         Reviewed by Geoff Garen.
150
151         Add API test coverage. Also update some existing API tests to not expect
152         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
153
154         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
155         (TestWebKitAPI::TEST):
156         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
157         (TestWebKitAPI::TEST):
158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
159         (TEST):
160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
161         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
162         (TEST):
163         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
164         (TEST):
165         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
166
167 2019-03-18  Xan Lopez  <xan@igalia.com>
168
169         [CMake] Prevent potential warning when determining $architecture
170         https://bugs.webkit.org/show_bug.cgi?id=195891
171
172         Reviewed by Michael Catanzaro.
173
174         It's possible for generateBuildSystemForCMakeProject to be called
175         before determineArchitecture() is ever called. This will make the
176         first eq check with $architecture to be bogus (and print a
177         warning). Change that to an eq check with architecture(), which
178         implicitly calls determineArchitecture() if needed, and change all
179         the other similar cases in the method in the same way to prevent
180         future bugs like this one.
181
182         * Scripts/webkitdirs.pm:
183         (generateBuildSystemFromCMakeProject):
184
185 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
186
187         [WPE] Tarballs generated with “make dist” cannot build documentation
188         https://bugs.webkit.org/show_bug.cgi?id=195885
189
190         Reviewed by Carlos Garcia Campos.
191
192         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
193
194 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
195
196         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
197         https://bugs.webkit.org/show_bug.cgi?id=195883
198
199         Reviewed by Carlos Garcia Campos.
200
201         * gtkdoc/gtkdoc.py:
202         (GTKDoc._run_command): When commands fail to run, include the full command line for
203         the program invocation and the output it has generated on the standard error stream.
204
205 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
206
207         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
208         https://bugs.webkit.org/show_bug.cgi?id=195786
209
210         Reviewed by Philippe Normand.
211
212         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
213         * wpe/jhbuild.modules: Ditto.
214
215 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
216
217         [ews-build] Don't run clean builds on EWS builders
218         https://bugs.webkit.org/show_bug.cgi?id=195851
219
220         Reviewed by Geoffrey Garen.
221
222         * BuildSlaveSupport/ews-build/factories.py:
223
224 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
225
226         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
227         https://bugs.webkit.org/show_bug.cgi?id=195849
228
229         Reviewed by Chris Dumez.
230
231         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
234         (runWebsiteDataStoreCustomPaths):
235
236 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
237
238         webkitpy: Upload test results
239         https://bugs.webkit.org/show_bug.cgi?id=195755
240         <rdar://problem/48896182>
241
242         Reviewed by Aakash Jain.
243
244         Establish a new format for uploading results that is not tied to layout tests, apply
245         that format to webkitpy tests.
246
247         * Scripts/webkitpy/common/checkout/scm/git.py:
248         (Git.native_branch): Return what branch the current checkout is on.
249         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
250         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
251         * Scripts/webkitpy/common/checkout/scm/svn.py:
252         (SVN.native_branch): Ditto.
253         * Scripts/webkitpy/common/system/platforminfo.py:
254         (PlatformInfo.build_version): Return a build version for Mac.
255         * Scripts/webkitpy/common/system/platforminfo_mock.py:
256         (MockPlatformInfo.__init__):
257         (MockPlatformInfo.build_version):
258         * Scripts/webkitpy/results: Added.
259         * Scripts/webkitpy/results/__init__.py: Added.
260         * Scripts/webkitpy/results/options.py: Added.
261         (upload_options): OptParse list for upload options.
262         * Scripts/webkitpy/results/upload.py: Added.
263         (Upload): Class which enforces the upload format expected by the results server.
264         (Upload.Expectations):
265         (Upload.create_configuration):
266         (Upload.create_commit):
267         (Upload.create_details):
268         (Upload.create_run_stats):
269         (Upload.create_test_result):
270         (Upload.__init__):
271         (Upload.Encoder): Encode Upload object as json.
272         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
273         * Scripts/webkitpy/results/upload_unittest.py: Added.
274         * Scripts/webkitpy/test/main.py:
275         (Tester._parse_args): Add upload arguments.
276         (Tester._run_tests): Allow results to be uploaded.
277         * Scripts/webkitpy/test/runner.py:
278         (Runner.__init__): Record which tests were run, rather than just counting them.
279         (Runner.handle):
280         * Scripts/webkitpy/test/runner_unittest.py:
281         (RunnerTest.test_run):
282         * Scripts/webkitpy/thirdparty/__init__.py:
283         (AutoinstallImportHook.find_module): Add requests auto-install.
284         (AutoinstallImportHook._install_requests):
285         * Scripts/webkitpy/tool/commands/queues_unittest.py:
286         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
287
288 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
289
290         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
291         https://bugs.webkit.org/show_bug.cgi?id=195810
292
293         Reviewed by Tim Horton.
294
295         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
296         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
297         ending certain layout tests.
298
299         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
300         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
301         (-[TestRunnerWKWebView dealloc]):
302         (-[TestRunnerWKWebView resetInteractionCallbacks]):
303
304         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
305         helper method when destroying the web view, and when resetting state between tests.
306
307         * WebKitTestRunner/ios/TestControllerIOS.mm:
308         (WTR::TestController::platformResetStateToConsistentValues):
309
310         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
311
312 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
313
314         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
315         https://bugs.webkit.org/show_bug.cgi?id=190350
316         <rdar://problem/45089503>
317
318         Reviewed by Geoffrey Garen.
319
320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
321         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
322         (TEST):
323         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
324         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
325         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
326         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
327         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
328         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
329         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
330         (runTest):
331         (createDirectories):
332         (TEST):
333         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
334         (TEST):
335         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
336         (TEST):
337
338 2019-03-15  Timothy Hatcher  <timothy@apple.com>
339
340         Add support to WebPage for getting the contents as an attributed string.
341         https://bugs.webkit.org/show_bug.cgi?id=195636
342         rdar://problem/45055697
343
344         Reviewed by Tim Horton.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
347         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
348
349 2019-03-15  Chris Dumez  <cdumez@apple.com>
350
351         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
352         https://bugs.webkit.org/show_bug.cgi?id=195747
353
354         Reviewed by Geoff Garen.
355
356         Add API test coverage.
357
358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
359
360 2019-03-15  Shawn Roberts  <sroberts@apple.com>
361
362         Unreviewed, rolling out r242952.
363
364         Causing API failures on iOS Simulator
365
366         Reverted changeset:
367
368         "[PSON] Make sure the WebProcessCache is leverage when
369         relaunching a process after termination"
370         https://bugs.webkit.org/show_bug.cgi?id=195747
371         https://trac.webkit.org/changeset/242952
372
373 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
374
375         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
376         https://bugs.webkit.org/show_bug.cgi?id=195740
377
378         Reviewed by Ross Kirsling.
379
380         window.open doesn't work for WebKitBrowserWindow because it is not
381         implemented yet.
382
383         1. Implemented createNewPage callback of WKPageUIClient.
384         2. Changed MainWindow to take a BrowserWindow factory function
385           instead of BrowserWindowType to be flexible to create
386           BrowserWindow with extra settings.
387         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
388           because it is not relevant with MainWindow anymore.
389
390         * MiniBrowser/win/Common.cpp:
391         (parseCommandLine):
392         * MiniBrowser/win/Common.h:
393         (CommandLineOptions::CommandLineOptions):
394         * MiniBrowser/win/MainWindow.cpp:
395         (MainWindow::MainWindow):
396         (MainWindow::create):
397         (MainWindow::init):
398         (MainWindow::WndProc):
399         * MiniBrowser/win/MainWindow.h:
400         * MiniBrowser/win/PrintWebUIDelegate.cpp:
401         (PrintWebUIDelegate::createWebViewWithRequest):
402         * MiniBrowser/win/WebKitBrowserWindow.cpp:
403         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
404         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
405         (WebKitBrowserWindow::updateProxySettings):
406         (WebKitBrowserWindow::createNewPage):
407         * MiniBrowser/win/WebKitBrowserWindow.h:
408         * MiniBrowser/win/WinMain.cpp:
409         (wWinMain):
410
411 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
412
413         Make it possible to test scrolling tree layer manipulation more easily
414         https://bugs.webkit.org/show_bug.cgi?id=195780
415
416         Reviewed by Tim Horton.
417         
418         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
419         cuts off communication of scrolling tree scrolls back to the web process
420         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
421         allows tests to trigger scrolls which run the scrolling tree layer positioning
422         logic, but never get another commit from the web process that might mask
423         scrolling tree bugs.
424         
425         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
426         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
427         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
428
429         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
430         (WTR::UIScriptController::scrollUpdatesDisabled const):
431         (WTR::UIScriptController::setScrollUpdatesDisabled):
432         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
433         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
434         (WTR::UIScriptController::scrollUpdatesDisabled const):
435         (WTR::UIScriptController::setScrollUpdatesDisabled):
436         * TestRunnerShared/UIScriptContext/UIScriptController.h:
437         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
438         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
439         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
440         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
441         * WebKitTestRunner/ios/TestControllerIOS.mm:
442         (WTR::TestController::platformResetStateToConsistentValues):
443         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
444         (WTR::UIScriptController::scrollUpdatesDisabled const):
445         (WTR::UIScriptController::setScrollUpdatesDisabled):
446
447 2019-03-14  Youenn Fablet  <youenn@apple.com>
448
449         Move IDB storage in private browsing mode to NetworkProcess
450         https://bugs.webkit.org/show_bug.cgi?id=195602
451
452         Reviewed by Brady Eidson.
453
454         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
455         (TEST):
456
457 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
458
459         [ews-build] Make descriptionDone messages more readable
460         https://bugs.webkit.org/show_bug.cgi?id=195760
461
462         Reviewed by Lucas Forschler.
463
464         * BuildSlaveSupport/ews-build/steps.py:
465         * BuildSlaveSupport/ews-build/steps_unittest.py:
466
467 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
468
469         [ews-build] Generate status-bubble hover-over messages
470         https://bugs.webkit.org/show_bug.cgi?id=195680
471
472         Reviewed by Lucas Forschler.
473
474         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
475         (StatusBubble):
476         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
477         on hover-over.
478         (StatusBubble._iso_time):
479         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
480         hover-over message.
481         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
482
483 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
484
485         [ews-app] Gracefully handle the case when state_string is None
486         https://bugs.webkit.org/show_bug.cgi?id=195753
487
488         Reviewed by Lucas Forschler.
489
490         * BuildSlaveSupport/ews-app/ews/models/build.py:
491         * BuildSlaveSupport/ews-app/ews/models/step.py:
492
493 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
494
495         [ews-app] Status bubble display pending for currently running build step
496         https://bugs.webkit.org/show_bug.cgi?id=195744
497
498         Reviewed by Lucas Forschler.
499
500         * BuildSlaveSupport/ews-build/events.py:
501         (Events.stepStarted): If state_string is pending, replace it with step name.
502
503 2019-03-14  Chris Dumez  <cdumez@apple.com>
504
505         Add WebsitePolicy for the client to specify the device orientation & motion access policy
506         https://bugs.webkit.org/show_bug.cgi?id=195750
507
508         Reviewed by Geoffrey Garen.
509
510         Add API test coverage.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
513         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
514         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
515         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
516
517 2019-03-14  Chris Dumez  <cdumez@apple.com>
518
519         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
520         https://bugs.webkit.org/show_bug.cgi?id=195747
521
522         Reviewed by Geoff Garen.
523
524         Add API test coverage.
525
526         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
527
528 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
529
530         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
531         https://bugs.webkit.org/show_bug.cgi?id=195725
532         <rdar://problem/48545062>
533
534         Reviewed by Tim Horton.
535
536         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
537         handler is nil.
538
539         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
540         (TestWebKitAPI::TEST):
541
542 2019-03-13  Sam Weinig  <sam@webkit.org>
543
544         Add utility function to allow easy reverse range-based iteration of a container
545         https://bugs.webkit.org/show_bug.cgi?id=195542
546
547         Reviewed by Antti Koivisto.
548
549         * TestWebKitAPI/CMakeLists.txt:
550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
551         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
552         (TestWebKitAPI::TEST):
553         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
554
555 2019-03-13  Chris Dumez  <cdumez@apple.com>
556
557         Use a ServiceWorker process per registrable domain
558         https://bugs.webkit.org/show_bug.cgi?id=195649
559
560         Reviewed by Youenn Fablet.
561
562         Update API test coverage.
563
564         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
565
566 2019-03-13  Chris Dumez  <cdumez@apple.com>
567
568         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
569         https://bugs.webkit.org/show_bug.cgi?id=195684
570         <rdar://problem/48294714>
571
572         Reviewed by Antti Koivisto.
573
574         Add API test coverage.
575
576         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
577
578 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
579
580         [ews-app] Remove unused patch view
581         https://bugs.webkit.org/show_bug.cgi?id=195669
582
583         Reviewed by Lucas Forschler.
584
585         * BuildSlaveSupport/ews-app/ews/urls.py:
586         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
587
588 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
589
590         [ews-app] Use Buildbot result code variables
591         https://bugs.webkit.org/show_bug.cgi?id=195668
592
593         Reviewed by Alexey Proskuryakov.
594
595         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
596         (Buildbot): Added Buildbot result code variables.
597         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
598         (StatusBubble._build_bubble): Used Buildbot result code variables.
599
600 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
601
602         [Flatpak] Expand submodule recursively
603         https://bugs.webkit.org/show_bug.cgi?id=195672
604
605         Building WPE with flatpak was impossible without that as it was raising an exception.
606         Also update wpebackend-fdo to match what is built in jhbuild
607
608         Reviewed by Philippe Normand.
609
610         * flatpak/flatpakutils.py:
611         (expand_submodules_recurse):
612         (expand_manifest):
613         * flatpak/org.webkit.WPEModules.yaml:
614
615 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
616
617         [ews-app] status bubble should be hidden for certain builds
618         https://bugs.webkit.org/show_bug.cgi?id=194597
619
620         Reviewed by Dewei Zhu.
621
622         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
623         (StatusBubble._build_bubble):
624         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
625         because the patch didn't have relevant changes.
626         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
627         in production yet.
628
629 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
630
631         [Win] Fix a slew of simple clang-cl warnings.
632         https://bugs.webkit.org/show_bug.cgi?id=195652
633
634         Reviewed by Don Olmstead.
635
636         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
637         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
638
639 2019-03-12  Justin Fan  <justin_fan@apple.com>
640
641         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
642         https://bugs.webkit.org/show_bug.cgi?id=195518
643         <rdar://problem/46322356>
644
645         Reviewed by Myles C. Maxfield.
646
647         * DumpRenderTree/DerivedSources-input.xcfilelist:
648         * DumpRenderTree/DerivedSources-output.xcfilelist:
649
650 2019-03-12  Commit Queue  <commit-queue@webkit.org>
651
652         Unreviewed, rolling out r242825.
653         https://bugs.webkit.org/show_bug.cgi?id=195648
654
655         "Broke webkitpy tests with my change to
656         lldb_dump_class_layout.py" (Requested by rmorisset on
657         #webkit).
658
659         Reverted changeset:
660
661         "Alter Tools/Scripts/dump-class-layout to be able to dump all
662         classes with suspicious padding"
663         https://bugs.webkit.org/show_bug.cgi?id=195573
664         https://trac.webkit.org/changeset/242825
665
666 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
667
668         [ews-build] Show status bubbles while the patch is waiting in queue
669         https://bugs.webkit.org/show_bug.cgi?id=195618
670
671         Reviewed by Lucas Forschler.
672
673         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
674         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
675         enabled in initial deployment.
676         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
677         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
678         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
679         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
680         (StatusBubble._build_bubbles_for_patch):
681
682 2019-03-12  Robin Morisset  <rmorisset@apple.com>
683
684         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
685         https://bugs.webkit.org/show_bug.cgi?id=195573
686
687         Reviewed by Simon Fraser.
688
689         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
690
691         * Scripts/dump-class-layout:
692         (main):
693         * lldb/lldb_dump_class_layout.py:
694         (ClassLayout.__init__):
695         (ClassLayout._compute_padding_recursive):
696         (LLDBDebuggerInstance.dump_layout_for_classname):
697         (LLDBDebuggerInstance):
698         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
699         (LLDBDebuggerInstance.layout_for_classname): Deleted.
700
701 2019-03-12  Chris Dumez  <cdumez@apple.com>
702
703         Device Orientation access permission should be denied unless explicitly granted by the client
704         https://bugs.webkit.org/show_bug.cgi?id=195625
705
706         Reviewed by Youenn Fablet.
707
708         add API test coverage.
709
710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
711         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
712         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
713         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
714         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
715         (runDeviceOrientationTest):
716         (TEST):
717         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
718         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
719
720 2019-03-12  Jer Noble  <jer.noble@apple.com>
721
722         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
723         https://bugs.webkit.org/show_bug.cgi?id=195137
724         <rdar://problem/48810307>
725
726         Reviewed by Eric Carlson.
727
728         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
729         (TestWebKitAPI::TEST):
730
731 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
732
733         [ews-build] Change urls from uat to production
734         https://bugs.webkit.org/show_bug.cgi?id=195566
735
736         Reviewed by Lucas Forschler.
737
738         * BuildSlaveSupport/ews-app/ews/config.py:
739         * BuildSlaveSupport/ews-build/events.py:
740         * BuildSlaveSupport/ews-build/steps.py:
741
742 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-build] change max_builds for local-worker to 1
745         https://bugs.webkit.org/show_bug.cgi?id=195568
746
747         Reviewed by Lucas Forschler.
748
749         * BuildSlaveSupport/ews-build/loadConfig.py:
750
751 2019-03-12  Tim Horton  <timothy_horton@apple.com>
752
753         Fix the build
754
755         * TestRunnerShared/spi/PencilKitTestSPI.h:
756         * TestWebKitAPI/ios/PencilKitTestSPI.h:
757
758 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
759
760         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
761         https://bugs.webkit.org/show_bug.cgi?id=194131
762
763         Reviewed by Michael Catanzaro.
764
765         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
766         (uriChanged):
767         (testUnfinishedSubresourceLoad):
768         (serverCallback):
769         (beforeAll):
770
771 2019-03-11  Alex Christensen  <achristensen@webkit.org>
772
773         WTF::Expected should use std::addressof instead of operator&
774         https://bugs.webkit.org/show_bug.cgi?id=195604
775
776         Reviewed by Myles Maxfield.
777
778         * TestWebKitAPI/Tests/WTF/Expected.cpp:
779         (TestWebKitAPI::Unique::Unique):
780         (TestWebKitAPI::Unique::operator&):
781         (TestWebKitAPI::TEST):
782
783 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
784
785         Add Optional to Forward.h.
786         https://bugs.webkit.org/show_bug.cgi?id=195586
787
788         Reviewed by Darin Adler.
789
790         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
791         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
792         Remove unnecessary includes from headers.
793
794 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
795
796         Add testing API to hit-test and scroll overflow scrollers
797         https://bugs.webkit.org/show_bug.cgi?id=195278
798
799         Reviewed by Antti Koivisto.
800         
801         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
802         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
803         
804         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
805
806         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
807         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
808         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
809         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
810         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
811         * TestRunnerShared/UIScriptContext/UIScriptController.h:
812         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
813         (WTR::enclosingScrollViewIncludingSelf):
814         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
815
816 2019-03-11  Tim Horton  <timothy_horton@apple.com>
817
818         API test WebKit.RequestTextInputContext fails on iOS
819         https://bugs.webkit.org/show_bug.cgi?id=195585
820
821         Reviewed by Wenson Hsieh and Simon Fraser.
822
823         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
824         (applyStyle):
825         (TEST):
826         Add a viewport, so that the coordinates match up on iOS.
827         Scroll by moving the UIScrollView's contentOffset.
828
829 2019-03-11  Chris Dumez  <cdumez@apple.com>
830
831         Assert in WebPageProxy::suspendCurrentPageIfPossible()
832         https://bugs.webkit.org/show_bug.cgi?id=195506
833         <rdar://problem/48733477>
834
835         Reviewed by Alex Christensen.
836
837         Add API test coverage.
838
839         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
840
841 2019-03-11  Shawn Roberts  <sroberts@apple.com>
842
843         Adding myself to contributors.json
844
845         Unreviewed, addming myself to contributors.json .
846
847         * Scripts/webkitpy/common/config/contributors.json:
848
849 2019-03-11  Alex Christensen  <achristensen@webkit.org>
850
851         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
852         https://bugs.webkit.org/show_bug.cgi?id=195511
853         <rdar://problem/44873269>
854
855         Reviewed by Darin Adler.
856
857         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
858         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
859         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
860         (TEST_F):
861
862 2019-03-11  Chris Dumez  <cdumez@apple.com>
863
864         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
865         https://bugs.webkit.org/show_bug.cgi?id=195561
866
867         Reviewed by Youenn Fablet.
868
869         Make sure the JS in the test requests for permission to receive device orientation events.
870
871         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
872
873 2019-03-11  Youenn Fablet  <youenn@apple.com>
874
875         Allow storage quota increase by default in WTR
876         https://bugs.webkit.org/show_bug.cgi?id=195541
877
878         Reviewed by Geoffrey Garen.
879
880         Allow storage quota increase by default in WTR.
881         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
882         Use this for tests that explicitly need cache increase.
883
884         Instead of increasing quota by 2, make sure the next request is
885         granted by adding all given parameters.
886
887         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
888         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
889         (WTR::TestRunner::setAllowStorageQuotaIncrease):
890         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
891         * WebKitTestRunner/InjectedBundle/TestRunner.h:
892         * WebKitTestRunner/TestController.cpp:
893         (WTR::TestController::setAllowStorageQuotaIncrease):
894         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
895         * WebKitTestRunner/TestController.h:
896         * WebKitTestRunner/TestInvocation.cpp:
897         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
898         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
899         (WTR::TestController::cocoaResetStateToConsistentValues):
900         (WTR::TestController::setAllowStorageQuotaIncrease):
901         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
902         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
903         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
904
905 2019-03-11  Xan Lopez  <xan@igalia.com>
906
907         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
908         https://bugs.webkit.org/show_bug.cgi?id=194147
909
910         Reviewed by Michael Saboff.
911
912         To make --32-bit work correctly on Linux/64bit we need to:
913
914         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
915         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
916         unfortunately CMake only allows us to do this during
917         crosscompilation, which is overkill here.
918         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
919         pkg-config detection module uses the x86 .pc files instead of the
920         x86_64 ones.
921         - Set the -m32 flags for the compiler.
922
923         * Scripts/webkitdirs.pm:
924         (generateBuildSystemFromCMakeProject):
925
926 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
927
928         Add MotionMark-1.1 plan file for run-benchmark script.
929         https://bugs.webkit.org/show_bug.cgi?id=195481
930
931         Rubber-stamped by Darin Adler.
932
933         Run-benchmark script should support MontionMark-1.1.
934
935         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
936
937 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
938
939         [ews-app] Add support for submit-to-ews url
940         https://bugs.webkit.org/show_bug.cgi?id=195477
941
942         Reviewed by Lucas Forschler.
943
944         * BuildSlaveSupport/ews-app/ews/fetcher.py:
945         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
946         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
947         * BuildSlaveSupport/ews-app/ews/urls.py:
948         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
949
950 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
951
952         Unreviewed, rolling out r242688, r242643, r242624.
953
954         Caused multiple layout test failures and crashes on iOS and macOS.
955
956         Reverted changeset:
957
958         "requestAnimationFrame should execute before the next frame"
959         https://bugs.webkit.org/show_bug.cgi?id=177484
960         https://trac.webkit.org/changeset/242624/webkit
961
962         * Tracing/SystemTracePoints.plist:
963
964 2019-03-11  John Wilander  <wilander@apple.com>
965
966         Resource Load Statistics: Make it possible exclude localhost from classification
967         https://bugs.webkit.org/show_bug.cgi?id=195474
968         <rdar://problem/47520577>
969
970         Reviewed by Brent Fulgham.
971
972         This patch allows for localhost to be excluded from classification and
973         treatment as a prevalent resource.
974
975         The WebKit Tools change adds a new function called
976         testRunner.setStatisticsIsRunningTest() which can be used to control this
977         behavior.
978
979         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
980         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
981         (WTR::TestRunner::setStatisticsIsRunningTest):
982         * WebKitTestRunner/InjectedBundle/TestRunner.h:
983         * WebKitTestRunner/TestController.cpp:
984         (WTR::TestController::setStatisticsIsRunningTest):
985         * WebKitTestRunner/TestController.h:
986         * WebKitTestRunner/TestInvocation.cpp:
987         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
988
989 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
990
991         [ews-build] Disable waterfall and console view for ews-build.webkit.org
992         https://bugs.webkit.org/show_bug.cgi?id=195560
993
994         Reviewed by Lucas Forschler.
995
996         * BuildSlaveSupport/ews-build/master.cfg:
997
998 2019-03-11  Alex Christensen  <achristensen@webkit.org>
999
1000         Unreviewed, rolling out r242698.
1001
1002         API test crashes on bots.
1003
1004         Reverted changeset:
1005
1006         "Add a WKContentRuleList variant that uses copied memory
1007         instead of mmap'd shared memory for class A containerized
1008         apps"
1009         https://bugs.webkit.org/show_bug.cgi?id=195511
1010         https://trac.webkit.org/changeset/242698
1011
1012 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1013
1014         [WPE] Enable web process sandbox
1015         https://bugs.webkit.org/show_bug.cgi?id=195169
1016
1017         Reviewed by Daniel Bates.
1018
1019         * wpe/install-dependencies:
1020         * wpe/jhbuild.modules:
1021
1022 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1023
1024         [ews-app] Use port 17000 for worker communication
1025         https://bugs.webkit.org/show_bug.cgi?id=195558
1026
1027         Reviewed by Lucas Forschler.
1028
1029         * BuildSlaveSupport/ews-build/master.cfg:
1030
1031 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1032
1033         [ews-build] unit-tests fail when passwords.json is missing
1034         https://bugs.webkit.org/show_bug.cgi?id=195557
1035
1036         Reviewed by Lucas Forschler.
1037
1038         * BuildSlaveSupport/ews-build/loadConfig.py:
1039         (loadBuilderConfig):
1040         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1041         (ConfigDotJSONTest.test_configuration):
1042         * BuildSlaveSupport/ews-build/master.cfg:
1043
1044 2019-03-11  Truitt Savell  <tsavell@apple.com>
1045
1046         Unreviewed, rolling out r242702.
1047
1048         Broke High Sierra builders.
1049
1050         Reverted changeset:
1051
1052         "Add utility function to allow easy reverse range-based
1053         iteration of a container"
1054         https://bugs.webkit.org/show_bug.cgi?id=195542
1055         https://trac.webkit.org/changeset/242702
1056
1057 2019-03-11  Sam Weinig  <sam@webkit.org>
1058
1059         Add utility function to allow easy reverse range-based iteration of a container
1060         https://bugs.webkit.org/show_bug.cgi?id=195542
1061
1062         Reviewed by Antti Koivisto.
1063
1064         * TestWebKitAPI/CMakeLists.txt:
1065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1066         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1067         (TestWebKitAPI::TEST):
1068         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1069
1070 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1071
1072         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1073         https://bugs.webkit.org/show_bug.cgi?id=195511
1074         <rdar://problem/44873269>
1075
1076         Reviewed by Darin Adler.
1077
1078         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1079         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1080         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1081         (TEST_F):
1082
1083 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1084
1085         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1086         https://bugs.webkit.org/show_bug.cgi?id=195499
1087
1088         Reviewed by Darin Adler.
1089
1090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1091         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1092         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1093         (-[WKWebView synchronouslyFocusTextInputContext:]):
1094         (applyStyle):
1095         (applyIframe):
1096         (TEST):
1097         Add some tests for this SPI.
1098
1099 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1100
1101         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1102         https://bugs.webkit.org/show_bug.cgi?id=181151
1103
1104         Reviewed by Don Olmstead.
1105
1106         * TestWebKitAPI/CMakeLists.txt:
1107         * TestWebKitAPI/PlatformWin.cmake:
1108         Enable TestWTF RunLoop tests in all platforms.
1109
1110         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1111         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1112         (TestWebKitAPI::DerivedOneShotTimer::fired):
1113         (TestWebKitAPI::TEST):
1114         Only a few platforms support nested RunLoop.
1115
1116         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1117         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1118
1119 2019-03-10  David Quesada  <david_quesada@apple.com>
1120
1121         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1122         https://bugs.webkit.org/show_bug.cgi?id=152480
1123
1124         Reviewed by Chris Dumez.
1125
1126         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1127         there are no additional references to the process pool besides the one held by
1128         the download, waits for the download to finish (in the sense that the
1129         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1130         measure, also check that the process pool has been deallocated at the end of the
1131         test. The test wouldn't be meaningful if the process pool were still alive.
1132
1133         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1134         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1135         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1136             The download will be canceled because the delegate does not implement the
1137             method to decide the download's destination, so this is where we know the
1138             DownloadProxyMap is done with the DownloadProxy.
1139         (TEST):
1140
1141 2019-03-08  Chris Dumez  <cdumez@apple.com>
1142
1143         Add support for Device Orientation / Motion permission API
1144         https://bugs.webkit.org/show_bug.cgi?id=195329
1145         <rdar://problem/47645367>
1146
1147         Reviewed by Geoffrey Garen.
1148
1149         Add test infrastructure to help test the Device Orientation / Motion permission API.
1150
1151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1153         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1154         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1155         * WebKitTestRunner/TestController.cpp:
1156         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1157         (WTR::TestController::createWebViewWithOptions):
1158         (WTR::TestController::resetStateToConsistentValues):
1159         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1160         * WebKitTestRunner/TestController.h:
1161         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1162         * WebKitTestRunner/TestInvocation.cpp:
1163         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1164
1165 2019-03-08  Saam barati  <sbarati@apple.com>
1166
1167         Add a compare-results script to compare benchmark results
1168         https://bugs.webkit.org/show_bug.cgi?id=195486
1169         <rdar://problem/48723397>
1170
1171         Reviewed by Geoffrey Garen.
1172
1173         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1174         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1175         to extend it to learn about our other benchmarks.
1176
1177         * Scripts/compare-results: Added.
1178         (readJSONFile):
1179         (detectJetStream2):
1180         (JetStream2Results):
1181         (detectSpeedometer2):
1182         (Speedometer2Results):
1183         (detectPLT5):
1184         (PLT5Results):
1185         (detectBenchmark):
1186         (biggerIsBetter):
1187         (ttest):
1188         (getOptions):
1189         (main):
1190
1191 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1192
1193         Ensure old tab state is cleared between iterations of run-benchmark
1194         https://bugs.webkit.org/show_bug.cgi?id=195393
1195         <rdar://problem/46885583>
1196
1197         Reviewed by Dewei Zhu.
1198
1199         a) ensure the default to restore state is not set
1200         b) terminate Safari correctly
1201         c) Set the system default to ignore Persistent State in Safari
1202
1203         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1204         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1205         (OSXBrowserDriver.prepare_env): 
1206         (OSXBrowserDriver.restore_env):
1207         (OSXBrowserDriver.close_browsers):
1208         (OSXBrowserDriver._terminate_processes):
1209         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1210         (OSXChromeDriver):
1211         (OSXChromeCanaryDriver):
1212         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1213         (OSXFirefoxDriver):
1214         (OSXFirefoxNightlyDriver):
1215         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1216         (OSXSafariDriver):
1217         (OSXSafariDriver.prepare_env):
1218
1219 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1220
1221         [GTK] Several InputMethodFilter tests are failing
1222         https://bugs.webkit.org/show_bug.cgi?id=195408
1223
1224         Reviewed by Carlos Garcia Campos.
1225
1226         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1227         Regressed in r241751.
1228         Hexadecimal values of keycodes are expressed now in upper letters.
1229         Composited characters should be cast to UTF8 strings.
1230
1231         (TestWebKitAPI::TEST):
1232
1233 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1234
1235         [GTK] Make Tools/gtkdoc python3 compatible
1236         https://bugs.webkit.org/show_bug.cgi?id=195359
1237
1238         Reviewed by Carlos Garcia Campos.
1239
1240         * gtkdoc/generate-gtkdoc:
1241         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1242         work with Python 2 and 3.
1243         (get_gtkdoc_module_paths):
1244         The iteritems() was removed in Python 3, so let's use items() that's
1245         available in Python 2 and 3.
1246         (get_generator_for_config):
1247         * gtkdoc/gtkdoc.py:
1248         (GTKDoc._run_command):
1249         The sys.stdout.write() is expecting str in Python 3 and not bytes
1250         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1251         for passing the bytes there.
1252
1253 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1254
1255         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1256         https://bugs.webkit.org/show_bug.cgi?id=195346
1257         <rdar://problem/48667048>
1258
1259         Unreviewed build fix for clang-cl.
1260
1261         * DumpRenderTree/win/DumpRenderTree.cpp:
1262         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1263
1264 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1265
1266         requestAnimationFrame should execute before the next frame
1267         https://bugs.webkit.org/show_bug.cgi?id=177484
1268
1269         Reviewed by Simon Fraser.
1270
1271         Add trace points for the page RenderingUpdate.
1272
1273         * Tracing/SystemTracePoints.plist:
1274
1275 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1276
1277         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1278         https://bugs.webkit.org/show_bug.cgi?id=195353
1279         <rdar://problem/48626394>
1280
1281         Reviewed by Simon Fraser.
1282
1283         * WebKitTestRunner/ios/TestControllerIOS.mm:
1284         (WTR::TestController::platformResetPreferencesToConsistentValues):
1285
1286 2019-03-07  John Wilander  <wilander@apple.com>
1287
1288         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1289         https://bugs.webkit.org/show_bug.cgi?id=195383
1290         <rdar://problem/48570136>
1291
1292         Reviewed by Brent Fulgham.
1293
1294         This patch adds test infrastructure to purge only script-accessible cookies,
1295         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1296
1297         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1299         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1300         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1301         * WebKitTestRunner/TestController.cpp:
1302         (WTR::TestController::statisticsDeleteCookiesForHost):
1303         * WebKitTestRunner/TestController.h:
1304         * WebKitTestRunner/TestInvocation.cpp:
1305         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1306
1307 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1308
1309         Unreviewed, rolling out r242354.
1310         https://bugs.webkit.org/show_bug.cgi?id=195402
1311
1312         breaks layout tests in all configurations (Requested by
1313         zdobersek on #webkit).
1314
1315         Reverted changeset:
1316
1317         "[WPE] Enable web process sandbox"
1318         https://bugs.webkit.org/show_bug.cgi?id=195169
1319         https://trac.webkit.org/changeset/242354
1320
1321 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1322
1323         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1324         https://bugs.webkit.org/show_bug.cgi?id=195346
1325
1326         Reviewed by Fujii Hironori.
1327
1328         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1329         (TestWebKitAPI::TEST):
1330         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1331
1332         * DumpRenderTree/win/DumpRenderTree.cpp:
1333         (findFontFallback):
1334         (addFontFallbackIfPresent):
1335         (removeFontFallbackIfPresent):
1336         (main):
1337         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1338         (TestWebKitAPI::Util::moduleDirectory):
1339         (TestWebKitAPI::Util::createInjectedBundlePath):
1340         Use wchar helpers as needed.
1341
1342 2019-03-06  Rob Buis  <rbuis@igalia.com>
1343
1344         Consider supporting the `referrerpolicy` attribute.
1345         https://bugs.webkit.org/show_bug.cgi?id=179053
1346
1347         Reviewed by Darin Adler.
1348
1349         Add a runtime flag for referrerpolicy attribute.
1350
1351         * DumpRenderTree/mac/DumpRenderTree.mm:
1352         (enableExperimentalFeatures):
1353
1354 2019-03-05  Daniel Bates  <dabates@apple.com>
1355
1356         Update expected API test result following r242379
1357         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1358
1359         Update expected x-coordinate of selection rect now that the left padding of
1360         a textarea is sized in ems (so dependent on the font size) just like the left
1361         padding of a text field.
1362
1363         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1364         (TestWebKitAPI::TEST):
1365
1366 2019-03-05  David Quesada  <david_quesada@apple.com>
1367
1368         [WK2] It should be possible to follow links with 'download' attributes
1369         https://bugs.webkit.org/show_bug.cgi?id=195145
1370         rdar://problem/48462642
1371
1372         Reviewed by Alex Christensen.
1373
1374         Add a unit test to verify that activating links with 'download' attributes now
1375         navigates to the linked resource, rather than starts downloading it. Add another
1376         to verify that it is still possible to explicitly download the link via the
1377         'Download' navigation action policy.
1378
1379         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1380         (-[DownloadAttributeTestDelegate init]):
1381         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
1382         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
1383         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
1384         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
1385         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1386         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
1387         (TEST):
1388         * WebKitTestRunner/TestController.cpp:
1389         (WTR::TestController::decidePolicyForNavigationAction):
1390         * WebKitTestRunner/TestController.h:
1391
1392 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
1393
1394         [Curl] Implement Cookie Accept Policy.
1395         https://bugs.webkit.org/show_bug.cgi?id=191645
1396
1397         Reviewed by Fujii Hironori.
1398
1399         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1400         (TestWebKitAPI::Curl::TEST_F):
1401
1402 2019-03-05  Youenn Fablet  <youenn@apple.com>
1403
1404         Rename requestCacheStorageSpace to requestStorageSpace
1405         https://bugs.webkit.org/show_bug.cgi?id=195282
1406
1407         Reviewed by Chris Dumez.
1408
1409         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1410         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1411         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
1412
1413 2019-03-05  Brady Eidson  <beidson@apple.com>
1414
1415         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
1416         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
1417
1418         Reviewed by Tim Horton.
1419
1420         Loading a file: URL into a WKWebView and then loading another file: url from a completely
1421         different directory into that same WKWebView should work.
1422
1423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1424         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
1425
1426 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1427
1428         Add WeakHashSet
1429         https://bugs.webkit.org/show_bug.cgi?id=195152
1430
1431         Reviewed by Antti Koivisto.
1432
1433         Added tests for WeakHashSet.
1434
1435         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1436         (TestWebKitAPI::Base::Base): Moved.
1437         (TestWebKitAPI::Derived::foo): Moved.
1438         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
1439         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
1440         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
1441         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
1442
1443 2019-03-04  Chris Dumez  <cdumez@apple.com>
1444
1445         Do not share WebProcesses between private and regular sessions
1446         https://bugs.webkit.org/show_bug.cgi?id=195189
1447         <rdar://problem/48421064>
1448
1449         Reviewed by Alex Christensen.
1450
1451         Add API test coverage.
1452
1453         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1454         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1455
1456 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1457
1458         [WPE] Enable web process sandbox
1459         https://bugs.webkit.org/show_bug.cgi?id=195169
1460
1461         Reviewed by Daniel Bates.
1462
1463         * wpe/install-dependencies:
1464         * wpe/jhbuild.modules:
1465
1466 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1467
1468         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
1469         https://bugs.webkit.org/show_bug.cgi?id=195206
1470
1471         Reviewed by Žan Doberšek.
1472
1473         Add a new test case.
1474
1475         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1476         (testJSCClass):
1477
1478 2019-03-04  Charlie Turner  <cturner@igalia.com>
1479
1480         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
1481         https://bugs.webkit.org/show_bug.cgi?id=194898
1482
1483         Reviewed by Žan Doberšek.
1484
1485         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
1486         a GCC extension that permits arithmetic on void* pointer. Inline
1487         the macro until this issue is fixed upstream.
1488
1489 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1490
1491         Rid the world of WK_API_ENABLED
1492         https://bugs.webkit.org/show_bug.cgi?id=195263
1493
1494         Reviewed by Dan Bernstein.
1495
1496         List of changed files elided because it's useless.
1497
1498 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
1499
1500         Unreviewed follow-up to r242292.
1501
1502         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
1503
1504         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1505         (TestWebKitAPI::testStrip): Renamed from strip.
1506         (TestWebKitAPI::TEST):
1507
1508 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1509
1510         Unreviewed, remove accidentally-committed URLHelpers.cpp test
1511
1512         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
1513         and bug #194272 for details.
1514
1515         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
1516
1517 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1518
1519         Remove some more unused 32-bit code
1520         https://bugs.webkit.org/show_bug.cgi?id=195255
1521
1522         Reviewed by Darin Adler.
1523
1524         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1525         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
1526         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1527         (NPP_New):
1528         (NPP_HandleEvent):
1529         (handleEventCarbon): Deleted.
1530
1531 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
1532
1533         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
1534
1535         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1536         (TestWebKitAPI::TEST):
1537
1538 2019-03-01  Darin Adler  <darin@apple.com>
1539
1540         Finish removing String::format
1541         https://bugs.webkit.org/show_bug.cgi?id=194893
1542
1543         Reviewed by Daniel Bates.
1544 '
1545         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
1546
1547 2019-03-01  Alex Christensen  <achristensen@webkit.org>
1548
1549         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
1550         https://bugs.webkit.org/show_bug.cgi?id=195229
1551         <rdar://problem/48520362>
1552
1553         Reviewed by Chris Dumez.
1554
1555         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1556         (TEST):
1557
1558 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
1559
1560         Add a system trace scope for event region building
1561         https://bugs.webkit.org/show_bug.cgi?id=195226
1562
1563         Reviewed by Jon Lee.
1564
1565         This trace scope measures the time spend converting element rects into Region objects,
1566         which can be large on some pages.
1567
1568         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
1569
1570         * Tracing/SystemTracePoints.plist:
1571
1572 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1573
1574         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
1575         https://bugs.webkit.org/show_bug.cgi?id=194612
1576
1577         Reviewed by Alex Christensen.
1578
1579         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1580         Just test the new string-processing function and don't touch the actual environment.
1581         (Test cases are all as before, but based on operator== instead of strcmp.)
1582
1583 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
1584
1585         [ews-app] Update primary keys for handling multiple Buildbot instances
1586         https://bugs.webkit.org/show_bug.cgi?id=195120
1587
1588         Reviewed by Stephanie Lewis.
1589
1590         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
1591         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
1592         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
1593
1594         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
1595         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
1596         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
1597         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
1598         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
1599         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
1600
1601 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
1602
1603         [WinCairo] Enable service worker
1604         https://bugs.webkit.org/show_bug.cgi?id=188318
1605
1606         Reviewed by Youenn Fablet.
1607
1608         * DumpRenderTree/DumpRenderTreePrefix.h:
1609         * TestWebKitAPI/PlatformWin.cmake:
1610         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
1611         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
1612         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1613
1614 2019-03-01  Justin Fan  <justin_fan@apple.com>
1615
1616         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
1617         https://bugs.webkit.org/show_bug.cgi?id=195191
1618
1619         Rubber-stamped by Dean Jackson.
1620
1621         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
1622
1623         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1624
1625 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
1626
1627         Unreviewed, fix lldb webkitpy tests
1628         https://bugs.webkit.org/show_bug.cgi?id=194375
1629
1630         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
1631
1632         * lldb/lldb_webkit.py:
1633         (WTFStringImplProvider.is_8bit):
1634
1635 2019-02-28  David Quesada  <david_quesada@apple.com>
1636
1637         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1638         https://bugs.webkit.org/show_bug.cgi?id=195121
1639         rdar://problem/48450302
1640
1641         Reviewed by Alex Christensen.
1642
1643         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1644         configurations where the 'download' attribute is absent, blank, or populated
1645         with a filename, and where the anchor element is same-origin or cross-origin
1646         (meaning the 'download' attribute shouldn't be honored).
1647
1648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1649         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1650         (-[NavigationActionTestDelegate init]):
1651         (-[NavigationActionTestDelegate navigationAction]):
1652         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1653         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1654         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1655         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1656         (TEST):
1657
1658 2019-02-28  Antoine Quint  <graouts@apple.com>
1659
1660         Enable the Pointer Events runtime flag by default
1661         https://bugs.webkit.org/show_bug.cgi?id=195156
1662
1663         Reviewed by Dean Jackson.
1664
1665         * DumpRenderTree/mac/DumpRenderTree.mm:
1666         (enableExperimentalFeatures):
1667
1668 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1669
1670         Several PasteImage API tests are flaky
1671         https://bugs.webkit.org/show_bug.cgi?id=195160
1672
1673         Reviewed by Tim Horton.
1674
1675         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1676         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1677         listening for a "load" event after image load is already complete.
1678
1679         To address this, make these tests first register a "load" event handler, then run script to insert an image
1680         element into the document, and finally wait until the load event is observed before checking image size.
1681
1682         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1683
1684 2019-02-28  Chris Dumez  <cdumez@apple.com>
1685
1686         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1687         https://bugs.webkit.org/show_bug.cgi?id=195107
1688
1689         Reviewed by Alex Christensen.
1690
1691         Give some time for the zoom level to get restored.
1692
1693         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1694
1695 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1696
1697         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1698         https://bugs.webkit.org/show_bug.cgi?id=194958
1699
1700         Reviewed by Geoffrey Garen.
1701
1702         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1703         (TEST):
1704
1705 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1706
1707         [ews-app] Update method to save build to handle builder_display_name
1708         https://bugs.webkit.org/show_bug.cgi?id=195047
1709
1710         Reviewed by Dewei Zhu.
1711
1712         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1713         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1714
1715 2019-02-28  Justin Fan  <justin_fan@apple.com>
1716
1717         [Web GPU] Enable Web GPU only on 64-bit
1718         https://bugs.webkit.org/show_bug.cgi?id=195139
1719
1720         Because Metal is only supported on 64 bit apps.
1721
1722         Unreviewed build fix.
1723
1724         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1725
1726 2019-02-27  Youenn Fablet  <youenn@apple.com>
1727
1728         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1729         https://bugs.webkit.org/show_bug.cgi?id=194959
1730
1731         Reviewed by Chris Dumez.
1732
1733         Spin loop until getting the condition to remove flakiness.
1734
1735         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1736
1737 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1738
1739         [ews-build] Buildbot should include builder_display_name in the build events
1740         https://bugs.webkit.org/show_bug.cgi?id=195045
1741
1742         Reviewed by Dewei Zhu.
1743
1744         * BuildSlaveSupport/ews-build/events.py:
1745         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1746         buildername to builder_name to be consistent in naming style.
1747         (Events.buildFinished): Ditto.
1748
1749 2019-02-27  Chris Dumez  <cdumez@apple.com>
1750
1751         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1752         https://bugs.webkit.org/show_bug.cgi?id=194480
1753
1754         Reviewed by Brady Eidson.
1755
1756         Update existing API test to make it more likely to reproduce the issue.
1757
1758         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1759
1760 2019-02-27  Brady Eidson  <beidson@apple.com>
1761
1762         Universal links from Google search results pages don't open the app.
1763         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1764
1765         Reviewed by Geoffrey Garen.
1766
1767         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1768         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1769         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1770         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1771
1772 2019-02-27  Chris Dumez  <cdumez@apple.com>
1773
1774         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1775         https://bugs.webkit.org/show_bug.cgi?id=195102
1776
1777         Reviewed by Geoffrey Garen.
1778
1779         If the number of processes is not yet what we expect, wait a bit and check again to give
1780         processes some time to exit.
1781
1782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1783
1784 2019-02-27  Chris Dumez  <cdumez@apple.com>
1785
1786         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1787         https://bugs.webkit.org/show_bug.cgi?id=194545
1788
1789         Reviewed by Brady Eidson.
1790
1791         Make sure the test navigates forward and then back only once. Previously, navigating
1792         back would trigger a navigation again in a timer.
1793
1794         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1795
1796 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1797
1798         High Sierra Debug JSC test queue should use faster hardware
1799         https://bugs.webkit.org/show_bug.cgi?id=194603
1800
1801         Rubber-stamped by Alexey Proskuryakov.
1802
1803         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1804
1805         * BuildSlaveSupport/build.webkit.org-config/config.json:
1806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1807         (BubbleQueueServer):
1808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1809         (WebKitBuildbot):
1810         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1811         * QueueStatusServer/config/queues.py:
1812         * Scripts/webkitpy/common/config/ews.json:
1813         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1814         (test_ews_name):
1815
1816 2019-02-27  John Wilander  <wilander@apple.com>
1817
1818         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1819         https://bugs.webkit.org/show_bug.cgi?id=195071
1820         <rdar://problem/48417690>
1821
1822         Reviewed by Alex Christensen and Brent Fulgham.
1823
1824         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1825         (TestWebKitAPI::createURL):
1826             Convenience function.
1827         (TestWebKitAPI::TEST):
1828             WebCore::AdClickAttribution now takes a URL when creating Source and
1829             Destination.
1830         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1831         (TestWebKitAPI::TEST):
1832             WebCore::AdClickAttribution now takes a URL when creating Source and
1833             Destination.
1834
1835 2019-02-27  Antoine Quint  <graouts@apple.com>
1836
1837         Support Pointer Events on macOS
1838         https://bugs.webkit.org/show_bug.cgi?id=195008
1839         <rdar://problem/47454419>
1840
1841         Reviewed by Dean Jackson.
1842
1843         * DumpRenderTree/mac/DumpRenderTree.mm:
1844         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1845         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1846
1847 2019-02-26  Mark Lam  <mark.lam@apple.com>
1848
1849         Remove remaining poisoning code.
1850         https://bugs.webkit.org/show_bug.cgi?id=194138
1851
1852         Reviewed by Saam Barati.
1853
1854         * TestWebKitAPI/CMakeLists.txt:
1855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1856         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1857         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1858         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1859         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1860         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1861         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1862
1863 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1864
1865         Move ephemeral local storage from WebProcess to UIProcess
1866         https://bugs.webkit.org/show_bug.cgi?id=195074
1867         <rdar://problem/47937975>
1868
1869         Reviewed by Geoff Garen.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1872
1873 2019-02-20  Jer Noble  <jer.noble@apple.com>
1874
1875         [Cocoa] Media elements will restart network buffering just before suspending
1876         https://bugs.webkit.org/show_bug.cgi?id=193691
1877
1878         Reviewed by Eric Carlson.
1879
1880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1882         (TEST):
1883
1884 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1885
1886         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1887         https://bugs.webkit.org/show_bug.cgi?id=191652
1888
1889         Reviewed by Alex Christensen.
1890
1891         Fix WinCairo MiniBrowser behavior of authentication dialog.
1892
1893         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1894         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1895
1896 2019-02-26  Youenn Fablet  <youenn@apple.com>
1897
1898         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1899         https://bugs.webkit.org/show_bug.cgi?id=195028
1900         <rdar://problem/48243733>
1901
1902         Reviewed by Eric Carlson.
1903
1904         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1905
1906 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1907
1908         [WPE] Add API for webview background color configuration
1909         https://bugs.webkit.org/show_bug.cgi?id=192305
1910
1911         Reviewed by Michael Catanzaro.
1912
1913         * MiniBrowser/wpe/main.cpp:
1914         (main): Add a new option to configure the webview background
1915         color. Example: --bg-color=transparent.
1916         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1917         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1918         (beforeAll): Ditto.
1919
1920 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1921
1922         scalableNativeWebpageParameters() is not preserved on new page navigation.
1923         https://bugs.webkit.org/show_bug.cgi?id=194892
1924         <rdar://problem/47538280>
1925
1926         Reviewed by Wenson Hsieh.
1927         
1928         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1929
1930         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1931         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1932         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1933         (WTR::UIScriptController::allowsViewportShrinkToFit):
1934         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1935         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1936         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1937         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1938         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1939         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1940
1941 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1942
1943         [ews-app] Add model for handling multiple Buildbot instances
1944         https://bugs.webkit.org/show_bug.cgi?id=194863
1945
1946         Reviewed by Stephanie Lewis.
1947
1948         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1949
1950 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1951
1952         [ews-app] Remove BuilderMapping table
1953         https://bugs.webkit.org/show_bug.cgi?id=194961
1954
1955         Reviewed by Stephanie Lewis.
1956
1957         Store builder name directly in build table, instead of having a separate
1958         table for it.
1959
1960         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1961         * BuildSlaveSupport/ews-app/ews/models/build.py:
1962         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1963         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1964
1965 2019-02-25  John Wilander  <wilander@apple.com>
1966
1967         Introduce and adopt new class RegistrableDomain for eTLD+1
1968         https://bugs.webkit.org/show_bug.cgi?id=194791
1969         <rdar://problem/48179240>
1970
1971         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1972
1973         This patch adds an API test and replaces two instances of
1974         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1975
1976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1977         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1978         (TestWebKitAPI::TEST):
1979             Changed two strings to make sure the registrable domains are still considered
1980             invalid and pass the test.
1981         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1982         (TestWebKitAPI::TEST):
1983         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1984         (WTR::InjectedBundle::didReceiveMessageToPage):
1985
1986 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1987
1988         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1989         https://bugs.webkit.org/show_bug.cgi?id=195001
1990
1991         Reviewed by Carlos Garcia Campos.
1992
1993         API version 1.0 always includes the functionality previously guarded with
1994         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1995         unconditionally.
1996
1997         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1998         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1999         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2000         (WebViewTest::showInWindow): Ditto.
2001         (WebViewTest::hideView): Ditto.
2002         * wpe/backends/HeadlessViewBackend.cpp:
2003         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2004         * wpe/backends/ViewBackend.cpp:
2005         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2006         * wpe/backends/WindowViewBackend.cpp:
2007         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2008         WPE_BACKEND_CHECK_VERSION().
2009         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2010
2011 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2012
2013         [Flatpak] Add support for flatpak > 1.1.2
2014         https://bugs.webkit.org/show_bug.cgi?id=194088
2015
2016         Flatpak 1.2 is now out so we need to support that
2017         version now.
2018
2019         Reviewed by Michael Catanzaro.
2020
2021         * flatpak/flatpakutils.py:
2022         (check_flatpak):
2023         (FlatpakPackages.__init__):
2024         (FlatpakPackages.__detect_packages):
2025         (FlatpakPackages.__detect_packages.in):
2026         (FlatpakRepos.update):
2027
2028 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2029
2030         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2031         https://bugs.webkit.org/show_bug.cgi?id=194998
2032
2033         Reviewed by Carlos Garcia Campos.
2034
2035         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2036         to a Git checkout and using the latest commit containing various fixes
2037         and improvements.
2038
2039 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2040
2041         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2042         https://bugs.webkit.org/show_bug.cgi?id=194981
2043
2044         Reviewed by Žan Doberšek.
2045
2046         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2047         (TestWebKitAPI::TEST):
2048
2049 2019-02-23  Keith Miller  <keith_miller@apple.com>
2050
2051         Add new mac target numbers
2052         https://bugs.webkit.org/show_bug.cgi?id=194955
2053
2054         Reviewed by Tim Horton.
2055
2056         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2057         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2058         * MiniBrowser/Configurations/Base.xcconfig:
2059         * TestWebKitAPI/Configurations/Base.xcconfig:
2060         * WebKitTestRunner/Configurations/Base.xcconfig:
2061
2062 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2063
2064         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2065         https://bugs.webkit.org/show_bug.cgi?id=194846
2066
2067         Reviewed by Don Olmstead.
2068
2069         Added _search_paths() and _port_specific_expectations_files() for
2070         WinCairoPort.
2071
2072         * Scripts/webkitpy/port/win.py:
2073         (WinCairoPort.default_baseline_search_path):
2074         (WinCairoPort):
2075         (WinCairoPort._port_specific_expectations_files):
2076         (WinCairoPort._search_paths):
2077
2078 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2079
2080         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2081         https://bugs.webkit.org/show_bug.cgi?id=194963
2082
2083         Reviewed by Dean Jackson.
2084
2085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2086         Do a `contains` check instead of `equals`, because in debug builds we
2087         put the GraphicsLayer pointer in a prefix.
2088
2089 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2090
2091         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2092         https://bugs.webkit.org/show_bug.cgi?id=194873
2093         <rdar://problem/46701974>
2094
2095         Reviewed by Tim Horton.
2096
2097         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2098
2099         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2100         (WTR::UIScriptController::menuRect const):
2101         (WTR::UIScriptController::isShowingMenu const):
2102         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2103         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2104         (WTR::UIScriptController::menuRect const):
2105
2106         Add a function to query the bounds of the callout menu in content coordinates.
2107
2108         (WTR::UIScriptController::isShowingMenu const):
2109
2110         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2111
2112         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2113         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2114         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2115         (WTR::UIScriptController::rectForMenuAction const):
2116         (WTR::UIScriptController::menuRect const):
2117         (WTR::UIScriptController::isShowingMenu const):
2118         (WTR::findViewInHierarchyOfType): Deleted.
2119
2120 2019-02-22  Chris Dumez  <cdumez@apple.com>
2121
2122         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2123         https://bugs.webkit.org/show_bug.cgi?id=194954
2124         <rdar://problem/48127957>
2125
2126         Reviewed by Alex Christensen.
2127
2128         Add API test coverage.
2129
2130         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2131         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2132         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2133         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2134
2135 2019-02-22  Chris Dumez  <cdumez@apple.com>
2136
2137         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2138         https://bugs.webkit.org/show_bug.cgi?id=194924
2139         <rdar://problem/48216125>
2140
2141         Reviewed by Geoffrey Garen.
2142
2143         Add API test coverage.
2144
2145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2146
2147 2019-02-22  Chris Dumez  <cdumez@apple.com>
2148
2149         Unreviewed, disable API test added in r241928 on iOS.
2150
2151         The cache is not enabled on devices with less than 3GB of RAM.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2154
2155 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2156
2157         Hardcode Visual Viewports on everywhere except iOS WK1
2158         https://bugs.webkit.org/show_bug.cgi?id=194928
2159
2160         Reviewed by Zalan Bujtas.
2161
2162         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2163         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2164         set it to false. The setting has shipped for several years and there's no need to turn
2165         it off now.
2166
2167         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2168         Visual Viewports are not enabled.
2169         
2170         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2171         that only runs in WK2
2172
2173         * MiniBrowser/mac/SettingsController.h:
2174         * MiniBrowser/mac/SettingsController.m:
2175         (-[SettingsController init]):
2176         (-[SettingsController _populateMenu]):
2177         (-[SettingsController validateMenuItem:]):
2178         (-[SettingsController visualViewportEnabled]): Deleted.
2179         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2180         * MiniBrowser/mac/WK1BrowserWindowController.m:
2181         (-[WK1BrowserWindowController didChangeSettings]):
2182         * MiniBrowser/mac/WK2BrowserWindowController.m:
2183         (-[WK2BrowserWindowController didChangeSettings]):
2184
2185 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2186
2187         Discard cached processes when clearing website data store
2188         https://bugs.webkit.org/show_bug.cgi?id=194894
2189
2190         Reviewed by Chris Dumez.
2191
2192         Added a test case.
2193
2194         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2195         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2196
2197 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2198
2199         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2200         https://bugs.webkit.org/show_bug.cgi?id=194914
2201         <rdar://problem/47586889>
2202
2203         Reviewed by Geoffrey Garen.
2204
2205         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2206         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2207         (TEST):
2208         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2209
2210 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2211
2212         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2213         <https://webkit.org/b/194761>
2214
2215         Reviewed by Myles Maxfield.
2216
2217         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2218         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2219         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2220         to use ARC-compliant cast.
2221         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2222         ARC-compliant cast.
2223         (WTR::installFakeHelvetica): Log `error` to console if
2224         CTFontManagerRegisterFontsForURL() fails, but only on supported
2225         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2226         Call CFRelease() on `error` to fix the leak.  Update to use
2227         ARC-compliant cast.
2228         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2229         cast.
2230
2231 2019-02-21  Chris Dumez  <cdumez@apple.com>
2232
2233         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2234         https://bugs.webkit.org/show_bug.cgi?id=194481
2235
2236         Reviewed by Alex Christensen.
2237
2238         Give the processes a chance to shutdown and wait until we reached the expected number
2239         of processes.
2240
2241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2242
2243 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2244
2245         Fix the macOS build
2246
2247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2248
2249 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2250
2251         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2252
2253         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2254         I am a backwards.
2255
2256 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2257
2258         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2259
2260         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2261         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2262         We could force on UI-side compositing, but I feel like the test might be more
2263         valuable exercising the normal path on each platform (though the original
2264         bug was also UI-side specific). Though we can't validate that the overlay
2265         layer was installed successfully, there are layout tests that do that.
2266
2267 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2268
2269         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2270         https://bugs.webkit.org/show_bug.cgi?id=194845
2271         <rdar://problem/47944579>
2272
2273         Reviewed by Antti Koivisto.
2274
2275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2276         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2277
2278 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2279
2280         [LFC][Floats] Add support for placing formatting roots in-between floats.
2281         https://bugs.webkit.org/show_bug.cgi?id=194902
2282
2283         Reviewed by Antti Koivisto.
2284
2285         * LayoutReloaded/misc/LFC-passing-tests.txt:
2286
2287 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2288
2289         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2290         https://bugs.webkit.org/show_bug.cgi?id=194901
2291
2292         Unreviewed build fix.
2293
2294         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2295         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2296         WPEBackend-fdo-0.1 as library name.
2297
2298 2019-02-21  Rob Buis  <rbuis@igalia.com>
2299
2300         Update MIME type parser
2301         https://bugs.webkit.org/show_bug.cgi?id=180526
2302
2303         Reviewed by Darin Adler.
2304
2305         Add tests involving leading and trailing whitespace, non-token
2306         characters and quoted strings.
2307
2308         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2309         (TestWebKitAPI::TEST):
2310
2311 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2312
2313         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2314         https://bugs.webkit.org/show_bug.cgi?id=194884
2315
2316         Reviewed by Michael Catanzaro.
2317
2318         * PlatformWin.cmake:
2319
2320 2019-02-20  Chris Dumez  <cdumez@apple.com>
2321
2322         Add API test for <rdar://problem/47471222>
2323         https://bugs.webkit.org/show_bug.cgi?id=194847
2324
2325         Reviewed by Alex Christensen.
2326
2327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2328
2329 2019-02-20  Chris Dumez  <cdumez@apple.com>
2330
2331         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2332         https://bugs.webkit.org/show_bug.cgi?id=194872
2333         <rdar://problem/47924500>
2334
2335         Reviewed by Alex Christensen.
2336
2337         Add API test coverage.
2338
2339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2340
2341 2019-02-20  Jer Noble  <jer.noble@apple.com>
2342
2343         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2344         https://bugs.webkit.org/show_bug.cgi?id=191332
2345
2346         Reviewed by Dean Jackson.
2347
2348         * Scripts/git-is-in-range: Added.
2349
2350 2019-02-20  Andy Estes  <aestes@apple.com>
2351
2352         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2353         https://bugs.webkit.org/show_bug.cgi?id=194869
2354
2355         Rubber-stamped by Jer Noble.
2356
2357         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2358         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2359         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2360         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2362         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2363
2364 2019-02-20  Chris Dumez  <cdumez@apple.com>
2365
2366         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2367         https://bugs.webkit.org/show_bug.cgi?id=194857
2368         <rdar://problem/47759323>
2369
2370         Reviewed by Alex Christensen.
2371
2372         Add API test coverage.
2373
2374         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2375
2376 2019-02-20  Chris Dumez  <cdumez@apple.com>
2377
2378         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
2379         https://bugs.webkit.org/show_bug.cgi?id=194829
2380         <rdar://problem/47889906>
2381
2382         Reviewed by Alexey Proskuryakov.
2383
2384         Every time the TestOptions were changing we were creating both a new Web view and
2385         a new WKContext, which would start a new Network process. In most cases, we only
2386         need to contruct a new Web view and we do can keep reusing the same WKContext.
2387         This patch implements this optimization and thus avoids spinning a lot of new
2388         Network processes while running the layout tests.
2389
2390         * WebKitTestRunner/TestController.cpp:
2391         (WTR::TestController::generateContextConfiguration const):
2392         (WTR::TestController::generatePageConfiguration):
2393         (WTR::TestController::createWebViewWithOptions):
2394         (WTR::TestController::resetPreferencesToConsistentValues):
2395         (WTR::updateTestOptionsFromTestHeader):
2396         * WebKitTestRunner/TestController.h:
2397         * WebKitTestRunner/TestOptions.h:
2398         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
2399         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
2400         (WTR::TestOptions::hasSameInitializationOptions const):
2401         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
2402         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2403         (WTR::TestController::platformAddTestOptions const):
2404
2405 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2406
2407         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
2408         https://bugs.webkit.org/show_bug.cgi?id=167941
2409
2410         Reviewed by Carlos Garcia Campos.
2411
2412         * MiniBrowser/gtk/main.c:
2413         (filterSavedCallback): Added.
2414         (main): Support loading a JSON rule set file for content filtering.
2415         * MiniBrowser/wpe/main.cpp:
2416         (filterSavedCallback): Added.
2417         (main): Support loading a JSON rule set file for content filtering.
2418         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
2419         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
2420         (WTF::derefGPtr): Ditto.
2421         (testEmptyStore):
2422         (testSaveInvalidFilter):
2423         (testSaveLoadFilter):
2424         (testSavedFilterIdentifierMatch):
2425         (testRemoveFilter):
2426         (testSaveMultipleFilters):
2427         (testSaveFilterFromFile):
2428         (testFilterPersistence):
2429         (beforeAll):
2430         (afterAll):
2431         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2432         (removeOldInjectedContentAndResetLists): Also reset content filters.
2433         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
2434         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
2435         the element affected by the style sheet.
2436         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
2437         and returns it to be used by tests.
2438         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
2439         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
2440         (serverCallback): Add support for serving a CSS style sheet for testing.
2441         (beforeAll): Add call to testUserContentManagerContentFilter().
2442         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
2443
2444 2019-02-19  Keith Rollin  <krollin@apple.com>
2445
2446         Add timing information to build output
2447         https://bugs.webkit.org/show_bug.cgi?id=194839
2448         <rdar://problem/48219609>
2449
2450         Reviewed by Alexey Proskuryakov.
2451
2452         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
2453         emit each project's build time to its output. E.g.,
2454
2455             ** BUILD SUCCEEDED ** [0.132 sec]
2456
2457         * Scripts/webkitdirs.pm:
2458         (XcodeOptions):
2459
2460 2019-02-19  Truitt Savell  <tsavell@apple.com>
2461
2462         Unreviewed, rolling out r241784.
2463
2464         Broke all OpenSource builds.
2465
2466         Reverted changeset:
2467
2468         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
2469         instances view"
2470         https://bugs.webkit.org/show_bug.cgi?id=172848
2471         https://trac.webkit.org/changeset/241784
2472
2473 2019-02-19  Zalan Bujtas  <zalan@apple.com>
2474
2475         [LFC][Floats] Remove redundant intersecting logic
2476         https://bugs.webkit.org/show_bug.cgi?id=194804
2477
2478         Reviewed by Antti Koivisto.
2479
2480         * LayoutReloaded/misc/LFC-passing-tests.txt:
2481
2482 2019-02-19  Dean Jackson  <dino@apple.com>
2483
2484         Clean-up output from generate-xcfilelists so it can be filtered
2485         https://bugs.webkit.org/show_bug.cgi?id=194795
2486
2487         Reviewed by Joseph Pecoraro (and Keith Rollin).
2488
2489         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
2490         make a slight tweak to filter-build-webkit so such lines are marked
2491         as plain.
2492
2493         * Scripts/filter-build-webkit:
2494         * Scripts/generate-xcfilelists:
2495
2496 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
2497
2498         pytest is not correctly auto-installed
2499         https://bugs.webkit.org/show_bug.cgi?id=194707
2500
2501         Reviewed by Carlos Garcia Campos.
2502
2503         * Scripts/webkitpy/thirdparty/__init__.py:
2504         (AutoinstallImportHook._install_pytest):
2505
2506 2019-02-18  Chris Dumez  <cdumez@apple.com>
2507
2508         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
2509         https://bugs.webkit.org/show_bug.cgi?id=194797
2510         <rdar://problem/48055151>
2511
2512         Reviewed by Geoffrey Garen.
2513
2514         Add API test coverage.
2515
2516         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2517
2518 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2519
2520         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
2521         https://bugs.webkit.org/show_bug.cgi?id=194670
2522         <rdar://problem/39066529>
2523
2524         Reviewed by Tim Horton.
2525
2526         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
2527         pasted in an editable area as attachment elements.
2528
2529         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2530         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2531         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
2532         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2533         (TestWebKitAPI::TEST):
2534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2535         (WTR::InjectedBundlePage::InjectedBundlePage):
2536
2537 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2538
2539         Fix API test after r241728
2540        ​https://bugs.webkit.org/show_bug.cgi?id=194723
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2543         (TEST):
2544         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
2545
2546 2019-02-18  Daniel Bates  <dabates@apple.com>
2547
2548         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2549         https://bugs.webkit.org/show_bug.cgi?id=192824
2550         <rdar://problem/47100332>
2551
2552         Reviewed by Wenson Hsieh.
2553
2554         Fix a bug where the wrong usage code was used for F13 thru F24.
2555
2556         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2557         (keyCodeForDOMFunctionKey):
2558
2559 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
2560
2561         Bytecode cache should a have a boot-specific validation
2562         https://bugs.webkit.org/show_bug.cgi?id=194769
2563         <rdar://problem/48149509>
2564
2565         Reviewed by Keith Miller.
2566
2567         Add test for WTF::bootSessionUUIDString()
2568
2569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2570         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
2571         (TEST):
2572
2573 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2574
2575         Disable safe browsing in WKWebView and remove its WKPreferences API
2576         https://bugs.webkit.org/show_bug.cgi?id=194723
2577         <rdar://problem/48122993>
2578
2579         Reviewed by Geoffrey Garen.
2580
2581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2582         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2583         (TEST):
2584         (safeBrowsingView):
2585         Make tests use SPI instead of API.
2586
2587 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2588
2589         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
2590         https://bugs.webkit.org/show_bug.cgi?id=194586
2591
2592         Reviewed by Ross Kirsling.
2593
2594         * DumpRenderTree/win/DumpRenderTree.cpp:
2595         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
2596         * Scripts/webkitpy/port/driver.py:
2597         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
2598
2599 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2600
2601         Unreviewed, rolling out r241620.
2602
2603         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
2604         (Requested by ddkilzer on #webkit.)
2605
2606         Reverted changeset:
2607
2608         "[WTF] Add environment variable helpers"
2609         https://bugs.webkit.org/show_bug.cgi?id=192405
2610         https://trac.webkit.org/changeset/241620
2611
2612 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2613
2614         [LFC] RenderImage's default intrinsic size is 0.
2615         https://bugs.webkit.org/show_bug.cgi?id=194745
2616
2617         Reviewed by Antti Koivisto.
2618
2619         * LayoutReloaded/misc/LFC-passing-tests.txt:
2620
2621 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2622
2623         [LFC][BFC] Add support for block replaced intrinsic width.
2624         https://bugs.webkit.org/show_bug.cgi?id=194705
2625
2626         Reviewed by Simon Fraser.
2627
2628         * LayoutReloaded/misc/LFC-passing-tests.txt:
2629
2630 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2631
2632         [LFC] Apply min/max width constraints to preferred width computation
2633         https://bugs.webkit.org/show_bug.cgi?id=194739
2634
2635         Reviewed by Simon Fraser.
2636
2637         * LayoutReloaded/misc/LFC-passing-tests.txt:
2638
2639 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2640
2641         [WTF] Add environment variable helpers
2642         https://bugs.webkit.org/show_bug.cgi?id=192405
2643
2644         Reviewed by Michael Catanzaro.
2645
2646         * DumpRenderTree/mac/DumpRenderTree.mm:
2647         (libraryPathForDumpRenderTree):
2648         * DumpRenderTree/win/DumpRenderTree.cpp:
2649         (libraryPathForDumpRenderTree):
2650         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2651         (setUpIOSLayoutTestCommunication):
2652         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2653         (beforeAll):
2654         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2655         (main):
2656         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2657         (WebKitTestBus::run):
2658         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2659         (WTR::getOutputDir):
2660         (WTR::initializeFontConfigSetting):
2661         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2662         (WTR::InjectedBundle::platformInitialize):
2663         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2664         (WTR::topLevelPath):
2665         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2666         (WTR::topLevelPath):
2667         (WTR::getOutputDir):
2668         (WTR::activateFonts):
2669         * WebKitTestRunner/TestController.cpp:
2670         (WTR::TestController::libraryPathForTesting):
2671         (WTR::TestController::generateContextConfiguration const):
2672         (WTR::TestController::generatePageConfiguration):
2673         (WTR::TestController::decideDestinationWithSuggestedFilename):
2674         (WTR::TestController::platformAdjustContext):
2675         * WebKitTestRunner/TestController.h:
2676         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2677         (WTR::TestController::cocoaPlatformInitialize):
2678         (WTR::TestController::platformAdjustContext):
2679         * WebKitTestRunner/gtk/main.cpp:
2680         (main):
2681         * WebKitTestRunner/mac/TestControllerMac.mm:
2682         (WTR::TestController::configureContentExtensionForTest):
2683         * WebKitTestRunner/wpe/main.cpp:
2684         (main):
2685         Utilize WTF::Environment where possible.
2686
2687 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2688
2689         [iOS] WKWebView callout bar is missing Change Writing Direction item
2690         https://bugs.webkit.org/show_bug.cgi?id=190015
2691         <rdar://problem/44810366>
2692
2693         Reviewed by Tim Horton.
2694
2695         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2696         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2697
2698         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2699         (TestWebKitAPI::TEST):
2700
2701 2019-02-15  Chris Dumez  <cdumez@apple.com>
2702
2703         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2704         https://bugs.webkit.org/show_bug.cgi?id=194717
2705         <rdar://problem/47884404>
2706
2707         Reviewed by Brady Eidson.
2708
2709         Add API test coverage.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2712
2713 2019-02-15  Youenn Fablet  <youenn@apple.com>
2714
2715         Make navigator.mediaDevices SecureContext
2716         https://bugs.webkit.org/show_bug.cgi?id=194666
2717
2718         Reviewed by Eric Carlson.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2721         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2722         (TEST_F):
2723
2724 2019-02-15  Brian Burg  <bburg@apple.com>
2725
2726         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2727         https://bugs.webkit.org/show_bug.cgi?id=194411
2728         <rdar://problem/47787614>
2729
2730         Reviewed by Joseph Pecoraro.
2731
2732         Remove unnecessary soft linking macro usage.
2733
2734         * DumpRenderTree/mac/TestRunnerMac.mm:
2735         (TestRunner::inspectorTestStubURL):
2736         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2737         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2738         (WTR::TestRunner::inspectorTestStubURL):
2739
2740 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2741
2742         Unreviewed, rolling out r241559 and r241566.
2743         https://bugs.webkit.org/show_bug.cgi?id=194710
2744
2745         Causes layout test crashes under GuardMalloc (Requested by
2746         ryanhaddad on #webkit).
2747
2748         Reverted changesets:
2749
2750         "[WTF] Add environment variable helpers"
2751         https://bugs.webkit.org/show_bug.cgi?id=192405
2752         https://trac.webkit.org/changeset/241559
2753
2754         "Unreviewed build fix for WinCairo Debug after r241559."
2755         https://trac.webkit.org/changeset/241566
2756
2757 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2758
2759         [LFC] Out-of-flow box is never a float box
2760         https://bugs.webkit.org/show_bug.cgi?id=194704
2761
2762         Reviewed by Antti Koivisto.
2763
2764         * LayoutReloaded/misc/LFC-passing-tests.txt:
2765
2766 2019-02-10  Darin Adler  <darin@apple.com>
2767
2768         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2769         https://bugs.webkit.org/show_bug.cgi?id=194487
2770
2771         Reviewed by Daniel Bates.
2772
2773         * DumpRenderTree/win/DumpRenderTree.cpp:
2774         (applicationId): Use makeString instead of String::format.
2775         (main): Ditto.
2776         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2777         (TestWebKitAPI::Util::createURLForResource): Ditto.
2778         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2779         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2780
2781         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2782         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2783         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2784         (WTR::createStringWithAttributes): Use appendLiteral.
2785         (WTR::AccessibilityUIElement::helpText const): Ditto.
2786         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2787         directly instead of using String::format.
2788         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2789         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2790
2791 2019-02-15  Truitt Savell  <tsavell@apple.com>
2792
2793         Unreviewed, rolling out r241564.
2794
2795         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2796
2797         Reverted changeset:
2798
2799         "[Mac] WebInspectorUI.framework does not need to be soft-
2800         linked anymore"
2801         https://bugs.webkit.org/show_bug.cgi?id=194411
2802         https://trac.webkit.org/changeset/241564
2803
2804 2019-02-15  Saam barati  <sbarati@apple.com>
2805
2806         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2807         https://bugs.webkit.org/show_bug.cgi?id=194036
2808
2809         Reviewed by Yusuke Suzuki.
2810
2811         * Scripts/run-jsc-stress-tests:
2812
2813 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2814
2815         Fix the build.
2816
2817         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2818         (WTR::UIScriptController::drawSquareInEditableImage):
2819         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2820         (TestWebKitAPI::drawSquareInEditableImage):
2821
2822 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2823
2824         Fix the build.
2825
2826         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2827         (WTR::UIScriptController::drawSquareInEditableImage):
2828         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2829         (TestWebKitAPI::drawSquareInEditableImage):
2830
2831 2019-02-14  Brian Burg  <bburg@apple.com>
2832
2833         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2834         https://bugs.webkit.org/show_bug.cgi?id=194411
2835         <rdar://problem/47787614>
2836
2837         Reviewed by Joseph Pecoraro.
2838
2839         Remove unnecessary soft linking macro usage.
2840
2841         * DumpRenderTree/mac/TestRunnerMac.mm:
2842         (TestRunner::inspectorTestStubURL):
2843         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2844         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2845         (WTR::TestRunner::inspectorTestStubURL):
2846
2847 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2848
2849         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2850         https://bugs.webkit.org/show_bug.cgi?id=194599
2851
2852         Reviewed by Lucas Forschler.
2853
2854         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2855         (StatusBubble._build_bubble):
2856
2857 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2858
2859         [ews-app] Set Foreign Key in Django build model
2860         https://bugs.webkit.org/show_bug.cgi?id=194667
2861
2862         Reviewed by Lucas Forschler.
2863
2864         * BuildSlaveSupport/ews-app/ews/models/build.py:
2865         (Build):
2866
2867 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2868
2869         [WTF] Add environment variable helpers
2870         https://bugs.webkit.org/show_bug.cgi?id=192405
2871
2872         Reviewed by Michael Catanzaro.
2873
2874         * DumpRenderTree/mac/DumpRenderTree.mm:
2875         (libraryPathForDumpRenderTree):
2876         * DumpRenderTree/win/DumpRenderTree.cpp:
2877         (libraryPathForDumpRenderTree):
2878         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2879         (setUpIOSLayoutTestCommunication):
2880         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2881         (TestWebKitAPI::strip):
2882         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2883         (beforeAll):
2884         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2885         (main):
2886         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2887         (WebKitTestBus::run):
2888         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2889         (WTR::getOutputDir):
2890         (WTR::initializeFontConfigSetting):
2891         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2892         (WTR::InjectedBundle::platformInitialize):
2893         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2894         (WTR::topLevelPath):
2895         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2896         (WTR::topLevelPath):
2897         (WTR::getOutputDir):
2898         (WTR::activateFonts):
2899         * WebKitTestRunner/TestController.cpp:
2900         (WTR::TestController::libraryPathForTesting):
2901         (WTR::TestController::generateContextConfiguration const):
2902         (WTR::TestController::generatePageConfiguration):
2903         (WTR::TestController::decideDestinationWithSuggestedFilename):
2904         (WTR::TestController::platformAdjustContext):
2905         * WebKitTestRunner/TestController.h:
2906         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2907         (WTR::TestController::cocoaPlatformInitialize):
2908         (WTR::TestController::platformAdjustContext):
2909         * WebKitTestRunner/gtk/main.cpp:
2910         (main):
2911         * WebKitTestRunner/mac/TestControllerMac.mm:
2912         (WTR::TestController::configureContentExtensionForTest):
2913         * WebKitTestRunner/wpe/main.cpp:
2914         (main):
2915         Utilize WTF::Environment where possible.
2916
2917 2019-02-14  Chris Dumez  <cdumez@apple.com>
2918
2919         [PSON] Introduce a WebContent Process cache
2920         https://bugs.webkit.org/show_bug.cgi?id=194594
2921         <rdar://problem/46793397>
2922
2923         Reviewed by Geoff Garen.
2924
2925         Update API tests to turn on the WebContent Process cache.
2926
2927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2928
2929 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2930
2931         Unreviewed, build fix after r241480
2932
2933         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2934         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2935         (-[DragAndDropSimulator initWithWebView:]):
2936
2937 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2938
2939         AX: ARIA Reflection was disabled in error
2940         https://bugs.webkit.org/show_bug.cgi?id=194647
2941         <rdar://problem/48068336>
2942
2943         Reviewed by Ryosuke Niwa.
2944
2945         Remove test override now that this feature should be enabled by default.
2946
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::TestController::resetPreferencesToConsistentValues):
2949
2950 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2951
2952         Unreviewed, rolling out r241486.
2953         https://bugs.webkit.org/show_bug.cgi?id=194655
2954
2955         causing API failures in builds (Requested by ShawnRoberts on
2956         #webkit).
2957
2958         Reverted changeset:
2959
2960         "[Cocoa] Media elements will restart network buffering just
2961         before suspending"
2962         https://bugs.webkit.org/show_bug.cgi?id=193691
2963         https://trac.webkit.org/changeset/241486
2964
2965 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2966
2967         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2968         https://bugs.webkit.org/show_bug.cgi?id=194622
2969
2970         Reviewed by Antti Koivisto.
2971
2972         * LayoutReloaded/misc/LFC-passing-tests.txt:
2973
2974 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2975
2976         [LFC] Shrink-to-fit-width should be constrained by min/max width
2977         https://bugs.webkit.org/show_bug.cgi?id=194653
2978
2979         Reviewed by Antti Koivisto.
2980
2981         * LayoutReloaded/misc/LFC-passing-tests.txt:
2982
2983 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2984
2985         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2986         https://bugs.webkit.org/show_bug.cgi?id=194641
2987
2988         Reviewed by Geoffrey Garen.
2989
2990         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2991         so that the test would fail without this fix.
2992
2993         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2994         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2995
2996 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2997
2998         [ews-app] Change log level for a log statement
2999
3000         Unreviewed minor fix.
3001
3002         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3003         (Patch.save_patch):
3004
3005 2019-02-13  Jer Noble  <jer.noble@apple.com>
3006
3007         [Cocoa] Media elements will restart network buffering just before suspending
3008         https://bugs.webkit.org/show_bug.cgi?id=193691
3009
3010         Reviewed by Eric Carlson.
3011
3012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3013         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3014         (TEST):
3015
3016 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3017
3018         [ews-app] Fetch builder id to name mapping
3019         https://bugs.webkit.org/show_bug.cgi?id=194355
3020
3021         Reviewed by Lucas Forschler.
3022
3023         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3024         (Buildbot.get_builder_id_to_name_mapping):
3025         (Buildbot._get_display_name_from_builder_name):
3026
3027 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3028
3029         Further restricting webarchive loads
3030         https://bugs.webkit.org/show_bug.cgi?id=194567
3031         <rdar://problem/47610130>
3032
3033         Reviewed by Youenn Fablet.
3034
3035         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3036         navigations on drop.
3037
3038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3039         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3040         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3041         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3042         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3043         (TestWebKitAPI::TEST):
3044         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3045         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3046         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3047         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3048         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3049         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3050         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3051
3052 2019-02-13  John Wilander  <wilander@apple.com>
3053
3054         Store Ad Click Attribution requests in the network process
3055         https://bugs.webkit.org/show_bug.cgi?id=194510
3056         <rdar://problem/47650118>
3057
3058         Reviewed by Alex Christensen and Daniel Bates.
3059
3060         This patch adds two TestRunner functions:
3061         - dumpAdClickAttribution()
3062         - clearAdClickAttribution()
3063
3064         They call into the network process to dump and clear Ad Click
3065         Attribution state, respectively.
3066
3067         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3068         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3069         (WTR::TestRunner::dumpAdClickAttribution):
3070         (WTR::TestRunner::clearAdClickAttribution):
3071         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3072         * WebKitTestRunner/TestController.cpp:
3073         (WTR::TestController::resetStateToConsistentValues):
3074         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3075         (WTR::adClickAttributionStringResultCallback):
3076         (WTR::TestController::dumpAdClickAttribution):
3077         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3078         (WTR::adClickAttributionVoidCallback):
3079         (WTR::TestController::clearAdClickAttribution):
3080         * WebKitTestRunner/TestController.h:
3081         * WebKitTestRunner/TestInvocation.cpp:
3082         (WTR::TestInvocation::dumpResults):
3083         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3084         (WTR::TestInvocation::dumpAdClickAttribution):
3085         * WebKitTestRunner/TestInvocation.h:
3086
3087 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3088
3089         [ews-app] Generate status-bubble
3090         https://bugs.webkit.org/show_bug.cgi?id=194572
3091
3092         Reviewed by Lucas Forschler.
3093
3094         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3095         (StatusBubble._build_bubble):
3096         (StatusBubble._should_show_bubble_for):
3097         (StatusBubble._build_bubbles_for_patch):
3098
3099 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3100
3101         [ews-app] Add status bubble html template
3102         https://bugs.webkit.org/show_bug.cgi?id=194571
3103
3104         Reviewed by Lucas Forschler.
3105
3106         * BuildSlaveSupport/ews-app/ews/templates: Added.
3107         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3108
3109 2019-02-12  Chris Dumez  <cdumez@apple.com>
3110
3111         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3112         https://bugs.webkit.org/show_bug.cgi?id=194568
3113         <rdar://problem/47944490>
3114
3115         Reviewed by Ryosuke Niwa.
3116
3117         Add API test coverage.
3118
3119         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3120         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3121
3122 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3123
3124         webkitpy: Remove bug_dummy from parsed test expectations
3125         https://bugs.webkit.org/show_bug.cgi?id=194562
3126         <rdar://problem/47853999>
3127
3128         Reviewed by Lucas Forschler.
3129
3130         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3131         (TestExpectationParser):
3132         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3133         skipped tests.
3134         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3135
3136 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
3137
3138         [ews-app] Add method to fetch patch
3139         https://bugs.webkit.org/show_bug.cgi?id=194518
3140
3141         Reviewed by Lucas Forschler.
3142
3143         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3144         (Patch.get_patch):
3145
3146 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3147
3148         [LFC] Expand tests coverage (60 new tests -> 860)
3149
3150         Unreviewed test gardening (run-singly, --child-processes=1).
3151
3152         * LayoutReloaded/misc/LFC-passing-tests.txt:
3153
3154 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3155
3156         Allow pages to trigger programmatic paste from script on iOS
3157         https://bugs.webkit.org/show_bug.cgi?id=194271
3158         <rdar://problem/47808810>
3159
3160         Reviewed by Tim Horton.
3161
3162         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3163
3164         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3165         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3166         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3167         (WTR::UIScriptController::rectForMenuAction const):
3168
3169         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3170         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3171         for when the menu is shown or hidden.
3172
3173         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3174         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3175         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3176         (WTR::UIScriptController::setDidShowMenuCallback):
3177         (WTR::UIScriptController::didShowMenuCallback const):
3178         (WTR::UIScriptController::setDidHideMenuCallback):
3179         (WTR::UIScriptController::didHideMenuCallback const):
3180         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3181         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3182         (WTR::UIScriptController::rectForMenuAction const):
3183         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3184         * WebKitTestRunner/TestController.cpp:
3185         (WTR::TestController::resetPreferencesToConsistentValues):
3186         (WTR::updateTestOptionsFromTestHeader):
3187         * WebKitTestRunner/TestOptions.h:
3188
3189         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
3190         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
3191
3192         (WTR::TestOptions::hasSameInitializationOptions const):
3193         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3194         (WTR::UIScriptController::calendarType const):
3195         (WTR::UIScriptController::platformUndoManager const):
3196         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3197         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3198         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3199         (-[TestRunnerWKWebView dealloc]):
3200         (-[TestRunnerWKWebView _didShowMenu]):
3201         (-[TestRunnerWKWebView _didHideMenu]):
3202
3203         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
3204
3205         * WebKitTestRunner/ios/TestControllerIOS.mm:
3206         (WTR::handleMenuWillHideNotification):
3207         (WTR::handleMenuDidHideNotification):
3208         (WTR::TestController::platformInitialize):
3209         (WTR::TestController::platformDestroy):
3210         (WTR::TestController::platformResetStateToConsistentValues):
3211
3212         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
3213         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
3214
3215         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3216         (WTR::forEachViewInHierarchy):
3217         (WTR::findViewInHierarchyOfType):
3218
3219         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
3220         functions that dig through a given view's hierarchy in search of a view of a given class.
3221
3222         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3223         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3224         (WTR::UIScriptController::selectionCaretViewRect const):
3225         (WTR::UIScriptController::selectionRangeViewRects const):
3226         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3227         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3228
3229         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
3230
3231         (WTR::UIScriptController::rectForMenuAction const):
3232
3233         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
3234         callout bar) whose label matches the given string.
3235
3236         (WTR::UIScriptController::platformContentView const):
3237
3238         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
3239         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
3240         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
3241
3242         (WTR::UIScriptController::platformUndoManager const): Deleted.
3243         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3244         (WTR::UIScriptController::platformContentView const):
3245         (WTR::UIScriptController::platformUndoManager const): Deleted.
3246
3247 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3248
3249         webkitpy: No option to only show unexpected failures in results.html for iPad
3250         https://bugs.webkit.org/show_bug.cgi?id=194554
3251         <rdar://problem/47922442>
3252
3253         Rubber-stamped by Aakash Jain.
3254
3255         Just because a TestExpecations file does not exist for a specific platform does not mean that
3256         TestExpecations are not being used, given that platforms inherit test expectations.
3257
3258         * Scripts/webkitpy/port/base.py:
3259         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
3260         * Scripts/webkitpy/port/base_unittest.py:
3261         (PortTest.test_uses_test_expectations_file):
3262
3263 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3264
3265         Remove setDefersLoading infrastructure from WebKit2
3266         https://bugs.webkit.org/show_bug.cgi?id=194506
3267
3268         Reviewed by Brady Eidson.
3269
3270         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3271         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3272         (WTR::TestRunner::setDefersLoading): Deleted.
3273         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3274
3275 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3276
3277         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
3278         https://bugs.webkit.org/show_bug.cgi?id=194522
3279         <rdar://problem/47789393>
3280
3281         Reviewed by Chris Dumez.
3282
3283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3284         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
3285         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3287
3288 2019-02-12  Andy Estes  <aestes@apple.com>
3289
3290         [iOSMac] Enable Parental Controls Content Filtering
3291         https://bugs.webkit.org/show_bug.cgi?id=194521
3292         <rdar://39732376>
3293
3294         Reviewed by Tim Horton.
3295
3296         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3297
3298 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3299
3300         [LFC][IFC] Add intrinsic width support for float boxes.
3301         https://bugs.webkit.org/show_bug.cgi?id=194528
3302
3303         Reviewed by Antti Koivisto.
3304
3305         Expand tests coverage (2 new tests -> 800).
3306         (This is the correct test ordering --runs-singly --child-processes=1)
3307
3308         * LayoutReloaded/misc/LFC-passing-tests.txt:
3309
3310 2019-02-12  Rob Buis  <rbuis@igalia.com>
3311
3312         Implement serializing in MIME type parser
3313         https://bugs.webkit.org/show_bug.cgi?id=193909
3314
3315         Reviewed by Darin Adler.
3316
3317         Add various tests involving upper case, non-ASCII, control/null characters,
3318         various HTTP whitespace, single quotes and an unpaired surrogate.
3319
3320         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3321         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
3322         (TestWebKitAPI::serializeIfValid):
3323         (TestWebKitAPI::TEST):
3324
3325 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
3326
3327         [Cocoa] Ask platform for generic font family mappings
3328         https://bugs.webkit.org/show_bug.cgi?id=187723
3329         <rdar://problem/41892438>
3330
3331         Reviewed by Brent Fulgham.
3332
3333         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3334
3335         * DumpRenderTree/mac/DumpRenderTree.mm:
3336         (allowedFontFamilySet):
3337         * WebKitTestRunner/mac/TestControllerMac.mm:
3338         (WTR::allowedFontFamilySet):
3339
3340 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
3341
3342         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
3343         https://bugs.webkit.org/show_bug.cgi?id=193622
3344
3345         Reviewed by Michael Catanzaro.
3346
3347         This adds support for loading content extension rule sets from the JSON files which
3348         accompany the corresponding layout test, using the C API. The Cocoa specific parts
3349         of WKTR for this could be removed, but that is left for a follow-up patch with
3350         cleanups.
3351
3352         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
3353         * WebKitTestRunner/TestController.cpp:
3354         (WTR::testPath): Subtract one from the length when constructing the result std::string to
3355         avoid having the null-terminator copied into the result.
3356         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
3357         part of the preparations to run a test.
3358         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
3359         (WTR::contentExtensionStoreCallback): Added.
3360         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
3361         used for content extensions test.
3362         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
3363         extensions and compiling the JSON rule set for tests involving content extensions.
3364         (WTR::TestController::resetContentExtensions): Removes the content extension built for
3365         testing and disables content extensions.
3366         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
3367         resetContentExtensions().
3368         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
3369         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
3370         configureContentExtensionForTest(), and userContentController().
3371
3372 2019-02-11  Daniel Bates  <dabates@apple.com>
3373
3374         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3375         https://bugs.webkit.org/show_bug.cgi?id=191446
3376         <rdar://problem/45929460>
3377
3378         Reviewed by Tim Horton.
3379
3380         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3381
3382         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3383         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3384         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3385         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3386         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3387         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3388         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3389         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3390         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3391         (WTR::arrayLength):
3392         (WTR::parseModifierArray):
3393         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3394         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3395         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3396         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3397
3398 2019-02-11  Commit Queue  <commit-queue@webkit.org>
3399
3400         Unreviewed, rolling out r241272 and r241276.
3401         https://bugs.webkit.org/show_bug.cgi?id=194514
3402
3403         Broke the Apple Internal build and the fix requires human
3404         intervention :( (Requested by dydz on #webkit).
3405
3406         Reverted changesets:
3407
3408         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
3409         https://bugs.webkit.org/show_bug.cgi?id=191446
3410         https://trac.webkit.org/changeset/241272
3411
3412         "Fix internal iOS build after r241272"
3413         https://bugs.webkit.org/show_bug.cgi?id=191446
3414         https://trac.webkit.org/changeset/241276
3415
3416 2019-02-11  Truitt Savell  <tsavell@apple.com>
3417
3418         Unreviewed, rolling out r241269.
3419
3420         Caused 5 layout tests crashes on Mac WK1
3421
3422         Reverted changeset:
3423
3424         "DumpRenderTree should report unknown options"
3425         https://bugs.webkit.org/show_bug.cgi?id=191303
3426         https://trac.webkit.org/changeset/241269
3427
3428 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3429
3430         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
3431         https://bugs.webkit.org/show_bug.cgi?id=194313
3432
3433         Reviewed by Tim Horton.
3434
3435         Add a helper to determine whether the web view is presenting modal UI.
3436
3437         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3438         (WTR::UIScriptController::isPresentingModally const):
3439         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3440         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3441         (WTR::UIScriptController::isPresentingModally const):
3442         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3443         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3444         (WTR::UIScriptController::calendarType const): Deleted.
3445         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3446         (WTR::UIScriptController::isPresentingModally const):
3447         (WTR::UIScriptController::calendarType const):
3448         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3449         (WTR::UIScriptController::calendarType const):
3450
3451 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
3452
3453         GCHeapInspector: Show the retained sizes in more places
3454         https://bugs.webkit.org/show_bug.cgi?id=194464
3455
3456         Reviewed by Simon Fraser.
3457
3458         * GCHeapInspector/gc-heap-inspector.html:
3459         * GCHeapInspector/script/interface.js:
3460         (HeapInspectorUtils.humanReadableSize):
3461         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
3462         (HeapInspectorUtils.spanForNode.span.span):
3463         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
3464         (HeapSnapshotInspector.prototype.buildRoots):
3465
3466 2019-02-11  Daniel Bates  <dabates@apple.com>
3467
3468         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3469         https://bugs.webkit.org/show_bug.cgi?id=191446
3470         <rdar://problem/45929460>
3471
3472         Reviewed by Tim Horton.
3473
3474         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3475
3476         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3477         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3478         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3479         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3480         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3481         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3482         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3483         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3484         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3485         (WTR::arrayLength):
3486         (WTR::parseModifierArray):
3487         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3488         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3489         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3490         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3491
3492 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
3493
3494         DumpRenderTree should report unknown options
3495         https://bugs.webkit.org/show_bug.cgi?id=191303
3496
3497         Reviewed by Frédéric Wang.
3498
3499         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
3500         to report unknown options.
3501         Added and assigned test options which are currently used in tests.
3502
3503         * DumpRenderTree/TestOptions.cpp:
3504         (TestOptions::TestOptions):
3505
3506 2019-02-11  Truitt Savell  <tsavell@apple.com>
3507
3508         Unreviewed, rolling out r241229.
3509
3510         Revision broke internal builds for watchOS.
3511
3512         Reverted changeset:
3513
3514         "[Cocoa] Ask platform for generic font family mappings"
3515         https://bugs.webkit.org/show_bug.cgi?id=187723
3516         https://trac.webkit.org/changeset/241229
3517
3518 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
3519
3520         [WinCairo][MiniBrowser] Basic authentication always fails.
3521         https://bugs.webkit.org/show_bug.cgi?id=194496
3522
3523         Reviewed by Don Olmstead.
3524
3525         * MiniBrowser/win/DialogHelper.h:
3526         (Dialog::getText):
3527
3528 2019-02-11  Philippe Normand  <pnormand@igalia.com>
3529
3530         [GStreamer] GstMappedBuffer testsuite build fails
3531         https://bugs.webkit.org/show_bug.cgi?id=194495
3532
3533         Reviewed by Carlos Garcia Campos.
3534
3535         Fix the build by explicitely adding the gstreamer1.0-audio include
3536         directories to the include path.
3537
3538         * TestWebKitAPI/PlatformGTK.cmake:
3539         * TestWebKitAPI/PlatformWPE.cmake:
3540
3541 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3542
3543         [GTK][WPE] Add enable-javascript-markup setting
3544         https://bugs.webkit.org/show_bug.cgi?id=193439
3545
3546         Reviewed by Michael Catanzaro.
3547
3548         Add test cases to check the new setting.
3549
3550         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3551         (testWebKitSettings):
3552         (testWebKitSettingsJavaScriptMarkup):
3553         (beforeAll):
3554
3555 2019-02-10  Darin Adler  <darin@apple.com>
3556
3557         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
3558         https://bugs.webkit.org/show_bug.cgi?id=194485
3559
3560         Reviewed by Daniel Bates.
3561
3562         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
3563
3564 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3565
3566         Add more tests for clampTo<>()
3567         https://bugs.webkit.org/show_bug.cgi?id=194462
3568
3569         Reviewed by Geoffrey Garen.
3570
3571         Darin suggested to test the very last floating point number
3572         at the boundaries when truncating to integer.
3573         I added test for max/min and max-1/min-1.
3574
3575         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3576         (TestWebKitAPI::TEST):
3577
3578 2019-02-09  Darin Adler  <darin@apple.com>
3579
3580         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
3581         https://bugs.webkit.org/show_bug.cgi?id=194021
3582
3583         Reviewed by Geoffrey Garen.
3584
3585         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3586         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
3587         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
3588
3589 2019-02-09  Zalan Bujtas  <zalan@apple.com>
3590
3591         [LFC][IFC] Add intrinsic width support for basic inline containers
3592         https://bugs.webkit.org/show_bug.cgi?id=194473
3593
3594         Reviewed by Antti Koivisto.
3595
3596         Expand tests coverage (11 new tests -> 798)
3597
3598         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
3599
3600 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3601
3602         Fix MiniBrowser's entitlements
3603         https://bugs.webkit.org/show_bug.cgi?id=192431
3604
3605         Reviewed by Joseph Pecoraro.
3606
3607         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
3608         files, making it impossible to load any extension.
3609
3610         * MiniBrowser/MiniBrowser.entitlements:
3611
3612 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
3613
3614         [Cocoa] Ask platform for generic font family mappings
3615         https://bugs.webkit.org/show_bug.cgi?id=187723
3616         <rdar://problem/41892438>
3617
3618         Reviewed by Brent Fulgham.
3619
3620         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3621
3622         * DumpRenderTree/mac/DumpRenderTree.mm:
3623         (allowedFontFamilySet):
3624         * WebKitTestRunner/mac/TestControllerMac.mm:
3625         (WTR::allowedFontFamilySet):
3626
3627 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
3628
3629         [GTK] Implement back/forward touchpad gesture
3630         https://bugs.webkit.org/show_bug.cgi?id=193919
3631
3632         Reviewed by Michael Catanzaro.
3633
3634         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3635         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
3636
3637 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3638
3639         Add SPI to use networking daemon instead of XPC service
3640         https://bugs.webkit.org/show_bug.cgi?id=194427
3641
3642         Reviewed by Geoffrey Garen
3643
3644         * MiniBrowser/MiniBrowser.entitlements:
3645
3646 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3647
3648         [ews-build] Ensure that every builder in config.json has short name
3649         https://bugs.webkit.org/show_bug.cgi?id=194461
3650
3651         Reviewed by Lucas Forschler.
3652
3653         * BuildSlaveSupport/ews-build/loadConfig.py:
3654         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3655
3656 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3657
3658         [ews-build] Add short name to config.json
3659         https://bugs.webkit.org/show_bug.cgi?id=194456
3660
3661         Reviewed by Lucas Forschler.
3662
3663         * BuildSlaveSupport/ews-build/config.json: Added short name.
3664         * BuildSlaveSupport/ews-build/loadConfig.py:
3665         (loadBuilderConfig): Set the short name as the builder description.
3666
3667 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3668
3669         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3670         https://bugs.webkit.org/show_bug.cgi?id=194418
3671
3672         Reviewed by Lucas Forschler.
3673
3674         Do not include errors trying when finding crashlogs at the end of
3675         a run-webkit-tests run since we don't process those errors.
3676
3677         * Scripts/webkitpy/port/darwin.py:
3678         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3679         * Scripts/webkitpy/port/ios_device.py:
3680         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3681         * Scripts/webkitpy/port/watch_device.py:
3682         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3683
3684 2019-02-08  Beth Dakin  <bdakin@apple.com>
3685
3686         Add afterScreenUpdates to WKSnapshotConfiguration
3687         https://bugs.webkit.org/show_bug.cgi?id=194362
3688         -and corresponding-
3689         <rdar://problem/40655528> Please add an "after screen updates" property to 
3690         WKSnapshotConfiguration (to solve blank snapshots)
3691
3692         Reviewed by Tim Horton.
3693
3694         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3695         (TEST):
3696
3697 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3698
3699         clampTo(): do not convert the input to double when dealing with integers
3700         https://bugs.webkit.org/show_bug.cgi?id=194263
3701         <rdar://problem/47692312>
3702
3703         Reviewed by Darin Adler.
3704
3705         * TestWebKitAPI/Tests/WTF/MathExtras.cp